RFR: 8214205: PPC64: Add instructions for counting trailing zeros

[Gustavo Romero]

Hi Michi,

On 11/22/2018 09:37 AM, Michihiro Horie wrote:
> Gustavo,
> Could you review this change with testing and also push it when it's good?

v2 looks perfect, thanks.

Reviewed and pushed.


Best regards,
Gustavo

> 
> Best regards,
> --
> Michihiro,
> IBM Research - Tokyo
> 
> Inactive hide details for "Doerr, Martin" ---2018/11/22 19:21:52---Hi Michihiro, this change needs to get reviewed on hotspot-c"Doerr, Martin" ---2018/11/22 19:21:52---Hi Michihiro, this change needs to get reviewed on hotspot-compiler-dev (added).
> 
> From: "Doerr, Martin" <martin.doerr at sap.com>
> To: Michihiro Horie <HORIE at jp.ibm.com>, "ppc-aix-port-dev at openjdk.java.net" <ppc-aix-port-dev at openjdk.java.net>, "'hotspot-compiler-dev at openjdk.java.net'" <hotspot-compiler-dev at openjdk.java.net>
> Cc: Gustavo Romero <gromero at linux.vnet.ibm.com>
> Date: 2018/11/22 19:21
> Subject: RE: RFR: 8214205: PPC64: Add instructions for counting trailing zeros
> 
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> 
> 
> 
> Hi Michihiro,
> 
> this change needs to get reviewed on hotspot-compiler-dev (added).
> Also added missing „RFR“.
> 
> The change looks good. I only have very minor requests:
> “_Ex” should be removed from the new instruct names. They aren’t expand rules.
> Please also update the copyright year in the header of the ad file.
> 
> Maybe Gustavo can test it, write a 2^nd review and push it when it’s good.
> 
> Best regards,
> Martin
> 
> 
> *From:* Michihiro Horie <HORIE at jp.ibm.com> *
> Sent:* Donnerstag, 22. November 2018 06:40*
> To:* ppc-aix-port-dev at openjdk.java.net*
> Cc:* Gustavo Romero <gromero at linux.vnet.ibm.com>; Doerr, Martin <martin.doerr at sap.com>*
> Subject:* RFR: 8214205: PPC64: Add instructions for counting trailing zeros
> 
> Dear all,
> 
> Would you please review the following change that enables POWER9’s instructions for counting trailing zeros?
> 
> Bug: _https://bugs.openjdk.java.net/browse/JDK-8214205_
> Webrev: _http://cr.openjdk.java.net/~mhorie/8214205/webrev.00/_ <http://cr.openjdk.java.net/%7Emhorie/8214205/webrev.00/>
> 
> Simple micro benchmark attached showed improvements by around 30%./
> (See attached file: CNTTZTest.java)/
> 
> Currently, Gustavo at IBM can test POWER9 specific changes. (Thanks Gustavo!)
> 
> 
> Best regards,
> --
> Michihiro,
> IBM Research - Tokyo
> 
>