Definition of CRC32 helper generate_load_table_addr() is absent

Gustavo Romero gromero at linux.vnet.ibm.com
Wed Nov 28 12:06:51 UTC 2018


Hello Lutz,

It looks like that generate_load_table_addr() prototype in CRC32 code is not
defined anywhere, so I'm wondering if it's a leftover and must be removed.

Should I contribute with a trivial fix like the following?

diff -r 263c7685a22a src/hotspot/cpu/ppc/stubRoutines_ppc.hpp
--- a/src/hotspot/cpu/ppc/stubRoutines_ppc.hpp  Wed Nov 28 13:24:56 2018 +0300
+++ b/src/hotspot/cpu/ppc/stubRoutines_ppc.hpp  Wed Nov 28 06:54:52 2018 -0500
@@ -62,7 +62,6 @@
   public:
  
    // CRC32 Intrinsics.
-  static void generate_load_table_addr(MacroAssembler* masm, Register table, address table_addr, uint64_t table_contents);
    static void generate_load_crc_table_addr(MacroAssembler* masm, Register table);
    static void generate_load_crc_constants_addr(MacroAssembler* masm, Register table);
    static void generate_load_crc_barret_constants_addr(MacroAssembler* masm, Register table);


Best regards,
Gustavo



More information about the ppc-aix-port-dev mailing list