Definition of CRC32 helper generate_load_table_addr() is absent

[Gustavo Romero]

Hi Martin!

On 11/28/2018 11:21 AM, Doerr, Martin wrote:
> it's fine to remove it. I think there are more unused leftovers. E.g. kernel_crc32_2word is not used at all.

hmm I missed that one. It looks like it's also present and unused on s390 code.
Should I place a RFR to cleanup generate_load_table_addr + kernel_crc32_2word (PPC64 and s390)?
I won't be able to test the s390 builds...


Best regards,
Gustavo
> Best regards,
> Martin
> 
> 
> -----Original Message-----
> From: Gustavo Romero <gromero at linux.vnet.ibm.com>
> Sent: Mittwoch, 28. November 2018 14:14
> To: Schmidt, Lutz <lutz.schmidt at sap.com>
> Cc: ppc-aix-port-dev at openjdk.java.net; Doerr, Martin <martin.doerr at sap.com>
> Subject: Re: Definition of CRC32 helper generate_load_table_addr() is absent
> 
> Hi Lutz,
> 
> On 11/28/2018 11:04 AM, Schmidt, Lutz wrote:
>> I support your assumption: this declaration is just a leftover from times long gone. It can be deleted without harm to anything. So please go ahead with the cleanup.
>>
>> I put Martin on CC:, just to let him know.
> 
> OK. I'll send a RFR CC:ing you and Martin.
> 
> Thanks!
> 
> Best regards,
> Gustavo
> 
>> Regards,
>> Lutz
>>
>>
>> On 28.11.18, 13:07, "Gustavo Romero" <gromero at linux.vnet.ibm.com> wrote:
>>
>>       Hello Lutz,
>>       
>>       It looks like that generate_load_table_addr() prototype in CRC32 code is not
>>       defined anywhere, so I'm wondering if it's a leftover and must be removed.
>>       
>>       Should I contribute with a trivial fix like the following?
>>       
>>       diff -r 263c7685a22a src/hotspot/cpu/ppc/stubRoutines_ppc.hpp
>>       --- a/src/hotspot/cpu/ppc/stubRoutines_ppc.hpp  Wed Nov 28 13:24:56 2018 +0300
>>       +++ b/src/hotspot/cpu/ppc/stubRoutines_ppc.hpp  Wed Nov 28 06:54:52 2018 -0500
>>       @@ -62,7 +62,6 @@
>>          public:
>>         
>>           // CRC32 Intrinsics.
>>       -  static void generate_load_table_addr(MacroAssembler* masm, Register table, address table_addr, uint64_t table_contents);
>>           static void generate_load_crc_table_addr(MacroAssembler* masm, Register table);
>>           static void generate_load_crc_constants_addr(MacroAssembler* masm, Register table);
>>           static void generate_load_crc_barret_constants_addr(MacroAssembler* masm, Register table);
>>       
>>       
>>       Best regards,
>>       Gustavo
>>       
>>       
>>
>