RFR: 8221915: cleanup ticks related coding in os_perf_aix.cpp [aix]

[Baesken, Matthias]

> E.g. get_systemtype, get_jvm_ticks, etc. contain linux stuff.

Hi Martin, true  the functions you mentioned can be removed/reduced as well :

http://cr.openjdk.java.net/~mbaesken/webrevs/8221915.1/



Best regards, Matthias


> -----Original Message-----
> From: Doerr, Martin
> Sent: Dienstag, 9. April 2019 12:23
> To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>; ppc-aix-port-
> dev at openjdk.java.net
> Cc: Simonis, Volker <volker.simonis at sap.com>
> Subject: RE: RFR: 8221915: cleanup ticks related coding in os_perf_aix.cpp
> [aix]
> 
> Hi Matthias,
> 
> the purpose of this file is only to satisfy the build. JFR is not supported on
> AIX.
> I guess almost nothing of this file works. There are more things which could
> get removed.
> E.g. get_systemtype, get_jvm_ticks, etc. contain linux stuff.
> 
> Best regards,
> Martin
> 
> 
> -----Original Message-----
> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of
> Baesken, Matthias
> Sent: Dienstag, 9. April 2019 09:40
> To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>; ppc-
> aix-port-dev at openjdk.java.net
> Cc: Simonis, Volker <volker.simonis at sap.com>
> Subject: RFR: 8221915: cleanup ticks related coding in os_perf_aix.cpp [aix]
> 
> Hello, please review this small AIX related cleanup change .
> 
> When recently looking into the  os_perf coding ,  I noticed  that we try to
> read   (on AIX)   cpu ticks related data from /proc/stat .
> However this will most likely fail, on the AIX machines  I checked  there is a
> /proc  but  no  /proc/stat  .
> 
> (probably  the AIX coding has been taken over from linux)
> 
> The change cleans up  the coding  in  os_perf_aix.cpp  .
> 
> ( there might be other ways to get the CPU ticks related info on AIX  e.g. by
> using libperfstat or by using what  <sys/procfs.h>
> has to offer, see
> https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.
> aix.files/proc.htm    ,  but  this  should be  checked  and maybe  added
>   with another change in case someone is interested )
> 
> 
> 
> Bug/webrev :
> 
> https://bugs.openjdk.java.net/browse/JDK-8221915
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8221915.0/
> 
> 
> Thanks, Matthias