RFR: 8234794: AArch64: runtime/memory/ReadFromNoaccessArea.java crashes

Andrew Dinn adinn at redhat.com
Wed Dec 11 10:12:48 UTC 2019


Hi Nick,

On 11/12/2019 07:08, Nick Gasson wrote:
> Please help to review this patch to fix some issues uncovered by CDS
> archive relocation.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8234794
> Webrev: http://cr.openjdk.java.net/~ngasson/8234794/webrev.01/

  . . .

> Tested jtreg hotspot_all_no_apps, jdk_core on AArch64 and x86. Also did
> some manual testing with -XX:SharedBaseAddress and
> -XX:ArchiveRelocationMode=1 (thanks Ioi).
> 
> I'm not able to test on AIX which shares the same metaspace code (CC'd
> ppc-aix-port-dev).
Nice work. It looks good enough to me to push. However, first it would
only be right to have a review (and a sanity check test) from a ppc dev.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill



More information about the ppc-aix-port-dev mailing list