From OGATAK at jp.ibm.com Mon Jan 7 05:13:31 2019 From: OGATAK at jp.ibm.com (Kazunori Ogata) Date: Mon, 7 Jan 2019 14:13:31 +0900 Subject: [8u] RFR for backport of 8154156: PPC64: improve array copy stubs by using vector instructions In-Reply-To: References: Message-ID: Hi, Ping. Can anyone review this enhancement backport request? Regards, Ogata Kazunori Ogata/Japan/IBM wrote on 2018/12/18 23:41:16: > From: Kazunori Ogata/Japan/IBM > To: hotspot-compiler-dev at openjdk.java.net, ppc-aix-port-dev at openjdk.java.net > Date: 2018/12/18 23:41 > Subject: [8u] RFR for backport of 8154156: PPC64: improve array copy stubs > by using vector instructions > > Hi, > > May I get review for enhancement backport of 8154156: PPC64: improve array > copy stubs by using vector instructions? > > To make this patch buildable (and usable by other planned backports listed > in [1]), I cherry picked config_dscr() and its dependent code from [2,3] > and has_mfdscr() from [4]. > > Original patch: http://hg.openjdk.java.net/jdk/jdk/rev/c9d756fa846e > Weberv: http://cr.openjdk.java.net/~horii/jdk8u_aes_be/8154156/webrev.01/ > > I confirmed it was buildable for both relase and fastdebug builds, and > JTREG caused no degradation. > > Refs: > [1] http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2018-December/ > 003818.html > [2] 8149655: PPC64: Implement CompactString intrinsics > http://hg.openjdk.java.net/jdk/jdk/rev/6241574f5982 > [3] 8080684: PPC64: Fix little-endian build after "8077838: Recent > developments for ppc" > http://hg.openjdk.java.net/jdk/jdk/rev/12ccf8b26eb0 > [4] 8077838: Recent developments for ppc. > http://hg.openjdk.java.net/jdk/jdk/rev/c703c89fddbf > > Regards, > Ogata From martin.doerr at sap.com Mon Jan 7 13:08:57 2019 From: martin.doerr at sap.com (Doerr, Martin) Date: Mon, 7 Jan 2019 13:08:57 +0000 Subject: [8u] RFR for backport of 8154156: PPC64: improve array copy stubs by using vector instructions In-Reply-To: References: Message-ID: <6adf0a283eda47b29df02a3a2d8550ee@sap.com> Hi Ogata, looks good to me. However, I'm not a jdk8u reviewer. Best regards, Martin -----Original Message----- From: ppc-aix-port-dev On Behalf Of Kazunori Ogata Sent: Montag, 7. Januar 2019 06:14 To: hotspot-compiler-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net Subject: Re: [8u] RFR for backport of 8154156: PPC64: improve array copy stubs by using vector instructions Hi, Ping. Can anyone review this enhancement backport request? Regards, Ogata Kazunori Ogata/Japan/IBM wrote on 2018/12/18 23:41:16: > From: Kazunori Ogata/Japan/IBM > To: hotspot-compiler-dev at openjdk.java.net, ppc-aix-port-dev at openjdk.java.net > Date: 2018/12/18 23:41 > Subject: [8u] RFR for backport of 8154156: PPC64: improve array copy stubs > by using vector instructions > > Hi, > > May I get review for enhancement backport of 8154156: PPC64: improve array > copy stubs by using vector instructions? > > To make this patch buildable (and usable by other planned backports listed > in [1]), I cherry picked config_dscr() and its dependent code from [2,3] > and has_mfdscr() from [4]. > > Original patch: http://hg.openjdk.java.net/jdk/jdk/rev/c9d756fa846e > Weberv: http://cr.openjdk.java.net/~horii/jdk8u_aes_be/8154156/webrev.01/ > > I confirmed it was buildable for both relase and fastdebug builds, and > JTREG caused no degradation. > > Refs: > [1] http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2018-December/ > 003818.html > [2] 8149655: PPC64: Implement CompactString intrinsics > http://hg.openjdk.java.net/jdk/jdk/rev/6241574f5982 > [3] 8080684: PPC64: Fix little-endian build after "8077838: Recent > developments for ppc" > http://hg.openjdk.java.net/jdk/jdk/rev/12ccf8b26eb0 > [4] 8077838: Recent developments for ppc. > http://hg.openjdk.java.net/jdk/jdk/rev/c703c89fddbf > > Regards, > Ogata From chris.hegarty at oracle.com Mon Jan 7 14:33:48 2019 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 7 Jan 2019 14:33:48 +0000 Subject: 8207404: MulticastSocket tests failing on Aix In-Reply-To: References: <285fd29d18994a74be86dd923a07e10b@sap.com> Message-ID: <00f3a69d-cf14-7194-f2d0-d7f96afecaaf@oracle.com> Steve, On 05/12/2018 10:50, Steve Groeger wrote: > Posting this to net-dev as well as ppc-aix-port-dev as this may be a > more appropriate mailing list to get responses about networking. > > I have performed the test Volker mentioned in an earlier post (on xLinux > machine, remove the ipv6 address from the ens32 interface but leaving > inte6 enabled on the system). > With this configuration the jdk/java/net/MulticastSocket/JoinLeave.java > test still passes, whereas on AIX with a similar configuration the test > fails. > For those with knowledge of networking, should this MulticastSocket test > pass if there is no ipv6 address enabled for the interface being used. If there is no interface, that supports multicasting, with an IPv6 address, then the test will not execute the particular IPv6 multicasting scenario. That is fine, the IPv6 portion of the test is effectively skipped, since it cannot be tested on the particular platform. ( One could separate IPv4 from IPv6 in this test, and rather return a jtreg skipped status if a suitable interface with IPv6 is not found. But is does not seem worth while. ) -Chris. From OGATAK at jp.ibm.com Tue Jan 8 04:59:42 2019 From: OGATAK at jp.ibm.com (Kazunori Ogata) Date: Tue, 8 Jan 2019 13:59:42 +0900 Subject: [8u] RFR for backport of 8154156: PPC64: improve array copy stubs by using vector instructions In-Reply-To: <6adf0a283eda47b29df02a3a2d8550ee@sap.com> References: <6adf0a283eda47b29df02a3a2d8550ee@sap.com> Message-ID: Hi Martin, Thank you for reviewing the patch. I'll submit RFR to jdk8u-dev mailing list referring your reply. Regards, Ogata "Doerr, Martin" wrote on 2019/01/07 22:08:57: > From: "Doerr, Martin" > To: Kazunori Ogata , "hotspot-compiler- > dev at openjdk.java.net" , "ppc-aix- > port-dev at openjdk.java.net" > Date: 2019/01/07 22:09 > Subject: RE: [8u] RFR for backport of 8154156: PPC64: improve array copy > stubs by using vector instructions > > Hi Ogata, > > looks good to me. However, I'm not a jdk8u reviewer. > > Best regards, > Martin > > > -----Original Message----- > From: ppc-aix-port-dev On > Behalf Of Kazunori Ogata > Sent: Montag, 7. Januar 2019 06:14 > To: hotspot-compiler-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net > Subject: Re: [8u] RFR for backport of 8154156: PPC64: improve array copy > stubs by using vector instructions > > Hi, > > Ping. Can anyone review this enhancement backport request? > > Regards, > Ogata > > > Kazunori Ogata/Japan/IBM wrote on 2018/12/18 23:41:16: > > > From: Kazunori Ogata/Japan/IBM > > To: hotspot-compiler-dev at openjdk.java.net, > ppc-aix-port-dev at openjdk.java.net > > Date: 2018/12/18 23:41 > > Subject: [8u] RFR for backport of 8154156: PPC64: improve array copy > stubs > > by using vector instructions > > > > Hi, > > > > May I get review for enhancement backport of 8154156: PPC64: improve > array > > copy stubs by using vector instructions? > > > > To make this patch buildable (and usable by other planned backports > listed > > in [1]), I cherry picked config_dscr() and its dependent code from [2,3] > > > and has_mfdscr() from [4]. > > > > Original patch: http://hg.openjdk.java.net/jdk/jdk/rev/c9d756fa846e > > Weberv: http://cr.openjdk.java.net/~horii/jdk8u_aes_be/8154156/webrev.01/ > > > > I confirmed it was buildable for both relase and fastdebug builds, and > > JTREG caused no degradation. > > > > Refs: > > [1] http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2018-December/ > 003818.html > > [2] 8149655: PPC64: Implement CompactString intrinsics > > http://hg.openjdk.java.net/jdk/jdk/rev/6241574f5982 > > [3] 8080684: PPC64: Fix little-endian build after "8077838: Recent > > developments for ppc" > > http://hg.openjdk.java.net/jdk/jdk/rev/12ccf8b26eb0 > > [4] 8077838: Recent developments for ppc. > > http://hg.openjdk.java.net/jdk/jdk/rev/c703c89fddbf > > > > Regards, > > Ogata > > From goetz.lindenmaier at sap.com Wed Jan 9 11:07:23 2019 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 9 Jan 2019 11:07:23 +0000 Subject: SAP discontinues active support of jdk7u on linuxppc64 and aixppc64 Message-ID: <270c3fddc6784e899d8af694897f9136@sap.com> Hi, AS OpenJDK 7 is no longer relevant to SAP, we will no more actively support our port platforms linuxppc64 and aixppc64 in hg.openjdk.java.net/jdk7u/jdk7u. This means we will cancel our regular builds and tests of the repository. Nevertheless, in urgent cases we will still assist. Of course, we will continue our active support of linuxppc64 and aixppc64 in OpenJDK 8 and keep up our activities in the less recent versions. Best regards, G?tz Lindenmaier -------------- next part -------------- An HTML attachment was scrubbed... URL: From gromero at linux.vnet.ibm.com Wed Jan 9 13:06:35 2019 From: gromero at linux.vnet.ibm.com (Gustavo Romero) Date: Wed, 9 Jan 2019 11:06:35 -0200 Subject: SAP discontinues active support of jdk7u on linuxppc64 and aixppc64 In-Reply-To: <270c3fddc6784e899d8af694897f9136@sap.com> References: <270c3fddc6784e899d8af694897f9136@sap.com> Message-ID: <41034417-b77a-483a-4f05-242e9d7c3152@linux.vnet.ibm.com> Hi Goetz, Thanks for this important heads-up. On 01/09/2019 09:07 AM, Lindenmaier, Goetz wrote: > Of course, we will continue our active support of linuxppc64 > and aixppc64 in OpenJDK 8 and keep up our activities in > the less recent versions. We planned to finished the integration of arraycopy using VSX, SHA2, AES pieces for BE, and latest CRC32 intrinsic enhancement from SAP to 8u. Mostly, Ogata and me are working on it. Best regards, Gustavo From takiguc at linux.vnet.ibm.com Wed Jan 9 13:14:50 2019 From: takiguc at linux.vnet.ibm.com (Ichiroh Takiguchi) Date: Wed, 09 Jan 2019 22:14:50 +0900 Subject: Open ppc/s390/aix issues - JDK-8211841 In-Reply-To: <92c003c24bf8466886e3602604650c8c@sap.com> References: <8c6b8ea2a811401eb7559ab68e821bd4@sap.com> <92c003c24bf8466886e3602604650c8c@sap.com> Message-ID: <839f6ff1baaab593cb09a43867a702e7@linux.vnet.ibm.com> Hello Goetz. Could you check following fix ? http://cr.openjdk.java.net/~itakiguchi/8211841/ I tested it on AIX and Linux amd64 platform. It worked fine on both platform with jtreg. Thanks, Ichiroh Takiguchi On 2018-10-29 19:55, Lindenmaier, Goetz wrote: > Hi Ichiroh, > > I did not look into this issue, I just reported the > bug. So feel free to choose an adequate solution > to fix this. > > Best regards, > Goetz > >> -----Original Message----- >> From: Ichiroh Takiguchi >> Sent: Freitag, 19. Oktober 2018 04:00 >> To: Lindenmaier, Goetz >> Cc: ppc-aix-port-dev ; s390x-port- >> dev at openjdk.java.net; Gustavo Romero ; Tim >> Ellison ; Nasser Ebrahim ; >> Michihiro Horie ; Toshio 5 Nakamura >> ; Andrew Leonard >> >> Subject: Re: Open ppc/s390/aix issues >> >> Hello Goetz. >> > 8211841: [aix] sun/nio/cs/OLD/TestIBMDB.java fails with compilation >> > error >> > https://bugs.openjdk.java.net/browse/JDK-8211841 >> I'll handle it on Nov. >> But I'd like to confirm one thing. >> You may know this compilation error came from jigsaw (modularity >> feature). >> I may rewrite the some of the parts by using reflection feature. >> Do you think it's acceptable solution ? >> >> Thanks, >> Ichiroh Takiguchi >> >> On 2018-10-09 01:58, Lindenmaier, Goetz wrote: >> > Hi, >> > >> > We are now working on the ppc/s390/aix ports for quite some years. >> > With the release of jdk11 we delivered a very comprehensive and well >> > maintained port I think. For example, the jdk and hotspot jtreg tests >> > can be run quite stable on these platforms. >> > >> > I filed bugs for all the remaining issues we see, at least in the >> > test setup we run at SAP. >> > >> > Everybody is invited to join in and fix these few finally :) >> > >> > 8207404: MulticastSocket tests failing on Aix >> > https://bugs.openjdk.java.net/browse/JDK-8207404 >> > 8030957: AIX: Implement OperatingSystemMXBean.getSystemCpuLoad() and >> > .getProcessCpuLoad() on AIX >> > https://bugs.openjdk.java.net/browse/JDK-8030957 >> > 8211769: Port Dtrace support to ppc. >> > https://bugs.openjdk.java.net/browse/JDK-8211769 >> > 8211771: Port Dtrace support to s390x. >> > https://bugs.openjdk.java.net/browse/JDK-8211771 >> > 8211767: jtreg: Some SA tests are failing on PPC64 >> > https://bugs.openjdk.java.net/browse/JDK-8211767 >> > 8211844: [aix] ProcessBuilder: Piping between created processes does >> > not work. >> > https://bugs.openjdk.java.net/browse/JDK-8211844 >> > 8211847: [aix] java/lang/ProcessHandle/InfoTest.java fails: "reported >> > cputime less than expected" >> > https://bugs.openjdk.java.net/browse/JDK-8211847 >> > 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fais: >> > read times out >> > https://bugs.openjdk.java.net/browse/JDK-8211854 >> > 8211851: >> > /java/nio/channels/AsynchronousSocketChannel/StressLoopback.java times >> > out (aix) >> > https://bugs.openjdk.java.net/browse/JDK-8211851 >> > 8211841: [aix] sun/nio/cs/OLD/TestIBMDB.java fails with compilation >> > error >> > https://bugs.openjdk.java.net/browse/JDK-8211841 >> > >> > Best regards, >> > Goetz. From goetz.lindenmaier at sap.com Wed Jan 9 13:55:58 2019 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 9 Jan 2019 13:55:58 +0000 Subject: Open ppc/s390/aix issues - JDK-8211841 In-Reply-To: <839f6ff1baaab593cb09a43867a702e7@linux.vnet.ibm.com> References: <8c6b8ea2a811401eb7559ab68e821bd4@sap.com> <92c003c24bf8466886e3602604650c8c@sap.com> <839f6ff1baaab593cb09a43867a702e7@linux.vnet.ibm.com> Message-ID: <54fe49dbea3d4fe5b99985a8ab415d4b@sap.com> Hi Ichiroh, I put the patch into our nightly tests. I also verified that it fixes the issue on my aix machine locally. Before January 17th, please push this to jdk12. I marked it as [testbug]. Please remove the test from the problem list, else it will not be executed per default, see patch below. Best regards, Goetz. --- a/test/jdk/ProblemList.txt Wed Jan 09 11:11:00 2019 +0100 +++ b/test/jdk/ProblemList.txt Wed Jan 09 14:46:30 2019 +0100 @@ -583,7 +583,6 @@ java/nio/file/WatchService/LotsOfCancels.java 8188039 solaris-all Solaris 11 java/nio/file/WatchService/LotsOfEvents.java 7158947 solaris-all Solaris 11 -sun/nio/cs/OLD/TestIBMDB.java 8211841 aix-ppc64 ############################################################################ > -----Original Message----- > From: Ichiroh Takiguchi > Sent: Mittwoch, 9. Januar 2019 14:15 > To: Lindenmaier, Goetz > Cc: ppc-aix-port-dev ; s390x-port- > dev at openjdk.java.net; Gustavo Romero ; > Tim Ellison ; Nasser Ebrahim > ; Michihiro Horie ; Toshio 5 > Nakamura ; Andrew Leonard > > Subject: RE: Open ppc/s390/aix issues - JDK-8211841 > > Hello Goetz. > > Could you check following fix ? > http://cr.openjdk.java.net/~itakiguchi/8211841/ > > I tested it on AIX and Linux amd64 platform. > It worked fine on both platform with jtreg. > > Thanks, > Ichiroh Takiguchi > > On 2018-10-29 19:55, Lindenmaier, Goetz wrote: > > Hi Ichiroh, > > > > I did not look into this issue, I just reported the > > bug. So feel free to choose an adequate solution > > to fix this. > > > > Best regards, > > Goetz > > > >> -----Original Message----- > >> From: Ichiroh Takiguchi > >> Sent: Freitag, 19. Oktober 2018 04:00 > >> To: Lindenmaier, Goetz > >> Cc: ppc-aix-port-dev ; s390x-port- > >> dev at openjdk.java.net; Gustavo Romero ; > Tim > >> Ellison ; Nasser Ebrahim > ; > >> Michihiro Horie ; Toshio 5 Nakamura > >> ; Andrew Leonard > >> > >> Subject: Re: Open ppc/s390/aix issues > >> > >> Hello Goetz. > >> > 8211841: [aix] sun/nio/cs/OLD/TestIBMDB.java fails with compilation > >> > error > >> > https://bugs.openjdk.java.net/browse/JDK-8211841 > >> I'll handle it on Nov. > >> But I'd like to confirm one thing. > >> You may know this compilation error came from jigsaw (modularity > >> feature). > >> I may rewrite the some of the parts by using reflection feature. > >> Do you think it's acceptable solution ? > >> > >> Thanks, > >> Ichiroh Takiguchi > >> > >> On 2018-10-09 01:58, Lindenmaier, Goetz wrote: > >> > Hi, > >> > > >> > We are now working on the ppc/s390/aix ports for quite some years. > >> > With the release of jdk11 we delivered a very comprehensive and well > >> > maintained port I think. For example, the jdk and hotspot jtreg tests > >> > can be run quite stable on these platforms. > >> > > >> > I filed bugs for all the remaining issues we see, at least in the > >> > test setup we run at SAP. > >> > > >> > Everybody is invited to join in and fix these few finally :) > >> > > >> > 8207404: MulticastSocket tests failing on Aix > >> > https://bugs.openjdk.java.net/browse/JDK-8207404 > >> > 8030957: AIX: Implement OperatingSystemMXBean.getSystemCpuLoad() > and > >> > .getProcessCpuLoad() on AIX > >> > https://bugs.openjdk.java.net/browse/JDK-8030957 > >> > 8211769: Port Dtrace support to ppc. > >> > https://bugs.openjdk.java.net/browse/JDK-8211769 > >> > 8211771: Port Dtrace support to s390x. > >> > https://bugs.openjdk.java.net/browse/JDK-8211771 > >> > 8211767: jtreg: Some SA tests are failing on PPC64 > >> > https://bugs.openjdk.java.net/browse/JDK-8211767 > >> > 8211844: [aix] ProcessBuilder: Piping between created processes does > >> > not work. > >> > https://bugs.openjdk.java.net/browse/JDK-8211844 > >> > 8211847: [aix] java/lang/ProcessHandle/InfoTest.java fails: "reported > >> > cputime less than expected" > >> > https://bugs.openjdk.java.net/browse/JDK-8211847 > >> > 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fais: > >> > read times out > >> > https://bugs.openjdk.java.net/browse/JDK-8211854 > >> > 8211851: > >> > /java/nio/channels/AsynchronousSocketChannel/StressLoopback.java > times > >> > out (aix) > >> > https://bugs.openjdk.java.net/browse/JDK-8211851 > >> > 8211841: [aix] sun/nio/cs/OLD/TestIBMDB.java fails with compilation > >> > error > >> > https://bugs.openjdk.java.net/browse/JDK-8211841 > >> > > >> > Best regards, > >> > Goetz. From goetz.lindenmaier at sap.com Wed Jan 9 14:03:31 2019 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 9 Jan 2019 14:03:31 +0000 Subject: Open ppc/s390/aix issues - JDK-8211841 In-Reply-To: <839f6ff1baaab593cb09a43867a702e7@linux.vnet.ibm.com> References: <8c6b8ea2a811401eb7559ab68e821bd4@sap.com> <92c003c24bf8466886e3602604650c8c@sap.com> <839f6ff1baaab593cb09a43867a702e7@linux.vnet.ibm.com> Message-ID: <60682f6a360c447889c2939fbd6dddea@sap.com> Hi Ichiroh, I just see that you need to request review on core-libs-dev or some other official suited mailing list. Best regards, Goetz. > -----Original Message----- > From: Ichiroh Takiguchi > Sent: Mittwoch, 9. Januar 2019 14:15 > To: Lindenmaier, Goetz > Cc: ppc-aix-port-dev ; s390x-port- > dev at openjdk.java.net; Gustavo Romero ; > Tim Ellison ; Nasser Ebrahim > ; Michihiro Horie ; Toshio 5 > Nakamura ; Andrew Leonard > > Subject: RE: Open ppc/s390/aix issues - JDK-8211841 > > Hello Goetz. > > Could you check following fix ? > http://cr.openjdk.java.net/~itakiguchi/8211841/ > > I tested it on AIX and Linux amd64 platform. > It worked fine on both platform with jtreg. > > Thanks, > Ichiroh Takiguchi > > On 2018-10-29 19:55, Lindenmaier, Goetz wrote: > > Hi Ichiroh, > > > > I did not look into this issue, I just reported the > > bug. So feel free to choose an adequate solution > > to fix this. > > > > Best regards, > > Goetz > > > >> -----Original Message----- > >> From: Ichiroh Takiguchi > >> Sent: Freitag, 19. Oktober 2018 04:00 > >> To: Lindenmaier, Goetz > >> Cc: ppc-aix-port-dev ; s390x-port- > >> dev at openjdk.java.net; Gustavo Romero ; > Tim > >> Ellison ; Nasser Ebrahim > ; > >> Michihiro Horie ; Toshio 5 Nakamura > >> ; Andrew Leonard > >> > >> Subject: Re: Open ppc/s390/aix issues > >> > >> Hello Goetz. > >> > 8211841: [aix] sun/nio/cs/OLD/TestIBMDB.java fails with compilation > >> > error > >> > https://bugs.openjdk.java.net/browse/JDK-8211841 > >> I'll handle it on Nov. > >> But I'd like to confirm one thing. > >> You may know this compilation error came from jigsaw (modularity > >> feature). > >> I may rewrite the some of the parts by using reflection feature. > >> Do you think it's acceptable solution ? > >> > >> Thanks, > >> Ichiroh Takiguchi > >> > >> On 2018-10-09 01:58, Lindenmaier, Goetz wrote: > >> > Hi, > >> > > >> > We are now working on the ppc/s390/aix ports for quite some years. > >> > With the release of jdk11 we delivered a very comprehensive and well > >> > maintained port I think. For example, the jdk and hotspot jtreg tests > >> > can be run quite stable on these platforms. > >> > > >> > I filed bugs for all the remaining issues we see, at least in the > >> > test setup we run at SAP. > >> > > >> > Everybody is invited to join in and fix these few finally :) > >> > > >> > 8207404: MulticastSocket tests failing on Aix > >> > https://bugs.openjdk.java.net/browse/JDK-8207404 > >> > 8030957: AIX: Implement OperatingSystemMXBean.getSystemCpuLoad() > and > >> > .getProcessCpuLoad() on AIX > >> > https://bugs.openjdk.java.net/browse/JDK-8030957 > >> > 8211769: Port Dtrace support to ppc. > >> > https://bugs.openjdk.java.net/browse/JDK-8211769 > >> > 8211771: Port Dtrace support to s390x. > >> > https://bugs.openjdk.java.net/browse/JDK-8211771 > >> > 8211767: jtreg: Some SA tests are failing on PPC64 > >> > https://bugs.openjdk.java.net/browse/JDK-8211767 > >> > 8211844: [aix] ProcessBuilder: Piping between created processes does > >> > not work. > >> > https://bugs.openjdk.java.net/browse/JDK-8211844 > >> > 8211847: [aix] java/lang/ProcessHandle/InfoTest.java fails: "reported > >> > cputime less than expected" > >> > https://bugs.openjdk.java.net/browse/JDK-8211847 > >> > 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fais: > >> > read times out > >> > https://bugs.openjdk.java.net/browse/JDK-8211854 > >> > 8211851: > >> > /java/nio/channels/AsynchronousSocketChannel/StressLoopback.java > times > >> > out (aix) > >> > https://bugs.openjdk.java.net/browse/JDK-8211851 > >> > 8211841: [aix] sun/nio/cs/OLD/TestIBMDB.java fails with compilation > >> > error > >> > https://bugs.openjdk.java.net/browse/JDK-8211841 > >> > > >> > Best regards, > >> > Goetz. From GROEGES at uk.ibm.com Wed Jan 9 15:20:21 2019 From: GROEGES at uk.ibm.com (Steve Groeger) Date: Wed, 9 Jan 2019 15:20:21 +0000 Subject: 8207404: MulticastSocket tests failing on Aix In-Reply-To: <00f3a69d-cf14-7194-f2d0-d7f96afecaaf@oracle.com> References: <285fd29d18994a74be86dd923a07e10b@sap.com> <00f3a69d-cf14-7194-f2d0-d7f96afecaaf@oracle.com> Message-ID: Hi Chris, Thanks for responding. The IPv6 portion of the test is not being executed as you have mentioned. The errors I am seeing on AIX are when it runs the IPv4 portion of the test. The AIX system I am running on has IPv6 enabled but the interface that is being used for the IPv4 test (en0) doesn't have an IPv6/INET6 address configured for it. As can be seen from the output from the 'ifconfig -a' command en0: flags=1e084863,80480 inet 9.xxx.xxx.150 netmask 0xfffffe00 broadcast 9.xxx.xxx.255 tcp_sendspace 262144 tcp_recvspace 262144 rfc1323 1 lo0: flags=e08084b,c0 inet 127.0.0.1 netmask 0xff000000 broadcast 127.255.255.255 inet6 ::1%1/64 tcp_sendspace 131072 tcp_recvspace 131072 rfc1323 1 The test does the following: try (MulticastSocket soc = new MulticastSocket()) { soc.setNetworkInterface(nif); soc.joinGroup(group); soc.leaveGroup(group); } catch (IOException e) { throw new UncheckedIOException(e); } The issue I am gettiing is when the test calls the following line soc.setNetworkInterface(nif); which basically ends up throwing an exception from the mcast_set_if_by_if_v6 native method in java.base/unix/native/libnet/PlainDatagramSocketImpl.c when it is doing the setsockopt which gets a EADDRNOTAVAIL error and throws an exception. The code is: if (setsockopt(fd, IPPROTO_IPV6, IPV6_MULTICAST_IF, (const char*)&index, sizeof(index)) < 0) { if (errno == EINVAL && index > 0) { JNU_ThrowByName(env, JNU_JAVANETPKG "SocketException", "IPV6_MULTICAST_IF failed (interface has IPv4 " "address only?)"); } else { JNU_ThrowByNameWithMessageAndLastError (env, JNU_JAVANETPKG "SocketException", "Error setting socket option"); } return; } If I run the test with '-Djava.net.preferIPv4Stack=true` it al works fine. Digging into the java code I can see that when the MulticastSocket is created using try (MulticastSocket soc = new MulticastSocket()) { it ends up in the datagramSocketCreate function in Java_java_net_PlainDatagramSocketImpl_datagramSocketCreate(JNIEnv *env, jobject this) { jobject fdObj = (*env)->GetObjectField(env, this, pdsi_fdID); int arg, fd, t = 1; char tmpbuf[1024]; int domain = ipv6_available() ? AF_INET6 : AF_INET; if (IS_NULL(fdObj)) { JNU_ThrowByName(env, JNU_JAVANETPKG "SocketException", "Socket closed"); return; } if ((fd = socket(domain, SOCK_DGRAM, 0)) == -1) { JNU_ThrowByNameWithMessageAndLastError (env, JNU_JAVANETPKG "SocketException", "Error creating socket"); return; } where it is creating a socket with a family of AF_INET6 because the ipv6_available() function returns true. then later we are trying to configure an interface on that socket that doesnt have an IPv6/INET6 address and hence why I think we get the EADDRNOTAVAIL error. I think I have an Linux system setup with a simarly configured interface (system has IPv6 configured but interface has no IPv6/INET6 address configured) but the test works fine when run on that system. This was why I was asking the question on whether this should work on AIX, or whether it should fail on Linux!!! Hoping that with the description above you might be able to let me know what the expected behaviour is. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges at uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: Chris Hegarty To: Steve Groeger , net-dev at openjdk.java.net Cc: ppc-aix-port-dev at openjdk.java.net Date: 07/01/2019 14:34 Subject: Re: 8207404: MulticastSocket tests failing on Aix Steve, On 05/12/2018 10:50, Steve Groeger wrote: > Posting this to net-dev as well as ppc-aix-port-dev as this may be a > more appropriate mailing list to get responses about networking. > > I have performed the test Volker mentioned in an earlier post (on xLinux > machine, remove the ipv6 address from the ens32 interface but leaving > inte6 enabled on the system). > With this configuration the jdk/java/net/MulticastSocket/JoinLeave.java > test still passes, whereas on AIX with a similar configuration the test > fails. > For those with knowledge of networking, should this MulticastSocket test > pass if there is no ipv6 address enabled for the interface being used. If there is no interface, that supports multicasting, with an IPv6 address, then the test will not execute the particular IPv6 multicasting scenario. That is fine, the IPv6 portion of the test is effectively skipped, since it cannot be tested on the particular platform. ( One could separate IPv4 from IPv6 in this test, and rather return a jtreg skipped status if a suitable interface with IPv6 is not found. But is does not seem worth while. ) -Chris. Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From chris.hegarty at oracle.com Fri Jan 11 16:28:38 2019 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 11 Jan 2019 16:28:38 +0000 Subject: 8207404: MulticastSocket tests failing on Aix In-Reply-To: References: <285fd29d18994a74be86dd923a07e10b@sap.com> <00f3a69d-cf14-7194-f2d0-d7f96afecaaf@oracle.com> Message-ID: <6c49e1f1-eecb-5c66-1ee0-71aaff6921e6@oracle.com> On 09/01/2019 15:20, Steve Groeger wrote: >... > > I think I have an Linux system setup with a simarly configured interface > (system has IPv6 configured but interface > has no IPv6/INET6 address configured) but the test works fine when run > on that system. This is what I observe too. Confirmed by looking at the test output in the jtr file. > This was why I was asking the question on whether this should work on > AIX, or whether it should fail on Linux!!! I suspect that this is an issue with the native setsockopt on AIX. That said, if it cannot be resolved on AIX, then maybe the networking native code on AIX, should workaround it. -Chris. From volker.simonis at gmail.com Fri Jan 11 17:28:35 2019 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 11 Jan 2019 18:28:35 +0100 Subject: 8207404: MulticastSocket tests failing on Aix In-Reply-To: <6c49e1f1-eecb-5c66-1ee0-71aaff6921e6@oracle.com> References: <285fd29d18994a74be86dd923a07e10b@sap.com> <00f3a69d-cf14-7194-f2d0-d7f96afecaaf@oracle.com> <6c49e1f1-eecb-5c66-1ee0-71aaff6921e6@oracle.com> Message-ID: I think the difference is in setMulticastInterface() in PlainDatagramSocketImpl.c #ifdef __linux__ mcast_set_if_by_if_v4(env, this, fd, value); if (ipv6_available()) { if ((*env)->ExceptionCheck(env)){ (*env)->ExceptionClear(env); } mcast_set_if_by_if_v6(env, this, fd, value); } #else /* __linux__ not defined */ if (ipv6_available()) { mcast_set_if_by_if_v6(env, this, fd, value); } else { mcast_set_if_by_if_v4(env, this, fd, value); } #endif /* __linux__ */ We should probably follow the Linux way for AIX as well. On Fri, Jan 11, 2019 at 5:29 PM Chris Hegarty wrote: > > > On 09/01/2019 15:20, Steve Groeger wrote: > >... > > > > I think I have an Linux system setup with a simarly configured interface > > (system has IPv6 configured but interface > > has no IPv6/INET6 address configured) but the test works fine when run > > on that system. > > This is what I observe too. Confirmed by looking at the test > output in the jtr file. > > > This was why I was asking the question on whether this should work on > > AIX, or whether it should fail on Linux!!! > > I suspect that this is an issue with the native setsockopt > on AIX. That said, if it cannot be resolved on AIX, then > maybe the networking native code on AIX, should workaround > it. > > -Chris. From chris.hegarty at oracle.com Sat Jan 12 14:20:30 2019 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Sat, 12 Jan 2019 14:20:30 +0000 Subject: 8207404: MulticastSocket tests failing on Aix In-Reply-To: References: <285fd29d18994a74be86dd923a07e10b@sap.com> <00f3a69d-cf14-7194-f2d0-d7f96afecaaf@oracle.com> <6c49e1f1-eecb-5c66-1ee0-71aaff6921e6@oracle.com> Message-ID: > On 11 Jan 2019, at 17:28, Volker Simonis wrote: > > I think the difference is in setMulticastInterface() in > PlainDatagramSocketImpl.c > > #ifdef __linux__ > mcast_set_if_by_if_v4(env, this, fd, value); > if (ipv6_available()) { > if ((*env)->ExceptionCheck(env)){ > (*env)->ExceptionClear(env); > } > mcast_set_if_by_if_v6(env, this, fd, value); > } > #else /* __linux__ not defined */ > if (ipv6_available()) { > mcast_set_if_by_if_v6(env, this, fd, value); > } else { > mcast_set_if_by_if_v4(env, this, fd, value); > } > #endif /* __linux__ */ > > We should probably follow the Linux way for AIX as well. I agree. -Chris. >> On Fri, Jan 11, 2019 at 5:29 PM Chris Hegarty wrote: >> >> >>> On 09/01/2019 15:20, Steve Groeger wrote: >>> ... >>> >>> I think I have an Linux system setup with a simarly configured interface >>> (system has IPv6 configured but interface >>> has no IPv6/INET6 address configured) but the test works fine when run >>> on that system. >> >> This is what I observe too. Confirmed by looking at the test >> output in the jtr file. >> >>> This was why I was asking the question on whether this should work on >>> AIX, or whether it should fail on Linux!!! >> >> I suspect that this is an issue with the native setsockopt >> on AIX. That said, if it cannot be resolved on AIX, then >> maybe the networking native code on AIX, should workaround >> it. >> >> -Chris. From GROEGES at uk.ibm.com Mon Jan 14 13:19:38 2019 From: GROEGES at uk.ibm.com (Steve Groeger) Date: Mon, 14 Jan 2019 13:19:38 +0000 Subject: 8207404: MulticastSocket tests failing on Aix In-Reply-To: References: <285fd29d18994a74be86dd923a07e10b@sap.com> <00f3a69d-cf14-7194-f2d0-d7f96afecaaf@oracle.com> <6c49e1f1-eecb-5c66-1ee0-71aaff6921e6@oracle.com> Message-ID: Hi Chris / Volker, I had already tried doing the same as is done for Linux, ie calling this first mcast_set_if_by_if_v4(env, this, fd, value); This still fails for some reason with EADDRNOTAVAIL. This error gets cleared by the if ((*env)->ExceptionCheck(env)){ (*env)->ExceptionClear(env); } as ipv6_available() still returns true, but we then still try and call mcast_set_if_by_if_v6(env, this, fd, value); which again fails with EADDRNOTAVAIL. So we have the same result. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges at uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: Chris Hegarty To: Volker Simonis Cc: Steve Groeger , ppc-aix-port-dev at openjdk.java.net, net-dev Date: 12/01/2019 14:21 Subject: Re: 8207404: MulticastSocket tests failing on Aix > On 11 Jan 2019, at 17:28, Volker Simonis wrote: > > I think the difference is in setMulticastInterface() in > PlainDatagramSocketImpl.c > > #ifdef __linux__ > mcast_set_if_by_if_v4(env, this, fd, value); > if (ipv6_available()) { > if ((*env)->ExceptionCheck(env)){ > (*env)->ExceptionClear(env); > } > mcast_set_if_by_if_v6(env, this, fd, value); > } > #else /* __linux__ not defined */ > if (ipv6_available()) { > mcast_set_if_by_if_v6(env, this, fd, value); > } else { > mcast_set_if_by_if_v4(env, this, fd, value); > } > #endif /* __linux__ */ > > We should probably follow the Linux way for AIX as well. I agree. -Chris. >> On Fri, Jan 11, 2019 at 5:29 PM Chris Hegarty wrote: >> >> >>> On 09/01/2019 15:20, Steve Groeger wrote: >>> ... >>> >>> I think I have an Linux system setup with a simarly configured interface >>> (system has IPv6 configured but interface >>> has no IPv6/INET6 address configured) but the test works fine when run >>> on that system. >> >> This is what I observe too. Confirmed by looking at the test >> output in the jtr file. >> >>> This was why I was asking the question on whether this should work on >>> AIX, or whether it should fail on Linux!!! >> >> I suspect that this is an issue with the native setsockopt >> on AIX. That said, if it cannot be resolved on AIX, then >> maybe the networking native code on AIX, should workaround >> it. >> >> -Chris. Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From volker.simonis at gmail.com Mon Jan 14 14:08:52 2019 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 14 Jan 2019 15:08:52 +0100 Subject: 8207404: MulticastSocket tests failing on Aix In-Reply-To: References: <285fd29d18994a74be86dd923a07e10b@sap.com> <00f3a69d-cf14-7194-f2d0-d7f96afecaaf@oracle.com> <6c49e1f1-eecb-5c66-1ee0-71aaff6921e6@oracle.com> Message-ID: On Mon, Jan 14, 2019 at 2:19 PM Steve Groeger wrote: > > Hi Chris / Volker, > > I had already tried doing the same as is done for Linux, ie calling this first > > mcast_set_if_by_if_v4(env, this, fd, value); > > This still fails for some reason with EADDRNOTAVAIL. Finding this out is probably the main challenge in order to solve this issue and one of the reason why we asked IBM for assistance :) I suppose there must be a possibility to set a socket option for an IPv4 socket on AIX even if IPv6 is enabled. Otherwise this is probably an AIX problem/bug which should be fixed there (where, again, we need assistance from IBM). The man-page (https://www.ibm.com/support/knowledgecenter/ssw_ibm_i_71/apis/ssocko.htm) mentions the following: IP_MULTICAST_IF: et interface over which outgoing multicast datagrams should be sent. This option is only supported for sockets with an address family of AF_INET and type of SOCK_DGRAM or SOCK_RAW. Maybe the interface is erroneously in the AF_INET6 family? The man-page only mentions the following for EADDRNOTAVAIL: EADDRNOTAVAIL: Address not available. For the IP_ADD_MEMBERSHIP or IP_DROP_MEMBERSHIP operations, this error code indicates that an incorrect address was specified for either the imr_multiaddr or imr_interface parameter value. > This error gets cleared by the > > if ((*env)->ExceptionCheck(env)){ > (*env)->ExceptionClear(env); > } > > as ipv6_available() still returns true, but we then still try and call > > mcast_set_if_by_if_v6(env, this, fd, value); > > which again fails with EADDRNOTAVAIL. So we have the same result. > > Thanks > Steve Groeger > IBM Runtime Technologies > Hursley, Winchester > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > Fax (44) 1962 816800 > Lotus Notes: Steve Groeger/UK/IBM > Internet: groeges at uk.ibm.com > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > > > From: Chris Hegarty > To: Volker Simonis > Cc: Steve Groeger , ppc-aix-port-dev at openjdk.java.net, net-dev > Date: 12/01/2019 14:21 > Subject: Re: 8207404: MulticastSocket tests failing on Aix > ________________________________ > > > > > > > On 11 Jan 2019, at 17:28, Volker Simonis wrote: > > > > I think the difference is in setMulticastInterface() in > > PlainDatagramSocketImpl.c > > > > #ifdef __linux__ > > mcast_set_if_by_if_v4(env, this, fd, value); > > if (ipv6_available()) { > > if ((*env)->ExceptionCheck(env)){ > > (*env)->ExceptionClear(env); > > } > > mcast_set_if_by_if_v6(env, this, fd, value); > > } > > #else /* __linux__ not defined */ > > if (ipv6_available()) { > > mcast_set_if_by_if_v6(env, this, fd, value); > > } else { > > mcast_set_if_by_if_v4(env, this, fd, value); > > } > > #endif /* __linux__ */ > > > > We should probably follow the Linux way for AIX as well. > > I agree. > > -Chris. > > >> On Fri, Jan 11, 2019 at 5:29 PM Chris Hegarty wrote: > >> > >> > >>> On 09/01/2019 15:20, Steve Groeger wrote: > >>> ... > >>> > >>> I think I have an Linux system setup with a simarly configured interface > >>> (system has IPv6 configured but interface > >>> has no IPv6/INET6 address configured) but the test works fine when run > >>> on that system. > >> > >> This is what I observe too. Confirmed by looking at the test > >> output in the jtr file. > >> > >>> This was why I was asking the question on whether this should work on > >>> AIX, or whether it should fail on Linux!!! > >> > >> I suspect that this is an issue with the native setsockopt > >> on AIX. That said, if it cannot be resolved on AIX, then > >> maybe the networking native code on AIX, should workaround > >> it. > >> > >> -Chris. > > > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From GROEGES at uk.ibm.com Mon Jan 14 14:30:41 2019 From: GROEGES at uk.ibm.com (Steve Groeger) Date: Mon, 14 Jan 2019 14:30:41 +0000 Subject: 8207404: MulticastSocket tests failing on Aix In-Reply-To: References: <00f3a69d-cf14-7194-f2d0-d7f96afecaaf@oracle.com> <6c49e1f1-eecb-5c66-1ee0-71aaff6921e6@oracle.com> Message-ID: Hi Volker, The reason the mcast_set_if_by_if_v4(env, this, fd, value); probably fails is that the socket that we are trying to set the IPPROTO_IP, IP_MULTICAST_IF options on has been created with the AF_INET6 family, and these options may not be valid. The socket is setup with the AF_INET6 family because ipv6_available() returns true, as the AIX system does support INET6/IPv6. It is just that the interface we are using doesnt have an INET6 address associated with it. I am checking with the AIX/C compiler team in IBM to see if this a bug or not. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges at uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: Volker Simonis To: Steve Groeger Cc: Chris Hegarty , net-dev , ppc-aix-port-dev at openjdk.java.net Date: 14/01/2019 14:11 Subject: Re: 8207404: MulticastSocket tests failing on Aix On Mon, Jan 14, 2019 at 2:19 PM Steve Groeger wrote: > > Hi Chris / Volker, > > I had already tried doing the same as is done for Linux, ie calling this first > > mcast_set_if_by_if_v4(env, this, fd, value); > > This still fails for some reason with EADDRNOTAVAIL. Finding this out is probably the main challenge in order to solve this issue and one of the reason why we asked IBM for assistance :) I suppose there must be a possibility to set a socket option for an IPv4 socket on AIX even if IPv6 is enabled. Otherwise this is probably an AIX problem/bug which should be fixed there (where, again, we need assistance from IBM). The man-page ( https://www.ibm.com/support/knowledgecenter/ssw_ibm_i_71/apis/ssocko.htm) mentions the following: IP_MULTICAST_IF: et interface over which outgoing multicast datagrams should be sent. This option is only supported for sockets with an address family of AF_INET and type of SOCK_DGRAM or SOCK_RAW. Maybe the interface is erroneously in the AF_INET6 family? The man-page only mentions the following for EADDRNOTAVAIL: EADDRNOTAVAIL: Address not available. For the IP_ADD_MEMBERSHIP or IP_DROP_MEMBERSHIP operations, this error code indicates that an incorrect address was specified for either the imr_multiaddr or imr_interface parameter value. > This error gets cleared by the > > if ((*env)->ExceptionCheck(env)){ > (*env)->ExceptionClear(env); > } > > as ipv6_available() still returns true, but we then still try and call > > mcast_set_if_by_if_v6(env, this, fd, value); > > which again fails with EADDRNOTAVAIL. So we have the same result. > > Thanks > Steve Groeger > IBM Runtime Technologies > Hursley, Winchester > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > Fax (44) 1962 816800 > Lotus Notes: Steve Groeger/UK/IBM > Internet: groeges at uk.ibm.com > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > > > From: Chris Hegarty > To: Volker Simonis > Cc: Steve Groeger , ppc-aix-port-dev at openjdk.java.net, net-dev > Date: 12/01/2019 14:21 > Subject: Re: 8207404: MulticastSocket tests failing on Aix > ________________________________ > > > > > > > On 11 Jan 2019, at 17:28, Volker Simonis wrote: > > > > I think the difference is in setMulticastInterface() in > > PlainDatagramSocketImpl.c > > > > #ifdef __linux__ > > mcast_set_if_by_if_v4(env, this, fd, value); > > if (ipv6_available()) { > > if ((*env)->ExceptionCheck(env)){ > > (*env)->ExceptionClear(env); > > } > > mcast_set_if_by_if_v6(env, this, fd, value); > > } > > #else /* __linux__ not defined */ > > if (ipv6_available()) { > > mcast_set_if_by_if_v6(env, this, fd, value); > > } else { > > mcast_set_if_by_if_v4(env, this, fd, value); > > } > > #endif /* __linux__ */ > > > > We should probably follow the Linux way for AIX as well. > > I agree. > > -Chris. > > >> On Fri, Jan 11, 2019 at 5:29 PM Chris Hegarty wrote: > >> > >> > >>> On 09/01/2019 15:20, Steve Groeger wrote: > >>> ... > >>> > >>> I think I have an Linux system setup with a simarly configured interface > >>> (system has IPv6 configured but interface > >>> has no IPv6/INET6 address configured) but the test works fine when run > >>> on that system. > >> > >> This is what I observe too. Confirmed by looking at the test > >> output in the jtr file. > >> > >>> This was why I was asking the question on whether this should work on > >>> AIX, or whether it should fail on Linux!!! > >> > >> I suspect that this is an issue with the native setsockopt > >> on AIX. That said, if it cannot be resolved on AIX, then > >> maybe the networking native code on AIX, should workaround > >> it. > >> > >> -Chris. > > > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From takiguc at linux.vnet.ibm.com Tue Jan 15 00:51:10 2019 From: takiguc at linux.vnet.ibm.com (Ichiroh Takiguchi) Date: Tue, 15 Jan 2019 09:51:10 +0900 Subject: RFR: 8214533 IBM-29626C is required for AIX default charset In-Reply-To: <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> Message-ID: <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> Hello Alan. Could you review the fix again ? Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ I added IBM29626C charset as standard way. Please give any suggestion and question. Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2018-12-14 18:58, Ichiroh Takiguchi wrote: > Hello Alan. > > I opened JDK-8215333 for Charset filtering issue [1]. > I cannot wait until JDK-8215333 is closed. > Is it possible to put IBM-29626C charset with standard way ? > > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 > > Thanks, > Ichiroh Takiguchi > > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: >> Hello Roger, Magnus and Alan. >> I may need to put alias information into charsets file. >> stdcs-xxx cannot handle this information... >> >> Still AIX needs IBM-29626C charset for default encoding... >> >> I appreciate if you give me further suggestions. >> >> Thanks, >> Ichiroh Takiguchi >> >> On 2018-12-10 20:50, Alan Bateman wrote: >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: >>>> On 2018-12-07 21:20, Roger Riggs wrote: >>>>> Hi, >>>>> >>>>> It is a nice feature that charsets are selected at build time using >>>>> the stdcs-xxx files. >>>>> This change breaks that pattern and embeds os specific information >>>>> in more than one place. >>>>> That does not seem like an improvement.? Is there any alternative? >>>> I agree. Why is it not enough just to add it to stdcs-aix? >>> My reading of the patch is that the "os" key is to avoid generating >>> it >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on >>> non-AIX platforms. The general direction is welcome but I think >>> further work and discussion will be needed to get the right set of >>> changes to support filtering in the build. It can probably be >>> separated from the changes to add IBM-29626C to AIX's java.base. >>> >>> -Alan From christoph.langer at sap.com Tue Jan 15 15:16:14 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 15 Jan 2019 15:16:14 +0000 Subject: 8207404: MulticastSocket tests failing on Aix In-Reply-To: References: <00f3a69d-cf14-7194-f2d0-d7f96afecaaf@oracle.com> <6c49e1f1-eecb-5c66-1ee0-71aaff6921e6@oracle.com> Message-ID: <17df0a7e2f5d4b028dd570621216f77b@sap.com> Hi Steve, I have looked into this topic. I started some work in that area a few years ago and never finished it. I think the root cause of the issue got already pointed out in this discussion. The JVM (correctly) detects that the system is capable of IPv6 and hence opens new sockets with address family AF_INET6. This type of socket shall allow for communication in both domains, IPv6 and IPv4. To ensure the dual stack socket, we also set socket option IPV6_V6ONLY to '0' which should make sure it's not an IPv6 only socket. This is the way, the standard TCP/UDP socket communication works in the JDK, also on AIX. Now, for multicasting, the VM wants to set the multicast interface. At that point, the socket is not yet bound to a local address or has joined a multicast group which might restrict the address type. So, we need either setsockopt(IPV6_MULTICAST_IF) or setsockopt(IP_MULTICAST_IF) to work. The documentation cited by Volker (https://www.ibm.com/support/knowledgecenter/ssw_ibm_i_71/apis/ssocko.htm) is quite explicit in that IP_MULTICAST_IF is for AF_INET sockets and IPV6_MULTICAST_IF is for AF_INET6 type sockets. So I would expect, that IPV6_MULTICAST_IF works, even for an interface without configured IPv6 address. So, while this is nothing for the compiler folks, it is something for the AIX runtime/network people. Can you address that within IBM? Maybe the AIX experts have a suggestion if there's already a way to code around this. And if it's not possible to get this to work with the existing APIs, would it be possible for you to open a PMR with IBM or find any other means to get that fixed in the OS? Anyway, I think even if IBM can fix this in AIX, it'll be in future versions only. So I'll go ahead and create a patch for modifying the failing tests to be more tolerant to such type of system configurations on AIX. I will send an RFR mail soon. Best regards Christoph From: net-dev On Behalf Of Steve Groeger Sent: Montag, 14. Januar 2019 15:31 To: Volker Simonis Cc: ppc-aix-port-dev at openjdk.java.net; net-dev Subject: Re: 8207404: MulticastSocket tests failing on Aix Hi Volker, The reason the mcast_set_if_by_if_v4(env, this, fd, value); probably fails is that the socket that we are trying to set the IPPROTO_IP, IP_MULTICAST_IF options on has been created with the AF_INET6 family, and these options may not be valid. The socket is setup with the AF_INET6 family because ipv6_available() returns true, as the AIX system does support INET6/IPv6. It is just that the interface we are using doesnt have an INET6 address associated with it. I am checking with the AIX/C compiler team in IBM to see if this a bug or not. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges at uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: Volker Simonis > To: Steve Groeger > Cc: Chris Hegarty >, net-dev >, ppc-aix-port-dev at openjdk.java.net Date: 14/01/2019 14:11 Subject: Re: 8207404: MulticastSocket tests failing on Aix ________________________________ On Mon, Jan 14, 2019 at 2:19 PM Steve Groeger > wrote: > > Hi Chris / Volker, > > I had already tried doing the same as is done for Linux, ie calling this first > > mcast_set_if_by_if_v4(env, this, fd, value); > > This still fails for some reason with EADDRNOTAVAIL. Finding this out is probably the main challenge in order to solve this issue and one of the reason why we asked IBM for assistance :) I suppose there must be a possibility to set a socket option for an IPv4 socket on AIX even if IPv6 is enabled. Otherwise this is probably an AIX problem/bug which should be fixed there (where, again, we need assistance from IBM). The man-page (https://www.ibm.com/support/knowledgecenter/ssw_ibm_i_71/apis/ssocko.htm) mentions the following: IP_MULTICAST_IF: et interface over which outgoing multicast datagrams should be sent. This option is only supported for sockets with an address family of AF_INET and type of SOCK_DGRAM or SOCK_RAW. Maybe the interface is erroneously in the AF_INET6 family? The man-page only mentions the following for EADDRNOTAVAIL: EADDRNOTAVAIL: Address not available. For the IP_ADD_MEMBERSHIP or IP_DROP_MEMBERSHIP operations, this error code indicates that an incorrect address was specified for either the imr_multiaddr or imr_interface parameter value. > This error gets cleared by the > > if ((*env)->ExceptionCheck(env)){ > (*env)->ExceptionClear(env); > } > > as ipv6_available() still returns true, but we then still try and call > > mcast_set_if_by_if_v6(env, this, fd, value); > > which again fails with EADDRNOTAVAIL. So we have the same result. > > Thanks > Steve Groeger > IBM Runtime Technologies > Hursley, Winchester > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > Fax (44) 1962 816800 > Lotus Notes: Steve Groeger/UK/IBM > Internet: groeges at uk.ibm.com > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > > > From: Chris Hegarty > > To: Volker Simonis > > Cc: Steve Groeger >, ppc-aix-port-dev at openjdk.java.net, net-dev > > Date: 12/01/2019 14:21 > Subject: Re: 8207404: MulticastSocket tests failing on Aix > ________________________________ > > > > > > > On 11 Jan 2019, at 17:28, Volker Simonis > wrote: > > > > I think the difference is in setMulticastInterface() in > > PlainDatagramSocketImpl.c > > > > #ifdef __linux__ > > mcast_set_if_by_if_v4(env, this, fd, value); > > if (ipv6_available()) { > > if ((*env)->ExceptionCheck(env)){ > > (*env)->ExceptionClear(env); > > } > > mcast_set_if_by_if_v6(env, this, fd, value); > > } > > #else /* __linux__ not defined */ > > if (ipv6_available()) { > > mcast_set_if_by_if_v6(env, this, fd, value); > > } else { > > mcast_set_if_by_if_v4(env, this, fd, value); > > } > > #endif /* __linux__ */ > > > > We should probably follow the Linux way for AIX as well. > > I agree. > > -Chris. > > >> On Fri, Jan 11, 2019 at 5:29 PM Chris Hegarty > wrote: > >> > >> > >>> On 09/01/2019 15:20, Steve Groeger wrote: > >>> ... > >>> > >>> I think I have an Linux system setup with a simarly configured interface > >>> (system has IPv6 configured but interface > >>> has no IPv6/INET6 address configured) but the test works fine when run > >>> on that system. > >> > >> This is what I observe too. Confirmed by looking at the test > >> output in the jtr file. > >> > >>> This was why I was asking the question on whether this should work on > >>> AIX, or whether it should fail on Linux!!! > >> > >> I suspect that this is an issue with the native setsockopt > >> on AIX. That said, if it cannot be resolved on AIX, then > >> maybe the networking native code on AIX, should workaround > >> it. > >> > >> -Chris. > > > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From Alan.Bateman at oracle.com Tue Jan 15 15:43:24 2019 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 15 Jan 2019 15:43:24 +0000 Subject: RFR: 8214533 IBM-29626C is required for AIX default charset In-Reply-To: <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> Message-ID: <3eb1adab-7740-8f1b-a4d8-2796d91ee04d@oracle.com> On 15/01/2019 00:51, Ichiroh Takiguchi wrote: > Hello Alan. > > Could you review the fix again ? > > Bug:??? https://bugs.openjdk.java.net/browse/JDK-8214533 > Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ > > I added IBM29626C charset as standard way. > Please give any suggestion and question. This looks okay, assuming it's `hg copy` of EUR_JP.template to create IBM29626C.java.template rather than a `hg mv` (the webrev makes it look like a move/rename). -Alan From matthias.baesken at sap.com Wed Jan 16 09:26:09 2019 From: matthias.baesken at sap.com (Baesken, Matthias) Date: Wed, 16 Jan 2019 09:26:09 +0000 Subject: RFR [XS] 8217233: Update build settings for AIX/xlc Message-ID: Hello, please review this small fix . It adds stack protection compile flags for xlc/AIX . See : https://www.ibm.com/support/knowledgecenter/SSGH2K_12.1.0/com.ibm.xlc121.aix.doc/compiler_ref/opt_stackprotect.html "Provides protection against malicious code or programming errors that overwrite or corrupt the stack." The patch will set the stack protection flags . ( Similar changes have been done for Linux : 8199552: Update to build scripts https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/8b060cdf0251 Introduced stack protection compile flags for Linux/gcc ( -fstack-protector ) . ) Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8217233 http://cr.openjdk.java.net/~mbaesken/webrevs/8217233.0/ Thanks, Matthias -------------- next part -------------- An HTML attachment was scrubbed... URL: From GROEGES at uk.ibm.com Wed Jan 16 09:49:04 2019 From: GROEGES at uk.ibm.com (Steve Groeger) Date: Wed, 16 Jan 2019 09:49:04 +0000 Subject: RFR [XS] 8217233: Update build settings for AIX/xlc In-Reply-To: References: Message-ID: Hi Matthias, The change looks OK. The docs state: "This option is disabled by default because it can cause performance degradation." Do you know whether using this option actually causes any performance degradation on AIX? Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges at uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Baesken, Matthias" To: "'build-dev at openjdk.java.net'" , "ppc-aix-port-dev at openjdk.java.net" Date: 16/01/2019 09:26 Subject: RFR [XS] 8217233: Update build settings for AIX/xlc Sent by: "ppc-aix-port-dev" Hello, please review this small fix . It adds stack protection compile flags for xlc/AIX . See : https://www.ibm.com/support/knowledgecenter/SSGH2K_12.1.0/com.ibm.xlc121.aix.doc/compiler_ref/opt_stackprotect.html "Provides protection against malicious code or programming errors that overwrite or corrupt the stack." The patch will set the stack protection flags . ( Similar changes have been done for Linux : 8199552: Update to build scripts https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/8b060cdf0251 Introduced stack protection compile flags for Linux/gcc ( -fstack-protector ) . ) Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8217233 http://cr.openjdk.java.net/~mbaesken/webrevs/8217233.0/ Thanks, Matthias Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From matthias.baesken at sap.com Wed Jan 16 10:07:56 2019 From: matthias.baesken at sap.com (Baesken, Matthias) Date: Wed, 16 Jan 2019 10:07:56 +0000 Subject: RFR [XS] 8217233: Update build settings for AIX/xlc In-Reply-To: References: Message-ID: Hi Steve, from my experience the situation is similar to Linux (small performance change). Best regards, Matthias From: Steve Groeger Sent: Mittwoch, 16. Januar 2019 10:49 To: Baesken, Matthias Cc: 'build-dev at openjdk.java.net' ; ppc-aix-port-dev at openjdk.java.net; ppc-aix-port-dev Subject: Re: RFR [XS] 8217233: Update build settings for AIX/xlc Hi Matthias, The change looks OK. The docs state: "This option is disabled by default because it can cause performance degradation." Do you know whether using this option actually causes any performance degradation on AIX? Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges at uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Baesken, Matthias" > To: "'build-dev at openjdk.java.net'" >, "ppc-aix-port-dev at openjdk.java.net" > Date: 16/01/2019 09:26 Subject: RFR [XS] 8217233: Update build settings for AIX/xlc Sent by: "ppc-aix-port-dev" > ________________________________ Hello, please review this small fix . It adds stack protection compile flags for xlc/AIX . See : https://www.ibm.com/support/knowledgecenter/SSGH2K_12.1.0/com.ibm.xlc121.aix.doc/compiler_ref/opt_stackprotect.html "Provides protection against malicious code or programming errors that overwrite or corrupt the stack." The patch will set the stack protection flags . ( Similar changes have been done for Linux : 8199552: Update to build scripts https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/8b060cdf0251 Introduced stack protection compile flags for Linux/gcc ( -fstack-protector ) . ) Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8217233 http://cr.openjdk.java.net/~mbaesken/webrevs/8217233.0/ Thanks, Matthias Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From matthias.baesken at sap.com Thu Jan 17 06:41:09 2019 From: matthias.baesken at sap.com (Baesken, Matthias) Date: Thu, 17 Jan 2019 06:41:09 +0000 Subject: RFR [XS] 8217233: Update build settings for AIX/xlc In-Reply-To: References: Message-ID: May I have a second review please ? Best regards, Matthias From: Baesken, Matthias Sent: Mittwoch, 16. Januar 2019 11:08 To: 'Steve Groeger' Cc: 'build-dev at openjdk.java.net' ; ppc-aix-port-dev at openjdk.java.net; ppc-aix-port-dev Subject: RE: RFR [XS] 8217233: Update build settings for AIX/xlc Hi Steve, from my experience the situation is similar to Linux (small performance change). Best regards, Matthias From: Steve Groeger > Sent: Mittwoch, 16. Januar 2019 10:49 To: Baesken, Matthias > Cc: 'build-dev at openjdk.java.net' >; ppc-aix-port-dev at openjdk.java.net; ppc-aix-port-dev > Subject: Re: RFR [XS] 8217233: Update build settings for AIX/xlc Hi Matthias, The change looks OK. The docs state: "This option is disabled by default because it can cause performance degradation." Do you know whether using this option actually causes any performance degradation on AIX? Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges at uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Baesken, Matthias" > To: "'build-dev at openjdk.java.net'" >, "ppc-aix-port-dev at openjdk.java.net" > Date: 16/01/2019 09:26 Subject: RFR [XS] 8217233: Update build settings for AIX/xlc Sent by: "ppc-aix-port-dev" > ________________________________ Hello, please review this small fix . It adds stack protection compile flags for xlc/AIX . See : https://www.ibm.com/support/knowledgecenter/SSGH2K_12.1.0/com.ibm.xlc121.aix.doc/compiler_ref/opt_stackprotect.html "Provides protection against malicious code or programming errors that overwrite or corrupt the stack." The patch will set the stack protection flags . ( Similar changes have been done for Linux : 8199552: Update to build scripts https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/8b060cdf0251 Introduced stack protection compile flags for Linux/gcc ( -fstack-protector ) . ) Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8217233 http://cr.openjdk.java.net/~mbaesken/webrevs/8217233.0/ Thanks, Matthias Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From christoph.langer at sap.com Thu Jan 17 08:15:27 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 17 Jan 2019 08:15:27 +0000 Subject: RFR [XS] 8217233: Update build settings for AIX/xlc In-Reply-To: References: Message-ID: <0cdba8af728d484db51a56dcaa8be487@sap.com> Hi Matthias, looks good to me. Best regards Christoph > -----Original Message----- > From: build-dev On Behalf Of > Baesken, Matthias > Sent: Donnerstag, 17. Januar 2019 07:41 > To: Steve Groeger > Cc: 'build-dev at openjdk.java.net' ; ppc-aix- > port-dev at openjdk.java.net; ppc-aix-port-dev bounces at openjdk.java.net> > Subject: [CAUTION] RE: RFR [XS] 8217233: Update build settings for AIX/xlc > > May I have a second review please ? > > Best regards, Matthias > > > From: Baesken, Matthias > Sent: Mittwoch, 16. Januar 2019 11:08 > To: 'Steve Groeger' > Cc: 'build-dev at openjdk.java.net' ; ppc-aix- > port-dev at openjdk.java.net; ppc-aix-port-dev bounces at openjdk.java.net> > Subject: RE: RFR [XS] 8217233: Update build settings for AIX/xlc > > Hi Steve, > from my experience the situation is similar to Linux (small performance > change). > > Best regards, Matthias > > > From: Steve Groeger > > > Sent: Mittwoch, 16. Januar 2019 10:49 > To: Baesken, Matthias > > > Cc: 'build-dev at openjdk.java.net' dev at openjdk.java.net>; ppc-aix-port- > dev at openjdk.java.net; ppc- > aix-port-dev port-dev-bounces at openjdk.java.net>> > Subject: Re: RFR [XS] 8217233: Update build settings for AIX/xlc > > Hi Matthias, > > The change looks OK. > > The docs state: "This option is disabled by default because it can cause > performance degradation." > Do you know whether using this option actually causes any performance > degradation on AIX? > > Thanks > Steve Groeger > IBM Runtime Technologies > Hursley, Winchester > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > Fax (44) 1962 816800 > Lotus Notes: Steve Groeger/UK/IBM > Internet: groeges at uk.ibm.com > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > 3AU > > > > From: "Baesken, Matthias" > > > To: "'build-dev at openjdk.java.net'" dev at openjdk.java.net>, "ppc-aix- > port-dev at openjdk.java.net" > dev at openjdk.java.net>> > Date: 16/01/2019 09:26 > Subject: RFR [XS] 8217233: Update build settings for AIX/xlc > Sent by: "ppc-aix-port-dev" bounces at openjdk.java.net bounces at openjdk.java.net>> > ________________________________ > > > > Hello, please review this small fix . > > It adds stack protection compile flags for xlc/AIX . > > See : > > https://www.ibm.com/support/knowledgecenter/SSGH2K_12.1.0/com.ibm. > xlc121.aix.doc/compiler_ref/opt_stackprotect.html > > > "Provides protection against malicious code or programming errors that > overwrite or corrupt the stack." > The patch will set the stack protection flags . > > > ( Similar changes have been done for Linux : 8199552: Update to build > scripts > https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/8b060cdf0251 > Introduced stack protection compile flags for Linux/gcc ( -fstack-protector ) . > ) > > > Bug/webrev : > > https://bugs.openjdk.java.net/browse/JDK-8217233 > > http://cr.openjdk.java.net/~mbaesken/webrevs/8217233.0/ > > > Thanks, Matthias > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > 3AU From christoph.langer at sap.com Thu Jan 17 10:55:06 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 17 Jan 2019 10:55:06 +0000 Subject: RFR: 8207404: MulticastSocket tests failing on AIX Message-ID: <672942772ce64693ac5cb584d249d8c7@sap.com> Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8207404 First of all, I "modernized" the testcases test/jdk/java/net/MulticastSocket/SetGetNetworkInterfaceTest.java and test/jdk/java/net/MulticastSocket/Test.java to make use of test/lib/jdk/test/lib/NetworkConfiguration.java which probes for the network configuration and returns lists of local interfaces or addresses for certain use cases. In NetworkConfiguration.java I made some cleanups and enhancements which will hopefully find some appreciation. These 3 tests will now also be executed with and without -Djava.net.preferIPv4Stack=true. The actual fixes are: test/jdk/java/net/MulticastSocket/JoinLeave.java: test/jdk/java/net/MulticastSocket/SetGetNetworkInterfaceTest.java: -> NetworkConfiguration.ip4MulticastInterfaces() will now, on AIX, in a scenario where IPv6 is available, filter out interfaces that only have IPv4 addresses (line 121ff in test/lib/jdk/test/lib/NetworkConfiguration.java) test/jdk/java/net/MulticastSocket/Test.java: -> The test for node local multicasting is only executed, when NetworkConfiguration::hasTestableIPv6Address is true. For AIX it'll be the case only if a "real" IPv6 address exists (on some interface) which is not loopback or wildcard. This is how it has already been for Solaris. For other operating systems, any IPv6 address on any interface is sufficient for running the test. The coding for the AIX/Solaris check can be found in line 66ff of test/lib/jdk/test/lib/NetworkConfiguration.java. As it is a test only fix, I request to do it in JDK12. Thanks & Best regards Christoph -------------- next part -------------- An HTML attachment was scrubbed... URL: From chris.hegarty at oracle.com Thu Jan 17 11:27:15 2019 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 17 Jan 2019 11:27:15 +0000 Subject: RFR: 8207404: MulticastSocket tests failing on AIX In-Reply-To: <672942772ce64693ac5cb584d249d8c7@sap.com> References: <672942772ce64693ac5cb584d249d8c7@sap.com> Message-ID: > On 17 Jan 2019, at 10:55, Langer, Christoph wrote: > > Hi, > > here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ). -Chris. -------------- next part -------------- An HTML attachment was scrubbed... URL: From christoph.langer at sap.com Thu Jan 17 11:33:15 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 17 Jan 2019 11:33:15 +0000 Subject: RFR: 8207404: MulticastSocket tests failing on AIX In-Reply-To: References: <672942772ce64693ac5cb584d249d8c7@sap.com> Message-ID: <9437af146b67440fbc6c1453b9b80711@sap.com> Hi Chris, for me it was the other way round... I did not see immediately where the methods came from and had to do some navigation. But I'm happy to revert this. As I had only worked with AIX so far, I'll put the test update into our test system to see whether there'll be issues on other platforms. I'll send an updated webrev tomorrow. Best regards Christoph From: Chris Hegarty Sent: Donnerstag, 17. Januar 2019 12:27 To: Langer, Christoph Cc: net-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX On 17 Jan 2019, at 10:55, Langer, Christoph > wrote: Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ). -Chris. -------------- next part -------------- An HTML attachment was scrubbed... URL: From GROEGES at uk.ibm.com Thu Jan 17 13:32:24 2019 From: GROEGES at uk.ibm.com (Steve Groeger) Date: Thu, 17 Jan 2019 13:32:24 +0000 Subject: RFR: 8207404: MulticastSocket tests failing on AIX In-Reply-To: <9437af146b67440fbc6c1453b9b80711@sap.com> References: <672942772ce64693ac5cb584d249d8c7@sap.com> <9437af146b67440fbc6c1453b9b80711@sap.com> Message-ID: Hi Christoph, Have reviewed you changes and they look OK. I have no preference with regards the static imports, but my view is keep the changes as simple as possible and to not make changes just for the sake of it. Have tested your patches on a couple of AIX systems, both with IPv6 enabled but one didn't have an IPv6 address configured and the other did. All the jdk/java/net/MulticastSocket tests passed. So the change also looks functionally OK. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges at uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Langer, Christoph" To: Chris Hegarty Cc: "ppc-aix-port-dev at openjdk.java.net" , "net-dev at openjdk.java.net" Date: 17/01/2019 11:34 Subject: RE: RFR: 8207404: MulticastSocket tests failing on AIX Sent by: "net-dev" Hi Chris, for me it was the other way round? I did not see immediately where the methods came from and had to do some navigation. But I?m happy to revert this. As I had only worked with AIX so far, I?ll put the test update into our test system to see whether there?ll be issues on other platforms. I?ll send an updated webrev tomorrow. Best regards Christoph From: Chris Hegarty Sent: Donnerstag, 17. Januar 2019 12:27 To: Langer, Christoph Cc: net-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX On 17 Jan 2019, at 10:55, Langer, Christoph wrote: Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ). -Chris. Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From christoph.langer at sap.com Thu Jan 17 14:28:10 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 17 Jan 2019 14:28:10 +0000 Subject: RFR: 8207404: MulticastSocket tests failing on AIX In-Reply-To: References: <672942772ce64693ac5cb584d249d8c7@sap.com> <9437af146b67440fbc6c1453b9b80711@sap.com> Message-ID: <4ee0ceba10c542a48e94002ea1ae2abe@sap.com> Hi Steve, thanks for the review and the additional testing. I?ll post an update tomorrow after I have results from our test system which will test all platforms that we have an eye on. I?ll roll back the change to the import statement and will also add an update to the problem list in order to make the tests run by default on AIX. You could do me a favor though. There?s not only the issue with the IPV6_MULTICAST_IF setsockopt operation but there?s also the other where node local IPv6 multicast does not work when only the loopback interface is configured for IPv6 (as show in Test.java). Could you check this also with the AIX team whether they consider this a bug or working as expected? Thanks & Best regards Christoph From: Steve Groeger Sent: Donnerstag, 17. Januar 2019 14:32 To: Langer, Christoph Cc: Chris Hegarty ; net-dev at openjdk.java.net; net-dev ; ppc-aix-port-dev at openjdk.java.net Subject: RE: RFR: 8207404: MulticastSocket tests failing on AIX Hi Christoph, Have reviewed you changes and they look OK. I have no preference with regards the static imports, but my view is keep the changes as simple as possible and to not make changes just for the sake of it. Have tested your patches on a couple of AIX systems, both with IPv6 enabled but one didn't have an IPv6 address configured and the other did. All the jdk/java/net/MulticastSocket tests passed. So the change also looks functionally OK. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges at uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Langer, Christoph" > To: Chris Hegarty > Cc: "ppc-aix-port-dev at openjdk.java.net" >, "net-dev at openjdk.java.net" > Date: 17/01/2019 11:34 Subject: RE: RFR: 8207404: MulticastSocket tests failing on AIX Sent by: "net-dev" > ________________________________ Hi Chris, for me it was the other way round? I did not see immediately where the methods came from and had to do some navigation. But I?m happy to revert this. As I had only worked with AIX so far, I?ll put the test update into our test system to see whether there?ll be issues on other platforms. I?ll send an updated webrev tomorrow. Best regards Christoph From: Chris Hegarty > Sent: Donnerstag, 17. Januar 2019 12:27 To: Langer, Christoph > Cc: net-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX On 17 Jan 2019, at 10:55, Langer, Christoph > wrote: Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ). -Chris. Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From christoph.langer at sap.com Fri Jan 18 08:54:33 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 18 Jan 2019 08:54:33 +0000 Subject: RFR: 8207404: MulticastSocket tests failing on AIX In-Reply-To: References: <672942772ce64693ac5cb584d249d8c7@sap.com> Message-ID: Hi, here is the updated webrev with modifications to the problem list and reverting the static imports: http://cr.openjdk.java.net/~clanger/webrevs/8207404.1/ It went fine through our test system so I think it's good now. Please review. Thanks Christoph From: Chris Hegarty Sent: Donnerstag, 17. Januar 2019 12:27 To: Langer, Christoph Cc: net-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX On 17 Jan 2019, at 10:55, Langer, Christoph > wrote: Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ). -Chris. -------------- next part -------------- An HTML attachment was scrubbed... URL: From GROEGES at uk.ibm.com Fri Jan 18 12:58:09 2019 From: GROEGES at uk.ibm.com (Steve Groeger) Date: Fri, 18 Jan 2019 12:58:09 +0000 Subject: RFR: 8207404: MulticastSocket tests failing on AIX In-Reply-To: References: <672942772ce64693ac5cb584d249d8c7@sap.com> Message-ID: Hi Christoph, Had a look at the latest webrev and everything looks OK to me. Have also re-tested on my AIX systems and all tests oass OK. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges at uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Langer, Christoph" To: Chris Hegarty , Steve Groeger Cc: "net-dev at openjdk.java.net" , "ppc-aix-port-dev at openjdk.java.net" Date: 18/01/2019 08:54 Subject: RE: RFR: 8207404: MulticastSocket tests failing on AIX Hi, here is the updated webrev with modifications to the problem list and reverting the static imports: http://cr.openjdk.java.net/~clanger/webrevs/8207404.1/ It went fine through our test system so I think it?s good now. Please review. Thanks Christoph From: Chris Hegarty Sent: Donnerstag, 17. Januar 2019 12:27 To: Langer, Christoph Cc: net-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX On 17 Jan 2019, at 10:55, Langer, Christoph wrote: Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ). -Chris. Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU -------------- next part -------------- An HTML attachment was scrubbed... URL: From chris.hegarty at oracle.com Fri Jan 18 14:14:47 2019 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 18 Jan 2019 14:14:47 +0000 Subject: RFR: 8207404: MulticastSocket tests failing on AIX In-Reply-To: References: <672942772ce64693ac5cb584d249d8c7@sap.com> Message-ID: On 18/01/2019 08:54, Langer, Christoph wrote: > Hi, > > here is the updated webrev with modifications to the problem list and > reverting the static imports: > _http://cr.openjdk.java.net/~clanger/webrevs/8207404.1/__ I think this is ok. -Chris. From christoph.langer at sap.com Mon Jan 21 07:04:03 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 21 Jan 2019 07:04:03 +0000 Subject: RFR: 8207404: MulticastSocket tests failing on AIX In-Reply-To: References: <672942772ce64693ac5cb584d249d8c7@sap.com> Message-ID: Thanks, Steve and Chris for reviewing. Pushed to jdk12. > -----Original Message----- > From: Chris Hegarty > Sent: Freitag, 18. Januar 2019 15:15 > To: Langer, Christoph ; Steve Groeger > > Cc: net-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net > Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX > > > On 18/01/2019 08:54, Langer, Christoph wrote: > > Hi, > > > > here is the updated webrev with modifications to the problem list and > > reverting the static imports: > > _http://cr.openjdk.java.net/~clanger/webrevs/8207404.1/__ > I think this is ok. > > -Chris. From matthias.baesken at sap.com Mon Jan 28 08:03:36 2019 From: matthias.baesken at sap.com (Baesken, Matthias) Date: Mon, 28 Jan 2019 08:03:36 +0000 Subject: RFR: 8214533 IBM-29626C is required for AIX default charset In-Reply-To: <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> Message-ID: Hello, seems 8214533 got pushed recently into jdk/jdk. Now we see build errors on AIX , are they related to this change ? /nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63: error: Decoder is not public in EUC_JP; cannot be accessed from outside package private static class Decoder extends EUC_JP.Decoder { ^ /nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69: error: Encoder is not public in EUC_JP; cannot be accessed from outside package private static class Encoder extends EUC_JP.Encoder { ^ /nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65: error: Decoder is not public in EUC_JP; cannot be accessed from outside package private static class Decoder extends EUC_JP.Decoder { ^ /nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85: error: Encoder is not public in EUC_JP; cannot be accessed from outside package private static class Encoder extends EUC_JP.Encoder { Best regards, Matthias > -----Original Message----- > From: ppc-aix-port-dev On > Behalf Of Ichiroh Takiguchi > Sent: Dienstag, 15. Januar 2019 01:51 > To: Alan Bateman > Cc: build-dev ; ppc-aix-port-dev port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net > Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default charset > > Hello Alan. > > Could you review the fix again ? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 > Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ > > I added IBM29626C charset as standard way. > Please give any suggestion and question. > > Thanks, > Ichiroh Takiguchi > IBM Japan, Ltd. > > On 2018-12-14 18:58, Ichiroh Takiguchi wrote: > > Hello Alan. > > > > I opened JDK-8215333 for Charset filtering issue [1]. > > I cannot wait until JDK-8215333 is closed. > > Is it possible to put IBM-29626C charset with standard way ? > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 > > > > Thanks, > > Ichiroh Takiguchi > > > > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: > >> Hello Roger, Magnus and Alan. > >> I may need to put alias information into charsets file. > >> stdcs-xxx cannot handle this information... > >> > >> Still AIX needs IBM-29626C charset for default encoding... > >> > >> I appreciate if you give me further suggestions. > >> > >> Thanks, > >> Ichiroh Takiguchi > >> > >> On 2018-12-10 20:50, Alan Bateman wrote: > >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: > >>>> On 2018-12-07 21:20, Roger Riggs wrote: > >>>>> Hi, > >>>>> > >>>>> It is a nice feature that charsets are selected at build time using > >>>>> the stdcs-xxx files. > >>>>> This change breaks that pattern and embeds os specific information > >>>>> in more than one place. > >>>>> That does not seem like an improvement.? Is there any alternative? > >>>> I agree. Why is it not enough just to add it to stdcs-aix? > >>> My reading of the patch is that the "os" key is to avoid generating > >>> it > >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on > >>> non-AIX platforms. The general direction is welcome but I think > >>> further work and discussion will be needed to get the right set of > >>> changes to support filtering in the build. It can probably be > >>> separated from the changes to add IBM-29626C to AIX's java.base. > >>> > >>> -Alan From takiguc at linux.vnet.ibm.com Mon Jan 28 13:12:40 2019 From: takiguc at linux.vnet.ibm.com (Ichiroh Takiguchi) Date: Mon, 28 Jan 2019 22:12:40 +0900 Subject: RFR: 8214533 IBM-29626C is required for AIX default charset In-Reply-To: References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> Message-ID: Hello. I'm very sorry. It's my fault. EUC_JP class was moved to java.base module. (sun.nio.cs.EUC_JP). make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and EUC_JP_Open. Could you suggest me how I should provide new webrev files ? Thanks, Ichiroh Takiguchi On 2019-01-28 17:03, Baesken, Matthias wrote: > Hello, seems 8214533 got pushed recently into jdk/jdk. Now > we see build errors on AIX , are they related to this change ? > > > /nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63: > error: Decoder is not public in EUC_JP; cannot be accessed from > outside package > private static class Decoder extends EUC_JP.Decoder { > ^ > /nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69: > error: Encoder is not public in EUC_JP; cannot be accessed from > outside package > private static class Encoder extends EUC_JP.Encoder { > ^ > /nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65: > error: Decoder is not public in EUC_JP; cannot be accessed from > outside package > private static class Decoder extends EUC_JP.Decoder { > ^ > /nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85: > error: Encoder is not public in EUC_JP; cannot be accessed from > outside package > private static class Encoder extends EUC_JP.Encoder { > > Best regards, Matthias > > > >> -----Original Message----- >> From: ppc-aix-port-dev On >> Behalf Of Ichiroh Takiguchi >> Sent: Dienstag, 15. Januar 2019 01:51 >> To: Alan Bateman >> Cc: build-dev ; ppc-aix-port-dev > port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net >> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default >> charset >> >> Hello Alan. >> >> Could you review the fix again ? >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 >> Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ >> >> I added IBM29626C charset as standard way. >> Please give any suggestion and question. >> >> Thanks, >> Ichiroh Takiguchi >> IBM Japan, Ltd. >> >> On 2018-12-14 18:58, Ichiroh Takiguchi wrote: >> > Hello Alan. >> > >> > I opened JDK-8215333 for Charset filtering issue [1]. >> > I cannot wait until JDK-8215333 is closed. >> > Is it possible to put IBM-29626C charset with standard way ? >> > >> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 >> > >> > Thanks, >> > Ichiroh Takiguchi >> > >> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: >> >> Hello Roger, Magnus and Alan. >> >> I may need to put alias information into charsets file. >> >> stdcs-xxx cannot handle this information... >> >> >> >> Still AIX needs IBM-29626C charset for default encoding... >> >> >> >> I appreciate if you give me further suggestions. >> >> >> >> Thanks, >> >> Ichiroh Takiguchi >> >> >> >> On 2018-12-10 20:50, Alan Bateman wrote: >> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: >> >>>> On 2018-12-07 21:20, Roger Riggs wrote: >> >>>>> Hi, >> >>>>> >> >>>>> It is a nice feature that charsets are selected at build time using >> >>>>> the stdcs-xxx files. >> >>>>> This change breaks that pattern and embeds os specific information >> >>>>> in more than one place. >> >>>>> That does not seem like an improvement.? Is there any alternative? >> >>>> I agree. Why is it not enough just to add it to stdcs-aix? >> >>> My reading of the patch is that the "os" key is to avoid generating >> >>> it >> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on >> >>> non-AIX platforms. The general direction is welcome but I think >> >>> further work and discussion will be needed to get the right set of >> >>> changes to support filtering in the build. It can probably be >> >>> separated from the changes to add IBM-29626C to AIX's java.base. >> >>> >> >>> -Alan From goetz.lindenmaier at sap.com Mon Jan 28 13:11:27 2019 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Mon, 28 Jan 2019 13:11:27 +0000 Subject: RFR: 8214533 IBM-29626C is required for AIX default charset In-Reply-To: References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> Message-ID: <8c05b5147fa7489282d7cae04e801702@sap.com> Hi Ichiroh, just open a bug, like "Fix aix build after 8214533" and post a RFR for it. I assume the fix is quite trivial so we can review it quick. Best regards, Goetz. > -----Original Message----- > From: ppc-aix-port-dev On > Behalf Of Ichiroh Takiguchi > Sent: Montag, 28. Januar 2019 14:13 > To: Baesken, Matthias > Cc: build-dev ; ppc-aix-port-dev dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Alan Bateman > > Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default charset > > Hello. > > I'm very sorry. It's my fault. > EUC_JP class was moved to java.base module. > (sun.nio.cs.EUC_JP). > > make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and > EUC_JP_Open. > > Could you suggest me how I should provide new webrev files ? > > Thanks, > Ichiroh Takiguchi > > > On 2019-01-28 17:03, Baesken, Matthias wrote: > > Hello, seems 8214533 got pushed recently into jdk/jdk. Now > > we see build errors on AIX , are they related to this change ? > > > > > > /nb/rs6000_64/nightly/output-jdk- > test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63: > > error: Decoder is not public in EUC_JP; cannot be accessed from > > outside package > > private static class Decoder extends EUC_JP.Decoder { > > ^ > > /nb/rs6000_64/nightly/output-jdk- > test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69: > > error: Encoder is not public in EUC_JP; cannot be accessed from > > outside package > > private static class Encoder extends EUC_JP.Encoder { > > ^ > > /nb/rs6000_64/nightly/output-jdk- > test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65: > > error: Decoder is not public in EUC_JP; cannot be accessed from > > outside package > > private static class Decoder extends EUC_JP.Decoder { > > ^ > > /nb/rs6000_64/nightly/output-jdk- > test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85: > > error: Encoder is not public in EUC_JP; cannot be accessed from > > outside package > > private static class Encoder extends EUC_JP.Encoder { > > > > Best regards, Matthias > > > > > > > >> -----Original Message----- > >> From: ppc-aix-port-dev On > >> Behalf Of Ichiroh Takiguchi > >> Sent: Dienstag, 15. Januar 2019 01:51 > >> To: Alan Bateman > >> Cc: build-dev ; ppc-aix-port-dev >> port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net > >> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default > >> charset > >> > >> Hello Alan. > >> > >> Could you review the fix again ? > >> > >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 > >> Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ > >> > >> I added IBM29626C charset as standard way. > >> Please give any suggestion and question. > >> > >> Thanks, > >> Ichiroh Takiguchi > >> IBM Japan, Ltd. > >> > >> On 2018-12-14 18:58, Ichiroh Takiguchi wrote: > >> > Hello Alan. > >> > > >> > I opened JDK-8215333 for Charset filtering issue [1]. > >> > I cannot wait until JDK-8215333 is closed. > >> > Is it possible to put IBM-29626C charset with standard way ? > >> > > >> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 > >> > > >> > Thanks, > >> > Ichiroh Takiguchi > >> > > >> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: > >> >> Hello Roger, Magnus and Alan. > >> >> I may need to put alias information into charsets file. > >> >> stdcs-xxx cannot handle this information... > >> >> > >> >> Still AIX needs IBM-29626C charset for default encoding... > >> >> > >> >> I appreciate if you give me further suggestions. > >> >> > >> >> Thanks, > >> >> Ichiroh Takiguchi > >> >> > >> >> On 2018-12-10 20:50, Alan Bateman wrote: > >> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: > >> >>>> On 2018-12-07 21:20, Roger Riggs wrote: > >> >>>>> Hi, > >> >>>>> > >> >>>>> It is a nice feature that charsets are selected at build time using > >> >>>>> the stdcs-xxx files. > >> >>>>> This change breaks that pattern and embeds os specific information > >> >>>>> in more than one place. > >> >>>>> That does not seem like an improvement.? Is there any alternative? > >> >>>> I agree. Why is it not enough just to add it to stdcs-aix? > >> >>> My reading of the patch is that the "os" key is to avoid generating > >> >>> it > >> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on > >> >>> non-AIX platforms. The general direction is welcome but I think > >> >>> further work and discussion will be needed to get the right set of > >> >>> changes to support filtering in the build. It can probably be > >> >>> separated from the changes to add IBM-29626C to AIX's java.base. > >> >>> > >> >>> -Alan From takiguc at linux.vnet.ibm.com Mon Jan 28 13:49:34 2019 From: takiguc at linux.vnet.ibm.com (Ichiroh Takiguchi) Date: Mon, 28 Jan 2019 22:49:34 +0900 Subject: RFR: 8214533 IBM-29626C is required for AIX default charset In-Reply-To: <8c05b5147fa7489282d7cae04e801702@sap.com> References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> <8c05b5147fa7489282d7cae04e801702@sap.com> Message-ID: <71a838ee68f575ee384bdc833ab820db@linux.vnet.ibm.com> Hello Goetz. Thank you for your suggestion. I just open JDK-8217880 [1]. I just restart clean build. I'll post new fix including testcase for EUC_JP_LINUX and EUC_JP_Open. [1] https://bugs.openjdk.java.net/browse/JDK-8217880 Thanks, Ichiroh Takiguchi On 2019-01-28 22:11, Lindenmaier, Goetz wrote: > Hi Ichiroh, > > just open a bug, like "Fix aix build after 8214533" and post a RFR for > it. > I assume the fix is quite trivial so we can review it quick. > > Best regards, > Goetz. > >> -----Original Message----- >> From: ppc-aix-port-dev On >> Behalf Of Ichiroh Takiguchi >> Sent: Montag, 28. Januar 2019 14:13 >> To: Baesken, Matthias >> Cc: build-dev ; ppc-aix-port-dev >> > dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Alan Bateman >> >> Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default >> charset >> >> Hello. >> >> I'm very sorry. It's my fault. >> EUC_JP class was moved to java.base module. >> (sun.nio.cs.EUC_JP). >> >> make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and >> EUC_JP_Open. >> >> Could you suggest me how I should provide new webrev files ? >> >> Thanks, >> Ichiroh Takiguchi >> >> >> On 2019-01-28 17:03, Baesken, Matthias wrote: >> > Hello, seems 8214533 got pushed recently into jdk/jdk. Now >> > we see build errors on AIX , are they related to this change ? >> > >> > >> > /nb/rs6000_64/nightly/output-jdk- >> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63: >> > error: Decoder is not public in EUC_JP; cannot be accessed from >> > outside package >> > private static class Decoder extends EUC_JP.Decoder { >> > ^ >> > /nb/rs6000_64/nightly/output-jdk- >> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69: >> > error: Encoder is not public in EUC_JP; cannot be accessed from >> > outside package >> > private static class Encoder extends EUC_JP.Encoder { >> > ^ >> > /nb/rs6000_64/nightly/output-jdk- >> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65: >> > error: Decoder is not public in EUC_JP; cannot be accessed from >> > outside package >> > private static class Decoder extends EUC_JP.Decoder { >> > ^ >> > /nb/rs6000_64/nightly/output-jdk- >> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85: >> > error: Encoder is not public in EUC_JP; cannot be accessed from >> > outside package >> > private static class Encoder extends EUC_JP.Encoder { >> > >> > Best regards, Matthias >> > >> > >> > >> >> -----Original Message----- >> >> From: ppc-aix-port-dev On >> >> Behalf Of Ichiroh Takiguchi >> >> Sent: Dienstag, 15. Januar 2019 01:51 >> >> To: Alan Bateman >> >> Cc: build-dev ; ppc-aix-port-dev > >> port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net >> >> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default >> >> charset >> >> >> >> Hello Alan. >> >> >> >> Could you review the fix again ? >> >> >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 >> >> Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ >> >> >> >> I added IBM29626C charset as standard way. >> >> Please give any suggestion and question. >> >> >> >> Thanks, >> >> Ichiroh Takiguchi >> >> IBM Japan, Ltd. >> >> >> >> On 2018-12-14 18:58, Ichiroh Takiguchi wrote: >> >> > Hello Alan. >> >> > >> >> > I opened JDK-8215333 for Charset filtering issue [1]. >> >> > I cannot wait until JDK-8215333 is closed. >> >> > Is it possible to put IBM-29626C charset with standard way ? >> >> > >> >> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 >> >> > >> >> > Thanks, >> >> > Ichiroh Takiguchi >> >> > >> >> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: >> >> >> Hello Roger, Magnus and Alan. >> >> >> I may need to put alias information into charsets file. >> >> >> stdcs-xxx cannot handle this information... >> >> >> >> >> >> Still AIX needs IBM-29626C charset for default encoding... >> >> >> >> >> >> I appreciate if you give me further suggestions. >> >> >> >> >> >> Thanks, >> >> >> Ichiroh Takiguchi >> >> >> >> >> >> On 2018-12-10 20:50, Alan Bateman wrote: >> >> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: >> >> >>>> On 2018-12-07 21:20, Roger Riggs wrote: >> >> >>>>> Hi, >> >> >>>>> >> >> >>>>> It is a nice feature that charsets are selected at build time using >> >> >>>>> the stdcs-xxx files. >> >> >>>>> This change breaks that pattern and embeds os specific information >> >> >>>>> in more than one place. >> >> >>>>> That does not seem like an improvement.? Is there any alternative? >> >> >>>> I agree. Why is it not enough just to add it to stdcs-aix? >> >> >>> My reading of the patch is that the "os" key is to avoid generating >> >> >>> it >> >> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on >> >> >>> non-AIX platforms. The general direction is welcome but I think >> >> >>> further work and discussion will be needed to get the right set of >> >> >>> changes to support filtering in the build. It can probably be >> >> >>> separated from the changes to add IBM-29626C to AIX's java.base. >> >> >>> >> >> >>> -Alan From takiguc at linux.vnet.ibm.com Tue Jan 29 01:21:12 2019 From: takiguc at linux.vnet.ibm.com (Ichiroh Takiguchi) Date: Tue, 29 Jan 2019 10:21:12 +0900 Subject: RFR: JDK-8217880 AIX build issue about JDK-8214533 In-Reply-To: <71a838ee68f575ee384bdc833ab820db@linux.vnet.ibm.com> References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> <8c05b5147fa7489282d7cae04e801702@sap.com> <71a838ee68f575ee384bdc833ab820db@linux.vnet.ibm.com> Message-ID: <2360ba8a6e5ce7bf580beafb377af7c4@linux.vnet.ibm.com> Hello. Sorry about build issue for JDK-8214533. EUC_JP was extra entry on make/data/charsetmapping/stdcs-aix. Bug: https://bugs.openjdk.java.net/browse/JDK-8217880 Change: https://cr.openjdk.java.net/~itakiguchi/8217880/webrev.00/ Could you review the fix ? Thanks, Ichiroh Takiguchi IBM Japan, Ltd. On 2019-01-28 22:49, Ichiroh Takiguchi wrote: > Hello Goetz. > > Thank you for your suggestion. > I just open JDK-8217880 [1]. > > I just restart clean build. > > I'll post new fix including testcase for EUC_JP_LINUX and EUC_JP_Open. > > [1] https://bugs.openjdk.java.net/browse/JDK-8217880 > > Thanks, > Ichiroh Takiguchi > > On 2019-01-28 22:11, Lindenmaier, Goetz wrote: >> Hi Ichiroh, >> >> just open a bug, like "Fix aix build after 8214533" and post a RFR for >> it. >> I assume the fix is quite trivial so we can review it quick. >> >> Best regards, >> Goetz. >> >>> -----Original Message----- >>> From: ppc-aix-port-dev On >>> Behalf Of Ichiroh Takiguchi >>> Sent: Montag, 28. Januar 2019 14:13 >>> To: Baesken, Matthias >>> Cc: build-dev ; ppc-aix-port-dev >>> >> dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Alan Bateman >>> >>> Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default >>> charset >>> >>> Hello. >>> >>> I'm very sorry. It's my fault. >>> EUC_JP class was moved to java.base module. >>> (sun.nio.cs.EUC_JP). >>> >>> make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and >>> EUC_JP_Open. >>> >>> Could you suggest me how I should provide new webrev files ? >>> >>> Thanks, >>> Ichiroh Takiguchi >>> >>> >>> On 2019-01-28 17:03, Baesken, Matthias wrote: >>> > Hello, seems 8214533 got pushed recently into jdk/jdk. Now >>> > we see build errors on AIX , are they related to this change ? >>> > >>> > >>> > /nb/rs6000_64/nightly/output-jdk- >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63: >>> > error: Decoder is not public in EUC_JP; cannot be accessed from >>> > outside package >>> > private static class Decoder extends EUC_JP.Decoder { >>> > ^ >>> > /nb/rs6000_64/nightly/output-jdk- >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69: >>> > error: Encoder is not public in EUC_JP; cannot be accessed from >>> > outside package >>> > private static class Encoder extends EUC_JP.Encoder { >>> > ^ >>> > /nb/rs6000_64/nightly/output-jdk- >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65: >>> > error: Decoder is not public in EUC_JP; cannot be accessed from >>> > outside package >>> > private static class Decoder extends EUC_JP.Decoder { >>> > ^ >>> > /nb/rs6000_64/nightly/output-jdk- >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85: >>> > error: Encoder is not public in EUC_JP; cannot be accessed from >>> > outside package >>> > private static class Encoder extends EUC_JP.Encoder { >>> > >>> > Best regards, Matthias >>> > >>> > >>> > >>> >> -----Original Message----- >>> >> From: ppc-aix-port-dev On >>> >> Behalf Of Ichiroh Takiguchi >>> >> Sent: Dienstag, 15. Januar 2019 01:51 >>> >> To: Alan Bateman >>> >> Cc: build-dev ; ppc-aix-port-dev >> >> port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net >>> >> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default >>> >> charset >>> >> >>> >> Hello Alan. >>> >> >>> >> Could you review the fix again ? >>> >> >>> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 >>> >> Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ >>> >> >>> >> I added IBM29626C charset as standard way. >>> >> Please give any suggestion and question. >>> >> >>> >> Thanks, >>> >> Ichiroh Takiguchi >>> >> IBM Japan, Ltd. >>> >> >>> >> On 2018-12-14 18:58, Ichiroh Takiguchi wrote: >>> >> > Hello Alan. >>> >> > >>> >> > I opened JDK-8215333 for Charset filtering issue [1]. >>> >> > I cannot wait until JDK-8215333 is closed. >>> >> > Is it possible to put IBM-29626C charset with standard way ? >>> >> > >>> >> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 >>> >> > >>> >> > Thanks, >>> >> > Ichiroh Takiguchi >>> >> > >>> >> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: >>> >> >> Hello Roger, Magnus and Alan. >>> >> >> I may need to put alias information into charsets file. >>> >> >> stdcs-xxx cannot handle this information... >>> >> >> >>> >> >> Still AIX needs IBM-29626C charset for default encoding... >>> >> >> >>> >> >> I appreciate if you give me further suggestions. >>> >> >> >>> >> >> Thanks, >>> >> >> Ichiroh Takiguchi >>> >> >> >>> >> >> On 2018-12-10 20:50, Alan Bateman wrote: >>> >> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: >>> >> >>>> On 2018-12-07 21:20, Roger Riggs wrote: >>> >> >>>>> Hi, >>> >> >>>>> >>> >> >>>>> It is a nice feature that charsets are selected at build time using >>> >> >>>>> the stdcs-xxx files. >>> >> >>>>> This change breaks that pattern and embeds os specific information >>> >> >>>>> in more than one place. >>> >> >>>>> That does not seem like an improvement.? Is there any alternative? >>> >> >>>> I agree. Why is it not enough just to add it to stdcs-aix? >>> >> >>> My reading of the patch is that the "os" key is to avoid generating >>> >> >>> it >>> >> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on >>> >> >>> non-AIX platforms. The general direction is welcome but I think >>> >> >>> further work and discussion will be needed to get the right set of >>> >> >>> changes to support filtering in the build. It can probably be >>> >> >>> separated from the changes to add IBM-29626C to AIX's java.base. >>> >> >>> >>> >> >>> -Alan From goetz.lindenmaier at sap.com Tue Jan 29 10:17:21 2019 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Tue, 29 Jan 2019 10:17:21 +0000 Subject: JDK-8217880 AIX build issue about JDK-8214533 In-Reply-To: <2360ba8a6e5ce7bf580beafb377af7c4@linux.vnet.ibm.com> References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> <8c05b5147fa7489282d7cae04e801702@sap.com> <71a838ee68f575ee384bdc833ab820db@linux.vnet.ibm.com> <2360ba8a6e5ce7bf580beafb377af7c4@linux.vnet.ibm.com> Message-ID: <81787d1a7e0040829b628cf706564f27@sap.com> Hi, this looks good, the build works with this patch. Do you need a sponsor? Best regards, Goetz. > -----Original Message----- > From: Ichiroh Takiguchi > Sent: Dienstag, 29. Januar 2019 02:21 > To: Lindenmaier, Goetz > Cc: build-dev ; ppc-aix-port-dev dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Baesken, Matthias > > Subject: RFR: JDK-8217880 AIX build issue about JDK-8214533 > > Hello. > > Sorry about build issue for JDK-8214533. > > EUC_JP was extra entry on make/data/charsetmapping/stdcs-aix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8217880 > Change: https://cr.openjdk.java.net/~itakiguchi/8217880/webrev.00/ > > Could you review the fix ? > > Thanks, > Ichiroh Takiguchi > IBM Japan, Ltd. > > On 2019-01-28 22:49, Ichiroh Takiguchi wrote: > > Hello Goetz. > > > > Thank you for your suggestion. > > I just open JDK-8217880 [1]. > > > > I just restart clean build. > > > > I'll post new fix including testcase for EUC_JP_LINUX and EUC_JP_Open. > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8217880 > > > > Thanks, > > Ichiroh Takiguchi > > > > On 2019-01-28 22:11, Lindenmaier, Goetz wrote: > >> Hi Ichiroh, > >> > >> just open a bug, like "Fix aix build after 8214533" and post a RFR for > >> it. > >> I assume the fix is quite trivial so we can review it quick. > >> > >> Best regards, > >> Goetz. > >> > >>> -----Original Message----- > >>> From: ppc-aix-port-dev On > >>> Behalf Of Ichiroh Takiguchi > >>> Sent: Montag, 28. Januar 2019 14:13 > >>> To: Baesken, Matthias > >>> Cc: build-dev ; ppc-aix-port-dev > >>> >>> dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Alan Bateman > >>> > >>> Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default > >>> charset > >>> > >>> Hello. > >>> > >>> I'm very sorry. It's my fault. > >>> EUC_JP class was moved to java.base module. > >>> (sun.nio.cs.EUC_JP). > >>> > >>> make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and > >>> EUC_JP_Open. > >>> > >>> Could you suggest me how I should provide new webrev files ? > >>> > >>> Thanks, > >>> Ichiroh Takiguchi > >>> > >>> > >>> On 2019-01-28 17:03, Baesken, Matthias wrote: > >>> > Hello, seems 8214533 got pushed recently into jdk/jdk. Now > >>> > we see build errors on AIX , are they related to this change ? > >>> > > >>> > > >>> > /nb/rs6000_64/nightly/output-jdk- > >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63: > >>> > error: Decoder is not public in EUC_JP; cannot be accessed from > >>> > outside package > >>> > private static class Decoder extends EUC_JP.Decoder { > >>> > ^ > >>> > /nb/rs6000_64/nightly/output-jdk- > >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69: > >>> > error: Encoder is not public in EUC_JP; cannot be accessed from > >>> > outside package > >>> > private static class Encoder extends EUC_JP.Encoder { > >>> > ^ > >>> > /nb/rs6000_64/nightly/output-jdk- > >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65: > >>> > error: Decoder is not public in EUC_JP; cannot be accessed from > >>> > outside package > >>> > private static class Decoder extends EUC_JP.Decoder { > >>> > ^ > >>> > /nb/rs6000_64/nightly/output-jdk- > >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85: > >>> > error: Encoder is not public in EUC_JP; cannot be accessed from > >>> > outside package > >>> > private static class Encoder extends EUC_JP.Encoder { > >>> > > >>> > Best regards, Matthias > >>> > > >>> > > >>> > > >>> >> -----Original Message----- > >>> >> From: ppc-aix-port-dev > On > >>> >> Behalf Of Ichiroh Takiguchi > >>> >> Sent: Dienstag, 15. Januar 2019 01:51 > >>> >> To: Alan Bateman > >>> >> Cc: build-dev ; ppc-aix-port-dev >>> >> port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net > >>> >> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default > >>> >> charset > >>> >> > >>> >> Hello Alan. > >>> >> > >>> >> Could you review the fix again ? > >>> >> > >>> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 > >>> >> Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ > >>> >> > >>> >> I added IBM29626C charset as standard way. > >>> >> Please give any suggestion and question. > >>> >> > >>> >> Thanks, > >>> >> Ichiroh Takiguchi > >>> >> IBM Japan, Ltd. > >>> >> > >>> >> On 2018-12-14 18:58, Ichiroh Takiguchi wrote: > >>> >> > Hello Alan. > >>> >> > > >>> >> > I opened JDK-8215333 for Charset filtering issue [1]. > >>> >> > I cannot wait until JDK-8215333 is closed. > >>> >> > Is it possible to put IBM-29626C charset with standard way ? > >>> >> > > >>> >> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 > >>> >> > > >>> >> > Thanks, > >>> >> > Ichiroh Takiguchi > >>> >> > > >>> >> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: > >>> >> >> Hello Roger, Magnus and Alan. > >>> >> >> I may need to put alias information into charsets file. > >>> >> >> stdcs-xxx cannot handle this information... > >>> >> >> > >>> >> >> Still AIX needs IBM-29626C charset for default encoding... > >>> >> >> > >>> >> >> I appreciate if you give me further suggestions. > >>> >> >> > >>> >> >> Thanks, > >>> >> >> Ichiroh Takiguchi > >>> >> >> > >>> >> >> On 2018-12-10 20:50, Alan Bateman wrote: > >>> >> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: > >>> >> >>>> On 2018-12-07 21:20, Roger Riggs wrote: > >>> >> >>>>> Hi, > >>> >> >>>>> > >>> >> >>>>> It is a nice feature that charsets are selected at build time using > >>> >> >>>>> the stdcs-xxx files. > >>> >> >>>>> This change breaks that pattern and embeds os specific > information > >>> >> >>>>> in more than one place. > >>> >> >>>>> That does not seem like an improvement.? Is there any > alternative? > >>> >> >>>> I agree. Why is it not enough just to add it to stdcs-aix? > >>> >> >>> My reading of the patch is that the "os" key is to avoid generating > >>> >> >>> it > >>> >> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on > >>> >> >>> non-AIX platforms. The general direction is welcome but I think > >>> >> >>> further work and discussion will be needed to get the right set of > >>> >> >>> changes to support filtering in the build. It can probably be > >>> >> >>> separated from the changes to add IBM-29626C to AIX's java.base. > >>> >> >>> > >>> >> >>> -Alan From takiguc at linux.vnet.ibm.com Tue Jan 29 10:30:18 2019 From: takiguc at linux.vnet.ibm.com (Ichiroh Takiguchi) Date: Tue, 29 Jan 2019 19:30:18 +0900 Subject: JDK-8217880 AIX build issue about JDK-8214533 In-Reply-To: <81787d1a7e0040829b628cf706564f27@sap.com> References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> <8c05b5147fa7489282d7cae04e801702@sap.com> <71a838ee68f575ee384bdc833ab820db@linux.vnet.ibm.com> <2360ba8a6e5ce7bf580beafb377af7c4@linux.vnet.ibm.com> <81787d1a7e0040829b628cf706564f27@sap.com> Message-ID: Hello Goetz. Thank you for build testing. Yes, I need a sponsor. If possible, could you handle it ? Thanks, Ichiroh Takiguchi On 2019-01-29 19:17, Lindenmaier, Goetz wrote: > Hi, > > this looks good, the build works with this patch. > Do you need a sponsor? > > Best regards, > Goetz. > >> -----Original Message----- >> From: Ichiroh Takiguchi >> Sent: Dienstag, 29. Januar 2019 02:21 >> To: Lindenmaier, Goetz >> Cc: build-dev ; ppc-aix-port-dev >> > dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Baesken, >> Matthias >> >> Subject: RFR: JDK-8217880 AIX build issue about JDK-8214533 >> >> Hello. >> >> Sorry about build issue for JDK-8214533. >> >> EUC_JP was extra entry on make/data/charsetmapping/stdcs-aix. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8217880 >> Change: https://cr.openjdk.java.net/~itakiguchi/8217880/webrev.00/ >> >> Could you review the fix ? >> >> Thanks, >> Ichiroh Takiguchi >> IBM Japan, Ltd. >> >> On 2019-01-28 22:49, Ichiroh Takiguchi wrote: >> > Hello Goetz. >> > >> > Thank you for your suggestion. >> > I just open JDK-8217880 [1]. >> > >> > I just restart clean build. >> > >> > I'll post new fix including testcase for EUC_JP_LINUX and EUC_JP_Open. >> > >> > [1] https://bugs.openjdk.java.net/browse/JDK-8217880 >> > >> > Thanks, >> > Ichiroh Takiguchi >> > >> > On 2019-01-28 22:11, Lindenmaier, Goetz wrote: >> >> Hi Ichiroh, >> >> >> >> just open a bug, like "Fix aix build after 8214533" and post a RFR for >> >> it. >> >> I assume the fix is quite trivial so we can review it quick. >> >> >> >> Best regards, >> >> Goetz. >> >> >> >>> -----Original Message----- >> >>> From: ppc-aix-port-dev On >> >>> Behalf Of Ichiroh Takiguchi >> >>> Sent: Montag, 28. Januar 2019 14:13 >> >>> To: Baesken, Matthias >> >>> Cc: build-dev ; ppc-aix-port-dev >> >>> > >>> dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Alan Bateman >> >>> >> >>> Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default >> >>> charset >> >>> >> >>> Hello. >> >>> >> >>> I'm very sorry. It's my fault. >> >>> EUC_JP class was moved to java.base module. >> >>> (sun.nio.cs.EUC_JP). >> >>> >> >>> make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and >> >>> EUC_JP_Open. >> >>> >> >>> Could you suggest me how I should provide new webrev files ? >> >>> >> >>> Thanks, >> >>> Ichiroh Takiguchi >> >>> >> >>> >> >>> On 2019-01-28 17:03, Baesken, Matthias wrote: >> >>> > Hello, seems 8214533 got pushed recently into jdk/jdk. Now >> >>> > we see build errors on AIX , are they related to this change ? >> >>> > >> >>> > >> >>> > /nb/rs6000_64/nightly/output-jdk- >> >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63: >> >>> > error: Decoder is not public in EUC_JP; cannot be accessed from >> >>> > outside package >> >>> > private static class Decoder extends EUC_JP.Decoder { >> >>> > ^ >> >>> > /nb/rs6000_64/nightly/output-jdk- >> >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69: >> >>> > error: Encoder is not public in EUC_JP; cannot be accessed from >> >>> > outside package >> >>> > private static class Encoder extends EUC_JP.Encoder { >> >>> > ^ >> >>> > /nb/rs6000_64/nightly/output-jdk- >> >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65: >> >>> > error: Decoder is not public in EUC_JP; cannot be accessed from >> >>> > outside package >> >>> > private static class Decoder extends EUC_JP.Decoder { >> >>> > ^ >> >>> > /nb/rs6000_64/nightly/output-jdk- >> >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85: >> >>> > error: Encoder is not public in EUC_JP; cannot be accessed from >> >>> > outside package >> >>> > private static class Encoder extends EUC_JP.Encoder { >> >>> > >> >>> > Best regards, Matthias >> >>> > >> >>> > >> >>> > >> >>> >> -----Original Message----- >> >>> >> From: ppc-aix-port-dev >> On >> >>> >> Behalf Of Ichiroh Takiguchi >> >>> >> Sent: Dienstag, 15. Januar 2019 01:51 >> >>> >> To: Alan Bateman >> >>> >> Cc: build-dev ; ppc-aix-port-dev > >>> >> port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net >> >>> >> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default >> >>> >> charset >> >>> >> >> >>> >> Hello Alan. >> >>> >> >> >>> >> Could you review the fix again ? >> >>> >> >> >>> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 >> >>> >> Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ >> >>> >> >> >>> >> I added IBM29626C charset as standard way. >> >>> >> Please give any suggestion and question. >> >>> >> >> >>> >> Thanks, >> >>> >> Ichiroh Takiguchi >> >>> >> IBM Japan, Ltd. >> >>> >> >> >>> >> On 2018-12-14 18:58, Ichiroh Takiguchi wrote: >> >>> >> > Hello Alan. >> >>> >> > >> >>> >> > I opened JDK-8215333 for Charset filtering issue [1]. >> >>> >> > I cannot wait until JDK-8215333 is closed. >> >>> >> > Is it possible to put IBM-29626C charset with standard way ? >> >>> >> > >> >>> >> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 >> >>> >> > >> >>> >> > Thanks, >> >>> >> > Ichiroh Takiguchi >> >>> >> > >> >>> >> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: >> >>> >> >> Hello Roger, Magnus and Alan. >> >>> >> >> I may need to put alias information into charsets file. >> >>> >> >> stdcs-xxx cannot handle this information... >> >>> >> >> >> >>> >> >> Still AIX needs IBM-29626C charset for default encoding... >> >>> >> >> >> >>> >> >> I appreciate if you give me further suggestions. >> >>> >> >> >> >>> >> >> Thanks, >> >>> >> >> Ichiroh Takiguchi >> >>> >> >> >> >>> >> >> On 2018-12-10 20:50, Alan Bateman wrote: >> >>> >> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: >> >>> >> >>>> On 2018-12-07 21:20, Roger Riggs wrote: >> >>> >> >>>>> Hi, >> >>> >> >>>>> >> >>> >> >>>>> It is a nice feature that charsets are selected at build time using >> >>> >> >>>>> the stdcs-xxx files. >> >>> >> >>>>> This change breaks that pattern and embeds os specific >> information >> >>> >> >>>>> in more than one place. >> >>> >> >>>>> That does not seem like an improvement.? Is there any >> alternative? >> >>> >> >>>> I agree. Why is it not enough just to add it to stdcs-aix? >> >>> >> >>> My reading of the patch is that the "os" key is to avoid generating >> >>> >> >>> it >> >>> >> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on >> >>> >> >>> non-AIX platforms. The general direction is welcome but I think >> >>> >> >>> further work and discussion will be needed to get the right set of >> >>> >> >>> changes to support filtering in the build. It can probably be >> >>> >> >>> separated from the changes to add IBM-29626C to AIX's java.base. >> >>> >> >>> >> >>> >> >>> -Alan From magnus.ihse.bursie at oracle.com Tue Jan 29 11:03:49 2019 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 29 Jan 2019 12:03:49 +0100 Subject: RFR: JDK-8217880 AIX build issue about JDK-8214533 In-Reply-To: <2360ba8a6e5ce7bf580beafb377af7c4@linux.vnet.ibm.com> References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> <8c05b5147fa7489282d7cae04e801702@sap.com> <71a838ee68f575ee384bdc833ab820db@linux.vnet.ibm.com> <2! 360ba8a6e5ce7bf580beafb377af7c4@linux.vnet.ibm.com> Message-ID: > 29 jan. 2019 kl. 02:21 skrev Ichiroh Takiguchi : > > Hello. > > Sorry about build issue for JDK-8214533. > > EUC_JP was extra entry on make/data/charsetmapping/stdcs-aix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8217880 > Change: https://cr.openjdk.java.net/~itakiguchi/8217880/webrev.00/ LGTM. /Magnus > > Could you review the fix ? > > Thanks, > Ichiroh Takiguchi > IBM Japan, Ltd. > >> On 2019-01-28 22:49, Ichiroh Takiguchi wrote: >> Hello Goetz. >> Thank you for your suggestion. >> I just open JDK-8217880 [1]. >> I just restart clean build. >> I'll post new fix including testcase for EUC_JP_LINUX and EUC_JP_Open. >> [1] https://bugs.openjdk.java.net/browse/JDK-8217880 >> Thanks, >> Ichiroh Takiguchi >>> On 2019-01-28 22:11, Lindenmaier, Goetz wrote: >>> Hi Ichiroh, >>> just open a bug, like "Fix aix build after 8214533" and post a RFR for it. >>> I assume the fix is quite trivial so we can review it quick. >>> Best regards, >>> Goetz. >>>> -----Original Message----- >>>> From: ppc-aix-port-dev On >>>> Behalf Of Ichiroh Takiguchi >>>> Sent: Montag, 28. Januar 2019 14:13 >>>> To: Baesken, Matthias >>>> Cc: build-dev ; ppc-aix-port-dev >>> dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Alan Bateman >>>> >>>> Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default charset >>>> Hello. >>>> I'm very sorry. It's my fault. >>>> EUC_JP class was moved to java.base module. >>>> (sun.nio.cs.EUC_JP). >>>> make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and >>>> EUC_JP_Open. >>>> Could you suggest me how I should provide new webrev files ? >>>> Thanks, >>>> Ichiroh Takiguchi >>>> On 2019-01-28 17:03, Baesken, Matthias wrote: >>>> > Hello, seems 8214533 got pushed recently into jdk/jdk. Now >>>> > we see build errors on AIX , are they related to this change ? >>>> > >>>> > >>>> > /nb/rs6000_64/nightly/output-jdk- >>>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63: >>>> > error: Decoder is not public in EUC_JP; cannot be accessed from >>>> > outside package >>>> > private static class Decoder extends EUC_JP.Decoder { >>>> > ^ >>>> > /nb/rs6000_64/nightly/output-jdk- >>>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69: >>>> > error: Encoder is not public in EUC_JP; cannot be accessed from >>>> > outside package >>>> > private static class Encoder extends EUC_JP.Encoder { >>>> > ^ >>>> > /nb/rs6000_64/nightly/output-jdk- >>>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65: >>>> > error: Decoder is not public in EUC_JP; cannot be accessed from >>>> > outside package >>>> > private static class Decoder extends EUC_JP.Decoder { >>>> > ^ >>>> > /nb/rs6000_64/nightly/output-jdk- >>>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85: >>>> > error: Encoder is not public in EUC_JP; cannot be accessed from >>>> > outside package >>>> > private static class Encoder extends EUC_JP.Encoder { >>>> > >>>> > Best regards, Matthias >>>> > >>>> > >>>> > >>>> >> -----Original Message----- >>>> >> From: ppc-aix-port-dev On >>>> >> Behalf Of Ichiroh Takiguchi >>>> >> Sent: Dienstag, 15. Januar 2019 01:51 >>>> >> To: Alan Bateman >>>> >> Cc: build-dev ; ppc-aix-port-dev >>> >> port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net >>>> >> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default >>>> >> charset >>>> >> >>>> >> Hello Alan. >>>> >> >>>> >> Could you review the fix again ? >>>> >> >>>> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 >>>> >> Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ >>>> >> >>>> >> I added IBM29626C charset as standard way. >>>> >> Please give any suggestion and question. >>>> >> >>>> >> Thanks, >>>> >> Ichiroh Takiguchi >>>> >> IBM Japan, Ltd. >>>> >> >>>> >> On 2018-12-14 18:58, Ichiroh Takiguchi wrote: >>>> >> > Hello Alan. >>>> >> > >>>> >> > I opened JDK-8215333 for Charset filtering issue [1]. >>>> >> > I cannot wait until JDK-8215333 is closed. >>>> >> > Is it possible to put IBM-29626C charset with standard way ? >>>> >> > >>>> >> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 >>>> >> > >>>> >> > Thanks, >>>> >> > Ichiroh Takiguchi >>>> >> > >>>> >> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: >>>> >> >> Hello Roger, Magnus and Alan. >>>> >> >> I may need to put alias information into charsets file. >>>> >> >> stdcs-xxx cannot handle this information... >>>> >> >> >>>> >> >> Still AIX needs IBM-29626C charset for default encoding... >>>> >> >> >>>> >> >> I appreciate if you give me further suggestions. >>>> >> >> >>>> >> >> Thanks, >>>> >> >> Ichiroh Takiguchi >>>> >> >> >>>> >> >> On 2018-12-10 20:50, Alan Bateman wrote: >>>> >> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: >>>> >> >>>> On 2018-12-07 21:20, Roger Riggs wrote: >>>> >> >>>>> Hi, >>>> >> >>>>> >>>> >> >>>>> It is a nice feature that charsets are selected at build time using >>>> >> >>>>> the stdcs-xxx files. >>>> >> >>>>> This change breaks that pattern and embeds os specific information >>>> >> >>>>> in more than one place. >>>> >> >>>>> That does not seem like an improvement. Is there any alternative? >>>> >> >>>> I agree. Why is it not enough just to add it to stdcs-aix? >>>> >> >>> My reading of the patch is that the "os" key is to avoid generating >>>> >> >>> it >>>> >> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on >>>> >> >>> non-AIX platforms. The general direction is welcome but I think >>>> >> >>> further work and discussion will be needed to get the right set of >>>> >> >>> changes to support filtering in the build. It can probably be >>>> >> >>> separated from the changes to add IBM-29626C to AIX's java.base. >>>> >> >>> >>>> >> >>> -Alan > From matthias.baesken at sap.com Tue Jan 29 11:11:52 2019 From: matthias.baesken at sap.com (Baesken, Matthias) Date: Tue, 29 Jan 2019 11:11:52 +0000 Subject: JDK-8217880 AIX build issue about JDK-8214533 In-Reply-To: References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> <8c05b5147fa7489282d7cae04e801702@sap.com> <71a838ee68f575ee384bdc833ab820db@linux.vnet.ibm.com> <2360ba8a6e5ce7bf580beafb377af7c4@linux.vnet.ibm.com> <81787d1a7e0040829b628cf706564f27@sap.com> Message-ID: Looks good to me . The patch fixed the AIX build. Best regards, Matthias > -----Original Message----- > From: Ichiroh Takiguchi > Sent: Dienstag, 29. Januar 2019 11:30 > To: Lindenmaier, Goetz > Cc: build-dev ; ppc-aix-port-dev port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Baesken, > Matthias > Subject: RE: JDK-8217880 AIX build issue about JDK-8214533 > > Hello Goetz. > > Thank you for build testing. > > Yes, I need a sponsor. > If possible, could you handle it ? > > Thanks, > Ichiroh Takiguchi > > On 2019-01-29 19:17, Lindenmaier, Goetz wrote: > > Hi, > > > > this looks good, the build works with this patch. > > Do you need a sponsor? > > > > Best regards, > > Goetz. > > > >> -----Original Message----- > >> From: Ichiroh Takiguchi > >> Sent: Dienstag, 29. Januar 2019 02:21 > >> To: Lindenmaier, Goetz > >> Cc: build-dev ; ppc-aix-port-dev > >> >> dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Baesken, > >> Matthias > >> > >> Subject: RFR: JDK-8217880 AIX build issue about JDK-8214533 > >> > >> Hello. > >> > >> Sorry about build issue for JDK-8214533. > >> > >> EUC_JP was extra entry on make/data/charsetmapping/stdcs-aix. > >> > >> Bug: https://bugs.openjdk.java.net/browse/JDK-8217880 > >> Change: https://cr.openjdk.java.net/~itakiguchi/8217880/webrev.00/ > >> > >> Could you review the fix ? > >> > >> Thanks, > >> Ichiroh Takiguchi > >> IBM Japan, Ltd. > >> > >> On 2019-01-28 22:49, Ichiroh Takiguchi wrote: > >> > Hello Goetz. > >> > > >> > Thank you for your suggestion. > >> > I just open JDK-8217880 [1]. > >> > > >> > I just restart clean build. > >> > > >> > I'll post new fix including testcase for EUC_JP_LINUX and EUC_JP_Open. > >> > > >> > [1] https://bugs.openjdk.java.net/browse/JDK-8217880 > >> > > >> > Thanks, > >> > Ichiroh Takiguchi > >> > > >> > On 2019-01-28 22:11, Lindenmaier, Goetz wrote: > >> >> Hi Ichiroh, > >> >> > >> >> just open a bug, like "Fix aix build after 8214533" and post a RFR for > >> >> it. > >> >> I assume the fix is quite trivial so we can review it quick. > >> >> > >> >> Best regards, > >> >> Goetz. > >> >> > >> >>> -----Original Message----- > >> >>> From: ppc-aix-port-dev bounces at openjdk.java.net> On > >> >>> Behalf Of Ichiroh Takiguchi > >> >>> Sent: Montag, 28. Januar 2019 14:13 > >> >>> To: Baesken, Matthias > >> >>> Cc: build-dev ; ppc-aix-port-dev > >> >>> >> >>> dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Alan > Bateman > >> >>> > >> >>> Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default > >> >>> charset > >> >>> > >> >>> Hello. > >> >>> > >> >>> I'm very sorry. It's my fault. > >> >>> EUC_JP class was moved to java.base module. > >> >>> (sun.nio.cs.EUC_JP). > >> >>> > >> >>> make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX > and > >> >>> EUC_JP_Open. > >> >>> > >> >>> Could you suggest me how I should provide new webrev files ? > >> >>> > >> >>> Thanks, > >> >>> Ichiroh Takiguchi > >> >>> > >> >>> > >> >>> On 2019-01-28 17:03, Baesken, Matthias wrote: > >> >>> > Hello, seems 8214533 got pushed recently into jdk/jdk. Now > >> >>> > we see build errors on AIX , are they related to this change ? > >> >>> > > >> >>> > > >> >>> > /nb/rs6000_64/nightly/output-jdk- > >> >>> > test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63: > >> >>> > error: Decoder is not public in EUC_JP; cannot be accessed from > >> >>> > outside package > >> >>> > private static class Decoder extends EUC_JP.Decoder { > >> >>> > ^ > >> >>> > /nb/rs6000_64/nightly/output-jdk- > >> >>> > test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69: > >> >>> > error: Encoder is not public in EUC_JP; cannot be accessed from > >> >>> > outside package > >> >>> > private static class Encoder extends EUC_JP.Encoder { > >> >>> > ^ > >> >>> > /nb/rs6000_64/nightly/output-jdk- > >> >>> > test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65: > >> >>> > error: Decoder is not public in EUC_JP; cannot be accessed from > >> >>> > outside package > >> >>> > private static class Decoder extends EUC_JP.Decoder { > >> >>> > ^ > >> >>> > /nb/rs6000_64/nightly/output-jdk- > >> >>> > test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85: > >> >>> > error: Encoder is not public in EUC_JP; cannot be accessed from > >> >>> > outside package > >> >>> > private static class Encoder extends EUC_JP.Encoder { > >> >>> > > >> >>> > Best regards, Matthias > >> >>> > > >> >>> > > >> >>> > > >> >>> >> -----Original Message----- > >> >>> >> From: ppc-aix-port-dev bounces at openjdk.java.net> > >> On > >> >>> >> Behalf Of Ichiroh Takiguchi > >> >>> >> Sent: Dienstag, 15. Januar 2019 01:51 > >> >>> >> To: Alan Bateman > >> >>> >> Cc: build-dev ; ppc-aix-port-dev > >> >>> >> port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net > >> >>> >> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default > >> >>> >> charset > >> >>> >> > >> >>> >> Hello Alan. > >> >>> >> > >> >>> >> Could you review the fix again ? > >> >>> >> > >> >>> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 > >> >>> >> Change: > https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ > >> >>> >> > >> >>> >> I added IBM29626C charset as standard way. > >> >>> >> Please give any suggestion and question. > >> >>> >> > >> >>> >> Thanks, > >> >>> >> Ichiroh Takiguchi > >> >>> >> IBM Japan, Ltd. > >> >>> >> > >> >>> >> On 2018-12-14 18:58, Ichiroh Takiguchi wrote: > >> >>> >> > Hello Alan. > >> >>> >> > > >> >>> >> > I opened JDK-8215333 for Charset filtering issue [1]. > >> >>> >> > I cannot wait until JDK-8215333 is closed. > >> >>> >> > Is it possible to put IBM-29626C charset with standard way ? > >> >>> >> > > >> >>> >> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 > >> >>> >> > > >> >>> >> > Thanks, > >> >>> >> > Ichiroh Takiguchi > >> >>> >> > > >> >>> >> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: > >> >>> >> >> Hello Roger, Magnus and Alan. > >> >>> >> >> I may need to put alias information into charsets file. > >> >>> >> >> stdcs-xxx cannot handle this information... > >> >>> >> >> > >> >>> >> >> Still AIX needs IBM-29626C charset for default encoding... > >> >>> >> >> > >> >>> >> >> I appreciate if you give me further suggestions. > >> >>> >> >> > >> >>> >> >> Thanks, > >> >>> >> >> Ichiroh Takiguchi > >> >>> >> >> > >> >>> >> >> On 2018-12-10 20:50, Alan Bateman wrote: > >> >>> >> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: > >> >>> >> >>>> On 2018-12-07 21:20, Roger Riggs wrote: > >> >>> >> >>>>> Hi, > >> >>> >> >>>>> > >> >>> >> >>>>> It is a nice feature that charsets are selected at build time > using > >> >>> >> >>>>> the stdcs-xxx files. > >> >>> >> >>>>> This change breaks that pattern and embeds os specific > >> information > >> >>> >> >>>>> in more than one place. > >> >>> >> >>>>> That does not seem like an improvement.? Is there any > >> alternative? > >> >>> >> >>>> I agree. Why is it not enough just to add it to stdcs-aix? > >> >>> >> >>> My reading of the patch is that the "os" key is to avoid > generating > >> >>> >> >>> it > >> >>> >> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets > on > >> >>> >> >>> non-AIX platforms. The general direction is welcome but I > think > >> >>> >> >>> further work and discussion will be needed to get the right set > of > >> >>> >> >>> changes to support filtering in the build. It can probably be > >> >>> >> >>> separated from the changes to add IBM-29626C to AIX's > java.base. > >> >>> >> >>> > >> >>> >> >>> -Alan From goetz.lindenmaier at sap.com Tue Jan 29 11:20:38 2019 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Tue, 29 Jan 2019 11:20:38 +0000 Subject: JDK-8217880 AIX build issue about JDK-8214533 In-Reply-To: References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> <8c05b5147fa7489282d7cae04e801702@sap.com> <71a838ee68f575ee384bdc833ab820db@linux.vnet.ibm.com> <2360ba8a6e5ce7bf580beafb377af7c4@linux.vnet.ibm.com> <81787d1a7e0040829b628cf706564f27@sap.com> Message-ID: Pushed. Best regards, Goetz > -----Original Message----- > From: Ichiroh Takiguchi > Sent: Dienstag, 29. Januar 2019 11:30 > To: Lindenmaier, Goetz > Cc: build-dev ; ppc-aix-port-dev dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Baesken, Matthias > > Subject: RE: JDK-8217880 AIX build issue about JDK-8214533 > > Hello Goetz. > > Thank you for build testing. > > Yes, I need a sponsor. > If possible, could you handle it ? > > Thanks, > Ichiroh Takiguchi > > On 2019-01-29 19:17, Lindenmaier, Goetz wrote: > > Hi, > > > > this looks good, the build works with this patch. > > Do you need a sponsor? > > > > Best regards, > > Goetz. > > > >> -----Original Message----- > >> From: Ichiroh Takiguchi > >> Sent: Dienstag, 29. Januar 2019 02:21 > >> To: Lindenmaier, Goetz > >> Cc: build-dev ; ppc-aix-port-dev > >> >> dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Baesken, > >> Matthias > >> > >> Subject: RFR: JDK-8217880 AIX build issue about JDK-8214533 > >> > >> Hello. > >> > >> Sorry about build issue for JDK-8214533. > >> > >> EUC_JP was extra entry on make/data/charsetmapping/stdcs-aix. > >> > >> Bug: https://bugs.openjdk.java.net/browse/JDK-8217880 > >> Change: https://cr.openjdk.java.net/~itakiguchi/8217880/webrev.00/ > >> > >> Could you review the fix ? > >> > >> Thanks, > >> Ichiroh Takiguchi > >> IBM Japan, Ltd. > >> > >> On 2019-01-28 22:49, Ichiroh Takiguchi wrote: > >> > Hello Goetz. > >> > > >> > Thank you for your suggestion. > >> > I just open JDK-8217880 [1]. > >> > > >> > I just restart clean build. > >> > > >> > I'll post new fix including testcase for EUC_JP_LINUX and EUC_JP_Open. > >> > > >> > [1] https://bugs.openjdk.java.net/browse/JDK-8217880 > >> > > >> > Thanks, > >> > Ichiroh Takiguchi > >> > > >> > On 2019-01-28 22:11, Lindenmaier, Goetz wrote: > >> >> Hi Ichiroh, > >> >> > >> >> just open a bug, like "Fix aix build after 8214533" and post a RFR for > >> >> it. > >> >> I assume the fix is quite trivial so we can review it quick. > >> >> > >> >> Best regards, > >> >> Goetz. > >> >> > >> >>> -----Original Message----- > >> >>> From: ppc-aix-port-dev > On > >> >>> Behalf Of Ichiroh Takiguchi > >> >>> Sent: Montag, 28. Januar 2019 14:13 > >> >>> To: Baesken, Matthias > >> >>> Cc: build-dev ; ppc-aix-port-dev > >> >>> >> >>> dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Alan Bateman > >> >>> > >> >>> Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default > >> >>> charset > >> >>> > >> >>> Hello. > >> >>> > >> >>> I'm very sorry. It's my fault. > >> >>> EUC_JP class was moved to java.base module. > >> >>> (sun.nio.cs.EUC_JP). > >> >>> > >> >>> make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and > >> >>> EUC_JP_Open. > >> >>> > >> >>> Could you suggest me how I should provide new webrev files ? > >> >>> > >> >>> Thanks, > >> >>> Ichiroh Takiguchi > >> >>> > >> >>> > >> >>> On 2019-01-28 17:03, Baesken, Matthias wrote: > >> >>> > Hello, seems 8214533 got pushed recently into jdk/jdk. Now > >> >>> > we see build errors on AIX , are they related to this change ? > >> >>> > > >> >>> > > >> >>> > /nb/rs6000_64/nightly/output-jdk- > >> >>> > test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63: > >> >>> > error: Decoder is not public in EUC_JP; cannot be accessed from > >> >>> > outside package > >> >>> > private static class Decoder extends EUC_JP.Decoder { > >> >>> > ^ > >> >>> > /nb/rs6000_64/nightly/output-jdk- > >> >>> > test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69: > >> >>> > error: Encoder is not public in EUC_JP; cannot be accessed from > >> >>> > outside package > >> >>> > private static class Encoder extends EUC_JP.Encoder { > >> >>> > ^ > >> >>> > /nb/rs6000_64/nightly/output-jdk- > >> >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65: > >> >>> > error: Decoder is not public in EUC_JP; cannot be accessed from > >> >>> > outside package > >> >>> > private static class Decoder extends EUC_JP.Decoder { > >> >>> > ^ > >> >>> > /nb/rs6000_64/nightly/output-jdk- > >> >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85: > >> >>> > error: Encoder is not public in EUC_JP; cannot be accessed from > >> >>> > outside package > >> >>> > private static class Encoder extends EUC_JP.Encoder { > >> >>> > > >> >>> > Best regards, Matthias > >> >>> > > >> >>> > > >> >>> > > >> >>> >> -----Original Message----- > >> >>> >> From: ppc-aix-port-dev bounces at openjdk.java.net> > >> On > >> >>> >> Behalf Of Ichiroh Takiguchi > >> >>> >> Sent: Dienstag, 15. Januar 2019 01:51 > >> >>> >> To: Alan Bateman > >> >>> >> Cc: build-dev ; ppc-aix-port-dev aix- > >> >>> >> port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net > >> >>> >> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default > >> >>> >> charset > >> >>> >> > >> >>> >> Hello Alan. > >> >>> >> > >> >>> >> Could you review the fix again ? > >> >>> >> > >> >>> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 > >> >>> >> Change: > https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ > >> >>> >> > >> >>> >> I added IBM29626C charset as standard way. > >> >>> >> Please give any suggestion and question. > >> >>> >> > >> >>> >> Thanks, > >> >>> >> Ichiroh Takiguchi > >> >>> >> IBM Japan, Ltd. > >> >>> >> > >> >>> >> On 2018-12-14 18:58, Ichiroh Takiguchi wrote: > >> >>> >> > Hello Alan. > >> >>> >> > > >> >>> >> > I opened JDK-8215333 for Charset filtering issue [1]. > >> >>> >> > I cannot wait until JDK-8215333 is closed. > >> >>> >> > Is it possible to put IBM-29626C charset with standard way ? > >> >>> >> > > >> >>> >> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 > >> >>> >> > > >> >>> >> > Thanks, > >> >>> >> > Ichiroh Takiguchi > >> >>> >> > > >> >>> >> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: > >> >>> >> >> Hello Roger, Magnus and Alan. > >> >>> >> >> I may need to put alias information into charsets file. > >> >>> >> >> stdcs-xxx cannot handle this information... > >> >>> >> >> > >> >>> >> >> Still AIX needs IBM-29626C charset for default encoding... > >> >>> >> >> > >> >>> >> >> I appreciate if you give me further suggestions. > >> >>> >> >> > >> >>> >> >> Thanks, > >> >>> >> >> Ichiroh Takiguchi > >> >>> >> >> > >> >>> >> >> On 2018-12-10 20:50, Alan Bateman wrote: > >> >>> >> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: > >> >>> >> >>>> On 2018-12-07 21:20, Roger Riggs wrote: > >> >>> >> >>>>> Hi, > >> >>> >> >>>>> > >> >>> >> >>>>> It is a nice feature that charsets are selected at build time > using > >> >>> >> >>>>> the stdcs-xxx files. > >> >>> >> >>>>> This change breaks that pattern and embeds os specific > >> information > >> >>> >> >>>>> in more than one place. > >> >>> >> >>>>> That does not seem like an improvement.? Is there any > >> alternative? > >> >>> >> >>>> I agree. Why is it not enough just to add it to stdcs-aix? > >> >>> >> >>> My reading of the patch is that the "os" key is to avoid > generating > >> >>> >> >>> it > >> >>> >> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on > >> >>> >> >>> non-AIX platforms. The general direction is welcome but I think > >> >>> >> >>> further work and discussion will be needed to get the right set of > >> >>> >> >>> changes to support filtering in the build. It can probably be > >> >>> >> >>> separated from the changes to add IBM-29626C to AIX's > java.base. > >> >>> >> >>> > >> >>> >> >>> -Alan From takiguc at linux.vnet.ibm.com Tue Jan 29 12:01:55 2019 From: takiguc at linux.vnet.ibm.com (Ichiroh Takiguchi) Date: Tue, 29 Jan 2019 21:01:55 +0900 Subject: JDK-8217880 AIX build issue about JDK-8214533 In-Reply-To: References: <6e0506fa72311261d3b5923dd58cdb3c@linux.vnet.ibm.com> <07f980b6bd352a9eff8f2d0d161f3f19@linux.vnet.ibm.com> <74984761-7152-6026-42a5-fc60a6298a4b@oracle.com> <260a71c0-31f8-7127-8627-b383ddd73b5b@oracle.com> <6f0545b9-e304-4747-8004-f0e531b9e83d@oracle.com> <40eac4cde890ddde70eb24846aff2c83@linux.vnet.ibm.com> <551914f5-e2da-362e-a0a9-9e67153a7775@oracle.com> <27ae28a6-8bb7-a945-495c-c1d83db07531@oracle.com> <55f48343e23ec74f691250b59ae20bf2@linux.vnet.ibm.com> <8e04b8584178fcea5b4a517127162ed4@linux.vnet.ibm.com> <8c05b5147fa7489282d7cae04e801702@sap.com> <71a838ee68f575ee384bdc833ab820db@linux.vnet.ibm.com> <2360ba8a6e5ce7bf580beafb377af7c4@linux.vnet.ibm.com> <81787d1a7e0040829b628cf706564f27@sap.com> Message-ID: <17a0aa2962cc11279991fd8a10b41494@linux.vnet.ibm.com> To reviewers, Thank you for reviewing in a short time. Best regards, Ichiroh Takiguchi On 2019-01-29 20:20, Lindenmaier, Goetz wrote: > Pushed. > > Best regards, > Goetz > >> -----Original Message----- >> From: Ichiroh Takiguchi >> Sent: Dienstag, 29. Januar 2019 11:30 >> To: Lindenmaier, Goetz >> Cc: build-dev ; ppc-aix-port-dev >> > dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Baesken, >> Matthias >> >> Subject: RE: JDK-8217880 AIX build issue about JDK-8214533 >> >> Hello Goetz. >> >> Thank you for build testing. >> >> Yes, I need a sponsor. >> If possible, could you handle it ? >> >> Thanks, >> Ichiroh Takiguchi >> >> On 2019-01-29 19:17, Lindenmaier, Goetz wrote: >> > Hi, >> > >> > this looks good, the build works with this patch. >> > Do you need a sponsor? >> > >> > Best regards, >> > Goetz. >> > >> >> -----Original Message----- >> >> From: Ichiroh Takiguchi >> >> Sent: Dienstag, 29. Januar 2019 02:21 >> >> To: Lindenmaier, Goetz >> >> Cc: build-dev ; ppc-aix-port-dev >> >> > >> dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Baesken, >> >> Matthias >> >> >> >> Subject: RFR: JDK-8217880 AIX build issue about JDK-8214533 >> >> >> >> Hello. >> >> >> >> Sorry about build issue for JDK-8214533. >> >> >> >> EUC_JP was extra entry on make/data/charsetmapping/stdcs-aix. >> >> >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8217880 >> >> Change: https://cr.openjdk.java.net/~itakiguchi/8217880/webrev.00/ >> >> >> >> Could you review the fix ? >> >> >> >> Thanks, >> >> Ichiroh Takiguchi >> >> IBM Japan, Ltd. >> >> >> >> On 2019-01-28 22:49, Ichiroh Takiguchi wrote: >> >> > Hello Goetz. >> >> > >> >> > Thank you for your suggestion. >> >> > I just open JDK-8217880 [1]. >> >> > >> >> > I just restart clean build. >> >> > >> >> > I'll post new fix including testcase for EUC_JP_LINUX and EUC_JP_Open. >> >> > >> >> > [1] https://bugs.openjdk.java.net/browse/JDK-8217880 >> >> > >> >> > Thanks, >> >> > Ichiroh Takiguchi >> >> > >> >> > On 2019-01-28 22:11, Lindenmaier, Goetz wrote: >> >> >> Hi Ichiroh, >> >> >> >> >> >> just open a bug, like "Fix aix build after 8214533" and post a RFR for >> >> >> it. >> >> >> I assume the fix is quite trivial so we can review it quick. >> >> >> >> >> >> Best regards, >> >> >> Goetz. >> >> >> >> >> >>> -----Original Message----- >> >> >>> From: ppc-aix-port-dev >> On >> >> >>> Behalf Of Ichiroh Takiguchi >> >> >>> Sent: Montag, 28. Januar 2019 14:13 >> >> >>> To: Baesken, Matthias >> >> >>> Cc: build-dev ; ppc-aix-port-dev >> >> >>> > >> >>> dev at openjdk.java.net>; core-libs-dev at openjdk.java.net; Alan Bateman >> >> >>> >> >> >>> Subject: RE: RFR: 8214533 IBM-29626C is required for AIX default >> >> >>> charset >> >> >>> >> >> >>> Hello. >> >> >>> >> >> >>> I'm very sorry. It's my fault. >> >> >>> EUC_JP class was moved to java.base module. >> >> >>> (sun.nio.cs.EUC_JP). >> >> >>> >> >> >>> make/data/charsetmapping/stdcs-aix should have EUC_JP_LINUX and >> >> >>> EUC_JP_Open. >> >> >>> >> >> >>> Could you suggest me how I should provide new webrev files ? >> >> >>> >> >> >>> Thanks, >> >> >>> Ichiroh Takiguchi >> >> >>> >> >> >>> >> >> >>> On 2019-01-28 17:03, Baesken, Matthias wrote: >> >> >>> > Hello, seems 8214533 got pushed recently into jdk/jdk. Now >> >> >>> > we see build errors on AIX , are they related to this change ? >> >> >>> > >> >> >>> > >> >> >>> > /nb/rs6000_64/nightly/output-jdk- >> >> >>> >> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63: >> >> >>> > error: Decoder is not public in EUC_JP; cannot be accessed from >> >> >>> > outside package >> >> >>> > private static class Decoder extends EUC_JP.Decoder { >> >> >>> > ^ >> >> >>> > /nb/rs6000_64/nightly/output-jdk- >> >> >>> >> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:69: >> >> >>> > error: Encoder is not public in EUC_JP; cannot be accessed from >> >> >>> > outside package >> >> >>> > private static class Encoder extends EUC_JP.Encoder { >> >> >>> > ^ >> >> >>> > /nb/rs6000_64/nightly/output-jdk- >> >> >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:65: >> >> >>> > error: Decoder is not public in EUC_JP; cannot be accessed from >> >> >>> > outside package >> >> >>> > private static class Decoder extends EUC_JP.Decoder { >> >> >>> > ^ >> >> >>> > /nb/rs6000_64/nightly/output-jdk- >> >> >>> test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_Open.java:85: >> >> >>> > error: Encoder is not public in EUC_JP; cannot be accessed from >> >> >>> > outside package >> >> >>> > private static class Encoder extends EUC_JP.Encoder { >> >> >>> > >> >> >>> > Best regards, Matthias >> >> >>> > >> >> >>> > >> >> >>> > >> >> >>> >> -----Original Message----- >> >> >>> >> From: ppc-aix-port-dev > bounces at openjdk.java.net> >> >> On >> >> >>> >> Behalf Of Ichiroh Takiguchi >> >> >>> >> Sent: Dienstag, 15. Januar 2019 01:51 >> >> >>> >> To: Alan Bateman >> >> >>> >> Cc: build-dev ; ppc-aix-port-dev > aix- >> >> >>> >> port-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net >> >> >>> >> Subject: Re: RFR: 8214533 IBM-29626C is required for AIX default >> >> >>> >> charset >> >> >>> >> >> >> >>> >> Hello Alan. >> >> >>> >> >> >> >>> >> Could you review the fix again ? >> >> >>> >> >> >> >>> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214533 >> >> >>> >> Change: >> https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/ >> >> >>> >> >> >> >>> >> I added IBM29626C charset as standard way. >> >> >>> >> Please give any suggestion and question. >> >> >>> >> >> >> >>> >> Thanks, >> >> >>> >> Ichiroh Takiguchi >> >> >>> >> IBM Japan, Ltd. >> >> >>> >> >> >> >>> >> On 2018-12-14 18:58, Ichiroh Takiguchi wrote: >> >> >>> >> > Hello Alan. >> >> >>> >> > >> >> >>> >> > I opened JDK-8215333 for Charset filtering issue [1]. >> >> >>> >> > I cannot wait until JDK-8215333 is closed. >> >> >>> >> > Is it possible to put IBM-29626C charset with standard way ? >> >> >>> >> > >> >> >>> >> > [1] https://bugs.openjdk.java.net/browse/JDK-8215333 >> >> >>> >> > >> >> >>> >> > Thanks, >> >> >>> >> > Ichiroh Takiguchi >> >> >>> >> > >> >> >>> >> > On 2018-12-10 21:21, Ichiroh Takiguchi wrote: >> >> >>> >> >> Hello Roger, Magnus and Alan. >> >> >>> >> >> I may need to put alias information into charsets file. >> >> >>> >> >> stdcs-xxx cannot handle this information... >> >> >>> >> >> >> >> >>> >> >> Still AIX needs IBM-29626C charset for default encoding... >> >> >>> >> >> >> >> >>> >> >> I appreciate if you give me further suggestions. >> >> >>> >> >> >> >> >>> >> >> Thanks, >> >> >>> >> >> Ichiroh Takiguchi >> >> >>> >> >> >> >> >>> >> >> On 2018-12-10 20:50, Alan Bateman wrote: >> >> >>> >> >>> On 10/12/2018 11:01, Magnus Ihse Bursie wrote: >> >> >>> >> >>>> On 2018-12-07 21:20, Roger Riggs wrote: >> >> >>> >> >>>>> Hi, >> >> >>> >> >>>>> >> >> >>> >> >>>>> It is a nice feature that charsets are selected at build time >> using >> >> >>> >> >>>>> the stdcs-xxx files. >> >> >>> >> >>>>> This change breaks that pattern and embeds os specific >> >> information >> >> >>> >> >>>>> in more than one place. >> >> >>> >> >>>>> That does not seem like an improvement.? Is there any >> >> alternative? >> >> >>> >> >>>> I agree. Why is it not enough just to add it to stdcs-aix? >> >> >>> >> >>> My reading of the patch is that the "os" key is to avoid >> generating >> >> >>> >> >>> it >> >> >>> >> >>> on non-AIX platforms, it will otherwise end up in jdk.charsets on >> >> >>> >> >>> non-AIX platforms. The general direction is welcome but I think >> >> >>> >> >>> further work and discussion will be needed to get the right set of >> >> >>> >> >>> changes to support filtering in the build. It can probably be >> >> >>> >> >>> separated from the changes to add IBM-29626C to AIX's >> java.base. >> >> >>> >> >>> >> >> >>> >> >>> -Alan From matthias.baesken at sap.com Thu Jan 31 11:31:45 2019 From: matthias.baesken at sap.com (Baesken, Matthias) Date: Thu, 31 Jan 2019 11:31:45 +0000 Subject: jdk-build on AIX with xlc16/ xlclang++ : issue with (ibm)demangle.hpp Message-ID: Hello, when attempting to compile jdk/jdk on AIX with the recently released xlc16 / xlclang++ , I run into an issue with the compilation of hotspot/os/aix/porting_aix.cpp . The error is caused by the inclusion of demangle.h in porting_aix.cpp which leads to this error message : #error "Please include ibmdemangle.h for xlclang++ to demangle symbol names." However the inclusion of 'ibmdemangle.h' fails with : /jdk/src/hotspot/os/aix/porting_aix.cpp:39:10: fatal error: 'ibmdemangle.h' file not found #include Does anyone know where 'ibmdemangle.h' should come from ? I cannot find it in the compiler installation of xlc16 . And it is also not in /usr/include . My current workaround is to disable the C++ name demangling in porting_aix.cpp . Thanks, Matthias -------------- next part -------------- An HTML attachment was scrubbed... URL: