RFR: 8207404: MulticastSocket tests failing on AIX

[Steve Groeger]

Hi Christoph, 

Have reviewed you changes and they look OK.

I have no preference with regards the static imports, but my view is keep 
the changes as simple as possible and to not make changes just for the 
sake of it.

Have tested your patches on a couple of AIX systems, both with IPv6 
enabled but one didn't have an IPv6 address configured and the other did.
All the jdk/java/net/MulticastSocket tests passed. So the change also 
looks functionally OK. 

Thanks
Steve Groeger
IBM Runtime Technologies
Hursley, Winchester
Tel: (44) 1962 816911  Mobex: 279990  Mobile: 07718 517 129
Fax (44) 1962 816800
Lotus Notes: Steve Groeger/UK/IBM
Internet: groeges at uk.ibm.com

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU



From:   "Langer, Christoph" <christoph.langer at sap.com>
To:     Chris Hegarty <chris.hegarty at oracle.com>
Cc:     "ppc-aix-port-dev at openjdk.java.net" 
<ppc-aix-port-dev at openjdk.java.net>, "net-dev at openjdk.java.net" 
<net-dev at openjdk.java.net>
Date:   17/01/2019 11:34
Subject:        RE: RFR: 8207404: MulticastSocket tests failing on AIX
Sent by:        "net-dev" <net-dev-bounces at openjdk.java.net>



Hi Chris,
 
for me it was the other way round… I did not see immediately where the 
methods came from and had to do some navigation. But I’m happy to revert 
this.
 
As I had only worked with AIX so far, I’ll put the test update into our 
test system to see whether there’ll be issues on other platforms. I’ll 
send an updated webrev tomorrow.
 
Best regards
Christoph
 
From: Chris Hegarty <chris.hegarty at oracle.com> 
Sent: Donnerstag, 17. Januar 2019 12:27
To: Langer, Christoph <christoph.langer at sap.com>
Cc: net-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net
Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX
 
 


On 17 Jan 2019, at 10:55, Langer, Christoph <christoph.langer at sap.com> 
wrote:
 
Hi,
 
here is a fix for the MulticastSocket tests failing on AIX (in certain 
sceanrios):
 
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/
 
Why remove the static imports from NetworkConfiguration? It makes
the code more verbose ( and IMO harder to read ).
 
-Chris.
 


Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20190117/d48815ed/attachment.html>