RFR(S): 8220794: PPC64: Fix signal handler for SIGSEGV on branch to illegal address

[Thomas Stüfe]

Hi Gustavo,

Just a question, is the other case where we replace si_addr with

address addr = ((NativeInstruction*)pc)->get_stack_bang_address(uc);

really needed? Since we use si_addr in a number of places and I always
assumed that just works like on every other posix system.

E.g. we use it for assertion poison page handling or handling of secondary
crashes during error reporting, see handle_assert_poison_fault().

Cheers, Thomas


On Fri, Mar 22, 2019 at 4:29 PM Gustavo Romero <gromero at linux.vnet.ibm.com>
wrote:

> Hi,
>
> Please, could I get reviews for the following change:
>
> bug   : https://bugs.openjdk.java.net/browse/JDK-8220794
> webrev: http://cr.openjdk.java.net/~gromero/8220794/v1/
>
> It fixes the JVM signal handler on Linux / PPC64 when a SIGSEGV generated
> by a branch to an illegal/invalid address (not mapped address, address
> with no
> executable flags, etc) is caught by the JVM signal handler. Currently the
> signal
> handler does not handle that case correctly and the JVM crashes silently.
>
> That issue was reported by Goetz (SAP). Thanks for reporting the issue,
> Goetz.
>
> Thank you.
>
> Best regards,
> Gustavo
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20190322/2bf72662/attachment.html>