RFR : 8231753: use more Posix functionality in aix os::print_os_info
David Holmes
david.holmes at oracle.com
Wed Oct 2 13:07:39 UTC 2019
Hi Matthias,
On 2/10/2019 10:40 pm, Baesken, Matthias wrote:
> Hello, please review the following small (mostly AIX related) change .
>
> It replaces the AIX coding in function
> void os::print_os_info(outputStream* st) { ... }
>
>
> for uname and load average info output by os::Posix functionality.
> Additionally it slightly changes os::Posix::print_load_average function to handle the return value of os::loadavg
> ( indicating failure ) .
Might I make a slight suggestion here:
+ st->print("Failed to obtain load average");
as this is not an error message but still forms part of the report i.e.
it will print:
load average:Failed to obtain load average
that a simpler
+ st->print(" Unavailable");
would suffice to give:
load average: Unavailable
Otherwise changes appear fine.
Thanks,
David
> Bug / webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8231753
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8231753.0/
>
>
> Thanks, Matthias
>
More information about the ppc-aix-port-dev
mailing list