RFR(XS): 8245521: Remove STACK_BIAS

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue May 26 19:01:05 UTC 2020


On 5/21/20 9:11 PM, David Holmes wrote:
> Hi Mikael,
> 
> Looks good.

+1

> 
> I assume the change to GraalHotSpotVMConfig.java is to allow it to work with older VMs?

Yes. stackBias will be set to 0 if STACK_BIAS is not present. Otherwise it will be set to STACK_BIAS value.

Thanks,
Vladimir

> 
> Thanks,
> David
> 
> On 22/05/2020 1:36 pm, Mikael Vidstedt wrote:
>>
>> Please review this small change which removes the STACK_BIAS constant and its uses:
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8245521
>> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8245521/webrev.00/open/webrev/
>>
>> Background (from JBS):
>>
>> With Solaris/SPARC removed the STACK_BIAS definition in src/hotspot/share/utilities/globalDefinitions.hpp is now 
>> always 0 and can be removed.
>>
>>
>> Testing:
>>
>> Tier1
>>
>> Cheers,
>> Mikael
>>


More information about the ppc-aix-port-dev mailing list