From gromero at linux.vnet.ibm.com Thu Sep 3 18:31:14 2020 From: gromero at linux.vnet.ibm.com (Gustavo Romero) Date: Thu, 3 Sep 2020 15:31:14 -0300 Subject: RFR: 8251926: PPC: Remove an unused variable in assembler_ppc.cpp In-Reply-To: References: Message-ID: On 8/18/20 5:38 AM, Michihiro Horie wrote: > > Dear all, > > Would you please review a small change? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8251926 > Webrev: http://cr.openjdk.java.net/~mhorie/8251926/webrev.00/ > > The load_const_optimized function in assembler_ppc.cpp has an unused > variable named return_xd. It looks unnecessary in the current code. Hi Michi, The change looks good to me. As Thomas said that change can be considered trivial, so you can push it right through to jdk master repo without a second Review (only one Review is sufficient for trivial changes). Best regards, Gustavo From HORIE at jp.ibm.com Fri Sep 4 05:47:21 2020 From: HORIE at jp.ibm.com (Michihiro Horie) Date: Fri, 4 Sep 2020 14:47:21 +0900 Subject: RFR: 8251926: PPC: Remove an unused variable in assembler_ppc.cpp In-Reply-To: References: Message-ID: Hi Gustavo, Thanks for your additional review and guideline for the trivial change! Best regards, Michihiro From: "Gustavo Romero" To: Michihiro Horie/Japan/IBM at IBMJP, ppc-aix-port-dev at openjdk.java.net, hotspot-compiler-dev at openjdk.java.net Cc: "Thomas St?fe" Date: 2020/09/04 03:31 Subject: Re: RFR: 8251926: PPC: Remove an unused variable in assembler_ppc.cpp On 8/18/20 5:38 AM, Michihiro Horie wrote: > > Dear all, > > Would you please review a small change? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8251926 > Webrev: http://cr.openjdk.java.net/~mhorie/8251926/webrev.00/ > > The load_const_optimized function in assembler_ppc.cpp has an unused > variable named return_xd. It looks unnecessary in the current code. Hi Michi, The change looks good to me. As Thomas said that change can be considered trivial, so you can push it right through to jdk master repo without a second Review (only one Review is sufficient for trivial changes). Best regards, Gustavo -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: graycol.gif Type: image/gif Size: 105 bytes Desc: not available URL: