RFR: 8251926: PPC: Remove an unused variable in assembler_ppc.cpp
Michihiro Horie
HORIE at jp.ibm.com
Fri Sep 4 05:47:21 UTC 2020
Hi Gustavo,
Thanks for your additional review and guideline for the trivial change!
Best regards,
Michihiro
From: "Gustavo Romero" <gromero at linux.vnet.ibm.com>
To: Michihiro Horie/Japan/IBM at IBMJP,
ppc-aix-port-dev at openjdk.java.net,
hotspot-compiler-dev at openjdk.java.net
Cc: "Thomas Stüfe" <thomas.stuefe at gmail.com>
Date: 2020/09/04 03:31
Subject: Re: RFR: 8251926: PPC: Remove an unused variable in
assembler_ppc.cpp
On 8/18/20 5:38 AM, Michihiro Horie wrote:
>
> Dear all,
>
> Would you please review a small change?
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8251926
> Webrev: http://cr.openjdk.java.net/~mhorie/8251926/webrev.00/
>
> The load_const_optimized function in assembler_ppc.cpp has an unused
> variable named return_xd. It looks unnecessary in the current code.
Hi Michi,
The change looks good to me.
As Thomas said that change can be considered trivial, so you can push
it right through to jdk master repo without a second Review (only one
Review is sufficient for trivial changes).
Best regards,
Gustavo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20200904/9a796390/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/attachments/20200904/9a796390/graycol.gif>
More information about the ppc-aix-port-dev
mailing list