TEST: java/util/logging/LoggerWeakRefLeak.sh

[Alan Bateman]

On 18/12/2013 16:44, Volker Simonis wrote:
> Hi,
>
> the test 'java/util/logging/LoggerWeakRefLeak.sh' checks for the
> availability of the '-histo:live' option in jmap which is only
> available if  the SA is available.
>
> However I don't think that it should be an error if the option isn't
> supported because of a missing SA implementation on a certain
> platfrom.
The tests have a lot of implementation dependencies and I'm sure you'll 
run into others too.

>
> I suggest the following fix:
>
> --- a/test/java/util/logging/LoggerWeakRefLeak.sh       Tue Dec 17
> 19:01:21 2013 +0100
> +++ b/test/java/util/logging/LoggerWeakRefLeak.sh       Wed Dec 18
> 17:40:46 2013 +0100
> @@ -83,9 +83,9 @@
>       fi
>
>       if [ "$status" != 0 ]; then
> -        echo "ERROR: 'jmap $jmap_option' is not supported so this test"
> -        echo "ERROR: cannot work reliably. Aborting!"
> -        exit 2
> +        echo "WARNING: 'jmap $jmap_option' is not supported on this platform"
> +        echo "WARNING: so this test cannot work reliably. Aborting!"
> +        exit 0
>       fi
>   fi
>
> I want to put this fix into the patch for "8028537: PPC64: Updated
> jdk/test scripts to understand the AIX os and environment" so I don't
> think we need a special BugID for it.
>
> What do you think?
>
I'd prefer to see this one (and AnonLoggerWeakRefLeak) changed to not 
use jmap to detect leaks but that is beyond the scope of what you are 
doing. What you have is fine and shouldn't have any impact on other 
platforms.

-Alan