<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 14/01/2014 16:57, Volker Simonis wrote:
<blockquote
cite="mid:CA+3eh11gweW1qozBX=zXGsnwEGiHB-va0BSjqzHSUWLX+rUCMA@mail.gmail.com"
type="cite">
<pre wrap="">Hi,
could you please review the following change:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~simonis/webrevs/8028537/">http://cr.openjdk.java.net/~simonis/webrevs/8028537/</a>
which, together with the changes from "8031581: PPC64: Addons and fixes for
AIX to pass the jdk regression tests" and "8031134 : PPC64: implement
printing on AIX" enables our our port to pass all but the following 7 jtreg
regression tests on AIX (compared to the Linux/x86_64 baseline from
<a class="moz-txt-link-abbreviated" href="http://www.java.net/download/jdk8/testresults/testresults.html">www.java.net/download/jdk8/testresults/testresults.html</a>):
</pre>
</blockquote>
I've finally got to this one. As the event translation issue is now
a separate issue then I've ignored that part.<br>
<br>
I'm not comfortable with the changes to FileDispatcherImpl.c as I
don't think we shouldn't be calling into IO_ or NET_* functions
here. I think I get the issue that you have on AIX (and assume it's
the preClose/dup2 that blocks rather than close) but need a bit of
time to suggest alternatives. It may be that it will require an AIX
specific SocketDispatcher. Do you happen to know which tests fail
due to this part?<br>
<br>
The other changes look okay. There is a typo in the change to
zip_util.c, s/legel/legal/.<br>
<br>
In DatagramChannelImpl.c then you handle
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<span class="new">connect failing with EAFNOSUPPORT</span>. I would
be tempted to replace the comment to say that it <span class="new">EAFNOSUPPORT
can be</span> ignored on AIX. A minor comment but the indentation
for rv = errno can be fixed (I see the BSD code has it wrong too).<br>
<br>
-Alan.<br>
<br>
<br>
</body>
</html>