From felix.yang at huawei.com Sat Nov 6 02:30:00 2021 From: felix.yang at huawei.com (Yangfei (Felix)) Date: Sat, 6 Nov 2021 02:30:00 +0000 Subject: Welcome announcement Message-ID: Hi all, The RISC-V Port Project has been recorded in the OpenJDK Census [1]. We already have the repo [2] and the mailing list (pre-populated with initial Reviewers) [3]. The "master" branch is seeded with the most recent gh:openjdk/jdk and will automatically be sync'd to that repo. I will push a new "riscv-port" branch to the Project repo. Future Project development should happen on this new branch. We also have a web page [4] and a wikispace [5]. Note that the wikispace is still being setup, and we need to wait for write access permission. I'll add something more on the wiki page once it's ready for editing. The next thing for me to do is to propose the current code from the riscv-port-branch of jdk-sandbox as GitHub Pull-Request. This course made things simpler from the legal point of view. It would be beneficial to track our future issues in JBS. I will ask ops to add "riscv" as a CPU target. Like other Projects, we also need project-specific entries for the Affected and Fix Version fields, e.g. JDK-8251041 [6]. I think we can do the same. Aleksey Shipilev is building nightlies here [7]. And we've provided build instructions for reference [8]. You can try the RISC-V JDK with QEMU User/System mode or HiFive Unleashed/Unmatched board. Have fun and happy hacking! Thanks, Felix [1] https://openjdk.java.net/census#riscv-port [2] https://github.com/openjdk/riscv-port [3] https://mail.openjdk.java.net/mailman/listinfo/riscv-port-dev [4] http://openjdk.java.net/projects/riscv-port [5] https://wiki.openjdk.java.net/display/RISCVPort [6] https://bugs.openjdk.java.net/browse/JDK-8251041 [7] https://builds.shipilev.net/openjdk-jdk-riscv [8] http://cr.openjdk.java.net/~fyang/openjdk-riscv-port/BuildRISCVJDK.md From fyang at openjdk.java.net Mon Nov 8 03:26:40 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 8 Nov 2021 03:26:40 GMT Subject: [riscv-port] RFR: 8276792: RISC-V Port: Initial support for RV64GV Message-ID: This riscv64 port supports RV64GV, shorthand for RV64IMAFDV ISA extensions, and covers the templateInterpreter, C1 and C2, excluding AOT/JVMCI. All existing GCs are available on riscv64, including ZGC and ShenandoahGC. Passed jtreg tier{1,2,3,4} and jcstress tests on HiFive Unmatched board. SPECjbb & SPECjvm benchmark tests are also carried out regularly. So it should be good enough to run most Java programs. ------------- Commit messages: - 8276792: RISC-V Port: Initial support for RV64GV Changes: https://git.openjdk.java.net/riscv-port/pull/1/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=1&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276792 Stats: 56639 lines in 189 files changed: 56486 ins; 55 del; 98 mod Patch: https://git.openjdk.java.net/riscv-port/pull/1.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/1/head:pull/1 PR: https://git.openjdk.java.net/riscv-port/pull/1 From shade at openjdk.java.net Mon Nov 8 07:11:15 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 8 Nov 2021 07:11:15 GMT Subject: [riscv-port] RFR: 8276792: RISC-V Port: Initial support for RV64GV In-Reply-To: References: Message-ID: On Mon, 8 Nov 2021 03:15:55 GMT, Fei Yang wrote: > This riscv64 port supports RV64GV, shorthand for RV64IMAFDV ISA extensions, and covers the templateInterpreter, C1 and C2, excluding AOT/JVMCI. All existing GCs are available on riscv64, including ZGC and ShenandoahGC. > > Passed jtreg tier{1,2,3,4} and jcstress tests on HiFive Unmatched board. SPECjbb & SPECjvm benchmark tests are also carried out regularly. So it should be good enough to run most Java programs. Honestly, you could just push it :) No need for PR for the first import. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/riscv-port/pull/1 From fyang at openjdk.java.net Mon Nov 8 07:17:19 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 8 Nov 2021 07:17:19 GMT Subject: [riscv-port] Integrated: 8276792: RISC-V Port: Initial support for RV64GV In-Reply-To: References: Message-ID: <59QtT-ZSxTKDoMtVP58HdIYczhHh3aIbhdhsnf-Qn10=.b0d940fd-b3c8-4e82-b53c-4af543e95504@github.com> On Mon, 8 Nov 2021 03:15:55 GMT, Fei Yang wrote: > This riscv64 port supports RV64GV, shorthand for RV64IMAFDV ISA extensions, and covers the templateInterpreter, C1 and C2, excluding AOT/JVMCI. All existing GCs are available on riscv64, including ZGC and ShenandoahGC. > > Passed jtreg tier{1,2,3,4} and jcstress tests on HiFive Unmatched board. SPECjbb & SPECjvm benchmark tests are also carried out regularly. So it should be good enough to run most Java programs. This pull request has now been integrated. Changeset: 7148c398 Author: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/7148c39832fe522bad91df77ef4b5c9371193c35 Stats: 56639 lines in 189 files changed: 56486 ins; 55 del; 98 mod 8276792: RISC-V Port: Initial support for RV64GV Co-authored-by: Yadong Wang Co-authored-by: Yanhong Zhu Co-authored-by: Feilong Jiang Co-authored-by: Kun Wang Co-authored-by: Zhuxuan Ni Co-authored-by: Taiping Guo Co-authored-by: Kang He Co-authored-by: Aleksey Shipilev Reviewed-by: shade ------------- PR: https://git.openjdk.java.net/riscv-port/pull/1 From shade at redhat.com Mon Nov 8 07:33:07 2021 From: shade at redhat.com (Aleksey Shipilev) Date: Mon, 8 Nov 2021 08:33:07 +0100 Subject: Welcome announcement In-Reply-To: References: Message-ID: <50ed7271-c360-4ddf-f6ff-81316f509da9@redhat.com> On 11/6/21 3:30 AM, Yangfei (Felix) wrote: > Aleksey Shipilev is building nightlies here [7]. Thank you! I retargeted my builds to this new repo: https://builds.shipilev.net/openjdk-jdk-riscv https://builds.shipilev.net/patch-openjdk-riscv/ -- -Aleksey From felix.yang at huawei.com Tue Nov 9 02:14:38 2021 From: felix.yang at huawei.com (Yangfei (Felix)) Date: Tue, 9 Nov 2021 02:14:38 +0000 Subject: Welcome announcement In-Reply-To: <50ed7271-c360-4ddf-f6ff-81316f509da9@redhat.com> References: <50ed7271-c360-4ddf-f6ff-81316f509da9@redhat.com> Message-ID: Hi, > -----Original Message----- > From: Aleksey Shipilev [mailto:shade at redhat.com] > Sent: Monday, November 8, 2021 3:33 PM > To: Yangfei (Felix) ; riscv-port- > dev at openjdk.java.net > Subject: Re: Welcome announcement > > On 11/6/21 3:30 AM, Yangfei (Felix) wrote: > > Aleksey Shipilev is building nightlies here [7]. > > Thank you! I retargeted my builds to this new repo: > https://builds.shipilev.net/openjdk-jdk-riscv > https://builds.shipilev.net/patch-openjdk-riscv/ Thanks for taking care of that :-) Some update: I have pushed new "riscv-port" branch and imported the initial code for this port [1]. Also, the JBS has been updated with extra settings for this project. Here is an example issue for reference [2]. Felix [1] https://github.com/openjdk/riscv-port/pull/1 [2] https://bugs.openjdk.java.net/browse/JDK-8276792 From duke at openjdk.java.net Fri Nov 12 18:15:27 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Fri, 12 Nov 2021 18:15:27 GMT Subject: [riscv-port] RFR: 8276989: riscv: C1 should not allocate x3, which is the gp register Message-ID: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> Hi team, x3 is a special register on RISCV and we should not use it as a register allocation candidate - if users write JNI programs referencing global variables, where ld could link global reference loading logic to an instruction like 'ld $Rtmp, $offset(x3)', and try to call vm functions, C1 will zap x3's value and causes a crash. It seems C2 doesn't use x3 so we are just aligning the logic with C2 properly. Thanks, Xiaolin ------------- Commit messages: - Bug fix: C1 should not allocate x3, which is the gp register Changes: https://git.openjdk.java.net/riscv-port/pull/3/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=3&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276989 Stats: 8 lines in 3 files changed: 2 ins; 3 del; 3 mod Patch: https://git.openjdk.java.net/riscv-port/pull/3.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/3/head:pull/3 PR: https://git.openjdk.java.net/riscv-port/pull/3 From duke at openjdk.java.net Fri Nov 12 18:16:35 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Fri, 12 Nov 2021 18:16:35 GMT Subject: [riscv-port] RFR: 8276988: riscv: Fix a register name string: lr to x5 Message-ID: Hi team - Simply fix a register name string: `lr` is `names[1]` so `names[5]` should be `x5`. Thanks, Xiaolin ------------- Commit messages: - Fix the register name lr to x5 Changes: https://git.openjdk.java.net/riscv-port/pull/2/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=2&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276988 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/2.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/2/head:pull/2 PR: https://git.openjdk.java.net/riscv-port/pull/2 From fyang at openjdk.java.net Sun Nov 14 13:10:01 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Sun, 14 Nov 2021 13:10:01 GMT Subject: [riscv-port] RFR: 8276988: riscv: Fix a register name string: lr to x5 In-Reply-To: References: Message-ID: On Thu, 11 Nov 2021 09:25:24 GMT, zhengxiaolinX wrote: > Hi team - > > Simply fix a register name string: `lr` is `names[1]` so `names[5]` should be `x5`. > > Thanks, > Xiaolin Looks good. I suggest typo fixes like this be combined into other non-trivial PRs in future. ------------- Marked as reviewed by fyang (Committer). PR: https://git.openjdk.java.net/riscv-port/pull/2 From fyang at openjdk.java.net Sun Nov 14 14:09:14 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Sun, 14 Nov 2021 14:09:14 GMT Subject: [riscv-port] RFR: 8276989: riscv: C1 should not allocate x3, which is the gp register In-Reply-To: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> References: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> Message-ID: On Thu, 11 Nov 2021 09:28:13 GMT, zhengxiaolinX wrote: > Hi team, > > x3 is a special register on RISCV and we should not use it as a register allocation candidate - if users write JNI programs referencing global variables, where ld could link global reference loading logic to an instruction like 'ld $Rtmp, $offset(x3)', and try to call vm functions, C1 will zap x3's value and causes a crash. It seems C2 doesn't use x3 so we are just aligning the logic with C2 properly. > > Thanks, > Xiaolin Changes looks good to me. Thanks for fixing this. Did you performed any tests for this? ------------- PR: https://git.openjdk.java.net/riscv-port/pull/3 From duke at openjdk.java.net Mon Nov 15 02:55:59 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 15 Nov 2021 02:55:59 GMT Subject: [riscv-port] RFR: 8276988: riscv: Fix a register name string: lr to x5 In-Reply-To: References: Message-ID: On Thu, 11 Nov 2021 09:25:24 GMT, zhengxiaolinX wrote: > Hi team - > > Simply fix a register name string: `lr` is `names[1]` so `names[5]` should be `x5`. > > Thanks, > Xiaolin Thanks for the review - nice suggestion for a trivial patch like this. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/2 From duke at openjdk.java.net Mon Nov 15 03:06:53 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 15 Nov 2021 03:06:53 GMT Subject: [riscv-port] RFR: 8276989: riscv: C1 should not allocate x3, which is the gp register In-Reply-To: References: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> Message-ID: On Sun, 14 Nov 2021 14:06:11 GMT, Fei Yang wrote: > Changes looks good to me. Thanks for fixing this. Did you performed any tests for this? Yes - hotspot/jdk full tiers' results look good. This patch is directly cherry-picked from [that patch](https://github.com/riscv-collab/riscv-openjdk/pull/2). Would you like to have another simple review? Thanks. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/3 From duke at openjdk.java.net Mon Nov 15 03:22:50 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 15 Nov 2021 03:22:50 GMT Subject: [riscv-port] RFR: 8276988: riscv: Fix a register name string: lr to x5 In-Reply-To: References: Message-ID: On Thu, 11 Nov 2021 09:25:24 GMT, zhengxiaolinX wrote: > Hi team - > > Simply fix a register name string: `lr` is `names[1]` so `names[5]` should be `x5`. > > Thanks, > Xiaolin hmm... maybe I need another integration? Quite not able to figure out what has happened. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/2 From duke at openjdk.java.net Mon Nov 15 03:28:51 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 15 Nov 2021 03:28:51 GMT Subject: [riscv-port] RFR: 8276988: riscv: Fix a register name string: lr to x5 In-Reply-To: References: Message-ID: On Thu, 11 Nov 2021 09:25:24 GMT, zhengxiaolinX wrote: > Hi team - > > Simply fix a register name string: `lr` is `names[1]` so `names[5]` should be `x5`. > > Thanks, > Xiaolin Seems the third checkbox needs a mark. ![image](https://user-images.githubusercontent.com/38156692/141717351-eebce4bf-9672-4f17-80f6-af30f33ba410.png) ------------- PR: https://git.openjdk.java.net/riscv-port/pull/2 From fyang at openjdk.java.net Mon Nov 15 03:28:52 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 15 Nov 2021 03:28:52 GMT Subject: [riscv-port] RFR: 8276988: riscv: Fix a register name string: lr to x5 In-Reply-To: References: Message-ID: On Thu, 11 Nov 2021 09:25:24 GMT, zhengxiaolinX wrote: > Hi team - > > Simply fix a register name string: `lr` is `names[1]` so `names[5]` should be `x5`. > > Thanks, > Xiaolin > hmm... maybe I need another integration? Quite not able to figure out what has happened. /integrate I think we need another Reviewer here. Maybe @shipilev ? According to OpenJDK bylaws, a Project?s Lead is automatically considered to be a Reviewer. But looks like the robot does not follow this rule correctly for now. I am asking the registrar about this. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/2 From fyang at openjdk.java.net Mon Nov 15 03:28:52 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 15 Nov 2021 03:28:52 GMT Subject: [riscv-port] Withdrawn: 8276988: riscv: Fix a register name string: lr to x5 In-Reply-To: References: Message-ID: On Thu, 11 Nov 2021 09:25:24 GMT, zhengxiaolinX wrote: > Hi team - > > Simply fix a register name string: `lr` is `names[1]` so `names[5]` should be `x5`. > > Thanks, > Xiaolin This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/2 From fyang at openjdk.java.net Mon Nov 15 06:18:22 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 15 Nov 2021 06:18:22 GMT Subject: [riscv-port] RFR: 8276989: riscv: C1 should not allocate x3, which is the gp register In-Reply-To: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> References: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> Message-ID: On Thu, 11 Nov 2021 09:28:13 GMT, zhengxiaolinX wrote: > Hi team, > > x3 is a special register on RISCV and we should not use it as a register allocation candidate - if users write JNI programs referencing global variables, where ld could link global reference loading logic to an instruction like 'ld $Rtmp, $offset(x3)', and try to call vm functions, C1 will zap x3's value and causes a crash. It seems C2 doesn't use x3 so we are just aligning the logic with C2 properly. > > Thanks, > Xiaolin Marked as reviewed by fyang (Committer). ------------- PR: https://git.openjdk.java.net/riscv-port/pull/3 From fyang at openjdk.java.net Mon Nov 15 06:18:23 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 15 Nov 2021 06:18:23 GMT Subject: [riscv-port] RFR: 8276989: riscv: C1 should not allocate x3, which is the gp register In-Reply-To: References: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> Message-ID: On Mon, 15 Nov 2021 03:03:41 GMT, zhengxiaolinX wrote: > > Changes looks good to me. Thanks for fixing this. Did you performed any tests for this? > > Yes - hotspot/jdk full tiers' results look good. This patch is directly cherry-picked from [that patch](https://github.com/riscv-collab/riscv-openjdk/pull/2). Would you like to have another simple review? Thanks. OK. Thanks. I think we still need another Reviewer here. @shipilev ------------- PR: https://git.openjdk.java.net/riscv-port/pull/3 From shade at openjdk.java.net Mon Nov 15 08:22:52 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 15 Nov 2021 08:22:52 GMT Subject: [riscv-port] RFR: 8276989: riscv: C1 should not allocate x3, which is the gp register In-Reply-To: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> References: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> Message-ID: On Thu, 11 Nov 2021 09:28:13 GMT, zhengxiaolinX wrote: > Hi team, > > x3 is a special register on RISCV and we should not use it as a register allocation candidate - if users write JNI programs referencing global variables, where ld could link global reference loading logic to an instruction like 'ld $Rtmp, $offset(x3)', and try to call vm functions, C1 will zap x3's value and causes a crash. It seems C2 doesn't use x3 so we are just aligning the logic with C2 properly. > > Thanks, > Xiaolin No need for two reviewers in non-mainline projects. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/riscv-port/pull/3 From duke at openjdk.java.net Mon Nov 15 08:31:56 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 15 Nov 2021 08:31:56 GMT Subject: [riscv-port] RFR: 8276989: riscv: C1 should not allocate x3, which is the gp register In-Reply-To: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> References: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> Message-ID: <0ooShgkR_63utmBxQcMUwSLPZE8XW3TTJ3GPuB6zqao=.9e58bfc6-d3ac-4039-bbb6-a80e38de324c@github.com> On Thu, 11 Nov 2021 09:28:13 GMT, zhengxiaolinX wrote: > Hi team, > > x3 is a special register on RISCV and we should not use it as a register allocation candidate - if users write JNI programs referencing global variables, where ld could link global reference loading logic to an instruction like 'ld $Rtmp, $offset(x3)', and try to call vm functions, C1 will zap x3's value and causes a crash. It seems C2 doesn't use x3 so we are just aligning the logic with C2 properly. > > Thanks, > Xiaolin Thanks for the reviews, Fei and Aleksey. Seems I could integrate this patch and this repo's bot may need some minor adjustment in configuration. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/3 From shade at openjdk.java.net Mon Nov 15 08:34:55 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 15 Nov 2021 08:34:55 GMT Subject: [riscv-port] RFR: 8276988: riscv: Fix a register name string: lr to x5 In-Reply-To: References: Message-ID: On Thu, 11 Nov 2021 09:25:24 GMT, zhengxiaolinX wrote: > Hi team - > > Simply fix a register name string: `lr` is `names[1]` so `names[5]` should be `x5`. > > Thanks, > Xiaolin Marked as reviewed by shade (Reviewer). ------------- PR: https://git.openjdk.java.net/riscv-port/pull/2 From duke at openjdk.java.net Mon Nov 15 08:38:53 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 15 Nov 2021 08:38:53 GMT Subject: [riscv-port] RFR: 8276988: riscv: Fix a register name string: lr to x5 In-Reply-To: References: Message-ID: On Thu, 11 Nov 2021 09:25:24 GMT, zhengxiaolinX wrote: > Hi team - > > Simply fix a register name string: `lr` is `names[1]` so `names[5]` should be `x5`. > > Thanks, > Xiaolin Thanks - ------------- PR: https://git.openjdk.java.net/riscv-port/pull/2 From duke at openjdk.java.net Mon Nov 15 09:24:54 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 15 Nov 2021 09:24:54 GMT Subject: [riscv-port] Integrated: 8276988: riscv: Fix a register name string: lr to x5 In-Reply-To: References: Message-ID: <2akQky7M0pQMfnHuvJtpwHBApzgIIbCRbFW2_r3kUbI=.ebab2c6c-b770-49fd-8657-975a9060411f@github.com> On Thu, 11 Nov 2021 09:25:24 GMT, zhengxiaolinX wrote: > Hi team - > > Simply fix a register name string: `lr` is `names[1]` so `names[5]` should be `x5`. > > Thanks, > Xiaolin This pull request has now been integrated. Changeset: 30f10b49 Author: yunyao.zxl Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/30f10b4928fc94fd1c57246833673360e88e300b Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8276988: riscv: Fix a register name string: lr to x5 Reviewed-by: fyang, shade ------------- PR: https://git.openjdk.java.net/riscv-port/pull/2 From duke at openjdk.java.net Mon Nov 15 09:28:18 2021 From: duke at openjdk.java.net (duke) Date: Mon, 15 Nov 2021 09:28:18 GMT Subject: git: openjdk/riscv-port: riscv-port: Adjust jcheck config for RISC-V Port Message-ID: Changeset: 0d4f12f5 Author: Fei Yang Date: 2021-11-15 04:27:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0d4f12f5a78214e3ff702319baf1607bef9bb96e Adjust jcheck config for RISC-V Port ! .jcheck/conf From duke at openjdk.java.net Mon Nov 15 09:28:59 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 15 Nov 2021 09:28:59 GMT Subject: [riscv-port] Integrated: 8276989: riscv: C1 should not allocate x3, which is the gp register In-Reply-To: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> References: <-zQCZoC_Vv85cKHlK-QpaTP7H0hVNt-hpANqcQmVYQ0=.9b28c4d1-f869-44b8-ada8-1595e83fc720@github.com> Message-ID: On Thu, 11 Nov 2021 09:28:13 GMT, zhengxiaolinX wrote: > Hi team, > > x3 is a special register on RISCV and we should not use it as a register allocation candidate - if users write JNI programs referencing global variables, where ld could link global reference loading logic to an instruction like 'ld $Rtmp, $offset(x3)', and try to call vm functions, C1 will zap x3's value and causes a crash. It seems C2 doesn't use x3 so we are just aligning the logic with C2 properly. > > Thanks, > Xiaolin This pull request has now been integrated. Changeset: 7a735ca6 Author: yunyao.zxl Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/7a735ca64c767079caca852aef9959c2e072770f Stats: 8 lines in 3 files changed: 2 ins; 3 del; 3 mod 8276989: riscv: C1 should not allocate x3, which is the gp register Reviewed-by: fyang, shade ------------- PR: https://git.openjdk.java.net/riscv-port/pull/3 From duke at openjdk.java.net Tue Nov 16 11:48:11 2021 From: duke at openjdk.java.net (duke) Date: Tue, 16 Nov 2021 11:48:11 GMT Subject: git: openjdk/riscv-port: riscv-port: 107 new changesets Message-ID: <90dc0700-819c-4fe7-80a7-48c97fc61748@openjdk.java.net> Changeset: 88491549 Author: Ioi Lam Date: 2021-11-07 21:38:59 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/884915496f7bfe754279f1644603131c64f192b3 8275846: read_base_archive_name() could read past the end of buffer Reviewed-by: ccheung, stuefe ! src/hotspot/share/cds/filemap.cpp ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/ArchiveConsistency.java Changeset: 44047f84 Author: Yi Yang Date: 2021-11-08 02:18:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/44047f849fad157dac5df788aa5a2c1838e4aaf7 8274328: C2: Redundant CFG edges fixup in block ordering Reviewed-by: thartmann, kvn ! src/hotspot/share/opto/block.cpp ! src/hotspot/share/opto/block.hpp Changeset: 3934fe54 Author: Nick Gasson Date: 2021-11-08 06:40:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3934fe54b4c3e51add6d3fe1f145e5aebfe3b2fc 8275847: Scheduling fails with "too many D-U pinch points" on small method Reviewed-by: thartmann, kvn ! src/hotspot/cpu/x86/vmreg_x86.hpp ! src/hotspot/share/opto/buildOopMap.cpp ! src/hotspot/share/opto/output.cpp + test/hotspot/jtreg/compiler/c2/irTests/TestScheduleSmallMethod.java Changeset: fc0fe256 Author: Christian Stein Committer: Aleksey Shipilev Date: 2021-11-08 08:09:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/fc0fe256793b33430c1247e0c091150a091da3c4 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit Reviewed-by: shade ! test/jdk/tools/launcher/HelpFlagsTest.java Changeset: d8b0dee6 Author: Ludvig Janiuk Committer: Claes Redestad Date: 2021-11-08 09:44:44 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d8b0dee65e7e074d81eecf451542f79747ea7c78 8276239: Better tables in java.util.random package summary Reviewed-by: jlaskey ! src/java.base/share/classes/java/util/random/package-info.java Changeset: 0395e4ef Author: Hannes Walln?fer Date: 2021-11-08 11:35:26 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0395e4ef8ced8385cc2c9b3bea4c6f4490c62d2b 8276768: Snippet copy feature should use button instead of link Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/script.js ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetTag.java ! test/langtools/jdk/javadoc/lib/javadoc/tester/LinkChecker.java Changeset: 54481394 Author: Christian Hagedorn Date: 2021-11-08 12:47:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/54481394a3b7d36b2326e22e4aa910a3e8041b5c 8271056: C2: "assert(no_dead_loop) failed: dead loop detected" due to cmoving identity Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/cfgnode.cpp + test/hotspot/jtreg/compiler/c2/TestDeadDataLoopCmoveIdentity.java Changeset: ff6863c9 Author: Thomas Schatzl Date: 2021-11-08 12:59:00 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ff6863c98dbd15c4f3920402eb0991727d1a380c 8276540: Howl Full CardSet container iteration marks too many cards Reviewed-by: ayang, sjohanss ! src/hotspot/share/gc/g1/g1CardSetContainers.inline.hpp Changeset: 4c14eddf Author: Jan Lahoda Date: 2021-11-08 13:19:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4c14eddf41f1d9984417dc5ac6aba6f268b31029 8274734: the method jdk.jshell.SourceCodeAnalysis documentation not working Reviewed-by: vromero ! src/jdk.jshell/share/classes/jdk/jshell/SourceCodeAnalysisImpl.java + test/langtools/jdk/jshell/MultipleDocumentationTest.java Changeset: fa754b8f Author: Jan Lahoda Date: 2021-11-08 13:20:44 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/fa754b8ffda0ae16cda03d896260870ff8fb6ae9 8276149: jshell throws EOF error when throwing exception inside switch expression Reviewed-by: vromero ! src/jdk.jshell/share/classes/jdk/jshell/CompletenessAnalyzer.java ! test/langtools/jdk/jshell/CompletenessTest.java Changeset: 0c2d00bf Author: Jan Lahoda Date: 2021-11-08 13:21:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0c2d00bff7b96cca53820aadfdaf09c840a2a33a 8275097: Wrong span of the 'default' tag Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! test/langtools/tools/javac/parser/JavacParserTest.java ! test/langtools/tools/javac/patterns/SwitchErrors.out Changeset: cc2cac13 Author: Petr Portnov Committer: Roger Riggs Date: 2021-11-08 13:22:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cc2cac130cc28730a30d2e1d76bcb6ec8bc0b580 8274686: java.util.UUID#hashCode() should use Long.hashCode() Reviewed-by: rriggs ! src/java.base/share/classes/java/util/UUID.java Changeset: 71c4b195 Author: Andy Herrick Date: 2021-11-08 13:45:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/71c4b195178029f5414fa45d2c5ac70a1d2536e5 8276562: Fix to JDK-8263155 left out the help text changes Reviewed-by: asemenyuk, almatvee ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_ja.properties ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_zh_CN.properties Changeset: c815c5cb Author: Denghui Dong Date: 2021-11-08 14:30:54 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c815c5cbbb0b6a2aebd0a38cb930c74bd665d082 8276209: Some call sites doesn't pass the parameter 'size' to SharedRuntime::dtrace_object_alloc(_base) Reviewed-by: dholmes, coleenp ! src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp ! src/hotspot/cpu/aarch64/templateTable_aarch64.cpp ! src/hotspot/cpu/arm/templateTable_arm.cpp ! src/hotspot/cpu/ppc/c1_Runtime1_ppc.cpp ! src/hotspot/cpu/ppc/templateTable_ppc_64.cpp ! src/hotspot/cpu/s390/c1_Runtime1_s390.cpp ! src/hotspot/cpu/s390/templateTable_s390.cpp ! src/hotspot/cpu/x86/c1_Runtime1_x86.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/share/gc/shared/memAllocator.cpp ! src/hotspot/share/opto/macro.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp Changeset: ea23e733 Author: Daniel D. Daugherty Date: 2021-11-08 14:45:04 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ea23e7333e03abb4aca3e9f3854bab418a4b70e2 8249004: Reduce ThreadsListHandle overhead in relation to direct handshakes Reviewed-by: coleenp, sspitsyn, dholmes, rehn ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiEventController.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/handshake.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: 7320b77b Author: Thomas Schatzl Date: 2021-11-08 15:00:31 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7320b77b3e451932ee8befa7af4b80593725761e 8276548: Use range based visitor for Howl-Full cards Reviewed-by: ayang, sjohanss ! src/hotspot/share/gc/g1/g1CardSetContainers.inline.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp Changeset: 75adf54b Author: Aleksey Shipilev Date: 2021-11-08 15:35:27 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/75adf54bdcc5e06fb8e8ca499a2f326d70b65f76 8276306: jdk/jshell/CustomInputToolBuilder.java fails intermittently on storage acquisition Reviewed-by: jlahoda ! test/langtools/jdk/jshell/CustomInputToolBuilder.java Changeset: 7e73bca0 Author: Roger Riggs Date: 2021-11-08 16:39:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7e73bca0b7a34af9fb73780491951539815651b4 8276408: Deprecate Runtime.exec methods with a single string command line argument Reviewed-by: alanb ! src/java.base/share/classes/java/lang/Runtime.java ! test/jdk/java/lang/ProcessBuilder/Zombies.java ! test/jdk/java/lang/RuntimeTests/exec/BadEnvp.java ! test/jdk/java/lang/RuntimeTests/exec/ExecWithDir.java ! test/jdk/java/lang/RuntimeTests/exec/SetCwd.java Changeset: e383d263 Author: Jonathan Gibbons Date: 2021-11-08 19:13:22 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e383d263610c7b4d4be2dce599a9043b8f76cd64 8275199: Bogus warning generated for serializable records Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ClassBuilder.java ! test/langtools/jdk/javadoc/doclet/testRecordTypes/TestRecordTypes.java = test/langtools/jdk/javadoc/doclet/testRecordTypes/jdk17/element-list Changeset: 905e3e88 Author: Eamonn McManus Date: 2021-11-08 19:57:44 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/905e3e88137d46f90de7034e9fc324e97af873a6 8231490: Ugly racy writes to ZipUtils.defaultBuf Reviewed-by: lancea ! src/java.base/share/classes/java/util/zip/Inflater.java Changeset: 14d66bd4 Author: Andrew Leonard Date: 2021-11-08 20:37:24 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/14d66bd438dfa1feeafaca39be8f79a91e2968e9 8276654: element-list order is non deterministic Reviewed-by: ihse ! make/modules/jdk.javadoc/Gendata.gmk Changeset: a7dedb5f Author: Joe Darcy Date: 2021-11-08 22:19:55 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a7dedb5f4761a7d0bc4db658d96d369b13b80620 8276772: Refine javax.lang.model docs Reviewed-by: iris, vromero ! src/java.compiler/share/classes/javax/lang/model/SourceVersion.java ! src/java.compiler/share/classes/javax/lang/model/element/AnnotationMirror.java ! src/java.compiler/share/classes/javax/lang/model/element/Element.java ! src/java.compiler/share/classes/javax/lang/model/element/ElementVisitor.java ! src/java.compiler/share/classes/javax/lang/model/element/RecordComponentElement.java ! src/java.compiler/share/classes/javax/lang/model/element/TypeElement.java ! src/java.compiler/share/classes/javax/lang/model/type/NoType.java ! src/java.compiler/share/classes/javax/lang/model/type/NullType.java ! src/java.compiler/share/classes/javax/lang/model/type/PrimitiveType.java ! src/java.compiler/share/classes/javax/lang/model/util/Elements.java Changeset: 38e6d5d6 Author: Bradford Wetmore Date: 2021-11-09 01:11:18 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/38e6d5d6ed967f68e6ac1bfaa285efa16577c790 8276677: Malformed Javadoc inline tags in JDK source in javax/net/ssl Reviewed-by: jnimeh ! src/java.base/share/classes/javax/net/ssl/SSLEngine.java ! src/java.base/share/classes/javax/net/ssl/SSLSocket.java Changeset: 8747882e Author: Ioi Lam Date: 2021-11-09 07:18:06 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8747882e4cb3af58062923bf830f9de877bdb03d 8276790: Rename GenericCDSFileMapHeader::_base_archive_path_offset Reviewed-by: dholmes, ccheung ! src/hotspot/share/cds/cdsConstants.cpp ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/cds/filemap.hpp ! src/hotspot/share/include/cds.h ! test/hotspot/jtreg/runtime/cds/appcds/SharedArchiveConsistency.java ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/ArchiveConsistency.java ! test/lib/jdk/test/lib/cds/CDSArchiveUtils.java Changeset: 945f4085 Author: Stefan Johansson Date: 2021-11-09 11:11:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/945f4085e5c51f37c2048bb221a1521895ba28c6 8276098: Do precise BOT updates in G1 evacuation phase Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1AllocRegion.cpp ! src/hotspot/share/gc/g1/g1AllocRegion.hpp ! src/hotspot/share/gc/g1/g1AllocRegion.inline.hpp ! src/hotspot/share/gc/g1/g1Allocator.cpp ! src/hotspot/share/gc/g1/g1Allocator.hpp ! src/hotspot/share/gc/g1/g1Allocator.inline.hpp ! src/hotspot/share/gc/g1/g1BlockOffsetTable.hpp ! src/hotspot/share/gc/g1/g1BlockOffsetTable.inline.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegion.hpp ! src/hotspot/share/gc/g1/heapRegion.inline.hpp ! src/hotspot/share/gc/shared/plab.hpp Changeset: 5c7f77c8 Author: Thomas Schatzl Date: 2021-11-09 13:07:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5c7f77c82404976a6ca1d54b40f1969eac10d63b 8276850: Remove outdated comment in HeapRegionManager::par_iterate Reviewed-by: ayang, sjohanss ! src/hotspot/share/gc/g1/heapRegionManager.cpp Changeset: 4bd5bfd8 Author: Thomas Stuefe Date: 2021-11-09 14:12:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4bd5bfd8e2624715ebfa6e4c49172361389fbc98 8276731: Metaspace chunks are uncommitted twice Reviewed-by: shade, coleenp ! src/hotspot/share/memory/metaspace/chunkManager.cpp Changeset: e1985947 Author: Masanori Yano Committer: Alan Bateman Date: 2021-11-09 14:28:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e198594753b0b0653256923586c7f4ec9e3cfac3 8250678: ModuleDescriptor.Version parsing treats empty segments inconsistently Reviewed-by: mchung, alanb ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java ! test/jdk/java/lang/module/VersionTest.java Changeset: c27afb31 Author: Weijun Wang Date: 2021-11-09 14:46:32 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c27afb313b77d19e7ace7101c6f21aa5b2c56505 8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java Reviewed-by: ascarpino - test/jdk/sun/security/ec/ECDSAJavaVerify.java Changeset: f65db88b Author: Yasumasa Suenaga Date: 2021-11-09 14:54:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f65db88b74911e5896d2ff536c4ac97e7f62d98b 8276841: Add support for Visual Studio 2022 Reviewed-by: erikj, ihse ! make/autoconf/toolchain_microsoft.m4 Changeset: e35abe32 Author: Hannes Walln?fer Date: 2021-11-09 15:05:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e35abe3235ab38985a19545e76c58260ec97c718 8256208: Javadoc's generated overview does not show classes of unnamed package Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexWriter.java ! test/langtools/jdk/javadoc/doclet/testUnnamedPackage/TestUnnamedPackage.java = test/langtools/jdk/javadoc/doclet/testUnnamedPackage/src1/pkg/D.java + test/langtools/jdk/javadoc/doclet/testUnnamedPackage/src1/pkg/package.html Changeset: 93692ea0 Author: Andrey Turbanov Committer: Chris Plummer Date: 2021-11-09 16:58:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/93692ea0a9bc437309b808f511c771a79dcdfb9a 8274395: Use enhanced-for instead of plain 'for' in jdk.internal.jvmstat Reviewed-by: cjplummer, amenkov, sspitsyn ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/monitor/HostIdentifier.java ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/monitor/VmIdentifier.java ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/PerfDataBufferImpl.java ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalMonitoredVm.java ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalVmManager.java ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/MonitoredHostProvider.java ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/v2_0/TypeCode.java Changeset: daf77ebf Author: Leo Korinth Date: 2021-11-09 17:50:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/daf77ebfc4ca6d537ef55acbd62b908b5575ad08 8276337: Use override specifier in HeapDumper Reviewed-by: stuefe, dholmes ! src/hotspot/share/services/heapDumper.cpp Changeset: dde959df Author: Brian Burkhalter Date: 2021-11-09 19:17:59 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/dde959dfcef01897fdf51f820d414402e6309b8d 8276808: java/nio/channels/Channels/TransferTo.java timed out Reviewed-by: lancea, shade ! test/jdk/java/nio/channels/Channels/TransferTo.java Changeset: a60e9125 Author: Pankaj Bansal Date: 2021-11-09 20:10:20 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a60e91259ba83d2a525b612b2c7a1fd7934b88a2 8198626: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac Reviewed-by: serb ! test/jdk/ProblemList.txt ! test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.java Changeset: 055de6f5 Author: Hannes Walln?fer Date: 2021-11-09 20:11:18 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/055de6f566208b168818be1dc3ad29cdb9caa1cf 8223358: Incorrect HTML structure in annotation pages Reviewed-by: jjg + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeMemberWriterImpl.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlIds.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SummaryListWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/WriterFactoryImpl.java + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/AnnotationTypeMemberWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/AnnotationTypeOptionalMemberWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/AnnotationTypeRequiredMemberWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WriterFactory.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AbstractMemberBuilder.java + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeMemberBuilder.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/BuilderFactory.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ClassBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/VisibleMemberTable.java ! test/langtools/jdk/javadoc/doclet/testAnnotationTypes/TestAnnotationTypes.java ! test/langtools/jdk/javadoc/doclet/testAnnotationTypes/pkg/AnnotationType.java Changeset: f9024d06 Author: Hannes Walln?fer Date: 2021-11-09 20:17:25 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f9024d0606e39863b590f0d7c949d569f8bf8abd 8230130: javadoc search result dialog shows cut off headers for long results Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css Changeset: d7012fbd Author: Roger Riggs Date: 2021-11-09 20:43:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d7012fbd604fc1a54a2d7364a6ca4a32f47ffc7c 8276880: Remove java/lang/RuntimeTests/exec/ExecWithDir as unnecessary Reviewed-by: alanb - test/jdk/java/lang/RuntimeTests/exec/ExecWithDir.java Changeset: 06992208 Author: Rickard B?ckman Date: 2021-11-09 21:38:12 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0699220830a457959b784b35af125b70f43fa3b0 8268882: C2: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc Reviewed-by: neliasso, chagedorn, kvn ! src/hotspot/share/opto/postaloc.cpp Changeset: c8b0ee6b Author: Hamlin Li Date: 2021-11-10 01:12:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c8b0ee6b8a0c1bca8f8357e786f24c8cb6dd7310 8276833: G1: Make G1EvacFailureRegions::par_iterate const Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1EvacFailureRegions.cpp ! src/hotspot/share/gc/g1/g1EvacFailureRegions.hpp Changeset: c1e41fe3 Author: Hamlin Li Date: 2021-11-10 01:13:30 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c1e41fe38bbbae12e1f73d2cd63c7afffc19475b 8276842: G1: Only calculate size in bytes from words when needed Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1EvacFailure.cpp Changeset: 8822d41f Author: Jamil Nimeh Date: 2021-11-10 01:24:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8822d41fdcc2c2d568badd72635dc587d21dbd63 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily Reviewed-by: xuelei, wetmore ! src/java.base/share/classes/sun/security/ssl/TransportContext.java ! test/jdk/javax/net/ssl/templates/SSLSocketTemplate.java + test/jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java Changeset: e91e9d85 Author: Hamlin Li Date: 2021-11-10 01:26:35 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e91e9d853272ea8f5ce490f2f0c971fd40795d74 8276721: G1: Refine G1EvacFailureObjectsSet::iterate Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1EvacFailure.cpp ! src/hotspot/share/gc/g1/g1EvacFailureObjectsSet.cpp ! src/hotspot/share/gc/g1/g1EvacFailureObjectsSet.hpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegion.hpp Changeset: 403f3185 Author: Anirvan Sarkar Committer: Christoph Langer Date: 2021-11-10 05:51:39 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/403f3185f0988dcf6ef4e857d6659533bfa2943f 8276854: Windows GHA builds fail due to broken Cygwin Reviewed-by: clanger ! .github/workflows/submit.yml Changeset: fd0a25e6 Author: Aleksey Shipilev Date: 2021-11-10 07:59:01 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/fd0a25e62b2c8abc3a419c2e80abbcf11c9e882f 8276805: java/awt/print/PrinterJob/CheckPrivilege.java fails due to disabled SecurityManager Reviewed-by: serb, aivanov ! test/jdk/java/awt/print/PrinterJob/CheckPrivilege.java Changeset: e01d6d00 Author: Prasanta Sadhukhan Date: 2021-11-10 08:34:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e01d6d00bc4ab5ca0d38f8894a78e6d911e0fe93 8276679: Malformed Javadoc inline tags in JDK source in javax/swing Reviewed-by: aivanov, pbansal ! src/java.desktop/share/classes/javax/swing/JTree.java ! src/java.desktop/share/classes/javax/swing/SwingUtilities.java ! src/java.desktop/share/classes/javax/swing/event/HyperlinkEvent.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java Changeset: 0f463a7b Author: Aleksey Shipilev Date: 2021-11-10 09:50:27 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0f463a7bf73791eda9404882ff63daf9040399bb 8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32 Reviewed-by: alanb ! test/jdk/java/nio/file/spi/TestProvider.java Changeset: a3f710ef Author: Aleksey Shipilev Date: 2021-11-10 10:45:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a3f710efbe7dcef18477a96fd306bec19f181f8b 8276215: Intrinsics matchers should handle native method flags better Reviewed-by: dholmes, kvn ! src/hotspot/share/classfile/vmIntrinsics.cpp ! src/hotspot/share/classfile/vmIntrinsics.hpp Changeset: a0b84453 Author: Aleksey Shipilev Date: 2021-11-10 11:27:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a0b84453b087ff368a32b93729c5b30fda22ed48 8276846: JDK-8273416 is incomplete for UseSSE=1 Reviewed-by: neliasso, kvn ! src/hotspot/cpu/x86/x86_32.ad Changeset: 0f23c6a9 Author: Sergey Tsypanov Committer: Claes Redestad Date: 2021-11-10 12:46:30 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0f23c6a9feb3657eb20ff5988a9e2ffca2108af1 8276926: Use String.valueOf() when initializing File.separator and File.pathSeparator Reviewed-by: redestad, jlaskey ! src/java.base/share/classes/java/io/File.java Changeset: 55b36c6f Author: Harold Seigel Date: 2021-11-10 13:11:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/55b36c6f3bb7eb066daaf41f9eba46633afedf08 8276825: hotspot/runtime/SelectionResolution test errors Reviewed-by: dholmes, shade ! test/hotspot/jtreg/runtime/SelectionResolution/classes/selectionresolution/ClassBuilder.java ! test/hotspot/jtreg/runtime/SelectionResolution/classes/selectionresolution/Clazz.java ! test/hotspot/jtreg/runtime/SelectionResolution/classes/selectionresolution/TestBuilder.java Changeset: 38ec3a16 Author: Yasumasa Suenaga Date: 2021-11-10 14:33:02 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/38ec3a16d722d740d0b2128c6f6c2d1eab7a7c08 8276672: Cannot build hsdis on WSL Co-authored-by: Magnus Ihse Bursie Co-authored-by: Yasumasa Suenaga Reviewed-by: ihse, erikj ! make/Hsdis.gmk Changeset: f561d3c1 Author: Aleksey Shipilev Date: 2021-11-10 14:41:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f561d3c1942ce901fa77c907839032f76feb6998 8276864: Update boot JDKs to 17.0.1 in GHA Reviewed-by: erikj, ihse ! make/conf/test-dependencies Changeset: ce3ed65a Author: Jonathan Gibbons Date: 2021-11-10 15:24:27 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ce3ed65ac3411a533052a8c01231f7e540803afb 8273154: Provide a JavadocTester method for non-overlapping, unordered output matching Reviewed-by: prappo ! test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java + test/langtools/jdk/javadoc/testJavadocTester/TestJavadocTester.java Changeset: a5c160c7 Author: Weijun Wang Date: 2021-11-10 19:35:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a5c160c711a3f66db18c75973f4efdea63332863 8267108: Alternate Subject.getSubject and doAs APIs that do not depend on Security Manager APIs Reviewed-by: mullan ! src/java.base/share/classes/javax/security/auth/Subject.java ! src/java.security.jgss/share/classes/sun/security/jgss/GSSUtil.java ! src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5AcceptCredential.java ! src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java ! src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java ! src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Util.java ! test/jdk/com/sun/security/sasl/gsskerb/AuthOnly.java ! test/jdk/com/sun/security/sasl/gsskerb/ConfSecurityLayer.java ! test/jdk/com/sun/security/sasl/gsskerb/NoSecurityLayer.java ! test/jdk/java/security/AccessController/PreserveCombiner.java + test/jdk/javax/security/auth/Subject/CurrentSubject.java ! test/jdk/javax/security/auth/Subject/DoAs.java + test/jdk/javax/security/auth/Subject/Exceptions.java + test/jdk/javax/security/auth/Subject/FromACC.java ! test/jdk/javax/security/auth/Subject/Synch.java ! test/jdk/sun/security/krb5/KrbCredSubKey.java ! test/jdk/sun/security/krb5/ServiceCredsCombination.java ! test/jdk/sun/security/krb5/auto/Context.java ! test/jdk/sun/security/krb5/auto/HttpNegotiateServer.java ! test/jdk/sun/security/krb5/auto/LongLife.java Changeset: 67c2714b Author: Coleen Phillimore Date: 2021-11-10 19:45:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/67c2714ba2c9658e07153a6f50391c896e4caebc 8276889: Improve compatibility discussion in instanceKlass.cpp Reviewed-by: hseigel ! src/hotspot/share/oops/instanceKlass.cpp Changeset: 2374abda Author: Alisen Chung Committer: Alexey Ivanov Date: 2021-11-10 20:08:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2374abda19213d615a72c83f584ea61d5bbba4a3 8276678: Malformed Javadoc inline tags in JDK source in com/sun/beans/decoder/DocumentHandler.java Reviewed-by: serb, aivanov ! src/java.desktop/share/classes/com/sun/beans/decoder/DocumentHandler.java Changeset: df02daa6 Author: Ioi Lam Date: 2021-11-10 20:22:41 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/df02daa6f9df801a7e0b6203fd6411d8a62bb277 8269986: Remove +3 from Symbol::identity_hash() Reviewed-by: coleenp ! src/hotspot/share/oops/symbol.hpp Changeset: 0c409cac Author: Naoto Sato Date: 2021-11-10 20:52:11 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0c409cac789f1b1d21e09a65db36bb6c72c569db 8276186: Require getAvailableLocales() methods to include Locale.ROOT Reviewed-by: prappo, smarks, iris ! src/java.base/share/classes/java/text/BreakIterator.java ! src/java.base/share/classes/java/text/Collator.java ! src/java.base/share/classes/java/text/DateFormat.java ! src/java.base/share/classes/java/text/DateFormatSymbols.java ! src/java.base/share/classes/java/text/DecimalFormatSymbols.java ! src/java.base/share/classes/java/text/NumberFormat.java ! src/java.base/share/classes/java/time/format/DecimalStyle.java ! src/java.base/share/classes/java/util/Calendar.java ! src/java.base/share/classes/java/util/Locale.java + test/jdk/java/util/Locale/RequiredAvailableLocalesTest.java Changeset: bce35ac1 Author: Naoto Sato Date: 2021-11-10 20:53:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/bce35ac1d6c4115148468a3240ad459074e0b79e 8276775: ZonedDateTime/OffsetDateTime.toString return invalid ISO-8601 for years <= 1893 Reviewed-by: lancea, iris, bpb, scolebourne, rriggs ! src/java.base/share/classes/java/time/OffsetDateTime.java ! src/java.base/share/classes/java/time/ZonedDateTime.java Changeset: 73e6d7d7 Author: Zhengyu Gu Date: 2021-11-11 00:14:52 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/73e6d7d74d2ddd27f11775944c6fc4fb5268106d 8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp ! src/hotspot/share/gc/shenandoah/shenandoahNMethod.cpp Changeset: e27a67a9 Author: Jesper Wilhelmsson Date: 2021-11-11 01:14:30 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e27a67a91647e584411a9ef57c0a028ab37af19b 8276930: Update ProblemList Reviewed-by: kevinw, dholmes ! test/jdk/ProblemList.txt Changeset: ad3be04d Author: Yoshiki Sato Committer: Naoto Sato Date: 2021-11-11 01:39:06 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ad3be04d2ac84836e393d696ff03ddfe72779094 8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766 Reviewed-by: naoto, coffeys ! src/java.base/share/classes/sun/util/resources/TimeZoneNames.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_de.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_es.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_fr.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_it.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_ja.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_ko.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_pt_BR.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_sv.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_zh_CN.java ! src/jdk.localedata/share/classes/sun/util/resources/ext/TimeZoneNames_zh_TW.java Changeset: 08e0fd67 Author: Hamlin Li Date: 2021-11-11 05:52:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/08e0fd6757ef15b71df0e86afd01211a6e48bd09 8276835: G1: make G1EvacFailureObjectsSet::record inline Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1EvacFailureObjectsSet.cpp ! src/hotspot/share/gc/g1/g1EvacFailureObjectsSet.hpp + src/hotspot/share/gc/g1/g1EvacFailureObjectsSet.inline.hpp ! src/hotspot/share/gc/g1/heapRegion.inline.hpp Changeset: 91bb0d65 Author: Aleksey Shipilev Date: 2021-11-11 07:07:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/91bb0d658bce010e74b248b56f0fa5b8a79e8802 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC Reviewed-by: pliden, stefank ! test/hotspot/jtreg/gc/TestSystemGC.java Changeset: 7a140af2 Author: Christian Hagedorn Date: 2021-11-11 08:03:01 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7a140af25362556ebe86147dcd74413e0044edc0 8276546: [IR Framework] Whitelist and ignore CompileThreshold Reviewed-by: kvn, neliasso ! test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java ! test/hotspot/jtreg/compiler/lib/ir_framework/driver/TestVMProcess.java + test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCompileThreshold.java Changeset: 9862cd07 Author: Hannes Walln?fer Date: 2021-11-11 09:13:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9862cd07c162fcc9cd5cbdd0aab564f446f9256c 8275786: New javadoc option to add script files to generated documentation Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlOptions.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Head.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/DocPaths.java ! test/langtools/jdk/javadoc/doclet/testHelpOption/TestHelpOption.java ! test/langtools/jdk/javadoc/doclet/testOptions/TestOptions.java + test/langtools/jdk/javadoc/doclet/testOptions/additional-script-1.js + test/langtools/jdk/javadoc/doclet/testOptions/additional-script-2.js ! test/langtools/jdk/javadoc/tool/CheckManPageOptions.java Changeset: aea09677 Author: casparcwang Committer: Hui Shi Date: 2021-11-11 10:39:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/aea096770e74b9c0e1556467705ffdd6cf843d9d 8275854: C2: assert(stride_con != 0) failed: missed some peephole opt Co-authored-by: Roland Westrelin Reviewed-by: thartmann, roland, kvn ! src/hotspot/share/opto/ifnode.cpp + test/hotspot/jtreg/compiler/loopopts/TestLoopEndNodeEliminate.java Changeset: c29cab8a Author: Tobias Hartmann Date: 2021-11-11 13:09:05 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c29cab8ab475055e02e4300f212907ff2db955ab 8276112: Inconsistent scalar replacement debug info at safepoints Reviewed-by: kvn, chagedorn ! src/hotspot/share/opto/callGenerator.cpp ! src/hotspot/share/opto/macro.hpp ! test/hotspot/jtreg/compiler/eliminateAutobox/TestIdentityWithEliminateBoxInDebugInfo.java + test/hotspot/jtreg/compiler/eliminateAutobox/TestSafepointDebugInfo.java Changeset: 2ca4ff87 Author: Aleksei Efimov Date: 2021-11-11 14:33:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2ca4ff87b7c31d56542bbdcea70e828be33f4e97 8244202: Implementation of JEP 418: Internet-Address Resolution SPI Co-authored-by: Chris Hegarty Co-authored-by: Daniel Fuchs Co-authored-by: Alan Bateman Reviewed-by: dfuchs, alanb, michaelm, chegar ! src/java.base/share/classes/java/lang/RuntimePermission.java ! src/java.base/share/classes/java/net/Inet4AddressImpl.java ! src/java.base/share/classes/java/net/Inet6AddressImpl.java ! src/java.base/share/classes/java/net/InetAddress.java ! src/java.base/share/classes/java/net/InetAddressImpl.java ! src/java.base/share/classes/java/net/doc-files/net-properties.html + src/java.base/share/classes/java/net/spi/InetAddressResolver.java + src/java.base/share/classes/java/net/spi/InetAddressResolverProvider.java ! src/java.base/share/classes/java/net/spi/package-info.java ! src/java.base/share/classes/jdk/internal/access/JavaNetInetAddressAccess.java ! src/java.base/share/classes/module-info.java + src/java.base/share/classes/sun/net/ResolverProviderConfiguration.java ! src/java.base/share/native/libnet/InetAddress.c ! src/java.base/share/native/libnet/net_util.c ! src/java.base/share/native/libnet/net_util.h ! src/java.base/unix/native/libnet/Inet4AddressImpl.c ! src/java.base/unix/native/libnet/Inet6AddressImpl.c ! src/java.base/windows/native/libnet/Inet6AddressImpl.c + test/jdk/java/net/spi/InetAddressResolverProvider/AddressesCachingTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/BootstrapResolverUsageTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/BuiltInResolverTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/EmptyResultsStreamTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/ForeverCache.props + test/jdk/java/net/spi/InetAddressResolverProvider/InetAddressUsageInGetProviderTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/LookupPolicyMappingTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/LookupPolicyOfTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/NeverCache.props + test/jdk/java/net/spi/InetAddressResolverProvider/ProviderGetExceptionTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/ResolutionWithExceptionTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/ResolvePermissionTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/ReverseLookupDelegationTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/RuntimePermissionTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/addresses.txt + test/jdk/java/net/spi/InetAddressResolverProvider/lib/test.library/module-info.java + test/jdk/java/net/spi/InetAddressResolverProvider/lib/test.library/testlib/ResolutionRegistry.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/bootstrapUsage/bootstrap.usage.provider/impl/WithBootstrapResolverUsageProvider.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/bootstrapUsage/bootstrap.usage.provider/module-info.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/delegating/delegating.provider/impl/DelegatingProviderImpl.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/delegating/delegating.provider/module-info.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/empty/empty.results.provider/impl/EmptyResultsProviderImpl.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/empty/empty.results.provider/module-info.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/faulty/faulty.provider/impl/FaultyResolverProviderGetImpl.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/faulty/faulty.provider/module-info.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/recursive/recursive.init.provider/impl/InetAddressUsageInGetProviderImpl.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/recursive/recursive.init.provider/module-info.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/simple/simple.provider/impl/SimpleResolverProviderImpl.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/simple/simple.provider/module-info.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/throwing/throwing.lookups.provider/impl/ThrowingLookupsProviderImpl.java + test/jdk/java/net/spi/InetAddressResolverProvider/providers/throwing/throwing.lookups.provider/module-info.java + test/jdk/java/net/spi/InetAddressResolverProvider/serviceProviderOriginType/classpath/ClasspathProviderTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/serviceProviderOriginType/classpath/ClasspathResolverProviderImpl.java + test/jdk/java/net/spi/InetAddressResolverProvider/serviceProviderOriginType/classpath/META-INF/services/java.net.spi.InetAddressResolverProvider + test/jdk/java/net/spi/InetAddressResolverProvider/serviceProviderOriginType/classpath/addresses.txt + test/jdk/java/net/spi/InetAddressResolverProvider/serviceProviderOriginType/module/ModularProviderTest.java + test/jdk/java/net/spi/InetAddressResolverProvider/serviceProviderOriginType/module/addresses.txt ! test/lib/jdk/test/lib/net/IPSupport.java Changeset: 5e98f993 Author: Ludvig Janiuk Committer: Alexey Ivanov Date: 2021-11-11 16:46:52 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5e98f993b3cd68bb8564ea904f322235f55c4a7c 8276800: Fix table headers in NumericShaper.html Reviewed-by: naoto, aivanov ! src/java.desktop/share/classes/java/awt/font/NumericShaper.java Changeset: 6f35eede Author: Alexander Zvegintsev Date: 2021-11-11 16:53:27 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6f35eede4576b6252544f553c3651312b024e7ea 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails Reviewed-by: serb ! test/jdk/ProblemList.txt ! test/jdk/java/awt/Frame/MiscUndecorated/RepaintTest.java Changeset: 8aae88b0 Author: Alan Bateman Date: 2021-11-11 19:07:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8aae88b0fc4acb76ef140f120712403cf4b04a46 8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out" Reviewed-by: dfuchs ! test/jdk/java/nio/channels/SocketChannel/AdaptorStreams.java Changeset: b0d7a9da Author: Lance Andersen Date: 2021-11-11 19:09:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b0d7a9daa6ceb1959bc701043fe3f0397d2ba6f7 8276994: java/nio/channels/Channels/TransferTo.java leaves multi-GB files in /tmp Reviewed-by: alanb ! test/jdk/java/nio/channels/Channels/TransferTo.java Changeset: 0ca0acf6 Author: Claes Redestad Date: 2021-11-11 20:36:46 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0ca0acf63cb5cec4c62a9948956a04822d6f74a5 8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges Reviewed-by: rriggs, naoto ! src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java Changeset: 3445e50b Author: David Holmes Date: 2021-11-11 22:10:18 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3445e50bd573857660908a964886f94714315f4c 8276265: jcmd man page is outdated Reviewed-by: stuefe, cjplummer ! src/jdk.jcmd/share/man/jcmd.1 Changeset: 6954b98f Author: Evgeny Astigeevich Committer: Paul Hohensee Date: 2021-11-11 22:23:35 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6954b98f8faf29b6c2d13687a7a94e83302bdd85 8186670: Implement _onSpinWait() intrinsic for AArch64 Reviewed-by: phh, aph ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/globals_aarch64.hpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp + src/hotspot/cpu/aarch64/spin_wait_aarch64.hpp ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp ! src/hotspot/cpu/aarch64/vm_version_aarch64.hpp + test/hotspot/jtreg/compiler/onSpinWait/TestOnSpinWaitAArch64.java + test/hotspot/jtreg/compiler/onSpinWait/TestOnSpinWaitNoneAArch64.java + test/micro/org/openjdk/bench/java/lang/ThreadOnSpinWait.java + test/micro/org/openjdk/bench/java/lang/ThreadOnSpinWaitProducerConsumer.java + test/micro/org/openjdk/bench/java/lang/ThreadOnSpinWaitSharedCounter.java Changeset: 1e941ded Author: Andrey Turbanov Committer: Roger Riggs Date: 2021-11-11 22:26:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1e941dedad0ff6282ca4c1d2d71512974c97fc5e 8275197: Remove unused fields in ThaiBuddhistChronology Reviewed-by: naoto, rriggs, iris ! src/java.base/share/classes/java/time/chrono/ThaiBuddhistChronology.java Changeset: 6b833db3 Author: Per Liden Date: 2021-11-12 08:19:03 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6b833db3f9cace8fbb09bb803ba31208e37a4622 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases? Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/shared/gcTimer.cpp Changeset: 710f4964 Author: Nils Eliasson Date: 2021-11-12 10:08:26 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/710f496456d642c3e98d230270598f0b2dc75aba 8273277: C2: Move conditional negation into rc_predicate Reviewed-by: thartmann, chagedorn, kvn ! src/hotspot/share/opto/loopPredicate.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.hpp + test/hotspot/jtreg/compiler/loopopts/TestSkeletonPredicateNegation.java ! test/hotspot/jtreg/vmTestbase/jit/t/t105/t105.java Changeset: 13deb384 Author: Julia Boes Date: 2021-11-12 12:05:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/13deb38433444a196af5e22e9b29bea6a9a15400 8276848: sun.net.httpserver.simpleserver.CommandLinePositiveTest: test does not specify port Reviewed-by: dfuchs + test/jdk/com/sun/net/httpserver/simpleserver/CommandLinePortNotSpecifiedTest.java ! test/jdk/com/sun/net/httpserver/simpleserver/CommandLinePositiveTest.java Changeset: c4b44329 Author: Magnus Ihse Bursie Date: 2021-11-12 14:08:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c4b44329c1d250f790ca82dd419cdf3330da16f5 8277012: Use blessed modifier order in src/utils Reviewed-by: dholmes, stuefe ! src/utils/IdealGraphVisualizer/Bytecodes/src/main/java/com/sun/hotspot/igv/bytecodes/BytecodeViewTopComponent.java ! src/utils/IdealGraphVisualizer/ControlFlow/src/main/java/com/sun/hotspot/igv/controlflow/ControlFlowTopComponent.java ! src/utils/IdealGraphVisualizer/Data/src/main/java/com/sun/hotspot/igv/data/serialization/BinaryParser.java ! src/utils/IdealGraphVisualizer/FilterWindow/src/main/java/com/sun/hotspot/igv/filterwindow/FilterTopComponent.java ! src/utils/IdealGraphVisualizer/Settings/src/main/java/com/sun/hotspot/igv/settings/Settings.java ! src/utils/LogCompilation/src/main/java/com/sun/hotspot/tools/compiler/BasicLogEvent.java ! src/utils/LogCompilation/src/main/java/com/sun/hotspot/tools/compiler/LogCleanupReader.java ! src/utils/LogCompilation/src/main/java/com/sun/hotspot/tools/compiler/LogParser.java ! src/utils/src/build/tools/commentchecker/CommentChecker.java ! src/utils/src/build/tools/dirdiff/DirDiff.java Changeset: 51a5731d Author: Magnus Ihse Bursie Date: 2021-11-12 14:12:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/51a5731d6dc4b6f6feac920a4b8b49c15fd6b34f 8277016: Use blessed modifier order in jdk.httpserver Reviewed-by: dfuchs ! src/jdk.httpserver/share/classes/sun/net/httpserver/ChunkedInputStream.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/ChunkedOutputStream.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/Request.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/ServerImpl.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/SimpleFileServerImpl.java Changeset: aeba6530 Author: Andrew Leonard Date: 2021-11-12 14:43:54 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/aeba65303479130d9bab74484accad5d7d116a40 8276743: Make openjdk build Zip Archive generation "reproducible" Reviewed-by: erikj, ihse ! make/Main.gmk ! make/ToolsJdk.gmk ! make/common/ZipArchive.gmk + make/jdk/src/classes/build/tools/makezipreproducible/MakeZipReproducible.java Changeset: 3b2585c0 Author: Coleen Phillimore Date: 2021-11-12 16:17:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3b2585c02bd9d66cc2c8b2d5c16e9a48f4280d07 8276658: Clean up JNI local handles code Reviewed-by: dholmes, pchilanomate ! src/hotspot/share/ci/ciInstanceKlass.cpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/compiler/compileBroker.hpp ! src/hotspot/share/gc/shared/concurrentGCThread.cpp ! src/hotspot/share/jfr/dcmd/jfrDcmds.cpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.cpp ! src/hotspot/share/jvmci/jvmciCodeInstaller.cpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.hpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/prims/jvmtiExport.cpp ! src/hotspot/share/runtime/jniHandles.cpp ! src/hotspot/share/runtime/jniHandles.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp ! src/hotspot/share/runtime/nonJavaThread.cpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/hotspot/share/runtime/vmThread.cpp ! src/hotspot/share/runtime/vmThread.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaThread.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/Thread.java Changeset: 5a2452c8 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-11-12 16:30:56 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5a2452c80e64b8b7a1799caa1a8a6e9e6a7dab6d 8274835: Remove unnecessary castings in java.base Reviewed-by: mullan, naoto, lancea, bpb ! src/java.base/share/classes/java/io/SequenceInputStream.java ! src/java.base/share/classes/java/lang/ClassValue.java ! src/java.base/share/classes/java/lang/Enum.java ! src/java.base/share/classes/java/lang/StackTraceElement.java ! src/java.base/share/classes/java/security/Signature.java ! src/java.base/share/classes/java/util/GregorianCalendar.java ! src/java.base/share/classes/java/util/HashSet.java ! src/java.base/share/classes/java/util/stream/ReferencePipeline.java ! src/java.base/share/classes/sun/net/www/MimeTable.java ! src/java.base/share/classes/sun/net/www/protocol/http/AuthCacheImpl.java ! src/java.base/share/classes/sun/security/provider/DSAPublicKey.java ! src/java.base/share/classes/sun/security/provider/certpath/PKIX.java ! src/java.base/share/classes/sun/security/provider/certpath/RevocationChecker.java ! src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/java.base/share/classes/sun/util/calendar/Era.java Changeset: 0d2980cd Author: Coleen Phillimore Date: 2021-11-12 17:03:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0d2980cdd1486b0689a71fc107a1d4c100bd3025 8258192: Obsolete the CriticalJNINatives flag Reviewed-by: mdoerr, shade ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp ! src/hotspot/cpu/arm/sharedRuntime_arm.cpp ! src/hotspot/cpu/arm/vm_version_arm_32.cpp ! src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp ! src/hotspot/cpu/s390/sharedRuntime_s390.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/cpu/zero/sharedRuntime_zero.cpp ! src/hotspot/cpu/zero/vm_version_zero.cpp ! src/hotspot/share/prims/nativeLookup.cpp ! src/hotspot/share/prims/nativeLookup.hpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp ! test/hotspot/jtreg/TEST.groups - test/hotspot/jtreg/compiler/runtime/criticalnatives/argumentcorruption/CheckLongArgs.java - test/hotspot/jtreg/compiler/runtime/criticalnatives/argumentcorruption/libCNCheckLongArgs.c - test/hotspot/jtreg/compiler/runtime/criticalnatives/lookup/LookUp.java - test/hotspot/jtreg/compiler/runtime/criticalnatives/lookup/libCNLookUp.c - test/hotspot/jtreg/gc/CriticalNative.java - test/hotspot/jtreg/gc/CriticalNativeArgs.java - test/hotspot/jtreg/gc/libCriticalNative.c - test/hotspot/jtreg/gc/stress/CriticalNativeStress.java Changeset: b85500e5 Author: Lance Andersen Date: 2021-11-12 17:12:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b85500e52479c48b02a96b28fddefa2b25d5d9bd 8276123: ZipFile::getEntry will not return a file entry when there is a directory entry of the same name within a Zip File Reviewed-by: redestad, alanb ! src/java.base/share/classes/java/util/zip/ZipFile.java + test/jdk/java/util/zip/ZipFile/ZipFileDuplicateEntryTest.java Changeset: 74f3e69d Author: Daniel D. Daugherty Date: 2021-11-12 18:46:39 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/74f3e69dc888685558408e663df5d32cb906991f 8277071: [BACKOUT] JDK-8276743 Make openjdk build Zip Archive generation "reproducible" Reviewed-by: erikj ! make/Main.gmk ! make/ToolsJdk.gmk ! make/common/ZipArchive.gmk - make/jdk/src/classes/build/tools/makezipreproducible/MakeZipReproducible.java Changeset: 176d21d6 Author: Daniel D. Daugherty Date: 2021-11-12 19:06:01 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/176d21d6c525f8fd9592db5b4975308ea0001856 8276824: refactor Thread::is_JavaThread_protected Reviewed-by: coleenp, rehn, dholmes ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: 8c5f0304 Author: Man Cao Date: 2021-11-12 22:34:10 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8c5f03049196e66a4f8411bdd853b287134e7ce5 8276453: Undefined behavior in C1 LIR_OprDesc causes SEGV in fastdebug build Co-authored-by: Chuck Rasbold Co-authored-by: James Y Knight Reviewed-by: kvn, dlong ! src/hotspot/cpu/aarch64/c1_CodeStubs_aarch64.cpp ! src/hotspot/cpu/aarch64/c1_FrameMap_aarch64.cpp ! src/hotspot/cpu/aarch64/c1_LIRGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/z/zBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/arm/c1_CodeStubs_arm.cpp ! src/hotspot/cpu/arm/c1_FrameMap_arm.cpp ! src/hotspot/cpu/arm/c1_LIRGenerator_arm.cpp ! src/hotspot/cpu/ppc/c1_CodeStubs_ppc.cpp ! src/hotspot/cpu/ppc/c1_FrameMap_ppc.cpp ! src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp ! src/hotspot/cpu/ppc/gc/z/zBarrierSetAssembler_ppc.hpp ! src/hotspot/cpu/s390/c1_CodeStubs_s390.cpp ! src/hotspot/cpu/s390/c1_FrameMap_s390.cpp ! src/hotspot/cpu/x86/c1_CodeStubs_x86.cpp ! src/hotspot/cpu/x86/c1_FrameMap_x86.cpp ! src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp ! src/hotspot/cpu/x86/gc/z/zBarrierSetAssembler_x86.hpp ! src/hotspot/share/c1/c1_Compilation.hpp ! src/hotspot/share/c1/c1_FrameMap.hpp ! src/hotspot/share/c1/c1_Instruction.hpp ! src/hotspot/share/c1/c1_LIR.cpp ! src/hotspot/share/c1/c1_LIR.hpp ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_LIRGenerator.hpp ! src/hotspot/share/gc/g1/c1/g1BarrierSetC1.cpp ! src/hotspot/share/gc/g1/c1/g1BarrierSetC1.hpp ! src/hotspot/share/gc/shared/c1/barrierSetC1.hpp ! src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp ! src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.hpp ! src/hotspot/share/gc/shared/c1/modRefBarrierSetC1.hpp Changeset: 296780c7 Author: Thomas Stuefe Date: 2021-11-15 06:47:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/296780c7ae5c129d24997007600f428b697d3365 8276983: Small fixes to DumpAllocStat::print_stats Reviewed-by: dholmes, iklam ! src/hotspot/share/cds/dumpAllocStats.cpp Changeset: ca2efb73 Author: Richard Reingruber Date: 2021-11-15 07:02:22 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ca2efb73f59112d9be2ec29db405deb4c58dd435 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend Reviewed-by: cjplummer, sspitsyn, rschmelter ! src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c + test/jdk/com/sun/jdi/ResumeAfterThreadResumeCallTest.java Changeset: b231f5ba Author: Hamlin Li Date: 2021-11-15 10:08:14 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b231f5baa94c7104324cd206c1081b35fd27164c 8276921: G1: Remove redundant failed evacuation regions calculation in RemoveSelfForwardPtrHRClosure Reviewed-by: ayang, tschatzl ! src/hotspot/share/gc/g1/g1EvacFailure.cpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp Changeset: fdcd16a3 Author: Pavel Rappo Date: 2021-11-15 11:25:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/fdcd16a38fb9a14a819d68682f9666ebfe7285db 8277048: Tiny improvements to the specification text for java.util.Properties.load Reviewed-by: rriggs, iris, naoto ! src/java.base/share/classes/java/util/Properties.java Changeset: 02f79008 Author: Albert Mingkun Yang Date: 2021-11-15 12:46:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/02f79008828b3dcce3bd6492efaa43e99376c0c5 8276932: G1: Annotate methods with override explicitly in g1CollectedHeap.hpp Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp Changeset: 35a831d5 Author: Thomas Schatzl Date: 2021-11-15 14:34:19 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/35a831d5a755de8f3c71653bd0a37190adddb8ae 8272170: Missing memory barrier when checking active state for regions Reviewed-by: sjohanss, ayang ! src/hotspot/share/gc/g1/g1CommittedRegionMap.inline.hpp Changeset: 7fc344dc Author: Hannes Walln?fer Date: 2021-11-15 15:53:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7fc344dc96008f277dacf5518b28447f3a598cde 8277028: Use service type documentation as fallback for @provides Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModuleServices.java Changeset: 9046077f Author: Alexey Semenyuk Date: 2021-11-15 17:57:06 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9046077fe6ce7bb042fbd0fa1a80537cb4a60581 8276084: Linux DEB Bundler: release number in outputted .deb file should be optional Reviewed-by: almatvee, herrick ! src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java ! src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxPackageBundler.java ! src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxRpmBundler.java ! src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.control ! test/jdk/tools/jpackage/helpers/jdk/jpackage/test/LinuxHelper.java ! test/jdk/tools/jpackage/linux/LinuxResourceTest.java ! test/jdk/tools/jpackage/linux/ReleaseTest.java Changeset: fe45835f Author: Alexey Semenyuk Date: 2021-11-15 17:57:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/fe45835f7cebfccd4544ae19d88bdc7f07560fbe 8274856: Failing jpackage tests with fastdebug/release build Reviewed-by: almatvee, herrick ! src/jdk.jpackage/linux/native/applauncher/LinuxLauncher.c ! src/jdk.jpackage/linux/native/libapplauncher/LinuxLauncherLib.cpp ! src/jdk.jpackage/share/native/applauncher/AppLauncher.cpp ! src/jdk.jpackage/share/native/applauncher/JvmLauncher.cpp ! src/jdk.jpackage/share/native/applauncher/JvmLauncher.h ! src/jdk.jpackage/share/native/applauncher/JvmLauncherLib.c ! src/jdk.jpackage/unix/native/common/UnixSysInfo.cpp ! src/jdk.jpackage/windows/native/applauncher/WinLauncher.cpp Changeset: 1830b8da Author: Thomas Schatzl Date: 2021-11-15 18:09:32 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1830b8da9028af430ee4791f310b5fc9cb1ff37d 8275056: Virtualize G1CardSet containers over heap region Reviewed-by: sjohanss, ayang ! src/hotspot/share/gc/g1/g1CardSet.cpp ! src/hotspot/share/gc/g1/g1CardSet.hpp ! src/hotspot/share/gc/g1/g1CardSet.inline.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1_globals.hpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegionBounds.hpp ! src/hotspot/share/gc/g1/heapRegionBounds.inline.hpp ! src/hotspot/share/gc/g1/heapRegionRemSet.cpp ! src/hotspot/share/gc/g1/heapRegionRemSet.inline.hpp ! test/hotspot/gtest/gc/g1/test_g1CardSet.cpp ! test/hotspot/jtreg/gc/arguments/TestG1HeapRegionSize.java Changeset: db0c8d52 Author: Andrey Turbanov Committer: Chris Plummer Date: 2021-11-15 19:14:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/db0c8d522704d2e12bce4ebeb9297b57e3789f4f 8274232: Cleanup unnecessary null comparison before instanceof check in jdk.jdi Reviewed-by: cjplummer, sspitsyn ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Commands.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/BooleanValueImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ByteValueImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/CharValueImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ConnectorImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/DoubleValueImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/FieldImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/FloatValueImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/IntegerValueImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/LocalVariableImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/LocationImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/LongValueImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/MethodImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/MirrorImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ObjectReferenceImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ShortValueImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/StackFrameImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/TypeImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VoidValueImpl.java Changeset: 7a870418 Author: Andrey Turbanov Committer: Chris Plummer Date: 2021-11-15 19:18:35 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7a870418a3e8de3b290ba71cbe4ca7979ec029f9 8275385: Change nested classes in jdk.jdi to static nested classes Reviewed-by: sspitsyn, amenkov, cjplummer ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/Commands.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ConnectorImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/SDE.java Changeset: 9326eb14 Author: Dean Long Date: 2021-11-15 21:09:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9326eb14617bf08e3376f854fc022e11d1ef34dd 8276095: ciReplay: replay failure due to incomplete ciMethodData information Reviewed-by: chagedorn, kvn ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/ci/ciMethodData.cpp ! src/hotspot/share/ci/ciMethodData.hpp ! src/hotspot/share/ci/ciReplay.cpp ! src/hotspot/share/ci/ciReplay.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ci/ciMethodData.java ! test/hotspot/jtreg/compiler/ciReplay/TestLambdas.java Changeset: a59c9b2a Author: Paul Sandoz Date: 2021-11-15 21:48:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a59c9b2ac277d6ff6be1700d91ff389f137e61ca 8271515: Integration of JEP 417: Vector API (Third Incubator) Co-authored-by: Sandhya Viswanathan Co-authored-by: Jatin Bhateja Co-authored-by: Ningsheng Jian Co-authored-by: Xiaohong Gong Co-authored-by: Eric Liu Co-authored-by: Jie Fu Co-authored-by: Vladimir Ivanov Co-authored-by: John R Rose Co-authored-by: Paul Sandoz Co-authored-by: Rado Smogura Reviewed-by: kvn, sviswanathan, ngasson ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/aarch64_sve.ad ! src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/gc/z/zBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/register_aarch64.cpp ! src/hotspot/cpu/aarch64/register_aarch64.hpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/arm/arm.ad ! src/hotspot/cpu/ppc/ppc.ad ! src/hotspot/cpu/s390/s390.ad ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_32.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/stubRoutines_x86.cpp ! src/hotspot/cpu/x86/stubRoutines_x86.hpp ! src/hotspot/cpu/x86/vm_version_x86.hpp ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/share/adlc/forms.cpp ! src/hotspot/share/adlc/formssel.cpp ! src/hotspot/share/classfile/vmIntrinsics.hpp ! src/hotspot/share/opto/c2compiler.cpp ! src/hotspot/share/opto/cfgnode.cpp ! src/hotspot/share/opto/cfgnode.hpp ! src/hotspot/share/opto/chaitin.cpp ! src/hotspot/share/opto/chaitin.hpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/lcm.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/library_call.hpp ! src/hotspot/share/opto/matcher.cpp ! src/hotspot/share/opto/matcher.hpp ! src/hotspot/share/opto/memnode.cpp ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/opto/postaloc.cpp ! src/hotspot/share/opto/regmask.cpp ! src/hotspot/share/opto/type.cpp ! src/hotspot/share/opto/type.hpp ! src/hotspot/share/opto/vector.cpp ! src/hotspot/share/opto/vectorIntrinsics.cpp ! src/hotspot/share/opto/vectornode.cpp ! src/hotspot/share/opto/vectornode.hpp ! src/hotspot/share/prims/vectorSupport.cpp ! src/hotspot/share/prims/vectorSupport.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/hotspot/share/utilities/growableArray.hpp ! src/java.base/share/classes/jdk/internal/misc/X-ScopedMemoryAccess.java.template ! src/java.base/share/classes/jdk/internal/vm/vector/VectorSupport.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractMask.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/DoubleMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/DoubleVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/FloatMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/FloatVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Long128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Long256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Long512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Long64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LongMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LongVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Short128Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Short256Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Short512Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Short64Vector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ShortMaxVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ShortVector.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMask.java ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template ! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-VectorBits.java.template ! src/jdk.incubator.vector/windows/native/libjsvml/globals_vectorApiSupport_windows.S.inc ! test/hotspot/gtest/aarch64/aarch64-asmtest.py ! test/hotspot/gtest/aarch64/asmtest.out.h + test/hotspot/jtreg/compiler/vectorapi/VectorMaskCastTest.java + test/hotspot/jtreg/compiler/vectorapi/VectorMaskLoadStoreTest.java + test/hotspot/jtreg/compiler/vectorapi/VectorMemoryAlias.java Changeset: bd92674b Author: Calvin Cheung Date: 2021-11-16 02:34:36 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/bd92674be563ad291990216b7cdf061c498f5dd3 8276184: Exclude lambda proxy class from the CDS archive if its caller class is excluded Reviewed-by: iklam, dholmes ! src/hotspot/share/cds/dynamicArchive.cpp ! src/hotspot/share/cds/metaspaceShared.cpp ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! src/hotspot/share/classfile/systemDictionaryShared.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! test/hotspot/jtreg/runtime/cds/appcds/LambdaContainsOldInf.java ! test/hotspot/jtreg/runtime/cds/appcds/SignedJar.java ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/LambdaContainsOldInf.java + test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/LambdaForOldInfInBaseArchive.java + test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/OldClassInBaseArchive.java + test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/RedefineCallerClassTest.java + test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/test-classes/RedefineCallerClass.java ! test/hotspot/jtreg/runtime/cds/appcds/test-classes/Hello.java ! test/hotspot/jtreg/runtime/cds/appcds/test-classes/LambdaContainsOldInfApp.java Changeset: fef1e172 Author: Fei Yang Date: 2021-11-16 06:40:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/fef1e1729d0b616e9860b07adc7c39c42711e4f8 Merge branch 'master' into riscv-port ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/riscv/c1_CodeStubs_riscv.cpp ! src/hotspot/cpu/riscv/c1_FrameMap_riscv.cpp ! src/hotspot/cpu/riscv/c1_LIRGenerator_riscv.cpp ! src/hotspot/cpu/riscv/c1_Runtime1_riscv.cpp ! src/hotspot/cpu/riscv/gc/z/zBarrierSetAssembler_riscv.hpp ! src/hotspot/cpu/riscv/riscv.ad ! src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp ! src/hotspot/cpu/riscv/templateTable_riscv.cpp ! src/hotspot/cpu/riscv/vm_version_riscv.cpp ! src/hotspot/share/c1/c1_LIR.cpp ! src/hotspot/share/c1/c1_LIR.hpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp + src/hotspot/cpu/riscv/c1_CodeStubs_riscv.cpp + src/hotspot/cpu/riscv/c1_FrameMap_riscv.cpp + src/hotspot/cpu/riscv/c1_LIRGenerator_riscv.cpp + src/hotspot/cpu/riscv/c1_Runtime1_riscv.cpp + src/hotspot/cpu/riscv/gc/z/zBarrierSetAssembler_riscv.hpp + src/hotspot/cpu/riscv/riscv.ad + src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp + src/hotspot/cpu/riscv/templateTable_riscv.cpp + src/hotspot/cpu/riscv/vm_version_riscv.cpp ! src/hotspot/share/c1/c1_LIR.cpp ! src/hotspot/share/c1/c1_LIR.hpp ! src/hotspot/share/runtime/os.cpp From duke at openjdk.java.net Thu Nov 18 12:43:33 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Thu, 18 Nov 2021 12:43:33 GMT Subject: [riscv-port] RFR: 8277391: riscv: Implement tls function MacroAssembler::get_thread() using tls.ie Message-ID: Hi team, This patch fixes the unimplemented assembly version of `__ get_thread()`, bringing some performance improvement by directly using the x4 register to refer to the variable `Thread::_thr_current`. Tested tests under hotspot/ and jdk/. [Original patch](https://github.com/riscv-collab/riscv-openjdk/pull/4) Thanks, Xiaolin ------------- Commit messages: - Implement tls function MacroAssembler::get_thread() using tls.ie Changes: https://git.openjdk.java.net/riscv-port/pull/7/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=7&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277391 Stats: 60 lines in 3 files changed: 44 ins; 12 del; 4 mod Patch: https://git.openjdk.java.net/riscv-port/pull/7.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/7/head:pull/7 PR: https://git.openjdk.java.net/riscv-port/pull/7 From duke at openjdk.java.net Thu Nov 18 12:45:35 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Thu, 18 Nov 2021 12:45:35 GMT Subject: [riscv-port] RFR: 8277392: riscv: Port missing trampoline logic from AArch64 platform Message-ID: Hi team, Java calls will jump to the trampoline stub even if the target address is directly reachable by using a simple `jal` before this patch. After adding back the logic from the AArch64 platform, we find a nearly 4% performance enhancement on SPECjbb2005/15. Tested tests under hotspot/ and jdk/. [Original Patch](https://github.com/riscv-collab/riscv-openjdk/pull/8) Thanks, Xiaolin ------------- Commit messages: - Port optimization for trampoline call patching logic Changes: https://git.openjdk.java.net/riscv-port/pull/8/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=8&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277392 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/riscv-port/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/8/head:pull/8 PR: https://git.openjdk.java.net/riscv-port/pull/8 From yzhu at openjdk.java.net Thu Nov 18 13:45:30 2021 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Thu, 18 Nov 2021 13:45:30 GMT Subject: [riscv-port] RFR: 8277167: riscv: Remove unnecessary register declaration for lr Message-ID: Currently, there are two register declarations for both 'ra' and 'lr' on riscv port. But they refer to the same register x1. Since 'ra' is the ABI name for register x1, we should keep register declaration for 'ra' and remove register declaration for 'lr' in order to avoid possible confusion. ------------- Commit messages: - 8277167: riscv: Remove unnecessary register declaration for lr Changes: https://git.openjdk.java.net/riscv-port/pull/6/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=6&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277167 Stats: 122 lines in 19 files changed: 1 ins; 4 del; 117 mod Patch: https://git.openjdk.java.net/riscv-port/pull/6.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/6/head:pull/6 PR: https://git.openjdk.java.net/riscv-port/pull/6 From fyang at openjdk.java.net Fri Nov 19 01:41:09 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 19 Nov 2021 01:41:09 GMT Subject: [riscv-port] RFR: 8277167: riscv: Remove unnecessary register declaration for lr In-Reply-To: References: Message-ID: On Thu, 18 Nov 2021 02:52:17 GMT, Yanhong Zhu wrote: > Currently, there are two register declarations for both 'ra' and 'lr' on riscv port. But they refer to the same register x1. Since 'ra' is the ABI name for register x1, we should keep register declaration for 'ra' and remove register declaration for 'lr' in order to avoid possible confusion. > Hotspot tier1 tests pass on QEMU. Nice cleanup. Looks good. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/6 From yzhu at openjdk.java.net Fri Nov 19 01:58:32 2021 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 19 Nov 2021 01:58:32 GMT Subject: [riscv-port] Integrated: 8277167: riscv: Remove unnecessary register declaration for lr In-Reply-To: References: Message-ID: On Thu, 18 Nov 2021 02:52:17 GMT, Yanhong Zhu wrote: > Currently, there are two register declarations for both 'ra' and 'lr' on riscv port. But they refer to the same register x1. Since 'ra' is the ABI name for register x1, we should keep register declaration for 'ra' and remove register declaration for 'lr' in order to avoid possible confusion. > Hotspot tier1 tests pass on QEMU. This pull request has now been integrated. Changeset: a8e5e560 Author: Yanhong Zhu Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/a8e5e56036b333051068752ee1269248c296d15b Stats: 122 lines in 19 files changed: 1 ins; 4 del; 117 mod 8277167: riscv: Remove unnecessary register declaration for lr Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/6 From yzhu at openjdk.java.net Fri Nov 19 02:46:29 2021 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 19 Nov 2021 02:46:29 GMT Subject: [riscv-port] RFR: 8277036: riscv: Get CPU features from the auxiliary vector on Linux Message-ID: Due to the lack of native environment in our early development of riscv port, we detect riscv CPU ISA extensions through checking whether simulator (e.g. QEMU) supports execution of one of the instructions in the corresponding feature spec or not. Fortunately, there are several riscv hardwares available now, we can directly get this CPU info from the auxiliary vector on Linux. Note that the aarch64 port also did the same thing on Linux platform. This has been tested on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu): # HiFive Unmatched $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt OpenJDK 64-Bit Server VM warning: RVV is not supported on this CPU bool UseVExt = false {ARCH product} {command line} openjdk version "18-internal" 2022-03-15 OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt bool UseVExt = false {ARCH product} {command line} openjdk version "18-internal" 2022-03-15 OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt bool UseVExt = false {ARCH product} {command line} openjdk version "18-internal" 2022-03-15 OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) # NeZha D1 $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt bool UseVExt = true {ARCH product} {command line} openjdk version "18-internal" 2022-03-15 OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt bool UseVExt = false {ARCH product} {command line} openjdk version "18-internal" 2022-03-15 OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt bool UseVExt = false {ARCH product} {command line} openjdk version "18-internal" 2022-03-15 OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) ------------- Commit messages: - 8277036: riscv: Get CPU features from the auxiliary vector on Linux Changes: https://git.openjdk.java.net/riscv-port/pull/10/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=10&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277036 Stats: 245 lines in 13 files changed: 115 ins; 112 del; 18 mod Patch: https://git.openjdk.java.net/riscv-port/pull/10.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/10/head:pull/10 PR: https://git.openjdk.java.net/riscv-port/pull/10 From fyang at openjdk.java.net Fri Nov 19 04:00:23 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 19 Nov 2021 04:00:23 GMT Subject: [riscv-port] RFR: 8277036: riscv: Get CPU features from the auxiliary vector on Linux In-Reply-To: References: Message-ID: <6Z0UqaHAXBcqv-NLJo4IwAyfrEunAcgeztb9CryrGI0=.9bda301c-63a4-4892-80b1-50ab1b699349@github.com> On Fri, 19 Nov 2021 02:39:12 GMT, Yanhong Zhu wrote: > Due to the lack of native environment in our early development of riscv port, we detect riscv CPU ISA extensions through checking whether simulator (e.g. QEMU) supports execution of one of the instructions in the corresponding feature spec or not. Fortunately, there are several riscv hardwares available now, we can directly get this CPU info from the auxiliary vector on Linux. Note that the aarch64 port also did the same thing on Linux platform. This also fixes some whitespace issue reported by jcheck. > > This has been tested on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu): > > # HiFive Unmatched > $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > OpenJDK 64-Bit Server VM warning: RVV is not supported on this CPU > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > # NeZha D1 > $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = true {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) Changes requested by fyang (Lead). src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 100: > 98: HWCAP_ISA_I | > 99: HWCAP_ISA_M | > 100: HWCAP_ISA_V); Please also add checking for 'B' and 'C' here. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/10 From fyang at openjdk.java.net Fri Nov 19 04:01:21 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 19 Nov 2021 04:01:21 GMT Subject: [riscv-port] RFR: 8277391: riscv: implement tls function MacroAssembler::get_thread() by using tls.ie In-Reply-To: References: Message-ID: On Thu, 18 Nov 2021 12:36:31 GMT, zhengxiaolinX wrote: > Hi team, > > This patch fixes the unimplemented assembly version of `__ get_thread()`, bringing some performance improvement by directly using the x4 register to refer to the variable `Thread::_thr_current`. Tested tests under hotspot/ and jdk/. [Original patch](https://github.com/riscv-collab/riscv-openjdk/pull/4) > > Thanks, > Xiaolin Changes requested by fyang (Lead). src/hotspot/os_cpu/linux_riscv/threadLS_linux_riscv.S line 31: > 29: .type _ZN10JavaThread25riscv64_get_thread_helperEv, %function > 30: > 31: _ZN10JavaThread25riscv64_get_thread_helperEv: For maximum flexibility, I would suggest we switch to use the global-dynamic TLS model here if you don't have a strong reason to use the initial-exec TLS model. That's the default TLS model used by the host GCC compiler and I don't want to affected by the limits of the initial-exec TLS model some day. --------------- la.tls.gd a0, _ZN6Thread12_thr_currentE addi sp, sp, -16 sd ra, 8(sp) call __tls_get_addr at plt ld ra, 8(sp) ld a0, 0(a0) addi sp, sp, 16 ret --------------- ------------- PR: https://git.openjdk.java.net/riscv-port/pull/7 From yzhu at openjdk.java.net Fri Nov 19 04:04:53 2021 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 19 Nov 2021 04:04:53 GMT Subject: [riscv-port] RFR: 8277036: riscv: Get CPU features from the auxiliary vector on Linux [v2] In-Reply-To: References: Message-ID: > Due to the lack of native environment in our early development of riscv port, we detect riscv CPU ISA extensions through checking whether simulator (e.g. QEMU) supports execution of one of the instructions in the corresponding feature spec or not. Fortunately, there are several riscv hardwares available now, we can directly get this CPU info from the auxiliary vector on Linux. Note that the aarch64 port also did the same thing on Linux platform. This also fixes some whitespace issue reported by jcheck. > > This has been tested on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu): > > # HiFive Unmatched > $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > OpenJDK 64-Bit Server VM warning: RVV is not supported on this CPU > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > # NeZha D1 > $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = true {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) Yanhong Zhu has updated the pull request incrementally with one additional commit since the last revision: Add checking for B & C extension ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/10/files - new: https://git.openjdk.java.net/riscv-port/pull/10/files/93affbae..9c06b3df Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=10&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=10&range=00-01 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/riscv-port/pull/10.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/10/head:pull/10 PR: https://git.openjdk.java.net/riscv-port/pull/10 From fyang at openjdk.java.net Fri Nov 19 04:04:54 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 19 Nov 2021 04:04:54 GMT Subject: [riscv-port] RFR: 8277036: riscv: Get CPU features from the auxiliary vector on Linux [v2] In-Reply-To: References: Message-ID: <653pUDBf2tUNrDbYp-XsCr7Q5Xsyd7YFdLFk-vNax9A=.4dc0708a-fbea-413d-a3ef-8ef4b420726a@github.com> On Fri, 19 Nov 2021 04:01:46 GMT, Yanhong Zhu wrote: >> Due to the lack of native environment in our early development of riscv port, we detect riscv CPU ISA extensions through checking whether simulator (e.g. QEMU) supports execution of one of the instructions in the corresponding feature spec or not. Fortunately, there are several riscv hardwares available now, we can directly get this CPU info from the auxiliary vector on Linux. Note that the aarch64 port also did the same thing on Linux platform. This also fixes some whitespace issue reported by jcheck. >> >> This has been tested on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu): >> >> # HiFive Unmatched >> $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt >> OpenJDK 64-Bit Server VM warning: RVV is not supported on this CPU >> bool UseVExt = false {ARCH product} {command line} >> openjdk version "18-internal" 2022-03-15 >> OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) >> OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) >> >> $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt >> bool UseVExt = false {ARCH product} {command line} >> openjdk version "18-internal" 2022-03-15 >> OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) >> OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) >> >> $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt >> bool UseVExt = false {ARCH product} {command line} >> openjdk version "18-internal" 2022-03-15 >> OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) >> OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) >> >> # NeZha D1 >> $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt >> bool UseVExt = true {ARCH product} {command line} >> openjdk version "18-internal" 2022-03-15 >> OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) >> OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) >> >> $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt >> bool UseVExt = false {ARCH product} {command line} >> openjdk version "18-internal" 2022-03-15 >> OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) >> OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) >> >> $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt >> bool UseVExt = false {ARCH product} {command line} >> openjdk version "18-internal" 2022-03-15 >> OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) >> OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > Yanhong Zhu has updated the pull request incrementally with one additional commit since the last revision: > > Add checking for B & C extension Changes requested by fyang (Lead). src/hotspot/cpu/riscv/vm_version_riscv.hpp line 44: > 42: > 43: enum Feature_Flag { > 44: #define CPU_FEATURE_FLAGS(decl) \ Please keep those macros in the same order as the HWCAP_ISA_X macros in file vm_version_linux_riscv.cpp. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/10 From yzhu at openjdk.java.net Fri Nov 19 04:57:47 2021 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 19 Nov 2021 04:57:47 GMT Subject: [riscv-port] RFR: 8277036: riscv: Get CPU features from the auxiliary vector on Linux [v3] In-Reply-To: References: Message-ID: > Due to the lack of native environment in our early development of riscv port, we detect riscv CPU ISA extensions through checking whether simulator (e.g. QEMU) supports execution of one of the instructions in the corresponding feature spec or not. Fortunately, there are several riscv hardwares available now, we can directly get this CPU info from the auxiliary vector on Linux. Note that the aarch64 port also did the same thing on Linux platform. This also fixes some whitespace issue reported by jcheck. > > This has been tested on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu): > > # HiFive Unmatched > $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > OpenJDK 64-Bit Server VM warning: RVV is not supported on this CPU > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > # NeZha D1 > $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = true {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) Yanhong Zhu has updated the pull request incrementally with one additional commit since the last revision: keep extension order same as HWCAP_ISA ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/10/files - new: https://git.openjdk.java.net/riscv-port/pull/10/files/9c06b3df..492ca943 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=10&range=02 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=10&range=01-02 Stats: 32 lines in 2 files changed: 16 ins; 16 del; 0 mod Patch: https://git.openjdk.java.net/riscv-port/pull/10.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/10/head:pull/10 PR: https://git.openjdk.java.net/riscv-port/pull/10 From yzhu at openjdk.java.net Fri Nov 19 04:57:48 2021 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 19 Nov 2021 04:57:48 GMT Subject: [riscv-port] RFR: 8277036: riscv: Get CPU features from the auxiliary vector on Linux [v3] In-Reply-To: <653pUDBf2tUNrDbYp-XsCr7Q5Xsyd7YFdLFk-vNax9A=.4dc0708a-fbea-413d-a3ef-8ef4b420726a@github.com> References: <653pUDBf2tUNrDbYp-XsCr7Q5Xsyd7YFdLFk-vNax9A=.4dc0708a-fbea-413d-a3ef-8ef4b420726a@github.com> Message-ID: On Fri, 19 Nov 2021 04:01:14 GMT, Fei Yang wrote: >> Yanhong Zhu has updated the pull request incrementally with one additional commit since the last revision: >> >> keep extension order same as HWCAP_ISA > > src/hotspot/cpu/riscv/vm_version_riscv.hpp line 44: > >> 42: >> 43: enum Feature_Flag { >> 44: #define CPU_FEATURE_FLAGS(decl) \ > > Please keep those macros in the same order as the HWCAP_ISA_X macros in file vm_version_linux_riscv.cpp. fixed > src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 100: > >> 98: HWCAP_ISA_I | >> 99: HWCAP_ISA_M | >> 100: HWCAP_ISA_V); > > Please also add checking for 'B' and 'C' here. done ------------- PR: https://git.openjdk.java.net/riscv-port/pull/10 From fyang at openjdk.java.net Fri Nov 19 06:17:55 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 19 Nov 2021 06:17:55 GMT Subject: [riscv-port] RFR: 8277036: riscv: Get CPU features from the auxiliary vector on Linux [v3] In-Reply-To: References: Message-ID: On Fri, 19 Nov 2021 04:57:47 GMT, Yanhong Zhu wrote: >> Due to the lack of native environment in our early development of riscv port, we detect riscv CPU ISA extensions through checking whether simulator (e.g. QEMU) supports execution of one of the instructions in the corresponding feature spec or not. Fortunately, there are several riscv hardwares available now, we can directly get this CPU info from the auxiliary vector on Linux. Note that the aarch64 port also did the same thing on Linux platform. This also fixes some whitespace issue reported by jcheck. >> >> This has been tested on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu): >> >> # HiFive Unmatched >> $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt >> OpenJDK 64-Bit Server VM warning: RVV is not supported on this CPU >> bool UseVExt = false {ARCH product} {command line} >> openjdk version "18-internal" 2022-03-15 >> OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) >> OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) >> >> $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt >> bool UseVExt = false {ARCH product} {command line} >> openjdk version "18-internal" 2022-03-15 >> OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) >> OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) >> >> $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt >> bool UseVExt = false {ARCH product} {command line} >> openjdk version "18-internal" 2022-03-15 >> OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) >> OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) >> >> # NeZha D1 >> $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt >> bool UseVExt = true {ARCH product} {command line} >> openjdk version "18-internal" 2022-03-15 >> OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) >> OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) >> >> $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt >> bool UseVExt = false {ARCH product} {command line} >> openjdk version "18-internal" 2022-03-15 >> OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) >> OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) >> >> $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt >> bool UseVExt = false {ARCH product} {command line} >> openjdk version "18-internal" 2022-03-15 >> OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) >> OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > Yanhong Zhu has updated the pull request incrementally with one additional commit since the last revision: > > keep extension order same as HWCAP_ISA Looks good. Thanks. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/10 From yzhu at openjdk.java.net Fri Nov 19 06:32:00 2021 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 19 Nov 2021 06:32:00 GMT Subject: [riscv-port] Integrated: 8277036: riscv: Get CPU features from the auxiliary vector on Linux In-Reply-To: References: Message-ID: On Fri, 19 Nov 2021 02:39:12 GMT, Yanhong Zhu wrote: > Due to the lack of native environment in our early development of riscv port, we detect riscv CPU ISA extensions through checking whether simulator (e.g. QEMU) supports execution of one of the instructions in the corresponding feature spec or not. Fortunately, there are several riscv hardwares available now, we can directly get this CPU info from the auxiliary vector on Linux. Note that the aarch64 port also did the same thing on Linux platform. This also fixes some whitespace issue reported by jcheck. > > This has been tested on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu): > > # HiFive Unmatched > $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > OpenJDK 64-Bit Server VM warning: RVV is not supported on this CPU > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > # NeZha D1 > $jdk/bin/java -XX:+UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = true {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:-UseVExt -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) > > $jdk/bin/java -XX:+PrintFlagsFinal -version |grep UseVExt > bool UseVExt = false {ARCH product} {command line} > openjdk version "18-internal" 2022-03-15 > OpenJDK Runtime Environment (build 18-internal+0-adhoc..riscv-port) > OpenJDK 64-Bit Server VM (build 18-internal+0-adhoc..riscv-port, mixed mode) This pull request has now been integrated. Changeset: b7ad0df6 Author: Yanhong Zhu Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/b7ad0df6a74a4c66e8542e6f1963d28c6b19037d Stats: 247 lines in 13 files changed: 117 ins; 112 del; 18 mod 8277036: riscv: Get CPU features from the auxiliary vector on Linux Co-authored-by: Feilong Jiang Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/10 From yzhu at openjdk.java.net Fri Nov 19 08:44:23 2021 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 19 Nov 2021 08:44:23 GMT Subject: [riscv-port] RFR: 8277440: riscv: Move UseVExt from product to experimental Message-ID: Currently, riscv port supports vector operations which is fully compatible with vector extension 1.0 spec. And we have passed tier 1-4 tests with option "-XX:+UseVExt" with QEMU. Due to lack of native environment which supports vector extension 1.0, we cannot carry out tests for vector operations on real hardware. So we decided to move port-specific option UseVExt from product to experimental for now, and rename UseVExt to UseRVV. This also fixes some typos in comments, and removes unused v extension instructions. The test results on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu) are in line with expectations. ------------- Commit messages: - 8277440: riscv: Move UseVExt from product to experimental Changes: https://git.openjdk.java.net/riscv-port/pull/11/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=11&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277440 Stats: 440 lines in 18 files changed: 12 ins; 333 del; 95 mod Patch: https://git.openjdk.java.net/riscv-port/pull/11.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/11/head:pull/11 PR: https://git.openjdk.java.net/riscv-port/pull/11 From fyang at openjdk.java.net Fri Nov 19 08:47:00 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 19 Nov 2021 08:47:00 GMT Subject: [riscv-port] RFR: 8277392: riscv: Port missing trampoline logic from AArch64 platform In-Reply-To: References: Message-ID: On Thu, 18 Nov 2021 12:38:35 GMT, zhengxiaolinX wrote: > Hi team, > > Java calls will jump to the trampoline stub even if the target address is directly reachable by using a simple `jal` before this patch. After adding back the logic from the AArch64 platform, we find a nearly 4% performance enhancement on SPECjbb2005/15. Tested tests under hotspot/ and jdk/. [Original Patch](https://github.com/riscv-collab/riscv-openjdk/pull/8) > > Thanks, > Xiaolin Looks good. Thanks. Marked as reviewed by fyang (Lead). ------------- Changes requested by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/8 From yadongwang at openjdk.java.net Fri Nov 19 08:54:56 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Fri, 19 Nov 2021 08:54:56 GMT Subject: [riscv-port] RFR: 8277440: riscv: Move UseVExt from product to experimental In-Reply-To: References: Message-ID: On Fri, 19 Nov 2021 08:36:31 GMT, Yanhong Zhu wrote: > Currently, riscv port supports vector operations which is fully compatible with vector extension 1.0 spec. And we have passed tier 1-4 tests with option "-XX:+UseVExt" with QEMU. > > Due to lack of native environment which supports vector extension 1.0, we cannot carry out tests for vector operations on real hardware. So we decided to move port-specific option UseVExt from product to experimental for now, and rename UseVExt to UseRVV. > > This also fixes some typos in comments, and removes unused v extension instructions. > > The test results on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu) are in line with expectations. src/hotspot/cpu/riscv/globals_riscv.hpp line 91: > 89: "Extend i for r and o for w in the pred/succ flags of fence;" \ > 90: "Extend fence.i to fence.i + fence.") \ > 91: product(bool, UseRVV, false, "Use RVV instructions") \ Is RVV still a product flag? ------------- PR: https://git.openjdk.java.net/riscv-port/pull/11 From yzhu at openjdk.java.net Fri Nov 19 08:54:56 2021 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 19 Nov 2021 08:54:56 GMT Subject: [riscv-port] RFR: 8277440: riscv: Move UseVExt from product to experimental In-Reply-To: References: Message-ID: On Fri, 19 Nov 2021 08:44:59 GMT, Yadong Wang wrote: > Is RVV still a product flag? UseRVV is only available as experimental option on this platform. It must be enabled via -XX:+UnlockExperimentalVMOptions flag. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/11 From yadongwang at openjdk.java.net Fri Nov 19 09:12:00 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Fri, 19 Nov 2021 09:12:00 GMT Subject: [riscv-port] RFR: 8277440: riscv: Move UseVExt from product to experimental In-Reply-To: References: Message-ID: On Fri, 19 Nov 2021 08:51:49 GMT, Yanhong Zhu wrote: >> src/hotspot/cpu/riscv/globals_riscv.hpp line 91: >> >>> 89: "Extend i for r and o for w in the pred/succ flags of fence;" \ >>> 90: "Extend fence.i to fence.i + fence.") \ >>> 91: product(bool, UseRVV, false, "Use RVV instructions") \ >> >> Is RVV still a product flag? > >> Is RVV still a product flag? > > UseRVV is only available as experimental option on this platform. It must be enabled via -XX:+UnlockExperimentalVMOptions flag. It's better to write like this: product(bool, UseRTMForStackLocks, false, EXPERIMENTAL, \ "Enable RTM lock eliding for stack locks in compiled code") \ ------------- PR: https://git.openjdk.java.net/riscv-port/pull/11 From yzhu at openjdk.java.net Fri Nov 19 09:43:32 2021 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 19 Nov 2021 09:43:32 GMT Subject: [riscv-port] RFR: 8277440: riscv: Move UseVExt from product to experimental [v2] In-Reply-To: References: Message-ID: > Currently, riscv port supports vector operations which is fully compatible with vector extension 1.0 spec. And we have passed tier 1-4 tests with option "-XX:+UseVExt" with QEMU. > > Due to lack of native environment which supports vector extension 1.0, we cannot carry out tests for vector operations on real hardware. So we decided to move port-specific option UseVExt from product to experimental for now, and rename UseVExt to UseRVV. > > This also fixes some typos in comments, and removes unused v extension instructions. > > The test results on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu) are in line with expectations. Yanhong Zhu has updated the pull request incrementally with one additional commit since the last revision: Set UseRVV EXPERIMENTAL ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/11/files - new: https://git.openjdk.java.net/riscv-port/pull/11/files/829cb59d..5283eec6 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=11&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=11&range=00-01 Stats: 5 lines in 2 files changed: 0 ins; 4 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/11.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/11/head:pull/11 PR: https://git.openjdk.java.net/riscv-port/pull/11 From yzhu at openjdk.java.net Fri Nov 19 10:03:00 2021 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 19 Nov 2021 10:03:00 GMT Subject: [riscv-port] RFR: 8277440: riscv: Move UseVExt from product to experimental [v2] In-Reply-To: References: Message-ID: On Fri, 19 Nov 2021 09:09:05 GMT, Yadong Wang wrote: > It's better to write like this: > > ``` > product(bool, UseRTMForStackLocks, false, EXPERIMENTAL, \ > "Enable RTM lock eliding for stack locks in compiled code") \ > ``` Done. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/11 From yadongwang at openjdk.java.net Fri Nov 19 10:36:04 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Fri, 19 Nov 2021 10:36:04 GMT Subject: [riscv-port] RFR: 8277440: riscv: Move UseVExt from product to experimental [v2] In-Reply-To: References: Message-ID: <2KjTaJHpwFbuwVTK0BO2ADNsfQl6P7A_P09TpC7oyJY=.125452de-7e9b-43e0-944b-969d6475edce@github.com> On Fri, 19 Nov 2021 09:43:32 GMT, Yanhong Zhu wrote: >> Currently, riscv port supports vector operations which is fully compatible with vector extension 1.0 spec. And we have passed tier 1-4 tests with option "-XX:+UseVExt" with QEMU. >> >> Due to lack of native environment which supports vector extension 1.0, we cannot carry out tests for vector operations on real hardware. So we decided to move port-specific option UseVExt from product to experimental for now, and rename UseVExt to UseRVV. >> >> This also fixes some typos in comments, and removes unused v extension instructions. >> >> The test results on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu) are in line with expectations. > > Yanhong Zhu has updated the pull request incrementally with one additional commit since the last revision: > > Set UseRVV EXPERIMENTAL lgtm ------------- Marked as reviewed by yadongwang (Author). PR: https://git.openjdk.java.net/riscv-port/pull/11 From duke at openjdk.java.net Fri Nov 19 10:46:59 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Fri, 19 Nov 2021 10:46:59 GMT Subject: [riscv-port] Integrated: 8277392: riscv: Port missing trampoline logic from AArch64 platform In-Reply-To: References: Message-ID: On Thu, 18 Nov 2021 12:38:35 GMT, zhengxiaolinX wrote: > Hi team, > > Java calls will jump to the trampoline stub even if the target address is directly reachable by using a simple `jal` before this patch. After adding back the logic from the AArch64 platform, we find a nearly 4% performance enhancement on SPECjbb2005/15. Tested tests under hotspot/ and jdk/. [Original Patch](https://github.com/riscv-collab/riscv-openjdk/pull/8) > > Thanks, > Xiaolin This pull request has now been integrated. Changeset: 398cec38 Author: yunyao.zxl Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/398cec38a05fea7a434b6be087f4241bcad16d2f Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod 8277392: riscv: Port missing trampoline logic from AArch64 platform Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/8 From fyang at openjdk.java.net Fri Nov 19 10:54:17 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 19 Nov 2021 10:54:17 GMT Subject: [riscv-port] RFR: 8277440: riscv: Move UseVExt from product to experimental [v2] In-Reply-To: References: Message-ID: On Fri, 19 Nov 2021 09:43:32 GMT, Yanhong Zhu wrote: >> Currently, riscv port supports vector operations which is fully compatible with vector extension 1.0 spec. And we have passed tier 1-4 tests with option "-XX:+UseVExt" with QEMU. >> >> Due to lack of native environment which supports vector extension 1.0, we cannot carry out tests for vector operations on real hardware. So we decided to move port-specific option UseVExt from product to experimental for now, and rename UseVExt to UseRVV. >> >> This also fixes some typos in comments, and removes unused v extension instructions. >> >> The test results on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu) are in line with expectations. > > Yanhong Zhu has updated the pull request incrementally with one additional commit since the last revision: > > Set UseRVV EXPERIMENTAL Thanks for cleanup. Looks good. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/11 From yzhu at openjdk.java.net Fri Nov 19 11:00:11 2021 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 19 Nov 2021 11:00:11 GMT Subject: [riscv-port] Integrated: 8277440: riscv: Move UseVExt from product to experimental In-Reply-To: References: Message-ID: On Fri, 19 Nov 2021 08:36:31 GMT, Yanhong Zhu wrote: > Currently, riscv port supports vector operations which is fully compatible with vector extension 1.0 spec. And we have passed tier 1-4 tests with option "-XX:+UseVExt" with QEMU. > > Due to lack of native environment which supports vector extension 1.0, we cannot carry out tests for vector operations on real hardware. So we decided to move port-specific option UseVExt from product to experimental for now, and rename UseVExt to UseRVV. > > This also fixes some typos in comments, and removes unused v extension instructions. > > The test results on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu) are in line with expectations. This pull request has now been integrated. Changeset: dfde4e4e Author: Yanhong Zhu Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/dfde4e4ebfb1c15f1fb225f7400aced51cc469dd Stats: 436 lines in 18 files changed: 8 ins; 333 del; 95 mod 8277440: riscv: Move UseVExt from product to experimental Reviewed-by: yadongwang, fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/11 From duke at openjdk.java.net Fri Nov 19 11:19:10 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Fri, 19 Nov 2021 11:19:10 GMT Subject: [riscv-port] RFR: 8277391: riscv: implement tls function MacroAssembler::get_thread() by using tls.ie In-Reply-To: References: Message-ID: On Fri, 19 Nov 2021 03:36:00 GMT, Fei Yang wrote: >> Hi team, >> >> This patch fixes the unimplemented assembly version of `__ get_thread()`, bringing some performance improvement by directly using the x4 register to refer to the variable `Thread::_thr_current`. Tested tests under hotspot/ and jdk/. [Original patch](https://github.com/riscv-collab/riscv-openjdk/pull/4) >> >> Thanks, >> Xiaolin > > src/hotspot/os_cpu/linux_riscv/threadLS_linux_riscv.S line 31: > >> 29: .type _ZN10JavaThread25riscv64_get_thread_helperEv, %function >> 30: >> 31: _ZN10JavaThread25riscv64_get_thread_helperEv: > > For maximum flexibility, I would suggest we switch to use the global-dynamic TLS model here if you don't have a strong reason to use the initial-exec TLS model. That's the default TLS model used by the host GCC compiler and I don't want to affected by the limits of the initial-exec TLS model some day. > --------------- > la.tls.gd a0, _ZN6Thread12_thr_currentE > addi sp, sp, -16 > sd ra, 8(sp) > call __tls_get_addr at plt > ld ra, 8(sp) > ld a0, 0(a0) > addi sp, sp, 16 > ret > --------------- Hi Felix - Quite sorry for the late reply - it takes me some time to look up some references. This code looks great without any problem and I totally agree with your point - so it is hard to make me not think you have implemented one version already in your codebase :-) And `__tls_get_addr`'s implementation could found itself at [this link](https://sources.debian.org/src/glibc/2.31-13/sysdeps/riscv/libc-tls.c/) with [macros defined](https://sources.debian.org/src/glibc/2.31-13/sysdeps/riscv/nptl/tls.h/), which is a C function. With this respect, it seems that I also need to save and restore all volatile registers pessimistically in `MacroAssembler::get_thread`, same as the current implementation on the master branch. I think it might be hard to keep the saved registers the same as AArch64's implementation that only clobbers x1 - please correct me if I missed something. But this seems much cheaper than calling a [pthread_getspecific](https://sources.debian.org/src/glibc/2.32-4/nptl/pthread_gets pecific.c/?hl=24#L24). In fact, the first version of this patch is written in a similar way as yours - for better performance I chose to use tls.ie - but I think you hold a very reasonable point. It's Friday night so please feel free to move the discussion to weekdays. Thanks - Xiaolin ------------- PR: https://git.openjdk.java.net/riscv-port/pull/7 From mark.reinhold at oracle.com Fri Nov 19 19:53:51 2021 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Fri, 19 Nov 2021 11:53:51 -0800 (PST) Subject: New candidate JEP: 422: Linux/RISC-V Port Message-ID: <20211119195351.C76594C9ED2@eggemoggin.niobe.net> https://openjdk.java.net/jeps/422 Summary: Port the JDK to Linux/RISC-V. - Mark From duke at openjdk.java.net Sat Nov 20 02:42:33 2021 From: duke at openjdk.java.net (duke) Date: Sat, 20 Nov 2021 02:42:33 GMT Subject: git: openjdk/riscv-port: riscv-port: 85 new changesets Message-ID: Changeset: e4362007 Author: Aleksey Shipilev Date: 2021-11-16 07:32:34 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e4362007da8e40c076493364df91cf85960a03e7 8008243: Zero: Implement fast bytecodes Reviewed-by: rkennke, coleenp ! src/hotspot/cpu/zero/zeroInterpreter_zero.cpp ! src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp ! src/hotspot/share/interpreter/zero/bytecodeInterpreter.hpp ! src/hotspot/share/prims/jvmtiManageCapabilities.cpp Changeset: 7719a74c Author: Thomas Stuefe Date: 2021-11-16 07:49:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7719a74cec8c47fd036226b520a5fce7887386da 8277172: Remove stray comment mentioning instr_size_for_decode_klass_not_null on x64 Reviewed-by: dholmes ! src/hotspot/cpu/x86/macroAssembler_x86.cpp Changeset: 1d79cfd3 Author: Stefan Johansson Date: 2021-11-16 08:27:34 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1d79cfd3a16a71ec1bf93a0748e806b21a717b52 8276229: Stop allowing implicit updates in G1BlockOffsetTable Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1BlockOffsetTable.cpp ! src/hotspot/share/gc/g1/g1BlockOffsetTable.hpp ! src/hotspot/share/gc/g1/g1BlockOffsetTable.inline.hpp ! src/hotspot/share/gc/g1/heapRegion.inline.hpp Changeset: b8d33a2a Author: Thomas Stuefe Date: 2021-11-16 09:49:03 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b8d33a2a4e4ac1be322644102e8f09ce1435b4fb 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes Reviewed-by: dholmes, sspitsyn ! src/hotspot/share/include/jmm.h ! src/hotspot/share/services/management.cpp ! src/jdk.management/share/native/libmanagement_ext/DiagnosticCommandImpl.c Changeset: 20f3872d Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-11-16 11:13:24 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/20f3872d1cd6257ab9c76bb998f8dc2d07bc1724 8274261: Use enhanced-for instead of plain 'for' in jdk.jcmd Reviewed-by: sspitsyn, cjplummer ! src/jdk.jcmd/share/classes/sun/tools/jmap/JMap.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/Arguments.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/ColumnFormat.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/OptionFormat.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/Parser.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/RawOutputFormatter.java Changeset: a9cb8bdb Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-11-16 11:14:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a9cb8bdbaac7241959805c491b6d13b6e14f8966 8274168: Avoid String.compareTo == 0 to check String equality in java.management Reviewed-by: sspitsyn, dfuchs, cjplummer, dholmes ! src/java.management/share/classes/javax/management/BinaryRelQueryExp.java ! src/java.management/share/classes/javax/management/loading/MLet.java Changeset: 0bc26837 Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-11-16 11:15:52 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0bc268377ed5d2dd15bdd7283a77b59ad505e2b7 8274190: Use String.equals instead of String.compareTo in jdk.internal.jvmstat Reviewed-by: cjplummer, sspitsyn ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/monitor/HostIdentifier.java ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/monitor/MonitoredHost.java ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/monitor/MonitoredVmUtil.java ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/monitor/VmIdentifier.java ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/AliasFileParser.java ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/file/PerfDataBuffer.java ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/v1_0/PerfDataBuffer.java Changeset: 9629627e Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-11-16 11:17:08 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9629627e2c8021c254517ac5463cc66723175fd9 8274163: Use String.equals instead of String.compareTo in jdk.jcmd Reviewed-by: cjplummer, amenkov, sspitsyn ! src/jdk.jcmd/share/classes/sun/tools/jps/Arguments.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/Arguments.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/OptionLister.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/Parser.java Changeset: c06df25a Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-11-16 11:18:10 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c06df25a4fb76ee65d3fa99ec0579ca4a406c345 8274662: Replace 'while' cycles with iterator with enhanced-for in jdk.hotspot.agent Reviewed-by: amenkov, cjplummer, sspitsyn ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/DeadlockDetector.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/FindInHeapPanel.java Changeset: 1c45c8a0 Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-11-16 11:19:01 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1c45c8a08287e2d8d7574eaa773850b7f0b33207 8274757: Cleanup unnecessary calls to Throwable.initCause() in java.management module Reviewed-by: dfuchs, sspitsyn ! src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java ! src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/java.management/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerInterceptor.java ! src/java.management/share/classes/com/sun/jmx/remote/internal/ArrayNotificationBuffer.java ! src/java.management/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java ! src/java.management/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! src/java.management/share/classes/com/sun/jmx/remote/security/JMXPluggableAuthenticator.java ! src/java.management/share/classes/javax/management/openmbean/OpenMBeanAttributeInfoSupport.java ! src/java.management/share/classes/javax/management/remote/JMXConnectorFactory.java Changeset: 7906eb05 Author: Hamlin Li Date: 2021-11-16 11:37:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7906eb050d4675092536048e8e21334767e397e6 8277119: Add asserts in GenericTaskQueueSet methods Reviewed-by: tschatzl ! src/hotspot/share/gc/shared/taskqueue.hpp ! src/hotspot/share/gc/shared/taskqueue.inline.hpp Changeset: 9a9a157a Author: Jayathirth D V Date: 2021-11-16 13:18:56 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9a9a157a7d45cbfb016d4427931e1d5345210f7a 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders Reviewed-by: ihse, kcr, erikj, prr ! make/modules/java.desktop/lib/Awt2dLibraries.gmk Changeset: f3eb5014 Author: MeryKitty Committer: Tobias Hartmann Date: 2021-11-16 14:09:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f3eb5014aa75af4463308f52f2bc6e9fcd2da36c 8276162: Optimise unsigned comparison pattern Reviewed-by: thartmann, kvn ! src/hotspot/share/opto/subnode.cpp + test/hotspot/jtreg/compiler/c2/irTests/TestUnsignedComparison.java + test/micro/org/openjdk/bench/vm/compiler/UnsignedComparison.java Changeset: d5e47d6b Author: Yasumasa Suenaga Date: 2021-11-16 14:47:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d5e47d6b84514edde23a8baff8c2274e5b3ca6bb 8277089: Use system binutils to build hsdis Reviewed-by: ihse ! make/autoconf/jdk-options.m4 ! src/utils/hsdis/README ! src/utils/hsdis/hsdis.c Changeset: e5ffdf91 Author: Dean Long Date: 2021-11-16 17:25:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e5ffdf9120c14b38e4c8794888d2002e2686ebfc 8276231: ciReplay: SIGSEGV when replay compiling lambdas Reviewed-by: iveresov, chagedorn ! src/hotspot/share/ci/ciReplay.cpp Changeset: b0a463fa Author: Alexander Zuev Date: 2021-11-16 19:01:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b0a463fa59a1c3c554f48267525729bf89a2c5be 8169468: NoResizeEventOnDMChangeTest.java fails because FS Window didn't receive all resizes! Reviewed-by: serb ! test/jdk/ProblemList.txt ! test/jdk/java/awt/FullScreen/NoResizeEventOnDMChangeTest/NoResizeEventOnDMChangeTest.java Changeset: cddc6ce4 Author: Daniel Jelinski Committer: Xue-Lei Andrew Fan Date: 2021-11-16 20:34:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cddc6ce44695cba4614c3405eb2b194d7c76489b 8275811: Incorrect instance to dispose Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/ssl/InputRecord.java ! src/java.base/share/classes/sun/security/ssl/OutputRecord.java ! src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java ! src/java.base/share/classes/sun/security/ssl/SSLSocketOutputRecord.java Changeset: 8ed384cf Author: Roger Riggs Date: 2021-11-16 20:53:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8ed384cfb655d97ba452033e06d18ca38e5fc9b0 8276609: Document setting property `jdk.serialFilter` to an invalid value throws `ExceptionInInitializerError` Reviewed-by: dfuchs, lancea ! src/java.base/share/classes/java/io/ObjectInputFilter.java Changeset: a77d8ddf Author: Ioi Lam Date: 2021-11-16 21:03:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a77d8ddf11fba33007a4f5c0468d69de23f10f6a 8276787: Improve warning messages for -XX:+RecordDynamicDumpInfo Reviewed-by: ccheung, stuefe ! src/hotspot/share/cds/dynamicArchive.cpp ! src/hotspot/share/cds/dynamicArchive.hpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/arguments.hpp ! src/hotspot/share/runtime/java.cpp ! src/hotspot/share/runtime/thread.cpp ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/SharedArchiveFileOption.java ! test/lib/jdk/test/lib/cds/CDSTestUtils.java Changeset: 23e5117a Author: Jaikiran Pai Date: 2021-11-17 03:20:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/23e5117a55b3f3d0e3d26bf2d481f4ad1c99af57 8276559: (httpclient) Consider adding an HttpRequest.Builder.HEAD method to build a HEAD request. Reviewed-by: cstein, dfuchs ! src/java.net.http/share/classes/java/net/http/HttpRequest.java ! src/java.net.http/share/classes/jdk/internal/net/http/HttpRequestBuilderImpl.java ! test/jdk/java/net/httpclient/HeadTest.java ! test/jdk/java/net/httpclient/HttpRequestBuilderTest.java ! test/jdk/java/net/httpclient/HttpRequestNewBuilderTest.java ! test/jdk/java/net/httpclient/RequestBuilderTest.java Changeset: 08f65a59 Author: Fairoz Matte Committer: Jayathirth D V Date: 2021-11-17 06:13:26 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/08f65a59a7bd387974d94253ec7093524a3e92f1 8277313: Validate header failed for test/jdk/java/net/httpclient/HeadTest.java Reviewed-by: jdv ! test/jdk/java/net/httpclient/HeadTest.java Changeset: 9aa30de4 Author: Faye Gao Committer: Tobias Hartmann Date: 2021-11-17 08:19:46 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9aa30de4bb55357ddf0900e6103062f02e85753b 8275317: AArch64: Support some type conversion vectorization in SLP Reviewed-by: thartmann, ngasson ! src/hotspot/share/opto/superword.cpp ! src/hotspot/share/opto/vectornode.cpp ! test/hotspot/jtreg/compiler/codegen/TestIntFloatVect.java ! test/hotspot/jtreg/compiler/codegen/TestLongDoubleVect.java ! test/micro/org/openjdk/bench/vm/compiler/TypeVectorOperations.java Changeset: e9934e12 Author: Albert Mingkun Yang Date: 2021-11-17 09:59:55 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e9934e1243929514e147ecdd3cefa74168ed0500 8277221: G1: Remove methods without implementations in G1CollectedHeap Reviewed-by: tschatzl ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp Changeset: 2af9e597 Author: Kevin Walls Date: 2021-11-17 11:59:52 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2af9e5976fdf94afc7dbe5ad7827553818057bae 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test Reviewed-by: jiefu, sspitsyn ! test/jdk/sun/jvmstat/monitor/HostIdentifier/HostIdentifierCreate.java ! test/jdk/sun/jvmstat/monitor/HostIdentifier/testcases - test/jdk/sun/tools/jps/TestJpsHostName.java Changeset: 9f2f46ee Author: Harold Seigel Date: 2021-11-17 14:25:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9f2f46ee4576d9cd0190530949e5e50f796a6bdc 8275037: Test vmTestbase/nsk/sysdict/vm/stress/btree/btree011/btree011.java crashes with memory exhaustion on Windows Reviewed-by: coleenp ! test/hotspot/jtreg/vmTestbase/nsk/sysdict/share/GenClassesBuilder.java ! test/hotspot/jtreg/vmTestbase/nsk/sysdict/share/SysDictTest.java Changeset: 8f5a8f74 Author: Alexander Zuev Date: 2021-11-17 17:36:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8f5a8f740b62c27cc244debe57aaa2975f84a694 8264293: Create implementation for NSAccessibilityMenu protocol peer 8264296: Create implementation for NSAccessibilityPopUpButton protocol peer 8264295: Create implementation for NSAccessibilityMenuItem protocol peer 8264294: Create implementation for NSAccessibilityMenuBar protocol peer Reviewed-by: pbansal, ant ! src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m + src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/MenuAccessibility.h + src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/MenuAccessibility.m + src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/MenuBarAccessibility.h + src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/MenuBarAccessibility.m + src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/MenuItemAccessibility.h + src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/MenuItemAccessibility.m Changeset: b6876649 Author: Alex Kasko Committer: Zhengyu Gu Date: 2021-11-17 17:48:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b6876649a82bed508d817ccbde1600d00937e4b2 8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points Reviewed-by: bpb, shade ! test/jdk/java/nio/file/FileStore/Basic.java Changeset: a907b2b1 Author: Coleen Phillimore Date: 2021-11-17 19:53:55 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a907b2b144f2af27392eb7c2f9656fbb1a759618 8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here" Reviewed-by: hseigel, sspitsyn ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/utilities/accessFlags.hpp ! test/hotspot/jtreg/ProblemList.txt Changeset: 262d0700 Author: Weijun Wang Date: 2021-11-17 20:03:55 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/262d07001babcbe7f9acd2053aa3b7bac304cf85 8277246: Check for NonRepudiation as well when validating a TSA certificate Reviewed-by: xuelei, mullan ! src/java.base/share/classes/sun/security/validator/EndEntityChecker.java ! test/jdk/sun/security/tools/jarsigner/TimestampCheck.java Changeset: 8881f29b Author: Dean Long Date: 2021-11-17 20:18:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8881f29bc83336bcbc0e8ff0cf1d2bbe55172f5c 8277310: ciReplay: @cpi MethodHandle references not resolved Reviewed-by: chagedorn, thartmann ! src/hotspot/share/ci/ciReplay.cpp Changeset: 007ad7c7 Author: Joe Darcy Date: 2021-11-17 20:23:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/007ad7c77c6277ce733386b4402b787d81dd41cf 8277303: Terminology mismatch between JLS17-3.9 and SE17's javax.lang.model.SourceVersion method specs Reviewed-by: iris, jjg ! src/java.compiler/share/classes/javax/lang/model/SourceVersion.java Changeset: d8c02802 Author: Dean Long Date: 2021-11-17 20:26:25 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d8c0280273fa9f8e113088d6a43a4af076cd4f87 8277316: ciReplay: dump_replay_data is not thread-safe Reviewed-by: chagedorn, thartmann ! src/hotspot/share/ci/ciEnv.cpp Changeset: 6bb04626 Author: Sean Coffey Date: 2021-11-17 20:50:46 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6bb04626af6574ef1e8d4b7dad0389d4b59f5d08 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE Reviewed-by: weijun ! src/java.base/share/classes/sun/security/pkcs/PKCS9Attributes.java ! test/jdk/sun/security/x509/AlgorithmId/NonStandardNames.java Changeset: 45a60db5 Author: Albert Mingkun Yang Date: 2021-11-17 21:02:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/45a60db5a0aa78fa9eb1c2899bd167c136e0fa03 8277045: G1: Remove unnecessary set_concurrency call in G1ConcurrentMark::weak_refs_work Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp Changeset: ce4471f8 Author: Daniel D. Daugherty Date: 2021-11-17 21:23:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ce4471f806e51bc9f9ad746b69ba490443947110 8277346: ProblemList 7 serviceability/sa tests on macosx-x64 8277351: ProblemList runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on macosx-x64 Reviewed-by: tschatzl, bpb ! test/hotspot/jtreg/ProblemList.txt Changeset: 29e552c0 Author: Sergey Bylokhov Date: 2021-11-17 22:21:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/29e552c03a2825f9526330072668a1d63ac68fd4 8272358: Some tests may fail when executed with other locales than the US Reviewed-by: aivanov ! test/langtools/jdk/jshell/ToolBasicTest.java ! test/langtools/jdk/jshell/ToolSimpleTest.java ! test/langtools/tools/javac/lambda/lambdaExecution/LambdaTranslationTest1.java ! test/langtools/tools/javac/lambda/lambdaExecution/LambdaTranslationTest2.java Changeset: 231fb61a Author: Naoto Sato Date: 2021-11-18 01:12:12 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/231fb61aaeae04787c06a4c972197943d9085627 8276970: Default charset for PrintWriter that wraps PrintStream Reviewed-by: rriggs, alanb ! src/java.base/share/classes/java/io/OutputStreamWriter.java ! src/java.base/share/classes/java/io/PrintStream.java ! src/java.base/share/classes/java/io/PrintWriter.java + test/jdk/java/io/PrintStream/InheritEncodingTest.java Changeset: b8453ebd Author: Naoto Sato Date: 2021-11-18 01:13:26 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b8453ebdb471e08cc8d62c777f33ad52902f67d7 8275007: Java fails to start with null charset if LC_ALL is set to certain locales Reviewed-by: rriggs, iris, joehw, alanb ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/native/libjava/jni_util.c Changeset: 81938001 Author: Fei Gao Committer: Ningsheng Jian Date: 2021-11-18 02:41:27 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/81938001f9bae56c59f4e18b7756089f2cf0bf74 8274179: AArch64: Support SVE operations with encodable immediates Reviewed-by: aph, ngasson ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/aarch64_sve.ad ! src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 ! src/hotspot/cpu/aarch64/assembler_aarch64.cpp ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! test/hotspot/gtest/aarch64/aarch64-asmtest.py ! test/hotspot/gtest/aarch64/asmtest.out.h ! test/hotspot/jtreg/compiler/codegen/TestByteVect.java ! test/hotspot/jtreg/compiler/codegen/TestCharVect.java ! test/hotspot/jtreg/compiler/codegen/TestIntVect.java ! test/hotspot/jtreg/compiler/codegen/TestLongVect.java ! test/hotspot/jtreg/compiler/codegen/TestShortVect.java Changeset: 91607436 Author: Prasanta Sadhukhan Date: 2021-11-18 04:33:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/91607436b79126ccb999deaf38a98209dbfe6ec1 8276058: Some swing test fails on specific CI macos system Reviewed-by: prr, kizune ! test/jdk/ProblemList.txt ! test/jdk/java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java ! test/jdk/javax/swing/JButton/8151303/PressedIconTest.java ! test/jdk/javax/swing/JInternalFrame/8069348/bug8069348.java ! test/jdk/javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java Changeset: 2f4b5405 Author: Doug Simon Date: 2021-11-18 08:32:54 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2f4b5405f0b53782f3ed5274f68b31eb968efb6d 8276314: [JVMCI] check alignment of call displacement during code installation Reviewed-by: kvn ! src/hotspot/cpu/x86/jvmciCodeInstaller_x86.cpp ! src/hotspot/cpu/x86/nativeInst_x86.cpp ! src/hotspot/cpu/x86/nativeInst_x86.hpp Changeset: db55f927 Author: Ioi Lam Date: 2021-11-18 08:49:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/db55f9272c0889f4ea4dee0f4aa3d9613fadb2f8 8277343: dynamicArchive/SharedArchiveFileOption.java failed: '-XX:+RecordDynamicDumpInfo is unsupported when a dynamic CDS archive is specified in -XX:SharedArchiveFile:' missing Reviewed-by: hseigel, ccheung ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveTestBase.java ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/SharedArchiveFileOption.java Changeset: 0a65e8b2 Author: Andrey Turbanov Committer: Alexey Ivanov Date: 2021-11-18 10:48:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0a65e8b282fd41e57108422fbd140527d9697efd 8276794: Change nested classes in java.desktop to static nested classes Reviewed-by: serb, aivanov ! src/java.desktop/macosx/classes/com/apple/eawt/_AppEventHandler.java ! src/java.desktop/macosx/classes/com/apple/laf/AquaFileChooserUI.java ! src/java.desktop/macosx/classes/com/apple/laf/AquaFileSystemModel.java ! src/java.desktop/macosx/classes/com/apple/laf/AquaInternalFramePaneUI.java ! src/java.desktop/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java ! src/java.desktop/macosx/classes/sun/java2d/metal/MTLRenderer.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/DHTMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/DQTMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/JFIFMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/SOFMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/SOSMarkerSegment.java ! src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKColorChooserPanel.java ! src/java.desktop/share/classes/com/sun/java/swing/plaf/motif/MotifDesktopPaneUI.java ! src/java.desktop/share/classes/com/sun/media/sound/EventDispatcher.java ! src/java.desktop/share/classes/com/sun/media/sound/RealTimeSequencer.java ! src/java.desktop/share/classes/com/sun/media/sound/SoftMainMixer.java ! src/java.desktop/share/classes/com/sun/media/sound/SunFileWriter.java ! src/java.desktop/share/classes/java/awt/CardLayout.java ! src/java.desktop/share/classes/java/awt/Component.java ! src/java.desktop/share/classes/java/awt/Polygon.java ! src/java.desktop/share/classes/java/awt/ScrollPane.java ! src/java.desktop/share/classes/java/awt/Toolkit.java ! src/java.desktop/share/classes/java/awt/print/Book.java ! src/java.desktop/share/classes/java/beans/XMLEncoder.java ! src/java.desktop/share/classes/javax/imageio/metadata/IIOMetadataFormatImpl.java ! src/java.desktop/share/classes/javax/print/attribute/standard/PrinterStateReasons.java ! src/java.desktop/share/classes/javax/sound/sampled/AudioInputStream.java ! src/java.desktop/share/classes/javax/swing/GroupLayout.java ! src/java.desktop/share/classes/javax/swing/JComboBox.java ! src/java.desktop/share/classes/javax/swing/JComponent.java ! src/java.desktop/share/classes/javax/swing/JTable.java ! src/java.desktop/share/classes/javax/swing/KeyboardManager.java ! src/java.desktop/share/classes/javax/swing/RepaintManager.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDesktopPaneUI.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! src/java.desktop/share/classes/javax/swing/plaf/metal/MetalComboBoxEditor.java ! src/java.desktop/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java ! src/java.desktop/share/classes/javax/swing/plaf/metal/MetalIconFactory.java ! src/java.desktop/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java ! src/java.desktop/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java ! src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java ! src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTableUI.java ! src/java.desktop/share/classes/javax/swing/text/DefaultHighlighter.java ! src/java.desktop/share/classes/javax/swing/text/ElementIterator.java ! src/java.desktop/share/classes/javax/swing/text/JTextComponent.java ! src/java.desktop/share/classes/javax/swing/text/StringContent.java ! src/java.desktop/share/classes/javax/swing/text/StyleContext.java ! src/java.desktop/share/classes/javax/swing/text/html/ImageView.java ! src/java.desktop/share/classes/javax/swing/text/html/TableView.java ! src/java.desktop/share/classes/javax/swing/text/rtf/RTFReader.java ! src/java.desktop/share/classes/javax/swing/tree/DefaultMutableTreeNode.java ! src/java.desktop/share/classes/sun/awt/PlatformFont.java ! src/java.desktop/share/classes/sun/java2d/loops/RenderCache.java ! src/java.desktop/share/classes/sun/java2d/opengl/OGLRenderer.java ! src/java.desktop/share/classes/sun/java2d/pipe/GeneralCompositePipe.java ! src/java.desktop/share/classes/sun/java2d/pipe/SpanClipRenderer.java ! src/java.desktop/share/classes/sun/print/PrintJob2D.java ! src/java.desktop/share/classes/sun/print/RasterPrinterJob.java ! src/java.desktop/share/classes/sun/print/ServiceDialog.java ! src/java.desktop/share/classes/sun/swing/plaf/synth/SynthFileChooserUI.java ! src/java.desktop/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java ! src/java.desktop/share/classes/sun/swing/table/DefaultTableCellHeaderRenderer.java ! src/java.desktop/unix/classes/sun/awt/X11/XTextAreaPeer.java ! src/java.desktop/unix/classes/sun/awt/X11/XTextFieldPeer.java ! src/java.desktop/unix/classes/sun/font/X11GB2312.java ! src/java.desktop/unix/classes/sun/font/X11GBK.java ! src/java.desktop/unix/classes/sun/font/X11KSC5601.java ! src/java.desktop/unix/classes/sun/print/IPPPrintService.java ! src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsComboBoxUI.java ! src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java ! src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/XPStyle.java ! src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java ! src/java.desktop/windows/classes/sun/awt/windows/WScrollPanePeer.java ! src/java.desktop/windows/classes/sun/java2d/d3d/D3DRenderer.java Changeset: 77cc5088 Author: Albert Mingkun Yang Date: 2021-11-18 10:52:55 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/77cc508802899b370f1cdf592331f81efb8d9208 8277215: Remove redundancy in ReferenceProcessor constructor args Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psScavenge.cpp ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/referenceProcessor.hpp Changeset: 2c06bca9 Author: Erik ?sterlund Date: 2021-11-18 11:17:00 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2c06bca98fcf9d129d6085e26c225fb26368a558 8266368: Inaccurate after_unwind hook in C2 exception handler Reviewed-by: dlong, thartmann ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp Changeset: 38345bd2 Author: Evgeny Astigeevich Committer: Volker Simonis Date: 2021-11-18 11:18:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/38345bd28db83371676f1685806ddc207a833879 8277137: Set OnSpinWaitInst/OnSpinWaitInstCount defaults to "isb"/1 for Arm Neoverse N1 Reviewed-by: phh, aph, ngasson ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp + test/hotspot/jtreg/compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java Changeset: b3a62b48 Author: Harold Seigel Date: 2021-11-18 13:18:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b3a62b48816358ac7dadde4e7893190500ca7b79 8276795: Deprecate seldom used CDS flags Reviewed-by: dholmes, ccheung, iklam ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp ! test/hotspot/jtreg/compiler/intrinsics/klass/TestIsPrimitive.java ! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Changeset: a44b45fd Author: Sean Mullan Date: 2021-11-18 13:48:12 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a44b45fdf31275a2c1e9d1d0132874a7de45f8ee 4337793: Mark non-serializable fields of java.security.cert.Certificate and CertPath Reviewed-by: valeriep, rriggs ! src/java.base/share/classes/java/security/cert/CertPath.java ! src/java.base/share/classes/java/security/cert/Certificate.java Changeset: 00c388b4 Author: Erik ?sterlund Date: 2021-11-18 14:32:59 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/00c388b4aba41d5f0874585e9c0a33c4571805f6 8259643: ZGC can return metaspace OOM prematurely Reviewed-by: stefank, pliden, stuefe ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/memory/metaspace.cpp + src/hotspot/share/memory/metaspaceCriticalAllocation.cpp + src/hotspot/share/memory/metaspaceCriticalAllocation.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp Changeset: d93b238f Author: Erik ?sterlund Date: 2021-11-18 14:44:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d93b238f9725727ae1e2e9f203943b5ddf778f35 8277180: Intrinsify recursive ObjectMonitor locking for C2 x64 and A64 Reviewed-by: aph, ngasson ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp Changeset: 276bfcd1 Author: Prasanta Sadhukhan Date: 2021-11-18 15:17:59 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/276bfcd1a115f90dde644abef79d64bb61788c75 8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058 Reviewed-by: dcubed ! test/jdk/javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java Changeset: 354a34ea Author: Albert Mingkun Yang Date: 2021-11-18 15:54:04 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/354a34ea2077c9372e585adb1303df604827a2e2 8277336: Improve CollectedHeap::safepoint_workers comments Reviewed-by: sjohanss, tschatzl ! src/hotspot/share/gc/shared/collectedHeap.hpp Changeset: 5d249c46 Author: Alexander Zuev Date: 2021-11-18 16:07:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5d249c46abc8dfdc3acdaff41d26f3bd9ba84731 8275071: [macos] A11y cursor gets stuck when combobox is closed Reviewed-by: serb, pbansal ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessible.java Changeset: ce0f00f6 Author: Thomas Schatzl Date: 2021-11-18 16:59:41 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ce0f00f66e78a504d5e40a25fa213325ec0af394 8276093: Improve naming in closures to iterate over card sets Reviewed-by: sjohanss, ayang ! src/hotspot/share/gc/g1/g1CardSet.cpp ! src/hotspot/share/gc/g1/g1CardSet.hpp ! src/hotspot/share/gc/g1/g1CardSet.inline.hpp ! src/hotspot/share/gc/g1/heapRegionRemSet.inline.hpp ! test/hotspot/gtest/gc/g1/test_g1CardSet.cpp Changeset: 03473b4c Author: Sergey Bylokhov Date: 2021-11-18 18:25:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/03473b4c271b2ec7f0ebdb0edabadf7f36816b9d 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor Reviewed-by: jdv ! src/java.desktop/windows/native/libawt/windows/awt_Component.cpp ! test/jdk/java/awt/Window/WindowResizingOnDPIChanging/WindowResizingOnMovingToAnotherDisplay.java Changeset: 8db0c361 Author: Daniel D. Daugherty Date: 2021-11-18 18:40:26 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8db0c361a39cf10d373c3d2dfa54267cf53452db 8277414: ProblemList runtime/CommandLine/VMDeprecatedOptions.java on windows-x64 Reviewed-by: mikael, iklam ! test/hotspot/jtreg/ProblemList.txt Changeset: 57eb8647 Author: Niklas Radomski Committer: Martin Doerr Date: 2021-11-18 19:00:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/57eb864765f38185f8db8f1d37681d6cfe2a3c73 8276927: [PPC64] Port shenandoahgc to linux on ppc64le Reviewed-by: rkennke, ihse, mdoerr ! make/autoconf/jvm-features.m4 ! make/hotspot/gensrc/GensrcAdlc.gmk ! src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp + src/hotspot/cpu/ppc/gc/shenandoah/c1/shenandoahBarrierSetC1_ppc.cpp + src/hotspot/cpu/ppc/gc/shenandoah/shenandoahBarrierSetAssembler_ppc.cpp + src/hotspot/cpu/ppc/gc/shenandoah/shenandoahBarrierSetAssembler_ppc.hpp + src/hotspot/cpu/ppc/gc/shenandoah/shenandoah_ppc.ad ! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp Changeset: 36bd4a35 Author: Harold Seigel Date: 2021-11-18 20:06:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/36bd4a35fbee077c00c1f4240f1f02f4d7d5f656 8277404: Test VMDeprecatedOptions.java failing with Unable to create shared archive file Reviewed-by: dcubed ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Changeset: 89b125f4 Author: Roman Kennke Date: 2021-11-18 21:32:00 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/89b125f4d4d6a467185b4b39861fd530a738e67f 8275527: Refactor forward pointer access Reviewed-by: tschatzl, stefank ! src/hotspot/share/gc/g1/g1FullGCCompactTask.cpp ! src/hotspot/share/gc/g1/g1FullGCCompactionPoint.cpp ! src/hotspot/share/gc/g1/g1FullGCOopClosures.inline.hpp ! src/hotspot/share/gc/g1/g1FullGCPrepareTask.cpp ! src/hotspot/share/gc/g1/g1OopClosures.inline.hpp ! src/hotspot/share/gc/g1/g1YoungCollector.cpp ! src/hotspot/share/gc/serial/markSweep.inline.hpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/oops/oop.inline.hpp Changeset: 839033ba Author: Man Cao Date: 2021-11-18 23:35:01 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/839033baf61ca7f10437e8e53b2114b081d97ea9 8276976: Rename LIR_OprDesc to LIR_Opr Co-authored-by: Chuck Rasbold Reviewed-by: thartmann, iveresov ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/c1_LIR_aarch64.cpp ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp ! src/hotspot/cpu/arm/c1_LIR_arm.cpp ! src/hotspot/cpu/ppc/c1_LIR_ppc.cpp ! src/hotspot/cpu/s390/c1_LIR_s390.cpp ! src/hotspot/cpu/x86/c1_LIR_x86.cpp ! src/hotspot/share/c1/c1_LIR.cpp ! src/hotspot/share/c1/c1_LIR.hpp ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_LIRGenerator.hpp ! src/hotspot/share/c1/c1_LinearScan.cpp ! src/hotspot/share/c1/c1_LinearScan.hpp ! src/hotspot/share/gc/g1/c1/g1BarrierSetC1.cpp Changeset: 2f0bde1a Author: Yi Yang Date: 2021-11-19 02:04:48 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2f0bde1a658b0910304c110920a2e8ccbe4557f8 8277102: Dubious PrintCompilation output Reviewed-by: thartmann, dnsimon ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/compiler/compileTask.cpp ! src/hotspot/share/compiler/compileTask.hpp ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/DisassembleCodeBlobTest.java Changeset: 47564cae Author: Tobias Hartmann Date: 2021-11-19 07:07:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/47564caeb0628e5c03a0e7f04093adce77d6dd3b 8275643: C2's unaryOp vector intrinsic does not properly handle LongVector.neg Reviewed-by: chagedorn, sviswanathan ! src/hotspot/share/prims/vectorSupport.cpp + test/hotspot/jtreg/compiler/vectorapi/TestLongVectorNeg.java Changeset: f34f1190 Author: Tobias Hartmann Date: 2021-11-19 07:13:05 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f34f119080b4e8baf396fb26c21d572dd432fd91 8277213: CompileTask_lock is acquired out of order with MethodCompileQueue_lock Reviewed-by: rbackman, coleenp ! src/hotspot/share/compiler/compileTask.hpp Changeset: 2f20b0d8 Author: Jan Lahoda Date: 2021-11-19 07:49:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2f20b0d8daca6bdc53b4b9e1837c428930d34236 8273039: JShell crashes when naming variable or method "abstract" or "strictfp" Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! test/langtools/jdk/jshell/ErrorRecoveryTest.java + test/langtools/tools/javac/attr/AttrRecoveryTest.java Changeset: 3a76d397 Author: Tobias Hartmann Date: 2021-11-19 08:23:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3a76d397949ad22e4786476e583cc9d33c015214 8277324: C2 compilation fails with "bad AD file" on x86-32 after JDK-8276162 due to missing match rule Reviewed-by: chagedorn, roland ! src/hotspot/cpu/x86/x86_32.ad Changeset: 7a046e0f Author: Albert Mingkun Yang Date: 2021-11-19 08:31:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7a046e0f765e0ad04fd52c9a882c5d90b085bc00 8277371: Remove unnecessary DefNewGeneration::ref_processor_init() Reviewed-by: stefank, tschatzl, mli ! src/hotspot/share/gc/serial/defNewGeneration.cpp ! src/hotspot/share/gc/serial/defNewGeneration.hpp ! src/hotspot/share/gc/shared/generation.hpp Changeset: 11d819d6 Author: Hamlin Li Date: 2021-11-19 10:15:30 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/11d819d68a3ce2ae0973b496141c52aa419f90f0 8277439: G1: Correct include guard name in G1EvacFailureObjectsSet.hpp Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1EvacFailureObjectsSet.hpp Changeset: b15e6f07 Author: Jie Fu Date: 2021-11-19 10:38:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b15e6f076afe5ac68e9af68756860d0b25adea4b 8277449: compiler/vectorapi/TestLongVectorNeg.java fails with release VMs Reviewed-by: thartmann, chagedorn ! test/hotspot/jtreg/compiler/vectorapi/TestLongVectorNeg.java Changeset: 03debf27 Author: Daniel Fuchs Date: 2021-11-19 13:18:12 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/03debf277537135974d3f55e3a5c7cf6842ee5e0 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie Reviewed-by: michaelm ! src/java.net.http/share/classes/jdk/internal/net/http/Http1Request.java ! src/java.net.http/share/classes/jdk/internal/net/http/Stream.java ! test/jdk/java/net/httpclient/CookieHeaderTest.java = test/jdk/java/net/httpclient/UserCookieTest.java Changeset: b1a1bf4e Author: Claes Redestad Date: 2021-11-19 13:25:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b1a1bf4e305d6675f8f751aa8fef7013d99466f1 8277427: Update jib-profiles.js to use JMH 1.33 devkit Reviewed-by: shade, erikj ! make/conf/jib-profiles.js Changeset: a0227965 Author: Magnus Ihse Bursie Committer: Magnus Ihse Bursie Date: 2021-11-19 13:55:08 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a0227965bb8d1d49718794d67f8a4cfeebc9bec2 8275745: Reproducible copyright headers Reviewed-by: ihse, erikj ! make/autoconf/basic_tools.m4 ! make/autoconf/jdk-options.m4 ! make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java ! make/jdk/src/classes/build/tools/cldrconverter/CopyrightHeaders.java ! make/jdk/src/classes/build/tools/cldrconverter/ResourceBundleGenerator.java ! make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java ! make/modules/java.base/Gensrc.gmk ! make/modules/jdk.localedata/Gensrc.gmk Changeset: 936f7ff4 Author: Andy Herrick Date: 2021-11-19 14:23:04 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0 8276150: Quarantined jpackage apps are labeled as "damaged" Reviewed-by: almatvee ! src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java ! test/jdk/tools/jpackage/macosx/SigningAppImageTest.java Changeset: 03f8c0fb Author: Sean Mullan Date: 2021-11-19 14:36:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/03f8c0fb9363dc1bb07bed1ae0359c029caa0130 8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled Reviewed-by: weijun ! src/java.base/share/classes/sun/security/pkcs/SignerInfo.java ! src/java.base/share/classes/sun/security/provider/certpath/AlgorithmChecker.java ! src/java.base/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java ! src/java.base/share/classes/sun/security/util/JarConstraintsParameters.java ! src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java ! src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java ! test/jdk/sun/security/tools/jarsigner/TimestampCheck.java Changeset: 976c2bb0 Author: Stefan Karlsson Date: 2021-11-19 15:34:22 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/976c2bb05611cdc7b11b0918aaf50ff693507aae 8277212: GC accidentally cleans valid megamorphic vtable inline caches Reviewed-by: eosterlund, pliden, coleenp, thartmann ! src/hotspot/share/code/compiledMethod.cpp Changeset: 09e8c8c6 Author: Coleen Phillimore Date: 2021-11-19 17:48:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/09e8c8c64abf4178a042c79b92d7e08e54467331 8277342: vmTestbase/nsk/stress/strace/strace004.java fails with SIGSEGV in InstanceKlass::jni_id_for Reviewed-by: dholmes, hseigel ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp Changeset: 66775543 Author: Andrey Turbanov Committer: Roger Riggs Date: 2021-11-19 18:48:06 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6677554374ade32c9f2ddaaa093064de8aebd831 8274949: Use String.contains() instead of String.indexOf() in java.base Reviewed-by: weijun, dfuchs, vtewari, lancea ! src/java.base/share/classes/java/net/HttpCookie.java ! src/java.base/share/classes/java/net/HttpURLConnection.java ! src/java.base/share/classes/java/net/SocketPermission.java ! src/java.base/share/classes/jdk/internal/jrtfs/JrtPath.java ! src/java.base/share/classes/jdk/internal/loader/URLClassPath.java ! src/java.base/share/classes/sun/net/www/http/HttpCapture.java ! src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java ! src/java.base/share/classes/sun/security/provider/PolicyFile.java ! src/java.base/share/classes/sun/security/rsa/RSAPSSSignature.java ! src/java.base/share/classes/sun/security/rsa/RSAUtil.java ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/java.base/share/classes/sun/security/util/Debug.java ! src/java.base/share/classes/sun/security/util/SignatureUtil.java ! src/java.base/share/classes/sun/security/x509/AlgorithmId.java ! src/java.base/share/classes/sun/util/locale/LocaleMatcher.java ! src/java.base/unix/classes/sun/net/www/protocol/jar/JarFileFactory.java ! src/java.base/windows/classes/sun/net/www/protocol/jar/JarFileFactory.java Changeset: 36b59f38 Author: Andrey Turbanov Committer: Roger Riggs Date: 2021-11-19 18:49:04 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/36b59f3814fdaa44c9c04a0e8d63d0ba56929326 8274333: Redundant null comparison after Pattern.split Reviewed-by: mullan, weijun, rriggs, iris ! src/java.base/share/classes/sun/launcher/LauncherHelper.java ! src/java.base/share/classes/sun/security/util/AlgorithmDecomposer.java Changeset: f609b8fd Author: Andrey Turbanov Committer: Roger Riggs Date: 2021-11-19 18:50:03 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f609b8fd74c55f3149d8e5a6a9a9bc3598c0b961 8274946: Cleanup unnecessary calls to Throwable.initCause() in java.rmi Reviewed-by: iris, rriggs ! src/java.rmi/share/classes/java/rmi/server/RMIClassLoader.java ! src/java.rmi/share/classes/java/rmi/server/RemoteObjectInvocationHandler.java ! src/java.rmi/share/classes/javax/rmi/ssl/SslRMIClientSocketFactory.java ! src/java.rmi/share/classes/javax/rmi/ssl/SslRMIServerSocketFactory.java ! src/java.rmi/share/classes/sun/rmi/log/ReliableLog.java Changeset: e47cc81b Author: Andrey Turbanov Committer: Roger Riggs Date: 2021-11-19 18:51:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e47cc81b095381266104e9137495e91fb4c225a4 8275386: Change nested classes in jdk.jlink to static nested classes Reviewed-by: alanb, rriggs, iris ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginStack.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ResourcePoolManager.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java Changeset: a3406a1d Author: Thomas Stuefe Date: 2021-11-19 19:49:57 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a3406a1d8ab4228b06b4f2978f87275093c39468 8277092: TestMetaspaceAllocationMT2.java#ndebug-default fails with "RuntimeException: Committed seems high: NNNN expected at most MMMM" Reviewed-by: coleenp ! test/hotspot/jtreg/runtime/Metaspace/elastic/MetaspaceTestContext.java ! test/hotspot/jtreg/runtime/Metaspace/elastic/MetaspaceTestManyArenasManyThreads.java Changeset: 2d4af225 Author: Yasumasa Suenaga Date: 2021-11-19 20:24:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2d4af2255feb2eaeca533424f8cba3ec0945d757 8277370: configure script cannot distinguish WSL version Reviewed-by: erikj ! make/autoconf/basic_windows.m4 Changeset: 2ab43ec2 Author: Pavel Rappo Date: 2021-11-19 20:51:22 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2ab43ec2428edaebfe9a7fb0e716ff7141a28de0 8273544: Increase test coverage for snippets Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/SnippetTaglet.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Attribute.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Attributes.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Parser.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Replace.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Style.java + test/langtools/jdk/javadoc/doclet/testSnippetTag/SnippetTester.java + test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetMarkup.java + test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetPathOption.java ! test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetTag.java Changeset: c79a485f Author: Daniel D. Daugherty Date: 2021-11-19 22:37:28 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c79a485f1c3f9c0c3a79b8847fdcd50a141cd529 8277494: [BACKOUT] JDK-8276150 Quarantined jpackage apps are labeled as "damaged" Reviewed-by: asemenyuk, tschatzl ! src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java ! test/jdk/tools/jpackage/macosx/SigningAppImageTest.java Changeset: 1d7cef33 Author: Derek White Date: 2021-11-20 00:48:32 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1d7cef33c5ff24695463a03c58c7ca350ec190fc 8276662: Scalability bottleneck in SymbolTable::lookup_common() Reviewed-by: redestad, dholmes, iklam, shade ! src/hotspot/share/classfile/symbolTable.cpp Changeset: a055af3e Author: Fei Yang Date: 2021-11-19 21:32:48 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a055af3e271f9b5325284ab3878b0ad3092fd38f Merge branch 'master' into riscv-port ! make/autoconf/jvm-features.m4 ! make/hotspot/gensrc/GensrcAdlc.gmk ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp ! src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp ! src/hotspot/cpu/riscv/c1_LIR_riscv.cpp ! src/hotspot/share/c1/c1_LIR.cpp ! src/hotspot/share/c1/c1_LIR.hpp ! src/hotspot/share/c1/c1_LinearScan.cpp ! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp ! make/autoconf/jvm-features.m4 ! make/hotspot/gensrc/GensrcAdlc.gmk ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp + src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp + src/hotspot/cpu/riscv/c1_LIR_riscv.cpp ! src/hotspot/share/c1/c1_LIR.cpp ! src/hotspot/share/c1/c1_LIR.hpp ! src/hotspot/share/c1/c1_LinearScan.cpp ! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp From duke at openjdk.java.net Mon Nov 22 02:46:03 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 22 Nov 2021 02:46:03 GMT Subject: [riscv-port] RFR: 8277391: riscv: implement tls function MacroAssembler::get_thread() by using tls.gd [v2] In-Reply-To: References: Message-ID: <_swFqm5pZ3XN45D8wTisJqG4LV5p8rYgjvQaR7-d_7c=.6d316a63-97f9-447f-99a6-8dc8501edbc7@github.com> > Hi team, > > This patch fixes the unimplemented assembly version of `__ get_thread()`, bringing some performance improvement by directly using the x4 register to refer to the variable `Thread::_thr_current`. Tested tests under hotspot/ and jdk/. [Original patch](https://github.com/riscv-collab/riscv-openjdk/pull/4) > > Thanks, > Xiaolin zhengxiaolinX has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: Implement tls function MacroAssembler::get_thread() using tls.gd ------------- Changes: https://git.openjdk.java.net/riscv-port/pull/7/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=7&range=01 Stats: 58 lines in 3 files changed: 45 ins; 9 del; 4 mod Patch: https://git.openjdk.java.net/riscv-port/pull/7.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/7/head:pull/7 PR: https://git.openjdk.java.net/riscv-port/pull/7 From duke at openjdk.java.net Mon Nov 22 02:46:03 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 22 Nov 2021 02:46:03 GMT Subject: [riscv-port] RFR: 8277391: riscv: implement tls function MacroAssembler::get_thread() by using tls.gd [v2] In-Reply-To: References: Message-ID: On Fri, 19 Nov 2021 11:15:40 GMT, zhengxiaolinX wrote: >> src/hotspot/os_cpu/linux_riscv/threadLS_linux_riscv.S line 31: >> >>> 29: .type _ZN10JavaThread25riscv64_get_thread_helperEv, %function >>> 30: >>> 31: _ZN10JavaThread25riscv64_get_thread_helperEv: >> >> For maximum flexibility, I would suggest we switch to use the global-dynamic TLS model here if you don't have a strong reason to use the initial-exec TLS model. That's the default TLS model used by the host GCC compiler and I don't want to affected by the limits of the initial-exec TLS model some day. >> --------------- >> la.tls.gd a0, _ZN6Thread12_thr_currentE >> addi sp, sp, -16 >> sd ra, 8(sp) >> call __tls_get_addr at plt >> ld ra, 8(sp) >> ld a0, 0(a0) >> addi sp, sp, 16 >> ret >> --------------- > > Hi Felix - > > Quite sorry for the late reply - it takes me some time to look up some references. This code looks great without any problem and I totally agree with your point - so it is hard to make me not think you have implemented one version already in your codebase :-) And `__tls_get_addr`'s implementation could found itself at [this link](https://sources.debian.org/src/glibc/2.31-13/sysdeps/riscv/libc-tls.c/) with [macros defined](https://sources.debian.org/src/glibc/2.31-13/sysdeps/riscv/nptl/tls.h/), which is a C function. With this respect, it seems that I also need to save and restore all volatile registers pessimistically in `MacroAssembler::get_thread`, same as the current implementation on the master branch. I think it might be hard to keep the saved registers the same as AArch64's implementation that only clobbers x1 - please correct me if I missed something. But this seems much cheaper than calling a [pthread_getspecific](https://sources.debian.org/src/glibc/2.32-4/nptl/pthread_ge tspecific.c/?hl=24#L24). In fact, the first version of this patch is written in a similar way as yours - for better performance I chose to use tls.ie - but I think you hold a very reasonable point. > > It's Friday night so please feel free to move the discussion to weekdays. > > Thanks - > Xiaolin Seems `get_thread()` is only used in debug code on AArch64 and RISCV -- I have pushed revised code and now hotspot and jdk tier1 are under testing. I will ping this thread when tests are done. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/7 From yadongwang at openjdk.java.net Mon Nov 22 09:58:51 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Mon, 22 Nov 2021 09:58:51 GMT Subject: [riscv-port] RFR: 8277430: riscv: Refactor interpreter native wrappers Message-ID: A similar refactor similar to https://bugs.openjdk.java.net/browse/JDK-8261071, to make the code more clean and open for extension. ------------- Commit messages: - 8277430: riscv: Refactor interpreter native wrappers Changes: https://git.openjdk.java.net/riscv-port/pull/12/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=12&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277430 Stats: 155 lines in 2 files changed: 39 ins; 33 del; 83 mod Patch: https://git.openjdk.java.net/riscv-port/pull/12.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/12/head:pull/12 PR: https://git.openjdk.java.net/riscv-port/pull/12 From fyang at openjdk.java.net Tue Nov 23 01:29:30 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 23 Nov 2021 01:29:30 GMT Subject: [riscv-port] RFR: 8277430: riscv: Refactor interpreter native wrappers In-Reply-To: References: Message-ID: On Mon, 22 Nov 2021 09:53:44 GMT, Yadong Wang wrote: > A similar refactor similar to https://bugs.openjdk.java.net/browse/JDK-8261071, to make the code more clean and open for extension. > Hotspot and jdk tier1 test passed on unmatched boards. All JTreg tests were tested on qemu without new failures. Changes requested by fyang (Lead). src/hotspot/cpu/riscv/interpreterRT_riscv.cpp line 175: > 173: private: > 174: address _from; > 175: char* _to; It would be better to do this change in another commit. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/12 From fyang at openjdk.java.net Tue Nov 23 01:30:35 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 23 Nov 2021 01:30:35 GMT Subject: [riscv-port] RFR: 8277391: riscv: implement tls function MacroAssembler::get_thread() by using tls.gd [v2] In-Reply-To: References: Message-ID: On Mon, 22 Nov 2021 02:40:18 GMT, zhengxiaolinX wrote: >> Hi Felix - >> >> Quite sorry for the late reply - it takes me some time to look up some references. This code looks great without any problem and I totally agree with your point - so it is hard to make me not think you have implemented one version already in your codebase :-) And `__tls_get_addr`'s implementation could found itself at [this link](https://sources.debian.org/src/glibc/2.31-13/sysdeps/riscv/libc-tls.c/) with [macros defined](https://sources.debian.org/src/glibc/2.31-13/sysdeps/riscv/nptl/tls.h/), which is a C function. With this respect, it seems that I also need to save and restore all volatile registers pessimistically in `MacroAssembler::get_thread`, same as the current implementation on the master branch. I think it might be hard to keep the saved registers the same as AArch64's implementation that only clobbers x1 - please correct me if I missed something. But this seems much cheaper than calling a [pthread_getspecific](https://sources.debian.org/src/glibc/2.32-4/nptl/pthread_g etspecific.c/?hl=24#L24). In fact, the first version of this patch is written in a similar way as yours - for better performance I chose to use tls.ie - but I think you hold a very reasonable point. >> >> It's Friday night so please feel free to move the discussion to weekdays. >> >> Thanks - >> Xiaolin > > Seems `get_thread()` is only used in debug code on AArch64 and RISCV -- I have pushed revised code and now hotspot and jdk tier1 are under testing. I will ping this thread when tests are done. Updated changes looks good. Let's see when you have the test result. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/7 From yadongwang at openjdk.java.net Tue Nov 23 02:55:07 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Tue, 23 Nov 2021 02:55:07 GMT Subject: [riscv-port] RFR: 8277430: riscv: Refactor interpreter native wrappers [v2] In-Reply-To: References: Message-ID: > A similar refactor similar to https://bugs.openjdk.java.net/browse/JDK-8261071, to make the code more clean and open for extension. > Hotspot and jdk tier1 test passed on unmatched boards. All JTreg tests were tested on qemu without new failures. Yadong Wang has updated the pull request incrementally with one additional commit since the last revision: 8277430: riscv: Refactor interpreter native wrappers(2) ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/12/files - new: https://git.openjdk.java.net/riscv-port/pull/12/files/d6d4c6fd..b0e28c80 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=12&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=12&range=00-01 Stats: 11 lines in 1 file changed: 0 ins; 2 del; 9 mod Patch: https://git.openjdk.java.net/riscv-port/pull/12.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/12/head:pull/12 PR: https://git.openjdk.java.net/riscv-port/pull/12 From fyang at openjdk.java.net Tue Nov 23 03:59:38 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 23 Nov 2021 03:59:38 GMT Subject: [riscv-port] RFR: 8277430: riscv: Refactor interpreter native wrappers [v2] In-Reply-To: References: Message-ID: <8Zz4ZiMi5mkbX79nR4b8dTdieAuS3sppqFXa2OklgMI=.74f02a33-c0ad-4afd-b9f4-cfb37632b2a1@github.com> On Tue, 23 Nov 2021 02:55:07 GMT, Yadong Wang wrote: >> A similar refactor similar to https://bugs.openjdk.java.net/browse/JDK-8261071, to make the code more clean and open for extension. >> Hotspot and jdk tier1 test passed on unmatched boards. All JTreg tests were tested on qemu without new failures. > > Yadong Wang has updated the pull request incrementally with one additional commit since the last revision: > > 8277430: riscv: Refactor interpreter native wrappers(2) Updated changes looks good. Nice cleanup! ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/12 From yadongwang at openjdk.java.net Tue Nov 23 05:06:35 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Tue, 23 Nov 2021 05:06:35 GMT Subject: [riscv-port] Integrated: 8277430: riscv: Refactor interpreter native wrappers In-Reply-To: References: Message-ID: On Mon, 22 Nov 2021 09:53:44 GMT, Yadong Wang wrote: > A similar refactor similar to https://bugs.openjdk.java.net/browse/JDK-8261071, to make the code more clean and open for extension. > Hotspot and jdk tier1 test passed on unmatched boards. All JTreg tests were tested on qemu without new failures. This pull request has now been integrated. Changeset: 2485efbf Author: Yadong Wang Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/2485efbf90041ff98506dfe46d2545adf5044bd3 Stats: 152 lines in 2 files changed: 38 ins; 34 del; 80 mod 8277430: riscv: Refactor interpreter native wrappers Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/12 From yadongwang at openjdk.java.net Tue Nov 23 07:07:45 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Tue, 23 Nov 2021 07:07:45 GMT Subject: [riscv-port] RFR: 8277431: riscv: Intrinsify recursive ObjectMonitor locking for C2 Message-ID: According to https://bugs.openjdk.java.net/browse/JDK-8277180, the C2 fast_lock and fast_unlock intrinsics don't support recursive ObjectMonitor locking. Some workload can significantly benefit from this. This fixes the problem on riscv. Tier1 tests of hotspot and jdk are passed on unmatched and all JTreg tests are tested on qemu without new failures. ------------- Commit messages: - 8277431: riscv: Intrinsify recursive ObjectMonitor locking for C2 Changes: https://git.openjdk.java.net/riscv-port/pull/13/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=13&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277431 Stats: 21 lines in 1 file changed: 20 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/riscv-port/pull/13.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/13/head:pull/13 PR: https://git.openjdk.java.net/riscv-port/pull/13 From fyang at openjdk.java.net Tue Nov 23 07:56:27 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 23 Nov 2021 07:56:27 GMT Subject: [riscv-port] RFR: 8277391: riscv: implement tls function MacroAssembler::get_thread() by using tls.gd [v2] In-Reply-To: <_swFqm5pZ3XN45D8wTisJqG4LV5p8rYgjvQaR7-d_7c=.6d316a63-97f9-447f-99a6-8dc8501edbc7@github.com> References: <_swFqm5pZ3XN45D8wTisJqG4LV5p8rYgjvQaR7-d_7c=.6d316a63-97f9-447f-99a6-8dc8501edbc7@github.com> Message-ID: On Mon, 22 Nov 2021 02:46:03 GMT, zhengxiaolinX wrote: >> Hi team, >> >> This patch fixes the unimplemented assembly version of `__ get_thread()`, bringing some performance improvement by directly using the x4 register to refer to the variable `Thread::_thr_current`. Tested tests under hotspot/ and jdk/. [Original patch](https://github.com/riscv-collab/riscv-openjdk/pull/4) >> >> Thanks, >> Xiaolin > > zhengxiaolinX has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > Implement tls function MacroAssembler::get_thread() using tls.gd After some reconsideration, I think we can go one step further: simply keep the changes in file src/hotspot/share/utilities/globalDefinitions_gcc.hpp and remote all other changes in this PR. Then USE_LIBRARY_BASED_TLS_ONLY macro won't be defined and Thread::current() will return '_ZN6Thread12_thr_currentE' in that case. This will be the same in functionality as the newly add assembly function '_ZN10JavaThread25riscv64_get_thread_helperEv'. I have checked with Yadong, the reason for defining USE_LIBRARY_BASED_TLS_ONLY macro is to workaround some host compiler bug when accessing TLS variables in the very early days. This should not affect us now. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/7 From duke at openjdk.java.net Tue Nov 23 08:42:34 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Tue, 23 Nov 2021 08:42:34 GMT Subject: [riscv-port] RFR: 8277391: riscv: implement tls function MacroAssembler::get_thread() by using tls.gd [v2] In-Reply-To: References: <_swFqm5pZ3XN45D8wTisJqG4LV5p8rYgjvQaR7-d_7c=.6d316a63-97f9-447f-99a6-8dc8501edbc7@github.com> Message-ID: On Tue, 23 Nov 2021 07:53:46 GMT, Fei Yang wrote: > After some reconsideration, I think we can go one step further: simply keep the changes in file src/hotspot/share/utilities/globalDefinitions_gcc.hpp and remote all other changes in this PR. > > Then USE_LIBRARY_BASED_TLS_ONLY macro won't be defined and Thread::current() will return '_ZN6Thread12_thr_currentE' in that case. This will be the same in functionality as the newly add assembly function '_ZN10JavaThread25riscv64_get_thread_helperEv'. > > I have checked with Yadong, the reason for defining USE_LIBRARY_BASED_TLS_ONLY macro is to workaround some host compiler bug when accessing TLS variables in the very early days. This should not affect us now. I think I get your point - I wonder if that `remote` should actually be a `revert`? If it is - that's great - I think this is a pretty and concise solution if we need to clobber all volatile registers anyway. Let me revise this patch and change the titles. But calling a `call_VM_leaf_base()` is a bit duplicated because this function would save another bunch of registers like x5 and x31 again, so I would recommend directly using a pair of `movptr_with_offset` and `jalr` - though it might be insignificant. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/7 From duke at openjdk.java.net Tue Nov 23 09:08:59 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Tue, 23 Nov 2021 09:08:59 GMT Subject: [riscv-port] RFR: 8277391: riscv: Remove the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific [v3] In-Reply-To: References: Message-ID: > Hi team, > > This patch removes the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific. [Original patch](https://github.com/riscv-collab/riscv-openjdk/pull/4) > > Thanks, > Xiaolin zhengxiaolinX has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Remove the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/7/files - new: https://git.openjdk.java.net/riscv-port/pull/7/files/d64f27ef..9fa339c5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=7&range=02 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=7&range=01-02 Stats: 44 lines in 2 files changed: 0 ins; 42 del; 2 mod Patch: https://git.openjdk.java.net/riscv-port/pull/7.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/7/head:pull/7 PR: https://git.openjdk.java.net/riscv-port/pull/7 From fyang at openjdk.java.net Tue Nov 23 09:08:59 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 23 Nov 2021 09:08:59 GMT Subject: [riscv-port] RFR: 8277391: riscv: Remove the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific [v2] In-Reply-To: References: <_swFqm5pZ3XN45D8wTisJqG4LV5p8rYgjvQaR7-d_7c=.6d316a63-97f9-447f-99a6-8dc8501edbc7@github.com> Message-ID: On Tue, 23 Nov 2021 08:39:28 GMT, zhengxiaolinX wrote: > > After some reconsideration, I think we can go one step further: simply keep the changes in file src/hotspot/share/utilities/globalDefinitions_gcc.hpp and remote all other changes in this PR. > > Then USE_LIBRARY_BASED_TLS_ONLY macro won't be defined and Thread::current() will return '_ZN6Thread12_thr_currentE' in that case. This will be the same in functionality as the newly add assembly function '_ZN10JavaThread25riscv64_get_thread_helperEv'. > > I have checked with Yadong, the reason for defining USE_LIBRARY_BASED_TLS_ONLY macro is to workaround some host compiler bug when accessing TLS variables in the very early days. This should not affect us now. > > I think I get your point - I wonder if that `remote` should actually be a `revert`? If it is - that's great - I think this is a pretty and concise solution if we need to clobber all volatile registers anyway. Let me revise this patch and change the titles. But calling a `call_VM_leaf_base()` is a bit duplicated because this function would save another bunch of registers like x5 and x31 again, so I would recommend directly using a pair of `movptr_with_offset` and `jalr` - though it might be insignificant. Sorry for the typo. Should be "remove". Please do. We should keep your original changes about the comment for MacroAssembler::get_thread(Register thread) at the same time :-) ------------- PR: https://git.openjdk.java.net/riscv-port/pull/7 From duke at openjdk.java.net Tue Nov 23 10:23:38 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Tue, 23 Nov 2021 10:23:38 GMT Subject: [riscv-port] RFR: 8277391: riscv: Remove the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific [v3] In-Reply-To: References: Message-ID: On Tue, 23 Nov 2021 09:08:59 GMT, zhengxiaolinX wrote: >> Hi team, >> >> This patch removes the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific. [Original patch](https://github.com/riscv-collab/riscv-openjdk/pull/4) >> >> Thanks, >> Xiaolin > > zhengxiaolinX has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. Simply tested a `test/hotspot/jtreg/compiler` folder on qemu and no more errors found. Would you mind having another review of this patch? I feel pleased to receive any suggestion. Thanks, Xiaolin ------------- PR: https://git.openjdk.java.net/riscv-port/pull/7 From fyang at openjdk.java.net Tue Nov 23 10:50:24 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 23 Nov 2021 10:50:24 GMT Subject: [riscv-port] RFR: 8277391: riscv: Remove the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific [v3] In-Reply-To: References: Message-ID: On Tue, 23 Nov 2021 09:08:59 GMT, zhengxiaolinX wrote: >> Hi team, >> >> This patch removes the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific. [Original patch](https://github.com/riscv-collab/riscv-openjdk/pull/4) >> >> Thanks, >> Xiaolin > > zhengxiaolinX has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Remove the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific Looks good. Thanks. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/7 From duke at openjdk.java.net Tue Nov 23 10:58:02 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Tue, 23 Nov 2021 10:58:02 GMT Subject: [riscv-port] RFR: 8277391: riscv: Remove the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific [v3] In-Reply-To: References: Message-ID: On Tue, 23 Nov 2021 09:08:59 GMT, zhengxiaolinX wrote: >> Hi team, >> >> This patch removes the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific. [Original patch](https://github.com/riscv-collab/riscv-openjdk/pull/4) >> >> Thanks, >> Xiaolin > > zhengxiaolinX has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. Sorry for that typo - ------------- PR: https://git.openjdk.java.net/riscv-port/pull/7 From duke at openjdk.java.net Tue Nov 23 11:03:26 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Tue, 23 Nov 2021 11:03:26 GMT Subject: [riscv-port] Integrated: 8277391: riscv: Remove the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific In-Reply-To: References: Message-ID: <4lcw-93sVM6QfybqaeIhtEQ8ErUF2fPh4dDnkrwZUmQ=.6fcda6f6-2bf4-431d-a001-ca463909c509@github.com> On Thu, 18 Nov 2021 12:36:31 GMT, zhengxiaolinX wrote: > Hi team, > > This patch removes the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific. [Original patch](https://github.com/riscv-collab/riscv-openjdk/pull/4) > > Thanks, > Xiaolin This pull request has now been integrated. Changeset: 7cf6b9d2 Author: yunyao.zxl Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/7cf6b9d27a3c628771b70b9982c17d0d52b75b3b Stats: 16 lines in 2 files changed: 4 ins; 10 del; 2 mod 8277391: riscv: Remove the USE_LIBRARY_BASED_TLS_ONLY macro to use tls instead of pthread_getspecific Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/7 From fyang at openjdk.java.net Tue Nov 23 11:10:35 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 23 Nov 2021 11:10:35 GMT Subject: [riscv-port] RFR: 8277431: riscv: Intrinsify recursive ObjectMonitor locking for C2 In-Reply-To: References: Message-ID: <4Bmd4y2GtkU5V6dMuV9CGxYTjLDJO_a2pf1LJWBWgrM=.09a26203-b1f6-4580-a354-51bd16875cf1@github.com> On Tue, 23 Nov 2021 07:02:33 GMT, Yadong Wang wrote: > According to https://bugs.openjdk.java.net/browse/JDK-8277180, the C2 fast_lock and fast_unlock intrinsics don't support recursive ObjectMonitor locking. Some workload can significantly benefit from this. This fixes the problem on riscv. > Tier1 tests of hotspot and jdk are passed on unmatched and all JTreg tests are tested on qemu without new failures. It would be interesting to know how this may affect performance on riscv. Maybe we can try DaCapo h2 to see. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/13 From yadongwang at openjdk.java.net Tue Nov 23 11:37:24 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Tue, 23 Nov 2021 11:37:24 GMT Subject: [riscv-port] RFR: 8277431: riscv: Intrinsify recursive ObjectMonitor locking for C2 In-Reply-To: <4Bmd4y2GtkU5V6dMuV9CGxYTjLDJO_a2pf1LJWBWgrM=.09a26203-b1f6-4580-a354-51bd16875cf1@github.com> References: <4Bmd4y2GtkU5V6dMuV9CGxYTjLDJO_a2pf1LJWBWgrM=.09a26203-b1f6-4580-a354-51bd16875cf1@github.com> Message-ID: On Tue, 23 Nov 2021 11:07:09 GMT, Fei Yang wrote: > It would be interesting to know how this may affect performance on riscv. Maybe we can try DaCapo h2 to see. DaCapo results are updated. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/13 From fyang at openjdk.java.net Tue Nov 23 12:18:26 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 23 Nov 2021 12:18:26 GMT Subject: [riscv-port] RFR: 8277431: riscv: Intrinsify recursive ObjectMonitor locking for C2 In-Reply-To: References: Message-ID: On Tue, 23 Nov 2021 07:02:33 GMT, Yadong Wang wrote: > According to https://bugs.openjdk.java.net/browse/JDK-8277180, the C2 fast_lock and fast_unlock intrinsics don't support recursive ObjectMonitor locking. Some workload can significantly benefit from this. This fixes the problem on riscv. > > Tier1 tests of hotspot and jdk are passed on unmatched and all JTreg tests are tested on qemu without new failures. > > [The original performance regression after JDK-8253064](https://bugs.openjdk.java.net/browse/JDK-8263864) was resolved by this intrinsic. > The benchmark ran on unmatched: > > dacapo-9.12-MR1-bach.jar h2 -s huge -t 1 -n 1 > > Non-intrisified recursive fast_lock/fast_unlock: > ===== DaCapo 9.12-MR1 h2 PASSED in 2614652 msec ===== > Intrisified recursive fast_lock/fast_unlock: > ===== DaCapo 9.12-MR1 h2 PASSED in 2027247 msec ===== The performance numbers looks great. Thanks. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/13 From yadongwang at openjdk.java.net Tue Nov 23 12:25:39 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Tue, 23 Nov 2021 12:25:39 GMT Subject: [riscv-port] Integrated: 8277431: riscv: Intrinsify recursive ObjectMonitor locking for C2 In-Reply-To: References: Message-ID: <3c62KCBDKd7RgSYtuAO9Ns4-_EmtngurmZT7TR38QxU=.709eec04-f494-45d6-80c7-125dbad2f9a0@github.com> On Tue, 23 Nov 2021 07:02:33 GMT, Yadong Wang wrote: > According to https://bugs.openjdk.java.net/browse/JDK-8277180, the C2 fast_lock and fast_unlock intrinsics don't support recursive ObjectMonitor locking. Some workload can significantly benefit from this. This fixes the problem on riscv. > > Tier1 tests of hotspot and jdk are passed on unmatched and all JTreg tests are tested on qemu without new failures. > > [The original performance regression after JDK-8253064](https://bugs.openjdk.java.net/browse/JDK-8263864) was resolved by this intrinsic. > The benchmark ran on unmatched: > > dacapo-9.12-MR1-bach.jar h2 -s huge -t 1 -n 1 > > Non-intrisified recursive fast_lock/fast_unlock: > ===== DaCapo 9.12-MR1 h2 PASSED in 2614652 msec ===== > Intrisified recursive fast_lock/fast_unlock: > ===== DaCapo 9.12-MR1 h2 PASSED in 2027247 msec ===== This pull request has now been integrated. Changeset: a319e9ab Author: Yadong Wang Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/a319e9aba1eddb558fd4fa0c6c85ea36fe0303d2 Stats: 21 lines in 1 file changed: 20 ins; 1 del; 0 mod 8277431: riscv: Intrinsify recursive ObjectMonitor locking for C2 Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/13 From duke at openjdk.java.net Fri Nov 26 02:03:51 2021 From: duke at openjdk.java.net (duke) Date: Fri, 26 Nov 2021 02:03:51 GMT Subject: git: openjdk/riscv-port: riscv-port: 61 new changesets Message-ID: <1674d3ea-1a28-407b-ae32-b178aa3347af@openjdk.java.net> Changeset: 1c215f33 Author: Vishal Chand Committer: Thomas Schatzl Date: 2021-11-20 10:03:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1c215f33698ba2aef4fb230475a9bd33ed3005f9 8272773: Configurable card table card size Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1Arguments.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/parallel/objectStartArray.cpp ! src/hotspot/share/gc/parallel/objectStartArray.hpp ! src/hotspot/share/gc/parallel/parallelArguments.cpp ! src/hotspot/share/gc/shared/blockOffsetTable.cpp ! src/hotspot/share/gc/shared/blockOffsetTable.hpp ! src/hotspot/share/gc/shared/cardTable.cpp ! src/hotspot/share/gc/shared/cardTable.hpp ! src/hotspot/share/gc/shared/gc_globals.hpp ! src/hotspot/share/gc/shared/genArguments.cpp ! src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp ! src/hotspot/share/gc/shared/jvmFlagConstraintsGC.hpp Changeset: 0a9e76c4 Author: Jie Fu Date: 2021-11-20 10:12:26 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0a9e76c4f9d966015c19e87e3eb59ceb7489459f 8277485: Zero: Fix _fast_{i,f}access_0 bytecodes handling Reviewed-by: sgehwolf, shade ! src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp Changeset: 4ff43010 Author: Joe Darcy Date: 2021-11-21 20:42:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4ff43010bb3f92bd58f66be52a086b3d078b0cbb 8224922: Access JavaFileObject from Element(s) Co-authored-by: Jan Lahoda Reviewed-by: jjg ! src/java.compiler/share/classes/javax/annotation/processing/Filer.java ! src/java.compiler/share/classes/javax/lang/model/element/ExecutableElement.java ! src/java.compiler/share/classes/javax/lang/model/element/package-info.java ! src/java.compiler/share/classes/javax/lang/model/util/Elements.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/model/JavacElements.java + test/langtools/tools/javac/processing/model/element/TestFileObjectOf.java ! test/langtools/tools/javac/tree/NoPrivateTypesExported.java Changeset: ca31ed53 Author: TatWai Chong Date: 2021-11-22 02:31:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ca31ed5335f6fa7229c94ba20d9d6031b930d69a 8275448: [REDO] AArch64: Implement string_compare intrinsic in SVE Reviewed-by: ngasson, aph ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/aarch64_sve.ad ! src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 ! src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/register_aarch64.hpp ! src/hotspot/cpu/aarch64/register_definitions_aarch64.cpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp + test/micro/org/openjdk/bench/java/lang/StringCompareToDifferentLength.java Changeset: 3f847fe8 Author: Aleksey Shipilev Date: 2021-11-22 09:09:21 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3f847fe89a088d6921107ca887a7a1bace871bd6 8277385: Zero: Enable CompactStrings support Reviewed-by: redestad, adinn ! src/hotspot/cpu/zero/globals_zero.hpp Changeset: 8051041e Author: Albert Mingkun Yang Date: 2021-11-22 09:59:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8051041eb2b3d70d4cc62b6f2726279d51e44733 8277534: Remove unused ReferenceProcessor::has_discovered_references Reviewed-by: tschatzl ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/referenceProcessor.hpp Changeset: 32839ba0 Author: Serguei Spitsyn Date: 2021-11-22 10:47:47 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/32839ba012f0a0a66e249cd8d12b94499d82ec0a 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be" Reviewed-by: mdoerr, lmesnik, dcubed ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! test/hotspot/jtreg/ProblemList.txt Changeset: d427c79d Author: Hamlin Li Date: 2021-11-22 11:27:05 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d427c79d3bd6c80b67c10d15a461f13ae7e0f84b 8277428: G1: Move and inline G1STWIsAliveClosure::do_object_b Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/g1/g1YoungCollector.cpp Changeset: 6b4fbaed Author: Jim Laskey Date: 2021-11-22 16:17:01 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6b4fbaedbb782c5f028735ac1d92838895589192 8273792: JumpableGenerator.rngs() documentation refers to wrong method Co-authored-by: Guy Steele Reviewed-by: rriggs ! src/java.base/share/classes/java/util/random/RandomGenerator.java Changeset: 8683de5e Author: Jim Laskey Date: 2021-11-22 16:19:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8683de5eda2d1a04f187073f969140245908f324 8274685: Documentation suggests there are ArbitrarilyJumpableGenerator when none Co-authored-by: Guy Steele Reviewed-by: rriggs ! src/java.base/share/classes/java/util/random/package-info.java Changeset: e5298655 Author: Jatin Bhateja Date: 2021-11-22 16:38:52 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e529865531d0eb5a2119a1d220b195d088794226 8277239: SIGSEGV in vrshift_reg_maskedNode::emit Reviewed-by: sviswanathan, dlong ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/opto/vectorIntrinsics.cpp ! src/hotspot/share/opto/vectornode.cpp ! src/hotspot/share/opto/vectornode.hpp Changeset: 22f12ac4 Author: Joe Darcy Date: 2021-11-22 16:59:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/22f12ac429fbbf134d182d9bf2a16a3d43bc71e1 8277522: Make formatting of null consistent in Elements Reviewed-by: jlahoda ! src/java.compiler/share/classes/javax/lang/model/util/Elements.java Changeset: 33e2a518 Author: Leonid Mesnik Date: 2021-11-22 17:11:34 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/33e2a518ebcd50e76c559512539fd7c864fd2407 8265795: vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java fails when running with JEP 416 Reviewed-by: sspitsyn, dholmes ! src/hotspot/share/prims/unsafe.cpp ! test/hotspot/jtreg/ProblemList.txt + test/hotspot/jtreg/serviceability/jvmti/VMObjectAlloc/VMObjectAllocTest.java + test/hotspot/jtreg/serviceability/jvmti/VMObjectAlloc/libVMObjectAlloc.cpp Changeset: e3911a85 Author: Alexey Semenyuk Date: 2021-11-22 18:04:46 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e3911a8532e9b93ba5e65c613bd79864485db5ce 8277429: Conflicting jpackage static library name Reviewed-by: almatvee, herrick, erikj ! make/modules/jdk.jpackage/Lib.gmk ! src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxAppImageBuilder.java Changeset: 6cf4cd1a Author: Coleen Phillimore Date: 2021-11-22 18:08:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6cf4cd1aa46414d9af17f3704b27d0d381a17ee8 8273341: Update Siphash to version 1.0 Reviewed-by: dholmes ! src/hotspot/share/classfile/altHashing.cpp ! src/hotspot/share/classfile/altHashing.hpp Changeset: 851a3624 Author: Alexander Zuev Date: 2021-11-22 18:26:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/851a36247937d124e8217deaaa1a1831cba19b6e 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer Reviewed-by: pbansal ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m = src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ProgressIndicatorAccessibility.h + src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ProgressIndicatorAccessibility.m Changeset: 1049aba1 Author: Daniel D. Daugherty Date: 2021-11-22 19:03:30 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1049aba1fb65fd70bd723c80a84250512a68d653 8277576: ProblemList runtime/ErrorHandling/CreateCoredumpOnCrash.java on macosx-X64 8277577: ProblemList compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java on linux-aarch64 8277578: ProblemList applications/jcstress/acqrel.java on linux-aarch64 Reviewed-by: mikael ! test/hotspot/jtreg/ProblemList.txt Changeset: 05a9a51d Author: Dean Long Date: 2021-11-22 20:50:06 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/05a9a51dbfc46eb52bc28f1f9a618c75ee2597e9 8277423: ciReplay: hidden class with comment expected error Reviewed-by: chagedorn, thartmann ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/ci/ciInstanceKlass.cpp ! src/hotspot/share/ci/ciInstanceKlass.hpp Changeset: f62b81c3 Author: Dean Long Date: 2021-11-22 23:17:46 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f62b81c3b5e34895e06bedec137bcef701d49df6 8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/Test.java fails with "wrong OOME" Reviewed-by: shade, stefank ! test/hotspot/jtreg/ProblemList-Xcomp.txt ! test/hotspot/jtreg/vmTestbase/vm/mlvm/hiddenloader/stress/oome/heap/Test.java Changeset: bb11c55d Author: Hamlin Li Date: 2021-11-23 00:58:03 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/bb11c55dff86706a010c93ee2cc60c87bb2d53b6 8277542: G1: Move G1CardSetFreePool and related classes to separate files Reviewed-by: ayang, tschatzl ! src/hotspot/share/gc/g1/g1CardSetMemory.cpp ! src/hotspot/share/gc/g1/g1CardSetMemory.hpp + src/hotspot/share/gc/g1/g1SegmentedArrayFreePool.cpp + src/hotspot/share/gc/g1/g1SegmentedArrayFreePool.hpp Changeset: 12f08ba4 Author: Jaikiran Pai Date: 2021-11-23 08:19:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/12f08ba4d47cb70a0629b17bc3639ce170309f21 8277507: Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures Reviewed-by: almatvee ! test/jdk/tools/jpackage/helpers/jdk/jpackage/test/HelloApp.java Changeset: e3243ee9 Author: Sergey Bylokhov Date: 2021-11-23 08:57:34 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e3243ee963d074c892a0ed16a00fd91b440c96ac 8277087: ZipException: zip END header not found at ZipFile#Source.findEND Reviewed-by: lancea ! src/java.base/share/classes/java/util/zip/ZipOutputStream.java + test/jdk/java/util/zip/ZipOutputStream/EmptyComment.java Changeset: 79350b9b Author: Volker Simonis Date: 2021-11-23 09:15:20 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/79350b9b4f42e43a8ab27ea76b9115dae6f448af 8276216: Negated character classes performance regression in Pattern Reviewed-by: clanger ! src/java.base/share/classes/java/util/regex/Pattern.java + test/micro/org/openjdk/bench/java/util/regex/FindPattern.java Changeset: 017df140 Author: Albert Mingkun Yang Date: 2021-11-23 10:56:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/017df140ba65058270c5184db82162d42e42b908 8277556: Call ReferenceProcessorPhaseTimes::set_processing_is_mt once Reviewed-by: sjohanss, tschatzl ! src/hotspot/share/gc/shared/referenceProcessor.cpp Changeset: 36b887a8 Author: Albert Mingkun Yang Date: 2021-11-23 10:57:29 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/36b887a885c76ddbbb1e21b32b8e7d9cc92f6ce2 8277560: Remove WorkerDataArray::_is_serial Reviewed-by: sjohanss, tschatzl ! src/hotspot/share/gc/shared/workerDataArray.cpp ! src/hotspot/share/gc/shared/workerDataArray.hpp ! src/hotspot/share/gc/shared/workerDataArray.inline.hpp Changeset: 66eaf652 Author: Andrey Turbanov Committer: Thomas Schatzl Date: 2021-11-23 12:33:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/66eaf6526126eb27c18acc64c2bb0791142815c9 8277413: Remove unused local variables in jdk.hotspot.agent Reviewed-by: lmesnik, tschatzl, sspitsyn ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HSDB.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HotSpotTypeDataBase.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/NMethod.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/StubQueue.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgCDebugInfoBuilder.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/GenerateOopMap.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java Changeset: 90f96fb4 Author: Tobias Hartmann Date: 2021-11-23 12:46:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/90f96fb4db174e50cc2510f292fe69fc995add26 8277441: CompileQueue::add fails with assert(_last->next() == __null) failed: not last Reviewed-by: chagedorn, neliasso ! src/hotspot/share/compiler/compileBroker.cpp Changeset: f4dc03ea Author: Erik ?sterlund Date: 2021-11-23 14:34:21 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f4dc03ea6de327425ff265c3d2ec16ea7b0e1634 8276696: ParallelObjectIterator freed at the wrong time in VM_HeapDumper Reviewed-by: pliden, stefank ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/shared/collectedHeap.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zHeapIterator.hpp ! src/hotspot/share/memory/heapInspection.cpp ! src/hotspot/share/services/heapDumper.cpp Changeset: 5e7e2da2 Author: Roger Riggs Date: 2021-11-23 15:02:48 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5e7e2da227cd2b5e2d3d1e2f59fb74ddd1835abb 8272042: java.util.ImmutableCollections$Map1 and MapN should not be @ValueBased Reviewed-by: mchung, iris, naoto, smarks ! src/java.base/share/classes/java/util/ImmutableCollections.java Changeset: 64bdc843 Author: Daniel D. Daugherty Date: 2021-11-23 15:16:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/64bdc843907634b24ab02b8d81a0f5048b46072c 8277649: [BACKOUT] JDK-8277507 Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures Reviewed-by: alanb, stefank ! test/jdk/tools/jpackage/helpers/jdk/jpackage/test/HelloApp.java Changeset: 38802ad5 Author: Christian Hagedorn Date: 2021-11-23 15:22:11 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/38802ad56a31efc90733cb75ea27f019e2c4f5a4 8254108: ciReplay: Support incremental inlining Reviewed-by: dlong, thartmann ! src/hotspot/share/ci/ciReplay.cpp ! src/hotspot/share/ci/ciReplay.hpp ! src/hotspot/share/opto/bytecodeInfo.cpp ! src/hotspot/share/opto/doCall.cpp ! src/hotspot/share/opto/parse.hpp ! test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java + test/hotspot/jtreg/compiler/ciReplay/InliningBase.java + test/hotspot/jtreg/compiler/ciReplay/TestIncrementalInlining.java ! test/hotspot/jtreg/compiler/ciReplay/TestInliningProtectionDomain.java Changeset: 7b67a49f Author: Vicente Romero Date: 2021-11-23 15:23:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7b67a49f830b71ef129a4a3a9b0d994d58587edf 8261847: performance of java.lang.Record::toString should be improved Reviewed-by: jlaskey, redestad ! src/java.base/share/classes/java/lang/runtime/ObjectMethods.java + test/langtools/tools/javac/records/BigRecordsToStringTest.java + test/micro/org/openjdk/bench/java/lang/runtime/ObjectMethods.java Changeset: 8a44e093 Author: Jan Lahoda Date: 2021-11-23 16:46:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8a44e093dc3e192990fde8ab37ab08c737f06b39 8268725: jshell does not support the --enable-native-access option Reviewed-by: sundar ! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java ! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n.properties + test/langtools/jdk/jshell/ToolEnableNativeAccessTest.java Changeset: e8acac2a Author: Daniel D. Daugherty Date: 2021-11-23 17:08:31 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e8acac2aba30e8a172ca14509220ec06e833d4af 8277350: runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java times out Reviewed-by: hseigel, dholmes, lmesnik ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java Changeset: 03206726 Author: Mandy Chung Date: 2021-11-23 17:14:59 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/032067264fd73cd2f338838d6178f8af24d228b0 8277451: java.lang.reflect.Field::set on static field with invalid argument type should throw IAE Reviewed-by: alanb ! src/java.base/share/classes/jdk/internal/reflect/FieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/MethodHandleBooleanFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/MethodHandleByteFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/MethodHandleCharacterFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/MethodHandleDoubleFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/MethodHandleFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/MethodHandleFloatFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/MethodHandleIntegerFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/MethodHandleLongFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/MethodHandleObjectFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/MethodHandleShortFieldAccessorImpl.java + test/jdk/java/lang/reflect/Field/NegativeTest.java ! test/jdk/java/lang/reflect/MethodHandleAccessorsTest.java Changeset: ea85e01a Author: Liam Miller-Cushon Date: 2021-11-23 18:14:47 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ea85e01a4c8db1bc48d590abc882dc6efe5b0f4a 8271623: Omit enclosing instance fields from inner classes that don't use it Reviewed-by: vromero, jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Target.java ! test/langtools/tools/javac/6521805/T6521805d.java ! test/langtools/tools/javac/6521805/T6521805d.out ! test/langtools/tools/javac/6521805/p/Outer.java ! test/langtools/tools/javac/ClassFileModifiers/MemberModifiers.out ! test/langtools/tools/javac/annotations/typeAnnotations/classfile/AnnotatedExtendsTest.java ! test/langtools/tools/javac/classfiles/attributes/Synthetic/AccessToPrivateInnerClassConstructorsTest.java ! test/langtools/tools/javac/classfiles/attributes/Synthetic/AccessToPrivateInnerClassMembersTest.java ! test/langtools/tools/javac/classfiles/attributes/Synthetic/AccessToPrivateSiblingsTest.java ! test/langtools/tools/javac/classfiles/attributes/Synthetic/BridgeMethodsForLambdaTest.java ! test/langtools/tools/javac/classfiles/attributes/Synthetic/ThisFieldTest.java ! test/langtools/tools/javac/diags/examples/ErrSyntheticNameConflict.java + test/langtools/tools/javac/optimizeOuterThis/DontOptimizeOuterThis.java + test/langtools/tools/javac/optimizeOuterThis/InnerClasses.java + test/langtools/tools/javac/optimizeOuterThis/OptimizeOuterThis.java ! test/langtools/tools/javap/AnnoTest.java Changeset: 24e586a0 Author: Andrew Leonard Date: 2021-11-23 18:28:30 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/24e586a04368a76cd9f37aa783b974b9e0351d58 8276764: Enable deterministic file content ordering for Jar and Jmod Reviewed-by: mchung, ihse ! src/jdk.jartool/share/classes/sun/tools/jar/Main.java ! src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java + test/jdk/tools/jar/ContentOrder.java ! test/jdk/tools/jmod/JmodTest.java Changeset: 7cb56a23 Author: Leonid Mesnik Date: 2021-11-23 19:27:50 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7cb56a230dbd52935ae48fe44b4192ae3b4d7adb 8265796: vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java fails when running with JEP 416 Reviewed-by: cjplummer, mchung ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects002/referringObjects002a.java Changeset: 7b2d823e Author: Evgeny Astigeevich Committer: Paul Hohensee Date: 2021-11-23 20:05:57 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7b2d823e842e6a66dbe46b048da44ca9e5485c75 8277503: compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java failed with "OnSpinWaitInst with the expected value 'isb' not found." Reviewed-by: chagedorn, aph, phh ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java Changeset: 712b8756 Author: Stefan Karlsson Date: 2021-11-24 08:25:03 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/712b8756828c88d4f71292d19fddb598d188c429 8277397: ZGC: Add JFR event for temporary latency measurements Reviewed-by: eosterlund, jbachorik, pliden, mgronlun ! src/hotspot/share/gc/z/zTracer.cpp ! src/hotspot/share/gc/z/zTracer.hpp ! src/hotspot/share/gc/z/zTracer.inline.hpp ! src/hotspot/share/jfr/metadata/metadata.xml ! src/jdk.jfr/share/conf/jfr/default.jfc ! src/jdk.jfr/share/conf/jfr/profile.jfc Changeset: 6d734604 Author: Stefan Karlsson Date: 2021-11-24 08:26:22 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6d734604a38447d81df36f4d4ca57ce71bd570af 8277399: ZGC: Move worker thread logging out of gc+phase=debug Reviewed-by: eosterlund, pliden ! src/hotspot/share/gc/z/zStat.cpp Changeset: d085c2b8 Author: Jan Lahoda Date: 2021-11-24 10:07:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d085c2b8a790a5ddfbb01a0ea4edd4051cfb704b 8273328: Compiler implementation for Pattern Matching for switch (Second Preview) Reviewed-by: vromero, mcimadamore ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java ! test/langtools/tools/javac/patterns/Domination.java ! test/langtools/tools/javac/patterns/Domination.out ! test/langtools/tools/javac/patterns/EnumTypeChanges.java ! test/langtools/tools/javac/patterns/Exhaustiveness.java ! test/langtools/tools/javac/patterns/SwitchErrors.java ! test/langtools/tools/javac/patterns/SwitchErrors.out ! test/langtools/tools/javac/patterns/Switches.java Changeset: 8a8bc29f Author: Ludvig Janiuk Committer: Nils Eliasson Date: 2021-11-24 11:03:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8a8bc29f203fa4aaa29303a778fd388e32ca651a 8277562: Remove dead method c1 If::swap_sux Reviewed-by: thartmann, neliasso ! src/hotspot/share/c1/c1_Instruction.hpp Changeset: 17e68caa Author: KIRIYAMA Takuya Committer: Tobias Hartmann Date: 2021-11-24 11:22:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/17e68caad727b04f5e7efde59fce960c66558504 8277042: add test for 8276036 to compiler/codecache Reviewed-by: chagedorn, thartmann + test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java Changeset: 96e36071 Author: Maurizio Cimadamore Date: 2021-11-24 11:51:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/96e36071b63b624d56739b014b457ffc48147c4f 8275063: Implementation of Foreign Function & Memory API (Second incubator) Reviewed-by: erikj, psandoz, jvernee, darcy ! make/test/JtregNativeJdk.gmk ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/prims/universalUpcallHandler.cpp ! src/java.base/share/classes/java/lang/Module.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/java.base/share/classes/java/lang/invoke/VarHandles.java ! src/java.base/share/classes/java/nio/Buffer.java ! src/java.base/share/classes/jdk/internal/access/JavaLangInvokeAccess.java ! src/java.base/share/classes/jdk/internal/access/JavaNioAccess.java ! src/java.base/share/classes/jdk/internal/misc/X-ScopedMemoryAccess.java.template ! src/java.base/share/classes/jdk/internal/reflect/Reflection.java ! src/java.base/share/classes/sun/nio/ch/IOUtil.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/AbstractLayout.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/Addressable.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/FunctionDescriptor.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/GroupLayout.java - src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryAccess.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryAddress.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryHandles.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayout.java - src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayouts.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java + src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/NativeSymbol.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/PaddingLayout.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/ResourceScope.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/SegmentAllocator.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/SequenceLayout.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/SymbolLookup.java + src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/VaList.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/ValueLayout.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/package-info.java - src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/AbstractCLinker.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/ArenaAllocator.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/CABI.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/ConfinedScope.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/LayoutPath.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/MemoryAddressImpl.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/NativeMemorySegmentImpl.java + src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/NativeSymbolImpl.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/PlatformLayouts.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/ResourceScopeImpl.java + src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/Scoped.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/SharedScope.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/SystemLookup.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/Utils.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/Binding.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/BufferLayout.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/CallingSequence.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/CallingSequenceBuilder.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/ProgrammableInvoker.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/ProgrammableUpcallHandler.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/SharedUtils.java - src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/UpcallHandler.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/UpcallStubs.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/aarch64/CallArranger.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/aarch64/TypeClass.java + src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/aarch64/linux/LinuxAArch64CallArranger.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/aarch64/linux/LinuxAArch64Linker.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/aarch64/linux/LinuxAArch64VaList.java + src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/aarch64/macos/MacOsAArch64CallArranger.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/aarch64/macos/MacOsAArch64Linker.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/aarch64/macos/MacOsAArch64VaList.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/sysv/CallArranger.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/sysv/SysVVaList.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/sysv/SysVx64Linker.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/sysv/TypeClass.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/windows/CallArranger.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/windows/TypeClass.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/windows/WinVaList.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/abi/x64/windows/Windowsx64Linker.java ! test/hotspot/jtreg/gc/shenandoah/compiler/TestLinkToNativeRBP.java ! test/jdk/java/foreign/CallGeneratorHelper.java ! test/jdk/java/foreign/NativeTestHelper.java ! test/jdk/java/foreign/SafeFunctionAccessTest.java ! test/jdk/java/foreign/StdLibTest.java ! test/jdk/java/foreign/TestAdaptVarHandles.java - test/jdk/java/foreign/TestAddressHandle.java + test/jdk/java/foreign/TestArrayCopy.java ! test/jdk/java/foreign/TestArrays.java ! test/jdk/java/foreign/TestByteBuffer.java - test/jdk/java/foreign/TestCircularInit1.java - test/jdk/java/foreign/TestCircularInit2.java ! test/jdk/java/foreign/TestCondy.java ! test/jdk/java/foreign/TestDowncall.java ! test/jdk/java/foreign/TestFree.java ! test/jdk/java/foreign/TestFunctionDescriptor.java ! test/jdk/java/foreign/TestHandshake.java ! test/jdk/java/foreign/TestIllegalLink.java ! test/jdk/java/foreign/TestIntrinsics.java - test/jdk/java/foreign/TestLayoutAttributes.java ! test/jdk/java/foreign/TestLayoutConstants.java ! test/jdk/java/foreign/TestLayoutEquality.java ! test/jdk/java/foreign/TestLayoutPaths.java ! test/jdk/java/foreign/TestLayouts.java ! test/jdk/java/foreign/TestMemoryAccess.java + test/jdk/java/foreign/TestMemoryAccessInstance.java - test/jdk/java/foreign/TestMemoryAccessStatics.java ! test/jdk/java/foreign/TestMemoryAlignment.java - test/jdk/java/foreign/TestMemoryCopy.java + test/jdk/java/foreign/TestMemoryDereference.java ! test/jdk/java/foreign/TestMemoryHandleAsUnsigned.java ! test/jdk/java/foreign/TestMismatch.java ! test/jdk/java/foreign/TestNULLAddress.java ! test/jdk/java/foreign/TestNative.java ! test/jdk/java/foreign/TestNoForeignUnsafeOverride.java ! test/jdk/java/foreign/TestNulls.java - test/jdk/java/foreign/TestRebase.java ! test/jdk/java/foreign/TestReshape.java ! test/jdk/java/foreign/TestResourceScope.java ! test/jdk/java/foreign/TestRestricted.java ! test/jdk/java/foreign/TestScopedOperations.java ! test/jdk/java/foreign/TestSegmentAllocators.java + test/jdk/java/foreign/TestSegmentCopy.java + test/jdk/java/foreign/TestSegmentOffset.java + test/jdk/java/foreign/TestSegmentOverlap.java ! test/jdk/java/foreign/TestSegments.java ! test/jdk/java/foreign/TestSharedAccess.java ! test/jdk/java/foreign/TestSlices.java ! test/jdk/java/foreign/TestSpliterator.java ! test/jdk/java/foreign/TestStringEncoding.java ! test/jdk/java/foreign/TestSymbolLookup.java ! test/jdk/java/foreign/TestTypeAccess.java ! test/jdk/java/foreign/TestUnsupportedPlatform.java ! test/jdk/java/foreign/TestUpcall.java ! test/jdk/java/foreign/TestUpcallException.java ! test/jdk/java/foreign/TestUpcallHighArity.java ! test/jdk/java/foreign/TestUpcallStructScope.java ! test/jdk/java/foreign/TestVarArgs.java ! test/jdk/java/foreign/TestVarHandleCombinators.java ! test/jdk/java/foreign/ThrowingUpcall.java ! test/jdk/java/foreign/callarranger/TestAarch64CallArranger.java ! test/jdk/java/foreign/callarranger/TestWindowsCallArranger.java ! test/jdk/java/foreign/channels/AbstractChannelsTest.java ! test/jdk/java/foreign/channels/TestAsyncSocketChannels.java ! test/jdk/java/foreign/channels/TestSocketChannels.java ! test/jdk/java/foreign/enablenativeaccess/org/openjdk/foreigntest/PanamaMainUnnamedModule.java ! test/jdk/java/foreign/enablenativeaccess/panama_module/org/openjdk/foreigntest/PanamaMain.java ! test/jdk/java/foreign/enablenativeaccess/panama_module/org/openjdk/foreigntest/PanamaMainInvoke.java ! test/jdk/java/foreign/enablenativeaccess/panama_module/org/openjdk/foreigntest/PanamaMainReflection.java ! test/jdk/java/foreign/handles/invoker_module/handle/invoker/MethodHandleInvoker.java ! test/jdk/java/foreign/handles/lookup_module/handle/lookup/MethodHandleLookup.java + test/jdk/java/foreign/libAsyncInvokers.cpp ! test/jdk/java/foreign/libIntrinsics.c ! test/jdk/java/foreign/libSafeAccess.c + test/jdk/java/foreign/loaderLookup/TestLoaderLookup.java + test/jdk/java/foreign/loaderLookup/invoker/Invoker.java + test/jdk/java/foreign/loaderLookup/lookup/Lookup.java + test/jdk/java/foreign/loaderLookup/lookup/libFoo.c ! test/jdk/java/foreign/malloc/TestMixedMallocFree.java ! test/jdk/java/foreign/stackwalk/TestAsyncStackWalk.java ! test/jdk/java/foreign/stackwalk/TestStackWalk.java ! test/jdk/java/foreign/valist/VaListTest.java ! test/jdk/java/foreign/virtual/TestVirtualCalls.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestExact.java ! test/jdk/java/util/stream/test/org/openjdk/tests/java/util/stream/SegmentTestDataProvider.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/BulkMismatchAcquire.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/BulkOps.java + test/micro/org/openjdk/bench/jdk/incubator/foreign/CLayouts.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/CallOverheadConstant.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/CallOverheadHelper.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/CallOverheadVirtual.java + test/micro/org/openjdk/bench/jdk/incubator/foreign/JNICB.h + test/micro/org/openjdk/bench/jdk/incubator/foreign/JNICB.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverConstant.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverNew.java + test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverNewHeap.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverNonConstant.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverNonConstantFP.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverNonConstantHeap.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverNonConstantMapped.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverNonConstantShared.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverPollutedBuffer.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverPollutedSegments.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/ParallelSum.java + test/micro/org/openjdk/bench/jdk/incubator/foreign/QSort.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/StrLenTest.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/TestAdaptVarHandles.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/TestLoadBytes.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/UnrolledAccess.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/Upcalls.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/VaList.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/VarHandleExact.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/libCallOverhead.c + test/micro/org/openjdk/bench/jdk/incubator/foreign/libJNICB.c + test/micro/org/openjdk/bench/jdk/incubator/foreign/libQSort.c + test/micro/org/openjdk/bench/jdk/incubator/foreign/libQSortJNI.c ! test/micro/org/openjdk/bench/jdk/incubator/foreign/libUpcallsJNI.c ! test/micro/org/openjdk/bench/jdk/incubator/foreign/points/support/PanamaPoint.java ! test/micro/org/openjdk/bench/jdk/incubator/vector/TestLoadStoreBytes.java ! test/micro/org/openjdk/bench/jdk/incubator/vector/TestLoadStoreShort.java Changeset: cf7adae6 Author: Thomas Stuefe Date: 2021-11-24 12:12:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cf7adae6333c7446048ef0364737927337631f63 8275320: NMT should perform buffer overrun checks 8275320: NMT should perform buffer overrun checks 8275301: Unify C-heap buffer overrun checks into NMT Reviewed-by: simonis, zgu ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/services/mallocSiteTable.cpp ! src/hotspot/share/services/mallocSiteTable.hpp ! src/hotspot/share/services/mallocTracker.cpp ! src/hotspot/share/services/mallocTracker.hpp ! src/hotspot/share/services/memTracker.hpp ! src/hotspot/share/utilities/debug.cpp + test/hotspot/gtest/nmt/test_nmt_buffer_overflow_detection.cpp ! test/hotspot/gtest/testutils.cpp ! test/hotspot/gtest/testutils.hpp ! test/hotspot/gtest/unittest.hpp Changeset: 0384739a Author: Roger Riggs Date: 2021-11-24 15:14:22 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0384739afc2d470ab6a3525e9d85aca0af58f2ed 8276665: ObjectInputStream.GetField.get(name, object) should throw ClassNotFoundException Reviewed-by: naoto, lancea, smarks ! src/java.base/share/classes/java/io/ObjectInputStream.java + test/jdk/java/io/Serializable/GetField/ReadFieldsCNF.java Changeset: 663e33de Author: Christian Stein Committer: Jonathan Gibbons Date: 2021-11-24 16:50:25 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/663e33de13788586fa49bd9816bd148e58ad1031 8272728: javac ignores any -J option in @argfiles silently Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java ! test/langtools/tools/javac/options/modes/AtFilesTest.java Changeset: 951247c8 Author: Adam Sotona Date: 2021-11-24 17:03:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/951247c8cb4ea898bf7c188bed8e143ca7417c83 8235876: Misleading warning message in java source-file mode Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/Main.java ! test/langtools/tools/javac/launcher/SourceLauncherTest.java Changeset: 077b2de0 Author: Andrey Turbanov Committer: Vicente Romero Date: 2021-11-24 18:47:50 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/077b2de088665b907dbfc2b0522a1e109d1d2ca3 8274161: Cleanup redundant casts in jdk.compiler Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/StringConcat.java Changeset: 96fe1d0d Author: Leonid Mesnik Date: 2021-11-24 20:11:18 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/96fe1d0d4d95d87950ff2ecec570a927d831746e 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL" Reviewed-by: sspitsyn, dholmes ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_tools.cpp Changeset: e785f699 Author: Pavel Rappo Date: 2021-11-24 20:13:06 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e785f699614abc8d557be8fc1782a1f86f272430 8276124: Provide snippet support for properties files Co-authored-by: Jonathan Gibbons Co-authored-by: Hannes Walln?fer Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/SnippetTaglet.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Parser.java ! test/langtools/jdk/javadoc/doclet/testSnippetTag/SnippetTester.java + test/langtools/jdk/javadoc/doclet/testSnippetTag/TestLangProperties.java Changeset: b5841ba3 Author: Lance Andersen Date: 2021-11-24 20:42:29 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b5841ba3f3d079f3cfee532a4e7f23b00f5cd063 8277806: 4 tools/jar failures per platform after JDK-8272728 Reviewed-by: alanb, jjg ! test/jdk/tools/jar/modularJar/Basic.java ! test/jdk/tools/jar/multiRelease/MRTestBase.java Changeset: 26472bd3 Author: Daniel D. Daugherty Date: 2021-11-24 22:27:24 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/26472bd3bd8788b0839e2871ed220e438fb6d608 8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java 8277813: ProblemList vmTestbase/nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java Reviewed-by: dholmes ! test/hotspot/jtreg/ProblemList.txt Changeset: a81e4fc0 Author: Jaikiran Pai Date: 2021-11-25 02:12:03 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a81e4fc07b654a3cc954921981d9d3c0cfd8bcec 8258117: jar tool sets the time stamp of module-info.class entries to the current time Reviewed-by: lancea, ihse, alanb ! src/jdk.jartool/share/classes/sun/tools/jar/Main.java + test/jdk/tools/jar/modularJar/JarToolModuleDescriptorReproducibilityTest.java Changeset: 21e302a0 Author: Daniel D. Daugherty Date: 2021-11-25 04:27:21 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/21e302a0f4cbf3ace907c36d871a2f2cf6277188 8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find too_many string in output Reviewed-by: dholmes ! test/hotspot/jtreg/runtime/Monitor/MonitorUsedDeflationThresholdTest.java Changeset: f0136ec9 Author: Fairoz Matte Committer: Christian Hagedorn Date: 2021-11-25 08:37:31 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f0136ec94539d0e30ec11d44f8143196da1f7125 8275687: runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException Reviewed-by: iklam, chagedorn ! test/hotspot/jtreg/runtime/CommandLine/PrintTouchedMethodsJcmd.java Changeset: 3034ae87 Author: Erik ?sterlund Date: 2021-11-25 09:50:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3034ae87ce4b94c7dc40cfb5a96d6d1e87910bbf 8277631: ZGC: CriticalMetaspaceAllocation asserts Reviewed-by: pliden, stefank, dholmes ! src/hotspot/share/memory/metaspaceCriticalAllocation.cpp ! test/hotspot/jtreg/vmTestbase/gc/gctests/LoadUnloadGC/LoadUnloadGC.java Changeset: f7888349 Author: Ivan Walulya Date: 2021-11-25 14:10:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f788834998eeb9083e971857446321ed173aa916 8277786: G1: Rename log2_card_region_per_heap_region used in G1CardSet Reviewed-by: ayang, tschatzl, mli ! src/hotspot/share/gc/g1/g1CardSet.cpp ! src/hotspot/share/gc/g1/g1CardSet.hpp ! src/hotspot/share/gc/g1/heapRegionRemSet.inline.hpp Changeset: 98799204 Author: Albert Mingkun Yang Date: 2021-11-25 14:54:48 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/987992042454f92936d3efbd01e7beb921e3b70e 8277825: Remove unused ReferenceProcessorPhaseTimes::_sub_phases_total_time_ms Reviewed-by: tschatzl ! src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.cpp ! src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.hpp Changeset: 23628049 Author: Fei Yang Date: 2021-11-25 20:57:27 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/236280495646c81653d9c1f944b4774f1dc8b7a1 Merge branch 'master' into riscv-port ! .jcheck/conf ! .jcheck/conf From duke at openjdk.java.net Sat Nov 27 01:03:40 2021 From: duke at openjdk.java.net (duke) Date: Sat, 27 Nov 2021 01:03:40 GMT Subject: git: openjdk/riscv-port: riscv-port: 13 new changesets Message-ID: Changeset: eb4d886b Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-11-26 01:45:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/eb4d886bc0f57085b21ef41f2069ff60b2714cfa 8277504: Use String.stripTrailing instead of hand-crafted method in SwingUtilities2 Reviewed-by: pbansal, serb ! src/java.desktop/share/classes/sun/swing/SwingUtilities2.java Changeset: 7e54d065 Author: Mandy Chung Date: 2021-11-26 01:55:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7e54d065a17f1277adf1b8561fadb8a480bc6bed 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories 8277166: Data race in jdeps VersionHelper 8277123: jdeps does not report some exceptions correctly Reviewed-by: jvernee, alanb ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ClassFileReader.java ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/DependencyFinder.java ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/MultiReleaseException.java ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/VersionHelper.java + test/langtools/tools/jdeps/multiVersion/MultiVersionError.java + test/langtools/tools/jdeps/multiVersion/src/m1/module-info.java + test/langtools/tools/jdeps/multiVersion/src/m1/p/Test.java + test/langtools/tools/jdeps/multiVersion/src/m1/p/internal/P.java + test/langtools/tools/jdeps/multiVersion/src/m2/module-info.java + test/langtools/tools/jdeps/multiVersion/src/m2/p/internal/P.java + test/langtools/tools/jdeps/multiVersion/src/m2/q/Q.java Changeset: 3383c0dc Author: Stuart Monteith Committer: Nick Gasson Date: 2021-11-26 09:02:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3383c0dcc016715dcb350b6ba196a7cdc833cdc6 8277659: [TESTBUG] Microbenchmark ThreadOnSpinWaitProducerConsumer.java hangs Reviewed-by: njian, ngasson ! test/micro/org/openjdk/bench/java/lang/ThreadOnSpinWaitProducerConsumer.java Changeset: 00a6238d Author: Yadong Wang Committer: Fei Yang Date: 2021-11-26 09:09:02 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/00a6238daed4a4aaa6001275ce620646cdabfeb5 8277508: need to check has_predicated_vectors before calling scalable_predicate_reg_slots Reviewed-by: njian, thartmann, ngasson ! src/hotspot/share/opto/matcher.cpp Changeset: 99e4bda3 Author: Roman Kennke Date: 2021-11-26 09:46:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/99e4bda303f2c71972a125d0ecaf4cf986c8614a 8277417: C1 LIR instruction for load-klass Reviewed-by: iveresov, mdoerr, ngasson, aph ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp ! src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp ! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp ! src/hotspot/share/c1/c1_LIR.cpp ! src/hotspot/share/c1/c1_LIR.hpp ! src/hotspot/share/c1/c1_LIRAssembler.hpp ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_LIRGenerator.hpp ! src/hotspot/share/gc/shared/c1/barrierSetC1.cpp Changeset: 3e798dd4 Author: Roland Westrelin Date: 2021-11-26 09:48:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3e798dd40c68439f3220445e679b9e0e495435d8 8275330: C2: assert(n->is_Root() || n->is_Region() || n->is_Phi() || n->is_MachMerge() || def_block->dominates(block)) failed: uses must be dominated by definitions Reviewed-by: thartmann, chagedorn ! src/hotspot/share/opto/loopPredicate.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/macro.cpp ! src/hotspot/share/opto/opaquenode.cpp ! src/hotspot/share/opto/opaquenode.hpp + test/hotspot/jtreg/compiler/loopopts/TestDeadPostLoopBecausePredicate.java Changeset: 040b2c52 Author: Ludvig Janiuk Committer: Nils Eliasson Date: 2021-11-26 09:52:10 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/040b2c52d3e82048630fbd45a7db48a5e65204b7 8277139: Improve code readability in PredecessorValidator (c1_IR.cpp) Reviewed-by: thartmann, chagedorn ! src/hotspot/share/c1/c1_IR.cpp Changeset: ce0234b4 Author: Roman Kennke Date: 2021-11-26 14:54:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ce0234b47d5c40e74dac368396e92cdec5cc2de7 8277860: PPC: Remove duplicate info != NULL check Reviewed-by: chagedorn, mdoerr ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp Changeset: 3d810ad6 Author: Erik ?sterlund Date: 2021-11-26 14:55:02 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3d810ad6912b7bca03e212b604cf60412da11c18 8277411: C2 fast_unlock intrinsic on AArch64 has unnecessary ownership check Reviewed-by: ngasson, neliasso ! src/hotspot/cpu/aarch64/aarch64.ad Changeset: 40fef231 Author: Volker Simonis Date: 2021-11-26 16:21:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/40fef2311c95eca0ec34652f9fc0e56b827b8380 8275908: Record null_check traps for calls and array_check traps in the interpreter Reviewed-by: chagedorn, mdoerr ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/deoptimization.hpp + test/hotspot/jtreg/compiler/exceptions/OptimizeImplicitExceptions.java + test/hotspot/jtreg/compiler/uncommontrap/Decompile.java ! test/lib/jdk/test/whitebox/WhiteBox.java ! test/lib/sun/hotspot/WhiteBox.java Changeset: b9eb532d Author: Erik Gahlin Date: 2021-11-26 19:13:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b9eb532de20be7c2c18a654a23dcc8dd66654049 8276685: Malformed Javadoc inline tags in JDK source in /jdk/management/jfr/RecordingInfo.java Reviewed-by: mgronlun ! src/jdk.management.jfr/share/classes/jdk/management/jfr/RecordingInfo.java Changeset: e9b36a83 Author: Hamlin Li Date: 2021-11-27 00:46:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e9b36a83160d3c1fa79841692e9fadf336bf7954 8276670: G1: Rename G1CardSetFreePool and related classes Reviewed-by: tschatzl, ayang - src/hotspot/share/gc/g1/g1CardSetFreeMemoryTask.cpp - src/hotspot/share/gc/g1/g1CardSetFreeMemoryTask.hpp ! src/hotspot/share/gc/g1/g1CardSetMemory.cpp ! src/hotspot/share/gc/g1/g1CardSetMemory.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp + src/hotspot/share/gc/g1/g1SegmentedArrayFreeMemoryTask.cpp + src/hotspot/share/gc/g1/g1SegmentedArrayFreeMemoryTask.hpp ! src/hotspot/share/gc/g1/g1SegmentedArrayFreePool.cpp ! src/hotspot/share/gc/g1/g1SegmentedArrayFreePool.hpp ! src/hotspot/share/gc/g1/g1YoungCollector.cpp ! src/hotspot/share/gc/g1/g1YoungCollector.hpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp ! src/hotspot/share/gc/g1/heapRegion.hpp ! src/hotspot/share/gc/g1/heapRegionRemSet.cpp ! src/hotspot/share/gc/g1/heapRegionRemSet.hpp ! test/hotspot/gtest/gc/g1/test_g1CardSet.cpp Changeset: a2ab8988 Author: Fei Yang Date: 2021-11-26 20:00:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a2ab8988a0ed4e13b834f3c841cf74d834acc048 Merge branch 'master' into riscv-port ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp ! src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp ! src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp ! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp ! src/hotspot/share/c1/c1_LIR.cpp ! src/hotspot/share/c1/c1_LIR.hpp ! src/hotspot/share/c1/c1_LIRAssembler.hpp ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp + src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp ! src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp ! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp ! src/hotspot/share/c1/c1_LIR.cpp ! src/hotspot/share/c1/c1_LIR.hpp ! src/hotspot/share/c1/c1_LIRAssembler.hpp From yadongwang at openjdk.java.net Sat Nov 27 03:32:52 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Sat, 27 Nov 2021 03:32:52 GMT Subject: [riscv-port] RFR: 8277877: C2 fast_unlock intrinsic on riscv has unnecessary ownership check Message-ID: It's an optional, maybe only for debug, to check the owner of the lock in the fast_unlock intrinsic in riscv, which already applied in AArch64. ------------- Commit messages: - 8277877: C2 fast_unlock intrinsic on riscv has unnecessary ownership check Changes: https://git.openjdk.java.net/riscv-port/pull/14/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=14&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277877 Stats: 5 lines in 1 file changed: 1 ins; 4 del; 0 mod Patch: https://git.openjdk.java.net/riscv-port/pull/14.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/14/head:pull/14 PR: https://git.openjdk.java.net/riscv-port/pull/14 From fyang at openjdk.java.net Sat Nov 27 06:20:19 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Sat, 27 Nov 2021 06:20:19 GMT Subject: [riscv-port] RFR: 8277877: C2 fast_unlock intrinsic on riscv has unnecessary ownership check In-Reply-To: References: Message-ID: On Sat, 27 Nov 2021 03:27:00 GMT, Yadong Wang wrote: > It's an optional, maybe only for debug, to check the owner of the lock in the fast_unlock intrinsic in riscv, which already applied in AArch64. Looks good. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/14 From yadongwang at openjdk.java.net Mon Nov 29 01:17:26 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Mon, 29 Nov 2021 01:17:26 GMT Subject: [riscv-port] Integrated: 8277877: C2 fast_unlock intrinsic on riscv has unnecessary ownership check In-Reply-To: References: Message-ID: <2j-KzzaTPy0JkerCrUaetRTdbqaN9LeSxryy6Hgg_Qo=.8d73b040-3343-493d-990d-af9601fa5999@github.com> On Sat, 27 Nov 2021 03:27:00 GMT, Yadong Wang wrote: > It's an optional, maybe only for debug, to check the owner of the lock in the fast_unlock intrinsic in riscv, which already applied in AArch64. This pull request has now been integrated. Changeset: 9fef2cab Author: Yadong Wang Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/9fef2cab2e64de910e5da14093b602e2c5f52e93 Stats: 5 lines in 1 file changed: 1 ins; 4 del; 0 mod 8277877: C2 fast_unlock intrinsic on riscv has unnecessary ownership check Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/14 From duke at openjdk.java.net Mon Nov 29 03:49:30 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 29 Nov 2021 03:49:30 GMT Subject: [riscv-port] RFR: 8277884: riscv: Fix cmpxchg_narrow_value that needs to sign-extend non-bool results Message-ID: Hi team, According to https://bugs.openjdk.java.net/browse/JDK-8277884 and [the original patch](https://github.com/riscv-collab/riscv-openjdk/pull/15): A very simple program inherited from jcstress could reproduce this: import java.lang.invoke.MethodHandles; import java.lang.invoke.VarHandle; // run with: // build/linux-riscv64-server-release/images/jdk/bin/java -ea -XX:-TieredCompilation -XX:CompileCommand=compileonly,jdk.internal.misc.Unsafe::compareAndSetByte TestCASByte // assert will fail. // if we add '-XX:+UnlockDiagnosticVMOptions -XX:DisableIntrinsic=_compareAndExchangeByte' this test will pass. public class TestCASByte { byte[] array = new byte[1]; static final VarHandle vh; static { try { vh = MethodHandles.arrayElementVarHandle(byte[].class); } catch (Exception e) { throw new RuntimeException(e); } } public void test() { for (int i = 0; i < 100_000; i++) { // To level 4 // clear array[0] = 0; byte res1 = (byte)vh.getAndSet(array, 0, (byte)-1); byte res2 = (byte)vh.getAndSet(array, 0, (byte)2); assert res1 == 0 && res2 == -1; } } public static void main(String[] args) { new TestCASByte().test(); } } In this case when we are getting the -1 value saved in memory, the shift is 0, the old is 0x00000000000000ff and the mask is 0x00000000000000ff at the end of cmpxchg_narrow_value. The final result is 0x00000000000000ff but it indeed should be 0xffffffffffffffff. BTW the shift is 0. Therefore, if the result is negative, we need to make a sign extension. Thanks, Xiaolin ------------- Commit messages: - Fix cmpxchg_narrow_value that needs to sign-extend non-bool results Changes: https://git.openjdk.java.net/riscv-port/pull/15/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=15&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277884 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/riscv-port/pull/15.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/15/head:pull/15 PR: https://git.openjdk.java.net/riscv-port/pull/15 From duke at openjdk.java.net Mon Nov 29 03:51:47 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 29 Nov 2021 03:51:47 GMT Subject: [riscv-port] RFR: 8277883: riscv: Fix a temp register usage in eden_allocate Message-ID: Hi team, A trivial fix for a small C1 crash - this issue could be directly reproduced by using `java -XX:+UseSerialGC -XX:-UseTLAB -XX:TieredStopAtLevel=1`. The reason is simple: the eden_allocate uses t2 as a register and zaps it, whereas C1 will use it as a register allocation candidate, leading to a crash. In this function, t0 never gets a use so we can use it safely. Tested in all cases. [The original patch](https://github.com/riscv-collab/riscv-openjdk/pull/15) Thanks, Xiaolin ------------- Commit messages: - Fix a temp register usage in eden_allocate Changes: https://git.openjdk.java.net/riscv-port/pull/16/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=16&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277883 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/riscv-port/pull/16.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/16/head:pull/16 PR: https://git.openjdk.java.net/riscv-port/pull/16 From fyang at openjdk.java.net Mon Nov 29 05:09:27 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 29 Nov 2021 05:09:27 GMT Subject: [riscv-port] RFR: 8277884: riscv: Fix cmpxchg_narrow_value that needs to sign-extend non-bool results In-Reply-To: References: Message-ID: On Mon, 29 Nov 2021 03:40:43 GMT, zhengxiaolinX wrote: > Hi team, > > According to https://bugs.openjdk.java.net/browse/JDK-8277884 and [the original patch](https://github.com/riscv-collab/riscv-openjdk/pull/9): > > A very simple program inherited from jcstress could reproduce this: > > > import java.lang.invoke.MethodHandles; > import java.lang.invoke.VarHandle; > > // run with: > // build/linux-riscv64-server-release/images/jdk/bin/java -ea -XX:-TieredCompilation -XX:CompileCommand=compileonly,jdk.internal.misc.Unsafe::compareAndSetByte TestCASByte > // assert will fail. > // if we add '-XX:+UnlockDiagnosticVMOptions -XX:DisableIntrinsic=_compareAndExchangeByte' this test will pass. > > public class TestCASByte { > > byte[] array = new byte[1]; > > static final VarHandle vh; > static { > try { > vh = MethodHandles.arrayElementVarHandle(byte[].class); > } catch (Exception e) { > throw new RuntimeException(e); > } > } > > public void test() { > for (int i = 0; i < 100_000; i++) { // To level 4 > // clear > array[0] = 0; > > byte res1 = (byte)vh.getAndSet(array, 0, (byte)-1); > byte res2 = (byte)vh.getAndSet(array, 0, (byte)2); > > assert res1 == 0 && res2 == -1; > } > } > > public static void main(String[] args) { > new TestCASByte().test(); > } > > } > > > In this case when we are getting the `-1` value saved in memory, the shift is `0`, the old is `0x00000000000000ff` and the mask is `0x00000000000000ff` at the end of cmpxchg_narrow_value. The final result is `0x00000000000000ff` but it indeed should be `0xffffffffffffffff`. Therefore, if the result is negative, we need to make a sign extension. > > Thanks, > Xiaolin Looks good. I can also reproduce the bug with following three jcstress tests: org.openjdk.jcstress.tests.atomicity.varHandles.fields.GetAndSetTest.GetAndSetByte org.openjdk.jcstress.tests.atomicity.varHandles.fields.GetAndSetTest.GetAndSetShort org.openjdk.jcstress.tests.atomicity.varHandles.arrays.GetAndSetTest.GetAndSetByte ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/15 From duke at openjdk.java.net Mon Nov 29 06:40:23 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 29 Nov 2021 06:40:23 GMT Subject: [riscv-port] RFR: 8277884: riscv: Fix cmpxchg_narrow_value that needs to sign-extend non-bool results In-Reply-To: References: Message-ID: On Mon, 29 Nov 2021 05:06:34 GMT, Fei Yang wrote: > Looks good. I can also reproduce the bug with following three jcstress tests: org.openjdk.jcstress.tests.atomicity.varHandles.fields.GetAndSetTest.GetAndSetByte org.openjdk.jcstress.tests.atomicity.varHandles.fields.GetAndSetTest.GetAndSetShort org.openjdk.jcstress.tests.atomicity.varHandles.arrays.GetAndSetTest.GetAndSetByte Quite thanks for the supplementary information about the failed tests. A simple `test/hotspot/jtreg/compiler` on Qemu seems no error found. And these three jcstress tests seem no `FORBIDDEN` occurrences after this patch. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/15 From duke at openjdk.java.net Mon Nov 29 06:47:27 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 29 Nov 2021 06:47:27 GMT Subject: [riscv-port] Integrated: 8277884: riscv: Fix cmpxchg_narrow_value that needs to sign-extend non-bool results In-Reply-To: References: Message-ID: On Mon, 29 Nov 2021 03:40:43 GMT, zhengxiaolinX wrote: > Hi team, > > According to https://bugs.openjdk.java.net/browse/JDK-8277884 and [the original patch](https://github.com/riscv-collab/riscv-openjdk/pull/9): > > A very simple program inherited from jcstress could reproduce this: > > > import java.lang.invoke.MethodHandles; > import java.lang.invoke.VarHandle; > > // run with: > // build/linux-riscv64-server-release/images/jdk/bin/java -ea -XX:-TieredCompilation -XX:CompileCommand=compileonly,jdk.internal.misc.Unsafe::compareAndSetByte TestCASByte > // assert will fail. > // if we add '-XX:+UnlockDiagnosticVMOptions -XX:DisableIntrinsic=_compareAndExchangeByte' this test will pass. > > public class TestCASByte { > > byte[] array = new byte[1]; > > static final VarHandle vh; > static { > try { > vh = MethodHandles.arrayElementVarHandle(byte[].class); > } catch (Exception e) { > throw new RuntimeException(e); > } > } > > public void test() { > for (int i = 0; i < 100_000; i++) { // To level 4 > // clear > array[0] = 0; > > byte res1 = (byte)vh.getAndSet(array, 0, (byte)-1); > byte res2 = (byte)vh.getAndSet(array, 0, (byte)2); > > assert res1 == 0 && res2 == -1; > } > } > > public static void main(String[] args) { > new TestCASByte().test(); > } > > } > > > In this case when we are getting the `-1` value saved in memory, the shift is `0`, the old is `0x00000000000000ff` and the mask is `0x00000000000000ff` at the end of cmpxchg_narrow_value. The final result is `0x00000000000000ff` but it indeed should be `0xffffffffffffffff`. Therefore, if the result is negative, we need to make a sign extension. > > Thanks, > Xiaolin This pull request has now been integrated. Changeset: 5c1cbe08 Author: yunyao.zxl Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/5c1cbe08946a940e46b91183ea7d21638f245e1f Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod 8277884: riscv: Fix cmpxchg_narrow_value that needs to sign-extend non-bool results Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/15 From fyang at openjdk.java.net Mon Nov 29 07:50:31 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 29 Nov 2021 07:50:31 GMT Subject: [riscv-port] RFR: 8277883: riscv: Fix a temp register usage in eden_allocate In-Reply-To: References: Message-ID: On Mon, 29 Nov 2021 03:43:32 GMT, zhengxiaolinX wrote: > Hi team, > > A trivial fix for a small C1 crash - this issue could be directly reproduced by using `java -XX:+UseSerialGC -XX:-UseTLAB -XX:TieredStopAtLevel=1`. The reason is simple: the eden_allocate uses t2 as a register and zaps it, whereas C1 will use it as a register allocation candidate, leading to a crash. In this function, t0 never gets a use so we can use it safely. Tested in all cases. [The original patch](https://github.com/riscv-collab/riscv-openjdk/pull/15) > > Thanks, > Xiaolin Changes requested by fyang (Lead). src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp line 182: > 180: __ bind(retry); > 181: > 182: Register tmp = t0; No need to introduce local variable "tmp" here. I think we can use t0 directly here. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/16 From duke at openjdk.java.net Mon Nov 29 08:13:59 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 29 Nov 2021 08:13:59 GMT Subject: [riscv-port] RFR: 8277883: riscv: Fix a temp register usage in eden_allocate [v2] In-Reply-To: References: Message-ID: > Hi team, > > A trivial fix for a small C1 crash - this issue could be directly reproduced by using `java -XX:+UseSerialGC -XX:-UseTLAB -XX:TieredStopAtLevel=1`. The reason is simple: the eden_allocate uses t2 as a register and zaps it, whereas C1 will use it as a register allocation candidate, leading to a crash. In this function, t0 never gets a use so we can use it safely. Tested in all cases. [The original patch](https://github.com/riscv-collab/riscv-openjdk/pull/15) > > Thanks, > Xiaolin zhengxiaolinX has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Fix a temp register usage in eden_allocate ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/16/files - new: https://git.openjdk.java.net/riscv-port/pull/16/files/b37dd6d3..ed811e74 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=16&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=16&range=00-01 Stats: 6 lines in 1 file changed: 0 ins; 2 del; 4 mod Patch: https://git.openjdk.java.net/riscv-port/pull/16.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/16/head:pull/16 PR: https://git.openjdk.java.net/riscv-port/pull/16 From fyang at openjdk.java.net Mon Nov 29 08:13:59 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 29 Nov 2021 08:13:59 GMT Subject: [riscv-port] RFR: 8277883: riscv: Fix a temp register usage in eden_allocate [v2] In-Reply-To: References: Message-ID: <_te7U2weFWnKMcILnbwhWg7CZ9HcYQTfVOqLcFKIWUY=.cac05da2-a8d8-4531-991c-0218239bb9a8@github.com> On Mon, 29 Nov 2021 08:05:03 GMT, zhengxiaolinX wrote: >> Hi team, >> >> A trivial fix for a small C1 crash - this issue could be directly reproduced by using `java -XX:+UseSerialGC -XX:-UseTLAB -XX:TieredStopAtLevel=1`. The reason is simple: the eden_allocate uses t2 as a register and zaps it, whereas C1 will use it as a register allocation candidate, leading to a crash. In this function, t0 never gets a use so we can use it safely. Tested in all cases. [The original patch](https://github.com/riscv-collab/riscv-openjdk/pull/15) >> >> Thanks, >> Xiaolin > > zhengxiaolinX has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Fix a temp register usage in eden_allocate Looks good. It's definitely inappropriate to use an allocatable general-purpose register here. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/16 From duke at openjdk.java.net Mon Nov 29 08:14:00 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 29 Nov 2021 08:14:00 GMT Subject: [riscv-port] RFR: 8277883: riscv: Fix a temp register usage in eden_allocate [v2] In-Reply-To: References: Message-ID: On Mon, 29 Nov 2021 07:46:53 GMT, Fei Yang wrote: >> zhengxiaolinX has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: >> >> Fix a temp register usage in eden_allocate > > src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp line 182: > >> 180: __ bind(retry); >> 181: >> 182: Register tmp = t0; > > No need to introduce local variable "tmp" here. I think we can use t0 directly here. This is a reasonable point -- changed as proposal, passed fastdebug build, and tested a simple `java -XX:+UseSerialGC -XX:-UseTLAB -XX:TieredStopAtLevel=1`. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/16 From duke at openjdk.java.net Mon Nov 29 08:14:01 2021 From: duke at openjdk.java.net (zhengxiaolinX) Date: Mon, 29 Nov 2021 08:14:01 GMT Subject: [riscv-port] Integrated: 8277883: riscv: Fix a temp register usage in eden_allocate In-Reply-To: References: Message-ID: <5D8brlsF2QHO_wp-IN5Lv-9U37GcxtJ1Lpddn9vB-Uw=.3abc0f0a-fc54-4fda-bd20-7997e1ff88e6@github.com> On Mon, 29 Nov 2021 03:43:32 GMT, zhengxiaolinX wrote: > Hi team, > > A trivial fix for a small C1 crash - this issue could be directly reproduced by using `java -XX:+UseSerialGC -XX:-UseTLAB -XX:TieredStopAtLevel=1`. The reason is simple: the eden_allocate uses t2 as a register and zaps it, whereas C1 will use it as a register allocation candidate, leading to a crash. In this function, t0 never gets a use so we can use it safely. Tested in all cases. [The original patch](https://github.com/riscv-collab/riscv-openjdk/pull/15) > > Thanks, > Xiaolin This pull request has now been integrated. Changeset: 1101c14f Author: yunyao.zxl Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/1101c14fd5c4b5ea89e6f3868bf9917d772445fa Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8277883: riscv: Fix a temp register usage in eden_allocate Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/16 From yadongwang at openjdk.java.net Mon Nov 29 15:11:43 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Mon, 29 Nov 2021 15:11:43 GMT Subject: [riscv-port] RFR: 8277890: riscv: fix the infinite LR/SC loop in BarrierSetAssembler::eden_allocate Message-ID: This bug can be reproduced by `java -XX:+UseSerialGC -XX:-UseTLAB -XX:TieredStopAtLevel=1 -version` on the unmatched board where this command will hang. The reason is that the implementation of load reserved/store conditional loop in BarrierSetAssembler::eden_allocate breaks the RISC-V Atomic extension spec: For the sequence to be guaranteed to eventually succeed, the dynamic code executed between the LR and SC instructions can only contain other instructions from the base \I" subset, excluding loads, stores, backward jumps or taken backward branches, FENCE, FENCE.I, and SYSTEM instructions. It may cause an unspecified behaviour depends on specific hardware implementations. ------------- Commit messages: - 8277890: riscv: fix the infinite LR/SC loop in BarrierSetAssembler::eden_allocate Changes: https://git.openjdk.java.net/riscv-port/pull/17/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=17&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277890 Stats: 24 lines in 1 file changed: 12 ins; 8 del; 4 mod Patch: https://git.openjdk.java.net/riscv-port/pull/17.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/17/head:pull/17 PR: https://git.openjdk.java.net/riscv-port/pull/17 From fyang at openjdk.java.net Tue Nov 30 01:07:34 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 30 Nov 2021 01:07:34 GMT Subject: [riscv-port] RFR: 8277890: riscv: fix the infinite LR/SC loop in BarrierSetAssembler::eden_allocate In-Reply-To: References: Message-ID: On Mon, 29 Nov 2021 15:06:51 GMT, Yadong Wang wrote: > This bug can be reproduced by `java -XX:+UseSerialGC -XX:-UseTLAB -XX:TieredStopAtLevel=1 -version` on the unmatched board where this command will hang. The reason is that the implementation of load reserved/store conditional loop in BarrierSetAssembler::eden_allocate breaks the RISC-V Atomic extension spec: > > For the > sequence to be guaranteed to eventually succeed, the dynamic code executed between the LR and > SC instructions can only contain other instructions from the base \I" subset, excluding loads, stores, > backward jumps or taken backward branches, FENCE, FENCE.I, and SYSTEM instructions. > > It may cause an unspecified behaviour depends on specific hardware implementations. Looks good. Thanks for fixing this :-) ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/17 From yadongwang at openjdk.java.net Tue Nov 30 03:33:34 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Tue, 30 Nov 2021 03:33:34 GMT Subject: [riscv-port] Integrated: 8277890: riscv: fix the infinite LR/SC loop in BarrierSetAssembler::eden_allocate In-Reply-To: References: Message-ID: On Mon, 29 Nov 2021 15:06:51 GMT, Yadong Wang wrote: > This bug can be reproduced by `java -XX:+UseSerialGC -XX:-UseTLAB -XX:TieredStopAtLevel=1 -version` on the unmatched board where this command will hang. The reason is that the implementation of load reserved/store conditional loop in BarrierSetAssembler::eden_allocate breaks the RISC-V Atomic extension spec: > > For the > sequence to be guaranteed to eventually succeed, the dynamic code executed between the LR and > SC instructions can only contain other instructions from the base \I" subset, excluding loads, stores, > backward jumps or taken backward branches, FENCE, FENCE.I, and SYSTEM instructions. > > It may cause an unspecified behaviour depends on specific hardware implementations. This pull request has now been integrated. Changeset: 5bb7f8bb Author: Yadong Wang Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/5bb7f8bb4feeed2b090ebd8038a06f5bfd7dec98 Stats: 24 lines in 1 file changed: 12 ins; 8 del; 4 mod 8277890: riscv: fix the infinite LR/SC loop in BarrierSetAssembler::eden_allocate Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/17 From duke at openjdk.java.net Tue Nov 30 07:27:33 2021 From: duke at openjdk.java.net (kuaiwei) Date: Tue, 30 Nov 2021 07:27:33 GMT Subject: [riscv-port] RFR: 8277968: riscv: detect vector extension with vcsr Message-ID: UseRVV could cause crash on D1 board(RISCV-C906). It seems that though the D1 board is equipped with RVV-0.7.1[1] . In our test, VLENB CSR can return value of 16 on D1 board. So JDK will assume it can support RVV extension and crash in vector instructions when UseRVV is enabled. RVV-0.9 and above[2] introduce a new VCSR CSR register, it will raise SIGILL on D1 board. So we can check it to detect vext support. [1] https://github.com/riscv/riscv-v-spec/blob/0a24d0f61b5cd3f1f9265e8c40ab211daa865ede/v-spec.adoc#vector-extension-programmers-model [2] https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#vector-extension-programmers-model ------------- Commit messages: - 8277968: riscv: detect vector extension with vcsr Changes: https://git.openjdk.java.net/riscv-port/pull/18/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=18&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277968 Stats: 88 lines in 4 files changed: 81 ins; 6 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/18.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/18/head:pull/18 PR: https://git.openjdk.java.net/riscv-port/pull/18 From duke at openjdk.java.net Tue Nov 30 08:04:52 2021 From: duke at openjdk.java.net (kuaiwei) Date: Tue, 30 Nov 2021 08:04:52 GMT Subject: [riscv-port] RFR: 8277968: riscv: Detect vector extension with vcsr [v2] In-Reply-To: References: Message-ID: <-NT5UlFnkXOx4doj-ZlI5cQvVb1aFIkIOVs9H2dFp1E=.2aeb817f-9ba3-4b16-88e8-44ae7d89e214@github.com> > UseRVV could cause crash on D1 board(RISCV-C906). > > It seems that though the D1 board is equipped with RVV-0.7.1[1] . In our test, VLENB CSR can return value of 16 on D1 board. So JDK will assume it can support RVV extension and crash in vector instructions when UseRVV is enabled. > > RVV-0.9 and above[2] introduce a new VCSR CSR register, it will raise SIGILL on D1 board. So we can check it to detect vext support. > > > [1] https://github.com/riscv/riscv-v-spec/blob/0a24d0f61b5cd3f1f9265e8c40ab211daa865ede/v-spec.adoc#vector-extension-programmers-model > [2] https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#vector-extension-programmers-model kuaiwei has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8277968: riscv: Detect vector extension with vcsr ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/18/files - new: https://git.openjdk.java.net/riscv-port/pull/18/files/380bb30b..fecbfefd Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=18&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=18&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/riscv-port/pull/18.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/18/head:pull/18 PR: https://git.openjdk.java.net/riscv-port/pull/18 From fyang at openjdk.java.net Tue Nov 30 10:54:29 2021 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 30 Nov 2021 10:54:29 GMT Subject: [riscv-port] RFR: 8277968: riscv: Detect vector extension with vcsr [v2] In-Reply-To: <-NT5UlFnkXOx4doj-ZlI5cQvVb1aFIkIOVs9H2dFp1E=.2aeb817f-9ba3-4b16-88e8-44ae7d89e214@github.com> References: <-NT5UlFnkXOx4doj-ZlI5cQvVb1aFIkIOVs9H2dFp1E=.2aeb817f-9ba3-4b16-88e8-44ae7d89e214@github.com> Message-ID: On Tue, 30 Nov 2021 08:04:52 GMT, kuaiwei wrote: >> UseRVV could cause crash on D1 board(RISCV-C906). >> >> It seems that though the D1 board is equipped with RVV-0.7.1[1] . In our test, VLENB CSR can return value of 16 on D1 board. So JDK will assume it can support RVV extension and crash in vector instructions when UseRVV is enabled. >> >> RVV-0.9 and above[2] introduce a new VCSR CSR register, it will raise SIGILL on D1 board. So we can check it to detect vext support. >> >> >> [1] https://github.com/riscv/riscv-v-spec/blob/0a24d0f61b5cd3f1f9265e8c40ab211daa865ede/v-spec.adoc#vector-extension-programmers-model >> [2] https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#vector-extension-programmers-model > > kuaiwei has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. This might unnecessarily complicated the issue tbh. If you want to distinguish the specific cpu/core vendor, I would suggest we do in some different way. One possible way would be through checking /proc/cpuinfo for this infomation like aarch64 port [1]. I see boards like hifive unleashed and unmatched also provide necessary microarchitecure version through /proc/cpuinfo [2]. I think this kind of infomation should be made available in the system. [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp#L146 [2] https://t2sde.org/hardware/board/SiFive/Unmatched ------------- PR: https://git.openjdk.java.net/riscv-port/pull/18 From duke at openjdk.java.net Tue Nov 30 11:30:23 2021 From: duke at openjdk.java.net (kuaiwei) Date: Tue, 30 Nov 2021 11:30:23 GMT Subject: [riscv-port] RFR: 8277968: riscv: Detect vector extension with vcsr [v2] In-Reply-To: <-NT5UlFnkXOx4doj-ZlI5cQvVb1aFIkIOVs9H2dFp1E=.2aeb817f-9ba3-4b16-88e8-44ae7d89e214@github.com> References: <-NT5UlFnkXOx4doj-ZlI5cQvVb1aFIkIOVs9H2dFp1E=.2aeb817f-9ba3-4b16-88e8-44ae7d89e214@github.com> Message-ID: On Tue, 30 Nov 2021 08:04:52 GMT, kuaiwei wrote: >> UseRVV could cause crash on D1 board(RISCV-C906). >> >> It seems that though the D1 board is equipped with RVV-0.7.1[1] . In our test, VLENB CSR can return value of 16 on D1 board. So JDK will assume it can support RVV extension and crash in vector instructions when UseRVV is enabled. >> >> RVV-0.9 and above[2] introduce a new VCSR CSR register, it will raise SIGILL on D1 board. So we can check it to detect vext support. >> >> >> [1] https://github.com/riscv/riscv-v-spec/blob/0a24d0f61b5cd3f1f9265e8c40ab211daa865ede/v-spec.adoc#vector-extension-programmers-model >> [2] https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#vector-extension-programmers-model > > kuaiwei has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. > Thanks for your comment. My first thinking is to check /proc/cpuinfo . But it doesn't provide cpu model information. Below is /proc/cpuinfo from Fedora31 on D1: [riscv at fedora-riscv ~]$ cat /proc/cpuinfo processor : 0 hart : 0 isa : rv64imafdcvu mmu : sv39 ------------- PR: https://git.openjdk.java.net/riscv-port/pull/18 From yadongwang at openjdk.java.net Tue Nov 30 13:29:29 2021 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Tue, 30 Nov 2021 13:29:29 GMT Subject: [riscv-port] RFR: 8277968: riscv: Detect vector extension with vcsr [v2] In-Reply-To: <-NT5UlFnkXOx4doj-ZlI5cQvVb1aFIkIOVs9H2dFp1E=.2aeb817f-9ba3-4b16-88e8-44ae7d89e214@github.com> References: <-NT5UlFnkXOx4doj-ZlI5cQvVb1aFIkIOVs9H2dFp1E=.2aeb817f-9ba3-4b16-88e8-44ae7d89e214@github.com> Message-ID: On Tue, 30 Nov 2021 08:04:52 GMT, kuaiwei wrote: >> UseRVV could cause crash on D1 board(RISCV-C906). >> >> It seems that though the D1 board is equipped with RVV-0.7.1[1] . In our test, VLENB CSR can return value of 16 on D1 board. So JDK will assume it can support RVV extension and crash in vector instructions when UseRVV is enabled. >> >> RVV-0.9 and above[2] introduce a new VCSR CSR register, it will raise SIGILL on D1 board. So we can check it to detect vext support. >> >> >> [1] https://github.com/riscv/riscv-v-spec/blob/0a24d0f61b5cd3f1f9265e8c40ab211daa865ede/v-spec.adoc#vector-extension-programmers-model >> [2] https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#vector-extension-programmers-model > > kuaiwei has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. > > > > Thanks for your comment. My first thinking is to check /proc/cpuinfo . But it doesn't provide cpu model information. Below is /proc/cpuinfo from Fedora31 on D1: > > ```shell > [riscv at fedora-riscv ~]$ cat /proc/cpuinfo > processor : 0 > hart : 0 > isa : rv64imafdcvu > mmu : sv39 > ``` Is it a OS porting problem? See `cat /proc/cpuinfo` from Ubuntu 21.04 on unmatched: processor : 0 hart : 2 isa : rv64imafdc mmu : sv39 uarch : sifive,u74-mc ------------- PR: https://git.openjdk.java.net/riscv-port/pull/18