[riscv-port] RFR: 8281731: riscv: Refactor instruction extraction code in nativeInst_riscv.h/cpp [v2]
xlinzheng at openjdk.java.net
Wed Feb 16 04:42:14 UTC 2022
On Wed, 16 Feb 2022 03:05:42 GMT, Yadong Wang <yadongwang at openjdk.org> wrote:
>> In fact - I have the same thought though after revising the code. Seems sadly I cannot find a way to extract them only once and in the meantime keep the readability without introducing new local variables. I don't know - maybe turning back to [my original version](https://github.com/openjdk/riscv-port/blob/92273c63986eef7126194f32c28a915fb0abf11c/src/hotspot/cpu/riscv/nativeInst_riscv.hpp#L100-L116) is a choice?
> Yes. In my personal opinion, it would be better.
Thanks for the decision - changed back `check_*_data_dependency` to the first version, and tested a `test/jtreg/hotspot/compiler` on Qemu.
More information about the riscv-port-dev