[riscv-port] RFR: 8281731: riscv: Refactor instruction extraction code in nativeInst_riscv.h/cpp [v3]
xlinzheng at openjdk.java.net
Wed Feb 16 07:11:36 UTC 2022
On Wed, 16 Feb 2022 04:42:13 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:
>> Hi team,
>> Could I have a review of this patch - this is just a trivial refactoring with some cleanups for `nativeInst_riscv.h/cpp` using `Assembler::extract()` with raw bits, by adding `extract_rs1`, `extract_rs2`, `extract_rd`, `extract_opcode`, and `extract_funct3` to make the code cleaner and conciser. Tested hotspot tier1 on Qemu with no other errors found.
> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
> Keep readability
Thanks for the reviews, team!
More information about the riscv-port-dev