From fyang at openjdk.java.net Tue Jan 4 02:44:46 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 4 Jan 2022 02:44:46 GMT Subject: [riscv-port] RFR: 8279346: riscv: Unnecessary sign extension in BigInteger intrinsics In-Reply-To: <6rczN2yxo3a_Jp1b42HKiNqDw0ashboHLDqqoEH7tqM=.648ec3d1-66f6-4925-9162-5461fd58f022@github.com> References: <6rczN2yxo3a_Jp1b42HKiNqDw0ashboHLDqqoEH7tqM=.648ec3d1-66f6-4925-9162-5461fd58f022@github.com> Message-ID: <_PwM2G7bcr2VB1tTzP1Un2dbLVrw__MFRmf4xV9PyM8=.6fa858eb-7d8a-4ec9-8a4a-8cea3b94a3b9@github.com> On Fri, 31 Dec 2021 09:13:47 GMT, Yanhong Zhu wrote: > Reference: https://github.com/riscv-non-isa/riscv-elf-psabi-doc > > " Scalars that are at most XLEN bits wide are passed in a single argument register, or on the stack by value if none is available. > When passed in registers or on the stack, integer scalars narrower than XLEN bits are widened according to the sign of their type up to 32 bits, then sign-extended to XLEN bits. > When passed in registers or on the stack, floating-point types narrower than XLEN bits are widened to XLEN bits, with the upper bits undefined." > > So there is no need to do sign extension for signed integer input parameters. > > Performed full jtreg tests with qemu without new failures. Looks good. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/40 From yzhu at openjdk.java.net Tue Jan 4 02:50:33 2022 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Tue, 4 Jan 2022 02:50:33 GMT Subject: [riscv-port] Integrated: 8279346: riscv: Unnecessary sign extension in BigInteger intrinsics In-Reply-To: <6rczN2yxo3a_Jp1b42HKiNqDw0ashboHLDqqoEH7tqM=.648ec3d1-66f6-4925-9162-5461fd58f022@github.com> References: <6rczN2yxo3a_Jp1b42HKiNqDw0ashboHLDqqoEH7tqM=.648ec3d1-66f6-4925-9162-5461fd58f022@github.com> Message-ID: On Fri, 31 Dec 2021 09:13:47 GMT, Yanhong Zhu wrote: > Reference: https://github.com/riscv-non-isa/riscv-elf-psabi-doc > > " Scalars that are at most XLEN bits wide are passed in a single argument register, or on the stack by value if none is available. > When passed in registers or on the stack, integer scalars narrower than XLEN bits are widened according to the sign of their type up to 32 bits, then sign-extended to XLEN bits. > When passed in registers or on the stack, floating-point types narrower than XLEN bits are widened to XLEN bits, with the upper bits undefined." > > So there is no need to do sign extension for signed integer input parameters. > > Performed full jtreg tests with qemu without new failures. This pull request has now been integrated. Changeset: e73db5d3 Author: Yanhong Zhu Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/e73db5d332f4d69261d0c92817d4e839a7ac71c1 Stats: 41 lines in 4 files changed: 4 ins; 8 del; 29 mod 8279346: riscv: Unnecessary sign extension in BigInteger intrinsics Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/40 From xlinzheng at openjdk.java.net Tue Jan 4 02:59:14 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Tue, 4 Jan 2022 02:59:14 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v4] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: Update licenses to the new year ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/34/files - new: https://git.openjdk.java.net/riscv-port/pull/34/files/5df07a18..2accc5b5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=03 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=02-03 Stats: 37 lines in 15 files changed: 0 ins; 0 del; 37 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From fjiang at openjdk.java.net Tue Jan 4 02:59:18 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Tue, 4 Jan 2022 02:59:18 GMT Subject: [riscv-port] RFR: 8279344: riscv: RVB: Add bitwise rotation instructions [v6] In-Reply-To: References: Message-ID: > This PR implements bitwise instructions of RISC-V BitManipulation Extension, including ror/rolw/ror/rori/roriw/rorw. New C2 instructions are covered by following JTREG tests: > - test/hotspot/jtreg/compiler/intrinsics/TestRotate.java > - test/jdk/java/lang > > This PR also add zext/bext C2 instructions that were missed in JDK-8279213 > > Hotspot and jdk tier1 test on QEMU (enable RVB) are passed without new failures. Feilong Jiang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - remove unused imm definition - remove unused instruction in riscv_b.ad - 8279344: riscv: RVB: Add bitwise rotation instructions ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/39/files - new: https://git.openjdk.java.net/riscv-port/pull/39/files/428e2151..92e21821 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=39&range=05 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=39&range=04-05 Stats: 41 lines in 4 files changed: 4 ins; 8 del; 29 mod Patch: https://git.openjdk.java.net/riscv-port/pull/39.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/39/head:pull/39 PR: https://git.openjdk.java.net/riscv-port/pull/39 From fjiang at openjdk.java.net Tue Jan 4 02:59:19 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Tue, 4 Jan 2022 02:59:19 GMT Subject: [riscv-port] RFR: 8279344: riscv: RVB: Add bitwise rotation instructions [v5] In-Reply-To: References: Message-ID: On Fri, 31 Dec 2021 10:07:06 GMT, Feilong Jiang wrote: >> This PR implements bitwise instructions of RISC-V BitManipulation Extension, including ror/rolw/ror/rori/roriw/rorw. New C2 instructions are covered by following JTREG tests: >> - test/hotspot/jtreg/compiler/intrinsics/TestRotate.java >> - test/jdk/java/lang >> >> This PR also add zext/bext C2 instructions that were missed in JDK-8279213 >> >> Hotspot and jdk tier1 test on QEMU (enable RVB) are passed without new failures. > > Feilong Jiang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. Rebased #40 with no conflicts. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/39 From fjiang at openjdk.java.net Tue Jan 4 03:07:30 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Tue, 4 Jan 2022 03:07:30 GMT Subject: [riscv-port] RFR: 8279344: riscv: RVB: Add bitwise rotation instructions [v7] In-Reply-To: References: Message-ID: > This PR implements bitwise instructions of RISC-V BitManipulation Extension, including ror/rolw/ror/rori/roriw/rorw. New C2 instructions are covered by following JTREG tests: > - test/hotspot/jtreg/compiler/intrinsics/TestRotate.java > - test/jdk/java/lang > > This PR also add zext/bext C2 instructions that were missed in JDK-8279213 > > Hotspot and jdk tier1 test on QEMU (enable RVB) are passed without new failures. Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: update copyright to 2022 ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/39/files - new: https://git.openjdk.java.net/riscv-port/pull/39/files/92e21821..fe673075 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=39&range=06 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=39&range=05-06 Stats: 6 lines in 6 files changed: 1 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/riscv-port/pull/39.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/39/head:pull/39 PR: https://git.openjdk.java.net/riscv-port/pull/39 From fjiang at openjdk.java.net Tue Jan 4 03:36:24 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Tue, 4 Jan 2022 03:36:24 GMT Subject: [riscv-port] RFR: 8279344: riscv: RVB: Add bitwise rotation instructions [v8] In-Reply-To: References: Message-ID: <6NztdzsIDaHGvTfpW3R7x1uvcayT8xYR_9aksD47s7o=.79bd1815-9090-45e0-95ec-814e9159aa31@github.com> > This PR implements bitwise instructions of RISC-V BitManipulation Extension, including ror/rolw/ror/rori/roriw/rorw. New C2 instructions are covered by following JTREG tests: > - test/hotspot/jtreg/compiler/intrinsics/TestRotate.java > - test/jdk/java/lang > > This PR also add zext/bext C2 instructions that were missed in JDK-8279213 > > Hotspot and jdk tier1 test on QEMU (enable RVB) are passed without new failures. Feilong Jiang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: update copyright to 2022 ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/39/files - new: https://git.openjdk.java.net/riscv-port/pull/39/files/fe673075..1c519c74 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=39&range=07 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=39&range=06-07 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/39.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/39/head:pull/39 PR: https://git.openjdk.java.net/riscv-port/pull/39 From xlinzheng at openjdk.java.net Tue Jan 4 04:34:11 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Tue, 4 Jan 2022 04:34:11 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v5] In-Reply-To: References: Message-ID: <6GRkIcoZn--WXcu3JADPIKzubJCCn5o6bt-heaHldOQ=.43e9dd47-ae8d-4f1a-a0b7-23961092ea08@github.com> > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Update licenses to the new year ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/34/files - new: https://git.openjdk.java.net/riscv-port/pull/34/files/2accc5b5..84de97e9 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=04 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=03-04 Stats: 37 lines in 15 files changed: 0 ins; 0 del; 37 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Tue Jan 4 06:14:31 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 4 Jan 2022 06:14:31 GMT Subject: [riscv-port] RFR: 8279344: riscv: RVB: Add bitwise rotation instructions [v8] In-Reply-To: <6NztdzsIDaHGvTfpW3R7x1uvcayT8xYR_9aksD47s7o=.79bd1815-9090-45e0-95ec-814e9159aa31@github.com> References: <6NztdzsIDaHGvTfpW3R7x1uvcayT8xYR_9aksD47s7o=.79bd1815-9090-45e0-95ec-814e9159aa31@github.com> Message-ID: On Tue, 4 Jan 2022 03:36:24 GMT, Feilong Jiang wrote: >> This PR implements bitwise instructions of RISC-V BitManipulation Extension, including ror/rolw/ror/rori/roriw/rorw. New C2 instructions are covered by following JTREG tests: >> - test/hotspot/jtreg/compiler/intrinsics/TestRotate.java >> - test/jdk/java/lang >> >> This PR also add zext/bext C2 instructions that were missed in JDK-8279213 >> >> Hotspot and jdk tier1 test on QEMU (enable RVB) are passed without new failures. > > Feilong Jiang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. Changes requested by fyang (Lead). src/hotspot/cpu/riscv/riscv_b.ad line 166: > 164: > 165: // unsigned int to short > 166: instruct convUI2S_reg_reg_rvb(iRegINoSp dst, iRegIorL2I src, immI_16bits mask) %{ We should rename this from convUI2S_reg_reg_rvb to convS2UI_reg_reg_rvb. Please also update the comments. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/39 From fjiang at openjdk.java.net Tue Jan 4 07:07:23 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Tue, 4 Jan 2022 07:07:23 GMT Subject: [riscv-port] RFR: 8279344: riscv: RVB: Add bitwise rotation instructions [v9] In-Reply-To: References: Message-ID: > This PR implements bitwise instructions of RISC-V BitManipulation Extension, including ror/rolw/ror/rori/roriw/rorw. New C2 instructions are covered by following JTREG tests: > - test/hotspot/jtreg/compiler/intrinsics/TestRotate.java > - test/jdk/java/lang > > This PR also add zext/bext C2 instructions that were missed in JDK-8279213 > > Hotspot and jdk tier1 test on QEMU (enable RVB) are passed without new failures. Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: rename some instruct to match its match rule ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/39/files - new: https://git.openjdk.java.net/riscv-port/pull/39/files/1c519c74..d4e74d53 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=39&range=08 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=39&range=07-08 Stats: 41 lines in 2 files changed: 15 ins; 17 del; 9 mod Patch: https://git.openjdk.java.net/riscv-port/pull/39.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/39/head:pull/39 PR: https://git.openjdk.java.net/riscv-port/pull/39 From fyang at openjdk.java.net Tue Jan 4 07:25:44 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 4 Jan 2022 07:25:44 GMT Subject: [riscv-port] RFR: 8279344: riscv: RVB: Add bitwise rotation instructions [v9] In-Reply-To: References: Message-ID: On Tue, 4 Jan 2022 07:07:23 GMT, Feilong Jiang wrote: >> This PR implements bitwise instructions of RISC-V BitManipulation Extension, including ror/rolw/ror/rori/roriw/rorw. New C2 instructions are covered by following JTREG tests: >> - test/hotspot/jtreg/compiler/intrinsics/TestRotate.java >> - test/jdk/java/lang >> >> This PR also add zext/bext C2 instructions that were missed in JDK-8279213 >> >> Hotspot and jdk tier1 test on QEMU (enable RVB) are passed without new failures. > > Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: > > rename some instruct to match its match rule Looks good. Thanks. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/39 From duke at openjdk.java.net Tue Jan 4 07:41:54 2022 From: duke at openjdk.java.net (duke) Date: Tue, 4 Jan 2022 07:41:54 GMT Subject: git: openjdk/riscv-port: riscv-port: 8 new changesets Message-ID: Changeset: 299022df Author: Sergey Nazarkin Committer: Alexey Bakhtin Date: 2021-12-28 11:29:12 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/299022dfacbcb49e3bc5beca8ff9b1fca1101493 8279225: [arm32] C1 longs comparison operation destroys argument registers Reviewed-by: haosun, aph ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp Changeset: 2a59ebbb Author: Chris Plummer Date: 2022-01-03 01:29:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2a59ebbba391ee0d70604027081712f1c2dfd1fe 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist Reviewed-by: kevinw, sspitsyn ! src/jdk.hotspot.agent/doc/index.html Changeset: 3a1fca3a Author: Aleksey Shipilev Date: 2022-01-03 14:39:35 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3a1fca3adf3111a966cb62d926b95acc89b7fe97 8278146: G1: Rework VM_G1Concurrent VMOp to clearly identify it as pause Reviewed-by: tschatzl, kbarrett ! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp ! src/hotspot/share/gc/g1/g1VMOperations.cpp ! src/hotspot/share/gc/g1/g1VMOperations.hpp ! src/hotspot/share/runtime/vmOperation.hpp Changeset: c295e71b Author: Hendrik Schreiber Committer: Roger Riggs Date: 2022-01-03 15:57:34 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c295e71b49db20ab398ae1e8ba504d8ebff5fb77 8276700: Improve java.lang.ref.Cleaner javadocs Reviewed-by: rriggs, mchung ! src/java.base/share/classes/java/lang/ref/Cleaner.java Changeset: 6b906bba Author: Erik Joelsson Date: 2022-01-03 21:53:50 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6b906bbab1bdeceab9610cec8c6fd95128fddf32 8279223: Define version in .jcheck/conf Reviewed-by: alanb, iris, kcr ! .jcheck/conf Changeset: 8dc4437d Author: Naoto Sato Date: 2022-01-04 02:48:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8dc4437d002db5d025b47f48e7420e3bae55bdec 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java Reviewed-by: joehw ! src/java.base/share/classes/sun/util/cldr/CLDRTimeZoneNameProviderImpl.java ! test/jdk/java/time/test/java/time/format/TestZoneTextPrinterParser.java + test/micro/org/openjdk/bench/java/text/ZoneStrings.java Changeset: 09cf5f19 Author: Ioi Lam Date: 2022-01-04 04:52:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/09cf5f19d76b17790ffb899aad247f821a27d46b 8278602: CDS dynamic dump may access unloaded classes Reviewed-by: coleenp, ccheung ! src/hotspot/share/cds/dumpTimeClassInfo.cpp ! src/hotspot/share/cds/dumpTimeClassInfo.hpp + src/hotspot/share/cds/dumpTimeClassInfo.inline.hpp ! src/hotspot/share/cds/dynamicArchive.cpp ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! src/hotspot/share/classfile/systemDictionaryShared.hpp + test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/LotsUnloadTest.java + test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/test-classes/LotsUnloadApp.java Changeset: dc923e2b Author: Fei Yang Date: 2022-01-04 02:40:18 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/dc923e2b744a001bdc652d9c816a8af3c4dc8cd3 Merge branch 'master' into riscv-port ! .jcheck/conf ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp ! .jcheck/conf ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp From felix.yang at huawei.com Tue Jan 4 08:25:16 2022 From: felix.yang at huawei.com (Yangfei (Felix)) Date: Tue, 4 Jan 2022 08:25:16 +0000 Subject: Result: New RISC-V Port Committer: Yanhong Zhu Message-ID: <92919c181bcf44f5babae1ea84ea72b2@huawei.com> Voting for Yanhong Zhu [1] is now closed. Yes: 2 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Felix [1] https://mail.openjdk.java.net/pipermail/riscv-port-dev/2021-December/000230.html From fjiang at openjdk.java.net Wed Jan 5 03:17:59 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 5 Jan 2022 03:17:59 GMT Subject: [riscv-port] RFR: 8279487: riscv: Fix bad AD file when UseRVB is disabled Message-ID: After JDK-8279344, test/hotspot/jtreg/compiler/intrinsics/TestRotate.java will report bad AD file error in fastdebug when UseRVB is disabled: ----------System.out:(61/2324)---------- o27 RotateRight === _ o10 o22 [[o28 2 ]] #int --N: o27 RotateRight === _ o10 o22 [[o28 2 ]] #int --N: o10 Parm === o3 [[o27 ]] Parm0: int IREGI 0 IREGI IREGINOSP 0 IREGINOSP IREGI_R10 0 IREGI_R10 IREGI_R12 0 IREGI_R12 IREGI_R13 0 IREGI_R13 IREGI_R14 0 IREGI_R14 IREGIHEAPBASE 0 IREGIHEAPBASE IREGIORL2I 0 IREGI IREGIORL 0 IREGI IREGILNP 0 IREGI IREGILNPNOSP 0 IREGINOSP --N: o22 ConI === o0 [[o27 ]] #int:1 IMMI 0 IMMI IMMI_1 0 IMMI_1 IMMI_LE_4 0 IMMI_LE_4 IMMIADD 0 IMMIADD IMMISUB 0 IMMISUB IMMI5 0 IMMI5 IMMIOFFSET 0 IMMIOFFSET IREGI 100 loadConI IREGINOSP 100 loadConI IREGI_R10 100 loadConI IREGI_R12 100 loadConI IREGI_R13 100 loadConI IREGI_R14 100 loadConI IREGIORL2I 100 IREGI IREGIORL 100 IREGI IREGILNP 100 IREGI ------------- Commit messages: - 8279487: riscv: Fix bad AD file when UseRVB is disabled Changes: https://git.openjdk.java.net/riscv-port/pull/41/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=41&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279487 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/riscv-port/pull/41.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/41/head:pull/41 PR: https://git.openjdk.java.net/riscv-port/pull/41 From yadongwang at openjdk.java.net Wed Jan 5 03:50:51 2022 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Wed, 5 Jan 2022 03:50:51 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v5] In-Reply-To: <6GRkIcoZn--WXcu3JADPIKzubJCCn5o6bt-heaHldOQ=.43e9dd47-ae8d-4f1a-a0b7-23961092ea08@github.com> References: <6GRkIcoZn--WXcu3JADPIKzubJCCn5o6bt-heaHldOQ=.43e9dd47-ae8d-4f1a-a0b7-23961092ea08@github.com> Message-ID: On Tue, 4 Jan 2022 04:34:11 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. src/hotspot/cpu/riscv/assembler_riscv.hpp line 431: > 429: INSN(remu, 0b0110011, 0b111, 0b0000001, NOT_COMPRESSIBLE); > 430: INSN(remw, 0b0111011, 0b110, 0b0000001, NOT_COMPRESSIBLE); > 431: INSN(remuw, 0b0111011, 0b111, 0b0000001, NOT_COMPRESSIBLE); Shall we arrange the instructions to 2 groups (compressible and non-compressible), instead of crossing each other? src/hotspot/cpu/riscv/c2_globals_riscv.hpp line 49: > 47: define_pd_global(intx, FreqInlineSize, 325); > 48: define_pd_global(intx, MinJumpTableSize, 10); > 49: define_pd_global(intx, InteriorEntryAlignment, 4); It's best to keep InteriorEntryAlignment and CodeEntryAlignment unchanged if there's no obvious benefits. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Wed Jan 5 06:32:41 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Wed, 5 Jan 2022 06:32:41 GMT Subject: [riscv-port] RFR: 8279487: riscv: Fix bad AD file when UseRVB is disabled In-Reply-To: References: Message-ID: On Wed, 5 Jan 2022 03:12:16 GMT, Feilong Jiang wrote: > After JDK-8279344, test/hotspot/jtreg/compiler/intrinsics/TestRotate.java will report bad AD file error in fastdebug when UseRVB is disabled. > Some match rules for `RotateRight` and `RotateLeft` are added by [JDK-8279344](https://bugs.openjdk.java.net/browse/JDK-8279344) , which is under predicate of UseRVB. But `match_rule_supported(Op_RotateRight/Op_RotateLeft)` still returns true even when UseRVB is disabled. This will cause the bad AD file error on fastdebug JDK. > This PR fixes this issue by setting `match_rule_supported(Op_RotateRight)` and `match_rule_supported(Op_RotateLeft)` to false when UseRVB is disabled. > > test/hotspot/jtreg/compiler/intrinsics/TestRotate.java passed with/without UseRVB on fastdebug JDK. Looks reasonable. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/41 From fjiang at openjdk.java.net Wed Jan 5 06:32:42 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 5 Jan 2022 06:32:42 GMT Subject: [riscv-port] RFR: 8279487: riscv: Fix bad AD file when UseRVB is disabled In-Reply-To: References: Message-ID: On Wed, 5 Jan 2022 03:12:16 GMT, Feilong Jiang wrote: > After JDK-8279344, test/hotspot/jtreg/compiler/intrinsics/TestRotate.java will report bad AD file error in fastdebug when UseRVB is disabled. > Some match rules for `RotateRight` and `RotateLeft` are added by [JDK-8279344](https://bugs.openjdk.java.net/browse/JDK-8279344) , which is under predicate of UseRVB. But `match_rule_supported(Op_RotateRight/Op_RotateLeft)` still returns true even when UseRVB is disabled. This will cause the bad AD file error on fastdebug JDK. > This PR fixes this issue by setting `match_rule_supported(Op_RotateRight)` and `match_rule_supported(Op_RotateLeft)` to false when UseRVB is disabled. > > test/hotspot/jtreg/compiler/intrinsics/TestRotate.java passed with/without UseRVB on fastdebug JDK. Thank you for the review, Felix. /integrate ------------- PR: https://git.openjdk.java.net/riscv-port/pull/41 From fjiang at openjdk.java.net Wed Jan 5 06:39:34 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 5 Jan 2022 06:39:34 GMT Subject: [riscv-port] Integrated: 8279487: riscv: Fix bad AD file when UseRVB is disabled In-Reply-To: References: Message-ID: On Wed, 5 Jan 2022 03:12:16 GMT, Feilong Jiang wrote: > After JDK-8279344, test/hotspot/jtreg/compiler/intrinsics/TestRotate.java will report bad AD file error in fastdebug when UseRVB is disabled. > Some match rules for `RotateRight` and `RotateLeft` are added by [JDK-8279344](https://bugs.openjdk.java.net/browse/JDK-8279344) , which is under predicate of UseRVB. But `match_rule_supported(Op_RotateRight/Op_RotateLeft)` still returns true even when UseRVB is disabled. This will cause the bad AD file error on fastdebug JDK. > This PR fixes this issue by setting `match_rule_supported(Op_RotateRight)` and `match_rule_supported(Op_RotateLeft)` to false when UseRVB is disabled. > > test/hotspot/jtreg/compiler/intrinsics/TestRotate.java passed with/without UseRVB on fastdebug JDK. This pull request has now been integrated. Changeset: 65cf0efe Author: Feilong Jiang Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/65cf0efe4317a73fdd6a00af432b48972e77cf17 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8279487: riscv: Fix bad AD file when UseRVB is disabled Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/41 From xlinzheng at openjdk.java.net Thu Jan 6 08:12:11 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Thu, 6 Jan 2022 08:12:11 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v6] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request incrementally with five additional commits since the last revision: - Manually inline all macros into functions as discussions - Remove assembler_riscv_c.hpp as discussions - Remove COMPRESSIBLE & NOT_COMPRESSIBLE macros by adding one layer as discussions - Fix remaining CEXT -> RVC - Remove Alignment-related changes as discussions ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/34/files - new: https://git.openjdk.java.net/riscv-port/pull/34/files/84de97e9..e0de8c92 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=05 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=04-05 Stats: 2004 lines in 5 files changed: 1016 ins; 902 del; 86 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Thu Jan 6 08:12:12 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Thu, 6 Jan 2022 08:12:12 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v5] In-Reply-To: References: <6GRkIcoZn--WXcu3JADPIKzubJCCn5o6bt-heaHldOQ=.43e9dd47-ae8d-4f1a-a0b7-23961092ea08@github.com> Message-ID: On Tue, 4 Jan 2022 11:23:52 GMT, Yadong Wang wrote: >> Xiaolin Zheng has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. > > src/hotspot/cpu/riscv/assembler_riscv.hpp line 431: > >> 429: INSN(remu, 0b0110011, 0b111, 0b0000001, NOT_COMPRESSIBLE); >> 430: INSN(remw, 0b0111011, 0b110, 0b0000001, NOT_COMPRESSIBLE); >> 431: INSN(remuw, 0b0111011, 0b111, 0b0000001, NOT_COMPRESSIBLE); > > Shall we arrange the instructions to 2 groups (compressible and non-compressible), instead of crossing each other? Thanks for your reviews Yadong. These macros are not existed anymore - I have separated them off and hope you like it. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Thu Jan 6 08:17:15 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Thu, 6 Jan 2022 08:17:15 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v7] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: Remain an 'minimum_alignment' unchanged ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/34/files - new: https://git.openjdk.java.net/riscv-port/pull/34/files/e0de8c92..42abb1b8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=06 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=05-06 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Thu Jan 6 08:20:46 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Thu, 6 Jan 2022 08:20:46 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v5] In-Reply-To: References: <6GRkIcoZn--WXcu3JADPIKzubJCCn5o6bt-heaHldOQ=.43e9dd47-ae8d-4f1a-a0b7-23961092ea08@github.com> Message-ID: On Wed, 5 Jan 2022 03:47:42 GMT, Yadong Wang wrote: >> Xiaolin Zheng has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. > > src/hotspot/cpu/riscv/c2_globals_riscv.hpp line 49: > >> 47: define_pd_global(intx, FreqInlineSize, 325); >> 48: define_pd_global(intx, MinJumpTableSize, 10); >> 49: define_pd_global(intx, InteriorEntryAlignment, 4); > > It's best to keep InteriorEntryAlignment and CodeEntryAlignment unchanged if there's no obvious benefits. These changes are made for shrinking the code size to a minimum level. Though regarding them doing no harm and as an enhancement, I consider it also great to remain them unchanged. Need some testing work after the changes and if there are other suggestions I feel pleased to change. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Thu Jan 6 09:30:19 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Thu, 6 Jan 2022 09:30:19 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v8] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: Remove remaining macros as discussions ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/34/files - new: https://git.openjdk.java.net/riscv-port/pull/34/files/42abb1b8..2ecdc92b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=07 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=06-07 Stats: 154 lines in 1 file changed: 15 ins; 15 del; 124 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Thu Jan 6 09:54:46 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Thu, 6 Jan 2022 09:54:46 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v8] In-Reply-To: References: Message-ID: <4Fp4GmDeW3x0w_Mxrz4Rs_qdqErusN23ZbiEa7PjC6Q=.3d9bf48a-634a-489d-b6ea-3b84153056db@github.com> On Thu, 6 Jan 2022 09:30:19 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: > > Remove remaining macros as discussions src/hotspot/cpu/riscv/assembler_riscv.hpp line 1345: > 1343: protected: > 1344: Assembler *_masm; > 1345: bool _prev_in_compressible_region; suggestion: rename to "_saved_in_compressible_region" src/hotspot/cpu/riscv/assembler_riscv.hpp line 1858: > 1856: > 1857: // -------------------------- > 1858: // sub/subw -> c.sub/c.subw It's better to move this comment before the if block which does compression. src/hotspot/cpu/riscv/assembler_riscv.hpp line 1898: > 1896: private: > 1897: // some helper functions > 1898: bool check_rvc() const { maybe rename to "bool do_compress"? ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Thu Jan 6 09:58:33 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Thu, 6 Jan 2022 09:58:33 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v8] In-Reply-To: References: Message-ID: On Thu, 6 Jan 2022 09:30:19 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: > > Remove remaining macros as discussions src/hotspot/cpu/riscv/globals_riscv.hpp line 95: > 93: product(bool, UseRVV, false, EXPERIMENTAL, "Use RVV instructions") \ > 94: product(bool, UseRVB, false, EXPERIMENTAL, "Use RVB instructions") \ > 95: product(bool, UseRVC, false, EXPERIMENTAL, "Use RVC instructions") \ redundant '' at end of line, we should remove it. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Thu Jan 6 11:33:26 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Thu, 6 Jan 2022 11:33:26 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v9] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: Rename misc functions and change the positions of some comments ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/34/files - new: https://git.openjdk.java.net/riscv-port/pull/34/files/2ecdc92b..6102220b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=08 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=07-08 Stats: 68 lines in 2 files changed: 21 ins; 20 del; 27 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Thu Jan 6 11:33:27 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Thu, 6 Jan 2022 11:33:27 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v8] In-Reply-To: <4Fp4GmDeW3x0w_Mxrz4Rs_qdqErusN23ZbiEa7PjC6Q=.3d9bf48a-634a-489d-b6ea-3b84153056db@github.com> References: <4Fp4GmDeW3x0w_Mxrz4Rs_qdqErusN23ZbiEa7PjC6Q=.3d9bf48a-634a-489d-b6ea-3b84153056db@github.com> Message-ID: On Thu, 6 Jan 2022 09:46:25 GMT, Fei Yang wrote: >> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove remaining macros as discussions > > src/hotspot/cpu/riscv/assembler_riscv.hpp line 1858: > >> 1856: >> 1857: // -------------------------- >> 1858: // sub/subw -> c.sub/c.subw > > It's better to move this comment before the if block which does compression. Thanks for pointing out this and I have moved them before every if block. A trivial detail might be that we need to use `/**/` inside macros instead of `//`. Also fixed other comments. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From fjiang at openjdk.java.net Fri Jan 7 01:29:02 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 7 Jan 2022 01:29:02 GMT Subject: [riscv-port] RFR: 8279565: riscv: RVB: Add byte reverse instruction Message-ID: This PR has the following changes: 1. Implement byte-reverse instruction `rev8` of RISC-V BitManipulation Extension. 2. Code improvement of existing byte reverse methods. 3. Merge assembler_riscv_b.hpp and assembler_riscv_v.hpp into assembler_riscv.hpp New C2 instructions under riscv_b.ad are covered by the following JTREG tests: - test/hotspot/jtreg/compiler/codegen/Test6431242.java - test/hotspot/jtreg/compiler/c2/TestCharShortByteSwap.java Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. ------------- Commit messages: - 8279565: riscv: RVB: Add byte reverse instruction Changes: https://git.openjdk.java.net/riscv-port/pull/42/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=42&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279565 Stats: 1845 lines in 10 files changed: 877 ins; 865 del; 103 mod Patch: https://git.openjdk.java.net/riscv-port/pull/42.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/42/head:pull/42 PR: https://git.openjdk.java.net/riscv-port/pull/42 From fjiang at openjdk.java.net Fri Jan 7 02:01:28 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 7 Jan 2022 02:01:28 GMT Subject: [riscv-port] RFR: 8279565: riscv: RVB: Add byte reverse instruction [v2] In-Reply-To: References: Message-ID: > This PR has the following changes: > 1. Implement byte-reverse instruction `rev8` of RISC-V BitManipulation Extension. > 2. Code improvement of existing byte reverse methods. > 3. Merge assembler_riscv_b.hpp and assembler_riscv_v.hpp into assembler_riscv.hpp > > Renaming of byte reverse methods is based on BitManipulation v0.93 [[1]], which provides `rev8.h`, `rev8.w` and `rev8` to reverse bytes in halfwords, words, and doubleword respectively. However, there are still some byte reverse operations that are not covered by spec, for example, "reverse bytes in halfword in lower 16 bits and sign extend". Base on the existing instructions naming style, we use `rev8.h.h` to represent it. > > New C2 instructions under riscv_b.ad are covered by the following JTREG tests: > - test/hotspot/jtreg/compiler/codegen/Test6431242.java > - test/hotspot/jtreg/compiler/c2/TestCharShortByteSwap.java > > Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. > > [1]: https://github.com/riscv/riscv-bitmanip/releases/download/v0.93/bitmanip-0.93.pdf Feilong Jiang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8279565: riscv: RVB: Add byte reverse instruction ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/42/files - new: https://git.openjdk.java.net/riscv-port/pull/42/files/79753194..46022206 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=42&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=42&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/riscv-port/pull/42.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/42/head:pull/42 PR: https://git.openjdk.java.net/riscv-port/pull/42 From duke at openjdk.java.net Fri Jan 7 03:24:46 2022 From: duke at openjdk.java.net (duke) Date: Fri, 7 Jan 2022 03:24:46 GMT Subject: git: openjdk/riscv-port: riscv-port: 36 new changesets Message-ID: <1129aac1-5e64-4770-9c8c-992ff7aea0fe@openjdk.java.net> Changeset: 9bdf6eb7 Author: Matthias Baesken Date: 2022-01-04 07:55:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9bdf6eb7b2412ecff523015f1430dfb6a0e4dd09 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 Reviewed-by: weijun ! test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java Changeset: 863bffb3 Author: Albert Mingkun Yang Date: 2022-01-04 09:56:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/863bffb3b6617dcec6461a41cf0a676ad2fefbc7 8279374: Remove unused JNIHandles::weak_oops_do Reviewed-by: coleenp ! src/hotspot/share/runtime/jniHandles.cpp ! src/hotspot/share/runtime/jniHandles.hpp Changeset: 1ffdc52c Author: Doug Simon Date: 2022-01-04 10:14:50 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1ffdc52cf0ab88458e0583bff28d35ca33d244b7 8279412: [JVMCI] failed speculations list must outlive any nmethod that refers to it Reviewed-by: kvn, never ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotCodeCacheProvider.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotNmethod.java Changeset: 93c7d90c Author: Hamlin Li Date: 2022-01-04 11:55:41 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/93c7d90c55034ba8dbcd612366c891ad08c9c54e 8278282: G1: Log basic statistics for evacuation failure Reviewed-by: tschatzl, ayang, iwalulya ! src/hotspot/share/gc/g1/g1EvacFailure.cpp ! src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp ! src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp ! test/hotspot/jtreg/gc/g1/TestGCLogMessages.java ! test/jdk/jdk/jfr/event/gc/collection/TestG1ParallelPhases.java Changeset: d1e6f261 Author: Yasumasa Suenaga Date: 2022-01-04 15:00:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d1e6f26160e811b8d6f44108899422a62c0be388 8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error Reviewed-by: cjplummer ! test/hotspot/jtreg/serviceability/sa/sadebugd/SADebugDTest.java Changeset: 99a8351b Author: Albert Mingkun Yang Date: 2022-01-04 16:06:34 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/99a8351bc913a94f8aebef54fe7b147545edd258 8279386: Remove duplicate RefProcPhaseTimeTracker Reviewed-by: iwalulya, mli ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.cpp ! src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.hpp Changeset: b4b0328d Author: William Kemper Committer: Paul Hohensee Date: 2021-12-28 17:32:00 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b4b0328d62d9a9646f2822c361e41001bf0d4aa0 8278824: Uneven work distribution when scanning heap roots in G1 Reviewed-by: ayang, tschatzl, phh ! src/hotspot/share/gc/g1/g1RemSet.cpp Changeset: e7244c19 Author: Roland Westrelin Date: 2022-01-04 10:56:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e7244c19f4e24698ab074da530bf6c403f0e22cd 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638 Reviewed-by: rbackman, vlivanov ! src/hotspot/share/opto/callGenerator.cpp ! test/hotspot/jtreg/compiler/exceptions/TestLateMHInlineExceptions.java Changeset: 06f37132 Author: Aleksey Shipilev Date: 2022-01-04 11:13:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/06f3713271f7827b376a3a9cfbfd3d91bc77f7de 8279379: GHA: Print tests that are in error Reviewed-by: erikj, clanger ! .github/workflows/submit.yml Changeset: 58b5fb32 Author: Vladimir Ivanov Date: 2022-01-04 12:34:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/58b5fb3233a9bbbfc1f1f8818be4dfd54325f1bd 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL Reviewed-by: kvn, thartmann ! src/hotspot/share/prims/vectorSupport.cpp Changeset: 95a3010a Author: Vladimir Ivanov Date: 2022-01-04 12:35:48 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/95a3010acf822a76bf0e1ebffdddce5d38b75e7b 8275830: C2: Receiver downcast is missing when inlining through method handle linkers Reviewed-by: kvn, dlong ! src/hotspot/share/opto/doCall.cpp ! test/hotspot/jtreg/compiler/cha/AbstractRootMethod.java ! test/hotspot/jtreg/compiler/cha/DefaultRootMethod.java ! test/hotspot/jtreg/compiler/cha/Utils.java Changeset: 191f7307 Author: Jesper Wilhelmsson Date: 2022-01-04 19:31:12 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/191f7307bb2f2e2ce93480b4fc5fbbef216ff7cd Merge ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RemSet.cpp Changeset: f3263053 Author: Zhiqiang Zang Committer: Vladimir Kozlov Date: 2022-01-05 00:38:59 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f3263053963451637258f9d318e7b93b79fcce54 8278114: New addnode ideal optimization: converting "x + x" into "x << 1" Reviewed-by: kvn, redestad ! src/hotspot/share/opto/mulnode.cpp + test/hotspot/jtreg/compiler/c2/irTests/TestIRLShiftIdeal_XPlusX_LShiftC.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java + test/micro/org/openjdk/bench/vm/compiler/LShiftIdeal_XPlusX_LShiftC.java Changeset: 8b5de27c Author: bobpengxie Committer: Jie Fu Date: 2022-01-05 02:22:26 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8b5de27ce1e4fe664e08879c2ca89d08db710c9d 8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode.java after JDK-8278114 Reviewed-by: haosun, jiefu ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java Changeset: 0f98efbf Author: Aleksey Shipilev Date: 2022-01-05 12:04:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0f98efbf2f0e47bb398fe7ca5235853e1d98df3a 8279445: Update JMH devkit to 1.34 Reviewed-by: aph, erikj ! make/devkit/createJMHBundle.sh Changeset: b6ec39cc Author: Albert Mingkun Yang Date: 2022-01-05 15:36:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b6ec39cc84cfc845b09c0f851a24751c4abf6e1c 8279510: Parallel: Remove unused PSScavenge::_consecutive_skipped_scavenges Reviewed-by: kbarrett ! src/hotspot/share/gc/parallel/psScavenge.cpp ! src/hotspot/share/gc/parallel/psScavenge.hpp Changeset: a741b927 Author: Aleksey Shipilev Date: 2022-01-05 16:19:00 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a741b927a3cdc8e339ae557c77886ea850aa06b6 8279453: Disable tools/jar/ReproducibleJar.java on 32-bit platforms Reviewed-by: alanb, bpb ! test/jdk/tools/jar/ReproducibleJar.java Changeset: 9a0e8900 Author: Joe Darcy Date: 2022-01-05 18:55:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9a0e890056fb8ae4e28e656118e73fae33ba5e2a 8277515: Update --release 18 symbol information for JDK 18 build 29 Reviewed-by: iris ! make/data/symbols/java.base-I.sym.txt Changeset: 7b429a64 Author: Zhengyu Gu Date: 2022-01-05 19:12:41 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7b429a64ce7def84833de9e95217f303d9a7629d 8279168: Shenandoah: Remove unused always_true in ShenandoahRootAdjuster::roots_do() Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp Changeset: 523300e7 Author: Aleksey Shipilev Date: 2022-01-05 19:45:27 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/523300e7968b28ade4bbfe004030227a224ab2dc 8279526: Exceptions::count_out_of_memory_exceptions miscounts class metaspace OOMEs Reviewed-by: zgu, coleenp ! src/hotspot/share/utilities/exceptions.cpp Changeset: ab490534 Author: Ludvig Janiuk Committer: Aleksey Shipilev Date: 2022-01-05 20:09:32 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ab490534a1d14ad48ceb532ec1673ca9636f552d 8279533: Bad indentation and missing curly braces in BlockBegin::set_end Reviewed-by: shade ! src/hotspot/share/c1/c1_Instruction.cpp Changeset: f8f91480 Author: Quan Anh Mai Committer: Vladimir Kozlov Date: 2022-01-04 22:59:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f8f9148016662578804479180a70e3732b08c11c 8278948: compiler/vectorapi/reshape/TestVectorCastAVX1.java crashes in assembler Reviewed-by: kvn, sviswanathan ! src/hotspot/cpu/x86/x86.ad + test/hotspot/jtreg/compiler/vectorapi/Test8278948.java Changeset: 0f4807e8 Author: Aleksey Shipilev Date: 2022-01-05 07:29:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0f4807e8fe2468f303b32a6f2dc9ccc7ecad82a1 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660 Co-authored-by: Valerie Peng Reviewed-by: alanb, valeriep ! src/java.base/share/classes/java/security/Provider.java ! test/jdk/java/security/Provider/CaseSensitiveServices.java Changeset: 9d43d25d Author: Maurizio Cimadamore Date: 2022-01-05 10:47:34 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9d43d25da8bcfff425a795dcc230914a384a5c82 8278897: Alignment of heap segments is not enforced correctly Reviewed-by: jvernee ! src/java.base/share/classes/java/lang/invoke/MemoryAccessVarHandleBase.java ! src/java.base/share/classes/java/lang/invoke/X-VarHandleMemoryAccess.java.template ! src/java.base/share/classes/jdk/internal/access/foreign/MemorySegmentProxy.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryAddress.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/HeapMemorySegmentImpl.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/LayoutPath.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/MemoryAddressImpl.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/NativeMemorySegmentImpl.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/Utils.java ! test/jdk/java/foreign/TestArrayCopy.java + test/jdk/java/foreign/TestHeapAlignment.java ! test/jdk/java/foreign/TestMemoryAccessInstance.java ! test/jdk/java/foreign/TestMemoryAlignment.java ! test/jdk/java/foreign/TestSegmentCopy.java ! test/jdk/java/foreign/TestSpliterator.java ! test/jdk/java/foreign/TestVarHandleCombinators.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverNonConstant.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverNonConstantHeap.java Changeset: 5cd95153 Author: Daniel D. Daugherty Date: 2022-01-05 16:37:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5cd95153331860f990c268bd28e4cd38f3ce6d4a 8279525: ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java on macosx-aarch64 Reviewed-by: ccheung ! test/jdk/ProblemList.txt Changeset: 590fa9d8 Author: Anton Tarasov Date: 2022-01-05 18:37:00 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/590fa9d8d75b4cf401fe5a1556f4f0b7145a77ab 8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS Reviewed-by: serb, kizune ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.h ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TabButtonAccessibility.m Changeset: 564c8c63 Author: Daniel D. Daugherty Date: 2022-01-05 19:01:11 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/564c8c6390ee380ab2e2eb73ef22c3184c369f9f 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 8279532: ProblemList sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java Reviewed-by: jnimeh ! test/jdk/ProblemList.txt Changeset: 844dfb3a Author: Jesper Wilhelmsson Date: 2022-01-06 01:26:50 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/844dfb3ab6a1d8b68ccdcc73726ee0f73cfcb3c8 Merge ! src/hotspot/cpu/x86/x86.ad ! test/jdk/ProblemList.txt ! src/hotspot/cpu/x86/x86.ad ! test/jdk/ProblemList.txt Changeset: 456bd1ed Author: Vicente Romero Date: 2022-01-06 05:58:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/456bd1ed1cbfedc225194e9afb917b913e5bc9d5 8211004: javac is complaining about non-denotable types and refusing to generate the class file Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/langtools/tools/javac/8203436/T8203436a.java ! test/langtools/tools/javac/8203436/T8203436a.out ! test/langtools/tools/javac/8203436/T8203436b.out ! test/langtools/tools/javac/diags/examples.not-yet.txt ! test/langtools/tools/javac/diags/examples/IllegalSignature.java ! test/langtools/tools/javac/generics/diamond/neg/Neg21.out Changeset: 2dbb936d Author: Alan Bateman Date: 2022-01-06 08:12:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2dbb936da91a875a5a88da5d4c0b4956b9c6368f 8279339: (ch) Input/Output streams returned by Channels factory methods don't support concurrent read/write ops Reviewed-by: lancea, bpb ! src/java.base/share/classes/java/nio/channels/Channels.java ! src/java.base/share/classes/sun/nio/ch/ChannelInputStream.java ! src/java.base/share/classes/sun/nio/ch/ChannelOutputStream.java ! src/java.base/share/classes/sun/nio/ch/SocketAdaptor.java + src/java.base/share/classes/sun/nio/ch/SocketInputStream.java + src/java.base/share/classes/sun/nio/ch/SocketOutputStream.java + src/java.base/share/classes/sun/nio/ch/Streams.java + test/jdk/java/nio/channels/Channels/SocketChannelStreams.java Changeset: bc123811 Author: Aleksey Shipilev Date: 2022-01-06 08:27:54 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/bc12381105ef5ba14f99304a220817e97c9a99b5 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT Reviewed-by: erikj, serb ! doc/testing.html ! doc/testing.md Changeset: 8703f148 Author: Jatin Bhateja Date: 2022-01-06 18:41:06 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8703f14808d7256d4b07e7ea8a232889bbca4894 8273322: Enhance macro logic optimization for masked logic operations. Reviewed-by: kvn, sviswanathan ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/matcher.cpp ! src/hotspot/share/opto/vectornode.cpp ! src/hotspot/share/opto/vectornode.hpp + test/hotspot/jtreg/compiler/vectorapi/TestMaskedMacroLogicVector.java + test/micro/org/openjdk/bench/jdk/incubator/vector/MaskedLogicOpts.java ! test/micro/org/openjdk/bench/vm/compiler/MacroLogicOpt.java Changeset: b3dbfc64 Author: Phil Race Date: 2022-01-06 19:06:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b3dbfc645283cb315016ec531ec41570ab3f75f1 4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate Reviewed-by: serb ! src/java.desktop/share/classes/sun/print/PSStreamPrintService.java + test/jdk/javax/print/attribute/StreamServiceAttributeTest.java Changeset: 8d0f385f Author: Weijun Wang Date: 2022-01-06 22:02:55 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8d0f385fd0243c3e38b400f463b8d9727b0a5956 8279520: SPNEGO has not passed channel binding info into the underlying mechanism Reviewed-by: mullan, valeriep ! src/java.security.jgss/share/classes/sun/security/jgss/spnego/SpNegoContext.java ! test/jdk/sun/security/krb5/auto/IgnoreChannelBinding.java Changeset: 6a42fbaf Author: Jie Fu Date: 2022-01-07 00:04:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6a42fbaf9b87c69e72fd1a8053431c3f24e8875e 8279258: Auto-vectorization enhancement for two-dimensional array operations Reviewed-by: neliasso, kvn ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.hpp + test/hotspot/jtreg/compiler/c2/irTests/TestAutoVectorization2DArray.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java + test/micro/org/openjdk/bench/vm/compiler/AutoVectorization2DArray.java Changeset: 78f48a22 Author: Fei Yang Date: 2022-01-06 22:21:12 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/78f48a22a92f94fb90cfe4fce68cd4c31153a948 Merge branch 'master' into riscv-port From fjiang at openjdk.java.net Fri Jan 7 06:14:13 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 7 Jan 2022 06:14:13 GMT Subject: [riscv-port] RFR: 8279565: riscv: RVB: Add byte reverse instruction [v3] In-Reply-To: References: Message-ID: > This PR has the following changes: > 1. Implement byte-reverse instruction `rev8` of RISC-V BitManipulation Extension. > 2. Code improvement of existing byte reverse methods. > 3. Merge assembler_riscv_b.hpp and assembler_riscv_v.hpp into assembler_riscv.hpp > > Renaming of byte reverse methods is based on BitManipulation v0.93 [[1]], which provides `rev8.h`, `rev8.w` and `rev8` to reverse bytes in halfwords, words, and doubleword respectively. However, there are still some byte reverse operations that are not covered by spec, for example, "reverse bytes in halfword in lower 16 bits and sign extend". Base on the existing instructions naming style, we use `rev8.h.h` to represent it. > > New C2 instructions under riscv_b.ad are covered by the following JTREG tests: > - test/hotspot/jtreg/compiler/codegen/Test6431242.java > - test/hotspot/jtreg/compiler/c2/TestCharShortByteSwap.java > > Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. > > [1]: https://github.com/riscv/riscv-bitmanip/releases/download/v0.93/bitmanip-0.93.pdf Feilong Jiang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8279565: riscv: RVB: Add byte reverse instruction ------------- Changes: https://git.openjdk.java.net/riscv-port/pull/42/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=42&range=02 Stats: 1845 lines in 10 files changed: 877 ins; 865 del; 103 mod Patch: https://git.openjdk.java.net/riscv-port/pull/42.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/42/head:pull/42 PR: https://git.openjdk.java.net/riscv-port/pull/42 From fjiang at openjdk.java.net Fri Jan 7 06:18:33 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 7 Jan 2022 06:18:33 GMT Subject: [riscv-port] RFR: 8279565: riscv: RVB: Add byte reverse instruction [v3] In-Reply-To: References: Message-ID: On Fri, 7 Jan 2022 06:14:13 GMT, Feilong Jiang wrote: >> This PR has the following changes: >> 1. Implement byte-reverse instruction `rev8` of RISC-V BitManipulation Extension. >> 2. Code improvement of existing byte reverse methods. >> 3. Merge assembler_riscv_b.hpp and assembler_riscv_v.hpp into assembler_riscv.hpp >> >> Renaming of byte reverse methods is based on BitManipulation v0.93 [[1]], which provides `rev8.h`, `rev8.w` and `rev8` to reverse bytes in halfwords, words, and doubleword respectively. However, there are still some byte reverse operations that are not covered by spec, for example, "reverse bytes in halfword in lower 16 bits and sign extend". Base on the existing instructions naming style, we use `rev8.h.h` to represent it. >> >> New C2 instructions under riscv_b.ad are covered by the following JTREG tests: >> - test/hotspot/jtreg/compiler/codegen/Test6431242.java >> - test/hotspot/jtreg/compiler/c2/TestCharShortByteSwap.java >> >> Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. >> >> [1]: https://github.com/riscv/riscv-bitmanip/releases/download/v0.93/bitmanip-0.93.pdf > > Feilong Jiang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8279565: riscv: RVB: Add byte reverse instruction Rebased riscv-port branch with no conflicts. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/42 From fyang at openjdk.java.net Fri Jan 7 07:25:32 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 7 Jan 2022 07:25:32 GMT Subject: [riscv-port] RFR: 8279565: riscv: RVB: Add byte reverse instruction [v3] In-Reply-To: References: Message-ID: On Fri, 7 Jan 2022 06:14:13 GMT, Feilong Jiang wrote: >> This PR has the following changes: >> 1. Implement byte-reverse instruction `rev8` of RISC-V BitManipulation Extension. >> 2. Code improvement of existing byte reverse methods. >> 3. Merge assembler_riscv_b.hpp and assembler_riscv_v.hpp into assembler_riscv.hpp >> >> Renaming of byte reverse methods is based on BitManipulation v0.93 [[1]], which provides `rev8.h`, `rev8.w` and `rev8` to reverse bytes in halfwords, words, and doubleword respectively. However, there are still some byte reverse operations that are not covered by spec, for example, "reverse bytes in halfword in lower 16 bits and sign extend". Base on the existing instructions naming style, we use `rev8.h.h` to represent it. >> >> New C2 instructions under riscv_b.ad are covered by the following JTREG tests: >> - test/hotspot/jtreg/compiler/codegen/Test6431242.java >> - test/hotspot/jtreg/compiler/c2/TestCharShortByteSwap.java >> >> Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. >> >> [1]: https://github.com/riscv/riscv-bitmanip/releases/download/v0.93/bitmanip-0.93.pdf > > Feilong Jiang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8279565: riscv: RVB: Add byte reverse instruction Looks good. Thanks. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/42 From fjiang at openjdk.java.net Fri Jan 7 07:30:31 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 7 Jan 2022 07:30:31 GMT Subject: [riscv-port] RFR: 8279565: riscv: RVB: Add byte reverse instruction [v3] In-Reply-To: References: Message-ID: On Fri, 7 Jan 2022 06:14:13 GMT, Feilong Jiang wrote: >> This PR has the following changes: >> 1. Implement byte-reverse instruction `rev8` of RISC-V BitManipulation Extension. >> 2. Code improvement of existing byte reverse methods. >> 3. Merge assembler_riscv_b.hpp and assembler_riscv_v.hpp into assembler_riscv.hpp >> >> Renaming of byte reverse methods is based on BitManipulation v0.93 [[1]], which provides `rev8.h`, `rev8.w` and `rev8` to reverse bytes in halfwords, words, and doubleword respectively. However, there are still some byte reverse operations that are not covered by spec, for example, "reverse bytes in halfword in lower 16 bits and sign extend". Base on the existing instructions naming style, we use `rev8.h.h` to represent it. >> >> New C2 instructions under riscv_b.ad are covered by the following JTREG tests: >> - test/hotspot/jtreg/compiler/codegen/Test6431242.java >> - test/hotspot/jtreg/compiler/c2/TestCharShortByteSwap.java >> >> Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. >> >> [1]: https://github.com/riscv/riscv-bitmanip/releases/download/v0.93/bitmanip-0.93.pdf > > Feilong Jiang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8279565: riscv: RVB: Add byte reverse instruction Thanks for your reviews, Felix. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/42 From fjiang at openjdk.java.net Fri Jan 7 07:34:35 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 7 Jan 2022 07:34:35 GMT Subject: [riscv-port] Integrated: 8279565: riscv: RVB: Add byte reverse instruction In-Reply-To: References: Message-ID: On Fri, 7 Jan 2022 01:22:01 GMT, Feilong Jiang wrote: > This PR has the following changes: > 1. Implement byte-reverse instruction `rev8` of RISC-V BitManipulation Extension. > 2. Code improvement of existing byte reverse methods. > 3. Merge assembler_riscv_b.hpp and assembler_riscv_v.hpp into assembler_riscv.hpp > > Renaming of byte reverse methods is based on BitManipulation v0.93 [[1]], which provides `rev8.h`, `rev8.w` and `rev8` to reverse bytes in halfwords, words, and doubleword respectively. However, there are still some byte reverse operations that are not covered by spec, for example, "reverse bytes in halfword in lower 16 bits and sign extend". Base on the existing instructions naming style, we use `rev8.h.h` to represent it. > > New C2 instructions under riscv_b.ad are covered by the following JTREG tests: > - test/hotspot/jtreg/compiler/codegen/Test6431242.java > - test/hotspot/jtreg/compiler/c2/TestCharShortByteSwap.java > > Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. > > [1]: https://github.com/riscv/riscv-bitmanip/releases/download/v0.93/bitmanip-0.93.pdf This pull request has now been integrated. Changeset: c7944edf Author: Feilong Jiang Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/c7944edf3626c9167ca77f05b1dfd53d3d98e062 Stats: 1845 lines in 10 files changed: 877 ins; 865 del; 103 mod 8279565: riscv: RVB: Add byte reverse instruction Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/42 From xlinzheng at openjdk.java.net Fri Jan 7 08:36:47 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Fri, 7 Jan 2022 08:36:47 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v10] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - Move RVC code to the proper location after rebasing (#42) - Rename misc functions and change the positions of some comments - Remove remaining macros as discussions - Remain an 'minimum_alignment' unchanged - Manually inline all macros into functions as discussions - Remove assembler_riscv_c.hpp as discussions - Remove COMPRESSIBLE & NOT_COMPRESSIBLE macros by adding one layer as discussions - Fix remaining CEXT -> RVC - Remove Alignment-related changes as discussions - Update licenses to the new year - ... and 4 more: https://git.openjdk.java.net/riscv-port/compare/c7944edf...2a6ff151 ------------- Changes: https://git.openjdk.java.net/riscv-port/pull/34/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=09 Stats: 1255 lines in 12 files changed: 1171 ins; 10 del; 74 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Sat Jan 8 11:18:04 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Sat, 8 Jan 2022 11:18:04 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v10] In-Reply-To: References: Message-ID: On Fri, 7 Jan 2022 08:36:47 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: > > - Move RVC code to the proper location after rebasing (#42) > - Rename misc functions and change the positions of some comments > - Remove remaining macros as discussions > - Remain an 'minimum_alignment' unchanged > - Manually inline all macros into functions as discussions > - Remove assembler_riscv_c.hpp as discussions > - Remove COMPRESSIBLE & NOT_COMPRESSIBLE macros by adding one layer as discussions > - Fix remaining CEXT -> RVC > - Remove Alignment-related changes as discussions > - Update licenses to the new year > - ... and 4 more: https://git.openjdk.java.net/riscv-port/compare/c7944edf...2a6ff151 src/hotspot/cpu/riscv/assembler_riscv.hpp line 2053: > 2051: > 2052: // RVC: extract a 16-bit instruction. > 2053: static inline uint16_t c_extract(uint16_t val, unsigned msb, unsigned lsb) { Looks like c_extract and c_sextract are not used? src/hotspot/cpu/riscv/assembler_riscv.hpp line 2409: > 2407: } > 2408: > 2409: #define IF(BOOL, ...) IF_##BOOL(__VA_ARGS__) maybe better to expand those macros directly? src/hotspot/cpu/riscv/riscv.ad line 1194: > 1192: > 1193: // RVC: With RVC a call may get 2-byte aligned. > 1194: // The offset encoding in jal ranges bits [12, 31], which could span the cache line. Maybe rephrasing like this: // The offset encoding in jal ranges bits [12, 31] could span the cache line. src/hotspot/cpu/riscv/riscv.ad line 1204: > 1202: } > 1203: > 1204: // RVC: With RVC a call may get 2-byte aligned. Looks like this comment dupliates the one for CallStaticJavaDirectNode::compute_padding. src/hotspot/cpu/riscv/vm_version_riscv.cpp line 109: > 107: } > 108: > 109: // compressed instruction extension I think this should better to place this one after UseRVV and UseRVB. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Mon Jan 10 01:26:54 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 10 Jan 2022 01:26:54 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v10] In-Reply-To: References: Message-ID: On Fri, 7 Jan 2022 08:36:47 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: > > - Move RVC code to the proper location after rebasing (#42) > - Rename misc functions and change the positions of some comments > - Remove remaining macros as discussions > - Remain an 'minimum_alignment' unchanged > - Manually inline all macros into functions as discussions > - Remove assembler_riscv_c.hpp as discussions > - Remove COMPRESSIBLE & NOT_COMPRESSIBLE macros by adding one layer as discussions > - Fix remaining CEXT -> RVC > - Remove Alignment-related changes as discussions > - Update licenses to the new year > - ... and 4 more: https://git.openjdk.java.net/riscv-port/compare/c7944edf...2a6ff151 src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp line 245: > 243: // RVC: RISCV's amoswap instructions need an alignment for the memory address it swaps > 244: // when we reach here we may get a 2-byte alignment so need to align it > 245: __ align(4, nmethod_barrier_guard_offset()); Is it necessary to pass nmethod_barrier_guard_offset() as the "extra_offset" parameter here since this function will return (12 * instruction_size) which is multiple of 4 ? src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 2954: > 2952: // 8 byte aligned after 3 intructions > 2953: // RVC: when we reach here we may get a 2-byte alignment so need to align it > 2954: align(wordSize, NativeCallTrampolineStub::data_offset); Same question: Is there a reason to pass "NativeCallTrampolineStub::data_offset" as the "extra_offset" parameter here since this function will return (3 * NativeInstruction::instruction_size) which is multiple of 4 ? ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Mon Jan 10 03:04:38 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 10 Jan 2022 03:04:38 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v11] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: Remove useless and polish comments ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/34/files - new: https://git.openjdk.java.net/riscv-port/pull/34/files/2a6ff151..70ddc0b3 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=10 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=09-10 Stats: 46 lines in 4 files changed: 5 ins; 27 del; 14 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Mon Jan 10 03:04:40 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 10 Jan 2022 03:04:40 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v10] In-Reply-To: References: Message-ID: On Sat, 8 Jan 2022 11:09:59 GMT, Fei Yang wrote: >> Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: >> >> - Move RVC code to the proper location after rebasing (#42) >> - Rename misc functions and change the positions of some comments >> - Remove remaining macros as discussions >> - Remain an 'minimum_alignment' unchanged >> - Manually inline all macros into functions as discussions >> - Remove assembler_riscv_c.hpp as discussions >> - Remove COMPRESSIBLE & NOT_COMPRESSIBLE macros by adding one layer as discussions >> - Fix remaining CEXT -> RVC >> - Remove Alignment-related changes as discussions >> - Update licenses to the new year >> - ... and 4 more: https://git.openjdk.java.net/riscv-port/compare/c7944edf...2a6ff151 > > src/hotspot/cpu/riscv/assembler_riscv.hpp line 2053: > >> 2051: >> 2052: // RVC: extract a 16-bit instruction. >> 2053: static inline uint16_t c_extract(uint16_t val, unsigned msb, unsigned lsb) { > > Looks like c_extract and c_sextract are not used? Thanks for pointing out this - this seems to be inherited from the original patch (the version that we decode instructions in `emit()`) and they seem to be not used anymore and I have removed them. > src/hotspot/cpu/riscv/riscv.ad line 1194: > >> 1192: >> 1193: // RVC: With RVC a call may get 2-byte aligned. >> 1194: // The offset encoding in jal ranges bits [12, 31], which could span the cache line. > > Maybe rephrasing like this: > // The offset encoding in jal ranges bits [12, 31] could span the cache line. done. Thanks for polishing the sentence. > src/hotspot/cpu/riscv/riscv.ad line 1204: > >> 1202: } >> 1203: >> 1204: // RVC: With RVC a call may get 2-byte aligned. > > Looks like this comment dupliates the one for CallStaticJavaDirectNode::compute_padding. done. > src/hotspot/cpu/riscv/vm_version_riscv.cpp line 109: > >> 107: } >> 108: >> 109: // compressed instruction extension > > I think this should better to place this one after UseRVV and UseRVB. done. Thanks for pointing out this. It is inherited from my original patch and it indeed needs to be moved downward to keep the consistency. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Mon Jan 10 03:08:03 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 10 Jan 2022 03:08:03 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v10] In-Reply-To: References: Message-ID: <9oBbBecylptxxoZ00fmSeuOgf47D5izoeXyoGzjL6aM=.6a279922-5760-4492-82f0-2e2bd5cf993b@github.com> On Sat, 8 Jan 2022 11:11:21 GMT, Fei Yang wrote: >> Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: >> >> - Move RVC code to the proper location after rebasing (#42) >> - Rename misc functions and change the positions of some comments >> - Remove remaining macros as discussions >> - Remain an 'minimum_alignment' unchanged >> - Manually inline all macros into functions as discussions >> - Remove assembler_riscv_c.hpp as discussions >> - Remove COMPRESSIBLE & NOT_COMPRESSIBLE macros by adding one layer as discussions >> - Fix remaining CEXT -> RVC >> - Remove Alignment-related changes as discussions >> - Update licenses to the new year >> - ... and 4 more: https://git.openjdk.java.net/riscv-port/compare/c7944edf...2a6ff151 > > src/hotspot/cpu/riscv/assembler_riscv.hpp line 2409: > >> 2407: } >> 2408: >> 2409: #define IF(BOOL, ...) IF_##BOOL(__VA_ARGS__) > > maybe better to expand those macros directly? Unfortunately, this could not be easily done by substituting by a simple `assert_cond(!CHECK_RD || Rd != x0);` because of some details: `c_ldsp` and `c_fldsp` use `Register` and `FloatRegister` separately so there is a type-related problem: x0 is only one `Register` and only `c_ldsp` needs this sanity check. So these macros here are trying to make sure this check isn't generated by `c_fldsp` at all because checking `Rd(a float register) != x0` will result in compilation errors. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Mon Jan 10 03:21:03 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 10 Jan 2022 03:21:03 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v10] In-Reply-To: <9oBbBecylptxxoZ00fmSeuOgf47D5izoeXyoGzjL6aM=.6a279922-5760-4492-82f0-2e2bd5cf993b@github.com> References: <9oBbBecylptxxoZ00fmSeuOgf47D5izoeXyoGzjL6aM=.6a279922-5760-4492-82f0-2e2bd5cf993b@github.com> Message-ID: On Mon, 10 Jan 2022 03:04:25 GMT, Xiaolin Zheng wrote: >> src/hotspot/cpu/riscv/assembler_riscv.hpp line 2409: >> >>> 2407: } >>> 2408: >>> 2409: #define IF(BOOL, ...) IF_##BOOL(__VA_ARGS__) >> >> maybe better to expand those macros directly? > > Unfortunately, this could not be easily done by substituting by a simple `assert_cond(!CHECK_RD || Rd != x0);` because of some details: > `c_ldsp` and `c_fldsp` use `Register` and `FloatRegister` separately so there is a type-related problem: x0 is only one `Register` and only `c_ldsp` needs this sanity check. So these macros here are trying to make sure this check isn't generated by `c_fldsp` at all because checking `Rd(a float register) != x0` will result in compilation errors. Yes, I know the issue you are trying to resolve. Actually, I prefer to have two INSN macro definitions here: one for the integer case and one for the floating point case. That will be cleaner. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Mon Jan 10 03:47:35 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 10 Jan 2022 03:47:35 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v12] In-Reply-To: References: Message-ID: <7iW2JdaFY-lZYDOzH-uJyQueAHBvWEXySx4UM1-B0I4=.d84ee84a-5d1d-47fd-9227-e9d122daecee@github.com> > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: Split c_ldsp and c_fldsp ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/34/files - new: https://git.openjdk.java.net/riscv-port/pull/34/files/70ddc0b3..f9caca8d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=11 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=10-11 Stats: 25 lines in 1 file changed: 14 ins; 4 del; 7 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Mon Jan 10 03:47:36 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 10 Jan 2022 03:47:36 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v10] In-Reply-To: References: <9oBbBecylptxxoZ00fmSeuOgf47D5izoeXyoGzjL6aM=.6a279922-5760-4492-82f0-2e2bd5cf993b@github.com> Message-ID: On Mon, 10 Jan 2022 03:17:48 GMT, Fei Yang wrote: >> Unfortunately, this could not be easily done by substituting by a simple `assert_cond(!CHECK_RD || Rd != x0);` because of some details: >> `c_ldsp` and `c_fldsp` use `Register` and `FloatRegister` separately so there is a type-related problem: x0 is only one `Register` and only `c_ldsp` needs this sanity check. So these macros here are trying to make sure this check isn't generated by `c_fldsp` at all because checking `Rd(a float register) != x0` will result in compilation errors. > > Yes, I know the issue you are trying to resolve. Actually, I prefer to have two INSN macro definitions here: one for the integer case and one for the floating point case. That will be cleaner. done - thanks for the suggestions of splitting the two macros. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Mon Jan 10 03:47:37 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 10 Jan 2022 03:47:37 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v10] In-Reply-To: References: Message-ID: On Mon, 10 Jan 2022 01:20:58 GMT, Fei Yang wrote: >> Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: >> >> - Move RVC code to the proper location after rebasing (#42) >> - Rename misc functions and change the positions of some comments >> - Remove remaining macros as discussions >> - Remain an 'minimum_alignment' unchanged >> - Manually inline all macros into functions as discussions >> - Remove assembler_riscv_c.hpp as discussions >> - Remove COMPRESSIBLE & NOT_COMPRESSIBLE macros by adding one layer as discussions >> - Fix remaining CEXT -> RVC >> - Remove Alignment-related changes as discussions >> - Update licenses to the new year >> - ... and 4 more: https://git.openjdk.java.net/riscv-port/compare/c7944edf...2a6ff151 > > src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp line 245: > >> 243: // RVC: RISCV's amoswap instructions need an alignment for the memory address it swaps >> 244: // when we reach here we may get a 2-byte alignment so need to align it >> 245: __ align(4, nmethod_barrier_guard_offset()); > > Is it necessary to pass nmethod_barrier_guard_offset() as the "extra_offset" parameter here since this function will return (12 * instruction_size) which is multiple of 4 ? Yes - it seems a little obscure though. 1. The background is that: about the `nmethod_entry_barrier`: nmethod_entry_barrier (begin) { <- when we reach here, we may get a 2-byte alignment because of RVC's existence. ... amoswap <- though the size of the whole stub is a multiple of 4 currently, here we may also get a 2-byte alignment because of the above issue. } nmethod_entry_barrier (end) and about the trampoline: trampoline (begin) { <- when we reach here, we may get a 2-byte alignment because of RVC's existence. auipc ld jalr <- same as the above explanation. } trampline (end) 2. The reason to pass another argument is that: we might consider just keeping the start address of the code slices (nmethod_entry_barrier and trampoline) aligned to 4-byte to solve this issue, but this assumption is based on 'the size of the code slices (nmethod_entry_barrier and trampoline themselves) are a multiple of 4', and we don't know if they will change in the future by RVC. So I explicitly pass the real target address to the `align` function as a new argument to make sure the code is always right in the future. I am pleased with other suggestions for this part. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Mon Jan 10 06:49:44 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 10 Jan 2022 06:49:44 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v10] In-Reply-To: References: Message-ID: On Mon, 10 Jan 2022 03:32:43 GMT, Xiaolin Zheng wrote: >> src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp line 245: >> >>> 243: // RVC: RISCV's amoswap instructions need an alignment for the memory address it swaps >>> 244: // when we reach here we may get a 2-byte alignment so need to align it >>> 245: __ align(4, nmethod_barrier_guard_offset()); >> >> Is it necessary to pass nmethod_barrier_guard_offset() as the "extra_offset" parameter here since this function will return (12 * instruction_size) which is multiple of 4 ? > > Yes - it seems a little obscure though. > > 1. The background is that: > > about the `nmethod_entry_barrier`: > > nmethod_entry_barrier (begin) { <- when we reach here, we may get a 2-byte alignment because of RVC's existence. > ... > amoswap > <- though the size of the whole stub is a multiple of 4 currently, > here we may also get a 2-byte alignment because of the above issue. > } nmethod_entry_barrier (end) > > > and about the trampoline: > > trampoline (begin) { <- when we reach here, we may get a 2-byte alignment because of RVC's existence. > auipc > ld > jalr > <- same as the above explanation. > } trampline (end) > > > 2. The reason to pass another argument is that: > > we might consider just keeping the start address of the code slices (nmethod_entry_barrier and trampoline) aligned to 4-byte to solve this issue, but this assumption is based on 'the size of the code slices (nmethod_entry_barrier and trampoline themselves) are a multiple of 4', and we don't know if they will change in the future by RVC. So I explicitly pass the real target address to the `align` function as a new argument to make sure the code is always right in the future. > > I am pleased with other suggestions for this part. For the nmethod_entry_barrier case, I would omit the extra_offset parameter (and also the nmethod_barrier_guard_offset funtion). I think your newly-added assertion at line 265 is enough. But looks like it's different in the trampoline case where I see we need a wordSize (8bytes) alignment. So we may keep the change for this case. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Mon Jan 10 07:01:54 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 10 Jan 2022 07:01:54 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v10] In-Reply-To: References: Message-ID: On Mon, 10 Jan 2022 06:46:59 GMT, Fei Yang wrote: >> Yes - it seems a little obscure though. >> >> 1. The background is that: >> >> about the `nmethod_entry_barrier`: >> >> nmethod_entry_barrier (begin) { <- when we reach here, we may get a 2-byte alignment because of RVC's existence. >> ... >> amoswap >> <- though the size of the whole stub is a multiple of 4 currently, >> here we may also get a 2-byte alignment because of the above issue. >> } nmethod_entry_barrier (end) >> >> >> and about the trampoline: >> >> trampoline (begin) { <- when we reach here, we may get a 2-byte alignment because of RVC's existence. >> auipc >> ld >> jalr >> <- same as the above explanation. >> } trampline (end) >> >> >> 2. The reason to pass another argument is that: >> >> we might consider just keeping the start address of the code slices (nmethod_entry_barrier and trampoline) aligned to 4-byte to solve this issue, but this assumption is based on 'the size of the code slices (nmethod_entry_barrier and trampoline themselves) are a multiple of 4', and we don't know if they will change in the future by RVC. So I explicitly pass the real target address to the `align` function as a new argument to make sure the code is always right in the future. >> >> I am pleased with other suggestions for this part. > > For the nmethod_entry_barrier case, I would omit the extra_offset parameter (and also the nmethod_barrier_guard_offset funtion). I think your newly-added assertion at line 265 is enough. > > But looks like it's different in the trampoline case where I see we need a wordSize (8bytes) alignment. So we may keep the change for this case. Yes, I agree with your point. That trampoline part is special and requires to be scrupulous to make changes. So maybe I'd better remove the `nmethod_barrier_guard_offset` part right? ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Mon Jan 10 07:18:18 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 10 Jan 2022 07:18:18 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v13] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: Remove `nmethod_entry_barrier`-related things ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/34/files - new: https://git.openjdk.java.net/riscv-port/pull/34/files/f9caca8d..c0c4416b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=12 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=11-12 Stats: 16 lines in 2 files changed: 0 ins; 13 del; 3 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Mon Jan 10 07:18:20 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 10 Jan 2022 07:18:20 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v10] In-Reply-To: References: Message-ID: On Mon, 10 Jan 2022 06:57:05 GMT, Xiaolin Zheng wrote: >> For the nmethod_entry_barrier case, I would omit the extra_offset parameter (and also the nmethod_barrier_guard_offset funtion). I think your newly-added assertion at line 265 is enough. >> >> But looks like it's different in the trampoline case where I see we need a wordSize (8bytes) alignment. So we may keep the change for this case. > > Yes, I agree with your point. That trampoline part is special and requires to be scrupulous to make changes. > > So maybe I'd better remove the `nmethod_barrier_guard_offset` part right? Yes. Please also update the code comments. It looks strange to find those comments starts with a "RVC:". Also we should make the exact alignment required explicit in comments like: "RISCV's amoswap instructions need an alignment for the memory address it swaps" or "RISCV CAS needs an alignment for memory", etc. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From duke at openjdk.java.net Mon Jan 10 07:28:51 2022 From: duke at openjdk.java.net (duke) Date: Mon, 10 Jan 2022 07:28:51 GMT Subject: git: openjdk/riscv-port: riscv-port: 7 new changesets Message-ID: <1c809b67-5d96-40bb-b2f1-f1894a46a298@openjdk.java.net> Changeset: 62d03c28 Author: Quan Anh Mai Committer: Vladimir Kozlov Date: 2022-01-07 03:22:34 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/62d03c283667c4122130ec9bbeec623e6a2840e5 8279547: [vectorapi] Enable vector cast tests after JDK-8278948 Reviewed-by: kvn ! test/hotspot/jtreg/compiler/vectorapi/reshape/utils/TestCastMethods.java Changeset: 4243f4c9 Author: Zhengyu Gu Date: 2022-01-07 13:33:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4243f4c998344e77dccd4d5605e56e869bc8af89 8279540: Shenandoah: Should only clear CLD::_claim_strong mark for strong CLD iterations Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp Changeset: d47af74e Author: Ioi Lam Date: 2022-01-07 18:38:47 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d47af74e4c98c9fc4aef537c6d8eeb66a1621586 8279500: Remove FileMapHeader::_heap_obj_roots Reviewed-by: minqi, ccheung ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/cds/filemap.hpp ! src/hotspot/share/cds/heapShared.cpp ! src/hotspot/share/cds/heapShared.hpp ! src/hotspot/share/cds/metaspaceShared.cpp ! src/hotspot/share/include/cds.h Changeset: f203723f Author: Sergey Bylokhov Date: 2022-01-08 01:02:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f203723fc72c5d92c8745d4c595f360a9b50c512 8279337: The MToolkit is still referenced in a few places Reviewed-by: prr ! src/java.desktop/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/java.desktop/share/classes/sun/awt/SunToolkit.java ! src/java.desktop/unix/classes/sun/awt/X11GraphicsEnvironment.java ! src/java.desktop/unix/classes/sun/java2d/opengl/GLXGraphicsConfig.java ! src/java.desktop/unix/native/common/awt/awt.h ! test/jdk/java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.java ! test/jdk/java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java ! test/jdk/java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusSetVisibleTest.java ! test/jdk/java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusToFrontTest.java ! test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.java ! test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.java ! test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.java ! test/jdk/java/awt/Focus/SimpleWindowActivationTest/SimpleWindowActivationTest.java ! test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.java ! test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java ! test/jdk/java/awt/Robot/AcceptExtraMouseButtons/AcceptExtraMouseButtons.java ! test/jdk/java/awt/Window/GrabSequence/GrabSequence.java ! test/jdk/java/awt/regtesthelpers/Util.java Changeset: 77757ba9 Author: Sergey Bylokhov Date: 2022-01-08 01:03:34 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/77757ba974239b558e29c7adc551dfa04b9baa48 8225122: Test AncestorResized.java fails when Windows desktop is scaled. Reviewed-by: kizune, aivanov ! test/jdk/java/awt/event/HierarchyEvent/AncestorResized/AncestorResized.java Changeset: e14fb4f4 Author: Doug Simon Date: 2022-01-08 21:47:54 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e14fb4f4aa9c4569615005e474f897c54094f024 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM Reviewed-by: kvn ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/jvmci/jvmciEnv.cpp ! src/hotspot/share/jvmci/jvmciEnv.hpp ! src/hotspot/share/jvmci/jvmciJavaClasses.cpp ! src/hotspot/share/jvmci/jvmciJavaClasses.hpp ! src/hotspot/share/jvmci/vmSymbols_jvmci.hpp ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/TranslatedException.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestTranslatedException.java Changeset: 5b8cc18b Author: Fei Yang Date: 2022-01-10 02:24:11 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5b8cc18bce1a72ab965e463d42f3e871b2334095 Merge branch 'master' into riscv-port ! src/hotspot/cpu/riscv/riscv.ad + src/hotspot/cpu/riscv/riscv.ad From xlinzheng at openjdk.java.net Mon Jan 10 07:30:28 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 10 Jan 2022 07:30:28 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v14] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: Polish `nmethod_entry_barrier` and RISC-V CAS related comments ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/34/files - new: https://git.openjdk.java.net/riscv-port/pull/34/files/c0c4416b..aef57f3b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=13 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=12-13 Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Mon Jan 10 07:30:28 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 10 Jan 2022 07:30:28 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v10] In-Reply-To: References: Message-ID: On Mon, 10 Jan 2022 07:14:52 GMT, Fei Yang wrote: >> Yes, I agree with your point. That trampoline part is special and requires to be scrupulous to make changes. >> >> So maybe I'd better remove the `nmethod_barrier_guard_offset` part right? > > Yes. Please also update the code comments. It looks strange to find those comments starts with a "RVC:". > Also we should make the exact alignment required explicit in comments like: "RISCV's amoswap instructions need an alignment for the memory address it swaps" or "RISCV CAS needs an alignment for memory", etc. done - polished and it needs some testing works. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Mon Jan 10 08:47:06 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 10 Jan 2022 08:47:06 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v14] In-Reply-To: References: Message-ID: On Mon, 10 Jan 2022 07:30:28 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: > > Polish `nmethod_entry_barrier` and RISC-V CAS related comments Thanks for resolving the comments :-) We will need more tests for this patch, both in respects of functionality and performance. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From duke at openjdk.java.net Tue Jan 11 02:09:29 2022 From: duke at openjdk.java.net (duke) Date: Tue, 11 Jan 2022 02:09:29 GMT Subject: git: openjdk/riscv-port: riscv-port: 28 new changesets Message-ID: Changeset: 8d1a1e83 Author: Roland Westrelin Date: 2022-01-10 07:52:18 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8d1a1e83f40f7a147e033be6b2221c1bb1abd8ab 8278228: C2: Improve identical back-to-back if elimination Reviewed-by: chagedorn, kvn ! src/hotspot/share/opto/loopPredicate.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopUnswitch.cpp ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/loopopts.cpp ! src/hotspot/share/opto/split_if.cpp + test/hotspot/jtreg/compiler/c2/irTests/TestBackToBackIfs.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java Changeset: 2f8a2fd0 Author: Christian Hagedorn Date: 2022-01-10 08:17:36 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2f8a2fd077a2b9c88ab1823b52715278e26bbff1 8279568: IGV: Add bci and line number property for OSR compilations Reviewed-by: kvn, roland ! src/hotspot/share/opto/idealGraphPrinter.cpp Changeset: 4aefd8b8 Author: Aleksey Shipilev Date: 2022-01-10 08:30:39 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4aefd8b8b6cd76137e3bc51a84d1182fde22ba02 8279528: Unused TypeEnter.diag after JDK-8205187 Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TypeEnter.java Changeset: 5fa13bb4 Author: Albert Mingkun Yang Date: 2022-01-10 08:56:34 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5fa13bb4a39225c4345ee129b30fb08ad5fdff6d 8279522: Serial: Remove unused Generation::clear_remembered_set Reviewed-by: iwalulya, mli ! src/hotspot/share/gc/shared/cardGeneration.cpp ! src/hotspot/share/gc/shared/cardGeneration.hpp ! src/hotspot/share/gc/shared/generation.hpp Changeset: 79b614cc Author: Albert Mingkun Yang Date: 2022-01-10 08:57:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/79b614cc19454765eba17acd27d9772e7eaae1ee 8279523: Parallel: Remove unnecessary PSScavenge::_to_space_top_before_gc Reviewed-by: kbarrett, mli ! src/hotspot/share/gc/parallel/psScavenge.cpp ! src/hotspot/share/gc/parallel/psScavenge.hpp ! src/hotspot/share/gc/parallel/psScavenge.inline.hpp Changeset: 1f101b04 Author: Tobias Holenstein Committer: Tobias Hartmann Date: 2022-01-10 10:50:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1f101b04f4d7c166cc0a830383e4e08025df5c74 8278329: some TraceDeoptimization code not included in PRODUCT build Reviewed-by: dnsimon, kvn, never, thartmann ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/vframe.cpp ! src/hotspot/share/runtime/vframeArray.cpp Changeset: 6613ce64 Author: Sergey Nazarkin Committer: Aleksey Shipilev Date: 2022-01-10 11:54:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6613ce64d76a6cc40fd933b022834098721b8d23 8279300: [arm32] SIGILL when running GetObjectSizeIntrinsicsTest Reviewed-by: shade ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp Changeset: 4ff67205 Author: Harold Seigel Date: 2022-01-10 13:18:41 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4ff6720573f9b55eb397d1aac9b398228faf2ceb 8183227: read/write APIs in class os shall return ssize_t Reviewed-by: fparain, rehn ! src/hotspot/os/linux/attachListener_linux.cpp ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/posix/perfMemory_posix.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/jfr/writers/jfrStreamWriterHost.inline.hpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/os.hpp ! src/hotspot/share/services/heapDumperCompression.cpp ! src/hotspot/share/utilities/ostream.cpp Changeset: 11d88ce8 Author: Harold Seigel Date: 2022-01-10 13:57:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/11d88ce82efd72d3d63f7c7271c285cd21b01217 8218857: Confusing overloads for os::open Reviewed-by: kbarrett, rehn ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/cds/classListParser.cpp ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/runtime/os.hpp ! src/hotspot/share/utilities/vmError.cpp Changeset: 76477f8c Author: Coleen Phillimore Date: 2022-01-10 14:34:04 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/76477f8cdbc012f7ff0670ad57067ebf304612a0 8142362: Lots of code duplication in Copy class Reviewed-by: kvn, hseigel ! src/hotspot/cpu/aarch64/copy_aarch64.hpp ! src/hotspot/cpu/x86/copy_x86.hpp ! src/hotspot/os_cpu/bsd_aarch64/copy_bsd_aarch64.hpp ! src/hotspot/os_cpu/bsd_x86/bsd_x86_32.S ! src/hotspot/os_cpu/bsd_x86/copy_bsd_x86.hpp ! src/hotspot/os_cpu/linux_aarch64/copy_linux_aarch64.hpp ! src/hotspot/os_cpu/linux_arm/linux_arm_32.S ! src/hotspot/os_cpu/linux_x86/copy_linux_x86.hpp ! src/hotspot/os_cpu/linux_x86/linux_x86_32.S ! src/hotspot/os_cpu/windows_x86/copy_windows_x86.hpp ! src/hotspot/share/utilities/copy.hpp Changeset: debaa28e Author: Andrey Turbanov Committer: Weijun Wang Date: 2022-01-10 15:02:57 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/debaa28e9c0bcb01d0551df907a851bd1e1c3e78 8274679: Remove unnecessary conversion to String in security code in java.base Reviewed-by: weijun ! src/java.base/share/classes/java/security/cert/PKIXCertPathBuilderResult.java ! src/java.base/share/classes/java/security/cert/PKIXCertPathValidatorResult.java ! src/java.base/share/classes/java/security/cert/PKIXParameters.java ! src/java.base/share/classes/java/security/cert/TrustAnchor.java ! src/java.base/share/classes/java/security/cert/X509CertSelector.java ! src/java.base/share/classes/javax/crypto/Cipher.java ! src/java.base/share/classes/javax/crypto/CryptoPolicyParser.java ! src/java.base/share/classes/sun/security/provider/PolicyParser.java ! src/java.base/share/classes/sun/security/provider/certpath/Builder.java ! src/java.base/share/classes/sun/security/provider/certpath/ConstraintsChecker.java ! src/java.base/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/java.base/share/classes/sun/security/provider/certpath/ForwardState.java ! src/java.base/share/classes/sun/security/x509/CertificateIssuerExtension.java ! src/java.base/share/classes/sun/security/x509/InvalidityDateExtension.java Changeset: dee447f8 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2022-01-10 16:20:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/dee447f8ae788c6c1f6cd1e1fcb93faceab37b6c 8274809: Update java.base classes to use try-with-resources Reviewed-by: mullan, alanb, dfuchs ! src/java.base/share/classes/javax/crypto/SealedObject.java ! src/java.base/share/classes/sun/net/NetProperties.java ! src/java.base/share/classes/sun/net/www/MimeTable.java ! src/java.base/share/classes/sun/security/timestamp/HttpTimestamper.java ! src/java.base/share/classes/sun/security/tools/KeyStoreUtil.java ! src/java.base/share/classes/sun/security/util/PolicyUtil.java ! src/java.base/unix/classes/sun/net/sdp/SdpProvider.java Changeset: 7c792f27 Author: Fairoz Matte Committer: Erik Gahlin Date: 2022-01-06 14:20:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7c792f27a8f6ccf87922cc5f2768946e55e33816 8279333: Some JFR tests do not accept 'GCLocker Initiated GC' as a valid GC Cause Reviewed-by: egahlin ! test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithG1ConcurrentMark.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithG1FullCollection.java Changeset: 967ef0c4 Author: Ioi Lam Date: 2022-01-07 05:30:20 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/967ef0c48252957f9bec42965fe02414fd2c77cb 8278020: ~13% variation in Renaissance-Scrabble Backport-of: 4ba980ba439f94a6b5015e64382a6c308476d63f ! src/hotspot/share/oops/klass.hpp Changeset: d65c6658 Author: Maurizio Cimadamore Date: 2022-01-07 13:41:29 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d65c665839c0a564c422ef685f2673fac37315d7 8279527: Dereferencing segments backed by different scopes leads to pollution Reviewed-by: psandoz, jvernee ! src/java.base/share/classes/java/nio/Buffer.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/ConfinedScope.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/NativeSymbolImpl.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/ResourceScopeImpl.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/SharedScope.java ! test/jdk/java/foreign/TestByteBuffer.java ! test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverPollutedSegments.java Changeset: 642ab34a Author: Jan Lahoda Date: 2022-01-10 08:33:46 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/642ab34a60172f4b629f953e146b54b9c7269033 8278373: JavacTrees.searchMethod finds incorrect match Reviewed-by: vromero, jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTrees.java ! test/langtools/tools/javac/doctree/ReferenceTest.java Changeset: 8f969a13 Author: Jan Lahoda Date: 2022-01-10 09:30:55 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8f969a1362343df8592046a838436f41894ee471 8278930: javac tries to compile a file twice via PackageElement.getEnclosedElements Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java + test/langtools/tools/javac/processing/model/element/TestListPackageFromAPI.java Changeset: 06b4d494 Author: Matthias Baesken Date: 2022-01-10 11:41:14 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/06b4d494bf7bfec7db83351f0df372cba2b22bae 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output Backport-of: 8b5ff4bdffc8f32317d67b00c085071d6c772b30 ! test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java Changeset: 354c9047 Author: Hannes Walln?fer Date: 2022-01-10 12:04:01 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/354c9047987c0837d95440780993a0aa84551ea1 8273452: DocTrees.getDocCommentTree should be specified as idempotent Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/source/util/DocTrees.java Changeset: 928e3477 Author: Fairoz Matte Committer: Christian Hagedorn Date: 2022-01-10 12:36:05 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/928e34773694dda5373027848a3363887bcaf4f4 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4 Reviewed-by: chagedorn, thartmann ! test/hotspot/jtreg/compiler/loopopts/TestSkeletonPredicateNegation.java Changeset: ad34f03b Author: Vladimir Ivanov Date: 2022-01-10 13:56:01 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ad34f03b549e6f37825efc3e554d2232b557611a 8279515: C1: No inlining through invokedynamic and invokestatic call sites when resolved class is not linked Reviewed-by: kvn, dlong ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/ci/ciStreams.cpp ! src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java + test/hotspot/jtreg/compiler/inlining/ResolvedClassTest.java Changeset: 40df5df9 Author: Erik Gahlin Date: 2022-01-10 15:07:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/40df5df95edb67331d39d829b895094e961fe21f 8279398: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with "RuntimeException: getStopTime() > afterStop" Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/MetadataRepository.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/PlatformRecorder.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/Utils.java Changeset: d9b1bb58 Author: Jesper Wilhelmsson Date: 2022-01-10 17:06:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d9b1bb58600c03cee43387864d1530d4dd5f1422 Merge ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTrees.java ! test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTrees.java ! test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java Changeset: 0d190961 Author: Erik Gahlin Date: 2022-01-10 18:41:39 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0d190961f28fb670fab06838dba69ec7a20c2fb9 8279642: JFR: Remove unnecessary creation of Duration and Instant objects Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordedEvent.java ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordedObject.java Changeset: d7e6e9bd Author: Erik Gahlin Date: 2022-01-10 18:58:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d7e6e9bd0b0ed819bf04454397cfb45ee82c3a9f 8279643: JFR: Explain why path is sometimes missing from FileRead and FileWrite events Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/events/FileReadEvent.java ! src/jdk.jfr/share/classes/jdk/jfr/events/FileWriteEvent.java Changeset: 4471e951 Author: Erik Gahlin Date: 2022-01-10 19:52:26 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4471e95174a89d83794ed894c2a1bb3fc9def74d 8279645: JFR: The cacheEventType in Dispatcher is never assigned Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/Dispatcher.java Changeset: 2f7665b8 Author: Yasumasa Suenaga Date: 2022-01-11 00:21:20 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2f7665b8292cc09574d62fecc3e9619c488ac137 8279644: hsdis may not work when it was built with --with-binutils=system Reviewed-by: erikj ! make/autoconf/jdk-options.m4 Changeset: e2ef978d Author: Fei Yang Date: 2022-01-10 21:05:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e2ef978d427e0ee532aaa21d90e7c7d227adaef9 Merge branch 'master' into riscv-port ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp ! src/hotspot/cpu/riscv/assembler_riscv.cpp ! src/hotspot/cpu/riscv/assembler_riscv.hpp ! src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp ! src/hotspot/cpu/riscv/c1_LIRGenerator_riscv.cpp ! src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/copy_riscv.hpp ! src/hotspot/cpu/riscv/frame_riscv.inline.hpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/nativeInst_riscv.cpp ! src/hotspot/cpu/riscv/relocInfo_riscv.cpp ! src/hotspot/cpu/riscv/riscv.ad ! src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp ! src/hotspot/cpu/riscv/vmreg_riscv.inline.hpp ! src/hotspot/os_cpu/linux_riscv/copy_linux_riscv.hpp ! src/hotspot/os_cpu/linux_riscv/os_linux_riscv.cpp ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp + src/hotspot/cpu/riscv/assembler_riscv.cpp + src/hotspot/cpu/riscv/assembler_riscv.hpp + src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp + src/hotspot/cpu/riscv/c1_LIRGenerator_riscv.cpp + src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp + src/hotspot/cpu/riscv/copy_riscv.hpp + src/hotspot/cpu/riscv/frame_riscv.inline.hpp + src/hotspot/cpu/riscv/macroAssembler_riscv.cpp + src/hotspot/cpu/riscv/nativeInst_riscv.cpp + src/hotspot/cpu/riscv/relocInfo_riscv.cpp + src/hotspot/cpu/riscv/riscv.ad + src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp + src/hotspot/cpu/riscv/vmreg_riscv.inline.hpp + src/hotspot/os_cpu/linux_riscv/copy_linux_riscv.hpp + src/hotspot/os_cpu/linux_riscv/os_linux_riscv.cpp From fjiang at openjdk.java.net Tue Jan 11 07:24:21 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Tue, 11 Jan 2022 07:24:21 GMT Subject: [riscv-port] RFR: 8279827: riscv: RVB: Add shift and add instructions Message-ID: This PR implements shift left and add instructions: `sh1add`/`sh2add`/`sh3add`/`sh1add.uw`/`sh2add.uw`/`sh3add.uw`. ------------- Commit messages: - 8279827: riscv: RVB: Add shift and add instructions Changes: https://git.openjdk.java.net/riscv-port/pull/43/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=43&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279827 Stats: 508 lines in 14 files changed: 259 ins; 107 del; 142 mod Patch: https://git.openjdk.java.net/riscv-port/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/43/head:pull/43 PR: https://git.openjdk.java.net/riscv-port/pull/43 From fjiang at openjdk.java.net Tue Jan 11 12:33:27 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Tue, 11 Jan 2022 12:33:27 GMT Subject: [riscv-port] RFR: 8279827: riscv: RVB: Add shift and add instructions [v2] In-Reply-To: References: Message-ID: > This PR implements shift left and add instructions: `sh1add`/`sh2add`/`sh3add`/`sh1add.uw`/`sh2add.uw`/`sh3add.uw`. > > New C2 instructions are covered by JTREG test: test/jdk/java/lang Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: match iRegI instead of iRegIorL2I ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/43/files - new: https://git.openjdk.java.net/riscv-port/pull/43/files/3329fc67..bb1b8580 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=43&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=43&range=00-01 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/riscv-port/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/43/head:pull/43 PR: https://git.openjdk.java.net/riscv-port/pull/43 From yzhu at openjdk.java.net Tue Jan 11 12:44:05 2022 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Tue, 11 Jan 2022 12:44:05 GMT Subject: [riscv-port] RFR: 8279827: riscv: RVB: Add shift and add instructions [v2] In-Reply-To: References: Message-ID: On Tue, 11 Jan 2022 12:33:27 GMT, Feilong Jiang wrote: >> This PR implements shift left and add instructions: `sh1add`/`sh2add`/`sh3add`/`sh1add.uw`/`sh2add.uw`/`sh3add.uw`. >> >> New C2 instructions are covered by JTREG test: test/jdk/java/lang > > Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: > > match iRegI instead of iRegIorL2I src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 3900: > 3898: } > 3899: > 3900: if (shamt == 0) { Is "shamt == 0" a common condition? Maybe it would be better to move it into the "else" branch. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/43 From fyang at openjdk.java.net Wed Jan 12 01:01:55 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Wed, 12 Jan 2022 01:01:55 GMT Subject: [riscv-port] RFR: 8279827: riscv: RVB: Add shift and add instructions [v2] In-Reply-To: References: Message-ID: On Tue, 11 Jan 2022 12:33:27 GMT, Feilong Jiang wrote: >> This PR implements shift left and add instructions: `sh1add`/`sh2add`/`sh3add`/`sh1add.uw`/`sh2add.uw`/`sh3add.uw`. >> >> New C2 instructions are covered by JTREG test: test/jdk/java/lang > > Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: > > match iRegI instead of iRegIorL2I Changes requested by fyang (Lead). src/hotspot/cpu/riscv/riscv.ad line 3030: > 3028: interface(CONST_INTER); > 3029: %} > 3030: I think it will be better to introduce one new immIScale which combines all three. Then we can combine the newly-added instructs and reduce redundancy. If you do that, you will also need a new enc_class for distinguishing between the different Zba shift instruction encodings. // Scale/Shift values for Zba instructions operand immIScale() %{ predicate(0 <= n->get_int() && (n->get_int() <= 3)); match(ConI); op_cost(0); format %{ %} interface(CONST_INTER); %} ------------- PR: https://git.openjdk.java.net/riscv-port/pull/43 From fjiang at openjdk.java.net Wed Jan 12 01:40:38 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 12 Jan 2022 01:40:38 GMT Subject: [riscv-port] RFR: 8279827: riscv: RVB: Add shift and add instructions [v3] In-Reply-To: References: Message-ID: <8HuWMi0CTGzKpb2eEjYG_17bArLixnhVmmxWAlnSDHM=.66da9632-140c-43e4-8564-b4869581057c@github.com> > This PR implements shift left and add instructions: `sh1add`/`sh2add`/`sh3add`/`sh1add.uw`/`sh2add.uw`/`sh3add.uw`. > > New C2 instructions are covered by JTREG test: test/jdk/java/lang Feilong Jiang has updated the pull request incrementally with two additional commits since the last revision: - move uncommon shamt 0 to else branch - merge shxadd instructs into one instruct ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/43/files - new: https://git.openjdk.java.net/riscv-port/pull/43/files/bb1b8580..f166a82b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=43&range=02 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=43&range=01-02 Stats: 183 lines in 3 files changed: 10 ins; 150 del; 23 mod Patch: https://git.openjdk.java.net/riscv-port/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/43/head:pull/43 PR: https://git.openjdk.java.net/riscv-port/pull/43 From fjiang at openjdk.java.net Wed Jan 12 01:44:21 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 12 Jan 2022 01:44:21 GMT Subject: [riscv-port] RFR: 8279827: riscv: RVB: Add shift and add instructions [v4] In-Reply-To: References: Message-ID: > This PR implements shift left and add instructions: `sh1add`/`sh2add`/`sh3add`/`sh1add.uw`/`sh2add.uw`/`sh3add.uw`. > > New C2 instructions are covered by JTREG test: test/jdk/java/lang Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: fix build error ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/43/files - new: https://git.openjdk.java.net/riscv-port/pull/43/files/f166a82b..4356b5aa Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=43&range=03 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=43&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/43/head:pull/43 PR: https://git.openjdk.java.net/riscv-port/pull/43 From fjiang at openjdk.java.net Wed Jan 12 02:44:55 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 12 Jan 2022 02:44:55 GMT Subject: [riscv-port] RFR: 8279827: riscv: RVB: Add shift and add instructions [v4] In-Reply-To: References: Message-ID: <1EAxGzUP90F391t8EPjUYacByAvEx91Oi53PyQiyI-M=.c81eb903-6e7c-4493-9b26-645be4e3d37b@github.com> On Tue, 11 Jan 2022 08:49:46 GMT, Yanhong Zhu wrote: >> Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: >> >> fix build error > > src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 3900: > >> 3898: } >> 3899: >> 3900: if (shamt == 0) { > > Is "shamt == 0" a common condition? Maybe it would be better to move it into the "else" branch. `shamt == 0` is not a common case. I have moved it to else branch. Thank you for pointing it out :-) ------------- PR: https://git.openjdk.java.net/riscv-port/pull/43 From fjiang at openjdk.java.net Wed Jan 12 02:51:01 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 12 Jan 2022 02:51:01 GMT Subject: [riscv-port] RFR: 8279827: riscv: RVB: Add shift and add instructions [v2] In-Reply-To: References: Message-ID: <-q-kD1NIgF9A800un0JHFPVC0E2R2i-LctMGchELmE8=.12941592-4ac4-4c12-9553-493adb88c919@github.com> On Wed, 12 Jan 2022 00:58:40 GMT, Fei Yang wrote: >> Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: >> >> match iRegI instead of iRegIorL2I > > src/hotspot/cpu/riscv/riscv.ad line 3030: > >> 3028: interface(CONST_INTER); >> 3029: %} >> 3030: > > I think it will be better to introduce one new immIScale which combines all three. > Then we can combine the newly-added instructs and reduce redundancy. If you do that, you will also need a new enc_class for distinguishing between the different Zba shift instruction encodings. > > // Scale/Shift values for Zba instructions > operand immIScale() > %{ > predicate(0 <= n->get_int() && (n->get_int() <= 3)); > match(ConI); > op_cost(0); > format %{ %} > interface(CONST_INTER); > %} Thank you for the suggestion. It's maybe better to call the `shadd` under macroAssembler (where t0 is actually not used) to avoid the reduction definition of enc_class. New commits pushed. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/43 From xlinzheng at openjdk.java.net Wed Jan 12 03:02:07 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Wed, 12 Jan 2022 03:02:07 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v14] In-Reply-To: References: Message-ID: On Mon, 10 Jan 2022 07:30:28 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: > > Polish `nmethod_entry_barrier` and RISC-V CAS related comments > I have tested this patch under whole `test/jdk` and `test/hotspot/jtreg` folders without Monday's change through last weekend on a Hifive Unleashed and only revealed [JDK-8279664](https://bugs.openjdk.java.net/browse/JDK-8279664), which has nothing to do with this patch, for the [RISC-V backend initial-load patch](https://github.com/openjdk/riscv-port/commit/7148c39832fe522bad91df77ef4b5c9371193c35) could also reveal this problem on the Unleashed board I'm currently using. This one is a bit weird and I need more time to dig deep into that. About Monday's incremental changesets I tested `test/hotspot/jtreg/compiler`, `test/hotspot/jtreg/gc/z`, and `test/hotspot/jtreg/gc/shenandoah` with or without RVC and revealed no errors. Also SPECjbb2015 is tested and the result seems to have no regression found under RVC - the result on Unleashed remains a `max-jOPs` level of score 370 with minor fluctuations. I think maybe this patch could safely move forward -- except I need to take a look at JDK-8279664 to find whether it is a board-related issue because I cannot reproduce it on C910 and qemu. And thanks for the scrupulous reviews and the delicious suggestions, Felix and Yadong. :-) ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Wed Jan 12 06:21:01 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Wed, 12 Jan 2022 06:21:01 GMT Subject: [riscv-port] RFR: 8279827: riscv: RVB: Add shift and add instructions [v4] In-Reply-To: References: Message-ID: On Wed, 12 Jan 2022 01:44:21 GMT, Feilong Jiang wrote: >> This PR implements shift left and add instructions: `sh1add`/`sh2add`/`sh3add`/`sh1add.uw`/`sh2add.uw`/`sh3add.uw`. >> >> New C2 instructions are covered by JTREG test: test/jdk/java/lang >> >> Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. > > Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: > > fix build error Looks good. Thanks. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/43 From yzhu at openjdk.java.net Wed Jan 12 06:21:02 2022 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Wed, 12 Jan 2022 06:21:02 GMT Subject: [riscv-port] RFR: 8279827: riscv: RVB: Add shift and add instructions [v4] In-Reply-To: References: Message-ID: On Wed, 12 Jan 2022 01:44:21 GMT, Feilong Jiang wrote: >> This PR implements shift left and add instructions: `sh1add`/`sh2add`/`sh3add`/`sh1add.uw`/`sh2add.uw`/`sh3add.uw`. >> >> New C2 instructions are covered by JTREG test: test/jdk/java/lang >> >> Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. > > Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: > > fix build error Marked as reviewed by yzhu (Author). ------------- PR: https://git.openjdk.java.net/riscv-port/pull/43 From fjiang at openjdk.java.net Wed Jan 12 06:21:02 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 12 Jan 2022 06:21:02 GMT Subject: [riscv-port] RFR: 8279827: riscv: RVB: Add shift and add instructions [v4] In-Reply-To: References: Message-ID: <00i2_kSrqF5yeCn3begp7pDEstXRIV6nVew02fqw3Hc=.11d22e08-c431-4c33-97ba-b552fa896c01@github.com> On Wed, 12 Jan 2022 01:44:21 GMT, Feilong Jiang wrote: >> This PR implements shift left and add instructions: `sh1add`/`sh2add`/`sh3add`/`sh1add.uw`/`sh2add.uw`/`sh3add.uw`. >> >> New C2 instructions are covered by JTREG test: test/jdk/java/lang >> >> Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. > > Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: > > fix build error Thanks for the reviews! @yhzhu20 @RealFYang. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/43 From fjiang at openjdk.java.net Wed Jan 12 06:21:04 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 12 Jan 2022 06:21:04 GMT Subject: [riscv-port] Integrated: 8279827: riscv: RVB: Add shift and add instructions In-Reply-To: References: Message-ID: <8FCSzydbKjvoNXE0rjHYxESDHWRuMZ9uocwGMF0G5ds=.6924f099-b2f9-4f98-a0b1-0c93170f0430@github.com> On Tue, 11 Jan 2022 07:18:10 GMT, Feilong Jiang wrote: > This PR implements shift left and add instructions: `sh1add`/`sh2add`/`sh3add`/`sh1add.uw`/`sh2add.uw`/`sh3add.uw`. > > New C2 instructions are covered by JTREG test: test/jdk/java/lang > > Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. This pull request has now been integrated. Changeset: 67049937 Author: Feilong Jiang Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/67049937130f1796d2625c44b4e64d67ce08dc96 Stats: 368 lines in 14 files changed: 119 ins; 107 del; 142 mod 8279827: riscv: RVB: Add shift and add instructions Reviewed-by: fyang, yzhu ------------- PR: https://git.openjdk.java.net/riscv-port/pull/43 From fyang at openjdk.java.net Wed Jan 12 06:21:45 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Wed, 12 Jan 2022 06:21:45 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v14] In-Reply-To: References: Message-ID: On Wed, 12 Jan 2022 02:58:59 GMT, Xiaolin Zheng wrote: > > > > I have tested this patch under whole `test/jdk` and `test/hotspot/jtreg` folders without Monday's change through last weekend on a Hifive Unleashed and only revealed [JDK-8279664](https://bugs.openjdk.java.net/browse/JDK-8279664), which has nothing to do with this patch, for the [RISC-V backend initial-load patch](https://github.com/openjdk/riscv-port/commit/7148c39832fe522bad91df77ef4b5c9371193c35) could also reveal this problem on the Unleashed board I'm currently using. This one is a bit weird and I need more time to dig deep into that. > > About Monday's incremental changesets I tested `test/hotspot/jtreg/compiler`, `test/hotspot/jtreg/gc/z`, and `test/hotspot/jtreg/gc/shenandoah` with or without RVC and revealed no errors. Also SPECjbb2015 is tested and the result seems to have no regression found under RVC - the result on Unleashed remains a `max-jOPs` level of score 370 with minor fluctuations. > > I think maybe this patch could safely move forward -- except I need to take a look at JDK-8279664 to find whether it is a board-related issue because I cannot reproduce it on C910 and qemu. And thanks for the scrupulous reviews and the delicious suggestions, Felix and Yadong. :-) What about codesize improvement of the C2 JIT code? BTW: You need to rebase the patch on the latest repo. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Wed Jan 12 07:38:17 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Wed, 12 Jan 2022 07:38:17 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v15] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: - Polish `nmethod_entry_barrier` and RISC-V CAS related comments - Remove `nmethod_entry_barrier`-related things - Split c_ldsp and c_fldsp - Remove useless and polish comments - Move RVC code to the proper location after rebasing (#42) - Rename misc functions and change the positions of some comments - Remove remaining macros as discussions - Remain an 'minimum_alignment' unchanged - Manually inline all macros into functions as discussions - Remove assembler_riscv_c.hpp as discussions - ... and 8 more: https://git.openjdk.java.net/riscv-port/compare/67049937...176ae66f ------------- Changes: https://git.openjdk.java.net/riscv-port/pull/34/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=14 Stats: 1227 lines in 11 files changed: 1145 ins; 10 del; 72 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Wed Jan 12 07:38:19 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Wed, 12 Jan 2022 07:38:19 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v14] In-Reply-To: References: Message-ID: On Mon, 10 Jan 2022 07:30:28 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. > > > > > > > > > I have tested this patch under whole `test/jdk` and `test/hotspot/jtreg` folders without Monday's change through last weekend on a Hifive Unleashed and only revealed [JDK-8279664](https://bugs.openjdk.java.net/browse/JDK-8279664), which has nothing to do with this patch, for the [RISC-V backend initial-load patch](https://github.com/openjdk/riscv-port/commit/7148c39832fe522bad91df77ef4b5c9371193c35) could also reveal this problem on the Unleashed board I'm currently using. This one is a bit weird and I need more time to dig deep into that. > > About Monday's incremental changesets I tested `test/hotspot/jtreg/compiler`, `test/hotspot/jtreg/gc/z`, and `test/hotspot/jtreg/gc/shenandoah` with or without RVC and revealed no errors. Also SPECjbb2015 is tested and the result seems to have no regression found under RVC - the result on Unleashed remains a `max-jOPs` level of score 370 with minor fluctuations. > > I think maybe this patch could safely move forward -- except I need to take a look at JDK-8279664 to find whether it is a board-related issue because I cannot reproduce it on C910 and qemu. And thanks for the scrupulous reviews and the delicious suggestions, Felix and Yadong. :-) > > What about codesize improvement of the C2 JIT code? BTW: You need to rebase the patch on the latest repo. > BTW: You need to rebase the patch on the latest repo. Thanks for the kind reminder - rebased and tested a simple `test/hotspot/jtreg/compiler` with/without RVC on qemu without errors found. > What about codesize improvement of the C2 JIT code? To be short and precise, currently just 'fair' but far from 'good', as the effect of [original patch](https://github.com/openjdk/riscv-port/pull/24). This patch only enables the basic definitions of RVC and some scattered usages in the dot ad file, so its title is just a very simple 'riscv: RVC support' and I didn't mention its effect. But considering currently register spills and `pusha/popa`s are covered by this patch, which could cover many instructions (C2 and some stub code), so the result is not 'poor' though. With respect to this, I shall consider ways to further enable compressions for C1/C2's instructions to take it back to nearly a level of the original patch afterward by adding further patches. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From fjiang at openjdk.java.net Wed Jan 12 11:07:08 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 12 Jan 2022 11:07:08 GMT Subject: [riscv-port] RFR: 8279914: =?UTF-8?B?cmlzY3bvvJpXcm9uZw==?= result caused by incorrect use of iregL2I operand in some c2 match rules Message-ID: This PR fix the issue that incorrect use if iRegL2I operand in some c2 match rules. ------------- Commit messages: - 8279914: riscv?Wrong result caused by incorrect use of iregL2I operand in some c2 match rules Changes: https://git.openjdk.java.net/riscv-port/pull/44/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=44&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279914 Stats: 39 lines in 2 files changed: 6 ins; 17 del; 16 mod Patch: https://git.openjdk.java.net/riscv-port/pull/44.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/44/head:pull/44 PR: https://git.openjdk.java.net/riscv-port/pull/44 From fjiang at openjdk.java.net Wed Jan 12 11:12:40 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 12 Jan 2022 11:12:40 GMT Subject: [riscv-port] RFR: 8279914: =?UTF-8?B?cmlzY3bvvJpXcm9uZw==?= result caused by incorrect use of iregL2I operand in some c2 match rules [v2] In-Reply-To: References: Message-ID: > This PR fix the issue that incorrect use if iRegL2I operand in some c2 match rules. Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: update commments rs2 to src2 ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/44/files - new: https://git.openjdk.java.net/riscv-port/pull/44/files/9ed5f2d8..7fe8898f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=44&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=44&range=00-01 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/riscv-port/pull/44.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/44/head:pull/44 PR: https://git.openjdk.java.net/riscv-port/pull/44 From fjiang at openjdk.java.net Wed Jan 12 11:31:21 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 12 Jan 2022 11:31:21 GMT Subject: [riscv-port] RFR: 8279914: riscv: Wrong result caused by incorrect use of iregL2I operand in some c2 match rules [v3] In-Reply-To: References: Message-ID: > This PR fix the issue that incorrect use if iRegL2I operand in some c2 match rules. Feilong Jiang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision: - update commments rs2 to src2 - 8279914: riscv: Wrong result caused by incorrect use of iregL2I operand in some c2 match rules ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/44/files - new: https://git.openjdk.java.net/riscv-port/pull/44/files/7fe8898f..fab29f8c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=44&range=02 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=44&range=01-02 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/riscv-port/pull/44.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/44/head:pull/44 PR: https://git.openjdk.java.net/riscv-port/pull/44 From fyang at openjdk.java.net Wed Jan 12 11:48:54 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Wed, 12 Jan 2022 11:48:54 GMT Subject: [riscv-port] RFR: 8279914: riscv: Wrong result caused by incorrect use of iregL2I operand in some c2 match rules [v3] In-Reply-To: References: Message-ID: <1hBjiEVDujbdymGtLUJlmNLjBsBFYX8TESU1BkHdh80=.a18207c2-2ccd-4541-b07d-63af35efdc73@github.com> On Wed, 12 Jan 2022 11:31:21 GMT, Feilong Jiang wrote: >> This PR fixes the issue that incorrect use of iRegL2I operand in some c2 match rules. >> >> Test on [JDK-8279914](https://bugs.openjdk.java.net/browse/JDK-8279914) passed after this fixing. >> >> Hotspot tier1 test on QEMU are passed without new failures. > > Feilong Jiang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision: > > - update commments rs2 to src2 > - 8279914: riscv: Wrong result caused by incorrect use of iregL2I operand in some c2 match rules Nice catch. Looks good. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/44 From fjiang at openjdk.java.net Wed Jan 12 11:52:47 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 12 Jan 2022 11:52:47 GMT Subject: [riscv-port] Integrated: 8279914: riscv: Wrong result caused by incorrect use of iregL2I operand in some c2 match rules In-Reply-To: References: Message-ID: On Wed, 12 Jan 2022 10:59:57 GMT, Feilong Jiang wrote: > This PR fixes the issue that incorrect use of iRegL2I operand in some c2 match rules. > > Test on [JDK-8279914](https://bugs.openjdk.java.net/browse/JDK-8279914) passed after this fixing. > > Hotspot tier1 test on QEMU are passed without new failures. This pull request has now been integrated. Changeset: c9976c3b Author: Feilong Jiang Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/c9976c3bf840d9ffd907df45631cbed4a61ab5a8 Stats: 39 lines in 2 files changed: 6 ins; 17 del; 16 mod 8279914: riscv: Wrong result caused by incorrect use of iregL2I operand in some c2 match rules Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/44 From duke at openjdk.java.net Thu Jan 13 01:47:42 2022 From: duke at openjdk.java.net (duke) Date: Thu, 13 Jan 2022 01:47:42 GMT Subject: git: openjdk/riscv-port: riscv-port: 41 new changesets Message-ID: <15b7a8ac-3262-4e21-b788-17f8f901f25b@openjdk.java.net> Changeset: 2f13872d Author: Erik Gahlin Date: 2022-01-11 02:51:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2f13872d5152a7fab122d52ebcfb468dc0db7ac5 8279646: JFR: Remove recursive call in jdk.jfr.internal.Control Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/Control.java Changeset: 6504458d Author: Erik Gahlin Date: 2022-01-11 04:39:39 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6504458d87cdf6001f70c354b11942516a457137 8279647: JFR: Unclosed directory stream Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/SecuritySupport.java Changeset: ec5a455e Author: Erik Gahlin Date: 2022-01-11 05:49:21 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ec5a455efb04a503836f10db214d6b95bf9b4c37 8279682: JFR: Remove dead code Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/Recording.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/SecuritySupport.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkHeader.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventDirectoryStream.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/settings/CutoffSetting.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/settings/ThrottleSetting.java Changeset: 126328cb Author: Wang Huang Committer: Aleksey Shipilev Date: 2022-01-11 06:40:46 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/126328cb6218a93d23ed6169d7e52fb2719528ed 8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment Co-authored-by: Wang Huang Reviewed-by: shade, aph ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp Changeset: bf7bcaac Author: Emanuel Peter Committer: Tobias Hartmann Date: 2022-01-11 08:32:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/bf7bcaacaab12dbba1c2fb010487ed9196cb2fa5 8277748: Obsolete the MinInliningThreshold flag in JDK 19 Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/bytecodeInfo.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp Changeset: 3121898c Author: Thomas Schatzl Date: 2022-01-11 08:39:54 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3121898c33fa3cc5a049977f8677105a84c3e50c 8279703: G1: Remove unused force_not_compacted local in G1CalculatePointersClosure::do_heap_region Reviewed-by: ayang, mli ! src/hotspot/share/gc/g1/g1FullGCPrepareTask.cpp Changeset: 2bbeae3f Author: Aleksey Shipilev Date: 2022-01-11 10:28:47 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2bbeae3f056243a224b0bda021f16cdcbee3b3d6 8279668: x86: AVX2 versions of vpxor should be asserted Reviewed-by: kvn, jiefu ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp Changeset: d46410c5 Author: Erik Gahlin Date: 2022-01-11 13:04:20 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d46410c553293a91405d0f2757b0ac3bbbb157a5 8279785: JFR: 'jfr configure' should show default values Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/jfc/model/XmlFlag.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/jfc/model/XmlSelection.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/jfc/model/XmlText.java Changeset: 4c52eb39 Author: Zdenek Zambersky Committer: Severin Gehwolf Date: 2022-01-11 13:14:48 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4c52eb39431c2479b0d140907bdcc0311d30f871 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition Reviewed-by: amenkov, sspitsyn ! test/jdk/com/sun/jdi/TestScaffold.java Changeset: c08b2ac3 Author: Harold Seigel Date: 2022-01-11 13:43:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c08b2ac34c436f07f7d43f25ce16c94a137597f5 8225093: Special property jdk.boot.class.path.append should not default to empty string Reviewed-by: dholmes, sspitsyn, alanb ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/arguments.hpp + test/hotspot/jtreg/runtime/BootClassAppendProp/GetBootClassPathAppendProp.java + test/hotspot/jtreg/runtime/BootClassAppendProp/libGetBootClassPathAppendProp.c Changeset: 08e14c60 Author: Albert Mingkun Yang Date: 2022-01-11 14:04:52 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/08e14c605e7ecf555feddda59ae842e2af2035ba 8278207: G1: Tighten verification in G1ResetSkipCompactingClosure Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1FullGCCompactTask.cpp Changeset: 9e024476 Author: Andrew Leonard Date: 2022-01-11 14:21:31 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9e0244762c0961b1bb3453d294531997b367e757 8279834: Alpine Linux fails to build when --with-source-date enabled Reviewed-by: erikj ! make/autoconf/basic_tools.m4 Changeset: c3d0a940 Author: Claes Redestad Date: 2022-01-11 14:49:03 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c3d0a94040d9bd0f4b99da97b89fbfce252a41c0 8279833: Loop optimization issue in String.encodeUTF8_UTF16 Reviewed-by: shade, alanb ! src/java.base/share/classes/java/lang/String.java ! test/micro/org/openjdk/bench/java/lang/StringEncode.java Changeset: cfee4512 Author: Liam Miller-Cushon Date: 2022-01-11 15:45:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cfee4512f7048e9cf440078e9eb87d37c7ebcdd9 8273914: Indy string concat changes order of operations Reviewed-by: vromero, jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/StringConcat.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/MethodAccessReadTwice.java + test/hotspot/jtreg/runtime/modules/AccessCheck/p5/c5.jasm + test/hotspot/jtreg/runtime/modules/AccessCheck/p7/c7.jasm + test/langtools/tools/javac/StringConcat/StringAppendEvaluatesInOrder.java + test/langtools/tools/javac/StringConcat/WellKnownTypeSignatures.java + test/langtools/tools/javac/StringConcat/WellKnownTypes.java ! test/langtools/tools/javac/StringConcat/access/Test.java Changeset: 67141849 Author: Albert Mingkun Yang Date: 2022-01-11 16:18:06 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/67141849d922a3899fcb4429a520b874b7d91b4c 8279700: Parallel: Simplify ScavengeRootsTask constructor API Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/parallel/psScavenge.cpp Changeset: c4518e25 Author: Vamsi Parasa Committer: Sandhya Viswanathan Date: 2022-01-11 18:47:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c4518e257c1680a6cdb80b7e177d01700ea2c54e 8278868: Add x86 vectorization support for Long.bitCount() Reviewed-by: jbhateja, sviswanathan, kvn ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/share/adlc/formssel.cpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/superword.cpp ! src/hotspot/share/opto/vectornode.cpp ! src/hotspot/share/opto/vectornode.hpp ! src/hotspot/share/runtime/vmStructs.cpp + test/hotspot/jtreg/compiler/vectorization/TestPopCountVectorLong.java + test/micro/org/openjdk/bench/vm/compiler/VectorBitCount.java Changeset: 36f41cbe Author: Mikael Vidstedt Date: 2022-01-11 22:34:24 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/36f41cbe1126c6d9a00b21a1a68cf5f44e2f443f 8279884: Use better file for cygwin source permission check Reviewed-by: erikj ! make/autoconf/basic.m4 Changeset: 3aaa0982 Author: Masanori Yano Committer: Ian Graves Date: 2022-01-11 22:37:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3aaa0982d8c1735208a331b0097a5aea4a1fef5a 8276694: Pattern trailing unescaped backslash causes internal error Reviewed-by: jlaskey ! src/java.base/share/classes/java/util/regex/Pattern.java ! test/jdk/java/util/regex/RegExTest.java Changeset: 1c688f41 Author: Jie Fu Date: 2022-01-12 03:55:00 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1c688f41373e90865b729b5149be2ec010bc9b37 8279900: compiler/vectorization/TestPopCountVectorLong.java fails due to vpopcntdq is not supported Reviewed-by: kvn ! test/hotspot/jtreg/compiler/vectorization/TestPopCountVectorLong.java Changeset: f16f6a95 Author: Erik Gahlin Date: 2022-01-12 05:16:36 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f16f6a95df30fbc720811181f5eca8533730d626 8279821: JFR: Log warnings properly when loading a misconfigured .jfc file Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdStart.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/jfc/model/JFCModel.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Configure.java Changeset: 13bfb497 Author: TejeshR13 Committer: Jayathirth D V Date: 2022-01-12 05:38:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/13bfb4972543d87677b693b7a1b82ffdbdb45e00 6496103: isFileHidingEnabled return false by default Reviewed-by: serb, aivanov, prr ! src/java.desktop/share/classes/javax/swing/JFileChooser.java Changeset: 319d2303 Author: Masanori Yano Committer: Prasanta Sadhukhan Date: 2022-01-12 06:57:36 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/319d23033f4a814935f10885aef725c818b0baed 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in Reviewed-by: psadhukhan ! src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java + test/jdk/javax/swing/JFileChooser/8277463/UNCFileChooserTest.java Changeset: bd339aa6 Author: Emanuel Peter Committer: Tobias Hartmann Date: 2022-01-12 08:17:14 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/bd339aa6c03d12cb830a2caa04bda322e9f40c33 8277627: Fix copyright years in some jvmci files Reviewed-by: kvn, thartmann ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/MemoryBarriers.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotCallingConventionType.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/UnsafeAccess.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/Constant.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/DeoptimizationReason.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/InvokeTarget.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/MethodHandleAccessProvider.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/ProfilingInfo.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/VMConstant.java Changeset: 4f0b6502 Author: Albert Mingkun Yang Date: 2022-01-12 08:28:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4f0b65023f8f37ba59a6397d8caf6b4b86ab18b7 8278581: Improve reference processing statistics log output Reviewed-by: tschatzl, kbarrett, sjohanss ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.cpp ! src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.hpp ! test/hotspot/jtreg/gc/logging/TestPrintReferences.java Changeset: 525b20fc Author: Aleksey Shipilev Date: 2022-01-12 08:32:08 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/525b20fce0acd393f31fd37fe1f05f9d32577f77 8279676: Dubious YMM register clearing in x86_64 arraycopy stubs Reviewed-by: kvn, vlivanov, neliasso ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp Changeset: ece98d85 Author: Sergey Tsypanov Committer: Claes Redestad Date: 2022-01-12 10:16:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ece98d859d847196d298a28c1a095b09cebbee6f 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code Reviewed-by: redestad ! src/java.base/share/classes/java/lang/reflect/Constructor.java ! src/java.base/share/classes/java/lang/reflect/Method.java Changeset: ff0cb989 Author: Jaikiran Pai Date: 2022-01-12 12:58:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ff0cb98965a0b6be2f6c399e4645630c10b3466e 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out Reviewed-by: lancea ! test/jdk/jdk/nio/zipfs/ZipFSOutputStreamTest.java Changeset: f54ce844 Author: Harold Seigel Date: 2022-01-12 13:11:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f54ce84474c2ced340c92564814fa5c221415944 8238161: use os::fopen in HS code where possible Reviewed-by: mbaesken, coleenp ! src/hotspot/cpu/ppc/vm_version_ppc.cpp ! src/hotspot/os/aix/os_perf_aix.cpp ! src/hotspot/os/linux/cgroupSubsystem_linux.cpp ! src/hotspot/os/linux/cgroupSubsystem_linux.hpp ! src/hotspot/os/linux/decoder_linux.cpp ! src/hotspot/os/linux/gc/z/zMountPoint_linux.cpp ! src/hotspot/os/linux/gc/z/zPhysicalMemoryBacking_linux.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/linux/os_perf_linux.cpp ! src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp ! src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp ! src/hotspot/share/c1/c1_Compilation.cpp ! src/hotspot/share/ci/ciReplay.cpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/compiler/compilerOracle.cpp ! src/hotspot/share/compiler/disassembler.cpp ! src/hotspot/share/runtime/abstract_vm_version.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/utilities/elfFile.cpp ! src/hotspot/share/utilities/ostream.cpp Changeset: 8fed8ab2 Author: Roman Kennke Date: 2022-01-12 13:47:25 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8fed8ab29cae4f189f44609c23f116967eef6bdf 8278065: Refactor subclassAudits to use ClassValue Reviewed-by: rriggs, plevart ! src/java.base/share/classes/java/io/ObjectInputStream.java ! src/java.base/share/classes/java/io/ObjectOutputStream.java ! src/java.base/share/classes/java/io/ObjectStreamClass.java Changeset: ddddec7d Author: Patric Hedlin Date: 2022-01-12 15:30:54 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ddddec7d74745905230282124524a0dbdd1bd1c1 8274243: Implement fast-path for ASCII-compatible CharsetEncoders on aarch64 Reviewed-by: neliasso, redestad ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/matcher_aarch64.hpp ! test/micro/org/openjdk/bench/java/nio/CharsetEncodeDecode.java Changeset: 0a094d7c Author: Naoto Sato Date: 2022-01-12 19:17:18 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0a094d7c286ed0b5a35c517391e48c603cb43a68 8268081: Upgrade Unicode Data Files to 14.0.0 Reviewed-by: joehw, iris, lancea ! make/data/unicodedata/Blocks.txt ! make/data/unicodedata/DerivedCoreProperties.txt ! make/data/unicodedata/NormalizationTest.txt ! make/data/unicodedata/PropList.txt ! make/data/unicodedata/PropertyValueAliases.txt + make/data/unicodedata/ReadMe.txt ! make/data/unicodedata/Scripts.txt ! make/data/unicodedata/SpecialCasing.txt ! make/data/unicodedata/UnicodeData.txt - make/data/unicodedata/VERSION ! make/data/unicodedata/auxiliary/GraphemeBreakProperty.txt ! make/data/unicodedata/auxiliary/GraphemeBreakTest.txt ! make/data/unicodedata/emoji/emoji-data.txt ! src/java.base/share/classes/java/lang/Character.java ! src/java.base/share/classes/java/util/regex/Grapheme.java ! src/java.base/share/classes/jdk/internal/icu/impl/Punycode.java ! src/java.base/share/classes/jdk/internal/icu/impl/UnicodeSetStringSpan.java - src/java.base/share/classes/jdk/internal/icu/impl/data/icudt67b/nfc.nrm - src/java.base/share/classes/jdk/internal/icu/impl/data/icudt67b/nfkc.nrm - src/java.base/share/classes/jdk/internal/icu/impl/data/icudt67b/ubidi.icu - src/java.base/share/classes/jdk/internal/icu/impl/data/icudt67b/uprops.icu + src/java.base/share/classes/jdk/internal/icu/impl/data/icudt70b/nfc.nrm + src/java.base/share/classes/jdk/internal/icu/impl/data/icudt70b/nfkc.nrm + src/java.base/share/classes/jdk/internal/icu/impl/data/icudt70b/ubidi.icu + src/java.base/share/classes/jdk/internal/icu/impl/data/icudt70b/uprops.icu ! src/java.base/share/classes/jdk/internal/icu/lang/UCharacter.java ! src/java.base/share/classes/jdk/internal/icu/lang/UCharacterDirection.java ! src/java.base/share/classes/jdk/internal/icu/lang/UCharacterEnums.java ! src/java.base/share/classes/jdk/internal/icu/text/BidiBase.java ! src/java.base/share/classes/jdk/internal/icu/text/BidiLine.java ! src/java.base/share/classes/jdk/internal/icu/text/Normalizer2.java ! src/java.base/share/classes/jdk/internal/icu/text/NormalizerBase.java ! src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java ! src/java.base/share/classes/jdk/internal/icu/text/UCharacterIterator.java ! src/java.base/share/classes/jdk/internal/icu/text/UTF16.java ! src/java.base/share/classes/jdk/internal/icu/text/UnicodeSet.java ! src/java.base/share/classes/jdk/internal/icu/util/CodePointTrie.java ! src/java.base/share/classes/jdk/internal/icu/util/VersionInfo.java ! src/java.base/share/legal/icu.md ! src/java.base/share/legal/unicode.md ! test/jdk/java/lang/Character/UnicodeBlock/OptimalMapSize.java Changeset: d70545d7 Author: Ludvig Janiuk Committer: Vladimir Kozlov Date: 2022-01-12 19:24:52 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d70545d71080d534fefd3c9652656549f689f620 8258603: c1 IR::verify is expensive Reviewed-by: chagedorn, kvn ! src/hotspot/share/c1/c1_IR.cpp ! src/hotspot/share/c1/c1_IR.hpp ! src/hotspot/share/c1/c1_Instruction.hpp ! src/hotspot/share/c1/c1_Optimizer.cpp Changeset: 1228b2f1 Author: Yumin Qi Date: 2022-01-13 00:23:05 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1228b2f1f8737a363ab6a7065b24e9f972441b27 8261455: Automatically generate the CDS archive if necessary Reviewed-by: iklam, ccheung ! src/hotspot/share/cds/dynamicArchive.cpp ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/cds/filemap.hpp ! src/hotspot/share/cds/metaspaceShared.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp ! test/hotspot/jtreg/runtime/cds/appcds/MoveJDKTest.java ! test/hotspot/jtreg/runtime/cds/appcds/SharedArchiveConsistency.java ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveTestBase.java + test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchive.java + test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveNoDefaultArchive.java ! test/lib/jdk/test/lib/cds/CDSArchiveUtils.java ! test/lib/jdk/test/lib/cds/CDSTestUtils.java Changeset: cb250298 Author: Weijun Wang Date: 2022-01-13 00:42:00 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cb25029885b176be9ebbc84ac1a8ba71be96a6a7 8279800: isAssignableFrom checks in AlgorithmParametersSpi.engineGetParameterSpec appear to be backwards Reviewed-by: xuelei, valeriep ! src/java.base/share/classes/com/sun/crypto/provider/BlockCipherParamsCore.java ! src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Poly1305Parameters.java ! src/java.base/share/classes/com/sun/crypto/provider/DHParameters.java ! src/java.base/share/classes/com/sun/crypto/provider/GCMParameters.java ! src/java.base/share/classes/com/sun/crypto/provider/OAEPParameters.java ! src/java.base/share/classes/com/sun/crypto/provider/PBEKeyFactory.java ! src/java.base/share/classes/com/sun/crypto/provider/PBEParameters.java ! src/java.base/share/classes/com/sun/crypto/provider/PBES2Parameters.java ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2Core.java - src/java.base/share/classes/com/sun/crypto/provider/PBKDF2HmacSHA1Factory.java ! src/java.base/share/classes/com/sun/crypto/provider/RC2Parameters.java ! src/java.base/share/classes/sun/security/provider/DSAParameters.java ! src/java.base/share/classes/sun/security/rsa/PSSParameters.java ! src/java.base/share/classes/sun/security/util/GCMParameters.java + test/jdk/java/security/spec/IsAssignableFromOrder.java Changeset: bbc1ddb4 Author: Hao Sun Committer: Dean Long Date: 2022-01-10 20:46:28 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/bbc1ddb4744bfb15c4e3ab0bed14f7ad0d17b7e5 8278267: ARM32: several vector test failures for ASHR Reviewed-by: njian, dlong ! src/hotspot/cpu/arm/arm.ad ! src/hotspot/share/opto/vectornode.hpp Changeset: 92307e5a Author: Roman Kennke Date: 2022-01-10 20:47:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/92307e5a944f7e995780fc6f5e55713802919dfd 8278489: Preserve result in native wrapper with +UseHeavyMonitors Reviewed-by: shade, kvn ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp Changeset: 6d7db4b0 Author: Tobias Hartmann Date: 2022-01-11 06:59:26 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6d7db4b0b3e9172645cef12c36fbeb41a6d38d83 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist! Reviewed-by: chagedorn, kvn, coleenp ! src/hotspot/share/oops/method.cpp ! test/hotspot/jtreg/compiler/codecache/OverflowCodeCacheTest.java Changeset: 86d0abb6 Author: Fairoz Matte Committer: Nils Eliasson Date: 2022-01-11 09:39:39 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/86d0abb66bd2fe1edd15b81d351ea3b3c90fd256 8279695: [TESTBUG] modify compiler/loopopts/TestSkeletonPredicateNegation.java to run on C1 also Reviewed-by: neliasso ! test/hotspot/jtreg/compiler/loopopts/TestSkeletonPredicateNegation.java Changeset: 5aecb372 Author: Pavel Rappo Date: 2022-01-11 14:28:03 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5aecb37211c2dec475c56dcc354b6bb4f7e3585e 8206181: ExceptionInInitializerError: improve handling of exceptions in user-provided taglets Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java + test/langtools/jdk/javadoc/doclet/testCustomTagletRegistration/ClassCastExceptionTaglet.java + test/langtools/jdk/javadoc/doclet/testCustomTagletRegistration/ExceptionInInitializerErrorTaglet.java + test/langtools/jdk/javadoc/doclet/testCustomTagletRegistration/InstantiationExceptionTaglet.java + test/langtools/jdk/javadoc/doclet/testCustomTagletRegistration/InvocationTargetExceptionTaglet.java + test/langtools/jdk/javadoc/doclet/testCustomTagletRegistration/NoSuchMethodExceptionNoNullaryCtorTaglet.java + test/langtools/jdk/javadoc/doclet/testCustomTagletRegistration/NoSuchMethodExceptionPrivateCtorTaglet.java + test/langtools/jdk/javadoc/doclet/testCustomTagletRegistration/TestRegistrationErrors.java Changeset: 67e3d51d Author: Jesper Wilhelmsson Date: 2022-01-13 01:05:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/67e3d51d68e7319bd6d5b01233b664e6ee6b17ec Merge ! src/hotspot/share/opto/vectornode.hpp ! src/hotspot/share/opto/vectornode.hpp Changeset: a61d66c5 Author: Fei Yang Date: 2022-01-12 20:41:31 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a61d66c57b420ee8b61d6e31ec89dad1cb98b64f Merge branch 'master' into riscv-port ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/share/runtime/abstract_vm_version.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/share/runtime/abstract_vm_version.cpp ! src/hotspot/share/runtime/arguments.cpp From xlinzheng at openjdk.java.net Thu Jan 13 10:02:27 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Thu, 13 Jan 2022 10:02:27 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v16] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 19 commits: - Polish comments: remove the 'RVC:' prefix - Polish `nmethod_entry_barrier` and RISC-V CAS related comments - Remove `nmethod_entry_barrier`-related things - Split c_ldsp and c_fldsp - Remove useless and polish comments - Move RVC code to the proper location after rebasing (#42) - Rename misc functions and change the positions of some comments - Remove remaining macros as discussions - Remain an 'minimum_alignment' unchanged - Manually inline all macros into functions as discussions - ... and 9 more: https://git.openjdk.java.net/riscv-port/compare/a61d66c5...969a4d4d ------------- Changes: https://git.openjdk.java.net/riscv-port/pull/34/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=15 Stats: 1227 lines in 11 files changed: 1145 ins; 10 del; 72 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From fjiang at openjdk.java.net Fri Jan 14 06:16:08 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 14 Jan 2022 06:16:08 GMT Subject: [riscv-port] RFR: 8279996: riscv: RVB: Add zeros/population count instructions Message-ID: This PR implements zeros and population count instructions: `clz`/`clzw`/`ctz`/`ctzw`/`cpop`/`cpopw`. New C2 instructions are covered by the following JTREG tests: - test/hotspot/jtreg/compiler/codegen/Test6823354.java - test/hotspot/jtreg/compiler/codegen/Test7100757.java - test/hotspot/jtreg/compiler/codegen/Test8005033.java ------------- Commit messages: - 8279996: riscv: RVB: Add zeros/population count instructions Changes: https://git.openjdk.java.net/riscv-port/pull/45/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=45&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279996 Stats: 143 lines in 6 files changed: 116 ins; 5 del; 22 mod Patch: https://git.openjdk.java.net/riscv-port/pull/45.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/45/head:pull/45 PR: https://git.openjdk.java.net/riscv-port/pull/45 From fyang at openjdk.java.net Fri Jan 14 06:31:53 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 14 Jan 2022 06:31:53 GMT Subject: [riscv-port] RFR: 8279996: riscv: RVB: Add zeros/population count instructions In-Reply-To: References: Message-ID: On Fri, 14 Jan 2022 06:09:34 GMT, Feilong Jiang wrote: > This PR implements zeros and population count instructions: `clz`/`clzw`/`ctz`/`ctzw`/`cpop`/`cpopw`. > > New C2 instructions are covered by the following JTREG tests: > - test/hotspot/jtreg/compiler/codegen/Test6823354.java > - test/hotspot/jtreg/compiler/codegen/Test7100757.java > - test/hotspot/jtreg/compiler/codegen/Test8005033.java > > Hotspot and jdk tier1 tests on QEMU (with UseRVB) are passed without new failures. Looks good. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/45 From fjiang at openjdk.java.net Fri Jan 14 07:09:24 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 14 Jan 2022 07:09:24 GMT Subject: [riscv-port] RFR: 8279996: riscv: RVB: Add zeros/population count instructions [v2] In-Reply-To: References: Message-ID: > This PR implements zeros and population count instructions: `clz`/`clzw`/`ctz`/`ctzw`/`cpop`/`cpopw`. > > New C2 instructions are covered by the following JTREG tests: > - test/hotspot/jtreg/compiler/codegen/Test6823354.java > - test/hotspot/jtreg/compiler/codegen/Test7100757.java > - test/hotspot/jtreg/compiler/codegen/Test8005033.java > > Hotspot and jdk tier1 tests on QEMU (with UseRVB) are passed without new failures. Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: update license to new year ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/45/files - new: https://git.openjdk.java.net/riscv-port/pull/45/files/e8cd88e5..e4fb09d0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=45&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=45&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/45.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/45/head:pull/45 PR: https://git.openjdk.java.net/riscv-port/pull/45 From fyang at openjdk.java.net Fri Jan 14 07:32:45 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 14 Jan 2022 07:32:45 GMT Subject: [riscv-port] RFR: 8279996: riscv: RVB: Add zeros/population count instructions [v2] In-Reply-To: References: Message-ID: On Fri, 14 Jan 2022 07:09:24 GMT, Feilong Jiang wrote: >> This PR implements zeros and population count instructions: `clz`/`clzw`/`ctz`/`ctzw`/`cpop`/`cpopw`. >> >> New C2 instructions are covered by the following JTREG tests: >> - test/hotspot/jtreg/compiler/codegen/Test6823354.java >> - test/hotspot/jtreg/compiler/codegen/Test7100757.java >> - test/hotspot/jtreg/compiler/codegen/Test8005033.java >> >> Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. > > Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: > > update license to new year OK. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/45 From fjiang at openjdk.java.net Fri Jan 14 07:35:44 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 14 Jan 2022 07:35:44 GMT Subject: [riscv-port] Integrated: 8279996: riscv: RVB: Add zeros/population count instructions In-Reply-To: References: Message-ID: On Fri, 14 Jan 2022 06:09:34 GMT, Feilong Jiang wrote: > This PR implements zeros and population count instructions: `clz`/`clzw`/`ctz`/`ctzw`/`cpop`/`cpopw`. > > New C2 instructions are covered by the following JTREG tests: > - test/hotspot/jtreg/compiler/codegen/Test6823354.java > - test/hotspot/jtreg/compiler/codegen/Test7100757.java > - test/hotspot/jtreg/compiler/codegen/Test8005033.java > > Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. This pull request has now been integrated. Changeset: d119eda6 Author: Feilong Jiang Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/d119eda6aad8199244359b17a754b3e9a33fef60 Stats: 144 lines in 6 files changed: 116 ins; 5 del; 23 mod 8279996: riscv: RVB: Add zeros/population count instructions Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/45 From yadongwang at openjdk.java.net Fri Jan 14 10:50:14 2022 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Fri, 14 Jan 2022 10:50:14 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v16] In-Reply-To: References: Message-ID: On Thu, 13 Jan 2022 10:02:27 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 19 commits: > > - Polish comments: remove the 'RVC:' prefix > - Polish `nmethod_entry_barrier` and RISC-V CAS related comments > - Remove `nmethod_entry_barrier`-related things > - Split c_ldsp and c_fldsp > - Remove useless and polish comments > - Move RVC code to the proper location after rebasing (#42) > - Rename misc functions and change the positions of some comments > - Remove remaining macros as discussions > - Remain an 'minimum_alignment' unchanged > - Manually inline all macros into functions as discussions > - ... and 9 more: https://git.openjdk.java.net/riscv-port/compare/a61d66c5...969a4d4d lgtm ------------- Marked as reviewed by yadongwang (Author). PR: https://git.openjdk.java.net/riscv-port/pull/34 From yadongwang at openjdk.java.net Sat Jan 15 03:21:17 2022 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Sat, 15 Jan 2022 03:21:17 GMT Subject: [riscv-port] RFR: 8279826: riscv: Preserve result in native wrapper with +UseHeavyMonitors Message-ID: Testing observed a few failures after JDK-8278387. On RISC-V, we followed JDK-8278489: The reason for the failures is in the native-wrappers, in the +UseHeavyMonitors paths, we don't preserve the result register after the native call. Hotspot/jdk tier1 passed on the unmatched with -XX:+UseHeavyMonitors, and all jtregs were tested on Qemu without new failures. ------------- Commit messages: - 8279826: riscv: Preserve result in native wrapper with +UseHeavyMonitors Changes: https://git.openjdk.java.net/riscv-port/pull/46/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=46&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279826 Stats: 10 lines in 1 file changed: 6 ins; 4 del; 0 mod Patch: https://git.openjdk.java.net/riscv-port/pull/46.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/46/head:pull/46 PR: https://git.openjdk.java.net/riscv-port/pull/46 From fjiang at openjdk.java.net Sat Jan 15 03:26:52 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Sat, 15 Jan 2022 03:26:52 GMT Subject: [riscv-port] RFR: 8279826: riscv: Preserve result in native wrapper with +UseHeavyMonitors In-Reply-To: References: Message-ID: On Sat, 15 Jan 2022 03:15:44 GMT, Yadong Wang wrote: > Testing observed a few failures after JDK-8278387. On RISC-V, we followed JDK-8278489: The reason for the failures is in the native-wrappers, in the +UseHeavyMonitors paths, we don't preserve the result register after the native call. > > Hotspot/jdk tier1 passed on the unmatched with -XX:+UseHeavyMonitors, and all jtregs were tested on Qemu without new failures. Marked as reviewed by fjiang (Author). ------------- PR: https://git.openjdk.java.net/riscv-port/pull/46 From yadongwang at openjdk.java.net Sat Jan 15 03:35:02 2022 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Sat, 15 Jan 2022 03:35:02 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v16] In-Reply-To: References: Message-ID: On Thu, 13 Jan 2022 10:02:27 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 19 commits: > > - Polish comments: remove the 'RVC:' prefix > - Polish `nmethod_entry_barrier` and RISC-V CAS related comments > - Remove `nmethod_entry_barrier`-related things > - Split c_ldsp and c_fldsp > - Remove useless and polish comments > - Move RVC code to the proper location after rebasing (#42) > - Rename misc functions and change the positions of some comments > - Remove remaining macros as discussions > - Remain an 'minimum_alignment' unchanged > - Manually inline all macros into functions as discussions > - ... and 9 more: https://git.openjdk.java.net/riscv-port/compare/a61d66c5...969a4d4d src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp line 1329: > 1327: // the address of jal itself (which will be patched later) should not span the cache line. > 1328: // See CallStaticJavaDirectNode::compute_padding() for more info. > 1329: __ align(4); It's better to add some alignment asserts before the code that may be patched, for example, in MacroAssembler::emit_static_call_stub. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Sat Jan 15 04:21:12 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Sat, 15 Jan 2022 04:21:12 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v17] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits: - Add an assertion for patchable jals' alignment - Polish comments: remove the 'RVC:' prefix - Polish `nmethod_entry_barrier` and RISC-V CAS related comments - Remove `nmethod_entry_barrier`-related things - Split c_ldsp and c_fldsp - Remove useless and polish comments - Move RVC code to the proper location after rebasing (#42) - Rename misc functions and change the positions of some comments - Remove remaining macros as discussions - Remain an 'minimum_alignment' unchanged - ... and 10 more: https://git.openjdk.java.net/riscv-port/compare/d119eda6...3496b133 ------------- Changes: https://git.openjdk.java.net/riscv-port/pull/34/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=16 Stats: 1228 lines in 11 files changed: 1146 ins; 10 del; 72 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Sat Jan 15 04:21:19 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Sat, 15 Jan 2022 04:21:19 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v16] In-Reply-To: References: Message-ID: On Sat, 15 Jan 2022 03:31:35 GMT, Yadong Wang wrote: >> Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. > > src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp line 1329: > >> 1327: // the address of jal itself (which will be patched later) should not span the cache line. >> 1328: // See CallStaticJavaDirectNode::compute_padding() for more info. >> 1329: __ align(4); > > It's better to add some alignment asserts before the code that may be patched, for example, in MacroAssembler::emit_static_call_stub. Thanks for the reasonable suggestion. Rebased and added the assertion with testing a fastdebug build under RVC for `test/jtreg/hotspot/compiler` without errors found. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Sun Jan 16 02:06:46 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Sun, 16 Jan 2022 02:06:46 GMT Subject: [riscv-port] RFR: 8279826: riscv: Preserve result in native wrapper with +UseHeavyMonitors In-Reply-To: References: Message-ID: On Sat, 15 Jan 2022 03:15:44 GMT, Yadong Wang wrote: > Testing observed a few failures after JDK-8278387. On RISC-V, we followed JDK-8278489: The reason for the failures is in the native-wrappers, in the +UseHeavyMonitors paths, we don't preserve the result register after the native call. > > Hotspot/jdk tier1 passed on the unmatched with -XX:+UseHeavyMonitors, and all jtregs were tested on Qemu without new failures. Approved. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/46 From yadongwang at openjdk.java.net Mon Jan 17 01:05:47 2022 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Mon, 17 Jan 2022 01:05:47 GMT Subject: [riscv-port] Integrated: 8279826: riscv: Preserve result in native wrapper with +UseHeavyMonitors In-Reply-To: References: Message-ID: On Sat, 15 Jan 2022 03:15:44 GMT, Yadong Wang wrote: > Testing observed a few failures after JDK-8278387. On RISC-V, we followed JDK-8278489: The reason for the failures is in the native-wrappers, in the +UseHeavyMonitors paths, we don't preserve the result register after the native call. > > Hotspot/jdk tier1 passed on the unmatched with -XX:+UseHeavyMonitors, and all jtregs were tested on Qemu without new failures. This pull request has now been integrated. Changeset: 80f64ffb Author: Yadong Wang URL: https://git.openjdk.java.net/riscv-port/commit/80f64ffbc2867f88132846421870f1ffa5c9da2e Stats: 10 lines in 1 file changed: 6 ins; 4 del; 0 mod 8279826: riscv: Preserve result in native wrapper with +UseHeavyMonitors Reviewed-by: fjiang, fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/46 From duke at openjdk.java.net Mon Jan 17 02:01:09 2022 From: duke at openjdk.java.net (duke) Date: Mon, 17 Jan 2022 02:01:09 GMT Subject: git: openjdk/riscv-port: riscv-port: 29 new changesets Message-ID: <6a5bdf29-eb03-4579-b63c-4615b462cd65@openjdk.java.net> Changeset: 48519480 Author: John Jiang Date: 2022-01-13 02:16:50 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/485194805966e8dbb76473fa26276e5ba26d8097 8279903: Redundant modulo operation in ECDHKeyAgreement Reviewed-by: weijun, xuelei ! src/jdk.crypto.ec/share/classes/sun/security/ec/ECDHKeyAgreement.java Changeset: 69339346 Author: Kevin Walls Date: 2022-01-13 09:29:05 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/693393463385a966f9bf8a4569074c185c1f2863 8278597: Remove outdated comments regarding RMISecurityManager in HotSpotAgent.java Reviewed-by: rriggs, sspitsyn ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HotSpotAgent.java Changeset: b61a4af7 Author: Erik Gahlin Date: 2022-01-13 09:46:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b61a4af719ec2f6be446612baea11245e222d6fa 8259774: Deprecate -XX:FlightRecorderOptions:samplethreads Reviewed-by: mgronlun ! src/hotspot/share/jfr/dcmd/jfrDcmds.cpp ! src/hotspot/share/jfr/jni/jfrJniMethod.cpp ! src/hotspot/share/jfr/jni/jfrJniMethod.hpp ! src/hotspot/share/jfr/jni/jfrJniMethodRegistration.cpp ! src/hotspot/share/jfr/recorder/service/jfrOptionSet.cpp ! src/hotspot/share/jfr/recorder/service/jfrOptionSet.hpp ! src/java.base/share/man/java.1 ! src/jdk.jfr/share/classes/jdk/jfr/FlightRecorder.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/JVM.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/Options.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdConfigure.java ! test/jdk/jdk/jfr/jcmd/TestJcmdConfigure.java Changeset: c17a0122 Author: Jaikiran Pai Date: 2022-01-13 13:23:57 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c17a0122c4b5f17b85dc0bee0777b2a831debf6d 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java Reviewed-by: dfuchs, msheppar ! test/jdk/java/net/DatagramSocket/SendDatagramToBadAddress.java Changeset: 6fcaa322 Author: Daniel Jelinski Committer: Daniel Fuchs Date: 2022-01-13 14:41:55 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6fcaa322d90f06ba79a8fc30ebe314aa9ea8e959 8262442: (windows) Use all proxy configuration sources when java.net.useSystemProxies=true Reviewed-by: dfuchs ! src/java.base/windows/native/libnet/DefaultProxySelector.c Changeset: 0a839b43 Author: Weijun Wang Date: 2022-01-13 15:26:41 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0a839b434b8454e22d6e5084af6e45cab3daa538 8279801: EC KeyFactory and KeyPairGenerator do not have aliases for OID format Reviewed-by: xuelei, valeriep ! src/jdk.crypto.ec/share/classes/sun/security/ec/SunEC.java + test/jdk/sun/security/ec/OidInstance.java Changeset: 9209e6d6 Author: Daniel Jelinski Committer: Lance Andersen Date: 2022-01-13 16:17:50 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9209e6d6aeee002c5de3b29cfed1e91c61c37868 8279877: Document IDEA IDE setup in docs/ide.md Reviewed-by: lancea, erikj ! doc/ide.html ! doc/ide.md Changeset: 237f861e Author: Patricio Chilano Mateo Date: 2022-01-13 17:49:01 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/237f861e8245749cb260fa81e7797d337dc15e22 8273143: Transition to _thread_in_vm when handling a polling page exception Reviewed-by: rehn, dcubed, coleenp, rrich ! src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/interfaceSupport.inline.hpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/safepoint.hpp ! src/hotspot/share/runtime/safepointMechanism.cpp ! src/hotspot/share/runtime/thread.cpp Changeset: 35172cda Author: Ioi Lam Date: 2022-01-13 18:28:03 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/35172cdaf38d83cd3ed57a5436bf985dde2d802b 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 Reviewed-by: hseigel, sgehwolf ! src/hotspot/os/linux/cgroupSubsystem_linux.hpp ! src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp Changeset: 965c64bc Author: Albert Mingkun Yang Date: 2022-01-14 07:47:08 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/965c64bca713446e7e513170aa9138a8a5eec5de 8279699: Parallel: More precise boundary in ObjectStartArray::object_starts_in_range Reviewed-by: sjohanss, mli ! src/hotspot/share/gc/parallel/objectStartArray.cpp ! src/hotspot/share/gc/parallel/objectStartArray.hpp Changeset: 84976b45 Author: Matthias Baesken Date: 2022-01-14 09:51:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/84976b45315feb6c37a9f3db6e1e62812c9b0a37 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15 Reviewed-by: mdoerr, lucy ! src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java ! src/java.desktop/unix/classes/sun/font/MFontConfiguration.java Changeset: dd76a28d Author: Albert Mingkun Yang Date: 2022-01-14 12:35:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/dd76a28d441e01b1993a71de67ace58bcb67acc8 8280000: Remove unused CardTable::find_covering_region_containing Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/shared/cardTable.cpp ! src/hotspot/share/gc/shared/cardTable.hpp Changeset: 9f30ec17 Author: Julia Boes Date: 2022-01-14 12:48:03 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9f30ec174faae10484766308996cab136a779658 8278398: jwebserver: Add test to confirm maximum request time Reviewed-by: dfuchs, michaelm ! src/jdk.httpserver/share/classes/sun/net/httpserver/ServerImpl.java + test/jdk/com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java Changeset: e8f494cd Author: Erik Gahlin Date: 2022-01-14 14:31:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e8f494cd5f2e7ef345cd145ad7836419efa1a059 8279825: JFR: JFCModel shouldn't need FilePermission to read predefined .jfc files Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/jfc/JFC.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/jfc/model/JFCModel.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/jfc/model/Parser.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Configure.java Changeset: 35734ad0 Author: Harold Seigel Date: 2022-01-14 14:41:12 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/35734ad0805b9ecaf6eb72a4b1513b8de53ed72c 8279545: Buffer overrun in reverse_words of sharedRuntime_x86_64.cpp:3517 Reviewed-by: coleenp, lfoltan ! src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp ! src/hotspot/cpu/s390/sharedRuntime_s390.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp Changeset: 61b89443 Author: Sean Mullan Date: 2022-01-14 15:22:31 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/61b8944327e3d12cf58dc3f6bc45ecbeba4ef611 8278851: Correct signer logic for jars signed with multiple digestalgs Reviewed-by: coffeys, weijun ! src/java.base/share/classes/java/util/jar/JarVerifier.java ! src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java + test/jdk/jdk/security/jarsigner/JarWithOneNonDisabledDigestAlg.java Changeset: ac98b220 Author: Albert Mingkun Yang Date: 2022-01-14 15:54:31 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ac98b22040f854de79813a1c2a97fc399d3bcc42 8280028: [BACKOUT] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range Reviewed-by: sjohanss ! src/hotspot/share/gc/parallel/objectStartArray.cpp ! src/hotspot/share/gc/parallel/objectStartArray.hpp Changeset: f1805309 Author: Pavel Rappo Date: 2022-01-14 16:10:14 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f1805309352a22119ae2edf8bfbb596f00936224 8279918: Fix various doc typos Reviewed-by: kevinw, lancea, mullan, sspitsyn, naoto, jlahoda, azvegint, egahlin, jjg ! src/java.base/share/classes/java/io/DataInput.java ! src/java.base/share/classes/java/io/ObjectInputStream.java ! src/java.base/share/classes/java/io/PipedInputStream.java ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/math/BigDecimal.java ! src/java.base/share/classes/java/text/MessageFormat.java ! src/java.base/share/classes/java/util/Locale.java ! src/java.base/share/classes/java/util/zip/ZipFile.java ! src/java.base/share/classes/sun/text/RuleBasedBreakIterator.java ! src/java.base/share/classes/sun/text/spi/JavaTimeDateTimePatternProvider.java ! src/java.desktop/share/classes/com/sun/beans/TypeResolver.java ! src/java.desktop/share/classes/java/awt/List.java ! src/java.desktop/share/classes/java/awt/MenuComponent.java ! src/java.desktop/share/classes/java/awt/font/GlyphJustificationInfo.java ! src/java.desktop/share/classes/java/awt/geom/Arc2D.java ! src/java.desktop/share/classes/javax/imageio/stream/ImageInputStream.java ! src/java.desktop/share/classes/javax/print/attribute/standard/JobStateReason.java ! src/java.desktop/share/classes/javax/sound/midi/Sequencer.java ! src/java.desktop/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/java.logging/share/classes/java/util/logging/LogRecord.java ! src/java.management/share/classes/javax/management/MXBean.java ! src/java.security.sasl/share/classes/javax/security/sasl/SaslServer.java ! src/java.sql/share/classes/java/sql/BatchUpdateException.java ! src/java.sql/share/classes/java/sql/Connection.java ! src/java.sql/share/classes/java/sql/DatabaseMetaData.java ! src/java.sql/share/classes/java/sql/Statement.java ! src/java.xml/share/classes/javax/xml/stream/XMLStreamReader.java ! src/java.xml/share/classes/org/xml/sax/ext/DeclHandler.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ArgumentAttr.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/Package.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/Transformer.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ParamTaglet.java ! src/jdk.jdi/share/classes/com/sun/jdi/VirtualMachineManager.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/SecuritySupport.java ! src/jdk.security.auth/share/classes/com/sun/security/auth/module/KeyStoreLoginModule.java Changeset: cf283e2a Author: Christian Hagedorn Date: 2022-01-14 16:17:01 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cf283e2a33a053407eac65ea35baa61a3a23c8d5 8279570: IGV: Add source/destination property for load and store nodes with an associated field Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/idealGraphPrinter.cpp ! src/hotspot/share/opto/idealGraphPrinter.hpp Changeset: d9dd485b Author: Thomas Stuefe Date: 2022-01-14 16:17:48 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d9dd485b95e1796822c0dcfaed8a28328b0a976a 8280019: Remove unused code from metaspace Reviewed-by: coleenp, hseigel ! src/hotspot/share/memory/metaspace/blockTree.cpp ! src/hotspot/share/memory/metaspace/chunkManager.cpp ! src/hotspot/share/memory/metaspace/chunkManager.hpp ! src/hotspot/share/memory/metaspace/commitMask.hpp ! src/hotspot/share/memory/metaspace/counters.hpp ! src/hotspot/share/memory/metaspace/freeChunkList.cpp ! src/hotspot/share/memory/metaspace/rootChunkArea.cpp Changeset: fb8fdc0f Author: Brian Burkhalter Date: 2022-01-14 17:47:35 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/fb8fdc0fbf17dd7e900cb688df4917b97b26b9ab 8279990: (fs) Awkward verbiage in description of Files.createTempFile(Path,String,String,FileAttribute) Reviewed-by: lancea ! src/java.base/share/classes/java/nio/file/Files.java Changeset: c359c358 Author: Thomas Stuefe Date: 2022-01-14 19:40:10 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c359c358c8ebaf7b1dddbc4b499a7aae65ba6736 8280002: jmap -histo may leak stream Reviewed-by: shade, sspitsyn ! src/hotspot/share/services/attachListener.cpp Changeset: 0d1a97f7 Author: Weijun Wang Date: 2022-01-14 20:44:22 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0d1a97f793309919bd6d67085630049eaafcced1 8279064: New options for ktab to provide non-default salt Reviewed-by: valeriep ! src/java.security.jgss/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Ktab.java ! test/jdk/sun/security/krb5/auto/Context.java + test/jdk/sun/security/krb5/auto/tools/KtabSalt.java ! test/jdk/sun/security/krb5/tools/KtabCheck.java Changeset: eab4e6d6 Author: Daniel D. Daugherty Date: 2022-01-14 22:24:39 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/eab4e6d6701f2e217374c073c2578f029fa58393 8280045: ProblemList 2 AppCDS tests until JDK-8279970 is fixed Reviewed-by: ccheung ! test/hotspot/jtreg/ProblemList.txt Changeset: 9b0f6895 Author: Jie Fu Date: 2022-01-14 23:13:05 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9b0f68955770d017d727a423e46140033317f273 8279947: Remove two redundant gvn.transform calls in Parse::do_one_bytecode() Reviewed-by: kvn ! src/hotspot/share/opto/parse2.cpp Changeset: 22b7295e Author: Masanori Yano Committer: Sergey Bylokhov Date: 2022-01-15 02:17:46 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/22b7295e75d3bc7ba2c2cd7b871bb2bb5bf290eb 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails Reviewed-by: serb ! test/jdk/ProblemList.txt ! test/jdk/java/awt/Graphics2D/CopyAreaOOB.java Changeset: 9a18190a Author: Mikael Vidstedt Date: 2022-01-15 03:20:34 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9a18190a4f8e31801d1442d97f247f074a3fd5c0 8280048: Missing comma in copyright header Reviewed-by: prr ! test/jdk/java/awt/Graphics2D/CopyAreaOOB.java Changeset: fef8f2d3 Author: Erik Gahlin Date: 2022-01-15 07:01:55 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/fef8f2d30004ea75c663752ae6c61b214fb8abc8 8279797: JFR: Show .jfc options in JFR.start help Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdStart.java Changeset: f26f83ff Author: Fei Yang Date: 2022-01-16 20:56:21 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f26f83ff03a9e378225063c2cf2408a9cf2df303 Merge branch 'master' into riscv-port ! src/hotspot/cpu/riscv/macroAssembler_riscv.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HotSpotAgent.java + src/hotspot/cpu/riscv/macroAssembler_riscv.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HotSpotAgent.java From xlinzheng at openjdk.java.net Mon Jan 17 03:09:25 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 17 Jan 2022 03:09:25 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v18] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision: - Add an assertion for patchable jals' alignment - Polish comments: remove the 'RVC:' prefix - Polish `nmethod_entry_barrier` and RISC-V CAS related comments - Remove `nmethod_entry_barrier`-related things - Split c_ldsp and c_fldsp - Remove useless and polish comments - Move RVC code to the proper location after rebasing (#42) - Rename misc functions and change the positions of some comments - Remove remaining macros as discussions - Remain an 'minimum_alignment' unchanged - ... and 10 more: https://git.openjdk.java.net/riscv-port/compare/83e32f9f...37899306 ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/34/files - new: https://git.openjdk.java.net/riscv-port/pull/34/files/3496b133..37899306 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=17 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=16-17 Stats: 1413 lines in 103 files changed: 898 ins; 276 del; 239 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Mon Jan 17 12:17:12 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Mon, 17 Jan 2022 12:17:12 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v18] In-Reply-To: References: Message-ID: On Mon, 17 Jan 2022 03:09:25 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits: > > - Add an assertion for patchable jals' alignment > - Polish comments: remove the 'RVC:' prefix > - Polish `nmethod_entry_barrier` and RISC-V CAS related comments > - Remove `nmethod_entry_barrier`-related things > - Split c_ldsp and c_fldsp > - Remove useless and polish comments > - Move RVC code to the proper location after rebasing (#42) > - Rename misc functions and change the positions of some comments > - Remove remaining macros as discussions > - Remain an 'minimum_alignment' unchanged > - ... and 10 more: https://git.openjdk.java.net/riscv-port/compare/f26f83ff...37899306 Still some suggestions about the comments, otherwise looks good. src/hotspot/cpu/riscv/assembler_riscv.hpp line 2030: > 2028: // 2. RVC instructions in Assembler always begin with 'c_' prefix, as 'c_li', > 2029: // but most of time we have no need to explicitly use these instructions. > 2030: // 3. We introduce 'CompressibleRegion' to hint instructions in this Region's RTTI range Suggestion: // 3. 'CompressibleRegion' is introduced to hint instructions in this Region's RTTI range src/hotspot/cpu/riscv/assembler_riscv.hpp line 2031: > 2029: // but most of time we have no need to explicitly use these instructions. > 2030: // 3. We introduce 'CompressibleRegion' to hint instructions in this Region's RTTI range > 2031: // are qualified to change to their 2-byte versions. // are qualified to be compressed with their 2-byte versions. src/hotspot/cpu/riscv/assembler_riscv.hpp line 2038: > 2036: // > 2037: // 4. Using -XX:PrintAssemblyOptions=no-aliases could print RVC instructions instead of > 2038: // normal ones. Suggestion: // 4. Using -XX:PrintAssemblyOptions=no-aliases could distinguish RVC instructions from // normal ones. src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp line 1328: > 1326: // With RVC a call may get 2-byte aligned. > 1327: // the address of jal itself (which will be patched later) should not span the cache line. > 1328: // See CallStaticJavaDirectNode::compute_padding() for more info. Suggestion: // With RVC a call instruction (which will be patched later) may get 2-byte aligned and could // span multiple cache lines. See CallStaticJavaDirectNode::compute_padding() for more info. src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp line 1352: > 1350: void LIR_Assembler::emit_static_call_stub() { > 1351: address call_pc = __ pc(); > 1352: assert((__ offset() % 4) == 0, "call pc (patchable jals) must be aligned to maintain atomicity"); Suggestion: assert((__ offset() % 4) == 0, "call sites must be properly aligned"); src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp line 241: > 239: } > 240: > 241: // RISCV's amoswap instructions need a 4-byte alignment for the 4-byte word it swaps in memory Suggestion: // RISCV's amoswap instructions require that the memory address must be naturally aligned. src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp line 262: > 260: __ bind(guard); > 261: > 262: assert(__ offset() % 4 == 0, "RISCV CAS needs a 4-byte alignment for the 4-byte word it swaps in memory"); Suggestion: assert(__ offset() % 4 == 0, "bad alignment"); src/hotspot/cpu/riscv/riscv.ad line 1197: > 1195: // Patching this unaligned address will make the write operation not atomic. > 1196: // Other threads may be running the same piece of code at full speed, causing concurrency issues. > 1197: // So we must ensure that it does not span a cache line so that it can be patched. Suggestion: // With RVC a call site may get 2-byte aligned. // The offset encoding in jal instruction bits [12, 31] could span multiple cache lines. // Patching this jal instruction will not be atomic when its address is not naturally aligned. // Other threads may be running the same piece of code at the same time, thus causing concurrency issues. ------------- Changes requested by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Mon Jan 17 12:30:43 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 17 Jan 2022 12:30:43 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v19] In-Reply-To: References: Message-ID: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: Polish English comments as suggestions ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/34/files - new: https://git.openjdk.java.net/riscv-port/pull/34/files/37899306..502ff3d8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=18 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=34&range=17-18 Stats: 14 lines in 4 files changed: 0 ins; 2 del; 12 mod Patch: https://git.openjdk.java.net/riscv-port/pull/34.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/34/head:pull/34 PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Mon Jan 17 12:30:49 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Mon, 17 Jan 2022 12:30:49 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v18] In-Reply-To: References: Message-ID: On Mon, 17 Jan 2022 11:42:28 GMT, Fei Yang wrote: >> Xiaolin Zheng has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision: >> >> - Add an assertion for patchable jals' alignment >> - Polish comments: remove the 'RVC:' prefix >> - Polish `nmethod_entry_barrier` and RISC-V CAS related comments >> - Remove `nmethod_entry_barrier`-related things >> - Split c_ldsp and c_fldsp >> - Remove useless and polish comments >> - Move RVC code to the proper location after rebasing (#42) >> - Rename misc functions and change the positions of some comments >> - Remove remaining macros as discussions >> - Remain an 'minimum_alignment' unchanged >> - ... and 10 more: https://git.openjdk.java.net/riscv-port/compare/0e400fce...37899306 > > src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp line 1328: > >> 1326: // With RVC a call may get 2-byte aligned. >> 1327: // the address of jal itself (which will be patched later) should not span the cache line. >> 1328: // See CallStaticJavaDirectNode::compute_padding() for more info. > > Suggestion: > // With RVC a call instruction (which will be patched later) may get 2-byte aligned and could > // span multiple cache lines. See CallStaticJavaDirectNode::compute_padding() for more info. Thanks for spending time polishing my poor English :-) Revised all as suggestions, and it looks nicer than before. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From fyang at openjdk.java.net Tue Jan 18 06:55:56 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 18 Jan 2022 06:55:56 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v19] In-Reply-To: References: Message-ID: On Mon, 17 Jan 2022 12:30:43 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: > > Polish English comments as suggestions Approved. Thanks. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Tue Jan 18 06:55:57 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Tue, 18 Jan 2022 06:55:57 GMT Subject: [riscv-port] RFR: 8278994: riscv: RVC support [v19] In-Reply-To: References: Message-ID: On Mon, 17 Jan 2022 12:30:43 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. >> >> Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: > > Polish English comments as suggestions Thank you for the nice reviews, Felix and Yadong! ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From xlinzheng at openjdk.java.net Tue Jan 18 07:21:50 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Tue, 18 Jan 2022 07:21:50 GMT Subject: [riscv-port] Integrated: 8278994: riscv: RVC support In-Reply-To: References: Message-ID: On Mon, 20 Dec 2021 08:10:10 GMT, Xiaolin Zheng wrote: > Hi team, > > This patch includes the basic definition of the RVC instruction set and some cleanups. Tested a simple `test/hotspot/jtreg/compiler/` folder on qemu. > > Using `/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseRVC -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -XX:PrintAssemblyOptions=no-aliases,numeric -XX:+PrintStubCode -XX:-TieredCompilation` could show RVC instructions. > > Thanks, > Xiaolin This pull request has now been integrated. Changeset: fe82bcc1 Author: Xiaolin Zheng Committer: Yadong Wang URL: https://git.openjdk.java.net/riscv-port/commit/fe82bcc14bbe64d4fc568aa29f01d5f100d8a84d Stats: 1226 lines in 11 files changed: 1144 ins; 10 del; 72 mod 8278994: riscv: RVC support Co-authored-by: Wei Kuai Reviewed-by: fyang, yadongwang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34 From fjiang at openjdk.java.net Tue Jan 18 07:59:22 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Tue, 18 Jan 2022 07:59:22 GMT Subject: [riscv-port] RFR: 8280116: riscv: RVB: Add rest instructions of zba, zbb, and bitwise rotation Message-ID: This PR has the following changes: 1. Implement rest instructions of zba, zbb and bitwise rotation sub-extension 2. Add non-rvb version of AbsI/AbsL New C2 instructions are covered by the JTREG tests hotspot:tier1 ------------- Commit messages: - 8280116: riscv: RVB: Add rest instructions of zba, zbb, and bitwise rotation Changes: https://git.openjdk.java.net/riscv-port/pull/47/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=47&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280116 Stats: 180 lines in 3 files changed: 179 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/47.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/47/head:pull/47 PR: https://git.openjdk.java.net/riscv-port/pull/47 From fyang at openjdk.java.net Tue Jan 18 08:20:51 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Tue, 18 Jan 2022 08:20:51 GMT Subject: [riscv-port] RFR: 8280116: riscv: RVB: Add rest instructions of zba, zbb, and bitwise rotation In-Reply-To: References: Message-ID: On Tue, 18 Jan 2022 07:52:30 GMT, Feilong Jiang wrote: > This PR has the following changes: > 1. Implement rest instructions of zba, zbb and bitwise rotation sub-extension > 2. Add non-rvb version of AbsI/AbsL > > Within this PR, zba, zbb and bitwise rotation of RISC-V Bit-Manipulation are fully supported in riscv-port. > > New C2 instructions are covered by the JTREG tests hotspot:tier1 Looks good. Thanks. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/47 From duke at openjdk.java.net Tue Jan 18 08:35:27 2022 From: duke at openjdk.java.net (duke) Date: Tue, 18 Jan 2022 08:35:27 GMT Subject: git: openjdk/riscv-port: riscv-port: 25 new changesets Message-ID: <4d05af8c-0c42-4d1e-a89f-2c7fb512675b@openjdk.java.net> Changeset: c6196662 Author: Fei Gao Committer: Jie Fu Date: 2022-01-17 02:16:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c6196662b8a15276916badd333291057980a6552 8276673: Optimize abs operations in C2 compiler Reviewed-by: thartmann, jiefu ! src/hotspot/share/opto/subnode.cpp ! src/hotspot/share/opto/subnode.hpp ! src/hotspot/share/opto/type.hpp + test/hotspot/jtreg/compiler/c2/irTests/TestIRAbs.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java Changeset: 590eb860 Author: Aleksey Shipilev Date: 2022-01-17 08:17:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/590eb86033d5445018cd0e961e8721a20de4bb0c 8280016: gc/g1/TestShrinkAuxiliaryData30 test fails on large machines Reviewed-by: tschatzl, ayang + test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData27.java - test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData30.java Changeset: a30aa52b Author: Aleksey Shipilev Date: 2022-01-17 08:19:08 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a30aa52b77931bcea38213cf3d243d18a37dc858 8279958: Provide configure hints for Alpine/apk package managers Reviewed-by: erikj ! make/autoconf/help.m4 Changeset: 431bd9a6 Author: Albert Mingkun Yang Date: 2022-01-17 08:56:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/431bd9a66d759fcd014e9bfc15a0e12976802f06 8280001: Serial: Add documentation to heap memory layout Reviewed-by: mli, sjohanss, tschatzl ! src/hotspot/share/gc/serial/serialHeap.hpp Changeset: 71ca85f5 Author: Claes Redestad Date: 2022-01-17 11:01:55 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/71ca85f5a6741a2db55a529192564f94b269fbd9 8278831: Use table lookup for the last two bytes in Integer.getChars Reviewed-by: jlaskey, rriggs ! src/java.base/share/classes/java/lang/Integer.java ! src/java.base/share/classes/java/lang/Long.java ! src/java.base/share/classes/java/lang/StringUTF16.java ! test/micro/org/openjdk/bench/java/lang/Integers.java Changeset: 9e536b64 Author: Claes Redestad Date: 2022-01-17 11:03:10 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9e536b64705f841b224d0e64cad0f1609ebf5bca 8280032: Update jib-profiles.js to use JMH 1.34 devkit Reviewed-by: erikj, iris ! make/conf/jib-profiles.js Changeset: 3edcb132 Author: Albert Mingkun Yang Date: 2022-01-17 13:17:24 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3edcb13272c7d1a587e17fc16be523b3d73053ac 8280018: Remove obsolete VM_GenCollectFullConcurrent Reviewed-by: tschatzl ! src/hotspot/share/gc/shared/gcVMOperations.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/runtime/vmOperation.hpp Changeset: 5d52bf99 Author: Hamlin Li Date: 2022-01-17 14:33:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5d52bf9987445b3a6033d66e8644ed77c4d761bd 8279910: G1: Simplify HeapRegionRemSet::add_reference Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1OopClosures.inline.hpp ! src/hotspot/share/gc/g1/heapRegionRemSet.inline.hpp Changeset: 7b6738fa Author: Ana Marsh Committer: Thomas Schatzl Date: 2022-01-17 16:36:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7b6738fa02023825ed9e602555bd5ed2b87a6ca6 8278885: Remove Windows ARM64 int8_t workaround in G1 Reviewed-by: erikj, tschatzl, mli ! doc/building.html ! doc/building.md ! make/autoconf/toolchain_microsoft.m4 ! src/hotspot/share/gc/g1/g1HeapRegionAttr.hpp Changeset: 262f2efd Author: David Holmes Date: 2022-01-18 00:47:27 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/262f2efd6ce546b4ee8c9c045916c1a23ad14676 8280059: Incorrect glibc version is used in a comment in os_linux.cpp Reviewed-by: jiefu ! src/hotspot/os/linux/os_linux.cpp Changeset: 65eb066b Author: Christian Hagedorn Date: 2022-01-13 07:13:22 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/65eb066b630b892f22492457e0f86165e5ef4765 8279837: C2: assert(is_Loop()) failed: invalid node class: Region Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/loopTransform.cpp + test/hotspot/jtreg/compiler/loopopts/TestIterationSplitWithRegionHead.java Changeset: 33814791 Author: Thomas Schatzl Date: 2022-01-13 08:42:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/33814791d917b0c09909bf19b432dd8dfc6cd9db 8274007: [REDO] VM Exit does not abort concurrent mark Reviewed-by: sjohanss, iwalulya ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp Changeset: 14a90e53 Author: Aleksey Shipilev Date: 2022-01-13 08:51:35 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/14a90e536b86a8fb8d5f0272ec03359e44638da5 8279370: jdk.jpackage/share/native/applauncher/JvmLauncher.cpp fails to build with GCC 6.3.0 Reviewed-by: almatvee, asemenyuk ! src/jdk.jpackage/share/native/applauncher/JvmLauncher.cpp Changeset: ff856593 Author: Claes Redestad Date: 2022-01-13 15:25:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ff8565931115d581afff679ea85b1a2d80c03b99 8279833: Loop optimization issue in String.encodeUTF8_UTF16 Reviewed-by: rriggs Backport-of: c3d0a94040d9bd0f4b99da97b89fbfce252a41c0 ! src/java.base/share/classes/java/lang/String.java ! test/micro/org/openjdk/bench/java/lang/StringEncode.java Changeset: 37143c09 Author: Jesper Wilhelmsson Date: 2022-01-18 01:10:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/37143c09ab56ff07767ab3ac392234e36ee82358 Merge ! src/hotspot/share/gc/g1/g1ConcurrentMark.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp ! src/hotspot/share/opto/loopTransform.cpp Changeset: 064ee6ae Author: Naoto Sato Date: 2022-01-13 22:05:52 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/064ee6ae135366d59e9485b449a41d2b55811bbe 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java Backport-of: 8dc4437d002db5d025b47f48e7420e3bae55bdec ! src/java.base/share/classes/sun/util/cldr/CLDRTimeZoneNameProviderImpl.java ! test/jdk/java/time/test/java/time/format/TestZoneTextPrinterParser.java + test/micro/org/openjdk/bench/java/text/ZoneStrings.java Changeset: 45f20633 Author: Hao Sun Committer: Vladimir Kozlov Date: 2022-01-13 23:56:27 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/45f20633f66af51f017b884dc85637e8f3547d85 8279597: [TESTBUG] ReturnBlobToWrongHeapTest.java fails with -XX:TieredStopAtLevel=1 on machines with many cores Reviewed-by: kvn ! test/hotspot/jtreg/compiler/codecache/stress/ReturnBlobToWrongHeapTest.java Changeset: c6b02755 Author: Maurizio Cimadamore Date: 2022-01-14 11:15:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c6b027559c6e055b1475ada4001ef483b1a12d24 8279930: Synthetic cast causes generation of store barriers when using heap segments Reviewed-by: psandoz ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java ! src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/HeapMemorySegmentImpl.java + test/micro/org/openjdk/bench/jdk/incubator/foreign/LoopOverSlice.java Changeset: 4b520f00 Author: Johannes Bechberger Committer: Christoph Langer Date: 2022-01-14 13:53:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4b520f0001be5f33996d5ab7d9ad75773a847e54 8279702: [macosx] ignore xcodebuild warnings on M1 Reviewed-by: goetz, erikj ! make/autoconf/toolchain.m4 Changeset: c809d34f Author: Martin Doerr Date: 2022-01-14 14:12:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c809d34f9ec0d8e9f77adc73ee772ce90efbe58d 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks Reviewed-by: rrich, mbaesken ! src/hotspot/cpu/ppc/frame_ppc.cpp ! src/hotspot/cpu/s390/frame_s390.cpp Changeset: 09d61b61 Author: Daniel D. Daugherty Date: 2022-01-14 17:49:54 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/09d61b6187425ba528c568fb637087817ffb10c0 8280034: ProblemList jdk/jfr/api/consumer/recordingstream/TestOnEvent.java on linux-x64 Reviewed-by: ccheung ! test/jdk/ProblemList.txt Changeset: 4d9b3f4c Author: Aleksey Shipilev Date: 2022-01-17 08:20:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4d9b3f4ceef4b514ec943e1a5dd1147618376ad8 8279998: PPC64 debug builds fail with "untested: RangeCheckStub: predicate_failed_trap_id" Reviewed-by: goetz, mdoerr ! src/hotspot/cpu/ppc/c1_CodeStubs_ppc.cpp Changeset: 39f140a2 Author: Jesper Wilhelmsson Date: 2022-01-18 01:56:50 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/39f140a20120300074167597580f9be34e812cad Merge ! test/jdk/ProblemList.txt ! test/jdk/ProblemList.txt Changeset: 48c5f3c7 Author: Nils Eliasson Date: 2022-01-18 07:58:11 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/48c5f3c71519826d3510e5ac55980d10be763b17 8280026: Cleanup of IGV printing Reviewed-by: chagedorn, thartmann ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/compile.hpp ! src/hotspot/share/opto/matcher.cpp Changeset: 1b9ea497 Author: Fei Yang Date: 2022-01-18 03:30:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1b9ea49769c18e9f3df0e3062e012650f76f696e Merge branch 'master' into riscv-port ! src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp ! src/hotspot/cpu/riscv/riscv.ad ! src/hotspot/os/linux/os_linux.cpp + src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp + src/hotspot/cpu/riscv/riscv.ad ! src/hotspot/os/linux/os_linux.cpp From fjiang at openjdk.java.net Tue Jan 18 08:47:29 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Tue, 18 Jan 2022 08:47:29 GMT Subject: [riscv-port] RFR: 8280116: riscv: RVB: Add rest instructions of zba, zbb, and bitwise rotation [v2] In-Reply-To: References: Message-ID: > This PR has the following changes: > 1. Implement rest instructions of zba, zbb and bitwise rotation sub-extension > 2. Add non-rvb version of AbsI/AbsL > > Within this PR, zba, zbb and bitwise rotation of RISC-V Bit-Manipulation are fully supported in riscv-port. > > New C2 instructions are covered by the JTREG tests hotspot:tier1 Feilong Jiang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'riscv-port' of https://github.com/openjdk/riscv-port into rvb-rest - 8280116: riscv: RVB: Add rest instructions of zba, zbb, and bitwise rotation ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/47/files - new: https://git.openjdk.java.net/riscv-port/pull/47/files/33436edf..94becf2d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=47&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=47&range=00-01 Stats: 1146 lines in 44 files changed: 924 ins; 120 del; 102 mod Patch: https://git.openjdk.java.net/riscv-port/pull/47.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/47/head:pull/47 PR: https://git.openjdk.java.net/riscv-port/pull/47 From fjiang at openjdk.java.net Tue Jan 18 12:16:03 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Tue, 18 Jan 2022 12:16:03 GMT Subject: [riscv-port] RFR: 8280116: riscv: RVB: Add rest instructions of zba, zbb, and bitwise rotation [v2] In-Reply-To: References: Message-ID: On Tue, 18 Jan 2022 08:47:29 GMT, Feilong Jiang wrote: >> This PR has the following changes: >> 1. Implement rest instructions of zba, zbb and bitwise rotation sub-extension >> 2. Add non-rvb version of AbsI/AbsL >> >> Within this PR, zba, zbb and bitwise rotation of RISC-V Bit-Manipulation are fully supported in riscv-port. >> >> New C2 instructions are covered by the JTREG tests hotspot:tier1 >> >> Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. > > Feilong Jiang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'riscv-port' of https://github.com/openjdk/riscv-port into rvb-rest > - 8280116: riscv: RVB: Add rest instructions of zba, zbb, and bitwise rotation Thanks for reviews. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/47 From fjiang at openjdk.java.net Tue Jan 18 12:19:52 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Tue, 18 Jan 2022 12:19:52 GMT Subject: [riscv-port] Integrated: 8280116: riscv: RVB: Add rest instructions of zba, zbb, and bitwise rotation In-Reply-To: References: Message-ID: On Tue, 18 Jan 2022 07:52:30 GMT, Feilong Jiang wrote: > This PR has the following changes: > 1. Implement rest instructions of zba, zbb and bitwise rotation sub-extension > 2. Add non-rvb version of AbsI/AbsL > > Within this PR, zba, zbb and bitwise rotation of RISC-V Bit-Manipulation are fully supported in riscv-port. > > New C2 instructions are covered by the JTREG tests hotspot:tier1 > > Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures. This pull request has now been integrated. Changeset: 21a8e167 Author: Feilong Jiang Committer: Yanhong Zhu URL: https://git.openjdk.java.net/riscv-port/commit/21a8e1677d5c8459b895cc85abd64354517f7e45 Stats: 180 lines in 3 files changed: 179 ins; 0 del; 1 mod 8280116: riscv: RVB: Add rest instructions of zba, zbb, and bitwise rotation Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/47 From duke at openjdk.java.net Wed Jan 19 02:27:32 2022 From: duke at openjdk.java.net (duke) Date: Wed, 19 Jan 2022 02:27:32 GMT Subject: git: openjdk/riscv-port: riscv-port: 21 new changesets Message-ID: <42af2d11-27d5-4845-a36c-93bc93180b42@openjdk.java.net> Changeset: 94522626 Author: Masanori Yano Committer: Aleksei Efimov Date: 2022-01-18 09:04:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/945226265234b790b175ea312f7af1126984db68 8278892: java.naming module description is missing @uses tags to document the services that it uses Reviewed-by: aefimov, alanb ! src/java.naming/share/classes/module-info.java Changeset: eb949953 Author: Hamlin Li Date: 2022-01-18 09:16:24 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/eb9499535cde140c6bf16b3c4a8e9ee55412d0c3 8280070: G1: Fix template parameters in G1SegmentedArraySegment Reviewed-by: ayang, tschatzl ! src/hotspot/share/gc/g1/g1SegmentedArray.inline.hpp Changeset: 645b38d5 Author: Aleksey Shipilev Date: 2022-01-18 12:13:44 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/645b38d586b38252faa4663aca0453e3079fc30d 8280089: compiler/c2/irTests/TestIRAbs.java fails on some arches Reviewed-by: jiefu, thartmann, chagedorn, fgao ! test/hotspot/jtreg/compiler/c2/irTests/TestIRAbs.java Changeset: 1725f77b Author: Aleksey Shipilev Date: 2022-01-18 14:40:39 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1725f77bcd6528d56960a0796fcea3725cc98b6a 8280029: G1: "Overflow during reference processing, can not continue" on x86_32 Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/shared/gc_globals.hpp Changeset: d175d33f Author: Albert Mingkun Yang Date: 2022-01-18 14:53:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d175d33f44e996d2927f953dac2ad4fef542f2a0 8280079: Serial: Remove empty Generation::prepare_for_verify Reviewed-by: tschatzl, iwalulya ! src/hotspot/share/gc/serial/tenuredGeneration.cpp ! src/hotspot/share/gc/serial/tenuredGeneration.hpp ! src/hotspot/share/gc/shared/cardGeneration.cpp ! src/hotspot/share/gc/shared/cardGeneration.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/generation.hpp Changeset: 64c0c0e1 Author: Andrew Haley Date: 2022-01-18 15:27:18 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/64c0c0e109f9853072f1d306fef1a2e31568ec9e 8276563: Undefined Behaviour in class Assembler Reviewed-by: jvernee, stuefe ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! src/hotspot/cpu/aarch64/foreign_globals_aarch64.cpp ! src/hotspot/cpu/aarch64/globalDefinitions_aarch64.hpp ! src/hotspot/cpu/aarch64/jvmciCodeInstaller_aarch64.cpp ! src/hotspot/cpu/aarch64/register_aarch64.cpp ! src/hotspot/cpu/aarch64/register_aarch64.hpp ! src/hotspot/cpu/aarch64/vmreg_aarch64.inline.hpp ! src/hotspot/share/asm/register.hpp Changeset: 9eb50a5e Author: Andrey Turbanov Date: 2022-01-18 15:49:03 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9eb50a5ee4a069fbb248748ebee09132e2450420 8280010: Remove double buffering of InputStream for Properties.load Reviewed-by: amenkov, sspitsyn, serb ! src/java.base/share/classes/java/security/Security.java ! src/java.base/share/classes/sun/net/NetProperties.java ! src/java.base/share/classes/sun/net/www/MimeTable.java ! src/java.desktop/share/classes/sun/print/PSPrinterJob.java ! src/java.logging/share/classes/java/util/logging/LogManager.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSystemProperty.java ! src/jdk.management.agent/share/classes/jdk/internal/agent/Agent.java ! src/jdk.management.agent/share/classes/sun/management/jmxremote/ConnectorBootstrap.java Changeset: 9e3f68d8 Author: Vicente Romero Date: 2022-01-18 15:50:22 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9e3f68d8f41ff632ebf28a6f488f6a06754a088f 8279290: symbol not found error, implicit lambdas and diamond constructor invocations Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java + test/langtools/tools/javac/lambda/CantFindSymbolImplicitLambdaAndDiamondTest.java Changeset: 88a8b239 Author: Nils Eliasson Date: 2022-01-18 16:48:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/88a8b239aa9fbda3705c39dca7a102a19fc57659 8280076: Unify IGV and IR printing Reviewed-by: chagedorn, thartmann, vlivanov ! src/hotspot/share/compiler/compilerDirectives.hpp ! src/hotspot/share/compiler/compilerOracle.hpp ! src/hotspot/share/opto/c2_globals.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/compile.hpp ! src/hotspot/share/opto/idealGraphPrinter.cpp ! src/hotspot/share/opto/parse2.cpp Changeset: 7acc4c7d Author: Erik Gahlin Date: 2022-01-18 17:14:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7acc4c7dfe4b79e2bf1c993e84fd5fcd6855f292 8280058: JFR: StreamUtils::getJfrRepository(Process) should print stdout and stderr Reviewed-by: mgronlun ! test/lib/jdk/test/lib/jfr/StreamingUtils.java Changeset: b734dc86 Author: Erik Gahlin Date: 2022-01-18 17:57:12 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b734dc86ee261ecb4a5fbf4db7b3d9905c94191f 8280055: JFR: Improve ObjectContext implementation Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordedObject.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ObjectContext.java Changeset: 848b16a3 Author: Masanori Yano Committer: Lance Andersen Date: 2022-01-18 18:20:57 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/848b16a3f933c1cffbce93337a5d9b4e48ce4b45 8272746: ZipFile can't open big file (NegativeArraySizeException) Reviewed-by: lancea ! src/java.base/share/classes/java/util/zip/ZipFile.java + test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java Changeset: fd9fb9a4 Author: Chris Plummer Date: 2022-01-18 19:20:20 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/fd9fb9a4af149177c2a8d6ab20782d7a0b5bc113 8279194: Add Annotated Memory Viewer feature to SA's HSDB Reviewed-by: sspitsyn, ysuenaga ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HSDB.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/MemoryPanel.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/MemoryViewer.java Changeset: bdfa15d9 Author: Chris Plummer Date: 2022-01-18 19:21:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/bdfa15d92cb0e795d04431f82168644dee2da128 8250801: Add clhsdb "threadcontext" command Reviewed-by: sspitsyn, kevinw ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaThread.java + test/hotspot/jtreg/serviceability/sa/ClhsdbThreadContext.java Changeset: e314a4cf Author: Claes Redestad Date: 2022-01-18 19:28:12 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e314a4cfda30cc680b3f0aef8c62b75ff81bdbb1 8280124: Reduce branches decoding latin-1 chars from UTF-8 encoded bytes Reviewed-by: rriggs, alanb, naoto ! src/java.base/share/classes/java/lang/String.java ! test/micro/org/openjdk/bench/java/lang/StringDecode.java Changeset: 46fd6838 Author: Chris Plummer Date: 2022-01-18 19:31:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/46fd683820bb7149c0605a0ba03f59e76de69c16 8176567: nsk/jdi/ReferenceType/instances/instances002: TestFailure: Unexpected size of referenceType.instances(nsk.share.jdi.TestInterfaceImplementer1): 11, expected: 10 Reviewed-by: sspitsyn, amenkov ! src/jdk.jdwp.agent/share/native/libjdwp/invoker.c Changeset: 1a206287 Author: Coleen Phillimore Date: 2022-01-18 21:56:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1a206287576ec55d50d33c68b54647efc7fe32b0 8248404: AArch64: Remove uses of long and unsigned long Reviewed-by: kbarrett ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64_log.cpp ! src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp Changeset: 3a421e4b Author: John Jiang Date: 2022-01-18 22:40:14 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3a421e4b78ae5e7116ac68128504b65fa00e1f7f 8280122: SupportedGroupsExtension should output "named groups" rather than "versions" Reviewed-by: weijun, xuelei ! src/java.base/share/classes/sun/security/ssl/SupportedGroupsExtension.java Changeset: 4f4da3b1 Author: Ioi Lam Date: 2022-01-19 01:35:06 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4f4da3b172bb6ed5dd80a144e8eeb17b90bd7cdf 8275318: loaded_classes_do may see ArrayKlass before InstanceKlass is loaded Reviewed-by: coleenp, ccheung ! src/hotspot/share/classfile/classLoaderData.cpp Changeset: 4eb4f94d Author: sunguoyun Committer: Jie Fu Date: 2022-01-19 02:08:02 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4eb4f94db09cbd204fa228fc1eaac5153dfe3521 8279956: Useless method Scheduling::ComputeLocalLatenciesForward() Reviewed-by: jiefu, neliasso ! src/hotspot/share/opto/output.cpp Changeset: f49a3bc3 Author: Fei Yang Date: 2022-01-18 21:22:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f49a3bc3d042cd5f0e783b3e727b027f7527100c Merge branch 'master' into riscv-port ! src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp + src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp From fjiang at openjdk.java.net Wed Jan 19 09:06:21 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 19 Jan 2022 09:06:21 GMT Subject: [riscv-port] RFR: 8280236: riscv: Minimal build failed after JDK-8279565 Message-ID: After JDK-8279565, minimal build complains `'ror_imm' was not declared in this scope` error. The definition of `ror_imm` should move outside of the`COMPILER2` macro. ------------- Commit messages: - 8280236: riscv: Minimal build failed after JDK-8279565 Changes: https://git.openjdk.java.net/riscv-port/pull/48/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=48&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280236 Stats: 95 lines in 2 files changed: 17 ins; 17 del; 61 mod Patch: https://git.openjdk.java.net/riscv-port/pull/48.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/48/head:pull/48 PR: https://git.openjdk.java.net/riscv-port/pull/48 From fyang at openjdk.java.net Wed Jan 19 09:38:51 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Wed, 19 Jan 2022 09:38:51 GMT Subject: [riscv-port] RFR: 8280236: riscv: Minimal build failed after JDK-8279565 In-Reply-To: References: Message-ID: <6SKOgmGVX2SsN4XBCq0ZHBpdBBjmPF5_Z3-d0GUsj8g=.1ccf999e-1322-48e9-aee7-657dfb8c3b65@github.com> On Wed, 19 Jan 2022 08:59:46 GMT, Feilong Jiang wrote: > After JDK-8279565, minimal build complains `'ror_imm' was not declared in this scope` error. The definition of `ror_imm` should move outside of the`COMPILER2` macro. > > With this patch, minimal build passed without errors. Looks good. Thanks for the extra code cleanup. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/48 From fjiang at openjdk.java.net Thu Jan 20 00:28:14 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Thu, 20 Jan 2022 00:28:14 GMT Subject: [riscv-port] Integrated: 8280236: riscv: Minimal build failed after JDK-8279565 In-Reply-To: References: Message-ID: On Wed, 19 Jan 2022 08:59:46 GMT, Feilong Jiang wrote: > After JDK-8279565, minimal build complains `'ror_imm' was not declared in this scope` error. The definition of `ror_imm` should move outside of the`COMPILER2` macro. > > With this patch, minimal build passed without errors. This pull request has now been integrated. Changeset: d321f69e Author: Feilong Jiang Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/d321f69e96eb3eff0a844c995f7806b23b8a17fc Stats: 95 lines in 2 files changed: 17 ins; 17 del; 61 mod 8280236: riscv: Minimal build failed after JDK-8279565 Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/48 From duke at openjdk.java.net Thu Jan 20 07:34:48 2022 From: duke at openjdk.java.net (duke) Date: Thu, 20 Jan 2022 07:34:48 GMT Subject: git: openjdk/riscv-port: riscv-port: 61 new changesets Message-ID: Changeset: b0496b0d Author: Yumin Qi Date: 2022-01-19 03:21:19 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b0496b0df60cf19a0666f1f1c382f7bcd01e15bb 8279970: two AppCDS tests fail after JDK-8261455 Reviewed-by: ccheung, iklam ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveTestBase.java ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchive.java ! test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java Changeset: 44fe958c Author: TejeshR13 Committer: Prasanta Sadhukhan Date: 2022-01-19 05:33:24 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/44fe958c8a924dda436125716b164a335199e22b 6465404: some problems in CellEditor related API docs Reviewed-by: psadhukhan, aivanov, kizune, serb, prr ! src/java.desktop/share/classes/javax/swing/table/TableCellEditor.java Changeset: 5af7f258 Author: Andrey Turbanov Date: 2022-01-19 10:59:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5af7f258144d9f753ebe6ebfada42f33aaed108b 8274811: Remove superfluous use of boxing in java.base Reviewed-by: lancea ! src/java.base/linux/classes/sun/nio/fs/LinuxFileStore.java ! src/java.base/share/classes/java/util/ResourceBundle.java ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/java.base/share/classes/sun/util/locale/provider/LocaleResources.java Changeset: 39b1d75f Author: Thomas Stuefe Date: 2022-01-19 11:16:00 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/39b1d75f25ff2cc348f8b69d4e280847c6843ae2 8277822: Remove debug-only heap overrun checks in os::malloc and friends Reviewed-by: coleenp, zgu ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/runtime/os.hpp ! test/hotspot/jtreg/gtest/NMTGtests.java ! test/hotspot/jtreg/runtime/NMT/JcmdWithNMTDisabled.java ! test/hotspot/jtreg/runtime/NMT/PrintNMTStatisticsWithNMTDisabled.java Changeset: 68b40ec2 Author: Emanuel Peter Committer: Tobias Hartmann Date: 2022-01-19 11:47:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/68b40ec28658a2dd829c77281b0025e16095c170 8273139: C2: assert(f <= 1 && f >= 0) failed: Incorrect frequency Reviewed-by: thartmann, chagedorn, roland ! src/hotspot/share/opto/loopPredicate.cpp Changeset: 8931c122 Author: Matthias Baesken Date: 2022-01-19 12:01:10 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8931c12258a39cabda2cd1b92f54afcb216b882e 8280157: wrong texts Falied in a couple of tests Reviewed-by: egahlin, aivanov ! test/jdk/java/awt/Window/TranslucentShapedFrameTest/TranslucentShapedFrameTest.form ! test/jdk/java/awt/Window/TranslucentShapedFrameTest/TranslucentShapedFrameTest.java ! test/jdk/java/io/OutputStreamWriter/WriteAfterClose.java ! test/jdk/jdk/jfr/api/consumer/TestRecordedFullStackTrace.java ! test/jdk/jdk/jfr/event/profiling/TestFullStackTrace.java Changeset: cc2f474c Author: Albert Mingkun Yang Date: 2022-01-19 12:02:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cc2f474c18082413420b353528198883055de73a 8280024: Parallel: Remove unnecessary region resizing methods in PSCardTable Reviewed-by: tschatzl, mli ! src/hotspot/share/gc/parallel/psCardTable.cpp ! src/hotspot/share/gc/parallel/psCardTable.hpp Changeset: 96114315 Author: Harold Seigel Date: 2022-01-19 13:51:23 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/96114315cf91b03aeca7e12f225e4c76862f1be7 8279936: Change shared code to use os:: system API's Reviewed-by: dholmes, kbarrett ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/classfile/compactHashtable.cpp ! src/hotspot/share/compiler/compileLog.cpp ! src/hotspot/share/utilities/vmError.cpp ! test/hotspot/gtest/logging/logTestUtils.inline.hpp ! test/hotspot/gtest/logging/test_asynclog.cpp ! test/hotspot/gtest/logging/test_log.cpp ! test/hotspot/gtest/logging/test_logTagSetDescriptions.cpp Changeset: b20b11cf Author: Daniel Jelinski Committer: Erik Joelsson Date: 2022-01-19 14:18:14 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b20b11cf8215238e5cd51a1d3a331d5cbfdad710 8258240: make vscode-project on Windows generates jdk.code-workspace file with unescaped '\' in paths Reviewed-by: erikj ! make/ide/vscode/hotspot/CreateVSCodeProject.gmk Changeset: e20c6bf9 Author: Erik Gahlin Date: 2022-01-19 15:35:57 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e20c6bf972a106105733c395877d11d9c894eb28 8280189: JFR: TestPrintXML should print mismatching XML Reviewed-by: mgronlun ! test/jdk/jdk/jfr/tool/TestPrintXML.java Changeset: 610a1290 Author: Jonathan Gibbons Date: 2022-01-19 17:56:25 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/610a12904d834507754e6d6171a4b8df7e6aa6b0 8268831: Improve javadoc tool handling of streams. Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/JavadocLog.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/JavadocTool.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ToolEnvironment.java Changeset: 84fa0d8c Author: Alisen Chung Committer: Alexey Ivanov Date: 2022-01-19 19:12:35 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/84fa0d8c7d0e1be19e48464801d81efa8c263793 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel Co-authored-by: Alexey Ivanov Reviewed-by: kizune, serb, aivanov ! src/java.desktop/macosx/classes/com/apple/laf/AquaScrollBarUI.java + test/jdk/java/awt/Scrollbar/AquaLFScrollbarTest/ScrollBarBorderTest.java Changeset: dac15efc Author: Liam Miller-Cushon Date: 2022-01-19 20:17:14 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/dac15efc1be8fe49d2f6365f9adfb31dc3ea74ba 8280182: HotSpot Style Guide has stale link to chromium style guide Reviewed-by: dholmes ! doc/hotspot-style.html ! doc/hotspot-style.md Changeset: 5523ddeb Author: Alexandre Iline Date: 2022-01-19 21:02:08 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5523ddebd572f38c3f960950d114ffead33266ae 8279641: Create manual JTReg tests for Swing accessibility Reviewed-by: serb, prr + test/jdk/javax/accessibility/manual/ButtonDemo.html + test/jdk/javax/accessibility/manual/ButtonDemo.java + test/jdk/javax/accessibility/manual/ComboBoxDemo.html + test/jdk/javax/accessibility/manual/ComboBoxDemo.java + test/jdk/javax/accessibility/manual/DemoSelection.html + test/jdk/javax/accessibility/manual/DemoSelection.java + test/jdk/javax/accessibility/manual/OptionPaneDemo.html + test/jdk/javax/accessibility/manual/OptionPaneDemo.java + test/jdk/javax/accessibility/manual/README.md + test/jdk/javax/accessibility/manual/SwingSetTest.java + test/jdk/javax/accessibility/manual/TableDemo.html + test/jdk/javax/accessibility/manual/TableDemo.java + test/jdk/javax/accessibility/manual/TabsDemo.html + test/jdk/javax/accessibility/manual/TabsDemo.java + test/jdk/javax/accessibility/manual/TreeDemo.html + test/jdk/javax/accessibility/manual/TreeDemo.java + test/jdk/javax/accessibility/manual/lib/DescriptionPane.java + test/jdk/javax/accessibility/manual/lib/FailureReasonPane.java + test/jdk/javax/accessibility/manual/lib/ManualTestFrame.java + test/jdk/javax/accessibility/manual/lib/PassFailPane.java + test/jdk/javax/accessibility/manual/lib/ScreenImagePane.java + test/jdk/javax/accessibility/manual/lib/TestResult.java + test/jdk/javax/accessibility/manual/resource/btn.png + test/jdk/javax/accessibility/manual/resource/cmb.png + test/jdk/javax/accessibility/manual/resource/dep.png + test/jdk/javax/accessibility/manual/resource/dms.png + test/jdk/javax/accessibility/manual/resource/hc.jpg + test/jdk/javax/accessibility/manual/resource/if.png + test/jdk/javax/accessibility/manual/resource/ifm.png + test/jdk/javax/accessibility/manual/resource/list.png + test/jdk/javax/accessibility/manual/resource/op.png + test/jdk/javax/accessibility/manual/resource/rbtn.png + test/jdk/javax/accessibility/manual/resource/tbl.png + test/jdk/javax/accessibility/manual/resource/tbld.png + test/jdk/javax/accessibility/manual/resource/tree.png Changeset: 6179e13b Author: Erik Gahlin Date: 2022-01-19 22:23:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6179e13b084a64a3ad247ced8d314e425a6e0596 8266410: jdk/jfr/javaagent/TestLoadedAgent.java failed with "Mismatch in TestEvent count" Reviewed-by: mgronlun ! test/jdk/jdk/jfr/javaagent/EventEmitterAgent.java Changeset: d1efb0cc Author: Gerard Ziemski Date: 2022-01-19 22:34:54 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d1efb0cc56127a40f2b23ccc608b27be2b39a389 8267341: macos attempt_reserve_memory_at(arg1, arg2, true) failure Reviewed-by: dcubed, dholmes ! test/hotspot/gtest/runtime/test_os.cpp Changeset: 98d96a77 Author: Weijun Wang Date: 2022-01-19 23:06:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/98d96a770756ffe3e7f5e4b82120e9fb484cad9a 8279796: Fix typo: Constucts -> Constructs Reviewed-by: iris ! src/java.security.sasl/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java Changeset: e38df216 Author: Markus Gr?nlund Date: 2022-01-18 13:16:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e38df21641f13d7ae92f72cf8e72660072d3e5fe 8256291: RunThese30M fails "assert(_class_unload ? true : ((((JfrTraceIdBits::load(class_loader_klass)) & ((1 << 4) << 8)) != 0))) failed: invariant" Reviewed-by: egahlin ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdLoadBarrier.inline.hpp Changeset: bd35f974 Author: Erik Gahlin Date: 2022-01-18 16:55:06 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/bd35f9740dce8865b9a8cdb582c771279ab02d76 8278628: jdk/jfr/jmx/streaming/TestMaxSize.java Expected only one or two chunks Reviewed-by: mgronlun ! test/jdk/jdk/jfr/jmx/streaming/TestMaxSize.java Changeset: 20ef9541 Author: Aleksandr Veselov Committer: Anton Tarasov Date: 2022-01-18 18:51:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/20ef954158bc5a339118640946b39047fe853ae4 8279227: Access Bridge: Wrong frame position and hit test result on HiDPI display Reviewed-by: ant, kizune, aivanov ! src/jdk.accessibility/windows/classes/com/sun/java/accessibility/internal/AccessBridge.java Changeset: feff0e55 Author: Roger Riggs Committer: Henry Jen Date: 2021-06-09 14:29:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/feff0e5578769c003af5bb817c2be89c8121708d 8264934: Enhance cross VM serialization Reviewed-by: smarks, rhalade, chegar ! src/java.base/share/classes/java/io/ObjectInputStream.java Changeset: 29f61b3b Author: Patrick Concannon Committer: Henry Jen Date: 2021-07-14 13:41:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/29f61b3b0a5b2dcfef125363da3b5338dcc7de94 8269944: Better HTTP transport redux Reviewed-by: dfuchs, chegar, rhalade, ahgross ! src/jdk.httpserver/share/classes/sun/net/httpserver/FixedLengthInputStream.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/FixedLengthOutputStream.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/Request.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/ServerImpl.java Changeset: f18deeb6 Author: Valerie Peng Committer: Henry Jen Date: 2021-07-23 18:04:54 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f18deeb69e8d2fa34b9c747226bbe3567116ae8f 8268488: More valuable DerValues Reviewed-by: weijun, ahgross, rhalade ! src/java.base/share/classes/com/sun/crypto/provider/KeyProtector.java ! src/java.base/share/classes/com/sun/crypto/provider/OAEPParameters.java ! src/java.base/share/classes/sun/security/pkcs/SignerInfo.java ! src/java.base/share/classes/sun/security/rsa/PSSParameters.java Changeset: e069a3b8 Author: Hai-May Chao Committer: Henry Jen Date: 2021-07-29 19:20:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e069a3b8bfe67a7ffda635e92b4777e9cfeaf136 8268512: More content for ContentInfo Reviewed-by: ahgross, weijun, rhalade ! src/java.base/share/classes/sun/security/pkcs/ContentInfo.java Changeset: 7ee905a8 Author: Joe Wang Committer: Henry Jen Date: 2021-08-05 19:05:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7ee905a8a09c92b9534a440660d37c28cf5d797b 8270498: Improve SAX Parser configuration management Reviewed-by: ahgross, lancea, rhalade, naoto ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java Changeset: 1fddb03d Author: Harold Seigel Committer: Henry Jen Date: 2021-08-11 16:48:14 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1fddb03d93a024b66ce02598e1057b2b09a5073f 8271968: Better canonical naming Reviewed-by: coleenp, lfoltan, mschoene, ahgross ! src/hotspot/share/classfile/classFileParser.cpp Changeset: 9a94fbc7 Author: Phil Race Committer: Henry Jen Date: 2021-08-16 18:19:08 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9a94fbc793feb855e974c3814fe030f2671ed830 8270952: Improve TIFF file handling Reviewed-by: jdv, psadhukhan, mschoene, rhalade ! src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFNullDecompressor.java Changeset: fa47c368 Author: Ioi Lam Committer: Henry Jen Date: 2021-08-16 19:37:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/fa47c368d470f59f3c98e6e8a7ff82371d3389df 8270386: Better verification of scan methods Reviewed-by: hseigel, coleenp, mschoene, rhalade ! src/hotspot/share/oops/instanceKlass.cpp Changeset: b02ea6dc Author: Joe Wang Committer: Henry Jen Date: 2021-08-17 04:34:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b02ea6dc3ca2e2a8c21ed76f28422a6f8bf2fa00 8270646: Improved scanning of XML entities Reviewed-by: naoto, lancea, mschoene, rhalade ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XML11DocumentScannerImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XML11EntityScanner.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLScanner.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/XMLStringBuffer.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xni/XMLString.java Changeset: afd0dc76 Author: Phil Race Committer: Henry Jen Date: 2021-08-17 20:56:54 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/afd0dc76b684f03d2de665f3150c93ce17bafbe0 8271962: Better TrueType font loading Reviewed-by: psadhukhan, jdv, mschoene, rhalade ! src/java.desktop/share/classes/sun/font/TrueTypeFont.java Changeset: 51816035 Author: Kevin Walls Committer: Henry Jen Date: 2021-08-20 07:46:35 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/518160353a96a75fd666f0e426ad649fb58f5fc5 8272272: Enhance jcmd communication Reviewed-by: amenkov ! src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c Changeset: c372990f Author: Vladimir Ivanov Committer: Henry Jen Date: 2021-08-20 11:09:25 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c372990f5f520f03159a6586862191e3f15ef6df 8268494: Better inlining of inlined interfaces Reviewed-by: thartmann, jcm, ahgross, rhalade ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/code/dependencies.cpp ! src/hotspot/share/code/dependencies.hpp ! src/hotspot/share/opto/doCall.cpp Changeset: 6b6f829b Author: Anthony Scarpino Committer: Henry Jen Date: 2021-08-23 16:06:31 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6b6f829b46ef158775e66f36336895080cab9df6 8269151: Better construction of EncryptedPrivateKeyInfo Reviewed-by: jnimeh, mschoene, rhalade ! src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java Changeset: 5832a344 Author: Julia Boes Committer: Henry Jen Date: 2021-08-25 11:41:26 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/5832a3440489d0967dc3b0542c1ace51eed292d6 8270416: Enhance construction of Identity maps Reviewed-by: dfuchs, chegar, rhalade, ahgross, smarks, robm ! src/java.base/share/classes/java/util/Hashtable.java ! src/java.base/share/classes/java/util/IdentityHashMap.java ! test/jdk/java/util/Hashtable/DeserializedLength.java Changeset: 4be02d31 Author: Harold Seigel Committer: Henry Jen Date: 2021-09-02 18:09:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4be02d31554b8d3bb84789923cf64a7dc4707eff 8271987: Manifest improved manifest entries Reviewed-by: rhalade, dholmes ! src/hotspot/share/classfile/classLoader.cpp Changeset: aa28430b Author: Ian Graves Committer: Henry Jen Date: 2021-09-02 19:20:30 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/aa28430bdd8a5778f2e4307f198177b69eac9410 8268813: Better String matching Reviewed-by: mschoene, rhalade, smarks ! src/java.base/share/classes/java/util/regex/Pattern.java Changeset: 3adc1117 Author: Roger Riggs Committer: Henry Jen Date: 2021-09-03 19:10:21 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3adc1117661ac0e9c819d6d9b32dd8a8a19a61ed 8272236: Improve serial forms for transport Reviewed-by: bchristi, rhalade, smarks ! src/java.base/share/classes/java/io/ObjectInputStream.java Changeset: 78b2c841 Author: Joe Wang Committer: Henry Jen Date: 2021-09-09 17:41:56 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/78b2c8419bc69436873e6fc9c542480949d140c5 8270492: Better resolution of URIs Reviewed-by: lancea, naoto, ahgross, rhalade ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/LoadDocument.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/SystemIDResolver.java Changeset: ae7877df Author: Alexander Zuev Committer: Henry Jen Date: 2021-09-14 23:19:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ae7877df2e417acecb2fd8d03dec2e5eac4e8879 8273290: Enhance sound handling Reviewed-by: rhalade, ahgross, prr, jdv ! src/java.desktop/share/classes/com/sun/media/sound/StandardMidiFileReader.java ! src/java.desktop/share/classes/com/sun/media/sound/WaveFloatFileReader.java Changeset: cb7482d5 Author: Christian Hagedorn Committer: Henry Jen Date: 2021-09-20 07:35:25 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cb7482d5bdb7e0e275ae179ae57b56e881180523 8272014: Better array indexing Reviewed-by: thartmann, rhalade, ahgross, kvn ! src/hotspot/cpu/aarch64/c1_LIRGenerator_aarch64.cpp ! src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp Changeset: 4d3663a6 Author: Weijun Wang Committer: Henry Jen Date: 2021-09-20 15:12:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4d3663a6d0620103f10b2f7fad50ae84d38f33e2 8272026: Verify Jar Verification Reviewed-by: rhalade, valeriep, mschoene ! src/java.base/share/classes/java/util/jar/Attributes.java Changeset: 12034273 Author: Alexander Zuev Committer: Henry Jen Date: 2021-09-22 17:39:28 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/12034273c7b3f9da565da6a12a26b9493d813cf8 8272462: Enhance image handling Reviewed-by: jdv, ahgross, rhalade, prr ! src/java.desktop/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java Changeset: 9c02c4c5 Author: Jayathirth D V Committer: Henry Jen Date: 2021-09-23 12:34:20 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9c02c4c55f571363cbc430a26d795d10cff93819 8273756: Enhance BMP image support Reviewed-by: prr, rhalade, kizune, mschoene ! src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java Changeset: abf6fdd7 Author: Joe Wang Committer: Henry Jen Date: 2021-09-24 18:55:03 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/abf6fdd75a5362970d3d4bb5f46bbb4815d6b458 8273968: JCK javax_xml tests fail in CI Reviewed-by: naoto, lancea ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java Changeset: 4525a4b9 Author: Julia Boes Committer: Henry Jen Date: 2021-09-27 08:59:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4525a4b94dc2e856e74101ab3cbc1f6ffe365f37 8270392: Improve String constructions Reviewed-by: rhalade, dfuchs, robm, ahgross, smarks ! src/java.base/share/classes/java/lang/StringBuffer.java ! src/java.base/share/classes/java/lang/StringBuilder.java Changeset: a6fd2c31 Author: Jayathirth D V Committer: Henry Jen Date: 2021-09-28 03:05:14 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a6fd2c311457db024cb699adabd195302885034a 8273838: Enhanced BMP processing Reviewed-by: rhalade, ahgross, prr, kizune, azvegint, mschoene ! src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java Changeset: 3603e754 Author: Christian Hagedorn Committer: Henry Jen Date: 2021-09-29 08:33:39 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3603e754cedb5d77a8563ba9da7846ba3b335712 8274374: Additional fix for JDK-8272014 Reviewed-by: kvn, thartmann ! src/hotspot/cpu/aarch64/c1_LIRGenerator_aarch64.cpp Changeset: 82d6afe6 Author: Jayathirth D V Committer: Henry Jen Date: 2021-10-11 15:52:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/82d6afe6759b3768748126171ff3c6d59e8724d5 8274096: Improve decoding of image files Reviewed-by: prr, kizune, rhalade, mschoene ! src/java.desktop/share/classes/com/sun/imageio/plugins/common/ReaderUtil.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFDecompressor.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFFaxDecompressor.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFLZWDecompressor.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFPackBitsDecompressor.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFYCbCrDecompressor.java Changeset: 6d3fd860 Author: Christian Hagedorn Committer: Henry Jen Date: 2022-01-04 10:48:28 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6d3fd860d748a092a65ab9700b47686099b81bf4 8278417: Closed test fails after JDK-8276108 on aarch64 Reviewed-by: kvn, iveresov, dlong ! src/hotspot/cpu/aarch64/c1_LIRGenerator_aarch64.cpp Changeset: af6c9aba Author: Fei Gao Committer: Ningsheng Jian Date: 2022-01-19 01:20:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/af6c9abafaa3b8f9bdcc938fec465aeeed8b30ed 8279654: jdk/incubator/vector/Vector256ConversionTests.java crashes randomly with SVE Reviewed-by: njian, kvn ! src/hotspot/cpu/aarch64/aarch64.ad Changeset: 69cfa9cb Author: Kim Barrett Date: 2022-01-19 04:37:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/69cfa9cb36ab2b5490c231c30306f682665faab4 8273383: vmTestbase/vm/gc/containers/Combination05/TestDescription.java crashes verifying length of DCQS Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp Changeset: f37bfead Author: Martin Doerr Date: 2022-01-19 08:28:31 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f37bfeadcf036a75defc64ad7f4a9f5596cd7407 8280155: [PPC64, s390] frame size checks are not yet correct Reviewed-by: mbaesken, lucy ! src/hotspot/cpu/ppc/frame_ppc.cpp ! src/hotspot/cpu/s390/frame_s390.cpp ! src/hotspot/os_cpu/linux_ppc/thread_linux_ppc.cpp Changeset: 28e02fa2 Author: Aleksey Shipilev Date: 2022-01-19 12:01:05 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/28e02fa2cb40267136c88a507696ec3e610e95a3 8280234: AArch64 "core" variant does not build after JDK-8270947 Reviewed-by: adinn, aph ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp Changeset: f5de6fa7 Author: Daniel D. Daugherty Date: 2022-01-19 17:37:36 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f5de6fa7995fa1e82c8d969692392465b963ac35 8272058: 25 Null pointer dereference defect groups in 4 files Reviewed-by: gziemski, coleenp, dlong ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp Changeset: be0538d7 Author: Jan Lahoda Date: 2022-01-19 19:03:02 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/be0538d7c8e2cbfa599dbcb4c5c69533678a8421 8278834: Error "Cannot read field "sym" because "this.lvar[od]" is null" when compiling Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java + test/langtools/tools/javac/patterns/BindingsInitializer.java Changeset: 03680bea Author: Michael McMahon Date: 2022-01-19 19:48:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/03680bea1cca1113ea23a1eb7a413b93dd73c381 8280233: Temporarily disable Unix domain sockets in Windows PipeImpl Reviewed-by: alanb ! src/java.base/windows/classes/sun/nio/ch/PipeImpl.java Changeset: 4616c13c Author: Jesper Wilhelmsson Date: 2022-01-20 01:18:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4616c13c2f1ced8a8bdeed81f0469523932e91b5 Merge ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/java.base/share/classes/com/sun/crypto/provider/OAEPParameters.java ! src/java.base/share/classes/java/io/ObjectInputStream.java ! src/java.base/share/classes/java/util/regex/Pattern.java ! src/java.base/share/classes/sun/security/rsa/PSSParameters.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java ! src/java.desktop/share/classes/com/sun/media/sound/StandardMidiFileReader.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/ServerImpl.java ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/java.base/share/classes/com/sun/crypto/provider/OAEPParameters.java ! src/java.base/share/classes/java/io/ObjectInputStream.java ! src/java.base/share/classes/java/util/regex/Pattern.java ! src/java.base/share/classes/sun/security/rsa/PSSParameters.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java ! src/java.desktop/share/classes/com/sun/media/sound/StandardMidiFileReader.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/ServerImpl.java Changeset: c4a624d4 Author: Prasanta Sadhukhan Date: 2022-01-20 04:13:50 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c4a624d46332552e7baca8ee09bfdce0e53eef05 8279894: javax/swing/JInternalFrame/8020708/bug8020708.java timeouts on Windows 11 Reviewed-by: serb, kizune ! test/jdk/javax/swing/JInternalFrame/8020708/bug8020708.java Changeset: 1022cbdf Author: Prasanta Sadhukhan Date: 2022-01-20 04:16:11 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1022cbdf987af846e79b92dfa20b763db7563320 8280047: Broken link to Swing Connection document from javax.swing package docs Reviewed-by: kcr, aivanov ! src/java.desktop/share/classes/javax/swing/package-info.java Changeset: e683d4ac Author: Jaikiran Pai Date: 2022-01-20 04:49:52 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e683d4ac8d9ee3b0078c5e87a2b3e7d36d7344fc 8279921: Dump the .class file in jlink debug mode for any failure during transform() of a plugin Reviewed-by: mchung ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/AbstractPlugin.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripJavaDebugAttributesPlugin.java Changeset: 3f82c394 Author: Fei Yang Date: 2022-01-20 02:29:29 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3f82c394ed968c914a26b6ba12268da86ddc6869 Merge branch 'master' into riscv-port ! src/hotspot/cpu/riscv/c1_LIRAssembler_arith_riscv.cpp ! src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp ! src/hotspot/cpu/riscv/c1_LIRGenerator_riscv.cpp ! src/hotspot/cpu/riscv/c1_Runtime1_riscv.cpp ! src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/interp_masm_riscv.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/stubGenerator_riscv.cpp ! src/hotspot/os_cpu/linux_riscv/os_linux_riscv.cpp + src/hotspot/cpu/riscv/c1_LIRAssembler_arith_riscv.cpp + src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp + src/hotspot/cpu/riscv/c1_LIRGenerator_riscv.cpp + src/hotspot/cpu/riscv/c1_Runtime1_riscv.cpp + src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp + src/hotspot/cpu/riscv/interp_masm_riscv.cpp + src/hotspot/cpu/riscv/macroAssembler_riscv.cpp + src/hotspot/cpu/riscv/stubGenerator_riscv.cpp + src/hotspot/os_cpu/linux_riscv/os_linux_riscv.cpp From xlinzheng at openjdk.java.net Thu Jan 20 15:08:39 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Thu, 20 Jan 2022 15:08:39 GMT Subject: [riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 Message-ID: Hi team, This is a preview fix for the JFR-related crash - maybe the comment in this patch should be polished. TIL that complex problems often result from seemingly negligible changes :-) I need to cautiously test this change, though it seems no harm, to guarantee that it is safe and to ensure the problem is gone so please stay a little tuned. Thanks, Xiaolin ------------- Commit messages: - Fix sp-related undefined behavior Changes: https://git.openjdk.java.net/riscv-port/pull/49/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=49&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279664 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/riscv-port/pull/49.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/49/head:pull/49 PR: https://git.openjdk.java.net/riscv-port/pull/49 From yadongwang at openjdk.java.net Fri Jan 21 02:12:03 2022 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Fri, 21 Jan 2022 02:12:03 GMT Subject: [riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 In-Reply-To: References: Message-ID: On Thu, 20 Jan 2022 15:02:20 GMT, Xiaolin Zheng wrote: > Hi team, > > This is a preview fix for the JFR-related crash - maybe the comment in this patch should be polished. > TIL that complex problems often result from seemingly negligible changes :-) > I need to cautiously test this change, though it seems no harm, to guarantee that it is safe and to ensure the problem is gone so please stay a little tuned. > > Thanks, > Xiaolin @zhengxiaolinX Nice catch. In fact, we fixed a similar bug before, and unfortunately missed here. ------------- Marked as reviewed by yadongwang (Committer). PR: https://git.openjdk.java.net/riscv-port/pull/49 From duke at openjdk.java.net Fri Jan 21 02:22:29 2022 From: duke at openjdk.java.net (duke) Date: Fri, 21 Jan 2022 02:22:29 GMT Subject: git: openjdk/riscv-port: riscv-port: 16 new changesets Message-ID: Changeset: 0bf95a1a Author: Zhiqiang Zang Committer: Tobias Hartmann Date: 2022-01-20 07:38:04 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0bf95a1a7327cc4899863143e2dfdf3d87dbdf0c 8279607: Existing optimization "~x+1" -> "-x" can be generalized to "~x+c" -> "(c-1)-x". Reviewed-by: thartmann, kvn ! src/hotspot/share/opto/addnode.cpp + test/hotspot/jtreg/compiler/c2/irTests/TestIRAddIdealNotXPlusC.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java + test/micro/org/openjdk/bench/vm/compiler/AddIdealNotXPlusC.java Changeset: cf977e88 Author: Sergey Tsypanov Committer: Julia Boes Date: 2022-01-20 09:14:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cf977e88ecc64b549f332efe01578fca9f435060 8276166: Remove dead code from MimeTable and MimeEntry Reviewed-by: dfuchs ! src/java.base/share/classes/sun/net/www/MimeEntry.java ! src/java.base/share/classes/sun/net/www/MimeTable.java Changeset: 3f747368 Author: Vladimir Ivanov Date: 2022-01-20 11:23:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3f747368b9a5c321d2724ba57103f17edc166251 8280123: C2: Infinite loop in CMoveINode::Ideal during IGVN Reviewed-by: kvn, thartmann, chagedorn ! src/hotspot/share/opto/movenode.cpp + test/hotspot/jtreg/compiler/c2/TestCMoveInfiniteGVN.java Changeset: 20297dea Author: Julia Boes Date: 2022-01-20 12:16:21 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/20297deaeb64fb1e025ed1fcde19867c6875f9a0 8280161: com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java fails with SSLException Reviewed-by: dfuchs ! test/jdk/com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java Changeset: 98b157a7 Author: Albert Mingkun Yang Date: 2022-01-20 12:33:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/98b157a79af3e76f028bccd04a5e505642aae7a4 8280146: Parallel: Remove time log tag Reviewed-by: tschatzl, iwalulya ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psScavenge.cpp ! src/hotspot/share/logging/logPrefix.hpp ! src/hotspot/share/logging/logTag.hpp Changeset: a4d20190 Author: Harold Seigel Date: 2022-01-20 13:10:33 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a4d201909c8919b7465dee72594d718252c6344e 8280178: Remove os:: API's that just call system API's Reviewed-by: iklam, ccheung, dholmes ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/posix/perfMemory_posix.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/classfile/compactHashtable.cpp ! src/hotspot/share/compiler/compileLog.cpp ! src/hotspot/share/compiler/directivesParser.cpp ! src/hotspot/share/include/cds.h ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp ! src/hotspot/share/jfr/writers/jfrStreamWriterHost.inline.hpp ! src/hotspot/share/memory/virtualspace.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/runtime/os.hpp ! src/hotspot/share/services/heapDumperCompression.cpp ! src/hotspot/share/utilities/ostream.cpp ! src/hotspot/share/utilities/vmError.cpp Changeset: ec8b6acf Author: Hannes Walln?fer Date: 2022-01-20 16:17:08 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ec8b6acff39953ca60309c6f1db7ae4c93404da9 8234682: The order of @param in the generated docs should match the method signature Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ParamTaglet.java ! test/langtools/jdk/javadoc/doclet/testParamTaglet/TestParamTaglet.java ! test/langtools/jdk/javadoc/doclet/testParamTaglet/pkg/C.java ! test/langtools/jdk/javadoc/doclet/testParamTaglet/pkg/Parent.java Changeset: 0ea2b390 Author: Xue-Lei Andrew Fan Date: 2022-01-20 16:50:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0ea2b39035f1b535a53770379c94ae43f0ddb8b6 8280363: Minor correction of ALPN specification in SSLParameters Reviewed-by: dfuchs, mullan ! src/java.base/share/classes/javax/net/ssl/SSLParameters.java Changeset: 96365026 Author: Albert Mingkun Yang Date: 2022-01-20 17:18:54 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9636502658c0844c5790cf37af4b15163bf9fa61 8279008: G1: Calculate BOT threshold on-the-fly during Object Copy phase Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1Allocator.cpp ! src/hotspot/share/gc/g1/g1Allocator.hpp ! src/hotspot/share/gc/g1/g1Allocator.inline.hpp ! src/hotspot/share/gc/g1/g1BlockOffsetTable.hpp ! src/hotspot/share/gc/g1/g1BlockOffsetTable.inline.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.hpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegion.hpp ! src/hotspot/share/gc/g1/heapRegion.inline.hpp ! src/hotspot/share/gc/shared/plab.hpp Changeset: d48279b0 Author: Yumin Qi Date: 2022-01-20 17:52:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d48279b0bf9ee9d18ac764776a655c44fa020509 8279009: CDS crashes when the source of an InstanceKlass is NULL Reviewed-by: iklam, ccheung ! src/hotspot/share/cds/classListWriter.cpp + test/hotspot/jtreg/runtime/cds/appcds/ClassListWithCustomClassNoSource.java + test/hotspot/jtreg/runtime/cds/appcds/ClassSpecializerTestApp.java ! test/hotspot/jtreg/runtime/cds/appcds/CommandLineFlagCombo.java + test/hotspot/jtreg/runtime/cds/appcds/TestDumpClassListSource.java Changeset: 3419ff7b Author: Andrey Turbanov Date: 2022-01-20 18:11:55 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/3419ff7ba70b778906249dd5ab3a91998ca5a864 8277535: Remove redundant Stream.distinct()/sorted() steps Reviewed-by: prappo ! src/java.base/share/classes/jdk/internal/module/ModulePath.java ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ModuleDotGraph.java ! src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java Changeset: 02390c79 Author: Quan Anh Mai Committer: Sandhya Viswanathan Date: 2022-01-20 18:24:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/02390c79b1acff1a953d29c6f70623f3b7838698 8279282: [vectorapi] Matcher::supports_vector_comparison_unsigned is not needed on x86 Reviewed-by: kvn, sviswanathan, vlivanov ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/matcher_x86.hpp ! src/hotspot/cpu/x86/x86.ad Changeset: 2426d58e Author: Alexey Ivanov Date: 2022-01-20 20:12:11 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2426d58e592c54de64ebe0f06448d239aeced082 8278472: Invalid value set to CANDIDATEFORM structure Reviewed-by: prr, naoto, serb ! src/java.desktop/windows/native/libawt/windows/awt_Component.cpp Changeset: 293fb46f Author: Daniel D. Daugherty Date: 2022-01-20 20:27:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/293fb46f7cd28f2a08055e3eb8ec9459d64e9688 8280413: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on all X64 platforms Reviewed-by: azvegint ! test/jdk/ProblemList.txt Changeset: 35ee0f38 Author: Yi-Fan Tsai Committer: Paul Hohensee Date: 2022-01-20 23:46:26 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/35ee0f38c6d5e35fb50a059a189e032df7f7e7c5 8258814: Compilation logging crashes for thread suspension / debugging tests Reviewed-by: xliu, phh ! src/hotspot/share/compiler/compileBroker.cpp Changeset: 414c5802 Author: Fei Yang Date: 2022-01-20 21:20:52 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/414c58026b7a4e27f63f52cce4434e2258050816 Merge branch 'master' into riscv-port ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/arguments.cpp From fyang at openjdk.java.net Fri Jan 21 03:07:19 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 21 Jan 2022 03:07:19 GMT Subject: [riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 In-Reply-To: References: Message-ID: On Thu, 20 Jan 2022 15:02:20 GMT, Xiaolin Zheng wrote: > Hi team, > > This is a preview fix for the JFR-related crash - maybe the comment in this patch should be polished. > TIL that complex problems often result from seemingly negligible changes :-) > I need to cautiously test this change, though it seems no harm, to guarantee that it is safe and to ensure the problem is gone so please stay a little tuned. > > ---- > Update: > > 1. Overnight JFR testing reveals no error, seems fixed. > 2. `test/hotspot/jtreg` on the board reveals no error until now - still testing, but I think it is safe. > ---- > > Thanks, > Xiaolin Great catch. This aligns with function "enter()" which creates stack frames. Looks good. src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 63: > 61: > 62: void leave() { > 63: // Note: setting sp above the address of alive variables could result in undefined behaviors: I would suggest move this code comment before function "void enter()" in the same file. Maybe rephrasing like this: "SP must be updated to the right place before saving/restoring RA and FP because signal based thread suspend/resume could happen asynchronously." ------------- Changes requested by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/49 From xlinzheng at openjdk.java.net Fri Jan 21 03:14:36 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Fri, 21 Jan 2022 03:14:36 GMT Subject: [riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 [v2] In-Reply-To: References: Message-ID: > Hi team, > > This is a preview fix for the JFR-related crash - maybe the comment in this patch should be polished. > TIL that complex problems often result from seemingly negligible changes :-) > I need to cautiously test this change, though it seems no harm, to guarantee that it is safe and to ensure the problem is gone so please stay a little tuned. > > ---- > Update: > > 1. Overnight JFR testing reveals no error, seems fixed. > 2. `test/hotspot/jtreg` on the board reveals no error until now - still testing, but I think it is safe. > ---- > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: Polish comments ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/49/files - new: https://git.openjdk.java.net/riscv-port/pull/49/files/7c7a1426..9ae33721 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=49&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=49&range=00-01 Stats: 5 lines in 1 file changed: 2 ins; 2 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/49.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/49/head:pull/49 PR: https://git.openjdk.java.net/riscv-port/pull/49 From xlinzheng at openjdk.java.net Fri Jan 21 03:14:37 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Fri, 21 Jan 2022 03:14:37 GMT Subject: [riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 [v2] In-Reply-To: References: Message-ID: On Fri, 21 Jan 2022 03:01:43 GMT, Fei Yang wrote: >> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: >> >> Polish comments > > src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 63: > >> 61: >> 62: void leave() { >> 63: // Note: setting sp above the address of alive variables could result in undefined behaviors: > > I would suggest move this code comment before function "void enter()" in the same file. > Maybe rephrasing like this: > "SP must be updated to the right place before saving/restoring RA and FP because signal > based thread suspend/resume could happen asynchronously." Thanks for the suggestion, changed. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/49 From fyang at openjdk.java.net Fri Jan 21 03:18:12 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 21 Jan 2022 03:18:12 GMT Subject: [riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 [v2] In-Reply-To: References: Message-ID: On Fri, 21 Jan 2022 03:09:30 GMT, Xiaolin Zheng wrote: >> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 63: >> >>> 61: >>> 62: void leave() { >>> 63: // Note: setting sp above the address of alive variables could result in undefined behaviors: >> >> I would suggest move this code comment before function "void enter()" in the same file. >> Maybe rephrasing like this: >> "SP must be updated to the right place before saving/restoring RA and FP because signal >> based thread suspend/resume could happen asynchronously." > > Thanks for the suggestion, changed. I think it's better to go like this: // Stack frame creation/removal // Note that SP must be updated to the right place before saving/restoring RA and FP // because signal based thread suspend/resume could happen asynchronously. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/49 From xlinzheng at openjdk.java.net Fri Jan 21 03:21:49 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Fri, 21 Jan 2022 03:21:49 GMT Subject: [riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 [v3] In-Reply-To: References: Message-ID: <1YK5fYFp_-I0r0kqNuOhx-d63zoYHq36aE4EpfNXHqE=.e430ff89-16d1-4103-867c-93b545aabc58@github.com> > Hi team, > > This is a preview fix for the JFR-related crash - maybe the comment in this patch should be polished. > TIL that complex problems often result from seemingly negligible changes :-) > I need to cautiously test this change, though it seems no harm, to guarantee that it is safe and to ensure the problem is gone so please stay a little tuned. > > ---- > Update: > > 1. Overnight JFR testing reveals no error, seems fixed. > 2. `test/hotspot/jtreg` on the board reveals no error until now - still testing, but I think it is safe. > ---- > > Thanks, > Xiaolin Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: Polish comments ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/49/files - new: https://git.openjdk.java.net/riscv-port/pull/49/files/9ae33721..dd8b495e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=49&range=02 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=49&range=01-02 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/riscv-port/pull/49.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/49/head:pull/49 PR: https://git.openjdk.java.net/riscv-port/pull/49 From xlinzheng at openjdk.java.net Fri Jan 21 03:21:49 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Fri, 21 Jan 2022 03:21:49 GMT Subject: [riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 [v3] In-Reply-To: References: Message-ID: On Fri, 21 Jan 2022 03:14:52 GMT, Fei Yang wrote: >> Thanks for the suggestion, changed. > > I think it's better to go like this: > > // Stack frame creation/removal > // Note that SP must be updated to the right place before saving/restoring RA and FP > // because signal based thread suspend/resume could happen asynchronously. Thank you, changed. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/49 From fyang at openjdk.java.net Fri Jan 21 03:48:07 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 21 Jan 2022 03:48:07 GMT Subject: [riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 [v3] In-Reply-To: <1YK5fYFp_-I0r0kqNuOhx-d63zoYHq36aE4EpfNXHqE=.e430ff89-16d1-4103-867c-93b545aabc58@github.com> References: <1YK5fYFp_-I0r0kqNuOhx-d63zoYHq36aE4EpfNXHqE=.e430ff89-16d1-4103-867c-93b545aabc58@github.com> Message-ID: On Fri, 21 Jan 2022 03:21:49 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This is a preview fix for the JFR-related crash - maybe the comment in this patch should be polished. >> TIL that complex problems often result from seemingly negligible changes :-) >> I need to cautiously test this change, though it seems no harm, to guarantee that it is safe and to ensure the problem is gone so please stay a little tuned. >> >> ---- >> Update: >> >> 1. Overnight JFR testing reveals no error, seems fixed. >> 2. `test/hotspot/jtreg` on the board reveals no error until now - still testing, but I think it is safe. >> ---- >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: > > Polish comments I see JFR works quite stable with some non-trivial benchmark workload. So good to go. Thanks. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/49 From xlinzheng at openjdk.java.net Fri Jan 21 03:48:08 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Fri, 21 Jan 2022 03:48:08 GMT Subject: [riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 [v3] In-Reply-To: <1YK5fYFp_-I0r0kqNuOhx-d63zoYHq36aE4EpfNXHqE=.e430ff89-16d1-4103-867c-93b545aabc58@github.com> References: <1YK5fYFp_-I0r0kqNuOhx-d63zoYHq36aE4EpfNXHqE=.e430ff89-16d1-4103-867c-93b545aabc58@github.com> Message-ID: <5UxJxCD5La90vnkwAVRABYTBQZiDvk0a21GtMBl9API=.9f9f0a64-664c-4f44-9acd-dc8260861a79@github.com> On Fri, 21 Jan 2022 03:21:49 GMT, Xiaolin Zheng wrote: >> Hi team, >> >> This is a preview fix for the JFR-related crash - maybe the comment in this patch should be polished. >> TIL that complex problems often result from seemingly negligible changes :-) >> I need to cautiously test this change, though it seems no harm, to guarantee that it is safe and to ensure the problem is gone so please stay a little tuned. >> >> ---- >> Update: >> >> 1. Overnight JFR testing reveals no error, seems fixed. >> 2. `test/hotspot/jtreg` on the board reveals no error until now - still testing, but I think it is safe. >> ---- >> >> Thanks, >> Xiaolin > > Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision: > > Polish comments Thanks for the fast reviews, team! ------------- PR: https://git.openjdk.java.net/riscv-port/pull/49 From xlinzheng at openjdk.java.net Fri Jan 21 03:51:16 2022 From: xlinzheng at openjdk.java.net (Xiaolin Zheng) Date: Fri, 21 Jan 2022 03:51:16 GMT Subject: [riscv-port] Integrated: 8279664: riscv: JFR crashes at 0x0 In-Reply-To: References: Message-ID: On Thu, 20 Jan 2022 15:02:20 GMT, Xiaolin Zheng wrote: > Hi team, > > This is a preview fix for the JFR-related crash - maybe the comment in this patch should be polished. > TIL that complex problems often result from seemingly negligible changes :-) > I need to cautiously test this change, though it seems no harm, to guarantee that it is safe and to ensure the problem is gone so please stay a little tuned. > > ---- > Update: > > 1. Overnight JFR testing reveals no error, seems fixed. > 2. `test/hotspot/jtreg` on the board reveals no error until now - still testing, but I think it is safe. > ---- > > Thanks, > Xiaolin This pull request has now been integrated. Changeset: 29384f99 Author: Xiaolin Zheng Committer: Fei Yang URL: https://git.openjdk.java.net/riscv-port/commit/29384f99736a1b614ebbafde19503c30f841b544 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod 8279664: riscv: JFR crashes at 0x0 Reviewed-by: yadongwang, fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/49 From fjiang at openjdk.java.net Fri Jan 21 07:06:29 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 21 Jan 2022 07:06:29 GMT Subject: [riscv-port] RFR: 8280423: riscv: Unnecessary i2l conversion in LIRGenerator::emit_array_address Message-ID: This fix is similar with JDK-8278417, which calls `generate_address` directly to generate address for array access. All jtregs were tested on QEMU passed without new failures. ------------- Commit messages: - 8280423: riscv: Unnecessary i2l conversion in LIRGenerator::emit_array_address Changes: https://git.openjdk.java.net/riscv-port/pull/50/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=50&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280423 Stats: 18 lines in 1 file changed: 3 ins; 14 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/50.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/50/head:pull/50 PR: https://git.openjdk.java.net/riscv-port/pull/50 From fjiang at openjdk.java.net Fri Jan 21 07:12:24 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 21 Jan 2022 07:12:24 GMT Subject: [riscv-port] RFR: 8280423: riscv: Unnecessary i2l conversion in LIRGenerator::emit_array_address In-Reply-To: References: Message-ID: On Fri, 21 Jan 2022 06:59:27 GMT, Feilong Jiang wrote: > This fix is similar with JDK-8278417, which calls `generate_address` directly to generate address for array access. > > All jtregs were tested on QEMU passed without new failures. Closed due to the same name of source and target branch. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/50 From fjiang at openjdk.java.net Fri Jan 21 07:12:24 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 21 Jan 2022 07:12:24 GMT Subject: [riscv-port] Withdrawn: 8280423: riscv: Unnecessary i2l conversion in LIRGenerator::emit_array_address In-Reply-To: References: Message-ID: On Fri, 21 Jan 2022 06:59:27 GMT, Feilong Jiang wrote: > This fix is similar with JDK-8278417, which calls `generate_address` directly to generate address for array access. > > All jtregs were tested on QEMU passed without new failures. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/50 From fjiang at openjdk.java.net Fri Jan 21 07:13:32 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 21 Jan 2022 07:13:32 GMT Subject: [riscv-port] RFR: 8280423: riscv: Unnecessary i2l conversion in LIRGenerator::emit_array_address Message-ID: This fix is similar with JDK-8278417, which calls generate_address directly to generate address for array access. All jtregs were tested on QEMU passed without new failures. ------------- Commit messages: - 8280423: riscv: Unnecessary i2l conversion in LIRGenerator::emit_array_address Changes: https://git.openjdk.java.net/riscv-port/pull/51/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=51&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280423 Stats: 18 lines in 1 file changed: 3 ins; 14 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/51.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/51/head:pull/51 PR: https://git.openjdk.java.net/riscv-port/pull/51 From fyang at openjdk.java.net Fri Jan 21 08:13:05 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 21 Jan 2022 08:13:05 GMT Subject: [riscv-port] RFR: 8280423: riscv: Unnecessary i2l conversion in LIRGenerator::emit_array_address In-Reply-To: References: Message-ID: On Fri, 21 Jan 2022 07:08:50 GMT, Feilong Jiang wrote: > On RISC-V, operands with `T_INT` type are sign-extended implicitly when defined, so i2l conversion is unnecessary. > This fix is similar with JDK-8278417, which calls generate_address directly to generate address for array access. > > All jtregs were tested on QEMU without new failures. Looks reasonable. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/51 From yzhu at openjdk.java.net Fri Jan 21 08:32:09 2022 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 21 Jan 2022 08:32:09 GMT Subject: [riscv-port] RFR: 8280423: riscv: Unnecessary i2l conversion in LIRGenerator::emit_array_address In-Reply-To: References: Message-ID: On Fri, 21 Jan 2022 07:08:50 GMT, Feilong Jiang wrote: > On RISC-V, operands with `T_INT` type are sign-extended implicitly when defined, so i2l conversion is unnecessary. > This fix is similar with JDK-8278417, which calls generate_address directly to generate address for array access. > > All jtregs were tested on QEMU without new failures. Looks good. ------------- Marked as reviewed by yzhu (Committer). PR: https://git.openjdk.java.net/riscv-port/pull/51 From fjiang at openjdk.java.net Fri Jan 21 08:32:11 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 21 Jan 2022 08:32:11 GMT Subject: [riscv-port] RFR: 8280423: riscv: Unnecessary i2l conversion in LIRGenerator::emit_array_address In-Reply-To: References: Message-ID: On Fri, 21 Jan 2022 08:09:51 GMT, Fei Yang wrote: >> On RISC-V, operands with `T_INT` type are sign-extended implicitly when defined, so i2l conversion is unnecessary. >> This fix is similar with JDK-8278417, which calls generate_address directly to generate address for array access. >> >> All jtregs were tested on QEMU without new failures. > > Looks reasonable. Thanks for the reviews. @RealFYang @yhzhu20 ------------- PR: https://git.openjdk.java.net/riscv-port/pull/51 From fjiang at openjdk.java.net Fri Jan 21 08:36:23 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Fri, 21 Jan 2022 08:36:23 GMT Subject: [riscv-port] Integrated: 8280423: riscv: Unnecessary i2l conversion in LIRGenerator::emit_array_address In-Reply-To: References: Message-ID: On Fri, 21 Jan 2022 07:08:50 GMT, Feilong Jiang wrote: > On RISC-V, operands with `T_INT` type are sign-extended implicitly when defined, so i2l conversion is unnecessary. > This fix is similar with JDK-8278417, which calls generate_address directly to generate address for array access. > > All jtregs were tested on QEMU without new failures. This pull request has now been integrated. Changeset: c9b0030b Author: Feilong Jiang Committer: Yanhong Zhu URL: https://git.openjdk.java.net/riscv-port/commit/c9b0030b26040fa0934ca58e8b92cc6781148af2 Stats: 18 lines in 1 file changed: 3 ins; 14 del; 1 mod 8280423: riscv: Unnecessary i2l conversion in LIRGenerator::emit_array_address Reviewed-by: fyang, yzhu ------------- PR: https://git.openjdk.java.net/riscv-port/pull/51 From yzhu at openjdk.java.net Sat Jan 22 03:53:51 2022 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Sat, 22 Jan 2022 03:53:51 GMT Subject: [riscv-port] RFR: 8280424: riscv: fix saved_fp for compiled frame in frame::safe_for_sender Message-ID: <5a7xyGcUQKBxshcXfWeKNZM3dUyUzeWbUSr87acGxDM=.8ffeeee6-02da-454b-b3bc-45e8c0fa7852@github.com> Some places are missed updating when refactoring riscv stack frame previously. We need to update calculation of saved_fp for compiled frame in frame::safe_for_sender. Previous riscv stack frame patch: https://github.com/openjdk/jdk-sandbox/commit/db2415748747a0912749bb8fc160a8948021a924 All jtregs were tested on QEMU without new failures. ------------- Commit messages: - 8280424: riscv: fix saved_fp for compiled frame in frame::safe_for_sender Changes: https://git.openjdk.java.net/riscv-port/pull/52/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=52&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280424 Stats: 20 lines in 3 files changed: 0 ins; 10 del; 10 mod Patch: https://git.openjdk.java.net/riscv-port/pull/52.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/52/head:pull/52 PR: https://git.openjdk.java.net/riscv-port/pull/52 From fyang at openjdk.java.net Sat Jan 22 07:05:31 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Sat, 22 Jan 2022 07:05:31 GMT Subject: [riscv-port] RFR: 8280424: riscv: fix saved_fp for compiled frame in frame::safe_for_sender In-Reply-To: <5a7xyGcUQKBxshcXfWeKNZM3dUyUzeWbUSr87acGxDM=.8ffeeee6-02da-454b-b3bc-45e8c0fa7852@github.com> References: <5a7xyGcUQKBxshcXfWeKNZM3dUyUzeWbUSr87acGxDM=.8ffeeee6-02da-454b-b3bc-45e8c0fa7852@github.com> Message-ID: <0jCEqa4LY3HUZn7l7H8FItGQ1L11KCEc2bCggi7whII=.a96dfbf3-0489-4e6c-bc48-7d27235542bb@github.com> On Sat, 22 Jan 2022 03:47:25 GMT, Yanhong Zhu wrote: > Some places are missed updating when refactoring riscv stack frame previously. > > We need to update calculation of saved_fp for compiled frame in frame::safe_for_sender. > > Previous riscv stack frame patch: > https://github.com/openjdk/jdk-sandbox/commit/db2415748747a0912749bb8fc160a8948021a924 > > All jtregs were tested on QEMU without new failures. Looks reasonable. Thanks for fixing this. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/52 From yzhu at openjdk.java.net Sat Jan 22 07:11:38 2022 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Sat, 22 Jan 2022 07:11:38 GMT Subject: [riscv-port] Integrated: 8280424: riscv: fix saved_fp for compiled frame in frame::safe_for_sender In-Reply-To: <5a7xyGcUQKBxshcXfWeKNZM3dUyUzeWbUSr87acGxDM=.8ffeeee6-02da-454b-b3bc-45e8c0fa7852@github.com> References: <5a7xyGcUQKBxshcXfWeKNZM3dUyUzeWbUSr87acGxDM=.8ffeeee6-02da-454b-b3bc-45e8c0fa7852@github.com> Message-ID: On Sat, 22 Jan 2022 03:47:25 GMT, Yanhong Zhu wrote: > Some places are missed updating when refactoring riscv stack frame previously. > > We need to update calculation of saved_fp for compiled frame in frame::safe_for_sender. > > Previous riscv stack frame patch: > https://github.com/openjdk/jdk-sandbox/commit/db2415748747a0912749bb8fc160a8948021a924 > > All jtregs were tested on QEMU without new failures. This pull request has now been integrated. Changeset: 2afd2d29 Author: Yanhong Zhu URL: https://git.openjdk.java.net/riscv-port/commit/2afd2d29dc046479800ed47cfd78edf28f9ed88d Stats: 20 lines in 3 files changed: 0 ins; 10 del; 10 mod 8280424: riscv: fix saved_fp for compiled frame in frame::safe_for_sender Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/52 From duke at openjdk.java.net Sat Jan 22 07:55:01 2022 From: duke at openjdk.java.net (duke) Date: Sat, 22 Jan 2022 07:55:01 GMT Subject: git: openjdk/riscv-port: riscv-port: 9 new changesets Message-ID: <4b5b3c1b-1964-4768-9858-cf1af4ed45ec@openjdk.java.net> Changeset: 6352c020 Author: Weijun Wang Date: 2022-01-21 03:16:08 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6352c020c25f2701afb4fabee0cc7fcef2d407fb 8280401: [sspi] gss_accept_sec_context leaves output_token uninitialized Reviewed-by: valeriep ! src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp Changeset: 19f87798 Author: Roland Westrelin Date: 2022-01-21 07:32:08 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/19f877981edf1db41b98c3b370d81c26d6617e49 8278784: C2: Refactor PhaseIdealLoop::remix_address_expressions() so it operates on longs Reviewed-by: chagedorn, thartmann ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/loopopts.cpp ! src/hotspot/share/opto/mulnode.cpp ! src/hotspot/share/opto/mulnode.hpp + test/hotspot/jtreg/compiler/c2/irTests/TestRemixAddressExpressions.java Changeset: 47b1c51b Author: Andrey Turbanov Date: 2022-01-21 08:53:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/47b1c51bbd28582d209db07052e553a76acced65 8277120: Use Optional.isEmpty instead of !Optional.isPresent in java.net.http Reviewed-by: dfuchs ! src/java.net.http/share/classes/jdk/internal/net/http/AuthenticationFilter.java ! src/java.net.http/share/classes/jdk/internal/net/http/HttpRequestImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/Utils.java ! src/java.net.http/share/classes/jdk/internal/net/http/websocket/BuilderImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/websocket/OpeningHandshake.java Changeset: ab2c8d3c Author: Hannes Walln?fer Date: 2022-01-21 09:10:19 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ab2c8d3c9baf1080f436287785e4e02fd79953a7 8280393: Promote use of HtmlTree factory methods Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialFieldWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialMethodWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/IndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SubWriterHolderWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Table.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTree.java Changeset: 6287ae37 Author: KIRIYAMA Takuya Committer: David Holmes Date: 2022-01-21 13:36:29 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6287ae3707bac091b37cd5693ca77e2349a903ef 8277531: Print actual default stacksize on Windows thread logging Reviewed-by: dholmes, stuefe ! src/hotspot/os/windows/os_windows.cpp ! test/hotspot/jtreg/runtime/logging/ThreadLoggingTest.java Changeset: 2920ce54 Author: Yi-Fan Tsai Committer: Paul Hohensee Date: 2022-01-21 18:09:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2920ce54874c404126d9fd6bfbebee5f3da27dae 8278036: Saving rscratch1 is optional in MacroAssembler::verify_heapbase Reviewed-by: xliu, phh, coleenp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp Changeset: c1e4f3dd Author: Joe Darcy Date: 2022-01-21 18:55:25 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c1e4f3dd1b42474c9abc22c7b981a98f9c36e0d5 8279397: Update --release 18 symbol information for JDK 18 build 32 Reviewed-by: iris, jlahoda ! make/data/symbols/java.base-I.sym.txt Changeset: b9ae7790 Author: Calvin Cheung Date: 2022-01-21 23:47:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b9ae77906e9c886ee239871b75c183c5ec7ae846 8279675: CDS cannot handle non-existent JAR file in bootclassapth Reviewed-by: iklam, minqi ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/cds/filemap.hpp ! test/hotspot/jtreg/runtime/cds/appcds/NonExistClasspath.java ! test/hotspot/jtreg/runtime/cds/appcds/PrintSharedArchiveAndExit.java ! test/hotspot/jtreg/runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java Changeset: b569dd8d Author: Fei Yang Date: 2022-01-22 02:51:59 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b569dd8d5e5d233916252c2949123f11eec64960 Merge branch 'master' into riscv-port From duke at openjdk.java.net Tue Jan 25 01:48:10 2022 From: duke at openjdk.java.net (duke) Date: Tue, 25 Jan 2022 01:48:10 GMT Subject: git: openjdk/riscv-port: riscv-port: 28 new changesets Message-ID: <454bfaf6-df69-45cd-881a-f5755ad33efb@openjdk.java.net> Changeset: 54c9de26 Author: Andrey Turbanov Date: 2022-01-22 13:56:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/54c9de26aba24ff5496f97dd6cb95075ab6b9777 8275918: Remove unused local variables in java.base security code Reviewed-by: weijun ! src/java.base/macosx/classes/apple/security/KeychainStore.java ! src/java.base/share/classes/com/sun/crypto/provider/BlowfishCrypt.java ! src/java.base/share/classes/java/security/AccessControlContext.java ! src/java.base/share/classes/sun/security/pkcs10/PKCS10.java ! src/java.base/share/classes/sun/security/rsa/RSAPSSSignature.java ! src/java.base/share/classes/sun/security/rsa/RSAPrivateCrtKeyImpl.java ! src/java.base/share/classes/sun/security/ssl/DHServerKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/SSLEngineInputRecord.java ! src/java.base/share/classes/sun/security/x509/CRLNumberExtension.java ! src/java.base/share/classes/sun/security/x509/DeltaCRLIndicatorExtension.java ! src/java.base/share/classes/sun/security/x509/GeneralSubtrees.java ! src/java.base/share/classes/sun/security/x509/X509CertInfo.java ! src/java.base/share/classes/sun/security/x509/X509Key.java Changeset: 30cd47d4 Author: Jie Fu Date: 2022-01-24 04:37:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/30cd47d42124540303e5f5dbbd509b58d8fb90a0 8280499: runtime/cds/appcds/TestDumpClassListSource.java fails on platforms without AppCDS custom class loaders support Reviewed-by: iklam ! test/hotspot/jtreg/runtime/cds/appcds/TestDumpClassListSource.java Changeset: 9bf6ffa1 Author: Xin Liu Date: 2022-01-24 05:05:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9bf6ffa19f1ea9efcadb3396d921305c9ec0b1d1 8279124: VM does not handle SIGQUIT during initialization Reviewed-by: dholmes, stuefe ! src/hotspot/os/posix/signals_posix.cpp Changeset: d1569111 Author: Aleksey Shipilev Date: 2022-01-24 09:18:20 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d1569111d7077dd95b95aea6c42616f85d85e781 8280459: Suspicious integer division in Hashtable.readHashtable Reviewed-by: rriggs, bpb ! src/java.base/share/classes/java/util/Hashtable.java Changeset: 0567a84d Author: Jie Fu Date: 2022-01-24 10:52:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0567a84d49fccda139388c22d1fc14e4aea6002b 8280457: Duplicate implementation of dprecision_rounding and dstore_rounding Reviewed-by: vlivanov, shade ! src/hotspot/share/gc/shared/c2/barrierSetC2.cpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/graphKit.hpp ! src/hotspot/share/opto/parse2.cpp Changeset: 7a0a6c95 Author: Dmitry Markov Date: 2022-01-24 10:55:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7a0a6c95a53c6cb3340328d6543a97807320b740 8274751: Drag And Drop hangs on Windows Reviewed-by: aivanov, prr, serb ! src/java.desktop/windows/native/libawt/windows/awt_DnDDS.cpp ! src/java.desktop/windows/native/libawt/windows/awt_DnDDT.cpp ! src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp ! src/java.desktop/windows/native/libawt/windows/awt_Toolkit.h Changeset: f05ff996 Author: Andrey Turbanov Date: 2022-01-24 11:10:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f05ff996543d0239383d8b363fdbba15769c4aae 8280174: Possible NPE in Thread.dispatchUncaughtException Reviewed-by: alanb ! src/java.base/share/classes/java/lang/Thread.java Changeset: afd2805e Author: Roman Kennke Date: 2022-01-24 11:16:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/afd2805ef2fe72aee04b84956dba5bb5c012ff3c 8279534: Consolidate and remove oopDesc::klass_gap methods Reviewed-by: shade, dholmes ! src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp Changeset: 4501ddda Author: Harold Seigel Date: 2022-01-24 13:33:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4501ddda7f8e0eb9352a937030a62902bfaac647 8214733: runtime/8176717/TestInheritFD.java timed out Reviewed-by: lmesnik, coleenp, dcubed ! test/hotspot/jtreg/runtime/8176717/TestInheritFD.java Changeset: 44db4794 Author: Zhengyu Gu Date: 2022-01-24 13:34:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/44db4794d29c6e0755a6dc0ea1346f48f918155b 8280391: NMT: Correct NMT tag on CollectedHeap Reviewed-by: kbarrett, tschatzl, mli ! src/hotspot/share/gc/shared/collectedHeap.hpp Changeset: 18c9cb07 Author: Jan Lahoda Date: 2022-01-24 13:52:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/18c9cb07891cdd68c06385a28af16e3931b84317 8280067: Incorrect code generated for unary - on char operand Reviewed-by: jlaskey, vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Items.java + test/langtools/tools/javac/code/CharImmediateValue.java Changeset: d53d8bd7 Author: Dmitry Kulikov Committer: Erik Joelsson Date: 2022-01-24 14:07:14 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d53d8bd7088c3dac0ca104aed919ad2dcb1cf6af 8279315: Add Git support to update_copyright_year.sh script Reviewed-by: erikj ! make/scripts/update_copyright_year.sh Changeset: 2b133415 Author: Angelos Bimpoudis Committer: Vicente Romero Date: 2022-01-24 15:09:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2b13341500cb9474f5fd6375b97d102ffb635b13 8036019: Insufficient alternatives listed in some errors produced by the parser Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties + test/langtools/tools/javac/T8036019.java + test/langtools/tools/javac/T8036019.out ! test/langtools/tools/javac/annotations/typeAnnotations/6967002/T6967002.out + test/langtools/tools/javac/diags/examples/AnnotationMissingElementValue.java ! test/langtools/tools/javac/enum/EnumMembersOrder.out ! test/langtools/tools/javac/parser/7157165/T7157165.out ! test/langtools/tools/javac/parser/SingleCommaAnnotationValueFail.out Changeset: 4b329add Author: Kim Barrett Date: 2022-01-24 17:08:50 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4b329addf1aca4b5f67057b5c6852d283d0c8f49 8280496: Remove unused G1PageBasedVirtualSpace::pretouch_internal Reviewed-by: tschatzl, sjohanss, mli ! src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp ! src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.hpp Changeset: 1c7769d3 Author: Kim Barrett Date: 2022-01-24 17:23:14 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1c7769d35b3a2aa4afe3125239dbfa1da5cfdeee 8280437: Move G1BufferNodeList to gc/shared Reviewed-by: sjohanss, iwalulya, mli - src/hotspot/share/gc/g1/g1BufferNodeList.cpp - src/hotspot/share/gc/g1/g1BufferNodeList.hpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp ! src/hotspot/share/gc/g1/g1RedirtyCardsQueue.cpp ! src/hotspot/share/gc/g1/g1RedirtyCardsQueue.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp + src/hotspot/share/gc/shared/bufferNodeList.cpp + src/hotspot/share/gc/shared/bufferNodeList.hpp Changeset: dae2226a Author: Alexey Ivanov Date: 2022-01-24 18:30:31 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/dae2226a538f7156056d1f101fb5b4d1c6f72520 8279795: Fix typo in BasicFileChooserUI: Constucts -> Constructs Reviewed-by: prr, serb ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java Changeset: acd98294 Author: Alexey Ivanov Date: 2022-01-24 18:31:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/acd98294c628e8e03a036a8e3e08d775147b2fda 8279794: Fix typos in BasicScrollBarUI: Laysouts a vertical scroll bar Reviewed-by: prr, psadhukhan ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java Changeset: 0b5c54be Author: Alexey Ivanov Date: 2022-01-24 18:32:35 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0b5c54be675c63ecac17cd37f6d388fd42f09aa8 8279798: Javadoc for BasicTabbedPaneUI is inconsistent Reviewed-by: prr, psadhukhan ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java Changeset: a825a4a1 Author: Alexey Ivanov Date: 2022-01-24 18:35:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a825a4a1dba14317547b57bc0188b1e912baa251 8279861: Clarify 'rect' parameters and description of paintTabBorder method in BasicTabbedPaneUI Reviewed-by: prr, psadhukhan ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java Changeset: a5416669 Author: Daniel Jeli?ski Committer: Naoto Sato Date: 2022-01-24 19:31:11 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a5416669a57a7739af13efc32ec084560527862b 8280474: Garbage value passed to getLocaleInfoWrapper in HostLocaleProviderAdapter_md Reviewed-by: naoto, alanb ! src/java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c Changeset: 8e82d002 Author: Joe Darcy Date: 2022-01-24 20:16:38 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8e82d0021c119b7793870811fad37d7659c1174d 8280492: Use cross-module syntax for cross-module links Reviewed-by: iris, serb, lancea, dfuchs, aivanov ! src/java.base/share/classes/java/io/FilenameFilter.java ! src/java.base/share/classes/java/lang/Character.java ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/net/package-info.java ! src/java.base/share/classes/java/text/AttributedCharacterIterator.java ! src/java.base/share/classes/java/text/Bidi.java ! src/java.base/share/classes/java/util/Observable.java ! src/java.base/share/classes/java/util/ServiceLoader.java ! src/java.datatransfer/share/classes/java/awt/datatransfer/Clipboard.java ! src/java.logging/share/classes/java/util/logging/LogManager.java ! src/java.logging/share/classes/java/util/logging/LoggingMXBean.java ! src/java.management/share/classes/java/lang/management/ManagementFactory.java ! src/java.management/share/classes/java/lang/management/PlatformLoggingMXBean.java ! src/java.management/share/classes/javax/management/remote/JMXAddressable.java ! src/java.management/share/classes/javax/management/remote/JMXServerErrorException.java Changeset: 7d2ef9d9 Author: Jonathan Gibbons Date: 2022-01-21 23:18:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7d2ef9d984f96cd260dc233c4acf58669615227f 8279179: Update nroff pages in JDK 18 before RC Reviewed-by: iris, mchung ! src/java.base/share/man/java.1 ! src/java.base/share/man/keytool.1 ! src/jdk.jartool/share/man/jarsigner.1 Changeset: ead9fecc Author: Julia Boes Date: 2022-01-24 10:03:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ead9feccae75ab0491ce86a707f5056d88ac899a 8280441: Missing "classpath exception" in several files from jdk.httpserver Reviewed-by: alanb, dfuchs ! src/jdk.httpserver/share/classes/com/sun/net/httpserver/SimpleFileServer.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/JWebServer.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/Main.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/OutputFilter.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/ResourceBundleHelper.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/SimpleFileServerImpl.java Changeset: 52ddbe2d Author: Jesper Wilhelmsson Date: 2022-01-24 21:53:27 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/52ddbe2dcdb2fa52d85c987443ffa14522ace729 Merge ! src/java.base/share/man/java.1 ! src/java.base/share/man/keytool.1 ! src/jdk.jartool/share/man/jarsigner.1 ! src/java.base/share/man/java.1 ! src/java.base/share/man/keytool.1 ! src/jdk.jartool/share/man/jarsigner.1 Changeset: e3076552 Author: Ian Graves Date: 2022-01-24 22:21:22 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e3076552ec528864e61a6e0ec91e228006fddefc 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match Reviewed-by: lancea, iris, naoto, rriggs ! src/java.base/share/classes/java/util/regex/Pattern.java ! test/jdk/java/util/regex/RegExTest.java Changeset: f35df5bf Author: David Holmes Date: 2022-01-25 01:22:48 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f35df5bfb5d23f439fb64e8511fd5ca34c773f30 8280422: thread_from_jni_environment can never return NULL Reviewed-by: shade, kbarrett ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/interfaceSupport.inline.hpp ! src/hotspot/share/runtime/thread.hpp Changeset: a59d717f Author: Zhengyu Gu Date: 2022-01-25 01:31:24 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a59d717fd65d523bb6f4fc57949054e904a149f1 8280289: Enhance debug pp() command with NMT info Reviewed-by: stuefe, iklam ! src/hotspot/share/services/mallocTracker.cpp ! src/hotspot/share/services/mallocTracker.hpp ! src/hotspot/share/services/virtualMemoryTracker.cpp ! src/hotspot/share/services/virtualMemoryTracker.hpp ! src/hotspot/share/utilities/debug.cpp Changeset: 9ab44a77 Author: Fei Yang Date: 2022-01-24 20:43:20 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9ab44a77500b865f68eb431d3b2ec4953f2c3b17 Merge branch 'master' into riscv-port ! src/hotspot/cpu/riscv/frame_riscv.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/riscv64/RISCV64Frame.java + src/hotspot/cpu/riscv/frame_riscv.cpp + src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/riscv64/RISCV64Frame.java From duke at openjdk.java.net Wed Jan 26 01:14:54 2022 From: duke at openjdk.java.net (duke) Date: Wed, 26 Jan 2022 01:14:54 GMT Subject: git: openjdk/riscv-port: riscv-port: 20 new changesets Message-ID: <6d978f3a-caf3-4dde-a5dc-a2096d48f7b8@openjdk.java.net> Changeset: 53804720 Author: Andrey Turbanov Date: 2022-01-25 08:08:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/53804720a04b5b314701de82eddf1a55798eba00 8280470: Confusing instanceof check in HijrahChronology.range Reviewed-by: rriggs, naoto, dfuchs, iris ! src/java.base/share/classes/java/time/chrono/HijrahChronology.java Changeset: b3277465 Author: Thomas Schatzl Date: 2022-01-25 09:12:18 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b32774653f72f379655192874cb7076079d238e6 8280384: Parallel: Remove VMThread specific ParCompactionManager Reviewed-by: ayang, sjohanss ! src/hotspot/share/gc/parallel/psCompactionManager.cpp ! src/hotspot/share/gc/parallel/psCompactionManager.hpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.hpp ! src/hotspot/share/gc/parallel/psParallelCompact.inline.hpp ! src/hotspot/share/gc/parallel/psPromotionManager.cpp ! src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp Changeset: 295b263f Author: Thomas Schatzl Date: 2022-01-25 09:13:50 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/295b263fa951b9d51bfa92c04e49b2a17a62bd6f 8279241: G1 Full GC does not always slide memory to bottom addresses Reviewed-by: iwalulya, ayang, sjohanss ! src/hotspot/share/gc/g1/g1FullCollector.cpp ! src/hotspot/share/gc/g1/g1FullCollector.hpp ! src/hotspot/share/gc/g1/g1FullCollector.inline.hpp ! src/hotspot/share/gc/g1/g1FullGCHeapRegionAttr.hpp ! src/hotspot/share/gc/g1/g1FullGCPrepareTask.cpp ! src/hotspot/share/gc/g1/g1FullGCPrepareTask.hpp + src/hotspot/share/gc/g1/g1FullGCPrepareTask.inline.hpp ! src/hotspot/share/gc/g1/g1FullGCScope.cpp ! src/hotspot/share/gc/g1/g1FullGCScope.hpp Changeset: 2155afe2 Author: Thomas Stuefe Date: 2022-01-25 09:15:11 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2155afe2a87d718757b009d712361d7a63946a7f 8280503: Use allStatic.hpp instead of allocation.hpp where possible Reviewed-by: dholmes, iklam ! src/hotspot/cpu/aarch64/bytes_aarch64.hpp ! src/hotspot/cpu/aarch64/jniTypes_aarch64.hpp ! src/hotspot/cpu/arm/bytes_arm.hpp ! src/hotspot/cpu/arm/jniTypes_arm.hpp ! src/hotspot/cpu/ppc/bytes_ppc.hpp ! src/hotspot/cpu/ppc/jniTypes_ppc.hpp ! src/hotspot/cpu/s390/bytes_s390.hpp ! src/hotspot/cpu/s390/jniTypes_s390.hpp ! src/hotspot/cpu/x86/bytes_x86.hpp ! src/hotspot/cpu/x86/c2_intelJccErratum_x86.hpp ! src/hotspot/cpu/x86/jniTypes_x86.hpp ! src/hotspot/cpu/x86/rdtsc_x86.hpp ! src/hotspot/cpu/zero/bytes_zero.hpp ! src/hotspot/cpu/zero/jniTypes_zero.hpp ! src/hotspot/os/bsd/gc/z/zNUMA_bsd.cpp ! src/hotspot/os/linux/gc/z/zSyscall_linux.hpp ! src/hotspot/os/linux/osContainer_linux.hpp ! src/hotspot/os/posix/signals_posix.hpp ! src/hotspot/os/posix/threadLocalStorage_posix.cpp ! src/hotspot/os/windows/gc/z/zMapper_windows.hpp ! src/hotspot/os/windows/iphlp_interface.hpp ! src/hotspot/os/windows/pdh_interface.hpp ! src/hotspot/os/windows/threadLocalStorage_windows.cpp ! src/hotspot/share/c1/c1_Runtime1.hpp ! src/hotspot/share/cds/archiveUtils.cpp ! src/hotspot/share/cds/dynamicArchive.hpp ! src/hotspot/share/classfile/altHashing.hpp ! src/hotspot/share/classfile/klassFactory.hpp ! src/hotspot/share/classfile/modules.hpp ! src/hotspot/share/code/vtableStubs.hpp ! src/hotspot/share/compiler/compilerDefinitions.hpp ! src/hotspot/share/compiler/compilerEvent.hpp ! src/hotspot/share/compiler/compilerOracle.hpp ! src/hotspot/share/gc/g1/g1CollectionSetChooser.hpp ! src/hotspot/share/gc/g1/g1FromCardCache.hpp ! src/hotspot/share/gc/g1/g1HeapRegionEventSender.hpp ! src/hotspot/share/gc/g1/g1HeapRegionTraceType.hpp ! src/hotspot/share/gc/g1/heapRegionBounds.hpp ! src/hotspot/share/gc/g1/heapRegionTracer.hpp ! src/hotspot/share/gc/g1/heapRegionType.hpp ! src/hotspot/share/gc/parallel/psRootType.hpp ! src/hotspot/share/gc/parallel/psScavenge.hpp ! src/hotspot/share/gc/shared/accessBarrierSupport.hpp ! src/hotspot/share/gc/shared/ageTableTracer.hpp ! src/hotspot/share/gc/shared/allocTracer.hpp ! src/hotspot/share/gc/shared/blockOffsetTable.hpp ! src/hotspot/share/gc/shared/concurrentGCBreakpoints.hpp ! src/hotspot/share/gc/shared/gcCause.hpp ! src/hotspot/share/gc/shared/gcConfig.hpp ! src/hotspot/share/gc/shared/gcLocker.hpp ! src/hotspot/share/gc/shared/gcLogPrecious.hpp ! src/hotspot/share/gc/shared/gcWhen.hpp ! src/hotspot/share/gc/shared/locationPrinter.hpp ! src/hotspot/share/gc/shared/objectCountEventSender.hpp ! src/hotspot/share/gc/shared/scavengableNMethods.hpp ! src/hotspot/share/gc/shared/spaceDecorator.hpp ! src/hotspot/share/gc/shared/weakProcessor.hpp ! src/hotspot/share/gc/shared/workerPolicy.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBreakpoint.hpp ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp ! src/hotspot/share/gc/shenandoah/shenandoahWorkerPolicy.hpp ! src/hotspot/share/gc/z/zAbort.hpp ! src/hotspot/share/gc/z/zAddress.hpp ! src/hotspot/share/gc/z/zAddressSpaceLimit.hpp ! src/hotspot/share/gc/z/zBarrier.hpp ! src/hotspot/share/gc/z/zBarrierSetRuntime.hpp ! src/hotspot/share/gc/z/zBitField.hpp ! src/hotspot/share/gc/z/zBreakpoint.hpp ! src/hotspot/share/gc/z/zCPU.hpp ! src/hotspot/share/gc/z/zHash.hpp ! src/hotspot/share/gc/z/zHeuristics.hpp ! src/hotspot/share/gc/z/zLargePages.hpp ! src/hotspot/share/gc/z/zNMethod.hpp ! src/hotspot/share/gc/z/zNMethodTable.hpp ! src/hotspot/share/gc/z/zNUMA.hpp ! src/hotspot/share/gc/z/zOop.hpp ! src/hotspot/share/gc/z/zResurrection.hpp ! src/hotspot/share/gc/z/zThread.hpp ! src/hotspot/share/gc/z/zThreadLocalAllocBuffer.hpp ! src/hotspot/share/gc/z/zUtils.hpp ! src/hotspot/share/gc/z/zValue.hpp ! src/hotspot/share/gc/z/zVerify.hpp ! src/hotspot/share/interpreter/bytecodeHistogram.hpp ! src/hotspot/share/interpreter/bytecodeTracer.hpp ! src/hotspot/share/interpreter/bytecodeUtils.hpp ! src/hotspot/share/interpreter/bytecodes.hpp ! src/hotspot/share/interpreter/templateTable.hpp ! src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.hpp ! src/hotspot/share/jfr/jfr.hpp ! src/hotspot/share/jfr/leakprofiler/chains/edgeUtils.hpp ! src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleCheckpoint.hpp ! src/hotspot/share/jfr/leakprofiler/checkpoint/rootResolver.hpp ! src/hotspot/share/jfr/leakprofiler/leakProfiler.hpp ! src/hotspot/share/jfr/leakprofiler/utilities/granularTimer.hpp ! src/hotspot/share/jfr/leakprofiler/utilities/rootType.hpp ! src/hotspot/share/jfr/periodic/jfrFinalizerStatisticsEvent.hpp ! src/hotspot/share/jfr/periodic/jfrModuleEvent.hpp ! src/hotspot/share/jfr/periodic/jfrNetworkUtilization.hpp ! src/hotspot/share/jfr/periodic/jfrThreadCPULoadEvent.hpp ! src/hotspot/share/jfr/periodic/jfrThreadDumpEvent.hpp ! src/hotspot/share/jfr/recorder/checkpoint/jfrMetadataEvent.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrThreadState.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdLoadBarrier.hpp ! src/hotspot/share/jfr/recorder/repository/jfrChunkRotation.hpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.hpp ! src/hotspot/share/jfr/recorder/service/jfrMemorySizer.hpp ! src/hotspot/share/jfr/recorder/service/jfrOptionSet.hpp ! src/hotspot/share/jfr/recorder/service/jfrRecorderThread.hpp ! src/hotspot/share/jfr/support/jfrJdkJfrEvent.hpp ! src/hotspot/share/jfr/support/jfrKlassUnloading.hpp ! src/hotspot/share/jfr/support/jfrMethodLookup.hpp ! src/hotspot/share/jfr/support/jfrObjectAllocationSample.hpp ! src/hotspot/share/jfr/utilities/jfrBigEndian.hpp ! src/hotspot/share/jfr/utilities/jfrJavaLog.hpp ! src/hotspot/share/jfr/utilities/jfrPredicate.hpp ! src/hotspot/share/jfr/utilities/jfrTimeConverter.hpp ! src/hotspot/share/jfr/writers/jfrEncoding.hpp ! src/hotspot/share/jfr/writers/jfrJavaEventWriter.hpp ! src/hotspot/share/logging/logConfiguration.hpp ! src/hotspot/share/logging/logLevel.hpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/memory/metaspace/internalStats.hpp ! src/hotspot/share/memory/metaspace/metaspaceReporter.hpp ! src/hotspot/share/memory/metaspace/metaspaceSettings.hpp ! src/hotspot/share/memory/metaspace/runningCounters.hpp ! src/hotspot/share/memory/metaspaceCounters.hpp ! src/hotspot/share/memory/metaspaceCriticalAllocation.hpp ! src/hotspot/share/metaprogramming/conditional.hpp ! src/hotspot/share/metaprogramming/decay.hpp ! src/hotspot/share/metaprogramming/removeCV.hpp ! src/hotspot/share/metaprogramming/removeExtent.hpp ! src/hotspot/share/metaprogramming/removePointer.hpp ! src/hotspot/share/metaprogramming/removeReference.hpp ! src/hotspot/share/oops/access.hpp ! src/hotspot/share/oops/accessDecorators.hpp ! src/hotspot/share/oops/compressedOops.hpp ! src/hotspot/share/prims/jniFastGetField.hpp ! src/hotspot/share/prims/jvmtiEventController.hpp ! src/hotspot/share/prims/jvmtiExtensions.hpp ! src/hotspot/share/prims/jvmtiManageCapabilities.hpp ! src/hotspot/share/prims/nativeLookup.hpp ! src/hotspot/share/prims/resolvedMethodTable.hpp ! src/hotspot/share/prims/vectorSupport.hpp ! src/hotspot/share/runtime/abstract_vm_version.hpp ! src/hotspot/share/runtime/arguments.hpp ! src/hotspot/share/runtime/handshake.hpp ! src/hotspot/share/runtime/icache.hpp ! src/hotspot/share/runtime/jniHandles.hpp ! src/hotspot/share/runtime/orderAccess.hpp ! src/hotspot/share/runtime/prefetch.hpp ! src/hotspot/share/runtime/reflectionUtils.hpp ! src/hotspot/share/runtime/safepoint.hpp ! src/hotspot/share/runtime/sharedRuntime.hpp ! src/hotspot/share/runtime/stackWatermark.hpp ! src/hotspot/share/runtime/threadLocalStorage.hpp ! src/hotspot/share/services/attachListener.hpp ! src/hotspot/share/services/gcNotifier.hpp ! src/hotspot/share/services/lowMemoryDetector.hpp ! src/hotspot/share/services/nmtCommon.hpp ! src/hotspot/share/services/threadIdTable.hpp ! src/hotspot/share/utilities/decoder.hpp ! src/hotspot/share/utilities/globalCounter.hpp ! src/hotspot/share/utilities/quickSort.hpp ! src/hotspot/share/utilities/stringUtils.cpp ! src/hotspot/share/utilities/stringUtils.hpp ! src/hotspot/share/utilities/utf8.cpp ! src/hotspot/share/utilities/utf8.hpp ! test/hotspot/gtest/classfile/test_AltHashing.cpp Changeset: 1b141576 Author: Tobias Holenstein <71546117+tobiasholenstein at users.noreply.github.com> Committer: Tobias Hartmann Date: 2022-01-25 09:59:55 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1b14157677b34891385f643a76a7aa19d7003acf 8280274: Guard printing code of Compile::print_method in PRODUCT Reviewed-by: thartmann, neliasso ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/compile.hpp Changeset: c43ce85f Author: Lutz Schmidt Date: 2022-01-25 10:07:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c43ce85f01c96a4b80b971865306254c9417e549 8278302: [s390] Implement fast-path for ASCII-compatible CharsetEncoders Reviewed-by: mdoerr ! src/hotspot/cpu/s390/c2_MacroAssembler_s390.cpp ! src/hotspot/cpu/s390/c2_MacroAssembler_s390.hpp ! src/hotspot/cpu/s390/matcher_s390.hpp ! src/hotspot/cpu/s390/s390.ad Changeset: 28796cbd Author: Daniel Jeli?ski Committer: Michael McMahon Date: 2022-01-25 11:10:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/28796cbd1d15de678b80295418f5d1f9f59176a6 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC Reviewed-by: dfuchs, michaelm ! src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! test/jdk/sun/net/www/B8185898.java Changeset: 36fbec78 Author: Daniel Jeli?ski Committer: Daniel Fuchs Date: 2022-01-25 11:15:47 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/36fbec78be837fe1defb72f39c6e3f2b5135fddf 8280241: (aio) AsynchronousSocketChannel init fails in IPv6 only Windows env Reviewed-by: dfuchs, alanb ! src/java.base/windows/native/libnio/ch/WindowsAsynchronousServerSocketChannelImpl.c ! src/java.base/windows/native/libnio/ch/WindowsAsynchronousSocketChannelImpl.c Changeset: 4503d043 Author: Hamlin Li Date: 2022-01-25 12:11:21 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4503d0431c0dd4d177cf5eb4df592f26b9d372bb 8280375: G1: Tighten mem region limit in G1RebuildRemSetHeapRegionClosure Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1RemSet.cpp Changeset: 496baada Author: Albert Mingkun Yang Date: 2022-01-25 14:09:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/496baada1021eecae03e737afe838ad6d383cba9 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range Reviewed-by: sjohanss, tschatzl ! src/hotspot/share/gc/parallel/objectStartArray.cpp ! src/hotspot/share/gc/parallel/objectStartArray.hpp Changeset: fe77250f Author: Daniel Jeli?ski Committer: Daniel Fuchs Date: 2022-01-25 14:41:41 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/fe77250fa450ec803d2818dc90c5bf156521d537 8280414: Memory leak in DefaultProxySelector Reviewed-by: dfuchs ! src/java.base/windows/native/libnet/DefaultProxySelector.c Changeset: 674a97b2 Author: Thomas Schatzl Date: 2022-01-25 16:27:30 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/674a97b27ef621e7b54c13c121c625f91df5ee60 8280396: G1: Full gc mark stack draining should prefer to make work available to other threads Reviewed-by: sjohanss, ayang ! src/hotspot/share/gc/g1/g1FullGCMarker.hpp ! src/hotspot/share/gc/g1/g1FullGCMarker.inline.hpp Changeset: f4575e40 Author: Brian Burkhalter Date: 2022-01-25 18:02:18 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f4575e4052bf66f1259c626e01a74d3ac593e645 8279946: (ch) java.nio.channels.FileChannel tryLock and write methods are missing @throws NonWritableChannelException Reviewed-by: alanb ! src/java.base/share/classes/java/nio/channels/FileChannel.java Changeset: cbe8395a Author: Joe Darcy Date: 2022-01-25 18:15:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cbe8395ace3230dc599c7f082e3524a861b2da8e 8280168: Add Objects.toIdentityString Reviewed-by: alanb, mchung, rriggs, smarks ! src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/java.base/share/classes/java/util/Objects.java ! test/jdk/java/util/Objects/BasicObjectsTest.java Changeset: cebaad1c Author: Aleksey Shipilev Date: 2022-01-25 19:22:07 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cebaad1c94c301304fd146526cac95bfeaac66bf 8280041: Retry loop issues in java.io.ClassCache Co-authored-by: Peter Levart Reviewed-by: rkennke, rriggs, plevart ! src/java.base/share/classes/java/io/ClassCache.java + test/jdk/java/io/ClassCache/ContinuousGCTest.java + test/jdk/java/io/ClassCache/NullValueTest.java + test/jdk/java/io/ClassCache/java.base/java/io/NameClassCache.java + test/jdk/java/io/ClassCache/java.base/java/io/NullClassCache.java Changeset: 76fe03fe Author: Aleksey Shipilev Date: 2022-01-25 19:23:02 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/76fe03fe01a7c824e2e9263de95b8bcbb4b9d752 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases Reviewed-by: sspitsyn, lmesnik ! test/jdk/java/lang/instrument/GetObjectSizeIntrinsicsTest.java Changeset: 841eae6f Author: Chris Plummer Date: 2022-01-25 19:26:11 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/841eae6f527c00115e0455c4e04f042c28a014bb 8269542: JDWP: EnableCollection support is no longer spec compliant after JDK-8255987 8258071: Fix for JDK-8255987 can be subverted with ObjectReference.EnableCollection Reviewed-by: dholmes, pliden ! src/jdk.jdwp.agent/share/native/libjdwp/commonRef.c ! src/jdk.jdwp.agent/share/native/libjdwp/util.h Changeset: 295c0474 Author: Joe Darcy Date: 2022-01-25 20:05:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/295c0474c43484e793b67a70af316aaae49fe361 8279242: Reflection newInstance() error message when constructor has no access modifiers could use improvement Reviewed-by: iris, dholmes, mchung ! src/java.base/share/classes/jdk/internal/reflect/Reflection.java Changeset: 2eab86b5 Author: Vicente Romero Date: 2022-01-26 00:33:10 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2eab86b513a9e4566b3f5989f899ae44280d3834 8213905: reflection not working for type annotations applied to exception types in the inner class constructor Reviewed-by: jlahoda ! src/java.base/share/classes/sun/reflect/annotation/TypeAnnotationParser.java ! test/jdk/java/lang/annotation/TypeAnnotationReflection.java Changeset: 1a31f9f3 Author: Fei Yang Date: 2022-01-25 20:11:10 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/1a31f9f3547bad09e1cec8a211a6e0d3211bac6a Merge branch 'master' into riscv-port ! src/hotspot/cpu/riscv/assembler_riscv.hpp ! src/hotspot/cpu/riscv/bytes_riscv.hpp ! src/hotspot/cpu/riscv/frame_riscv.hpp ! src/hotspot/cpu/riscv/jniTypes_riscv.hpp ! src/hotspot/cpu/riscv/register_riscv.hpp ! src/hotspot/share/jfr/utilities/jfrBigEndian.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/riscv64/RISCV64Frame.java + src/hotspot/cpu/riscv/assembler_riscv.hpp + src/hotspot/cpu/riscv/bytes_riscv.hpp + src/hotspot/cpu/riscv/frame_riscv.hpp + src/hotspot/cpu/riscv/jniTypes_riscv.hpp + src/hotspot/cpu/riscv/register_riscv.hpp ! src/hotspot/share/jfr/utilities/jfrBigEndian.hpp + src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/riscv64/RISCV64Frame.java From yadongwang at openjdk.java.net Wed Jan 26 05:34:19 2022 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Wed, 26 Jan 2022 05:34:19 GMT Subject: [riscv-port] RFR: 8280497: riscv: Undefined Behaviour in class Assembler Message-ID: The same problem exists on the riscv platfom. So we follow https://bugs.openjdk.java.net/browse/JDK-8276563. All instances of type Register exhibit UB in the form of wild pointer (including null pointer) dereferences. This isn't very hard to fix: we should make Registers pointer to something rather than aliases of small integers. Hotspot/jdk tier1 were passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. ------------- Commit messages: - 8280497: riscv: Undefined Behaviour in class Assembler Changes: https://git.openjdk.java.net/riscv-port/pull/53/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=53&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280497 Stats: 137 lines in 8 files changed: 51 ins; 16 del; 70 mod Patch: https://git.openjdk.java.net/riscv-port/pull/53.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/53/head:pull/53 PR: https://git.openjdk.java.net/riscv-port/pull/53 From fyang at openjdk.java.net Wed Jan 26 06:29:03 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Wed, 26 Jan 2022 06:29:03 GMT Subject: [riscv-port] RFR: 8280497: riscv: Undefined Behaviour in class Assembler In-Reply-To: References: Message-ID: On Wed, 26 Jan 2022 05:28:15 GMT, Yadong Wang wrote: > The same problem exists on the riscv platfom. So we follow https://bugs.openjdk.java.net/browse/JDK-8276563. > > All instances of type Register exhibit UB in the form of wild pointer (including null pointer) dereferences. This isn't very hard to fix: we should make Registers pointer to something rather than aliases of small integers. > > Hotspot/jdk tier1 were passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. Changes requested by fyang (Lead). src/hotspot/cpu/riscv/assembler_riscv.hpp line 46: > 44: n_float_register_parameters_c = 8, // f10, f11, ... f17 (c_farg0, c_farg1, ... ) > 45: > 46: n_int_register_parameters_j = 8, // x11, ... x17, x10 (rj_rarg0, j_rarg1, ...) Could you please also fix this typo: "rj_rarg0" should be "j_rarg0"? Otherwise looks good. Thanks. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/53 From yadongwang at openjdk.java.net Wed Jan 26 06:59:35 2022 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Wed, 26 Jan 2022 06:59:35 GMT Subject: [riscv-port] RFR: 8280497: riscv: Undefined Behaviour in class Assembler [v2] In-Reply-To: References: Message-ID: > The same problem exists on the riscv platfom. So we follow https://bugs.openjdk.java.net/browse/JDK-8276563. > > All instances of type Register exhibit UB in the form of wild pointer (including null pointer) dereferences. This isn't very hard to fix: we should make Registers pointer to something rather than aliases of small integers. > > Hotspot/jdk tier1 were passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. Yadong Wang has updated the pull request incrementally with one additional commit since the last revision: fix typo ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/53/files - new: https://git.openjdk.java.net/riscv-port/pull/53/files/8e61f40c..27ecc023 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=53&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=53&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/53.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/53/head:pull/53 PR: https://git.openjdk.java.net/riscv-port/pull/53 From fyang at openjdk.java.net Wed Jan 26 07:03:08 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Wed, 26 Jan 2022 07:03:08 GMT Subject: [riscv-port] RFR: 8280497: riscv: Undefined Behaviour in class Assembler [v2] In-Reply-To: References: Message-ID: <3BZZ5ksd6_teKSFtuEs2E-izVo9rolU5dwQvmAERAtE=.a8c4c014-fec7-42d5-8f92-76bbf0caafff@github.com> On Wed, 26 Jan 2022 06:59:35 GMT, Yadong Wang wrote: >> The same problem exists on the riscv platfom. So we follow https://bugs.openjdk.java.net/browse/JDK-8276563. >> >> All instances of type Register exhibit UB in the form of wild pointer (including null pointer) dereferences. This isn't very hard to fix: we should make Registers pointer to something rather than aliases of small integers. >> >> Hotspot/jdk tier1 were passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. > > Yadong Wang has updated the pull request incrementally with one additional commit since the last revision: > > fix typo Marked as reviewed by fyang (Lead). ------------- PR: https://git.openjdk.java.net/riscv-port/pull/53 From fjiang at openjdk.java.net Wed Jan 26 11:11:01 2022 From: fjiang at openjdk.java.net (Feilong Jiang) Date: Wed, 26 Jan 2022 11:11:01 GMT Subject: [riscv-port] RFR: 8280497: riscv: Undefined Behaviour in class Assembler [v2] In-Reply-To: References: Message-ID: <5K9e8BN6MycwcscrwEFyJtngtwirjo8yRVbM3LrsEcQ=.7d9d4a11-740b-4524-abca-a1e966ddc56f@github.com> On Wed, 26 Jan 2022 06:59:35 GMT, Yadong Wang wrote: >> The same problem exists on the riscv platfom. So we follow https://bugs.openjdk.java.net/browse/JDK-8276563. >> >> All instances of type Register exhibit UB in the form of wild pointer (including null pointer) dereferences. This isn't very hard to fix: we should make Registers pointer to something rather than aliases of small integers. >> >> Hotspot/jdk tier1 were passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. > > Yadong Wang has updated the pull request incrementally with one additional commit since the last revision: > > fix typo Marked as reviewed by fjiang (Author). ------------- PR: https://git.openjdk.java.net/riscv-port/pull/53 From duke at openjdk.java.net Thu Jan 27 01:42:34 2022 From: duke at openjdk.java.net (duke) Date: Thu, 27 Jan 2022 01:42:34 GMT Subject: git: openjdk/riscv-port: riscv-port: 19 new changesets Message-ID: Changeset: a183bfb4 Author: Mandy Chung Date: 2022-01-26 01:24:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a183bfb436a7dd998e602c2d16486e88c390fca1 8280377: MethodHandleProxies does not correctly invoke default methods with varags Reviewed-by: alanb ! src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/java.base/share/classes/java/lang/reflect/InvocationHandler.java ! src/java.base/share/classes/java/lang/reflect/Proxy.java ! src/java.base/share/classes/java/lang/reflect/ReflectAccess.java ! src/java.base/share/classes/jdk/internal/access/JavaLangReflectAccess.java + test/jdk/java/lang/invoke/MethodHandleProxies/Driver.java = test/jdk/java/lang/invoke/MethodHandleProxies/MethodHandlesProxiesTest.java + test/jdk/java/lang/invoke/MethodHandleProxies/Unnamed.java + test/jdk/java/lang/invoke/MethodHandleProxies/m1/module-info.java + test/jdk/java/lang/invoke/MethodHandleProxies/m1/p1/Main.java + test/jdk/java/lang/invoke/MethodHandleProxies/m2/module-info.java + test/jdk/java/lang/invoke/MethodHandleProxies/m2/p2/TestIntf.java Changeset: 2c64a7f2 Author: Hamlin Li Date: 2022-01-26 06:11:04 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2c64a7f2e30dc83701456595814a831e41e5f628 8280374: G1: Remove unnecessary prev bitmap mark Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1EvacFailure.cpp Changeset: e72eefd9 Author: Andrey Turbanov Date: 2022-01-26 06:52:12 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e72eefd9f66e63a1e11d582e4916374840111928 8280531: Remove unused DeferredCloseInputStream Reviewed-by: bpb, rriggs, iris ! src/java.base/unix/classes/java/lang/ProcessImpl.java Changeset: a24f44d1 Author: Aleksey Shipilev Date: 2022-01-26 08:31:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a24f44d17de586c72c8343f8891e72ad8a514597 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1} Reviewed-by: kvn, neliasso ! src/hotspot/cpu/x86/x86.ad Changeset: c180070c Author: Matthias Baesken Date: 2022-01-26 08:41:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c180070cb59b8e075376ae913c5db9a4ed868303 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 Reviewed-by: yan, joehw ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java Changeset: ed0df2fa Author: Emanuel Peter Committer: Christian Hagedorn Date: 2022-01-26 10:12:22 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ed0df2fa1f1cb019eadd0083a5006b3142ac0eb5 8268033: compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java fails with "fatal error: Not compilable at tier 3: CodeBuffer overflow" Reviewed-by: kvn, neliasso, chagedorn ! test/hotspot/jtreg/ProblemList-Xcomp.txt ! test/hotspot/jtreg/compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java Changeset: a07e19d8 Author: Roman Kennke Date: 2022-01-26 11:05:30 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a07e19d8336f8fbea8736ba169787aec6d812817 8278410: Improve argument processing around UseHeavyMonitors Reviewed-by: rehn, dholmes ! src/hotspot/share/runtime/arguments.cpp Changeset: f34f8d4d Author: stsypanov Committer: Daniel Fuchs Date: 2022-01-26 14:12:51 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/f34f8d4d6a9b3e24a93a322b985c1413c27311cc 8277983: Remove unused fields from sun.net.www.protocol.jar.JarURLConnection Reviewed-by: dfuchs ! src/java.base/share/classes/sun/net/www/protocol/jar/JarURLConnection.java Changeset: e1d8f555 Author: Jonathan Gibbons Date: 2022-01-26 17:06:50 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/e1d8f555644e7766811bda1468af3f7f3d3f4239 8280402: Add new convenience forms to HtmlTree Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTree.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/Content.java Changeset: 4b2370e5 Author: Kim Barrett Date: 2022-01-26 17:07:53 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/4b2370e57698e7413fef053afe9d22bb0bc86041 8279294: NonblockingQueue::try_pop may improperly indicate queue is empty Reviewed-by: iwalulya, tschatzl ! src/hotspot/share/utilities/nonblockingQueue.inline.hpp Changeset: b8365aa4 Author: Jonathan Gibbons Date: 2022-01-26 17:10:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b8365aa48599a318c426c2ec4ffb3f296ffdbd73 8268978: Document the javadoc software stack Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/package-info.java Changeset: ef08e2c6 Author: Maurizio Cimadamore Date: 2022-01-26 01:12:37 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ef08e2c63b040cef6ca5f71dbce49f3d7647fdd8 8280592: Small javadoc tweaks to foreign API Reviewed-by: psandoz ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/Addressable.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/FunctionDescriptor.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/GroupLayout.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryAddress.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayout.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/NativeSymbol.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/ResourceScope.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/SequenceLayout.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/VaList.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/ValueLayout.java ! src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/package-info.java Changeset: a5a11f14 Author: Jesper Wilhelmsson Date: 2022-01-26 17:24:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a5a11f14b9ccc8c25f8a4232e9de23f47fbfb400 Merge Changeset: 0c42e43f Author: Joe Darcy Date: 2022-01-26 17:25:30 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0c42e43f77b91a50fedc3fddb74e17f910d8df2a 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound Reviewed-by: jlaskey, psandoz ! src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java + test/jdk/java/util/Random/RandomNextDoubleBoundary.java Changeset: b5de2cc9 Author: Liam Miller-Cushon Date: 2022-01-26 17:40:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b5de2cc9d36e1fad7d0bf70f7c83ff829e16b7f3 8280546: Remove hard-coded 127.0.0.1 loopback address Reviewed-by: mullan ! test/jdk/javax/net/ssl/TLS/TestJSSE.java ! test/jdk/javax/net/ssl/sanity/interop/JSSEClient.java Changeset: d2a50a64 Author: Alexandre Iline Date: 2022-01-26 18:05:15 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d2a50a64920d22bbbd19ac7fa8681ff177799faf 8279636: Update JCov version to 3.0.12 Reviewed-by: alanb, erikj ! make/conf/jib-profiles.js Changeset: 16e0ad0a Author: Chris Plummer Date: 2022-01-26 18:06:05 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/16e0ad0ad088af3ba1c9903ed8df60799a1ba651 8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed Reviewed-by: dholmes, kevinw ! test/hotspot/jtreg/ProblemList.txt ! test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java ! test/lib/jdk/test/lib/Platform.java ! test/lib/jdk/test/lib/SA/SATestUtils.java ! test/lib/jdk/test/lib/util/CoreUtils.java Changeset: c2ee1b33 Author: Hai-May Chao Date: 2022-01-26 20:31:04 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/c2ee1b33c37e6f2848dc8b3e5417b93b1dac1112 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints Reviewed-by: mullan ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/java.base/share/classes/sun/security/tools/keytool/Resources.java + test/jdk/sun/security/tools/keytool/TestSha1Usage.java Changeset: 068f5d5d Author: Fei Yang Date: 2022-01-26 20:40:28 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/068f5d5d5e3354decd59b569661ef92e1128066f Merge branch 'master' into riscv-port ! src/hotspot/share/runtime/arguments.cpp ! test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java ! test/lib/jdk/test/lib/Platform.java ! src/hotspot/share/runtime/arguments.cpp ! test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java ! test/lib/jdk/test/lib/Platform.java From yadongwang at openjdk.java.net Thu Jan 27 01:47:04 2022 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Thu, 27 Jan 2022 01:47:04 GMT Subject: [riscv-port] Integrated: 8280497: riscv: Undefined Behaviour in class Assembler In-Reply-To: References: Message-ID: <_b0Ky5DaYg5fBFRnmQmInzNUuEEbZ543w9qLKM0JoW0=.a0ef3602-d41c-40a5-91bd-dad879773dfb@github.com> On Wed, 26 Jan 2022 05:28:15 GMT, Yadong Wang wrote: > The same problem exists on the riscv platfom. So we follow https://bugs.openjdk.java.net/browse/JDK-8276563. > > All instances of type Register exhibit UB in the form of wild pointer (including null pointer) dereferences. This isn't very hard to fix: we should make Registers pointer to something rather than aliases of small integers. > > Hotspot/jdk tier1 were passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. This pull request has now been integrated. Changeset: 65852a6b Author: Yadong Wang URL: https://git.openjdk.java.net/riscv-port/commit/65852a6b98758604329937bb36ae7a769ef66df2 Stats: 138 lines in 8 files changed: 51 ins; 16 del; 71 mod 8280497: riscv: Undefined Behaviour in class Assembler Reviewed-by: fyang, fjiang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/53 From yzhu at openjdk.java.net Thu Jan 27 03:52:20 2022 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Thu, 27 Jan 2022 03:52:20 GMT Subject: [riscv-port] RFR: 8278847: riscv: Intrinsify BigInteger.montgomeryMultiply Message-ID: Intrinsify BigInteger.montgomeryMultiply on RISCV. On unmatched borad, performance of SPECjvm2008 crypto has improved by 4%?of which sub-testcase crypto.rsa have improved by 7%.The details are as follows? TRUE(ops/m) | 1 | 2 | 3 | geomean | percent(true/false) -- | -- | -- | -- | -- | -- crypto.aes | 6.15 | 6.26 | 5.82 | 6.07 | 102.81% crypto.rsa | 73.07 | 72.77 | 69.5 | 71.76 | 107.22% crypto.signverify | 56.82 | 57.13 | 56.34 | 56.76 | 102.59% crypto | 29.44 | 29.63 | 28.35 | 29.13 | 104.18% **FALSE(ops/m)** | ? | ? | ? | ? |? crypto.aes | 5.77 | 6.14 | 5.82 | 5.91 | ? crypto.rsa | 67.09 | 67.26 | 66.44 | 66.93 | ? crypto.signverify | 55.51 | 55.6 | 54.88 | 55.33 | ? crypto | 27.8 | 28.42 | 27.68 | 27.96 | ? ------------- Commit messages: - 8278847: riscv: Intrinsify BigInteger.montgomeryMultiply Changes: https://git.openjdk.java.net/riscv-port/pull/54/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=54&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278847 Stats: 484 lines in 2 files changed: 484 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/riscv-port/pull/54.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/54/head:pull/54 PR: https://git.openjdk.java.net/riscv-port/pull/54 From fyang at openjdk.java.net Fri Jan 28 02:30:41 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 28 Jan 2022 02:30:41 GMT Subject: [riscv-port] RFR: 8278847: riscv: Intrinsify BigInteger.montgomeryMultiply In-Reply-To: References: Message-ID: <6z_4xJkTb0KaNmgh7velck3AAejJscN3GcARTVMKX10=.9bd57d69-8281-4791-9335-c5e4a216ad04@github.com> On Thu, 27 Jan 2022 03:47:11 GMT, Yanhong Zhu wrote: > Intrinsify BigInteger.montgomeryMultiply on RISCV. > On unmatched borad, performance of SPECjvm2008 crypto has improved by 4%?of which sub-testcase crypto.rsa has improved by 7%.The details are as follows? > > xmlns:o="urn:schemas-microsoft-com:office:office" > xmlns:x="urn:schemas-microsoft-com:office:excel" > xmlns="http://www.w3.org/TR/REC-html40"> > > > > > > href="file:///C:\Users\Z00540~1\AppData\Local\Temp\msohtmlclip1\01\clip.htm"> > href="file:///C:\Users\Z00540~1\AppData\Local\Temp\msohtmlclip1\01\clip_filelist.xml"> > > > > > > > > > > TRUE(ops/m) | 1 | 2 | 3 | geomean | percent(true/false) > -- | -- | -- | -- | -- | -- > crypto.aes | 6.15 | 6.26 | 5.82 | 6.07 | 102.81% > crypto.rsa | 73.07 | 72.77 | 69.5 | 71.76 | 107.22% > crypto.signverify | 56.82 | 57.13 | 56.34 | 56.76 | 102.59% > crypto | 29.44 | 29.63 | 28.35 | 29.13 | 104.18% > **FALSE(ops/m)** | ? | ? | ? | ? |? > crypto.aes | 5.77 | 6.14 | 5.82 | 5.91 | ? > crypto.rsa | 67.09 | 67.26 | 66.44 | 66.93 | ? > crypto.signverify | 55.51 | 55.6 | 54.88 | 55.33 | ? > crypto | 27.8 | 28.42 | 27.68 | 27.96 | ? > > > > > > > All jtregs were tested on QEMU without new failures. Looks good. This implementation has been there in our JDK distribution for a long time. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/54 From yzhu at openjdk.java.net Fri Jan 28 03:03:36 2022 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 28 Jan 2022 03:03:36 GMT Subject: [riscv-port] Integrated: 8278847: riscv: Intrinsify BigInteger.montgomeryMultiply In-Reply-To: References: Message-ID: <_tBlOkW2L2010cx8z1dkni4zYjcY-LJV7PUVHO2ot3g=.600c4b75-a7e9-4d4d-8202-24b6695e003b@github.com> On Thu, 27 Jan 2022 03:47:11 GMT, Yanhong Zhu wrote: > Intrinsify BigInteger.montgomeryMultiply on RISCV. > On unmatched borad, performance of SPECjvm2008 crypto has improved by 4%?of which sub-testcase crypto.rsa has improved by 7%.The details are as follows? > > xmlns:o="urn:schemas-microsoft-com:office:office" > xmlns:x="urn:schemas-microsoft-com:office:excel" > xmlns="http://www.w3.org/TR/REC-html40"> > > > > > > href="file:///C:\Users\Z00540~1\AppData\Local\Temp\msohtmlclip1\01\clip.htm"> > href="file:///C:\Users\Z00540~1\AppData\Local\Temp\msohtmlclip1\01\clip_filelist.xml"> > > > > > > > > > > TRUE(ops/m) | 1 | 2 | 3 | geomean | percent(true/false) > -- | -- | -- | -- | -- | -- > crypto.aes | 6.15 | 6.26 | 5.82 | 6.07 | 102.81% > crypto.rsa | 73.07 | 72.77 | 69.5 | 71.76 | 107.22% > crypto.signverify | 56.82 | 57.13 | 56.34 | 56.76 | 102.59% > crypto | 29.44 | 29.63 | 28.35 | 29.13 | 104.18% > **FALSE(ops/m)** | ? | ? | ? | ? |? > crypto.aes | 5.77 | 6.14 | 5.82 | 5.91 | ? > crypto.rsa | 67.09 | 67.26 | 66.44 | 66.93 | ? > crypto.signverify | 55.51 | 55.6 | 54.88 | 55.33 | ? > crypto | 27.8 | 28.42 | 27.68 | 27.96 | ? > > > > > > > All jtregs were tested on QEMU without new failures. This pull request has now been integrated. Changeset: 7676f0b5 Author: Yanhong Zhu URL: https://git.openjdk.java.net/riscv-port/commit/7676f0b58d950da49ec483caaa0311c58359f4fa Stats: 484 lines in 2 files changed: 484 ins; 0 del; 0 mod 8278847: riscv: Intrinsify BigInteger.montgomeryMultiply Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/54 From yadongwang at openjdk.java.net Fri Jan 28 05:18:55 2022 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Fri, 28 Jan 2022 05:18:55 GMT Subject: [riscv-port] RFR: 8280683: riscv: Remove uses of long and unsigned long Message-ID: The riscv port should follow https://bugs.openjdk.java.net/browse/JDK-8248404, for the same reason of: In many cases the RISCV64 back end uses long and unsigned long types. These types don't work on LLP64 systems (such as Windows) and should be replaced either by int64_t or jlong, as appropriate. Hotspot/jdk tier1 passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. ------------- Commit messages: - 8280683: riscv: Remove uses of long and unsigned long Changes: https://git.openjdk.java.net/riscv-port/pull/55/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=55&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280683 Stats: 44 lines in 5 files changed: 13 ins; 19 del; 12 mod Patch: https://git.openjdk.java.net/riscv-port/pull/55.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/55/head:pull/55 PR: https://git.openjdk.java.net/riscv-port/pull/55 From fyang at openjdk.java.net Fri Jan 28 06:45:38 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 28 Jan 2022 06:45:38 GMT Subject: [riscv-port] RFR: 8280683: riscv: Remove uses of long and unsigned long In-Reply-To: References: Message-ID: On Fri, 28 Jan 2022 05:13:00 GMT, Yadong Wang wrote: > The riscv port should follow https://bugs.openjdk.java.net/browse/JDK-8248404, for the same reason of: > > In many cases the RISCV64 back end uses long and unsigned long types. These types don't work on LLP64 systems (such as Windows) and should be replaced either by int64_t or jlong, as appropriate. > > > Hotspot/jdk tier1 passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. Changes requested by fyang (Lead). src/hotspot/cpu/riscv/assembler_riscv.hpp line 169: > 167: Address(Register r) > 168: : _base(r), _index(noreg), _offset(0), _mode(base_plus_offset), _target(NULL) { } > 169: Suggestion: better to include header file: #include "metaprogramming/enableIf.hpp" ------------- PR: https://git.openjdk.java.net/riscv-port/pull/55 From yadongwang at openjdk.java.net Fri Jan 28 07:00:13 2022 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Fri, 28 Jan 2022 07:00:13 GMT Subject: [riscv-port] RFR: 8280683: riscv: Remove uses of long and unsigned long [v2] In-Reply-To: References: Message-ID: > The riscv port should follow https://bugs.openjdk.java.net/browse/JDK-8248404, for the same reason of: > > In many cases the RISCV64 back end uses long and unsigned long types. These types don't work on LLP64 systems (such as Windows) and should be replaced either by int64_t or jlong, as appropriate. > > > Hotspot/jdk tier1 passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. Yadong Wang has updated the pull request incrementally with one additional commit since the last revision: include a header file ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/55/files - new: https://git.openjdk.java.net/riscv-port/pull/55/files/2ed5134e..621dbecc Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=55&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=55&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/riscv-port/pull/55.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/55/head:pull/55 PR: https://git.openjdk.java.net/riscv-port/pull/55 From fyang at openjdk.java.net Fri Jan 28 07:03:34 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Fri, 28 Jan 2022 07:03:34 GMT Subject: [riscv-port] RFR: 8280683: riscv: Remove uses of long and unsigned long [v2] In-Reply-To: References: Message-ID: On Fri, 28 Jan 2022 07:00:13 GMT, Yadong Wang wrote: >> The riscv port should follow https://bugs.openjdk.java.net/browse/JDK-8248404, for the same reason of: >> >> In many cases the RISCV64 back end uses long and unsigned long types. These types don't work on LLP64 systems (such as Windows) and should be replaced either by int64_t or jlong, as appropriate. >> >> >> Hotspot/jdk tier1 passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. > > Yadong Wang has updated the pull request incrementally with one additional commit since the last revision: > > include a header file Marked as reviewed by fyang (Lead). ------------- PR: https://git.openjdk.java.net/riscv-port/pull/55 From yadongwang at openjdk.java.net Fri Jan 28 07:35:34 2022 From: yadongwang at openjdk.java.net (Yadong Wang) Date: Fri, 28 Jan 2022 07:35:34 GMT Subject: [riscv-port] Integrated: 8280683: riscv: Remove uses of long and unsigned long In-Reply-To: References: Message-ID: On Fri, 28 Jan 2022 05:13:00 GMT, Yadong Wang wrote: > The riscv port should follow https://bugs.openjdk.java.net/browse/JDK-8248404, for the same reason of: > > In many cases the RISCV64 back end uses long and unsigned long types. These types don't work on LLP64 systems (such as Windows) and should be replaced either by int64_t or jlong, as appropriate. > > > Hotspot/jdk tier1 passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. This pull request has now been integrated. Changeset: 7bb9b270 Author: Yadong Wang URL: https://git.openjdk.java.net/riscv-port/commit/7bb9b27071ee0821d5449d554c89aefd4b445b0d Stats: 45 lines in 5 files changed: 14 ins; 19 del; 12 mod 8280683: riscv: Remove uses of long and unsigned long Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/55 From yzhu at openjdk.java.net Fri Jan 28 09:27:53 2022 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Fri, 28 Jan 2022 09:27:53 GMT Subject: [riscv-port] RFR: 8280845: riscv: Intrinsify BigInteger.montgomerySquare Message-ID: Intrinsify BigInteger.montgomerySquare on RISCV. On unmatched borad, performance of SPECjvm2008 crypto with intrinsic has improved 40%. The details are as follows? Tested with option ?UseMontgomerySquareIntrinsic?. TRUE(ops/m) | 1 | 2 | 3 | 4 | geomean | ? -- | -- | -- | -- | -- | -- | -- crypto.aes | 6.04 | 6.07 | 5.78 | 5.76 | 5.91 | 100.81% crypto.rsa | 171.75 | 172.01 | 172.03 | 172.07 | 171.96 | 239.34% crypto.signverify | 63.91 | 63.77 | 63.96 | 63.76 | 63.85 | 114.35% crypto | 40.48 | 40.52 | 39.92 | 39.84 | 40.19 | 140.25% FALSE(ops/m) | ? | ? | ? | ? | ? | ? crypto.aes | 5.75 | 5.75 | 6.26 | 5.71 | 5.86 | ? crypto.rsa | 72.86 | 73.22 | 68.87 | 72.53 | 71.85 | ? crypto.signverify | 55.75 | 55.55 | 55.76 | 56.29 | 55.84 | ? crypto | 28.58 | 28.6 | 28.87 | 28.57 | 28.65 | ? ------------- Commit messages: - 8280845: riscv: Intrinsify BigInteger.montgomerySquare Changes: https://git.openjdk.java.net/riscv-port/pull/56/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=56&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280845 Stats: 248 lines in 2 files changed: 208 ins; 2 del; 38 mod Patch: https://git.openjdk.java.net/riscv-port/pull/56.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/56/head:pull/56 PR: https://git.openjdk.java.net/riscv-port/pull/56 From duke at openjdk.java.net Fri Jan 28 11:16:56 2022 From: duke at openjdk.java.net (duke) Date: Fri, 28 Jan 2022 11:16:56 GMT Subject: git: openjdk/riscv-port: riscv-port: 20 new changesets Message-ID: Changeset: 89083019 Author: Jaikiran Pai Date: 2022-01-27 03:57:28 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/890830196dea3dfacef231b458fa4a459791c2bb 8076089: Cleanup: Inline & remove sun.management.Util.newException Reviewed-by: kevinw, amenkov, dfuchs, sspitsyn ! src/java.management/share/classes/sun/management/LockInfoCompositeData.java ! src/java.management/share/classes/sun/management/ManagementFactoryHelper.java ! src/java.management/share/classes/sun/management/Util.java Changeset: 2ea0edf2 Author: Andrey Turbanov Date: 2022-01-27 07:00:56 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/2ea0edf2c40edde4c191864a40e7a4d741ac0b8e 8279673: AudioClip.play doesn't work due to NullPointerException when creating DataPusher Reviewed-by: prr, serb ! src/java.desktop/share/classes/com/sun/media/sound/DataPusher.java ! src/java.desktop/share/classes/com/sun/media/sound/JSSecurityManager.java + test/jdk/javax/sound/sampled/Clip/DataPusherThreadCheck.java Changeset: 0dba1707 Author: Roland Westrelin Date: 2022-01-27 08:44:58 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0dba1707910734d03c318424764b8682b028a8e0 8278518: String(byte[], int, int, Charset) constructor and String.translateEscapes() miss bounds check elimination Co-authored-by: Sergey Tsypanov Reviewed-by: kvn, jrose ! src/hotspot/share/ci/ciTypeFlow.cpp ! src/hotspot/share/ci/ciTypeFlow.hpp + test/micro/org/openjdk/bench/vm/compiler/SharedLoopHeader.java + test/micro/org/openjdk/bench/vm/compiler/StringConstructorBenchmark.java Changeset: 94380d0e Author: Prasanta Sadhukhan Date: 2022-01-27 08:59:34 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/94380d0e464a491977ed2b5f1998a55cfe73c3c6 8278232: [macos] Wrong chars emitted when entering certain char-sequence of Indic language Reviewed-by: prr ! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m Changeset: 7f68759c Author: Thomas Schatzl Date: 2022-01-27 09:06:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/7f68759c60d026eba3ad0a7f775497886c727384 8280719: G1: Remove outdated comment in RemoveSelfForwardPtrObjClosure::apply Reviewed-by: ayang, mli ! src/hotspot/share/gc/g1/g1EvacFailure.cpp Changeset: cab59051 Author: Thomas Stuefe Date: 2022-01-27 09:18:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cab590517bf705418c7376edd5d7066b13b6dde8 8280583: Always build NMT Reviewed-by: shade, ihse, zgu ! make/autoconf/jvm-features.m4 ! make/hotspot/lib/JvmFeatures.gmk ! src/hotspot/share/memory/allocation.hpp ! src/hotspot/share/memory/metaspace/metaspaceDCmd.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/services/mallocSiteTable.hpp ! src/hotspot/share/services/mallocTracker.hpp ! src/hotspot/share/services/memBaseline.hpp ! src/hotspot/share/services/memReporter.hpp ! src/hotspot/share/services/memTracker.hpp ! src/hotspot/share/services/nmtDCmd.hpp ! src/hotspot/share/services/nmtPreInit.cpp ! src/hotspot/share/services/nmtPreInit.hpp ! src/hotspot/share/services/threadStackTracker.hpp ! src/hotspot/share/services/virtualMemoryTracker.hpp ! src/hotspot/share/utilities/debug.cpp ! src/hotspot/share/utilities/macros.hpp ! test/hotspot/gtest/nmt/test_nmt_buffer_overflow_detection.cpp ! test/hotspot/gtest/nmt/test_nmtpreinit.cpp ! test/hotspot/gtest/nmt/test_nmtpreinitmap.cpp ! test/hotspot/gtest/runtime/test_committed_virtualmemory.cpp ! test/hotspot/gtest/runtime/test_virtualMemoryTracker.cpp Changeset: a3a0dcd9 Author: Yumin Qi Date: 2022-01-27 18:58:49 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a3a0dcd9215beb6baf43c6e94f8e16fb6a2ccf68 8280353: -XX:ArchiveClassesAtExit should print warning if base archive failed to load Reviewed-by: iklam, ccheung ! src/hotspot/share/cds/metaspaceShared.cpp Changeset: b94ebaa0 Author: Xin Liu Date: 2022-01-27 19:31:19 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/b94ebaa09c9ff788a37edcdbd043f9bb3998cede 8280686: Remove Compile::print_method_impl Reviewed-by: neliasso, chagedorn, thartmann ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/compile.hpp ! src/hotspot/share/opto/vector.cpp Changeset: ece89c6d Author: Brian Burkhalter Date: 2022-01-27 21:00:45 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ece89c6df167e9a7f99b00e3f89c2c41c10ab31b 8280366: (fs) Restore Files.createTempFile javadoc Reviewed-by: alanb, lancea ! src/java.base/share/classes/java/nio/file/Files.java Changeset: 6d242e40 Author: Jonathan Gibbons Date: 2022-01-27 21:58:44 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6d242e406539e97bdd4da82c478db901942b770f 8280835: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy Reviewed-by: hannesw ! test/langtools/jdk/javadoc/tool/CheckManPageOptions.java Changeset: 40a2ce20 Author: Joe Darcy Date: 2022-01-27 22:57:09 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/40a2ce20334207b542d18f52e26bf418bf29c9ca 8270476: Make floating-point test infrastructure more lambda and method reference friendly Reviewed-by: bpb ! test/jdk/java/lang/Math/Atan2Tests.java ! test/jdk/java/lang/Math/CeilAndFloorTests.java ! test/jdk/java/lang/Math/CubeRootTests.java ! test/jdk/java/lang/Math/ExpCornerCaseTests.java ! test/jdk/java/lang/Math/Expm1Tests.java ! test/jdk/java/lang/Math/FusedMultiplyAddTests.java ! test/jdk/java/lang/Math/HyperbolicTests.java ! test/jdk/java/lang/Math/HypotTests.java ! test/jdk/java/lang/Math/Ieee754SpecialCaseTests.java ! test/jdk/java/lang/Math/IeeeRecommendedTests.java ! test/jdk/java/lang/Math/Log10Tests.java ! test/jdk/java/lang/Math/Log1pTests.java ! test/jdk/java/lang/Math/PowTests.java ! test/jdk/java/lang/Math/Rint.java ! test/jdk/java/lang/Math/RoundTests.java ! test/jdk/java/lang/Math/SinCosCornerCasesTests.java ! test/jdk/java/lang/Math/TanTests.java ! test/jdk/java/lang/Math/Tests.java ! test/jdk/java/lang/Math/WorstCaseTests.java ! test/jdk/java/lang/StrictMath/CubeRootTests.java ! test/jdk/java/lang/StrictMath/Expm1Tests.java ! test/jdk/java/lang/StrictMath/HyperbolicTests.java ! test/jdk/java/lang/StrictMath/HypotTests.java ! test/jdk/java/lang/StrictMath/Log10Tests.java ! test/jdk/java/lang/StrictMath/Log1pTests.java ! test/jdk/java/lang/StrictMath/PowTests.java ! test/jdk/java/lang/StrictMath/Tests.java Changeset: 78574057 Author: Joe Darcy Date: 2022-01-28 00:44:13 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/78574057a4758fc3da5f39af77df09dc2232a9a1 8280744: Allow SuppressWarnings to be used in all declaration contexts Reviewed-by: iris ! src/java.base/share/classes/java/lang/SuppressWarnings.java Changeset: 094db1a3 Author: Denghui Dong Date: 2022-01-28 00:49:17 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/094db1a3eeb3709c8218d8d26f13699024ec2943 8277948: AArch64: Print the correct native stack if -XX:+PreserveFramePointer when crash Reviewed-by: aph, adinn ! src/hotspot/cpu/aarch64/frame_aarch64.cpp ! src/hotspot/cpu/aarch64/frame_aarch64.hpp ! src/hotspot/cpu/aarch64/frame_aarch64.inline.hpp ! src/hotspot/os_cpu/linux_aarch64/thread_linux_aarch64.cpp Changeset: a1d1e475 Author: Ioi Lam Date: 2022-01-28 01:55:16 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/a1d1e4753b87dfc6ce179c389480dcf2c5a0dc2e 8280823: Remove NULL check in DumpTimeClassInfo::is_excluded Reviewed-by: minqi, ccheung ! src/hotspot/share/cds/dumpTimeClassInfo.hpp Changeset: 178ac746 Author: Andrey Turbanov Date: 2022-01-28 07:01:21 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/178ac7465360729628521a0d555253b9fb2ad7bf 8251466: test/java/io/File/GetXSpace.java fails on Windows with mapped network drives. Reviewed-by: bpb ! test/jdk/java/io/File/GetXSpace.java Changeset: 55f180fb Author: Thomas Stuefe Date: 2022-01-28 08:10:12 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/55f180fb7dfecc859e59c7852d48aeab6c936a5d 8280004: DCmdArgument::parse_value() should handle NULL input Reviewed-by: dholmes, mbaesken ! src/hotspot/share/services/diagnosticArgument.cpp Changeset: 973dda5c Author: Albert Mingkun Yang Date: 2022-01-28 08:11:44 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/973dda5ce0747a8ea67ec3a34c2ef2a0b2b6b140 8280804: Parallel: Remove unused variables in PSPromotionManager::drain_stacks_depth Reviewed-by: tschatzl, mli ! src/hotspot/share/gc/parallel/psPromotionManager.cpp Changeset: 8a3cca09 Author: Stefan Karlsson Date: 2022-01-28 09:06:06 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/8a3cca09ba427282f2712bec7298b85bbacf076b 8280784: VM_Cleanup unnecessarily processes all thread oops Reviewed-by: eosterlund, shade ! src/hotspot/share/runtime/vmOperations.hpp Changeset: ed826f29 Author: Thomas Schatzl Date: 2022-01-28 09:16:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ed826f2927457f73f058732c6d073acf54ee86f7 8280397: Factor out task queue statistics printing Reviewed-by: pliden, kbarrett, mli ! src/hotspot/share/gc/g1/g1YoungCollector.cpp ! src/hotspot/share/gc/g1/g1YoungCollector.hpp ! src/hotspot/share/gc/parallel/psPromotionManager.cpp ! src/hotspot/share/gc/shared/taskqueue.hpp ! src/hotspot/share/gc/shared/taskqueue.inline.hpp Changeset: 9e37d5c4 Author: Fei Yang Date: 2022-01-28 06:13:32 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/9e37d5c4fc7661f25105cf448bfd7b25b1d9747f Merge branch 'master' into riscv-port ! make/autoconf/jvm-features.m4 ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/utilities/macros.hpp ! make/autoconf/jvm-features.m4 ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/utilities/macros.hpp From fyang at openjdk.java.net Sat Jan 29 04:07:36 2022 From: fyang at openjdk.java.net (Fei Yang) Date: Sat, 29 Jan 2022 04:07:36 GMT Subject: [riscv-port] RFR: 8280845: riscv: Intrinsify BigInteger.montgomerySquare In-Reply-To: References: Message-ID: On Fri, 28 Jan 2022 09:22:09 GMT, Yanhong Zhu wrote: > Intrinsify BigInteger.montgomerySquare on RISCV. > On unmatched borad, performance of SPECjvm2008 crypto with intrinsic has improved 40%. > Hotspot/jdk tier1 passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. > > The details are as follows? > Tested with option ?UseMontgomerySquareIntrinsic?. > xmlns:o="urn:schemas-microsoft-com:office:office" > xmlns:x="urn:schemas-microsoft-com:office:excel" > xmlns="http://www.w3.org/TR/REC-html40"> > > > > > > href="file:///C:\Users\Z00540~1\AppData\Local\Temp\msohtmlclip1\01\clip.htm"> > href="file:///C:\Users\Z00540~1\AppData\Local\Temp\msohtmlclip1\01\clip_filelist.xml"> > > > > > > > > > > TRUE(ops/m) | 1 | 2 | 3 | 4 | geomean | ? > -- | -- | -- | -- | -- | -- | -- > crypto.aes | 6.04 | 6.07 | 5.78 | 5.76 | 5.91 | 100.81% > crypto.rsa | 171.75 | 172.01 | 172.03 | 172.07 | 171.96 | 239.34% > crypto.signverify | 63.91 | 63.77 | 63.96 | 63.76 | 63.85 | 114.35% > crypto | 40.48 | 40.52 | 39.92 | 39.84 | 40.19 | 140.25% > FALSE(ops/m) | ? | ? | ? | ? | ? | ? > crypto.aes | 5.75 | 5.75 | 6.26 | 5.71 | 5.86 | ? > crypto.rsa | 72.86 | 73.22 | 68.87 | 72.53 | 71.85 | ? > crypto.signverify | 55.75 | 55.55 | 55.76 | 56.29 | 55.84 | ? > crypto | 28.58 | 28.6 | 28.87 | 28.57 | 28.65 | ? > > > > > > Great numbers. Looks good. ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/56 From yzhu at openjdk.java.net Sat Jan 29 04:12:40 2022 From: yzhu at openjdk.java.net (Yanhong Zhu) Date: Sat, 29 Jan 2022 04:12:40 GMT Subject: [riscv-port] Integrated: 8280845: riscv: Intrinsify BigInteger.montgomerySquare In-Reply-To: References: Message-ID: On Fri, 28 Jan 2022 09:22:09 GMT, Yanhong Zhu wrote: > Intrinsify BigInteger.montgomerySquare on RISCV. > On unmatched borad, performance of SPECjvm2008 crypto with intrinsic has improved 40%. > Hotspot/jdk tier1 passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures. > > The details are as follows? > Tested with option ?UseMontgomerySquareIntrinsic?. > xmlns:o="urn:schemas-microsoft-com:office:office" > xmlns:x="urn:schemas-microsoft-com:office:excel" > xmlns="http://www.w3.org/TR/REC-html40"> > > > > > > href="file:///C:\Users\Z00540~1\AppData\Local\Temp\msohtmlclip1\01\clip.htm"> > href="file:///C:\Users\Z00540~1\AppData\Local\Temp\msohtmlclip1\01\clip_filelist.xml"> > > > > > > > > > > TRUE(ops/m) | 1 | 2 | 3 | 4 | geomean | ? > -- | -- | -- | -- | -- | -- | -- > crypto.aes | 6.04 | 6.07 | 5.78 | 5.76 | 5.91 | 100.81% > crypto.rsa | 171.75 | 172.01 | 172.03 | 172.07 | 171.96 | 239.34% > crypto.signverify | 63.91 | 63.77 | 63.96 | 63.76 | 63.85 | 114.35% > crypto | 40.48 | 40.52 | 39.92 | 39.84 | 40.19 | 140.25% > FALSE(ops/m) | ? | ? | ? | ? | ? | ? > crypto.aes | 5.75 | 5.75 | 6.26 | 5.71 | 5.86 | ? > crypto.rsa | 72.86 | 73.22 | 68.87 | 72.53 | 71.85 | ? > crypto.signverify | 55.75 | 55.55 | 55.76 | 56.29 | 55.84 | ? > crypto | 28.58 | 28.6 | 28.87 | 28.57 | 28.65 | ? > > > > > > This pull request has now been integrated. Changeset: bbc2132d Author: Yanhong Zhu URL: https://git.openjdk.java.net/riscv-port/commit/bbc2132d638b94422f7968a10a2049081c90e40e Stats: 248 lines in 2 files changed: 208 ins; 2 del; 38 mod 8280845: riscv: Intrinsify BigInteger.montgomerySquare Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/56 From duke at openjdk.java.net Sat Jan 29 12:13:27 2022 From: duke at openjdk.java.net (duke) Date: Sat, 29 Jan 2022 12:13:27 GMT Subject: git: openjdk/riscv-port: riscv-port: 10 new changesets Message-ID: <487a6711-805a-4ea4-bed3-0b48f62aac3d@openjdk.java.net> Changeset: 6de90ad9 Author: Magnus Ihse Bursie Committer: Magnus Ihse Bursie Date: 2022-01-28 12:45:43 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/6de90ad9800b83c4a5f364c3645603fcb6828d6c 8280863: Update build README to reflect that MSYS2 is supported Reviewed-by: ihse ! doc/building.html ! doc/building.md Changeset: cb8a82ee Author: Kevin Walls Date: 2022-01-28 12:54:19 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/cb8a82ee24881113af4eea04d7ce5963d18e9b83 8272317: jstatd has dependency on Security Manager which needs to be removed Reviewed-by: cjplummer, rriggs ! make/modules/jdk.jstatd/Launcher.gmk ! src/jdk.jstatd/share/classes/sun/tools/jstatd/Jstatd.java ! test/jdk/sun/tools/jstatd/JstatdTest.java - test/jdk/sun/tools/jstatd/all.policy Changeset: 409382ba Author: Sebastian Stenzel Committer: Anthony Scarpino Date: 2022-01-28 16:42:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/409382ba4b43bf48ed0086020dd20641effd35b6 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption Reviewed-by: ascarpino ! src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java Changeset: 95ee9bf7 Author: Brian Burkhalter Date: 2022-01-28 17:12:42 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/95ee9bf7be40572e768cf6213c03ca183b8ad886 4774868: (fc spec) Unclear spec for FileChannel.force Reviewed-by: alanb ! src/java.base/share/classes/java/nio/channels/FileChannel.java Changeset: ff34d624 Author: Daniel D. Daugherty Date: 2022-01-28 18:09:35 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/ff34d624ba81698db0aacc1d5e2332c4345010ce 8280898: ProblemList compiler/regalloc/TestC2IntPressure.java on macosx-aarch64 Reviewed-by: ctornqvi ! test/hotspot/jtreg/ProblemList.txt Changeset: 0740ac47 Author: Chris Plummer Date: 2022-01-28 18:51:21 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/0740ac474cbda439684223e660827e38964e6b1f 8280555: serviceability/sa/TestObjectMonitorIterate.java is failing due to ObjectMonitor referencing a null Object Reviewed-by: sspitsyn, lmesnik ! test/hotspot/jtreg/serviceability/sa/TestObjectMonitorIterate.java Changeset: 91391598 Author: Denghui Dong Date: 2022-01-28 22:52:32 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/91391598989c70c98b9400997df4f9177d3e576f 8280843: macos-Aarch64 SEGV in frame::sender_for_compiled_frame after JDK-8277948 Reviewed-by: aph, dholmes ! src/hotspot/os_cpu/bsd_aarch64/thread_bsd_aarch64.cpp ! src/hotspot/os_cpu/windows_aarch64/thread_windows_aarch64.cpp ! test/hotspot/jtreg/ProblemList.txt Changeset: d366d15d Author: Brian Burkhalter Date: 2022-01-28 23:18:20 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/d366d15d67a08833d93a5806edef8145cb7803e5 8280903: javadoc build fails after JDK-4774868 Reviewed-by: lancea ! src/java.base/share/classes/java/nio/channels/FileChannel.java Changeset: 268880b4 Author: Andrey Turbanov Date: 2022-01-29 11:36:11 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/268880b471eed54535927fba953347160f447fcd 8277412: Use String.isBlank to simplify code in sun.net.www.protocol.mailto.Handler Reviewed-by: dfuchs ! src/java.base/share/classes/sun/net/www/protocol/mailto/Handler.java Changeset: fd72cc48 Author: Fei Yang Date: 2022-01-29 07:10:40 +0000 URL: https://git.openjdk.java.net/riscv-port/commit/fd72cc48fadac15a928d053c5a5458adf2ec846a Merge branch 'master' into riscv-port ! src/hotspot/cpu/riscv/assembler_riscv.cpp ! src/hotspot/cpu/riscv/assembler_riscv.hpp ! src/hotspot/cpu/riscv/register_riscv.cpp ! src/hotspot/cpu/riscv/register_riscv.hpp ! src/hotspot/cpu/riscv/stubGenerator_riscv.cpp ! src/hotspot/cpu/riscv/vm_version_riscv.cpp ! src/hotspot/cpu/riscv/vmreg_riscv.cpp ! src/hotspot/cpu/riscv/vmreg_riscv.hpp + src/hotspot/cpu/riscv/assembler_riscv.cpp + src/hotspot/cpu/riscv/assembler_riscv.hpp + src/hotspot/cpu/riscv/register_riscv.cpp + src/hotspot/cpu/riscv/register_riscv.hpp + src/hotspot/cpu/riscv/stubGenerator_riscv.cpp + src/hotspot/cpu/riscv/vm_version_riscv.cpp + src/hotspot/cpu/riscv/vmreg_riscv.cpp + src/hotspot/cpu/riscv/vmreg_riscv.hpp