[riscv-port] RFR: 8279664: riscv: JFR crashes at 0x0 [v3]
Fei Yang
fyang at openjdk.java.net
Fri Jan 21 03:48:07 UTC 2022
On Fri, 21 Jan 2022 03:21:49 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:
>> Hi team,
>>
>> This is a preview fix for the JFR-related crash - maybe the comment in this patch should be polished.
>> TIL that complex problems often result from seemingly negligible changes :-)
>> I need to cautiously test this change, though it seems no harm, to guarantee that it is safe and to ensure the problem is gone so please stay a little tuned.
>>
>> ----
>> Update:
>>
>> 1. Overnight JFR testing reveals no error, seems fixed.
>> 2. `test/hotspot/jtreg` on the board reveals no error until now - still testing, but I think it is safe.
>> ----
>>
>> Thanks,
>> Xiaolin
>
> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
>
> Polish comments
I see JFR works quite stable with some non-trivial benchmark workload. So good to go. Thanks.
-------------
Marked as reviewed by fyang (Lead).
PR: https://git.openjdk.java.net/riscv-port/pull/49
More information about the riscv-port-dev
mailing list