[riscv-port] RFR: 8281632: riscv: Improve interpreter stack banging [v4]
Fei Yang
fyang at openjdk.java.net
Tue Mar 8 01:37:41 UTC 2022
On Wed, 23 Feb 2022 09:27:57 GMT, Yadong Wang <yadongwang at openjdk.org> wrote:
>> With reference to https://bugs.openjdk.java.net/browse/JDK-8072070, there is the same issue on the riscv platform.
>>
>>
>> Every time we enter a method in interpreter, we bang a lot of stack ahead for shadow zone checks. I believe this could be made significantly better, e.g. by checking how far away we are from the stack_overflow_limit.
>>
>>
>> Hotspot/jdk tier1 passed on unmatched, and all jtreg cases were tested on Qemu without new failures.
>>
>> Performed the performance regression test in SPECjvm2008 sunflow, and achieved 17% improvement in the interpreter-only mode.
>
> Yadong Wang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> missing check for stack growth watermark
src/hotspot/cpu/riscv/templateInterpreterGenerator_riscv.cpp line 923:
> 921: __ bgtu(sp, t0, L_done);
> 922:
> 923: for (int p = 1; p <= n_shadow_pages ; p++) {
Extra whitespace in loop condition. Looks good otherwise.
-------------
PR: https://git.openjdk.java.net/riscv-port/pull/58
More information about the riscv-port-dev
mailing list