[riscv-port] RFR: 8283020: riscv: Fix configure integration
Fei Yang
fyang at openjdk.java.net
Mon Mar 14 08:57:14 UTC 2022
On Fri, 11 Mar 2022 11:16:01 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> The current implementation in the riscv-port modifies make/autoconf/build-aux/autoconf-* files. For legal reasons, this is not something that is allowed. Instead, we need to introduce patches in our wrapper scripts in the same directory.
>
> This patch will restore the original contents of the autoconf-* files, and instead move this logic to the wrapper scripts.
>
> This PR also fixes an indentation problem in configure.
>
> I have not been able to verify this patch, since I do not have access to riscv hardware. I believe it is sufficient and correct, but it might be the case that config.sub also needs updating. I kindly request assistance in verifying this.
>
> (Apart from these fixes, all build changes in the riscv-port looks good to me)
Thanks for reviewing and pointing this out. RISCV release and debug targets builds OK with both native-compiling and cross-compiling.
-------------
Marked as reviewed by fyang (Lead).
PR: https://git.openjdk.java.net/riscv-port/pull/66
More information about the riscv-port-dev
mailing list