From yangfei at iscas.ac.cn  Wed Feb  1 02:23:23 2023
From: yangfei at iscas.ac.cn (yangfei at iscas.ac.cn)
Date: Wed, 1 Feb 2023 10:23:23 +0800 (GMT+08:00)
Subject: Backports to jdk11u and jdk17u
In-Reply-To: <1bb15352.1af1.185c4eb5693.Coremail.yangfei@iscas.ac.cn>
References: <CADT88DvbXvzMx5h6kDCnmrp2rvKy8iDDPpWWSiZuCT8_hkTGig@mail.gmail.com>
 <79ab2542.1f08.185ba593e97.Coremail.yangfei@iscas.ac.cn>
 <2b9d63dc.2ad6.185bac8df55.Coremail.zhangxiang@iscas.ac.cn>
 <CADT88DvmwLiKZDxw4BX-zrN0p5aUYeKqTr6TORXXAz+jjRS8dw@mail.gmail.com>
 <5e09da27.4add.185bed323a6.Coremail.yangfei@iscas.ac.cn>
 <PAXPR02MB8245971774A3A617415AA6B8ECC69@PAXPR02MB8245.eurprd02.prod.outlook.com>
 <CADT88DsT6Hu_t=rXVCYTvWzKTYBBFGhNQDVrSKkSzOoVoEf=hw@mail.gmail.com>
 <1bb15352.1af1.185c4eb5693.Coremail.yangfei@iscas.ac.cn>
Message-ID: <23420643.13c67.1860ac93267.Coremail.yangfei@iscas.ac.cn>

Hi all,

  Good news is that following three repos have been created by ops and should be ready for use!

    https://github.com/openjdk/riscv-port-jdk17u
    https://github.com/openjdk/riscv-port-jdk11u
    https://github.com/openjdk/riscv-port-jdk8u

  They are seeded with jdk{17, 11, 8}u-dev repos respectively. 
  We should start from riscv-port-jdk17u. And I have created a riscv-port branch in this repo for future 17u backporting work. 
  As mentioned by Lindenmaier Goetz, the initial backport should be restricted to the changes that are definitely needed to get it working. 
  Also, changes to shared code should be kept to a minimum. 
  Please let me know if there are other things missed. 

Thanks,
Fei Yang

&gt; -----Original Messages-----
&gt; From: yangfei at iscas.ac.cn
&gt; Sent Time: 2023-01-18 20:47:15 (Wednesday)
&gt; To: "Ludovic Henry" <ludovic at rivosinc.com>
&gt; Cc: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>, "??" <zhangxiang at iscas.ac.cn>, "riscv-port-dev at openjdk.org" <riscv-port-dev at openjdk.org>, "yadonn.wang at huawei.com" <yadonn.wang at huawei.com>, "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
&gt; Subject: Re: Re: Re: Re: Backports to jdk11u and jdk17u
&gt; 
&gt; -----Original Messages-----
&gt; From:"Ludovic Henry" <ludovic at rivosinc.com>
&gt; Sent Time:2023-01-18 17:05:58 (Wednesday)
&gt; To: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>
&gt; Cc: "yangfei at iscas.ac.cn" <yangfei at iscas.ac.cn>, "??" <zhangxiang at iscas.ac.cn>, "riscv-port-dev at openjdk.org" <riscv-port-dev at openjdk.org>, "yadonn.wang at huawei.com" <yadonn.wang at huawei.com>, "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
&gt; Subject: Re: Re: Re: Backports to jdk11u and jdk17u
&gt; 
&gt; Hi,  
&gt; 
&gt; &gt;&gt; It would be great to see a complete list of
&gt; &gt;&gt; changes that need to be backported.
&gt; &gt; Let's make sure we can bake the backports in a dedicated repository so that we can have a better sense on what the changes would entail.  
&gt; &gt; 
&gt; &gt;  After reaching to skara-dev, the only thing needed to create these repositories is for the riscv-project to contact ops at openjdk dot org. @Fei Yang, I am assuming you'd need to contact them being the riscv-port lead.
&gt; 
&gt;  Sure! I just sent an email to ops at openjdk.java.net requesting creation of following three new repos:
&gt; 
&gt;   1. https://github.com/openjdk/riscv-port-jdk17u
&gt;   2. https://github.com/openjdk/riscv-port-jdk11u
&gt;   3. https://github.com/openjdk/riscv-port-jdk8u
&gt; 
&gt; Let's see :-)
&gt; 
&gt; Thanks,
&gt; Fei
&gt; </jdk-updates-dev at openjdk.java.net></yadonn.wang at huawei.com></riscv-port-dev at openjdk.org></zhangxiang at iscas.ac.cn></yangfei at iscas.ac.cn></goetz.lindenmaier at sap.com></ludovic at rivosinc.com>
</jdk-updates-dev at openjdk.java.net></yadonn.wang at huawei.com></riscv-port-dev at openjdk.org></zhangxiang at iscas.ac.cn></goetz.lindenmaier at sap.com></ludovic at rivosinc.com>

From ludovic at rivosinc.com  Wed Feb  1 09:26:33 2023
From: ludovic at rivosinc.com (Ludovic Henry)
Date: Wed, 1 Feb 2023 10:26:33 +0100
Subject: Backports to jdk11u and jdk17u
In-Reply-To: <23420643.13c67.1860ac93267.Coremail.yangfei@iscas.ac.cn>
References: <CADT88DvbXvzMx5h6kDCnmrp2rvKy8iDDPpWWSiZuCT8_hkTGig@mail.gmail.com>
 <79ab2542.1f08.185ba593e97.Coremail.yangfei@iscas.ac.cn>
 <2b9d63dc.2ad6.185bac8df55.Coremail.zhangxiang@iscas.ac.cn>
 <CADT88DvmwLiKZDxw4BX-zrN0p5aUYeKqTr6TORXXAz+jjRS8dw@mail.gmail.com>
 <5e09da27.4add.185bed323a6.Coremail.yangfei@iscas.ac.cn>
 <PAXPR02MB8245971774A3A617415AA6B8ECC69@PAXPR02MB8245.eurprd02.prod.outlook.com>
 <CADT88DsT6Hu_t=rXVCYTvWzKTYBBFGhNQDVrSKkSzOoVoEf=hw@mail.gmail.com>
 <1bb15352.1af1.185c4eb5693.Coremail.yangfei@iscas.ac.cn>
 <23420643.13c67.1860ac93267.Coremail.yangfei@iscas.ac.cn>
Message-ID: <CADT88DuyZ+8+JAo1AZxmHKx0x4MQauD=wsbCdJbrq77nR6FM5g@mail.gmail.com>

That's great news, thank you!

I'll work with Adoptium to start getting some CI up and running on these
repos and get a binary that we can also easily test out.

On Wed, Feb 1, 2023 at 3:23 AM <yangfei at iscas.ac.cn> wrote:

> Hi all,
>
>   Good news is that following three repos have been created by ops and
> should be ready for use!
>
>     https://github.com/openjdk/riscv-port-jdk17u
>     https://github.com/openjdk/riscv-port-jdk11u
>     https://github.com/openjdk/riscv-port-jdk8u
>
>   They are seeded with jdk{17, 11, 8}u-dev repos respectively.
>   We should start from riscv-port-jdk17u. And I have created a riscv-port
> branch in this repo for future 17u backporting work.
>   As mentioned by Lindenmaier Goetz, the initial backport should be
> restricted to the changes that are definitely needed to get it working.
>   Also, changes to shared code should be kept to a minimum.
>   Please let me know if there are other things missed.
>
> Thanks,
> Fei Yang
>
> &gt; -----Original Messages-----
> &gt; From: yangfei at iscas.ac.cn
> &gt; Sent Time: 2023-01-18 20:47:15 (Wednesday)
> &gt; To: "Ludovic Henry" <ludovic at rivosinc.com>
> &gt; Cc: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>, "??" <
> zhangxiang at iscas.ac.cn>, "riscv-port-dev at openjdk.org" <
> riscv-port-dev at openjdk.org>, "yadonn.wang at huawei.com" <
> yadonn.wang at huawei.com>, "jdk-updates-dev at openjdk.java.net" <
> jdk-updates-dev at openjdk.java.net>
> &gt; Subject: Re: Re: Re: Re: Backports to jdk11u and jdk17u
> &gt;
> &gt; -----Original Messages-----
> &gt; From:"Ludovic Henry" <ludovic at rivosinc.com>
> &gt; Sent Time:2023-01-18 17:05:58 (Wednesday)
> &gt; To: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>
> &gt; Cc: "yangfei at iscas.ac.cn" <yangfei at iscas.ac.cn>, "??" <
> zhangxiang at iscas.ac.cn>, "riscv-port-dev at openjdk.org" <
> riscv-port-dev at openjdk.org>, "yadonn.wang at huawei.com" <
> yadonn.wang at huawei.com>, "jdk-updates-dev at openjdk.java.net" <
> jdk-updates-dev at openjdk.java.net>
> &gt; Subject: Re: Re: Re: Backports to jdk11u and jdk17u
> &gt;
> &gt; Hi,
> &gt;
> &gt; &gt;&gt; It would be great to see a complete list of
> &gt; &gt;&gt; changes that need to be backported.
> &gt; &gt; Let's make sure we can bake the backports in a dedicated
> repository so that we can have a better sense on what the changes would
> entail.
> &gt; &gt;
> &gt; &gt;  After reaching to skara-dev, the only thing needed to create
> these repositories is for the riscv-project to contact ops at openjdk dot
> org. @Fei Yang, I am assuming you'd need to contact them being the
> riscv-port lead.
> &gt;
> &gt;  Sure! I just sent an email to ops at openjdk.java.net requesting
> creation of following three new repos:
> &gt;
> &gt;   1. https://github.com/openjdk/riscv-port-jdk17u
> &gt;   2. https://github.com/openjdk/riscv-port-jdk11u
> &gt;   3. https://github.com/openjdk/riscv-port-jdk8u
> &gt;
> &gt; Let's see :-)
> &gt;
> &gt; Thanks,
> &gt; Fei
> &gt; </jdk-updates-dev at openjdk.java.net></yadonn.wang at huawei.com></
> riscv-port-dev at openjdk.org></zhangxiang at iscas.ac.cn></yangfei at iscas.ac.cn
> ></goetz.lindenmaier at sap.com></ludovic at rivosinc.com>
> </jdk-updates-dev at openjdk.java.net></yadonn.wang at huawei.com></
> riscv-port-dev at openjdk.org></zhangxiang at iscas.ac.cn></
> goetz.lindenmaier at sap.com></ludovic at rivosinc.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/riscv-port-dev/attachments/20230201/f873255c/attachment.htm>

From vladimir.kempik at gmail.com  Wed Feb  1 09:35:02 2023
From: vladimir.kempik at gmail.com (Vladimir Kempik)
Date: Wed, 1 Feb 2023 12:35:02 +0300
Subject: Backports to jdk11u and jdk17u
In-Reply-To: <23420643.13c67.1860ac93267.Coremail.yangfei@iscas.ac.cn>
References: <CADT88DvbXvzMx5h6kDCnmrp2rvKy8iDDPpWWSiZuCT8_hkTGig@mail.gmail.com>
 <79ab2542.1f08.185ba593e97.Coremail.yangfei@iscas.ac.cn>
 <2b9d63dc.2ad6.185bac8df55.Coremail.zhangxiang@iscas.ac.cn>
 <CADT88DvmwLiKZDxw4BX-zrN0p5aUYeKqTr6TORXXAz+jjRS8dw@mail.gmail.com>
 <5e09da27.4add.185bed323a6.Coremail.yangfei@iscas.ac.cn>
 <PAXPR02MB8245971774A3A617415AA6B8ECC69@PAXPR02MB8245.eurprd02.prod.outlook.com>
 <CADT88DsT6Hu_t=rXVCYTvWzKTYBBFGhNQDVrSKkSzOoVoEf=hw@mail.gmail.com>
 <1bb15352.1af1.185c4eb5693.Coremail.yangfei@iscas.ac.cn>
 <23420643.13c67.1860ac93267.Coremail.yangfei@iscas.ac.cn>
Message-ID: <89D8FD2C-60F0-4AE6-894F-6B0403C65443@gmail.com>

Hello

After initial jep-422. we saw few bug-fixes coming in, they were critical for risc-v.
We should probably identify and include them into the port ?

For example:
https://bugs.openjdk.org/browse/JDK-8293100

Regards, Vladimir

> 1 ????. 2023 ?., ? 05:23, yangfei at iscas.ac.cn ???????(?):
> 
> Hi all,
> 
>  Good news is that following three repos have been created by ops and should be ready for use!
> 
>    https://github.com/openjdk/riscv-port-jdk17u
>    https://github.com/openjdk/riscv-port-jdk11u
>    https://github.com/openjdk/riscv-port-jdk8u
> 
>  They are seeded with jdk{17, 11, 8}u-dev repos respectively. 
>  We should start from riscv-port-jdk17u. And I have created a riscv-port branch in this repo for future 17u backporting work. 
>  As mentioned by Lindenmaier Goetz, the initial backport should be restricted to the changes that are definitely needed to get it working. 
>  Also, changes to shared code should be kept to a minimum. 
>  Please let me know if there are other things missed. 
> 
> Thanks,
> Fei Yang
> 
> &gt; -----Original Messages-----
> &gt; From: yangfei at iscas.ac.cn
> &gt; Sent Time: 2023-01-18 20:47:15 (Wednesday)
> &gt; To: "Ludovic Henry" <ludovic at rivosinc.com>
> &gt; Cc: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>, "??" <zhangxiang at iscas.ac.cn>, "riscv-port-dev at openjdk.org" <riscv-port-dev at openjdk.org>, "yadonn.wang at huawei.com" <yadonn.wang at huawei.com>, "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
> &gt; Subject: Re: Re: Re: Re: Backports to jdk11u and jdk17u
> &gt; 
> &gt; -----Original Messages-----
> &gt; From:"Ludovic Henry" <ludovic at rivosinc.com>
> &gt; Sent Time:2023-01-18 17:05:58 (Wednesday)
> &gt; To: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>
> &gt; Cc: "yangfei at iscas.ac.cn" <yangfei at iscas.ac.cn>, "??" <zhangxiang at iscas.ac.cn>, "riscv-port-dev at openjdk.org" <riscv-port-dev at openjdk.org>, "yadonn.wang at huawei.com" <yadonn.wang at huawei.com>, "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
> &gt; Subject: Re: Re: Re: Backports to jdk11u and jdk17u
> &gt; 
> &gt; Hi,  
> &gt; 
> &gt; &gt;&gt; It would be great to see a complete list of
> &gt; &gt;&gt; changes that need to be backported.
> &gt; &gt; Let's make sure we can bake the backports in a dedicated repository so that we can have a better sense on what the changes would entail.  
> &gt; &gt; 
> &gt; &gt;  After reaching to skara-dev, the only thing needed to create these repositories is for the riscv-project to contact ops at openjdk dot org. @Fei Yang, I am assuming you'd need to contact them being the riscv-port lead.
> &gt; 
> &gt;  Sure! I just sent an email to ops at openjdk.java.net requesting creation of following three new repos:
> &gt; 
> &gt;   1. https://github.com/openjdk/riscv-port-jdk17u
> &gt;   2. https://github.com/openjdk/riscv-port-jdk11u
> &gt;   3. https://github.com/openjdk/riscv-port-jdk8u
> &gt; 
> &gt; Let's see :-)
> &gt; 
> &gt; Thanks,
> &gt; Fei
> &gt; </jdk-updates-dev at openjdk.java.net></yadonn.wang at huawei.com></riscv-port-dev at openjdk.org></zhangxiang at iscas.ac.cn></yangfei at iscas.ac.cn></goetz.lindenmaier at sap.com></ludovic at rivosinc.com>
> </jdk-updates-dev at openjdk.java.net></yadonn.wang at huawei.com></riscv-port-dev at openjdk.org></zhangxiang at iscas.ac.cn></goetz.lindenmaier at sap.com></ludovic at rivosinc.com>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/riscv-port-dev/attachments/20230201/9dbf3feb/attachment-0001.htm>

From yadonn.wang at huawei.com  Thu Feb  2 09:46:05 2023
From: yadonn.wang at huawei.com (wangyadong (E))
Date: Thu, 2 Feb 2023 09:46:05 +0000
Subject: Backports to jdk11u and jdk17u
In-Reply-To: <89D8FD2C-60F0-4AE6-894F-6B0403C65443@gmail.com>
References: <CADT88DvbXvzMx5h6kDCnmrp2rvKy8iDDPpWWSiZuCT8_hkTGig@mail.gmail.com>
 <79ab2542.1f08.185ba593e97.Coremail.yangfei@iscas.ac.cn>
 <2b9d63dc.2ad6.185bac8df55.Coremail.zhangxiang@iscas.ac.cn>
 <CADT88DvmwLiKZDxw4BX-zrN0p5aUYeKqTr6TORXXAz+jjRS8dw@mail.gmail.com>
 <5e09da27.4add.185bed323a6.Coremail.yangfei@iscas.ac.cn>
 <PAXPR02MB8245971774A3A617415AA6B8ECC69@PAXPR02MB8245.eurprd02.prod.outlook.com>
 <CADT88DsT6Hu_t=rXVCYTvWzKTYBBFGhNQDVrSKkSzOoVoEf=hw@mail.gmail.com>
 <1bb15352.1af1.185c4eb5693.Coremail.yangfei@iscas.ac.cn>
 <23420643.13c67.1860ac93267.Coremail.yangfei@iscas.ac.cn>
 <89D8FD2C-60F0-4AE6-894F-6B0403C65443@gmail.com>
Message-ID: <601d67bfedc141f1b2101f9ebde24619@huawei.com>

Hi,

I have a ?ready-to-go? recently-rebased backport version of jdk17u-dev for riscv (https://github.com/yadongw/jdk17u-dev/tree/backport-riscv-port-v6).

It based on the initial implementation of JEP-422 with some modifications for backport to 17u, and included a collection of patches that I think are necessary. We can discuss whether it's appropriate.

I suggest to do an initial backport PR including 1, 2, 3 and 4. And the list of patches in 5 require more effort from anyone interested to backport one by one, if necessary.
Looking forward to your comments.


1.       The initial patch
commit 84efeb4e3e0e6b0c03f5ab043f276cf537de3b81
Author: yadongw <yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>>
Date:   Sat Apr 2 15:58:06 2022 +0800

    8276799: Implementation of JEP 422: Linux/RISC-V Port


2.        remove features that do not belong to jdk 17
commit ce9864243a9d75589ed444cd439c02d2ae710ff9
Author: yadongw <yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>>
Date:   Thu Apr 7 20:33:59 2022 +0800

    revert 8277417: C1 LIR instruction for load-klass

commit 441d0e77ad7579849c9533f15ca44b3843fb55af
Author: yadongw <yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>>
Date:   Thu Apr 7 20:47:42 2022 +0800

    revert 8278387: Implement UseHeavyMonitors consistently

commit 492b705ba21b5022207f361e9c4c3e4d23896ad5
Author: yadongw <yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>>
Date:   Thu Apr 7 21:09:05 2022 +0800

    revert 8227369: pd_disjoint_words_atomic() needs to be atomic

commit 0fec342dba256726e3b2e592533bc5deb9c58e84
Author: yadongw <yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>>
Date:   Thu Apr 7 21:14:51 2022 +0800

    revert 8258192: Obsolete the CriticalNatives flag

commit cc6cd9de04f5b6ff8612fc1691f6226942863b30
Author: yadongw <yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>>
Date:   Thu Apr 7 21:12:43 2022 +0800

    revert 8281632: riscv: Improve interpreter stack banging

commit ac8fc147f82f78e7cab87e5f1301d7510348600e
Author: yadongw <yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>>
Date:   Sat Apr 23 11:37:50 2022 +0800

    revert 8283364: Intrinsify countPositives


3.       add features that belongs to jdk 17

commit 930df079ec09715c65a93ce20893fb58bf5e8e89
Author: yadongw <yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>>
Date:   Fri Apr 1 12:04:41 2022 +0800

    enable the biased locking


4.        Wrap modifications to shared code under RISCV and revert changes to other platforms
commit 5a8be1b201142c0f0c245d0ff2d01c5290a69e95
Author: yadongw <yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>>
Date:   Sun May 22 23:38:56 2022 +0800

isolate modification to other platforms


5.       Patch list for backport
5.1 patch for bugfix
8282306: os::is_first_C_frame(frame*) crashes on invalid link access
8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler
8293007: riscv: failed to build after JDK-8290025
8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub
8284191: Replace usages of 'a the' in hotspot and java.base
8285437: riscv: Fix MachNode size mismatch for MacroAssembler::verify_oops*
8287552: riscv: Fix comment typo in li64
8287970: riscv: jdk/incubator/vector/*VectorTests failing
8290496: riscv: Fix build warnings-as-errors with GCC 11
8291893: riscv: remove fence.i used in user space
8291947: riscv: fail to build after JDK-8290840
8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6
8294083: RISC-V: Minimal build failed with --disable-precompiled-headers
8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops
8294190: Incorrect check messages in SharedRuntime::generate_uncommon_trap_blob
8295016: Make the arraycopy_epilogue signature consistent with its usage
8295468: RISC-V: Minimal builds are broken
8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic
8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null
8296771: RISC-V: C2: assert(false) failed: bad AD file


5.2   Other refactoring patches
8290137: riscv: small refactoring for add_memory_int32/64
8292867: RISC-V: Simplify weak CAS return value handling
8293050: RISC-V: Remove redundant non-null assertions about macro-assembler
8293290: RISC-V: Explicitly pass a third temp register to MacroAssembler::store_heap_oop
8293474: RISC-V: Unify the way of moving function pointer
8293524: RISC-V: Use macro-assembler functions as appropriate
8293566: RISC-V: Clean up push and pop registers
8293769: RISC-V: Add a second temporary register for BarrierSetAssembler::load_at
8293781: RISC-V: Clarify types of calls
8293840: RISC-V: Remove cbuf parameter from far_call/far_jump/trampoline_call
8294086: RISC-V: Cleanup InstructionMark usages in the backend
8294100: RISC-V: Move rt_call and xxx_move from SharedRuntime to MacroAssembler
8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate()
8294366: RISC-V: Partially mark out incompressible regions
8294430: RISC-V: Small refactoring for movptr_with_offset
8294492: RISC-V: Use li instead of patchable movptr at non-patchable callsites
8295110: RISC-V: Mark out relocations as incompressible
8295270: RISC-V: Clean up and refactoring for assembler functions
8295273: Remove unused argument in [load/store]_sized_value on aarch64 and riscv
8295396: RISC-V: Cleanup useless CompressibleRegions
8295703: RISC-V: Remove implicit noreg temp register arguments in MacroAssembler
8295968: RISC-V: Rename some assembler intrinsic functions for RVV 1.0


From: Vladimir Kempik [mailto:vladimir.kempik at gmail.com]
Sent: Wednesday, February 1, 2023 5:35 PM
To: yangfei at iscas.ac.cn
Cc: Ludovic Henry <ludovic at rivosinc.com>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; ?? <zhangxiang at iscas.ac.cn>; riscv-port-dev at openjdk.org; wangyadong (E) <yadonn.wang at huawei.com>; jdk-updates-dev at openjdk.java.net
Subject: Re: Backports to jdk11u and jdk17u

Hello

After initial jep-422. we saw few bug-fixes coming in, they were critical for risc-v.
We should probably identify and include them into the port ?

For example:
https://bugs.openjdk.org/browse/JDK-8293100

Regards, Vladimir


1 ????. 2023 ?., ? 05:23, yangfei at iscas.ac.cn<mailto:yangfei at iscas.ac.cn> ???????(?):

Hi all,

 Good news is that following three repos have been created by ops and should be ready for use!

   https://github.com/openjdk/riscv-port-jdk17u
   https://github.com/openjdk/riscv-port-jdk11u
   https://github.com/openjdk/riscv-port-jdk8u

 They are seeded with jdk{17, 11, 8}u-dev repos respectively.
 We should start from riscv-port-jdk17u. And I have created a riscv-port branch in this repo for future 17u backporting work.
 As mentioned by Lindenmaier Goetz, the initial backport should be restricted to the changes that are definitely needed to get it working.
 Also, changes to shared code should be kept to a minimum.
 Please let me know if there are other things missed.

Thanks,
Fei Yang

&gt; -----Original Messages-----
&gt; From: yangfei at iscas.ac.cn<mailto:yangfei at iscas.ac.cn>
&gt; Sent Time: 2023-01-18 20:47:15 (Wednesday)
&gt; To: "Ludovic Henry" <ludovic at rivosinc.com<mailto:ludovic at rivosinc.com>>
&gt; Cc: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>>, "??" <zhangxiang at iscas.ac.cn<mailto:zhangxiang at iscas.ac.cn>>, "riscv-port-dev at openjdk.org<mailto:riscv-port-dev at openjdk.org>" <riscv-port-dev at openjdk.org<mailto:riscv-port-dev at openjdk.org>>, "yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>" <yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>>, "jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>" <jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>>
&gt; Subject: Re: Re: Re: Re: Backports to jdk11u and jdk17u
&gt;
&gt; -----Original Messages-----
&gt; From:"Ludovic Henry" <ludovic at rivosinc.com<mailto:ludovic at rivosinc.com>>
&gt; Sent Time:2023-01-18 17:05:58 (Wednesday)
&gt; To: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>>
&gt; Cc: "yangfei at iscas.ac.cn<mailto:yangfei at iscas.ac.cn>" <yangfei at iscas.ac.cn<mailto:yangfei at iscas.ac.cn>>, "??" <zhangxiang at iscas.ac.cn<mailto:zhangxiang at iscas.ac.cn>>, "riscv-port-dev at openjdk.org<mailto:riscv-port-dev at openjdk.org>" <riscv-port-dev at openjdk.org<mailto:riscv-port-dev at openjdk.org>>, "yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>" <yadonn.wang at huawei.com<mailto:yadonn.wang at huawei.com>>, "jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>" <jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>>
&gt; Subject: Re: Re: Re: Backports to jdk11u and jdk17u
&gt;
&gt; Hi,
&gt;
&gt; &gt;&gt; It would be great to see a complete list of
&gt; &gt;&gt; changes that need to be backported.
&gt; &gt; Let's make sure we can bake the backports in a dedicated repository so that we can have a better sense on what the changes would entail.
&gt; &gt;
&gt; &gt;  After reaching to skara-dev, the only thing needed to create these repositories is for the riscv-project to contact ops at openjdk dot org. @Fei Yang, I am assuming you'd need to contact them being the riscv-port lead.
&gt;
&gt;  Sure! I just sent an email to ops at openjdk.java.net<mailto:ops at openjdk.java.net> requesting creation of following three new repos:
&gt;
&gt;   1. https://github.com/openjdk/riscv-port-jdk17u
&gt;   2. https://github.com/openjdk/riscv-port-jdk11u
&gt;   3. https://github.com/openjdk/riscv-port-jdk8u
&gt;
&gt; Let's see :-)
&gt;
&gt; Thanks,
&gt; Fei
&gt; </jdk-updates-dev at openjdk.java.net<mailto:/jdk-updates-dev at openjdk.java.net>></yadonn.wang at huawei.com<mailto:/yadonn.wang at huawei.com>></riscv-port-dev at openjdk.org<mailto:/riscv-port-dev at openjdk.org>></zhangxiang at iscas.ac.cn<mailto:/zhangxiang at iscas.ac.cn>></yangfei at iscas.ac.cn<mailto:/yangfei at iscas.ac.cn>></goetz.lindenmaier at sap.com<mailto:/goetz.lindenmaier at sap.com>></ludovic at rivosinc.com<mailto:/ludovic at rivosinc.com>>
</jdk-updates-dev at openjdk.java.net<mailto:/jdk-updates-dev at openjdk.java.net>></yadonn.wang at huawei.com<mailto:/yadonn.wang at huawei.com>></riscv-port-dev at openjdk.org<mailto:/riscv-port-dev at openjdk.org>></zhangxiang at iscas.ac.cn<mailto:/zhangxiang at iscas.ac.cn>></goetz.lindenmaier at sap.com<mailto:/goetz.lindenmaier at sap.com>></ludovic at rivosinc.com<mailto:/ludovic at rivosinc.com>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/riscv-port-dev/attachments/20230202/c04f0fce/attachment-0001.htm>

From shade at redhat.com  Thu Feb  2 10:34:51 2023
From: shade at redhat.com (Aleksey Shipilev)
Date: Thu, 2 Feb 2023 11:34:51 +0100
Subject: Backports to jdk11u and jdk17u
In-Reply-To: <23420643.13c67.1860ac93267.Coremail.yangfei@iscas.ac.cn>
References: <CADT88DvbXvzMx5h6kDCnmrp2rvKy8iDDPpWWSiZuCT8_hkTGig@mail.gmail.com>
 <79ab2542.1f08.185ba593e97.Coremail.yangfei@iscas.ac.cn>
 <2b9d63dc.2ad6.185bac8df55.Coremail.zhangxiang@iscas.ac.cn>
 <CADT88DvmwLiKZDxw4BX-zrN0p5aUYeKqTr6TORXXAz+jjRS8dw@mail.gmail.com>
 <5e09da27.4add.185bed323a6.Coremail.yangfei@iscas.ac.cn>
 <PAXPR02MB8245971774A3A617415AA6B8ECC69@PAXPR02MB8245.eurprd02.prod.outlook.com>
 <CADT88DsT6Hu_t=rXVCYTvWzKTYBBFGhNQDVrSKkSzOoVoEf=hw@mail.gmail.com>
 <1bb15352.1af1.185c4eb5693.Coremail.yangfei@iscas.ac.cn>
 <23420643.13c67.1860ac93267.Coremail.yangfei@iscas.ac.cn>
Message-ID: <a85288a3-4862-000d-8b25-092cbebf6934@redhat.com>

On 2/1/23 03:23, yangfei at iscas.ac.cn wrote:
>    Good news is that following three repos have been created by ops and should be ready for use!
> 
>      https://github.com/openjdk/riscv-port-jdk17u
>      https://github.com/openjdk/riscv-port-jdk11u
>      https://github.com/openjdk/riscv-port-jdk8u
> 
>    They are seeded with jdk{17, 11, 8}u-dev repos respectively.
>    We should start from riscv-port-jdk17u. And I have created a riscv-port branch in this repo for future 17u backporting work.
>    As mentioned by Lindenmaier Goetz, the initial backport should be restricted to the changes that are definitely needed to get it working.
>    Also, changes to shared code should be kept to a minimum.
>    Please let me know if there are other things missed.

I have added the webrev autogeneration from these repos to my CI:
   https://builds.shipilev.net/patch-openjdk-riscv-jdk8/
   https://builds.shipilev.net/patch-openjdk-riscv-jdk11/
   https://builds.shipilev.net/patch-openjdk-riscv-jdk17/

These diff "riscv-port" branch against relevant master fork. Only 17u currently has such a branch, 
and it is currently empty. This is why only that webrev is generated. Once we put more stuff into 
that branch, I would also provide the nightly builds for it. This would test if the backport breaks 
anything else.

-- 
Thanks,
-Aleksey


From ludovic at rivosinc.com  Thu Feb  2 10:31:28 2023
From: ludovic at rivosinc.com (Ludovic Henry)
Date: Thu, 2 Feb 2023 11:31:28 +0100
Subject: Backports to jdk11u and jdk17u
In-Reply-To: <601d67bfedc141f1b2101f9ebde24619@huawei.com>
References: <CADT88DvbXvzMx5h6kDCnmrp2rvKy8iDDPpWWSiZuCT8_hkTGig@mail.gmail.com>
 <79ab2542.1f08.185ba593e97.Coremail.yangfei@iscas.ac.cn>
 <2b9d63dc.2ad6.185bac8df55.Coremail.zhangxiang@iscas.ac.cn>
 <CADT88DvmwLiKZDxw4BX-zrN0p5aUYeKqTr6TORXXAz+jjRS8dw@mail.gmail.com>
 <5e09da27.4add.185bed323a6.Coremail.yangfei@iscas.ac.cn>
 <PAXPR02MB8245971774A3A617415AA6B8ECC69@PAXPR02MB8245.eurprd02.prod.outlook.com>
 <CADT88DsT6Hu_t=rXVCYTvWzKTYBBFGhNQDVrSKkSzOoVoEf=hw@mail.gmail.com>
 <1bb15352.1af1.185c4eb5693.Coremail.yangfei@iscas.ac.cn>
 <23420643.13c67.1860ac93267.Coremail.yangfei@iscas.ac.cn>
 <89D8FD2C-60F0-4AE6-894F-6B0403C65443@gmail.com>
 <601d67bfedc141f1b2101f9ebde24619@huawei.com>
Message-ID: <CADT88DuHo82XWX=J0a+MJ=9tjL-rT_CHHsegEqRvHTMyh7R8sA@mail.gmail.com>

> I suggest to do an initial backport PR including 1, 2, 3 and 4. And the
list of patches in 5 require more effort from anyone interested to backport
one by one, if necessary.

Thank you for all of these!

I would say we start with 1, 2, 3, and 4. For 5, I'll want to take a more
in depth look at each of these changes. Discussing these on the mailing
list is the most appropriate I think.

@Lindenmaier, Goetz <goetz.lindenmaier at sap.com> , what's the policy for
changes which are in the architecture specific folders (os_cpu/linux_riscv
and cpu/riscv)? I understand the general push to keep these to a minimum,
but are there other aspects to the tradeoffs we want to make (performance,
features, readability of the code, etc.)?



On Thu, Feb 2, 2023 at 10:46 AM wangyadong (E) <yadonn.wang at huawei.com>
wrote:

> Hi,
>
>
>
> I have a ?ready-to-go? recently-rebased backport version of jdk17u-dev for
> riscv (https://github.com/yadongw/jdk17u-dev/tree/backport-riscv-port-v6).
>
>
>
> It based on the initial implementation of JEP-422 with some modifications
> for backport to 17u, and included a collection of patches that I think are
> necessary. We can discuss whether it's appropriate.
>
>
>
> I suggest to do an initial backport PR including 1, 2, 3 and 4. And the
> list of patches in 5 require more effort from anyone interested to backport
> one by one, if necessary.
>
> Looking forward to your comments.
>
>
>
> 1.       The initial patch
>
> commit 84efeb4e3e0e6b0c03f5ab043f276cf537de3b81
>
> Author: yadongw <yadonn.wang at huawei.com>
>
> Date:   Sat Apr 2 15:58:06 2022 +0800
>
>
>
>     8276799: Implementation of JEP 422: Linux/RISC-V Port
>
>
>
> 2.        remove features that do not belong to jdk 17
>
> commit ce9864243a9d75589ed444cd439c02d2ae710ff9
>
> Author: yadongw <yadonn.wang at huawei.com>
>
> Date:   Thu Apr 7 20:33:59 2022 +0800
>
>
>
>     revert 8277417: C1 LIR instruction for load-klass
>
>
>
> commit 441d0e77ad7579849c9533f15ca44b3843fb55af
>
> Author: yadongw <yadonn.wang at huawei.com>
>
> Date:   Thu Apr 7 20:47:42 2022 +0800
>
>
>
>     revert 8278387: Implement UseHeavyMonitors consistently
>
>
>
> commit 492b705ba21b5022207f361e9c4c3e4d23896ad5
>
> Author: yadongw <yadonn.wang at huawei.com>
>
> Date:   Thu Apr 7 21:09:05 2022 +0800
>
>
>
>     revert 8227369: pd_disjoint_words_atomic() needs to be atomic
>
>
>
> commit 0fec342dba256726e3b2e592533bc5deb9c58e84
>
> Author: yadongw <yadonn.wang at huawei.com>
>
> Date:   Thu Apr 7 21:14:51 2022 +0800
>
>
>
>     revert 8258192: Obsolete the CriticalNatives flag
>
>
>
> commit cc6cd9de04f5b6ff8612fc1691f6226942863b30
>
> Author: yadongw <yadonn.wang at huawei.com>
>
> Date:   Thu Apr 7 21:12:43 2022 +0800
>
>
>
>     revert 8281632: riscv: Improve interpreter stack banging
>
>
>
> commit ac8fc147f82f78e7cab87e5f1301d7510348600e
>
> Author: yadongw <yadonn.wang at huawei.com>
>
> Date:   Sat Apr 23 11:37:50 2022 +0800
>
>
>
>     revert 8283364: Intrinsify countPositives
>
>
>
> 3.       add features that belongs to jdk 17
>
>
>
> commit 930df079ec09715c65a93ce20893fb58bf5e8e89
>
> Author: yadongw <yadonn.wang at huawei.com>
>
> Date:   Fri Apr 1 12:04:41 2022 +0800
>
>
>
>     enable the biased locking
>
>
>
> 4.        Wrap modifications to shared code under RISCV and revert
> changes to other platforms
>
> commit 5a8be1b201142c0f0c245d0ff2d01c5290a69e95
>
> Author: yadongw <yadonn.wang at huawei.com>
>
> Date:   Sun May 22 23:38:56 2022 +0800
>
>
>
> isolate modification to other platforms
>
>
>
> 5.       Patch list for backport
>
> 5.1 patch for bugfix
>
> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
>
> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with
> async profiler
>
> 8293007: riscv: failed to build after JDK-8290025
>
> 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in
> StubGenerator::generate_call_stub
>
> 8284191: Replace usages of 'a the' in hotspot and java.base
>
> 8285437: riscv: Fix MachNode size mismatch for MacroAssembler::verify_oops*
>
> 8287552: riscv: Fix comment typo in li64
>
> 8287970: riscv: jdk/incubator/vector/*VectorTests failing
>
> 8290496: riscv: Fix build warnings-as-errors with GCC 11
>
> 8291893: riscv: remove fence.i used in user space
>
> 8291947: riscv: fail to build after JDK-8290840
>
> 8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6
>
> 8294083: RISC-V: Minimal build failed with --disable-precompiled-headers
>
> 8294087: RISC-V: RVC: Fix a potential alignment issue and add more
> alignment assertions for the patchable calls/nops
>
> 8294190: Incorrect check messages in
> SharedRuntime::generate_uncommon_trap_blob
>
> 8295016: Make the arraycopy_epilogue signature consistent with its usage
>
> 8295468: RISC-V: Minimal builds are broken
>
> 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic
>
> 8296448: RISC-V: Fix temp usages of heapbase register killed by
> MacroAssembler::en/decode_klass_not_null
>
> 8296771: RISC-V: C2: assert(false) failed: bad AD file
>
>
>
> 5.2   Other refactoring patches
>
> 8290137: riscv: small refactoring for add_memory_int32/64
>
> 8292867: RISC-V: Simplify weak CAS return value handling
>
> 8293050: RISC-V: Remove redundant non-null assertions about macro-assembler
>
> 8293290: RISC-V: Explicitly pass a third temp register to
> MacroAssembler::store_heap_oop
>
> 8293474: RISC-V: Unify the way of moving function pointer
>
> 8293524: RISC-V: Use macro-assembler functions as appropriate
>
> 8293566: RISC-V: Clean up push and pop registers
>
> 8293769: RISC-V: Add a second temporary register for
> BarrierSetAssembler::load_at
>
> 8293781: RISC-V: Clarify types of calls
>
> 8293840: RISC-V: Remove cbuf parameter from
> far_call/far_jump/trampoline_call
>
> 8294086: RISC-V: Cleanup InstructionMark usages in the backend
>
> 8294100: RISC-V: Move rt_call and xxx_move from SharedRuntime to
> MacroAssembler
>
> 8294187: RISC-V: Unify all relocations for the backend into
> AbstractAssembler::relocate()
>
> 8294366: RISC-V: Partially mark out incompressible regions
>
> 8294430: RISC-V: Small refactoring for movptr_with_offset
>
> 8294492: RISC-V: Use li instead of patchable movptr at non-patchable
> callsites
>
> 8295110: RISC-V: Mark out relocations as incompressible
>
> 8295270: RISC-V: Clean up and refactoring for assembler functions
>
> 8295273: Remove unused argument in [load/store]_sized_value on aarch64 and
> riscv
>
> 8295396: RISC-V: Cleanup useless CompressibleRegions
>
> 8295703: RISC-V: Remove implicit noreg temp register arguments in
> MacroAssembler
>
> 8295968: RISC-V: Rename some assembler intrinsic functions for RVV 1.0
>
>
>
>
>
> *From:* Vladimir Kempik [mailto:vladimir.kempik at gmail.com]
> *Sent:* Wednesday, February 1, 2023 5:35 PM
> *To:* yangfei at iscas.ac.cn
> *Cc:* Ludovic Henry <ludovic at rivosinc.com>; Lindenmaier, Goetz <
> goetz.lindenmaier at sap.com>; ?? <zhangxiang at iscas.ac.cn>;
> riscv-port-dev at openjdk.org; wangyadong (E) <yadonn.wang at huawei.com>;
> jdk-updates-dev at openjdk.java.net
> *Subject:* Re: Backports to jdk11u and jdk17u
>
>
>
> Hello
>
>
>
> After initial jep-422. we saw few bug-fixes coming in, they were critical
> for risc-v.
>
> We should probably identify and include them into the port ?
>
>
>
> For example:
>
> https://bugs.openjdk.org/browse/JDK-8293100
>
>
>
> Regards, Vladimir
>
>
>
> 1 ????. 2023 ?., ? 05:23, yangfei at iscas.ac.cn ???????(?):
>
>
>
> Hi all,
>
>  Good news is that following three repos have been created by ops and
> should be ready for use!
>
>    https://github.com/openjdk/riscv-port-jdk17u
>    https://github.com/openjdk/riscv-port-jdk11u
>    https://github.com/openjdk/riscv-port-jdk8u
>
>  They are seeded with jdk{17, 11, 8}u-dev repos respectively.
>  We should start from riscv-port-jdk17u. And I have created a riscv-port
> branch in this repo for future 17u backporting work.
>  As mentioned by Lindenmaier Goetz, the initial backport should be
> restricted to the changes that are definitely needed to get it working.
>  Also, changes to shared code should be kept to a minimum.
>  Please let me know if there are other things missed.
>
> Thanks,
> Fei Yang
>
> &gt; -----Original Messages-----
> &gt; From: yangfei at iscas.ac.cn
> &gt; Sent Time: 2023-01-18 20:47:15 (Wednesday)
> &gt; To: "Ludovic Henry" <ludovic at rivosinc.com>
> &gt; Cc: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>, "??" <
> zhangxiang at iscas.ac.cn>, "riscv-port-dev at openjdk.org" <
> riscv-port-dev at openjdk.org>, "yadonn.wang at huawei.com" <
> yadonn.wang at huawei.com>, "jdk-updates-dev at openjdk.java.net" <
> jdk-updates-dev at openjdk.java.net>
> &gt; Subject: Re: Re: Re: Re: Backports to jdk11u and jdk17u
> &gt;
> &gt; -----Original Messages-----
> &gt; From:"Ludovic Henry" <ludovic at rivosinc.com>
> &gt; Sent Time:2023-01-18 17:05:58 (Wednesday)
> &gt; To: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>
> &gt; Cc: "yangfei at iscas.ac.cn" <yangfei at iscas.ac.cn>, "??" <
> zhangxiang at iscas.ac.cn>, "riscv-port-dev at openjdk.org" <
> riscv-port-dev at openjdk.org>, "yadonn.wang at huawei.com" <
> yadonn.wang at huawei.com>, "jdk-updates-dev at openjdk.java.net" <
> jdk-updates-dev at openjdk.java.net>
> &gt; Subject: Re: Re: Re: Backports to jdk11u and jdk17u
> &gt;
> &gt; Hi,
> &gt;
> &gt; &gt;&gt; It would be great to see a complete list of
> &gt; &gt;&gt; changes that need to be backported.
> &gt; &gt; Let's make sure we can bake the backports in a dedicated
> repository so that we can have a better sense on what the changes would
> entail.
> &gt; &gt;
> &gt; &gt;  After reaching to skara-dev, the only thing needed to create
> these repositories is for the riscv-project to contact ops at openjdk dot
> org. @Fei Yang, I am assuming you'd need to contact them being the
> riscv-port lead.
> &gt;
> &gt;  Sure! I just sent an email to ops at openjdk.java.net requesting
> creation of following three new repos:
> &gt;
> &gt;   1. https://github.com/openjdk/riscv-port-jdk17u
> &gt;   2. https://github.com/openjdk/riscv-port-jdk11u
> &gt;   3. https://github.com/openjdk/riscv-port-jdk8u
> &gt;
> &gt; Let's see :-)
> &gt;
> &gt; Thanks,
> &gt; Fei
> &gt; </jdk-updates-dev at openjdk.java.net></yadonn.wang at huawei.com><
> /riscv-port-dev at openjdk.org></zhangxiang at iscas.ac.cn></yangfei at iscas.ac.cn
> ></goetz.lindenmaier at sap.com></ludovic at rivosinc.com>
> </jdk-updates-dev at openjdk.java.net></yadonn.wang at huawei.com><
> /riscv-port-dev at openjdk.org></zhangxiang at iscas.ac.cn><
> /goetz.lindenmaier at sap.com></ludovic at rivosinc.com>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/riscv-port-dev/attachments/20230202/1ca47b5e/attachment-0001.htm>

From yan at openjdk.org  Tue Feb  7 13:45:21 2023
From: yan at openjdk.org (Yuri Nesterenko)
Date: Tue, 7 Feb 2023 13:45:21 GMT
Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 20 new changesets
Message-ID: <977e05b8-a7a2-47ef-aade-8973e21e548e@openjdk.org>

Changeset: 49a0287c
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-01 09:08:56 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/49a0287c437942e114ba47811ac871e51cc6fa90

6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java

Backport-of: 8a662105c2da1f0fb9b7ecc5058fc85858439ed9

! test/jdk/sun/management/jmxremote/LocalRMIServerSocketFactoryTest.java

Changeset: 71f53ada
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-01 09:14:01 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/71f53adab839b2ced0d6855770ac2ea5b4dc6ee2

8286154: Fix 3rd party notices in test files

Backport-of: 1277f5d84e9c2863595396a471a61d83f8a0298c

! test/jdk/java/text/BreakIterator/BreakIteratorTest.java
! test/jdk/java/text/CharacterIterator/CharacterIteratorTest.java
! test/jdk/java/text/Format/ChoiceFormat/Bug4185732Test.java
! test/jdk/java/text/Format/MessageFormat/Bug4185816Test.java
! test/jdk/java/util/Locale/Bug4184873Test.java
! test/jdk/java/util/Locale/LocaleTest.java
! test/jdk/java/util/Locale/PrintDefaultLocale.java
! test/jdk/java/util/ResourceBundle/Bug4179766Class.java
! test/jdk/java/util/ResourceBundle/Bug4179766Getter.java
! test/jdk/java/util/ResourceBundle/Bug4179766Resource.java
! test/jdk/java/util/ResourceBundle/FakeTestResource.java
! test/jdk/java/util/ResourceBundle/RBTestFmwk.java
! test/jdk/java/util/ResourceBundle/ResourceBundleTest.java
! test/jdk/java/util/ResourceBundle/TestBug4179766.java
! test/jdk/java/util/ResourceBundle/TestResource.java
! test/jdk/java/util/ResourceBundle/TestResource_de.java
! test/jdk/java/util/ResourceBundle/TestResource_fr.java
! test/jdk/java/util/ResourceBundle/TestResource_fr_CH.java
! test/jdk/java/util/ResourceBundle/TestResource_it.java
! test/jdk/sun/text/IntHashtable/patch-src/java.base/java/text/Bug4170614Test.java
! test/jdk/sun/text/resources/LocaleDataTest.java

Changeset: 62461a29
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-01 09:15:37 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/62461a298a4a4bf7c75a7f5d2e88041da02c75bc

8271838: AmazonCA.java interop test fails

Backport-of: 512db0ff31a0a1a2bd8805964ba3d06e2cbfb9e9

! test/jdk/security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java

Changeset: 535c64b6
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-01 09:22:28 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/535c64b658e1ba0da24517d535ca5b70432d3330

8209935: Test to cover CodeSource.getCodeSigners()

Backport-of: 0cb0ecf4433f1054ba2f0fbdabee01323893e0fe

+ test/jdk/java/security/CodeSource/CertsMatch.java
! test/jdk/java/security/CodeSource/Implies.java
+ test/jdk/java/security/CodeSource/certs

Changeset: c9fac0e3
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-01 09:25:20 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/c9fac0e3eae84ae01d1f6e06cfc043ba1c7bb335

8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions

Backport-of: 784fa0add77a3e473e2cdbdcc27b3ed076678565

! test/jdk/java/util/zip/ZipFile/DeleteTempJar.java

Changeset: b9e4d10c
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-01 09:27:01 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/b9e4d10ce9304991880bd502a1bbefb729d9a39f

8289440: Remove vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003 from ProblemList.txt

Backport-of: 00d06d4a82c5cbc8cc5fde97caa8cb56279c441a

! test/hotspot/jtreg/ProblemList.txt
! test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded001.java

Changeset: 83c0805b
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-02-01 16:44:06 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/83c0805b45d9c0df5bfb770a43ec42f0316ce675

8289948: Improve test coverage for XPath functions: Node Set Functions

Backport-of: 57bf603b7332db86c39680d16b78f94a904daf46

! test/jaxp/javax/xml/jaxp/unittest/xpath/XPathAnyTypeTest.java
! test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpAnyTypeTest.java
+ test/jaxp/javax/xml/jaxp/unittest/xpath/XPathNodeSetFnTest.java
! test/jaxp/javax/xml/jaxp/unittest/xpath/XPathTestBase.java

Changeset: 7224cbe0
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-02 20:01:18 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/7224cbe0871946efe7db763831fb82226dc3d00c

8287593: ShortResponseBody could be made more resilient to rogue connections

Reviewed-by: chegar
Backport-of: 9ccae7078e22c27a8f84152f005c628534c9af53

! test/jdk/java/net/httpclient/ShortResponseBody.java

Changeset: a3f22885
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-02 20:04:10 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/a3f228858e71f7812324532e75480f10b5aa2f6b

8286844: com/sun/jdi/RedefineCrossEvent.java failed with 1 threads completed while VM suspended

Backport-of: 7ec0132ad3129b805664c85351fe6d55041066fa

! test/jdk/com/sun/jdi/DebuggerThreadTest.java

Changeset: 50c34336
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-02 20:05:31 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/50c34336e497c868ed5402931dad6dd863cfdc4f

8291825: java/time/nontestng/java/time/zone/CustomZoneNameTest.java fails if defaultLocale and defaultFormatLocale are different

Backport-of: 4772354f4caf5eb314eda81217e5bc48a62d485b

! test/jdk/java/time/nontestng/java/time/zone/zoneProvider/custom/CustomTimeZoneNameProvider.java

Changeset: 78c6be2d
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-02 20:07:14 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/78c6be2dc04edab1912459568c599cd72f11e647

8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases

Backport-of: e8bc87956abc92851de8694c56a78f6ecc546cbd

! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestBoolean.java
! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestByte.java
! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestChar.java
! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestDouble.java
! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestFloat.java
! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestInt.java
! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestLong.java
! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestObject.java
! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestShort.java
! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestBoolean.java
! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestByte.java
! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestChar.java
! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestDouble.java
! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestFloat.java
! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestInt.java
! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestLong.java
! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestObject.java
! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestShort.java
! test/hotspot/jtreg/compiler/unsafe/X-UnsafeAccessTest.java.template
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessBoolean.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessByte.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessChar.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessDouble.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessFloat.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessInt.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessLong.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessShort.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessString.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsChar.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsDouble.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsFloat.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsLong.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsShort.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessBoolean.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessByte.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessChar.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessDouble.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessFloat.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessInt.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessLong.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessShort.java
! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessString.java
! test/jdk/java/lang/invoke/VarHandles/X-VarHandleTestAccess.java.template
! test/jdk/java/lang/invoke/VarHandles/X-VarHandleTestByteArrayView.java.template
! test/jdk/java/lang/invoke/VarHandles/X-VarHandleTestMethodHandleAccess.java.template

Changeset: c74eb2bf
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-02 20:10:16 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/c74eb2bffd85aeff47f81dfce75f2bb2c5d7c1d7

8292066: Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version

Backport-of: 032be168b5a6af6f9e82deb8c8cafcd2c44b5447

! test/jdk/java/lang/management/OperatingSystemMXBean/GetSystemLoadAverage.java
- test/jdk/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh
! test/jdk/java/lang/management/RuntimeMXBean/InputArgument.java
- test/jdk/java/lang/management/RuntimeMXBean/TestInputArgument.sh

Changeset: 012a216c
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-02 20:13:20 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/012a216cbbefa4581cf4dea04f4bd24934eccc6f

8289400: Improve com/sun/jdi/TestScaffold error reporting

Backport-of: da99e3e8299f3a476603aa43a99164c2c01adff4

! test/jdk/com/sun/jdi/TestScaffold.java

Changeset: 38eb0d6c
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-02 20:15:20 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/38eb0d6c27448d375baba7f0c8883261d059e067

8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows

Backport-of: 205f992e9ecf9f83bb052ee2e2a32e3f532c5ac9

! test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java

Changeset: fe770e32
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-02-03 18:41:57 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/fe770e32a197e850dfd4f510a1047ad95cf7dd06

8299296: Write a test to verify the components selection sends ItemEvent

Backport-of: 5ae6de859d472d107cdf642c417c6d2f1c74e5db

+ test/jdk/java/awt/event/ComponentEvent/ComponentItemEventTest.java

Changeset: 2fa09bbc
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-02-03 19:22:30 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/2fa09bbc6953e1b6142bc149c94c44fcd8870347

8290836: Improve test coverage for XPath functions: String Functions
8290837: Improve test coverage for XPath functions: Boolean Functions
8290838: Improve test coverage for XPath functions: Number Functions

Backport-of: d889264c6123b6c28bdd6336f5ae547e4e441aa7

+ test/jaxp/javax/xml/jaxp/unittest/xpath/XPathBooleanFnTest.java
! test/jaxp/javax/xml/jaxp/unittest/xpath/XPathNodeSetFnTest.java
+ test/jaxp/javax/xml/jaxp/unittest/xpath/XPathNumberFnTest.java
+ test/jaxp/javax/xml/jaxp/unittest/xpath/XPathStringFnTest.java
! test/jaxp/javax/xml/jaxp/unittest/xpath/XPathTestBase.java

Changeset: 0ed36894
Author:    Ichiroh Takiguchi <itakiguchi at openjdk.org>
Date:      2023-02-04 04:50:37 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/0ed36894a98dfb5365f23179e722e141289cd500

8299194: CustomTzIDCheckDST.java may fail at future date

Backport-of: 5e2de89628aaf6acb8e458fb417426ca5e477bea

! test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java

Changeset: ddd9631f
Author:    Thomas Stuefe <stuefe at openjdk.org>
Date:      2023-02-05 07:48:37 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/ddd9631f329b9e8170098117b5816e22f0855ac1

8294677: chunklevel::MAX_CHUNK_WORD_SIZE too small for some applications

Reviewed-by: phh, xliu
Backport-of: 2292ce137c16accf0622600d5a096403b8a8058d

! src/hotspot/share/memory/metaspace/chunklevel.hpp
! src/hotspot/share/memory/metaspace/metaspaceSettings.hpp
! test/hotspot/gtest/metaspace/test_chunkManager_stress.cpp
! test/hotspot/gtest/metaspace/test_metachunk.cpp
! test/hotspot/gtest/metaspace/test_metaspace_misc.cpp
! test/hotspot/gtest/metaspace/test_virtualspacenode.cpp
! test/hotspot/jtreg/runtime/CompressedOops/CompressedClassSpaceSize.java
! test/hotspot/jtreg/runtime/Metaspace/elastic/Settings.java
! test/hotspot/jtreg/runtime/Metaspace/elastic/TestMetaspaceAllocationMT1.java
! test/hotspot/jtreg/runtime/Metaspace/elastic/TestMetaspaceAllocationMT2.java

Changeset: ceabaee8
Author:    Radim Vansa <rvansa at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
Date:      2023-02-06 12:29:10 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/ceabaee8a676195016468ef445a27d89c112cfe6

8300590: [JVMCI] BytecodeFrame.equals is broken

Reviewed-by: phh
Backport-of: 06394ee8b110fe8e37a3b9e582f5dfbf225a3d89

! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/BytecodeFrame.java
+ test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestBytecodeFrame.java

Changeset: 4ab869e9
Author:    Radim Vansa <rvansa at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
Date:      2023-02-06 12:39:32 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/4ab869e9308055314a3a1dadbb4b781948438267

8296329: jar validator doesn't account for minor class file version

Reviewed-by: yan
Backport-of: faf48e61be4f97f725b053aa351d3c64638546bf

! src/jdk.jartool/share/classes/sun/tools/jar/FingerPrint.java
! test/jdk/tools/jar/multiRelease/MRTestBase.java
+ test/jdk/tools/jar/multiRelease/VersionValidatorTest.java


From yadongwang at openjdk.org  Sun Feb 12 12:28:02 2023
From: yadongwang at openjdk.org (Yadong Wang)
Date: Sun, 12 Feb 2023 12:28:02 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port
Message-ID: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>

This PR backports the implementation of RISC-V port into jdk17u. 

It based on the initial implementation of JEP-422 with some modifications for jdk17u:
1.	The initial patch
    8276799: Implementation of JEP 422: Linux/RISC-V Port
2.	 remove features that do not belong to jdk17u
    revert 8277417: C1 LIR instruction for load-klass
    revert 8278387: Implement UseHeavyMonitors consistently
    revert 8227369: pd_disjoint_words_atomic() needs to be atomic
    revert 8258192: Obsolete the CriticalNatives flag
    revert 8281632: riscv: Improve interpreter stack banging
    revert 8283364: Intrinsify countPositives
3.	add features that belongs to jdk17u
    enable the biased locking
4.	 Wrap modifications to shared code under RISCV and revert changes to other platforms
isolate modification to other platforms
5.	Patches for making compilation pass
8282306: os::is_first_C_frame(frame*) crashes on invalid link access
8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler

-------------

Commit messages:
 - fix copyright year
 - 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
 - 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler
 - isolate modification to other platforms
 - enable the biased locking
 - revert 8283364: Intrinsify countPositives
 - revert 8281632: riscv: Improve interpreter stack banging
 - revert 8258192: Obsolete the CriticalNatives flag
 - revert 8227369: pd_disjoint_words_atomic() needs to be atomic
 - revert 8278387: Implement UseHeavyMonitors consistently
 - ... and 2 more: https://git.openjdk.org/riscv-port-jdk17u/compare/501a4bf9...47916a22

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/1/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=1&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8276799
  Stats: 59945 lines in 185 files changed: 59814 ins; 43 del; 88 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/1.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/1/head:pull/1

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From luhenry at openjdk.org  Sun Feb 12 12:28:02 2023
From: luhenry at openjdk.org (Ludovic Henry)
Date: Sun, 12 Feb 2023 12:28:02 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port
In-Reply-To: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
Message-ID: <CJomzvwUQvHCyyOAqJZsAIqyIPmWdQ8BnweLC_fa2D4=.bc61dd03-cbb5-4882-a534-27df2a1bb53a@github.com>

On Tue, 7 Feb 2023 11:20:37 GMT, Yadong Wang <yadongwang at openjdk.org> wrote:

> This PR backports the implementation of RISC-V port into jdk17u. 
> 
> It based on the initial implementation of JEP-422 with some modifications for jdk17u:
> 1.	The initial patch
>     8276799: Implementation of JEP 422: Linux/RISC-V Port
> 2.	 remove features that do not belong to jdk17u
>     revert 8277417: C1 LIR instruction for load-klass
>     revert 8278387: Implement UseHeavyMonitors consistently
>     revert 8227369: pd_disjoint_words_atomic() needs to be atomic
>     revert 8258192: Obsolete the CriticalNatives flag
>     revert 8281632: riscv: Improve interpreter stack banging
>     revert 8283364: Intrinsify countPositives
> 3.	add features that belongs to jdk17u
>     enable the biased locking
> 4.	 Wrap modifications to shared code under RISCV and revert changes to other platforms
> isolate modification to other platforms
> 5.	Patches for making compilation pass
> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler

Love to see this!

How has it been tested? I'm happy to submit some changes to this riscv-port branch to add testing for tier1 on GHA if that's any help (similar to https://github.com/rivosinc/jdk/actions/runs/4028920698).

Ok, I'll work on submitting a PR tomorrow. It'll be limited to `.github/` so should be fairly easy to isolate.

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From fyang at openjdk.org  Sun Feb 12 12:28:02 2023
From: fyang at openjdk.org (Fei Yang)
Date: Sun, 12 Feb 2023 12:28:02 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port
In-Reply-To: <CJomzvwUQvHCyyOAqJZsAIqyIPmWdQ8BnweLC_fa2D4=.bc61dd03-cbb5-4882-a534-27df2a1bb53a@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
 <CJomzvwUQvHCyyOAqJZsAIqyIPmWdQ8BnweLC_fa2D4=.bc61dd03-cbb5-4882-a534-27df2a1bb53a@github.com>
Message-ID: <6SV1fUHBZVw7qcr6YgV7JakFUmrVtVhK5QZPHt7tZ9s=.e43953d1-9cb0-4145-a39c-00f2c5b67807@github.com>

On Tue, 7 Feb 2023 13:44:50 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> This PR backports the implementation of RISC-V port into jdk17u. 
>> 
>> It based on the initial implementation of JEP-422 with some modifications for jdk17u:
>> 1.	The initial patch
>>     8276799: Implementation of JEP 422: Linux/RISC-V Port
>> 2.	 remove features that do not belong to jdk17u
>>     revert 8277417: C1 LIR instruction for load-klass
>>     revert 8278387: Implement UseHeavyMonitors consistently
>>     revert 8227369: pd_disjoint_words_atomic() needs to be atomic
>>     revert 8258192: Obsolete the CriticalNatives flag
>>     revert 8281632: riscv: Improve interpreter stack banging
>>     revert 8283364: Intrinsify countPositives
>> 3.	add features that belongs to jdk17u
>>     enable the biased locking
>> 4.	 Wrap modifications to shared code under RISCV and revert changes to other platforms
>> isolate modification to other platforms
>> 5.	Patches for making compilation pass
>> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
>> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler
>
> Love to see this!
> 
> How has it been tested? I'm happy to submit some changes to this riscv-port branch to add testing for tier1 on GHA if that's any help (similar to https://github.com/rivosinc/jdk/actions/runs/4028920698).

@luhenry : That sounds great. It's nice if we could have some basic tier1 testing enabled for this branch on GHA.
PS: I believe Yadong is still testing patch and I am also trying this on my Unmatched board.

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From yadongwang at openjdk.org  Sun Feb 12 12:28:02 2023
From: yadongwang at openjdk.org (Yadong Wang)
Date: Sun, 12 Feb 2023 12:28:02 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port
In-Reply-To: <CJomzvwUQvHCyyOAqJZsAIqyIPmWdQ8BnweLC_fa2D4=.bc61dd03-cbb5-4882-a534-27df2a1bb53a@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
 <CJomzvwUQvHCyyOAqJZsAIqyIPmWdQ8BnweLC_fa2D4=.bc61dd03-cbb5-4882-a534-27df2a1bb53a@github.com>
Message-ID: <iYQ87TjA5HBOGmEefgrFU_OlE9dQa4c_nM5fLfWigvo=.62f48a9e-0d11-4697-b41a-c9d90890a8c4@github.com>

On Tue, 7 Feb 2023 13:44:50 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

> Love to see this!
> 
> How has it been tested? I'm happy to submit some changes to this riscv-port branch to add testing for tier1 on GHA if that's any help (similar to https://github.com/rivosinc/jdk/actions/runs/4028920698).

Tier1 tests are running on unmatched boards, and a full jtreg tests are running with Qemu. Happy to see more tests, and some failures may be related to existed issues.

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From vkempik at openjdk.org  Sun Feb 12 12:38:03 2023
From: vkempik at openjdk.org (Vladimir Kempik)
Date: Sun, 12 Feb 2023 12:38:03 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port
In-Reply-To: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
Message-ID: <8i17DvxZrXvnlbOuLQ93AgQL-Aknp50Whg31lmKE-U4=.ef84765d-ecdb-4bbd-b6e6-e34455d7bf51@github.com>

On Tue, 7 Feb 2023 11:20:37 GMT, Yadong Wang <yadongwang at openjdk.org> wrote:

> This PR backports the implementation of RISC-V port into jdk17u. 
> 
> It based on the initial implementation of JEP-422 with some modifications for jdk17u:
> 1.	The initial patch
>     8276799: Implementation of JEP 422: Linux/RISC-V Port
> 2.	 remove features that do not belong to jdk17u
>     revert 8277417: C1 LIR instruction for load-klass
>     revert 8278387: Implement UseHeavyMonitors consistently
>     revert 8227369: pd_disjoint_words_atomic() needs to be atomic
>     revert 8258192: Obsolete the CriticalNatives flag
>     revert 8281632: riscv: Improve interpreter stack banging
>     revert 8283364: Intrinsify countPositives
> 3.	add features that belongs to jdk17u
>     enable the biased locking
> 4.	 Wrap modifications to shared code under RISCV and revert changes to other platforms
> isolate modification to other platforms
> 5.	Patches for making compilation pass
> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler

Hello
could you include https://bugs.openjdk.org/browse/JDK-8293100 into initial backport ?

it was really critical for risc-v and some jni stress tests from vmtestBase/hotspot:tier4 was failing

JDK17 ready backport can be used from https://github.com/syntacore/syntaj17/commit/2053a4ba85078bcfc956676256264f6d7b68061c

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From fyang at openjdk.org  Sun Feb 12 12:45:04 2023
From: fyang at openjdk.org (Fei Yang)
Date: Sun, 12 Feb 2023 12:45:04 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port
In-Reply-To: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
Message-ID: <hABQ0ErH6QqFgfUNlXyfd9jpNtvEfBb4FvQVc60vIec=.bd42821d-d488-40b8-b982-cf8afdb042d4@github.com>

On Tue, 7 Feb 2023 11:20:37 GMT, Yadong Wang <yadongwang at openjdk.org> wrote:

> This PR backports the implementation of RISC-V port into jdk17u. 
> 
> It based on the initial implementation of JEP-422 with some modifications for jdk17u:
> 1.	The initial patch
>     8276799: Implementation of JEP 422: Linux/RISC-V Port
> 2.	 remove features that do not belong to jdk17u
>     revert 8277417: C1 LIR instruction for load-klass
>     revert 8278387: Implement UseHeavyMonitors consistently
>     revert 8227369: pd_disjoint_words_atomic() needs to be atomic
>     revert 8258192: Obsolete the CriticalNatives flag
>     revert 8281632: riscv: Improve interpreter stack banging
>     revert 8283364: Intrinsify countPositives
> 3.	add features that belongs to jdk17u
>     enable the biased locking
> 4.	 Wrap modifications to shared code under RISCV and revert changes to other platforms
> isolate modification to other platforms
> 5.	Patches for making compilation pass
> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler

Let me share some of the testing results carried out on my unmatched boards:
- [x] boot-cycle (fastdebug)
- [x] Tier1-3 tests (release)
- [x] Non-trivial benchmark tests like: renaissance, specjbb2015 (release)
- [ ] Tier4 test in progress (release)

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From fyang at openjdk.org  Sun Feb 12 12:57:04 2023
From: fyang at openjdk.org (Fei Yang)
Date: Sun, 12 Feb 2023 12:57:04 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port
In-Reply-To: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
Message-ID: <yePQZ46Sr3ycX_JuIDtXB2HGcL-Zquw9zxym9uTObH0=.1363cbea-e838-4deb-b9c9-effc938187bb@github.com>

On Tue, 7 Feb 2023 11:20:37 GMT, Yadong Wang <yadongwang at openjdk.org> wrote:

> This PR backports the implementation of RISC-V port into jdk17u. 
> 
> It based on the initial implementation of JEP-422 with some modifications for jdk17u:
> 1.	The initial patch
>     8276799: Implementation of JEP 422: Linux/RISC-V Port
> 2.	 remove features that do not belong to jdk17u
>     revert 8277417: C1 LIR instruction for load-klass
>     revert 8278387: Implement UseHeavyMonitors consistently
>     revert 8227369: pd_disjoint_words_atomic() needs to be atomic
>     revert 8258192: Obsolete the CriticalNatives flag
>     revert 8281632: riscv: Improve interpreter stack banging
>     revert 8283364: Intrinsify countPositives
> 3.	add features that belongs to jdk17u
>     enable the biased locking
> 4.	 Wrap modifications to shared code under RISCV and revert changes to other platforms
> isolate modification to other platforms
> 5.	Patches for making compilation pass
> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler

> Hello could you include https://bugs.openjdk.org/browse/JDK-8293100 into initial backport ?
> 
> it was really critical for risc-v and some jni stress tests from vmtestBase/hotspot:tier4 was failing
> 
> JDK17 ready backport can be used from [syntacore/syntaj17 at 2053a4b](https://github.com/syntacore/syntaj17/commit/2053a4ba85078bcfc956676256264f6d7b68061c)

I think that deserves another seperate PR after this one? I see the robot is trying to link backporting PRs with the original issue. So it might not be a good idea to put serveral seperate fixes together into one backporting PR.

But the following two changes included in this PR are kind of special as they are needed for a successfull build/bootcycle:
  8282306: os::is_first_C_frame(frame*) crashes on invalid link access
  8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From vkempik at openjdk.org  Sun Feb 12 13:07:49 2023
From: vkempik at openjdk.org (Vladimir Kempik)
Date: Sun, 12 Feb 2023 13:07:49 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port
In-Reply-To: <yePQZ46Sr3ycX_JuIDtXB2HGcL-Zquw9zxym9uTObH0=.1363cbea-e838-4deb-b9c9-effc938187bb@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
 <yePQZ46Sr3ycX_JuIDtXB2HGcL-Zquw9zxym9uTObH0=.1363cbea-e838-4deb-b9c9-effc938187bb@github.com>
Message-ID: <7gpmOnwj3zokHVzgGGpZjglzxIG5-PKq99e7AccrTdc=.d952c36b-797e-4b99-a757-9685dbce7c42@github.com>

On Sun, 12 Feb 2023 12:53:10 GMT, Fei Yang <fyang at openjdk.org> wrote:

> I think that deserves another seperate backporting PR after this one? I see the robot is trying to link each backporting PR with the original issue. So it might not be a good idea to put serveral seperate fixes together into one backporting PR.

Last time I was backporting JEP ( https://github.com/openjdk/jdk11u-dev/pull/715 ) it was ok. Just order scara-bot few commands /issue 8282306 , /issue 8282477.

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From fyang at openjdk.org  Sun Feb 12 13:29:03 2023
From: fyang at openjdk.org (Fei Yang)
Date: Sun, 12 Feb 2023 13:29:03 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port
In-Reply-To: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
Message-ID: <DYoBqCZJBlmT56y1mpQl6Y8kvihgnH_4gja6SdrsEpw=.f8326b37-50e6-4e03-a824-ee17133cfd0c@github.com>

On Tue, 7 Feb 2023 11:20:37 GMT, Yadong Wang <yadongwang at openjdk.org> wrote:

> This PR backports the implementation of RISC-V port into jdk17u. 
> 
> It based on the initial implementation of JEP-422 with some modifications for jdk17u:
> 1.	The initial patch
>     8276799: Implementation of JEP 422: Linux/RISC-V Port
> 2.	 remove features that do not belong to jdk17u
>     revert 8277417: C1 LIR instruction for load-klass
>     revert 8278387: Implement UseHeavyMonitors consistently
>     revert 8227369: pd_disjoint_words_atomic() needs to be atomic
>     revert 8258192: Obsolete the CriticalNatives flag
>     revert 8281632: riscv: Improve interpreter stack banging
>     revert 8283364: Intrinsify countPositives
> 3.	add features that belongs to jdk17u
>     enable the biased locking
> 4.	 Wrap modifications to shared code under RISCV and revert changes to other platforms
> isolate modification to other platforms
> 5.	Patches for making compilation pass
> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler

> > I think that deserves another seperate backporting PR after this one? I see the robot is trying to link each backporting PR with the original issue. So it might not be a good idea to put serveral seperate fixes together into one backporting PR.
> 
> Last time I was backporting JEP ( [openjdk/jdk11u-dev#715](https://github.com/openjdk/jdk11u-dev/pull/715) ) it was ok. Just order scara-bot few commands /issue 8282306 , /issue 8282477.

Hmm, I think that might be a good way when we are doing the final upstreaming. For now, I still prefer to keep a simple/clean relationship between a backporting PR and the corresponding issue unless there is a special reason for this staging repo.
@yadongw : Please link these two issues (8282306 & 8282477) with this backporting PR.

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From fyang at openjdk.org  Wed Feb 15 02:41:37 2023
From: fyang at openjdk.org (Fei Yang)
Date: Wed, 15 Feb 2023 02:41:37 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port
In-Reply-To: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
Message-ID: <JMTsgFyVNBhiRAtjfh4bcL5DDrBUtotDMkrOU_wgtIo=.a7b9fc1e-fdf1-40a5-8115-235c719c9646@github.com>

On Tue, 7 Feb 2023 11:20:37 GMT, Yadong Wang <yadongwang at openjdk.org> wrote:

> This PR backports the implementation of RISC-V port into jdk17u. 
> 
> It based on the initial implementation of JEP-422 with some modifications for jdk17u:
> 1.	The initial patch
>     8276799: Implementation of JEP 422: Linux/RISC-V Port
> 2.	 remove features that do not belong to jdk17u
>     revert 8277417: C1 LIR instruction for load-klass
>     revert 8278387: Implement UseHeavyMonitors consistently
>     revert 8227369: pd_disjoint_words_atomic() needs to be atomic
>     revert 8258192: Obsolete the CriticalNatives flag
>     revert 8281632: riscv: Improve interpreter stack banging
>     revert 8283364: Intrinsify countPositives
> 3.	add features that belongs to jdk17u
>     enable the biased locking
> 4.	 Wrap modifications to shared code under RISCV and revert changes to other platforms
> isolate modification to other platforms
> 5.	Patches for making compilation pass
> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler

So I have finished the aforementioned tests on my unmatched boards.
The test results are expected. I think we can proceed reviewing this now.
The tests also expose several build/test failures that should be resolved by backporting other fixes.

0. https://bugs.openjdk.org/browse/JDK-8290496
- To resolve build warnings-as-errors

1. https://bugs.openjdk.org/browse/JDK-8290164
- TEST: compiler/runtime/TestConstantsInError.java

2. https://bugs.openjdk.org/browse/JDK-8292407
- TEST: compiler/unsafe/JdkInternalMiscUnsafeAccessTestChar.java
- TEST: java/lang/invoke/VarHandles/VarHandleTestAccessChar.java
- And others

3. https://bugs.openjdk.org/browse/JDK-8293100
- TEST: vmTestbase/nsk/stress/jni/jnistress002.java

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From goetz at openjdk.org  Wed Feb 15 03:03:46 2023
From: goetz at openjdk.org (Goetz Lindenmaier)
Date: Wed, 15 Feb 2023 03:03:46 GMT
Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 20 new changesets
Message-ID: <fbb9e170-cced-45e5-a35f-3955ff630593@openjdk.org>

Changeset: beaf5b10
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-08 16:05:51 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/beaf5b10c231ca82aec95c74ea9db58a596203a3

8286962: java/net/httpclient/ServerCloseTest.java failed once with ConnectException

Backport-of: 13d4ddc35b1a64e2d882c7dcd554b5aee2720c53

! test/jdk/java/net/httpclient/ServerCloseTest.java

Changeset: a15041a2
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-08 16:07:41 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/a15041a232d1ba273dd7366f35da674381a01688

8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx
8241293: CompressedClassSpaceSizeInJmapHeap.java time out after 8 minutes

Reviewed-by: phh
Backport-of: 99a6c47855ad82e81a80726cf3aa4522c547716d

! test/hotspot/jtreg/ProblemList.txt
! test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java

Changeset: 651ec7d1
Author:    Yuri Nesterenko <yan at openjdk.org>
Date:      2023-02-10 07:49:07 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/651ec7d1f4165a3d0c125c9fe09b496706ae2f09

8301760: Fix possible leak in SpNegoContext dispose

Backport-of: 3f3356bcbd2b2fbc545263dc70a48ee931a4e56b

! src/java.security.jgss/share/classes/sun/security/jgss/spnego/SpNegoContext.java

Changeset: 3330f9c2
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-02-10 07:52:38 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/3330f9c2ad508fdb9100a2400abdd3366342dde1

8301170: perfMemory_windows.cpp add free_security_attr to early returns

Backport-of: 810c8a271b4524ae776e2306ef699e04a7d145a2

! src/hotspot/os/windows/perfMemory_windows.cpp

Changeset: cb1a54ab
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-10 08:34:17 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/cb1a54abd40c240008f1b2fd6d4dc87c2e837f29

8195809: [TESTBUG] jps and jcmd -l support for containers is not tested

Backport-of: 7c26ddb575bb6f1161850c31a933d154ae8b96e3

+ test/hotspot/jtreg/containers/docker/TestJcmd.java
! test/hotspot/jtreg/containers/docker/TestJcmdWithSideCar.java
! test/lib/jdk/test/lib/containers/docker/DockerfileConfig.java

Changeset: b023d5c1
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-10 08:35:42 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/b023d5c1fbbfaab29b4c6fd96083b6b0b5b49e68

8290083: ResponseBodyBeforeError: AssertionError or SSLException: Unsupported or unrecognized SSL message

Backport-of: 3b9059a1471ba74af8bf6a3c0e5b2e1140eb4afd

! test/jdk/java/net/httpclient/ResponseBodyBeforeError.java

Changeset: d52e18c9
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-10 08:37:36 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/d52e18c92d307f5f6e9e649d410a54bef3a910da

8286030: Avoid JVM crash when containers share the same /tmp dir

Reviewed-by: stuefe
Backport-of: 84f23149e22561173feb0e34bca31a7345b43c89

! src/hotspot/os/posix/perfMemory_posix.cpp
+ test/hotspot/jtreg/containers/docker/ShareTmpDir.java
+ test/hotspot/jtreg/containers/docker/WaitForFlagFile.java

Changeset: 49023f45
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-10 08:39:14 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/49023f45f38d229f63c782a7a5f644d803ba443f

8293819: sun/util/logging/PlatformLoggerTest.java failed with "RuntimeException: Retrieved backing PlatformLogger level null is not the expected CONFIG"

Backport-of: 11e7d53b23796cbd3d878048f7553885ae07f4d1

! test/jdk/sun/util/logging/PlatformLoggerTest.java

Changeset: 1b5825cc
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-10 08:40:41 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/1b5825cc60e04992153e82ff570d3f9041001e2f

8292328: AccessibleActionsTest.java test instruction for show popup on JLabel did not specify shift key

Backport-of: df53fa752a81a88b9495978cccb3d7b9f5ed553c

! test/jdk/java/awt/a11y/AccessibleActionsTest.java

Changeset: 5bef90fa
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-10 08:41:59 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/5bef90fad339092c76ae800fd41891929fc178e2

8296675: Exclude linux-aarch64 in NSS tests

Backport-of: fa8a8668a6656046d713a6b09244adfc81556d63

! test/jdk/sun/security/pkcs11/PKCS11Test.java

Changeset: a248b78a
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-12 19:07:05 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/a248b78a5305fa7dda9d1943004e606092c0df49

8295000: java/util/Formatter/Basic test cleanup

Backport-of: 78763fc8e0d6940f1c85ff8705733b8e6ae8e945

! test/jdk/java/util/Formatter/Basic-X.java.template
! test/jdk/java/util/Formatter/BasicBigDecimal.java
! test/jdk/java/util/Formatter/BasicBigInteger.java
! test/jdk/java/util/Formatter/BasicBoolean.java
! test/jdk/java/util/Formatter/BasicBooleanObject.java
! test/jdk/java/util/Formatter/BasicByte.java
! test/jdk/java/util/Formatter/BasicByteObject.java
! test/jdk/java/util/Formatter/BasicChar.java
! test/jdk/java/util/Formatter/BasicCharObject.java
! test/jdk/java/util/Formatter/BasicDateTime.java
! test/jdk/java/util/Formatter/BasicDouble.java
! test/jdk/java/util/Formatter/BasicDoubleObject.java
! test/jdk/java/util/Formatter/BasicFloat.java
! test/jdk/java/util/Formatter/BasicFloatObject.java
! test/jdk/java/util/Formatter/BasicInt.java
! test/jdk/java/util/Formatter/BasicIntObject.java
! test/jdk/java/util/Formatter/BasicLong.java
! test/jdk/java/util/Formatter/BasicLongObject.java
! test/jdk/java/util/Formatter/BasicShort.java
! test/jdk/java/util/Formatter/BasicShortObject.java

Changeset: fab9770b
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-12 19:08:08 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/fab9770b890b58ae438103978071aaf94d57a5d5

8295774: Write a test to verify List sends ItemEvent/ActionEvent

Backport-of: 2a79dfc1f9c419e92aac99f92ef4e40a3471695b

+ test/jdk/java/awt/event/ComponentEvent/ListItemEventsTest.java

Changeset: 20211715
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-13 14:35:38 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/202117158b751705eb8335b095c22a88edbd6770

8186765: Speed up test sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java

Backport-of: 43dbf5899b455acf7c665d221564c4d4dff7dea4

! test/jdk/sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java

Changeset: 05f1bdb2
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-13 14:39:12 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/05f1bdb236ebc13b83fc957f8c7ee5239621e8e9

8223783: sun/net/www/http/HttpClient/MultiThreadTest.java sometimes detect threads+1 connections

Backport-of: 8effaa8f1f550d2cd0ff369f99436a8a7401fa10

! test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java

Changeset: da75daf5
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-13 14:41:05 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/da75daf547b19c2d67cb43c123be0fdde826fd57

8297489: Modify TextAreaTextEventTest.java as to verify the content change of TextComponent sends TextEvent

Backport-of: 7d20a60a983e459ea1c4e843fbde70fb796c6249

- test/jdk/java/awt/event/ComponentEvent/TextAreaTextEventTest.java
+ test/jdk/java/awt/event/ComponentEvent/TextComponentTextEventTest.java

Changeset: a800231f
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-13 14:42:44 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/a800231f17a5081de7f2336742faa97b11f12b3b

8299018: java/net/httpclient/HttpsTunnelAuthTest.java fails with java.io.IOException: HTTP/1.1 header parser received no bytes

Backport-of: e5edb10dc56d9edac8e050e0f8e6c116743975d6

! test/jdk/java/net/httpclient/ProxyServer.java

Changeset: 95a805bb
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-14 09:30:06 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/95a805bbd58282e847fe2c9ea0334dd3fff89086

8299671: Speed up compiler/intrinsics/string/TestStringLatin1IndexOfChar.java

Backport-of: d2827ec8f77020241fee7d613fb7cf081b455eb9

! test/hotspot/jtreg/compiler/intrinsics/string/TestStringLatin1IndexOfChar.java

Changeset: 17084d59
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-02-14 15:10:53 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/17084d59f7460fa4da13c38115c5235579826dae

8299957: Enhance error logging in instrument coding with additional jplis_assert_msg

Backport-of: be8e6d05db2f623626506e64a2fb7caf755d5d06

! src/java.instrument/share/native/libinstrument/InvocationAdapter.c
! src/java.instrument/share/native/libinstrument/JPLISAgent.c

Changeset: 8b309685
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-02-14 15:12:38 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/8b309685dab761469cad2336815461aa47032fab

8300205: Swing test bug8078268 make latch timeout configurable

Backport-of: e82dc6935b5f575a53fcba9c96767cee1b535cb8

! test/jdk/javax/swing/text/html/parser/Parser/8078268/bug8078268.java

Changeset: 68d7ac57
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-14 20:06:35 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/68d7ac57e53f48c4fbb4275725f165262a05fe66

8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

Backport-of: a2f67660f088559ce49f73da7401801fb826028b

! test/jdk/java/awt/PopupMenu/PopupMenuLocation.java


From fjiang at openjdk.org  Thu Feb 16 13:28:16 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Thu, 16 Feb 2023 13:28:16 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port
In-Reply-To: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
Message-ID: <uyokK4QVwKIxJ8lCoNZ385TTzbhvTgg4F879s3kIu5g=.dc21bc78-ce6f-4776-afc2-cd244f4c8974@github.com>

On Tue, 7 Feb 2023 11:20:37 GMT, Yadong Wang <yadongwang at openjdk.org> wrote:

> This PR backports the implementation of RISC-V port into jdk17u. 
> 
> It based on the initial implementation of JEP-422 with some modifications for jdk17u:
> 1.	The initial patch
>     8276799: Implementation of JEP 422: Linux/RISC-V Port
> 2.	 remove features that do not belong to jdk17u
>     revert 8277417: C1 LIR instruction for load-klass
>     revert 8278387: Implement UseHeavyMonitors consistently
>     revert 8227369: pd_disjoint_words_atomic() needs to be atomic
>     revert 8258192: Obsolete the CriticalNatives flag
>     revert 8281632: riscv: Improve interpreter stack banging
>     revert 8283364: Intrinsify countPositives
> 3.	add features that belongs to jdk17u
>     enable the biased locking
> 4.	 Wrap modifications to shared code under RISCV and revert changes to other platforms
> isolate modification to other platforms
> 5.	Patches for making compilation pass
> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler

Overall looks good, thanks.

src/hotspot/cpu/riscv/riscv.ad line 2367:

> 2365:     __ add(tmp, disp_hdr, (ObjectMonitor::owner_offset_in_bytes() - markWord::monitor_value));
> 2366:     __ cmpxchg(/*memory address*/tmp, /*expected value*/zr, /*new value*/xthread, Assembler::int64, Assembler::aq,
> 2367:              Assembler::rl, /*result*/flag); // cas succeeds if flag == zr(expected)

Indentation here could be improved too.

src/hotspot/cpu/riscv/riscv.ad line 2422:

> 2420:     // object.
> 2421: 
> 2422:     __ cmpxchg(/*memory address*/oop, /*expected value*/box, /*new value*/disp_hdr, Assembler::int64, Assembler::relaxed,

Could you adjust the indentation here to align with https://github.com/openjdk/riscv-port-jdk17u/blob/47916a22eed5c92d56a330a481635c355274062f/src/hotspot/cpu/riscv/riscv.ad#L2335-L2336

-------------

Marked as reviewed by fjiang (no project role).

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From yunyao.zxl at alibaba-inc.com  Fri Feb 17 07:53:59 2023
From: yunyao.zxl at alibaba-inc.com (Xiaolin Zheng)
Date: Fri, 17 Feb 2023 15:53:59 +0800
Subject: =?UTF-8?B?RGlzY3VzcyB0aGUgUklTQy1WIE9wZW5KREsxMXUgcG9ydA==?=
Message-ID: <a4a23424-d508-4992-9049-9ffeff58991d.yunyao.zxl@alibaba-inc.com>

Hi team,
We would like to discuss the RISC-V OpenJDK11u port.
Currently seems no one claims this port yet, and it would be a pleasure for us if we (from Alibaba) could take the backporting work.
We have a backport [1] [2] on Alibaba Dragonwell11 (downstream of our OpenJDK11) that works fine currently, though backported from the initial load of the riscv-port repo [3] at the beginning of the last year. We are currently thinking of contributing that to the upstream, despite that various polishing, patch splitting, and further backporting to meet the requirements of backports are needed. So obviously it is not a "ready-to-go" one like the 17u port [4] by Yadong.
Some challenging parts might be the differences between the gaps in 11u and 19 and above. For example, on 11u we do not have a VecA implementation, yet, the RVV vector extension in the RISC-V backend [5] in the mainline needs it. The VecA implementation may look currently unlikely to get permission to backport since the changes [6] in shared code. Without VecA, C2 vector intrinsics and the VectorAPI-related code may not work, but intrinsics using vector registers directly could work as expected, like `StubGenerator::copy_memory_v`.
Looking forward to further discussions.
Best Regards,
Xiaolin
[1] https://github.com/alibaba/dragonwell11/commit/959fa35e24714f63c9e8d835268e3a9aef898a22 <https://github.com/alibaba/dragonwell11/commit/959fa35e24714f63c9e8d835268e3a9aef898a22 >
[2] https://github.com/alibaba/dragonwell11/issues/209 <https://github.com/alibaba/dragonwell11/issues/209 >
[3] https://github.com/openjdk/riscv-port/pull/1 <https://github.com/openjdk/riscv-port/pull/1 >
[4] https://github.com/openjdk/riscv-port-jdk17u/pull/1 <https://github.com/openjdk/riscv-port-jdk17u/pull/1 >
[5] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/riscv.ad#L240-L243 <https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/riscv.ad#L240-L243 >
[6] https://bugs.openjdk.org/browse/JDK-8231441 <https://bugs.openjdk.org/browse/JDK-8231441 >
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/riscv-port-dev/attachments/20230217/f20fa29f/attachment.htm>

From yadongwang at openjdk.org  Sat Feb 18 03:47:54 2023
From: yadongwang at openjdk.org (Yadong Wang)
Date: Sat, 18 Feb 2023 03:47:54 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port [v2]
In-Reply-To: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
Message-ID: <w4XkuFlb6vj7j5lhee8NKGRelIPTbc1GrGJipaQA_fo=.353fcead-d7aa-43d2-b252-80650a6abd2e@github.com>

> This PR backports the implementation of RISC-V port into jdk17u. 
> 
> It based on the initial implementation of JEP-422 with some modifications for jdk17u:
> 1.	The initial patch
>     8276799: Implementation of JEP 422: Linux/RISC-V Port
> 2.	 remove features that do not belong to jdk17u
>     revert 8277417: C1 LIR instruction for load-klass
>     revert 8278387: Implement UseHeavyMonitors consistently
>     revert 8227369: pd_disjoint_words_atomic() needs to be atomic
>     revert 8258192: Obsolete the CriticalNatives flag
>     revert 8281632: riscv: Improve interpreter stack banging
>     revert 8283364: Intrinsify countPositives
> 3.	add features that belongs to jdk17u
>     enable the biased locking
> 4.	 Wrap modifications to shared code under RISCV and revert changes to other platforms
> isolate modification to other platforms
> 5.	Patches for making compilation pass
> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler

Yadong Wang has updated the pull request incrementally with one additional commit since the last revision:

  fix indentation

-------------

Changes:
  - all: https://git.openjdk.org/riscv-port-jdk17u/pull/1/files
  - new: https://git.openjdk.org/riscv-port-jdk17u/pull/1/files/47916a22..f59f403f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=1&range=01
 - incr: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=1&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/1.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/1/head:pull/1

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From fyang at openjdk.org  Mon Feb 20 08:23:53 2023
From: fyang at openjdk.org (Fei Yang)
Date: Mon, 20 Feb 2023 08:23:53 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP
 422: Linux/RISC-V Port [v2]
In-Reply-To: <w4XkuFlb6vj7j5lhee8NKGRelIPTbc1GrGJipaQA_fo=.353fcead-d7aa-43d2-b252-80650a6abd2e@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
 <w4XkuFlb6vj7j5lhee8NKGRelIPTbc1GrGJipaQA_fo=.353fcead-d7aa-43d2-b252-80650a6abd2e@github.com>
Message-ID: <ZzEM6ttSwTjTIyijcAPz90bQWGyzKKgdqWhparXizMQ=.a7d6899b-e1d6-4e20-979f-c49798a2f669@github.com>

On Sat, 18 Feb 2023 03:47:54 GMT, Yadong Wang <yadongwang at openjdk.org> wrote:

>> This PR backports the implementation of RISC-V port into jdk17u. 
>> 
>> It based on the initial implementation of JEP-422 with some modifications for jdk17u:
>> 1.	The initial patch
>>     8276799: Implementation of JEP 422: Linux/RISC-V Port
>> 2.	 remove features that do not belong to jdk17u
>>     revert 8277417: C1 LIR instruction for load-klass
>>     revert 8278387: Implement UseHeavyMonitors consistently
>>     revert 8227369: pd_disjoint_words_atomic() needs to be atomic
>>     revert 8258192: Obsolete the CriticalNatives flag
>>     revert 8281632: riscv: Improve interpreter stack banging
>>     revert 8283364: Intrinsify countPositives
>> 3.	add features that belongs to jdk17u
>>     enable the biased locking
>> 4.	 Wrap modifications to shared code under RISCV and revert changes to other platforms
>> isolate modification to other platforms
>> 5.	Patches for making compilation pass
>> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
>> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler
>
> Yadong Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix indentation

Looks fine from the cursory review.

-------------

Marked as reviewed by fyang (Committer).

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From duke at openjdk.org  Mon Feb 20 08:33:10 2023
From: duke at openjdk.org (duke)
Date: Mon, 20 Feb 2023 08:33:10 GMT
Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8276799: Implementation of
 JEP 422: Linux/RISC-V Port (#1)
Message-ID: <f3b7d113-4b1d-4ae8-a490-b4d84f98b7ed@openjdk.org>

Changeset: d4c1e23c
Author:    yadongw <yadong.w at hotmail.com>
Committer: GitHub <noreply at github.com>
Date:      2023-02-20 16:32:40 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/d4c1e23cf980c55a9f1d0e10de9df91ba27a6e26

8276799: Implementation of JEP 422: Linux/RISC-V Port (#1)

* 8276799: Implementation of JEP 422: Linux/RISC-V Port

* revert 8277417: C1 LIR instruction for load-klass

* revert 8278387: Implement UseHeavyMonitors consistently

* revert 8227369: pd_disjoint_words_atomic() needs to be atomic

* revert 8258192: Obsolete the CriticalNatives flag

* revert 8281632: riscv: Improve interpreter stack banging

* revert 8283364: Intrinsify countPositives

* enable the biased locking

* isolate modification to other platforms

* 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler

* 8282306: os::is_first_C_frame(frame*) crashes on invalid link access

* fix copyright year

* fix indentation

! make/autoconf/jvm-features.m4
! make/autoconf/libraries.m4
! make/autoconf/platform.m4
! make/hotspot/gensrc/GensrcAdlc.gmk
+ src/hotspot/cpu/riscv/abstractInterpreter_riscv.cpp
+ src/hotspot/cpu/riscv/assembler_riscv.cpp
+ src/hotspot/cpu/riscv/assembler_riscv.hpp
+ src/hotspot/cpu/riscv/assembler_riscv.inline.hpp
+ src/hotspot/cpu/riscv/bytes_riscv.hpp
+ src/hotspot/cpu/riscv/c1_CodeStubs_riscv.cpp
+ src/hotspot/cpu/riscv/c1_Defs_riscv.hpp
+ src/hotspot/cpu/riscv/c1_FpuStackSim_riscv.cpp
+ src/hotspot/cpu/riscv/c1_FpuStackSim_riscv.hpp
+ src/hotspot/cpu/riscv/c1_FrameMap_riscv.cpp
+ src/hotspot/cpu/riscv/c1_FrameMap_riscv.hpp
+ src/hotspot/cpu/riscv/c1_LIRAssembler_arith_riscv.cpp
+ src/hotspot/cpu/riscv/c1_LIRAssembler_arith_riscv.hpp
+ src/hotspot/cpu/riscv/c1_LIRAssembler_arraycopy_riscv.cpp
+ src/hotspot/cpu/riscv/c1_LIRAssembler_arraycopy_riscv.hpp
+ src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp
+ src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.hpp
+ src/hotspot/cpu/riscv/c1_LIRGenerator_riscv.cpp
+ src/hotspot/cpu/riscv/c1_LIR_riscv.cpp
+ src/hotspot/cpu/riscv/c1_LinearScan_riscv.cpp
+ src/hotspot/cpu/riscv/c1_LinearScan_riscv.hpp
+ src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.cpp
+ src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.hpp
+ src/hotspot/cpu/riscv/c1_Runtime1_riscv.cpp
+ src/hotspot/cpu/riscv/c1_globals_riscv.hpp
+ src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp
+ src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.hpp
+ src/hotspot/cpu/riscv/c2_globals_riscv.hpp
+ src/hotspot/cpu/riscv/c2_init_riscv.cpp
+ src/hotspot/cpu/riscv/c2_safepointPollStubTable_riscv.cpp
+ src/hotspot/cpu/riscv/codeBuffer_riscv.hpp
+ src/hotspot/cpu/riscv/compiledIC_riscv.cpp
+ src/hotspot/cpu/riscv/copy_riscv.hpp
+ src/hotspot/cpu/riscv/disassembler_riscv.hpp
+ src/hotspot/cpu/riscv/foreign_globals_riscv.cpp
+ src/hotspot/cpu/riscv/foreign_globals_riscv.hpp
+ src/hotspot/cpu/riscv/frame_riscv.cpp
+ src/hotspot/cpu/riscv/frame_riscv.hpp
+ src/hotspot/cpu/riscv/frame_riscv.inline.hpp
+ src/hotspot/cpu/riscv/gc/g1/g1BarrierSetAssembler_riscv.cpp
+ src/hotspot/cpu/riscv/gc/g1/g1BarrierSetAssembler_riscv.hpp
+ src/hotspot/cpu/riscv/gc/g1/g1Globals_riscv.hpp
+ src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp
+ src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.hpp
+ src/hotspot/cpu/riscv/gc/shared/barrierSetNMethod_riscv.cpp
+ src/hotspot/cpu/riscv/gc/shared/cardTableBarrierSetAssembler_riscv.cpp
+ src/hotspot/cpu/riscv/gc/shared/cardTableBarrierSetAssembler_riscv.hpp
+ src/hotspot/cpu/riscv/gc/shared/modRefBarrierSetAssembler_riscv.cpp
+ src/hotspot/cpu/riscv/gc/shared/modRefBarrierSetAssembler_riscv.hpp
+ src/hotspot/cpu/riscv/gc/shenandoah/c1/shenandoahBarrierSetC1_riscv.cpp
+ src/hotspot/cpu/riscv/gc/shenandoah/shenandoahBarrierSetAssembler_riscv.cpp
+ src/hotspot/cpu/riscv/gc/shenandoah/shenandoahBarrierSetAssembler_riscv.hpp
+ src/hotspot/cpu/riscv/gc/shenandoah/shenandoah_riscv64.ad
+ src/hotspot/cpu/riscv/gc/z/zBarrierSetAssembler_riscv.cpp
+ src/hotspot/cpu/riscv/gc/z/zBarrierSetAssembler_riscv.hpp
+ src/hotspot/cpu/riscv/gc/z/zGlobals_riscv.cpp
+ src/hotspot/cpu/riscv/gc/z/zGlobals_riscv.hpp
+ src/hotspot/cpu/riscv/gc/z/z_riscv64.ad
+ src/hotspot/cpu/riscv/globalDefinitions_riscv.hpp
+ src/hotspot/cpu/riscv/globals_riscv.hpp
+ src/hotspot/cpu/riscv/icBuffer_riscv.cpp
+ src/hotspot/cpu/riscv/icache_riscv.cpp
+ src/hotspot/cpu/riscv/icache_riscv.hpp
+ src/hotspot/cpu/riscv/interp_masm_riscv.cpp
+ src/hotspot/cpu/riscv/interp_masm_riscv.hpp
+ src/hotspot/cpu/riscv/interpreterRT_riscv.cpp
+ src/hotspot/cpu/riscv/interpreterRT_riscv.hpp
+ src/hotspot/cpu/riscv/javaFrameAnchor_riscv.hpp
+ src/hotspot/cpu/riscv/jniFastGetField_riscv.cpp
+ src/hotspot/cpu/riscv/jniTypes_riscv.hpp
+ src/hotspot/cpu/riscv/macroAssembler_riscv.cpp
+ src/hotspot/cpu/riscv/macroAssembler_riscv.hpp
+ src/hotspot/cpu/riscv/macroAssembler_riscv.inline.hpp
+ src/hotspot/cpu/riscv/matcher_riscv.hpp
+ src/hotspot/cpu/riscv/methodHandles_riscv.cpp
+ src/hotspot/cpu/riscv/methodHandles_riscv.hpp
+ src/hotspot/cpu/riscv/nativeInst_riscv.cpp
+ src/hotspot/cpu/riscv/nativeInst_riscv.hpp
+ src/hotspot/cpu/riscv/registerMap_riscv.cpp
+ src/hotspot/cpu/riscv/registerMap_riscv.hpp
+ src/hotspot/cpu/riscv/register_definitions_riscv.cpp
+ src/hotspot/cpu/riscv/register_riscv.cpp
+ src/hotspot/cpu/riscv/register_riscv.hpp
+ src/hotspot/cpu/riscv/relocInfo_riscv.cpp
+ src/hotspot/cpu/riscv/relocInfo_riscv.hpp
+ src/hotspot/cpu/riscv/riscv.ad
+ src/hotspot/cpu/riscv/riscv_b.ad
+ src/hotspot/cpu/riscv/riscv_v.ad
+ src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp
+ src/hotspot/cpu/riscv/stubGenerator_riscv.cpp
+ src/hotspot/cpu/riscv/stubRoutines_riscv.cpp
+ src/hotspot/cpu/riscv/stubRoutines_riscv.hpp
+ src/hotspot/cpu/riscv/templateInterpreterGenerator_riscv.cpp
+ src/hotspot/cpu/riscv/templateTable_riscv.cpp
+ src/hotspot/cpu/riscv/templateTable_riscv.hpp
+ src/hotspot/cpu/riscv/universalNativeInvoker_riscv.cpp
+ src/hotspot/cpu/riscv/universalUpcallHandle_riscv.cpp
+ src/hotspot/cpu/riscv/vmStructs_riscv.hpp
+ src/hotspot/cpu/riscv/vm_version_ext_riscv.cpp
+ src/hotspot/cpu/riscv/vm_version_ext_riscv.hpp
+ src/hotspot/cpu/riscv/vm_version_riscv.cpp
+ src/hotspot/cpu/riscv/vm_version_riscv.hpp
+ src/hotspot/cpu/riscv/vmreg_riscv.cpp
+ src/hotspot/cpu/riscv/vmreg_riscv.hpp
+ src/hotspot/cpu/riscv/vmreg_riscv.inline.hpp
+ src/hotspot/cpu/riscv/vtableStubs_riscv.cpp
! src/hotspot/os/linux/os_linux.cpp
+ src/hotspot/os_cpu/linux_riscv/assembler_linux_riscv.cpp
+ src/hotspot/os_cpu/linux_riscv/atomic_linux_riscv.hpp
+ src/hotspot/os_cpu/linux_riscv/bytes_linux_riscv.hpp
+ src/hotspot/os_cpu/linux_riscv/copy_linux_riscv.hpp
+ src/hotspot/os_cpu/linux_riscv/gc/z/zSyscall_linux_riscv.hpp
+ src/hotspot/os_cpu/linux_riscv/globals_linux_riscv.hpp
+ src/hotspot/os_cpu/linux_riscv/orderAccess_linux_riscv.hpp
+ src/hotspot/os_cpu/linux_riscv/os_linux_riscv.cpp
+ src/hotspot/os_cpu/linux_riscv/os_linux_riscv.hpp
+ src/hotspot/os_cpu/linux_riscv/prefetch_linux_riscv.inline.hpp
+ src/hotspot/os_cpu/linux_riscv/thread_linux_riscv.cpp
+ src/hotspot/os_cpu/linux_riscv/thread_linux_riscv.hpp
+ src/hotspot/os_cpu/linux_riscv/vmStructs_linux_riscv.hpp
+ src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp
! src/hotspot/share/c1/c1_LIR.cpp
! src/hotspot/share/c1/c1_LIR.hpp
! src/hotspot/share/c1/c1_LIRAssembler.cpp
! src/hotspot/share/c1/c1_LIRAssembler.hpp
! src/hotspot/share/c1/c1_LinearScan.cpp
! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp
! src/hotspot/share/gc/z/c1/zBarrierSetC1.cpp
! src/hotspot/share/jfr/utilities/jfrBigEndian.hpp
! src/hotspot/share/opto/regmask.hpp
! src/hotspot/share/runtime/abstract_vm_version.cpp
! src/hotspot/share/runtime/thread.inline.hpp
! src/hotspot/share/utilities/macros.hpp
! src/jdk.hotspot.agent/linux/native/libsaproc/LinuxDebuggerLocal.cpp
! src/jdk.hotspot.agent/linux/native/libsaproc/libproc.h
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HotSpotAgent.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/MachineDescriptionRISCV64.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/LinuxCDebugger.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/riscv64/LinuxRISCV64CFrame.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/riscv64/LinuxRISCV64ThreadContext.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/proc/riscv64/ProcRISCV64Thread.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/proc/riscv64/ProcRISCV64ThreadContext.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/proc/riscv64/ProcRISCV64ThreadFactory.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/remote/riscv64/RemoteRISCV64Thread.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/remote/riscv64/RemoteRISCV64ThreadContext.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/remote/riscv64/RemoteRISCV64ThreadFactory.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/riscv/RISCV64ThreadContext.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/Threads.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/linux_riscv64/LinuxRISCV64JavaThreadPDAccess.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/riscv64/RISCV64CurrentFrameGuess.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/riscv64/RISCV64Frame.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/riscv64/RISCV64JavaCallWrapper.java
+ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/riscv64/RISCV64RegisterMap.java
! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/PlatformInfo.java
! test/hotspot/jtreg/compiler/c2/TestBit.java
! test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA1IntrinsicsOptionOnUnsupportedCPU.java
! test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java
! test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA512IntrinsicsOptionOnUnsupportedCPU.java
! test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java
! test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForOtherCPU.java
+ test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForUnsupportedRISCV64CPU.java
! test/hotspot/jtreg/compiler/loopopts/superword/ProdRed_Double.java
! test/hotspot/jtreg/compiler/loopopts/superword/ProdRed_Float.java
! test/hotspot/jtreg/compiler/loopopts/superword/ProdRed_Int.java
! test/hotspot/jtreg/compiler/loopopts/superword/ReductionPerf.java
! test/hotspot/jtreg/compiler/loopopts/superword/SumRedAbsNeg_Double.java
! test/hotspot/jtreg/compiler/loopopts/superword/SumRedAbsNeg_Float.java
! test/hotspot/jtreg/compiler/loopopts/superword/SumRedSqrt_Double.java
! test/hotspot/jtreg/compiler/loopopts/superword/SumRed_Double.java
! test/hotspot/jtreg/compiler/loopopts/superword/SumRed_Float.java
! test/hotspot/jtreg/compiler/loopopts/superword/SumRed_Int.java
! test/hotspot/jtreg/compiler/runtime/criticalnatives/argumentcorruption/CheckLongArgs.java
! test/hotspot/jtreg/compiler/runtime/criticalnatives/lookup/LookUp.java
! test/hotspot/jtreg/compiler/testlibrary/sha/predicate/IntrinsicPredicates.java
! test/hotspot/jtreg/runtime/NMT/CheckForProperDetailStackTrace.java
! test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTest.java
! test/hotspot/jtreg/serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java
! test/hotspot/jtreg/vmTestbase/nsk/share/jdi/ArgumentHandler.java
! test/jdk/jdk/jfr/event/os/TestCPUInformation.java
! test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
! test/lib/jdk/test/lib/Platform.java


From yadongwang at openjdk.org  Mon Feb 20 08:35:00 2023
From: yadongwang at openjdk.org (Yadong Wang)
Date: Mon, 20 Feb 2023 08:35:00 GMT
Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8276799: Implementation of
 JEP 422: Linux/RISC-V Port
In-Reply-To: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com>
Message-ID: <uaXPNFnkw5GtIq2nqWMv2U4DRnh_kvQCBVNTuoIFPG4=.ccc3792a-258a-4f3b-a40a-a741c339104c@github.com>

On Tue, 7 Feb 2023 11:20:37 GMT, Yadong Wang <yadongwang at openjdk.org> wrote:

> This PR backports the implementation of RISC-V port into jdk17u. 
> 
> It based on the initial implementation of JEP-422 with some modifications for jdk17u:
> 1.	The initial patch
>     8276799: Implementation of JEP 422: Linux/RISC-V Port
> 2.	 remove features that do not belong to jdk17u
>     revert 8277417: C1 LIR instruction for load-klass
>     revert 8278387: Implement UseHeavyMonitors consistently
>     revert 8227369: pd_disjoint_words_atomic() needs to be atomic
>     revert 8258192: Obsolete the CriticalNatives flag
>     revert 8281632: riscv: Improve interpreter stack banging
>     revert 8283364: Intrinsify countPositives
> 3.	add features that belongs to jdk17u
>     enable the biased locking
> 4.	 Wrap modifications to shared code under RISCV and revert changes to other platforms
> isolate modification to other platforms
> 5.	Patches for making compilation pass
> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1

From duke at openjdk.org  Mon Feb 20 08:42:18 2023
From: duke at openjdk.org (duke)
Date: Mon, 20 Feb 2023 08:42:18 GMT
Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 11 new changesets
Message-ID: <a1ae4dc1-de84-4cf9-b6af-a259358be06a@openjdk.org>

Changeset: 9e26f383
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-02-15 10:18:41 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/9e26f383d529571c88a623dee048b96b9bcd26cc

8300266: Detect Virtualization on Linux aarch64

Reviewed-by: clanger
Backport-of: 544c16e0bdd4335b2624158fd1f6521984aa5079

! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp
! src/hotspot/cpu/aarch64/vm_version_aarch64.hpp

Changeset: 036029e6
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-15 13:58:02 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/036029e6102e04e578ea2fd167c6eae668279520

8281170: Test jdk/tools/jpackage/windows/WinInstallerIconTest always fails on Windows 11

Backport-of: bb4dece246a56f2b225089c331e9f3d092dfbfa1

! test/jdk/tools/jpackage/windows/WinInstallerIconTest.java

Changeset: efe86767
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-15 14:49:55 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/efe86767af814c5f7be6b8d40ae2891b358d4298

8279614: The left line of the TitledBorder is not painted on 150 scale factor

Backport-of: b42c1ad1086a5c3f579e27380d23f67f8cebb437

! src/java.desktop/share/classes/javax/swing/border/EtchedBorder.java
+ test/jdk/javax/swing/border/EtchedBorder/ScaledEtchedBorderTest.java

Changeset: 0ce70e32
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-15 14:51:42 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/0ce70e32637e8c5aa69b563e9866fdfcb2e6daca

8294958: java/net/httpclient/ConnectTimeout tests are slow

Backport-of: fe70487d0bc53149150c23d39287d9856c5a0e95

! test/jdk/java/net/httpclient/AbstractConnectTimeout.java
! test/jdk/java/net/httpclient/AbstractConnectTimeoutHandshake.java

Changeset: d2409a7d
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-15 14:53:42 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/d2409a7d0d599280d7e63e6904a8f1ff4dd8b557

8295777: java/net/httpclient/ConnectExceptionTest.java should not rely on system resolver

Backport-of: 65c84e0cf890df2a604ac07213327be007227e77

! test/jdk/java/net/httpclient/ConnectExceptionTest.java

Changeset: 334ec9a0
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-15 14:55:31 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/334ec9a0c0460d64598312bf5ddc58c0d01befdc

8282958: Rendering Issues with Borders on Windows High-DPI systems

Backport-of: 9911405e543dbe07767808bad88534abbcc03c5a

! src/java.desktop/share/classes/javax/swing/border/LineBorder.java
+ test/jdk/javax/swing/border/LineBorder/ScaledLineBorderTest.java
+ test/jdk/javax/swing/border/LineBorder/ScaledTextFieldBorderTest.java

Changeset: cf5490b5
Author:    Roman Marchenko <rmarchenko at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-02-15 15:51:12 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/cf5490b5c9eea23fff892c53fe0b55280a135157

8297437: javadoc cannot link to old docs (with old style anchors)

Reviewed-by: phh
Backport-of: 15a14884013a975707008f648b8e4864e16006ed

! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Extern.java
! test/langtools/jdk/javadoc/doclet/testClassCrossReferences/TestClassCrossReferences.java
! test/langtools/jdk/javadoc/doclet/testExternalOverriddenMethod/TestExternalOverriddenMethod.java
! test/langtools/jdk/javadoc/doclet/testHref/TestHref.java
! test/langtools/jdk/javadoc/doclet/testLinkOption/TestLinkOption.java
! test/langtools/jdk/javadoc/doclet/testLinkPlatform/TestLinkPlatform.java

Changeset: fb6d6fef
Author:    Ekaterina Vergizova <evergizova at openjdk.org>
Date:      2023-02-16 10:51:26 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/fb6d6fef567ed6114a4d0da5e5ee1c1931e99dac

8301842: JFR: increase checkpoint event size for stacktrace and string pool

Backport-of: 7dfe75cf553193faf709cff6b8b2505680d7cebc

! src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp

Changeset: d0e06335
Author:    Christoph Langer <clanger at openjdk.org>
Date:      2023-02-17 09:57:24 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/d0e06335235ddd50012a9040a3af4eb5631dc49a

8302692: [17u] Update GHA Boot JDK to 17.0.6

Reviewed-by: mbaesken, sgehwolf

! make/conf/github-actions.conf

Changeset: 5027f562
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-02-17 09:58:59 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/5027f562344b97245521b44abc66386278c22c77

8288332: Tier1 validate-source fails after 8279614

Backport-of: e90b579b294eb88f6b4e236d19b05063775ee8d7

! test/jdk/javax/swing/border/EtchedBorder/ScaledEtchedBorderTest.java

Changeset: cd72094c
Author:    Fei Yang <yangfei at iscas.ac.cn>
Date:      2023-02-20 16:38:53 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/cd72094c5444e7851b53557c2e6796864f6421f1

Merge branch 'master' into riscv-port



From yangfei at iscas.ac.cn  Mon Feb 20 09:24:13 2023
From: yangfei at iscas.ac.cn (yangfei at iscas.ac.cn)
Date: Mon, 20 Feb 2023 17:24:13 +0800 (GMT+08:00)
Subject: Discuss the RISC-V OpenJDK11u port
In-Reply-To: <a4a23424-d508-4992-9049-9ffeff58991d.yunyao.zxl@alibaba-inc.com>
References: <a4a23424-d508-4992-9049-9ffeff58991d.yunyao.zxl@alibaba-inc.com>
Message-ID: <512bb955.2956e.1866e234fd2.Coremail.yangfei@iscas.ac.cn>

Hi,

-----Original Messages-----
From:"Xiaolin Zheng" <yunyao.zxl at alibaba-inc.com>
Sent Time:2023-02-17 15:53:59 (Friday)
To: riscv-port-dev <riscv-port-dev at openjdk.org>
Cc: "??(??)" <kuaiwei.kw at alibaba-inc.com>, "???(??)" <sanhong.lsh at alibaba-inc.com>
Subject: Discuss the RISC-V OpenJDK11u port

&gt; Hi team,
&gt; We would like to discuss the RISC-V OpenJDK11u port.   
   
&gt;    Currently seems no one claims this port yet, and it would be a pleasure for us if we (from Alibaba) could take the backporting work.    

Welcome joining the backporting work :-)
Note that we should start from 17u, then 11u and finally 8u.
So I think backporting process for the 11u staging repo should only start after we finished 17u backporting.
But that should not stop you from doing/preparing the work in your private repo.

&gt; We have a backport [1] [2] on Alibaba Dragonwell11 (downstream of our OpenJDK11) that works fine currently, though backported from the initial load of the riscv-port repo [3] at the beginning of the last year. We are currently thinking of contributing that to the upstream, despite that various polishing, patch splitting, and further backporting to meet the requirements of backports are needed. So obviously it is not a "ready-to-go" one like the 17u port [4] by Yadong.    

That's great to hear.
Yes, I suppose the backporting patches for 11u should be derived from 17u repo unless there is a special reason.
That also means that normally a fix should be first backported to 17u before it could be considered for older versions like 11u.

&gt; Some challenging parts might be the differences between the gaps in 11u and 19 and above. For example, on 11u we do not have a VecA implementation, yet, the RVV vector extension in the RISC-V backend [5] in the mainline needs it. The VecA implementation may look currently unlikely to get permission to backport since the changes [6] in shared code. Without VecA, C2 vector intrinsics and the VectorAPI-related code may not work, but intrinsics using vector registers directly could work as expected, like `StubGenerator::copy_memory_v`.    
   
I guess it should be reasonable if it could be demonstrated that is necessary for some basic functionality?
But that will depend on the upstream jdk update project maintainers. 

Thanks,
Fei Yang
   



</sanhong.lsh at alibaba-inc.com></kuaiwei.kw at alibaba-inc.com></riscv-port-dev at openjdk.org></yunyao.zxl at alibaba-inc.com>

From yunyao.zxl at alibaba-inc.com  Tue Feb 21 07:08:55 2023
From: yunyao.zxl at alibaba-inc.com (Xiaolin Zheng)
Date: Tue, 21 Feb 2023 15:08:55 +0800
Subject: =?UTF-8?B?UmU6IERpc2N1c3MgdGhlIFJJU0MtViBPcGVuSkRLMTF1IHBvcnQ=?=
In-Reply-To: <512bb955.2956e.1866e234fd2.Coremail.yangfei@iscas.ac.cn>
References: <a4a23424-d508-4992-9049-9ffeff58991d.yunyao.zxl@alibaba-inc.com>,
 <512bb955.2956e.1866e234fd2.Coremail.yangfei@iscas.ac.cn>
Message-ID: <e757c6d7-50f6-4b14-9048-badbae3cc936.yunyao.zxl@alibaba-inc.com>

Hi Felix,
Thanks for the details. We will follow the advice and begin to work on that in our internal forked openjdk11u repo first, and I will send another email, cc jdk-updates for the aforementioned VecA backport thing.
Best Regards,
Xiaolin
------------------------------------------------------------------
From:yangfei <yangfei at iscas.ac.cn>
Send Time:2023?2?20?(???) 17:30
To:???(??) <yunyao.zxl at alibaba-inc.com>
Cc:riscv-port-dev <riscv-port-dev at openjdk.org>; ??(??) <kuaiwei.kw at alibaba-inc.com>; ???(??) <sanhong.lsh at alibaba-inc.com>
Subject:Re: Discuss the RISC-V OpenJDK11u port
Hi,
-----Original Messages-----
From:"Xiaolin Zheng" <yunyao.zxl at alibaba-inc.com>
Sent Time:2023-02-17 15:53:59 (Friday)
To: riscv-port-dev <riscv-port-dev at openjdk.org>
Cc: "??(??)" <kuaiwei.kw at alibaba-inc.com>, "???(??)" <sanhong.lsh at alibaba-inc.com>
Subject: Discuss the RISC-V OpenJDK11u port
&gt; Hi team,
&gt; We would like to discuss the RISC-V OpenJDK11u port. 
&gt; Currently seems no one claims this port yet, and it would be a pleasure for us if we (from Alibaba) could take the backporting work. 
Welcome joining the backporting work :-)
Note that we should start from 17u, then 11u and finally 8u.
So I think backporting process for the 11u staging repo should only start after we finished 17u backporting.
But that should not stop you from doing/preparing the work in your private repo.
&gt; We have a backport [1] [2] on Alibaba Dragonwell11 (downstream of our OpenJDK11) that works fine currently, though backported from the initial load of the riscv-port repo [3] at the beginning of the last year. We are currently thinking of contributing that to the upstream, despite that various polishing, patch splitting, and further backporting to meet the requirements of backports are needed. So obviously it is not a "ready-to-go" one like the 17u port [4] by Yadong. 
That's great to hear.
Yes, I suppose the backporting patches for 11u should be derived from 17u repo unless there is a special reason.
That also means that normally a fix should be first backported to 17u before it could be considered for older versions like 11u.
&gt; Some challenging parts might be the differences between the gaps in 11u and 19 and above. For example, on 11u we do not have a VecA implementation, yet, the RVV vector extension in the RISC-V backend [5] in the mainline needs it. The VecA implementation may look currently unlikely to get permission to backport since the changes [6] in shared code. Without VecA, C2 vector intrinsics and the VectorAPI-related code may not work, but intrinsics using vector registers directly could work as expected, like `StubGenerator::copy_memory_v`. 
I guess it should be reasonable if it could be demonstrated that is necessary for some basic functionality?
But that will depend on the upstream jdk update project maintainers. 
Thanks,
Fei Yang
</sanhong.lsh at alibaba-inc.com></kuaiwei.kw at alibaba-inc.com></riscv-port-dev at openjdk.org></yunyao.zxl at alibaba-inc.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/riscv-port-dev/attachments/20230221/5c811fe2/attachment.htm>

From zhangze.linux at gmail.com  Thu Feb 23 09:15:49 2023
From: zhangze.linux at gmail.com (Ze Zhang)
Date: Thu, 23 Feb 2023 17:15:49 +0800
Subject: [sw-dev] openjdk crash on linux kernel 6.1.5
In-Reply-To: <LO0P265MB68669F0625B0020B3FCDFCF4F9D09@LO0P265MB6866.GBRP265.PROD.OUTLOOK.COM>
References: <CAEJU13K0EzJ2exUBVGTgXbc1Z325qAjFcKPRudfso_mcR=UXFA@mail.gmail.com>
 <LO0P265MB686695260AB9933114A2FF36F9D09@LO0P265MB6866.GBRP265.PROD.OUTLOOK.COM>
 <CAEJU13KfdpiQ4Fh5M29DtR1vzqc-c5TwDFNwy_hotU7Y0jceMQ@mail.gmail.com>
 <LO0P265MB68669F0625B0020B3FCDFCF4F9D09@LO0P265MB6866.GBRP265.PROD.OUTLOOK.COM>
Message-ID: <CAEJU13Knxe=mX7Bb4prT_eNd6JjO=Peoj-o1EfbQKY=6Gf0EmA@mail.gmail.com>

Yes, it is.
thanks a lot,  my current kernel version 6.1.9 uses this:

    if
(!static_branch_likely(&riscv_isa_ext_keys[RISCV_ISA_EXT_KEY_ZIHINTPAUSE]))
{

which has this issue, and kernel 5.15 / 5.19 / 6.20 do not use this array.

but I have no evidence about this, because gdb can not print vdso backtrace:

(gdb) info threads
  Id   Target Id                                         Frame
  1    Thread 0x7ffff7e97020 (LWP 432) "java"            0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff6090250,
expected=<optimized out>, op=<optimized out>, abstime=0x0,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  2    Thread 0x7ffff6090180 (LWP 437) "java"            syscall
(syscall_number=98, arg1=<optimized out>, arg2=128, arg3=21, arg4=0,
arg5=0, arg6=0, arg7=178)
    at
/usr/src/debug/glibc/2.37-r0/sysdeps/unix/sysv/linux/riscv/syscall.c:30
  3    Thread 0x7ffff48d7180 (LWP 438) "GC Thread#0"     0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff0068508,
expected=<optimized out>, op=<optimized out>, abstime=0x0,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  4    Thread 0x7ffff46d5180 (LWP 439) "G1 Main Marker"  0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff0025ad8,
expected=<optimized out>, op=<optimized out>, abstime=0x0,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  5    Thread 0x7ffff44d3180 (LWP 440) "G1 Conc#0"       0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff0070758,
expected=<optimized out>, op=<optimized out>, abstime=0x0,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  6    Thread 0x7fffd839e180 (LWP 441) "G1 Refine#0"     0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff00a1318,
expected=<optimized out>, op=<optimized out>, abstime=0x0,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  7    Thread 0x7fffc9fff180 (LWP 442) "G1 Service"      0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff00a2468,
expected=<optimized out>, op=<optimized out>, abstime=0x7fffc9ffe6e8,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  8    Thread 0x7fffc9dfd180 (LWP 443) "VM Thread"       0x00007ffff7f23466
in __GI___clock_nanosleep (clock_id=clock_id at entry=0, flags=flags at entry=0,
req=0x7fffc9dfc268, rem=0x0)
    at
/usr/src/debug/glibc/2.37-r0/sysdeps/unix/sysv/linux/clock_nanosleep.c:48
  9    Thread 0x7fffc9bfb180 (LWP 444) "Reference Handl" 0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff002a078,
expected=<optimized out>, op=<optimized out>, abstime=0x0,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  10   Thread 0x7fffc99fb180 (LWP 445) "Finalizer"       0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff0221678,
expected=<optimized out>, op=<optimized out>, abstime=0x0,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  11   Thread 0x7fffc97fb180 (LWP 446) "Signal Dispatch" 0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff0017cf0,
expected=<optimized out>, op=<optimized out>, abstime=0x0,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  12   Thread 0x7fffc95fb180 (LWP 447) "Service Thread"  0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff0026938,
expected=<optimized out>, op=<optimized out>, abstime=0x0,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  13   Thread 0x7fffc93fb180 (LWP 448) "Monitor Deflati" 0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff0026858,
expected=<optimized out>, op=<optimized out>, abstime=0x7fffc93fa6d8,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  14   Thread 0x7fffc91fb180 (LWP 449) "C2 CompilerThre" 0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff0027b08,
expected=<optimized out>, op=<optimized out>, abstime=0x7fffc91fa548,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  15   Thread 0x7fffc8ffb180 (LWP 450) "C1 CompilerThre" syscall
(syscall_number=98, arg1=<optimized out>, arg2=128, arg3=21, arg4=0,
arg5=0, arg6=0, arg7=178)
    at
/usr/src/debug/glibc/2.37-r0/sysdeps/unix/sysv/linux/riscv/syscall.c:30
  16   Thread 0x7fffc8dfb180 (LWP 451) "Notification Th" 0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff0026a18,
expected=<optimized out>, op=<optimized out>, abstime=0x0,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
  17   Thread 0x7fffc8bfb180 (LWP 452) "VM Periodic Tas" 0x00007ffff7f23466
in __GI___clock_nanosleep (clock_id=clock_id at entry=0, flags=flags at entry=0,
req=0x7fffc8bfa788, rem=0x0)
    at
/usr/src/debug/glibc/2.37-r0/sysdeps/unix/sysv/linux/clock_nanosleep.c:48
  18   Thread 0x7fffc89f9180 (LWP 453) "Common-Cleaner"  0x00007ffff7efa506
in __futex_abstimed_wait_common64 (futex_word=0x7ffff0366f88,
expected=<optimized out>, op=<optimized out>, abstime=0x7fffc89f7bf0,
    private=<optimized out>, cancel=<optimized out>) at futex-internal.c:57
* 19   Thread 0x7fffc87f9180 (LWP 454) "Tail"            _SafeFetch32_fault
() at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/os_cpu/linux_riscv/safefetch_linux_riscv.S:40
  20   Thread 0x7fffc85f9180 (LWP 455) "Tail"            syscall
(syscall_number=98, arg1=<optimized out>, arg2=128, arg3=21, arg4=0,
arg5=0, arg6=0, arg7=178)
    at
/usr/src/debug/glibc/2.37-r0/sysdeps/unix/sysv/linux/riscv/syscall.c:30
(gdb) bt
#0  _SafeFetch32_fault () at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/os_cpu/linux_riscv/safefetch_linux_riscv.S:40
#1  0x00007ffff6ed5072 in SafeFetch32 (adr=0x18c87f7fa0,
errValue=-889275714) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/runtime/safefetch.hpp:51
#2  0x00007ffff6effd62 in os::is_readable_pointer (p=0x18c87f7fa0) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/runtime/os.cpp:1115
#3  0x00007ffff6effece in os::print_location (st=0x7fffc87f2830,
x=106443014048, verbose=false) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/runtime/os.cpp:1151
#4  0x00007ffff724c832 in VMError::report (st=0x7fffc87f2830,
_verbose=true) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/vmError.cpp:890
#5  0x00007ffff724eff6 in VMError::report_and_die (id=-536870912,
message=0x7ffff782b9c0 "assert(!is_global_tagged(handle) ||
is_storage_handle(global_handles(), global_ptr(handle))) failed",
    detail_fmt=0x7ffff782b9b0 "invalid storage",
detail_args=0x7fffc87f29e0, thread=0x7ffff05255b0, pc=0x0, siginfo=0x0,
context=0x0,
    filename=0x7ffff782b780
"/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/runtime/jniHandles.cpp",
lineno=245, size=0)
    at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/vmError.cpp:1588
#6  0x00007ffff724e766 in VMError::report_and_die (thread=0x7ffff05255b0,
context=0x0, filename=0x7ffff782b780
"/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/runtime/jniHandles.cpp",

    lineno=245, message=0x7ffff782b9c0 "assert(!is_global_tagged(handle) ||
is_storage_handle(global_handles(), global_ptr(handle))) failed",
detail_fmt=0x7ffff782b9b0 "invalid storage",
    detail_args=0x7fffc87f29e0) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/vmError.cpp:1351
#7  0x00007ffff67acf9e in report_vm_error (file=0x7ffff782b780
"/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/runtime/jniHandles.cpp",
line=245,
    error_msg=0x7ffff782b9c0 "assert(!is_global_tagged(handle) ||
is_storage_handle(global_handles(), global_ptr(handle))) failed",
detail_fmt=0x7ffff782b9b0 "invalid storage")
    at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/debug.cpp:286
#8  0x00007ffff6ba1178 in JNIHandles::is_global_handle
(handle=0x7ffff7fe0916 <__vdso_clock_gettime+228>) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/runtime/jniHandles.cpp:245
#9  0x00007ffff6efff02 in os::print_location (st=0x7fffc87f36e0,
x=140737354008854, verbose=false) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/runtime/os.cpp:1155
#10 0x00007ffff6f13062 in os::print_register_info (st=0x7fffc87f36e0,
context=0x7fffc87f7ba0) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/os_cpu/linux_riscv/os_linux_riscv.cpp:387
#11 0x00007ffff724c578 in VMError::report (st=0x7fffc87f36e0,
_verbose=true) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/vmError.cpp:867
#12 0x00007ffff724eff6 in VMError::report_and_die (id=-536870912,
message=0x7ffff758ceb0 "assert(false) failed", detail_fmt=0x7ffff758ce80
"section header string table should be loaded",
    detail_args=0x7fffc87f3890, thread=0x7ffff05255b0, pc=0x0, siginfo=0x0,
context=0x0, filename=0x7ffff758ca50
"/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/elfFile.cpp",

    lineno=536, size=0) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/vmError.cpp:1588
#13 0x00007ffff724e766 in VMError::report_and_die (thread=0x7ffff05255b0,
context=0x0, filename=0x7ffff758ca50
"/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/elfFile.cpp",

    lineno=536, message=0x7ffff758ceb0 "assert(false) failed",
detail_fmt=0x7ffff758ce80 "section header string table should be loaded",
detail_args=0x7fffc87f3890)
    at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/vmError.cpp:1351
#14 0x00007ffff67acf9e in report_vm_error (file=0x7ffff758ca50
"/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/elfFile.cpp",
line=536,
    error_msg=0x7ffff758ceb0 "assert(false) failed",
detail_fmt=0x7ffff758ce80 "section header string table should be loaded")
    at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/debug.cpp:286
#15 0x00007ffff6865928 in ElfFile::read_section_header
(this=0x7fff880049d0, name=0x7ffff758cd48 ".gnu_debuglink", hdr=...)
    at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/elfFile.cpp:536
#16 0x00007ffff6865066 in ElfFile::read_debug_info (this=0x7fff880049d0,
debug_info=0x7fffc87f39f8) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/elfFile.cpp:407
#17 0x00007ffff6864f0e in ElfFile::load_dwarf_file (this=0x7fff880049d0) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/elfFile.cpp:391
#18 0x00007ffff6864c9a in ElfFile::get_source_info (this=0x7fff880049d0,
offset_in_library=2326, filename=0x7fffc87f6c08 "", filename_len=128,
line=0x7fffc87f6bfc, is_pc_after_call=false)
    at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/elfFile.cpp:354
#19 0x00007ffff67b45ac in ElfDecoder::get_source_info (this=0x7fff880042f0,
pc=0x7ffff7fe0916 <__vdso_clock_gettime+228> "\334CcR\360\b\017",
filename=0x7fffc87f6c08 "", filename_len=128, line=0x7fffc87f6bfc,
    is_pc_after_call=false) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/decoder_elf.cpp:90
#20 0x00007ffff67b3cd6 in Decoder::get_source_info (pc=0x7ffff7fe0916
<__vdso_clock_gettime+228> "\334CcR\360\b\017", filename=0x7fffc87f6c08 "",
filename_len=128, line=0x7fffc87f6bfc, is_pc_after_call=false)
    at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/decoder.cpp:118
#21 0x00007ffff7249f5a in VMError::print_native_stack (st=0x7fffc87f7870,
fr=..., t=0x7ffff05255b0, print_source_info=true, max_frames=-1,
    buf=0x7ffff7e8f350 <VMError::report(outputStream*, bool)::buf>
"mill.main.client.FileToStreamTailer.run()V", buf_size=2000)
    at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/vmError.cpp:366
#22 0x00007ffff724beee in VMError::report (st=0x7fffc87f7870,
_verbose=true) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/vmError.cpp:820
#23 0x00007ffff724eff6 in VMError::report_and_die (id=11, message=0x0,
detail_fmt=0x7ffff7c278c0 "%s", detail_args=0x7fffc87f79d0,
thread=0x7ffff05255b0,
    pc=0x7ffff7fe0916 <__vdso_clock_gettime+228> "\334CcR\360\b\017",
siginfo=0x7fffc87f7b20, context=0x7fffc87f7ba0, filename=0x0, lineno=0,
size=0)
    at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/vmError.cpp:1588
#24 0x00007ffff724e69c in VMError::report_and_die (thread=0x7ffff05255b0,
sig=11, pc=0x7ffff7fe0916 <__vdso_clock_gettime+228> "\334CcR\360\b\017",
siginfo=0x7fffc87f7b20, context=0x7fffc87f7ba0,
    detail_fmt=0x7ffff7c278c0 "%s") at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/vmError.cpp:1339
#25 0x00007ffff724e708 in VMError::report_and_die (thread=0x7ffff05255b0,
sig=11, pc=0x7ffff7fe0916 <__vdso_clock_gettime+228> "\334CcR\360\b\017",
siginfo=0x7fffc87f7b20, context=0x7fffc87f7ba0)
    at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/share/utilities/vmError.cpp:1345
#26 0x00007ffff70c389e in JVM_handle_linux_signal (sig=11,
info=0x7fffc87f7b20, ucVoid=0x7fffc87f7ba0, abort_if_unrecognized=1)
    at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/os/posix/signals_posix.cpp:655
#27 0x00007ffff70c3936 in javaSignalHandler (sig=11, info=0x7fffc87f7b20,
context=0x7fffc87f7ba0) at
/usr/src/debug/openjdk/20+gitAUTOINC+5dfc4ec7d9-r0/src/hotspot/os/posix/signals_posix.cpp:666
#28 <signal handler called>
#29 0x00007ffff7fe0916 in __vdso_clock_gettime ()
#30 0x00007ffff7f23356 in __GI___clock_gettime (clock_id=<optimized out>,
tp=<optimized out>) at
/usr/src/debug/glibc/2.37-r0/sysdeps/unix/sysv/linux/clock_gettime.c:42
#31 0x00000000d5fa7858 in ?? ()
(gdb)



Tommy Murphy <tommy_murphy at hotmail.com> ?2023?1?31??? 22:01???

> Could it be related to this issue?
>
>
> https://lore.kernel.org/all/3815b200-a9e2-a3db-c7f1-1e3f86dbab3f at cloudbear.ru/T/#rccffdbbebe5130653c80cdd5189ed25fdc609936
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/riscv-port-dev/attachments/20230223/f4b2aab9/attachment-0001.htm>

From dzhang at openjdk.org  Tue Feb 28 06:44:41 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Tue, 28 Feb 2023 06:44:41 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8290496: riscv: Fix build
 warnings-as-errors with GCC 11
Message-ID: <4bZJt2AHnuZ8R76bVQUYfWL6T166eOWjGv6ZhNZdR-M=.6c32d8b5-20b1-4f42-8b93-bf763ce448f3@github.com>

Please review this backport to riscv-port-jdk17u.
Backport of [JDK-8290496](https://bugs.openjdk.java.net/browse/JDK-8290496). Applies cleanly.

Build without --disable-warnings-as-errors after this fix passed on unmatched board with GCC11.

-------------

Commit messages:
 - backport JDK-8290496

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/2/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=2&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8290496
  Stats: 43 lines in 2 files changed: 6 ins; 14 del; 23 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/2.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/2/head:pull/2

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/2

From vkempik at openjdk.org  Tue Feb 28 07:50:32 2023
From: vkempik at openjdk.org (Vladimir Kempik)
Date: Tue, 28 Feb 2023 07:50:32 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8290496: riscv: Fix build
 warnings-as-errors with GCC 11
In-Reply-To: <4bZJt2AHnuZ8R76bVQUYfWL6T166eOWjGv6ZhNZdR-M=.6c32d8b5-20b1-4f42-8b93-bf763ce448f3@github.com>
References: <4bZJt2AHnuZ8R76bVQUYfWL6T166eOWjGv6ZhNZdR-M=.6c32d8b5-20b1-4f42-8b93-bf763ce448f3@github.com>
Message-ID: <Bmog_k13XrUebrJy8u_4xFaC7EVvyna07nH_6Wh_CkM=.eac3b50d-b611-4cb8-8158-79211beca141@github.com>

On Tue, 28 Feb 2023 06:35:49 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8290496](https://bugs.openjdk.java.net/browse/JDK-8290496). Applies cleanly.
> 
> Build without --disable-warnings-as-errors after this fix passed on unmatched board with GCC11.

Your backport is clean so it doesn't need a review.
However, the process is not clear yet: who would approve backports in this project ? how to request approval ?
Also, Can anyone, who is already reviewer in jdk-updates-project become reviewer in riscv-port-jdk17u ?

This Qs is not for @DingliZhang , but general one

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/2

From fyang at openjdk.org  Tue Feb 28 08:50:55 2023
From: fyang at openjdk.org (Fei Yang)
Date: Tue, 28 Feb 2023 08:50:55 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8290496: riscv: Fix build
 warnings-as-errors with GCC 11
In-Reply-To: <Bmog_k13XrUebrJy8u_4xFaC7EVvyna07nH_6Wh_CkM=.eac3b50d-b611-4cb8-8158-79211beca141@github.com>
References: <4bZJt2AHnuZ8R76bVQUYfWL6T166eOWjGv6ZhNZdR-M=.6c32d8b5-20b1-4f42-8b93-bf763ce448f3@github.com>
 <Bmog_k13XrUebrJy8u_4xFaC7EVvyna07nH_6Wh_CkM=.eac3b50d-b611-4cb8-8158-79211beca141@github.com>
Message-ID: <GLNAU7mY8cPnIZ-I7f2A7A1TACn7sSBk0n4IY4bzetA=.1ac92fba-fafc-4268-ad18-3fe964cc9e9b@github.com>

On Tue, 28 Feb 2023 07:47:58 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> Please review this backport to riscv-port-jdk17u.
>> Backport of [JDK-8290496](https://bugs.openjdk.java.net/browse/JDK-8290496). Applies cleanly.
>> 
>> Build without --disable-warnings-as-errors after this fix passed on unmatched board with GCC11.
>
> Your backport is clean so it doesn't need a review.
> However, the process is not clear yet: who would approve backports in this project ? how to request approval ?
> Also, Can anyone, who is already reviewer in jdk-updates-project become reviewer in riscv-port-jdk17u ?
> 
> This Qs is not for @DingliZhang , but general one

@VladimirKempik 

Here is what I am think about the backporting work flow for this repo. 
Since we are not upstreamed yet, I think we could follow a simplified workflow here. In fact, if you look at other projects like Lilliput or ZGC, they also follow a rather simplified flow for PR integration. In these cases, Committers could also do code reviews [1] and you don't even need a JBS issue for creating a PR [2]. 

Here in our case for riscv-port-jdk17u repo, I am not expecting uses of labels/comments on the JBS issue for request approvals, which is required by the upstreaming backporting flow.  I think it's better to do that (like marking the JBS issues for requesting maintainer approvals) when we do the final upstreaming to jdk17u-dev repo. 
So any people who are familar with the riscv port could review a PR for riscv-port-jdk17u repo. When a backporting PR for this repo is clean or is fully reviewed, I could help do the final integration. I am open to other suggestions. 

[1] https://github.com/openjdk/lilliput/pull/67
[2] https://github.com/openjdk/zgc/pull/1

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/2

From vkempik at openjdk.org  Tue Feb 28 09:02:39 2023
From: vkempik at openjdk.org (Vladimir Kempik)
Date: Tue, 28 Feb 2023 09:02:39 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8290496: riscv: Fix build
 warnings-as-errors with GCC 11
In-Reply-To: <GLNAU7mY8cPnIZ-I7f2A7A1TACn7sSBk0n4IY4bzetA=.1ac92fba-fafc-4268-ad18-3fe964cc9e9b@github.com>
References: <4bZJt2AHnuZ8R76bVQUYfWL6T166eOWjGv6ZhNZdR-M=.6c32d8b5-20b1-4f42-8b93-bf763ce448f3@github.com>
 <Bmog_k13XrUebrJy8u_4xFaC7EVvyna07nH_6Wh_CkM=.eac3b50d-b611-4cb8-8158-79211beca141@github.com>
 <GLNAU7mY8cPnIZ-I7f2A7A1TACn7sSBk0n4IY4bzetA=.1ac92fba-fafc-4268-ad18-3fe964cc9e9b@github.com>
Message-ID: <uXNu6koLsnVWFs4scBPu5iMrMQnvvPZAHOyxiKtnEM8=.e965aed3-e886-4c8f-b480-188dba750fcc@github.com>

On Tue, 28 Feb 2023 08:47:53 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Your backport is clean so it doesn't need a review.
>> However, the process is not clear yet: who would approve backports in this project ? how to request approval ?
>> Also, Can anyone, who is already reviewer in jdk-updates-project become reviewer in riscv-port-jdk17u ?
>> 
>> This Qs is not for @DingliZhang , but general one
>
> @VladimirKempik 
> 
> Here is what I am think about the backporting work flow for this repo. 
> Since we are not upstreamed yet, I think we could follow a simplified workflow here. In fact, if you look at other projects like Lilliput or ZGC, they also follow a rather simplified flow for PR integration. In these cases, Committers could also do code reviews [1] and you don't even need a JBS issue for creating a PR [2]. 
> 
> Here in our case for riscv-port-jdk17u repo, I am not expecting uses of labels/comments on the JBS issue for request approvals, which is required by the upstreaming backporting flow.  I think it's better to do that (like marking the JBS issues for requesting maintainer approvals) when we do the final upstreaming to jdk17u-dev repo. 
> So any people who are familar with the riscv port could review a PR for riscv-port-jdk17u repo. When a backporting PR for this repo is clean or is fully reviewed, I could help do the final integration. I am open to other suggestions. 
> 
> [1] https://github.com/openjdk/lilliput/pull/67
> [2] https://github.com/openjdk/zgc/pull/1

Hello @RealFYang, thanks to explanation, however one moment isn't clear yet

In case of "clean" backports, can we request integration right away ?

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/2

From fyang at openjdk.org  Tue Feb 28 09:33:34 2023
From: fyang at openjdk.org (Fei Yang)
Date: Tue, 28 Feb 2023 09:33:34 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8290496: riscv: Fix build
 warnings-as-errors with GCC 11
In-Reply-To: <GLNAU7mY8cPnIZ-I7f2A7A1TACn7sSBk0n4IY4bzetA=.1ac92fba-fafc-4268-ad18-3fe964cc9e9b@github.com>
References: <4bZJt2AHnuZ8R76bVQUYfWL6T166eOWjGv6ZhNZdR-M=.6c32d8b5-20b1-4f42-8b93-bf763ce448f3@github.com>
 <Bmog_k13XrUebrJy8u_4xFaC7EVvyna07nH_6Wh_CkM=.eac3b50d-b611-4cb8-8158-79211beca141@github.com>
 <GLNAU7mY8cPnIZ-I7f2A7A1TACn7sSBk0n4IY4bzetA=.1ac92fba-fafc-4268-ad18-3fe964cc9e9b@github.com>
Message-ID: <pKFW79Y62NKizm1qC3otoYCNU1UZj0GlHEwY7UvaOE0=.a133956c-1e43-4383-96f7-2ec6127e424e@github.com>

On Tue, 28 Feb 2023 08:47:53 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Your backport is clean so it doesn't need a review.
>> However, the process is not clear yet: who would approve backports in this project ? how to request approval ?
>> Also, Can anyone, who is already reviewer in jdk-updates-project become reviewer in riscv-port-jdk17u ?
>> 
>> This Qs is not for @DingliZhang , but general one
>
> @VladimirKempik 
> 
> Here is what I am think about the backporting work flow for this repo. 
> Since we are not upstreamed yet, I think we could follow a simplified workflow here. In fact, if you look at other projects like Lilliput or ZGC, they also follow a rather simplified flow for PR integration. In these cases, Committers could also do code reviews [1] and you don't even need a JBS issue for creating a PR [2]. 
> 
> Here in our case for riscv-port-jdk17u repo, I am not expecting uses of labels/comments on the JBS issue for request approvals, which is required by the upstream backporting flow.  I think it's better to do that (like marking the JBS issues for requesting maintainer approvals) when we do the final upstreaming to jdk17u-dev repo. 
> So any people who are familar with the riscv port could review a PR for riscv-port-jdk17u repo. When a backporting PR for this repo is clean or is fully reviewed, I could help do the final integration. I am open to other suggestions. 
> 
> [1] https://github.com/openjdk/lilliput/pull/67
> [2] https://github.com/openjdk/zgc/pull/1

> Hello @RealFYang, thanks to explanation, however one moment isn't clear yet
> 
> In case of "clean" backports, can we request integration right away ?

Just ping me on the PR when you have a clean backport :-)
I am not sure if the bot could be configured to help with that.

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/2

From duke at openjdk.org  Tue Feb 28 10:55:18 2023
From: duke at openjdk.org (duke)
Date: Tue, 28 Feb 2023 10:55:18 GMT
Subject: git: openjdk/riscv-port-jdk17u: riscv-port: backport JDK-8290496 (#2)
Message-ID: <234022be-f802-4826-9ff3-38a91582d42c@openjdk.org>

Changeset: 501e1b10
Author:    Dingli Zhang <dingli at iscas.ac.cn>
Committer: GitHub <noreply at github.com>
Date:      2023-02-28 18:54:32 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/501e1b10fc2b88545f6cc660138ebcd36110e6fc

backport JDK-8290496 (#2)


! src/hotspot/cpu/riscv/nativeInst_riscv.hpp
! src/hotspot/cpu/riscv/vtableStubs_riscv.cpp


From fyang at openjdk.org  Tue Feb 28 10:57:55 2023
From: fyang at openjdk.org (Fei Yang)
Date: Tue, 28 Feb 2023 10:57:55 GMT
Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8290496: riscv: Fix build
 warnings-as-errors with GCC 11
In-Reply-To: <4bZJt2AHnuZ8R76bVQUYfWL6T166eOWjGv6ZhNZdR-M=.6c32d8b5-20b1-4f42-8b93-bf763ce448f3@github.com>
References: <4bZJt2AHnuZ8R76bVQUYfWL6T166eOWjGv6ZhNZdR-M=.6c32d8b5-20b1-4f42-8b93-bf763ce448f3@github.com>
Message-ID: <HDVUhtDWczuTiDCprdH87XhGMQYT4tnuo-2dXMFHEWg=.35b5f52b-f849-4230-9976-81e853b35912@github.com>

On Tue, 28 Feb 2023 06:35:49 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8290496](https://bugs.openjdk.java.net/browse/JDK-8290496). Applies cleanly.
> 
> Build without --disable-warnings-as-errors after this fix passed on unmatched board with GCC11.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/2