From dzhang at openjdk.org Wed Mar 1 01:26:19 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 1 Mar 2023 01:26:19 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8290164: compiler/runtime/TestConstantsInError.java fails on riscv Message-ID: <1EjVUi4snzZ2R1Mlge-ZgGB03hIEgs2AstiFxzmN-cQ=.efaf1365-9f33-4502-85e7-f80363c1e3e1@github.com> Please review this backport to riscv-port-jdk17u. Backport of [JDK-8290164](https://bugs.openjdk.org/browse/JDK-8290164). Since jdk17u does not have the patch [JDK-8280473](https://bugs.openjdk.java.net/browse/JDK-8280473), there will be one less `if` to modify. Testing: - compiler/runtime/TestConstantsInError.java passed on qemu and unmacthed. ------------- Commit messages: - backport JDK-8290164 Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/3/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=3&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290164 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/3.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/3/head:pull/3 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/3 From duke at openjdk.org Wed Mar 1 02:12:19 2023 From: duke at openjdk.org (duke) Date: Wed, 1 Mar 2023 02:12:19 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 15 new changesets Message-ID: Changeset: 49ff97cd Author: Victor Rudometov Committer: Paul Hohensee Date: 2023-02-20 18:44:08 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/49ff97cdf73655153a1ebe82be8fb773e4346f89 8301342: Prefer ArrayList to LinkedList in LayoutComparator Backport-of: d67bfe21a23fea2d9ef4eef4e811b774cca2ab94 ! src/java.desktop/share/classes/javax/swing/LayoutComparator.java Changeset: a6f4cf1a Author: Victor Rudometov Committer: Paul Hohensee Date: 2023-02-20 18:45:40 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/a6f4cf1aaadb8c17f01822ce510e43c74005258e 8302152: Speed up tests with infinite loops, sleep less Backport-of: a9a53f417d017c6e92d1f0331359037815bd431e ! test/hotspot/jtreg/compiler/loopopts/TestCMoveWithDeadPhi.java ! test/hotspot/jtreg/compiler/loopopts/TestInfLoopNearUsePlacement.java ! test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopCCP.java ! test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopNest.java ! test/hotspot/jtreg/compiler/loopopts/TestStrangeControl.java Changeset: fcd9110e Author: Patrick Zhang Date: 2023-02-21 15:29:13 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/fcd9110e73cfa3b19c3f1b17de26a2a15331ab1b 8298472: AArch64: Detect Ampere-1 and Ampere-1A CPUs and set default options Reviewed-by: aph, goetz Backport-of: 706845743699efb01994e2d12c65023a3e972b77 ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp ! src/hotspot/cpu/aarch64/vm_version_aarch64.hpp Changeset: da62b2b3 Author: Victor Rudometov Committer: Paul Hohensee Date: 2023-02-21 16:39:01 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/da62b2b37e079d88039eec363cb9c7f5e59a8ff0 8299970: Speed up compiler/arraycopy/TestArrayCopyConjoint.java Backport-of: 5d39d14522df5dc35a5f4c9934d2cf8da4fecaa6 ! test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyConjoint.java ! test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyDisjoint.java Changeset: bf4e6590 Author: Radim Vansa Committer: Paul Hohensee Date: 2023-02-24 15:03:57 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/bf4e6590c629883d424db2ca01fac5b0f200ac9f 8272702: Resolving URI relative path with no / may lead to incorrect toString Reviewed-by: phh Backport-of: 79597f1ea6844f374beeeba219719cd9d5fe7d03 ! src/java.base/share/classes/java/net/URI.java ! test/jdk/java/net/URI/Test.java Changeset: 3c1e03b4 Author: Goetz Lindenmaier Date: 2023-02-24 19:52:17 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/3c1e03b44dd57455719e007cef81c60b6d61469f 8251177: [macosx] The text "big" is truncated in JTabbedPane Backport-of: 16ebe40a1bcd1fe43126fe1dca27bb64cb12de16 ! test/jdk/ProblemList.txt - test/jdk/javax/swing/JTabbedPane/4209065/bug4209065.html ! test/jdk/javax/swing/JTabbedPane/4209065/bug4209065.java Changeset: a0cda28d Author: Goetz Lindenmaier Date: 2023-02-24 19:53:43 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/a0cda28d039b92cdae8a357e1287dc502ee02353 8294902: Undefined Behavior in C2 regalloc with null references Reviewed-by: rrich, phh Backport-of: 0bbc4181cdbccfc3a542f306ce1902cc2e9f36cb ! src/hotspot/share/memory/arena.cpp ! src/hotspot/share/opto/bytecodeInfo.cpp ! src/hotspot/share/opto/chaitin.hpp ! src/hotspot/share/opto/postaloc.cpp ! src/hotspot/share/runtime/vmStructs.hpp ! src/hotspot/share/utilities/globalDefinitions.hpp ! src/hotspot/share/utilities/globalDefinitions_gcc.hpp Changeset: c8ee0762 Author: Goetz Lindenmaier Date: 2023-02-24 19:58:15 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/c8ee076241cc7d83f423683d97ec37f9e0d6ebaa 8245654: Add Certigna Root CA Reviewed-by: phh Backport-of: 8c87a67419b91f254ed7e4dd8ac8d294b8c4735e + make/data/cacerts/certignaca + test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CertignaCA.java ! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java Changeset: a5c97d4a Author: Shruthi Committer: Christoph Langer Date: 2023-02-24 21:07:31 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/a5c97d4ad752ef9f54046c48b5bdfbc9cfb84280 8300751: [17u] Remove duplicate entry in javac.properties Reviewed-by: clanger ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties Changeset: 9bacd0c5 Author: Shruthi Committer: Christoph Langer Date: 2023-02-24 21:32:51 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/9bacd0c593c48dc7aa95ace9ab983aef0b002df4 8266974: duplicate property key in java.sql.rowset resource bundle Backport-of: e3d5c9e7c4ab210ae7a4417a47632603910744a1 ! src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle.properties ! src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_de.properties ! src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_es.properties ! src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_fr.properties ! src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_it.properties ! src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_ja.properties ! src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_ko.properties ! src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_pt_BR.properties ! src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_sv.properties ! src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_zh_CN.properties ! src/java.sql.rowset/share/classes/com/sun/rowset/RowSetResourceBundle_zh_TW.properties Changeset: 53caaf58 Author: Anton Kozlov Committer: Christoph Langer Date: 2023-02-24 22:06:15 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/53caaf5896947c6a11879835114223d9869f21ca 8289647: AssertionError during annotation processing of record related tests Reviewed-by: phh Backport-of: 64a1a08ff9f120648e466449f65750991cbf673c ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TypeEnter.java ! test/langtools/tools/javac/records/RecordCompilationTests.java Changeset: 9c35d599 Author: Scott Gibbons Committer: Christoph Langer Date: 2023-02-24 22:15:39 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/9c35d599116e5874d9b397b298603aed4b7fa5b8 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption Backport-of: 409382ba4b43bf48ed0086020dd20641effd35b6 ! src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java Changeset: 70ea0e66 Author: Adam Sotona Committer: Christoph Langer Date: 2023-02-27 10:33:11 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/70ea0e6687faf7d003f40ff9624aeeb85623f506 8293000: Review running times of jshell regression tests Backport-of: b4e1e416dacb6099a780f2250cef737834c19d56 ! test/langtools/jdk/jshell/ClassMembersTest.java ! test/langtools/jdk/jshell/CompletionSuggestionTest.java ! test/langtools/jdk/jshell/ExecutionControlTestBase.java ! test/langtools/jdk/jshell/SimpleRegressionTest.java ! test/langtools/jdk/jshell/ToolBasicTest.java Changeset: e618681e Author: George Adams Date: 2023-02-27 10:57:02 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/e618681e9b6d496ca4e81768dd177f2ad01ee894 8302879: doc/building.md update link to jtreg builds Reviewed-by: clanger Backport-of: bb3dfd6adbb58871bc7238107ed254831b22d48b ! doc/building.html ! doc/building.md Changeset: 6eaa6815 Author: Fei Yang Date: 2023-02-28 19:04:15 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/6eaa6815a8dc52846499bde76f10ba9467376259 Merge branch 'master' into riscv-port From gcao at openjdk.org Wed Mar 1 02:33:21 2023 From: gcao at openjdk.org (Gui Cao) Date: Wed, 1 Mar 2023 02:33:21 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub Message-ID: <6YDGzaj1Kh-ghWdeTeLUYaKLgqLmynNY6_wVJA50hmE=.472fd199-d8f8-4aae-8810-6c3c064eda36@github.com> Please review this backport to riscv-port-jdk17u. Backport of [JDK-8293100](https://bugs.openjdk.org/browse/JDK-8293100). The original patch cannot be directly applied because of the line number, but there are no other additional changes. Testing: - vmTestbase/nsk/stress/jni/jnistress002.java passed on qemu and unmacthed. - all tier1 passed on unmacthed (release). ------------- Commit messages: - backport JDK-8293100 Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/4/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=4&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293100 Stats: 81 lines in 4 files changed: 64 ins; 0 del; 17 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/4.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/4/head:pull/4 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/4 From dzhang at openjdk.org Wed Mar 1 04:37:13 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 1 Mar 2023 04:37:13 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8290164: compiler/runtime/TestConstantsInError.java fails on riscv [v2] In-Reply-To: <1EjVUi4snzZ2R1Mlge-ZgGB03hIEgs2AstiFxzmN-cQ=.efaf1365-9f33-4502-85e7-f80363c1e3e1@github.com> References: <1EjVUi4snzZ2R1Mlge-ZgGB03hIEgs2AstiFxzmN-cQ=.efaf1365-9f33-4502-85e7-f80363c1e3e1@github.com> Message-ID: > Please review this backport to riscv-port-jdk17u. Backport of [JDK-8290164](https://bugs.openjdk.org/browse/JDK-8290164). > Since jdk17u does not have the patch [JDK-8280473](https://bugs.openjdk.java.net/browse/JDK-8280473), there will be one less `if` to modify. > > > Testing: > > - compiler/runtime/TestConstantsInError.java passed on qemu and unmacthed. Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: backport JDK-8290164 ------------- Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/3/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=3&range=01 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/3.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/3/head:pull/3 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/3 From gcao at openjdk.org Wed Mar 1 05:38:17 2023 From: gcao at openjdk.org (Gui Cao) Date: Wed, 1 Mar 2023 05:38:17 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub [v2] In-Reply-To: <6YDGzaj1Kh-ghWdeTeLUYaKLgqLmynNY6_wVJA50hmE=.472fd199-d8f8-4aae-8810-6c3c064eda36@github.com> References: <6YDGzaj1Kh-ghWdeTeLUYaKLgqLmynNY6_wVJA50hmE=.472fd199-d8f8-4aae-8810-6c3c064eda36@github.com> Message-ID: > Please review this backport to riscv-port-jdk17u. Backport of [JDK-8293100](https://bugs.openjdk.org/browse/JDK-8293100). > The original patch cannot be directly applied because of the line number, but there are no other additional changes. > > Testing: > > - vmTestbase/nsk/stress/jni/jnistress002.java passed on qemu and unmacthed. > - all tier1 passed on unmacthed (release). Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: backport JDK-8293100 ------------- Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/4/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=4&range=01 Stats: 81 lines in 4 files changed: 64 ins; 0 del; 17 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/4.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/4/head:pull/4 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/4 From vkempik at openjdk.org Wed Mar 1 06:31:30 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Wed, 1 Mar 2023 06:31:30 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub [v2] In-Reply-To: References: <6YDGzaj1Kh-ghWdeTeLUYaKLgqLmynNY6_wVJA50hmE=.472fd199-d8f8-4aae-8810-6c3c064eda36@github.com> Message-ID: On Wed, 1 Mar 2023 05:38:17 GMT, Gui Cao wrote: >> Please review this backport to riscv-port-jdk17u. Backport of [JDK-8293100](https://bugs.openjdk.org/browse/JDK-8293100). >> The original patch cannot be directly applied because of the line number, but there are no other additional changes. >> >> Testing: >> >> - vmTestbase/nsk/stress/jni/jnistress002.java passed on qemu and unmacthed. >> - all tier1 passed on unmacthed (release). > > Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > backport JDK-8293100 lgtm ------------- Marked as reviewed by vkempik (Reviewer). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/4 From fyang at openjdk.org Wed Mar 1 07:08:34 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 1 Mar 2023 07:08:34 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8290164: compiler/runtime/TestConstantsInError.java fails on riscv [v2] In-Reply-To: References: <1EjVUi4snzZ2R1Mlge-ZgGB03hIEgs2AstiFxzmN-cQ=.efaf1365-9f33-4502-85e7-f80363c1e3e1@github.com> Message-ID: On Wed, 1 Mar 2023 04:37:13 GMT, Dingli Zhang wrote: >> Please review this backport to riscv-port-jdk17u. Backport of [JDK-8290164](https://bugs.openjdk.org/browse/JDK-8290164). >> Since jdk17u does not have the patch [JDK-8280473](https://bugs.openjdk.java.net/browse/JDK-8280473), there will be one less `if` to modify. >> >> >> Testing: >> >> - compiler/runtime/TestConstantsInError.java passed on qemu and unmacthed. > > Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > backport JDK-8290164 Looks good. ------------- Marked as reviewed by fyang (Committer). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/3 From fyang at openjdk.org Wed Mar 1 08:22:38 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 1 Mar 2023 08:22:38 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub [v2] In-Reply-To: References: <6YDGzaj1Kh-ghWdeTeLUYaKLgqLmynNY6_wVJA50hmE=.472fd199-d8f8-4aae-8810-6c3c064eda36@github.com> Message-ID: <_I9F4_JXOT8FbwLLNqJSkgtIIDA1V-31R95J84fywCc=.a2386858-b579-4307-9c75-fec03f8eba99@github.com> On Wed, 1 Mar 2023 05:38:17 GMT, Gui Cao wrote: >> Please review this backport to riscv-port-jdk17u. Backport of [JDK-8293100](https://bugs.openjdk.org/browse/JDK-8293100). >> The original patch cannot be directly applied because of the line number, but there are no other additional changes. >> >> Testing: >> >> - vmTestbase/nsk/stress/jni/jnistress002.java passed on qemu and unmacthed. >> - all tier1 passed on unmacthed (release). > > Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > backport JDK-8293100 Looks good. ------------- Marked as reviewed by fyang (Committer). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/4 From xlinzheng at openjdk.org Wed Mar 1 08:53:48 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Wed, 1 Mar 2023 08:53:48 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub [v2] In-Reply-To: References: <6YDGzaj1Kh-ghWdeTeLUYaKLgqLmynNY6_wVJA50hmE=.472fd199-d8f8-4aae-8810-6c3c064eda36@github.com> Message-ID: On Wed, 1 Mar 2023 05:38:17 GMT, Gui Cao wrote: >> Please review this backport to riscv-port-jdk17u. Backport of [JDK-8293100](https://bugs.openjdk.org/browse/JDK-8293100). >> The original patch cannot be directly applied because of the line number, but there are no other additional changes. >> >> Testing: >> >> - vmTestbase/nsk/stress/jni/jnistress002.java passed on qemu and unmacthed. >> - all tier1 passed on unmacthed (release). > > Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > backport JDK-8293100 Thanks for backporting this! ------------- Marked as reviewed by xlinzheng (no project role). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/4 From luhenry at openjdk.org Wed Mar 1 22:26:51 2023 From: luhenry at openjdk.org (Ludovic Henry) Date: Wed, 1 Mar 2023 22:26:51 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub [v2] In-Reply-To: References: <6YDGzaj1Kh-ghWdeTeLUYaKLgqLmynNY6_wVJA50hmE=.472fd199-d8f8-4aae-8810-6c3c064eda36@github.com> Message-ID: On Wed, 1 Mar 2023 05:38:17 GMT, Gui Cao wrote: >> Please review this backport to riscv-port-jdk17u. Backport of [JDK-8293100](https://bugs.openjdk.org/browse/JDK-8293100). >> The original patch cannot be directly applied because of the line number, but there are no other additional changes. >> >> Testing: >> >> - vmTestbase/nsk/stress/jni/jnistress002.java passed on qemu and unmacthed. >> - all tier1 passed on unmacthed (release). > > Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > backport JDK-8293100 Marked as reviewed by luhenry (no project role). ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/4 From duke at openjdk.org Thu Mar 2 00:12:23 2023 From: duke at openjdk.org (duke) Date: Thu, 2 Mar 2023 00:12:23 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 2 new changesets Message-ID: <0229ffeb-4672-4b0f-8b42-54308248c265@openjdk.org> Changeset: efabbf8f Author: Dingli Zhang Committer: GitHub Date: 2023-03-02 08:10:57 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/efabbf8f592f132afd4ec235f76bae4a2212cc20 8290164: compiler/runtime/TestConstantsInError.java fails on riscv ! test/hotspot/jtreg/compiler/runtime/TestConstantsInError.java Changeset: ae348d8f Author: zifeihan Committer: GitHub Date: 2023-03-02 08:11:23 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/ae348d8f6b1ba26aa9ddea4943a0a8b9e0ed359d 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub ! src/hotspot/cpu/riscv/frame_riscv.hpp ! src/hotspot/cpu/riscv/riscv.ad ! src/hotspot/cpu/riscv/stubGenerator_riscv.cpp ! src/hotspot/cpu/riscv/vmreg_riscv.cpp From fyang at openjdk.org Thu Mar 2 00:13:59 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 2 Mar 2023 00:13:59 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8290164: compiler/runtime/TestConstantsInError.java fails on riscv In-Reply-To: <1EjVUi4snzZ2R1Mlge-ZgGB03hIEgs2AstiFxzmN-cQ=.efaf1365-9f33-4502-85e7-f80363c1e3e1@github.com> References: <1EjVUi4snzZ2R1Mlge-ZgGB03hIEgs2AstiFxzmN-cQ=.efaf1365-9f33-4502-85e7-f80363c1e3e1@github.com> Message-ID: On Wed, 1 Mar 2023 01:12:21 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. Backport of [JDK-8290164](https://bugs.openjdk.org/browse/JDK-8290164). > Since jdk17u does not have the patch [JDK-8280473](https://bugs.openjdk.java.net/browse/JDK-8280473), there will be one less `if` to modify. > > > Testing: > > - compiler/runtime/TestConstantsInError.java passed on qemu and unmacthed. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/3 From fyang at openjdk.org Thu Mar 2 00:14:02 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 2 Mar 2023 00:14:02 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub In-Reply-To: <6YDGzaj1Kh-ghWdeTeLUYaKLgqLmynNY6_wVJA50hmE=.472fd199-d8f8-4aae-8810-6c3c064eda36@github.com> References: <6YDGzaj1Kh-ghWdeTeLUYaKLgqLmynNY6_wVJA50hmE=.472fd199-d8f8-4aae-8810-6c3c064eda36@github.com> Message-ID: On Wed, 1 Mar 2023 02:25:52 GMT, Gui Cao wrote: > Please review this backport to riscv-port-jdk17u. Backport of [JDK-8293100](https://bugs.openjdk.org/browse/JDK-8293100). > The original patch cannot be directly applied because of the line number, but there are no other additional changes. > > Testing: > > - vmTestbase/nsk/stress/jni/jnistress002.java passed on qemu and unmacthed. > - all tier1 passed on unmacthed (release). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/4 From dzhang at openjdk.org Thu Mar 2 04:00:34 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 2 Mar 2023 04:00:34 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8285437: riscv: Fix MachNode size mismatch for MacroAssembler::verify_oops* Message-ID: Please review this backport to riscv-port-jdk17u. Backport of [JDK-8285437](https://bugs.openjdk.java.net/browse/JDK-8285437). Applies cleanly. Testing: - A normal springboot-helloworld program using -XX:+VerifyOops passed on qemu and unmacthed. - All tier1 passed on unmacthed (release). ------------- Commit messages: - 8285437: riscv: Fix MachNode size mismatch for MacroAssembler::verify_oops* Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/5/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=5&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285437 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/5.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/5/head:pull/5 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/5 From xlinzheng at openjdk.org Thu Mar 2 09:03:40 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Thu, 2 Mar 2023 09:03:40 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8285437: riscv: Fix MachNode size mismatch for MacroAssembler::verify_oops* In-Reply-To: References: Message-ID: <7G7ZcRvrRdEPCRhf89JDl5MKBxJgcB68KWmvVSDtiuA=.e756e3fa-2d18-4774-8609-c63ba5a0a349@github.com> On Thu, 2 Mar 2023 03:50:59 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8285437](https://bugs.openjdk.java.net/browse/JDK-8285437). Applies cleanly. > > Testing: > - A normal springboot-helloworld program using -XX:+VerifyOops passed on qemu and unmacthed. > - Tier1 passed without new failure on unmacthed (release). lgtm. ------------- Marked as reviewed by xlinzheng (no project role). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/5 From vladimir.kempik at gmail.com Thu Mar 2 09:33:49 2023 From: vladimir.kempik at gmail.com (Vladimir Kempik) Date: Thu, 2 Mar 2023 12:33:49 +0300 Subject: regarding 17u port Message-ID: Hello Now that the 17u backport in riscv-port-jdk17u is feeling well, what?s next? Should the riscv-port branch be frozen, so we have a minimalistic backport which is ready to start traveling to jdk17u-dev ? And the development ( more backports important for performance, etc) continues in a separate branch ? Regards, Vladimir From luhenry at openjdk.org Thu Mar 2 10:04:40 2023 From: luhenry at openjdk.org (Ludovic Henry) Date: Thu, 2 Mar 2023 10:04:40 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8285437: riscv: Fix MachNode size mismatch for MacroAssembler::verify_oops* In-Reply-To: References: Message-ID: <1QKpxaov-HtDmFJhOWunhQnv1R-cvflrsuG_2ASt37w=.9fdb8eb4-7eeb-4a1a-a81c-62026bdd0f81@github.com> On Thu, 2 Mar 2023 03:50:59 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8285437](https://bugs.openjdk.java.net/browse/JDK-8285437). Applies cleanly. > > Testing: > - A normal springboot-helloworld program using -XX:+VerifyOops passed on qemu and unmacthed. > - Tier1 passed without new failure on unmacthed (release). Marked as reviewed by luhenry (no project role). ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/5 From gcao at openjdk.org Thu Mar 2 14:48:22 2023 From: gcao at openjdk.org (Gui Cao) Date: Thu, 2 Mar 2023 14:48:22 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8294083: RISC-V: Minimal build failed with --disable-precompiled-headers Message-ID: Please review this backport to riscv-port-jdk17u. Backport of [JDK-8294083](https://bugs.openjdk.org/browse/JDK-8294083). Compared to the original patch, the addition of including the corresponding header (gc/shared/collectedHeap.hpp) fix the invalid use of incomplete type 'class CollectedHeap' as follows: === Output from failing command(s) repeated here === * For target hotspot_variant-minimal_libjvm_objs_c1_Runtime1_riscv.o: ------------- Commit messages: - backport JDK-8294083 Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/6/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=6&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294083 Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/6.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/6/head:pull/6 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/6 From gcao at openjdk.org Thu Mar 2 15:07:38 2023 From: gcao at openjdk.org (Gui Cao) Date: Thu, 2 Mar 2023 15:07:38 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8294083: RISC-V: Minimal build failed with --disable-precompiled-headers [v2] In-Reply-To: References: Message-ID: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8294083](https://bugs.openjdk.org/browse/JDK-8294083). > Compared to the original patch, the addition of including the corresponding header (gc/shared/collectedHeap.hpp) fix the invalid use of incomplete type 'class CollectedHeap' as follows: > > === Output from failing command(s) repeated here === > * For target hotspot_variant-minimal_libjvm_objs_c1_Runtime1_riscv.o: Gui Cao has updated the pull request incrementally with one additional commit since the last revision: backport 8295468: RISC-V: Minimal builds are broken ------------- Changes: - all: https://git.openjdk.org/riscv-port-jdk17u/pull/6/files - new: https://git.openjdk.org/riscv-port-jdk17u/pull/6/files/8858c65a..e57adee0 Webrevs: - full: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=6&range=01 - incr: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=6&range=00-01 Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/6.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/6/head:pull/6 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/6 From luhenry at openjdk.org Thu Mar 2 16:14:39 2023 From: luhenry at openjdk.org (Ludovic Henry) Date: Thu, 2 Mar 2023 16:14:39 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8294083: RISC-V: Minimal build failed with --disable-precompiled-headers [v2] In-Reply-To: References:

Message-ID: On Thu, 2 Mar 2023 15:07:38 GMT, Gui Cao wrote: >> Please review this backport to riscv-port-jdk17u. >> Backport of [JDK-8294083](https://bugs.openjdk.org/browse/JDK-8294083). >> Compared to the original patch, the addition of including the corresponding header (gc/shared/collectedHeap.hpp) fix the invalid use of incomplete type 'class CollectedHeap' as follows: >> >> === Output from failing command(s) repeated here === >> * For target hotspot_variant-minimal_libjvm_objs_c1_Runtime1_riscv.o: > > Gui Cao has updated the pull request incrementally with one additional commit since the last revision: > > backport 8295468: RISC-V: Minimal builds are broken Looks good. ------------- Marked as reviewed by fyang (Committer). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/6 From fyang at openjdk.org Tue Mar 7 02:32:42 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 7 Mar 2023 02:32:42 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8294083: RISC-V: Minimal build failed with --disable-precompiled-headers In-Reply-To: References: Message-ID: On Thu, 2 Mar 2023 14:40:47 GMT, Gui Cao wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8294083](https://bugs.openjdk.org/browse/JDK-8294083). > Compared to the original patch, the addition of including the corresponding header (gc/shared/collectedHeap.hpp) fix the invalid use of incomplete type 'class CollectedHeap' as follows: > > === Output from failing command(s) repeated here === > * For target hotspot_variant-minimal_libjvm_objs_c1_Runtime1_riscv.o: This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/6 From yangfei at iscas.ac.cn Tue Mar 7 03:22:41 2023 From: yangfei at iscas.ac.cn (yangfei at iscas.ac.cn) Date: Tue, 7 Mar 2023 11:22:41 +0800 (GMT+08:00) Subject: regarding 17u port In-Reply-To: References: Message-ID: <546ac79f.79ec.186ba17b5ca.Coremail.yangfei@iscas.ac.cn> Hi, I think we still have a couple of fixes to backport, as mentioned in the previous discussion [1] (5.1 patch for bugfix). By referencing the 8u upstreaming of aarch64 port [2], I feel it's still possible to have some refectoring/performance fixes in the current riscv-port branch before upstreaming. For example, support for RVC extension is still experimental in this branch as compared to product in jdk mainline. AFAIK, the current off-the-shelf RV64 chips/boards are all equipped with this extension. But before we proceed, we will need the jdk-update project maintainer's confirmation about that. I see similar questions has been raised before [3]. Regards, Fei [1] https://mail.openjdk.org/pipermail/riscv-port-dev/2023-February/000733.html [2] https://mail.openjdk.org/pipermail/jdk8u-dev/2020-November/013121.html [3] https://mail.openjdk.org/pipermail/riscv-port-dev/2023-February/000735.html > -----Original Messages----- > From: "Vladimir Kempik" > Sent Time: 2023-03-02 17:33:49 (Thursday) > To: riscv-port-dev > Cc: > Subject: regarding 17u port > > Hello > > Now that the 17u backport in riscv-port-jdk17u is feeling well, what?s next? > > Should the riscv-port branch be frozen, so we have a minimalistic backport which is ready to start traveling to jdk17u-dev ? > And the development ( more backports important for performance, etc) continues in a separate branch ? > > Regards, Vladimir From vladimir.kempik at gmail.com Tue Mar 7 07:21:42 2023 From: vladimir.kempik at gmail.com (Vladimir Kempik) Date: Tue, 7 Mar 2023 10:21:42 +0300 Subject: regarding 17u port In-Reply-To: <546ac79f.79ec.186ba17b5ca.Coremail.yangfei@iscas.ac.cn> References: <546ac79f.79ec.186ba17b5ca.Coremail.yangfei@iscas.ac.cn> Message-ID: Hello In that case I would like to add a couple of RISC-V only performance fixes [1], [2]. Regards, Vladimir [1] https://bugs.openjdk.org/browse/JDK-8296602 [2] https://bugs.openjdk.org/browse/JDK-8297359 > 7 ????? 2023 ?., ? 06:22, yangfei at iscas.ac.cn ???????(?): > > Hi, > > I think we still have a couple of fixes to backport, as mentioned in the previous discussion [1] (5.1 patch for bugfix). > By referencing the 8u upstreaming of aarch64 port [2], I feel it's still possible to have some refectoring/performance fixes in the current riscv-port branch before upstreaming. > For example, support for RVC extension is still experimental in this branch as compared to product in jdk mainline. AFAIK, the current off-the-shelf RV64 chips/boards are all equipped with this extension. > But before we proceed, we will need the jdk-update project maintainer's confirmation about that. I see similar questions has been raised before [3]. > > Regards, > Fei > > [1] https://mail.openjdk.org/pipermail/riscv-port-dev/2023-February/000733.html > [2] https://mail.openjdk.org/pipermail/jdk8u-dev/2020-November/013121.html > [3] https://mail.openjdk.org/pipermail/riscv-port-dev/2023-February/000735.html > > > -----Original Messages----- > > From: "Vladimir Kempik" > > Sent Time: 2023-03-02 17:33:49 (Thursday) > > To: riscv-port-dev > > Cc: > > Subject: regarding 17u port > > > > Hello > > > > Now that the 17u backport in riscv-port-jdk17u is feeling well, what?s next? > > > > Should the riscv-port branch be frozen, so we have a minimalistic backport which is ready to start traveling to jdk17u-dev ? > > And the development ( more backports important for performance, etc) continues in a separate branch ? > > > > Regards, Vladimir > -------------- next part -------------- An HTML attachment was scrubbed... URL: From dzhang at openjdk.org Tue Mar 7 07:55:25 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Tue, 7 Mar 2023 07:55:25 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8287552: riscv: Fix comment typo in li64 Message-ID: Please review this backport to riscv-port-jdk17u. Backport of [JDK-8287552](https://bugs.openjdk.java.net/browse/JDK-8287552). Applies cleanly. Testing: - Tier1 passed without new failure on unmacthed (release). ------------- Commit messages: - 8287552: riscv: Fix comment typo in li64 Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/7/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=7&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287552 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/7.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/7/head:pull/7 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/7 From gcao at openjdk.org Tue Mar 7 09:10:18 2023 From: gcao at openjdk.org (Gui Cao) Date: Tue, 7 Mar 2023 09:10:18 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296771: RISC-V: C2: assert(false) failed: bad AD file Message-ID: Please review this backport to riscv-port-jdk17u. Backport of [JDK-8296771](https://bugs.openjdk.org/browse/JDK-8296771). Applies cleanly. Testing: - compiler/runtime/TestConstantsInError.java passed on qemu (fastdebug). - Tier1 passed without new failure on unmacthed (release). ------------- Commit messages: - 8296771: RISC-V: C2: assert(false) failed: bad AD file Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/8/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=8&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296771 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/8.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/8/head:pull/8 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/8 From duke at openjdk.org Thu Mar 9 09:16:55 2023 From: duke at openjdk.org (duke) Date: Thu, 9 Mar 2023 09:16:55 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8296771: RISC-V: C2: assert(false) failed: bad AD file Message-ID: <585ec34c-0643-4362-8ef9-207fad249241@openjdk.org> Changeset: 0a74c412 Author: zifeihan Committer: GitHub Date: 2023-03-09 17:16:27 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/0a74c412d7d5d157b8e097d7696060de56279a5a 8296771: RISC-V: C2: assert(false) failed: bad AD file ! src/hotspot/cpu/riscv/riscv.ad From fyang at openjdk.org Thu Mar 9 09:19:45 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 9 Mar 2023 09:19:45 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8296771: RISC-V: C2: assert(false) failed: bad AD file In-Reply-To: References: Message-ID: On Tue, 7 Mar 2023 09:01:32 GMT, Gui Cao wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8296771](https://bugs.openjdk.org/browse/JDK-8296771). Applies cleanly. > By the way, we can directly use` compiler/types/TestSubTypeCheckMacroTrichotomy.java` to reproduce the bad ad file error. > > Testing: > - compiler/types/TestSubTypeCheckMacroTrichotomy.java passed on qemu/unmatched (fastdebug). > - Tier1 passed without new failure on unmacthed (release). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/8 From vkempik at openjdk.org Thu Mar 9 10:22:55 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Thu, 9 Mar 2023 10:22:55 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296602: RISC-V: improve performance of copy_memory stub Message-ID: <3c9iHhPfP8yibC97x_ITeN4n4V_MrfU6b__JLO9KWj4=.6c641fc3-a366-4a48-be25-f8a5e0e32764@github.com> Please review this backport of JDK-8296602 to jdk17u This effectively unrolls copy memory loop offering significant perf improvement on real hw platforms. ( data are the same as in original commit) RISC-V only change, low risc for other platforms. Testing: TBD. thead rvb-ice c910 thead Before ( copy8 only ) Benchmark (size) Mode Cnt Score Error Units ArrayCopyObject.conjoint_micro 31 thrpt 25 6653.095 ? 251.565 ops/ms ArrayCopyObject.conjoint_micro 63 thrpt 25 4933.970 ? 77.559 ops/ms ArrayCopyObject.conjoint_micro 127 thrpt 25 3627.454 ? 34.589 ops/ms ArrayCopyObject.conjoint_micro 2047 thrpt 25 368.249 ? 0.453 ops/ms ArrayCopyObject.conjoint_micro 4095 thrpt 25 187.776 ? 0.306 ops/ms ArrayCopyObject.conjoint_micro 8191 thrpt 25 94.477 ? 0.340 ops/ms after ( with copy32 ) ArrayCopyObject.conjoint_micro 31 thrpt 25 7620.546 ? 69.756 ops/ms ArrayCopyObject.conjoint_micro 63 thrpt 25 6677.978 ? 33.112 ops/ms ArrayCopyObject.conjoint_micro 127 thrpt 25 5206.973 ? 22.612 ops/ms ArrayCopyObject.conjoint_micro 2047 thrpt 25 653.655 ? 31.494 ops/ms ArrayCopyObject.conjoint_micro 4095 thrpt 25 352.905 ? 7.390 ops/ms ArrayCopyObject.conjoint_micro 8191 thrpt 25 165.127 ? 0.832 ops/ms after ( copy32 with dead code elimination and independent addis ) ArrayCopyObject.conjoint_micro 31 thrpt 25 7576.346 ? 94.487 ops/ms ArrayCopyObject.conjoint_micro 63 thrpt 25 6475.730 ? 252.590 ops/ms ArrayCopyObject.conjoint_micro 127 thrpt 25 5221.764 ? 20.415 ops/ms ArrayCopyObject.conjoint_micro 2047 thrpt 25 691.847 ? 1.102 ops/ms ArrayCopyObject.conjoint_micro 4095 thrpt 25 360.269 ? 1.091 ops/ms ArrayCopyObject.conjoint_micro 8191 thrpt 25 179.733 ? 3.012 ops/ms on hifive unmatched: before: Benchmark (size) Mode Cnt Score Error Units ArrayCopyObject.conjoint_micro 31 thrpt 25 5391.575 ? 152.984 ops/ms ArrayCopyObject.conjoint_micro 63 thrpt 25 3700.946 ? 43.175 ops/ms ArrayCopyObject.conjoint_micro 127 thrpt 25 2316.160 ? 24.734 ops/ms ArrayCopyObject.conjoint_micro 2047 thrpt 25 188.616 ? 0.151 ops/ms ArrayCopyObject.conjoint_micro 4095 thrpt 25 95.323 ? 0.053 ops/ms ArrayCopyObject.conjoint_micro 8191 thrpt 25 46.935 ? 0.041 ops/ms after: Benchmark (size) Mode Cnt Score Error Units ArrayCopyObject.conjoint_micro 31 thrpt 25 6136.169 ? 330.409 ops/ms ArrayCopyObject.conjoint_micro 63 thrpt 25 4924.020 ? 78.529 ops/ms ArrayCopyObject.conjoint_micro 127 thrpt 25 3732.561 ? 89.606 ops/ms ArrayCopyObject.conjoint_micro 2047 thrpt 25 431.103 ? 0.505 ops/ms ArrayCopyObject.conjoint_micro 4095 thrpt 25 221.543 ? 0.363 ops/ms ArrayCopyObject.conjoint_micro 8191 thrpt 25 100.586 ? 0.197 ops/ms ------------- Commit messages: - Backport bd57e2138fc980822a149af905e572ab71ccbf11 Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/9/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=9&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296602 Stats: 70 lines in 1 file changed: 41 ins; 1 del; 28 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/9.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/9/head:pull/9 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/9 From dzhang at openjdk.org Thu Mar 9 11:41:34 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 9 Mar 2023 11:41:34 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic Message-ID: <0qSwtkj4j9EEzxcCre9Uf3WDy4sLYx9EAzT1QeZtSgY=.2e4fae46-6a34-4821-b070-7ed42078e199@github.com> Please review this backport to riscv-port-jdk17u. Backport of [JDK-8295926](https://bugs.openjdk.org/browse/JDK-8295926). Applies cleanly. Case test/hotspot/jtreg/compiler/floatingpoint/TestLibmIntrinsics.java failed before this patch. Testing: - test/hotspot/jtreg/compiler/floatingpoint/TestLibmIntrinsics.java passed on qemu and unmatched. - Tier1 passed without new failure on unmacthed (release). ------------- Commit messages: - 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/10/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=10&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295926 Stats: 100 lines in 2 files changed: 95 ins; 4 del; 1 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/10.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/10/head:pull/10 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/10 From fjiang at openjdk.org Thu Mar 9 15:06:52 2023 From: fjiang at openjdk.org (Feilong Jiang) Date: Thu, 9 Mar 2023 15:06:52 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8287552: riscv: Fix comment typo in li64 In-Reply-To: References: Message-ID: The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- On Tue, 7 Mar 2023 07:46:02 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8287552](https://bugs.openjdk.java.net/browse/JDK-8287552). Applies cleanly. > > Testing: > > - Tier1 passed without new failure on unmacthed (release). Marked as reviewed by fjiang (no project role). ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/7 From xlinzheng at openjdk.org Fri Mar 10 03:17:33 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Fri, 10 Mar 2023 03:17:33 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic In-Reply-To: <0qSwtkj4j9EEzxcCre9Uf3WDy4sLYx9EAzT1QeZtSgY=.2e4fae46-6a34-4821-b070-7ed42078e199@github.com> References: <0qSwtkj4j9EEzxcCre9Uf3WDy4sLYx9EAzT1QeZtSgY=.2e4fae46-6a34-4821-b070-7ed42078e199@github.com> Message-ID: <-If5NJKP8a-TqB5_pNQ-0xCL2o3fDH2Ob3WjeP6LdNE=.5c6c1edf-bf73-4c82-a90e-c4037e5c7c2c@github.com> On Thu, 9 Mar 2023 11:33:34 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8295926](https://bugs.openjdk.org/browse/JDK-8295926). Applies cleanly. > Case test/hotspot/jtreg/compiler/floatingpoint/TestLibmIntrinsics.java failed before this patch. > > Testing: > - test/hotspot/jtreg/compiler/floatingpoint/TestLibmIntrinsics.java passed on qemu and unmatched. > - Tier1 passed without new failure on unmacthed (release). Looks good; thank you. ------------- Marked as reviewed by xlinzheng (no project role). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/10 From gcao at openjdk.org Fri Mar 10 06:18:25 2023 From: gcao at openjdk.org (Gui Cao) Date: Fri, 10 Mar 2023 06:18:25 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8287970: riscv: jdk/incubator/vector/*VectorTests failing Message-ID: Please review this backport to riscv-port-jdk17u. Backport of [JDK-8287970](https://bugs.openjdk.org/browse/JDK-8287970). Applies cleanly. Note that the vector operation VectorOperations.BIT_COUNT has not been introduced in this version, so even if the node Op_PopCountVI exists, it will not cause the test case to fail. Also, the node Op_PopCountVL has not been introduced in this version, so there is no need to add this node to the list of unsupported vectors Testing: - test/jdk/jdk/incubator/vector (release/fastdebug on qemu with UseRVV) - Tier1 passed without new failure on unmacthed (release). ------------- Commit messages: - backport 8287970: riscv: jdk/incubator/vector/*VectorTests failing Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/11/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=11&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287970 Stats: 13 lines in 1 file changed: 1 ins; 12 del; 0 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/11.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/11/head:pull/11 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/11 From fjiang at openjdk.org Fri Mar 10 08:52:51 2023 From: fjiang at openjdk.org (Feilong Jiang) Date: Fri, 10 Mar 2023 08:52:51 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8287970: riscv: jdk/incubator/vector/*VectorTests failing In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 06:10:20 GMT, Gui Cao wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8287970](https://bugs.openjdk.org/browse/JDK-8287970). compared with the original patch, there is less to add Op_PopCountVL to the list of unsupported vectors. > > Note that the vector operation VectorOperations.BIT_COUNT has not been introduced in this version, so even if the node Op_PopCountVI exists, it will not cause the test case to fail. Also, the node Op_PopCountVL has not been introduced in this version, so there is no need to add this node to the list of unsupported vectors. > > Testing: > - test/jdk/jdk/incubator/vector (release/fastdebug on qemu with UseRVV) > - Tier1 passed without new failure on unmacthed (release). Marked as reviewed by fjiang (no project role). ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/11 From vkempik at openjdk.org Fri Mar 10 11:16:40 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Fri, 10 Mar 2023 11:16:40 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296602: RISC-V: improve performance of copy_memory stub In-Reply-To: <3c9iHhPfP8yibC97x_ITeN4n4V_MrfU6b__JLO9KWj4=.6c641fc3-a366-4a48-be25-f8a5e0e32764@github.com> References: <3c9iHhPfP8yibC97x_ITeN4n4V_MrfU6b__JLO9KWj4=.6c641fc3-a366-4a48-be25-f8a5e0e32764@github.com> Message-ID: On Thu, 9 Mar 2023 10:15:22 GMT, Vladimir Kempik wrote: > Please review this backport of JDK-8296602 to jdk17u > This effectively unrolls copy memory loop offering significant perf improvement on real hw platforms. ( data are the same as in original commit) > > RISC-V only change, low risc for other platforms. > Testing: TBD. > > thead rvb-ice c910 > thead > > Before ( copy8 only ) > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 6653.095 ? 251.565 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 4933.970 ? 77.559 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 3627.454 ? 34.589 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 368.249 ? 0.453 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 187.776 ? 0.306 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 94.477 ? 0.340 ops/ms > > after ( with copy32 ) > ArrayCopyObject.conjoint_micro 31 thrpt 25 7620.546 ? 69.756 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 6677.978 ? 33.112 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 5206.973 ? 22.612 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 653.655 ? 31.494 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 352.905 ? 7.390 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 165.127 ? 0.832 ops/ms > > after ( copy32 with dead code elimination and independent addis ) > ArrayCopyObject.conjoint_micro 31 thrpt 25 7576.346 ? 94.487 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 6475.730 ? 252.590 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 5221.764 ? 20.415 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 691.847 ? 1.102 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 360.269 ? 1.091 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 179.733 ? 3.012 ops/ms > > on hifive unmatched: > > before: > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 5391.575 ? 152.984 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 3700.946 ? 43.175 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 2316.160 ? 24.734 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 188.616 ? 0.151 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 95.323 ? 0.053 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 46.935 ? 0.041 ops/ms > > after: > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 6136.169 ? 330.409 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 4924.020 ? 78.529 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 3732.561 ? 89.606 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 431.103 ? 0.505 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 221.543 ? 0.363 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 100.586 ? 0.197 ops/ms I have filled https://github.com/openjdk/jdk17u-dev/pull/1200 to have more clean tier1 results ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/9 From vkempik at openjdk.org Fri Mar 10 13:06:42 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Fri, 10 Mar 2023 13:06:42 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296602: RISC-V: improve performance of copy_memory stub In-Reply-To: <3c9iHhPfP8yibC97x_ITeN4n4V_MrfU6b__JLO9KWj4=.6c641fc3-a366-4a48-be25-f8a5e0e32764@github.com> References: <3c9iHhPfP8yibC97x_ITeN4n4V_MrfU6b__JLO9KWj4=.6c641fc3-a366-4a48-be25-f8a5e0e32764@github.com> Message-ID: On Thu, 9 Mar 2023 10:15:22 GMT, Vladimir Kempik wrote: > Please review this backport of JDK-8296602 to jdk17u > This effectively unrolls copy memory loop offering significant perf improvement on real hw platforms. ( data are the same as in original commit) > > RISC-V only change, low risc for other platforms. > Testing: TBD. > > thead rvb-ice c910 > thead > > Before ( copy8 only ) > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 6653.095 ? 251.565 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 4933.970 ? 77.559 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 3627.454 ? 34.589 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 368.249 ? 0.453 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 187.776 ? 0.306 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 94.477 ? 0.340 ops/ms > > after ( with copy32 ) > ArrayCopyObject.conjoint_micro 31 thrpt 25 7620.546 ? 69.756 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 6677.978 ? 33.112 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 5206.973 ? 22.612 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 653.655 ? 31.494 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 352.905 ? 7.390 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 165.127 ? 0.832 ops/ms > > after ( copy32 with dead code elimination and independent addis ) > ArrayCopyObject.conjoint_micro 31 thrpt 25 7576.346 ? 94.487 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 6475.730 ? 252.590 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 5221.764 ? 20.415 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 691.847 ? 1.102 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 360.269 ? 1.091 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 179.733 ? 3.012 ops/ms > > on hifive unmatched: > > before: > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 5391.575 ? 152.984 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 3700.946 ? 43.175 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 2316.160 ? 24.734 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 188.616 ? 0.151 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 95.323 ? 0.053 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 46.935 ? 0.041 ops/ms > > after: > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 6136.169 ? 330.409 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 4924.020 ? 78.529 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 3732.561 ? 89.606 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 431.103 ? 0.505 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 221.543 ? 0.363 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 100.586 ? 0.197 ops/ms Testing looks good, no new failures in tier1, hotspot:tier2 is clean I have created PR for backport of JDK-8292407 to jdk17u, it will significantly reduce the amount of failures in tier1, please merge riscv-port branch with master once this backport is integrated. One strange failure I see before and after the patch is "runtime/8176717/TestInheritFD.java", maybe it's my setup, but unlikely. Ping @RealFYang for integration ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/9 From duke at openjdk.org Sat Mar 11 02:19:27 2023 From: duke at openjdk.org (duke) Date: Sat, 11 Mar 2023 02:19:27 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8287970: riscv: jdk/incubator/vector/*VectorTests failing Message-ID: <60e9a4b0-ed9e-4b11-88a1-baa23e45dd11@openjdk.org> Changeset: b486a8c9 Author: zifeihan Committer: GitHub Date: 2023-03-11 10:17:30 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/b486a8c9c531a4354d88e11c9faf001186daa3c7 8287970: riscv: jdk/incubator/vector/*VectorTests failing ! src/hotspot/cpu/riscv/riscv_v.ad From fyang at openjdk.org Sat Mar 11 02:19:53 2023 From: fyang at openjdk.org (Fei Yang) Date: Sat, 11 Mar 2023 02:19:53 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8287970: riscv: jdk/incubator/vector/*VectorTests failing In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 06:10:20 GMT, Gui Cao wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8287970](https://bugs.openjdk.org/browse/JDK-8287970). compared with the original patch, there is less to add Op_PopCountVL to the list of unsupported vectors. > > Note that the vector operation VectorOperations.BIT_COUNT has not been introduced in this version, so even if the node Op_PopCountVI exists, it will not cause the test case to fail. Also, the node Op_PopCountVL has not been introduced in this version, so there is no need to add this node to the list of unsupported vectors. > > Testing: > - test/jdk/jdk/incubator/vector (release/fastdebug on qemu with UseRVV) > - Tier1 passed without new failure on unmacthed (release). Looks good. ------------- Marked as reviewed by fyang (Committer). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/11 From fyang at openjdk.org Sat Mar 11 02:19:53 2023 From: fyang at openjdk.org (Fei Yang) Date: Sat, 11 Mar 2023 02:19:53 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8287970: riscv: jdk/incubator/vector/*VectorTests failing In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 06:10:20 GMT, Gui Cao wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8287970](https://bugs.openjdk.org/browse/JDK-8287970). compared with the original patch, there is less to add Op_PopCountVL to the list of unsupported vectors. > > Note that the vector operation VectorOperations.BIT_COUNT has not been introduced in this version, so even if the node Op_PopCountVI exists, it will not cause the test case to fail. Also, the node Op_PopCountVL has not been introduced in this version, so there is no need to add this node to the list of unsupported vectors. > > Testing: > - test/jdk/jdk/incubator/vector (release/fastdebug on qemu with UseRVV) > - Tier1 passed without new failure on unmacthed (release). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/11 From duke at openjdk.org Sat Mar 11 02:23:55 2023 From: duke at openjdk.org (duke) Date: Sat, 11 Mar 2023 02:23:55 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic Message-ID: Changeset: 75180c4d Author: Dingli Zhang Committer: GitHub Date: 2023-03-11 10:21:10 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/75180c4db72b7936594c1fe6b80f7153933544b5 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic ! src/hotspot/cpu/riscv/c1_LIRGenerator_riscv.cpp + test/hotspot/jtreg/compiler/floatingpoint/TestLibmIntrinsics.java From fyang at openjdk.org Sat Mar 11 02:25:51 2023 From: fyang at openjdk.org (Fei Yang) Date: Sat, 11 Mar 2023 02:25:51 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic In-Reply-To: <0qSwtkj4j9EEzxcCre9Uf3WDy4sLYx9EAzT1QeZtSgY=.2e4fae46-6a34-4821-b070-7ed42078e199@github.com> References: <0qSwtkj4j9EEzxcCre9Uf3WDy4sLYx9EAzT1QeZtSgY=.2e4fae46-6a34-4821-b070-7ed42078e199@github.com> Message-ID: On Thu, 9 Mar 2023 11:33:34 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8295926](https://bugs.openjdk.org/browse/JDK-8295926). Applies cleanly. > Case test/hotspot/jtreg/compiler/floatingpoint/TestLibmIntrinsics.java failed before this patch. > > Testing: > - test/hotspot/jtreg/compiler/floatingpoint/TestLibmIntrinsics.java passed on qemu and unmatched. > - Tier1 passed without new failure on unmacthed (release). Marked as reviewed by fyang (Committer). ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/10 From fyang at openjdk.org Sat Mar 11 02:25:51 2023 From: fyang at openjdk.org (Fei Yang) Date: Sat, 11 Mar 2023 02:25:51 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic In-Reply-To: <0qSwtkj4j9EEzxcCre9Uf3WDy4sLYx9EAzT1QeZtSgY=.2e4fae46-6a34-4821-b070-7ed42078e199@github.com> References: <0qSwtkj4j9EEzxcCre9Uf3WDy4sLYx9EAzT1QeZtSgY=.2e4fae46-6a34-4821-b070-7ed42078e199@github.com> Message-ID: On Thu, 9 Mar 2023 11:33:34 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8295926](https://bugs.openjdk.org/browse/JDK-8295926). Applies cleanly. > Case test/hotspot/jtreg/compiler/floatingpoint/TestLibmIntrinsics.java failed before this patch. > > Testing: > - test/hotspot/jtreg/compiler/floatingpoint/TestLibmIntrinsics.java passed on qemu and unmatched. > - Tier1 passed without new failure on unmacthed (release). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/10 From fyang at openjdk.org Sat Mar 11 02:29:48 2023 From: fyang at openjdk.org (Fei Yang) Date: Sat, 11 Mar 2023 02:29:48 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296602: RISC-V: improve performance of copy_memory stub In-Reply-To: <3c9iHhPfP8yibC97x_ITeN4n4V_MrfU6b__JLO9KWj4=.6c641fc3-a366-4a48-be25-f8a5e0e32764@github.com> References: <3c9iHhPfP8yibC97x_ITeN4n4V_MrfU6b__JLO9KWj4=.6c641fc3-a366-4a48-be25-f8a5e0e32764@github.com> Message-ID: On Thu, 9 Mar 2023 10:15:22 GMT, Vladimir Kempik wrote: > Please review this backport of JDK-8296602 to jdk17u > This effectively unrolls copy memory loop offering significant perf improvement on real hw platforms. ( data are the same as in original commit) > > RISC-V only change, low risk for other platforms. > Testing: TBD. > > thead rvb-ice c910 > thead > > > Before ( copy8 only ) > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 6653.095 ? 251.565 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 4933.970 ? 77.559 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 3627.454 ? 34.589 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 368.249 ? 0.453 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 187.776 ? 0.306 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 94.477 ? 0.340 ops/ms > > after ( with copy32 ) > ArrayCopyObject.conjoint_micro 31 thrpt 25 7620.546 ? 69.756 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 6677.978 ? 33.112 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 5206.973 ? 22.612 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 653.655 ? 31.494 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 352.905 ? 7.390 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 165.127 ? 0.832 ops/ms > > after ( copy32 with dead code elimination and independent addis ) > ArrayCopyObject.conjoint_micro 31 thrpt 25 7576.346 ? 94.487 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 6475.730 ? 252.590 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 5221.764 ? 20.415 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 691.847 ? 1.102 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 360.269 ? 1.091 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 179.733 ? 3.012 ops/ms > > on hifive unmatched: > > before: > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 5391.575 ? 152.984 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 3700.946 ? 43.175 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 2316.160 ? 24.734 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 188.616 ? 0.151 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 95.323 ? 0.053 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 46.935 ? 0.041 ops/ms > > after: > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 6136.169 ? 330.409 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 4924.020 ? 78.529 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 3732.561 ? 89.606 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 431.103 ? 0.505 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 221.543 ? 0.363 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 100.586 ? 0.197 ops/ms Thanks for filing the upstream backporting to fix the failing tests. I will do a merge once that's integrated. Regarding this performance backporting, I would put off integration for a while after several other nasty bugfixes are backported. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/9 From duke at openjdk.org Sat Mar 11 05:48:56 2023 From: duke at openjdk.org (duke) Date: Sat, 11 Mar 2023 05:48:56 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 10 new changesets Message-ID: <36f751c1-308d-41b7-bed2-6172ad122ea3@openjdk.org> Changeset: ae1a3b4b Author: Goetz Lindenmaier Date: 2023-02-28 11:40:25 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/ae1a3b4b1efc74c9381402b757011cf18467f07a 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316 Reviewed-by: clanger Backport-of: 545ded1a82baf62ef551b2be2a08ee29ab5d9311 ! test/hotspot/jtreg/ProblemList.txt Changeset: 58b479b0 Author: Masanori Yano Committer: Paul Hohensee Date: 2023-02-28 15:26:51 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/58b479b0c5f63cefd5e01dd99b077e44f630e909 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails Reviewed-by: phh Backport-of: 07d24509a68cc06f062b8249f207bc0d2148c79b ! test/jdk/ProblemList.txt ! test/jdk/javax/swing/border/TestTitledBorderLeak.java Changeset: 7b967bf6 Author: Goetz Lindenmaier Date: 2023-03-01 14:47:23 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/7b967bf66f37a671c7db3e0e25e5e00ffdc1c5f8 8290197: test/jdk/java/nio/file/Files/probeContentType/Basic.java fails on some systems for the ".rar" extension Backport-of: 44fb92e2aa8a708b94c568e3d39217cb4c39f6bf ! test/jdk/java/nio/file/Files/probeContentType/Basic.java Changeset: bf513540 Author: Goetz Lindenmaier Date: 2023-03-03 08:45:30 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/bf513540298f7e36a57de767e6fadfdb03d7ea57 8048190: NoClassDefFoundError omits original ExceptionInInitializerError Reviewed-by: phh Backport-of: 464e874a5c6b46fcc729227764d07feb1801314d ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp + test/hotspot/jtreg/runtime/ClassInitErrors/InitExceptionUnloadTest.java Changeset: 181a7bb3 Author: Goetz Lindenmaier Date: 2023-03-03 08:50:37 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/181a7bb31d515ea44439d782db3846d7f209a4ba 8210927: JDB tests do not update source path after doing a redefine class Backport-of: 61ac53f6e5a149c6ec68a8df43106e72bfd1ebb2 ! test/jdk/com/sun/jdi/RedefineTTYLineNumber.java ! test/jdk/com/sun/jdi/lib/jdb/JdbCommand.java ! test/jdk/com/sun/jdi/lib/jdb/JdbTest.java Changeset: fd93a6af Author: Goetz Lindenmaier Date: 2023-03-03 08:52:08 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/fd93a6afd871bcf804b5df1ea24fff788aa45b3a 8284767: Create an automated test for JDK-4422535 Backport-of: 5ae4320921b15dcc198d0c71416cd46e5b5c2f85 + test/jdk/javax/accessibility/SetCurrentAccessibleValueTest.java Changeset: ca049ec2 Author: Goetz Lindenmaier Date: 2023-03-03 08:58:10 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/ca049ec2c6e37abcd389c98c15acac699c6d8447 8284524: Create an automated test for JDK-4422362 Backport-of: b9de0a7556f7be2c6afc6bb41bfa0339b639ff88 + test/jdk/javax/accessibility/MaximumAccessibleValueTest.java Changeset: 9b054a1f Author: Goetz Lindenmaier Date: 2023-03-03 09:03:14 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/9b054a1fafe546495dd209fa927b56ecb3bbc1ca 8289511: Improve test coverage for XPath Axes: child Backport-of: cfe9026fe0506488cc0f0557299cfa585811d194 + test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpChildTest.java Changeset: 1cad49bc Author: Goetz Lindenmaier Date: 2023-03-07 20:46:00 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/1cad49bcd9ea70b3e02ce150e409177eab8851dd 8303433: Bump update version for OpenJDK: jdk-17.0.8 Reviewed-by: rrich ! .jcheck/conf ! make/conf/version-numbers.conf Changeset: 8a432e05 Author: Fei Yang Date: 2023-03-11 10:33:19 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/8a432e05507d22f1bd1366317380d934fa4581b9 Merge branch 'master' into riscv-port From dzhang at openjdk.org Sat Mar 11 10:03:48 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Sat, 11 Mar 2023 10:03:48 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null Message-ID: Please review this backport to riscv-port-jdk17u. Backport of [JDK-8296448](https://bugs.openjdk.org/browse/JDK-8296448). Compared to the original patch, 17u does not have the patches [JDK-8295457](https://bugs.openjdk.org/browse/JDK-8295457) and [JDK-8293290](https://bugs.openjdk.org/browse/JDK-8293290), so some parameters will be slightly different. The same problem was reproduced using the same method as in the original issue: # To suppress the following error report, specify this argument # after -XX: or in .hotspotrc: SuppressErrorAt=/stackValue.cpp:139 # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (/home/zhangdingli/riscv-port-jdk17u/src/hotspot/share/runtime/stackValue.cpp:139), pid=1963135, tid=1963872 # assert(oopDesc::is_oop_or_null(val, false)) failed: bad oop found # # JRE version: OpenJDK Runtime Environment (17.0.7) (fastdebug build 17.0.7-internal+0-adhoc.zhangdingli.riscv-port-jdk17u) # Java VM: OpenJDK 64-Bit Server VM (fastdebug 17.0.7-internal+0-adhoc.zhangdingli.riscv-port-jdk17u, mixed mode, sharing, compressed class ptrs, g1 gc, linux-riscv64) # Problematic frame: # V [libjvm.so+0x12057b0] StackValue::create_stack_value(frame const*, RegisterMap const*, ScopeValue*)+0x9e2 # # No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again # # An error report file with more information is saved as: # /home/zhangdingli/riscv-port-jdk17u/hs_err_pid1963135.log # # If you would like to submit a bug report, please visit: # https://bugreport.java.com/bugreport/crash.jsp # Aborted To reproduce using a cross-compiled build: -XX:-UseCompressedOops -XX:+UseCompressedClassPointers -Xshare:dump -Xlog:cds* -version -XX:-UseCompressedOops -XX:+UseCompressedClassPointers -Xshare:on -XX:-TieredCompilation \ -Xlog:cds* -Xlog:gc+metaspace=info -jar renaissance-gpl-0.14.1.jar -r 1 movie-lens The problem was solved after this patch. Testing: - Tier1 passed without new failure on unmacthed (release). ------------- Commit messages: - 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/12/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=12&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296448 Stats: 52 lines in 8 files changed: 7 ins; 6 del; 39 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/12.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/12/head:pull/12 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/12 From xlinzheng at openjdk.org Sun Mar 12 07:55:43 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Sun, 12 Mar 2023 07:55:43 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null In-Reply-To: References: Message-ID: On Sat, 11 Mar 2023 09:55:47 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8296448](https://bugs.openjdk.org/browse/JDK-8296448). > > Compared to the original patch, 17u does not have the patches [JDK-8295457](https://bugs.openjdk.org/browse/JDK-8295457) and [JDK-8293290](https://bugs.openjdk.org/browse/JDK-8293290), so some parameters will be slightly different. > > The same problem was reproduced using the same method as in the original issue: > > # To suppress the following error report, specify this argument > # after -XX: or in .hotspotrc: SuppressErrorAt=/stackValue.cpp:139 > # > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error (/home/zhangdingli/riscv-port-jdk17u/src/hotspot/share/runtime/stackValue.cpp:139), pid=1963135, tid=1963872 > # assert(oopDesc::is_oop_or_null(val, false)) failed: bad oop found > # > # JRE version: OpenJDK Runtime Environment (17.0.7) (fastdebug build 17.0.7-internal+0-adhoc.zhangdingli.riscv-port-jdk17u) > # Java VM: OpenJDK 64-Bit Server VM (fastdebug 17.0.7-internal+0-adhoc.zhangdingli.riscv-port-jdk17u, mixed mode, sharing, compressed class ptrs, g1 gc, linux-riscv64) > # Problematic frame: > # V [libjvm.so+0x12057b0] StackValue::create_stack_value(frame const*, RegisterMap const*, ScopeValue*)+0x9e2 > # > # No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again > # > # An error report file with more information is saved as: > # /home/zhangdingli/riscv-port-jdk17u/hs_err_pid1963135.log > # > # If you would like to submit a bug report, please visit: > # https://bugreport.java.com/bugreport/crash.jsp > # > Aborted > > To reproduce using a cross-compiled build: > > -XX:-UseCompressedOops -XX:+UseCompressedClassPointers -Xshare:dump -Xlog:cds* -version > -XX:-UseCompressedOops -XX:+UseCompressedClassPointers -Xshare:on -XX:-TieredCompilation \ > -Xlog:cds* -Xlog:gc+metaspace=info -jar renaissance-gpl-0.14.1.jar -r 1 movie-lens > > The problem was solved after this patch. > > Testing: > - Tier1 passed without new failure on unmacthed (release). Looks fine to me. Thank you. ------------- Marked as reviewed by xlinzheng (no project role). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/12 From fyang at openjdk.org Mon Mar 13 02:08:50 2023 From: fyang at openjdk.org (Fei Yang) Date: Mon, 13 Mar 2023 02:08:50 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null In-Reply-To: References: Message-ID: On Sat, 11 Mar 2023 09:55:47 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8296448](https://bugs.openjdk.org/browse/JDK-8296448). > > Compared to the original patch, 17u does not have the patches [JDK-8295457](https://bugs.openjdk.org/browse/JDK-8295457) and [JDK-8293290](https://bugs.openjdk.org/browse/JDK-8293290), so some parameters will be slightly different. > > The same problem was reproduced using the same method as in the original issue: > > # To suppress the following error report, specify this argument > # after -XX: or in .hotspotrc: SuppressErrorAt=/stackValue.cpp:139 > # > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error (/home/zhangdingli/riscv-port-jdk17u/src/hotspot/share/runtime/stackValue.cpp:139), pid=1963135, tid=1963872 > # assert(oopDesc::is_oop_or_null(val, false)) failed: bad oop found > # > # JRE version: OpenJDK Runtime Environment (17.0.7) (fastdebug build 17.0.7-internal+0-adhoc.zhangdingli.riscv-port-jdk17u) > # Java VM: OpenJDK 64-Bit Server VM (fastdebug 17.0.7-internal+0-adhoc.zhangdingli.riscv-port-jdk17u, mixed mode, sharing, compressed class ptrs, g1 gc, linux-riscv64) > # Problematic frame: > # V [libjvm.so+0x12057b0] StackValue::create_stack_value(frame const*, RegisterMap const*, ScopeValue*)+0x9e2 > # > # No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again > # > # An error report file with more information is saved as: > # /home/zhangdingli/riscv-port-jdk17u/hs_err_pid1963135.log > # > # If you would like to submit a bug report, please visit: > # https://bugreport.java.com/bugreport/crash.jsp > # > Aborted > > To reproduce using a cross-compiled build: > > -XX:-UseCompressedOops -XX:+UseCompressedClassPointers -Xshare:dump -Xlog:cds* -version > -XX:-UseCompressedOops -XX:+UseCompressedClassPointers -Xshare:on -XX:-TieredCompilation \ > -Xlog:cds* -Xlog:gc+metaspace=info -jar renaissance-gpl-0.14.1.jar -r 1 movie-lens > > The problem was solved after this patch. > > Testing: > - Tier1 passed without new failure on unmacthed (release). src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 191: > 189: Address src, Register tmp1, Register thread_tmp); > 190: void access_store_at(BasicType type, DecoratorSet decorators, Address dst, > 191: Register val, Register tmp1, Register tmp2, Register tmp3); I think we should not touch 'access_store_at' here? ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/12 From dzhang at openjdk.org Mon Mar 13 04:06:21 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Mon, 13 Mar 2023 04:06:21 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null [v2] In-Reply-To: References: Message-ID: <8p7m5f14NivC4yNBrRokyftNpuzxGw0CqBMeM9PPc2U=.b9633fee-f0e4-4111-993e-db79365aedef@github.com> > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8296448](https://bugs.openjdk.org/browse/JDK-8296448). > > Compared to the original patch, 17u does not have the patches [JDK-8295457](https://bugs.openjdk.org/browse/JDK-8295457) and [JDK-8293290](https://bugs.openjdk.org/browse/JDK-8293290), so some parameters will be slightly different. > > The same problem was reproduced using the same method as in the original issue: > > # To suppress the following error report, specify this argument > # after -XX: or in .hotspotrc: SuppressErrorAt=/stackValue.cpp:139 > # > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error (/home/zhangdingli/riscv-port-jdk17u/src/hotspot/share/runtime/stackValue.cpp:139), pid=1963135, tid=1963872 > # assert(oopDesc::is_oop_or_null(val, false)) failed: bad oop found > # > # JRE version: OpenJDK Runtime Environment (17.0.7) (fastdebug build 17.0.7-internal+0-adhoc.zhangdingli.riscv-port-jdk17u) > # Java VM: OpenJDK 64-Bit Server VM (fastdebug 17.0.7-internal+0-adhoc.zhangdingli.riscv-port-jdk17u, mixed mode, sharing, compressed class ptrs, g1 gc, linux-riscv64) > # Problematic frame: > # V [libjvm.so+0x12057b0] StackValue::create_stack_value(frame const*, RegisterMap const*, ScopeValue*)+0x9e2 > # > # No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again > # > # An error report file with more information is saved as: > # /home/zhangdingli/riscv-port-jdk17u/hs_err_pid1963135.log > # > # If you would like to submit a bug report, please visit: > # https://bugreport.java.com/bugreport/crash.jsp > # > Aborted > > To reproduce using a cross-compiled build: > > -XX:-UseCompressedOops -XX:+UseCompressedClassPointers -Xshare:dump -Xlog:cds* -version > -XX:-UseCompressedOops -XX:+UseCompressedClassPointers -Xshare:on -XX:-TieredCompilation \ > -Xlog:cds* -Xlog:gc+metaspace=info -jar renaissance-gpl-0.14.1.jar -r 1 movie-lens > > The problem was solved after this patch. > > Testing: > - Tier1 passed without new failure on unmacthed (release). Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: Fix the access_store_at parameter ------------- Changes: - all: https://git.openjdk.org/riscv-port-jdk17u/pull/12/files - new: https://git.openjdk.org/riscv-port-jdk17u/pull/12/files/33abdfd4..cc9d3f5c Webrevs: - full: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=12&range=01 - incr: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=12&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/12.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/12/head:pull/12 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/12 From dzhang at openjdk.org Mon Mar 13 04:06:23 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Mon, 13 Mar 2023 04:06:23 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null [v2] In-Reply-To: References:

Message-ID: <9EFlxhsCzzTi31j-WLi88j96-X-TWmLHfst4yr70GRI=.28b8fd55-2386-428e-9910-9bbb01f67b58@github.com> On Mon, 13 Mar 2023 02:05:47 GMT, Fei Yang wrote: >> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix the access_store_at parameter > > src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 191: > >> 189: Address src, Register tmp1, Register thread_tmp); >> 190: void access_store_at(BasicType type, DecoratorSet decorators, Address dst, >> 191: Register val, Register tmp1, Register tmp2, Register tmp3); > > I think we should not touch 'access_store_at' here? Oh sorry, I confused the other branches here when rebase. By the way, the correct code was used when testing. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/12 From fyang at openjdk.org Mon Mar 13 07:04:55 2023 From: fyang at openjdk.org (Fei Yang) Date: Mon, 13 Mar 2023 07:04:55 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null [v2] In-Reply-To: <8p7m5f14NivC4yNBrRokyftNpuzxGw0CqBMeM9PPc2U=.b9633fee-f0e4-4111-993e-db79365aedef@github.com> References: <8p7m5f14NivC4yNBrRokyftNpuzxGw0CqBMeM9PPc2U=.b9633fee-f0e4-4111-993e-db79365aedef@github.com> Message-ID: On Mon, 13 Mar 2023 04:06:21 GMT, Dingli Zhang wrote: >> Please review this backport to riscv-port-jdk17u. >> Backport of [JDK-8296448](https://bugs.openjdk.org/browse/JDK-8296448). >> >> Compared to the original patch, 17u does not have the patches [JDK-8295457](https://bugs.openjdk.org/browse/JDK-8295457) and [JDK-8293290](https://bugs.openjdk.org/browse/JDK-8293290), so some parameters will be slightly different. >> >> The same problem was reproduced using the same method as in the original issue: >> >> # To suppress the following error report, specify this argument >> # after -XX: or in .hotspotrc: SuppressErrorAt=/stackValue.cpp:139 >> # >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error (/home/zhangdingli/riscv-port-jdk17u/src/hotspot/share/runtime/stackValue.cpp:139), pid=1963135, tid=1963872 >> # assert(oopDesc::is_oop_or_null(val, false)) failed: bad oop found >> # >> # JRE version: OpenJDK Runtime Environment (17.0.7) (fastdebug build 17.0.7-internal+0-adhoc.zhangdingli.riscv-port-jdk17u) >> # Java VM: OpenJDK 64-Bit Server VM (fastdebug 17.0.7-internal+0-adhoc.zhangdingli.riscv-port-jdk17u, mixed mode, sharing, compressed class ptrs, g1 gc, linux-riscv64) >> # Problematic frame: >> # V [libjvm.so+0x12057b0] StackValue::create_stack_value(frame const*, RegisterMap const*, ScopeValue*)+0x9e2 >> # >> # No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again >> # >> # An error report file with more information is saved as: >> # /home/zhangdingli/riscv-port-jdk17u/hs_err_pid1963135.log >> # >> # If you would like to submit a bug report, please visit: >> # https://bugreport.java.com/bugreport/crash.jsp >> # >> Aborted >> >> To reproduce using a cross-compiled build: >> >> -XX:-UseCompressedOops -XX:+UseCompressedClassPointers -Xshare:dump -Xlog:cds* -version >> -XX:-UseCompressedOops -XX:+UseCompressedClassPointers -Xshare:on -XX:-TieredCompilation \ >> -Xlog:cds* -Xlog:gc+metaspace=info -jar renaissance-gpl-0.14.1.jar -r 1 movie-lens >> >> The problem was solved after this patch. >> >> Testing: >> - Tier1 passed without new failure on unmacthed (release). > > Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: > > Fix the access_store_at parameter Updated change looks good. Thanks. ------------- Marked as reviewed by fyang (Committer). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/12 From fyang at openjdk.org Mon Mar 13 07:04:55 2023 From: fyang at openjdk.org (Fei Yang) Date: Mon, 13 Mar 2023 07:04:55 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null In-Reply-To: References: Message-ID: On Sat, 11 Mar 2023 09:55:47 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8296448](https://bugs.openjdk.org/browse/JDK-8296448). > > Compared to the original patch, 17u does not have the patches [JDK-8295457](https://bugs.openjdk.org/browse/JDK-8295457) and [JDK-8293290](https://bugs.openjdk.org/browse/JDK-8293290), so some parameters will be slightly different. > > The same problem was reproduced using the same method as in the original issue: > > # To suppress the following error report, specify this argument > # after -XX: or in .hotspotrc: SuppressErrorAt=/stackValue.cpp:139 > # > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error (/home/zhangdingli/riscv-port-jdk17u/src/hotspot/share/runtime/stackValue.cpp:139), pid=1963135, tid=1963872 > # assert(oopDesc::is_oop_or_null(val, false)) failed: bad oop found > # > # JRE version: OpenJDK Runtime Environment (17.0.7) (fastdebug build 17.0.7-internal+0-adhoc.zhangdingli.riscv-port-jdk17u) > # Java VM: OpenJDK 64-Bit Server VM (fastdebug 17.0.7-internal+0-adhoc.zhangdingli.riscv-port-jdk17u, mixed mode, sharing, compressed class ptrs, g1 gc, linux-riscv64) > # Problematic frame: > # V [libjvm.so+0x12057b0] StackValue::create_stack_value(frame const*, RegisterMap const*, ScopeValue*)+0x9e2 > # > # No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again > # > # An error report file with more information is saved as: > # /home/zhangdingli/riscv-port-jdk17u/hs_err_pid1963135.log > # > # If you would like to submit a bug report, please visit: > # https://bugreport.java.com/bugreport/crash.jsp > # > Aborted > > To reproduce using a cross-compiled build: > > -XX:-UseCompressedOops -XX:+UseCompressedClassPointers -Xshare:dump -Xlog:cds* -version > -XX:-UseCompressedOops -XX:+UseCompressedClassPointers -Xshare:on -XX:-TieredCompilation \ > -Xlog:cds* -Xlog:gc+metaspace=info -jar renaissance-gpl-0.14.1.jar -r 1 movie-lens > > The problem was solved after this patch. > > Testing: > - Tier1 passed without new failure on unmacthed (release). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/12 From duke at openjdk.org Mon Mar 13 07:11:48 2023 From: duke at openjdk.org (duke) Date: Mon, 13 Mar 2023 07:11:48 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null Message-ID: <30b6009f-223b-4417-9e9c-86fe0e5d2f52@openjdk.org> Changeset: 319154c4 Author: Dingli Zhang Committer: GitHub Date: 2023-03-13 15:02:40 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/319154c477e25c16521ab435eec429c76e065df9 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null ! src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp ! src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.hpp ! src/hotspot/cpu/riscv/methodHandles_riscv.cpp ! src/hotspot/cpu/riscv/riscv.ad ! src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp ! src/hotspot/cpu/riscv/stubGenerator_riscv.cpp From vkempik at openjdk.org Mon Mar 13 07:28:46 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Mon, 13 Mar 2023 07:28:46 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296602: RISC-V: improve performance of copy_memory stub In-Reply-To: References: <3c9iHhPfP8yibC97x_ITeN4n4V_MrfU6b__JLO9KWj4=.6c641fc3-a366-4a48-be25-f8a5e0e32764@github.com> Message-ID: On Sat, 11 Mar 2023 02:26:46 GMT, Fei Yang wrote: >> Please review this backport of JDK-8296602 to jdk17u >> This effectively unrolls copy memory loop offering significant perf improvement on real hw platforms. ( data are the same as in original commit) >> >> RISC-V only change, low risk for other platforms. >> Testing: TBD. >> >> thead rvb-ice c910 >> thead >> >> >> Before ( copy8 only ) >> Benchmark (size) Mode Cnt Score Error Units >> ArrayCopyObject.conjoint_micro 31 thrpt 25 6653.095 ? 251.565 ops/ms >> ArrayCopyObject.conjoint_micro 63 thrpt 25 4933.970 ? 77.559 ops/ms >> ArrayCopyObject.conjoint_micro 127 thrpt 25 3627.454 ? 34.589 ops/ms >> ArrayCopyObject.conjoint_micro 2047 thrpt 25 368.249 ? 0.453 ops/ms >> ArrayCopyObject.conjoint_micro 4095 thrpt 25 187.776 ? 0.306 ops/ms >> ArrayCopyObject.conjoint_micro 8191 thrpt 25 94.477 ? 0.340 ops/ms >> >> after ( with copy32 ) >> ArrayCopyObject.conjoint_micro 31 thrpt 25 7620.546 ? 69.756 ops/ms >> ArrayCopyObject.conjoint_micro 63 thrpt 25 6677.978 ? 33.112 ops/ms >> ArrayCopyObject.conjoint_micro 127 thrpt 25 5206.973 ? 22.612 ops/ms >> ArrayCopyObject.conjoint_micro 2047 thrpt 25 653.655 ? 31.494 ops/ms >> ArrayCopyObject.conjoint_micro 4095 thrpt 25 352.905 ? 7.390 ops/ms >> ArrayCopyObject.conjoint_micro 8191 thrpt 25 165.127 ? 0.832 ops/ms >> >> after ( copy32 with dead code elimination and independent addis ) >> ArrayCopyObject.conjoint_micro 31 thrpt 25 7576.346 ? 94.487 ops/ms >> ArrayCopyObject.conjoint_micro 63 thrpt 25 6475.730 ? 252.590 ops/ms >> ArrayCopyObject.conjoint_micro 127 thrpt 25 5221.764 ? 20.415 ops/ms >> ArrayCopyObject.conjoint_micro 2047 thrpt 25 691.847 ? 1.102 ops/ms >> ArrayCopyObject.conjoint_micro 4095 thrpt 25 360.269 ? 1.091 ops/ms >> ArrayCopyObject.conjoint_micro 8191 thrpt 25 179.733 ? 3.012 ops/ms >> >> on hifive unmatched: >> >> before: >> Benchmark (size) Mode Cnt Score Error Units >> ArrayCopyObject.conjoint_micro 31 thrpt 25 5391.575 ? 152.984 ops/ms >> ArrayCopyObject.conjoint_micro 63 thrpt 25 3700.946 ? 43.175 ops/ms >> ArrayCopyObject.conjoint_micro 127 thrpt 25 2316.160 ? 24.734 ops/ms >> ArrayCopyObject.conjoint_micro 2047 thrpt 25 188.616 ? 0.151 ops/ms >> ArrayCopyObject.conjoint_micro 4095 thrpt 25 95.323 ? 0.053 ops/ms >> ArrayCopyObject.conjoint_micro 8191 thrpt 25 46.935 ? 0.041 ops/ms >> >> after: >> Benchmark (size) Mode Cnt Score Error Units >> ArrayCopyObject.conjoint_micro 31 thrpt 25 6136.169 ? 330.409 ops/ms >> ArrayCopyObject.conjoint_micro 63 thrpt 25 4924.020 ? 78.529 ops/ms >> ArrayCopyObject.conjoint_micro 127 thrpt 25 3732.561 ? 89.606 ops/ms >> ArrayCopyObject.conjoint_micro 2047 thrpt 25 431.103 ? 0.505 ops/ms >> ArrayCopyObject.conjoint_micro 4095 thrpt 25 221.543 ? 0.363 ops/ms >> ArrayCopyObject.conjoint_micro 8191 thrpt 25 100.586 ? 0.197 ops/ms > > Thanks for filing the upstream backporting to fix the failing tests. I will do a merge once that's integrated. > Regarding this performance backporting, I would put off integration for a while after several other nasty bugs are fixed. @RealFYang , it's integrated ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/9 From duke at openjdk.org Mon Mar 13 07:45:19 2023 From: duke at openjdk.org (duke) Date: Mon, 13 Mar 2023 07:45:19 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 2 new changesets Message-ID: Changeset: 1ad9e684 Author: Vladimir Kempik Date: 2023-03-13 07:23:30 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/1ad9e6843ab54dbd16631474969986c1de87dd9b 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures Backport-of: 6e6202c14d0f6dd26369f21883ff317057aa469f ! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestBoolean.java ! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestByte.java ! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestChar.java ! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestDouble.java ! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestFloat.java ! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestInt.java ! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestLong.java ! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestObject.java ! test/hotspot/jtreg/compiler/unsafe/JdkInternalMiscUnsafeAccessTestShort.java ! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestBoolean.java ! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestByte.java ! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestChar.java ! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestDouble.java ! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestFloat.java ! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestInt.java ! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestLong.java ! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestObject.java ! test/hotspot/jtreg/compiler/unsafe/SunMiscUnsafeAccessTestShort.java ! test/hotspot/jtreg/compiler/unsafe/X-UnsafeAccessTest.java.template ! test/jdk/java/lang/invoke/VarHandles/VarHandleBaseTest.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessBoolean.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessByte.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessChar.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessDouble.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessFloat.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessInt.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessLong.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessShort.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessString.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsDouble.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsFloat.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsLong.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessBoolean.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessByte.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessChar.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessDouble.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessFloat.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessInt.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessLong.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessShort.java ! test/jdk/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessString.java ! test/jdk/java/lang/invoke/VarHandles/X-VarHandleTestAccess.java.template ! test/jdk/java/lang/invoke/VarHandles/X-VarHandleTestByteArrayView.java.template ! test/jdk/java/lang/invoke/VarHandles/X-VarHandleTestMethodHandleAccess.java.template Changeset: 6b761ef1 Author: Fei Yang Date: 2023-03-13 15:35:19 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/6b761ef12d4b7a574c404d7c5a3de9016cbfb13b Merge branch 'master' into riscv-port From dzhang at openjdk.org Wed Mar 15 00:43:57 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 15 Mar 2023 00:43:57 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space Message-ID: Please review this backport to riscv-port-jdk17u. Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893). The original patch cannot be directly applied because of the line number, but there are no other additional changes. Testing: - Tier1 passed without new failure on unmacthed (release). ------------- Commit messages: - 8291893: riscv: remove fence.i used in user space Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/13/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=13&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291893 Stats: 77 lines in 10 files changed: 8 ins; 63 del; 6 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/13.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/13/head:pull/13 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/13 From fjiang at openjdk.org Wed Mar 15 01:11:37 2023 From: fjiang at openjdk.org (Feilong Jiang) Date: Wed, 15 Mar 2023 01:11:37 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 00:37:21 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893). > > The original patch cannot be directly applied because of the line number, but there are no other additional changes. > > Testing: > - Tier1 passed without new failure on unmacthed (release). Looks good. ------------- Marked as reviewed by fjiang (no project role). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/13 From xlinzheng at openjdk.org Wed Mar 15 05:01:41 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Wed, 15 Mar 2023 05:01:41 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops Message-ID: May be not clean, for we do not have `C2CodeStub`. Tested hotspot tier1~2 (fastdebug); other tiers are on the way. ------------- Commit messages: - 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/14/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=14&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294087 Stats: 29 lines in 8 files changed: 25 ins; 0 del; 4 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/14.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/14/head:pull/14 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/14 From vkempik at openjdk.org Wed Mar 15 06:16:49 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Wed, 15 Mar 2023 06:16:49 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 00:37:21 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893). > > The original patch cannot be directly applied because of the line number, but there are no other additional changes. > > Testing: > - Tier1 passed without new failure on unmacthed (release). Marked as reviewed by vkempik (Reviewer). ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/13 From gcao at openjdk.org Thu Mar 16 03:18:38 2023 From: gcao at openjdk.org (Gui Cao) Date: Thu, 16 Mar 2023 03:18:38 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8291947: riscv: fail to build after JDK-8290840 Message-ID: Please review this backport to riscv-port-jdk17u. Backport of [JDK-8291947](https://bugs.openjdk.org/browse/JDK-8291947). In the current version, https://bugs.openjdk.org/browse/JDK-8290840 has not been refactored, so the issues corresponding to the original issue do not exist. compared to the original patch, the icache_flush function is removed in a different location. Testing: - Tier1 passed without new failure on unmacthed (release). ------------- Commit messages: - 8291947: riscv: fail to build after JDK-8290840 Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/15/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=15&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291947 Stats: 20 lines in 2 files changed: 0 ins; 19 del; 1 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/15.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/15/head:pull/15 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/15 From xlinzheng at openjdk.org Thu Mar 16 04:46:46 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Thu, 16 Mar 2023 04:46:46 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path Message-ID: This is another-half backport (RISC-V part only) of [JDK-8287425](https://bugs.openjdk.org/browse/JDK-8287425). The original patch is at [1]. This patch can interestingly fix an issue with async-profiler [2], and has been backported to JDK17/JDK11u. But when backporting to JDK17, the RISC-V part of this patch was dropped [3] since we did not have the RISC-V backend. Now that we have the RISC-V port of JDK17, the missing part needs a backport as well. Tested on unmatched, hotspot tier1~2 (fastdebug). More tiers are on the way. [1] https://github.com/openjdk/jdk/commit/b5a646ee6cfd432cef6b7e69a177959227a38ace [2] https://github.com/jvm-profiling-tools/async-profiler/issues/673#issuecomment-1316738564 [3] https://github.com/openjdk/jdk17u-dev/pull/672 ------------- Commit messages: - 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/16/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=16&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287425 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/16.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/16/head:pull/16 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/16 From fyang at openjdk.org Thu Mar 16 06:19:49 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 16 Mar 2023 06:19:49 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path In-Reply-To: References: Message-ID: <9SqM-785a4JKEiS_EbK8oCCr1MP0M6IswKn_wxbfh_c=.a485ed57-0e65-4957-b4fc-f025eaf42c95@github.com> On Thu, 16 Mar 2023 04:34:39 GMT, Xiaolin Zheng wrote: > This is another-half backport (RISC-V part only) of [JDK-8287425](https://bugs.openjdk.org/browse/JDK-8287425). The original patch is at [1]. > > This patch can interestingly fix an issue with async-profiler [2], and has been backported to JDK17/JDK11u. But when backporting to JDK17, the RISC-V part of this patch was dropped [3] since we did not have the RISC-V backend. Now that we have the RISC-V port of JDK17, the missing part needs a backport as well. > > Tested on unmatched, hotspot tier1~2 (fastdebug). More tiers are on the way. > > [1] https://github.com/openjdk/jdk/commit/b5a646ee6cfd432cef6b7e69a177959227a38ace > [2] https://github.com/jvm-profiling-tools/async-profiler/issues/673#issuecomment-1316738564 > [3] https://github.com/openjdk/jdk17u-dev/pull/672 Looks fine. Thanks. ------------- Marked as reviewed by fyang (Committer). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/16 From fyang at openjdk.org Thu Mar 16 06:19:49 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 16 Mar 2023 06:19:49 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 04:34:39 GMT, Xiaolin Zheng wrote: > This is another-half backport (RISC-V part only) of [JDK-8287425](https://bugs.openjdk.org/browse/JDK-8287425). The original patch is at [1]. > > This patch can interestingly fix an issue with async-profiler [2], and has been backported to JDK17/JDK11u. But when backporting to JDK17, the RISC-V part of this patch was dropped [3] since we did not have the RISC-V backend. Now that we have the RISC-V port of JDK17, the missing part needs a backport as well. > > Tested on unmatched, hotspot tier1~2 (fastdebug). More tiers are on the way. > > [1] https://github.com/openjdk/jdk/commit/b5a646ee6cfd432cef6b7e69a177959227a38ace > [2] https://github.com/jvm-profiling-tools/async-profiler/issues/673#issuecomment-1316738564 > [3] https://github.com/openjdk/jdk17u-dev/pull/672 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/16 From duke at openjdk.org Thu Mar 16 06:25:15 2023 From: duke at openjdk.org (duke) Date: Thu, 16 Mar 2023 06:25:15 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path Message-ID: Changeset: d2025abd Author: zhengxiaolinX Committer: GitHub Date: 2023-03-16 14:16:08 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/d2025abd01fed9bed05d615ddcd88aa1f6f84925 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path Co-authored-by: Wei Kuai ! src/hotspot/cpu/riscv/macroAssembler_riscv.cpp From vkempik at openjdk.org Thu Mar 16 06:28:48 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Thu, 16 Mar 2023 06:28:48 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8291947: riscv: fail to build after JDK-8290840 In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 03:10:55 GMT, Gui Cao wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8291947](https://bugs.openjdk.org/browse/JDK-8291947). > In the current version, https://bugs.openjdk.org/browse/JDK-8290840 has not been refactored, so the issues corresponding to the original issue do not exist. compared to the original patch, the icache_flush function is removed in a different location. > > Testing: > - Tier1 passed without new failure on unmacthed (release). Looks good ------------- Marked as reviewed by vkempik (Reviewer). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/15 From fyang at openjdk.org Thu Mar 16 07:07:54 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 16 Mar 2023 07:07:54 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops In-Reply-To: References: Message-ID: <-rpobEvnLNxuqcvvBtbeHxbuONtBDwDQIUhWY1r2Q-o=.e696c03e-bbb9-4eb2-a07a-030c197069a6@github.com> On Wed, 15 Mar 2023 04:54:10 GMT, Xiaolin Zheng wrote: > May be not clean, for we do not have `C2CodeStub`. > > Tested hotspot tier1~2 (fastdebug); other tiers are on the way. Looks good. ------------- Marked as reviewed by fyang (Committer). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/14 From fyang at openjdk.org Thu Mar 16 07:07:54 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 16 Mar 2023 07:07:54 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops In-Reply-To: References: Message-ID: <4DPrcRDJvsQv2ej6V_f-ohkD0XOWvOKHpFKGavw4KFc=.cfccb28a-42a3-48dc-aaff-cd32a05e7428@github.com> On Wed, 15 Mar 2023 04:54:10 GMT, Xiaolin Zheng wrote: > May be not clean, for we do not have `C2CodeStub`. > > Tested hotspot tier1~2 (fastdebug); other tiers are on the way. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/14 From duke at openjdk.org Thu Mar 16 07:13:00 2023 From: duke at openjdk.org (duke) Date: Thu, 16 Mar 2023 07:13:00 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops Message-ID: <6f3d858d-24fc-4056-8108-1be07e406e8b@openjdk.org> Changeset: 529c6a36 Author: zhengxiaolinX Committer: GitHub Date: 2023-03-16 15:05:50 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/529c6a36c737a2ca90bef8862c76f666a3c48e75 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops ! src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp ! src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.hpp ! src/hotspot/cpu/riscv/nativeInst_riscv.cpp ! src/hotspot/cpu/riscv/riscv.ad ! src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp From fyang at openjdk.org Thu Mar 16 07:21:52 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 16 Mar 2023 07:21:52 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8291947: riscv: fail to build after JDK-8290840 In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 03:10:55 GMT, Gui Cao wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8291947](https://bugs.openjdk.org/browse/JDK-8291947). > In the current version, https://bugs.openjdk.org/browse/JDK-8290840 has not been refactored, so the issues corresponding to the original issue do not exist. compared to the original patch, the icache_flush function is removed in a different location. > > Testing: > - Tier1 passed without new failure on unmacthed (release). Looks OK. ------------- Marked as reviewed by fyang (Committer). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/15 From fyang at openjdk.org Thu Mar 16 07:21:52 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 16 Mar 2023 07:21:52 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8291947: riscv: fail to build after JDK-8290840 In-Reply-To: References: Message-ID: <6dZNJLWbCCxtgWiHkhzBmmyVOenR-4AUdk2qwg8OGqY=.e2210cdd-dac1-4c31-96e4-d709b1eae230@github.com> On Thu, 16 Mar 2023 03:10:55 GMT, Gui Cao wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8291947](https://bugs.openjdk.org/browse/JDK-8291947). > In the current version, https://bugs.openjdk.org/browse/JDK-8290840 has not been refactored, so the issues corresponding to the original issue do not exist. compared to the original patch, the icache_flush function is removed in a different location. > > Testing: > - Tier1 passed without new failure on unmacthed (release). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/15 From duke at openjdk.org Thu Mar 16 07:29:24 2023 From: duke at openjdk.org (duke) Date: Thu, 16 Mar 2023 07:29:24 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8291947: riscv: fail to build after JDK-8290840 Message-ID: <3e289647-feba-4d28-9b94-130cbc87291b@openjdk.org> Changeset: 7e9e30d9 Author: zifeihan Committer: GitHub Date: 2023-03-16 15:19:17 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/7e9e30d900209858f749067753c2e9d82a4a7b02 8291947: riscv: fail to build after JDK-8290840 ! src/hotspot/cpu/riscv/icache_riscv.cpp ! src/hotspot/os_cpu/linux_riscv/os_linux_riscv.hpp From fyang at openjdk.org Thu Mar 16 07:43:56 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 16 Mar 2023 07:43:56 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v2] In-Reply-To: References: <9PlQbOvwFAwNUY2gj2-y72AKcncEvd-QKvGQl7KM-gs=.c0cdb3a8-dc09-4b7e-9f81-1ab280b2ea7e@github.com> Message-ID: <3wUf_XVlpCqByQ9TlfwFdDu8o2z5Eg0Y1vpMyRuj1rg=.28d4cbe2-0261-4aa8-802d-1e1a5b9b2dd7@github.com> On Sat, 18 Feb 2023 03:47:54 GMT, Yadong Wang wrote: >> This PR backports the implementation of RISC-V port into jdk17u. >> >> It based on the initial implementation of JEP-422 with some modifications for jdk17u: >> 1. The initial patch >> 8276799: Implementation of JEP 422: Linux/RISC-V Port >> 2. remove features that do not belong to jdk17u >> revert 8277417: C1 LIR instruction for load-klass >> revert 8278387: Implement UseHeavyMonitors consistently >> revert 8227369: pd_disjoint_words_atomic() needs to be atomic >> revert 8258192: Obsolete the CriticalNatives flag >> revert 8281632: riscv: Improve interpreter stack banging >> revert 8283364: Intrinsify countPositives >> 3. add features that belongs to jdk17u >> enable the biased locking >> 4. Wrap modifications to shared code under RISCV and revert changes to other platforms >> isolate modification to other platforms >> 5. Patches for making compilation pass >> 8282306: os::is_first_C_frame(frame*) crashes on invalid link access >> 8282477: vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler > > Yadong Wang has updated the pull request incrementally with one additional commit since the last revision: > > fix indentation NOTE: Fix for [JDK-8284068](https://bugs.openjdk.org/browse/JDK-8284068) (https://git.openjdk.java.net/jdk/pull/8055) is also contained in this backport PR. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/1 From dzhang at openjdk.org Thu Mar 16 08:15:33 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 16 Mar 2023 08:15:33 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space [v2] In-Reply-To: References: Message-ID: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893). > > The original patch cannot be directly applied because of the line number, but there are no other additional changes. > > Testing: > - Tier1 passed without new failure on unmacthed (release). Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: rebase ------------- Changes: - all: https://git.openjdk.org/riscv-port-jdk17u/pull/13/files - new: https://git.openjdk.org/riscv-port-jdk17u/pull/13/files/0bec4f0a..31aee659 Webrevs: - full: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=13&range=01 - incr: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=13&range=00-01 Stats: 9 lines in 1 file changed: 0 ins; 8 del; 1 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/13.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/13/head:pull/13 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/13 From dzhang at openjdk.org Thu Mar 16 08:26:52 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 16 Mar 2023 08:26:52 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space [v3] In-Reply-To: References: Message-ID: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893). > > The original patch cannot be directly applied because of the line number, but there are no other additional changes. > > Testing: > - Tier1 passed without new failure on unmacthed (release). Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'riscv-port' into backport-JDK-8291893 - rebase - 8291893: riscv: remove fence.i used in user space ------------- Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/13/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=13&range=02 Stats: 77 lines in 10 files changed: 8 ins; 63 del; 6 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/13.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/13/head:pull/13 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/13 From fyang at openjdk.org Thu Mar 16 08:38:09 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 16 Mar 2023 08:38:09 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space [v3] In-Reply-To: References:

Message-ID: On Thu, 16 Mar 2023 08:26:52 GMT, Dingli Zhang wrote: >> Please review this backport to riscv-port-jdk17u. >> Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893). >> >> The original patch cannot be directly applied because of the line number, but there are no other additional changes. >> >> Testing: >> - Tier1 passed without new failure on unmacthed (release). > > Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: > > - Merge branch 'riscv-port' into backport-JDK-8291893 > - rebase > - 8291893: riscv: remove fence.i used in user space Looks good. ------------- Marked as reviewed by fyang (Committer). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/13 From fyang at openjdk.org Thu Mar 16 08:38:11 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 16 Mar 2023 08:38:11 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8291893: riscv: remove fence.i used in user space In-Reply-To: References: Message-ID: <-laea_44i-puH85c7pQ6AQRGv6YmLqXGdEjU-zJ_N5I=.bec91be4-d670-4b2e-9c7b-8791f49a76c6@github.com> On Wed, 15 Mar 2023 00:37:21 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893). > > The original patch cannot be directly applied because of the line number, but there are no other additional changes. > > Testing: > - Tier1 passed without new failure on unmacthed (release). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/13 From duke at openjdk.org Thu Mar 16 08:50:52 2023 From: duke at openjdk.org (duke) Date: Thu, 16 Mar 2023 08:50:52 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8291893: riscv: remove fence.i used in user spac Message-ID: Changeset: 7ca0b844 Author: Dingli Zhang Committer: GitHub Date: 2023-03-16 16:35:13 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/7ca0b8442fe8aa0a753e556b8951a09cd1a815d1 8291893: riscv: remove fence.i used in user spac ! src/hotspot/cpu/riscv/assembler_riscv.cpp ! src/hotspot/cpu/riscv/assembler_riscv.hpp ! src/hotspot/cpu/riscv/compiledIC_riscv.cpp ! src/hotspot/cpu/riscv/globals_riscv.hpp ! src/hotspot/cpu/riscv/icache_riscv.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.hpp ! src/hotspot/cpu/riscv/nativeInst_riscv.hpp ! src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp ! src/hotspot/os_cpu/linux_riscv/orderAccess_linux_riscv.hpp From vladimir.kempik at gmail.com Fri Mar 17 10:50:19 2023 From: vladimir.kempik at gmail.com (Vladimir Kempik) Date: Fri, 17 Mar 2023 13:50:19 +0300 Subject: Missaligned memory accesses from JDK Message-ID: <29875E09-8B1E-4255-AAED-06305459C872@gmail.com> Hello Continuing on misaligned memory accesses from JDK. Hearing no news from Yadong's team [4], I have decided to take a look myself. I have an fpga with risc-v cores, in this config it has no support for misaligned loads/stores. When such memory access happens, it leads to trap and then the M-mode emulator is used ( very similar to opensbi) Also I have two perf counters - trp_lam/trp_sam (for misaligned loads and stores resp.) Using them and perfasm.jar I can track every misaligned access. I have started with the patch from Xiaolin Zheng (which fixes misaligned memory access when writing/reading instructions), that completely removed trp_sam events, but trp_lam was mostly unaffected. Using perfasm.jar I have found the rest of trp_lam to originate from Template Interpreter's generated code. Here is numbers on current jdk21-dev (without Xiaolin's patch) java -Xint -version 239163 trp_lam 16289 trp_sam 5.602736519 seconds time elapsed 5.260201000 seconds user Total executed instructions - 380M 1:1600 (trp_lam:total) - pretty high ration. I was able to identify and fix all of them (also applying Xiaolin's patch) New results: java -Xint -version 0 trp_lam 0 trp_sam 4.273510055 seconds time elapsed 3.926482000 seconds user Notice time improvements. Also running renaissance philosophers in Xint mode for 20 minutes: 0 trp_lam 0 trp_sam 1290.397695196 seconds time elapsed 2099.607472000 seconds user 40.825845000 seconds sys Clear win, for this fpga. I can still get some trp_lam when running java -Xcomp -version, but their number is pretty low (less than 50) and they come from C2 generated code. Now need to check if this changes affect performance on real hardware (I don't want to impact their performance) java -Xint -version is too fast for it, so I was running renaissance philosophers in Xint mode, just one repetition, multiple runs. Checking on Thead (c910 core): before: 671-684 seconds after: 657-689 seconds It's good it?s not worse On hifive umatched: before: 2638-2663 seconds after: 1489-1504 seconds hifive benefits it. I would like to get some pre-review for my patch [1] Main points: - safeness of using t0/t1 registers. - the method void TemplateTable::load_unsigned_short_at_bcp(Register dst, int offset, Register tmp), maybe it has to be designed differently [2] [3] The patch [1] has some comments describing how much of trp_lam events I won there. Regards, Vladimir [1] https://github.com/VladimirKempik/jdk/commit/18d7f399ce1bc213b2495411193938d914d3f616 [2] https://github.com/VladimirKempik/jdk/commit/18d7f399ce1bc213b2495411193938d914d3f616#diff-ecc50a63ee11d784ec34c55425afb755500a58f9ef4065cdc691fe18fce3692dR148 [3] https://github.com/VladimirKempik/jdk/commit/18d7f399ce1bc213b2495411193938d914d3f616#diff-412c07ae1ae7770f87b04175c0d65ed3cc1f60dca186e3cfaf0af6b6d00b597eR104 [4] https://mail.openjdk.org/pipermail/riscv-port-dev/2022-July/000563.html -------------- next part -------------- An HTML attachment was scrubbed... URL: From dzhang at openjdk.org Sun Mar 19 01:16:37 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Sun, 19 Mar 2023 01:16:37 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule Message-ID: Please review this backport to riscv-port-jdk17u. Backport of [JDK-8301313](https://bugs.openjdk.org/browse/JDK-8301313). Compared to the original patch, jdk17u does not have the patche [JDK-8293290](https://bugs.openjdk.org/browse/JDK-8293290), so format and ins_pipe of some nodes will be slightly different. The error `C2: assert(false) failed` mentioned in the original issue may require foreign api to reproduce, which is not available in jdk17u, but the same problem actually exists in jdk17u. Testing: - Tier1-3 passed without new failure on unmacthed (release). ------------- Commit messages: - 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/17/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=17&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301313 Stats: 41 lines in 1 file changed: 37 ins; 0 del; 4 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/17.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u pull/17/head:pull/17 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/17 From duke at openjdk.org Mon Mar 20 00:58:49 2023 From: duke at openjdk.org (duke) Date: Mon, 20 Mar 2023 00:58:49 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8 new changesets Message-ID: Changeset: c118b0e9 Author: Sergey Bylokhov Date: 2023-03-13 10:25:40 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/c118b0e9c835fdec7c0e5ac743d70d4cbda15ad5 8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K Backport-of: 90cd2fa16458dcc3e36171fa4bf21f26bc92b168 ! src/java.desktop/macosx/classes/com/apple/eio/FileManager.java ! src/java.desktop/macosx/classes/com/apple/laf/AquaFileView.java ! src/java.desktop/macosx/classes/com/apple/laf/ScreenMenu.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibility.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/java.desktop/share/classes/java/awt/EventQueue.java ! src/java.desktop/share/classes/javax/print/DocFlavor.java ! src/java.desktop/share/classes/javax/swing/ImageIcon.java ! src/java.desktop/share/classes/javax/swing/JPopupMenu.java ! src/java.desktop/share/classes/javax/swing/JRootPane.java ! src/java.desktop/share/classes/javax/swing/SortingFocusTraversalPolicy.java ! src/java.desktop/share/classes/sun/font/FontUtilities.java ! src/java.desktop/share/classes/sun/font/StrikeCache.java ! src/java.desktop/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/java.desktop/share/classes/sun/swing/JLightweightFrame.java ! src/java.desktop/unix/classes/sun/awt/X11GraphicsEnvironment.java ! src/java.desktop/unix/classes/sun/print/CUPSPrinter.java ! src/java.desktop/unix/classes/sun/print/PrintServiceLookupProvider.java ! src/java.desktop/unix/classes/sun/print/UnixPrintJob.java ! src/java.desktop/unix/classes/sun/print/UnixPrintService.java ! src/java.desktop/windows/classes/sun/awt/Win32FontManager.java ! src/java.desktop/windows/classes/sun/print/PrintServiceLookupProvider.java Changeset: b087032f Author: Sergey Bylokhov Date: 2023-03-13 18:55:26 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/b087032f9b26b9756da9f5dc368b1b564c9c5048 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id Backport-of: cfb0a25a4ee1a9cebd88c84fa622c46fe1c89bae ! src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java + test/jdk/java/time/test/java/time/format/TestUTCParse.java Changeset: bc79161e Author: Man Cao Committer: Christoph Langer Date: 2023-03-15 07:16:31 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/bc79161e25c256d41650325f5e26e426c703ae6c 8303937: Corrupted heap dumps due to missing retries for os::write() Reviewed-by: clanger Backport-of: bf16b5b9880eb89b283006db090dce4346aa877b ! src/hotspot/share/services/heapDumperCompression.cpp Changeset: 4baaa110 Author: Johannes Bechberger Committer: Martin Doerr Date: 2023-03-15 10:30:56 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/4baaa110d6135adfb8e4c7ca9a0bef60ea93598c 8302320: AsyncGetCallTrace obtains too few frames in sanity test Backport-of: db483a38a815f85bd9668749674b5f0f6e4b27b4 ! src/hotspot/cpu/x86/frame_x86.cpp ! test/hotspot/jtreg/serviceability/AsyncGetCallTrace/libAsyncGetCallTraceTest.cpp Changeset: c6805e64 Author: Ravali Yatham Committer: Paul Hohensee Date: 2023-03-16 21:31:39 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/c6805e643faf3776bb1779fe6f045e7a20a220de 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message Reviewed-by: mchung, phh Backport-of: 9f9d678591e02ecaeae7b81eeefb0ba41c7b4dae ! src/java.base/share/classes/java/lang/ClassLoader.java ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/lang/reflect/Proxy.java ! src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java Changeset: fba6dd8b Author: Matthias Baesken Date: 2023-03-17 08:05:49 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/fba6dd8b454d14b0ae6ce84587c1e4f0358f115d 8301050: Detect Xen Virtualization on Linux aarch64 Reviewed-by: clanger Backport-of: 11804b246e8643a3465b9549794ccfb24ccd8fc5 ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp ! src/hotspot/share/runtime/abstract_vm_version.hpp Changeset: c0056825 Author: Matthias Baesken Date: 2023-03-17 08:06:35 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/c00568255be4fef9183ee9650775702efff43d43 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return Backport-of: b51ea4204eaa18687e7712e87cdc92efbddfcb5b ! src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m Changeset: ec690a38 Author: Fei Yang Date: 2023-03-20 08:40:06 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/ec690a389f234954095f24e780c95450bb0024c6 Merge branch 'master' into riscv-port From fjiang at openjdk.org Mon Mar 20 01:48:17 2023 From: fjiang at openjdk.org (Feilong Jiang) Date: Mon, 20 Mar 2023 01:48:17 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule In-Reply-To: References: Message-ID: On Sun, 19 Mar 2023 01:10:00 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8301313](https://bugs.openjdk.org/browse/JDK-8301313). > Compared to the original patch, jdk17u does not have the patche [JDK-8293290](https://bugs.openjdk.org/browse/JDK-8293290), so format and ins_pipe of some nodes will be slightly different. > The error `C2: assert(false) failed` mentioned in the original issue may require foreign api to reproduce, which is not available in jdk17u, but the same problem actually exists in jdk17u. > > > Testing: > - Tier1-3 passed without new failure on unmacthed (release). LGTM ------------- Marked as reviewed by fjiang (no project role). PR: https://git.openjdk.org/riscv-port-jdk17u/pull/17 From fyang at openjdk.org Mon Mar 20 01:48:18 2023 From: fyang at openjdk.org (Fei Yang) Date: Mon, 20 Mar 2023 01:48:18 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule In-Reply-To: References: Message-ID: On Sun, 19 Mar 2023 01:10:00 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8301313](https://bugs.openjdk.org/browse/JDK-8301313). > Compared to the original patch, jdk17u does not have the patche [JDK-8293290](https://bugs.openjdk.org/browse/JDK-8293290), so format and ins_pipe of some nodes will be slightly different. > The error `C2: assert(false) failed` mentioned in the original issue may require foreign api to reproduce, which is not available in jdk17u, but the same problem actually exists in jdk17u. > > > Testing: > - Tier1-3 passed without new failure on unmacthed (release). I think you should backport fix for https://bugs.openjdk.org/browse/JDK-8299847 first which corrects 'ins_pipe' for the CMove nodes for RISC-V. That would help resolve the dependency here. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/17 From yangfei at iscas.ac.cn Mon Mar 20 07:29:36 2023 From: yangfei at iscas.ac.cn (yangfei at iscas.ac.cn) Date: Mon, 20 Mar 2023 15:29:36 +0800 (GMT+08:00) Subject: Missaligned memory accesses from JDK In-Reply-To: <29875E09-8B1E-4255-AAED-06305459C872@gmail.com> References: <29875E09-8B1E-4255-AAED-06305459C872@gmail.com> Message-ID: <330a2677.26fa2.186fdec7098.Coremail.yangfei@iscas.ac.cn> Hi, Just did a quick scan of the changes. I have a few comments. It's interesting to see that changes were made in hotspot shared code, especially in file: src/hotspot/share/asm/codeBuffer.hpp For each emit_intX functions modified, I see there is a correspondent version which handles unaligned access. For example, 'void emit_int16(uint8_t x1, uint8_t x2)' for 'void emit_int16(uint16_t x)' So if we encounter an unaligned access issue when using 'emit_int16(uint16_t x)', shouldn't we change the callsite to use 'emit_int16(uint8_t x1, uint8_t x2)' instead? I think this will also be a potential issue for other platforms in respect of functionality or performance. It doesn't look nice for us to handle that in a platform-dependent way. Also, instead of changing file: src/hotspot/share/interpreter/templateTable.hpp for new function 'load_unsigned_short_at_bcp', I personally perfer inlining it at its callsites. And what about C1 & C2 JIT compilers? Thanks, Fei Yang -----Original Messages----- From:"Vladimir Kempik" Sent Time:2023-03-17 18:50:19 (Friday) To: riscv-port-dev Cc: yunyao.zxl at alibaba-inc.com Subject: Missaligned memory accesses from JDK Hello Continuing on misaligned memory accesses from JDK. Hearing no news from Yadong's team [4], I have decided to take a look myself. I have an fpga with risc-v cores, in this config it has no support for misaligned loads/stores. When such memory access happens, it leads to trap and then the M-mode emulator is used ( very similar to opensbi) Also I have two perf counters - trp_lam/trp_sam (for misaligned loads and stores resp.) Using them and perfasm.jar I can track every misaligned access. I have started with the patch from Xiaolin Zheng (which fixes misaligned memory access when writing/reading instructions), that completely removed trp_sam events, but trp_lam was mostly unaffected. Using perfasm.jar I have found the rest of trp_lam to originate from Template Interpreter's generated code. Here is numbers on current jdk21-dev (without Xiaolin's patch) java -Xint -version 239163 trp_lam 16289 trp_sam 5.602736519 seconds time elapsed 5.260201000 seconds user Total executed instructions - 380M 1:1600 (trp_lam:total) - pretty high ration. I was able to identify and fix all of them (also applying Xiaolin's patch) New results: java -Xint -version 0 trp_lam 0 trp_sam 4.273510055 seconds time elapsed 3.926482000 seconds user Notice time improvements. Also running renaissance philosophers in Xint mode for 20 minutes: 0 trp_lam 0 trp_sam 1290.397695196 seconds time elapsed 2099.607472000 seconds user 40.825845000 seconds sys Clear win, for this fpga. I can still get some trp_lam when running java -Xcomp -version, but their number is pretty low (less than 50) and they come from C2 generated code. Now need to check if this changes affect performance on real hardware (I don't want to impact their performance) java -Xint -version is too fast for it, so I was running renaissance philosophers in Xint mode, just one repetition, multiple runs. Checking on Thead (c910 core): before: 671-684 seconds after: 657-689 seconds It's good it?s not worse On hifive umatched: before: 2638-2663 seconds after: 1489-1504 seconds hifive benefits it. I would like to get some pre-review for my patch [1] Main points: - safeness of using t0/t1 registers. - the method void TemplateTable::load_unsigned_short_at_bcp(Register dst, int offset, Register tmp), maybe it has to be designed differently [2] [3] The patch [1] has some comments describing how much of trp_lam events I won there. Regards, Vladimir [1] https://github.com/VladimirKempik/jdk/commit/18d7f399ce1bc213b2495411193938d914d3f616 [2] https://github.com/VladimirKempik/jdk/commit/18d7f399ce1bc213b2495411193938d914d3f616#diff-ecc50a63ee11d784ec34c55425afb755500a58f9ef4065cdc691fe18fce3692dR148 [3] https://github.com/VladimirKempik/jdk/commit/18d7f399ce1bc213b2495411193938d914d3f616#diff-412c07ae1ae7770f87b04175c0d65ed3cc1f60dca186e3cfaf0af6b6d00b597eR104 [4] https://mail.openjdk.org/pipermail/riscv-port-dev/2022-July/000563.html From dzhang at openjdk.org Mon Mar 20 08:03:09 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Mon, 20 Mar 2023 08:03:09 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule In-Reply-To: References:

Message-ID: <9KFZwDCjMAA5Xwh4-aojm6XXgObdqnC7nrWJttPqmoE=.99c0545c-7dbd-4ff2-93a2-5f303a9c9872@github.com> On Mon, 20 Mar 2023 01:44:06 GMT, Fei Yang wrote: > I think you should backport fix for https://bugs.openjdk.org/browse/JDK-8299847 first which corrects 'ins_pipe' for the CMove nodes for RISC-V. That would help resolve the dependency here. Thanks for pointing this out. I'm currently testing [JDK-8299847](https://bugs.openjdk.org/browse/JDK-8299847) and will create backport PR after that first. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/17 From vladimir.kempik at gmail.com Mon Mar 20 09:42:02 2023 From: vladimir.kempik at gmail.com (Vladimir Kempik) Date: Mon, 20 Mar 2023 12:42:02 +0300 Subject: Missaligned memory accesses from JDK In-Reply-To: <330a2677.26fa2.186fdec7098.Coremail.yangfei@iscas.ac.cn> References: <29875E09-8B1E-4255-AAED-06305459C872@gmail.com> <330a2677.26fa2.186fdec7098.Coremail.yangfei@iscas.ac.cn> Message-ID: <6194F148-F760-407F-961E-180BBDC6AE4F@gmail.com> > For each emit_intX functions modified, I see there is a correspondent version which handles unaligned access. For example, 'void emit_int16(uint8_t x1, uint8_t x2)' for 'void emit_int16(uint16_t x)' > So if we encounter an unaligned access issue when using 'emit_int16(uint16_t x)', shouldn't we change the callsite to use 'emit_int16(uint8_t x1, uint8_t x2)' instead? Hello not exactly 'void emit_int16(uint8_t x1, uint8_t x2) will always use slow version ( store byte) but void emit_int16(uint16_t x) will use slow version only on unaligned stores. if store is aligned, it will use "store half", which should be faster. So we can?t always use emit_int16(uint8_t x1, uint8_t x2) at callsite. and we can?t decide which one to use at callsite as callsite should be unaware of end() value inside CodeSection class Regards, Vladimir -------------- next part -------------- An HTML attachment was scrubbed... URL: From vladimir.kempik at gmail.com Mon Mar 20 15:26:09 2023 From: vladimir.kempik at gmail.com (Vladimir Kempik) Date: Mon, 20 Mar 2023 18:26:09 +0300 Subject: Missaligned memory accesses from JDK In-Reply-To: <6194F148-F760-407F-961E-180BBDC6AE4F@gmail.com> References: <29875E09-8B1E-4255-AAED-06305459C872@gmail.com> <330a2677.26fa2.186fdec7098.Coremail.yangfei@iscas.ac.cn> <6194F148-F760-407F-961E-180BBDC6AE4F@gmail.com> Message-ID: <66F089DC-6F97-488E-B337-80F3C0DAE5A1@gmail.com> Adding compiler list. Could you please suggest on best way to make emit_intX methods not perform misaligned memory stores ? Talking about src/hotspot/share/asm/codeBuffer.hpp from https://github.com/VladimirKempik/jdk/commit/18d7f399ce1bc213b2495411193938d914d3f616#diff-deb8ab083311ba60c0016dc34d6518579bbee4683c81e8d348982bac897fe8ae Regards, Vladimir > 20 ????? 2023 ?., ? 12:42, Vladimir Kempik ???????(?): > > >> For each emit_intX functions modified, I see there is a correspondent version which handles unaligned access. For example, 'void emit_int16(uint8_t x1, uint8_t x2)' for 'void emit_int16(uint16_t x)' >> So if we encounter an unaligned access issue when using 'emit_int16(uint16_t x)', shouldn't we change the callsite to use 'emit_int16(uint8_t x1, uint8_t x2)' instead? > > Hello > not exactly > 'void emit_int16(uint8_t x1, uint8_t x2) > will always use slow version ( store byte) > > but > void emit_int16(uint16_t x) > will use slow version only on unaligned stores. if store is aligned, it will use "store half", which should be faster. > > So we can?t always use emit_int16(uint8_t x1, uint8_t x2) at callsite. > > and we can?t decide which one to use at callsite as callsite should be unaware of end() value inside CodeSection class > > Regards, Vladimir -------------- next part -------------- An HTML attachment was scrubbed... URL: From dzhang at openjdk.org Tue Mar 21 01:25:08 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Tue, 21 Mar 2023 01:25:08 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule Message-ID: Please review this backport to riscv-port-jdk17u. Backport of [JDK-8299847](https://bugs.openjdk.org/browse/JDK-8299847). Applies cleanly. Testing: - Tier1 passed without new failure on unmacthed (release). ------------- Commit messages: - 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/18/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=18&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8301313 Stats: 41 lines in 1 file changed: 1 ins; 12 del; 28 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/18.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/18/head:pull/18 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/18 From dzhang at openjdk.org Tue Mar 21 01:37:36 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Tue, 21 Mar 2023 01:37:36 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes [v2] In-Reply-To: References: Message-ID: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8299847](https://bugs.openjdk.org/browse/JDK-8299847). Applies cleanly. > > Testing: > - Tier1 passed without new failure on unmacthed (release). Dingli Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes Backport-of: 859ccd1a150653c42ebbcd3402994ef9ff4c810f ------------- Changes: - all: https://git.openjdk.org/riscv-port-jdk17u/pull/18/files - new: https://git.openjdk.org/riscv-port-jdk17u/pull/18/files/7ed1b5a3..9d949615 Webrevs: - full: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=18&range=01 - incr: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=18&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/18.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/18/head:pull/18 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/18 From gcao at openjdk.org Tue Mar 21 02:45:04 2023 From: gcao at openjdk.org (Gui Cao) Date: Tue, 21 Mar 2023 02:45:04 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8304293: RISC-V: JDK-8276799 missed atomic intrinsic support for C1 Message-ID: <_kLP6SDxhwRqaDbisLO-MERQ9MF--O2kiO0n8yJNZv0=.ea666170-4fac-4972-b209-dd5e46fc087b@github.com> Please review this backport to riscv-port-jdk17u. Backport of [JDK-8304293](https://bugs.openjdk.org/browse/JDK-8304293). Let me show the IR changes before and after the modification: `java -Xcomp -XX:TieredStopAtLevel=1 -XX:+PrintIR -version > C1.log` before: B3 (V) [33, 49] dom B1 pred: B1 empty stack inlining depth 0 __bci__use__tid____instr____________________________________ 33 1 a35 . 8 0 l42 a25.invokespecial(a35, l27, l4) jdk/internal/misc/Unsafe.getAndAddLong(Ljava/lang/Object;JJ)J 41 1 a46 7 1 l53 1L . 8 0 l54 a25.invokespecial(a46, l27, l53) jdk/internal/misc/Unsafe.getAndAddLong(Ljava/lang/Object;JJ)J . 49 0 i61 ireturn i29 after: B3 (V) [33, 49] dom B1 pred: B1 empty stack inlining depth 0 __bci__use__tid____instr____________________________________ 33 1 a35 . 8 0 l42 UnsafeGetAndSetObject (add).(a35, l27, value l4) 41 1 a46 7 1 l53 1L . 8 0 l54 UnsafeGetAndSetObject (add).(a46, l27, value l53) . 49 0 i61 ireturn i29 Testing: Tier1 passed without new failure on unmacthed (release). ------------- Commit messages: - backport 8304293: RISC-V: JDK-8276799 missed atomic intrinsic support for C1 Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/19/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=19&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304293 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/19.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/19/head:pull/19 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/19 From xlinzheng at openjdk.org Tue Mar 21 04:29:57 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Tue, 21 Mar 2023 04:29:57 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8285711: riscv: RVC: Support disassembler show-bytes option Message-ID: Backporting RVC-related patches. Applied cleanly. Tested along with other patches, hotspot tier1~4 with fastdebug build. ------------- Commit messages: - 8285711: riscv: RVC: Support disassembler show-bytes option Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/20/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=20&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285711 Stats: 22 lines in 1 file changed: 20 ins; 0 del; 2 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/20.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/20/head:pull/20 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/20 From xlinzheng at openjdk.org Tue Mar 21 04:31:00 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Tue, 21 Mar 2023 04:31:00 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8285699: riscv: Provide information when hitting a HaltNode Message-ID: Backport one Yadong's patch, which can cleanup some RVC things. Tested along with other patches, hotspot tier1~4 with fastdebug build. ------------- Commit messages: - 8285699: riscv: Provide information when hitting a HaltNode Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/21/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=21&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285699 Stats: 98 lines in 9 files changed: 45 ins; 39 del; 14 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/21.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/21/head:pull/21 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/21 From duke at openjdk.org Tue Mar 21 08:17:42 2023 From: duke at openjdk.org (duke) Date: Tue, 21 Mar 2023 08:17:42 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes Message-ID: <3fc64e60-8424-4c4c-b3ee-ac04441c6c69@openjdk.org> Changeset: 4d4daec7 Author: Dingli Zhang Committer: GitHub Date: 2023-03-21 16:17:09 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/4d4daec7906b90ff22e4e0736a071ddd4fa95090 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes ! src/hotspot/cpu/riscv/riscv.ad From fyang at openjdk.org Tue Mar 21 08:19:18 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 21 Mar 2023 08:19:18 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes [v2] In-Reply-To: References:

Message-ID: On Tue, 21 Mar 2023 01:37:36 GMT, Dingli Zhang wrote: >> Please review this backport to riscv-port-jdk17u. >> Backport of [JDK-8299847](https://bugs.openjdk.org/browse/JDK-8299847). Applies cleanly. >> >> Testing: >> - Tier1 passed without new failure on unmacthed (release). > > Dingli Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes > > Backport-of: 859ccd1a150653c42ebbcd3402994ef9ff4c810f Looks good. Thanks. ------------- Marked as reviewed by fyang (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/18#pullrequestreview-1349887671 From fyang at openjdk.org Tue Mar 21 08:19:19 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 21 Mar 2023 08:19:19 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 01:18:03 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8299847](https://bugs.openjdk.org/browse/JDK-8299847). Applies cleanly. > > Testing: > - Tier1 passed without new failure on unmacthed (release). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/18 From dzhang at openjdk.org Tue Mar 21 08:36:12 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Tue, 21 Mar 2023 08:36:12 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule [v2] In-Reply-To: References: Message-ID: <0YcomIJ1mrpkJeeUB2ooGcDjjSBJ2f8OTffMArd3UPw=.bc3ef934-d515-4e7c-baa6-34f6508e5480@github.com> > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8301313](https://bugs.openjdk.org/browse/JDK-8301313). > The original patch cannot be directly applied because of the line number, but there are no other additional changes. > The error `C2: assert(false) failed` mentioned in the original issue may require foreign api to reproduce, which is not available in jdk17u, but the same problem actually exists in jdk17u. > > > Testing: > - Tier1-3 passed without new failure on unmacthed (release). Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'riscv-port' into backport-JDK-8301313 - Fix format and ins_pipe - 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule Backport-of: 3ad6aef1496de914b70f00005465e4b22f248d4f ------------- Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/17/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=17&range=01 Stats: 37 lines in 1 file changed: 33 ins; 0 del; 4 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/17.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/17/head:pull/17 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/17 From fyang at openjdk.org Tue Mar 21 08:43:25 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 21 Mar 2023 08:43:25 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule [v2] In-Reply-To: <0YcomIJ1mrpkJeeUB2ooGcDjjSBJ2f8OTffMArd3UPw=.bc3ef934-d515-4e7c-baa6-34f6508e5480@github.com> References: <0YcomIJ1mrpkJeeUB2ooGcDjjSBJ2f8OTffMArd3UPw=.bc3ef934-d515-4e7c-baa6-34f6508e5480@github.com> Message-ID: On Tue, 21 Mar 2023 08:36:12 GMT, Dingli Zhang wrote: >> Please review this backport to riscv-port-jdk17u. >> Backport of [JDK-8301313](https://bugs.openjdk.org/browse/JDK-8301313). >> The original patch cannot be directly applied because of the line number, but there are no other additional changes. >> The error `C2: assert(false) failed` mentioned in the original issue may require foreign api to reproduce, which is not available in jdk17u, but the same problem actually exists in jdk17u. >> >> >> Testing: >> - Tier1-3 passed without new failure on unmacthed (release). > > Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: > > - Merge branch 'riscv-port' into backport-JDK-8301313 > - Fix format and ins_pipe > - 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule > > Backport-of: 3ad6aef1496de914b70f00005465e4b22f248d4f OK. I see the C2 transformation code leading to the original issue is also there in jdk17u. ------------- Marked as reviewed by fyang (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/17#pullrequestreview-1349923114 From fyang at openjdk.org Tue Mar 21 08:43:27 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 21 Mar 2023 08:43:27 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule In-Reply-To: References: Message-ID: On Sun, 19 Mar 2023 01:10:00 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8301313](https://bugs.openjdk.org/browse/JDK-8301313). > The original patch cannot be directly applied because of the line number, but there are no other additional changes. > The error `C2: assert(false) failed` mentioned in the original issue may require foreign api to reproduce, which is not available in jdk17u, but the same problem actually exists in jdk17u. > > > Testing: > - Tier1-3 passed without new failure on unmacthed (release). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/17 From duke at openjdk.org Tue Mar 21 08:43:42 2023 From: duke at openjdk.org (duke) Date: Tue, 21 Mar 2023 08:43:42 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule Message-ID: <83fc7b33-d797-4644-b2d0-bdcbb0e11b5c@openjdk.org> Changeset: f2bdd162 Author: Dingli Zhang Committer: GitHub Date: 2023-03-21 16:41:21 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/f2bdd1627e7f6925e5e927c2fdef75ac05a73c72 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule ! src/hotspot/cpu/riscv/riscv.ad From fjiang at openjdk.org Tue Mar 21 10:35:17 2023 From: fjiang at openjdk.org (Feilong Jiang) Date: Tue, 21 Mar 2023 10:35:17 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8304293: RISC-V: JDK-8276799 missed atomic intrinsic support for C1 In-Reply-To: <_kLP6SDxhwRqaDbisLO-MERQ9MF--O2kiO0n8yJNZv0=.ea666170-4fac-4972-b209-dd5e46fc087b@github.com> References: <_kLP6SDxhwRqaDbisLO-MERQ9MF--O2kiO0n8yJNZv0=.ea666170-4fac-4972-b209-dd5e46fc087b@github.com> Message-ID: On Tue, 21 Mar 2023 02:33:45 GMT, Gui Cao wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8304293](https://bugs.openjdk.org/browse/JDK-8304293). > Let me show the IR changes before and after the modification: > `java -Xcomp -XX:TieredStopAtLevel=1 -XX:+PrintIR -version > C1.log` > > before: > > B3 (V) [33, 49] dom B1 pred: B1 > empty stack > inlining depth 0 > __bci__use__tid____instr____________________________________ > 33 1 a35 > . 8 0 l42 a25.invokespecial(a35, l27, l4) > jdk/internal/misc/Unsafe.getAndAddLong(Ljava/lang/Object;JJ)J > 41 1 a46 > 7 1 l53 1L > . 8 0 l54 a25.invokespecial(a46, l27, l53) > jdk/internal/misc/Unsafe.getAndAddLong(Ljava/lang/Object;JJ)J > . 49 0 i61 ireturn i29 > > > after: > > B3 (V) [33, 49] dom B1 pred: B1 > empty stack > inlining depth 0 > __bci__use__tid____instr____________________________________ > 33 1 a35 > . 8 0 l42 UnsafeGetAndSetObject (add).(a35, l27, value l4) > 41 1 a46 > 7 1 l53 1L > . 8 0 l54 UnsafeGetAndSetObject (add).(a46, l27, value l53) > . 49 0 i61 ireturn i29 > > > Testing: > > Tier1 passed without new failure on unmacthed (release). Thanks for backporting this! ------------- Marked as reviewed by fjiang (no project role). PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/19#pullrequestreview-1350128156 From duke at openjdk.org Tue Mar 21 14:09:45 2023 From: duke at openjdk.org (duke) Date: Tue, 21 Mar 2023 14:09:45 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8287552: riscv: Fix comment typo in li64 Message-ID: <21b01162-b8e3-44a6-ac91-5feb0e34f229@openjdk.org> Changeset: bf2d16c1 Author: Dingli Zhang Committer: GitHub Date: 2023-03-21 22:08:55 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/bf2d16c1de5b893f2be5c7db9dfd813aa89982b0 8287552: riscv: Fix comment typo in li64 ! src/hotspot/cpu/riscv/assembler_riscv.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.cpp From fyang at openjdk.org Tue Mar 21 14:12:19 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 21 Mar 2023 14:12:19 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8287552: riscv: Fix comment typo in li64 In-Reply-To: References: Message-ID: On Tue, 7 Mar 2023 07:46:02 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8287552](https://bugs.openjdk.java.net/browse/JDK-8287552). Applies cleanly. > > Testing: > > - Tier1 passed without new failure on unmacthed (release). Marked as reviewed by fyang (Committer). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/7#pullrequestreview-1350566290 From fyang at openjdk.org Tue Mar 21 14:12:20 2023 From: fyang at openjdk.org (Fei Yang) Date: Tue, 21 Mar 2023 14:12:20 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8287552: riscv: Fix comment typo in li64 In-Reply-To: References: Message-ID: On Tue, 7 Mar 2023 07:46:02 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8287552](https://bugs.openjdk.java.net/browse/JDK-8287552). Applies cleanly. > > Testing: > > - Tier1 passed without new failure on unmacthed (release). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/7 From duke at openjdk.org Wed Mar 22 03:26:40 2023 From: duke at openjdk.org (duke) Date: Wed, 22 Mar 2023 03:26:40 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8296602: RISC-V: improve performance of copy_memory stub Message-ID: <359339ce-296b-4e16-950a-4163fb6fc49e@openjdk.org> Changeset: 3e3e63c7 Author: VladimirKempik <69576004+VladimirKempik at users.noreply.github.com> Committer: GitHub Date: 2023-03-22 06:24:20 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/3e3e63c72492bf32bf16f33827e70715781f81d1 8296602: RISC-V: improve performance of copy_memory stub ! src/hotspot/cpu/riscv/stubGenerator_riscv.cpp From fyang at openjdk.org Wed Mar 22 03:27:16 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 22 Mar 2023 03:27:16 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296602: RISC-V: improve performance of copy_memory stub In-Reply-To: <3c9iHhPfP8yibC97x_ITeN4n4V_MrfU6b__JLO9KWj4=.6c641fc3-a366-4a48-be25-f8a5e0e32764@github.com> References: <3c9iHhPfP8yibC97x_ITeN4n4V_MrfU6b__JLO9KWj4=.6c641fc3-a366-4a48-be25-f8a5e0e32764@github.com> Message-ID: On Thu, 9 Mar 2023 10:15:22 GMT, Vladimir Kempik wrote: > Please review this backport of JDK-8296602 to jdk17u > This effectively unrolls copy memory loop offering significant perf improvement on real hw platforms. ( data are the same as in original commit) > > RISC-V only change, low risk for other platforms. > Testing: TBD. > > thead rvb-ice c910 > thead > > > Before ( copy8 only ) > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 6653.095 ? 251.565 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 4933.970 ? 77.559 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 3627.454 ? 34.589 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 368.249 ? 0.453 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 187.776 ? 0.306 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 94.477 ? 0.340 ops/ms > > after ( with copy32 ) > ArrayCopyObject.conjoint_micro 31 thrpt 25 7620.546 ? 69.756 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 6677.978 ? 33.112 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 5206.973 ? 22.612 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 653.655 ? 31.494 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 352.905 ? 7.390 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 165.127 ? 0.832 ops/ms > > after ( copy32 with dead code elimination and independent addis ) > ArrayCopyObject.conjoint_micro 31 thrpt 25 7576.346 ? 94.487 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 6475.730 ? 252.590 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 5221.764 ? 20.415 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 691.847 ? 1.102 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 360.269 ? 1.091 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 179.733 ? 3.012 ops/ms > > on hifive unmatched: > > before: > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 5391.575 ? 152.984 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 3700.946 ? 43.175 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 2316.160 ? 24.734 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 188.616 ? 0.151 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 95.323 ? 0.053 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 46.935 ? 0.041 ops/ms > > after: > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 6136.169 ? 330.409 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 4924.020 ? 78.529 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 3732.561 ? 89.606 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 431.103 ? 0.505 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 221.543 ? 0.363 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 100.586 ? 0.197 ops/ms I also tried this test "runtime/8176717/TestInheritFD.java" on my boards, it passed stably for 10 times run. ------------- Marked as reviewed by fyang (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/9#pullrequestreview-1351665473 From fyang at openjdk.org Wed Mar 22 03:27:16 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 22 Mar 2023 03:27:16 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8296602: RISC-V: improve performance of copy_memory stub In-Reply-To: <3c9iHhPfP8yibC97x_ITeN4n4V_MrfU6b__JLO9KWj4=.6c641fc3-a366-4a48-be25-f8a5e0e32764@github.com> References: <3c9iHhPfP8yibC97x_ITeN4n4V_MrfU6b__JLO9KWj4=.6c641fc3-a366-4a48-be25-f8a5e0e32764@github.com> Message-ID: <7YGpjqMXctLdxFUEGLGvXBBX4QnAo949dnX6Sm_iRSo=.ecf4cbd2-1da5-4139-9582-25a4221d5ea5@github.com> On Thu, 9 Mar 2023 10:15:22 GMT, Vladimir Kempik wrote: > Please review this backport of JDK-8296602 to jdk17u > This effectively unrolls copy memory loop offering significant perf improvement on real hw platforms. ( data are the same as in original commit) > > RISC-V only change, low risk for other platforms. > Testing: TBD. > > thead rvb-ice c910 > thead > > > Before ( copy8 only ) > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 6653.095 ? 251.565 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 4933.970 ? 77.559 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 3627.454 ? 34.589 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 368.249 ? 0.453 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 187.776 ? 0.306 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 94.477 ? 0.340 ops/ms > > after ( with copy32 ) > ArrayCopyObject.conjoint_micro 31 thrpt 25 7620.546 ? 69.756 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 6677.978 ? 33.112 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 5206.973 ? 22.612 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 653.655 ? 31.494 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 352.905 ? 7.390 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 165.127 ? 0.832 ops/ms > > after ( copy32 with dead code elimination and independent addis ) > ArrayCopyObject.conjoint_micro 31 thrpt 25 7576.346 ? 94.487 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 6475.730 ? 252.590 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 5221.764 ? 20.415 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 691.847 ? 1.102 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 360.269 ? 1.091 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 179.733 ? 3.012 ops/ms > > on hifive unmatched: > > before: > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 5391.575 ? 152.984 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 3700.946 ? 43.175 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 2316.160 ? 24.734 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 188.616 ? 0.151 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 95.323 ? 0.053 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 46.935 ? 0.041 ops/ms > > after: > Benchmark (size) Mode Cnt Score Error Units > ArrayCopyObject.conjoint_micro 31 thrpt 25 6136.169 ? 330.409 ops/ms > ArrayCopyObject.conjoint_micro 63 thrpt 25 4924.020 ? 78.529 ops/ms > ArrayCopyObject.conjoint_micro 127 thrpt 25 3732.561 ? 89.606 ops/ms > ArrayCopyObject.conjoint_micro 2047 thrpt 25 431.103 ? 0.505 ops/ms > ArrayCopyObject.conjoint_micro 4095 thrpt 25 221.543 ? 0.363 ops/ms > ArrayCopyObject.conjoint_micro 8191 thrpt 25 100.586 ? 0.197 ops/ms This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/9 From duke at openjdk.org Wed Mar 22 03:28:40 2023 From: duke at openjdk.org (duke) Date: Wed, 22 Mar 2023 03:28:40 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8304293: RISC-V: JDK-8276799 missed atomic intrinsic support for C1 Message-ID: <962edc06-6c43-4050-9d9e-4d074024017e@openjdk.org> Changeset: 63319e29 Author: zifeihan Committer: GitHub Date: 2023-03-22 11:27:42 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/63319e2945c912607f10fe477a56e4d9c8983cc0 8304293: RISC-V: JDK-8276799 missed atomic intrinsic support for C1 ! src/hotspot/cpu/riscv/vm_version_riscv.cpp From fyang at openjdk.org Wed Mar 22 03:30:10 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 22 Mar 2023 03:30:10 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8304293: RISC-V: JDK-8276799 missed atomic intrinsic support for C1 In-Reply-To: <_kLP6SDxhwRqaDbisLO-MERQ9MF--O2kiO0n8yJNZv0=.ea666170-4fac-4972-b209-dd5e46fc087b@github.com> References: <_kLP6SDxhwRqaDbisLO-MERQ9MF--O2kiO0n8yJNZv0=.ea666170-4fac-4972-b209-dd5e46fc087b@github.com> Message-ID: On Tue, 21 Mar 2023 02:33:45 GMT, Gui Cao wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8304293](https://bugs.openjdk.org/browse/JDK-8304293). > Let me show the IR changes before and after the modification: > `java -Xcomp -XX:TieredStopAtLevel=1 -XX:+PrintIR -version > C1.log` > > before: > > B3 (V) [33, 49] dom B1 pred: B1 > empty stack > inlining depth 0 > __bci__use__tid____instr____________________________________ > 33 1 a35 > . 8 0 l42 a25.invokespecial(a35, l27, l4) > jdk/internal/misc/Unsafe.getAndAddLong(Ljava/lang/Object;JJ)J > 41 1 a46 > 7 1 l53 1L > . 8 0 l54 a25.invokespecial(a46, l27, l53) > jdk/internal/misc/Unsafe.getAndAddLong(Ljava/lang/Object;JJ)J > . 49 0 i61 ireturn i29 > > > after: > > B3 (V) [33, 49] dom B1 pred: B1 > empty stack > inlining depth 0 > __bci__use__tid____instr____________________________________ > 33 1 a35 > . 8 0 l42 UnsafeGetAndSetObject (add).(a35, l27, value l4) > 41 1 a46 > 7 1 l53 1L > . 8 0 l54 UnsafeGetAndSetObject (add).(a46, l27, value l53) > . 49 0 i61 ireturn i29 > > > Testing: > > Tier1 passed without new failure on unmacthed (release). Marked as reviewed by fyang (Committer). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/19#pullrequestreview-1351667268 From fyang at openjdk.org Wed Mar 22 03:30:10 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 22 Mar 2023 03:30:10 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8304293: RISC-V: JDK-8276799 missed atomic intrinsic support for C1 In-Reply-To: <_kLP6SDxhwRqaDbisLO-MERQ9MF--O2kiO0n8yJNZv0=.ea666170-4fac-4972-b209-dd5e46fc087b@github.com> References: <_kLP6SDxhwRqaDbisLO-MERQ9MF--O2kiO0n8yJNZv0=.ea666170-4fac-4972-b209-dd5e46fc087b@github.com> Message-ID: On Tue, 21 Mar 2023 02:33:45 GMT, Gui Cao wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8304293](https://bugs.openjdk.org/browse/JDK-8304293). > Let me show the IR changes before and after the modification: > `java -Xcomp -XX:TieredStopAtLevel=1 -XX:+PrintIR -version > C1.log` > > before: > > B3 (V) [33, 49] dom B1 pred: B1 > empty stack > inlining depth 0 > __bci__use__tid____instr____________________________________ > 33 1 a35 > . 8 0 l42 a25.invokespecial(a35, l27, l4) > jdk/internal/misc/Unsafe.getAndAddLong(Ljava/lang/Object;JJ)J > 41 1 a46 > 7 1 l53 1L > . 8 0 l54 a25.invokespecial(a46, l27, l53) > jdk/internal/misc/Unsafe.getAndAddLong(Ljava/lang/Object;JJ)J > . 49 0 i61 ireturn i29 > > > after: > > B3 (V) [33, 49] dom B1 pred: B1 > empty stack > inlining depth 0 > __bci__use__tid____instr____________________________________ > 33 1 a35 > . 8 0 l42 UnsafeGetAndSetObject (add).(a35, l27, value l4) > 41 1 a46 > 7 1 l53 1L > . 8 0 l54 UnsafeGetAndSetObject (add).(a46, l27, value l53) > . 49 0 i61 ireturn i29 > > > Testing: > > Tier1 passed without new failure on unmacthed (release). This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/19 From duke at openjdk.org Wed Mar 22 07:19:13 2023 From: duke at openjdk.org (duke) Date: Wed, 22 Mar 2023 07:19:13 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8285711: riscv: RVC: Support disassembler show-bytes option Message-ID: Changeset: 8084d9e7 Author: zhengxiaolinX Committer: GitHub Date: 2023-03-22 15:17:55 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/8084d9e7d9eb0553c9873e5cd6a517dcfbdb7076 8285711: riscv: RVC: Support disassembler show-bytes option Reviewed-by: fyang ! src/hotspot/cpu/riscv/assembler_riscv.hpp From fyang at openjdk.org Wed Mar 22 07:20:14 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 22 Mar 2023 07:20:14 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8285711: riscv: RVC: Support disassembler show-bytes option In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 04:20:53 GMT, Xiaolin Zheng wrote: > Backporting RVC-related patches. Applied cleanly. > > Tested along with other patches, hotspot tier1~4 with fastdebug build. Marked as reviewed by fyang (Committer). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/20#pullrequestreview-1351854575 From fyang at openjdk.org Wed Mar 22 07:20:14 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 22 Mar 2023 07:20:14 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8285711: riscv: RVC: Support disassembler show-bytes option In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 04:20:53 GMT, Xiaolin Zheng wrote: > Backporting RVC-related patches. Applied cleanly. > > Tested along with other patches, hotspot tier1~4 with fastdebug build. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/20 From gcao at openjdk.org Wed Mar 22 07:51:11 2023 From: gcao at openjdk.org (Gui Cao) Date: Wed, 22 Mar 2023 07:51:11 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8297644: RISC-V: Compilation error when shenandoah is disabled Message-ID: Please help review this backport to riscv-port-jdk17u. Backport of [JDK-8297644](https://bugs.openjdk.org/browse/JDK-8297644). Applies cleanly. The compilation failed before the modification as follows: Creating support/modules_libs/java.base/server/libjvm.so from 975 file(s) /home/zifeihan/riscv-port-jdk17u/src/hotspot/cpu/riscv/riscv.ad: In member function 'virtual void MachPrologNode::emit(CodeBuffer&, PhaseRegAlloc*) const': /home/zifeihan/riscv-port-jdk17u/src/hotspot/cpu/riscv/riscv.ad:1351:7: error: invalid use of incomplete type 'class BarrierSetAssembler' 1351 | bs->nmethod_entry_barrier(&_masm); | ^~ In file included from /home/zifeihan/riscv-port-jdk17u/src/hotspot/share/gc/shared/modRefBarrierSet.hpp:28, from /home/zifeihan/riscv-port-jdk17u/src/hotspot/share/gc/shared/cardTableBarrierSet.hpp:29, from /home/zifeihan/riscv-port-jdk17u/src/hotspot/cpu/riscv/riscv.ad:960, from ad_riscv.cpp:31: /home/zifeihan/riscv-port-jdk17u/src/hotspot/share/gc/shared/barrierSet.hpp:36:7: note: forward declaration of 'class BarrierSetAssembler' 36 | class BarrierSetAssembler; | ^~~~~~~~~~~~~~~~~~~ ... === End of repeated output === No indication of failed target found. Hint: Try searching the build log for '] Error'. Hint: See doc/building.html#troubleshooting for assistance. make[1]: *** [/home/zifeihan/riscv-port-jdk17u/make/Init.gmk:315: main] Error 2 make: *** [/home/zifeihan/riscv-port-jdk17u/make/Init.gmk:186: default] Error 2 Compile normally after fix. ------------- Commit messages: - backport 8297644: RISC-V: Compilation error when shenandoah is disabled Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/22/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=22&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297644 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/22.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/22/head:pull/22 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/22 From fyang at openjdk.org Wed Mar 22 08:15:12 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 22 Mar 2023 08:15:12 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8297644: RISC-V: Compilation error when shenandoah is disabled In-Reply-To: References: Message-ID: <6fbwja5gKElTdEh2qEkzh6nOboTbrfx8Y-1exAt_ASQ=.bfc7813e-81b2-4da3-b06c-fb1e5d433c16@github.com> On Wed, 22 Mar 2023 07:43:11 GMT, Gui Cao wrote: > Please help review this backport to riscv-port-jdk17u. > Backport of [JDK-8297644](https://bugs.openjdk.org/browse/JDK-8297644). Applies cleanly. > The compilation failed before the modification as follows: > > Creating support/modules_libs/java.base/server/libjvm.so from 975 file(s) > /home/zifeihan/riscv-port-jdk17u/src/hotspot/cpu/riscv/riscv.ad: In member function 'virtual void MachPrologNode::emit(CodeBuffer&, PhaseRegAlloc*) const': > /home/zifeihan/riscv-port-jdk17u/src/hotspot/cpu/riscv/riscv.ad:1351:7: error: invalid use of incomplete type 'class BarrierSetAssembler' > 1351 | bs->nmethod_entry_barrier(&_masm); > | ^~ > In file included from /home/zifeihan/riscv-port-jdk17u/src/hotspot/share/gc/shared/modRefBarrierSet.hpp:28, > from /home/zifeihan/riscv-port-jdk17u/src/hotspot/share/gc/shared/cardTableBarrierSet.hpp:29, > from /home/zifeihan/riscv-port-jdk17u/src/hotspot/cpu/riscv/riscv.ad:960, > from ad_riscv.cpp:31: > /home/zifeihan/riscv-port-jdk17u/src/hotspot/share/gc/shared/barrierSet.hpp:36:7: note: forward declaration of 'class BarrierSetAssembler' > 36 | class BarrierSetAssembler; > | ^~~~~~~~~~~~~~~~~~~ > ... > === End of repeated output === > > No indication of failed target found. > Hint: Try searching the build log for '] Error'. > Hint: See doc/building.html#troubleshooting for assistance. > > make[1]: *** [/home/zifeihan/riscv-port-jdk17u/make/Init.gmk:315: main] Error 2 > make: *** [/home/zifeihan/riscv-port-jdk17u/make/Init.gmk:186: default] Error 2 > > Compile normally after fix. OK. Thanks. ------------- Marked as reviewed by fyang (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/22#pullrequestreview-1351926025 From fyang at openjdk.org Wed Mar 22 08:15:12 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 22 Mar 2023 08:15:12 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8297644: RISC-V: Compilation error when shenandoah is disabled In-Reply-To: References: Message-ID: On Wed, 22 Mar 2023 07:43:11 GMT, Gui Cao wrote: > Please help review this backport to riscv-port-jdk17u. > Backport of [JDK-8297644](https://bugs.openjdk.org/browse/JDK-8297644). Applies cleanly. > The compilation failed before the modification as follows: > > Creating support/modules_libs/java.base/server/libjvm.so from 975 file(s) > /home/zifeihan/riscv-port-jdk17u/src/hotspot/cpu/riscv/riscv.ad: In member function 'virtual void MachPrologNode::emit(CodeBuffer&, PhaseRegAlloc*) const': > /home/zifeihan/riscv-port-jdk17u/src/hotspot/cpu/riscv/riscv.ad:1351:7: error: invalid use of incomplete type 'class BarrierSetAssembler' > 1351 | bs->nmethod_entry_barrier(&_masm); > | ^~ > In file included from /home/zifeihan/riscv-port-jdk17u/src/hotspot/share/gc/shared/modRefBarrierSet.hpp:28, > from /home/zifeihan/riscv-port-jdk17u/src/hotspot/share/gc/shared/cardTableBarrierSet.hpp:29, > from /home/zifeihan/riscv-port-jdk17u/src/hotspot/cpu/riscv/riscv.ad:960, > from ad_riscv.cpp:31: > /home/zifeihan/riscv-port-jdk17u/src/hotspot/share/gc/shared/barrierSet.hpp:36:7: note: forward declaration of 'class BarrierSetAssembler' > 36 | class BarrierSetAssembler; > | ^~~~~~~~~~~~~~~~~~~ > ... > === End of repeated output === > > No indication of failed target found. > Hint: Try searching the build log for '] Error'. > Hint: See doc/building.html#troubleshooting for assistance. > > make[1]: *** [/home/zifeihan/riscv-port-jdk17u/make/Init.gmk:315: main] Error 2 > make: *** [/home/zifeihan/riscv-port-jdk17u/make/Init.gmk:186: default] Error 2 > > Compile normally after fix. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/22 From duke at openjdk.org Wed Mar 22 08:16:04 2023 From: duke at openjdk.org (duke) Date: Wed, 22 Mar 2023 08:16:04 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8297644: RISC-V: Compilation error when shenandoah is disabled Message-ID: Changeset: 1201b31e Author: zifeihan Committer: GitHub Date: 2023-03-22 16:12:57 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/1201b31e2841f74236875034caa1b796bb0cf7fa 8297644: RISC-V: Compilation error when shenandoah is disabled ! src/hotspot/cpu/riscv/riscv.ad From duke at openjdk.org Wed Mar 22 08:27:25 2023 From: duke at openjdk.org (duke) Date: Wed, 22 Mar 2023 08:27:25 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8285699: riscv: Provide information when hitting a HaltNode Message-ID: <3409c564-0e2c-4029-bf05-4f07c10f585d@openjdk.org> Changeset: 6f3d1ab1 Author: zhengxiaolinX Committer: GitHub Date: 2023-03-22 16:25:10 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/6f3d1ab19cea5b2f6f48c7f9dd2f3d9e9f270587 8285699: riscv: Provide information when hitting a HaltNode ! src/hotspot/cpu/riscv/assembler_riscv.hpp ! src/hotspot/cpu/riscv/frame_riscv.hpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.hpp ! src/hotspot/cpu/riscv/nativeInst_riscv.cpp ! src/hotspot/cpu/riscv/riscv.ad ! src/hotspot/cpu/riscv/stubGenerator_riscv.cpp ! src/hotspot/cpu/riscv/templateInterpreterGenerator_riscv.cpp ! src/hotspot/os_cpu/linux_riscv/os_linux_riscv.cpp From fyang at openjdk.org Wed Mar 22 08:29:15 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 22 Mar 2023 08:29:15 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8285699: riscv: Provide information when hitting a HaltNode In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 04:22:58 GMT, Xiaolin Zheng wrote: > Backport one Yadong's patch, which can cleanup some RVC things. > > Tested along with other patches, hotspot tier1~4 with fastdebug build. Looks good. Thanks. ------------- Marked as reviewed by fyang (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/21#pullrequestreview-1351944028 From fyang at openjdk.org Wed Mar 22 08:29:15 2023 From: fyang at openjdk.org (Fei Yang) Date: Wed, 22 Mar 2023 08:29:15 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8285699: riscv: Provide information when hitting a HaltNode In-Reply-To: References: Message-ID: On Tue, 21 Mar 2023 04:22:58 GMT, Xiaolin Zheng wrote: > Backport one Yadong's patch, which can cleanup some RVC things. > > Tested along with other patches, hotspot tier1~4 with fastdebug build. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/21 From xlinzheng at openjdk.org Wed Mar 22 10:25:16 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Wed, 22 Mar 2023 10:25:16 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8294086: RISC-V: Cleanup InstructionMark usages in the backend Message-ID: Backport one RVC-related patch (3rd, 8 in total). The remaining patches seem to be linear and cannot be submitted concurrently. Tested along with remaining RVC patches, hotspot tier1~4 with fastdebug build. ------------- Commit messages: - 8294086: RISC-V: Cleanup InstructionMark usages in the backend Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/23/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=23&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294086 Stats: 21 lines in 3 files changed: 0 ins; 12 del; 9 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/23.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/23/head:pull/23 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/23 From fyang at openjdk.org Thu Mar 23 09:15:19 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 23 Mar 2023 09:15:19 GMT Subject: [riscv-port-jdk17u:riscv-port] Withdrawn: 8294086: RISC-V: Cleanup InstructionMark usages in the backend In-Reply-To: References: Message-ID: <0YTZS5DgAqVAWRFidZTxelYseooBq1tQcK970L4YAPY=.da435d8a-09a2-4730-a94f-2468275f9d06@github.com> On Wed, 22 Mar 2023 10:16:57 GMT, Xiaolin Zheng wrote: > Backport one RVC-related patch (3rd, 8 in total). The remaining patches seem to be linear and cannot be submitted concurrently. > > Tested along with remaining RVC patches, hotspot tier1~4 with fastdebug build. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk17u/pull/23 From duke at openjdk.org Thu Mar 23 09:12:53 2023 From: duke at openjdk.org (duke) Date: Thu, 23 Mar 2023 09:12:53 GMT Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 8294086: RISC-V: Cleanup InstructionMark usages in the backend Message-ID: <5414e038-f13d-4a7e-bfaa-852559376717@openjdk.org> Changeset: c3083f9a Author: zhengxiaolinX Committer: GitHub Date: 2023-03-23 17:12:36 +0000 URL: https://git.openjdk.org/riscv-port-jdk17u/commit/c3083f9a68f493ea0b214d0182c08f406ebc0fc3 8294086: RISC-V: Cleanup InstructionMark usages in the backend Reviewed-by: fjiang, fyang ! src/hotspot/cpu/riscv/assembler_riscv.hpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.hpp From fyang at openjdk.org Thu Mar 23 09:15:19 2023 From: fyang at openjdk.org (Fei Yang) Date: Thu, 23 Mar 2023 09:15:19 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8294086: RISC-V: Cleanup InstructionMark usages in the backend In-Reply-To: References: Message-ID: <_xXmqr-SgpkAUqK5FHQ9efDLSTO3SyppzkIT-0QmiVU=.92fbc311-1d73-478b-9ca6-5f31c686989a@github.com> On Wed, 22 Mar 2023 10:16:57 GMT, Xiaolin Zheng wrote: > Backport one RVC-related patch (3rd, 8 in total). The remaining patches seem to be linear and cannot be submitted concurrently. > > Tested along with remaining RVC patches, hotspot tier1~4 with fastdebug build. Looks good. ------------- Marked as reviewed by fyang (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/23#pullrequestreview-1354148000 From xlinzheng at openjdk.org Thu Mar 23 10:00:19 2023 From: xlinzheng at openjdk.org (Xiaolin Zheng) Date: Thu, 23 Mar 2023 10:00:19 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate() Message-ID: Tested along with remaining patches, hotspot tier1~4 with fastdebug build. ------------- Commit messages: - 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate() Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/24/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=24&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294187 Stats: 33 lines in 7 files changed: 3 ins; 18 del; 12 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/24.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/24/head:pull/24 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/24 From lgxbslgx at gmail.com Thu Mar 23 16:12:56 2023 From: lgxbslgx at gmail.com (Guoxiong Li) Date: Fri, 24 Mar 2023 00:12:56 +0800 Subject: The building document about RISC-V Message-ID: Hi all, I noticed there is no content about the risc-v port in the building document [1]. And the link [2] in the wiki, which may be related to the building, can't be opened now (it returns 404 status code). So it is good to add the risc-v content into the building document. Has somebody started the work locally? Or does someone intend to do that? If not, I can provide a patch. Best Regards, -- Guoxiong [1] https://github.com/openjdk/jdk/blob/master/doc/building.md [2] http://cr.openjdk.java.net/~fyang/openjdk-riscv-port/BuildRISCVJDK.md [3] https://wiki.openjdk.org/display/RISCVPort -------------- next part -------------- An HTML attachment was scrubbed... URL: From dzhang at openjdk.org Thu Mar 23 16:19:32 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 23 Mar 2023 16:19:32 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8300109: RISC-V: Improve code generation for MinI/MaxI nodes Message-ID: Please review this backport to riscv-port-jdk17u. Backport of [JDK-8300109](https://bugs.openjdk.org/browse/JDK-8300109). Applies cleanly. Testing: - Tier1 passed without new failure on unmacthed (release). ------------- Commit messages: - 8300109: RISC-V: Improve code generation for MinI/MaxI node Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/25/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=25&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300109 Stats: 92 lines in 1 file changed: 90 ins; 0 del; 2 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/25.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/25/head:pull/25 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/25 From dzhang at openjdk.org Thu Mar 23 16:45:23 2023 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 23 Mar 2023 16:45:23 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8297715: RISC-V: C2: Use single-bit instructions from the Zbs extension Message-ID: Please review this backport to riscv-port-jdk17u. Backport of [JDK-8297715](https://bugs.openjdk.org/browse/JDK-8297715). The original patch cannot be directly applied because of the line number, but there are no other additional changes. The effect is that we could then optimize C2 JIT code for methods like (print with case `xml.validation` in SPECjvm2008): Before: 03c lhu R28, [R11, #12] # short, #@loadUS ! Field: com/sun/org/apache/xerces/internal/dom/NodeImpl.flags 040 + andi R7, R28, #2 #@andI_reg_imm 044 + snez R10, R7 #@convI2Bool After: 03c lhu R28, [R11, #12] # short, #@loadUS ! Field: com/sun/org/apache/xerces/internal/dom/NodeImpl.flags 040 + bexti R10, R28, #2 #@convI2Bool_andI_reg_immIpowerOf2 Testing: - Tier1 passed without new failure on unmacthed (release). ------------- Commit messages: - 8297715: RISC-V: C2: Use single-bit instructions from the Zbs extension Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/26/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=26&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297715 Stats: 25 lines in 4 files changed: 24 ins; 0 del; 1 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/26.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/26/head:pull/26 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/26 From vkempik at openjdk.org Thu Mar 23 17:06:26 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Thu, 23 Mar 2023 17:06:26 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8297715: RISC-V: C2: Use single-bit instructions from the Zbs extension In-Reply-To: References: Message-ID: On Thu, 23 Mar 2023 16:17:36 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8297715](https://bugs.openjdk.org/browse/JDK-8297715). > The original patch cannot be directly applied because of the line number, but there are no other additional changes. > > The effect is that we could then optimize C2 JIT code for methods like (print with case `xml.validation` in SPECjvm2008): > Before: > > 03c lhu R28, [R11, #12] # short, #@loadUS ! Field: com/sun/org/apache/xerces/internal/dom/NodeImpl.flags > 040 + andi R7, R28, #2 #@andI_reg_imm > 044 + snez R10, R7 #@convI2Bool > > After: > > 03c lhu R28, [R11, #12] # short, #@loadUS ! Field: com/sun/org/apache/xerces/internal/dom/NodeImpl.flags > 040 + bexti R10, R28, #2 #@convI2Bool_andI_reg_immIpowerOf2 > > > Testing: > - Tier1 passed without new failure on unmacthed (release). Marked as reviewed by vkempik (Reviewer). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/26#pullrequestreview-1355087289 From gcao at openjdk.org Fri Mar 24 01:51:53 2023 From: gcao at openjdk.org (Gui Cao) Date: Fri, 24 Mar 2023 01:51:53 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296136: Use correct register in aarch64_enc_fast_unlock() Message-ID: Please help review this backport to riscv-port-jdk17u. Backport of [JDK-8296136](https://bugs.openjdk.org/browse/JDK-8296136). Testing: - Tier1 passed without new failure on qemu (release). ------------- Commit messages: - backport 8296136: Use correct register in aarch64_enc_fast_unlock() Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/27/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=27&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296136 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/27.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/27/head:pull/27 PR: https://git.openjdk.org/riscv-port-jdk17u/pull/27 From vkempik at openjdk.org Fri Mar 24 06:43:23 2023 From: vkempik at openjdk.org (Vladimir Kempik) Date: Fri, 24 Mar 2023 06:43:23 GMT Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296136: Use correct register in aarch64_enc_fast_unlock() In-Reply-To: References: