From vkempik at openjdk.org  Tue May  2 05:12:41 2023
From: vkempik at openjdk.org (Vladimir Kempik)
Date: Tue, 2 May 2023 05:12:41 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8297359: RISC-V: improve
 performance of floating Max Min intrinsics
In-Reply-To: <XiQ3m8K6QTI0V4Ri-uVA-JAc4Wyb6fOQXulNyhGewPY=.38c626f9-6744-4d2a-940c-14ca1a2fb43e@github.com>
References: <XiQ3m8K6QTI0V4Ri-uVA-JAc4Wyb6fOQXulNyhGewPY=.38c626f9-6744-4d2a-940c-14ca1a2fb43e@github.com>
Message-ID: <SY-9IQDbdnOJqJBmSniAnxcib6I1ejQtSLYcoabXyD8=.e4ccb6e3-e888-428c-87bc-2d39ea8eae6d@github.com>

On Fri, 28 Apr 2023 22:19:20 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

> Please review this clean backport of JDK-[8297359](https://bugs.openjdk.org/browse/JDK-8297359) to jdk17u riscv port dev
> This significantly improves performance of fp min/max instrinsics.
> Results are same as in upstream jdk - https://mail.openjdk.org/pipermail/riscv-port-dev/2022-November/000684.html

tier1/2 clean

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/49#issuecomment-1530888616

From vladimir.kempik at gmail.com  Wed May  3 08:53:58 2023
From: vladimir.kempik at gmail.com (Vladimir Kempik)
Date: Wed, 3 May 2023 11:53:58 +0300
Subject: safepointing. read vs write
Message-ID: <7586A24E-8438-4BCA-BCB1-4B396E69F171@gmail.com>

Hello

Just wanted to share some results of my analysis.

I have changed safepoints from reading polling page ( lwu to x0) to writing to polling page ( sw from x0).

here are results:

polling page  read
Benchmark                                                          Mode  Cnt   Score    Error  Units
InterfaceCalls.testInterfaceCastAndCall                            avgt   25  32.192 ?  0.364  ns/op
InterfaceCalls.testInterfaceCastAndCall:L1-dcache-load-misses:u    avgt    5   0.001 ?  0.001   #/op
InterfaceCalls.testInterfaceCastAndCall:L1-dcache-loads:u          avgt    5   9.036 ?  0.072   #/op
InterfaceCalls.testInterfaceCastAndCall:L1-dcache-stores:u         avgt    5   0.019 ?  0.025   #/op
InterfaceCalls.testInterfaceCastAndCall:LLC-loads:u                avgt    5   0.005 ?  0.007   #/op
InterfaceCalls.testInterfaceCastAndCall:LLC-stores:u               avgt    5   0.002 ?  0.002   #/op
InterfaceCalls.testInterfaceCastAndCall:branch-misses:u            avgt    5   0.001 ?  0.001   #/op
InterfaceCalls.testInterfaceCastAndCall:branches:u                 avgt    5   4.014 ?  0.029   #/op
InterfaceCalls.testInterfaceCastAndCall:cycles:u                   avgt    5  38.777 ?  2.444   #/op
InterfaceCalls.testInterfaceCastAndCall:instructions:u             avgt    5  15.121 ?  0.200   #/op
InterfaceCalls.testInterfaceCastAndCall:stalled-cycles-frontend:u  avgt    5   0.001 ?  0.002   #/op

polling page write
Benchmark                                                          Mode  Cnt   Score    Error  Units
InterfaceCalls.testInterfaceCastAndCall                            avgt   25  30.326 ?  0.257  ns/op
InterfaceCalls.testInterfaceCastAndCall:L1-dcache-load-misses:u    avgt    5   0.001 ?  0.001   #/op
InterfaceCalls.testInterfaceCastAndCall:L1-dcache-loads:u          avgt    5   8.035 ?  0.016   #/op
InterfaceCalls.testInterfaceCastAndCall:L1-dcache-stores:u         avgt    5   1.016 ?  0.012   #/op
InterfaceCalls.testInterfaceCastAndCall:LLC-loads:u                avgt    5   0.004 ?  0.004   #/op
InterfaceCalls.testInterfaceCastAndCall:LLC-stores:u               avgt    5   0.001 ?  0.001   #/op
InterfaceCalls.testInterfaceCastAndCall:branch-misses:u            avgt    5   0.001 ?  0.001   #/op
InterfaceCalls.testInterfaceCastAndCall:branches:u                 avgt    5   4.014 ?  0.007   #/op
InterfaceCalls.testInterfaceCastAndCall:cycles:u                   avgt    5  36.552 ?  1.662   #/op
InterfaceCalls.testInterfaceCastAndCall:instructions:u             avgt    5  15.110 ?  0.062   #/op
InterfaceCalls.testInterfaceCastAndCall:stalled-cycles-frontend:u  avgt    5   0.001 ?  0.001   #/op



Minus one 1 l1 load, Plus one l1 store, it?s obvious. Since stores are cheaper (for cpu core, not for caches), total cycles got reduced.
One another hand, stores storm should generate some traffic from l1d to LLC and then to RAM which may slow down another threads/apps.

Regards, Vladimir
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/riscv-port-dev/attachments/20230503/6f2d1bbf/attachment-0001.htm>

From duke at openjdk.org  Mon May 15 06:43:15 2023
From: duke at openjdk.org (duke)
Date: Mon, 15 May 2023 06:43:15 GMT
Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 60 new changesets
Message-ID: <bd9da7ad-fee1-4c27-b7cc-a6b30bac6116@openjdk.org>

Changeset: 1dee04a7
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-04-25 06:00:09 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/1dee04a76fd95f167524b83e0404d3c8d8fe2690

8278146: G1: Rework VM_G1Concurrent VMOp to clearly identify it as pause

Reviewed-by: tschatzl
Backport-of: 3a1fca3adf3111a966cb62d926b95acc89b7fe97

! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp
! src/hotspot/share/gc/g1/g1VMOperations.cpp
! src/hotspot/share/gc/g1/g1VMOperations.hpp
! src/hotspot/share/runtime/vmOperation.hpp

Changeset: ee63f83e
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-04-25 09:55:28 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/ee63f83ed705c9cd3c49316fc4936668744f415d

8296412: Special case infinite loops with unmerged backedges in IdealLoopTree::check_safepts

Backport-of: da38d43fcc640ea9852db6c7c23817dcef7080d5

! src/hotspot/share/opto/loopnode.cpp
+ test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedges.jasm
+ test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java

Changeset: 3e0e4f0e
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-04-25 09:56:58 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/3e0e4f0eadb52d09a598535a30d00c2b9374d757

8301338: Identical branch conditions in CompileBroker::print_heapinfo

Reviewed-by: mbaesken
Backport-of: d583767bf17aea55d361a1d1713444fc41fa9911

! src/hotspot/share/compiler/compileBroker.cpp

Changeset: d9642295
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-04-25 09:58:34 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/d964229552eb72bac8960ce12ecb6729162f98a2

8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline

Backport-of: 1ef9f6507ba45419f0fa896915eec064762c5153

! src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java

Changeset: 24e91c1e
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-04-25 10:02:48 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/24e91c1e5adee3e787b90128b402deb231f3b178

8302594: use-after-free in Node::destruct

Backport-of: 2e3cea01daca594dfa4477439a9849eea19b249e

! src/hotspot/share/opto/node.cpp

Changeset: e6e6bedf
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-04-25 15:12:44 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/e6e6bedf7b7898a88dedce79600a473832871e9c

8252990: Intrinsify Unsafe.storeStoreFence

Backport-of: b7a06be98d3057dac4adbb7f4071ac62cf88fe52

! src/hotspot/cpu/aarch64/aarch64.ad
! src/hotspot/cpu/arm/arm.ad
! src/hotspot/cpu/ppc/ppc.ad
! src/hotspot/cpu/s390/s390.ad
! src/hotspot/cpu/x86/x86_32.ad
! src/hotspot/cpu/x86/x86_64.ad
! src/hotspot/share/adlc/formssel.cpp
! src/hotspot/share/c1/c1_Compiler.cpp
! src/hotspot/share/c1/c1_LIRGenerator.cpp
! src/hotspot/share/classfile/vmIntrinsics.hpp
! src/hotspot/share/opto/c2compiler.cpp
! src/hotspot/share/opto/classes.hpp
! src/hotspot/share/opto/library_call.cpp
! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/opto/memnode.hpp
! src/java.base/share/classes/jdk/internal/misc/Unsafe.java

Changeset: bf0606a9
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-04-25 15:14:36 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/bf0606a9b735b555a860a99139c09c2bc1da1600

8283566: G1: Improve G1BarrierSet::enqueue performance

Reviewed-by: tschatzl
Backport-of: 6ebf845ff7d758c99367488818427fcb7a5dbda9

! src/hotspot/share/gc/g1/g1BarrierSet.cpp
! src/hotspot/share/gc/g1/g1BarrierSet.hpp
! src/hotspot/share/gc/g1/g1BarrierSet.inline.hpp
! src/hotspot/share/gc/g1/g1CollectedHeap.cpp

Changeset: d5cbf22f
Author:    Christoph Langer <clanger at openjdk.org>
Date:      2023-04-25 16:45:03 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/d5cbf22f23a5c3ecf97f9f0b23c19b435c6e266b

8306658: GHA: MSVC installation could be optional since it might already be pre-installed

Backport-of: d980cb48793f2bb662aece545fb00724c12a5613

! .github/workflows/build-windows.yml

Changeset: e1326051
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-04-25 20:15:51 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/e132605161ff25cdac0d993ab8ab41f75f367200

8296545: C2 Blackholes should allow load optimizations

Reviewed-by: mdoerr
Backport-of: eab0ada3a16a432fdfd1f0b8fceca149c725451b

! src/hotspot/share/opto/cfgnode.cpp
! src/hotspot/share/opto/cfgnode.hpp
! src/hotspot/share/opto/library_call.cpp
! src/hotspot/share/opto/memnode.cpp
! src/hotspot/share/opto/memnode.hpp
! src/hotspot/share/runtime/vmStructs.cpp
+ test/hotspot/jtreg/compiler/c2/irTests/blackhole/BlackholeLoadOptoTest.java
! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java

Changeset: 243e6430
Author:    Anton Kozlov <akozlov at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-04-26 11:44:03 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/243e643076f70c2cfb480897e1640a21e7ac6552

8306768: CodeCache Analytics reports wrong threshold

Reviewed-by: phh

! src/hotspot/share/code/codeHeapState.cpp

Changeset: 394a7562
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-04-27 06:49:42 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/394a7562cfd065c060387575fe3c811bf1b94de1

8254711: Add java.security.Provider.getService JFR Event
8294673: JFR: Add SecurityProviderService#threshold to TestActiveSettingEvent.java

Reviewed-by: mbaesken
Backport-of: bc2af47e1e4e6e96020e03a60ce098ddd17f63ba

! src/java.base/share/classes/java/security/Provider.java
+ src/java.base/share/classes/jdk/internal/event/SecurityProviderServiceEvent.java
+ src/jdk.jfr/share/classes/jdk/jfr/events/SecurityProviderServiceEvent.java
! src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java
! src/jdk.jfr/share/conf/jfr/default.jfc
! src/jdk.jfr/share/conf/jfr/profile.jfc
! test/jdk/jdk/jfr/event/metadata/TestDefaultConfigurations.java
! test/jdk/jdk/jfr/event/runtime/TestActiveSettingEvent.java
+ test/jdk/jdk/jfr/event/security/TestSecurityProviderServiceEvent.java
! test/lib/jdk/test/lib/jfr/EventNames.java

Changeset: 790802bd
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-04-27 06:51:07 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/790802bdd5cc6cd2a20674454c02c0f4366dbf21

8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG

Backport-of: 2157145766f9789ade0940e9ae1715a3b74d508b

! src/java.base/share/classes/sun/security/pkcs/PKCS7.java

Changeset: da740fa6
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-04-27 06:58:18 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/da740fa6fa89b99b618037786bbc5207a76a5ba8

8302595: use-after-free related to GraphKit::clone_map

Reviewed-by: rrich
Backport-of: 3cc459b6c2f571987dc36fd548a2b830f0b33a0a

! src/hotspot/share/opto/compile.hpp
! src/hotspot/share/opto/graphKit.cpp
! src/hotspot/share/opto/graphKit.hpp
! src/hotspot/share/opto/library_call.cpp
! src/hotspot/share/opto/node.hpp
! src/hotspot/share/opto/phaseX.hpp
! src/hotspot/share/opto/vectorIntrinsics.cpp

Changeset: ac823d34
Author:    Christoph Langer <clanger at openjdk.org>
Date:      2023-04-27 08:40:42 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/ac823d3453dcb36551a104bbfdee386e11f68f2f

8306664: GHA: Update MSVC version to latest stepping

Reviewed-by: shade

! .github/workflows/main.yml

Changeset: 52324b55
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-04-27 10:27:40 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/52324b55fb7be2cd1ba9e843ece93375ac23649c

8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument

Reviewed-by: mdoerr
Backport-of: 45e4e00981ef8b4bf143afce0889698319273c1d

! src/hotspot/share/opto/library_call.cpp
+ test/hotspot/jtreg/compiler/intrinsics/string/TestCopyValueOf.java

Changeset: 48632e51
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-04-27 10:32:13 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/48632e51c78cdda61a789e5781244eff3cf6eb9b

8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument

Backport-of: 47ca5773a54743244a9b28f877246d260b90a408

! src/hotspot/share/opto/library_call.cpp
+ test/hotspot/jtreg/compiler/intrinsics/string/TestStringIndexOfCharIntrinsics.java

Changeset: 241c066a
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-04-27 10:36:28 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/241c066a28edc3f72a50092846f49fe30d82e222

8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior

Backport-of: cd77fcfb5f9156e5f0909fa15a842dde6c25c66a

! src/hotspot/share/opto/loopTransform.cpp

Changeset: b90d9170
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-04-27 10:44:19 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/b90d91703225fb508b454d815981786876b7cbbe

8303130: Document required Accessibility permissions on macOS

Reviewed-by: dmarkov
Backport-of: a10d5ac61be3d074937f629959c7aeb694147203

! doc/testing.html
! doc/testing.md

Changeset: 1ba2d531
Author:    William Kemper <wkemper at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-04-27 15:53:58 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/1ba2d5310ad80ab595cb2ee7ad62cbe569d0110c

8305403: Shenandoah evacuation workers may deadlock

Reviewed-by: shade
Backport-of: 793da60ee833d09db0f6f14b50a7cbd7f4549e3b

! src/hotspot/share/gc/shenandoah/mode/shenandoahIUMode.cpp
! src/hotspot/share/gc/shenandoah/mode/shenandoahSATBMode.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp

Changeset: a4850332
Author:    Thomas Stuefe <stuefe at openjdk.org>
Date:      2023-04-28 14:10:44 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/a4850332065acc2c0713f1bb79cb3b175ab8c213

8306883: Thread stacksize is reported with wrong units in os::create_thread logging

Backport-of: 27c5c1070ac559caa8dbad598337046f59355464

! src/hotspot/os/aix/os_aix.cpp
! src/hotspot/os/bsd/os_bsd.cpp
! src/hotspot/os/linux/os_linux.cpp
! src/hotspot/os/windows/os_windows.cpp

Changeset: b2f16a59
Author:    Christoph Langer <clanger at openjdk.org>
Date:      2023-04-28 15:50:17 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/b2f16a5926c74146fe37b0373cc053d4fc3fd2a4

8289735: UTIL_LOOKUP_PROGS fails on pathes with space
8306976: UTIL_REQUIRE_SPECIAL warning on grep

Reviewed-by: mbaesken
Backport-of: bad6aa68e4d491e819ab22e91dd5d65bb094120e

! make/autoconf/basic.m4
! make/autoconf/basic_tools.m4
! make/autoconf/configure.ac
! make/autoconf/platform.m4

Changeset: aa8c46ca
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-02 07:04:09 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/aa8c46ca52c2f983470ab4c05e64c1ae85aa3b8e

8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr

Backport-of: c3ff151457102cd45e3c7a49a235a04066beca60

! src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LaneType.java

Changeset: 5296357f
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-05-03 08:04:00 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/5296357fe27ac9f68c635cd1ba324c4985934354

8303822: gtestMain should give more helpful output

Backport-of: 0f26d09da881b1dfedfc0dcaff46fc169fa1f020

! test/hotspot/gtest/gtestMain.cpp

Changeset: 07993bfa
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-03 08:29:17 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/07993bfa8862012c362fa44c271b102029eb438a

8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies

Backport-of: bc28baeba9360991e9b7575e1fbe178d873ccfc1

! src/jdk.internal.le/share/legal/jline.md

Changeset: 65a02dab
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-03 08:32:52 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/65a02dab9226191ae8d1b5a0884fcdba7674b797

8303476: Add the runtime version in the release file of a JDK image

Backport-of: 32247c336a189a40f696626a2578c65535ef6376

! make/ReleaseFile.gmk
+ test/jdk/build/releaseFile/CheckReleaseFile.java
- test/jdk/build/releaseFile/CheckSource.java

Changeset: 96adf073
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-03 08:37:05 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/96adf073565e9a65912392510df8575e49695734

8297955: LDAP CertStore should use LdapName and not String for DNs
8224768: Test ActalisCA.java fails

Backport-of: df9aad018a769a27221cb29e4e66465e5d98ba94

! src/java.naming/share/classes/sun/security/provider/certpath/ldap/LDAPCertStoreImpl.java
! test/jdk/ProblemList.txt
! test/jdk/security/infra/java/security/cert/CertPathValidator/certification/ActalisCA.java

Changeset: 5ed96968
Author:    Sergey Nazarkin <snazarki at openjdk.org>
Date:      2023-05-04 09:44:40 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/5ed96968109147ae2ef3485b182a4027c439f497

8305481: gtest is_first_C_frame failing on ARM

Backport-of: 0243da2e4adc1b7ab6fcd5b10778532101158dce

! test/hotspot/gtest/runtime/test_os.cpp

Changeset: 345e370f
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
Date:      2023-05-04 09:45:30 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/345e370fed065e2ee312fc315bfc453a29fbb2f0

8303861: Error handling step timeouts should never be blocked by OnError and others

Reviewed-by: phh, stuefe
Backport-of: a00f5d24d3824e3ab84208401a967efe0e7bf88e

! src/hotspot/share/runtime/nonJavaThread.cpp
! src/hotspot/share/utilities/vmError.cpp
! test/hotspot/jtreg/runtime/ErrorHandling/TimeoutInErrorHandlingTest.java

Changeset: 04eb720d
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-04 10:53:25 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/04eb720d03edc37d7e1cb32c909c31c40485d7a8

8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling

Reviewed-by: shade
Backport-of: 3f2d929dc3336b301e7e5dceb899d59451645828

! src/hotspot/share/opto/loopopts.cpp
+ test/hotspot/jtreg/compiler/loopstripmining/TestAddPAtOuterLoopHead.java

Changeset: 820030a5
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-04 10:56:45 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/820030a5a953b1684ea66c5cb4c698d4e4dd57b6

8303564: C2: "Bad graph detected in build_loop_late" after a CMove is wrongly split thru phi

Backport-of: 5e232cf0a96cf81036a2d9d7814127b7bc9ebab1

! src/hotspot/share/opto/loopopts.cpp
+ test/hotspot/jtreg/compiler/loopopts/TestWrongCMovSplitIf.java

Changeset: 1d7b9add
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-04 10:59:24 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/1d7b9add2664ce708ac20c971df8ef8f2b00afd4

8303069: Memory leak in CompilerOracle::parse_from_line

Backport-of: 384a8b85a7266b920242ea73baf578577ca588ec

! src/hotspot/share/compiler/compilerOracle.cpp

Changeset: d8d69f36
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-04 11:02:18 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/d8d69f3674ed98084a4d661a9e5c527921688c03

8303508: Vector.lane() gets wrong value on x86

Backport-of: d61de141eb8ba52122db43172429f9186ea47e61

! src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp
! src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp
+ test/hotspot/jtreg/compiler/vectorapi/Test8303508.java

Changeset: 79aa7b15
Author:    Christoph Langer <clanger at openjdk.org>
Date:      2023-05-04 15:10:52 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/79aa7b15dbc54de891838ae2d4ca63838028c157

8257856: Make ClassFileVersionsTest.java robust to JDK version updates

Reviewed-by: mbaesken
Backport-of: 8b042d14b78c66b50495d0d8b559ca3f6744d806

! test/jdk/java/lang/module/ClassFileVersionsTest.java

Changeset: 547667df
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-05 12:42:43 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/547667dff63ef851a97a5c4629c6d2a83edb6317

8305994: Guarantee eventual async monitor deflation

Reviewed-by: eastigeevich, simonis
Backport-of: 6b81342c2215041dbb7e9020a67cdc56976c97b1

! src/hotspot/share/runtime/globals.hpp
! src/hotspot/share/runtime/monitorDeflationThread.cpp
! src/hotspot/share/runtime/synchronizer.cpp
+ test/hotspot/jtreg/runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java

Changeset: 58c9f6a9
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-05 15:40:23 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/58c9f6a92b46d7373794496e85d5f6a031f70d23

8306774: Make runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java more reliable

Reviewed-by: serb, simonis
Backport-of: 9ad6dc881d285cc26c136f0ef19af5bac0a75022

! test/hotspot/jtreg/runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java

Changeset: 31bbf9f4
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-05 20:53:25 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/31bbf9f4a6f61befe426cd9d1de2e1874ddd765f

8306825: Monitor deflation might be accidentally disabled by zero intervals

Backport-of: a6b4f25bd50e6861281d162f143c5bc9c16bac51

! src/hotspot/share/runtime/globals.hpp
! src/hotspot/share/runtime/monitorDeflationThread.cpp
+ test/hotspot/jtreg/runtime/Monitor/DeflationIntervalsTest.java
- test/hotspot/jtreg/runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java

Changeset: fc1d3d3f
Author:    Tyler Steele <tsteele at openjdk.org>
Committer: Martin Doerr <mdoerr at openjdk.org>
Date:      2023-05-06 20:02:31 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/fc1d3d3fadf1ed369f889caf6d8c867b27846bb3

8304291: [AIX] Broken build after JDK-8301998

Backport-of: 310aa9347861922af5f0311e9e93a5f49dee6adc

! src/java.desktop/share/native/libharfbuzz/hb-algs.hh
! src/java.desktop/share/native/libharfbuzz/hb-subset.cc

Changeset: 6dbd5a68
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-08 07:54:27 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/6dbd5a68c7c1e8f433c3e1c9a0e0746f8d9d730f

8275735: [linux] Remove deprecated Metrics api (kernel memory limit)

Backport-of: 9971a2cab3892a17f3fd39243df5ecfff5b9f108

! src/java.base/linux/classes/jdk/internal/platform/CgroupV1Metrics.java
! src/java.base/linux/classes/jdk/internal/platform/CgroupV1MetricsImpl.java
! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java
! test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java
! test/jdk/jdk/internal/platform/docker/TestDockerMemoryMetrics.java
! test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java

Changeset: 72515481
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-08 07:56:52 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/725154813f61ec5b2ee38261867735b5d8dfa9f4

8283057: Update GCC to version 11.2.0 for Oracle builds on Linux

Reviewed-by: mbaesken
Backport-of: 8384ac4ed3eaaa18998ab88e1ca36358c212e699

! doc/building.html
! doc/building.md
! make/conf/jib-profiles.js
! make/devkit/Tools.gmk

Changeset: 7dab7e55
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-08 08:13:22 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/7dab7e5507286c682bf43862ff567ff0d9dfde36

8285987: executing shell scripts without #! fails on Alpine linux

Backport-of: 9d2f591e6a15dc155a8cc3b18a54456d5f9a3aa7

! test/jdk/java/lang/ProcessBuilder/Basic.java
! test/langtools/jdk/jshell/ExternalEditorTest.java
! test/lib/jdk/test/lib/Platform.java

Changeset: 8c541047
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-08 08:23:15 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/8c541047b0bc8178c4ecffdaefa67cab5a76110b

8286191: misc tests fail due to JDK-8285987

Reviewed-by: mbaesken
Backport-of: de8f4d01b234f5224a687dae5db52ab31247c2da

! test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
! test/lib/jdk/test/lib/Platform.java

Changeset: 05f15628
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-08 08:27:56 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/05f15628b0f61e01adf7aa622c968b4f1337ce04

8286398: Address possibly lossy conversions in jdk.internal.le

Backport-of: e534c133af9bcefb073a336f1fdc0dc226a9dd82

! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/WindowsAnsiWriter.java

Changeset: 20fea6c3
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-08 08:52:53 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/20fea6c325a4882572cac576e5dff23652adb3a0

8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName

Backport-of: 1451642317dbe9f941172945e9f366000434653f

! test/hotspot/jtreg/vmTestbase/nsk/jdi/Event/request/request001.java
! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventIterator/nextEvent/nextevent001.java
! test/hotspot/jtreg/vmTestbase/nsk/jdi/LocatableEvent/thread/thread001.java

Changeset: aee7ab68
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-08 08:57:56 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/aee7ab6869a6337256c883e313e4a8b30a46775e

8292990: Improve test coverage for XPath Axes: parent

Backport-of: e393973761eec8fe08d901d93fc5a9261b6faf14

+ test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpParentTest.java
! test/jaxp/javax/xml/jaxp/unittest/xpath/XPathTestBase.java

Changeset: 2aaf3c5b
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-08 09:35:32 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/2aaf3c5b01ddf5363eabfc6832133a2909fc27e3

8296084: javax/swing/JSpinner/4788637/bug4788637.java fails intermittently on a VM

Backport-of: 319faa5afc37df5fd9ce4305e6e38a7bd4b39c65

! test/jdk/javax/swing/JSpinner/4788637/bug4788637.java

Changeset: fafd0820
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-08 09:36:25 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/fafd082046d11acd964e90c72b52cd125bbfdbff

8289509: Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling

Backport-of: 1961e81e02e707cd0c8241aa3af6ddabf7668589

+ test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpDescendantTest.java
+ test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpFollowingTest.java

Changeset: b5e6753a
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-08 10:23:25 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/b5e6753a0901c3475a7b70f0b4c76a43595b4ec2

8297450: ScaledTextFieldBorderTest.java fails when run with -show parameter

Backport-of: ea83cb960d07ffa9384aad6a1e2a0233e3ebbdd1

! test/jdk/javax/swing/border/LineBorder/ScaledTextFieldBorderTest.java

Changeset: 86aca8b2
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-08 10:35:38 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/86aca8b260c2ca5966329c554ea0715c831e77fd

8302508: Add timestamp to the output TraceCompilerThreads

Reviewed-by: shade
Backport-of: f813dc71836e002814622fead8a2b0464b49c83a

! src/hotspot/share/compiler/compileBroker.cpp

Changeset: 3a0aff20
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-08 10:40:15 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/3a0aff20d958efef410773a345c9d322dd31f1e5

8299570: [JVMCI] Insufficient error handling when CodeBuffer is exhausted

Reviewed-by: shade
Backport-of: ad326fc62be9fa29438fb4b59a51c38dd94afd68

! src/hotspot/cpu/aarch64/jvmciCodeInstaller_aarch64.cpp
! src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp
! src/hotspot/cpu/aarch64/nativeInst_aarch64.hpp
! src/hotspot/share/code/compiledIC.hpp
! src/hotspot/share/jvmci/jvmciCodeInstaller.cpp

Changeset: 6a849743
Author:    Guoxiong Li <gli at openjdk.org>
Committer: Jie Fu <jiefu at openjdk.org>
Date:      2023-05-09 07:33:34 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/6a8497437ad11c8afbe7f02390ab5491a9390277

8305690: [X86] Do not emit two REX prefixes in Assembler::prefix

Backport-of: 49726ee3a95023a912aacad0e3714eae146eed21

! src/hotspot/cpu/x86/assembler_x86.cpp

Changeset: b9eca2d8
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-05-10 07:15:00 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/b9eca2d898433d29eab5c3472f2db13b6305ffa3

8305993: Add handleSocketErrorWithMessage to extend nio Net.c exception message

Backport-of: ebba42ac52109ca036f2e721402c06afa8f455bb

! src/java.base/unix/native/libnio/ch/Net.c

Changeset: d4467a72
Author:    Andrew Dinn <adinn at openjdk.org>
Date:      2023-05-10 08:28:04 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/d4467a72e6c1f124b07b0c1e2b753d65d6a41ff1

8307331: Correctly update line maps when class redefine rewrites bytecodes

Backport-of: f94f957734355fe112e861d1f2f0b49df20f6b66

! src/hotspot/share/runtime/relocator.cpp

Changeset: efa17865
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-10 14:37:37 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/efa178650c6b2c78602c9d4ed1ff374dba21f7d7

8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected

Backport-of: 6ccee839580fd9dc4cd4941b44dbbe3105202561

! test/jdk/jdk/internal/platform/cgroup/TestCgroupMetrics.java
! test/jdk/jdk/internal/platform/docker/TestSystemMetrics.java
! test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java

Changeset: 3f529615
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-10 14:41:04 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/3f5296153a528e7b6b8b8128f3725cbef6c14ca9

8296934: Write a test to verify whether Undecorated Frame can be iconified or not

Backport-of: 7845b0d7b4193688448b7bf0c427df4976d302e5

+ test/jdk/java/awt/Frame/Iconify/IconifyTest.java

Changeset: 86561416
Author:    Richard Reingruber <rrich at openjdk.org>
Date:      2023-05-11 07:47:39 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/86561416c87b036f7000910ef58d396a4bbf7ef6

8301216: ForkJoinPool invokeAll() ignores timeout

Reviewed-by: clanger

! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java

Changeset: d5a23099
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-11 08:55:00 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/d5a23099f5c820e0d45fe38578600d197a184b59

8297587: Upgrade JLine to 3.22.0

Reviewed-by: mbaesken
Backport-of: 4619e8bae838abd1f243c2c65a538806d226b8e8

! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Binding.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Candidate.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/CompletingParsedLine.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/CompletionMatcher.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Highlighter.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/History.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReader.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReaderBuilder.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Parser.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/CompletionMatcherImpl.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/DefaultParser.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/LineReaderImpl.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/FileNameCompleter.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/SystemCompleter.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/history/DefaultHistory.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/TerminalBuilder.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractPty.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractWindowsTerminal.java
+ src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/Diag.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ExecPty.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/PosixPtyTerminal.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/PosixSysTerminal.java
+ src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/exec/ExecTerminalProvider.java
- src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/spi/JansiSupport.java
- src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/spi/JnaSupport.java
+ src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/spi/TerminalProvider.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Colors.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Curses.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Display.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/InfoCmp.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlocking.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingInputStream.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingInputStreamImpl.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingPumpInputStream.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingPumpReader.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingReader.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingReaderImpl.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/OSUtils.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/PumpReader.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/StyleResolver.java
+ src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Timeout.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/WCWidth.java
! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/windows-vtp.caps
! src/jdk.internal.le/share/classes/module-info.java
! src/jdk.internal.le/share/legal/jline.md
- src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/JnaSupportImpl.java
+ src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/JnaTerminalProvider.java
! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/JnaWinConsoleWriter.java
! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/JnaWinSysTerminal.java
- src/jdk.internal.le/windows/classes/module-info.java.extra
! test/jdk/jdk/internal/jline/AbstractWindowsTerminalTest.java
! test/jdk/jdk/internal/jline/KeyConversionTest.java
+ test/jdk/jdk/internal/jline/OSUtilsTest.java
! test/langtools/jdk/jshell/ExecPtyGetFlagsToSetTest.java

Changeset: 5b29c6ec
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-05-11 11:04:45 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/5b29c6ec93372b20016565b84d449860b7233d6c

8304867: Explicitly disable dtrace for ppc builds

Reviewed-by: clanger
Backport-of: ff368d504e9101e11c7182185f56255f429d31e3

! make/autoconf/jvm-features.m4

Changeset: 1970b639
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-05-11 11:06:11 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/1970b639fd169f3370c940abe22343e0452ca30a

8304054: Linux: NullPointerException from FontConfiguration.getVersion in case no fonts are installed

Backport-of: 3c7ab80501d7935d6f65b18c1eb2b47b207ffcf9

! src/java.desktop/share/classes/sun/awt/FontConfiguration.java

Changeset: 398da7ec
Author:    Martin Doerr <mdoerr at openjdk.org>
Date:      2023-05-11 12:50:54 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/398da7ec46d04422e530d7742f334a764aabb5b5

8305088: SIGSEGV in Method::is_method_handle_intrinsic

Reviewed-by: mbaesken

! src/hotspot/share/code/nmethod.cpp

Changeset: e92cf807
Author:    Fei Yang <yangfei at iscas.ac.cn>
Date:      2023-05-15 10:24:19 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/e92cf807367592f8cf88d14bc59d7affea04aef0

Merge branch 'master' into riscv-port

! make/autoconf/jvm-features.m4
! make/autoconf/platform.m4
! src/hotspot/os/linux/os_linux.cpp
! test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
! test/lib/jdk/test/lib/Platform.java
! make/autoconf/jvm-features.m4
! make/autoconf/platform.m4
! src/hotspot/os/linux/os_linux.cpp
! test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
! test/lib/jdk/test/lib/Platform.java


From fyang at openjdk.org  Mon May 15 07:07:17 2023
From: fyang at openjdk.org (Fei Yang)
Date: Mon, 15 May 2023 07:07:17 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296435: RISC-V: Small
 refactoring for increment/decrement
In-Reply-To: <IflpxrH-PDnNAe_2ZA5pYLRixn6UjaQPSb25PWho_Ps=.32d7a8ea-68d4-44c2-aca1-4dcf708e863d@github.com>
References: <IflpxrH-PDnNAe_2ZA5pYLRixn6UjaQPSb25PWho_Ps=.32d7a8ea-68d4-44c2-aca1-4dcf708e863d@github.com>
Message-ID: <brTjeB6P-eSbXHAWGcnSYbYvXpoIY86QqTnqmRmU7Hk=.8a9d471b-774f-49c5-9e6b-688df03be1ee@github.com>

On Tue, 25 Apr 2023 08:46:42 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8296435](https://bugs.openjdk.org/browse/JDK-8296435).
> The original patch cannot be directly applied because jdk17u has no [JDK-8286301](https://bugs.openjdk.org/browse/JDK-8286301).
> 
> Testing:
> - Tier1-3 passed without new failure on unmacthed (release).

Looks good.

-------------

Marked as reviewed by fyang (Lead).

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/48#pullrequestreview-1425887538

From dzhang at openjdk.org  Mon May 15 07:10:20 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Mon, 15 May 2023 07:10:20 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296435: RISC-V: Small
 refactoring for increment/decrement
In-Reply-To: <IflpxrH-PDnNAe_2ZA5pYLRixn6UjaQPSb25PWho_Ps=.32d7a8ea-68d4-44c2-aca1-4dcf708e863d@github.com>
References: <IflpxrH-PDnNAe_2ZA5pYLRixn6UjaQPSb25PWho_Ps=.32d7a8ea-68d4-44c2-aca1-4dcf708e863d@github.com>
Message-ID: <HYoLcMaHeOZXNmKxsn_CbIP5V7Su65czpD3Yu5BdD04=.aa27e989-6df8-4e00-acb2-498e792d3dc2@github.com>

On Tue, 25 Apr 2023 08:46:42 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8296435](https://bugs.openjdk.org/browse/JDK-8296435).
> The original patch cannot be directly applied because jdk17u has no [JDK-8286301](https://bugs.openjdk.org/browse/JDK-8286301).
> 
> Testing:
> - Tier1-3 passed without new failure on unmacthed (release).

Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/48#issuecomment-1547302544

From dzhang at openjdk.org  Mon May 15 07:15:16 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Mon, 15 May 2023 07:15:16 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8296435: RISC-V: Small
 refactoring for increment/decrement
In-Reply-To: <IflpxrH-PDnNAe_2ZA5pYLRixn6UjaQPSb25PWho_Ps=.32d7a8ea-68d4-44c2-aca1-4dcf708e863d@github.com>
References: <IflpxrH-PDnNAe_2ZA5pYLRixn6UjaQPSb25PWho_Ps=.32d7a8ea-68d4-44c2-aca1-4dcf708e863d@github.com>
Message-ID: <7liNUBCHOfWaR_jSxSmeTOjXdM7EUQY-A3qfUsSlRIM=.9f13c61f-7246-4154-b161-650b6b027d50@github.com>

On Tue, 25 Apr 2023 08:46:42 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8296435](https://bugs.openjdk.org/browse/JDK-8296435).
> The original patch cannot be directly applied because jdk17u has no [JDK-8286301](https://bugs.openjdk.org/browse/JDK-8286301).
> 
> Testing:
> - Tier1-3 passed without new failure on unmacthed (release).

This pull request has now been integrated.

Changeset: cd7de115
Author:    Dingli Zhang <dzhang at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/cd7de115366e7fc2ce7d8f7f98785a592b992c63
Stats:     36 lines in 3 files changed: 0 ins; 2 del; 34 mod

8296435: RISC-V: Small refactoring for increment/decrement

Reviewed-by: fjiang, fyang
Backport-of: 4c80dff2cab8bc0fcfeca8d21754a28e31e92325

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/48

From fyang at openjdk.org  Mon May 15 07:24:13 2023
From: fyang at openjdk.org (Fei Yang)
Date: Mon, 15 May 2023 07:24:13 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8297359: RISC-V: improve
 performance of floating Max Min intrinsics
In-Reply-To: <XiQ3m8K6QTI0V4Ri-uVA-JAc4Wyb6fOQXulNyhGewPY=.38c626f9-6744-4d2a-940c-14ca1a2fb43e@github.com>
References: <XiQ3m8K6QTI0V4Ri-uVA-JAc4Wyb6fOQXulNyhGewPY=.38c626f9-6744-4d2a-940c-14ca1a2fb43e@github.com>
Message-ID: <f6NpXDeolZlLBp_IkRF7XSRPu8zUEURxFp7pngBeNNk=.b0477301-80b2-43dc-ab73-68663844e241@github.com>

On Fri, 28 Apr 2023 22:19:20 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

> Please review this clean backport of JDK-[8297359](https://bugs.openjdk.org/browse/JDK-8297359) to jdk17u riscv port dev
> This significantly improves performance of fp min/max instrinsics.
> Results are same as in upstream jdk - https://mail.openjdk.org/pipermail/riscv-port-dev/2022-November/000684.html

Marked as reviewed by fyang (Lead).

-------------

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/49#pullrequestreview-1425912996

From vkempik at openjdk.org  Mon May 15 08:44:16 2023
From: vkempik at openjdk.org (Vladimir Kempik)
Date: Mon, 15 May 2023 08:44:16 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8297359: RISC-V: improve
 performance of floating Max Min intrinsics
In-Reply-To: <XiQ3m8K6QTI0V4Ri-uVA-JAc4Wyb6fOQXulNyhGewPY=.38c626f9-6744-4d2a-940c-14ca1a2fb43e@github.com>
References: <XiQ3m8K6QTI0V4Ri-uVA-JAc4Wyb6fOQXulNyhGewPY=.38c626f9-6744-4d2a-940c-14ca1a2fb43e@github.com>
Message-ID: <R5E9gJRCrt2j9BjPS2a8lU6H7W2w_ueofaNyktmiBzI=.f082e0c9-545a-4de8-b19a-e6d99102e737@github.com>

On Fri, 28 Apr 2023 22:19:20 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

> Please review this clean backport of JDK-[8297359](https://bugs.openjdk.org/browse/JDK-8297359) to jdk17u riscv port dev
> This significantly improves performance of fp min/max instrinsics.
> Results are same as in upstream jdk - https://mail.openjdk.org/pipermail/riscv-port-dev/2022-November/000684.html

This pull request has now been integrated.

Changeset: 54a78c77
Author:    Vladimir Kempik <vkempik at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/54a78c773b3a0eb55e44438cb0117544cd514a2a
Stats:     33 lines in 2 files changed: 12 ins; 11 del; 10 mod

8297359: RISC-V: improve performance of floating Max Min intrinsics

Reviewed-by: fyang
Backport-of: 99d3840d368f1d99af72250678a2cb0c55ee0957

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/49

From dzhang at openjdk.org  Mon May 15 10:25:27 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Mon, 15 May 2023 10:25:27 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296916: RISC-V: Move some small
 macro-assembler functions to header file
Message-ID: <AhmNJ-R6mpd1-ebctNawwSg-ZVjPmS1yp_BPMSsJXLg=.1b88eb2d-2725-4759-9663-ee20937950ac@github.com>

Please review this backport to riscv-port-jdk17u.
Backport of [JDK-8296916](https://bugs.openjdk.org/browse/JDK-8296916).
The original patch cannot be directly applied because jdk17u has no [JDK-8294100](https://bugs.openjdk.org/browse/JDK-8294100) with `MacroAssembler::object_move` and has no `vneg_v`, either.

Testing:

Tier1-3 passed without new failure on unmacthed (release).

-------------

Commit messages:
 - 8296916: RISC-V: Move some small macro-assembler functions to header file

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/50/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=50&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296916
  Stats: 281 lines in 3 files changed: 101 ins; 140 del; 40 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/50.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/50/head:pull/50

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/50

From xlinzheng at openjdk.org  Mon May 15 10:37:23 2023
From: xlinzheng at openjdk.org (Xiaolin Zheng)
Date: Mon, 15 May 2023 10:37:23 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8306667: RISC-V: Fix storeImmN0
 matching rule by using zr register
Message-ID: <phIGGVX3PvoIuyOijX-1jzJJlUOZQ-1ZUVCmmxBdPoE=.1e7b3306-a6cc-4534-add9-13fa709b439b@github.com>

Backporting `8306667: RISC-V: Fix storeImmN0 matching rule by using zr register` to fix the crash. Applies cleanly.

Verified using `-Xcomp -XX:HeapBaseMinAddress=72030M`.

Testing a hotspot tier1~2 in progress.

-------------

Commit messages:
 - 8306667: RISC-V: Fix storeImmN0 matching rule by using zr register

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/51/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=51&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8306667
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/51.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/51/head:pull/51

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/51

From xlinzheng at openjdk.org  Mon May 15 10:38:15 2023
From: xlinzheng at openjdk.org (Xiaolin Zheng)
Date: Mon, 15 May 2023 10:38:15 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8308089: (riscv-port-jdk17u)
 Intrinsify Unsafe.storeStoreFence
Message-ID: <TI79Zbivb-IxbDOmIVgOl2K3t38er5haEhGxrjWg49A=.1f0516ac-70e5-4e0e-aa08-28130e168955@github.com>

[JDK-8252990](https://bugs.openjdk.org/browse/JDK-8252990) was recently ported to jdk17u in April. We should also enable the matching rule for `StoreStoreFence` on the WIP riscv-port-jdk17u repo.

Found the small fastdebug crash when backporting #51 using `-Xcomp`.

Testing a hotspot tier1~2 in progress.

-------------

Commit messages:
 - Missing: RISC-V: JDK-8252990: Intrinsify Unsafe.storeStoreFence

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/52/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=52&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8308089
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/52.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/52/head:pull/52

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/52

From fyang at openjdk.org  Tue May 16 00:04:14 2023
From: fyang at openjdk.org (Fei Yang)
Date: Tue, 16 May 2023 00:04:14 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8306667: RISC-V: Fix
 storeImmN0 matching rule by using zr register
In-Reply-To: <phIGGVX3PvoIuyOijX-1jzJJlUOZQ-1ZUVCmmxBdPoE=.1e7b3306-a6cc-4534-add9-13fa709b439b@github.com>
References: <phIGGVX3PvoIuyOijX-1jzJJlUOZQ-1ZUVCmmxBdPoE=.1e7b3306-a6cc-4534-add9-13fa709b439b@github.com>
Message-ID: <SI4jjA3CLPBLrHVCwoeKRVPkMItmEfMGiJqPW7-nEp4=.cceaf17f-5309-441b-b8af-2703d1d8578d@github.com>

On Mon, 15 May 2023 10:29:43 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

> Backporting `8306667: RISC-V: Fix storeImmN0 matching rule by using zr register` to fix the crash. Applies cleanly.
> 
> Verified using `-Xcomp -XX:HeapBaseMinAddress=72030M`.
> 
> Testing a hotspot tier1~2 in progress.

Marked as reviewed by fyang (Lead).

-------------

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/51#pullrequestreview-1427511863

From fyang at openjdk.org  Tue May 16 00:31:10 2023
From: fyang at openjdk.org (Fei Yang)
Date: Tue, 16 May 2023 00:31:10 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8308089: (riscv-port-jdk17u)
 Intrinsify Unsafe.storeStoreFence
In-Reply-To: <TI79Zbivb-IxbDOmIVgOl2K3t38er5haEhGxrjWg49A=.1f0516ac-70e5-4e0e-aa08-28130e168955@github.com>
References: <TI79Zbivb-IxbDOmIVgOl2K3t38er5haEhGxrjWg49A=.1f0516ac-70e5-4e0e-aa08-28130e168955@github.com>
Message-ID: <xq0FECVBVPTyJk4bj2GHMSrE8-478rf4CSjuyFJadxo=.63e2961e-71c3-47e9-b44b-600e2e501785@github.com>

On Mon, 15 May 2023 10:30:56 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

> [JDK-8252990](https://bugs.openjdk.org/browse/JDK-8252990) was recently backported to jdk17u in April. We should also enable the matching rule for `StoreStoreFence` on the WIP riscv-port-jdk17u repo.
> 
> Found the small fastdebug crash when backporting #51 using `-Xcomp`.
> 
> Testing a hotspot tier1~2 in progress.

@zhengxiaolinX : Thanks for fixing this. The changes looks good to me.
Suggestion for the JBS issue title: [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence

PS: I am referencing issue title naming convention for other project like lilliput: https://bugs.openjdk.org/browse/JDK-8302065

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/52#issuecomment-1548794578

From fyang at openjdk.org  Tue May 16 05:37:06 2023
From: fyang at openjdk.org (Fei Yang)
Date: Tue, 16 May 2023 05:37:06 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8308089: [riscv-port-jdk17u]
 Intrinsify Unsafe.storeStoreFence
In-Reply-To: <TI79Zbivb-IxbDOmIVgOl2K3t38er5haEhGxrjWg49A=.1f0516ac-70e5-4e0e-aa08-28130e168955@github.com>
References: <TI79Zbivb-IxbDOmIVgOl2K3t38er5haEhGxrjWg49A=.1f0516ac-70e5-4e0e-aa08-28130e168955@github.com>
Message-ID: <d0DqaFkk8FM4UZAxpItrikrbDdcbjbjlVcsr0Lrxai4=.ee30b37b-fa49-4c33-bf8f-a5be8b9c9ef1@github.com>

On Mon, 15 May 2023 10:30:56 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

> [JDK-8252990](https://bugs.openjdk.org/browse/JDK-8252990) was recently backported to jdk17u in April. We should also enable the matching rule for `StoreStoreFence` on the WIP riscv-port-jdk17u repo.
> 
> Found the small fastdebug crash when backporting #51 using `-Xcomp`.
> 
> Testing a hotspot tier1~2 in progress.

Marked as reviewed by fyang (Lead).

-------------

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/52#pullrequestreview-1427743998

From xlinzheng at openjdk.org  Tue May 16 05:38:11 2023
From: xlinzheng at openjdk.org (Xiaolin Zheng)
Date: Tue, 16 May 2023 05:38:11 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8306667: RISC-V: Fix
 storeImmN0 matching rule by using zr register
In-Reply-To: <phIGGVX3PvoIuyOijX-1jzJJlUOZQ-1ZUVCmmxBdPoE=.1e7b3306-a6cc-4534-add9-13fa709b439b@github.com>
References: <phIGGVX3PvoIuyOijX-1jzJJlUOZQ-1ZUVCmmxBdPoE=.1e7b3306-a6cc-4534-add9-13fa709b439b@github.com>
Message-ID: <NEyXFXcH94fvYNeJs5TnXfRNd0CYLU8GHrQSWGHVfPY=.bbb3675a-7551-4be9-9d74-5047ecacc8a5@github.com>

On Mon, 15 May 2023 10:29:43 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

> Backporting `8306667: RISC-V: Fix storeImmN0 matching rule by using zr register` to fix the crash. Applies cleanly.
> 
> Verified using `-Xcomp -XX:HeapBaseMinAddress=72030M`.
> 
> Testing a hotspot tier1~2 in progress.

This pull request has now been integrated.

Changeset: 3a02888f
Author:    Xiaolin Zheng <xlinzheng at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/3a02888f1d72eeb84df20407358f65ba01cf8f4c
Stats:     3 lines in 1 file changed: 0 ins; 0 del; 3 mod

8306667: RISC-V: Fix storeImmN0 matching rule by using zr register

Reviewed-by: fyang
Backport-of: e32de7efd6f3173a0bba5829e8de3edd01cfdbab

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/51

From xlinzheng at openjdk.org  Tue May 16 06:08:08 2023
From: xlinzheng at openjdk.org (Xiaolin Zheng)
Date: Tue, 16 May 2023 06:08:08 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8308089: [riscv-port-jdk17u]
 Intrinsify Unsafe.storeStoreFence
In-Reply-To: <TI79Zbivb-IxbDOmIVgOl2K3t38er5haEhGxrjWg49A=.1f0516ac-70e5-4e0e-aa08-28130e168955@github.com>
References: <TI79Zbivb-IxbDOmIVgOl2K3t38er5haEhGxrjWg49A=.1f0516ac-70e5-4e0e-aa08-28130e168955@github.com>
Message-ID: <wYLaK8RhY1_LL2dj7DU_koK6DknFUl8RyU77KrV5jgk=.9f24a813-a913-4959-b84e-3e8c91b5b5df@github.com>

On Mon, 15 May 2023 10:30:56 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

> [JDK-8252990](https://bugs.openjdk.org/browse/JDK-8252990) was recently backported to jdk17u in April. We should also enable the matching rule for `StoreStoreFence` on the WIP riscv-port-jdk17u repo.
> 
> Found the small fastdebug crash when backporting #51 using `-Xcomp`.
> 
> Testing a hotspot tier1~2 in progress.

Thank you for reviewing!

Tier1 and tier2 passed.

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/52#issuecomment-1549043929

From xlinzheng at openjdk.org  Tue May 16 07:38:12 2023
From: xlinzheng at openjdk.org (Xiaolin Zheng)
Date: Tue, 16 May 2023 07:38:12 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8308089:
 [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence
In-Reply-To: <TI79Zbivb-IxbDOmIVgOl2K3t38er5haEhGxrjWg49A=.1f0516ac-70e5-4e0e-aa08-28130e168955@github.com>
References: <TI79Zbivb-IxbDOmIVgOl2K3t38er5haEhGxrjWg49A=.1f0516ac-70e5-4e0e-aa08-28130e168955@github.com>
Message-ID: <WpbgkXc2AU4hRkaU4ZcoMyWNywWAeiEqeBQ0nOqsGww=.7e658dd2-c0a7-4483-b265-d5c6a86f320b@github.com>

On Mon, 15 May 2023 10:30:56 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

> [JDK-8252990](https://bugs.openjdk.org/browse/JDK-8252990) was recently backported to jdk17u in April. We should also enable the matching rule for `StoreStoreFence` on the WIP riscv-port-jdk17u repo.
> 
> Found the small fastdebug crash when backporting #51 using `-Xcomp`.
> 
> Testing a hotspot tier1~2 in progress.

This pull request has now been integrated.

Changeset: 0bdef916
Author:    Xiaolin Zheng <xlinzheng at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/0bdef9167832aa409c26fb8fe67d0cd88d7bd411
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8308089: [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence

Reviewed-by: fyang

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/52

From vkempik at openjdk.org  Wed May 17 17:25:24 2023
From: vkempik at openjdk.org (Vladimir Kempik)
Date: Wed, 17 May 2023 17:25:24 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8308089: [riscv-port-jdk17u]
 Intrinsify Unsafe.storeStoreFence
In-Reply-To: <xq0FECVBVPTyJk4bj2GHMSrE8-478rf4CSjuyFJadxo=.63e2961e-71c3-47e9-b44b-600e2e501785@github.com>
References: <TI79Zbivb-IxbDOmIVgOl2K3t38er5haEhGxrjWg49A=.1f0516ac-70e5-4e0e-aa08-28130e168955@github.com>
 <xq0FECVBVPTyJk4bj2GHMSrE8-478rf4CSjuyFJadxo=.63e2961e-71c3-47e9-b44b-600e2e501785@github.com>
Message-ID: <rYaLU6bt1ot0zAg23LgQyJe5LN7vgR6cUmF_XGvT42k=.f634130c-f7b3-421f-8a35-718afa106b37@github.com>

On Tue, 16 May 2023 00:28:33 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> [JDK-8252990](https://bugs.openjdk.org/browse/JDK-8252990) was recently backported to jdk17u in April. We should also enable the matching rule for `StoreStoreFence` on the WIP riscv-port-jdk17u repo.
>> 
>> Found the small fastdebug crash when backporting #51 using `-Xcomp`.
>> 
>> Testing a hotspot tier1~2 in progress.
>
> @zhengxiaolinX : Thanks for fixing this. The changes looks good to me.
> Suggestion for the JBS issue title: [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence
> 
> PS: I am referencing issue title naming convention for other project like lilliput: https://bugs.openjdk.org/browse/JDK-8302065

@RealFYang do you think we are ready now to try to go into jdk17u-dev ?

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/52#issuecomment-1551790428

From fyang at openjdk.org  Thu May 18 01:22:17 2023
From: fyang at openjdk.org (Fei Yang)
Date: Thu, 18 May 2023 01:22:17 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8308089: [riscv-port-jdk17u]
 Intrinsify Unsafe.storeStoreFence
In-Reply-To: <xq0FECVBVPTyJk4bj2GHMSrE8-478rf4CSjuyFJadxo=.63e2961e-71c3-47e9-b44b-600e2e501785@github.com>
References: <TI79Zbivb-IxbDOmIVgOl2K3t38er5haEhGxrjWg49A=.1f0516ac-70e5-4e0e-aa08-28130e168955@github.com>
 <xq0FECVBVPTyJk4bj2GHMSrE8-478rf4CSjuyFJadxo=.63e2961e-71c3-47e9-b44b-600e2e501785@github.com>
Message-ID: <KiIZD8IFo49SByTCTkLl7jnivsRFL_LfJaYDoR-dydQ=.df5ef69f-d9dc-4929-bb06-f56e1688afff@github.com>

On Tue, 16 May 2023 00:28:33 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> [JDK-8252990](https://bugs.openjdk.org/browse/JDK-8252990) was recently backported to jdk17u in April. We should also enable the matching rule for `StoreStoreFence` on the WIP riscv-port-jdk17u repo.
>> 
>> Found the small fastdebug crash when backporting #51 using `-Xcomp`.
>> 
>> Testing a hotspot tier1~2 in progress.
>
> @zhengxiaolinX : Thanks for fixing this. The changes looks good to me.
> Suggestion for the JBS issue title: [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence
> 
> PS: I am referencing issue title naming convention for other project like lilliput: https://bugs.openjdk.org/browse/JDK-8302065

> @RealFYang do you think we are ready now to try to go into jdk17u-dev ?

Still a couple of backports pending, like JDK-8307446. I was told those are currently under testing.
If everything goes well, I think we should be able to initiating the upstreaming early next month.

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/52#issuecomment-1552278548

From fyang at openjdk.org  Thu May 18 01:53:18 2023
From: fyang at openjdk.org (Fei Yang)
Date: Thu, 18 May 2023 01:53:18 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296916: RISC-V: Move some
 small macro-assembler functions to header file
In-Reply-To: <AhmNJ-R6mpd1-ebctNawwSg-ZVjPmS1yp_BPMSsJXLg=.1b88eb2d-2725-4759-9663-ee20937950ac@github.com>
References: <AhmNJ-R6mpd1-ebctNawwSg-ZVjPmS1yp_BPMSsJXLg=.1b88eb2d-2725-4759-9663-ee20937950ac@github.com>
Message-ID: <TVuBm1xNMpbtuYL9cx_-50p1TQLekmc-Zu-aJkxrxvA=.41caf6b5-b859-42de-9435-ecbcb9ebc34b@github.com>

On Mon, 15 May 2023 10:17:20 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8296916](https://bugs.openjdk.org/browse/JDK-8296916).
> The original patch cannot be directly applied because jdk17u has no [JDK-8294100](https://bugs.openjdk.org/browse/JDK-8294100) with `MacroAssembler::object_move` and has no `vneg_v`, either.
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

Looks good. This change should be low risk and will help minimize difference with jdk mainline.

-------------

Marked as reviewed by fyang (Lead).

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/50#pullrequestreview-1431893724

From dzhang at openjdk.org  Thu May 18 05:27:21 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Thu, 18 May 2023 05:27:21 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8296916: RISC-V: Move some
 small macro-assembler functions to header file
In-Reply-To: <AhmNJ-R6mpd1-ebctNawwSg-ZVjPmS1yp_BPMSsJXLg=.1b88eb2d-2725-4759-9663-ee20937950ac@github.com>
References: <AhmNJ-R6mpd1-ebctNawwSg-ZVjPmS1yp_BPMSsJXLg=.1b88eb2d-2725-4759-9663-ee20937950ac@github.com>
Message-ID: <PBtFgOgMw948Ewzchz2ry9KGyynGTt5N364GB-Q_dnA=.7a8b23e7-b56e-47e3-b128-c4ff94850647@github.com>

On Mon, 15 May 2023 10:17:20 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8296916](https://bugs.openjdk.org/browse/JDK-8296916).
> The original patch cannot be directly applied because jdk17u has no [JDK-8294100](https://bugs.openjdk.org/browse/JDK-8294100) with `MacroAssembler::object_move` and has no `vneg_v`, either.
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/50#issuecomment-1552416101

From dzhang at openjdk.org  Thu May 18 07:28:19 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Thu, 18 May 2023 07:28:19 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8296916: RISC-V: Move some
 small macro-assembler functions to header file
In-Reply-To: <AhmNJ-R6mpd1-ebctNawwSg-ZVjPmS1yp_BPMSsJXLg=.1b88eb2d-2725-4759-9663-ee20937950ac@github.com>
References: <AhmNJ-R6mpd1-ebctNawwSg-ZVjPmS1yp_BPMSsJXLg=.1b88eb2d-2725-4759-9663-ee20937950ac@github.com>
Message-ID: <WO6HHtJRu_AFE_oIIyuoydBEI8KGGUmHLASjhWMW8lI=.e3046427-0089-4da8-91d6-9ed8503a49ce@github.com>

On Mon, 15 May 2023 10:17:20 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8296916](https://bugs.openjdk.org/browse/JDK-8296916).
> The original patch cannot be directly applied because jdk17u has no [JDK-8294100](https://bugs.openjdk.org/browse/JDK-8294100) with `MacroAssembler::object_move` and has no `vneg_v`, either.
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

This pull request has now been integrated.

Changeset: 9b88e8e6
Author:    Dingli Zhang <dzhang at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/9b88e8e65771a7022b2ce3d7cd89281dea9ce975
Stats:     281 lines in 3 files changed: 101 ins; 140 del; 40 mod

8296916: RISC-V: Move some small macro-assembler functions to header file

Reviewed-by: fyang
Backport-of: c3b285a8acaf4a6771e80b0a19bf21d6873f1a38

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/50

From gcao at openjdk.org  Thu May 18 08:41:44 2023
From: gcao at openjdk.org (Gui Cao)
Date: Thu, 18 May 2023 08:41:44 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8297697: RISC-V: Add support for
 SATP mode detection
Message-ID: <Dm_9MiuHImsrHxsZNpgr8Rnm1EmhfYBvWXc3EXta5FU=.7ff0fd03-e32e-40b1-a8bb-5d75ab1cedad@github.com>

Hi,
Please review this backport to riscv-port-jdk17u.
Backport of [JDK-8297697](https://bugs.openjdk.org/browse/JDK-8297697), and [JDK-8301067](https://bugs.openjdk.org/browse/JDK-8301067). JDK-8301067 only modifies the log description information introduced by JDK-8297697.

After this patch, If it is an unsupported satp.mode , the message will be as follows:

root at qemuriscv64:~/STAP# ./jdk/bin/java -version
Error occurred during initialization of VM
Unsupported satp mode: sv57. Only satp modes up to sv48 are supported for now.


Testing:

Tier1-3 passed without new failure on unmacthed (release).

-------------

Commit messages:
 - Backport 8297697: RISC-V: Add support for SATP mode detection

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/53/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=53&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8297697
  Stats: 41 lines in 3 files changed: 40 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/53.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/53/head:pull/53

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/53

From fjiang at openjdk.org  Thu May 18 10:27:17 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Thu, 18 May 2023 10:27:17 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8297697: RISC-V: Add support
 for SATP mode detection
In-Reply-To: <Dm_9MiuHImsrHxsZNpgr8Rnm1EmhfYBvWXc3EXta5FU=.7ff0fd03-e32e-40b1-a8bb-5d75ab1cedad@github.com>
References: <Dm_9MiuHImsrHxsZNpgr8Rnm1EmhfYBvWXc3EXta5FU=.7ff0fd03-e32e-40b1-a8bb-5d75ab1cedad@github.com>
Message-ID: <lUFd3qiQ-KYEiZDviyMJl9aqbF4bR5zwMTayEas_gHk=.71966db9-04ad-442c-b3c6-c0f21e501b89@github.com>

On Thu, 18 May 2023 08:34:03 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi,
> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8297697](https://bugs.openjdk.org/browse/JDK-8297697), and [JDK-8301067](https://bugs.openjdk.org/browse/JDK-8301067). JDK-8301067 only modifies the log description information introduced by JDK-8297697.
> 
> After this patch, If it is an unsupported satp.mode , the message will be as follows:
> 
> root at qemuriscv64:~/STAP# ./jdk/bin/java -version
> Error occurred during initialization of VM
> Unsupported satp mode: sv57. Only satp modes up to sv48 are supported for now.
> 
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

Marked as reviewed by fjiang (Author).

-------------

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/53#pullrequestreview-1432441238

From dzhang at openjdk.org  Fri May 19 04:07:33 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Fri, 19 May 2023 04:07:33 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301036: RISC-V: Factor out
 functions baseOffset & baseOffset32 from MacroAssembler
Message-ID: <uHGObwHTc4cnFLXm89OnYvA0SLbb6EEoAkkXwMS-FG4=.b2f9fa9f-3923-4d20-bd7c-2baa387dec2e@github.com>

Hi, please review this backport to riscv-port-jdk17u.
Backport of [JDK-8301036](https://bugs.openjdk.org/browse/JDK-8301036).
The original patch cannot be directly applied because of the missing whitespace between `offset` and `=`:
https://github.com/openjdk/riscv-port-jdk17u/blob/9b88e8e65771a7022b2ce3d7cd89281dea9ce975/src/hotspot/cpu/riscv/macroAssembler_riscv.hpp#L889

Testing:

Tier1-3 passed without new failure on unmacthed (release).

-------------

Commit messages:
 - 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/54/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=54&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8301036
  Stats: 64 lines in 3 files changed: 15 ins; 31 del; 18 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/54.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/54/head:pull/54

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/54

From duke at openjdk.org  Mon May 22 01:25:22 2023
From: duke at openjdk.org (duke)
Date: Mon, 22 May 2023 01:25:22 GMT
Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 18 new changesets
Message-ID: <13bb4c8a-db0c-4f07-aa73-f7a5c62d4361@openjdk.org>

Changeset: bf7cedab
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-05-15 07:52:32 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/bf7cedabb4501d2556ed6d9a7710d64780ad6005

8282201: Consider removal of expiry check in VerifyCACerts.java test

Backport-of: 5b43804b7988ea4abd6458fba0a042b7bd6d9cb8

! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: 093f02aa
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-05-16 12:47:56 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/093f02aadbeedb8f22db7512cb5555c4c890b0fc

8305975: Add TWCA Global Root CA

Reviewed-by: mdoerr
Backport-of: 82ccfe3a21f6f9933d96c52286ecb4d6b432abb2

+ make/data/cacerts/twcaglobalrootca
+ test/jdk/security/infra/java/security/cert/CertPathValidator/certification/TWCAGlobalCA.java
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: e7bac423
Author:    Martin Doerr <mdoerr at openjdk.org>
Date:      2023-05-16 13:28:33 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/e7bac4235a64a187da1835b4fa903fdc69a03034

8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames

Reviewed-by: rrich
Backport-of: 375743336dc15f9f945a03422eaa7ff773622cd8

! make/test/JtregNativeHotspot.gmk
! src/hotspot/share/prims/jni.cpp
! src/hotspot/share/prims/jniCheck.cpp
! src/hotspot/share/prims/jniCheck.hpp
! src/hotspot/share/runtime/thread.cpp
! src/hotspot/share/runtime/thread.hpp
! src/hotspot/share/utilities/vmError.hpp
+ test/hotspot/jtreg/runtime/jni/nativeStack/TestNativeStack.java
+ test/hotspot/jtreg/runtime/jni/nativeStack/libnativeStack.c

Changeset: e55bea42
Author:    Andrei Pangin <apangin at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-16 15:38:08 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/e55bea42d04c3c8a0809056511cc1603573116bf

8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for small inputs

Reviewed-by: phh
Backport-of: 8c70bf3fff6f01b637f9e72a0b4c617051dbfafd

! src/hotspot/cpu/x86/crc32c.h
! src/hotspot/cpu/x86/macroAssembler_x86.cpp

Changeset: f655ccd1
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-05-17 07:07:52 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/f655ccd1c74bb18000ef2789d26952055c2deba1

8304760: Add 2 Microsoft TLS roots

Reviewed-by: mdoerr
Backport-of: c7e1df832837c2f19629cf0d5a5d3e65142ac208

+ make/data/cacerts/microsoftecc2017
+ make/data/cacerts/microsoftrsa2017
+ test/jdk/security/infra/java/security/cert/CertPathValidator/certification/MicrosoftTLS.java
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: bcb1f86d
Author:    ktakakuri <83941312+ktakakuri at users.noreply.github.com>
Committer: Christoph Langer <clanger at openjdk.org>
Date:      2023-05-17 08:14:19 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/bcb1f86d951916dfbccadeb98b8c55d101d10c4e

8248001: javadoc generates invalid HTML pages whose ftp:// links are broken

Backport-of: bb95dda0ac5032e4df582f2903dcbbbbaef9e8c4

! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java
! test/langtools/jdk/javadoc/doclet/testHrefInDocComment/TestHrefInDocComment.java
+ test/langtools/jdk/javadoc/doclet/testHrefInDocComment/pkg/J1.java

Changeset: 1087e3b9
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-17 10:58:36 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/1087e3b92e1e99fa1d4ac984ba8e07e70643794c

8306996: Open source Swing MenuItem related tests

Backport-of: 73491fa452e73cf7c02c577f4e3f1a34c02bea6d

+ test/jdk/javax/swing/JMenuItem/bug4198809.java
+ test/jdk/javax/swing/JMenuItem/bug4304129.java
+ test/jdk/javax/swing/JMenuItem/bug4839464.java
+ test/jdk/javax/swing/JMenuItem/bug4966168.java

Changeset: 76108622
Author:    Soumadipta Roy <roysouma at amazon.com>
Committer: Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-17 11:25:44 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/7610862256f900cd2091c47cd5ba05eeb337cc12

8307425: Socket input stream read burns CPU cycles with back-to-back poll(0) calls

Reviewed-by: ogillespie, shade
Backport-of: 73ac710533a45bf5ba17f308aa49556b877b8bf9

! src/java.base/share/classes/sun/nio/ch/NioSocketImpl.java
! src/java.base/share/classes/sun/nio/ch/SelChImpl.java

Changeset: 61c73517
Author:    Oli Gillespie <ogillespie at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-17 16:29:12 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/61c73517da1e8304d83b43abc9a2bbd7915d8391

8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code

Backport-of: 3f1927a7f3a2914402a25335c47a5a8bdd5511a6

! src/hotspot/share/gc/g1/g1FullCollector.cpp
! src/hotspot/share/gc/parallel/psParallelCompact.cpp
! src/hotspot/share/gc/serial/genMarkSweep.cpp

Changeset: 39f944bd
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-17 19:18:50 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/39f944bd331812b205ec5545691ddc610e9d4a10

8307130: Open source few Swing JMenu tests

Backport-of: d9052b946682d1c0f2629455d73fe4e6b95b29db

+ test/jdk/javax/swing/JMenu/bug4173633.java
+ test/jdk/javax/swing/JMenu/bug4186641.java
+ test/jdk/javax/swing/JMenu/bug4219523.java
+ test/jdk/javax/swing/JMenu/bug5013739.java

Changeset: e3e7722e
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-17 19:40:07 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/e3e7722e1454e1d93cc761ac3a386eeec85d9b75

8306941: Open source several datatransfer and dnd AWT tests

Backport-of: 3d3eaed9133dbe728ca8e00a626d33f7e35ba9ff

+ test/jdk/java/awt/datatransfer/MimeFormatsTest.java
+ test/jdk/java/awt/datatransfer/RemoveFlavorListenerTest.java
+ test/jdk/java/awt/dnd/AutoscrollStopTest.java
+ test/jdk/java/awt/dnd/ButtonReleaseTest.java

Changeset: f224212e
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-17 19:41:40 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/f224212e5f75ebed1084461e07ffa75f67eff800

8306871: Open source more AWT Drag & Drop tests

Backport-of: b5a48277ab5b42c4b13db7ddb5418a17ada512ec

+ test/jdk/java/awt/event/HierarchyEvent/ObjectSourceTest.java
+ test/jdk/java/awt/event/HierarchyEvent/SpecTest.java
+ test/jdk/java/awt/event/InputEvent/MouseModsTest.java
+ test/jdk/java/awt/event/InvocationEvent/CatchingThrowableTest.java
+ test/jdk/java/awt/event/KeyEvent/AltGraphModifier.java
+ test/jdk/java/awt/event/KeyEvent/KeyTyped/CancelKeyTyped.java

Changeset: 5cabeef0
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-17 19:42:20 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/5cabeef0d7db10d9a2abf1a8619ecf7cf871eae7

8307381: Open Source JFrame, JIF related Swing Tests

Backport-of: 4386d42d31af9042121581cd3fd4d5a7cf8961e6

+ test/jdk/javax/swing/JFrame/bug4101444.java
+ test/jdk/javax/swing/JFrame/bug4208018.java
+ test/jdk/javax/swing/JInternalFrame/bug4308938.java
+ test/jdk/javax/swing/JInternalFrame/bug4320889.java
+ test/jdk/javax/swing/JTextField/bug4300552.java
+ test/jdk/javax/swing/JToggleButton/bug4277049.java

Changeset: ed81283d
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-17 19:43:16 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/ed81283d879c3ccea508f907087d3188456654ed

8306943: Open source several dnd AWT tests

Backport-of: 2adb3b409e8cc87685a4379be3f7beeb53706e2e

+ test/jdk/java/awt/dnd/DnDAWTLockTest.java
+ test/jdk/java/awt/dnd/DragGestureInvokeLaterTest.java
+ test/jdk/java/awt/dnd/DragOverDropTargetPerformanceTest.java
+ test/jdk/java/awt/dnd/DragSourceDragEventModifiersTest.java
+ test/jdk/java/awt/dnd/DragSourceGCrashTest.java

Changeset: 9b41d419
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-17 19:44:06 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/9b41d4191900c66ac529da9eb1ee49abac1ebc54

8307133: Open source some JTable jtreg tests

Backport-of: 5ca0b08a7505d5c210d906e76c2a4cfc3eed64aa

+ test/jdk/javax/swing/JTable/4170447/bug4170447.java
+ test/jdk/javax/swing/JTable/4170447/swing.small.gif
+ test/jdk/javax/swing/JTable/bug4098201.java
+ test/jdk/javax/swing/JTable/bug4130356.java
+ test/jdk/javax/swing/JTable/bug4159300.java
+ test/jdk/javax/swing/JTable/bug4243159.java
+ test/jdk/javax/swing/JTable/bug4243313.java
+ test/jdk/javax/swing/JTable/bug4247487.java
+ test/jdk/javax/swing/JTable/bug4248070.java

Changeset: 6cc377db
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-17 19:59:26 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/6cc377db3ed16f37df2ec6bd85f9586e4090feb3

8306489: Open source AWT List related tests

Backport-of: 82a8e91ef7c3b397f9cce3854722cfe4bace6f2e

+ test/jdk/java/awt/List/ISCAfterRemoveAllTest.java
+ test/jdk/java/awt/List/InstanceOfSelectedArray.java
+ test/jdk/java/awt/List/ListEnterExitTest.java
+ test/jdk/java/awt/List/ListNullTest.java
+ test/jdk/java/awt/List/MaxWidthTest.java
+ test/jdk/java/awt/List/PageUPSelectsItemsTest.java
+ test/jdk/java/awt/List/TriggerActionEventTest.java

Changeset: f2e837f8
Author:    Jonathan Dowland <jdowland at openjdk.org>
Date:      2023-05-19 19:41:08 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/f2e837f8b23c935b7f9bfbf2d757208a5cda3e4c

8304350: Font.getStringBounds calculates wrong width for TextAttribute.TRACKING other than 0.0

Reviewed-by: andrew
Backport-of: 6b9b7d1d921367418f82c2813b272d3447a47595

! src/java.desktop/share/classes/java/awt/Font.java

Changeset: 9207935f
Author:    Fei Yang <yangfei at iscas.ac.cn>
Date:      2023-05-22 09:16:30 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/9207935f826ddc01176a88c0bf6341bc71a9d1bb

Merge branch 'master' into riscv-port



From fyang at openjdk.org  Mon May 22 01:31:13 2023
From: fyang at openjdk.org (Fei Yang)
Date: Mon, 22 May 2023 01:31:13 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8297697: RISC-V: Add support
 for SATP mode detection
In-Reply-To: <Dm_9MiuHImsrHxsZNpgr8Rnm1EmhfYBvWXc3EXta5FU=.7ff0fd03-e32e-40b1-a8bb-5d75ab1cedad@github.com>
References: <Dm_9MiuHImsrHxsZNpgr8Rnm1EmhfYBvWXc3EXta5FU=.7ff0fd03-e32e-40b1-a8bb-5d75ab1cedad@github.com>
Message-ID: <UQF6D-WgFFU7Db1f7tKGTLrxwMoeuxSZ8LB95ogayYA=.4550f514-6dc0-4a69-a599-809ec24c2469@github.com>

On Thu, 18 May 2023 08:34:03 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi,
> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8297697](https://bugs.openjdk.org/browse/JDK-8297697), and [JDK-8301067](https://bugs.openjdk.org/browse/JDK-8301067). JDK-8301067 only modifies the log description information introduced by JDK-8297697.
> 
> After this patch, If it is an unsupported satp.mode , the message will be as follows:
> 
> root at qemuriscv64:~/STAP# ./jdk/bin/java -version
> Error occurred during initialization of VM
> Unsupported satp mode: sv57. Only satp modes up to sv48 are supported for now.
> 
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

Looks good. Thanks.

-------------

Marked as reviewed by fyang (Lead).

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/53#pullrequestreview-1435643824

From fyang at openjdk.org  Mon May 22 01:41:14 2023
From: fyang at openjdk.org (Fei Yang)
Date: Mon, 22 May 2023 01:41:14 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301036: RISC-V: Factor out
 functions baseOffset & baseOffset32 from MacroAssembler
In-Reply-To: <uHGObwHTc4cnFLXm89OnYvA0SLbb6EEoAkkXwMS-FG4=.b2f9fa9f-3923-4d20-bd7c-2baa387dec2e@github.com>
References: <uHGObwHTc4cnFLXm89OnYvA0SLbb6EEoAkkXwMS-FG4=.b2f9fa9f-3923-4d20-bd7c-2baa387dec2e@github.com>
Message-ID: <fMqsE3Tw7Qaq2KJQnl8UI4UvcOAMSXYxHk5fh53tid8=.81553162-b191-4e45-b32b-b48d40ba3410@github.com>

On Fri, 19 May 2023 03:58:51 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Hi, please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301036](https://bugs.openjdk.org/browse/JDK-8301036).
> The original patch cannot be directly applied because of the missing whitespace between `offset` and `=`:
> https://github.com/openjdk/riscv-port-jdk17u/blob/9b88e8e65771a7022b2ce3d7cd89281dea9ce975/src/hotspot/cpu/riscv/macroAssembler_riscv.hpp#L889
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

Looks good.

-------------

Marked as reviewed by fyang (Lead).

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/54#pullrequestreview-1435649082

From fjiang at openjdk.org  Mon May 22 03:21:21 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Mon, 22 May 2023 03:21:21 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8307150: RISC-V: Remove remaining
 StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
Message-ID: <5F0Ja_e_d_3--_YrLnWRebS03hS89a3XSPJe8OsrSM4=.def42b47-2eed-4dc4-bc6d-77169b0a2fdc@github.com>

Hi,
Please review this clean backport of [JDK-8307150](https://bugs.openjdk.org/browse/JDK-8307150) to riscv-port-jdk17u.
Same as the mainline, this `StoreLoad` barrier is no longer needed after the removal of CMS.

-------------

Commit messages:
 - 8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/55/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=55&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8307150
  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/55.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/55/head:pull/55

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/55

From fjiang at openjdk.org  Mon May 22 04:27:16 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Mon, 22 May 2023 04:27:16 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8307651: RISC-V:
 stringL_indexof_char instruction has wrong format string
Message-ID: <j8OLGP2sATwNclHInG39D_fJsRTfK3erclK6xxlEDFI=.c9438a21-9597-4fbe-bbb5-e35fed762a75@github.com>

Hi,
Please review this clean backport of [JDK-8307651](https://bugs.openjdk.org/browse/JDK-8307651) to riscv-port-jdk17u.

backport is trivial since it only modifies some format of C2 string instructs.

-------------

Commit messages:
 - 8307651: RISC-V: stringL_indexof_char instruction has wrong format string

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/56/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=56&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8307651
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/56.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/56/head:pull/56

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/56

From dzhang at openjdk.org  Mon May 22 07:09:43 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Mon, 22 May 2023 07:09:43 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301036: RISC-V: Factor out
 functions baseOffset & baseOffset32 from MacroAssembler
In-Reply-To: <uHGObwHTc4cnFLXm89OnYvA0SLbb6EEoAkkXwMS-FG4=.b2f9fa9f-3923-4d20-bd7c-2baa387dec2e@github.com>
References: <uHGObwHTc4cnFLXm89OnYvA0SLbb6EEoAkkXwMS-FG4=.b2f9fa9f-3923-4d20-bd7c-2baa387dec2e@github.com>
Message-ID: <k1KiP2EaJOgLFowXg2XslDoPCvcW4G5qNQ1W6ZNRiT4=.00ed6ec6-fce8-4f85-bb8d-a1c5e8a778eb@github.com>

On Fri, 19 May 2023 03:58:51 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Hi, please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301036](https://bugs.openjdk.org/browse/JDK-8301036).
> The original patch cannot be directly applied because of the missing whitespace between `offset` and `=`:
> https://github.com/openjdk/riscv-port-jdk17u/blob/9b88e8e65771a7022b2ce3d7cd89281dea9ce975/src/hotspot/cpu/riscv/macroAssembler_riscv.hpp#L889
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/54#issuecomment-1556655084

From gcao at openjdk.org  Mon May 22 07:11:22 2023
From: gcao at openjdk.org (Gui Cao)
Date: Mon, 22 May 2023 07:11:22 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8297697: RISC-V: Add
 support for SATP mode detection
In-Reply-To: <Dm_9MiuHImsrHxsZNpgr8Rnm1EmhfYBvWXc3EXta5FU=.7ff0fd03-e32e-40b1-a8bb-5d75ab1cedad@github.com>
References: <Dm_9MiuHImsrHxsZNpgr8Rnm1EmhfYBvWXc3EXta5FU=.7ff0fd03-e32e-40b1-a8bb-5d75ab1cedad@github.com>
Message-ID: <VIWqH07qM3U_v2pl4vVjdoC2sELRpEnbAeATsKcWjak=.0f84b444-9739-428c-adf9-16a026f43890@github.com>

On Thu, 18 May 2023 08:34:03 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi,
> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8297697](https://bugs.openjdk.org/browse/JDK-8297697), and [JDK-8301067](https://bugs.openjdk.org/browse/JDK-8301067). JDK-8301067 only modifies the log description information introduced by JDK-8297697.
> 
> After this patch, If it is an unsupported satp.mode , the message will be as follows:
> 
> root at qemuriscv64:~/STAP# ./jdk/bin/java -version
> Error occurred during initialization of VM
> Unsupported satp mode: sv57. Only satp modes up to sv48 are supported for now.
> 
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

This pull request has now been integrated.

Changeset: 14226043
Author:    Gui Cao <gcao at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/142260434dc6863bab864242dc039bb6f3a4bf5a
Stats:     41 lines in 3 files changed: 40 ins; 0 del; 1 mod

8297697: RISC-V: Add support for SATP mode detection
8301067: RISC-V: better error message when reporting unsupported satp modes

Reviewed-by: fjiang, fyang
Backport-of: f49acd52594be3ec1e9682bda3ad69970dfd750d

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/53

From dzhang at openjdk.org  Mon May 22 07:29:20 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Mon, 22 May 2023 07:29:20 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8301036: RISC-V: Factor out
 functions baseOffset & baseOffset32 from MacroAssembler
In-Reply-To: <uHGObwHTc4cnFLXm89OnYvA0SLbb6EEoAkkXwMS-FG4=.b2f9fa9f-3923-4d20-bd7c-2baa387dec2e@github.com>
References: <uHGObwHTc4cnFLXm89OnYvA0SLbb6EEoAkkXwMS-FG4=.b2f9fa9f-3923-4d20-bd7c-2baa387dec2e@github.com>
Message-ID: <ph8gtoqffQThdGLoTfyPq5OlUDrujsx5nUnPT2h8TUQ=.80debaf9-03fa-444e-81cb-c0cfce5d3823@github.com>

On Fri, 19 May 2023 03:58:51 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Hi, please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301036](https://bugs.openjdk.org/browse/JDK-8301036).
> The original patch cannot be directly applied because of the missing whitespace between `offset` and `=`:
> https://github.com/openjdk/riscv-port-jdk17u/blob/9b88e8e65771a7022b2ce3d7cd89281dea9ce975/src/hotspot/cpu/riscv/macroAssembler_riscv.hpp#L889
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

This pull request has now been integrated.

Changeset: c24cc2a7
Author:    Dingli Zhang <dzhang at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/c24cc2a742f7719b23c3caa8ab23d2c87e558fef
Stats:     64 lines in 3 files changed: 15 ins; 31 del; 18 mod

8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler

Reviewed-by: fyang
Backport-of: ebb84ad70d3295d9a429904fcdacdb8ecd1bf434

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/54

From fjiang at openjdk.org  Mon May 22 11:25:18 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Mon, 22 May 2023 11:25:18 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8307446: RISC-V: Improve
 performance of floating point to integer conversion
Message-ID: <YCzl2OCICgc9iFZry-2ihNWQ9uLwrZA0aefYySSGMoc=.f234b693-fb44-4948-aa7b-0a1a6c04f65e@github.com>

Hi,
please review this clean backport of [JDK-8307446](https://bugs.openjdk.org/browse/JDK-8307446).

JHM shows the same improvement on Unmatched board:


Benchmark                     (size)   Mode  Cnt   Score   Error   Units
--- baseline -----------------------------------------------------------
FloatConversion.doubleToInt     2048  thrpt   15  30.270 ? 0.144  ops/ms
FloatConversion.doubleToLong    2048  thrpt   15  29.831 ? 0.128  ops/ms
FloatConversion.floatToInt      2048  thrpt   15  30.530 ? 0.031  ops/ms
FloatConversion.floatToLong     2048  thrpt   15  30.189 ? 0.100  ops/ms
--- optimized ----------------------------------------------------------
FloatConversion.doubleToInt     2048  thrpt   15  66.051 ? 0.064  ops/ms
FloatConversion.doubleToLong    2048  thrpt   15  66.095 ? 0.460  ops/ms
FloatConversion.floatToInt      2048  thrpt   15  68.114 ? 0.072  ops/ms
FloatConversion.floatToLong     2048  thrpt   15  68.482 ? 0.193  ops/ms

-------------

Commit messages:
 - 8307446: RISC-V: Improve performance of floating point to integer conversion

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/57/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=57&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8307446
  Stats: 18 lines in 1 file changed: 0 ins; 1 del; 17 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/57.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/57/head:pull/57

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/57

From fjiang at openjdk.org  Mon May 22 11:27:37 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Mon, 22 May 2023 11:27:37 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8308277: RISC-V: Improve
 vectorization of Match.sqrt() on floats
Message-ID: <1Zv6xPpIbVwdfYlMx9cNKrNtK57ceIvmcjT7FArkEuA=.e44afbd6-3eca-4ae8-bb17-f24777bcc8c9@github.com>

Hi,
Please review this clean backport of [JDK-8308277](https://bugs.openjdk.org/browse/JDK-8308277).

For jdk17u, `Math.sqrt(float)` will not get vectorized even when `UseRVV` is true without the `SqrtF` node.

Here is the OptoAssembly of Sqrt.java from [JDK-8190800](https://bugs.openjdk.org/browse/JDK-8190800):

before:

120     B14: #  out( B14 B15 ) <- in( B13 B14 ) Loop( B14-B14 inner main of N91 strip mined) Freq: 1.86254e+07
120 +   addw  R28, R12, zr  #@convI2L_reg_reg
124 +   slli  R28, R28, (#2 & 0x3f) #@lShiftL_reg_imm
128 +   add R28, R18, R28   # ptr, #@addP_reg_reg
12c +   flw  F0, [R28, #16] # float, #@loadF
130 +   fsqrt.s  F1, F0 #@sqrtF_reg
134 +   fsw  F1, [R28, #16] # float, #@storeF


after:

140     B14: #  out( B14 B15 ) <- in( B13 B14 ) Loop( B14-B14 inner main of N93 strip mined) Freq: 1.60517e+07
140     addw  R10, R31, zr  #@convI2L_reg_reg
144     slli  R10, R10, (#2 & 0x3f) #@lShiftL_reg_imm
148     add R11, R9, R10    # ptr, #@addP_reg_reg
14c     addi  R10, R11, #16 # ptr, #@addP_reg_imm
150     vle V1, [R10]   #@loadV
158     vfsqrt.v V1, V1 #@vsqrtF
160     addi  R10, R11, #16 # ptr, #@addP_reg_imm
164     vse V1, [R10]   #@storeV

-------------

Commit messages:
 - 8308277: RISC-V: Improve vectorization of Match.sqrt() on floats

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/58/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=58&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8308277
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/58.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/58/head:pull/58

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/58

From vladimir.kempik at gmail.com  Mon May 22 20:44:38 2023
From: vladimir.kempik at gmail.com (Vladimir Kempik)
Date: Mon, 22 May 2023 23:44:38 +0300
Subject: question about vector registers
Message-ID: <6502556F-A586-4E71-9D30-AAE74E474F30@gmail.com>

Hello

I have few questions about vector registers usage in hotspot.

Currently there is no calling convention for vector registers [1].

Currently all vector registers ( usage in hotspot) are not preserved and volatile ? is it true ?

why do we have defition for v1_reg-v5_reg and the rest of the registers ( except  v0_mask) ?

I guess some v6+ could be used somewhere due to lmul  = 2 or 4.

Thanks in advance, Vladimir

[1] https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/riscv-cc.adoc

From yangfei at iscas.ac.cn  Tue May 23 00:52:36 2023
From: yangfei at iscas.ac.cn (yangfei at iscas.ac.cn)
Date: Tue, 23 May 2023 08:52:36 +0800 (GMT+08:00)
Subject: question about vector registers
In-Reply-To: <6502556F-A586-4E71-9D30-AAE74E474F30@gmail.com>
References: <6502556F-A586-4E71-9D30-AAE74E474F30@gmail.com>
Message-ID: <1295a7b0.4d025.1884617fa26.Coremail.yangfei@iscas.ac.cn>

Hi,

Comments inlined.

&gt; -----Original Messages-----
&gt; From: "Vladimir Kempik" <vladimir.kempik at gmail.com>
&gt; Sent Time: 2023-05-23 04:44:38 (Tuesday)
&gt; To: riscv-port-dev <riscv-port-dev at openjdk.org>
&gt; Cc: 
&gt; Subject: question about vector registers
&gt; 
&gt; Hello
&gt; 
&gt; I have few questions about vector registers usage in hotspot.
&gt; 
&gt; Currently there is no calling convention for vector registers [1].
&gt;
&gt; Currently all vector registers ( usage in hotspot) are not preserved and volatile ? is it true ?

Yes, the ABI spec only mentions that vector registers are volatile and are not used for passing arguments or return values for now.
So if you look at register definition for C2, we set both 'register save type' and 'C convention save type' for vector registers as SOC (Save-On-Call).

&gt; why do we have defition for v1_reg-v5_reg and the rest of the registers ( except  v0_mask) ?

Several vector registers (including v0_mask register) are used as scratch registers to optimize code for C2 nodes like ClearArray, StrComp, etc.
And if you do this, remember to make this explicit on the side effect for those nodes like: https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/riscv_v.ad#L3278

&gt; I guess some v6+ could be used somewhere due to lmul  = 2 or 4.

I think it will depend on your specific usage then.
We already have some use of lmul =2/4 in some C2 assembler functions like C2_MacroAssembler::clear_array_v.
But currently those usages won't involve v6+ yet.

Hope that answers the questions,
Fei Yang
</riscv-port-dev at openjdk.org></vladimir.kempik at gmail.com>

From dzhang at openjdk.org  Tue May 23 03:22:35 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Tue, 23 May 2023 03:22:35 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301628: RISC-V: c2 fix pipeline
 class for several instructions
Message-ID: <6kkID34TO4XkfUCxmw4YhTm2NIhdcdnzUC1Zp__Qggw=.4b033d51-5dc0-470e-b681-a2ae729a9059@github.com>

Hi, please review this backport to riscv-port-jdk17u.
Backport of [JDK-8301628](https://bugs.openjdk.org/browse/JDK-8301628).
The original patch cannot be directly applied because jdk17u has no [JDK-8293695](https://bugs.openjdk.org/browse/JDK-8293695).

Testing:
- Tier1-3 passed without new failure on unmacthed (release).

-------------

Commit messages:
 - 8301628: RISC-V: c2 fix pipeline class for several instructions

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/59/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=59&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8301628
  Stats: 12 lines in 1 file changed: 0 ins; 0 del; 12 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/59.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/59/head:pull/59

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/59

From fyang at openjdk.org  Tue May 23 03:50:16 2023
From: fyang at openjdk.org (Fei Yang)
Date: Tue, 23 May 2023 03:50:16 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8307651: RISC-V:
 stringL_indexof_char instruction has wrong format string
In-Reply-To: <j8OLGP2sATwNclHInG39D_fJsRTfK3erclK6xxlEDFI=.c9438a21-9597-4fbe-bbb5-e35fed762a75@github.com>
References: <j8OLGP2sATwNclHInG39D_fJsRTfK3erclK6xxlEDFI=.c9438a21-9597-4fbe-bbb5-e35fed762a75@github.com>
Message-ID: <RzDckddkVcQSQlHIBV7o0QUU1Wn_o_QrTh43MzjrAzs=.38c527fb-e628-4d9a-9610-e0d10b3e3314@github.com>

On Mon, 22 May 2023 04:19:04 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> Hi,
> Please review this clean backport of [JDK-8307651](https://bugs.openjdk.org/browse/JDK-8307651) to riscv-port-jdk17u.
> 
> backport is trivial since it only modifies some format of C2 string instructs.

Marked as reviewed by fyang (Lead).

-------------

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/56#pullrequestreview-1438332170

From fyang at openjdk.org  Tue May 23 03:53:20 2023
From: fyang at openjdk.org (Fei Yang)
Date: Tue, 23 May 2023 03:53:20 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8307150: RISC-V: Remove
 remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
In-Reply-To: <5F0Ja_e_d_3--_YrLnWRebS03hS89a3XSPJe8OsrSM4=.def42b47-2eed-4dc4-bc6d-77169b0a2fdc@github.com>
References: <5F0Ja_e_d_3--_YrLnWRebS03hS89a3XSPJe8OsrSM4=.def42b47-2eed-4dc4-bc6d-77169b0a2fdc@github.com>
Message-ID: <YXJ5jPbSdYdfyZBKpDRATsu-lhIBj6TlXKjYvdandmI=.0e7ede2f-617a-4910-a5cd-3137d2242e16@github.com>

On Mon, 22 May 2023 03:14:32 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> Hi,
> Please review this clean backport of [JDK-8307150](https://bugs.openjdk.org/browse/JDK-8307150) to riscv-port-jdk17u.
> Same as the mainline, this `StoreLoad` barrier is no longer needed after the removal of CMS.

OK. We should have this so that we are on-par with other CPUs like aarch64.

-------------

Marked as reviewed by fyang (Lead).

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/55#pullrequestreview-1438337717

From fyang at openjdk.org  Tue May 23 03:55:16 2023
From: fyang at openjdk.org (Fei Yang)
Date: Tue, 23 May 2023 03:55:16 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8307446: RISC-V: Improve
 performance of floating point to integer conversion
In-Reply-To: <YCzl2OCICgc9iFZry-2ihNWQ9uLwrZA0aefYySSGMoc=.f234b693-fb44-4948-aa7b-0a1a6c04f65e@github.com>
References: <YCzl2OCICgc9iFZry-2ihNWQ9uLwrZA0aefYySSGMoc=.f234b693-fb44-4948-aa7b-0a1a6c04f65e@github.com>
Message-ID: <ZuMLGDQw7fXlAO0XvhzPKlCv18tQXMY66lM1UPEUr0g=.7b3671cd-04f2-4cea-8bcc-a7b581002678@github.com>

On Mon, 22 May 2023 04:22:49 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> Hi,
> please review this clean backport of [JDK-8307446](https://bugs.openjdk.org/browse/JDK-8307446).
> 
> JHM shows the same improvement on Unmatched board:
> 
> 
> Benchmark                     (size)   Mode  Cnt   Score   Error   Units
> --- baseline -----------------------------------------------------------
> FloatConversion.doubleToInt     2048  thrpt   15  30.270 ? 0.144  ops/ms
> FloatConversion.doubleToLong    2048  thrpt   15  29.831 ? 0.128  ops/ms
> FloatConversion.floatToInt      2048  thrpt   15  30.530 ? 0.031  ops/ms
> FloatConversion.floatToLong     2048  thrpt   15  30.189 ? 0.100  ops/ms
> --- optimized ----------------------------------------------------------
> FloatConversion.doubleToInt     2048  thrpt   15  66.051 ? 0.064  ops/ms
> FloatConversion.doubleToLong    2048  thrpt   15  66.095 ? 0.460  ops/ms
> FloatConversion.floatToInt      2048  thrpt   15  68.114 ? 0.072  ops/ms
> FloatConversion.floatToLong     2048  thrpt   15  68.482 ? 0.193  ops/ms

Marked as reviewed by fyang (Lead).

-------------

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/57#pullrequestreview-1438344676

From fyang at openjdk.org  Tue May 23 03:57:20 2023
From: fyang at openjdk.org (Fei Yang)
Date: Tue, 23 May 2023 03:57:20 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8308277: RISC-V: Improve
 vectorization of Match.sqrt() on floats
In-Reply-To: <1Zv6xPpIbVwdfYlMx9cNKrNtK57ceIvmcjT7FArkEuA=.e44afbd6-3eca-4ae8-bb17-f24777bcc8c9@github.com>
References: <1Zv6xPpIbVwdfYlMx9cNKrNtK57ceIvmcjT7FArkEuA=.e44afbd6-3eca-4ae8-bb17-f24777bcc8c9@github.com>
Message-ID: <qmhlg8mJy1qR4jxAiRzYaDlsx4ubkac90_fA14W5JRY=.31fa5c45-e250-4df5-b864-1c01d734190d@github.com>

On Mon, 22 May 2023 10:40:45 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> Hi,
> Please review this clean backport of [JDK-8308277](https://bugs.openjdk.org/browse/JDK-8308277).
> 
> For jdk17u, `Math.sqrt(float)` will not get vectorized even when `UseRVV` is true without the `SqrtF` node.
> 
> Here is the OptoAssembly of Sqrt.java from [JDK-8190800](https://bugs.openjdk.org/browse/JDK-8190800):
> 
> before:
> 
> 120     B14: #  out( B14 B15 ) <- in( B13 B14 ) Loop( B14-B14 inner main of N91 strip mined) Freq: 1.86254e+07
> 120 +   addw  R28, R12, zr  #@convI2L_reg_reg
> 124 +   slli  R28, R28, (#2 & 0x3f) #@lShiftL_reg_imm
> 128 +   add R28, R18, R28   # ptr, #@addP_reg_reg
> 12c +   flw  F0, [R28, #16] # float, #@loadF
> 130 +   fsqrt.s  F1, F0 #@sqrtF_reg
> 134 +   fsw  F1, [R28, #16] # float, #@storeF
> 
> 
> after:
> 
> 140     B14: #  out( B14 B15 ) <- in( B13 B14 ) Loop( B14-B14 inner main of N93 strip mined) Freq: 1.60517e+07
> 140     addw  R10, R31, zr  #@convI2L_reg_reg
> 144     slli  R10, R10, (#2 & 0x3f) #@lShiftL_reg_imm
> 148     add R11, R9, R10    # ptr, #@addP_reg_reg
> 14c     addi  R10, R11, #16 # ptr, #@addP_reg_imm
> 150     vle V1, [R10]   #@loadV
> 158     vfsqrt.v V1, V1 #@vsqrtF
> 160     addi  R10, R11, #16 # ptr, #@addP_reg_imm
> 164     vse V1, [R10]   #@storeV

I think it's OK to backport this so that we are on-par with other CPUs like aarch64.

-------------

Marked as reviewed by fyang (Lead).

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/58#pullrequestreview-1438348791

From vladimir.kempik at gmail.com  Tue May 23 06:17:11 2023
From: vladimir.kempik at gmail.com (Vladimir Kempik)
Date: Tue, 23 May 2023 09:17:11 +0300
Subject: question about vector registers
In-Reply-To: <1295a7b0.4d025.1884617fa26.Coremail.yangfei@iscas.ac.cn>
References: <6502556F-A586-4E71-9D30-AAE74E474F30@gmail.com>
 <1295a7b0.4d025.1884617fa26.Coremail.yangfei@iscas.ac.cn>
Message-ID: <28D98A4A-27CB-4C58-AAED-C81FCEE61FA1@gmail.com>

Hello

thank you for explanation

>But currently those usages won't involve v6+ yet
I found one usage of v6+:
src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp:

void C2_MacroAssembler::string_compare_v(?)

?
    VectorRegister vstr1 = encLU ? v4 : v0;  //vstr1 could be v4
    VectorRegister vstr2 = encLU ? v0 : v4;

    bind(loop);
    vsetvli(tmp1, cnt2, Assembler::e8, Assembler::m2);
    vle8_v(vstr1, strL);
    vsetvli(tmp1, cnt2, Assembler::e16, Assembler::m4); //lmul=4
    vzext_vf2(vstr2, vstr1);
    vle16_v(vstr1, strU); //usage of v4/v5/v6/v7
?

vstr1 could be v4.

after second vsetvli, we set lmul to 4, so v4 represents also v5, v6, v7

then we load some bytes from memory into vstr1 which stands for v4/v5/v6/v7 combo

I was also able to redo the vector support for vectors 0.7.1 and run it on real hardware ( thead, it has two c910 without vectors and one c910 with vectors, only one of sets can work at a time.), going to prepare some performance results, using openjdk?s microtests.

Regards, Vladimir

> 23 ??? 2023 ?., ? 03:52, yangfei at iscas.ac.cn ???????(?):
> 
> Hi,
> 
> Comments inlined.
> 
> &gt; -----Original Messages-----
> &gt; From: "Vladimir Kempik" <vladimir.kempik at gmail.com>
> &gt; Sent Time: 2023-05-23 04:44:38 (Tuesday)
> &gt; To: riscv-port-dev <riscv-port-dev at openjdk.org>
> &gt; Cc: 
> &gt; Subject: question about vector registers
> &gt; 
> &gt; Hello
> &gt; 
> &gt; I have few questions about vector registers usage in hotspot.
> &gt; 
> &gt; Currently there is no calling convention for vector registers [1].
> &gt;
> &gt; Currently all vector registers ( usage in hotspot) are not preserved and volatile ? is it true ?
> 
> Yes, the ABI spec only mentions that vector registers are volatile and are not used for passing arguments or return values for now.
> So if you look at register definition for C2, we set both 'register save type' and 'C convention save type' for vector registers as SOC (Save-On-Call).
> 
> &gt; why do we have defition for v1_reg-v5_reg and the rest of the registers ( except  v0_mask) ?
> 
> Several vector registers (including v0_mask register) are used as scratch registers to optimize code for C2 nodes like ClearArray, StrComp, etc.
> And if you do this, remember to make this explicit on the side effect for those nodes like: https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/riscv_v.ad#L3278
> 
> &gt; I guess some v6+ could be used somewhere due to lmul  = 2 or 4.
> 
> I think it will depend on your specific usage then.
> We already have some use of lmul =2/4 in some C2 assembler functions like C2_MacroAssembler::clear_array_v.
> But currently those usages won't involve v6+ yet.
> 
> Hope that answers the questions,
> Fei Yang
> </riscv-port-dev at openjdk.org></vladimir.kempik at gmail.com>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/riscv-port-dev/attachments/20230523/91f9ad37/attachment-0001.htm>

From yangfei at iscas.ac.cn  Tue May 23 07:13:20 2023
From: yangfei at iscas.ac.cn (yangfei at iscas.ac.cn)
Date: Tue, 23 May 2023 15:13:20 +0800 (GMT+08:00)
Subject: question about vector registers
In-Reply-To: <28D98A4A-27CB-4C58-AAED-C81FCEE61FA1@gmail.com>
References: <6502556F-A586-4E71-9D30-AAE74E474F30@gmail.com>
 <1295a7b0.4d025.1884617fa26.Coremail.yangfei@iscas.ac.cn>
 <28D98A4A-27CB-4C58-AAED-C81FCEE61FA1@gmail.com>
Message-ID: <67fcfd46.15051.18847748d8e.Coremail.yangfei@iscas.ac.cn>

Hi,

Looks like that's not quite right as the usage/clobbering of vector registers v6 and v7 does not menifest in the side-effect of C2 nodes.
We should also add TEMP v6 and TEMP v7 to effect of instructs: vstring_compareU, vstring_compareL, vstring_compareUL and vstring_compareLU.
Let me know if you are interested in fixing this issue.

Thanks,
Fei

-----Original Messages-----
From:"Vladimir Kempik" <vladimir.kempik at gmail.com>
Sent Time:2023-05-23 14:17:11 (Tuesday)
To: yangfei at iscas.ac.cn
Cc: riscv-port-dev <riscv-port-dev at openjdk.org>
Subject: Re: question about vector registers

Hello   
thank you for explanation    
&gt;But currently those usages won't involve v6+ yet
I found one usage of v6+:
src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp:    
   
voidC2_MacroAssembler::string_compare_v(?)    
    
    ?    
    VectorRegister vstr1 = encLU ? v4 : v0;  //vstr1 could be v4    
    VectorRegister vstr2 = encLU ? v0 : v4;    
    
    bind(loop);    
    vsetvli(tmp1, cnt2, Assembler::e8, Assembler::m2);    
    vle8_v(vstr1, strL);    
    vsetvli(tmp1, cnt2, Assembler::e16, Assembler::m4); //lmul=4    
    vzext_vf2(vstr2, vstr1);    
    vle16_v(vstr1, strU); //usage of v4/v5/v6/v7    
    ?    
    
    vstr1 could be v4.    
    
    after second vsetvli, we set lmul to 4, so v4 represents also v5, v6, v7    
    
    then we load some bytes from memory into vstr1 which stands for v4/v5/v6/v7 combo    
    
    I was also able to redo the vector support for vectors 0.7.1 and run it on real hardware ( thead, it has two c910 without vectors and one c910 with vectors, only one of sets can work at a time.), going to prepare some performance results, using openjdk?s microtests.    
    
    Regards, Vladimir    

</riscv-port-dev at openjdk.org></vladimir.kempik at gmail.com>

From vladimir.kempik at gmail.com  Tue May 23 07:27:04 2023
From: vladimir.kempik at gmail.com (Vladimir Kempik)
Date: Tue, 23 May 2023 10:27:04 +0300
Subject: question about vector registers
In-Reply-To: <67fcfd46.15051.18847748d8e.Coremail.yangfei@iscas.ac.cn>
References: <6502556F-A586-4E71-9D30-AAE74E474F30@gmail.com>
 <1295a7b0.4d025.1884617fa26.Coremail.yangfei@iscas.ac.cn>
 <28D98A4A-27CB-4C58-AAED-C81FCEE61FA1@gmail.com>
 <67fcfd46.15051.18847748d8e.Coremail.yangfei@iscas.ac.cn>
Message-ID: <C4376E82-3958-47EB-BE33-449186A5D811@gmail.com>

Hello

Thanks for comfirming my guesses

I?ll take on it

Regards, Vladimir
> 23 ??? 2023 ?., ? 10:13, yangfei at iscas.ac.cn ???????(?):
> 
> Hi,
> 
> Looks like that's not quite right as the usage/clobbering of vector registers v6 and v7 does not menifest in the side-effect of C2 nodes.
> We should also add TEMP v6 and TEMP v7 to effect of instructs: vstring_compareU, vstring_compareL, vstring_compareUL and vstring_compareLU.
> Let me know if you are interested in fixing this issue.
> 
> Thanks,
> Fei
> 
> -----Original Messages-----
> From:"Vladimir Kempik" <vladimir.kempik at gmail.com>
> Sent Time:2023-05-23 14:17:11 (Tuesday)
> To: yangfei at iscas.ac.cn
> Cc: riscv-port-dev <riscv-port-dev at openjdk.org>
> Subject: Re: question about vector registers
> 
> Hello   
> thank you for explanation    
> &gt;But currently those usages won't involve v6+ yet
> I found one usage of v6+:
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp:    
> 
> voidC2_MacroAssembler::string_compare_v(?)    
> 
>    ?    
>    VectorRegister vstr1 = encLU ? v4 : v0;  //vstr1 could be v4    
>    VectorRegister vstr2 = encLU ? v0 : v4;    
> 
>    bind(loop);    
>    vsetvli(tmp1, cnt2, Assembler::e8, Assembler::m2);    
>    vle8_v(vstr1, strL);    
>    vsetvli(tmp1, cnt2, Assembler::e16, Assembler::m4); //lmul=4    
>    vzext_vf2(vstr2, vstr1);    
>    vle16_v(vstr1, strU); //usage of v4/v5/v6/v7    
>    ?    
> 
>    vstr1 could be v4.    
> 
>    after second vsetvli, we set lmul to 4, so v4 represents also v5, v6, v7    
> 
>    then we load some bytes from memory into vstr1 which stands for v4/v5/v6/v7 combo    
> 
>    I was also able to redo the vector support for vectors 0.7.1 and run it on real hardware ( thead, it has two c910 without vectors and one c910 with vectors, only one of sets can work at a time.), going to prepare some performance results, using openjdk?s microtests.    
> 
>    Regards, Vladimir    
> 
> </riscv-port-dev at openjdk.org></vladimir.kempik at gmail.com>


From fyang at openjdk.org  Tue May 23 08:23:17 2023
From: fyang at openjdk.org (Fei Yang)
Date: Tue, 23 May 2023 08:23:17 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301628: RISC-V: c2 fix
 pipeline class for several instructions
In-Reply-To: <6kkID34TO4XkfUCxmw4YhTm2NIhdcdnzUC1Zp__Qggw=.4b033d51-5dc0-470e-b681-a2ae729a9059@github.com>
References: <6kkID34TO4XkfUCxmw4YhTm2NIhdcdnzUC1Zp__Qggw=.4b033d51-5dc0-470e-b681-a2ae729a9059@github.com>
Message-ID: <Fa0wNqngj9_wTEsdGK9eIxcuU-296K1tcCatTjiOrS0=.1a74e528-7976-464c-a3f4-a4ce77017514@github.com>

On Tue, 23 May 2023 03:15:52 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Hi, please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301628](https://bugs.openjdk.org/browse/JDK-8301628).
> The original patch cannot be directly applied because jdk17u has no [JDK-8293695](https://bugs.openjdk.org/browse/JDK-8293695).
> 
> Testing:
> - Tier1-3 passed without new failure on unmacthed (release).

Looks good.

-------------

Marked as reviewed by fyang (Lead).

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/59#pullrequestreview-1438956723

From fjiang at openjdk.org  Tue May 23 15:28:03 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Tue, 23 May 2023 15:28:03 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8307651: RISC-V:
 stringL_indexof_char instruction has wrong format string
In-Reply-To: <j8OLGP2sATwNclHInG39D_fJsRTfK3erclK6xxlEDFI=.c9438a21-9597-4fbe-bbb5-e35fed762a75@github.com>
References: <j8OLGP2sATwNclHInG39D_fJsRTfK3erclK6xxlEDFI=.c9438a21-9597-4fbe-bbb5-e35fed762a75@github.com>
Message-ID: <8RzWNNPhJYT6snF9ZdUnqxSo4NmgJrHmQiQTyF5bSPY=.0fcf1ea0-6ded-4a4c-bb2f-9420488a4377@github.com>

On Mon, 22 May 2023 04:19:04 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> Hi,
> Please review this clean backport of [JDK-8307651](https://bugs.openjdk.org/browse/JDK-8307651) to riscv-port-jdk17u.
> 
> backport is trivial since it only modifies some format of C2 string instructs.

This pull request has now been integrated.

Changeset: 9d8c08f3
Author:    Feilong Jiang <fjiang at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/9d8c08f383d388ad74f4ede768e4bcd16512a05e
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8307651: RISC-V: stringL_indexof_char instruction has wrong format string

Reviewed-by: fyang
Backport-of: d3e6d04e3eddfd26433f9cb95cfa9bff05b14bd6

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/56

From fjiang at openjdk.org  Tue May 23 15:28:03 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Tue, 23 May 2023 15:28:03 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8307150: RISC-V: Remove
 remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
In-Reply-To: <5F0Ja_e_d_3--_YrLnWRebS03hS89a3XSPJe8OsrSM4=.def42b47-2eed-4dc4-bc6d-77169b0a2fdc@github.com>
References: <5F0Ja_e_d_3--_YrLnWRebS03hS89a3XSPJe8OsrSM4=.def42b47-2eed-4dc4-bc6d-77169b0a2fdc@github.com>
Message-ID: <E1keDvwGpVjPcx0AeU3o_A3WXwNtKb8rKuj1E6e_QUQ=.c1c85e4a-eaf7-40e2-95e3-78d25a33adbc@github.com>

On Mon, 22 May 2023 03:14:32 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> Hi,
> Please review this clean backport of [JDK-8307150](https://bugs.openjdk.org/browse/JDK-8307150) to riscv-port-jdk17u.
> Same as the mainline, this `StoreLoad` barrier is no longer needed after the removal of CMS.

This pull request has now been integrated.

Changeset: 504014ca
Author:    Feilong Jiang <fjiang at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/504014caa46d357b4a685b4d608c2d689664dceb
Stats:     1 line in 1 file changed: 0 ins; 1 del; 0 mod

8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC

Reviewed-by: fyang
Backport-of: 0b5b6429a080c6526daeb262fee96e7d0408b4f8

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/55

From fjiang at openjdk.org  Tue May 23 15:27:52 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Tue, 23 May 2023 15:27:52 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8307150: RISC-V: Remove
 remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
In-Reply-To: <YXJ5jPbSdYdfyZBKpDRATsu-lhIBj6TlXKjYvdandmI=.0e7ede2f-617a-4910-a5cd-3137d2242e16@github.com>
References: <5F0Ja_e_d_3--_YrLnWRebS03hS89a3XSPJe8OsrSM4=.def42b47-2eed-4dc4-bc6d-77169b0a2fdc@github.com>
 <YXJ5jPbSdYdfyZBKpDRATsu-lhIBj6TlXKjYvdandmI=.0e7ede2f-617a-4910-a5cd-3137d2242e16@github.com>
Message-ID: <002s5IRDdtsFeBYmR83WJxXr7gZGmTJnPO1hYK5c624=.5222d6e2-f54f-4335-bc1f-b4007fc3a803@github.com>

On Tue, 23 May 2023 03:50:40 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hi,
>> Please review this clean backport of [JDK-8307150](https://bugs.openjdk.org/browse/JDK-8307150) to riscv-port-jdk17u.
>> Same as the mainline, this `StoreLoad` barrier is no longer needed after the removal of CMS.
>
> OK. We should have this so that we are on-par with other CPUs like aarch64.

@RealFYang -- Thanks for the review.

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/55#issuecomment-1559139834

From fjiang at openjdk.org  Tue May 23 15:27:53 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Tue, 23 May 2023 15:27:53 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8307651: RISC-V:
 stringL_indexof_char instruction has wrong format string
In-Reply-To: <RzDckddkVcQSQlHIBV7o0QUU1Wn_o_QrTh43MzjrAzs=.38c527fb-e628-4d9a-9610-e0d10b3e3314@github.com>
References: <j8OLGP2sATwNclHInG39D_fJsRTfK3erclK6xxlEDFI=.c9438a21-9597-4fbe-bbb5-e35fed762a75@github.com>
 <RzDckddkVcQSQlHIBV7o0QUU1Wn_o_QrTh43MzjrAzs=.38c527fb-e628-4d9a-9610-e0d10b3e3314@github.com>
Message-ID: <kdE-4L9dfz4BL_V-5bgj9OMG74aYPGRfmlxMtb4yE6w=.adc40acf-ea94-4c97-96b2-2eddbae8cee5@github.com>

On Tue, 23 May 2023 03:47:58 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hi,
>> Please review this clean backport of [JDK-8307651](https://bugs.openjdk.org/browse/JDK-8307651) to riscv-port-jdk17u.
>> 
>> backport is trivial since it only modifies some format of C2 string instructs.
>
> Marked as reviewed by fyang (Lead).

@RealFYang -- Thanks!

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/56#issuecomment-1559138916

From fjiang at openjdk.org  Wed May 24 00:50:23 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Wed, 24 May 2023 00:50:23 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8307446: RISC-V: Improve
 performance of floating point to integer conversion
In-Reply-To: <YCzl2OCICgc9iFZry-2ihNWQ9uLwrZA0aefYySSGMoc=.f234b693-fb44-4948-aa7b-0a1a6c04f65e@github.com>
References: <YCzl2OCICgc9iFZry-2ihNWQ9uLwrZA0aefYySSGMoc=.f234b693-fb44-4948-aa7b-0a1a6c04f65e@github.com>
Message-ID: <qSXj7Usg17X1iLUZ7NK5ZjEDzr5qgsEyI3U9wiT59vI=.ec59ddd9-1087-4824-93fe-f5b17f10bd6a@github.com>

On Mon, 22 May 2023 04:22:49 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> Hi,
> please review this clean backport of [JDK-8307446](https://bugs.openjdk.org/browse/JDK-8307446).
> 
> JHM shows the same improvement on Unmatched board:
> 
> 
> Benchmark                     (size)   Mode  Cnt   Score   Error   Units
> --- baseline -----------------------------------------------------------
> FloatConversion.doubleToInt     2048  thrpt   15  30.270 ? 0.144  ops/ms
> FloatConversion.doubleToLong    2048  thrpt   15  29.831 ? 0.128  ops/ms
> FloatConversion.floatToInt      2048  thrpt   15  30.530 ? 0.031  ops/ms
> FloatConversion.floatToLong     2048  thrpt   15  30.189 ? 0.100  ops/ms
> --- optimized ----------------------------------------------------------
> FloatConversion.doubleToInt     2048  thrpt   15  66.051 ? 0.064  ops/ms
> FloatConversion.doubleToLong    2048  thrpt   15  66.095 ? 0.460  ops/ms
> FloatConversion.floatToInt      2048  thrpt   15  68.114 ? 0.072  ops/ms
> FloatConversion.floatToLong     2048  thrpt   15  68.482 ? 0.193  ops/ms

tier1 on unmatched board is clean.

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/57#issuecomment-1560302809

From fjiang at openjdk.org  Wed May 24 00:55:25 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Wed, 24 May 2023 00:55:25 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8307446: RISC-V: Improve
 performance of floating point to integer conversion
In-Reply-To: <YCzl2OCICgc9iFZry-2ihNWQ9uLwrZA0aefYySSGMoc=.f234b693-fb44-4948-aa7b-0a1a6c04f65e@github.com>
References: <YCzl2OCICgc9iFZry-2ihNWQ9uLwrZA0aefYySSGMoc=.f234b693-fb44-4948-aa7b-0a1a6c04f65e@github.com>
Message-ID: <rJsDva8qU_BDXvSXyUDjLv0TF9gdnt7OJmpQIXgRQKI=.0e5dd016-fd8b-43d5-b1fa-9c1fd621ecc4@github.com>

On Mon, 22 May 2023 04:22:49 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> Hi,
> please review this clean backport of [JDK-8307446](https://bugs.openjdk.org/browse/JDK-8307446).
> 
> JHM shows the same improvement on Unmatched board:
> 
> 
> Benchmark                     (size)   Mode  Cnt   Score   Error   Units
> --- baseline -----------------------------------------------------------
> FloatConversion.doubleToInt     2048  thrpt   15  30.270 ? 0.144  ops/ms
> FloatConversion.doubleToLong    2048  thrpt   15  29.831 ? 0.128  ops/ms
> FloatConversion.floatToInt      2048  thrpt   15  30.530 ? 0.031  ops/ms
> FloatConversion.floatToLong     2048  thrpt   15  30.189 ? 0.100  ops/ms
> --- optimized ----------------------------------------------------------
> FloatConversion.doubleToInt     2048  thrpt   15  66.051 ? 0.064  ops/ms
> FloatConversion.doubleToLong    2048  thrpt   15  66.095 ? 0.460  ops/ms
> FloatConversion.floatToInt      2048  thrpt   15  68.114 ? 0.072  ops/ms
> FloatConversion.floatToLong     2048  thrpt   15  68.482 ? 0.193  ops/ms

This pull request has now been integrated.

Changeset: a9384466
Author:    Feilong Jiang <fjiang at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/a9384466086ca21044ff14bbec59cdef8ebe29b5
Stats:     18 lines in 1 file changed: 0 ins; 1 del; 17 mod

8307446: RISC-V: Improve performance of floating point to integer conversion

Reviewed-by: fyang
Backport-of: 1f57ce0a068a1346f3aa79f861981bd03c6f6d45

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/57

From dzhang at openjdk.org  Wed May 24 07:33:32 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Wed, 24 May 2023 07:33:32 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301628: RISC-V: c2 fix
 pipeline class for several instructions
In-Reply-To: <6kkID34TO4XkfUCxmw4YhTm2NIhdcdnzUC1Zp__Qggw=.4b033d51-5dc0-470e-b681-a2ae729a9059@github.com>
References: <6kkID34TO4XkfUCxmw4YhTm2NIhdcdnzUC1Zp__Qggw=.4b033d51-5dc0-470e-b681-a2ae729a9059@github.com>
Message-ID: <leV1kANBL5d-JZg0aSDIPcEm8Z9lM2ikBa4xd5OWC8g=.d5bfb2b0-9e40-47a6-9850-af4de75b5e65@github.com>

On Tue, 23 May 2023 03:15:52 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Hi, please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301628](https://bugs.openjdk.org/browse/JDK-8301628).
> The original patch cannot be directly applied because jdk17u has no [JDK-8293695](https://bugs.openjdk.org/browse/JDK-8293695).
> 
> Testing:
> - Tier1-3 passed without new failure on unmacthed (release).

Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/59#issuecomment-1560594856

From dzhang at openjdk.org  Wed May 24 07:54:27 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Wed, 24 May 2023 07:54:27 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8301628: RISC-V: c2 fix
 pipeline class for several instructions
In-Reply-To: <6kkID34TO4XkfUCxmw4YhTm2NIhdcdnzUC1Zp__Qggw=.4b033d51-5dc0-470e-b681-a2ae729a9059@github.com>
References: <6kkID34TO4XkfUCxmw4YhTm2NIhdcdnzUC1Zp__Qggw=.4b033d51-5dc0-470e-b681-a2ae729a9059@github.com>
Message-ID: <IUyYXn4ZdgmIjAtRs7qK9YVRfqyBb-T3-CRFDOZ19BE=.78976671-0b61-4a86-8587-d129001a3985@github.com>

On Tue, 23 May 2023 03:15:52 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Hi, please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301628](https://bugs.openjdk.org/browse/JDK-8301628).
> The original patch cannot be directly applied because jdk17u has no [JDK-8293695](https://bugs.openjdk.org/browse/JDK-8293695).
> 
> Testing:
> - Tier1-3 passed without new failure on unmacthed (release).

This pull request has now been integrated.

Changeset: 7743fb84
Author:    Dingli Zhang <dzhang at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/7743fb84e1c4f2a1d1b9918fe28680b71d5d1ef4
Stats:     12 lines in 1 file changed: 0 ins; 0 del; 12 mod

8301628: RISC-V: c2 fix pipeline class for several instructions

Reviewed-by: fyang
Backport-of: 8507db1567e3a524238f5145ed08fd1d80a2a2b2

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/59

From dzhang at openjdk.org  Wed May 24 08:03:51 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Wed, 24 May 2023 08:03:51 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301852: RISC-V: Optimize class
 atomic when order is memory_order_relaxed
Message-ID: <wyg4U2FEWXmU8anVAnVDGwz9i2EAvRm4hr4dyjZBVHk=.170536e7-b138-40f2-b15f-8ff82381e3b5@github.com>

Hi, please review this backport to riscv-port-jdk17u.
Backport of [JDK-8301852](https://bugs.openjdk.org/browse/JDK-8301852). Applies cleanly.

Testing:
- Tier1-3 passed without new failure on unmacthed (release).

-------------

Commit messages:
 - 8301852: RISC-V: Optimize class atomic when order is memory_order_relaxed

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/60/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=60&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8301852
  Stats: 36 lines in 1 file changed: 18 ins; 1 del; 17 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/60.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/60/head:pull/60

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/60

From gcao at openjdk.org  Wed May 24 15:51:55 2023
From: gcao at openjdk.org (Gui Cao)
Date: Wed, 24 May 2023 15:51:55 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301153: RISC-V: pipeline class
 for several instructions is not set correctly
Message-ID: <XFUNItO4S3vQ5Mq7WPK1oLKDQBrVaIT4uJBBOe1XWHI=.de160b79-f5a1-4b6e-9f44-d5dc7ee430ec@github.com>

Hi,
Please review this backport to riscv-port-jdk17u.
Backport of [JDK-8301153](https://bugs.openjdk.org/browse/JDK-8301153). Applies cleanly.

Testing:

Tier1-3 passed without new failure on unmacthed (release).

-------------

Commit messages:
 - backport RISC-V: pipeline class for several instructions is not set correctly

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/61/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=61&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8301153
  Stats: 20 lines in 1 file changed: 1 ins; 0 del; 19 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/61.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/61/head:pull/61

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/61

From duke at openjdk.org  Thu May 25 00:05:05 2023
From: duke at openjdk.org (duke)
Date: Thu, 25 May 2023 00:05:05 GMT
Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 29 new changesets
Message-ID: <1b9bcc46-6f72-4c61-a25d-e6801ef1ae57@openjdk.org>

Changeset: 4a0f0f46
Author:    Christoph Langer <clanger at openjdk.org>
Date:      2023-05-22 09:42:41 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/4a0f0f463e38ac08e8c515b3611401b51554995d

8276058: Some swing test fails on specific CI macos system
8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058

Backport-of: 91607436b79126ccb999deaf38a98209dbfe6ec1

! test/jdk/ProblemList.txt
! test/jdk/java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java
! test/jdk/javax/swing/JButton/8151303/PressedIconTest.java
! test/jdk/javax/swing/JInternalFrame/8069348/bug8069348.java
! test/jdk/javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java

Changeset: 36c364d5
Author:    Christoph Langer <clanger at openjdk.org>
Date:      2023-05-22 09:48:50 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/36c364d5b455b55e38713f14f5a95c910d4224f9

8284331: Add sanity check for signal handler modification warning.

Reviewed-by: kevinw
Backport-of: 116763cb5d58a7316b7bada689a0fa34a7250ee7

! test/jdk/sun/tools/jcmd/TestJcmdSanity.java

Changeset: 406d6ba3
Author:    William Kemper <wkemper at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-22 16:56:35 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/406d6ba392083d1262a5303417f6da0b0a261789

8307378: Allow collectors to provide specific values for GC notifications' actions

Reviewed-by: phh
Backport-of: 8f816bbd28f2b771f2b070f49718a492c1a0771a

! src/hotspot/share/gc/epsilon/epsilonHeap.hpp
! src/hotspot/share/gc/g1/g1MonitoringSupport.cpp
! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp
! src/hotspot/share/gc/parallel/psParallelCompact.cpp
! src/hotspot/share/gc/parallel/psScavenge.cpp
! src/hotspot/share/gc/serial/serialHeap.cpp
! src/hotspot/share/gc/shared/genCollectedHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
! src/hotspot/share/gc/shenandoah/shenandoahUtils.cpp
! src/hotspot/share/gc/shenandoah/shenandoahUtils.hpp
! src/hotspot/share/gc/shenandoah/shenandoahVMOperations.cpp
! src/hotspot/share/gc/z/zServiceability.cpp
! src/hotspot/share/gc/z/zServiceability.hpp
! src/hotspot/share/services/memoryManager.cpp
! src/hotspot/share/services/memoryManager.hpp
! src/hotspot/share/services/memoryService.cpp
! src/hotspot/share/services/memoryService.hpp
! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestPauseNotifications.java

Changeset: 2913a8dc
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-22 18:54:36 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/2913a8dcc5081b664afa9ed06e558ac7d9ea57ea

8306753: Open source several container AWT tests

Backport-of: b372f28ad4b7c1f46e0070a930911542d4d1a032

+ test/jdk/java/awt/Container/FindComponentAtTest.java
+ test/jdk/java/awt/Container/FindComponentTest.java
+ test/jdk/java/awt/Container/FocusTraversalPolicyProviderTest.java
+ test/jdk/java/awt/Container/PropertyEventsTest.java

Changeset: 879f4c59
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-23 08:51:26 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/879f4c591b82494157f3013041695a4cc4f1996b

8297154: Improve safepoint cleanup logging

Backport-of: 086763a629fe8b0592f5566c6e346716868d5e63

! src/hotspot/share/runtime/safepoint.cpp
! src/hotspot/share/runtime/safepoint.hpp

Changeset: 6b362e43
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-23 09:57:11 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/6b362e4317ddcfb8da6e8e78b4408b9aff0a9c79

8261495: Shenandoah: reconsider update references memory ordering

Backport-of: a96012a7afce6678125d3fb537f2433642953315

! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahBarrierSetClone.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahClosures.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp
! src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.cpp

Changeset: 32fda320
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
Date:      2023-05-23 10:03:13 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/32fda3200c6e9ad6d533c1d741fb805b987f74dd

8296343: CPVE thrown on missing content-length in OCSP response

Backport-of: 1a3cb8c5018bc016c2ad6b078e4abe13b39d151c

! src/java.base/share/classes/sun/security/provider/certpath/OCSP.java
! test/jdk/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java
! test/jdk/java/security/testlibrary/SimpleOCSPServer.java
! test/jdk/javax/net/ssl/Stapling/HttpsUrlConnClient.java
! test/jdk/javax/net/ssl/Stapling/SSLEngineWithStapling.java
! test/jdk/javax/net/ssl/Stapling/SSLSocketWithStapling.java
! test/jdk/javax/net/ssl/Stapling/StapleEnableProps.java
+ test/jdk/sun/security/provider/certpath/OCSP/OCSPNoContentLength.java
! test/jdk/sun/security/ssl/Stapling/java.base/sun/security/ssl/StatusResponseManagerTests.java

Changeset: 9cb01207
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
Date:      2023-05-23 11:49:02 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/9cb01207b371e3e0f0af3652b78dd623205b537f

8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression

Backport-of: d7c283a081c37bfb8bc5934e4b2af16cad512fd2

! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
! test/langtools/tools/javac/diags/examples/LambdaDeduplicate.java
+ test/langtools/tools/javac/lambda/deduplication/DeduplicationDebugInfo.java
+ test/langtools/tools/javac/lambda/deduplication/DeduplicationDebugInfo.out
= test/langtools/tools/javac/lambda/deduplication/DeduplicationDebugInfo_none.out
! test/langtools/tools/javac/lambda/deduplication/DeduplicationTest.java

Changeset: 39a6b558
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-23 11:57:15 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/39a6b55847be24e85a9d0e9ddb423808e7d1d57f

8287854: Dangling reference in ClassVerifier::verify_class

Backport-of: 3fa99844a69401f84677e7d512ffd937f7f16898

! src/hotspot/share/classfile/verifier.cpp
! src/hotspot/share/classfile/verifier.hpp

Changeset: 17b36401
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
Date:      2023-05-23 12:19:01 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/17b364016fe54311d8ed173abf7c42b713011fa1

8268582: javadoc throws NPE with --ignore-source-errors option

Backport-of: 0dfb3a705d2ad0ce4ac0f7dd18fb65d7ae735f16

! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java
! test/langtools/jdk/javadoc/tool/IgnoreSourceErrors.java

Changeset: 2dc22d6a
Author:    Jiangli Zhou <jiangli at openjdk.org>
Date:      2023-05-23 16:21:32 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/2dc22d6a5c3f6cb6a1a98351278cb51f65834b86

8307134: Add GTS root CAs

Reviewed-by: phh
Backport-of: 03030d47ebee5c20919fe0162ec86d3d400cd955

+ make/data/cacerts/gtsrootcar1
+ make/data/cacerts/gtsrootcar2
+ make/data/cacerts/gtsrootecccar3
+ make/data/cacerts/gtsrootecccar4
+ test/jdk/security/infra/java/security/cert/CertPathValidator/certification/GoogleCA.java
! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Changeset: 073d1a35
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:08:10 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/073d1a350ec450b0e1ee63f06a3ed771dd5b56a0

8306954: Open source five Focus related tests

Backport-of: 6d6d00b69cea47ccbe05a844db0fb6c384045caa

+ test/jdk/java/awt/Focus/AsyncUpFocusCycleTest.java
+ test/jdk/java/awt/Focus/ClearMostRecentFocusOwnerTest.java
+ test/jdk/java/awt/Focus/ConsumedTabKeyTest.java
+ test/jdk/java/awt/Focus/EventRetargetTest.java
+ test/jdk/java/awt/Focus/ExtraPropChangeNotifVetoingTest.java

Changeset: 7557ec1f
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:10:01 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/7557ec1f7959cda3aab1b84d568463f2fd446370

8306432: Open source several AWT Text Component related tests

Backport-of: 485a0691f4a762e9673967b7873356fb65afc5bc

+ test/jdk/java/awt/TextComponent/CorrectSetCaretPositionDuringInitPeerTest.java
+ test/jdk/java/awt/TextComponent/DeselectionDuringDoSelectionNonVisibleTest.java
+ test/jdk/java/awt/TextComponent/GetCaretPosOutOfBoundsTest.java
+ test/jdk/java/awt/TextComponent/InitialInsertionCaretPositionTest.java
+ test/jdk/java/awt/TextComponent/MiddleMouseClickPasteTest.java

Changeset: 88942252
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:10:49 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/8894225213fbff0f9d8dd1b82555a40dae04ca21

8306955: Open source several JComboBox jtreg tests

Backport-of: 1f689241cfcb4083cba283a2010b532948865283

+ test/jdk/javax/swing/JComboBox/bug4167850.java
+ test/jdk/javax/swing/JComboBox/bug4209474.java
+ test/jdk/javax/swing/JComboBox/bug4234119.java
+ test/jdk/javax/swing/JComboBox/bug4890345.java
+ test/jdk/javax/swing/JComboBox/bug4996503.java

Changeset: c06de01c
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:11:44 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/c06de01cdadd8f6ecf51fb7381417fb7afbfee56

8306681: Open source more AWT DnD related tests

Backport-of: 05af487a2d9b85b87d13ea23776d04e52c67bf49

+ test/jdk/java/awt/dnd/ZeroFormatTransferableTest.java
+ test/jdk/java/awt/event/ComponentEvent/ComponentResizedTest.java
+ test/jdk/java/awt/event/ComponentEvent/ObjectSourceTest.java
+ test/jdk/java/awt/event/ComponentEvent/ResizeDeniedTest.java
+ test/jdk/java/awt/event/FocusEvent/OppositeSerialization/OppositeSerialization.java
+ test/jdk/java/awt/event/FocusEvent/OppositeSerialization/old.ser
+ test/jdk/java/awt/event/HierarchyEvent/HierarchyEventOnWindowTest.java

Changeset: 04b95add
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:12:26 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/04b95add2f2701a40616a507130197faa02ccf9b

8306466: Open source more AWT Drag & Drop related tests

Backport-of: 418a82551a2c58e43963beb5aa242a58bbd30e2f

+ test/jdk/java/awt/dnd/RejectDragDropActionTest.java
+ test/jdk/java/awt/dnd/RemoveDragSourceListenerTest.java
+ test/jdk/java/awt/dnd/RemoveParentChildDropTargetTest.java
+ test/jdk/java/awt/dnd/SameJVMModalDialogDeadlockTest.java
+ test/jdk/java/awt/dnd/SkipDropCompleteTest/SkipDropCompleteTest.java
+ test/jdk/java/awt/dnd/SkipDropCompleteTest/SourceFrame.java
+ test/jdk/java/awt/dnd/SkipDropCompleteTest/TargetFrame.java
+ test/jdk/java/awt/dnd/SkipDropCompleteTest/TransferableObject.java

Changeset: e0f5fcde
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:13:17 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/e0f5fcdedf965b47ed2514f65544470326a90784

8306133: Open source few AWT Drag & Drop related tests

Backport-of: ec5c7926f3cea68bf0d0ceb460a8383f5e4ea278

+ test/jdk/java/awt/dnd/NextDropActionTest/NextDropActionTest.java
+ test/jdk/java/awt/dnd/NoFormatsDragEnterTest/NoFormatsDragEnterTest.java
+ test/jdk/java/awt/dnd/NoFormatsDropTest/NoFormatsDropTest.java
+ test/jdk/java/awt/dnd/NoTargetNoDragExitTest/NoTargetNoDragExitTest.java
+ test/jdk/java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java

Changeset: 40526a7f
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:14:08 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/40526a7f07558c8d332ab689b7481c4ffef165ff

8307080: Open source some more JComboBox jtreg tests

Backport-of: b8de39431dca90e63552968829a349a9b63e68ca

+ test/jdk/javax/swing/JComboBox/bug4171464.java
+ test/jdk/javax/swing/JComboBox/bug4244614.java
+ test/jdk/javax/swing/JComboBox/bug4276920.java
+ test/jdk/javax/swing/JComboBox/bug4924758.java
+ test/jdk/javax/swing/JComboBox/bug5029504.java

Changeset: 7277a753
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:14:49 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/7277a75307c4b299d1be55a5cc3d0a0798be7b73

8306072: Open source several AWT MouseInfo related tests

Backport-of: 44d9f55d0b3c469988be6f1c47f0cfbc433c4490

+ test/jdk/java/awt/MouseInfo/ButtonsNumber.java
+ test/jdk/java/awt/MouseInfo/ContainerMousePositionTest.java

Changeset: 536e133a
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:15:47 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/536e133ab9e64759d384120a4dc463e5f5a931a0

8306850: Open source AWT Modal related tests

Backport-of: 41ba05e450ed4467535bcee81946099e38665c3f

+ test/jdk/java/awt/Modal/BlockedMouseInputTest.java
+ test/jdk/java/awt/Modal/BlockedMouseInputTest2.java
+ test/jdk/java/awt/Modal/BlockedMouseInputTest3.java
+ test/jdk/java/awt/Modal/ModalDialogCannotBeMadeNonModalTest.java
+ test/jdk/java/awt/Modal/NonModalDialogReceiveEventsAfterModalTest.java
+ test/jdk/java/awt/Modal/ParentCatchupDraggingChildDialogTest.java

Changeset: 18ec0087
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:16:40 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/18ec0087a583b9da4e56c5553969c7dcac8ac346

8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests

Backport-of: 732179ca84ee1dab6530255c33de7f35cab649c2

+ test/jdk/java/awt/KeyboardFocusmanager/ChangeKFMTest.java
+ test/jdk/java/awt/KeyboardFocusmanager/PropertySupportNPETest.java
+ test/jdk/java/awt/Label/NullLabelTest.java
+ test/jdk/java/awt/Layout/InsetsTest.java
+ test/jdk/java/awt/LightweightComponent/LWClobberDragEvent.java
+ test/jdk/java/awt/LightweightComponent/LightweightDragTest.java

Changeset: 09e68807
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:17:24 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/09e688070bfc3a3db3303a4e87c3879b6c00578a

8306652: Open source AWT MenuItem related tests

Backport-of: ed1ebd242a4bb82a7074564ea96dc3d26b78f9e1

+ test/jdk/java/awt/MenuItem/EnableTest.java
+ test/jdk/java/awt/MenuItem/MenuSetLabelTest.java
+ test/jdk/java/awt/MenuItem/SetLabelWithPeerCreatedTest.java
+ test/jdk/java/awt/MenuItem/SetStateTest.java

Changeset: b5d3772b
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:18:06 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/b5d3772bcca59f99010123d7b0758bfd162faaeb

8306683: Open source several clipboard and color AWT tests

Backport-of: 1c2dadc31e8b732d43df5494437720bfbc3f5c8b

+ test/jdk/java/awt/Clipboard/DelayedQueryTest.java
+ test/jdk/java/awt/Clipboard/NullContentsTest.java
+ test/jdk/java/awt/Clipboard/SerializeLocalFlavorTest.java
+ test/jdk/java/awt/ColorClass/ColorSerializationTest.java

Changeset: 4caa4214
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:18:50 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/4caa421411d5aa4fbcb975b95b49c8b3e5ff462b

8306755: Open source few Swing JComponent and AbstractButton tests

Backport-of: f3e8bd1d1161772539f42405fc4fcb02259f5b66

+ test/jdk/javax/swing/AbstractButton/bug4143867.java
+ test/jdk/javax/swing/AbstractButton/bug4147740.java
+ test/jdk/javax/swing/AbstractButton/bug4246045.java
+ test/jdk/javax/swing/JComponent/bug4419219.java
+ test/jdk/javax/swing/JComponent/bug4962718.java

Changeset: 9c0afc5c
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-23 17:19:33 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/9c0afc5c441e10f6c5531395a7974708d5563c89

8306752: Open source several container and component AWT tests

Backport-of: 88d9ebf8e80eeead3e4a1494ba537530c16b75e1

+ test/jdk/java/awt/Component/GetListenersTest.java
+ test/jdk/java/awt/Container/OpenedPopupFrameDisposal.java
+ test/jdk/java/awt/Container/RemoveByIndexExceptionTest.java
+ test/jdk/java/awt/Container/ShowingChangedEventTest.java

Changeset: 05b2ff45
Author:    Goetz Lindenmaier <goetz at openjdk.org>
Date:      2023-05-24 06:59:15 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/05b2ff459011f45e49929ac8a8cb18092246813b

8308554: [17u] Fix commit of 8286191. vm.musl was not removed from ExternalEditorTest

Reviewed-by: shade

! test/langtools/jdk/jshell/ExternalEditorTest.java

Changeset: 6033871f
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-24 08:57:24 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/6033871fdbf4c1b63ee8de0e4f0412dde66198b5

8306640: Open source several AWT TextArea related tests

Backport-of: 169a7c27a7c6521fbfb1e61fbe85e6d7b0470619

+ test/jdk/java/awt/TextArea/ReplaceRangeTest.java
+ test/jdk/java/awt/TextArea/TextAreaCRLFAutoDetectTest.java
+ test/jdk/java/awt/TextArea/TextLengthTest.java
+ test/jdk/java/awt/TextArea/TextLimitTest.java

Changeset: 464a32b0
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-24 17:00:45 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/464a32b0ee50972d93a1df5bfcac5c87052d8ef7

8227060: Optimize safepoint cleanup subtask order

Reviewed-by: phh
Backport-of: 96a542feb2064dba155ebf05311752995d164038

! src/hotspot/share/compiler/compilationPolicy.hpp
! src/hotspot/share/runtime/safepoint.cpp
! src/hotspot/share/runtime/safepoint.hpp
! src/hotspot/share/runtime/synchronizer.cpp
! test/hotspot/jtreg/runtime/logging/SafepointCleanupTest.java

Changeset: 3e562255
Author:    Fei Yang <yangfei at iscas.ac.cn>
Date:      2023-05-25 08:00:45 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/3e562255a1bc3fe9093391b3f7d764ae6c565e65

Merge remote-tracking branch 'origin/master' into riscv-port



From fjiang at openjdk.org  Thu May 25 01:04:23 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Thu, 25 May 2023 01:04:23 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8308277: RISC-V: Improve
 vectorization of Match.sqrt() on floats
In-Reply-To: <1Zv6xPpIbVwdfYlMx9cNKrNtK57ceIvmcjT7FArkEuA=.e44afbd6-3eca-4ae8-bb17-f24777bcc8c9@github.com>
References: <1Zv6xPpIbVwdfYlMx9cNKrNtK57ceIvmcjT7FArkEuA=.e44afbd6-3eca-4ae8-bb17-f24777bcc8c9@github.com>
Message-ID: <YEzDfC_MI0wNOymHCdUQ-IRl1hiODxf5La-jH4tnvDI=.9bc2a49b-33a5-416f-9f19-ee1ca091a4c4@github.com>

On Mon, 22 May 2023 10:40:45 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> Hi,
> Please review this clean backport of [JDK-8308277](https://bugs.openjdk.org/browse/JDK-8308277).
> 
> For jdk17u, `Math.sqrt(float)` will not get vectorized even when `UseRVV` is true without the `SqrtF` node.
> 
> Here is the OptoAssembly of Sqrt.java from [JDK-8190800](https://bugs.openjdk.org/browse/JDK-8190800):
> 
> before:
> 
> 120     B14: #  out( B14 B15 ) <- in( B13 B14 ) Loop( B14-B14 inner main of N91 strip mined) Freq: 1.86254e+07
> 120 +   addw  R28, R12, zr  #@convI2L_reg_reg
> 124 +   slli  R28, R28, (#2 & 0x3f) #@lShiftL_reg_imm
> 128 +   add R28, R18, R28   # ptr, #@addP_reg_reg
> 12c +   flw  F0, [R28, #16] # float, #@loadF
> 130 +   fsqrt.s  F1, F0 #@sqrtF_reg
> 134 +   fsw  F1, [R28, #16] # float, #@storeF
> 
> 
> after:
> 
> 140     B14: #  out( B14 B15 ) <- in( B13 B14 ) Loop( B14-B14 inner main of N93 strip mined) Freq: 1.60517e+07
> 140     addw  R10, R31, zr  #@convI2L_reg_reg
> 144     slli  R10, R10, (#2 & 0x3f) #@lShiftL_reg_imm
> 148     add R11, R9, R10    # ptr, #@addP_reg_reg
> 14c     addi  R10, R11, #16 # ptr, #@addP_reg_imm
> 150     vle V1, [R10]   #@loadV
> 158     vfsqrt.v V1, V1 #@vsqrtF
> 160     addi  R10, R11, #16 # ptr, #@addP_reg_imm
> 164     vse V1, [R10]   #@storeV

tier1 looks good.

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/58#issuecomment-1562117141

From fjiang at openjdk.org  Thu May 25 01:09:26 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Thu, 25 May 2023 01:09:26 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8308277: RISC-V: Improve
 vectorization of Match.sqrt() on floats
In-Reply-To: <1Zv6xPpIbVwdfYlMx9cNKrNtK57ceIvmcjT7FArkEuA=.e44afbd6-3eca-4ae8-bb17-f24777bcc8c9@github.com>
References: <1Zv6xPpIbVwdfYlMx9cNKrNtK57ceIvmcjT7FArkEuA=.e44afbd6-3eca-4ae8-bb17-f24777bcc8c9@github.com>
Message-ID: <v8IU3-twcN1mEIIGEZcMTzQVjBUmfQNbDgm0_hbzdWM=.42eb5e68-f7c8-4d56-8cff-52d83c28d231@github.com>

On Mon, 22 May 2023 10:40:45 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> Hi,
> Please review this clean backport of [JDK-8308277](https://bugs.openjdk.org/browse/JDK-8308277).
> 
> For jdk17u, `Math.sqrt(float)` will not get vectorized even when `UseRVV` is true without the `SqrtF` node.
> 
> Here is the OptoAssembly of Sqrt.java from [JDK-8190800](https://bugs.openjdk.org/browse/JDK-8190800):
> 
> before:
> 
> 120     B14: #  out( B14 B15 ) <- in( B13 B14 ) Loop( B14-B14 inner main of N91 strip mined) Freq: 1.86254e+07
> 120 +   addw  R28, R12, zr  #@convI2L_reg_reg
> 124 +   slli  R28, R28, (#2 & 0x3f) #@lShiftL_reg_imm
> 128 +   add R28, R18, R28   # ptr, #@addP_reg_reg
> 12c +   flw  F0, [R28, #16] # float, #@loadF
> 130 +   fsqrt.s  F1, F0 #@sqrtF_reg
> 134 +   fsw  F1, [R28, #16] # float, #@storeF
> 
> 
> after:
> 
> 140     B14: #  out( B14 B15 ) <- in( B13 B14 ) Loop( B14-B14 inner main of N93 strip mined) Freq: 1.60517e+07
> 140     addw  R10, R31, zr  #@convI2L_reg_reg
> 144     slli  R10, R10, (#2 & 0x3f) #@lShiftL_reg_imm
> 148     add R11, R9, R10    # ptr, #@addP_reg_reg
> 14c     addi  R10, R11, #16 # ptr, #@addP_reg_imm
> 150     vle V1, [R10]   #@loadV
> 158     vfsqrt.v V1, V1 #@vsqrtF
> 160     addi  R10, R11, #16 # ptr, #@addP_reg_imm
> 164     vse V1, [R10]   #@storeV

This pull request has now been integrated.

Changeset: 42f752d9
Author:    Feilong Jiang <fjiang at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/42f752d97ed9f3df7e6d8175aaa3ee8f369b5b67
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8308277: RISC-V: Improve vectorization of Match.sqrt() on floats

Reviewed-by: fyang
Backport-of: e520cdc882a778260181a2162a01ceff7cc41ca0

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/58

From fjiang at openjdk.org  Thu May 25 01:32:23 2023
From: fjiang at openjdk.org (Feilong Jiang)
Date: Thu, 25 May 2023 01:32:23 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301153: RISC-V: pipeline
 class for several instructions is not set correctly
In-Reply-To: <XFUNItO4S3vQ5Mq7WPK1oLKDQBrVaIT4uJBBOe1XWHI=.de160b79-f5a1-4b6e-9f44-d5dc7ee430ec@github.com>
References: <XFUNItO4S3vQ5Mq7WPK1oLKDQBrVaIT4uJBBOe1XWHI=.de160b79-f5a1-4b6e-9f44-d5dc7ee430ec@github.com>
Message-ID: <vqxFAUuf-vldTKuJXl8t8bAj6--MnIim0bz8nQSyJMo=.17bc3fd3-a08f-4d92-b574-fa6905c17cf7@github.com>

On Wed, 24 May 2023 15:43:02 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi,
> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301153](https://bugs.openjdk.org/browse/JDK-8301153). Applies cleanly.
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

Marked as reviewed by fjiang (Author).

-------------

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/61#pullrequestreview-1442950768

From fyang at openjdk.org  Fri May 26 02:19:21 2023
From: fyang at openjdk.org (Fei Yang)
Date: Fri, 26 May 2023 02:19:21 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301153: RISC-V: pipeline
 class for several instructions is not set correctly
In-Reply-To: <XFUNItO4S3vQ5Mq7WPK1oLKDQBrVaIT4uJBBOe1XWHI=.de160b79-f5a1-4b6e-9f44-d5dc7ee430ec@github.com>
References: <XFUNItO4S3vQ5Mq7WPK1oLKDQBrVaIT4uJBBOe1XWHI=.de160b79-f5a1-4b6e-9f44-d5dc7ee430ec@github.com>
Message-ID: <xalzByMbQrpOGFTbudBZ_4CDU2M5yoj_TdlFnmCaPhw=.49bcf121-20fe-4428-bbdb-6acc632cc352@github.com>

On Wed, 24 May 2023 15:43:02 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi,
> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301153](https://bugs.openjdk.org/browse/JDK-8301153). Applies cleanly.
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

Marked as reviewed by fyang (Lead).

-------------

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/61#pullrequestreview-1444876958

From fyang at openjdk.org  Fri May 26 02:26:21 2023
From: fyang at openjdk.org (Fei Yang)
Date: Fri, 26 May 2023 02:26:21 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301852: RISC-V: Optimize
 class atomic when order is memory_order_relaxed
In-Reply-To: <wyg4U2FEWXmU8anVAnVDGwz9i2EAvRm4hr4dyjZBVHk=.170536e7-b138-40f2-b15f-8ff82381e3b5@github.com>
References: <wyg4U2FEWXmU8anVAnVDGwz9i2EAvRm4hr4dyjZBVHk=.170536e7-b138-40f2-b15f-8ff82381e3b5@github.com>
Message-ID: <laSQmh6TlWwgYtSTH7lx1KDedftFKCbaxX5H-gCBZGs=.45b06c3c-94eb-4460-8059-f3a5ae504941@github.com>

On Wed, 24 May 2023 07:55:27 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Hi, please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301852](https://bugs.openjdk.org/browse/JDK-8301852). Applies cleanly.
> 
> Testing:
> - Tier1-3 passed without new failure on unmacthed (release).

Marked as reviewed by fyang (Lead).

-------------

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/60#pullrequestreview-1444883856

From dzhang at openjdk.org  Fri May 26 06:56:21 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Fri, 26 May 2023 06:56:21 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301852: RISC-V: Optimize
 class atomic when order is memory_order_relaxed
In-Reply-To: <wyg4U2FEWXmU8anVAnVDGwz9i2EAvRm4hr4dyjZBVHk=.170536e7-b138-40f2-b15f-8ff82381e3b5@github.com>
References: <wyg4U2FEWXmU8anVAnVDGwz9i2EAvRm4hr4dyjZBVHk=.170536e7-b138-40f2-b15f-8ff82381e3b5@github.com>
Message-ID: <Wn9RdJJXPQo8luuqEE9OoMKUsJXDCo83yQEfJmQL7x4=.20cd9122-ee9c-4537-8e30-0b63a704caea@github.com>

On Wed, 24 May 2023 07:55:27 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Hi, please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301852](https://bugs.openjdk.org/browse/JDK-8301852). Applies cleanly.
> 
> Testing:
> - Tier1-3 passed without new failure on unmacthed (release).

Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk17u/pull/60#issuecomment-1563892801

From dzhang at openjdk.org  Fri May 26 07:22:25 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Fri, 26 May 2023 07:22:25 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8301852: RISC-V: Optimize
 class atomic when order is memory_order_relaxed
In-Reply-To: <wyg4U2FEWXmU8anVAnVDGwz9i2EAvRm4hr4dyjZBVHk=.170536e7-b138-40f2-b15f-8ff82381e3b5@github.com>
References: <wyg4U2FEWXmU8anVAnVDGwz9i2EAvRm4hr4dyjZBVHk=.170536e7-b138-40f2-b15f-8ff82381e3b5@github.com>
Message-ID: <diL1WKh6LHQty_3aCRkR_IAIZQFzENU3lzSIvh2kfD0=.cea3ed93-91ef-4b06-a6be-d40f7fa5c2ec@github.com>

On Wed, 24 May 2023 07:55:27 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Hi, please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301852](https://bugs.openjdk.org/browse/JDK-8301852). Applies cleanly.
> 
> Testing:
> - Tier1-3 passed without new failure on unmacthed (release).

This pull request has now been integrated.

Changeset: bac6ef76
Author:    Dingli Zhang <dzhang at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/bac6ef76ced0e997f820a2ef8fa0c5c16cd28d07
Stats:     36 lines in 1 file changed: 18 ins; 1 del; 17 mod

8301852: RISC-V: Optimize class atomic when order is memory_order_relaxed

Reviewed-by: fyang
Backport-of: 1fec6b5953b51dae4be640d6e4e4f79136b9348d

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/60

From gcao at openjdk.org  Fri May 26 07:35:27 2023
From: gcao at openjdk.org (Gui Cao)
Date: Fri, 26 May 2023 07:35:27 GMT
Subject: [riscv-port-jdk17u:riscv-port] Integrated: 8301153: RISC-V: pipeline
 class for several instructions is not set correctly
In-Reply-To: <XFUNItO4S3vQ5Mq7WPK1oLKDQBrVaIT4uJBBOe1XWHI=.de160b79-f5a1-4b6e-9f44-d5dc7ee430ec@github.com>
References: <XFUNItO4S3vQ5Mq7WPK1oLKDQBrVaIT4uJBBOe1XWHI=.de160b79-f5a1-4b6e-9f44-d5dc7ee430ec@github.com>
Message-ID: <EOJnyZFNzbBz60Un4BXLUqJAD4uBlcIvrQ-c0K_7PZc=.8ae2c215-26b0-4375-b125-0b9b188411ba@github.com>

On Wed, 24 May 2023 15:43:02 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi,
> Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301153](https://bugs.openjdk.org/browse/JDK-8301153). Applies cleanly.
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

This pull request has now been integrated.

Changeset: 09020a43
Author:    Gui Cao <gcao at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/09020a43a5aa0744b701a01dc81ed4cc22f35abc
Stats:     20 lines in 1 file changed: 1 ins; 0 del; 19 mod

8301153: RISC-V: pipeline class for several instructions is not set correctly

Reviewed-by: fjiang, fyang
Backport-of: 9cc0171ed51eef0deb63fe3a5923bae9cf0f5ff0

-------------

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/61

From gcao at openjdk.org  Fri May 26 14:37:04 2023
From: gcao at openjdk.org (Gui Cao)
Date: Fri, 26 May 2023 14:37:04 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301818: RISC-V: Factor out
 function mvw from MacroAssembler
Message-ID: <y7x4XGglPCee2XiHQCe6Z8vAvPTQlnN2Y5XkFpHYNcw=.afdd7934-1683-44f4-9f4d-853159aaa6b3@github.com>

Hi,
Please help review this backport to riscv-port-jdk17u.
Backport of [JDK-8301818](https://bugs.openjdk.org/browse/JDK-8301818), and [JDK-8302114](https://bugs.openjdk.org/browse/JDK-8302114).
Because there is no [JDK-8286301](https://bugs.openjdk.org/browse/JDK-8286301), [JDK-8290154](https://bugs.openjdk.org/browse/JDK-8290154) here in riscv-port-jdk17u, it will show not clean.

Testing:

Tier1-3 passed without new failure on unmacthed (release).

-------------

Commit messages:
 - backport 8301818: RISC-V: Factor out function mvw from MacroAssembler

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/62/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=62&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8301818
  Stats: 30 lines in 9 files changed: 0 ins; 2 del; 28 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/62.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/62/head:pull/62

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/62

From duke at openjdk.org  Mon May 29 00:47:59 2023
From: duke at openjdk.org (duke)
Date: Mon, 29 May 2023 00:47:59 GMT
Subject: git: openjdk/riscv-port-jdk17u: riscv-port: 15 new changesets
Message-ID: <1867a3b5-5b57-40e3-b375-bd474c825681@openjdk.org>

Changeset: fe17568e
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-05-25 08:47:32 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/fe17568ea90b1f23b924474ce6b38a8f1e9f4d45

8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed

Backport-of: d43a5a289f4ac84480bf54ab304c1ce1dbc8e067

! test/jdk/java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java

Changeset: 861fe74b
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-25 09:03:14 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/861fe74ba20fd807528d4eef6669bbef3fc65074

8274615: Support relaxed atomic add for linux-aarch64

Reviewed-by: aph
Backport-of: 8de26361f7d789c7b317536198c891756038a8ea

! src/hotspot/cpu/aarch64/atomic_aarch64.hpp
! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp
! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.S
! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp

Changeset: 50aabaa9
Author:    Arno Zeller <azeller at openjdk.org>
Committer: Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-05-25 09:12:22 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/50aabaa9ca4adbaf82d1d92d8f07f9f9cbf7a8fa

8307347: serviceability/sa/ClhsdbDumpclass.java could leave files owned by root on macOS

Backport-of: 5c7ede94ae59b46c12d40a38bf5b7e15319cc7e2

! test/hotspot/jtreg/serviceability/sa/ClhsdbDumpclass.java

Changeset: 436d96fd
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-25 11:38:03 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/436d96fd12236c42850be9e02803a68c839f6206

8275287: Relax memory ordering constraints on updating instance class and array class counters

Backport-of: 002c538bc03f55fa600f331a66242ee8575919dc

! src/hotspot/share/classfile/classLoaderDataGraph.inline.hpp

Changeset: 57d0a7f1
Author:    Alexey Pavlyutkin <apavlyutkin at azul.com>
Committer: Yuri Nesterenko <yan at openjdk.org>
Date:      2023-05-25 13:49:29 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/57d0a7f1b69214bd2de951c9907fe1321a66f3b8

8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors

Reviewed-by: goetz
Backport-of: da044dd5698d14eccd2a30a24cc691e30fa00cbd

! test/jdk/java/security/testlibrary/SimpleOCSPServer.java
! test/jdk/sun/security/provider/certpath/OCSP/OCSPNoContentLength.java

Changeset: 14779b1f
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-25 18:34:42 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/14779b1f4e82cb0576e4d8d208ee20f256b4ccc2

8294717: (bf) DirectByteBuffer constructor will leak if allocating Deallocator or Cleaner fails with OOME

Backport-of: 4cbac40de956974760cf54183b3ba29f0b5ec331

! src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template

Changeset: c581886c
Author:    Victor Rudometov <vrudomet at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
Date:      2023-05-25 18:53:11 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/c581886c15f0f4352e37a042959cd78eb080d6e4

8307128: Open source some drag and drop tests 4
8307799: Newly added java/awt/dnd/MozillaDnDTest.java has invalid jtreg `@requires` clause

Reviewed-by: phh
Backport-of: 98294242a94c611e2a713c2d520e59dd873ae4a0

+ test/jdk/java/awt/dnd/MouseExitGestureTriggerTest.java
+ test/jdk/java/awt/dnd/MozillaDnDTest.java
+ test/jdk/java/awt/dnd/MultiDataFlavorDropTest.java
+ test/jdk/java/awt/dnd/NativeDragJavaDropTest.java
+ test/jdk/java/awt/dnd/NestedHeavyweightDropTargetTest.java

Changeset: 5bf1b9a5
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-25 19:02:09 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/5bf1b9a53485b571095b934f65c2d6143f748d4f

8283520: JFR: Memory leak in dcmd_arena

Backport-of: 6a8be358d2af34fab8798077202b998badaa5d54

! src/hotspot/share/jfr/dcmd/jfrDcmds.cpp
! src/hotspot/share/jfr/support/jfrThreadLocal.cpp
! src/hotspot/share/jfr/support/jfrThreadLocal.hpp

Changeset: 0d2cc357
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-25 19:10:53 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/0d2cc357dc6547896de34b5c580fa1a83ad15e9f

8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses

Backport-of: c0623972cffdbcd7f80e84a1ec344fd382a4a5cc

! src/hotspot/share/classfile/vmIntrinsics.cpp

Changeset: 6803da9a
Author:    Matthias Baesken <mbaesken at openjdk.org>
Date:      2023-05-26 06:49:42 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/6803da9a4717211e67a65d638526c0a2392ff41a

8301661: Enhance os::pd_print_cpu_info on macOS and Windows

Backport-of: 9145670354c41381614877aa71895dc2bd5cce9d

! make/autoconf/libraries.m4
! src/hotspot/os/bsd/os_bsd.cpp
! src/hotspot/os/windows/os_windows.cpp

Changeset: 6287df05
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-26 07:42:09 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/6287df05cee5781da1c223ed6084d0b2fcc6959b

8286346: 3-parameter version of AllocateHeap should not ignore AllocFailType

Backport-of: 64b05ccbed7879dd38a49453a6098bfe9729ee76

! src/hotspot/share/memory/allocation.cpp

Changeset: 3d32a20e
Author:    Aleksey Shipilev <shade at openjdk.org>
Date:      2023-05-26 10:52:43 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/3d32a20e8921540f148adb9f8b7bd6a46c07d08f

8286331: jni_GetStringUTFChars() uses wrong heap allocator

Backport-of: b0d2b0a3553cbb2db23d543b98ab1401b3dbfa91

! src/hotspot/share/prims/jni.cpp
! src/hotspot/share/utilities/nativeCallStack.hpp

Changeset: 6919ff2c
Author:    Andrew John Hughes <andrew at openjdk.org>
Date:      2023-05-26 14:31:03 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/6919ff2cb00e4f672df30ac0a72bf038e1e8e8d2

8301119: Support for GB18030-2022

Reviewed-by: sgehwolf
Backport-of: a253b4602147633a3d2e83775d1feef4f12a5272

! make/data/charsetmapping/charsets
! make/data/charsetmapping/stdcs-aix
! make/data/charsetmapping/stdcs-linux
- make/data/charsetmapping/stdcs-solaris
! make/data/charsetmapping/stdcs-windows
! make/jdk/src/classes/build/tools/charsetmapping/SPI.java
= src/java.base/share/classes/sun/nio/cs/GB18030.java
! src/java.base/share/classes/sun/nio/cs/StandardCharsets.java.template
! src/jdk.charsets/share/classes/sun/nio/cs/ext/ExtendedCharsets.java.template
! test/jdk/java/nio/charset/Charset/RegisteredCharsets.java
! test/jdk/sun/nio/cs/TestGB18030.java
! test/jdk/sun/nio/cs/mapping/CoderTest.java
! test/jdk/sun/nio/cs/mapping/GB18030.b2c
= test/jdk/sun/nio/cs/mapping/GB18030_2000.b2c

Changeset: 16843770
Author:    Alexey Bakhtin <abakhtin at openjdk.org>
Date:      2023-05-26 17:41:05 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/16843770b5a9a56ff0689b1f70cc5768dfaa7a57

8303809: Dispose context in SPNEGO NegotiatorImpl

Backport-of: 10f16746254ce62031f40ffb0f49f22e81cbe631

! src/java.base/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java
! src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
! src/java.base/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java
! src/java.base/share/classes/sun/net/www/protocol/http/Negotiator.java
! src/java.security.jgss/share/classes/sun/net/www/protocol/http/spnego/NegotiatorImpl.java

Changeset: ace2c5c3
Author:    Fei Yang <yangfei at iscas.ac.cn>
Date:      2023-05-28 15:20:32 +0000
URL:       https://git.openjdk.org/riscv-port-jdk17u/commit/ace2c5c30dd53faa4929fce4397e797584cde26f

Merge branch 'master' into riscv-port

! make/autoconf/libraries.m4
! make/autoconf/libraries.m4


From dzhang at openjdk.org  Mon May 29 01:45:40 2023
From: dzhang at openjdk.org (Dingli Zhang)
Date: Mon, 29 May 2023 01:45:40 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8305008: RISC-V: Factor out
 immediate checking functions from assembler_riscv.inline.hpp
Message-ID: <Uu1po77oRhith-7sD1lgrFefuejHH4lvre5B2rbgw4A=.96019077-48fb-4acb-aea6-059adc25acd2@github.com>

Hi, please review this backport to riscv-port-jdk17u.
Backport of [JDK-8305008](https://bugs.openjdk.org/browse/JDK-8305008).
The original patch cannot be directly applied because jdk17u has no [JDK-8295948](https://bugs.openjdk.org/browse/JDK-8295948) and [JDK-8294100](https://bugs.openjdk.org/browse/JDK-8294100).

Testing:
- Tier1-3 passed without new failure on unmacthed (release).

-------------

Commit messages:
 - 8305008: RISC-V: Factor out immediate checking functions from assembler_riscv.inline.hpp

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/63/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=63&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8305008
  Stats: 149 lines in 11 files changed: 20 ins; 13 del; 116 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/63.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/63/head:pull/63

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/63

From gcao at openjdk.org  Wed May 31 06:08:52 2023
From: gcao at openjdk.org (Gui Cao)
Date: Wed, 31 May 2023 06:08:52 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8302289: RISC-V: Use bgez
 instruction in arraycopy_simple_check when possible
Message-ID: <v6fy0XtrJlLu9FWzPpd-LNicqJKeR7dlh6n8T02uCPo=.0f1954d7-182b-4bf7-91dc-feaf1dd88d57@github.com>

Hi,
Please help review this backport to riscv-port-jdk17u.
Backport of [JDK-8302289](https://bugs.openjdk.org/browse/JDK-8302289). Applies cleanly.

Testing:

Tier1-3 passed without new failure on unmacthed (release).

-------------

Commit messages:
 - backport 8302289: RISC-V: Use bgez instruction in arraycopy_simple_check when possible

Changes: https://git.openjdk.org/riscv-port-jdk17u/pull/64/files
 Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk17u&pr=64&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8302289
  Stats: 5 lines in 1 file changed: 1 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/riscv-port-jdk17u/pull/64.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/64/head:pull/64

PR: https://git.openjdk.org/riscv-port-jdk17u/pull/64

From fyang at openjdk.org  Wed May 31 06:13:28 2023
From: fyang at openjdk.org (Fei Yang)
Date: Wed, 31 May 2023 06:13:28 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8302289: RISC-V: Use bgez
 instruction in arraycopy_simple_check when possible
In-Reply-To: <v6fy0XtrJlLu9FWzPpd-LNicqJKeR7dlh6n8T02uCPo=.0f1954d7-182b-4bf7-91dc-feaf1dd88d57@github.com>
References: <v6fy0XtrJlLu9FWzPpd-LNicqJKeR7dlh6n8T02uCPo=.0f1954d7-182b-4bf7-91dc-feaf1dd88d57@github.com>
Message-ID: <EJr3kMl9hTjwNPKiDTE6wQFggNQWAgH_kklRBdwMVEw=.2d935746-df28-4e68-9bc0-4d7ac7309e3d@github.com>

On Wed, 31 May 2023 06:01:14 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi,
> Please help review this backport to riscv-port-jdk17u.
> Backport of [JDK-8302289](https://bugs.openjdk.org/browse/JDK-8302289). Applies cleanly.
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

Marked as reviewed by fyang (Lead).

-------------

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/64#pullrequestreview-1452273460

From fyang at openjdk.org  Wed May 31 07:37:20 2023
From: fyang at openjdk.org (Fei Yang)
Date: Wed, 31 May 2023 07:37:20 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8301818: RISC-V: Factor out
 function mvw from MacroAssembler
In-Reply-To: <y7x4XGglPCee2XiHQCe6Z8vAvPTQlnN2Y5XkFpHYNcw=.afdd7934-1683-44f4-9f4d-853159aaa6b3@github.com>
References: <y7x4XGglPCee2XiHQCe6Z8vAvPTQlnN2Y5XkFpHYNcw=.afdd7934-1683-44f4-9f4d-853159aaa6b3@github.com>
Message-ID: <o-3SrjGYCujPqQLDU_HxvnvSrCyFWpF6sCJ0emVnFqg=.427656fe-7009-4a18-9aea-68f97fcc2b4b@github.com>

On Fri, 26 May 2023 14:27:17 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi,
> Please help review this backport to riscv-port-jdk17u.
> Backport of [JDK-8301818](https://bugs.openjdk.org/browse/JDK-8301818), and [JDK-8302114](https://bugs.openjdk.org/browse/JDK-8302114).
> Because there is no [JDK-8286301](https://bugs.openjdk.org/browse/JDK-8286301), [JDK-8290154](https://bugs.openjdk.org/browse/JDK-8290154) here in riscv-port-jdk17u, it will show not clean.
> 
> Testing:
> 
> Tier1-3 passed without new failure on unmacthed (release).

Looks good.

-------------

Marked as reviewed by fyang (Lead).

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/62#pullrequestreview-1452406334

From fyang at openjdk.org  Wed May 31 10:59:27 2023
From: fyang at openjdk.org (Fei Yang)
Date: Wed, 31 May 2023 10:59:27 GMT
Subject: [riscv-port-jdk17u:riscv-port] RFR: 8305008: RISC-V: Factor out
 immediate checking functions from assembler_riscv.inline.hpp
In-Reply-To: <Uu1po77oRhith-7sD1lgrFefuejHH4lvre5B2rbgw4A=.96019077-48fb-4acb-aea6-059adc25acd2@github.com>
References: <Uu1po77oRhith-7sD1lgrFefuejHH4lvre5B2rbgw4A=.96019077-48fb-4acb-aea6-059adc25acd2@github.com>
Message-ID: <G_E7RgSN9PumnzHMwXHBUY7X6mUZKkYe4NcBN7jyC8s=.d83d4756-68eb-45a4-96ba-701d11c3641d@github.com>

On Mon, 29 May 2023 01:38:47 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

> Hi, please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8305008](https://bugs.openjdk.org/browse/JDK-8305008).
> The original patch cannot be directly applied because jdk17u has no [JDK-8295948](https://bugs.openjdk.org/browse/JDK-8295948) and [JDK-8294100](https://bugs.openjdk.org/browse/JDK-8294100).
> 
> Testing:
> - Tier1-3 passed without new failure on unmacthed (release).

Looks good.

-------------

Marked as reviewed by fyang (Lead).

PR Review: https://git.openjdk.org/riscv-port-jdk17u/pull/63#pullrequestreview-1452881720