[riscv-port-jdk11u:riscv-port] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v10]
Fei Yang
fyang at openjdk.org
Tue Feb 6 02:19:18 UTC 2024
On Thu, 1 Feb 2024 06:49:00 GMT, kuaiwei <duke at openjdk.org> wrote:
>> It's the initial patch based on https://github.com/openjdk/jdk17u-dev/pull/1427 , and revert patches not required in JDK11u. The testing is running on a linux riscv board. There are some failed cases and we are working on fix them , the progress will updated.
>>
>> Thanks the contribution of OpenJDK community and hard working of @zhengxiaolinX .
>>
>> - [x] slowdebug/fastdebug/release build
>> - [x] Benchmark: SPECJbb2015, Renaissance
>> - [x] Tier1 tests
>> - [x] Tier2 tests
>> - [x] Tier3 tests
>> - [ ] Tier4 tests
>
> kuaiwei has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 145 commits:
>
> - Remove unused zSyscall_linux_riscv.hpp
> - Merge riscv-port
> - Merge branch 'port_jdk11u_initial_patch' of github.com:kuaiwei/riscv-port-jdk11u into kw_initial_patch
> - Merge branch 'openjdk:master' into port_jdk11u_initial_patch
> - Merge riscv-port
> - Revert JDK-8247533: SA stack walking sometimes fails with sun.jvm.hotspot.debugger.DebuggerException: get_thread_regs failed for a lwp
> - Fix test error after port 8295926
> - 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic
>
> Reviewed-by: yadongwang, fyang
> - 8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub
>
> Reviewed-by: yadongwang, fjiang, shade, vkempik
> - Merge riscv-port
> - ... and 135 more: https://git.openjdk.org/riscv-port-jdk11u/compare/a0a61dda...4b01e137
> I assume for this initial load PR, maybe adding the additional RISC-V-specific fixes
>
> ```
> /issue add
> 8283737,8285437,8287418,8293100,8295926
> ```
>
> is enough. It seems not necessary to add other public/aarch64 issues to this patch since those are necessarily ported. So we only need to add `additional` changes compared to the original version of `8276799: Implementation of JEP 422: Linux/RISC-V Port` and the above command should suffice (we may need to revert the previous `/issue add <many issues>` -> `/issue remove <many issues>` command, I think).
>
> Is this correct? @RealFYang
@zhengxiaolinX : I don't think that is the correct thing to do from how the upstream JDK LTS versions works. It will not be easy for people to figure out whether a fix has been ported to this repo from the JBS. From the previous discussion, I am expecting this repo to be in use for quite some time, I would suggest we follow the upstrem LTS workflow and relate all the issues resolved by this PR.
-------------
PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/3#issuecomment-1928657745
More information about the riscv-port-dev
mailing list