[riscv-port-jdk11u:riscv-port] RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v4]

Fei Yang fyang at openjdk.org
Tue Feb 20 03:14:11 UTC 2024


On Mon, 19 Feb 2024 08:23:39 GMT, kuaiwei <duke at openjdk.org> wrote:

>>> > > It looks https://bugs.openjdk.org/browse/JDK-8247533 can fix the Clhsdb test error
>>> > 
>>> > 
>>> > Better to backport this fix in jdk11u-dev upstream if it really resolves this error. Then we can merge master and bring it to our riscv-port-jdk11u repo.
>>> 
>>> I may revert the change. Because I find the root cause of Clhsdb test failure is ptrace function is not fully supported in linux riscv. For example, PTRACE_GETREGS. We cat set kernel parameter "sysctl -w kernel.yama.ptrace_scope=1" to pass these tests.
>> 
>> @kuaiwei : I think the correct way to fix those Clhsdb test failure is to backport fix for https://bugs.openjdk.org/browse/JDK-8307955. I see they are passing with the following backport patch: 
>> [8307955-11u-backport.diff.txt](https://github.com/openjdk/riscv-port-jdk11u/files/14239024/8307955-11u-backport.diff.txt)
>
>> > > > It looks https://bugs.openjdk.org/browse/JDK-8247533 can fix the Clhsdb test error
>> > > 
>> > > 
>> > > Better to backport this fix in jdk11u-dev upstream if it really resolves this error. Then we can merge master and bring it to our riscv-port-jdk11u repo.
>> > 
>> > 
>> > I may revert the change. Because I find the root cause of Clhsdb test failure is ptrace function is not fully supported in linux riscv. For example, PTRACE_GETREGS. We cat set kernel parameter "sysctl -w kernel.yama.ptrace_scope=1" to pass these tests.
>> 
>> @kuaiwei : I think the correct way to fix those Clhsdb test failure is to backport fix for https://bugs.openjdk.org/browse/JDK-8307955. I see they are passing with the following backport patch: [8307955-11u-backport.diff.txt](https://github.com/openjdk/riscv-port-jdk11u/files/14239024/8307955-11u-backport.diff.txt)
> 
> It's a platform independent change. Do we need backport it to jdk11u upstream?
> 
> I can pass CLHSDB tests by changing sys parameter. 
> 
> sysctl -w kernel.yama.ptrace_scope=1

@kuaiwei : We should list @zhengxiaolinX as co-author of this PR. You can use `/contributor` pull request command to do that [1].

[1] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/contributor

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/3#issuecomment-1953415842


More information about the riscv-port-dev mailing list