From gcao at openjdk.org Sun Mar 3 06:45:09 2024 From: gcao at openjdk.org (Gui Cao) Date: Sun, 3 Mar 2024 06:45:09 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8290496: riscv: Fix build warnings-as-errors with GCC 11 Message-ID: <3gG9AS-yxijKUAcYR8iowQAbK0nEKJlFeghoq7eoWL4=.1e4d8f89-cdf9-4b30-9c48-aeedd5d3374e@github.com> Hi, Please review this backport to riscv-port-jdk17u. Backport of [JDK-8290496](https://bugs.openjdk.java.net/browse/JDK-8290496). Applies cleanly. build config: bash configure --with-debug-level=release --with-jvm-variants=minimal --with-zlib=system --with-native-debug-symbols=internal --with-boot-jdk=/home/zifeihan/jre/jre11 --with-extra-cxxflags=-Wno-maybe-uninitialized --with-extra-cflags=-Wno-maybe-uninitialized Before this backport: ERROR: Build failed for target 'default (exploded-image)' in configuration 'linux-riscv64-normal-minimal-release' (exit code 2) Stopping sjavac server === Output from failing command(s) repeated here === * For target hotspot_variant-minimal_libjvm_objs_c1_LIRAssembler.o: In file included from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_LIRAssembler.hpp:28, from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_LIRAssembler.cpp:30: In member function 'void PatchingStub::install(MacroAssembler*, LIR_PatchCode, Register, CodeEmitInfo*)', inlined from 'void LIR_Assembler::patching_epilog(PatchingStub*, LIR_PatchCode, Register, CodeEmitInfo*)' at /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_LIRAssembler.cpp:45:17: /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_CodeStubs.hpp:423:25: error: 'this' pointer is null [-Werror=nonnull] 423 | n_move->set_offset(field_offset); | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~ In file included from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/code/nativeInst.hpp:30, from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/precompiled/precompiled.hpp:77: /home/zifeihan/riscv-port-jdk11u/src/hotspot/cpu/riscv/nativeInst_riscv.hpp: In member function 'void LIR_Assembler::patching_epilog(PatchingStub*, LIR_PatchCode, Register, CodeEmitInfo*)': /home/zifeihan/riscv-port-jdk11u/src/hotspot/cpu/riscv/nativeInst_riscv.hpp:419:8: note: in a call to non-static member function 'void NativeMovRegMem::set_offset(int)' 419 | void set_offset(int x); | ^~~~~~~~~~ cc1plus: all warnings being treated as errors * All command lines available in /home/zifeihan/riscv-port-jdk11u/build/linux-riscv64-normal-minimal-release/make-support/failure-logs. === End of repeated output === No indication of failed target found. Hint: Try searching the build log for '] Error'. Hint: See doc/building.html#troubleshooting for assistance. make[1]: *** [/home/zifeihan/riscv-port-jdk11u/make/Init.gmk:308: main] Error 2 make: *** [/home/zifeihan/riscv-port-jdk11u/make/Init.gmk:186: default] Error 2 After this backport, We can build successful. ------------- Commit messages: - Backport 8290496: riscv: Fix build warnings-as-errors with GCC 11 Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/7/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=7&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290496 Stats: 43 lines in 2 files changed: 6 ins; 14 del; 23 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/7.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/7/head:pull/7 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/7 From fyang at openjdk.org Mon Mar 4 02:38:55 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 4 Mar 2024 02:38:55 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8290496: riscv: Fix build warnings-as-errors with GCC 11 In-Reply-To: <3gG9AS-yxijKUAcYR8iowQAbK0nEKJlFeghoq7eoWL4=.1e4d8f89-cdf9-4b30-9c48-aeedd5d3374e@github.com> References: <3gG9AS-yxijKUAcYR8iowQAbK0nEKJlFeghoq7eoWL4=.1e4d8f89-cdf9-4b30-9c48-aeedd5d3374e@github.com> Message-ID: On Sun, 3 Mar 2024 06:40:16 GMT, Gui Cao wrote: > Hi, Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8290496](https://bugs.openjdk.java.net/browse/JDK-8290496). Applies cleanly. > build config: > > bash configure --with-debug-level=release --with-jvm-variants=minimal --with-zlib=system --with-native-debug-symbols=internal --with-boot-jdk=/home/zifeihan/jre/jre11 --with-extra-cxxflags=-Wno-maybe-uninitialized --with-extra-cflags=-Wno-maybe-uninitialized > > > Before this backport: > > > ERROR: Build failed for target 'default (exploded-image)' in configuration 'linux-riscv64-normal-minimal-release' (exit code 2) > Stopping sjavac server > > === Output from failing command(s) repeated here === > * For target hotspot_variant-minimal_libjvm_objs_c1_LIRAssembler.o: > In file included from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_LIRAssembler.hpp:28, > from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_LIRAssembler.cpp:30: > In member function 'void PatchingStub::install(MacroAssembler*, LIR_PatchCode, Register, CodeEmitInfo*)', > inlined from 'void LIR_Assembler::patching_epilog(PatchingStub*, LIR_PatchCode, Register, CodeEmitInfo*)' at /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_LIRAssembler.cpp:45:17: > /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_CodeStubs.hpp:423:25: error: 'this' pointer is null [-Werror=nonnull] > 423 | n_move->set_offset(field_offset); > | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~ > In file included from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/code/nativeInst.hpp:30, > from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/precompiled/precompiled.hpp:77: > /home/zifeihan/riscv-port-jdk11u/src/hotspot/cpu/riscv/nativeInst_riscv.hpp: In member function 'void LIR_Assembler::patching_epilog(PatchingStub*, LIR_PatchCode, Register, CodeEmitInfo*)': > /home/zifeihan/riscv-port-jdk11u/src/hotspot/cpu/riscv/nativeInst_riscv.hpp:419:8: note: in a call to non-static member function 'void NativeMovRegMem::set_offset(int)' > 419 | void set_offset(int x); > | ^~~~~~~~~~ > cc1plus: all warnings being treated as errors > > * All command lines available in /home/zifeihan/riscv-port-jdk11u/build/linux-riscv64-normal-minimal-release/make-support/failure-logs. > === End of repeated output === > > No indication of failed target found. > Hint: Try searching the build log for '] Error'. > Hint: See doc/building.html#troubleshooting for assistance. > > make[1]: *** [/home/zifeihan/riscv-port-jdk11u/make/Init.gmk:308: main] E... Marked as reviewed by fyang (Lead). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/7#pullrequestreview-1913282355 From gcao at openjdk.org Mon Mar 4 11:59:20 2024 From: gcao at openjdk.org (Gui Cao) Date: Mon, 4 Mar 2024 11:59:20 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8305006: Use correct register in riscv_enc_fast_unlock() Message-ID: Hi, The same issue also exists in the riscv-port-jdk11u. It's already fixed in the jdk17u version above, for performance reasons, I'd like to backport it to this repo. Testing: - [ ] Run tier1 tests on SOPHGO SG2042 (release) ------------- Commit messages: - Backport 8305006: Use correct register in riscv_enc_fast_unlock() Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/8/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=8&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305006 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/8.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/8/head:pull/8 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/8 From gcao at openjdk.org Tue Mar 5 08:43:13 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 5 Mar 2024 08:43:13 GMT Subject: [riscv-port-jdk11u:riscv-port] Withdrawn: 8327284: Use correct register in riscv_enc_fast_unlock() In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 11:53:16 GMT, Gui Cao wrote: > Hi, The same issue also exists in the riscv-port-jdk11u. It's already fixed in the jdk17u version above, for performance reasons, I'd like to backport it to this repo. > > Testing: > > - [x] Run tier1 tests on SOPHGO SG2042 (release) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/8 From gcao at openjdk.org Tue Mar 5 08:49:20 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 5 Mar 2024 08:49:20 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: JDK-8327284: Use correct register in riscv_enc_fast_unlock() Message-ID: Hi, The same issue also exists in the riscv-port-jdk11u. It's already fixed in the jdk17u version above, for performance reasons, I'd like to backport it to this repo. Testing: - [x] Run tier1 tests on SOPHGO SG2042 (release) ------------- Commit messages: - JDK-8327284: Use correct register in riscv_enc_fast_unlock() Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/9/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=9&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327284 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/9.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/9/head:pull/9 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/9 From duke at openjdk.org Wed Mar 6 10:32:14 2024 From: duke at openjdk.org (duke) Date: Wed, 6 Mar 2024 10:32:14 GMT Subject: git: openjdk/riscv-port-jdk11u: riscv-port: 10 new changesets Message-ID: Changeset: f2565a6c Author: Aleksey Shipilev Date: 2024-02-28 07:39:37 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/f2565a6c6f26e84d8e5eede39c0f3a50be5d579f 8324723: GHA: Upgrade some actions to avoid deprecated Node 16 Reviewed-by: phh Backport-of: 951b5f8ecb9cd2a72b3904c110179afe487ada2b ! .github/actions/do-build/action.yml ! .github/actions/get-bootjdk/action.yml ! .github/actions/get-bundles/action.yml ! .github/actions/get-jtreg/action.yml ! .github/actions/get-msys2/action.yml ! .github/actions/upload-bundles/action.yml ! .github/workflows/build-cross-compile.yml ! .github/workflows/main.yml ! .github/workflows/test.yml Changeset: 61164cef Author: Aleksey Shipilev Date: 2024-02-28 07:41:01 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/61164cef029a4114d4c5d55a590488aac44c1fbd 8305962: update jcstress to 0.16 Backport-of: 292ee630ae32c3b50363b10ffa6090e57ffef1e8 ! test/hotspot/jtreg/applications/jcstress/JcstressRunner.java ! test/hotspot/jtreg/applications/jcstress/TestGenerator.java + test/hotspot/jtreg/applications/jcstress/collections.java = test/hotspot/jtreg/applications/jcstress/mxbeans.java = test/hotspot/jtreg/applications/jcstress/oota.java Changeset: 0ae93db1 Author: Aleksey Shipilev Date: 2024-02-29 10:24:24 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/0ae93db1267ccb76176d191cc454a62d4605fd35 8323717: Introduce test keyword for tests that need external dependencies Reviewed-by: phh Backport-of: 12b89cd2eeb5c2c43a2ce425c96fc4f718e30514 ! test/hotspot/jtreg/TEST.ROOT ! test/hotspot/jtreg/applications/jcstress/TestGenerator.java ! test/hotspot/jtreg/applications/jcstress/accessAtomic.java ! test/hotspot/jtreg/applications/jcstress/acqrel.java ! test/hotspot/jtreg/applications/jcstress/atomicity.java ! test/hotspot/jtreg/applications/jcstress/atomics.java ! test/hotspot/jtreg/applications/jcstress/causality.java ! test/hotspot/jtreg/applications/jcstress/coherence.java ! test/hotspot/jtreg/applications/jcstress/collections.java ! test/hotspot/jtreg/applications/jcstress/copy.java ! test/hotspot/jtreg/applications/jcstress/countdownlatch.java ! test/hotspot/jtreg/applications/jcstress/defaultValues.java ! test/hotspot/jtreg/applications/jcstress/executors.java ! test/hotspot/jtreg/applications/jcstress/fences.java ! test/hotspot/jtreg/applications/jcstress/future.java ! test/hotspot/jtreg/applications/jcstress/init.java ! test/hotspot/jtreg/applications/jcstress/initClass.java ! test/hotspot/jtreg/applications/jcstress/initLen.java ! test/hotspot/jtreg/applications/jcstress/interrupt.java ! test/hotspot/jtreg/applications/jcstress/locks.java ! test/hotspot/jtreg/applications/jcstress/memeffects.java ! test/hotspot/jtreg/applications/jcstress/mxbeans.java ! test/hotspot/jtreg/applications/jcstress/oota.java ! test/hotspot/jtreg/applications/jcstress/seqcst.java ! test/hotspot/jtreg/applications/jcstress/singletons.java ! test/hotspot/jtreg/applications/jcstress/strings.java ! test/hotspot/jtreg/applications/jcstress/tearing.java ! test/hotspot/jtreg/applications/jcstress/threadlocal.java ! test/hotspot/jtreg/applications/jcstress/unsafe.java ! test/hotspot/jtreg/applications/jcstress/varhandles.java ! test/hotspot/jtreg/applications/jcstress/volatiles.java ! test/hotspot/jtreg/applications/scimark/Scimark.java Changeset: b183cd23 Author: Aleksey Shipilev Date: 2024-02-29 10:44:14 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/b183cd239933552e1af8c890628b0bdee6ba21e7 8314552: Fix javadoc tests to work with jtreg 7 Reviewed-by: phh Backport-of: e83046409d81d074cd68dc823e794a852ed93cee ! test/langtools/jdk/javadoc/doclet/testSerialVersionUID/TestSerialVersionUID.java ! test/langtools/jdk/javadoc/doclet/testTagMisuse/TestTagMisuse.java ! test/langtools/jdk/javadoc/doclet/testThrowsHead/TestThrowsHead.java ! test/langtools/jdk/javadoc/doclet/testUnnamedPackage/TestUnnamedPackage.java ! test/langtools/jdk/javadoc/tool/nonConstExprs/Test.java Changeset: a582e118 Author: Aleksey Shipilev Date: 2024-03-04 08:31:15 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/a582e1180cd61b81407c4d9b0d64d343e716ff12 8281507: Two javac tests have bad jtreg `@clean` tags Reviewed-by: mbaesken Backport-of: 86723d4892485651bcae735ed13545ea89b9bb22 ! test/langtools/tools/javac/8074306/TestSyntheticNullChecks.java ! test/langtools/tools/javac/StringConcat/TestIndyStringConcat.java Changeset: f6e6eefc Author: Aleksey Shipilev Date: 2024-03-04 08:32:47 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/f6e6eefcc10f85ee289bbcc8de9caba1c915beeb 8326938: [11u] JDK-8214908 broke two CTW tests Reviewed-by: phh ! test/hotspot/jtreg/applications/ctw/modules/jdk_jfr.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_management_jfr.java Changeset: a4a5c7fe Author: Jiawei Tang Committer: Jie Fu Date: 2024-03-04 14:48:13 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/a4a5c7fe66679ce4d9022443e3cd1f9ec38059ac 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id Reviewed-by: mgronlun Backport-of: a885aab696777c99c8c4c5d9a46afc5fe0a4fe47 ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrThreadGroup.cpp Changeset: 5c5687d4 Author: Sergey Bylokhov Date: 2024-03-05 15:10:13 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/5c5687d4abde9180556db67c8a21f865dbebf7e7 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray Reviewed-by: phh Backport-of: 5a988a5087d0afbb577c6715fd5e1e44564888cb ! src/java.desktop/unix/classes/sun/awt/UNIXToolkit.java ! src/java.desktop/unix/classes/sun/awt/X11/XSystemTrayPeer.java Changeset: 2a78f2f1 Author: Goetz Lindenmaier Date: 2024-03-06 09:30:23 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/2a78f2f1591e55caeba9442b3a199db726470ded Merge Changeset: 17e4f4e3 Author: Fei Yang Date: 2024-03-06 18:29:50 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/17e4f4e3571980afcdff7bb4071eee585f041797 Merge remote-tracking branch 'origin/master' into riscv-port ! .github/workflows/build-cross-compile.yml ! .github/workflows/build-cross-compile.yml From gcao at openjdk.org Wed Mar 6 10:36:02 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 6 Mar 2024 10:36:02 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8290496: riscv: Fix build warnings-as-errors with GCC 11 In-Reply-To: <3gG9AS-yxijKUAcYR8iowQAbK0nEKJlFeghoq7eoWL4=.1e4d8f89-cdf9-4b30-9c48-aeedd5d3374e@github.com> References: <3gG9AS-yxijKUAcYR8iowQAbK0nEKJlFeghoq7eoWL4=.1e4d8f89-cdf9-4b30-9c48-aeedd5d3374e@github.com> Message-ID: On Sun, 3 Mar 2024 06:40:16 GMT, Gui Cao wrote: > Hi, Please review this backport to riscv-port-jdk17u. > Backport of [JDK-8290496](https://bugs.openjdk.java.net/browse/JDK-8290496). Applies cleanly. > build config: > > bash configure --with-debug-level=release --with-jvm-variants=minimal --with-zlib=system --with-native-debug-symbols=internal --with-boot-jdk=/home/zifeihan/jre/jre11 --with-extra-cxxflags=-Wno-maybe-uninitialized --with-extra-cflags=-Wno-maybe-uninitialized > > > Before this backport: > > > ERROR: Build failed for target 'default (exploded-image)' in configuration 'linux-riscv64-normal-minimal-release' (exit code 2) > Stopping sjavac server > > === Output from failing command(s) repeated here === > * For target hotspot_variant-minimal_libjvm_objs_c1_LIRAssembler.o: > In file included from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_LIRAssembler.hpp:28, > from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_LIRAssembler.cpp:30: > In member function 'void PatchingStub::install(MacroAssembler*, LIR_PatchCode, Register, CodeEmitInfo*)', > inlined from 'void LIR_Assembler::patching_epilog(PatchingStub*, LIR_PatchCode, Register, CodeEmitInfo*)' at /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_LIRAssembler.cpp:45:17: > /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_CodeStubs.hpp:423:25: error: 'this' pointer is null [-Werror=nonnull] > 423 | n_move->set_offset(field_offset); > | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~ > In file included from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/code/nativeInst.hpp:30, > from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/precompiled/precompiled.hpp:77: > /home/zifeihan/riscv-port-jdk11u/src/hotspot/cpu/riscv/nativeInst_riscv.hpp: In member function 'void LIR_Assembler::patching_epilog(PatchingStub*, LIR_PatchCode, Register, CodeEmitInfo*)': > /home/zifeihan/riscv-port-jdk11u/src/hotspot/cpu/riscv/nativeInst_riscv.hpp:419:8: note: in a call to non-static member function 'void NativeMovRegMem::set_offset(int)' > 419 | void set_offset(int x); > | ^~~~~~~~~~ > cc1plus: all warnings being treated as errors > > * All command lines available in /home/zifeihan/riscv-port-jdk11u/build/linux-riscv64-normal-minimal-release/make-support/failure-logs. > === End of repeated output === > > No indication of failed target found. > Hint: Try searching the build log for '] Error'. > Hint: See doc/building.html#troubleshooting for assistance. > > make[1]: *** [/home/zifeihan/riscv-port-jdk11u/make/Init.gmk:308: main] E... This pull request has now been integrated. Changeset: c7fb5135 Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/c7fb5135e2b43b20eb962d7a24fbc04301c6aeab Stats: 43 lines in 2 files changed: 6 ins; 14 del; 23 mod 8290496: riscv: Fix build warnings-as-errors with GCC 11 Reviewed-by: fyang Backport-of: 5425573bb4de1a2434201bc7ec3700b527ce346b ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/7 From rehn at openjdk.org Thu Mar 7 12:16:21 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Thu, 7 Mar 2024 12:16:21 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b Message-ID: For CI builds it helps to remove this. [8317335](https://bugs.openjdk.org/browse/JDK-8317335) is not needed as there is no gtest for atomic in 11. ------------- Commit messages: - Backport fb055e7e5300958b2a6a290aa6783e8ede929d9a Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/10/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=10&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316645 Stats: 75 lines in 2 files changed: 69 ins; 6 del; 0 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/10.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/10/head:pull/10 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/10 From luhenry at openjdk.org Thu Mar 7 18:33:09 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Thu, 7 Mar 2024 18:33:09 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 12:12:05 GMT, Robbin Ehn wrote: > For CI builds it helps to remove this. > [8317335](https://bugs.openjdk.org/browse/JDK-8317335) is not needed as there is no gtest for atomic in 11. Marked as reviewed by luhenry (no project role). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/10#pullrequestreview-1923224274 From fyang at openjdk.org Mon Mar 11 01:57:11 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 11 Mar 2024 01:57:11 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 12:12:05 GMT, Robbin Ehn wrote: > For CI builds it helps to remove this. > [8317335](https://bugs.openjdk.org/browse/JDK-8317335) is not needed as there is no gtest for atomic in 11. Could you please enable GHA for your fork? I think the GHA linux-cross-compile is back working again. Thanks. src/hotspot/os_cpu/linux_riscv/atomic_linux_riscv.hpp line 75: > 73: T compare_value, > 74: T exchange_value, > 75: atomic_memory_order order) const { I see the parameter order is not consistent with the one in jdk11u: `T Atomic::PlatformCmpxchg::operator()`. So this might need more adaptations, otherwise I guess it won't build. Also the original commit adds one `#undef FULL_COMPILER_ATOMIC_SUPPORT` at the end of the file, which is missing for this backport. ------------- Changes requested by fyang (Lead). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/10#pullrequestreview-1926794147 PR Review Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/10#discussion_r1519056413 From fyang at openjdk.org Mon Mar 11 02:45:10 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 11 Mar 2024 02:45:10 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: JDK-8327284: Use correct register in riscv_enc_fast_unlock() In-Reply-To: References: Message-ID: On Tue, 5 Mar 2024 08:44:18 GMT, Gui Cao wrote: > Hi, The same issue also exists in the riscv-port-jdk11u. It's already fixed in the jdk17u version above, for performance reasons, I'd like to backport it to this repo. > > Testing: > > - [x] Run tier1 tests on SOPHGO SG2042 (release) Looks good. Please retrigger GHA testing. Thanks. ------------- Marked as reviewed by fyang (Lead). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/9#pullrequestreview-1926828402 From duke at openjdk.org Mon Mar 11 03:13:54 2024 From: duke at openjdk.org (duke) Date: Mon, 11 Mar 2024 03:13:54 GMT Subject: git: openjdk/riscv-port-jdk11u: riscv-port: 7 new changesets Message-ID: <61513263-d903-49ca-8e01-7f7a247f62d7@openjdk.org> Changeset: 6c0a88d9 Author: Zhang Quan Committer: Christoph Langer Date: 2024-03-06 11:50:41 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/6c0a88d905ce068045cc3ff02891b48372b4c8c7 8271142: package help is not displayed for missing X11/extensions/Xrandr.h Reviewed-by: clanger Backport-of: b7f75c0a735f0cf40ae2288d1d0ae96a571a4155 ! make/autoconf/help.m4 Changeset: 4ef8db86 Author: Andrew Lu Date: 2024-03-07 08:04:09 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/4ef8db867145f24062fe7c774653aadbebc4dc84 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053 Backport-of: e4803e0cbf00da89b98c8703769edc403bb5055b ! test/jdk/javax/swing/MultiMonitor/MultimonVImage.java Changeset: bc14b9f1 Author: Andrew Lu Date: 2024-03-07 08:06:50 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/bc14b9f12e00b16194e228b315bc08a878d314d4 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop Backport-of: 9f0e7da64e21237322e55ca4f0e3639fa5d1c4ed ! src/hotspot/share/opto/loopopts.cpp + test/hotspot/jtreg/compiler/loopopts/TestRemixAddressExpressionsWithIrreducibleLoop.java Changeset: b425dff6 Author: Andrew Lu Date: 2024-03-07 08:07:24 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/b425dff6bbec035b18606be45800e621219a15df 8320303: Allow PassFailJFrame to accept single window creator Backport-of: 83ffc1ac94b8893532d8663b9058592f1714d337 ! test/jdk/java/awt/regtesthelpers/PassFailJFrame.java Changeset: f3069d13 Author: Andrew Lu Date: 2024-03-07 08:07:57 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/f3069d13d23301405b096db6d4843500a5f5fa56 8325972: Add -x to bash for building with LOG=debug Backport-of: 8668198c26bdac412f0a9d1255ca74da860761c5 ! make/common/MakeBase.gmk Changeset: 7b7fbdf6 Author: Ao Qi Committer: Paul Hohensee Date: 2024-03-07 20:07:14 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/7b7fbdf6159baceb83640786928d00b838be1a3a 8267938: (sctp) SCTP channel factory methods should check platform support Backport-of: bd31653e6f99d4337e4af1f7f138d688ec99c19d ! src/jdk.sctp/unix/native/libsctp/SctpNet.c Changeset: c74f7e30 Author: Fei Yang Date: 2024-03-11 11:12:37 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/c74f7e30a4c67c435351bd4194213faa5f1f5aad Merge branch 'master' into riscv-port From gcao at openjdk.org Mon Mar 11 07:06:14 2024 From: gcao at openjdk.org (Gui Cao) Date: Mon, 11 Mar 2024 07:06:14 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: JDK-8327284: Use correct register in riscv_enc_fast_unlock() In-Reply-To: References: Message-ID: <_A4EeH-aKMJKV_FvSP1PO_BoTxtS28bB5R8-B1M3IPE=.33b595e5-e1f5-4aff-833c-1f7b98dacceb@github.com> On Mon, 11 Mar 2024 02:42:08 GMT, Fei Yang wrote: >> Hi, The same issue also exists in the riscv-port-jdk11u. It's already fixed in the jdk17u version above, for performance reasons, I'd like to backport it to this repo. >> >> Testing: >> >> - [x] Run tier1 tests on SOPHGO SG2042 (release) > > Looks good. Please retrigger GHA testing. Thanks. @RealFYang : Thanks for your review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/9#issuecomment-1987749121 From rehn at openjdk.org Mon Mar 11 07:28:10 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Mon, 11 Mar 2024 07:28:10 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b In-Reply-To: References: Message-ID: <_BwV6f2Cn35PgoXTbfitxyi3SI6d91BcQI6SzU99MH8=.189b2621-733f-4c25-91bf-012625da2aed@github.com> On Mon, 11 Mar 2024 01:48:54 GMT, Fei Yang wrote: >> For CI builds it helps to remove this. >> [8317335](https://bugs.openjdk.org/browse/JDK-8317335) is not needed as there is no gtest for atomic in 11. > > src/hotspot/os_cpu/linux_riscv/atomic_linux_riscv.hpp line 75: > >> 73: T compare_value, >> 74: T exchange_value, >> 75: atomic_memory_order order) const { > > I see the parameter order is not consistent with the one in jdk11u: > `T Atomic::PlatformCmpxchg::operator()`. > So this might need more adaptations, otherwise I guess it won't build. > Also the original commit adds one `#undef FULL_COMPILER_ATOMIC_SUPPORT` at the end of the file, which is missing for this backport. It did build and run... I'll fix thanks. ------------- PR Review Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/10#discussion_r1519249001 From rehn at openjdk.org Mon Mar 11 07:45:03 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Mon, 11 Mar 2024 07:45:03 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b In-Reply-To: <_BwV6f2Cn35PgoXTbfitxyi3SI6d91BcQI6SzU99MH8=.189b2621-733f-4c25-91bf-012625da2aed@github.com> References: <_BwV6f2Cn35PgoXTbfitxyi3SI6d91BcQI6SzU99MH8=.189b2621-733f-4c25-91bf-012625da2aed@github.com> Message-ID: On Mon, 11 Mar 2024 07:25:25 GMT, Robbin Ehn wrote: >> src/hotspot/os_cpu/linux_riscv/atomic_linux_riscv.hpp line 75: >> >>> 73: T compare_value, >>> 74: T exchange_value, >>> 75: atomic_memory_order order) const { >> >> I see the parameter order is not consistent with the one in jdk11u: >> `T Atomic::PlatformCmpxchg::operator()`. >> So this might need more adaptations, otherwise I guess it won't build. >> Also the original commit adds one `#undef FULL_COMPILER_ATOMIC_SUPPORT` at the end of the file, which is missing for this backport. > > It did build and run... I'll fix thanks. I probably used to new compiler... ------------- PR Review Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/10#discussion_r1519263698 From rehn at openjdk.org Mon Mar 11 08:11:27 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Mon, 11 Mar 2024 08:11:27 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b [v2] In-Reply-To: References: Message-ID: > For CI builds it helps to remove this. > [8317335](https://bugs.openjdk.org/browse/JDK-8317335) is not needed as there is no gtest for atomic in 11. Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision: Fix old compiler ------------- Changes: - all: https://git.openjdk.org/riscv-port-jdk11u/pull/10/files - new: https://git.openjdk.org/riscv-port-jdk11u/pull/10/files/3f2651e4..a01cf4f8 Webrevs: - full: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=10&range=01 - incr: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=10&range=00-01 Stats: 4 lines in 1 file changed: 2 ins; 1 del; 1 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/10.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/10/head:pull/10 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/10 From gcao at openjdk.org Mon Mar 11 12:37:09 2024 From: gcao at openjdk.org (Gui Cao) Date: Mon, 11 Mar 2024 12:37:09 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: JDK-8327284: Use correct register in riscv_enc_fast_unlock() In-Reply-To: References: Message-ID: On Tue, 5 Mar 2024 08:44:18 GMT, Gui Cao wrote: > Hi, The same issue also exists in the riscv-port-jdk11u. It's already fixed in the jdk17u version above, for performance reasons, I'd like to backport it to this repo. > > Testing: > > - [x] Run tier1 tests on SOPHGO SG2042 (release) This pull request has now been integrated. Changeset: 95635170 Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/95635170c4eed4549d862d94001f095ff17b5b15 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8327284: Use correct register in riscv_enc_fast_unlock() Reviewed-by: fyang ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/9 From fyang at openjdk.org Mon Mar 11 13:01:18 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 11 Mar 2024 13:01:18 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b [v2] In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 08:11:27 GMT, Robbin Ehn wrote: >> For CI builds it helps to remove this. >> [8317335](https://bugs.openjdk.org/browse/JDK-8317335) is not needed as there is no gtest for atomic in 11. > > Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision: > > Fix old compiler Updated change looks fine. Thanks. ------------- Marked as reviewed by fyang (Lead). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/10#pullrequestreview-1927758846 From rehn at openjdk.org Mon Mar 11 20:40:34 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Mon, 11 Mar 2024 20:40:34 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b [v2] In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 08:11:27 GMT, Robbin Ehn wrote: >> For CI builds it helps to remove this. >> [8317335](https://bugs.openjdk.org/browse/JDK-8317335) is not needed as there is no gtest for atomic in 11. > > Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision: > > Fix old compiler Thanks! ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/10#issuecomment-1989400715 From rehn at openjdk.org Wed Mar 13 00:20:31 2024 From: rehn at openjdk.org (Robbin Ehn) Date: Wed, 13 Mar 2024 00:20:31 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b In-Reply-To: References: Message-ID: On Thu, 7 Mar 2024 12:12:05 GMT, Robbin Ehn wrote: > For CI builds it helps to remove this. > [8317335](https://bugs.openjdk.org/browse/JDK-8317335) is not needed as there is no gtest for atomic in 11. This pull request has now been integrated. Changeset: 4bddeb3f Author: Robbin Ehn Committer: Fei Yang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/4bddeb3f1d97cef8f2d4852cab60fec08939043d Stats: 76 lines in 2 files changed: 70 ins; 6 del; 0 mod 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b Reviewed-by: luhenry, fyang Backport-of: fb055e7e5300958b2a6a290aa6783e8ede929d9a ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/10 From gcao at openjdk.org Thu Mar 14 02:27:47 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 14 Mar 2024 02:27:47 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328065: RISC-V: Add isolation for shared code changes Message-ID: Hi, We want to add isolation for shared code changes. 1. To minimize the difference with jdk17u-dev upstream, the jdk17u-dev backport does isolate public code changes to avoid code changes to other architectures [1] 2. riscv-port-jdk11u is missing the sparc architecture adaptation in the backport, this may affect the correctness of the sparc architecture. ### Test - [x] Run tier1-3 tests on linux-x86 (release) - [x] Run tier1-3 tests on linux-arm64 (release) - [x] Run tier1-3 tests on on LicheePI 4A (release) [1] https://github.com/yadongw/riscv-port-jdk17u/commit/6bc31f690036ebf7d0db55b1e2ef83b13b74fed3 ------------- Commit messages: - 8328065: RISC-V: Add isolation for shared code changes Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/11/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=11&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328065 Stats: 168 lines in 12 files changed: 126 ins; 16 del; 26 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/11.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/11/head:pull/11 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/11 From duke at openjdk.org Tue Mar 19 06:34:31 2024 From: duke at openjdk.org (duke) Date: Tue, 19 Mar 2024 06:34:31 GMT Subject: git: openjdk/riscv-port-jdk11u: riscv-port: 21 new changesets Message-ID: <08dae594-8f76-469a-9b1a-792df49cf8b9@openjdk.org> Changeset: a26445db Author: Mar?a Arias de Reyna Committer: Severin Gehwolf Date: 2024-03-11 11:17:00 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/a26445db3b1a98f3e5bae11dcf12e2ab4a20ff74 8261404: Class.getReflectionFactory() is not thread-safe Backport-of: 905b7639424a0fa80f81f734f6fdae1b5018a14a ! src/java.base/share/classes/java/lang/Class.java Changeset: fbac37b7 Author: Amos Shi Committer: Aleksey Shipilev Date: 2024-03-11 12:16:35 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/fbac37b73ce517f64fd7e679f8fde09cf66ad8c3 8307083: Open source some drag and drop tests 3 Backport-of: 1b154e4fd361103936f976db72e04b73aa7b1077 + test/jdk/java/awt/dnd/MissedDragEnterTest.java + test/jdk/java/awt/dnd/ModalDialogDeadlockTest.java + test/jdk/java/awt/dnd/ModalDialogOnDragDeadlockTest.java + test/jdk/java/awt/dnd/ModalDialogOnDropDeadlockTest.java Changeset: 9b408561 Author: Amos Shi Committer: Aleksey Shipilev Date: 2024-03-11 12:16:54 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/9b4085619fffd871a74cee7f93bac67cf42b9cc0 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination Backport-of: cbfddf4e1d3ff8dddb95bcb9242b31c175b768fc ! test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.java Changeset: cf9aa9be Author: Amos Shi Committer: Aleksey Shipilev Date: 2024-03-11 12:17:08 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/cf9aa9be1631de55da7329ce4a1cc9bddd425723 8306941: Open source several datatransfer and dnd AWT tests Backport-of: 3d3eaed9133dbe728ca8e00a626d33f7e35ba9ff + test/jdk/java/awt/datatransfer/MimeFormatsTest.java + test/jdk/java/awt/datatransfer/RemoveFlavorListenerTest.java + test/jdk/java/awt/dnd/AutoscrollStopTest.java + test/jdk/java/awt/dnd/ButtonReleaseTest.java Changeset: eb5ef842 Author: Amos Shi Committer: Aleksey Shipilev Date: 2024-03-11 12:17:55 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/eb5ef84294e314efb7f2b179b7f187831ddb524b 8315677: Open source few swing JFileChooser and other tests Backport-of: fe5ef5f20dcf647b4ca30963b42fa01449f0d9c0 + test/jdk/javax/swing/JFileChooser/bug4624353.java + test/jdk/javax/swing/JFileChooser/bug4673161.java + test/jdk/javax/swing/JFileChooser/bug4782168.java + test/jdk/javax/swing/JLabel/bug4822331.java + test/jdk/javax/swing/JOptionPane/bug4191835.java Changeset: e6cec8f1 Author: Amos Shi Committer: Aleksey Shipilev Date: 2024-03-11 12:21:05 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/e6cec8f1a81e32860200ebdcaf506c37935531ba 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range Backport-of: 91d8dac9cff5689abcf2fc8950b15d284f933afd ! test/jdk/com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java Changeset: c8ca55ba Author: Ekaterina Vergizova Date: 2024-03-11 12:48:27 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/c8ca55bafa8137f48ccb184539e8fa4e609faa09 8314220: Configurable InlineCacheBuffer size Reviewed-by: phh Backport-of: a40d8d97e84d88d1a65aba81bfc09339be95e427 ! src/hotspot/share/code/icBuffer.cpp ! src/hotspot/share/code/stubs.cpp ! src/hotspot/share/compiler/compilerDefinitions.cpp ! src/hotspot/share/runtime/globals.hpp Changeset: 29f300eb Author: Jiawei Tang Committer: Paul Hohensee Date: 2024-03-11 21:50:42 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/29f300eb2ac4c038fad7f8e09eab8a53b69526c6 8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id Reviewed-by: phh ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp Changeset: 84ff9b3d Author: Andrew Lu Date: 2024-03-12 02:22:56 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/84ff9b3d1162b04cd4f0da8234e7755fe8568ebb 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java Backport-of: 1f2922ad8526d378ee7b616e5423ce56f20340db + test/jdk/java/awt/PopupMenu/TruncatedPopupMenuTest.java Changeset: 21b88dba Author: Andrew Lu Date: 2024-03-12 09:23:17 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/21b88dba7fb33da2bc975cf7ac689ad5951ac90a 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 Backport-of: f1b73350c237021c04ceac2f29f1f378630bd651 ! test/jdk/java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java Changeset: 069fbd77 Author: Andrew Lu Date: 2024-03-12 09:24:43 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/069fbd7770ecde71d9137df3c5ca378ffd6c0ae7 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries Backport-of: 721bfee53af5bc2e2d67eebc7b82f09a642d5309 ! make/autoconf/flags-cflags.m4 ! test/jdk/tools/launcher/RunpathTest.java Changeset: 5cf250f1 Author: Goetz Lindenmaier Date: 2024-03-12 13:41:30 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/5cf250f14f78832d0b58de42c9c998ed49c040b8 8292716: Configure should check that jtreg is of the required version 8292763: JDK-8292716 breaks configure without jtreg Reviewed-by: phh, shade Backport-of: 9288072655a689c06a03f85c976bbd2f0744d3d5 ! make/autoconf/toolchain.m4 Changeset: 1b3c570c Author: Amos Shi Committer: Goetz Lindenmaier Date: 2024-03-12 18:50:21 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/1b3c570c605cfdada5b3531071f0c3fd4d843f6f 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all Backport-of: ce36f6ea855a7ede02df969e6bb599ac36ac04fe ! test/hotspot/jtreg/ProblemList.txt Changeset: a097faa9 Author: Andrew Lu Date: 2024-03-13 08:22:27 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/a097faa97273b31400c356866f07319bd4be3194 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX Backport-of: 8be3e39220cd64521f4e370011958e17e5fdeaf3 ! test/failure_handler/src/share/conf/mac.properties Changeset: 7de6f3f6 Author: Andrew Lu Date: 2024-03-13 08:31:03 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/7de6f3f6ac1b2fe50a466b612718ed673aa70a19 8314283: Support for NSS tests on aarch64 platforms Reviewed-by: lucy Backport-of: 2a8016096000de5836251f2ca9bc8ad6479e6942 ! test/jdk/sun/security/pkcs11/KeyStore/ClientAuth.java ! test/jdk/sun/security/pkcs11/PKCS11Test.java Changeset: 1d102e8f Author: Andrew Lu Date: 2024-03-13 08:31:19 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/1d102e8f8afab928195550534110213ee31ace2e 8248667: Need support for building native libraries located in the test/lib directory Reviewed-by: lucy Backport-of: 1356a0f1ac06b006a20ca9fa2306ef60aef5c16e ! make/Main.gmk ! make/test/BuildTestLib.gmk + make/test/BuildTestLibNative.gmk + test/lib/jdk/test/lib/apps/libLingeredApp.c Changeset: 0f09d0ba Author: Andrew Lu Date: 2024-03-14 09:04:23 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/0f09d0ba6cf21e5b4b50e3827fb62c55be8953c7 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg Backport-of: 62c9530c056dbaaf65be0f43295af3d225326a4c ! test/jdk/java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java Changeset: 2921ad6b Author: Goetz Lindenmaier Date: 2024-03-14 20:16:21 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/2921ad6bb89c91ef7992a1eefa93e9a670512f54 8321489: Update LCMS to 2.16 Backport-of: dc7d3b182d226253ca246dd854c85c4dd964f10e ! src/java.desktop/share/legal/lcms.md ! src/java.desktop/share/native/liblcms/cmsalpha.c ! src/java.desktop/share/native/liblcms/cmscgats.c ! src/java.desktop/share/native/liblcms/cmscnvrt.c ! src/java.desktop/share/native/liblcms/cmserr.c ! src/java.desktop/share/native/liblcms/cmsgamma.c ! src/java.desktop/share/native/liblcms/cmsgmt.c ! src/java.desktop/share/native/liblcms/cmsio0.c ! src/java.desktop/share/native/liblcms/cmsio1.c ! src/java.desktop/share/native/liblcms/cmslut.c ! src/java.desktop/share/native/liblcms/cmsnamed.c ! src/java.desktop/share/native/liblcms/cmsopt.c ! src/java.desktop/share/native/liblcms/cmspack.c ! src/java.desktop/share/native/liblcms/cmsplugin.c ! src/java.desktop/share/native/liblcms/cmsps2.c ! src/java.desktop/share/native/liblcms/cmssamp.c ! src/java.desktop/share/native/liblcms/cmstypes.c ! src/java.desktop/share/native/liblcms/cmsvirt.c ! src/java.desktop/share/native/liblcms/cmsxform.c ! src/java.desktop/share/native/liblcms/lcms2.h ! src/java.desktop/share/native/liblcms/lcms2_internal.h Changeset: d1bdb255 Author: Goetz Lindenmaier Date: 2024-03-14 20:18:18 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/d1bdb255745f5818339e6e0fdd5de1b291920b36 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane Backport-of: 3b1062d45df69d4cf8479c6a65602bd2453ab885 ! src/java.desktop/share/classes/javax/swing/JTabbedPane.java + test/jdk/javax/swing/JTabbedPane/TabbedPaneNPECheck.java Changeset: 7ed3c3ef Author: Amos Shi Committer: Goetz Lindenmaier Date: 2024-03-15 08:25:01 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/7ed3c3ef2c70f83fdb35561fc2d6cb5d4814a606 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch Backport-of: 27cf2f404857aa8c3b1679d0e67f0a3a37e7604b ! test/jdk/java/nio/file/Files/probeContentType/Basic.java Changeset: 20321f82 Author: Fei Yang Date: 2024-03-19 14:32:29 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/20321f82a4be3ad56514d3e1be13a1416f2e2a68 Merge branch 'master' into riscv-port From fyang at openjdk.org Tue Mar 19 07:59:42 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 19 Mar 2024 07:59:42 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328065: RISC-V: Add isolation for shared code changes In-Reply-To: References: Message-ID: On Wed, 13 Mar 2024 14:08:22 GMT, Gui Cao wrote: > Hi, We want to add isolation for shared code changes. > 1. To minimize the difference with jdk17u-dev upstream, the jdk17u-dev backport does isolate public code changes to avoid code changes to other architectures [1] > 2. riscv-port-jdk11u is missing the sparc architecture adaptation in the backport, this may affect the correctness of the sparc architecture. > ### Test > - [x] Run tier1-3 tests on linux-x86 (release) > - [x] Run tier1-3 tests on linux-arm64 (release) > - [x] Run tier1-3 tests on on LicheePI 4A (release) > > [1] https://github.com/yadongw/riscv-port-jdk17u/commit/6bc31f690036ebf7d0db55b1e2ef83b13b74fed3 Looks good. I think we shoud have this in order to align and minimize the difference with 17u upstream. Thanks. ------------- Marked as reviewed by fyang (Lead). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/11#pullrequestreview-1945437370 From gcao at openjdk.org Wed Mar 20 06:13:39 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 20 Mar 2024 06:13:39 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8328065: RISC-V: Add isolation for shared code changes In-Reply-To: References: Message-ID: <2ffQdFyZbiiVwD3sLCrzM-jSQ7pC9v0GhmCEW3YZSlA=.b93692f6-b9b0-4055-9e0a-e4f71523c485@github.com> On Wed, 13 Mar 2024 14:08:22 GMT, Gui Cao wrote: > Hi, We want to add isolation for shared code changes. > 1. To minimize the difference with jdk17u-dev upstream, the jdk17u-dev backport does isolate public code changes to avoid code changes to other architectures [1] > 2. riscv-port-jdk11u is missing the sparc architecture adaptation in the backport, this may affect the correctness of the sparc architecture. > ### Test > - [x] Run tier1-3 tests on linux-x86 (release) > - [x] Run tier1-3 tests on linux-arm64 (release) > - [x] Run tier1-3 tests on on LicheePI 4A (release) > > [1] https://github.com/yadongw/riscv-port-jdk17u/commit/6bc31f690036ebf7d0db55b1e2ef83b13b74fed3 This pull request has now been integrated. Changeset: e0d3a375 Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/e0d3a3753ab54f09d16954f2a691ee311201c2ed Stats: 168 lines in 12 files changed: 126 ins; 16 del; 26 mod 8328065: RISC-V: Add isolation for shared code changes Reviewed-by: fyang ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/11 From duke at openjdk.org Wed Mar 20 07:10:41 2024 From: duke at openjdk.org (Andreas Schwab) Date: Wed, 20 Mar 2024 07:10:41 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328065: RISC-V: Add isolation for shared code changes In-Reply-To: References: Message-ID: <1iznpBIaODZ7HwrUuZTmEqysCujYjJNXHgTkenQIG8o=.3b9898e8-727c-48ba-b2e5-aa48d09f65a8@github.com> On Wed, 13 Mar 2024 14:08:22 GMT, Gui Cao wrote: > Hi, We want to add isolation for shared code changes. > 1. To minimize the difference with jdk17u-dev upstream, the jdk17u-dev backport does isolate public code changes to avoid code changes to other architectures [1] > 2. riscv-port-jdk11u is missing the sparc architecture adaptation in the backport, this may affect the correctness of the sparc architecture. > ### Test > - [x] Run tier1-3 tests on linux-x86 (release) > - [x] Run tier1-3 tests on linux-arm64 (release) > - [x] Run tier1-3 tests on on LicheePI 4A (release) > > [1] https://github.com/yadongw/riscv-port-jdk17u/commit/6bc31f690036ebf7d0db55b1e2ef83b13b74fed3 There are a few leftover changes: - make/autoconf/libraries.m4 is no longer modified due to 8316645, but still has the copyright date change. - spurious space change in src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp - another copyright date change in unmodified src/hotspot/share/opto/regmask.hpp ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/11#issuecomment-2008910914 From gcao at openjdk.org Wed Mar 20 08:15:44 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 20 Mar 2024 08:15:44 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328065: RISC-V: Add isolation for shared code changes In-Reply-To: <1iznpBIaODZ7HwrUuZTmEqysCujYjJNXHgTkenQIG8o=.3b9898e8-727c-48ba-b2e5-aa48d09f65a8@github.com> References: <1iznpBIaODZ7HwrUuZTmEqysCujYjJNXHgTkenQIG8o=.3b9898e8-727c-48ba-b2e5-aa48d09f65a8@github.com> Message-ID: <0osgAEZYHvlvI-u6GN34xm3f4CMtfLtCeMt29rPXkVo=.b2341baf-1850-46a2-8541-651deeb3c0b8@github.com> On Wed, 20 Mar 2024 07:07:52 GMT, Andreas Schwab wrote: > There are a few leftover changes: > > * make/autoconf/libraries.m4 is no longer modified due to 8316645, but > still has the copyright date change. > * spurious space change in src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp > * another copyright date change in unmodified src/hotspot/share/opto/regmask.hpp Yes, I will prepare another PR to cleanup those trivial leftover changes. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/11#issuecomment-2008999955 From gcao at openjdk.org Wed Mar 20 09:19:49 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 20 Mar 2024 09:19:49 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328580: Remove trivial shared code changes which are leftover from riscv port Message-ID: Hi, This patch used to remove trivial shared code changes which are leftover from riscv port, here are some related discussions https://github.com/openjdk/riscv-port-jdk11u/pull/11#issuecomment-2008999955. just a few changes to copyright date and spurious space. ------------- Commit messages: - 8328580: Remove trivial shared code changes which are leftover from riscv port Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/12/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=12&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328580 Stats: 3 lines in 3 files changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/12.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/12/head:pull/12 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/12 From gcao at openjdk.org Wed Mar 20 09:19:49 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 20 Mar 2024 09:19:49 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328580: Remove trivial shared code changes which are leftover from riscv port In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 08:48:31 GMT, Gui Cao wrote: > Hi, This patch used to remove trivial shared code changes which are leftover from riscv port, here are some related discussions https://github.com/openjdk/riscv-port-jdk11u/pull/11#issuecomment-2008999955. just a few changes to copyright date and spurious space. @andreas-schwab : Hi, Could you please take a look? ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/12#issuecomment-2009061529 From duke at openjdk.org Wed Mar 20 10:17:29 2024 From: duke at openjdk.org (Andreas Schwab) Date: Wed, 20 Mar 2024 10:17:29 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328580: Remove trivial shared code changes which are leftover from riscv port In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 08:48:31 GMT, Gui Cao wrote: > Hi, This patch used to remove trivial shared code changes which are leftover from riscv port, here are some related discussions https://github.com/openjdk/riscv-port-jdk11u/pull/11#issuecomment-2008999955. just a few changes to copyright date and spurious space. Looks good. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/12#issuecomment-2009201143 From fyang at openjdk.org Wed Mar 20 11:20:43 2024 From: fyang at openjdk.org (Fei Yang) Date: Wed, 20 Mar 2024 11:20:43 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328580: Remove trivial shared code changes which are leftover from riscv port In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 08:48:31 GMT, Gui Cao wrote: > Hi, This patch used to remove trivial shared code changes which are leftover from riscv port, here are some related discussions https://github.com/openjdk/riscv-port-jdk11u/pull/11#issuecomment-2008999955. just a few changes to copyright date and spurious space. Looks good and trivial. Thanks. ------------- Marked as reviewed by fyang (Lead). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/12#pullrequestreview-1948595245 From gcao at openjdk.org Thu Mar 21 02:24:33 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 21 Mar 2024 02:24:33 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328580: Remove trivial shared code changes which are leftover from riscv port In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 10:15:04 GMT, Andreas Schwab wrote: >> Hi, This patch used to remove trivial shared code changes which are leftover from riscv port, here are some related discussions https://github.com/openjdk/riscv-port-jdk11u/pull/11#issuecomment-2008999955. just a few changes to copyright date and spurious space. > > Looks good. @andreas-schwab @RealFYang : Thanks all for the review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/12#issuecomment-2011071036 From gcao at openjdk.org Thu Mar 21 03:59:40 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 21 Mar 2024 03:59:40 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8328580: Remove trivial shared code changes which are leftover from riscv port In-Reply-To: References: Message-ID: On Wed, 20 Mar 2024 08:48:31 GMT, Gui Cao wrote: > Hi, This patch used to remove trivial shared code changes which are leftover from riscv port, here are some related discussions https://github.com/openjdk/riscv-port-jdk11u/pull/11#issuecomment-2008999955. just a few changes to copyright date and spurious space. This pull request has now been integrated. Changeset: 46d18f6c Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/46d18f6ce2b09548ba0b1c976dc5214971e8b8e8 Stats: 3 lines in 3 files changed: 1 ins; 0 del; 2 mod 8328580: Remove trivial shared code changes which are leftover from riscv port Reviewed-by: fyang ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/12 From gcao at openjdk.org Sat Mar 23 05:27:01 2024 From: gcao at openjdk.org (Gui Cao) Date: Sat, 23 Mar 2024 05:27:01 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension Message-ID: Hi, The same issue[1] also exists in the riscv-port-jdk11u. According to the spec, we need to break down UseRVB into two individual options UseZba and UseZbb to enable or disable Zba and Zbb respectively. Linux RISCV64 release hotspot/jdk tier1 tests are passed on QEMU with following options: - [x] +UseZba && +UseZbb - [x] +UseZba && -UseZbb - [x] -UseZba && +UseZbb ------------- Commit messages: - Backport JDK-8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/13/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=13&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8283865 Stats: 123 lines in 8 files changed: 5 ins; 11 del; 107 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/13.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/13/head:pull/13 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/13 From duke at openjdk.org Mon Mar 25 09:47:47 2024 From: duke at openjdk.org (duke) Date: Mon, 25 Mar 2024 09:47:47 GMT Subject: git: openjdk/riscv-port-jdk11u: riscv-port: 14 new changesets Message-ID: <0ff8efff-4680-4800-b9df-5eb6a2e6a42d@openjdk.org> Changeset: cb1b9a64 Author: Goetz Lindenmaier Date: 2024-03-19 14:10:20 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/cb1b9a64878e7751c785860c4466e41ad1df276f 8292717: Clean up checking of testing requirements in configure Reviewed-by: shade, mdoerr Backport-of: 16593cf51c3d994ba4a6d28ab97e519dfd53f37b ! make/autoconf/configure.ac ! make/autoconf/jdk-options.m4 ! make/autoconf/lib-tests.m4 ! make/autoconf/toolchain.m4 Changeset: 74822988 Author: Martin Doerr Date: 2024-03-20 08:57:32 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/74822988a3a8e468181d5c3649ec1a6de87aea00 8325326: [PPC64] Don't relocate in case of allocation failure Backport-of: 4388095cde20dec602ada9fe2977f1a359ceab91 ! src/hotspot/cpu/ppc/ppc.ad Changeset: c5ba4b5c Author: Martin Doerr Date: 2024-03-20 08:58:52 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/c5ba4b5c3e25364f826da96e17176c90d15d655e 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space Reviewed-by: mbaesken Backport-of: e3ae81eeeee8e2b0063a576a90624dd927b512f0 ! src/hotspot/cpu/ppc/c1_CodeStubs_ppc.cpp ! src/hotspot/cpu/ppc/ppc.ad Changeset: ac9d090a Author: Goetz Lindenmaier Date: 2024-03-20 09:00:37 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/ac9d090a99c28986a8f20e4c58987ca69e425652 8015739: Background of JInternalFrame is located out of JInternalFrame Reviewed-by: lucy Backport-of: 7fb1fb0fa6bfb8258ac0191611f445b83a23408e ! src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java + test/jdk/javax/swing/JInternalFrame/InternalFrameBorderTest.java Changeset: 44825a00 Author: Goetz Lindenmaier Date: 2024-03-20 09:01:31 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/44825a003b6b172015c7f374d9b5e90a20129489 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap Backport-of: eebcc2181fe27f6aa10559233c7c58882a146f56 ! test/jdk/java/lang/String/StringRepeat.java Changeset: bd29eb6e Author: Goetz Lindenmaier Date: 2024-03-15 08:51:04 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/bd29eb6eec88a088703582318f790dff2432b7b7 8327391: Add SipHash attribution file Backport-of: fcf48ab3d36a7f8eed84e81c3e2445adcbc95374 + src/hotspot/share/legal/siphash.md Changeset: a46d4440 Author: Goetz Lindenmaier Date: 2024-03-20 10:27:11 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/a46d4440ee9a328d53f194245d79f124b7ceb80a Merge Changeset: 6bcb8ac9 Author: Andrew Lu Date: 2024-03-21 03:07:18 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/6bcb8ac9f966c552f7284957d8515c5abcf829a5 8248194: Need better support for running SA tests on core files Reviewed-by: lucy Backport-of: db2d4e8f5af1274d82242d3d86b922656954e1ef ! test/hotspot/jtreg/serviceability/sa/ClhsdbCDSCore.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java ! test/hotspot/jtreg/serviceability/sa/TestJmapCore.java ! test/lib/jdk/test/lib/SA/SATestUtils.java ! test/lib/jdk/test/lib/apps/LingeredApp.java + test/lib/jdk/test/lib/util/CoreUtils.java Changeset: 50d05032 Author: Goetz Lindenmaier Date: 2024-03-21 12:30:08 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/50d0503294ceb77289786532c82a887f12fba425 8314495: Update to use jtreg 7.3.1 Reviewed-by: shade, lucy Backport-of: 75e14419d29c1dc98bd040490e93ae8f6eee4e43 ! make/autoconf/lib-tests.m4 ! make/conf/github-actions.conf ! make/conf/jib-profiles.js ! test/hotspot/jtreg/TEST.ROOT ! test/jaxp/TEST.ROOT ! test/jdk/TEST.ROOT ! test/langtools/TEST.ROOT Changeset: 12a28633 Author: Andrew Lu Date: 2024-03-22 02:12:04 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/12a28633d28e08884fafeb654bbc22af166f3651 8315663: Open source misc awt tests Backport-of: a36f5a54ab4871739f2ccbabb684942fc3cadf20 + test/jdk/java/awt/Icon/SetIconImageExceptionTest.java + test/jdk/sun/awt/PaletteTester.java = test/jdk/sun/awt/duke.gif Changeset: c782d4c9 Author: Andrew Lu Date: 2024-03-25 07:25:53 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/c782d4c9cd2a600029ba8c80c963fffedcde101d 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection Reviewed-by: lucy Backport-of: bdd1aebea379b63ae405827074530ef8e8a7c239 ! src/java.base/share/classes/sun/security/ssl/X509Authentication.java Changeset: 8c18317e Author: Andrew Lu Date: 2024-03-25 07:40:08 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/8c18317ef89886ffd7b917c89ab02e047b940c20 8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed 8241951: SA core file tests failed to find core file for signed binaries on OSX 10.15 Reviewed-by: lucy Backport-of: 16e0ad0ad088af3ba1c9903ed8df60799a1ba651 ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java ! test/lib/jdk/test/lib/Platform.java ! test/lib/jdk/test/lib/SA/SATestUtils.java ! test/lib/jdk/test/lib/util/CoreUtils.java Changeset: f8225a42 Author: Andrew Lu Date: 2024-03-25 08:46:24 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/f8225a424f763aaead44c98c2f51a9d3a009032e 8313206: PKCS11 tests silently skip execution Reviewed-by: lucy Backport-of: 7c4aaec0dc74badb8363c10d2a10a29e85ceb246 ! test/jdk/sun/security/pkcs11/KeyStore/Basic.java ! test/jdk/sun/security/pkcs11/KeyStore/ClientAuth.java ! test/jdk/sun/security/pkcs11/KeyStore/SecretKeysBasic.java ! test/jdk/sun/security/pkcs11/PKCS11Test.java ! test/jdk/sun/security/pkcs11/Provider/ConfigQuotedString.java ! test/jdk/sun/security/pkcs11/Provider/Login.java ! test/jdk/sun/security/pkcs11/Provider/MultipleLogins.sh ! test/jdk/sun/security/pkcs11/SecmodTest.java ! test/jdk/sun/security/pkcs11/SecureRandom/Basic.java Changeset: fec9f492 Author: Fei Yang Date: 2024-03-25 17:44:14 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/fec9f4929ba5ab6e64e24c85bacebfdcff61b461 Merge branch 'master' into riscv-port ! test/hotspot/jtreg/testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java ! test/lib/jdk/test/lib/Platform.java ! test/hotspot/jtreg/testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java ! test/lib/jdk/test/lib/Platform.java From fyang at openjdk.org Mon Mar 25 11:30:43 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 25 Mar 2024 11:30:43 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension In-Reply-To: References: Message-ID: On Thu, 21 Mar 2024 10:42:20 GMT, Gui Cao wrote: > Hi, The same issue[1] also exists in the riscv-port-jdk11u. According to the spec, we need to break down UseRVB into two individual options UseZba and UseZbb to enable or disable Zba and Zbb respectively. > > Linux RISCV64 release hotspot/jdk tier1 tests are passed on QEMU with following options: > - [x] +UseZba && +UseZbb > - [x] +UseZba && -UseZbb > - [x] -UseZba && +UseZbb Backport looks good. Thanks. ------------- Marked as reviewed by fyang (Lead). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/13#pullrequestreview-1957484442 From fyang at openjdk.org Mon Mar 25 12:17:51 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 25 Mar 2024 12:17:51 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition Message-ID: Makes GHA cross-compilation jobs clean again. Applies cleanly. GHA passes. ------------- Commit messages: - backport Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/14/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=14&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8326960 Stats: 15 lines in 1 file changed: 14 ins; 0 del; 1 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/14.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/14/head:pull/14 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/14 From shade at openjdk.org Mon Mar 25 12:25:43 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 25 Mar 2024 12:25:43 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 12:12:35 GMT, Fei Yang wrote: > Makes GHA cross-compilation jobs clean again. Applies cleanly. GHA passes. Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/14#pullrequestreview-1957605346 From fyang at openjdk.org Mon Mar 25 12:25:43 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 25 Mar 2024 12:25:43 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 12:20:13 GMT, Aleksey Shipilev wrote: >> Makes GHA cross-compilation jobs clean again. Applies cleanly. GHA passes. > > Marked as reviewed by shade (Reviewer). I would like to have this fix for our riscv-port-jdk11 repo in order to be consistent with other upstream repos. This makes GHA cross-compilation jobs clean again. @shipilev : Can you take a look and hopefully approve this? Thanks. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/14#issuecomment-2017883199 From fyang at openjdk.org Mon Mar 25 13:34:42 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 25 Mar 2024 13:34:42 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 12:12:35 GMT, Fei Yang wrote: > Makes GHA cross-compilation jobs clean again. Applies cleanly. GHA passes. This pull request has now been integrated. Changeset: e69cfeb5 Author: Fei Yang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/e69cfeb56c35e5261b3248315b938783b157acea Stats: 15 lines in 1 file changed: 14 ins; 0 del; 1 mod 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition Reviewed-by: shade Backport-of: f207aa94f9296932276c2952252b263efc793b3f ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/14 From fyang at openjdk.org Mon Mar 25 13:34:42 2024 From: fyang at openjdk.org (Fei Yang) Date: Mon, 25 Mar 2024 13:34:42 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition In-Reply-To: References: Message-ID: <54dGdVcJtI9txJimLvZnBjLXVCjb3VeQ4D_M2j_1EaA=.359e7fe2-27bb-4d8a-b817-b85efee194bf@github.com> On Mon, 25 Mar 2024 12:12:35 GMT, Fei Yang wrote: > Makes GHA cross-compilation jobs clean again. Applies cleanly. GHA passes. GHA test is green again. Let's get this merged. Thanks. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/14#issuecomment-2018013645 From duke at openjdk.org Tue Mar 26 01:03:01 2024 From: duke at openjdk.org (duke) Date: Tue, 26 Mar 2024 01:03:01 GMT Subject: git: openjdk/riscv-port-jdk11u: riscv-port: 4 new changesets Message-ID: <6e4e7d8d-cfb1-4cb5-994a-1b7b5999e8ca@openjdk.org> Changeset: 6aa72164 Author: Goetz Lindenmaier Date: 2024-03-25 17:54:42 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/6aa721649d870354a79c3508343b14222e0edcfb 8324632: Update Zlib Data Compression Library to Version 1.3.1 8315117: Update Zlib Data Compression Library to Version 1.3 8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1 Backport-of: 6359b2843f83852561b925d3f1315eed5f4b9cda ! src/java.base/share/legal/zlib.md ! src/java.base/share/native/libzip/zlib/ChangeLog ! src/java.base/share/native/libzip/zlib/README ! src/java.base/share/native/libzip/zlib/compress.c ! src/java.base/share/native/libzip/zlib/deflate.c ! src/java.base/share/native/libzip/zlib/deflate.h ! src/java.base/share/native/libzip/zlib/gzclose.c ! src/java.base/share/native/libzip/zlib/gzguts.h ! src/java.base/share/native/libzip/zlib/gzlib.c ! src/java.base/share/native/libzip/zlib/gzread.c ! src/java.base/share/native/libzip/zlib/gzwrite.c ! src/java.base/share/native/libzip/zlib/infback.c ! src/java.base/share/native/libzip/zlib/inffast.c ! src/java.base/share/native/libzip/zlib/inffast.h ! src/java.base/share/native/libzip/zlib/inflate.c ! src/java.base/share/native/libzip/zlib/inftrees.c ! src/java.base/share/native/libzip/zlib/inftrees.h ! src/java.base/share/native/libzip/zlib/patches/ChangeLog_java ! src/java.base/share/native/libzip/zlib/trees.c ! src/java.base/share/native/libzip/zlib/uncompr.c ! src/java.base/share/native/libzip/zlib/zadler32.c ! src/java.base/share/native/libzip/zlib/zconf.h ! src/java.base/share/native/libzip/zlib/zcrc32.c ! src/java.base/share/native/libzip/zlib/zlib.h ! src/java.base/share/native/libzip/zlib/zutil.c ! src/java.base/share/native/libzip/zlib/zutil.h Changeset: 37cfd480 Author: Aleksey Shipilev Date: 2024-03-25 18:10:50 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/37cfd4808dead6e846a3626f6e7b50cc9e207d98 8328705: GHA: Cross-compilation jobs do not require build JDK Backport-of: 29ba4b7d1e62a834c1693fe6ad383c19467afc81 ! .github/workflows/build-cross-compile.yml ! .github/workflows/main.yml Changeset: b7f78a39 Author: Ben Taylor Date: 2024-03-25 23:27:02 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/b7f78a39c2c11e351a927da97455efa112b70d1c 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader Backport-of: 8eb6f617b3f8e2a990e4244af4e56287f9741b20 ! src/java.base/share/classes/java/lang/System.java ! test/jdk/java/lang/reflect/Proxy/ClassRestrictions.java Changeset: 8aa08085 Author: Fei Yang Date: 2024-03-26 09:02:00 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/8aa0808583293d3e11458436216c851260a3f241 Merge branch 'master' into riscv-port ! .github/workflows/build-cross-compile.yml ! .github/workflows/build-cross-compile.yml From fyang at openjdk.org Tue Mar 26 01:11:53 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 26 Mar 2024 01:11:53 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 Message-ID: Fixes a recent GHA regression. Applies cleanly. - [ ] GHA, first run passes cross-builds - [ ] GHA, second run passes cross-builds ------------- Commit messages: - backport Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/15/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=15&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328948 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/15.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/15/head:pull/15 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/15 From gcao at openjdk.org Tue Mar 26 01:44:33 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 26 Mar 2024 01:44:33 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension In-Reply-To: References: Message-ID: On Mon, 25 Mar 2024 11:28:01 GMT, Fei Yang wrote: >> Hi, The same issue[1] also exists in the riscv-port-jdk11u. According to the spec, we need to break down UseRVB into two individual options UseZba and UseZbb to enable or disable Zba and Zbb respectively. >> >> Linux RISCV64 release hotspot/jdk tier1 tests are passed on QEMU with following options: >> - [x] +UseZba && +UseZbb >> - [x] +UseZba && -UseZbb >> - [x] -UseZba && +UseZbb > > Backport looks good. Thanks. @RealFYang : Thanks for the review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/13#issuecomment-2019230634 From gcao at openjdk.org Tue Mar 26 01:44:34 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 26 Mar 2024 01:44:34 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension In-Reply-To: References: Message-ID: On Thu, 21 Mar 2024 10:42:20 GMT, Gui Cao wrote: > Hi, The same issue[1] also exists in the riscv-port-jdk11u. According to the spec, we need to break down UseRVB into two individual options UseZba and UseZbb to enable or disable Zba and Zbb respectively. > > Linux RISCV64 release hotspot/jdk tier1 tests are passed on QEMU with following options: > - [x] +UseZba && +UseZbb > - [x] +UseZba && -UseZbb > - [x] -UseZba && +UseZbb This pull request has now been integrated. Changeset: aee4eeaf Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/aee4eeaf1db356dde586cfddaa5c57fb437eaf68 Stats: 123 lines in 8 files changed: 5 ins; 11 del; 107 mod 8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension Reviewed-by: fyang Backport-of: 060a1887339a366075755ad2a359ee3336ef381d ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/13 From fyang at openjdk.org Tue Mar 26 02:33:53 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 26 Mar 2024 02:33:53 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 [v2] In-Reply-To: References: Message-ID: > Fixes a recent GHA regression. Applies cleanly. > > - [x] GHA, first run passes cross-builds > - [ ] GHA, second run passes cross-builds Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'riscv-port' into 8328948-backport - backport ------------- Changes: - all: https://git.openjdk.org/riscv-port-jdk11u/pull/15/files - new: https://git.openjdk.org/riscv-port-jdk11u/pull/15/files/67683034..010f3c0c Webrevs: - full: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=15&range=01 - incr: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=15&range=00-01 Stats: 2373 lines in 30 files changed: 629 ins; 1123 del; 621 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/15.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/15/head:pull/15 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/15 From shade at openjdk.org Tue Mar 26 13:02:46 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 26 Mar 2024 13:02:46 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 [v2] In-Reply-To: References: Message-ID: On Tue, 26 Mar 2024 02:33:53 GMT, Fei Yang wrote: >> Fixes a recent GHA regression. Applies cleanly. >> >> - [x] GHA, first run passes cross-builds >> - [x] GHA, second run passes cross-builds > > Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'riscv-port' into 8328948-backport > - backport Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/15#pullrequestreview-1960293589 From fyang at openjdk.org Tue Mar 26 13:02:46 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 26 Mar 2024 13:02:46 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 [v2] In-Reply-To: References: Message-ID: <4vFr32VxpBWAyjYj45mfdjHNQsDKhq2KrbuUyDDF09g=.8fbfd3d6-e93f-47f7-a6ea-d56223a7bd08@github.com> On Tue, 26 Mar 2024 02:33:53 GMT, Fei Yang wrote: >> Fixes a recent GHA regression. Applies cleanly. >> >> - [x] GHA, first run passes cross-builds >> - [x] GHA, second run passes cross-builds > > Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'riscv-port' into 8328948-backport > - backport @shipilev : Could you please take another look? Thanks. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/15#issuecomment-2020360863 From fyang at openjdk.org Tue Mar 26 13:07:38 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 26 Mar 2024 13:07:38 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 [v2] In-Reply-To: References: Message-ID: On Tue, 26 Mar 2024 02:33:53 GMT, Fei Yang wrote: >> Fixes a recent GHA regression. Applies cleanly. >> >> - [x] GHA, first run passes cross-builds >> - [x] GHA, second run passes cross-builds > > Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'riscv-port' into 8328948-backport > - backport Let's get this merged ASAP then :-) ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/15#issuecomment-2020377981 From fyang at openjdk.org Tue Mar 26 13:07:38 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 26 Mar 2024 13:07:38 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 In-Reply-To: References: Message-ID: <5Et_WxewRG4y-OtVFNf29Op7kTV7hN1eaa7zKnAdP54=.04ac55dc-3012-4a7c-9d09-85d0520ac0cf@github.com> On Tue, 26 Mar 2024 00:34:06 GMT, Fei Yang wrote: > Fixes a recent GHA regression. Applies cleanly. > > - [x] GHA, first run passes cross-builds > - [x] GHA, second run passes cross-builds This pull request has now been integrated. Changeset: f71648ca Author: Fei Yang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/f71648ca2cc03468b6ce24484f5f47f7b7519286 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 Reviewed-by: shade Backport-of: 447436e18c754424a62af5135fb3a8973564091d ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/15 From gcao at openjdk.org Wed Mar 27 06:56:48 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 27 Mar 2024 06:56:48 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space Message-ID: Please help review this backport to riscv-port-jdk11u. Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893) In addition to the backport [8291947](https://bugs.openjdk.org/browse/JDK-8291947), we can use __builtin__clear_cache instead of icache_flush. Testing: - [x] Run tier1-3 tests on SOPHON SG2042 (release) ------------- Commit messages: - 8310656: RISC-V: __builtin___clear_cache can fail silently. - Merge remote-tracking branch 'upstream/riscv-port' into backport-JDK-8291893 - Backport 8291893: riscv: remove fence.i used in user space Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/16/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=16&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291893 Stats: 194 lines in 12 files changed: 133 ins; 53 del; 8 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/16.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/16/head:pull/16 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/16 From luhenry at openjdk.org Wed Mar 27 06:56:48 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Wed, 27 Mar 2024 06:56:48 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space In-Reply-To: References: Message-ID: On Tue, 26 Mar 2024 08:35:05 GMT, Gui Cao wrote: > Please help review this backport to riscv-port-jdk11u. > Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893) > > In addition to the backport [8291947](https://bugs.openjdk.org/browse/JDK-8291947), we can use __builtin__clear_cache instead of icache_flush. > > Testing: > > - [x] Run tier1-3 tests on SOPHON SG2042 (release) Let's make sure we backport https://github.com/openjdk/jdk/commit/faf1b822d03b726413d77a2b247dfbbf4db7d57e as well as it's a fix for the commit you're backporting here. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/16#issuecomment-2020931991 From gcao at openjdk.org Wed Mar 27 08:23:15 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 27 Mar 2024 08:23:15 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space [v2] In-Reply-To: References: Message-ID: > Please help review this backport to riscv-port-jdk11u. > Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893) > > In addition to the backport [8291947](https://bugs.openjdk.org/browse/JDK-8291947), we can use __builtin__clear_cache instead of icache_flush. > > Testing: > > - [x] Run tier1-3 tests on SOPHON SG2042 (release) Gui Cao has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8310656: RISC-V: __builtin___clear_cache can fail silently. ------------- Changes: - all: https://git.openjdk.org/riscv-port-jdk11u/pull/16/files - new: https://git.openjdk.org/riscv-port-jdk11u/pull/16/files/85db9b24..6db0c80f Webrevs: - full: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=16&range=01 - incr: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=16&range=00-01 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/16.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/16/head:pull/16 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/16 From gcao at openjdk.org Wed Mar 27 09:14:40 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 27 Mar 2024 09:14:40 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space [v2] In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 08:23:15 GMT, Gui Cao wrote: >> Please help review this backport to riscv-port-jdk11u. >> Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893) >> >> In addition to the backport [8291947](https://bugs.openjdk.org/browse/JDK-8291947), [8310656](https://bugs.openjdk.org/browse/JDK-8310656) to align and minimize the difference with 17u upstream. >> >> Testing: >> >> - [x] Run tier1-3 tests on SOPHON SG2042 (release) > > Gui Cao has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8310656: RISC-V: __builtin___clear_cache can fail silently. > Let's make sure we backport [openjdk/jdk at faf1b82](https://github.com/openjdk/jdk/commit/faf1b822d03b726413d77a2b247dfbbf4db7d57e) as well as it's a fix for the commit you're backporting here. Hi, Thanks for your review. I've backported [8310656](https://bugs.openjdk.org/browse/JDK-8310656) and added a new commit. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/16#issuecomment-2022271957 From fyang at openjdk.org Thu Mar 28 01:56:45 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 28 Mar 2024 01:56:45 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space [v2] In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 08:23:15 GMT, Gui Cao wrote: >> Please help review this backport to riscv-port-jdk11u. >> Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893) >> >> In addition to the backport [8291947](https://bugs.openjdk.org/browse/JDK-8291947), [8310656](https://bugs.openjdk.org/browse/JDK-8310656) to align and minimize the difference with 17u upstream. >> >> Testing: >> >> - [x] Run tier1-3 tests on SOPHON SG2042 (release) > > Gui Cao has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8310656: RISC-V: __builtin___clear_cache can fail silently. src/hotspot/os_cpu/linux_riscv/riscv_flush_icache.hpp line 28: > 26: #ifndef OS_LINUX_RISCV_FLUSH_ICACHE_LINUX_HPP > 27: #define OS_LINUX_RISCV_FLUSH_ICACHE_LINUX_HPP > 28: I think we should add one extra include here: `#include "memory/allocation.hpp"`. ------------- PR Review Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/16#discussion_r1542218546 From gcao at openjdk.org Thu Mar 28 02:16:19 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 28 Mar 2024 02:16:19 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space [v3] In-Reply-To: References: Message-ID: > Please help review this backport to riscv-port-jdk11u. > Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893) > > In addition to the backport [8291947](https://bugs.openjdk.org/browse/JDK-8291947), [8310656](https://bugs.openjdk.org/browse/JDK-8310656) to align and minimize the difference with 17u upstream. > > Testing: > > - [x] Run tier1-3 tests on SOPHON SG2042 (release) Gui Cao has updated the pull request incrementally with one additional commit since the last revision: Add extra include header ------------- Changes: - all: https://git.openjdk.org/riscv-port-jdk11u/pull/16/files - new: https://git.openjdk.org/riscv-port-jdk11u/pull/16/files/6db0c80f..383fd357 Webrevs: - full: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=16&range=02 - incr: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=16&range=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/16.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/16/head:pull/16 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/16 From fyang at openjdk.org Thu Mar 28 02:16:19 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 28 Mar 2024 02:16:19 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space [v3] In-Reply-To: References: Message-ID: On Thu, 28 Mar 2024 02:12:50 GMT, Gui Cao wrote: >> Please help review this backport to riscv-port-jdk11u. >> Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893) >> >> In addition to the backport [8291947](https://bugs.openjdk.org/browse/JDK-8291947), [8310656](https://bugs.openjdk.org/browse/JDK-8310656) to align and minimize the difference with 17u upstream. >> >> Testing: >> >> - [x] Run tier1-3 tests on SOPHON SG2042 (release) > > Gui Cao has updated the pull request incrementally with one additional commit since the last revision: > > Add extra include header Updated change looks good to me. Thanks. ------------- Marked as reviewed by fyang (Lead). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/16#pullrequestreview-1965048380 From gcao at openjdk.org Thu Mar 28 02:16:19 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 28 Mar 2024 02:16:19 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space [v2] In-Reply-To: References: Message-ID: On Thu, 28 Mar 2024 01:53:52 GMT, Fei Yang wrote: > I think we should add one extra include here: `#include "memory/allocation.hpp"`. Thanks for the review. Fixed ------------- PR Review Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/16#discussion_r1542227285 From luhenry at openjdk.org Thu Mar 28 10:14:52 2024 From: luhenry at openjdk.org (Ludovic Henry) Date: Thu, 28 Mar 2024 10:14:52 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space [v3] In-Reply-To: References: Message-ID: <2_s3jxu7Cys-s9BwrpVfmd2Sfhfn9k4t6-pg1bOVodw=.5b04cfe4-f153-406b-9e9d-6db881e690b1@github.com> On Thu, 28 Mar 2024 02:16:19 GMT, Gui Cao wrote: >> Please help review this backport to riscv-port-jdk11u. >> Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893) >> >> In addition to the backport [8291947](https://bugs.openjdk.org/browse/JDK-8291947), [8310656](https://bugs.openjdk.org/browse/JDK-8310656) to align and minimize the difference with 17u upstream. >> >> Testing: >> >> - [x] Run tier1-3 tests on SOPHON SG2042 (release) > > Gui Cao has updated the pull request incrementally with one additional commit since the last revision: > > Add extra include header Marked as reviewed by luhenry (no project role). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/16#pullrequestreview-1965686850 From gcao at openjdk.org Fri Mar 29 01:13:55 2024 From: gcao at openjdk.org (Gui Cao) Date: Fri, 29 Mar 2024 01:13:55 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8291893: riscv: remove fence.i used in user space [v3] In-Reply-To: References: Message-ID: On Thu, 28 Mar 2024 02:11:08 GMT, Fei Yang wrote: >> Gui Cao has updated the pull request incrementally with one additional commit since the last revision: >> >> Add extra include header > > Updated change looks good to me. Thanks. @RealFYang @luhenry : Thanks for the review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/16#issuecomment-2026422939 From gcao at openjdk.org Fri Mar 29 01:13:57 2024 From: gcao at openjdk.org (Gui Cao) Date: Fri, 29 Mar 2024 01:13:57 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8291893: riscv: remove fence.i used in user space In-Reply-To: References: Message-ID: On Tue, 26 Mar 2024 08:35:05 GMT, Gui Cao wrote: > Please help review this backport to riscv-port-jdk11u. > Backport of [JDK-8291893](https://bugs.openjdk.org/browse/JDK-8291893) > > In addition to the backport [8291947](https://bugs.openjdk.org/browse/JDK-8291947), [8310656](https://bugs.openjdk.org/browse/JDK-8310656) to align and minimize the difference with 17u upstream. > > Testing: > > - [x] Run tier1-3 tests on SOPHON SG2042 (release) This pull request has now been integrated. Changeset: d4b0021a Author: Gui Cao Committer: Fei Yang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/d4b0021ac15c36f1cc5d5bae34b79b9d2ddc1182 Stats: 194 lines in 12 files changed: 133 ins; 53 del; 8 mod 8291893: riscv: remove fence.i used in user space 8291947: riscv: fail to build after JDK-8290840 8310656: RISC-V: __builtin___clear_cache can fail silently. Reviewed-by: fyang, luhenry Backport-of: 5a539e8da7dbea1eaa10d799f75199ea359f7a22 ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/16 From gcao at openjdk.org Fri Mar 29 01:14:17 2024 From: gcao at openjdk.org (Gui Cao) Date: Fri, 29 Mar 2024 01:14:17 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8284937: riscv: should not allocate special register for temp Message-ID: Hi, please help review this backport to riscv-port-jdk11u. Backport of [JDK-8284937](https://bugs.openjdk.org/browse/JDK-8284937). The original patch cannot be directly applied because riscv-port-jdk11u doesn't have riscv_v.ad and doesn't have c2_MacroAssembler, which uses MacroAssembler. Testing: - [x] Run tier1-3 tests on SOPHON SG2042 (release) ------------- Commit messages: - backport 8284937: riscv: should not allocate special register for temp Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/17/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=17&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8284937 Stats: 28 lines in 1 file changed: 0 ins; 0 del; 28 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/17.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/17/head:pull/17 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/17 From fyang at openjdk.org Fri Mar 29 02:51:53 2024 From: fyang at openjdk.org (Fei Yang) Date: Fri, 29 Mar 2024 02:51:53 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8284937: riscv: should not allocate special register for temp In-Reply-To: References: Message-ID: On Thu, 28 Mar 2024 10:09:33 GMT, Gui Cao wrote: > Hi, please help review this backport to riscv-port-jdk11u. > Backport of [JDK-8284937](https://bugs.openjdk.org/browse/JDK-8284937). The original patch cannot be directly applied because riscv-port-jdk11u doesn't have riscv_v.ad and doesn't have c2_MacroAssembler, which uses MacroAssembler. > > Testing: > > - [x] Run tier1-3 tests on SOPHON SG2042 (release) Looks good. ------------- Marked as reviewed by fyang (Lead). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/17#pullrequestreview-1967734261