[riscv-port-jdk11u:riscv-port] RFR: 8328065: RISC-V: Add isolation for shared code changes
Fei Yang
fyang at openjdk.org
Tue Mar 19 07:59:42 UTC 2024
On Wed, 13 Mar 2024 14:08:22 GMT, Gui Cao <gcao at openjdk.org> wrote:
> Hi, We want to add isolation for shared code changes.
> 1. To minimize the difference with jdk17u-dev upstream, the jdk17u-dev backport does isolate public code changes to avoid code changes to other architectures [1]
> 2. riscv-port-jdk11u is missing the sparc architecture adaptation in the backport, this may affect the correctness of the sparc architecture.
> ### Test
> - [x] Run tier1-3 tests on linux-x86 (release)
> - [x] Run tier1-3 tests on linux-arm64 (release)
> - [x] Run tier1-3 tests on on LicheePI 4A (release)
>
> [1] https://github.com/yadongw/riscv-port-jdk17u/commit/6bc31f690036ebf7d0db55b1e2ef83b13b74fed3
Looks good. I think we shoud have this in order to align and minimize the difference with 17u upstream. Thanks.
-------------
Marked as reviewed by fyang (Lead).
PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/11#pullrequestreview-1945437370
More information about the riscv-port-dev
mailing list