From duke at openjdk.org  Mon May 13 02:26:41 2024
From: duke at openjdk.org (kuaiwei)
Date: Mon, 13 May 2024 02:26:41 GMT
Subject: [riscv-port-jdk11u:riscv-port] RFR: 8290496: riscv: Fix build
 warnings-as-errors with GCC 11
In-Reply-To: <3gG9AS-yxijKUAcYR8iowQAbK0nEKJlFeghoq7eoWL4=.1e4d8f89-cdf9-4b30-9c48-aeedd5d3374e@github.com>
References: <3gG9AS-yxijKUAcYR8iowQAbK0nEKJlFeghoq7eoWL4=.1e4d8f89-cdf9-4b30-9c48-aeedd5d3374e@github.com>
Message-ID: <DZbLrdxEz6Yv6OHumEw5oYZ_dYCXAWwOanwOlmLSJpA=.27067eae-62e6-4ce6-b001-52631ebd1c54@github.com>

On Sun, 3 Mar 2024 06:40:16 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi, Please review this backport to riscv-port-jdk17u.
> Backport of [JDK-8290496](https://bugs.openjdk.java.net/browse/JDK-8290496). Applies cleanly.
> build config:
> 
> bash configure --with-debug-level=release --with-jvm-variants=minimal --with-zlib=system --with-native-debug-symbols=internal --with-boot-jdk=/home/zifeihan/jre/jre11 --with-extra-cxxflags=-Wno-maybe-uninitialized --with-extra-cflags=-Wno-maybe-uninitialized
> 
> 
> Before this backport:
> 
> 
> ERROR: Build failed for target 'default (exploded-image)' in configuration 'linux-riscv64-normal-minimal-release' (exit code 2)
> Stopping sjavac server
> 
> === Output from failing command(s) repeated here ===
> * For target hotspot_variant-minimal_libjvm_objs_c1_LIRAssembler.o:
> In file included from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_LIRAssembler.hpp:28,
>                  from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_LIRAssembler.cpp:30:
> In member function 'void PatchingStub::install(MacroAssembler*, LIR_PatchCode, Register, CodeEmitInfo*)',
>     inlined from 'void LIR_Assembler::patching_epilog(PatchingStub*, LIR_PatchCode, Register, CodeEmitInfo*)' at /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_LIRAssembler.cpp:45:17:
> /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/c1/c1_CodeStubs.hpp:423:25: error: 'this' pointer is null [-Werror=nonnull]
>   423 |       n_move->set_offset(field_offset);
>       |       ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
> In file included from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/code/nativeInst.hpp:30,
>                  from /home/zifeihan/riscv-port-jdk11u/src/hotspot/share/precompiled/precompiled.hpp:77:
> /home/zifeihan/riscv-port-jdk11u/src/hotspot/cpu/riscv/nativeInst_riscv.hpp: In member function 'void LIR_Assembler::patching_epilog(PatchingStub*, LIR_PatchCode, Register, CodeEmitInfo*)':
> /home/zifeihan/riscv-port-jdk11u/src/hotspot/cpu/riscv/nativeInst_riscv.hpp:419:8: note: in a call to non-static member function 'void NativeMovRegMem::set_offset(int)'
>   419 |   void set_offset(int x);
>       |        ^~~~~~~~~~
> cc1plus: all warnings being treated as errors
> 
> * All command lines available in /home/zifeihan/riscv-port-jdk11u/build/linux-riscv64-normal-minimal-release/make-support/failure-logs.
> === End of repeated output ===
> 
> No indication of failed target found.
> Hint: Try searching the build log for '] Error'.
> Hint: See doc/building.html#troubleshooting for assistance.
> 
> make[1]: *** [/home/zifeihan/riscv-port-jdk11u/make/Init.gmk:308: main] E...

LGTM

-------------

PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/7#pullrequestreview-2051579357

From syan at openjdk.org  Thu May 30 12:16:49 2024
From: syan at openjdk.org (SendaoYan)
Date: Thu, 30 May 2024 12:16:49 GMT
Subject: [riscv-port-jdk11u:riscv-port] RFR: 8333261: [repo-riscv-port-11]
 sun/jvm/hotspot/debugger/risv64 should be riscv64
Message-ID: <u9dO6WfmWblMGpWtF6tQBHMnRTtJponFus6ftZLHZjY=.db49b576-9655-443d-aef9-bb180329c8cd@github.com>

Hi,
  The package name of `RISCV64ThreadContext.java` is `sun.jvm.hotspot.debugger.riscv64`, so the directory name of `RISCV64ThreadContext.java` shoule be `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/riscv64`, rather than `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/risv64`.

-------------

Commit messages:
 - 8333261: [repo-riscv-port-11] sun/jvm/hotspot/debugger/risv64 should be riscv64

Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/23/files
  Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=23&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8333261
  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/23.diff
  Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/23/head:pull/23

PR: https://git.openjdk.org/riscv-port-jdk11u/pull/23

From fyang at openjdk.org  Thu May 30 12:31:21 2024
From: fyang at openjdk.org (Fei Yang)
Date: Thu, 30 May 2024 12:31:21 GMT
Subject: [riscv-port-jdk11u:riscv-port] RFR: 8333261: [repo-riscv-port-11]
 sun/jvm/hotspot/debugger/risv64 should be riscv64
In-Reply-To: <u9dO6WfmWblMGpWtF6tQBHMnRTtJponFus6ftZLHZjY=.db49b576-9655-443d-aef9-bb180329c8cd@github.com>
References: <u9dO6WfmWblMGpWtF6tQBHMnRTtJponFus6ftZLHZjY=.db49b576-9655-443d-aef9-bb180329c8cd@github.com>
Message-ID: <YviHrv1FKBDLpvYT-TYaDLHgrurjbrUL7KL-yWEzF2Y=.fcd83503-be39-4bdb-8cb0-8d65244957ec@github.com>

On Thu, 30 May 2024 12:11:57 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi,
>   The package name of `RISCV64ThreadContext.java` is `sun.jvm.hotspot.debugger.riscv64`, so the directory name of `RISCV64ThreadContext.java` shoule be `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/riscv64`, rather than `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/risv64`.
> 
> Additional testing:
> 
> - [ ] riscv64 native build

Good catch! Thanks.

-------------

Marked as reviewed by fyang (Lead).

PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/23#pullrequestreview-2088145629

From gcao at openjdk.org  Thu May 30 14:28:25 2024
From: gcao at openjdk.org (Gui Cao)
Date: Thu, 30 May 2024 14:28:25 GMT
Subject: [riscv-port-jdk11u:riscv-port] RFR: 8333261: [repo-riscv-port-11]
 sun/jvm/hotspot/debugger/risv64 should be riscv64
In-Reply-To: <u9dO6WfmWblMGpWtF6tQBHMnRTtJponFus6ftZLHZjY=.db49b576-9655-443d-aef9-bb180329c8cd@github.com>
References: <u9dO6WfmWblMGpWtF6tQBHMnRTtJponFus6ftZLHZjY=.db49b576-9655-443d-aef9-bb180329c8cd@github.com>
Message-ID: <y8t4tkfte43Jj64TtC9cri7sycCkD30AxN4-85CDUrk=.5c3ee2c7-0c6c-4506-b5ee-5b97c703a8a2@github.com>

On Thu, 30 May 2024 12:11:57 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi,
>   The package name of `RISCV64ThreadContext.java` is `sun.jvm.hotspot.debugger.riscv64`, so the directory name of `RISCV64ThreadContext.java` shoule be `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/riscv64`, rather than `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/risv64`.
> 
> Additional testing:
> 
> - [x] riscv64 native build

Looks good, Thanks.

-------------

Marked as reviewed by gcao (Committer).

PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/23#pullrequestreview-2088438439

From syan at openjdk.org  Fri May 31 01:28:28 2024
From: syan at openjdk.org (SendaoYan)
Date: Fri, 31 May 2024 01:28:28 GMT
Subject: [riscv-port-jdk11u:riscv-port] RFR: 8333261: [repo-riscv-port-11]
 sun/jvm/hotspot/debugger/risv64 should be riscv64
In-Reply-To: <u9dO6WfmWblMGpWtF6tQBHMnRTtJponFus6ftZLHZjY=.db49b576-9655-443d-aef9-bb180329c8cd@github.com>
References: <u9dO6WfmWblMGpWtF6tQBHMnRTtJponFus6ftZLHZjY=.db49b576-9655-443d-aef9-bb180329c8cd@github.com>
Message-ID: <xPyxda3_fdlANLqWlbtR_SsyLcCAzEKch6oOQflOqtM=.88019753-9fcc-4e5d-8053-d7bb48473f4e@github.com>

On Thu, 30 May 2024 12:11:57 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi,
>   The package name of `RISCV64ThreadContext.java` is `sun.jvm.hotspot.debugger.riscv64`, so the directory name of `RISCV64ThreadContext.java` shoule be `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/riscv64`, rather than `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/risv64`.
> 
> Additional testing:
> 
> - [x] riscv64 native build
> - [x] run all the jtreg tests expect for `test/hotspot/jtreg/vmTestbase/ test/hotspot/jtreg/applications/`

Run all the jtreg tests expect for `test/hotspot/jtreg/vmTestbase/ test/hotspot/jtreg/applications/`, there two failures.

1. javax/swing/JComboBox/6632953/bug6632953.java report `malloc(): unaligned fastbin chunk detected`. I can't reproduce it now, I will check it later. I think it's unrelated to this PR.
2. java/net/MulticastSocket/Test.java report `java.net.SocketException: No such device`, it's environmental issue, unrelated to this issue.

-------------

PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/23#issuecomment-2141081401