From dzhang at openjdk.org Tue Oct 1 01:05:01 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Tue, 1 Oct 2024 01:05:01 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8339741: RISC-V: C ABI breakage for integer on stack In-Reply-To: References: Message-ID: On Sun, 29 Sep 2024 01:50:56 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8339741](https://bugs.openjdk.org/browse/JDK-8339741). > > The original patch cannot be directly applied because jdk11u has no [JDK-8294100](https://bugs.openjdk.org/browse/JDK-8294100). > > Testing: > - Tier1 passed without new failure on lp4a (release). > - New jtreg test: test/hotspot/jtreg/compiler/calls/TestManyArgs.java This pull request has now been integrated. Changeset: e97f06fb Author: Dingli Zhang Committer: Fei Yang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/e97f06fb161feed07908b98136a708364e298f07 Stats: 156 lines in 4 files changed: 150 ins; 0 del; 6 mod 8339741: RISC-V: C ABI breakage for integer on stack Reviewed-by: fyang Backport-of: bfe7f9205b56483b4364130a3a87c58c3fc82998 ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/35 From duke at openjdk.org Thu Oct 3 08:19:26 2024 From: duke at openjdk.org (duke) Date: Thu, 3 Oct 2024 08:19:26 GMT Subject: git: openjdk/riscv-port-jdk11u: riscv-port: 10 new changesets Message-ID: <1f8afdb8-ee12-43bd-860b-ba3624a38f3e@openjdk.org> Changeset: 59b38591 Branch: riscv-port Author: George Adams Date: 2024-09-30 13:00:44 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/59b38591603ccdd6343f5199293c58752c32a8b2 8340815: Add SECURITY.md file Backport-of: 0474f020bf276c761f46bc8ba0873ed90a8fd19b + SECURITY.md Changeset: bec83f35 Branch: riscv-port Author: Sergey Bylokhov Date: 2024-09-30 15:45:40 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/bec83f35d6408c9e55f0e442c77019441282b50d 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java Reviewed-by: yan, andrew Backport-of: e61252dc278fd44345c5377811552ed6760ffcf0 ! test/jdk/javax/naming/module/RunBasic.java ! test/jdk/javax/naming/module/src/test/test/ConnectWithAuthzId.java ! test/jdk/javax/naming/module/src/test/test/ConnectWithFoo.java ! test/jdk/javax/naming/module/src/test/test/ReadByUrl.java ! test/jdk/javax/naming/module/src/test/test/StoreFruit.java ! test/jdk/javax/naming/module/src/test/test/StoreObject.java ! test/jdk/javax/naming/module/src/test/test/StorePerson.java ! test/jdk/javax/naming/module/src/test/test/StoreRemote.java Changeset: 01579674 Branch: riscv-port Author: Daniel Hu Committer: Sergey Bylokhov Date: 2024-09-30 16:01:52 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/015796747f05b9c32c2e5a8491d0e149788f9998 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak Backport-of: f6be922952642f40dcf0d27b7896c9a6acdd6378 ! test/jdk/jdk/jfr/event/oldobject/TestListenerLeak.java Changeset: 06d87ca6 Branch: riscv-port Author: Antonio Committer: Severin Gehwolf Date: 2024-09-30 16:03:42 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/06d87ca65927fa241c8e93cd2ebe4d0d52586e32 8299254: Support dealing with standard assert macro Reviewed-by: sgehwolf Backport-of: 89dd23f2fab0d98879e68f817923656e113087e3 ! make/hotspot/lib/JvmFlags.gmk + src/hotspot/share/utilities/vmassert_reinstall.hpp + src/hotspot/share/utilities/vmassert_uninstall.hpp ! test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp ! test/hotspot/gtest/jfr/test_networkUtilization.cpp ! test/hotspot/gtest/unittest.hpp Changeset: 2232d1f7 Branch: riscv-port Author: Zdenek Zambersky Committer: Aleksey Shipilev Date: 2024-09-30 16:23:40 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/2232d1f7b497d782edb6fa5f41ec9fd2a90ca33d 8338402: GHA: some of bundles may not get removed Backport-of: d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea ! .github/workflows/main.yml Changeset: 217b9fdf Branch: riscv-port Author: Goetz Lindenmaier Date: 2024-10-01 13:34:57 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/217b9fdf056f4887230f60fdf60b036861699cd8 8341057: Add 2 SSL.com TLS roots Reviewed-by: mbaesken Backport-of: 824a297aae15ba16cf6d7aded4b95fc9d6bf55e5 + make/data/cacerts/ssltlsrootecc2022 + make/data/cacerts/ssltlsrootrsa2022 ! test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java ! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java Changeset: 82c330b4 Branch: riscv-port Author: Goetz Lindenmaier Date: 2024-10-01 13:37:14 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/82c330b46498e78c67c1905535106c97536e4914 8341059: Change Entrust TLS distrust date to November 12, 2024 Backport-of: eced83e13090748218ab3dac78f6ff1bddf2b158 ! src/java.base/share/classes/sun/security/validator/CADistrustPolicy.java ! src/java.base/share/classes/sun/security/validator/EntrustTLSPolicy.java ! src/java.base/share/conf/security/java.security ! test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust/Distrust.java Changeset: 64367498 Branch: riscv-port Author: Goetz Lindenmaier Date: 2024-10-02 08:26:50 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/6436749891c2b35b9858f59f573d17f6d49bdd8b Merge Changeset: a754a3d8 Branch: riscv-port Author: Antonio Vieiro Committer: Paul Hohensee Date: 2024-10-02 19:38:28 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/a754a3d8972abc67aee768d31a2dc2e8214274cf 8339644: Improve parsing of Day/Month in tzdata rules Backport-of: 5faa0df6fb1b4c5dc7f642d7e062c44a1764029c ! make/jdk/src/classes/build/tools/tzdb/TzdbZoneRulesProvider.java ! test/jdk/sun/util/calendar/zi/Month.java ! test/jdk/sun/util/calendar/zi/RuleDay.java Changeset: 7c55d321 Branch: riscv-port Author: Fei Yang Date: 2024-10-03 16:14:04 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/7c55d3210776604b33914614bcd298932f96ba36 Merge branch 'master' into riscv-port From gcao at openjdk.org Tue Oct 8 06:35:23 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 8 Oct 2024 06:35:23 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293524: RISC-V: Use macro-assembler functions as appropriate In-Reply-To: <-nCeiq-d6VP-4Sregbjsr2cHyhmpDExtGy11RZWtXu8=.612c35b0-8b18-41bd-b9e7-315ad27bd05e@github.com> References: <-nCeiq-d6VP-4Sregbjsr2cHyhmpDExtGy11RZWtXu8=.612c35b0-8b18-41bd-b9e7-315ad27bd05e@github.com> Message-ID: <6z8WNIVeApOFIJc1Rvd4jGTCrTszmOWB2byGB8Gxco8=.4052c52c-8481-4064-92ce-2e1dfcc6b593@github.com> On Fri, 27 Sep 2024 03:03:41 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8293524](https://bugs.openjdk.org/browse/JDK-8293524). > The original patch cannot be directly applied because jdk11u has no [JDK-8241436 ](https://bugs.openjdk.org/browse/JDK-8241436 ) and [JDK-8229258](https://bugs.openjdk.org/browse/JDK-8229258) . Also jdk11u does not have generate_bigIntegerLeftShift and generate_bigIntegerRightShift functions. > > Testing: > - Tier1 passed without new failure on lp4a (release). Why is li(result, 1); converted to mv(result, -1);? src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 2258: > 2256: > 2257: // Success > 2258: mv(result, -1); why is -1? src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 2284: > 2282: // equal, succeed > 2283: if (result_as_bool) { > 2284: mv(result, -1); and here. src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 2313: > 2311: > 2312: // Success > 2313: mv(result, -1); and here. ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/34#pullrequestreview-2353513033 PR Review Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/34#discussion_r1791271129 PR Review Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/34#discussion_r1791272039 PR Review Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/34#discussion_r1791272298 From gcao at openjdk.org Tue Oct 8 06:43:23 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 8 Oct 2024 06:43:23 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293474: RISC-V: Unify the way of moving function pointer In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 02:51:15 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8293474](https://bugs.openjdk.org/browse/JDK-8293474). > Applies not cleanly due to context difference, and changes in `shenandoahBarrierSetAssembler_riscv.cpp` have been modified previously. > > Testing: > - Tier1 passed without new failure on lp4a (release). Looks good. ------------- Marked as reviewed by gcao (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/33#pullrequestreview-2353534152 From gcao at openjdk.org Tue Oct 8 08:33:54 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 8 Oct 2024 08:33:54 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293566: RISC-V: Clean up push and pop registers Message-ID: <-xbYXR6unNiojMy4KBv9h5cPY15OJ2qmHRHBGNxmgd0=.d2c05962-d4d6-45ae-8538-f2828d4c9dc6@github.com> Hi, I would like to backport [JDK-8293566](https://bugs.openjdk.org/browse/JDK-8293566) to riscv-port-jdk11u. with this patch ,it will have better readability. jdk11u not have z gc, so this backport is not clean. ### Testing - [ ] Run tier1 tests on SOPHON SG2042 (release) ------------- Commit messages: - Backport 8293566: RISC-V: Clean up push and pop registers Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/36/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=36&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293566 Stats: 35 lines in 4 files changed: 7 ins; 3 del; 25 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/36.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/36/head:pull/36 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/36 From dzhang at openjdk.org Tue Oct 8 13:21:53 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Tue, 8 Oct 2024 13:21:53 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293524: RISC-V: Use macro-assembler functions as appropriate [v2] In-Reply-To: <-nCeiq-d6VP-4Sregbjsr2cHyhmpDExtGy11RZWtXu8=.612c35b0-8b18-41bd-b9e7-315ad27bd05e@github.com> References: <-nCeiq-d6VP-4Sregbjsr2cHyhmpDExtGy11RZWtXu8=.612c35b0-8b18-41bd-b9e7-315ad27bd05e@github.com> Message-ID: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8293524](https://bugs.openjdk.org/browse/JDK-8293524). > The original patch cannot be directly applied because jdk11u has no [JDK-8241436 ](https://bugs.openjdk.org/browse/JDK-8241436 ) and [JDK-8229258](https://bugs.openjdk.org/browse/JDK-8229258) . Also jdk11u does not have generate_bigIntegerLeftShift and generate_bigIntegerRightShift functions. > > Testing: > - Tier1 passed without new failure on lp4a (release). Dingli Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8293524: RISC-V: Use macro-assembler functions as appropriate ------------- Changes: - all: https://git.openjdk.org/riscv-port-jdk11u/pull/34/files - new: https://git.openjdk.org/riscv-port-jdk11u/pull/34/files/8140338d..0c4fca28 Webrevs: - full: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=34&range=01 - incr: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=34&range=00-01 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/34.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/34/head:pull/34 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/34 From dzhang at openjdk.org Tue Oct 8 13:21:54 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Tue, 8 Oct 2024 13:21:54 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293524: RISC-V: Use macro-assembler functions as appropriate [v2] In-Reply-To: <6z8WNIVeApOFIJc1Rvd4jGTCrTszmOWB2byGB8Gxco8=.4052c52c-8481-4064-92ce-2e1dfcc6b593@github.com> References: <-nCeiq-d6VP-4Sregbjsr2cHyhmpDExtGy11RZWtXu8=.612c35b0-8b18-41bd-b9e7-315ad27bd05e@github.com> <6z8WNIVeApOFIJc1Rvd4jGTCrTszmOWB2byGB8Gxco8=.4052c52c-8481-4064-92ce-2e1dfcc6b593@github.com> Message-ID: On Tue, 8 Oct 2024 06:28:12 GMT, Gui Cao wrote: >> Dingli Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: >> >> 8293524: RISC-V: Use macro-assembler functions as appropriate > > src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 2258: > >> 2256: >> 2257: // Success >> 2258: mv(result, -1); > > why is -1? Just a typo, sorry. Fixed. ------------- PR Review Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/34#discussion_r1791862465 From dzhang at openjdk.org Tue Oct 8 13:35:24 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Tue, 8 Oct 2024 13:35:24 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293524: RISC-V: Use macro-assembler functions as appropriate [v2] In-Reply-To: <6z8WNIVeApOFIJc1Rvd4jGTCrTszmOWB2byGB8Gxco8=.4052c52c-8481-4064-92ce-2e1dfcc6b593@github.com> References: <-nCeiq-d6VP-4Sregbjsr2cHyhmpDExtGy11RZWtXu8=.612c35b0-8b18-41bd-b9e7-315ad27bd05e@github.com> <6z8WNIVeApOFIJc1Rvd4jGTCrTszmOWB2byGB8Gxco8=.4052c52c-8481-4064-92ce-2e1dfcc6b593@github.com> Message-ID: On Tue, 8 Oct 2024 06:32:39 GMT, Gui Cao wrote: > Why is li(result, 1); converted to mv(result, -1);? Just a typo, sorry. Fixed. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/34#issuecomment-2399861846 From fyang at openjdk.org Wed Oct 9 11:03:17 2024 From: fyang at openjdk.org (Fei Yang) Date: Wed, 9 Oct 2024 11:03:17 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293474: RISC-V: Unify the way of moving function pointer In-Reply-To: References: Message-ID: <07X4VMzushhY_frruaQLKgo5i5cPsGB5j7MHEn-sB_8=.7dfb5bea-b0b8-4226-8ec5-081de9e75880@github.com> On Fri, 27 Sep 2024 02:51:15 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8293474](https://bugs.openjdk.org/browse/JDK-8293474). > Applies not cleanly due to context difference, and changes in `shenandoahBarrierSetAssembler_riscv.cpp` have been modified previously. > > Testing: > - Tier1 passed without new failure on lp4a (release). Marked as reviewed by fyang (Lead). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/33#pullrequestreview-2356801843 From dzhang at openjdk.org Wed Oct 9 11:09:25 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 9 Oct 2024 11:09:25 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293474: RISC-V: Unify the way of moving function pointer In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 02:51:15 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8293474](https://bugs.openjdk.org/browse/JDK-8293474). > Applies not cleanly due to context difference, and changes in `shenandoahBarrierSetAssembler_riscv.cpp` have been modified previously. > > Testing: > - Tier1 passed without new failure on lp4a (release). Thanks all for the review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/33#issuecomment-2402012920 From dzhang at openjdk.org Wed Oct 9 11:09:25 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 9 Oct 2024 11:09:25 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8293474: RISC-V: Unify the way of moving function pointer In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 02:51:15 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8293474](https://bugs.openjdk.org/browse/JDK-8293474). > Applies not cleanly due to context difference, and changes in `shenandoahBarrierSetAssembler_riscv.cpp` have been modified previously. > > Testing: > - Tier1 passed without new failure on lp4a (release). This pull request has now been integrated. Changeset: d46c73c4 Author: Dingli Zhang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/d46c73c4d90670a06f8351bde444a3f4e5c0fc41 Stats: 16 lines in 2 files changed: 2 ins; 8 del; 6 mod 8293474: RISC-V: Unify the way of moving function pointer Reviewed-by: gcao, fyang Backport-of: fc5f97fe379825cb927666ae26aef00082cfae56 ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/33 From gcao at openjdk.org Wed Oct 9 11:39:26 2024 From: gcao at openjdk.org (Gui Cao) Date: Wed, 9 Oct 2024 11:39:26 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293524: RISC-V: Use macro-assembler functions as appropriate [v2] In-Reply-To: References: <-nCeiq-d6VP-4Sregbjsr2cHyhmpDExtGy11RZWtXu8=.612c35b0-8b18-41bd-b9e7-315ad27bd05e@github.com> Message-ID: On Tue, 8 Oct 2024 13:21:53 GMT, Dingli Zhang wrote: >> Please review this backport to riscv-port-jdk11u. >> Backport of [JDK-8293524](https://bugs.openjdk.org/browse/JDK-8293524). >> The original patch cannot be directly applied because jdk11u has no [JDK-8241436 ](https://bugs.openjdk.org/browse/JDK-8241436 ) and [JDK-8229258](https://bugs.openjdk.org/browse/JDK-8229258) . Also jdk11u does not have generate_bigIntegerLeftShift and generate_bigIntegerRightShift functions. >> >> Testing: >> - Tier1 passed without new failure on lp4a (release). > > Dingli Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8293524: RISC-V: Use macro-assembler functions as appropriate Looks good. ------------- Marked as reviewed by gcao (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/34#pullrequestreview-2356882619 From dzhang at openjdk.org Wed Oct 9 12:00:26 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 9 Oct 2024 12:00:26 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293566: RISC-V: Clean up push and pop registers In-Reply-To: <-xbYXR6unNiojMy4KBv9h5cPY15OJ2qmHRHBGNxmgd0=.d2c05962-d4d6-45ae-8538-f2828d4c9dc6@github.com> References: <-xbYXR6unNiojMy4KBv9h5cPY15OJ2qmHRHBGNxmgd0=.d2c05962-d4d6-45ae-8538-f2828d4c9dc6@github.com> Message-ID: On Tue, 8 Oct 2024 08:28:21 GMT, Gui Cao wrote: > Hi, I would like to backport [JDK-8293566](https://bugs.openjdk.org/browse/JDK-8293566) to riscv-port-jdk11u. with this patch ,it will have better readability. jdk11u not have z gc, so this backport is not clean. > > ### Testing > - [x] Run tier1 tests on SOPHON SG2042 (release) LGTM, thanks. ------------- Marked as reviewed by dzhang (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/36#pullrequestreview-2356931997 From fyang at openjdk.org Wed Oct 9 12:14:24 2024 From: fyang at openjdk.org (Fei Yang) Date: Wed, 9 Oct 2024 12:14:24 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293524: RISC-V: Use macro-assembler functions as appropriate [v2] In-Reply-To: References: <-nCeiq-d6VP-4Sregbjsr2cHyhmpDExtGy11RZWtXu8=.612c35b0-8b18-41bd-b9e7-315ad27bd05e@github.com> Message-ID: On Tue, 8 Oct 2024 13:21:53 GMT, Dingli Zhang wrote: >> Please review this backport to riscv-port-jdk11u. >> Backport of [JDK-8293524](https://bugs.openjdk.org/browse/JDK-8293524). >> The original patch cannot be directly applied because jdk11u has no [JDK-8241436 ](https://bugs.openjdk.org/browse/JDK-8241436 ) and [JDK-8229258](https://bugs.openjdk.org/browse/JDK-8229258) . Also jdk11u does not have generate_bigIntegerLeftShift and generate_bigIntegerRightShift functions. >> >> Testing: >> - Tier1 passed without new failure on lp4a (release). > > Dingli Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8293524: RISC-V: Use macro-assembler functions as appropriate Marked as reviewed by fyang (Lead). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/34#pullrequestreview-2356963254 From dzhang at openjdk.org Wed Oct 9 12:23:18 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 9 Oct 2024 12:23:18 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293524: RISC-V: Use macro-assembler functions as appropriate [v2] In-Reply-To: References: <-nCeiq-d6VP-4Sregbjsr2cHyhmpDExtGy11RZWtXu8=.612c35b0-8b18-41bd-b9e7-315ad27bd05e@github.com> Message-ID: <0D-HpbRCXwLCSYkIkQoZlcafrPYOZ7YWiEe1-Jvsu9U=.8fe96938-7252-41b1-b11a-98d850d309bc@github.com> On Tue, 8 Oct 2024 13:21:53 GMT, Dingli Zhang wrote: >> Please review this backport to riscv-port-jdk11u. >> Backport of [JDK-8293524](https://bugs.openjdk.org/browse/JDK-8293524). >> The original patch cannot be directly applied because jdk11u has no [JDK-8241436 ](https://bugs.openjdk.org/browse/JDK-8241436 ) and [JDK-8229258](https://bugs.openjdk.org/browse/JDK-8229258) . Also jdk11u does not have generate_bigIntegerLeftShift and generate_bigIntegerRightShift functions. >> >> Testing: >> - Tier1 passed without new failure on lp4a (release). > > Dingli Zhang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8293524: RISC-V: Use macro-assembler functions as appropriate Thanks all for the review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/34#issuecomment-2402162781 From dzhang at openjdk.org Wed Oct 9 12:23:18 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 9 Oct 2024 12:23:18 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8293524: RISC-V: Use macro-assembler functions as appropriate In-Reply-To: <-nCeiq-d6VP-4Sregbjsr2cHyhmpDExtGy11RZWtXu8=.612c35b0-8b18-41bd-b9e7-315ad27bd05e@github.com> References: <-nCeiq-d6VP-4Sregbjsr2cHyhmpDExtGy11RZWtXu8=.612c35b0-8b18-41bd-b9e7-315ad27bd05e@github.com> Message-ID: On Fri, 27 Sep 2024 03:03:41 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8293524](https://bugs.openjdk.org/browse/JDK-8293524). > The original patch cannot be directly applied because jdk11u has no [JDK-8241436 ](https://bugs.openjdk.org/browse/JDK-8241436 ) and [JDK-8229258](https://bugs.openjdk.org/browse/JDK-8229258) . Also jdk11u does not have generate_bigIntegerLeftShift and generate_bigIntegerRightShift functions. > > Testing: > - Tier1 passed without new failure on lp4a (release). This pull request has now been integrated. Changeset: 0d7892b1 Author: Dingli Zhang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/0d7892b1bc8772c4036a398886e1076e3b011ef6 Stats: 76 lines in 12 files changed: 0 ins; 0 del; 76 mod 8293524: RISC-V: Use macro-assembler functions as appropriate Reviewed-by: gcao, fyang Backport-of: 43e191d64b0094cc1ece61929c32e017ee90c0c8 ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/34 From fyang at openjdk.org Wed Oct 9 12:40:37 2024 From: fyang at openjdk.org (Fei Yang) Date: Wed, 9 Oct 2024 12:40:37 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293566: RISC-V: Clean up push and pop registers In-Reply-To: <-xbYXR6unNiojMy4KBv9h5cPY15OJ2qmHRHBGNxmgd0=.d2c05962-d4d6-45ae-8538-f2828d4c9dc6@github.com> References: <-xbYXR6unNiojMy4KBv9h5cPY15OJ2qmHRHBGNxmgd0=.d2c05962-d4d6-45ae-8538-f2828d4c9dc6@github.com> Message-ID: On Tue, 8 Oct 2024 08:28:21 GMT, Gui Cao wrote: > Hi, I would like to backport [JDK-8293566](https://bugs.openjdk.org/browse/JDK-8293566) to riscv-port-jdk11u. with this patch ,it will have better readability. jdk11u not have z gc, so this backport is not clean. > > ### Testing > - [x] Run tier1 tests on SOPHON SG2042 (release) Marked as reviewed by fyang (Lead). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/36#pullrequestreview-2357011571 From duke at openjdk.org Wed Oct 9 19:11:19 2024 From: duke at openjdk.org (Andreas Schwab) Date: Wed, 9 Oct 2024 19:11:19 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293474: RISC-V: Unify the way of moving function pointer In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 02:51:15 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8293474](https://bugs.openjdk.org/browse/JDK-8293474). > Applies not cleanly due to context difference, and changes in `shenandoahBarrierSetAssembler_riscv.cpp` have been modified previously. > > Testing: > - Tier1 passed without new failure on lp4a (release). This is causing a crash during boostrap, please revert. # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (output.cpp:1491), pid=174079, tid=174883 # guarantee((int)(blk_starts[i+1] - blk_starts[i]) >= (current_offset - blk_offset)) failed: shouldn't increase block size # # JRE version: OpenJDK Runtime Environment (11.0.24+8) (build 11.0.24+8-suse-370.1-riscv64) # Java VM: OpenJDK 64-Bit Server VM (11.0.24+8-suse-370.1-riscv64, mixed mode, tiered, compressed oops, g1 gc, linux-riscv64) # Core dump will be written. Default location: /.build/cores/174079 # # An error report file with more information is saved as: # /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/make/hs_err_pid174079.log [thread 174088 also had an error] # # Compiler replay data is saved as: # /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/make/replay_pid174079.log # # If you would like to submit a bug report, please visit: # https://bugreport.java.com/bugreport/crash.jsp # /usr/bin/bash: line 1: 174079 Aborted /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/jdk/bin/jlink -J-Djlink.debug=true --module-path /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/images/jmods --endian little --release-info /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/jdk/release --order-resources=**module-info.class,@/home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/support/link_opt/classlist,/java.base/java/**,/java.base/jdk/**,/java.base/sun/**,/java.base/com/**,/jdk.localedata/** --dedup-legal-notices=error-if-not-same-content --generate-jli-classes=@/home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/support/link_opt/default_jli_trace.txt --add-modules java.base,java.compiler,java.datatransfer,java.desktop,java.instrument,java.logging,java.management,java.management.rmi,java.naming,java.net.http,java.prefs,java.rmi,java.scripting,java.se,java.security.jgss,java.security.sasl,java.smartcardio,java.sql,java.sql.rowset,java.transac tion.xa,java.xml,java.xml.crypto,jdk.accessibility,jdk.attach,jdk.charsets,jdk.compiler,jdk.crypto.cryptoki,jdk.crypto.ec,jdk.dynalink,jdk.editpad,jdk.hotspot.agent,jdk.httpserver,jdk.internal.ed,jdk.internal.jvmstat,jdk.internal.le,jdk.internal.opt,jdk.jartool,jdk.javadoc,jdk.jcmd,jdk.jconsole,jdk.jdeps,jdk.jdi,jdk.jdwp.agent,jdk.jfr,jdk.jlink,jdk.jshell,jdk.jsobject,jdk.jstatd,jdk.localedata,jdk.management,jdk.management.agent,jdk.management.jfr,jdk.naming.dns,jdk.naming.ldap,jdk.naming.rmi,jdk.net,jdk.pack,jdk.rmic,jdk.scripting.nashorn,jdk.scripting.nashorn.shell,jdk.sctp,jdk.security.auth,jdk.security.jgss,jdk.unsupported,jdk.unsupported.desktop,jdk.xml.dom,jdk.zipfs --output /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/images/jdk > >(/usr/bin/tee -a /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/support/images/jdk.log) 2> >(/usr/bin/tee -a /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/support/images/jdk.log 1>&2) ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/33#issuecomment-2403102198 From duke at openjdk.org Thu Oct 10 06:07:34 2024 From: duke at openjdk.org (Andreas Schwab) Date: Thu, 10 Oct 2024 06:07:34 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293474: RISC-V: Unify the way of moving function pointer In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 02:51:15 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8293474](https://bugs.openjdk.org/browse/JDK-8293474). > Applies not cleanly due to context difference, and changes in `shenandoahBarrierSetAssembler_riscv.cpp` have been modified previously. > > Testing: > - Tier1 passed without new failure on lp4a (release). With slowdebug: 1894 Epilog === [[]] [-2147234809] # pop frame 112 add sp, sp, #112 ld ra, [sp,#-16] ld fp, [sp,#-8] # touch polling page li t0, #0x7f4cb960e000 ld zr, [t0] n_size (272), current_offset (1316), instr_offset (1036) Could not load hsdis-riscv64.so; library not loadable; PrintAssembly is disabled ------------------- # To suppress the following error report, specify this argument # after -XX: or in .hotspotrc: SuppressErrorAt=/output.cpp:1416 # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (/home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/src/hotspot/share/opto/output.cpp:1416), pid=366339, tid=366381 # assert(false) failed: wrong size of mach node ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/33#issuecomment-2404112264 From dzhang at openjdk.org Thu Oct 10 06:18:34 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 10 Oct 2024 06:18:34 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293474: RISC-V: Unify the way of moving function pointer In-Reply-To: References: Message-ID: On Wed, 9 Oct 2024 18:51:22 GMT, Andreas Schwab wrote: > This is causing a crash during boostrap, please revert. > > ``` > # > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error (output.cpp:1491), pid=174079, tid=174883 > # guarantee((int)(blk_starts[i+1] - blk_starts[i]) >= (current_offset - blk_offset)) failed: shouldn't increase block size > # > # JRE version: OpenJDK Runtime Environment (11.0.24+8) (build 11.0.24+8-suse-370.1-riscv64) > # Java VM: OpenJDK 64-Bit Server VM (11.0.24+8-suse-370.1-riscv64, mixed mode, tiered, compressed oops, g1 gc, linux-riscv64) > # Core dump will be written. Default location: /.build/cores/174079 > # > # An error report file with more information is saved as: > # /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/make/hs_err_pid174079.log > [thread 174088 also had an error] > # > # Compiler replay data is saved as: > # /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/make/replay_pid174079.log > # > # If you would like to submit a bug report, please visit: > # https://bugreport.java.com/bugreport/crash.jsp > # > /usr/bin/bash: line 1: 174079 Aborted /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/jdk/bin/jlink -J-Djlink.debug=true --module-path /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/images/jmods --endian little --release-info /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/jdk/release --order-resources=**module-info.class,@/home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/support/link_opt/classlist,/java.base/java/**,/java.base/jdk/**,/java.base/sun/**,/java.base/com/**,/jdk.localedata/** --dedup-legal-notices=error-if-not-same-content --generate-jli-classes=@/home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/support/link_opt/default_jli_trace.txt --add-modules java.base,java.compiler,java.datatransfer,java.desktop,java.instrument,java.logging,java.management,java.management.rmi,java.naming,java.net.http,java.prefs,java.rmi,java.scripting,java.se,java.security.jgss,java.security.sasl,java.smartcardio,java.sql,java.sql.rowset,java.trans action.xa,java.xml,java.xml.crypto,jdk.accessibility,jdk.attach,jdk.charsets,jdk.compiler,jdk.crypto.cryptoki,jdk.crypto.ec,jdk.dynalink,jdk.editpad,jdk.hotspot.agent,jdk.httpserver,jdk.internal.ed,jdk.internal.jvmstat,jdk.internal.le,jdk.internal.opt,jdk.jartool,jdk.javadoc,jdk.jcmd,jdk.jconsole,jdk.jdeps,jdk.jdi,jdk.jdwp.agent,jdk.jfr,jdk.jlink,jdk.jshell,jdk.jsobject,jdk.jstatd,jdk.localedata,jdk.management,jdk.management.agent,jdk.management.jfr,jdk.naming.dns,jdk.naming.ldap,jdk.naming.rmi,jdk.net,jdk.pack,jdk.rmic,jdk.scripting.nashorn,jdk.scripting.nashorn.shell,jdk.sctp,jdk.security.auth,jdk.security.jgss,jdk.unsupported,jdk.unsupported.desktop,jdk.xml.dom,jdk.zipfs --output /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/images/jdk > >(/usr/bin/tee -a /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/support/images/jdk.log) 2> >(/usr/bin/tee -a /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.24-8/build/support/images/jdk.log 1>&2) > ``` I use [this](https://builds.shipilev.net/openjdk-jdk11-riscv/openjdk-jdk11-riscv-linux-riscv64-server.tar.xz) as bootjdk and compiled on the commit `d46c73c4d90670a06f8351bde444a3f4e5c0fc41` using the following command: bash configure \ --disable-warnings-as-errors \ --with-boot-jdk=/home/dingli/jdk-bin/openjdk-11/jdk time make bootcycle-images It can be built successfully. Could you please try the same [bootjdk](https://builds.shipilev.net/openjdk-jdk11-riscv/openjdk-jdk11-riscv-linux-riscv64-server.tar.xz) ? Also can you give reproduction conditions? Thanks a lot. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/33#issuecomment-2404129453 From duke at openjdk.org Thu Oct 10 06:37:21 2024 From: duke at openjdk.org (Andreas Schwab) Date: Thu, 10 Oct 2024 06:37:21 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293474: RISC-V: Unify the way of moving function pointer In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 02:51:15 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8293474](https://bugs.openjdk.org/browse/JDK-8293474). > Applies not cleanly due to context difference, and changes in `shenandoahBarrierSetAssembler_riscv.cpp` have been modified previously. > > Testing: > - Tier1 passed without new failure on lp4a (release). https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:riscv:java:test/java-11-openjdk/standard/riscv64 ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/33#issuecomment-2404158925 From gcao at openjdk.org Thu Oct 10 10:00:49 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 10 Oct 2024 10:00:49 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8293566: RISC-V: Clean up push and pop registers In-Reply-To: <-xbYXR6unNiojMy4KBv9h5cPY15OJ2qmHRHBGNxmgd0=.d2c05962-d4d6-45ae-8538-f2828d4c9dc6@github.com> References: <-xbYXR6unNiojMy4KBv9h5cPY15OJ2qmHRHBGNxmgd0=.d2c05962-d4d6-45ae-8538-f2828d4c9dc6@github.com> Message-ID: <5bZbSc21gBYILtHVhHMgbqa94fz7QM0_XCwUUcoHvFs=.9a20e48d-d765-4726-b5f0-5a14d50a6b95@github.com> On Tue, 8 Oct 2024 08:28:21 GMT, Gui Cao wrote: > Hi, I would like to backport [JDK-8293566](https://bugs.openjdk.org/browse/JDK-8293566) to riscv-port-jdk11u. with this patch ,it will have better readability. jdk11u not have z gc, so this backport is not clean. > > ### Testing > - [x] Run tier1 tests on SOPHON SG2042 (release) Thanks all for the review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/36#issuecomment-2404635661 From gcao at openjdk.org Thu Oct 10 10:00:49 2024 From: gcao at openjdk.org (Gui Cao) Date: Thu, 10 Oct 2024 10:00:49 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8293566: RISC-V: Clean up push and pop registers In-Reply-To: <-xbYXR6unNiojMy4KBv9h5cPY15OJ2qmHRHBGNxmgd0=.d2c05962-d4d6-45ae-8538-f2828d4c9dc6@github.com> References: <-xbYXR6unNiojMy4KBv9h5cPY15OJ2qmHRHBGNxmgd0=.d2c05962-d4d6-45ae-8538-f2828d4c9dc6@github.com> Message-ID: <4vXA_nyb0HBGBjaXbaq_23IUwYG-wBQpDvzSt3MxGyA=.2a4dcd69-01f7-4b6c-9da6-de44a0be8850@github.com> On Tue, 8 Oct 2024 08:28:21 GMT, Gui Cao wrote: > Hi, I would like to backport [JDK-8293566](https://bugs.openjdk.org/browse/JDK-8293566) to riscv-port-jdk11u. with this patch ,it will have better readability. jdk11u not have z gc, so this backport is not clean. > > ### Testing > - [x] Run tier1 tests on SOPHON SG2042 (release) This pull request has now been integrated. Changeset: ef970d4c Author: Gui Cao URL: https://git.openjdk.org/riscv-port-jdk11u/commit/ef970d4c7267af52f8e667acb301826f228a6272 Stats: 35 lines in 4 files changed: 7 ins; 3 del; 25 mod 8293566: RISC-V: Clean up push and pop registers Reviewed-by: dzhang, fyang Backport-of: 68645ebffb28605fa2c6afef11f8265fd350b5cb ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/36 From dzhang at openjdk.org Fri Oct 11 03:31:04 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Fri, 11 Oct 2024 03:31:04 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6 Message-ID: Hi all, Please review this backport to riscv-port-jdk11u. Backport of [JDK-8294012](https://bugs.openjdk.org/browse/JDK-8294012). Applies cleanly. Testing: - Tier1 passed without new failure on lp4a (release). ------------- Commit messages: - 8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6 Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/37/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=37&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294012 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/37.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/37/head:pull/37 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/37 From dzhang at openjdk.org Fri Oct 11 03:36:17 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Fri, 11 Oct 2024 03:36:17 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294086: RISC-V: Cleanup InstructionMark usages in the backend Message-ID: Hi all, Please review this backport to riscv-port-jdk11u. Backport of [JDK-8294086](https://bugs.openjdk.org/browse/JDK-8294086). The original patch cannot be directly applied because changes of `MacroAssembler::read_polling_page` and `macroAssembler_riscv.hpp` have been modified. Testing: - Tier1 passed without new failure on lp4a (release). ------------- Commit messages: - 8294086: RISC-V: Cleanup InstructionMark usages in the backend Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/38/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=38&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294086 Stats: 11 lines in 2 files changed: 0 ins; 6 del; 5 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/38.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/38/head:pull/38 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/38 From fyang at openjdk.org Fri Oct 11 06:56:35 2024 From: fyang at openjdk.org (Fei Yang) Date: Fri, 11 Oct 2024 06:56:35 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6 In-Reply-To: References: Message-ID: On Fri, 11 Oct 2024 03:25:31 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294012](https://bugs.openjdk.org/browse/JDK-8294012). Applies cleanly. > > Testing: > - Tier1 passed without new failure on lp4a (release). Marked as reviewed by fyang (Lead). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/37#pullrequestreview-2362077933 From fyang at openjdk.org Fri Oct 11 07:00:36 2024 From: fyang at openjdk.org (Fei Yang) Date: Fri, 11 Oct 2024 07:00:36 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294086: RISC-V: Cleanup InstructionMark usages in the backend In-Reply-To: References: Message-ID: On Fri, 11 Oct 2024 03:30:15 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294086](https://bugs.openjdk.org/browse/JDK-8294086). > > The original patch cannot be directly applied because changes of `MacroAssembler::read_polling_page` and `macroAssembler_riscv.hpp` have been modified. > > Testing: > - Tier1 passed without new failure on lp4a (release). Marked as reviewed by fyang (Lead). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/38#pullrequestreview-2362083708 From gcao at openjdk.org Fri Oct 11 07:41:26 2024 From: gcao at openjdk.org (Gui Cao) Date: Fri, 11 Oct 2024 07:41:26 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6 In-Reply-To: References: Message-ID: On Fri, 11 Oct 2024 03:25:31 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294012](https://bugs.openjdk.org/browse/JDK-8294012). Applies cleanly. > > Testing: > - Tier1 passed without new failure on lp4a (release). LGTM. ------------- Marked as reviewed by gcao (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/37#pullrequestreview-2362152347 From gcao at openjdk.org Fri Oct 11 07:44:21 2024 From: gcao at openjdk.org (Gui Cao) Date: Fri, 11 Oct 2024 07:44:21 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294086: RISC-V: Cleanup InstructionMark usages in the backend In-Reply-To: References: Message-ID: <8zg57gvncbG30ELovnHRzhTjLm4NVMSUEbn1jP_uuFk=.70876c59-2160-40c9-aea9-215180b33fe3@github.com> On Fri, 11 Oct 2024 03:30:15 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294086](https://bugs.openjdk.org/browse/JDK-8294086). > > The original patch cannot be directly applied because changes of `MacroAssembler::read_polling_page` and `macroAssembler_riscv.hpp` have been modified. > > Testing: > - Tier1 passed without new failure on lp4a (release). LGTM. ------------- Marked as reviewed by gcao (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/38#pullrequestreview-2362157854 From dzhang at openjdk.org Mon Oct 14 01:02:27 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Mon, 14 Oct 2024 01:02:27 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6 In-Reply-To: References: Message-ID: <_NGrKkZ7WqU7GVgo7FHAM1CQ_KJkMU9gGyU8f0fmBDc=.89b1427e-0eae-4682-84ff-c56b826f6aef@github.com> On Fri, 11 Oct 2024 03:25:31 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294012](https://bugs.openjdk.org/browse/JDK-8294012). Applies cleanly. > > Testing: > - Tier1 passed without new failure on lp4a (release). Thanks for the review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/37#issuecomment-2409540859 From dzhang at openjdk.org Mon Oct 14 01:02:27 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Mon, 14 Oct 2024 01:02:27 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6 In-Reply-To: References: Message-ID: On Fri, 11 Oct 2024 03:25:31 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294012](https://bugs.openjdk.org/browse/JDK-8294012). Applies cleanly. > > Testing: > - Tier1 passed without new failure on lp4a (release). This pull request has now been integrated. Changeset: 9d179f49 Author: Dingli Zhang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/9d179f4937e81ed159360be69d9fb6afc6eb8880 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8294012: RISC-V: get/put_native_u8 missing the case when address&7 is 6 Reviewed-by: fyang, gcao Backport-of: 09af637a9be106a0a6b82b3638ae004d9248fc78 ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/37 From dzhang at openjdk.org Mon Oct 14 01:03:32 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Mon, 14 Oct 2024 01:03:32 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294086: RISC-V: Cleanup InstructionMark usages in the backend In-Reply-To: References: Message-ID: On Fri, 11 Oct 2024 03:30:15 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294086](https://bugs.openjdk.org/browse/JDK-8294086). > > The original patch cannot be directly applied because changes of `MacroAssembler::read_polling_page` and `macroAssembler_riscv.hpp` have been modified. > > Testing: > - Tier1 passed without new failure on lp4a (release). Thanks for the review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/38#issuecomment-2409543035 From dzhang at openjdk.org Mon Oct 14 01:03:33 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Mon, 14 Oct 2024 01:03:33 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8294086: RISC-V: Cleanup InstructionMark usages in the backend In-Reply-To: References: Message-ID: On Fri, 11 Oct 2024 03:30:15 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294086](https://bugs.openjdk.org/browse/JDK-8294086). > > The original patch cannot be directly applied because changes of `MacroAssembler::read_polling_page` and `macroAssembler_riscv.hpp` have been modified. > > Testing: > - Tier1 passed without new failure on lp4a (release). This pull request has now been integrated. Changeset: 61b686bc Author: Dingli Zhang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/61b686bcc5f269b0a6770e26be0e464d9f5cdcf6 Stats: 11 lines in 2 files changed: 0 ins; 6 del; 5 mod 8294086: RISC-V: Cleanup InstructionMark usages in the backend Reviewed-by: fyang, gcao Backport-of: d5bee4a0dffebcf3037b83fa3f7bc635dd6b1303 ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/38 From dzhang at openjdk.org Mon Oct 14 03:01:56 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Mon, 14 Oct 2024 03:01:56 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate() Message-ID: <4TvRtwZUjOsoJeMuYYsC_DrqZv4zURZep7f-1QysgQI=.d0497b68-477e-4e3c-b962-1e743c8d963d@github.com> Hi all, Please review this backport to riscv-port-jdk11u. Backport of [JDK-8294187](https://bugs.openjdk.org/browse/JDK-8294187). The original patch cannot be directly applied because jdk11 has no `C1SafepointPoll` or `C2SafepointPollStubTable`. Testing: - Tier1 passed without new failure on lp4a (release). ------------- Commit messages: - 8294187: RISC-V: Unify all relocations for the backend Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/39/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=39&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294187 Stats: 31 lines in 5 files changed: 3 ins; 18 del; 10 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/39.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/39/head:pull/39 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/39 From dzhang at openjdk.org Mon Oct 14 03:30:58 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Mon, 14 Oct 2024 03:30:58 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops Message-ID: Hi, Please help review this backport to riscv-port-jdk11u. Backport of [JDK-8294087](https://bugs.openjdk.org/browse/JDK-8294087). The original patch cannot be directly applied because of riscv-port-jdk11u do not have `emit_entry_barrier_stub ` C2CodeStub and no [JDK-8216557](https://bugs.openjdk.org/browse/JDK-8216557). Testing: - Tier1 passed without new failure on lp4a (release). ------------- Commit messages: - 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/40/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=40&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294087 Stats: 28 lines in 7 files changed: 26 ins; 0 del; 2 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/40.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/40/head:pull/40 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/40 From dzhang at openjdk.org Mon Oct 14 03:30:58 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Mon, 14 Oct 2024 03:30:58 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops In-Reply-To: References: Message-ID: <13PNb3OhjIYFj0DwOTV__f9Yw71sTL6dvmbnQxaAbmk=.e5274e36-d693-4c51-b530-884c968ec2bd@github.com> On Mon, 14 Oct 2024 03:25:45 GMT, Dingli Zhang wrote: > Hi, > Please help review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294087](https://bugs.openjdk.org/browse/JDK-8294087). > > The original patch cannot be directly applied because of riscv-port-jdk11u do not have `emit_entry_barrier_stub ` C2CodeStub and no [JDK-8216557](https://bugs.openjdk.org/browse/JDK-8216557). > > Testing: > - Tier1 passed without new failure on lp4a (release). Thanks to Gui Cao for the original patch. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/40#issuecomment-2409873237 From gcao at openjdk.org Tue Oct 15 01:06:25 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 15 Oct 2024 01:06:25 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate() In-Reply-To: <4TvRtwZUjOsoJeMuYYsC_DrqZv4zURZep7f-1QysgQI=.d0497b68-477e-4e3c-b962-1e743c8d963d@github.com> References: <4TvRtwZUjOsoJeMuYYsC_DrqZv4zURZep7f-1QysgQI=.d0497b68-477e-4e3c-b962-1e743c8d963d@github.com> Message-ID: On Mon, 14 Oct 2024 02:57:36 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294187](https://bugs.openjdk.org/browse/JDK-8294187). > > The original patch cannot be directly applied because jdk11 has no `C1SafepointPoll` or `C2SafepointPollStubTable`. > > Testing: > - Tier1 passed without new failure on lp4a (release). LGTM. ------------- Marked as reviewed by gcao (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/39#pullrequestreview-2367916482 From gcao at openjdk.org Tue Oct 15 01:12:20 2024 From: gcao at openjdk.org (Gui Cao) Date: Tue, 15 Oct 2024 01:12:20 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops In-Reply-To: References: Message-ID: On Mon, 14 Oct 2024 03:25:45 GMT, Dingli Zhang wrote: > Hi, > Please help review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294087](https://bugs.openjdk.org/browse/JDK-8294087). > > The original patch cannot be directly applied because of riscv-port-jdk11u do not have `emit_entry_barrier_stub ` C2CodeStub and no [JDK-8216557](https://bugs.openjdk.org/browse/JDK-8216557). > > Testing: > - Tier1 passed without new failure on lp4a (release). Looks good. ------------- Marked as reviewed by gcao (Committer). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/40#pullrequestreview-2367924481 From dzhang at openjdk.org Wed Oct 16 07:57:41 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 16 Oct 2024 07:57:41 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* Message-ID: Please review this backport to riscv-port-jdk11u. Backport of [JDK-8299168](https://bugs.openjdk.org/browse/JDK-8299168). Applies not cleanly due to context difference, but it is easy to resolve them manually. Testing: - [ ] Tier1 passed without new failure on unmatched (release). ------------- Commit messages: - 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/42/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=42&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8299168 Stats: 14 lines in 1 file changed: 6 ins; 0 del; 8 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/42.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/42/head:pull/42 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/42 From dzhang at openjdk.org Wed Oct 16 07:57:41 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 16 Oct 2024 07:57:41 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 07:53:11 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8299168](https://bugs.openjdk.org/browse/JDK-8299168). > Applies not cleanly due to context difference, but it is easy to resolve them manually. > > Testing: > - [ ] Tier1 passed without new failure on unmatched (release). The test is in progress and will be updated later with the results. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/42#issuecomment-2416000380 From fyang at openjdk.org Wed Oct 16 08:01:36 2024 From: fyang at openjdk.org (Fei Yang) Date: Wed, 16 Oct 2024 08:01:36 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 07:53:11 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8299168](https://bugs.openjdk.org/browse/JDK-8299168). > Applies not cleanly due to context difference, but it is easy to resolve them manually. > > Testing: > - [ ] Tier1 passed without new failure on unmatched (release). Looks good. ------------- Marked as reviewed by fyang (Lead). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/42#pullrequestreview-2371522554 From duke at openjdk.org Wed Oct 16 09:59:29 2024 From: duke at openjdk.org (Andreas Schwab) Date: Wed, 16 Oct 2024 09:59:29 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 07:53:11 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8299168](https://bugs.openjdk.org/browse/JDK-8299168). > Applies not cleanly due to context difference, but it is easy to resolve them manually. > > Testing: > - [ ] Tier1 passed without new failure on unmatched (release). /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.25-9/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp:391:5: error: 'IncompressibleRegion' was not declared in this scope; did you mean 'CompressibleRegion'? ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/42#issuecomment-2416317223 From dzhang at openjdk.org Wed Oct 16 10:11:27 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 16 Oct 2024 10:11:27 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 09:57:02 GMT, Andreas Schwab wrote: > /home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.25-9/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp:391:5: error: 'IncompressibleRegion' was not declared in this scope; did you mean 'CompressibleRegion'? Sorry for the confusion. This PR requires a [pre-patch](https://bugs.openjdk.org/browse/JDK-8294366) . We need to merge these PR in order, so please be patient. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/42#issuecomment-2416343546 From fyang at openjdk.org Wed Oct 16 12:19:29 2024 From: fyang at openjdk.org (Fei Yang) Date: Wed, 16 Oct 2024 12:19:29 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate() In-Reply-To: <4TvRtwZUjOsoJeMuYYsC_DrqZv4zURZep7f-1QysgQI=.d0497b68-477e-4e3c-b962-1e743c8d963d@github.com> References: <4TvRtwZUjOsoJeMuYYsC_DrqZv4zURZep7f-1QysgQI=.d0497b68-477e-4e3c-b962-1e743c8d963d@github.com> Message-ID: On Mon, 14 Oct 2024 02:57:36 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294187](https://bugs.openjdk.org/browse/JDK-8294187). > > The original patch cannot be directly applied because jdk11 has no `C1SafepointPoll` or `C2SafepointPollStubTable`. > > Testing: > - Tier1 passed without new failure on lp4a (release). Marked as reviewed by fyang (Lead). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/39#pullrequestreview-2372272506 From fyang at openjdk.org Wed Oct 16 12:19:29 2024 From: fyang at openjdk.org (Fei Yang) Date: Wed, 16 Oct 2024 12:19:29 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops In-Reply-To: References: Message-ID: On Mon, 14 Oct 2024 03:25:45 GMT, Dingli Zhang wrote: > Hi, > Please help review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294087](https://bugs.openjdk.org/browse/JDK-8294087). > > The original patch cannot be directly applied because of riscv-port-jdk11u do not have `emit_entry_barrier_stub ` C2CodeStub and no [JDK-8216557](https://bugs.openjdk.org/browse/JDK-8216557). > > Testing: > - Tier1 passed without new failure on lp4a (release). Marked as reviewed by fyang (Lead). ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/40#pullrequestreview-2372273279 From dzhang at openjdk.org Wed Oct 16 14:07:39 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 16 Oct 2024 14:07:39 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate() In-Reply-To: <4TvRtwZUjOsoJeMuYYsC_DrqZv4zURZep7f-1QysgQI=.d0497b68-477e-4e3c-b962-1e743c8d963d@github.com> References: <4TvRtwZUjOsoJeMuYYsC_DrqZv4zURZep7f-1QysgQI=.d0497b68-477e-4e3c-b962-1e743c8d963d@github.com> Message-ID: On Mon, 14 Oct 2024 02:57:36 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294187](https://bugs.openjdk.org/browse/JDK-8294187). > > The original patch cannot be directly applied because jdk11 has no `C1SafepointPoll` or `C2SafepointPollStubTable`. > > Testing: > - Tier1 passed without new failure on lp4a (release). Thanks for the review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/39#issuecomment-2416945637 From dzhang at openjdk.org Wed Oct 16 14:07:40 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 16 Oct 2024 14:07:40 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate() In-Reply-To: <4TvRtwZUjOsoJeMuYYsC_DrqZv4zURZep7f-1QysgQI=.d0497b68-477e-4e3c-b962-1e743c8d963d@github.com> References: <4TvRtwZUjOsoJeMuYYsC_DrqZv4zURZep7f-1QysgQI=.d0497b68-477e-4e3c-b962-1e743c8d963d@github.com> Message-ID: <7Vw5LqaHmaGqScG2PTu3gAVdkJ5FVPikH8yHlmFdf5M=.5d171174-9881-4f41-8c91-e7a84ae00a1d@github.com> On Mon, 14 Oct 2024 02:57:36 GMT, Dingli Zhang wrote: > Hi all, > > Please review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294187](https://bugs.openjdk.org/browse/JDK-8294187). > > The original patch cannot be directly applied because jdk11 has no `C1SafepointPoll` or `C2SafepointPollStubTable`. > > Testing: > - Tier1 passed without new failure on lp4a (release). This pull request has now been integrated. Changeset: 3deebd8c Author: Dingli Zhang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/3deebd8c5d2a1f27f584e0d1a7a51a90883c5e38 Stats: 31 lines in 5 files changed: 3 ins; 18 del; 10 mod 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate() Reviewed-by: gcao, fyang Backport-of: 664e5b1d2e91107a3bae5b4b95d5724cf241a55f ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/39 From dzhang at openjdk.org Wed Oct 16 14:08:29 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 16 Oct 2024 14:08:29 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops In-Reply-To: References: Message-ID: On Mon, 14 Oct 2024 03:25:45 GMT, Dingli Zhang wrote: > Hi, > Please help review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294087](https://bugs.openjdk.org/browse/JDK-8294087). > > The original patch cannot be directly applied because of riscv-port-jdk11u do not have `emit_entry_barrier_stub ` C2CodeStub and no [JDK-8216557](https://bugs.openjdk.org/browse/JDK-8216557). > > Testing: > - Tier1 passed without new failure on lp4a (release). Thanks for the review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/40#issuecomment-2416948854 From dzhang at openjdk.org Wed Oct 16 14:08:29 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 16 Oct 2024 14:08:29 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops In-Reply-To: References: Message-ID: On Mon, 14 Oct 2024 03:25:45 GMT, Dingli Zhang wrote: > Hi, > Please help review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294087](https://bugs.openjdk.org/browse/JDK-8294087). > > The original patch cannot be directly applied because of riscv-port-jdk11u do not have `emit_entry_barrier_stub ` C2CodeStub and no [JDK-8216557](https://bugs.openjdk.org/browse/JDK-8216557). > > Testing: > - Tier1 passed without new failure on lp4a (release). This pull request has now been integrated. Changeset: 2bdf5d2f Author: Dingli Zhang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/2bdf5d2f8823cc0cbe16a329e54f2546c3fd90d3 Stats: 28 lines in 7 files changed: 26 ins; 0 del; 2 mod 8294087: RISC-V: RVC: Fix a potential alignment issue and add more alignment assertions for the patchable calls/nops Co-authored-by: Gui Cao Reviewed-by: gcao, fyang Backport-of: a216960d71bdf111a9c232a0228cc43256a01b29 ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/40 From dzhang at openjdk.org Wed Oct 16 14:15:00 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 16 Oct 2024 14:15:00 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294366: RISC-V: Partially mark out incompressible regions Message-ID: Hi, Please help review this backport to riscv-port-jdk11u. Backport of [JDK-8294366](https://bugs.openjdk.org/browse/JDK-8294366). The original patch cannot be directly applied because of riscv-port-jdk11u do not have `BarrierSetAssembler::nmethod_entry_barrier`, [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8223173) or [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8293007). Testing: - Tier1 passed without new failure on lp4a (release). ------------- Commit messages: - 8294366: RISC-V: Partially mark out incompressible regions Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/43/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=43&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294366 Stats: 107 lines in 6 files changed: 46 ins; 36 del; 25 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/43.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/43/head:pull/43 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/43 From fyang at openjdk.org Thu Oct 17 02:19:26 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 17 Oct 2024 02:19:26 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294366: RISC-V: Partially mark out incompressible regions In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 14:08:57 GMT, Dingli Zhang wrote: > Hi, > Please help review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294366](https://bugs.openjdk.org/browse/JDK-8294366). > > The original patch cannot be directly applied because of riscv-port-jdk11u do not have `BarrierSetAssembler::nmethod_entry_barrier`, [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8223173) or [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8293007). > > Testing: > - Tier1 passed without new failure on lp4a (release). Changes requested by fyang (Lead). src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.cpp line 324: > 322: // must ensure that this first instruction is a J, JAL or NOP. > 323: // Make it a NOP. > 324: IncompressibleRegion ir(this); // keep the nop as 4 bytes for patching. I think you should move the `assert_alignment(pc())` in `C1_MacroAssembler::verified_entry` here before this nop. Seens that assertion was miss-placed by previous backport PR: https://github.com/openjdk/riscv-port-jdk11u/pull/40 ------------- PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/43#pullrequestreview-2373997065 PR Review Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/43#discussion_r1804011301 From dzhang at openjdk.org Thu Oct 17 02:38:59 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 17 Oct 2024 02:38:59 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294366: RISC-V: Partially mark out incompressible regions [v2] In-Reply-To: References: Message-ID: > Hi, > Please help review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294366](https://bugs.openjdk.org/browse/JDK-8294366). > > The original patch cannot be directly applied because of riscv-port-jdk11u do not have `BarrierSetAssembler::nmethod_entry_barrier`, [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8223173) or [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8293007). > > Testing: > - Tier1 passed without new failure on lp4a (release). Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: fix build_frame ------------- Changes: - all: https://git.openjdk.org/riscv-port-jdk11u/pull/43/files - new: https://git.openjdk.org/riscv-port-jdk11u/pull/43/files/a8545465..aa06797e Webrevs: - full: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=43&range=01 - incr: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=43&range=00-01 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/43.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/43/head:pull/43 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/43 From dzhang at openjdk.org Thu Oct 17 02:45:28 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 17 Oct 2024 02:45:28 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294366: RISC-V: Partially mark out incompressible regions [v2] In-Reply-To: References: Message-ID: On Thu, 17 Oct 2024 02:11:06 GMT, Fei Yang wrote: >> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: >> >> fix build_frame > > src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.cpp line 324: > >> 322: // must ensure that this first instruction is a J, JAL or NOP. >> 323: // Make it a NOP. >> 324: IncompressibleRegion ir(this); // keep the nop as 4 bytes for patching. > > I think you should move the `assert_alignment(pc())` in `C1_MacroAssembler::verified_entry` here before this nop. Seens that assertion was miss-placed by previous backport PR: https://github.com/openjdk/riscv-port-jdk11u/pull/40 Thanks for the review, fixed. ------------- PR Review Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/43#discussion_r1804028804 From duke at openjdk.org Thu Oct 17 02:46:25 2024 From: duke at openjdk.org (duke) Date: Thu, 17 Oct 2024 02:46:25 GMT Subject: git: openjdk/riscv-port-jdk11u: riscv-port: 17 new changesets Message-ID: <8f8f45e3-ef05-45f4-a432-92a9c93cb5ab@openjdk.org> Changeset: 13932713 Branch: riscv-port Author: Sergey Bylokhov Date: 2024-10-07 06:13:44 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/1393271305edc4d7bd1d9a5dcb2c011c93f4fd49 8251188: Update LDAP tests not to use wildcard addresses Reviewed-by: mbalao, andrew Backport-of: a75edc29c6ce41116cc99530aa1710efb62c6d5a ! test/jdk/ProblemList.txt ! test/jdk/com/sun/jndi/ldap/BalancedParentheses.java ! test/jdk/com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java + test/jdk/com/sun/jndi/ldap/DeadSSLSocketFactory.java ! test/jdk/com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java ! test/jdk/com/sun/jndi/ldap/lib/LDAPTestUtils.java Changeset: 240b2962 Branch: riscv-port Author: Alexey Bakhtin Committer: Christoph Langer Date: 2024-09-30 17:18:02 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/240b2962343493f824b5595432ae6cdd959666f0 8307383: Enhance DTLS connections Reviewed-by: mbaesken, andrew Backport-of: 362dbbaa952b3d4a5270c6bfae879a12e9bdf4d1 ! src/java.base/share/classes/sun/security/ssl/ClientHello.java ! src/java.base/share/classes/sun/security/ssl/DTLSInputRecord.java ! src/java.base/share/classes/sun/security/ssl/ServerHandshakeContext.java ! src/java.base/share/classes/sun/security/ssl/TransportContext.java ! test/jdk/javax/net/ssl/DTLS/InvalidRecords.java ! test/jdk/javax/net/ssl/TLSCommon/MFLNTest.java Changeset: 445e79ea Branch: riscv-port Author: Alexey Bakhtin Committer: Christoph Langer Date: 2024-09-27 15:25:46 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/445e79ea99250a77ca38223710ca7e7fef0b6309 8263031: HttpClient throws Exception if it receives a Push Promise that is too large Reviewed-by: mbalao Backport-of: 4d2cd26ab5092ad0a169e4239164a869a4255bd3 ! src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java + test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java ! test/jdk/java/net/httpclient/http2/server/Http2TestExchangeImpl.java ! test/jdk/java/net/httpclient/http2/server/Http2TestServerConnection.java Changeset: fe9c9c70 Branch: riscv-port Author: Alexey Bakhtin Committer: Christoph Langer Date: 2024-09-27 16:45:17 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/fe9c9c707b5555d24cb0ec4b2952aa5b056626b9 8303965: java.net.http.HttpClient should reset the stream if response headers contain malformed header fields Reviewed-by: mbalao Backport-of: 466ffebcae1ee5817a83fdbc33f5ec3bd6de7e60 ! src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java ! src/java.net.http/share/classes/jdk/internal/net/http/Stream.java + src/java.net.http/share/classes/jdk/internal/net/http/common/HeaderDecoder.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/Utils.java + src/java.net.http/share/classes/jdk/internal/net/http/common/ValidatingHeadersConsumer.java ! test/jdk/java/net/httpclient/http2/BadHeadersTest.java Changeset: 68c131d5 Branch: riscv-port Author: Alexey Bakhtin Committer: Christoph Langer Date: 2024-09-27 21:03:17 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/68c131d590ef20394d12f0a88a9bf4a1c0bea5ed 8284585: PushPromiseContinuation test fails intermittently in timeout Reviewed-by: mbalao Backport-of: 65da38d844760f7d17a143f8b4d5e25ea0144e27 ! src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java ! test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java ! test/jdk/java/net/httpclient/http2/server/Http2TestServerConnection.java ! test/jdk/java/net/httpclient/http2/server/OutgoingPushPromise.java Changeset: 2d393d8b Branch: riscv-port Author: Alexey Bakhtin Committer: Christoph Langer Date: 2024-09-28 17:03:16 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/2d393d8bb49ada5096799a059651b83de95658eb 8328286: Enhance HTTP client Reviewed-by: mbalao Backport-of: cf8dc79f392c8ec3414d8b36803f026852c4e386 ! src/java.base/share/classes/java/net/doc-files/net-properties.html ! src/java.base/share/classes/sun/net/www/MessageHeader.java ! src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/java.base/share/conf/net.properties ! src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http1HeaderParser.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java ! src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/HttpRequestImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/ResponseBodyHandlers.java ! src/java.net.http/share/classes/jdk/internal/net/http/Stream.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/HeaderDecoder.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/Utils.java ! src/java.net.http/share/classes/jdk/internal/net/http/hpack/Decoder.java ! src/java.net.http/share/classes/jdk/internal/net/http/hpack/DecodingCallback.java ! src/java.net.http/share/classes/jdk/internal/net/http/hpack/Encoder.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/Request.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/ServerConfig.java ! test/jdk/java/net/httpclient/HttpServerAdapters.java ! test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java + test/jdk/java/net/httpclient/http2/server/HpackTestEncoder.java ! test/jdk/java/net/httpclient/http2/server/Http2TestExchange.java ! test/jdk/java/net/httpclient/http2/server/Http2TestExchangeImpl.java ! test/jdk/java/net/httpclient/http2/server/Http2TestServerConnection.java Changeset: 6ae4b326 Branch: riscv-port Author: Martin Balao Committer: Christoph Langer Date: 2024-08-14 21:12:00 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/6ae4b326fa910fb6446ff77821389748e0021c8c 8328544: Improve handling of vectorization Reviewed-by: roland, yan Backport-of: b5174c9159fbffdf335ee6835267ba0e674cf432 ! src/hotspot/share/opto/superword.cpp ! src/hotspot/share/opto/superword.hpp Changeset: d73c162a Branch: riscv-port Author: Martin Balao Committer: Christoph Langer Date: 2024-09-14 00:31:00 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/d73c162a858890d4f4b8f0881f18f79ab610352c 8335713: Enhance vectorization analysis Reviewed-by: roland Backport-of: 3c05ad2290936ec9abc3f271cb6bf89e18c3eea7 ! src/hotspot/share/opto/superword.cpp ! src/hotspot/share/opto/superword.hpp Changeset: 51657d99 Branch: riscv-port Author: Alexey Bakhtin Committer: Christoph Langer Date: 2024-05-10 14:23:56 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/51657d990a40aed8f197bad24160765dde0a1f82 8328726: Better Kerberos support Reviewed-by: mbalao Backport-of: 7325899a11f17bf4516d39495a12796385e459ed ! src/java.security.jgss/share/classes/javax/security/auth/kerberos/EncryptionKey.java ! src/java.security.jgss/share/classes/javax/security/auth/kerberos/KerberosCredMessage.java ! src/java.security.jgss/share/classes/javax/security/auth/kerberos/KerberosKey.java ! src/java.security.jgss/share/classes/javax/security/auth/kerberos/KeyImpl.java ! src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Context.java ! src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Util.java ! src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/Krb5.java ! src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Kinit.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_PBE_PARAMS.java ! src/jdk.security.auth/share/classes/com/sun/security/auth/module/Krb5LoginModule.java Changeset: 56ded02f Branch: riscv-port Author: Alexei Voitylov Committer: Christoph Langer Date: 2024-08-13 10:30:49 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/56ded02fd8bcc61399b3ca5091d6e597759fb30e 8331446: Improve deserialization support Reviewed-by: yan, mbalao, andrew Backport-of: 8e4a392832f83e16d521024505b52c96d0a993f2 ! src/java.base/share/classes/java/text/MessageFormat.java + test/jdk/java/text/Format/MessageFormat/MaxArgumentIndexTest.java + test/jdk/java/text/Format/MessageFormat/SerializationTest.java Changeset: bd85b872 Branch: riscv-port Author: Sergey Bylokhov Committer: Christoph Langer Date: 2018-10-09 11:44:00 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/bd85b8729d9c7ffb31c57f328f35f4391b7d72fe 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java Reviewed-by: yan, andrew Backport-of: e61252dc278fd44345c5377811552ed6760ffcf0 ! test/jdk/javax/naming/module/RunBasic.java ! test/jdk/javax/naming/module/src/test/test/ConnectWithAuthzId.java ! test/jdk/javax/naming/module/src/test/test/ConnectWithFoo.java ! test/jdk/javax/naming/module/src/test/test/ReadByUrl.java ! test/jdk/javax/naming/module/src/test/test/StoreFruit.java ! test/jdk/javax/naming/module/src/test/test/StoreObject.java ! test/jdk/javax/naming/module/src/test/test/StorePerson.java ! test/jdk/javax/naming/module/src/test/test/StoreRemote.java Changeset: eb960ff6 Branch: riscv-port Author: Sergey Bylokhov Committer: Christoph Langer Date: 2020-09-25 12:46:08 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/eb960ff6d44af11a38f88a20db68218343725c7b 8251188: Update LDAP tests not to use wildcard addresses Reviewed-by: mbalao, andrew Backport-of: a75edc29c6ce41116cc99530aa1710efb62c6d5a ! test/jdk/ProblemList.txt ! test/jdk/com/sun/jndi/ldap/BalancedParentheses.java ! test/jdk/com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java + test/jdk/com/sun/jndi/ldap/DeadSSLSocketFactory.java ! test/jdk/com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java ! test/jdk/com/sun/jndi/ldap/lib/LDAPTestUtils.java Changeset: 34a77a47 Branch: riscv-port Author: Sergey Bylokhov Committer: Christoph Langer Date: 2022-09-16 10:04:51 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/34a77a471b260f3b6f65c6cc61609d51eeade193 8290367: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property 8332643: Better Location requests Reviewed-by: yan, andrew Backport-of: 7765942aeee25cbeb5fd932a93b3d8f9d4ca3655 ! src/java.naming/share/classes/com/sun/jndi/ldap/Obj.java ! src/java.naming/share/classes/com/sun/jndi/ldap/VersionHelper.java + test/jdk/com/sun/jndi/ldap/objects/RemoteLocationAttributeTest.java + test/jdk/com/sun/jndi/ldap/objects/RemoteLocationAttributeTest.ldap ! test/jdk/javax/naming/module/RunBasic.java ! test/jdk/javax/naming/module/src/test/test/ConnectWithAuthzId.java ! test/jdk/javax/naming/module/src/test/test/ConnectWithFoo.java ! test/jdk/javax/naming/module/src/test/test/ReadByUrl.java ! test/jdk/javax/naming/module/src/test/test/StoreFruit.java ! test/jdk/javax/naming/module/src/test/test/StoreObject.java ! test/jdk/javax/naming/module/src/test/test/StorePerson.java ! test/jdk/javax/naming/module/src/test/test/StoreRemote.java Changeset: 86d5188b Branch: riscv-port Author: Francisco Ferrari Bihurriet Committer: Christoph Langer Date: 2024-09-17 18:45:20 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/86d5188b8939c05abc2340c4c389c5fca640c485 8332644: Improve graph optimizations Reviewed-by: mbalao, andrew Backport-of: 7c16d649a8118d2e7ee77cedba87e620c83294b4 ! src/hotspot/share/opto/loopnode.cpp Changeset: cee8535a Branch: riscv-port Author: Andrew John Hughes Committer: Christoph Langer Date: 2024-10-07 20:28:48 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/cee8535a9d3de8558b4b5028d68e397e508bef71 8341675: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.25 Reviewed-by: clanger ! make/autoconf/version-numbers Changeset: 8ba03417 Branch: riscv-port Author: Goetz Lindenmaier Date: 2024-10-16 11:34:10 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/8ba0341757545856666fbfcd3e7f9d715f5c0f86 Merge ! test/jdk/javax/naming/module/RunBasic.java ! test/jdk/javax/naming/module/RunBasic.java Changeset: 9a579a0d Branch: riscv-port Author: Fei Yang Date: 2024-10-17 10:42:38 +0000 URL: https://git.openjdk.org/riscv-port-jdk11u/commit/9a579a0d4e29e741e3af4aa5adb7624b3992cbce Merge branch 'master' into riscv-port From fyang at openjdk.org Thu Oct 17 03:24:32 2024 From: fyang at openjdk.org (Fei Yang) Date: Thu, 17 Oct 2024 03:24:32 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294366: RISC-V: Partially mark out incompressible regions [v2] In-Reply-To: References: Message-ID: On Thu, 17 Oct 2024 02:38:59 GMT, Dingli Zhang wrote: >> Hi, >> Please help review this backport to riscv-port-jdk11u. >> >> Backport of [JDK-8294366](https://bugs.openjdk.org/browse/JDK-8294366). >> >> The original patch cannot be directly applied because of riscv-port-jdk11u do not have `BarrierSetAssembler::nmethod_entry_barrier`, [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8223173) or [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8293007). >> >> Testing: >> - Tier1 passed without new failure on lp4a (release). > > Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: > > fix build_frame Looks good. ------------- Marked as reviewed by fyang (Lead). PR Review: https://git.openjdk.org/riscv-port-jdk11u/pull/43#pullrequestreview-2374066433 From duke at openjdk.org Thu Oct 17 08:09:38 2024 From: duke at openjdk.org (Andreas Schwab) Date: Thu, 17 Oct 2024 08:09:38 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 07:53:11 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8299168](https://bugs.openjdk.org/browse/JDK-8299168). > Applies not cleanly due to context difference, but it is easy to resolve them manually. > > Testing: > - [ ] Tier1 passed without new failure on unmatched (release). Thanks, I can confirm that this together with refs/pull/43/head fixes the issue. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/42#issuecomment-2418853110 From dzhang at openjdk.org Thu Oct 17 12:32:34 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 17 Oct 2024 12:32:34 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294366: RISC-V: Partially mark out incompressible regions [v2] In-Reply-To: References: Message-ID: On Thu, 17 Oct 2024 02:38:59 GMT, Dingli Zhang wrote: >> Hi, >> Please help review this backport to riscv-port-jdk11u. >> >> Backport of [JDK-8294366](https://bugs.openjdk.org/browse/JDK-8294366). >> >> The original patch cannot be directly applied because of riscv-port-jdk11u do not have `BarrierSetAssembler::nmethod_entry_barrier`, [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8223173) or [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8293007). >> >> Testing: >> - Tier1 passed without new failure on lp4a (release). > > Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: > > fix build_frame Thanks for the review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/43#issuecomment-2419407906 From dzhang at openjdk.org Thu Oct 17 12:32:34 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 17 Oct 2024 12:32:34 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8294366: RISC-V: Partially mark out incompressible regions In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 14:08:57 GMT, Dingli Zhang wrote: > Hi, > Please help review this backport to riscv-port-jdk11u. > > Backport of [JDK-8294366](https://bugs.openjdk.org/browse/JDK-8294366). > > The original patch cannot be directly applied because of riscv-port-jdk11u do not have `BarrierSetAssembler::nmethod_entry_barrier`, [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8223173) or [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8293007). > > Testing: > - Tier1 passed without new failure on lp4a (release). This pull request has now been integrated. Changeset: f0b567de Author: Dingli Zhang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/f0b567dec6ae2539ee6e9999f98c646b4b7f0eca Stats: 109 lines in 6 files changed: 47 ins; 37 del; 25 mod 8294366: RISC-V: Partially mark out incompressible regions Reviewed-by: fyang Backport-of: 542cc602a7f023d3351133a321c4fa57249b8765 ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/43 From dzhang at openjdk.org Thu Oct 17 12:36:30 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 17 Oct 2024 12:36:30 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* [v2] In-Reply-To: References: Message-ID: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8299168](https://bugs.openjdk.org/browse/JDK-8299168). > Applies not cleanly due to context difference, but it is easy to resolve them manually. > > Testing: > - [ ] Tier1 passed without new failure on unmatched (release). Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* ------------- Changes: https://git.openjdk.org/riscv-port-jdk11u/pull/42/files Webrev: https://webrevs.openjdk.org/?repo=riscv-port-jdk11u&pr=42&range=01 Stats: 14 lines in 1 file changed: 6 ins; 0 del; 8 mod Patch: https://git.openjdk.org/riscv-port-jdk11u/pull/42.diff Fetch: git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/42/head:pull/42 PR: https://git.openjdk.org/riscv-port-jdk11u/pull/42 From dzhang at openjdk.org Thu Oct 17 14:00:33 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 17 Oct 2024 14:00:33 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* [v2] In-Reply-To: References: Message-ID: On Thu, 17 Oct 2024 12:36:30 GMT, Dingli Zhang wrote: >> Please review this backport to riscv-port-jdk11u. >> Backport of [JDK-8299168](https://bugs.openjdk.org/browse/JDK-8299168). >> Applies not cleanly due to context difference, but it is easy to resolve them manually. >> >> Testing: >> - [x] Tier1 passed without new failure on lp4a (release). >> - [x] Tier1 hotspot passed without new failure on lp4a (fastdebug). > > Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* Thanks for the review. ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/42#issuecomment-2419626227 From dzhang at openjdk.org Thu Oct 17 14:00:33 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 17 Oct 2024 14:00:33 GMT Subject: [riscv-port-jdk11u:riscv-port] Integrated: 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 07:53:11 GMT, Dingli Zhang wrote: > Please review this backport to riscv-port-jdk11u. > Backport of [JDK-8299168](https://bugs.openjdk.org/browse/JDK-8299168). > Applies not cleanly due to context difference, but it is easy to resolve them manually. > > Testing: > - [x] Tier1 passed without new failure on lp4a (release). > - [x] Tier1 hotspot passed without new failure on lp4a (fastdebug). This pull request has now been integrated. Changeset: ccbb6637 Author: Dingli Zhang URL: https://git.openjdk.org/riscv-port-jdk11u/commit/ccbb6637735a7abc161d9b66635e9e6185d851af Stats: 14 lines in 1 file changed: 6 ins; 0 del; 8 mod 8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* Reviewed-by: fyang Backport-of: 2f4098e1dc9c97e706d70008e473f9c4496cbc8a ------------- PR: https://git.openjdk.org/riscv-port-jdk11u/pull/42 From duke at openjdk.org Fri Oct 18 19:14:27 2024 From: duke at openjdk.org (Andreas Schwab) Date: Fri, 18 Oct 2024 19:14:27 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294366: RISC-V: Partially mark out incompressible regions [v2] In-Reply-To: References: Message-ID: On Thu, 17 Oct 2024 02:38:59 GMT, Dingli Zhang wrote: >> Hi, >> Please help review this backport to riscv-port-jdk11u. >> >> Backport of [JDK-8294366](https://bugs.openjdk.org/browse/JDK-8294366). >> >> The original patch cannot be directly applied because of riscv-port-jdk11u do not have `BarrierSetAssembler::nmethod_entry_barrier`, [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8223173) or [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8293007). >> >> Testing: >> - Tier1 passed without new failure on lp4a (release). > > Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: > > fix build_frame Unfortunately this is not enough, I'm still getting "assert(false) failed: wrong size of mach node" 13894 Epilog === [[]] [-2147459160] # pop frame 160 add sp, sp, #160 ld ra, [sp,#-16] ld fp, [sp,#-8] # touch polling page li t0, #0x7f6e12e29000 ld zr, [t0] n_size (272), current_offset (4620), instr_offset (4340) ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/43#issuecomment-2423081696 From dzhang at openjdk.org Sat Oct 19 01:17:44 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Sat, 19 Oct 2024 01:17:44 GMT Subject: [riscv-port-jdk11u:riscv-port] RFR: 8294366: RISC-V: Partially mark out incompressible regions [v2] In-Reply-To: References: Message-ID: On Thu, 17 Oct 2024 02:38:59 GMT, Dingli Zhang wrote: >> Hi, >> Please help review this backport to riscv-port-jdk11u. >> >> Backport of [JDK-8294366](https://bugs.openjdk.org/browse/JDK-8294366). >> >> The original patch cannot be directly applied because of riscv-port-jdk11u do not have `BarrierSetAssembler::nmethod_entry_barrier`, [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8223173) or [JDK-8223173](https://bugs.openjdk.org/browse/JDK-8293007). >> >> Testing: >> - Tier1 passed without new failure on lp4a (release). > > Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: > > fix build_frame https://github.com/openjdk/riscv-port-jdk11u/commit/309291f166821443393818beed364de6f2de5c52 > Unfortunately this is not enough, I'm still getting "assert(false) failed: wrong size of mach node" > > 13894 Epilog === [[]] [-2147459160] > > # pop frame 160 > ``` > add sp, sp, #160 > ld ra, [sp,#-16] > ld fp, [sp,#-8] > # touch polling page > li t0, #0x7f6e12e29000 > ld zr, [t0] n_size (272), current_offset (4620), instr_offset (4340) > ``` We have a couple more RVC patches related to the changes here, so please wait for those to be merged in before trying again, thanks! ------------- PR Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/43#issuecomment-2423423350