[riscv-port-jdk11u:riscv-port] RFR: 8294366: RISC-V: Partially mark out incompressible regions [v2]

[Dingli Zhang]

On Thu, 17 Oct 2024 02:11:06 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix build_frame
>
> src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.cpp line 324:
> 
>> 322:   // must ensure that this first instruction is a J, JAL or NOP.
>> 323:   // Make it a NOP.
>> 324:   IncompressibleRegion ir(this);  // keep the nop as 4 bytes for patching.
> 
> I think you should move the `assert_alignment(pc())` in `C1_MacroAssembler::verified_entry` here before this nop. Seens that assertion was miss-placed by previous backport PR: https://github.com/openjdk/riscv-port-jdk11u/pull/40

Thanks for the review, fixed.

-------------

PR Review Comment: https://git.openjdk.org/riscv-port-jdk11u/pull/43#discussion_r1804028804