<div dir="ltr">Hi,<div><br></div><div>> As pointed out in the mail you cited below, not breaking<br>> existing code is the major concern of such a backport in<br>> the view of the maintainers. <br><br>> Shared changes should be kept to a minimum.<br>> Especially in 11, only enabling shared changes are<br>> eligible, not changes that aim to improve the performance.<br></div><div><br></div><div>Thank you for the clarification, that makes a lot of sense, especially the focus on not breaking users of other platforms.</div><div><br></div><div>> It would be great to see a complete list of<br>> changes that need to be backported.<br></div><div><br></div><div>Let's make sure we can bake the backports in a dedicated repository so that we can have a better sense on what the changes would entail.</div><div><br></div><div>After reaching to skara-dev, the only thing needed to create these repositories is for the riscv-project to contact ops at openjdk dot org. @Fei Yang, I am assuming you'd need to contact them being the riscv-port lead.<br></div><div><br></div><div>Thank you,</div><div>Ludovic</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 17, 2023 at 4:06 PM Lindenmaier, Goetz <<a href="mailto:goetz.lindenmaier@sap.com" target="_blank">goetz.lindenmaier@sap.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
As pointed out in the mail you cited below, not breaking <br>
existing code is the major concern of such a backport in <br>
the view of the maintainers. <br>
<br>
Shared changes should be kept to a minimum.<br>
Especially in 11, only enabling shared changes are<br>
eligible, not changes that aim to improve the performance.<br>
<br>
It would be great to see a complete list of <br>
changes that need to be backported. These should <br>
make up a functioning port. A project repo can serve<br>
the purpose to collect these changes and prove<br>
they are a complete set.<br>
We can then look at this list of changes and give a <br>
basic ok for these to be integrated in 17u/11u. Then<br>
you can run the normal backport process for them.<br>
<br>
Best regards, <br>
Goetz.<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
> -----Original Message-----<br>
> From: jdk-updates-dev <<a href="mailto:jdk-updates-dev-retn@openjdk.org" target="_blank">jdk-updates-dev-retn@openjdk.org</a>> On Behalf Of<br>
> <a href="mailto:yangfei@iscas.ac.cn" target="_blank">yangfei@iscas.ac.cn</a><br>
> Sent: Tuesday, January 17, 2023 9:23 AM<br>
> To: Ludovic Henry <<a href="mailto:ludovic@rivosinc.com" target="_blank">ludovic@rivosinc.com</a>><br>
> Cc: 章翔 <<a href="mailto:zhangxiang@iscas.ac.cn" target="_blank">zhangxiang@iscas.ac.cn</a>>; <a href="mailto:riscv-port-dev@openjdk.org" target="_blank">riscv-port-dev@openjdk.org</a>;<br>
> <a href="mailto:yadonn.wang@huawei.com" target="_blank">yadonn.wang@huawei.com</a>; <a href="mailto:jdk-updates-dev@openjdk.java.net" target="_blank">jdk-updates-dev@openjdk.java.net</a><br>
> Subject: Re: Re: Re: Backports to jdk11u and jdk17u<br>
> <br>
> [Some people who received this message don't often get email from<br>
> <a href="mailto:yangfei@iscas.ac.cn" target="_blank">yangfei@iscas.ac.cn</a>. Learn why this is important at<br>
> <a href="https://aka.ms/LearnAboutSenderIdentification" rel="noreferrer" target="_blank">https://aka.ms/LearnAboutSenderIdentification</a> ]<br>
> <br>
> Hi,<br>
> <br>
> -----Original Messages-----<br>
> From:"Ludovic Henry" <<a href="mailto:ludovic@rivosinc.com" target="_blank">ludovic@rivosinc.com</a>><br>
> Sent Time:2023-01-16 23:36:33 (Monday)<br>
> To: "章翔" <<a href="mailto:zhangxiang@iscas.ac.cn" target="_blank">zhangxiang@iscas.ac.cn</a>><br>
> Cc: <a href="mailto:yangfei@iscas.ac.cn" target="_blank">yangfei@iscas.ac.cn</a>, <a href="mailto:riscv-port-dev@openjdk.org" target="_blank">riscv-port-dev@openjdk.org</a>,<br>
> <a href="mailto:yadonn.wang@huawei.com" target="_blank">yadonn.wang@huawei.com</a>, <a href="mailto:jdk-updates-dev@openjdk.java.net" target="_blank">jdk-updates-dev@openjdk.java.net</a><br>
> Subject: Re: Re: Backports to jdk11u and jdk17u<br>
> <br>
> >> However there is one big difference between general jdk17u and<br>
> riscv secific one: while jdk17u accepts only bug fixes and minor perf<br>
> improvements, the riscv-port-jdk17u will have to accept larger patches: as<br>
> risc-v port is far from being perfect so far, performance-wise is worse than<br>
> arm64 port.<br>
> > I expect to initiate the backport in a dedicated openjdk/riscv-port-<br>
> jdk17u repository for exactly that. Until the riscv port is considered very<br>
> stable and performant, we likely want to keep it in a separate repository.<br>
> When stable, we can work with the relevant maintainers of jdk8u, jdk11u<br>
> and jdk17u for possible integrations.<br>
> <br>
> That sounds reasonable to me as we are able to find more time to look at the<br>
> jvm performance issues on RISCV now.<br>
> <br>
> > > In fact, there were some discussions before on the list about the<br>
> backporting work [1].<br>
> ><br>
> > I missed this one, thanks for pointing it out.<br>
> ><br>
> > > I'm Xiang Zhang from the Institute of Software, Chinese Academy<br>
> of Sciences. I'm backporting jdk8u for RISC-V support. Here is my<br>
> development repository:<br>
> >> <a href="https://github.com/zhangxiang-plct/jdk8u" rel="noreferrer" target="_blank">https://github.com/zhangxiang-plct/jdk8u</a><br>
> > If there is a riscv-port-jdk8u project, would you be interested to<br>
> contribute there directly?<br>
> ><br>
> > In the meantime, I'll contact skara-dev to figure out what it would take<br>
> to create the riscv-port-jdk11u and riscv-port-jdk17u repositories.<br>
> <br>
> Besides the repositories needed, I also wonder the correct workflow for<br>
> future reviewing & merging of backporting PRs on those repos.<br>
> I would like to hear comments/suggestions from the jdk update maintainers.<br>
> <br>
> Thanks,<br>
> Fei </<a href="mailto:zhangxiang@iscas.ac.cn" target="_blank">zhangxiang@iscas.ac.cn</a>></<a href="mailto:ludovic@rivosinc.com" target="_blank">ludovic@rivosinc.com</a>><br>
</blockquote></div>