From mikael.vidstedt at oracle.com Tue Nov 6 21:00:51 2018 From: mikael.vidstedt at oracle.com (Mikael Vidstedt) Date: Tue, 6 Nov 2018 13:00:51 -0800 Subject: RFR(S): 8213436: Obsolete UseMembar Message-ID: <0747F464-31EC-4C84-B1EE-B045315A4611@oracle.com> Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead. bug: https://bugs.openjdk.java.net/browse/JDK-8213436 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/ * Background (from jbs) The UseMembar flag was deprecated in JDK 10, and is default true/enabled on all platforms since that same release. It should be obsoleted and the then dead serialization page functionality it controls should be removed. * Testing tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn?t hurt. (Unrelated to this change: It would be really nice to clean up some of the (mostly) duplicated code in the os/signal handling area...) Cheers, Mikael From vladimir.kozlov at oracle.com Tue Nov 6 21:35:16 2018 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Tue, 6 Nov 2018 13:35:16 -0800 Subject: RFR(S): 8213436: Obsolete UseMembar In-Reply-To: <0747F464-31EC-4C84-B1EE-B045315A4611@oracle.com> References: <0747F464-31EC-4C84-B1EE-B045315A4611@oracle.com> Message-ID: <2cf6a341-128f-f03e-c006-3a1717645d42@oracle.com> Nice cleanup. Thanks, Vladimir On 11/6/18 1:00 PM, Mikael Vidstedt wrote: > > Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead. > > bug: https://bugs.openjdk.java.net/browse/JDK-8213436 > webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/ > > * Background (from jbs) > > The UseMembar flag was deprecated in JDK 10, and is default true/enabled on all platforms since that same release. It should be obsoleted and the then dead serialization page functionality it controls should be removed. > > > * Testing > > tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn?t hurt. > > > (Unrelated to this change: It would be really nice to clean up some of the (mostly) duplicated code in the os/signal handling area...) > > Cheers, > Mikael > From david.holmes at oracle.com Tue Nov 6 22:20:49 2018 From: david.holmes at oracle.com (David Holmes) Date: Wed, 7 Nov 2018 08:20:49 +1000 Subject: RFR(S): 8213436: Obsolete UseMembar In-Reply-To: <0747F464-31EC-4C84-B1EE-B045315A4611@oracle.com> References: <0747F464-31EC-4C84-B1EE-B045315A4611@oracle.com> Message-ID: Hi Mikael, It is good to see a lot of complex code removed. Reviewed. Thanks, David On 7/11/2018 7:00 AM, Mikael Vidstedt wrote: > > Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead. > > bug: https://bugs.openjdk.java.net/browse/JDK-8213436 > webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/ > > * Background (from jbs) > > The UseMembar flag was deprecated in JDK 10, and is default true/enabled on all platforms since that same release. It should be obsoleted and the then dead serialization page functionality it controls should be removed. > > > * Testing > > tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn?t hurt. > > > (Unrelated to this change: It would be really nice to clean up some of the (mostly) duplicated code in the os/signal handling area...) > > Cheers, > Mikael > From martin.doerr at sap.com Wed Nov 7 07:37:47 2018 From: martin.doerr at sap.com (Doerr, Martin) Date: Wed, 7 Nov 2018 07:37:47 +0000 Subject: RFR(S): 8213436: Obsolete UseMembar In-Reply-To: <0747F464-31EC-4C84-B1EE-B045315A4611@oracle.com> References: <0747F464-31EC-4C84-B1EE-B045315A4611@oracle.com> Message-ID: <659d29c714cd498f89c94e0c3f5eb366@sap.com> Hi Mikael, looks good and builds on PPC64 and s390. Thanks, Martin -----Original Message----- From: s390x-port-dev On Behalf Of Mikael Vidstedt Sent: Dienstag, 6. November 2018 22:01 To: Hotspot dev runtime Cc: s390x-port-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net; aarch64-port-dev at openjdk.java.net Subject: RFR(S): 8213436: Obsolete UseMembar Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead. bug: https://bugs.openjdk.java.net/browse/JDK-8213436 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/ * Background (from jbs) The UseMembar flag was deprecated in JDK 10, and is default true/enabled on all platforms since that same release. It should be obsoleted and the then dead serialization page functionality it controls should be removed. * Testing tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn?t hurt. (Unrelated to this change: It would be really nice to clean up some of the (mostly) duplicated code in the os/signal handling area...) Cheers, Mikael From martin.doerr at sap.com Wed Nov 7 07:52:25 2018 From: martin.doerr at sap.com (Doerr, Martin) Date: Wed, 7 Nov 2018 07:52:25 +0000 Subject: RFR(S): 8213436: Obsolete UseMembar In-Reply-To: <659d29c714cd498f89c94e0c3f5eb366@sap.com> References: <0747F464-31EC-4C84-B1EE-B045315A4611@oracle.com> <659d29c714cd498f89c94e0c3f5eb366@sap.com> Message-ID: Hi again, I had started the wrong build on s390. Please fix os_linux_s390.cpp: You removed one "}" too much. (No need for a new webrev.) Best regards, Martin -----Original Message----- From: Doerr, Martin Sent: Mittwoch, 7. November 2018 08:38 To: 'Mikael Vidstedt' ; Hotspot dev runtime Cc: s390x-port-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net; aarch64-port-dev at openjdk.java.net Subject: RE: RFR(S): 8213436: Obsolete UseMembar Hi Mikael, looks good and builds on PPC64 and s390. Thanks, Martin -----Original Message----- From: s390x-port-dev On Behalf Of Mikael Vidstedt Sent: Dienstag, 6. November 2018 22:01 To: Hotspot dev runtime Cc: s390x-port-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net; aarch64-port-dev at openjdk.java.net Subject: RFR(S): 8213436: Obsolete UseMembar Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead. bug: https://bugs.openjdk.java.net/browse/JDK-8213436 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/ * Background (from jbs) The UseMembar flag was deprecated in JDK 10, and is default true/enabled on all platforms since that same release. It should be obsoleted and the then dead serialization page functionality it controls should be removed. * Testing tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn?t hurt. (Unrelated to this change: It would be really nice to clean up some of the (mostly) duplicated code in the os/signal handling area...) Cheers, Mikael From adinn at redhat.com Wed Nov 7 11:38:44 2018 From: adinn at redhat.com (Andrew Dinn) Date: Wed, 7 Nov 2018 11:38:44 +0000 Subject: RFR(S): 8213436: Obsolete UseMembar In-Reply-To: <0747F464-31EC-4C84-B1EE-B045315A4611@oracle.com> References: <0747F464-31EC-4C84-B1EE-B045315A4611@oracle.com> Message-ID: Hi Mikael, On 06/11/18 21:00, Mikael Vidstedt wrote: > Please review this change which obsoletes the UseMembar flag and > removes the code that then becomes unreachable/dead. Yes, all looks good. > * Testing > > tier1. If anybody wants to take it for a spin on > aarch64/ppc/s390/x86_32 that wouldn?t hurt. I have built successfully on aarch64 and tier1 testing is in progress. I will let you know the results when it completes. regards, Andrew Dinn ----------- From adinn at redhat.com Thu Nov 8 09:20:54 2018 From: adinn at redhat.com (Andrew Dinn) Date: Thu, 8 Nov 2018 09:20:54 +0000 Subject: RFR(S): 8213436: Obsolete UseMembar In-Reply-To: References: <0747F464-31EC-4C84-B1EE-B045315A4611@oracle.com> Message-ID: <033c5351-5ccf-6743-2f4e-9393ca11f4c3@redhat.com> Hi Mikael, On 07/11/18 11:38, Andrew Dinn wrote: > On 06/11/18 21:00, Mikael Vidstedt wrote: >> Please review this change which obsoletes the UseMembar flag and >> removes the code that then becomes unreachable/dead. > > Yes, all looks good. > >> * Testing >> >> tier1. If anybody wants to take it for a spin on >> aarch64/ppc/s390/x86_32 that wouldn?t hurt. > > I have built successfully on aarch64 and tier1 testing is in progress. I > will let you know the results when it completes. tier1 tests showed no problems on AArch64. Reviewed! regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander From mikael.vidstedt at oracle.com Thu Nov 8 19:48:22 2018 From: mikael.vidstedt at oracle.com (Mikael Vidstedt) Date: Thu, 8 Nov 2018 11:48:22 -0800 Subject: RFR(S): 8213436: Obsolete UseMembar In-Reply-To: <033c5351-5ccf-6743-2f4e-9393ca11f4c3@redhat.com> References: <0747F464-31EC-4C84-B1EE-B045315A4611@oracle.com> <033c5351-5ccf-6743-2f4e-9393ca11f4c3@redhat.com> Message-ID: <6C74FCB1-9EBC-45B0-B489-077921305667@oracle.com> I fixed (added back) the missing bracket in os_linux_s390.cpp and pushed. Thanks for the help reviewing and testing! Cheers, Mikael > On Nov 8, 2018, at 1:20 AM, Andrew Dinn wrote: > > Hi Mikael, > > On 07/11/18 11:38, Andrew Dinn wrote: >> On 06/11/18 21:00, Mikael Vidstedt wrote: >>> Please review this change which obsoletes the UseMembar flag and >>> removes the code that then becomes unreachable/dead. >> >> Yes, all looks good. >> >>> * Testing >>> >>> tier1. If anybody wants to take it for a spin on >>> aarch64/ppc/s390/x86_32 that wouldn?t hurt. >> >> I have built successfully on aarch64 and tier1 testing is in progress. I >> will let you know the results when it completes. > tier1 tests showed no problems on AArch64. > > Reviewed! > > regards, > > > Andrew Dinn > ----------- > Senior Principal Software Engineer > Red Hat UK Ltd > Registered in England and Wales under Company Registration No. 03798903 > Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander