[sctp-dev] Request for Review: 6915313

[Alan Bateman]

Christopher Hegarty - Sun Microsystems Ireland wrote:
> Hi,
>
> We have received several requests about porting the SCTP API to JDK6. 
> This bug aims to amend the current implementation to minimize the 
> amount of changes required to port it to JDK6.
>
> 1) Remove JDK7 API dependences from the implementation
> 2) provide all native functionality within libsctp.so
>
> 6915313: (sctp) Reorganize implementation to make it more feasible to 
> port to JDK6
>
> Webrev:
>   http://cr.openjdk.java.net/~chegar/6915313/webrev.0/webrev/
>
> Thanks,
> -Chris.
If I understand correctly, you're trying to help the folks that want to 
take this code and hack on it with jdk6 - is that right? Have you 
considered creating a page on the SCTP project with the recipe. Seems 
like removing the dependency on SocketOption and AlreadyBoundException 
are trivial and maybe there isn't a need to add commented out code. As 
the implementation is very tied to the selector implementation then I 
assume it's not an issue to keep the dependency on NativeDispatcher. 
That would avoid having to duplicate close/preClose at least. Otherwise 
looks okay to me.

-Alan.