From Weijun.Wang at Sun.COM Sun Aug 1 18:29:57 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Mon, 02 Aug 2010 09:29:57 +0800 Subject: code review request: 6973371: X509Factory should recognize PEM headers In-Reply-To: References: <4C52739F.6070208@sun.com> <4C5301FF.5020902@oracle.com> Message-ID: <4C561F95.2080706@sun.com> Re-send mail. Probably lost during in a mail server outage. On 07/31/2010 09:46 PM, Weijun Wang wrote: > Yes, you're correct. > > I regard "not-working" -> "working" a fix, not a regression. > > Thanks > Max > > > > On Jul 31, 2010, at 12:46 AM, Sean Mullan wrote: > >> Hi Max, >> >> I'm not sure about this change. There's a definitely a change in behavior. Before generateCertificate would only read one PEM block from the stream, and throw an exception if it wasn't a certificate. But the current fix ignores non certificate blocks until it finds a certificate or end of stream, right? >> >> --Sean >> >> On 7/30/10 2:39 AM, Weijun Wang wrote: >>> Hi Sean >>> >>> 6973371: X509Factory should recognize PEM headers >>> >>> Please review the webrev: >>> http://cr.openjdk.java.net/~weijun/6973371/webrev.00/ >>> >>> There is one place I haven't touched, generateCertPath. PKCS #7 PEM >>> block should begin with -----BEGIN PKCS7-----, or as described in [1], >>> with -----BEGIN CERTIFICATE-----. But what about a PKIPATH data block? >>> >>> Thanks >>> Max >>> >>> >>> === *Description* >>> ============================================================ >>> Currently, when X509Factory tries to read certificate or CRL from a PEM >>> file, it simply finds a block starting with "-----BEGIN STH-----" and >>> ending with "-----END STH-----", and does not care what this STH is at all. >>> >>> There are third-party tools that generates a PEM file containing >>> different kinds of PEM blocks. For example, "openssl pkcs12" can read in >>> a PKCS #12 file and output private key and certficates into a single PEM >>> file. If we want Java to read certificates from this file, we must take >>> care to remove any private key block first. This is quite troublesome. >>> >>> *** (#1 of 1): 2010-07-30 03:40:21 GMT+00:00 weijun.wang at sun.com >>> >>> [1] http://www.openssl.org/docs/apps/pkcs7.html#NOTES > From sean.mullan at oracle.com Mon Aug 2 12:21:59 2010 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 02 Aug 2010 15:21:59 -0400 Subject: 6653372 code review request Message-ID: <4C571AD7.7080309@oracle.com> Hi Max, Can you review this simple fix? http://cr.openjdk.java.net/~mullan/6653372/webrev.00/ Thanks, Sean From joe.darcy at oracle.com Mon Aug 2 13:37:52 2010 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 02 Aug 2010 20:37:52 +0000 Subject: hg: jdk7/tl/langtools: 6971877: Project Coin: improve semantics of suppressed exceptions in try-with-resources Message-ID: <20100802203800.C1AF547E72@hg.openjdk.java.net> Changeset: 38e2c23309f1 Author: darcy Date: 2010-08-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/38e2c23309f1 6971877: Project Coin: improve semantics of suppressed exceptions in try-with-resources Reviewed-by: jjb + test/tools/javac/TryWithResources/TwrSuppression.java From sean.mullan at oracle.com Mon Aug 2 14:10:57 2010 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 02 Aug 2010 17:10:57 -0400 Subject: code review request: 6973371: X509Factory should recognize PEM headers In-Reply-To: References: <4C52739F.6070208@sun.com> <4C5301FF.5020902@oracle.com> Message-ID: <4C573461.6080002@oracle.com> On 7/31/10 9:46 AM, Weijun Wang wrote: > Yes, you're correct. > > I regard "not-working" -> "working" a fix, not a regression. I think I would regard it as underspecified. There's nothing in CertificateFactory.generateCertificate that says it skips non-Certificate blocks. I suppose one could interpret it that way, but I would be wary of changing the behavior after so many years. Also, I'm wondering why the submitter could not have caught the exception and continued to read the rest of the data? --Sean > > Thanks Max > > > > On Jul 31, 2010, at 12:46 AM, Sean Mullan wrote: > >> Hi Max, >> >> I'm not sure about this change. There's a definitely a change in behavior. >> Before generateCertificate would only read one PEM block from the stream, >> and throw an exception if it wasn't a certificate. But the current fix >> ignores non certificate blocks until it finds a certificate or end of >> stream, right? >> >> --Sean >> >> On 7/30/10 2:39 AM, Weijun Wang wrote: >>> Hi Sean >>> >>> 6973371: X509Factory should recognize PEM headers >>> >>> Please review the webrev: >>> http://cr.openjdk.java.net/~weijun/6973371/webrev.00/ >>> >>> There is one place I haven't touched, generateCertPath. PKCS #7 PEM block >>> should begin with -----BEGIN PKCS7-----, or as described in [1], with >>> -----BEGIN CERTIFICATE-----. But what about a PKIPATH data block? >>> >>> Thanks Max >>> >>> >>> === *Description* >>> ============================================================ Currently, >>> when X509Factory tries to read certificate or CRL from a PEM file, it >>> simply finds a block starting with "-----BEGIN STH-----" and ending with >>> "-----END STH-----", and does not care what this STH is at all. >>> >>> There are third-party tools that generates a PEM file containing >>> different kinds of PEM blocks. For example, "openssl pkcs12" can read in >>> a PKCS #12 file and output private key and certficates into a single PEM >>> file. If we want Java to read certificates from this file, we must take >>> care to remove any private key block first. This is quite troublesome. >>> >>> *** (#1 of 1): 2010-07-30 03:40:21 GMT+00:00 weijun.wang at sun.com >>> >>> [1] http://www.openssl.org/docs/apps/pkcs7.html#NOTES > From jonathan.gibbons at oracle.com Mon Aug 2 16:31:32 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 02 Aug 2010 23:31:32 +0000 Subject: hg: jdk7/tl/langtools: 6973626: test/tools/javac/processing/* tests fail with assertions enabled Message-ID: <20100802233134.6801D47E7A@hg.openjdk.java.net> Changeset: 6318230cdb82 Author: jjg Date: 2010-08-02 16:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6318230cdb82 6973626: test/tools/javac/processing/* tests fail with assertions enabled Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java From Weijun.Wang at Sun.COM Mon Aug 2 17:33:10 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Tue, 03 Aug 2010 08:33:10 +0800 Subject: 6653372 code review request In-Reply-To: <4C571AD7.7080309@oracle.com> References: <4C571AD7.7080309@oracle.com> Message-ID: <4C5763C6.90903@sun.com> Looks good. Thanks Max On 08/03/2010 03:21 AM, Sean Mullan wrote: > Hi Max, > > Can you review this simple fix? > > http://cr.openjdk.java.net/~mullan/6653372/webrev.00/ > > Thanks, > Sean From Weijun.Wang at Sun.COM Mon Aug 2 17:38:37 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Tue, 03 Aug 2010 08:38:37 +0800 Subject: code review request: 6973371: X509Factory should recognize PEM headers In-Reply-To: <4C573461.6080002@oracle.com> References: <4C52739F.6070208@sun.com> <4C5301FF.5020902@oracle.com> <4C573461.6080002@oracle.com> Message-ID: <4C57650D.5030003@sun.com> On 08/03/2010 05:10 AM, Sean Mullan wrote: > On 7/31/10 9:46 AM, Weijun Wang wrote: >> Yes, you're correct. >> >> I regard "not-working" -> "working" a fix, not a regression. > > I think I would regard it as underspecified. There's nothing in > CertificateFactory.generateCertificate that says it skips non-Certificate > blocks. I suppose one could interpret it that way, but I would be wary > of changing the behavior after so many years. > > Also, I'm wondering why the submitter could not have caught the > exception and > continued to read the rest of the data? Yes, this works. I'll close the bug now. Thanks Max > > --Sean > >> >> Thanks Max >> >> >> >> On Jul 31, 2010, at 12:46 AM, Sean Mullan wrote: >> >>> Hi Max, >>> >>> I'm not sure about this change. There's a definitely a change in >>> behavior. >>> Before generateCertificate would only read one PEM block from the >>> stream, >>> and throw an exception if it wasn't a certificate. But the current fix >>> ignores non certificate blocks until it finds a certificate or end of >>> stream, right? >>> >>> --Sean >>> >>> On 7/30/10 2:39 AM, Weijun Wang wrote: >>>> Hi Sean >>>> >>>> 6973371: X509Factory should recognize PEM headers >>>> >>>> Please review the webrev: >>>> http://cr.openjdk.java.net/~weijun/6973371/webrev.00/ >>>> >>>> There is one place I haven't touched, generateCertPath. PKCS #7 PEM >>>> block >>>> should begin with -----BEGIN PKCS7-----, or as described in [1], with >>>> -----BEGIN CERTIFICATE-----. But what about a PKIPATH data block? >>>> >>>> Thanks Max >>>> >>>> >>>> === *Description* >>>> ============================================================ Currently, >>>> when X509Factory tries to read certificate or CRL from a PEM file, it >>>> simply finds a block starting with "-----BEGIN STH-----" and ending >>>> with >>>> "-----END STH-----", and does not care what this STH is at all. >>>> >>>> There are third-party tools that generates a PEM file containing >>>> different kinds of PEM blocks. For example, "openssl pkcs12" can >>>> read in >>>> a PKCS #12 file and output private key and certficates into a single >>>> PEM >>>> file. If we want Java to read certificates from this file, we must take >>>> care to remove any private key block first. This is quite troublesome. >>>> >>>> *** (#1 of 1): 2010-07-30 03:40:21 GMT+00:00 weijun.wang at sun.com >>>> >>>> [1] http://www.openssl.org/docs/apps/pkcs7.html#NOTES >> From chris.hegarty at oracle.com Tue Aug 3 04:04:10 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 03 Aug 2010 11:04:10 +0000 Subject: hg: jdk7/tl/jdk: 6973030: NTLM proxy authentication fails with https Message-ID: <20100803110435.9510B47E93@hg.openjdk.java.net> Changeset: 367b90ed38b1 Author: chegar Date: 2010-08-03 12:03 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/367b90ed38b1 6973030: NTLM proxy authentication fails with https Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6226610.java From sean.mullan at oracle.com Tue Aug 3 06:56:05 2010 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 03 Aug 2010 13:56:05 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100803135623.B5EE347E9B@hg.openjdk.java.net> Changeset: a21c46dac6cf Author: mullan Date: 2010-08-03 09:39 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a21c46dac6cf 6653372: Error in java.security.KeyStore example code Reviewed-by: weijun ! src/share/classes/java/security/KeyStore.java Changeset: 2feeefb45a44 Author: mullan Date: 2010-08-03 09:55 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2feeefb45a44 Merge From martinrb at google.com Tue Aug 3 14:20:01 2010 From: martinrb at google.com (martinrb at google.com) Date: Tue, 03 Aug 2010 21:20:01 +0000 Subject: hg: jdk7/tl/jdk: 6955504: (str) String[Builder/Buffer].append(char[], int, int) throws OutOfMemoryError in b94 Message-ID: <20100803212012.4314847EB3@hg.openjdk.java.net> Changeset: 3b63e506b57e Author: martin Date: 2010-08-03 12:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3b63e506b57e 6955504: (str) String[Builder/Buffer].append(char[],int,int) throws OutOfMemoryError in b94 Summary: let arraycopy throw AIOOBE for invalid negative length Reviewed-by: chegar, forax ! src/share/classes/java/lang/AbstractStringBuilder.java From maurizio.cimadamore at oracle.com Thu Aug 5 01:46:59 2010 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 05 Aug 2010 08:46:59 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20100805084702.B594247F12@hg.openjdk.java.net> Changeset: 0fe472f4a332 Author: mcimadamore Date: 2010-08-05 09:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0fe472f4a332 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException Summary: default annotation value is not attributed Reviewed-by: jjg, darcy ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/annotations/6881115/T6881115.java + test/tools/javac/annotations/6881115/T6881115.out Changeset: 237f3bd52242 Author: mcimadamore Date: 2010-08-05 09:45 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/237f3bd52242 6857948: Calling a constructor with a doubly bogus argument causes an internal error Summary: problem when constructor resolution returns an erroneous symbol Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/6857948/T6857948.java + test/tools/javac/6857948/T6857948.out From andrei.pangin at sun.com Thu Aug 5 05:49:32 2010 From: andrei.pangin at sun.com (andrei.pangin at sun.com) Date: Thu, 05 Aug 2010 12:49:32 +0000 Subject: hg: jdk7/tl/jdk: 6945961: SIGSEGV in memcpy() during class loading on linux-i586 Message-ID: <20100805125012.7077847F1F@hg.openjdk.java.net> Changeset: 188f156148ea Author: apangin Date: 2010-08-04 20:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/188f156148ea 6945961: SIGSEGV in memcpy() during class loading on linux-i586 Summary: Check the result of strchr() in Bytecode Verifier Reviewed-by: kamg, acorn ! src/share/native/common/check_code.c From daniel.daugherty at oracle.com Fri Aug 6 11:12:09 2010 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Fri, 06 Aug 2010 18:12:09 +0000 Subject: hg: jdk7/tl/jdk: 6962604: 3/3 Testcase sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh failure Message-ID: <20100806181242.46FED47F5D@hg.openjdk.java.net> Changeset: d47f5dcda481 Author: dcubed Date: 2010-08-06 11:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d47f5dcda481 6962604: 3/3 Testcase sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh failure Summary: Disable MonitorVmStartTerminate.sh until 6543856 is fixed. Reviewed-by: ohair ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh From Weijun.Wang at Sun.COM Sun Aug 8 19:11:36 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Mon, 09 Aug 2010 10:11:36 +0800 Subject: code review request: 6960894: Better AS-REQ creation and processing In-Reply-To: <4C5367D6.5050305@oracle.com> References: <22057664.1276437650877.JavaMail.sbladm@swsblss3-new> <09BC881F-51C5-4004-9BF4-B7F826BC48AA@Sun.COM> <4C474B31.20806@oracle.com> <4C5367D6.5050305@oracle.com> Message-ID: <4C5F63D8.5040702@sun.com> Webrev updated: http://cr.openjdk.java.net/~weijun/6960894/webrev.01/ Changes made: KrbAsReqBuilder.java: 1. state and state checks 2. clear() -> destroy() KrbAsReq.java: split decrypt() to decryptUsingKeys() and decryptUsingPassword() KrbKdcReq -> KdcComm: The internal class KdcCommunication name is retained, Comments inline. On 07/31/2010 08:01 AM, Valerie (Yu-Ching) Peng wrote: > Hi, Max, > > KrbAsRep.java > => 1) the javadoc of its decrypt method only documents the first two > arguments which seems incomplete. You meant to emphasize that there two > are user-provided? Maybe you can just enhance the method description. In > addition, only one of the keys and password arguments is used. Would it > be clearer to separate this into two methods, one uses keys and the > other uses password? Now in two methods. > => 2) one thing that I find somewhat confusing is the values of "creds". > The old model sets all of its fields in the constructor. With the new > model, creds is null until decrypt(...) is called. I add some comment to the field. > KrbKdcReq.java > => 1) for the if-block between line 229 and 232, is it possible for the > KRB_ERR_RESPONSE_TOO_BIG when 'useTCP' is true? And don't you have to > check ibuf again after line 231? The error should only happens when using UDP. RFC 4120 says: KRB_ERR_RESPONSE_TOO_BIG 52 Response too big for UDP; retry with TCP The only error handled in KrbKdcReq is KRB_ERR_RESPONSE_TOO_BIG error, which I treat as a communication-level error. Other errors are handled in a higher level. > => 2) I am open for a name change since the current naming seems to > imply an inheritance relationship which you've changed. I thought the name change would make an ugly webrev. It seems not. > KrbAsReqBuilder.java > => 1) line 72 "one and only is non-null" may be clearer as "one of them > must be null". I mean that one of them MUST be null and the other one MUST NOT be null. > => 2) keys(..) and pass(..) are initialization methods which must be > called before getKeys(), right? Can you rename them so it's clearer? > There is no checking in getKeys() and if called out of sequence, it > looks to me that it'll error out w/ NPE since eType is still null. There are also methods like target(), options(), addresses() that all must be called before action(). I've added an internal state now. Thanks Max > > Thanks, > Valerie > > On 07/21/10 12:32, Valerie (Yu-Ching) Peng wrote: >> On 06/13/10 08:02, Weijun Wang wrote: >>> Hi Valerie and Andrew >>> >>> Please review the following webrev: >>> >>> http://cr.openjdk.java.net/~weijun/6960894/webrev.00 >>> >>> The major enhancement is KrbAsReqBuilder which generates AS-REQ, sends it, parses any response, and returns a Credentials object. The other big change is KrbKdcReq, it's no longer base class for KrbAsReq and KrbTgsReq, but mainly a vehicle for both kinds of KDC-REQ messages. Maybe it needs a name change? >>> >>> Most other changes are about removing duplicate lines. >>> >>> Thanks >>> Max >>> >>> Begin forwarded message: >>> >>> >>>> *Change Request ID*: 6960894 >>>> *Synopsis*: Better AS-REQ creation and processing >>>> >>>> >>> >>> >>>> === *Description* ============================================================ >>>> The current AS-REQ creation and processing implementation: >>>> >>>> 1. spread into multiple source files and have duplicate codes >>>> 2. cannot deal with PA-DATA in AS-REP >>>> 3. only use a single salt, and write it into PrincipalName permanently >>>> 4. generate too many secret keys and have no consistent way to clear them >>>> 5. does not handle the preferences of PA-ETYPE-INFO2, PA-ETYPE-INFO correctly >>>> >>> >>> >> > From lance.andersen at oracle.com Tue Aug 10 07:19:03 2010 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Tue, 10 Aug 2010 14:19:03 +0000 Subject: hg: jdk7/tl/jdk: 6898593: java.sql.Date.valueOf no exception if date given is not in the JDBC date escape syntax Message-ID: <20100810141912.AA9BB4704E@hg.openjdk.java.net> Changeset: 3e239fe92832 Author: lancea Date: 2010-08-10 10:07 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3e239fe92832 6898593: java.sql.Date.valueOf no exception if date given is not in the JDBC date escape syntax Reviewed-by: minqi ! src/share/classes/java/sql/Date.java From maurizio.cimadamore at oracle.com Tue Aug 10 08:20:35 2010 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 10 Aug 2010 15:20:35 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20100810152038.B396E47051@hg.openjdk.java.net> Changeset: a2d8c7071f24 Author: mcimadamore Date: 2010-08-10 14:52 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a2d8c7071f24 6975275: diamond implementation needs some cleanup Summary: resolution issues during diamond inference should be reported through Resolve.logResolveError() Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: ea1930f4b789 Author: mcimadamore Date: 2010-08-10 14:53 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ea1930f4b789 6975231: Regression test for 6881115 is failing with compiler output not matching expected output Summary: missing symbols are collected in an HashSet which doesn't preserve ordering Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/annotations/6881115/T6881115.out + test/tools/javac/diags/examples/AnnotationMissingValues1.java From chris.hegarty at oracle.com Tue Aug 10 09:31:19 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 10 Aug 2010 16:31:19 +0000 Subject: hg: jdk7/tl/jdk: 6882910: Unexplained lack of IP4 network ability when transparent IP6 to IP4 is disabled. Message-ID: <20100810163132.5012247056@hg.openjdk.java.net> Changeset: 1f996198877b Author: chegar Date: 2010-08-10 17:30 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f996198877b 6882910: Unexplained lack of IP4 network ability when transparent IP6 to IP4 is disabled. Reviewed-by: alanb ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/PlainSocketImpl.c ! src/solaris/native/sun/nio/ch/Net.c From xueming.shen at oracle.com Tue Aug 10 13:17:57 2010 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 10 Aug 2010 20:17:57 +0000 Subject: hg: jdk7/tl/jdk: 6923794: About 40 JCK test case fail with AssertionError if -esa option is specified Message-ID: <20100810201807.0018E47061@hg.openjdk.java.net> Changeset: da5b67ac7755 Author: sherman Date: 2010-08-10 13:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/da5b67ac7755 6923794: About 40 JCK test case fail with AssertionError if -esa option is specified Summary: removed the assert Reviewed-by: alanb ! src/solaris/classes/java/io/UnixFileSystem.java ! src/windows/classes/java/io/Win32FileSystem.java From alan.bateman at oracle.com Thu Aug 12 11:56:13 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 12 Aug 2010 18:56:13 +0000 Subject: hg: jdk7/tl/jdk: 6971825: (so) improve scatter/gather implementation Message-ID: <20100812185626.EB50A470FC@hg.openjdk.java.net> Changeset: 11ee8b471f9c Author: alanb Date: 2010-08-12 19:53 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/11ee8b471f9c 6971825: (so) improve scatter/gather implementation Reviewed-by: chegar, sherman ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! src/share/classes/sun/nio/ch/IOUtil.java ! src/share/classes/sun/nio/ch/IOVecWrapper.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/share/classes/sun/nio/ch/Util.java From mandy.chung at oracle.com Thu Aug 12 16:47:41 2010 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 12 Aug 2010 23:47:41 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100812234800.12AEA47112@hg.openjdk.java.net> Changeset: 389bc53d0945 Author: mchung Date: 2010-08-12 16:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/389bc53d0945 6973831: NPE when printing stack trace of OOME Summary: Initialize suppressedExceptions field to null Reviewed-by: briangoetz, dholmes, forax ! src/share/classes/java/lang/Throwable.java Changeset: cdd6d518f47e Author: mchung Date: 2010-08-12 16:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cdd6d518f47e Merge From lana.steuck at oracle.com Thu Aug 12 22:49:18 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 13 Aug 2010 05:49:18 +0000 Subject: hg: jdk7/tl: 2 new changesets Message-ID: <20100813054918.8EEB047131@hg.openjdk.java.net> Changeset: f8be576feefc Author: cl Date: 2010-07-29 13:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/f8be576feefc Added tag jdk7-b103 for changeset be2aedc4e3b1 ! .hgtags Changeset: 9f96a4269d77 Author: cl Date: 2010-08-06 12:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/9f96a4269d77 Added tag jdk7-b104 for changeset f8be576feefc ! .hgtags From lana.steuck at oracle.com Thu Aug 12 22:49:23 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 13 Aug 2010 05:49:23 +0000 Subject: hg: jdk7/tl/corba: 2 new changesets Message-ID: <20100813054924.BCA4A47132@hg.openjdk.java.net> Changeset: 9607213481d4 Author: cl Date: 2010-07-29 13:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/9607213481d4 Added tag jdk7-b103 for changeset 11e7678c3eb1 ! .hgtags Changeset: 6f21b030092f Author: cl Date: 2010-08-06 12:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/6f21b030092f Added tag jdk7-b104 for changeset 9607213481d4 ! .hgtags From lana.steuck at oracle.com Thu Aug 12 22:54:10 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 13 Aug 2010 05:54:10 +0000 Subject: hg: jdk7/tl/jaxp: 2 new changesets Message-ID: <20100813055410.D6BED47136@hg.openjdk.java.net> Changeset: d42c4acb6424 Author: cl Date: 2010-07-29 13:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/d42c4acb6424 Added tag jdk7-b103 for changeset b7722e878864 ! .hgtags Changeset: 3233b9a4c12e Author: cl Date: 2010-08-06 12:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/3233b9a4c12e Added tag jdk7-b104 for changeset d42c4acb6424 ! .hgtags From lana.steuck at oracle.com Thu Aug 12 22:54:15 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 13 Aug 2010 05:54:15 +0000 Subject: hg: jdk7/tl/jaxws: 2 new changesets Message-ID: <20100813055415.E635A47137@hg.openjdk.java.net> Changeset: bbc4cce6c20a Author: cl Date: 2010-07-29 13:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/bbc4cce6c20a Added tag jdk7-b103 for changeset 267386d6b923 ! .hgtags Changeset: 39eb4f3031f4 Author: cl Date: 2010-08-06 12:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/39eb4f3031f4 Added tag jdk7-b104 for changeset bbc4cce6c20a ! .hgtags From lana.steuck at oracle.com Thu Aug 12 22:55:38 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 13 Aug 2010 05:55:38 +0000 Subject: hg: jdk7/tl/jdk: 21 new changesets Message-ID: <20100813055900.A0CE247139@hg.openjdk.java.net> Changeset: b839344245a9 Author: cl Date: 2010-07-29 13:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b839344245a9 Added tag jdk7-b103 for changeset 6488b70a23cc ! .hgtags Changeset: 6950da80c75c Author: ohair Date: 2010-08-02 16:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6950da80c75c 6973616: Update minimum boot jdk from 1.5 to 1.6 Reviewed-by: igor, jjg ! make/common/shared/Defs-versions.gmk Changeset: dd48c78218a7 Author: ohair Date: 2010-08-02 16:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dd48c78218a7 6971426: jdk/make/docs docs target does not work on windows Reviewed-by: igor, jjg ! make/docs/Makefile Changeset: f46ec75b1663 Author: ohair Date: 2010-08-03 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f46ec75b1663 6974239: Correct reference to jdk document site in javadoc Reviewed-by: skannan ! make/docs/Makefile Changeset: 1a92820132a0 Author: cl Date: 2010-08-04 22:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1a92820132a0 Merge Changeset: d967f8507d9d Author: cl Date: 2010-08-06 12:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d967f8507d9d Added tag jdk7-b104 for changeset 1a92820132a0 ! .hgtags Changeset: 539528c5d395 Author: lana Date: 2010-07-14 09:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/539528c5d395 Merge Changeset: cf0c23a99823 Author: lana Date: 2010-07-29 17:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cf0c23a99823 Merge - src/linux/doc/man/ja/kinit.1 - src/linux/doc/man/ja/klist.1 - src/linux/doc/man/ja/ktab.1 - test/java/nio/channels/ServerSocketChannel/AcceptAddress.java - test/java/nio/charset/coders/Surrogate.java - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so Changeset: c6f443c3d96a Author: lana Date: 2010-08-02 19:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c6f443c3d96a Merge Changeset: c38803ce0560 Author: uta Date: 2010-07-23 18:59 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c38803ce0560 6969851: VM hangs/crashes in FileDialog test (VS2008/2010 build) Reviewed-by: prr, art ! src/windows/native/sun/windows/awt.h Changeset: 9bb8d5c093fc Author: lana Date: 2010-07-29 13:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9bb8d5c093fc Merge - src/linux/doc/man/ja/kinit.1 - src/linux/doc/man/ja/klist.1 - src/linux/doc/man/ja/ktab.1 - test/java/nio/channels/ServerSocketChannel/AcceptAddress.java - test/java/nio/charset/coders/Surrogate.java - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so Changeset: 8a72583dc41d Author: lana Date: 2010-08-02 19:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8a72583dc41d Merge Changeset: 65403b9bcb58 Author: peterz Date: 2010-07-13 17:26 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/65403b9bcb58 6462562: InternationalFormatter inserts text incorrectly 6578432: Currency format instance does not work with Swing's NumberFormatter Reviewed-by: rupashka ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/InternationalFormatter.java + test/javax/swing/JFormattedTextField/Test6462562.java Changeset: a0d7b76abcd3 Author: alexp Date: 2010-07-29 19:34 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a0d7b76abcd3 4743225: Size of JComboBox list is wrong when list is populated via PopupMenuListener Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java + test/javax/swing/JComboBox/4743225/bug4743225.java Changeset: 0e8acbf12695 Author: lana Date: 2010-07-29 13:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0e8acbf12695 Merge - src/linux/doc/man/ja/kinit.1 - src/linux/doc/man/ja/klist.1 - src/linux/doc/man/ja/ktab.1 - test/java/nio/channels/ServerSocketChannel/AcceptAddress.java - test/java/nio/charset/coders/Surrogate.java - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so Changeset: 951e46d93af0 Author: malenkov Date: 2010-07-30 19:21 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/951e46d93af0 6199676: REGRESSION: ColorChooser loses preview when change LandF in Java5 Reviewed-by: alexp, peterz ! src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java + test/javax/swing/JColorChooser/Test6199676.java Changeset: f40de306ab66 Author: malenkov Date: 2010-07-30 19:40 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f40de306ab66 6972468: Security manager should be used for tests in java/beans/XMLEncoder Reviewed-by: peterz ! test/java/beans/XMLEncoder/Test4631471.java ! test/java/beans/XMLEncoder/Test4903007.java ! test/java/beans/XMLEncoder/javax_swing_JLayeredPane.java Changeset: ce1e26600ab7 Author: lana Date: 2010-08-02 19:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ce1e26600ab7 Merge Changeset: 10e7e04d1e96 Author: lana Date: 2010-08-02 19:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/10e7e04d1e96 Merge - test/java/net/Socket/AccurateTimeout.java Changeset: 3b0abcb51280 Author: lana Date: 2010-08-09 16:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3b0abcb51280 Merge - test/java/net/Socket/AccurateTimeout.java Changeset: 041997c49f15 Author: lana Date: 2010-08-12 19:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/041997c49f15 Merge From lana.steuck at oracle.com Thu Aug 12 22:52:06 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 13 Aug 2010 05:52:06 +0000 Subject: hg: jdk7/tl/hotspot: 20 new changesets Message-ID: <20100813055241.E622447133@hg.openjdk.java.net> Changeset: efd4401fab1d Author: cl Date: 2010-07-29 13:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/efd4401fab1d Added tag jdk7-b103 for changeset cb4250ef73b2 ! .hgtags Changeset: e7ec8cd4dd8a Author: tonyp Date: 2010-06-28 14:13 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e7ec8cd4dd8a 6962569: assembler_sparc.cpp:1969: assert(false) failed: error Summary: array_overlap_test() fails when the address range crosses the MSB boundary. Thanks to Tom and Vladimir for their help on this one. Reviewed-by: kvn, never, iveresov ! src/cpu/sparc/vm/stubGenerator_sparc.cpp Changeset: 4e5661ba9d98 Author: tonyp Date: 2010-06-28 14:13 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly Summary: G1 was not handling explicit GCs correctly in many ways. It does now. See the CR for the list of improvements contained in this changeset. Reviewed-by: iveresov, ysr, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.hpp ! src/share/vm/gc_implementation/includeDB_gc_g1 ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp ! src/share/vm/gc_interface/gcCause.cpp ! src/share/vm/runtime/mutexLocker.cpp Changeset: 1a1ce2076047 Author: ysr Date: 2010-07-16 10:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1a1ce2076047 Merge Changeset: ad7e433e2730 Author: ysr Date: 2010-07-20 16:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ad7e433e2730 Merge - src/os/linux/vm/vtune_linux.cpp - src/os/solaris/vm/vtune_solaris.cpp - src/os/windows/vm/vtune_windows.cpp - src/share/vm/runtime/vtune.hpp Changeset: 131ed9a23d48 Author: ysr Date: 2010-07-21 09:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/131ed9a23d48 Merge Changeset: 083fde3b838e Author: jrose Date: 2010-07-15 18:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/083fde3b838e 6964498: JSR 292 invokedynamic sites need local bootstrap methods Summary: Add JVM_CONSTANT_InvokeDynamic records to constant pool to determine per-instruction BSMs. Reviewed-by: twisti ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPool.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/ClassConstants.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/ConstantTag.java ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/constantTag.cpp ! src/share/vm/utilities/constantTag.hpp Changeset: 01b172b8cd7c Author: never Date: 2010-07-16 08:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/01b172b8cd7c Merge Changeset: e0ba4e04c839 Author: jrose Date: 2010-07-16 18:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e0ba4e04c839 6969574: invokedynamic call sites deoptimize instead of executing Reviewed-by: kvn ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/prims/methodHandleWalk.cpp Changeset: 7139e81efd2d Author: never Date: 2010-07-22 15:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7139e81efd2d 6970566: runThese fails with SIGSEGV Reviewed-by: kvn ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeBlob.hpp Changeset: 5063ce716349 Author: never Date: 2010-07-23 10:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5063ce716349 Merge Changeset: a93a9eda13f7 Author: jcoomes Date: 2010-07-16 21:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a93a9eda13f7 6962947: shared TaskQueue statistics Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/gc_implementation/parNew/parOopClosures.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/taskqueue.hpp Changeset: 5cbac8938c4c Author: johnc Date: 2010-07-19 11:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5cbac8938c4c 6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307 Summary: During concurrent refinment, filter cards in young regions after it has been determined that the region has been allocated from and the young type of the region has been set. Reviewed-by: iveresov, tonyp, jcoomes ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp Changeset: 4f1fffe08c63 Author: ysr Date: 2010-07-21 12:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4f1fffe08c63 Merge Changeset: 1890dc9151da Author: ysr Date: 2010-07-23 14:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1890dc9151da Merge Changeset: cc3fdfeb54b0 Author: trims Date: 2010-07-29 23:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cc3fdfeb54b0 Merge Changeset: fd2645290e89 Author: trims Date: 2010-07-30 06:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/fd2645290e89 6973381: Bump the HS19 build number to 05 Summary: Update the HS19 build number to 05 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 28abe3f6a5f6 Author: trims Date: 2010-08-03 19:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/28abe3f6a5f6 Merge Changeset: b4acf10eb134 Author: trims Date: 2010-08-05 02:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b4acf10eb134 Added tag hs19-b04 for changeset e55900b5c1b8 ! .hgtags Changeset: 6709c14587c2 Author: cl Date: 2010-08-06 12:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6709c14587c2 Added tag jdk7-b104 for changeset b4acf10eb134 ! .hgtags From lana.steuck at oracle.com Thu Aug 12 23:00:17 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 13 Aug 2010 06:00:17 +0000 Subject: hg: jdk7/tl/langtools: 5 new changesets Message-ID: <20100813060025.AE9BB4713A@hg.openjdk.java.net> Changeset: fc7219517ec1 Author: cl Date: 2010-07-29 13:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/fc7219517ec1 Added tag jdk7-b103 for changeset bd85271c580c ! .hgtags Changeset: 49489c1d8fae Author: cl Date: 2010-08-06 12:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/49489c1d8fae Added tag jdk7-b104 for changeset fc7219517ec1 ! .hgtags Changeset: 186feb2042f0 Author: lana Date: 2010-08-02 19:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/186feb2042f0 Merge Changeset: aaecac256d39 Author: lana Date: 2010-08-09 16:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/aaecac256d39 Merge Changeset: c04ae2714f52 Author: lana Date: 2010-08-12 19:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c04ae2714f52 Merge From ahughes at redhat.com Fri Aug 13 14:27:25 2010 From: ahughes at redhat.com (ahughes at redhat.com) Date: Fri, 13 Aug 2010 21:27:25 +0000 Subject: hg: jdk7/tl/jdk: 6976186: Integrate Shark Message-ID: <20100813212737.E9C8A4716A@hg.openjdk.java.net> Changeset: 0cdd73548292 Author: gbenson Date: 2010-08-13 22:26 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0cdd73548292 6976186: Integrate Shark Summary: Shark is a JIT compiler for Zero that uses the LLVM compiler infrastructure. Reviewed-by: ohair ! make/jdk_generic_profile.sh From maurizio.cimadamore at oracle.com Mon Aug 16 07:06:26 2010 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 16 Aug 2010 14:06:26 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20100816140629.E3B0647206@hg.openjdk.java.net> Changeset: 27bae58329d5 Author: mcimadamore Date: 2010-08-16 14:56 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/27bae58329d5 6976649: javac does not enforce required annotation elements in arrays Summary: type annotation should take advantage of recursive annotation checking Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/annotations/6881115/T6881115.java ! test/tools/javac/annotations/6881115/T6881115.out ! test/tools/javac/annotations/pos/TrailingComma.java Changeset: dc550520ed6f Author: mcimadamore Date: 2010-08-16 14:58 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/dc550520ed6f 6369605: Unconstrained type variables fails to include bounds Summary: unconstrained type-variables with recursive bounds are not inferred properly Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! test/tools/javac/Diagnostics/6862608/T6862608a.out ! test/tools/javac/diags/examples.not-yet.txt ! test/tools/javac/diags/examples/InvalidInferredTypes.java + test/tools/javac/generics/inference/6369605/T6369605a.java + test/tools/javac/generics/inference/6369605/T6369605b.java ! test/tools/javac/generics/inference/6638712/T6638712a.out From jonathan.gibbons at oracle.com Mon Aug 16 14:59:42 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 16 Aug 2010 21:59:42 +0000 Subject: hg: jdk7/tl/langtools: 6976833: options included twice in Example SimpleCompiler Message-ID: <20100816215944.29C474721B@hg.openjdk.java.net> Changeset: a31c511db424 Author: jjg Date: 2010-08-16 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a31c511db424 6976833: options included twice in Example SimpleCompiler Reviewed-by: darcy ! test/tools/javac/diags/Example.java From mandy.chung at oracle.com Mon Aug 16 15:36:36 2010 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Mon, 16 Aug 2010 22:36:36 +0000 Subject: hg: jdk7/tl/jdk: 6921234: TEST_BUG: java/lang/ClassLoader/deadlock/TestCrossDelegate.sh needs to be modified for Cygwin Message-ID: <20100816223646.22CDC4721E@hg.openjdk.java.net> Changeset: 8329ebeabc10 Author: mchung Date: 2010-08-16 15:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8329ebeabc10 6921234: TEST_BUG: java/lang/ClassLoader/deadlock/TestCrossDelegate.sh needs to be modified for Cygwin Summary: Add check for CYGWIN Reviewed-by: ohair ! test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh From michael.x.mcmahon at oracle.com Tue Aug 17 07:16:41 2010 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Tue, 17 Aug 2010 14:16:41 +0000 Subject: hg: jdk7/tl/jdk: 6339649: URI.create should include a detail message when throwing IllegalArgumentException Message-ID: <20100817141706.2738447248@hg.openjdk.java.net> Changeset: 42eaa082a4e6 Author: michaelm Date: 2010-08-17 14:49 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/42eaa082a4e6 6339649: URI.create should include a detail message when throwing IllegalArgumentException Summary: create enclosing exception with message of enclosed Reviewed-by: alanb, chegar ! src/share/classes/java/net/URI.java ! test/java/net/URI/Test.java From xueming.shen at oracle.com Tue Aug 17 16:07:31 2010 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 17 Aug 2010 23:07:31 +0000 Subject: hg: jdk7/tl/jdk: 6969651: TEST_BUG: tools/jar/JarEntryTime.java failed on JDK7 when run on NFS Message-ID: <20100817230740.B70464725D@hg.openjdk.java.net> Changeset: bfc3855a9341 Author: sherman Date: 2010-08-17 16:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bfc3855a9341 6969651: TEST_BUG: tools/jar/JarEntryTime.java failed on JDK7 when run on NFS Summary: changed to use more appropriate nfs file time Reviewed-by: martin ! test/tools/jar/JarEntryTime.java From kelly.ohair at oracle.com Wed Aug 18 18:46:37 2010 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Thu, 19 Aug 2010 01:46:37 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100819014656.681F8472A0@hg.openjdk.java.net> Changeset: 01dec49e95c4 Author: ohair Date: 2010-08-18 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/01dec49e95c4 6974005: Use of cygpath in Makefile logic needs to silence error messages Reviewed-by: mchung ! make/common/shared/Defs-windows.gmk Changeset: 42bfa43f2ae1 Author: ohair Date: 2010-08-18 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/42bfa43f2ae1 6932743: Makefiles not parsing version strings with - from uname -r Reviewed-by: mchung ! make/common/shared/Defs.gmk From weijun.wang at sun.com Wed Aug 18 20:27:10 2010 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Thu, 19 Aug 2010 03:27:10 +0000 Subject: hg: jdk7/tl/jdk: 6976536: Solaris JREs do not have the krb5.kdc.bad.policy configured by default. Message-ID: <20100819032719.85816472A4@hg.openjdk.java.net> Changeset: 4abd65f04638 Author: weijun Date: 2010-08-19 11:26 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4abd65f04638 6976536: Solaris JREs do not have the krb5.kdc.bad.policy configured by default. Reviewed-by: valeriep ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows + test/sun/security/krb5/BadKdcDefaultValue.java From weijun.wang at sun.com Wed Aug 18 21:25:11 2010 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Thu, 19 Aug 2010 04:25:11 +0000 Subject: hg: jdk7/tl/jdk: 6921610: 1.6 update 17 and 18 throw java.lang.IndexOutOfBoundsException Message-ID: <20100819042521.C27C4472A7@hg.openjdk.java.net> Changeset: 95bb147c7c33 Author: weijun Date: 2010-08-19 12:24 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/95bb147c7c33 6921610: 1.6 update 17 and 18 throw java.lang.IndexOutOfBoundsException Reviewed-by: vinnie, xuelei ! src/share/classes/com/sun/jndi/ldap/Connection.java From maurizio.cimadamore at oracle.com Thu Aug 19 04:04:46 2010 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 19 Aug 2010 11:04:46 +0000 Subject: hg: jdk7/tl/langtools: 3 new changesets Message-ID: <20100819110452.C4D74472B7@hg.openjdk.java.net> Changeset: c655e0280bdc Author: mcimadamore Date: 2010-08-19 11:50 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c655e0280bdc 6886247: regression: javac crashes with an assertion error in Attr.java Summary: capture conversion does not work on nested types Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/wildcards/6886247/T6886247_1.java + test/tools/javac/generics/wildcards/6886247/T6886247_2.java + test/tools/javac/generics/wildcards/6886247/T6886247_2.out Changeset: d6fe0ea070aa Author: mcimadamore Date: 2010-08-19 11:52 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d6fe0ea070aa 6885255: Improve usability of raw warnings Summary: raw warnings should be disabled in (i) instanceof expressions and (ii) when java.lang.Class is not parameterized Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/warnings/6747671/T6747671.java ! test/tools/javac/warnings/6747671/T6747671.out + test/tools/javac/warnings/6885255/T6885255.java + test/tools/javac/warnings/6885255/T6885255.out Changeset: a75770c0d7f6 Author: mcimadamore Date: 2010-08-19 11:54 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a75770c0d7f6 6977800: Regression: invalid resolution of supertype for local class Summary: resolution of superclass/superinterfaces in extends/implements clause skips local classes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/T6977800.java ! test/tools/javac/generics/typevars/5060485/Compatibility.java + test/tools/javac/generics/typevars/5060485/Compatibility.out + test/tools/javac/generics/typevars/5060485/Compatibility02.java + test/tools/javac/generics/typevars/5060485/Compatibility02.out From kumar.x.srinivasan at oracle.com Fri Aug 20 08:51:43 2010 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 20 Aug 2010 15:51:43 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20100820155217.D5DAB4730D@hg.openjdk.java.net> Changeset: 1ce9c1690080 Author: ksrini Date: 2010-08-19 14:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1ce9c1690080 6888127: java.util.jar.Pack200.Packer Memory Leak Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/classes/com/sun/java/util/jar/pack/Driver.java ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java + src/share/classes/com/sun/java/util/jar/pack/TLGlobals.java ! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java Changeset: 16e43f336262 Author: ksrini Date: 2010-08-20 08:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/16e43f336262 6966737: (pack200) the pack200 regression tests need to be more robust. Reviewed-by: jrose, ohair + test/tools/pack200/CommandLineTests.java - test/tools/pack200/Pack200Simple.sh ! test/tools/pack200/Pack200Test.java ! test/tools/pack200/PackageVersionTest.java ! test/tools/pack200/SegmentLimit.java + test/tools/pack200/Utils.java + test/tools/pack200/pack200-verifier/data/README + test/tools/pack200/pack200-verifier/data/golden.jar + test/tools/pack200/pack200-verifier/make/build.xml + test/tools/pack200/pack200-verifier/src/sun/tools/pack/verify/ClassCompare.java + test/tools/pack200/pack200-verifier/src/sun/tools/pack/verify/Globals.java + test/tools/pack200/pack200-verifier/src/sun/tools/pack/verify/JarFileCompare.java + test/tools/pack200/pack200-verifier/src/sun/tools/pack/verify/Main.java + test/tools/pack200/pack200-verifier/src/sun/tools/pack/verify/VerifyTreeSet.java + test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java + test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java + test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java + test/tools/pack200/pack200-verifier/src/xmlkit/CommandLineParser.java + test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java + test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java + test/tools/pack200/pack200-verifier/src/xmlkit/TokenList.java + test/tools/pack200/pack200-verifier/src/xmlkit/XMLKit.java Changeset: db1b7c10de61 Author: ksrini Date: 2010-08-20 08:49 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db1b7c10de61 Merge From chris.hegarty at oracle.com Mon Aug 23 06:36:04 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 23 Aug 2010 13:36:04 +0000 Subject: hg: jdk7/tl/jdk: 6968584: Thread should not be Cloneable Message-ID: <20100823133621.6DB78473B0@hg.openjdk.java.net> Changeset: fd28003bc1d6 Author: chegar Date: 2010-08-23 14:35 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fd28003bc1d6 6968584: Thread should not be Cloneable Reviewed-by: dholmes ! src/share/classes/java/lang/Thread.java From chris.hegarty at oracle.com Mon Aug 23 08:28:58 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 23 Aug 2010 15:28:58 +0000 Subject: hg: jdk7/tl/jdk: 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe Message-ID: <20100823152907.B3C4D473B5@hg.openjdk.java.net> Changeset: 03218163f4d5 Author: chegar Date: 2010-08-23 16:27 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/03218163f4d5 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe Reviewed-by: michaelm ! src/share/classes/java/net/HttpCookie.java From maurizio.cimadamore at oracle.com Mon Aug 23 09:01:09 2010 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 23 Aug 2010 16:01:09 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20100823160112.D7979473B7@hg.openjdk.java.net> Changeset: 995bcdb9a41d Author: mcimadamore Date: 2010-08-23 16:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/995bcdb9a41d 6932571: Compiling Generics causing Inconvertible types Summary: Types.rewriteQuantifiers() does not work well with recursive type-variable bounds Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/cast/6270087/T6270087.java + test/tools/javac/cast/6270087/T6270087neg.java + test/tools/javac/cast/6270087/T6270087neg.out + test/tools/javac/cast/6507317/T6507317.java + test/tools/javac/cast/6569057/T6569057.java + test/tools/javac/cast/6932571/T6932571a.java + test/tools/javac/cast/6932571/T6932571b.java + test/tools/javac/cast/6932571/T6932571neg.java + test/tools/javac/cast/6932571/T6932571neg.out Changeset: 594b3c2ef585 Author: mcimadamore Date: 2010-08-23 17:00 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/594b3c2ef585 6978574: return statement in try block with multi-catch causes ClassFormatError Summary: Wrong nested loops in Gen.java causes javac to generate bad bytecode Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/multicatch/T6978574.java From alan.bateman at oracle.com Mon Aug 23 09:38:39 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 23 Aug 2010 16:38:39 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100823163858.03F76473BA@hg.openjdk.java.net> Changeset: 47ab0dcec3e8 Author: alanb Date: 2010-08-23 17:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/47ab0dcec3e8 6978511: (file) Path.toRealPath should fail if not resolving links and file does not exist Reviewed-by: forax, chegar ! src/solaris/classes/sun/nio/fs/UnixPath.java ! test/java/nio/file/Path/Misc.java Changeset: f4a2b4e7a831 Author: alanb Date: 2010-08-23 17:35 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4a2b4e7a831 6431344: (fc) FileChannel.transferTo() doesn't work if address space runs out Reviewed-by: forax, chegar ! src/share/classes/sun/nio/ch/FileChannelImpl.java From jonathan.gibbons at oracle.com Mon Aug 23 11:57:57 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 23 Aug 2010 18:57:57 +0000 Subject: hg: jdk7/tl/langtools: 6975005: improve JavacProcessingEnvironment.Round abstraction Message-ID: <20100823185759.33223473C0@hg.openjdk.java.net> Changeset: 6b95dd682538 Author: jjg Date: 2010-08-23 11:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6b95dd682538 6975005: improve JavacProcessingEnvironment.Round abstraction Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! test/tools/javac/T6358024.java ! test/tools/javac/T6403466.out ! test/tools/javac/processing/filer/TestLastRound.out From kumar.x.srinivasan at oracle.com Mon Aug 23 12:44:11 2010 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 23 Aug 2010 19:44:11 +0000 Subject: hg: jdk7/tl/jdk: 6531345: Memory leak in unpack200 Message-ID: <20100823194420.90502473C2@hg.openjdk.java.net> Changeset: 6317f7e2c4fd Author: ksrini Date: 2010-08-23 08:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6317f7e2c4fd 6531345: Memory leak in unpack200 Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java + test/tools/pack200/UnpackerMemoryTest.java ! test/tools/pack200/Utils.java From chris.hegarty at oracle.com Mon Aug 23 14:00:32 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 23 Aug 2010 21:00:32 +0000 Subject: hg: jdk7/tl/jdk: 6977851: NPE from FileURLConnection.connect Message-ID: <20100823210042.D30B2473C8@hg.openjdk.java.net> Changeset: cb67f0263bd4 Author: chegar Date: 2010-08-23 21:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb67f0263bd4 6977851: NPE from FileURLConnection.connect Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/file/FileURLConnection.java + test/sun/net/www/protocol/file/DirPermissionDenied.java + test/sun/net/www/protocol/file/DirPermissionDenied.sh From jonathan.gibbons at oracle.com Mon Aug 23 15:13:31 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 23 Aug 2010 22:13:31 +0000 Subject: hg: jdk7/tl/langtools: 6976747: JCDiagnostic: replace "boolean mandatory" with new "Set" Message-ID: <20100823221333.A95CE473CB@hg.openjdk.java.net> Changeset: a626d8c1de6e Author: jjg Date: 2010-08-23 15:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a626d8c1de6e 6976747: JCDiagnostic: replace "boolean mandatory" with new "Set" Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java From kumar.x.srinivasan at oracle.com Mon Aug 23 17:21:38 2010 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Tue, 24 Aug 2010 00:21:38 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100824002158.9C155473D2@hg.openjdk.java.net> Changeset: 2585368bfc7c Author: ksrini Date: 2010-08-23 10:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2585368bfc7c 6969063: (pack200) The default value of Pack200.Packer.SEGMENT_LIMIT property is empty string instead of -1 Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java + test/tools/pack200/Pack200Props.java - test/tools/pack200/SegmentLimit.java Changeset: 732f59013e78 Author: ksrini Date: 2010-08-23 10:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/732f59013e78 6966740: (pack200) need to add the timezone regression test Reviewed-by: jrose + test/tools/pack200/TimeStamp.java ! test/tools/pack200/Utils.java From Weijun.Wang at Sun.COM Tue Aug 24 01:06:18 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Tue, 24 Aug 2010 16:06:18 +0800 Subject: code review request: 6979329: CCacheInputStream fails to read ticket cache files from Kerberos 1.8.1 Message-ID: <4C737D7A.4060609@sun.com> HI All webrev at -- http://cr.openjdk.java.net/~weijun/6979329/webrev.00/ I'm not sure if there will be other type of non-ticket entries later, so just ignore once an exception is thrown. I'll be glad if there can be more than one code reviewers. Mostly likely this will need to backported to update releases of JDK 6. Thanks Max -------- Original Message -------- *Change Request ID*: 6979329 *Synopsis*: CCacheInputStream fails to read ticket cache files from Kerberos 1.8.1 === *Description* ============================================================ FULL PRODUCT VERSION : java version "1.6.0_20" Java(TM) SE Runtime Environment (build 1.6.0_20-b02) Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode) ADDITIONAL OS VERSION INFORMATION : Linux thomas 2.6.32-24-generic #39-Ubuntu SMP Wed Jul 28 05:14:15 UTC 2010 x86_64 GNU/Linux EXTRA RELEVANT SYSTEM CONFIGURATION : Kerberos 1.8.1 A DESCRIPTION OF THE PROBLEM : Kerberos 1.8.1 introduced a new feature by which configuration settings can be stored in the ticket cache file using a special principal name: http://krbdev.mit.edu/rt/Ticket/Display.html?user=guest&pass=guest&id=6206 This breaks CCacheInputStream in such a way that the entire ticket cache file is unreadable. STEPS TO FOLLOW TO REPRODUCE THE PROBLEM : - Install Kerberos 1.8.1 or later - kinit - strings /path/to/ticketcache | grep X-CACHE If X-CACHE is in the file, then the Krb5Login module will not be able to make use of the cache. EXPECTED VERSUS ACTUAL BEHAVIOR : EXPECTED - Ticket cache is parsed correctly with new-style configuration credentials ignored. ACTUAL - Ticket cache fails to load. Debug output shows an exception trying to parse the configuration variable "yes" as if it were an encrypted ticket. ERROR MESSAGES/STACK TRACES THAT OCCUR : >>>DEBUG client principal is atm at ATM-LOCAL >>>DEBUG server principal is X-CACHECONF:/krb5_ccache_conf_data/fast_avail/krbtgt/ATM-LOCAL at ATM-LOCAL >>>DEBUG key type: 0 >>>DEBUG auth time: Wed Dec 31 16:00:00 PST 1969 >>>DEBUG start time: Wed Dec 31 16:00:00 PST 1969 >>>DEBUG end time: Wed Dec 31 16:00:00 PST 1969 >>>DEBUG renew_till time: Wed Dec 31 16:00:00 PST 1969 >>> CCacheInputStream: readFlags() java.io.IOException: extra data given to DerValue constructor at sun.security.util.DerValue.init(DerValue.java:368) at sun.security.util.DerValue.(DerValue.java:277) at sun.security.krb5.internal.Ticket.(Ticket.java:81) at sun.security.krb5.internal.ccache.CCacheInputStream.readData(CCacheInputStream.java:250) at sun.security.krb5.internal.ccache.CCacheInputStream.readCred(CCacheInputStream.java:357) at sun.security.krb5.internal.ccache.FileCredentialsCache.load(FileCredentialsCache.java:225) at sun.security.krb5.internal.ccache.FileCredentialsCache.acquireInstance(FileCredentialsCache.java:104) at sun.security.krb5.internal.ccache.CredentialsCache.getInstance(CredentialsCache.java:75) at sun.security.krb5.Credentials.acquireTGTFromCache(Credentials.java:309) at com.sun.security.auth.module.Krb5LoginModule.attemptAuthentication(Krb5LoginModule.java:589) at com.sun.security.auth.module.Krb5LoginModule.login(Krb5LoginModule.java:542) REPRODUCIBILITY : This bug can be reproduced always. CUSTOMER SUBMITTED WORKAROUND : On Kerberos 1.8.1, renewing the local kerberos ticket with "kinit -R" drops the special configuration credential initially added by "kinit", allowing this to succeed. The following patch resolves the problem: diff -r krb5.orig/internal/ccache/CCacheInputStream.java krb5.new/internal/ccache/CCacheInputStream.java 362a363,367 > if (isConfigurationPrincipal(spname)) { > skipLengthPrefixedData(); // skip ticket > skipLengthPrefixedData(); // skip secondary ticket > return null; > } 375a381,400 > > /** > * Return true if the given principal corresponds to a non-ticket configuration > * entry in the cache file. > */ > private boolean isConfigurationPrincipal(PrincipalName princ) { > String[] components = princ.getNameStrings(); > return (components.length > 2 && > PrincipalName.CONFIGURATION_REALM.equals(components[0]) && > PrincipalName.CONFIGURATION_NAME.equals(components[1])); > } > > /** > * Read a 32-bit length from the stream and skip an equal number of bytes. > */ > private void skipLengthPrefixedData() throws IOException { > int skip = read(4); > byte[] skipbuf = new byte[skip]; > read(skipbuf, 0, skip); > } diff -r krb5.orig/internal/ccache/FileCredentialsCache.java krb5.new/internal/ccache/FileCredentialsCache.java 189c189,192 < credentialsList.addElement(cis.readCred(version)); --- > Credentials cred = cis.readCred(version); > if (cred != null) { > credentialsList.addElement(cred); > } diff -r krb5.orig/PrincipalName.java krb5.new/PrincipalName.java 89a90,99 > /** > * The realm used for non-ticket configuration data stored in ccache > */ > public static final String CONFIGURATION_REALM = "X-CACHECONF:"; > > /** > * The nameused for non-ticket configuration data stored in ccache > */ > public static final String CONFIGURATION_NAME = "krb5_ccache_conf_data"; > *** (#1 of 1): 2010-08-24 01:26:27 GMT+00:00 weijun.wang at sun.com From ahughes at redhat.com Tue Aug 24 05:29:08 2010 From: ahughes at redhat.com (ahughes at redhat.com) Date: Tue, 24 Aug 2010 12:29:08 +0000 Subject: hg: jdk7/tl: 6976186: Integrate Shark Message-ID: <20100824122908.2F04A473ED@hg.openjdk.java.net> Changeset: 1fbed32d2ddd Author: gbenson Date: 2010-08-24 13:27 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/rev/1fbed32d2ddd 6976186: Integrate Shark Summary: Shark is a JIT compiler for Zero that uses the LLVM compiler infrastructure. Reviewed-by: ohair ! make/hotspot-rules.gmk From jonathan.gibbons at oracle.com Tue Aug 24 11:31:02 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 24 Aug 2010 18:31:02 +0000 Subject: hg: jdk7/tl/langtools: 6935638: -implicit:none prevents compilation with annotation processing Message-ID: <20100824183104.4CEC8473FD@hg.openjdk.java.net> Changeset: e9d09e97d669 Author: jjg Date: 2010-08-24 11:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e9d09e97d669 6935638: -implicit:none prevents compilation with annotation processing Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/processing/options/TestImplicitNone.java From jonathan.gibbons at oracle.com Tue Aug 24 15:09:37 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 24 Aug 2010 22:09:37 +0000 Subject: hg: jdk7/tl/langtools: 6929404: Filer.getResource(SOURCE_PATH, ...) does not work when -sourcepath contains >1 entry Message-ID: <20100824220939.CA0CE47405@hg.openjdk.java.net> Changeset: f3323b1c65ee Author: jjg Date: 2010-08-24 15:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f3323b1c65ee 6929404: Filer.getResource(SOURCE_PATH, ...) does not work when -sourcepath contains >1 entry Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java + test/tools/javac/processing/filer/TestGetResource2.java From Weijun.Wang at Sun.COM Tue Aug 24 22:23:06 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Wed, 25 Aug 2010 13:23:06 +0800 Subject: code review request: 6911951: NTLM should be a supported Java SASL mechanism In-Reply-To: References: <11045826.1262579400345.JavaMail.sbladm@swsblss3-new> Message-ID: <4C74A8BA.4020603@sun.com> Ping again. The webrev is updated: http://cr.openjdk.java.net/~weijun/6911951/webrev.01/ The CCC is about to be finalized: http://ccc.sfbay.sun.com/6911951 Thanks Max On 04/16/2010 11:12 AM, Weijun Wang wrote: > Vinnie > > Please take a review on this webrev: > > cr.openjdk.java.net/~weijun/6911951/webrev.00/ > > I've updated the spec a little by making NTLMv2 as the default version. It has been supported for a long time and now default with Windows 7 and Server 2008 R2. > > Networking guys, are you OK with the rewrite of NTLMAuthentication? > > Thanks > Max > > On Jan 4, 2010, at 12:30 PM, Weijun.Wang at Sun.COM wrote: > >> >> *Change Request ID*: 6911951 >> >> *Synopsis*: NTLM should be a supported Java SASL mechanism >> >> === *Description* ============================================================ >> The NTLM support currently available for HTTP authentication should be generalized >> and made available as a Java SASL mechanism for use with other protocols. > From vincent.x.ryan at oracle.com Wed Aug 25 10:48:11 2010 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 25 Aug 2010 18:48:11 +0100 Subject: code review request: 6911951: NTLM should be a supported Java SASL mechanism In-Reply-To: <4C74A8BA.4020603@sun.com> References: <11045826.1262579400345.JavaMail.sbladm@swsblss3-new> <4C74A8BA.4020603@sun.com> Message-ID: <4C75575B.4070001@oracle.com> The SASL component looks good Max. Michael/Chris: have you any comments on the NTLM changes? On 25/08/2010 06:23, Weijun Wang wrote: > Ping again. > > The webrev is updated: > http://cr.openjdk.java.net/~weijun/6911951/webrev.01/ > > The CCC is about to be finalized: > http://ccc.sfbay.sun.com/6911951 > > Thanks > Max > > On 04/16/2010 11:12 AM, Weijun Wang wrote: >> Vinnie >> >> Please take a review on this webrev: >> >> cr.openjdk.java.net/~weijun/6911951/webrev.00/ >> >> I've updated the spec a little by making NTLMv2 as the default >> version. It has been supported for a long time and now default with >> Windows 7 and Server 2008 R2. >> >> Networking guys, are you OK with the rewrite of NTLMAuthentication? >> >> Thanks >> Max >> >> On Jan 4, 2010, at 12:30 PM, Weijun.Wang at Sun.COM wrote: >> >>> >>> *Change Request ID*: 6911951 >>> >>> *Synopsis*: NTLM should be a supported Java SASL mechanism >>> >>> === *Description* >>> ============================================================ >>> The NTLM support currently available for HTTP authentication should >>> be generalized >>> and made available as a Java SASL mechanism for use with other >>> protocols. >> From jonathan.gibbons at oracle.com Wed Aug 25 11:24:31 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 25 Aug 2010 18:24:31 +0000 Subject: hg: jdk7/tl/langtools: 6979564: ":" for path separator in dist/bin/javac does not work on Windows Message-ID: <20100825182439.D167E47433@hg.openjdk.java.net> Changeset: 6ef801fa38b7 Author: jjg Date: 2010-08-25 11:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6ef801fa38b7 6979564: ":" for path separator in dist/bin/javac does not work on Windows Reviewed-by: jjh ! make/build.xml ! src/share/bin/launcher.sh-template From jonathan.gibbons at oracle.com Wed Aug 25 11:40:42 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 25 Aug 2010 18:40:42 +0000 Subject: hg: jdk7/tl/langtools: 6960424: new option -Xpkginfo for better control of when package-info.class is generated Message-ID: <20100825184044.1AF2847435@hg.openjdk.java.net> Changeset: 70ebdef189c9 Author: jjg Date: 2010-08-25 11:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/70ebdef189c9 6960424: new option -Xpkginfo for better control of when package-info.class is generated Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/OptionName.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/TestPkgInfo.java From joe.darcy at oracle.com Wed Aug 25 15:36:04 2010 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 25 Aug 2010 22:36:04 +0000 Subject: hg: jdk7/tl/jdk: 6980019: Finish rename of ARM -> try-with-resources in jdk repository Message-ID: <20100825223613.A1FB447440@hg.openjdk.java.net> Changeset: 93c49f01a4c2 Author: darcy Date: 2010-08-25 15:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/93c49f01a4c2 6980019: Finish rename of ARM -> try-with-resources in jdk repository Reviewed-by: jjg ! src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/java/lang/Throwable.java From naoto.sato at oracle.com Wed Aug 25 15:35:33 2010 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 25 Aug 2010 22:35:33 +0000 Subject: hg: jdk7/tl/langtools: 6875847: Java Locale Enhancement Message-ID: <20100825223535.1EC594743F@hg.openjdk.java.net> Changeset: ecff24121064 Author: naoto Date: 2010-08-25 15:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ecff24121064 6875847: Java Locale Enhancement Summary: Fix for javac to allow "sun.util.locale" package accessible. Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/resources/legacy.properties From tomas at primekey.se Wed Aug 25 21:37:38 2010 From: tomas at primekey.se (Tomas Gustavsson) Date: Thu, 26 Aug 2010 06:37:38 +0200 Subject: Supporting SHA224WithECDSA Message-ID: <4C75EF92.5080703@primekey.se> Hi, The PKCS#11 provider currently does not support SHA224WithECDSA, although this is becoming a popular algorithm. I have hacked it myself to support this and the patch is basically trivial. Is it possible to get this support in the JDK? It requires only trivial modifications to AgorithmId.java, P11Signature.java and SunPKCS11.java. Regards, Tomas From mstjohns at comcast.net Wed Aug 25 21:58:12 2010 From: mstjohns at comcast.net (Michael StJohns) Date: Thu, 26 Aug 2010 00:58:12 -0400 Subject: Supporting SHA224WithECDSA In-Reply-To: <4C75EF92.5080703@primekey.se> References: <4C75EF92.5080703@primekey.se> Message-ID: <20100826045819.ABEEC6FBC@mail.openjdk.java.net> Hi Tomas - I think the current provider is a PKCS11 v2.20 based provider. SHA224withECDSA is being added in v2.30. I remember seeing someone mention an intention to do wholesale pass on PKCS11 to update to 2.30 at some point, but I don't think that's in progress yet. A quick look at the current JDK7 has support for SHA224withECDSA in AlgorithmId.java already... Mike At 12:37 AM 8/26/2010, Tomas Gustavsson wrote: >Hi, > >The PKCS#11 provider currently does not support SHA224WithECDSA, although this is becoming a popular algorithm. >I have hacked it myself to support this and the patch is basically trivial. Is it possible to get this support in the JDK? > >It requires only trivial modifications to AgorithmId.java, P11Signature.java and SunPKCS11.java. > >Regards, >Tomas From michael.x.mcmahon at oracle.com Thu Aug 26 03:57:06 2010 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Thu, 26 Aug 2010 11:57:06 +0100 Subject: code review request: 6911951: NTLM should be a supported Java SASL mechanism In-Reply-To: <4C75575B.4070001@oracle.com> References: <11045826.1262579400345.JavaMail.sbladm@swsblss3-new> <4C74A8BA.4020603@sun.com> <4C75575B.4070001@oracle.com> Message-ID: <4C764882.8090105@oracle.com> Why is the serialVersionUid changed in NTLMAuthentication? Otherwise, the encapsulation of NTLM in the new API looks quite concise and neat to me? Looks fine. - Michael Vincent Ryan wrote: > The SASL component looks good Max. > > Michael/Chris: have you any comments on the NTLM changes? > > > > On 25/08/2010 06:23, Weijun Wang wrote: > >> Ping again. >> >> The webrev is updated: >> http://cr.openjdk.java.net/~weijun/6911951/webrev.01/ >> >> The CCC is about to be finalized: >> http://ccc.sfbay.sun.com/6911951 >> >> Thanks >> Max >> >> On 04/16/2010 11:12 AM, Weijun Wang wrote: >> >>> Vinnie >>> >>> Please take a review on this webrev: >>> >>> cr.openjdk.java.net/~weijun/6911951/webrev.00/ >>> >>> I've updated the spec a little by making NTLMv2 as the default >>> version. It has been supported for a long time and now default with >>> Windows 7 and Server 2008 R2. >>> >>> Networking guys, are you OK with the rewrite of NTLMAuthentication? >>> >>> Thanks >>> Max >>> >>> On Jan 4, 2010, at 12:30 PM, Weijun.Wang at Sun.COM wrote: >>> >>> >>>> *Change Request ID*: 6911951 >>>> >>>> *Synopsis*: NTLM should be a supported Java SASL mechanism >>>> >>>> === *Description* >>>> ============================================================ >>>> The NTLM support currently available for HTTP authentication should >>>> be generalized >>>> and made available as a Java SASL mechanism for use with other >>>> protocols. >>>> > > From Weijun.Wang at Sun.COM Thu Aug 26 04:58:35 2010 From: Weijun.Wang at Sun.COM (Weijun Wang) Date: Thu, 26 Aug 2010 19:58:35 +0800 Subject: code review request: 6911951: NTLM should be a supported Java SASL mechanism In-Reply-To: <4C764882.8090105@oracle.com> References: <11045826.1262579400345.JavaMail.sbladm@swsblss3-new> <4C74A8BA.4020603@sun.com> <4C75575B.4070001@oracle.com> <4C764882.8090105@oracle.com> Message-ID: <4C7656EB.1080606@sun.com> The internal structure of NTLMAuthentication is changed and that's why I changed the serialVersionUid as well. If unchanged, I guess the old serialized form can still be accepted by the new class, but all new field will become null/0. After the change, any such deserialization should throw a exception immediately. Of course this means if someone really depends on serialization to work between different versions of JDK, it would be broken. Is there a reason why this class, child of AuthenticationInfo, child of AuthCacheValue, is declared Serializable at the beginning? Thanks Max On 08/26/2010 06:57 PM, Michael McMahon wrote: > Why is the serialVersionUid changed in NTLMAuthentication? > > Otherwise, the encapsulation of NTLM in the new API looks quite > concise and neat to me? Looks fine. > > - Michael > > Vincent Ryan wrote: >> The SASL component looks good Max. >> >> Michael/Chris: have you any comments on the NTLM changes? >> >> >> >> On 25/08/2010 06:23, Weijun Wang wrote: >>> Ping again. >>> >>> The webrev is updated: >>> http://cr.openjdk.java.net/~weijun/6911951/webrev.01/ >>> >>> The CCC is about to be finalized: >>> http://ccc.sfbay.sun.com/6911951 >>> >>> Thanks >>> Max >>> >>> On 04/16/2010 11:12 AM, Weijun Wang wrote: >>>> Vinnie >>>> >>>> Please take a review on this webrev: >>>> >>>> cr.openjdk.java.net/~weijun/6911951/webrev.00/ >>>> >>>> I've updated the spec a little by making NTLMv2 as the default >>>> version. It has been supported for a long time and now default with >>>> Windows 7 and Server 2008 R2. >>>> >>>> Networking guys, are you OK with the rewrite of NTLMAuthentication? >>>> >>>> Thanks >>>> Max >>>> >>>> On Jan 4, 2010, at 12:30 PM, Weijun.Wang at Sun.COM wrote: >>>> >>>>> *Change Request ID*: 6911951 >>>>> >>>>> *Synopsis*: NTLM should be a supported Java SASL mechanism >>>>> >>>>> === *Description* >>>>> ============================================================ >>>>> The NTLM support currently available for HTTP authentication should >>>>> be generalized >>>>> and made available as a Java SASL mechanism for use with other >>>>> protocols. >> > From michael.x.mcmahon at oracle.com Thu Aug 26 05:24:19 2010 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Thu, 26 Aug 2010 13:24:19 +0100 Subject: code review request: 6911951: NTLM should be a supported Java SASL mechanism In-Reply-To: <4C7656EB.1080606@sun.com> References: <11045826.1262579400345.JavaMail.sbladm@swsblss3-new> <4C74A8BA.4020603@sun.com> <4C75575B.4070001@oracle.com> <4C764882.8090105@oracle.com> <4C7656EB.1080606@sun.com> Message-ID: <4C765CF3.1010402@oracle.com> Weijun Wang wrote: > The internal structure of NTLMAuthentication is changed and that's why > I changed the serialVersionUid as well. If unchanged, I guess the old > serialized form can still be accepted by the new class, but all new > field will become null/0. After the change, any such deserialization > should throw a exception immediately. > > Of course this means if someone really depends on serialization to > work between different versions of JDK, it would be broken. Is there a > reason why this class, child of AuthenticationInfo, child of > AuthCacheValue, is declared Serializable at the beginning? > It seems to be historical, and may have been used in the earliest days when the code was part of a browser. I guess it doesn't matter really then whether the serial uid is changed or left the same. It's an implementation class, and not public. Thanks Michael. From jonathan.gibbons at oracle.com Thu Aug 26 15:17:47 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 26 Aug 2010 22:17:47 +0000 Subject: hg: jdk7/tl/langtools: 6604599: ToolProvider should be less compiler-specific Message-ID: <20100826221748.E1EAC4747A@hg.openjdk.java.net> Changeset: cfd047f3cf60 Author: jjg Date: 2010-08-26 15:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/cfd047f3cf60 6604599: ToolProvider should be less compiler-specific Reviewed-by: darcy ! src/share/classes/javax/tools/ToolProvider.java + test/tools/javac/api/ToolProvider/HelloWorldTest.java + test/tools/javac/api/ToolProvider/ToolProviderTest1.java + test/tools/javac/api/ToolProvider/ToolProviderTest2.java From jonathan.gibbons at oracle.com Thu Aug 26 16:13:57 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 26 Aug 2010 23:13:57 +0000 Subject: hg: jdk7/tl/langtools: 6980017: javap -XDdetail:source behaves badly if source not available. Message-ID: <20100826231402.47CB34747F@hg.openjdk.java.net> Changeset: ae3acbf63943 Author: jjg Date: 2010-08-26 16:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ae3acbf63943 6980017: javap -XDdetail:source behaves badly if source not available. Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/SourceWriter.java + test/tools/javap/T6980017.java From tomas at primekey.se Fri Aug 27 01:16:13 2010 From: tomas at primekey.se (Tomas Gustavsson) Date: Fri, 27 Aug 2010 10:16:13 +0200 Subject: Supporting SHA224WithECDSA In-Reply-To: <20100826050634.9E1E3C3CDD@mail.primekey.se> References: <4C75EF92.5080703@primekey.se> <20100826050634.9E1E3C3CDD@mail.primekey.se> Message-ID: <4C77744D.80802@primekey.se> I see thanks for the reply. If the plans would somehow materialize we're glad to assist. I did test my patch adding SHA224withECDSA against a SafeNet HSM and it works fine. I'll take a look at jdk7 as well. Cheers, Tomas On 08/26/2010 06:58 AM, Michael StJohns wrote: > Hi Tomas - > > I think the current provider is a PKCS11 v2.20 based provider. SHA224withECDSA is being added in v2.30. I remember seeing someone mention an intention to do wholesale pass on PKCS11 to update to 2.30 at some point, but I don't think that's in progress yet. > > A quick look at the current JDK7 has support for SHA224withECDSA in AlgorithmId.java already... > > Mike > > > > At 12:37 AM 8/26/2010, Tomas Gustavsson wrote: > >> Hi, >> >> The PKCS#11 provider currently does not support SHA224WithECDSA, although this is becoming a popular algorithm. >> I have hacked it myself to support this and the patch is basically trivial. Is it possible to get this support in the JDK? >> >> It requires only trivial modifications to AgorithmId.java, P11Signature.java and SunPKCS11.java. >> >> Regards, >> Tomas > From jonathan.gibbons at oracle.com Fri Aug 27 17:15:21 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sat, 28 Aug 2010 00:15:21 +0000 Subject: hg: jdk7/tl/langtools: 6980724: test/tools/javac/InterfaceAssert.java sometimes fails Message-ID: <20100828001523.5E57B474CE@hg.openjdk.java.net> Changeset: 3a9f319be48a Author: jjg Date: 2010-08-27 17:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3a9f319be48a 6980724: test/tools/javac/InterfaceAssert.java sometimes fails Reviewed-by: darcy ! test/tools/javac/InterfaceAssert.java From jonathan.gibbons at oracle.com Fri Aug 27 17:21:05 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sat, 28 Aug 2010 00:21:05 +0000 Subject: hg: jdk7/tl/langtools: 6570730: com.sun.source.tree.ModifiersTree.getFlags() should return class type Message-ID: <20100828002107.6DB23474CF@hg.openjdk.java.net> Changeset: b4e7a57af8df Author: jjg Date: 2010-08-27 17:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b4e7a57af8df 6570730: com.sun.source.tree.ModifiersTree.getFlags() should return class type Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java - test/tools/javac/T6341023.java + test/tools/javac/tree/ClassTreeTest.java + test/tools/javac/tree/TreeKindTest.java From jonathan.gibbons at oracle.com Fri Aug 27 17:59:21 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sat, 28 Aug 2010 00:59:21 +0000 Subject: hg: jdk7/tl/langtools: 6980707: Reduce use of IOException in JavaCompiler Message-ID: <20100828005922.F1F49474D2@hg.openjdk.java.net> Changeset: eb7c263aab73 Author: jjg Date: 2010-08-27 17:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/eb7c263aab73 6980707: Reduce use of IOException in JavaCompiler Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/FatalError.java ! test/tools/javac/diags/examples.not-yet.txt From martinrb at google.com Sat Aug 28 12:20:29 2010 From: martinrb at google.com (martinrb at google.com) Date: Sat, 28 Aug 2010 19:20:29 +0000 Subject: hg: jdk7/tl/jdk: 6980747: Runtime.exec can fail due to SecurityException (lnx) Message-ID: <20100828192038.BD37F474F8@hg.openjdk.java.net> Changeset: 1470dffe6551 Author: martin Date: 2010-08-28 12:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1470dffe6551 6980747: Runtime.exec can fail due to SecurityException (lnx) Summary: Add missing doPrivileged to UNIXProcess.java.linux Reviewed-by: alanb ! src/solaris/classes/java/lang/UNIXProcess.java.linux + test/java/lang/ProcessBuilder/SecurityManagerClinit.java From weijun.wang at sun.com Mon Aug 30 00:29:59 2010 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Mon, 30 Aug 2010 07:29:59 +0000 Subject: hg: jdk7/tl/jdk: 6911951: NTLM should be a supported Java SASL mechanism Message-ID: <20100830073009.75A1047541@hg.openjdk.java.net> Changeset: 9be643e70f42 Author: weijun Date: 2010-08-30 14:37 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9be643e70f42 6911951: NTLM should be a supported Java SASL mechanism Reviewed-by: vinnie, michaelm + src/share/classes/com/sun/security/ntlm/Client.java + src/share/classes/com/sun/security/ntlm/NTLM.java + src/share/classes/com/sun/security/ntlm/NTLMException.java + src/share/classes/com/sun/security/ntlm/Server.java + src/share/classes/com/sun/security/ntlm/Version.java ! src/share/classes/com/sun/security/sasl/Provider.java + src/share/classes/com/sun/security/sasl/ntlm/FactoryImpl.java + src/share/classes/com/sun/security/sasl/ntlm/NTLMClient.java + src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java ! src/solaris/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java + test/com/sun/security/sasl/ntlm/NTLMTest.java From jonathan.gibbons at oracle.com Mon Aug 30 18:03:57 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 31 Aug 2010 01:03:57 +0000 Subject: hg: jdk7/tl/langtools: 6403465: javac should defer diagnostics until it can be determined they are persistent Message-ID: <20100831010359.3E5A947568@hg.openjdk.java.net> Changeset: 4124840b35fe Author: jjg Date: 2010-08-30 18:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4124840b35fe 6403465: javac should defer diagnostics until it can be determined they are persistent Reviewed-by: mcimadamore, darcy ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! test/tools/javac/processing/6430209/b6341534.java + test/tools/javac/processing/errors/TestSuppression.java From mandy.chung at oracle.com Tue Aug 31 09:19:33 2010 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 31 Aug 2010 16:19:33 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20100831161952.0AC864758A@hg.openjdk.java.net> Changeset: 6586ab5b79f4 Author: mchung Date: 2010-08-31 09:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6586ab5b79f4 6981005: TEST BUG: java/lang/ClassLoader/TestCrossDelegate.sh timeout on windows Summary: Increase timeout value Reviewed-by: alanb ! test/ProblemList.txt ! test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh Changeset: def50d3ad78e Author: mchung Date: 2010-08-31 09:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/def50d3ad78e 6977548: Broken link in ClassLoader.defineClass javadoc Reviewed-by: valeriep ! src/share/classes/java/lang/ClassLoader.java From kelly.ohair at oracle.com Tue Aug 31 15:51:20 2010 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Tue, 31 Aug 2010 22:51:20 +0000 Subject: hg: jdk7/tl/corba: 2 new changesets Message-ID: <20100831225121.E937F475A2@hg.openjdk.java.net> Changeset: 519daea48888 Author: cl Date: 2010-08-13 11:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/519daea48888 Added tag jdk7-b105 for changeset 6f21b030092f ! .hgtags Changeset: 0f60cf26c5b5 Author: ohair Date: 2010-08-30 14:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/0f60cf26c5b5 6981043: Clean out all native code makefile logic from corba repository Reviewed-by: jjg ! make/Makefile ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/common/Defs.gmk - make/common/Library.gmk - make/common/Mapfile-vers.gmk ! make/common/Rules.gmk - make/common/internal/NativeCompileRules.gmk - make/common/shared/Compiler-gcc.gmk - make/common/shared/Compiler-msvc.gmk - make/common/shared/Compiler-sun.gmk - make/common/shared/Compiler.gmk ! make/common/shared/Defs-java.gmk ! make/common/shared/Defs-linux.gmk ! make/common/shared/Defs-solaris.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Platform.gmk ! make/org/omg/idl/Makefile From kelly.ohair at oracle.com Tue Aug 31 15:49:35 2010 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Tue, 31 Aug 2010 22:49:35 +0000 Subject: hg: jdk7/tl/jaxws: 6962317: jdk7 jaxws source bundle still needs rebranding; ... Message-ID: <20100831224935.D045B475A0@hg.openjdk.java.net> Changeset: c6c2f9094bdd Author: ohair Date: 2010-08-30 16:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/c6c2f9094bdd 6962317: jdk7 jaxws source bundle still needs rebranding 6955300: Missing files in the jaf source bundle Reviewed-by: ramap ! jaxws.properties From valerie.peng at oracle.com Tue Aug 31 17:20:07 2010 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 31 Aug 2010 17:20:07 -0700 Subject: Code review request for 6687725 and 6848930 Message-ID: <4C7D9C37.7060807@oracle.com> Hi, Brad, Do you have time to review these two PKCS11 fixes? They are straight forward. 6687725: Internal PKCS5Padding impl should throw IllegalBlockSizeException and not BadPaddingException Webrev - http://cr.openjdk.java.net/~valeriep/6687725 6848930: JSN security test jce/Global/Cipher/PKCS5Padding cannot thrown expected BadPaddingException Webrev - http://cr.openjdk.java.net/~valeriep/6848930 Note: This is same as the changes made for 6U release, to workaround different Solaris impls. Thanks! Valerie From valerie.peng at oracle.com Tue Aug 31 17:33:03 2010 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 31 Aug 2010 17:33:03 -0700 Subject: Code review request for 6850402 and 6887853 Message-ID: <4C7D9F3F.9010402@oracle.com> Hi, Sean, Do you have time to review these two fixes? 6850402: Deadlock on sun.security.jca.ProviderConfig starting from jdk7-b55 http://cr.openjdk.java.net/~valeriep/6850402 Note: verify by re-running the stress test 6887853: javadoc for java.lang.Classloader should be more clear http://cr.openjdk.java.net/~valeriep/6887853 Note: javadoc re-wording only; will file CCC after changes being reviewed Thanks, Valerie From bradford.wetmore at oracle.com Tue Aug 31 17:41:06 2010 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Tue, 31 Aug 2010 17:41:06 -0700 Subject: Code review request for 6687725 and 6848930 In-Reply-To: <4C7D9C37.7060807@oracle.com> References: <4C7D9C37.7060807@oracle.com> Message-ID: <4C7DA122.8020706@oracle.com> Offhand, they look pretty straight forward. I'd like to look closer, but can't right away. Need to stay focused on something else the rest of the week. Brad On 8/31/2010 5:20 PM, Valerie (Yu-Ching) Peng wrote: > Hi, Brad, > > Do you have time to review these two PKCS11 fixes? They are straight > forward. > > 6687725: Internal PKCS5Padding impl should throw > IllegalBlockSizeException and not BadPaddingException > Webrev - http://cr.openjdk.java.net/~valeriep/6687725 > > 6848930: JSN security test jce/Global/Cipher/PKCS5Padding cannot thrown > expected BadPaddingException > Webrev - http://cr.openjdk.java.net/~valeriep/6848930 > Note: This is same as the changes made for 6U release, to workaround > different Solaris impls. > > Thanks! > Valerie