From chris.hegarty at oracle.com Thu Dec 1 05:02:25 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 01 Dec 2011 13:02:25 +0000 Subject: hg: jdk8/tl/jdk: 7116722: Miscellaneous warnings sun.misc ( and related classes ) Message-ID: <20111201130235.EF2FA474E1@hg.openjdk.java.net> Changeset: 3b8186aee592 Author: chegar Date: 2011-12-01 11:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b8186aee592 7116722: Miscellaneous warnings sun.misc ( and related classes ) Reviewed-by: alanb, darcy, forax, hawtin, lancea ! src/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/util/jar/JarVerifier.java ! src/share/classes/java/util/jar/JavaUtilJarAccessImpl.java ! src/share/classes/javax/script/ScriptEngineManager.java ! src/share/classes/sun/misc/BASE64Decoder.java ! src/share/classes/sun/misc/ExtensionDependency.java ! src/share/classes/sun/misc/JarIndex.java ! src/share/classes/sun/misc/JavaUtilJarAccess.java ! src/share/classes/sun/misc/ProxyGenerator.java ! src/share/classes/sun/misc/Service.java ! src/share/classes/sun/misc/Signal.java ! test/sun/misc/JarIndex/metaInfFilenames/Basic.java From Xuelei.Fan at Oracle.Com Thu Dec 1 06:20:22 2011 From: Xuelei.Fan at Oracle.Com (Xuelei Fan) Date: Thu, 1 Dec 2011 22:20:22 +0800 Subject: code review request: 7115524: Regression: keytool -printcert -sslserver failure In-Reply-To: <4ED6F601.8070404@oracle.com> References: <03DF622B-D49A-40D7-9581-4AF32747C9BB@Oracle.Com> <3ABE0759-F871-41D8-A3D0-66896AD4B2F8@oracle.com> <4ED6F601.8070404@oracle.com> Message-ID: Looks fine to me. Xuelei On Dec 1, 2011, at 11:35 AM, Weijun Wang wrote: > Hi Xuelei > > Please review the code changes for 7u4: > > http://cr.openjdk.java.net/~weijun/7115524/7u4/webrev.00/ > > I've changed the synopsis because there is no SSLServerCertStore in 7u4. > > Thanks > Max > > -------------------------------------------------- > 7115524: Regression: keytool -printcert -sslserver failure > > Description: > In 7u4, there is no sun.security.provider.certpath.ssl.SSLServerCertStore. That's because the class was extracted from a KeyTool method in JDK 8 (6953295). However, the same coding error still exists inside the KeyTool method. The synopis for this subCR is updated to reflect the fact. From weijun.wang at oracle.com Thu Dec 1 06:54:57 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 01 Dec 2011 22:54:57 +0800 Subject: Kerberos codes in Apple's Java In-Reply-To: <34482A59-CDB2-4639-BB24-AF788D7C0BB0@apple.com> References: <4E987379.1060501@oracle.com> <34482A59-CDB2-4639-BB24-AF788D7C0BB0@apple.com> Message-ID: <4ED79541.408@oracle.com> Hi Bino >> 2. Reading native memory-based credentials cache into Credentials objects > > I don't think we do this in JDK6 either. I just tried OS X's builtin kinit and klist command: $ kinit dummy Please enter the password for dummy at THREE.LOCAL: $ klist Kerberos 5 ticket cache: 'API:Initial default ccache' ... So here the ccache name is "API:Initial default ccache", which looks like an in-memory ccache. At least I cannot find normal file-based ccache file named /tmp/krb5cc_**. There is also a difference between Apple's JDK 6u29 and the current macosx-port OpenJDK build when calling the following method: sun.security.krb5,Credentials.acquireTGTFromCache() It returns a valid credential (which is identical to the klist output) in Apple's 6u29, but the macosx-port one returns null. So it seems the Apple JDK can see the special ccache object but macosx-port cannot. Thanks Max > > Regards > Bino. > > > > On Oct 14, 2011, at 10:38 AM, Weijun Wang wrote: > >> Hi Mike >> >> I'm working in the Java SE Security Team in Oracle. Apple's JRE (at >> least in the JDK 6 releases) supports some extra Kerberos features for >> OS X. As I know, at least there are: >> >> 1. Looking for krb5.conf at /Library/Preferences/edu.mit.Kerberos >> 2. Reading native memory-based credentials cache into Credentials objects >> >> I didn't see them on the Project Status page [1]. Is it because they >> are too trivial to be listed or you're not going to support them? >> >> Thanks >> Max >> >> [1] http://wikis.sun.com/display/OpenJDK/Mac+OS+X+Port+Project+Status > From sean.mullan at oracle.com Thu Dec 1 07:12:22 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 01 Dec 2011 10:12:22 -0500 Subject: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException In-Reply-To: <4ECC7A87.1030604@gmx.de> References: <4E525386.9000207@gmx.de> <4E52758D.2020208@oracle.com> <4E5E8AE3.3070402@gmx.de> <4E5FE753.2010705@oracle.com> <4E606D1D.6050509@gmx.de> <4E613565.1080801@oracle.com> <4E625E14.9060101@gmx.de> <4E67AF3D.2090609@oracle.com> <4E68FFBD.2030601@gmx.de> <4E6A13A2.2020503@gmx.de> <4E74F05D.7090806@gmx.de> <4E7CD5F8.9000501@oracle.com> <4E7DA91C.2000600@gmx.de> <4E81EDE6.9050205@oracle.com> <4E82A437.30907@gmx.de> <4E86073D.9050101@gmx.de> <4E873DA0.5050906@oracle.com> <4E88C03A.90904@gmx.de> <4EA96FB4.7000502@gmx.de> <4EABE0D5.5050802@gmx.de> <4ECC7A87.1030604@gmx.de> Message-ID: <4ED79956.4020101@oracle.com> On 11/22/2011 11:45 PM, Sebastian Sickelmann wrote: > It's been a long time ago. > Had someone had the time to think about this: > > Am 29.10.2011 13:17, schrieb Sebastian Sickelmann: >> Sorry i linked the wrong webrev for Solution 3. >> >> Am 27.10.2011 16:50, schrieb Sebastian Sickelmann: >>> Some time ago (see below) i ask what would be the right solution to >>> refactor >>> exception initialization to? >>> >>> Solution 1: Disallow calls to initCause after creation, if there was an >>> exception-cause-functionality in this class before it was introduced >>> to Throwable. >>> Solution 2: Disallow calls to initCause after creation with in ctor >>> which has a cause parameter. >>> Solution 3: Disallow calls to initCause after creation, if and only >>> if there are ctors >>> that allows us to specify the cause at creation time. >>> >>> >>> If i investigated it right:: >>> * Solution 1 is used by in the Exceptions in core-libs. >>> * Exceptions that had no cause-chain prior to Throwable's-cause-chain >>> uses Solution 2. >>> * Personally i found Solution 3 is the most intuitive for the users >>> >>> javax/xml/security- Exceptions had cause-chaining prio to Throwable >>> introduces them. jx/x/s-Exceptions are actually not refactored to >>> solution 2 like the other exceptions in core-libs that had >>> cause-chaining prior to Throwable. >>> >>> Before my change-request for jx/x/s-Exceptions i changed some in >>> core-libs (InternalError and VirtualMachineError) to provide >>> exception-chaining. These use Solution 2 like all other exceptions >>> that provided exception-chaining after it where introduced by Throwable. >>> >>> My personal view of this is that i think it may be valueable to >>> change all to Solution 3 or at least merge all Solutions to one >>> Solution(maybe Solution 2) and get rid of Solution 1. >>> I created a webrev[0] for jx/x/s-Exceptions that implements Solution >>> 2 (this can be used for all those Exceptions that used Solution 1 too). webrev[0] looks like it is using Solution 1. Looking at the diffs for KeySelectorException, the ctors that don't supply cause parameters are still forbidden from subsequently calling initCause. >>> The problem with Solution 3 is that bahavoir compatibility is not given >>> and some code may break. Can you please explain what you think the compatibility issues are in more detail? I would also like to see the diffs for solution 2 before I give you my opinion. --Sean >>> And I created a webrev[1] for jx/x/s-Exceptions that implement >>> Solution 3 for comparision. >>> >>> [0] >>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html >>> >>> >> [1] >> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_6/index.html >> > From maurizio.cimadamore at oracle.com Thu Dec 1 10:35:55 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 01 Dec 2011 18:35:55 +0000 Subject: hg: jdk8/tl/jdk: 7116954: Misc warnings in java.beans/java.beans.context Message-ID: <20111201183605.0D411474E9@hg.openjdk.java.net> Changeset: 89130611b178 Author: mcimadamore Date: 2011-12-01 18:34 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89130611b178 7116954: Misc warnings in java.beans/java.beans.context Summary: Remove generic warnings form java.beans and java.beans.context Reviewed-by: alanb, chegar ! src/share/classes/java/beans/BeanDescriptor.java ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/ChangeListenerMap.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/Encoder.java ! src/share/classes/java/beans/EventHandler.java ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/FeatureDescriptor.java ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/MetaData.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/NameGenerator.java ! src/share/classes/java/beans/PersistenceDelegate.java ! src/share/classes/java/beans/PropertyChangeSupport.java ! src/share/classes/java/beans/PropertyDescriptor.java ! src/share/classes/java/beans/PropertyEditorSupport.java ! src/share/classes/java/beans/ReflectionUtils.java ! src/share/classes/java/beans/SimpleBeanInfo.java ! src/share/classes/java/beans/Statement.java ! src/share/classes/java/beans/VetoableChangeSupport.java ! src/share/classes/java/beans/XMLEncoder.java ! src/share/classes/java/beans/beancontext/BeanContext.java ! src/share/classes/java/beans/beancontext/BeanContextMembershipEvent.java From stuart.marks at oracle.com Thu Dec 1 16:14:10 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 02 Dec 2011 00:14:10 +0000 Subject: hg: jdk8/tl/jdk: 7116890: additional warnings fixes for java.io Message-ID: <20111202001420.0DAB8474F8@hg.openjdk.java.net> Changeset: 0e3f706741ca Author: smarks Date: 2011-12-01 16:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e3f706741ca 7116890: additional warnings fixes for java.io Reviewed-by: alanb, smarks Contributed-by: Sebastian Sickelmann ! src/share/classes/java/io/ExpiringCache.java ! src/share/classes/java/io/LineNumberInputStream.java ! src/share/classes/java/io/LineNumberReader.java ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/io/RandomAccessFile.java From sebastian.sickelmann at gmx.de Thu Dec 1 21:54:25 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Fri, 02 Dec 2011 06:54:25 +0100 Subject: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException In-Reply-To: <4ED79956.4020101@oracle.com> References: <4E525386.9000207@gmx.de> <4E52758D.2020208@oracle.com> <4E5E8AE3.3070402@gmx.de> <4E5FE753.2010705@oracle.com> <4E606D1D.6050509@gmx.de> <4E613565.1080801@oracle.com> <4E625E14.9060101@gmx.de> <4E67AF3D.2090609@oracle.com> <4E68FFBD.2030601@gmx.de> <4E6A13A2.2020503@gmx.de> <4E74F05D.7090806@gmx.de> <4E7CD5F8.9000501@oracle.com> <4E7DA91C.2000600@gmx.de> <4E81EDE6.9050205@oracle.com> <4E82A437.30907@gmx.de> <4E86073D.9050101@gmx.de> <4E873DA0.5050906@oracle.com> <4E88C03A.90904@gmx.de> <4EA96FB4.7000502@gmx.de> <4EABE0D5.5050802@gmx.de> <4ECC7A87.1030604@gmx.de> <4ED79956.4020101@oracle.com> Message-ID: <4ED86811.4090804@gmx.de> Am 01.12.2011 16:12, schrieb Sean Mullan: > On 11/22/2011 11:45 PM, Sebastian Sickelmann wrote: >> It's been a long time ago. >> Had someone had the time to think about this: >> >> Am 29.10.2011 13:17, schrieb Sebastian Sickelmann: >>> Sorry i linked the wrong webrev for Solution 3. >>> >>> Am 27.10.2011 16:50, schrieb Sebastian Sickelmann: >>>> Some time ago (see below) i ask what would be the right solution to >>>> refactor >>>> exception initialization to? >>>> >>>> Solution 1: Disallow calls to initCause after creation, if there >>>> was an >>>> exception-cause-functionality in this class before it was introduced >>>> to Throwable. >>>> Solution 2: Disallow calls to initCause after creation with in ctor >>>> which has a cause parameter. >>>> Solution 3: Disallow calls to initCause after creation, if and only >>>> if there are ctors >>>> that allows us to specify the cause at creation time. >>>> >>>> >>>> If i investigated it right:: >>>> * Solution 1 is used by in the Exceptions in core-libs. >>>> * Exceptions that had no cause-chain prior to Throwable's-cause-chain >>>> uses Solution 2. >>>> * Personally i found Solution 3 is the most intuitive for the users >>>> >>>> javax/xml/security- Exceptions had cause-chaining prio to Throwable >>>> introduces them. jx/x/s-Exceptions are actually not refactored to >>>> solution 2 like the other exceptions in core-libs that had >>>> cause-chaining prior to Throwable. >>>> >>>> Before my change-request for jx/x/s-Exceptions i changed some in >>>> core-libs (InternalError and VirtualMachineError) to provide >>>> exception-chaining. These use Solution 2 like all other exceptions >>>> that provided exception-chaining after it where introduced by >>>> Throwable. >>>> >>>> My personal view of this is that i think it may be valueable to >>>> change all to Solution 3 or at least merge all Solutions to one >>>> Solution(maybe Solution 2) and get rid of Solution 1. >>>> I created a webrev[0] for jx/x/s-Exceptions that implements Solution >>>> 2 (this can be used for all those Exceptions that used Solution 1 >>>> too). > > webrev[0] looks like it is using Solution 1. Looking at the diffs for > KeySelectorException, the ctors that don't supply cause parameters are > still forbidden from subsequently calling initCause. > > >>> The problem with Solution 3 is that bahavoir compatibility is not > given > >>> and some code may break. > > Can you please explain what you think the compatibility issues are in > more detail? > > I would also like to see the diffs for solution 2 before I give you my > opinion. > > --Sean > > > >>>> And I created a webrev[1] for jx/x/s-Exceptions that implement >>>> Solution 3 for comparision. >>>> >>>> [0] >>>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html >>>> >>>> >>>> >>> [1] >>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_6/index.html >>> >>> >> > The 3 solutions I mentioned are solutions that can be commonly discussed for a solution choosing for all Exceptions in OpenJDK. Webrev[0] shows solution 1 for jx/x/s-Exceptions. From the users perspective (outside view) solution 1 and 3 are completely similar. Solution 2 are used widely in jdk codebase in Exceptions that had no chaining before it was introduced globally throught java/lang/Throwable. An Example for Solution2 is java/lang/RuntimeException. An webrev that show this jx/x/s-Exception is webrev[1] Solution 3 is actually not used by any Exception in JDK (or I haven't found them) The problem i see is that we now have 2 ways exception-chaining might work. * Solution 1 disallows chaining after creation. * Solution 2 disallows chaining only after creation with an ctors that supports it or after a call to initCause. We should only support one solution. If we introduce the commonly used exception-ctors for every class (which i actually try) we can switch over to an solutions that is consistent for the user. I think every Exception that gives the user the choice to use exception-chaining via a ctor-variant that supports chaining should disallow changes of the exception-chain via initCause even when the exception is created with an ctor that doesn't had chaining parameters. This is what i call Solution 3. Unfortunately Solution 3 introduces an behavior-incompatibility. In JDK every think is fine and we can make all the changes that are needed to do (replace all initCause calls with the right ctor-choice). But in the outside world there maybe users that rely on the feature of plumbing up the exception chain after creation. Those will get an Exception when they call initCause. Maybe we can warn them to not use initCause anymore through marking initCause deprecated. And switch over to solution 3 over several releases (maybe OpenJDK9 or 10) Sorry for the misleading webrev-mappings in my previous mails. Hope to cleared thinks up now (with my wired english ;-) ). -- Sebastian [0] Solution 1 http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html [1] Solution 2 http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_6/index.html From yuka.kamiya at oracle.com Thu Dec 1 23:10:52 2011 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Fri, 02 Dec 2011 07:10:52 +0000 Subject: hg: jdk8/tl/jdk: 7056472: Speed up test/java/util/ResourceBundle/Control/ExpirationTest.sh Message-ID: <20111202071112.F40AC47513@hg.openjdk.java.net> Changeset: b03da32c3186 Author: peytoia Date: 2011-12-02 16:09 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b03da32c3186 7056472: Speed up test/java/util/ResourceBundle/Control/ExpirationTest.sh Reviewed-by: okutsu - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh From chris.hegarty at oracle.com Fri Dec 2 05:34:11 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 02 Dec 2011 13:34:11 +0000 Subject: hg: jdk8/tl/jdk: 7116946: JSSecurityManager should use java.util.ServiceLoader to lookup service providers Message-ID: <20111202133429.9FDB84751A@hg.openjdk.java.net> Changeset: f615db07991e Author: chegar Date: 2011-12-02 11:39 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f615db07991e 7116946: JSSecurityManager should use java.util.ServiceLoader to lookup service providers Reviewed-by: prr ! src/share/classes/com/sun/media/sound/JSSecurityManager.java From sean.mullan at oracle.com Fri Dec 2 08:02:28 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 02 Dec 2011 11:02:28 -0500 Subject: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException In-Reply-To: <4ED86811.4090804@gmx.de> References: <4E525386.9000207@gmx.de> <4E52758D.2020208@oracle.com> <4E5E8AE3.3070402@gmx.de> <4E5FE753.2010705@oracle.com> <4E606D1D.6050509@gmx.de> <4E613565.1080801@oracle.com> <4E625E14.9060101@gmx.de> <4E67AF3D.2090609@oracle.com> <4E68FFBD.2030601@gmx.de> <4E6A13A2.2020503@gmx.de> <4E74F05D.7090806@gmx.de> <4E7CD5F8.9000501@oracle.com> <4E7DA91C.2000600@gmx.de> <4E81EDE6.9050205@oracle.com> <4E82A437.30907@gmx.de> <4E86073D.9050101@gmx.de> <4E873DA0.5050906@oracle.com> <4E88C03A.90904@gmx.de> <4EA96FB4.7000502@gmx.de> <4EABE0D5.5050802@gmx.de> <4ECC7A87.1030604@gmx.de> <4ED79956.4020101@oracle.com> <4ED86811.4090804@gmx.de> Message-ID: <4ED8F694.8010705@oracle.com> On 12/2/11 12:54 AM, Sebastian Sickelmann wrote: > The 3 solutions I mentioned are solutions that can be commonly discussed > for a solution choosing for all Exceptions in OpenJDK. > > Webrev[0] shows solution 1 for jx/x/s-Exceptions. From the users > perspective (outside view) solution 1 and 3 are completely similar. > > Solution 2 are used widely in jdk codebase in Exceptions that had no > chaining before it was introduced globally throught java/lang/Throwable. > An Example for Solution2 is java/lang/RuntimeException. > An webrev that show this jx/x/s-Exception is webrev[1] > > Solution 3 is actually not used by any Exception in JDK (or I haven't > found them) > > The problem i see is that we now have 2 ways exception-chaining might work. > > * Solution 1 disallows chaining after creation. > * Solution 2 disallows chaining only after creation with an ctors that > supports it or after a call to initCause. > > We should only support one solution. > If we introduce the commonly used exception-ctors for every class (which > i actually try) we can switch over to an solutions that is consistent > for the user. I think every Exception that gives the user the choice to > use exception-chaining via a ctor-variant that supports chaining should > disallow changes of the exception-chain via initCause even when the > exception is created with an ctor that doesn't had chaining parameters. > This is what i call Solution 3. > > Unfortunately Solution 3 introduces an behavior-incompatibility. In JDK > every think is fine and we can make all the changes that are needed to > do (replace all initCause calls with the right ctor-choice). But in the > outside world there maybe users that rely on the feature of plumbing up > the exception chain after creation. Right, and I think some of those cases are legitimate. I have seen exception handling code which performs cleanup in a finally block, and if an exception is thrown in the finally block, it catches that exception, but sets the cause of the exception to the original exception. This would not be possible with solution 3 if there was already a ctor that had a cause parameter. For example, I have seen code like this: Throwable t = null; try { ... } catch (Exception x) { t = x; } finally { try { ... } catch (FooException e) { if (t != null) e.initCause(t); throw e; } } > Those will get an Exception when > they call initCause. Maybe we can warn them to not use initCause anymore > through marking initCause deprecated. And switch over to solution 3 over > several releases (maybe OpenJDK9 or 10) My opinion is that the potential compatibility issues, as well as having awkward workarounds for the case above outweigh the advantages of making this change. So I am not in favor of solution 3. But that's just my opinion, others may feel differently. > Sorry for the misleading webrev-mappings in my previous mails. Hope to > cleared thinks up now (with my wired english ;-) ). Ok, so I think we're down to 2 solutions. Give me some more time to look them over more carefully and get back to you. --Sean > > -- Sebastian > > > [0] Solution 1 > http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html > [1] Solution 2 > http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_6/index.html From chris.hegarty at oracle.com Fri Dec 2 08:11:19 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 02 Dec 2011 16:11:19 +0000 Subject: hg: jdk8/tl/jdk: 7116957: javax.script.ScriptEngineManager should use java.util.ServiceLoader to lookup service providers Message-ID: <20111202161129.210C34751E@hg.openjdk.java.net> Changeset: 37f6e294759f Author: chegar Date: 2011-12-02 14:17 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37f6e294759f 7116957: javax.script.ScriptEngineManager should use java.util.ServiceLoader to lookup service providers Reviewed-by: alanb, lancea ! src/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java ! src/share/classes/javax/script/ScriptEngineManager.java ! src/share/classes/sun/net/ftp/FtpClientProvider.java From alan.bateman at oracle.com Fri Dec 2 09:48:39 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 02 Dec 2011 17:48:39 +0000 Subject: hg: jdk8/tl/jdk: 7117357: Warnings in sun.instrument, tools and other sun.* classes Message-ID: <20111202174849.7CBD147520@hg.openjdk.java.net> Changeset: 9950e2c9f3b5 Author: alanb Date: 2011-12-02 17:37 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9950e2c9f3b5 7117357: Warnings in sun.instrument, tools and other sun.* classes Reviewed-by: lancea, chegar ! src/share/classes/sun/instrument/InstrumentationImpl.java ! src/share/classes/sun/instrument/TransformerManager.java ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/management/counter/perf/PerfInstrumentation.java ! src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java ! src/share/classes/sun/net/RegisteredDomain.java ! src/share/classes/sun/net/www/protocol/jar/Handler.java ! src/share/classes/sun/tools/attach/HotSpotAttachProvider.java ! src/share/classes/sun/tools/jinfo/JInfo.java ! src/share/classes/sun/tools/jmap/JMap.java ! src/share/classes/sun/tools/jps/Jps.java ! src/share/classes/sun/tools/jstack/JStack.java ! src/share/classes/sun/tools/serialver/SerialVer.java From naoto.sato at oracle.com Fri Dec 2 16:05:06 2011 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Sat, 03 Dec 2011 00:05:06 +0000 Subject: hg: jdk8/tl/jdk: 7117465: Warning cleanup for IMF classes Message-ID: <20111203000516.221AD47548@hg.openjdk.java.net> Changeset: 42532a097816 Author: naoto Date: 2011-12-02 16:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42532a097816 7117465: Warning cleanup for IMF classes Reviewed-by: okutsu ! src/share/classes/java/awt/im/InputMethodHighlight.java ! src/share/classes/sun/awt/im/CompositionArea.java ! src/share/classes/sun/awt/im/CompositionAreaHandler.java ! src/share/classes/sun/awt/im/InputContext.java ! src/share/classes/sun/awt/im/InputMethodContext.java ! src/share/classes/sun/awt/im/InputMethodJFrame.java ! src/share/classes/sun/awt/im/InputMethodManager.java ! src/share/classes/sun/awt/im/SimpleInputMethodWindow.java From xueming.shen at oracle.com Fri Dec 2 16:24:22 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Sat, 03 Dec 2011 00:24:22 +0000 Subject: hg: jdk8/tl/jdk: 5035850: (str) String.CASE_INSENSITIVE_ORDER should override readResolve() Message-ID: <20111203002432.0B18C47549@hg.openjdk.java.net> Changeset: 1d7037df65ed Author: sherman Date: 2011-12-02 16:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d7037df65ed 5035850: (str) String.CASE_INSENSITIVE_ORDER should override readResolve() Summary: Fix to ensure singleton property of String.CaseInsensitiveComparator is maintained through de/serialization. Reviewed-by: alanb, forax, smarks, dholmes Contributed-by: darryl.mocek at oracle.com ! src/share/classes/java/lang/String.java + test/java/lang/String/CaseInsensitiveComparator.java From mandy.chung at oracle.com Fri Dec 2 16:29:33 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Sat, 03 Dec 2011 00:29:33 +0000 Subject: hg: jdk8/tl/jdk: 7117585: Eliminate java.lang.instrument, java.lang.management warnings Message-ID: <20111203002943.4A5AC4754A@hg.openjdk.java.net> Changeset: 98502d7a3f98 Author: mchung Date: 2011-12-02 16:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98502d7a3f98 7117585: Eliminate java.lang.instrument, java.lang.management warnings Reviewed-by: mchung Contributed-by: Jon VanAlten ! src/share/classes/java/lang/instrument/ClassDefinition.java ! src/share/classes/java/lang/management/ManagementFactory.java ! src/share/classes/java/lang/management/PlatformComponent.java From lance.andersen at oracle.com Fri Dec 2 16:34:59 2011 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Sat, 03 Dec 2011 00:34:59 +0000 Subject: hg: jdk8/tl/jdk: 7116445: Miscellaneous warnings in the JDBC/RowSet classes Message-ID: <20111203003509.5C3374754B@hg.openjdk.java.net> Changeset: 3c524deb8431 Author: lancea Date: 2011-12-02 19:33 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c524deb8431 7116445: Miscellaneous warnings in the JDBC/RowSet classes Reviewed-by: smarks, chegar ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/WebRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetReader.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/share/classes/com/sun/rowset/internal/Row.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/Time.java ! src/share/classes/java/sql/Timestamp.java ! src/share/classes/javax/sql/StatementEvent.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/RowSetMetaDataImpl.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java From masayoshi.okutsu at oracle.com Fri Dec 2 18:19:05 2011 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Sat, 03 Dec 2011 02:19:05 +0000 Subject: hg: jdk8/tl/jdk: 7117487: Warnings Cleanup: some i18n classes in java.util and sun.util Message-ID: <20111203021915.6E3C04754D@hg.openjdk.java.net> Changeset: f2a5d0001f15 Author: okutsu Date: 2011-12-03 10:58 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2a5d0001f15 7117487: Warnings Cleanup: some i18n classes in java.util and sun.util Reviewed-by: lancea, naoto ! src/share/classes/java/util/Date.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/sun/util/calendar/BaseCalendar.java ! src/share/classes/sun/util/calendar/CalendarSystem.java ! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java ! src/share/classes/sun/util/calendar/ZoneInfo.java ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! src/share/classes/sun/util/resources/OpenListResourceBundle.java ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java From weijun.wang at oracle.com Sun Dec 4 18:19:51 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 05 Dec 2011 02:19:51 +0000 Subject: hg: jdk8/tl/jdk: 7116857: Warnings in javax.security and some sun.misc Message-ID: <20111205022009.5BF384755E@hg.openjdk.java.net> Changeset: 2ae848ea980a Author: weijun Date: 2011-12-05 10:19 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ae848ea980a 7116857: Warnings in javax.security and some sun.misc Reviewed-by: smarks ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java ! src/share/classes/sun/misc/CEFormatException.java ! src/share/classes/sun/misc/CEStreamExhausted.java ! src/share/classes/sun/misc/ClassLoaderUtil.java ! src/share/classes/sun/misc/CompoundEnumeration.java ! src/share/classes/sun/misc/ExtensionInstallationException.java ! src/share/classes/sun/misc/FloatingDecimal.java ! src/share/classes/sun/misc/FormattedFloatingDecimal.java ! src/share/classes/sun/misc/InvalidJarIndexException.java ! src/share/classes/sun/misc/LRUCache.java ! src/share/classes/sun/misc/Queue.java ! src/share/classes/sun/misc/RequestProcessor.java ! src/share/classes/sun/misc/ServiceConfigurationError.java ! src/share/classes/sun/misc/URLClassPath.java From alan.bateman at oracle.com Mon Dec 5 04:28:02 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 05 Dec 2011 12:28:02 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111205122831.CED8A47562@hg.openjdk.java.net> Changeset: 053cb321467a Author: alanb Date: 2011-12-05 12:23 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/053cb321467a 7117717: (aio) Tests failing due to implementation bug 7052549 Reviewed-by: weijun, chegar ! test/ProblemList.txt ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java Changeset: da28826c5672 Author: alanb Date: 2011-12-05 12:24 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da28826c5672 Merge From chris.hegarty at oracle.com Mon Dec 5 09:35:42 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 05 Dec 2011 17:35:42 +0000 Subject: hg: jdk8/tl/jdk: 7117360: Warnings in java.util.concurrent.atomic package Message-ID: <20111205173606.A46904758B@hg.openjdk.java.net> Changeset: f352dd3cdff8 Author: dl Date: 2011-12-05 13:58 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f352dd3cdff8 7117360: Warnings in java.util.concurrent.atomic package Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/atomic/AtomicBoolean.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicStampedReference.java From sean.mullan at oracle.com Mon Dec 5 10:06:38 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 05 Dec 2011 13:06:38 -0500 Subject: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException In-Reply-To: <4ED8F694.8010705@oracle.com> References: <4E525386.9000207@gmx.de> <4E52758D.2020208@oracle.com> <4E5E8AE3.3070402@gmx.de> <4E5FE753.2010705@oracle.com> <4E606D1D.6050509@gmx.de> <4E613565.1080801@oracle.com> <4E625E14.9060101@gmx.de> <4E67AF3D.2090609@oracle.com> <4E68FFBD.2030601@gmx.de> <4E6A13A2.2020503@gmx.de> <4E74F05D.7090806@gmx.de> <4E7CD5F8.9000501@oracle.com> <4E7DA91C.2000600@gmx.de> <4E81EDE6.9050205@oracle.com> <4E82A437.30907@gmx.de> <4E86073D.9050101@gmx.de> <4E873DA0.5050906@oracle.com> <4E88C03A.90904@gmx.de> <4EA96FB4.7000502@gmx.de> <4EABE0D5.5050802@gmx.de> <4ECC7A87.1030604@gmx.de> <4ED79956.4020101@oracle.com> <4ED86811.4090804@gmx.de> <4ED8F694.8010705@oracle.com> Message-ID: <4EDD082E.7060803@oracle.com> On 12/2/11 11:02 AM, Sean Mullan wrote: >> [0] Solution 1 >> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html >> [1] Solution 2 >> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_6/index.html I definitely prefer solution 2. Just a few minor comments: - Use the javadoc @inheritDoc tag instead of copying the javadoc for the initCause method. - PreventOverridingOfChaining lines 68, 71: what do these comments mean? one additional test that would be useful to add would be to call initCause twice for those ctors that don't have a Throwable parameter, and make sure initCause throws IllegalStateExc. --Sean From xueming.shen at oracle.com Mon Dec 5 10:51:34 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 05 Dec 2011 18:51:34 +0000 Subject: hg: jdk8/tl/jdk: 5063455: (fmt) MissingFormatArgumentException.getFormatSpecifier() incorrect return value Message-ID: <20111205185143.E36C24758D@hg.openjdk.java.net> Changeset: 194faa6fdb3c Author: sherman Date: 2011-12-05 10:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/194faa6fdb3c 5063455: (fmt) MissingFormatArgumentException.getFormatSpecifier() incorrect return value Summary: updated the incorrect StringBuilder constructor usage Reviewed-by: dholmes, sherman Contributed-by: brandon.passanisi at oracle.com ! src/share/classes/java/util/Formatter.java + test/java/util/MissingFormatArgumentException/GetFormatSpecifier.java From yuka.kamiya at oracle.com Mon Dec 5 15:40:39 2011 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Mon, 05 Dec 2011 23:40:39 +0000 Subject: hg: jdk8/tl/jdk: 7116914: Miscellaneous warnings (sun.text) Message-ID: <20111205234049.2693647591@hg.openjdk.java.net> Changeset: ca383e32deaf Author: peytoia Date: 2011-12-06 08:39 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca383e32deaf 7116914: Miscellaneous warnings (sun.text) Reviewed-by: smarks, okutsu ! src/share/classes/sun/text/CompactByteArray.java ! src/share/classes/sun/text/IntHashtable.java ! src/share/classes/sun/text/bidi/BidiBase.java ! src/share/classes/sun/text/normalizer/ICUData.java ! src/share/classes/sun/text/normalizer/NormalizerBase.java ! src/share/classes/sun/text/normalizer/NormalizerImpl.java ! src/share/classes/sun/text/normalizer/SymbolTable.java ! src/share/classes/sun/text/normalizer/UnicodeSet.java ! src/share/classes/sun/text/normalizer/UnicodeSetIterator.java ! src/share/classes/sun/text/normalizer/VersionInfo.java From stuart.marks at oracle.com Mon Dec 5 16:51:00 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 06 Dec 2011 00:51:00 +0000 Subject: hg: jdk8/tl/jdk: 7116993: fix warnings in java.applet Message-ID: <20111206005114.C208A47592@hg.openjdk.java.net> Changeset: f4fe86bba8a2 Author: smarks Date: 2011-12-05 16:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4fe86bba8a2 7116993: fix warnings in java.applet Reviewed-by: art, smarks Contributed-by: Danesh Dadachanji ! src/share/classes/java/applet/Applet.java From naoto.sato at oracle.com Mon Dec 5 17:09:42 2011 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 06 Dec 2011 01:09:42 +0000 Subject: hg: jdk8/tl/jdk: 7117469: Warning cleanup for j.u.Currency and j.u.Locale related classes Message-ID: <20111206010951.8BAC347593@hg.openjdk.java.net> Changeset: 85363edbc92f Author: naoto Date: 2011-12-05 17:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85363edbc92f 7117469: Warning cleanup for j.u.Currency and j.u.Locale related classes Reviewed-by: okutsu, smarks ! src/share/classes/java/util/Currency.java ! src/share/classes/sun/util/LocaleServiceProviderPool.java ! src/share/classes/sun/util/resources/LocaleData.java From stuart.marks at oracle.com Tue Dec 6 10:23:11 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 06 Dec 2011 18:23:11 +0000 Subject: hg: jdk8/tl/jdk: 7116997: fix warnings in java.util.PropertyPermission Message-ID: <20111206182332.B74AA475A4@hg.openjdk.java.net> Changeset: 77f6d4360f4b Author: smarks Date: 2011-12-06 10:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77f6d4360f4b 7116997: fix warnings in java.util.PropertyPermission Reviewed-by: smarks Contributed-by: Brandon Passanisi ! src/share/classes/java/util/PropertyPermission.java From sebastian.sickelmann at gmx.de Tue Dec 6 12:48:18 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Tue, 06 Dec 2011 21:48:18 +0100 Subject: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException In-Reply-To: <4EDD082E.7060803@oracle.com> References: <4E525386.9000207@gmx.de> <4E52758D.2020208@oracle.com> <4E5E8AE3.3070402@gmx.de> <4E5FE753.2010705@oracle.com> <4E606D1D.6050509@gmx.de> <4E613565.1080801@oracle.com> <4E625E14.9060101@gmx.de> <4E67AF3D.2090609@oracle.com> <4E68FFBD.2030601@gmx.de> <4E6A13A2.2020503@gmx.de> <4E74F05D.7090806@gmx.de> <4E7CD5F8.9000501@oracle.com> <4E7DA91C.2000600@gmx.de> <4E81EDE6.9050205@oracle.com> <4E82A437.30907@gmx.de> <4E86073D.9050101@gmx.de> <4E873DA0.5050906@oracle.com> <4E88C03A.90904@gmx.de> <4EA96FB4.7000502@gmx.de> <4EABE0D5.5050802@gmx.de> <4ECC7A87.1030604@gmx.de> <4ED79956.4020101@oracle.com> <4ED86811.4090804@gmx.de> <4ED8F694.8010705@oracle.com> <4EDD082E.7060803@oracle.com> Message-ID: <4EDE7F92.406@gmx.de> Am 05.12.2011 19:06, schrieb Sean Mullan: > On 12/2/11 11:02 AM, Sean Mullan wrote: > >>> [0] Solution 1 >>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html >>> [1] Solution 2 >>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_6/index.html > I definitely prefer solution 2. Just a few minor comments: > > - Use the javadoc @inheritDoc tag instead of copying the javadoc for the > initCause method. > > - PreventOverridingOfChaining > > lines 68, 71: what do these comments mean? > > one additional test that would be useful to add would be to call initCause twice > for those ctors that don't have a Throwable parameter, and make sure initCause > throws IllegalStateExc. > > --Sean > Updated the webrev[2] to include your review. [2] http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_7/index.html -- Sebastian From stuart.marks at oracle.com Wed Dec 7 13:47:48 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Wed, 07 Dec 2011 21:47:48 +0000 Subject: hg: jdk8/tl/jdk: 7117249: fix warnings in java.util.jar, .logging, .prefs, .zip Message-ID: <20111207214805.430C647632@hg.openjdk.java.net> Changeset: 4f0f9f9c4892 Author: smarks Date: 2011-12-07 12:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f0f9f9c4892 7117249: fix warnings in java.util.jar, .logging, .prefs, .zip Reviewed-by: alanb, dholmes, forax, sherman, smarks Contributed-by: Prasannaa , Martijn Verburg , Goerge_Albrecht , Graham Allan , Michael Barker ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/jar/Manifest.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/prefs/Preferences.java ! src/share/classes/java/util/prefs/XmlSupport.java ! src/share/classes/java/util/zip/ZipEntry.java From kumar.x.srinivasan at oracle.com Wed Dec 7 14:35:20 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Wed, 07 Dec 2011 22:35:20 +0000 Subject: hg: jdk8/tl/langtools: 7086015: fix test/tools/javac/parser/netbeans/JavacParserTest.java Message-ID: <20111207223524.462F347633@hg.openjdk.java.net> Changeset: abfa0d8ea803 Author: ksrini Date: 2011-12-07 10:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abfa0d8ea803 7086015: fix test/tools/javac/parser/netbeans/JavacParserTest.java Reviewed-by: ksrini, jjg Contributed-by: matherey.nunez at oracle.com ! test/tools/javac/parser/netbeans/JavacParserTest.java From stuart.marks at oracle.com Wed Dec 7 17:38:03 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Wed, 07 Dec 2011 17:38:03 -0800 Subject: please review fix for 7118546, warnings cleanup in javax.xml.crypto Message-ID: <4EE014FB.6090707@oracle.com> Webrev is here: http://cr.openjdk.java.net/~smarks/reviews/7118546/webrev.0/ Notes: In addition to changes to javax.xml.crypto, this webrev also includes a change to a file in javax.script. This package (among others) is included in the same build step as javax.xml.crypto, specifically in jdk/make/javax/others/Makefile. With this change, this entire build step will become warning-free. Many of the changes are simply adding @SuppressWarnings("rawtypes") at locations where raw types are used in the API. I tried to be careful not to change any actual APIs, but please recheck this. (During this warnings effort, inadvertent API changes seem to be catching everyone.) Of particular note are changes in the following files: - ExcC14NParameterSpec.java - XPathFilter2ParameterSpec.java - XPathFilterParameterSpec.java - XPathType.java The constructors in these classes take a raw List or Map, make a defensive copy, run through the elements and use instanceof to ensure they're all of the right type, create an unmodifiable wrapper and then assign it to a field. The current code uses all raw types. (For the following discussion it probably would be useful to bring up the code for the XPathType constructor.) There were several alternative approaches to getting rid of the warnings in this code. Since the code inevitably would have raw types and unchecked casts, one approach would simply be to put @SuppressWarnings({"rawtypes","unchecked"}) at the top of the constructor and be done with it. However, this obscures up a bunch of important details and IMHO covers too much code with @SuppressWarnings. Another approach would be to do an unchecked cast (with warning suppressed) directly from the raw type to the destination generic type such as Map. The code would then run through the entries to ensure that each key and value is indeed a String. This seems odd, and might lead a future maintenance programmer to "optimize away" such checks. Of course, these dynamic type checks are important for the security of the system. The approach I ended up taking was to make the defensive copy into a wildcarded type such as Map which I believe is an accurate type: it's a map, but we don't know the actual types of its keys and values. Only after doing all the instanceof checks do we do the cast to Map. Unfortunately, the resulting code is longer and has a proliferation of wildcards, making it appear to be quite complex. But I think it actually makes the most sense of the alternatives. If we want to simplify this code, I'd suggest we convert these cases to use the enhanced-for loop. I've refrained from doing so since we're avoiding refactoring as part of the warnings cleanup exercise. But let me know what you think. s'marks From sean.mullan at oracle.com Thu Dec 8 09:24:40 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 08 Dec 2011 12:24:40 -0500 Subject: please review fix for 7118546, warnings cleanup in javax.xml.crypto In-Reply-To: <4EE014FB.6090707@oracle.com> References: <4EE014FB.6090707@oracle.com> Message-ID: <4EE0F2D8.8070607@oracle.com> On 12/7/11 8:38 PM, Stuart Marks wrote: > Webrev is here: > > http://cr.openjdk.java.net/~smarks/reviews/7118546/webrev.0/ > > Notes: > > In addition to changes to javax.xml.crypto, this webrev also includes a change > to a file in javax.script. This package (among others) is included in the same > build step as javax.xml.crypto, specifically in jdk/make/javax/others/Makefile. > With this change, this entire build step will become warning-free. Now that they are warning free, should there also be a change to the Makefile? In javax/script/ScriptException.java, why is the serialVersionUID field not marked private? > Many of the changes are simply adding @SuppressWarnings("rawtypes") at > locations where raw types are used in the API. I tried to be careful not to > change any actual APIs, but please recheck this. (During this warnings effort, > inadvertent API changes seem to be catching everyone.) It looks good to me. I did not see any API changes. > Of particular note are changes in the following files: > > - ExcC14NParameterSpec.java > - XPathFilter2ParameterSpec.java > - XPathFilterParameterSpec.java > - XPathType.java > > The constructors in these classes take a raw List or Map, make a defensive > copy, run through the elements and use instanceof to ensure they're all of the > right type, create an unmodifiable wrapper and then assign it to a field. The > current code uses all raw types. > > (For the following discussion it probably would be useful to bring up the code > for the XPathType constructor.) > > There were several alternative approaches to getting rid of the warnings in > this code. Since the code inevitably would have raw types and unchecked casts, > one approach would simply be to put @SuppressWarnings({"rawtypes","unchecked"}) > at the top of the constructor and be done with it. However, this obscures up a > bunch of important details and IMHO covers too much code with @SuppressWarnings. > > Another approach would be to do an unchecked cast (with warning suppressed) > directly from the raw type to the destination generic type such as > Map. The code would then run through the entries to ensure that > each key and value is indeed a String. This seems odd, and might lead a future > maintenance programmer to "optimize away" such checks. Of course, these dynamic > type checks are important for the security of the system. > > The approach I ended up taking was to make the defensive copy into a wildcarded > type such as Map which I believe is an accurate type: it's a map, but we > don't know the actual types of its keys and values. Only after doing all the > instanceof checks do we do the cast to Map. Unfortunately, the > resulting code is longer and has a proliferation of wildcards, making it appear > to be quite complex. But I think it actually makes the most sense of the > alternatives. It looks good to me. > If we want to simplify this code, I'd suggest we convert these cases to use the > enhanced-for loop. I've refrained from doing so since we're avoiding > refactoring as part of the warnings cleanup exercise. > > But let me know what you think. All the other changes look good. The only other suggestion I would make is to add a note to the CR with more rationale as to why the SuppressWarnings, etc were added to the API so that future maintainers will understand that. In short, this API was specified as a standalone JSR (105) and any API changes would need to be first published via a maintenance review per the JCP guidelines. Thanks, Sean From omajid at redhat.com Thu Dec 8 10:51:39 2011 From: omajid at redhat.com (omajid at redhat.com) Date: Thu, 08 Dec 2011 18:51:39 +0000 Subject: hg: jdk8/tl/jdk: 7117612: Miscellaneous warnings in java.lang Message-ID: <20111208185204.5AA4247640@hg.openjdk.java.net> Changeset: f8897baf40ea Author: omajid Date: 2011-12-08 13:48 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8897baf40ea 7117612: Miscellaneous warnings in java.lang Reviewed-by: smarks, dholmes, alanb, darcy ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/CharacterName.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/ConditionalSpecialCasing.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/EnumConstantNotPresentException.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/ThreadLocal.java ! src/share/classes/java/lang/Void.java ! src/solaris/classes/java/lang/ProcessEnvironment.java ! src/windows/classes/java/lang/ProcessEnvironment.java From stuart.marks at oracle.com Thu Dec 8 12:47:44 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 08 Dec 2011 12:47:44 -0800 Subject: please review fix for 7118546, warnings cleanup in javax.xml.crypto In-Reply-To: <4EE0F2D8.8070607@oracle.com> References: <4EE014FB.6090707@oracle.com> <4EE0F2D8.8070607@oracle.com> Message-ID: <4EE12270.6040404@oracle.com> On 12/8/11 9:24 AM, Sean Mullan wrote: > Now that they are warning free, should there also be a change to the Makefile? Eventually yes. I'll coordinate with Kurchi on this, but we probably want to add -Werror to various makefiles in the future, after we do more testing to ensure that we don't start breaking builds. > In javax/script/ScriptException.java, why is the serialVersionUID field not > marked private? No good reason. Well, there's a bad reason :-) which is that the "serialver" output doesn't make it private. I see that the majority (> 80%) of serialVersionUID fields in the JDK are private. I'll make this change. Aside: it seems that making svuid private is preferred. Is this true, and if so, what's the rationale? Is this a bug that serialver doesn't make its declaration private? > All the other changes look good. The only other suggestion I would make is to > add a note to the CR with more rationale as to why the SuppressWarnings, etc > were added to the API so that future maintainers will understand that. In short, > this API was specified as a standalone JSR (105) and any API changes would need > to be first published via a maintenance review per the JCP guidelines. OK, I'll add a note to the CR that covers this. Anything else? s'marks From sean.mullan at oracle.com Thu Dec 8 13:05:32 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 08 Dec 2011 16:05:32 -0500 Subject: please review fix for 7118546, warnings cleanup in javax.xml.crypto In-Reply-To: <4EE12270.6040404@oracle.com> References: <4EE014FB.6090707@oracle.com> <4EE0F2D8.8070607@oracle.com> <4EE12270.6040404@oracle.com> Message-ID: <4EE1269C.2000208@oracle.com> On 12/8/11 3:47 PM, Stuart Marks wrote: > On 12/8/11 9:24 AM, Sean Mullan wrote: >> Now that they are warning free, should there also be a change to the Makefile? > > Eventually yes. I'll coordinate with Kurchi on this, but we probably want to > add -Werror to various makefiles in the future, after we do more testing to > ensure that we don't start breaking builds. > >> In javax/script/ScriptException.java, why is the serialVersionUID field not >> marked private? > > No good reason. Well, there's a bad reason :-) which is that the "serialver" > output doesn't make it private. I see that the majority (> 80%) of > serialVersionUID fields in the JDK are private. I'll make this change. > > Aside: it seems that making svuid private is preferred. Is this true, and if > so, what's the rationale? Is this a bug that serialver doesn't make its > declaration private? Not sure if there is an obvious security risk by making it package-private but I think it's good practice in general to make it private. >> All the other changes look good. The only other suggestion I would make is to >> add a note to the CR with more rationale as to why the SuppressWarnings, etc >> were added to the API so that future maintainers will understand that. In short, >> this API was specified as a standalone JSR (105) and any API changes would need >> to be first published via a maintenance review per the JCP guidelines. > > OK, I'll add a note to the CR that covers this. > > Anything else? No. --Sean From stuart.marks at oracle.com Thu Dec 8 15:12:17 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Thu, 08 Dec 2011 23:12:17 +0000 Subject: hg: jdk8/tl/jdk: 7118546: fix warnings in javax.xml.crypto, javax.script Message-ID: <20111208231227.3940447644@hg.openjdk.java.net> Changeset: 9bb7c3b97384 Author: smarks Date: 2011-12-08 14:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bb7c3b97384 7118546: fix warnings in javax.xml.crypto, javax.script Reviewed-by: mullan ! src/share/classes/javax/script/ScriptException.java ! src/share/classes/javax/xml/crypto/NodeSetData.java ! src/share/classes/javax/xml/crypto/dom/DOMCryptoContext.java ! src/share/classes/javax/xml/crypto/dsig/Manifest.java ! src/share/classes/javax/xml/crypto/dsig/Reference.java ! src/share/classes/javax/xml/crypto/dsig/SignatureProperties.java ! src/share/classes/javax/xml/crypto/dsig/SignatureProperty.java ! src/share/classes/javax/xml/crypto/dsig/SignedInfo.java ! src/share/classes/javax/xml/crypto/dsig/TransformService.java ! src/share/classes/javax/xml/crypto/dsig/XMLObject.java ! src/share/classes/javax/xml/crypto/dsig/XMLSignature.java ! src/share/classes/javax/xml/crypto/dsig/XMLSignatureFactory.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/KeyInfo.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/KeyInfoFactory.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/PGPData.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/RetrievalMethod.java ! src/share/classes/javax/xml/crypto/dsig/keyinfo/X509Data.java ! src/share/classes/javax/xml/crypto/dsig/spec/ExcC14NParameterSpec.java ! src/share/classes/javax/xml/crypto/dsig/spec/XPathFilter2ParameterSpec.java ! src/share/classes/javax/xml/crypto/dsig/spec/XPathFilterParameterSpec.java ! src/share/classes/javax/xml/crypto/dsig/spec/XPathType.java From sean.mullan at oracle.com Fri Dec 9 08:07:18 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 09 Dec 2011 11:07:18 -0500 Subject: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException In-Reply-To: <4EDE7F92.406@gmx.de> References: <4E525386.9000207@gmx.de> <4E52758D.2020208@oracle.com> <4E5E8AE3.3070402@gmx.de> <4E5FE753.2010705@oracle.com> <4E606D1D.6050509@gmx.de> <4E613565.1080801@oracle.com> <4E625E14.9060101@gmx.de> <4E67AF3D.2090609@oracle.com> <4E68FFBD.2030601@gmx.de> <4E6A13A2.2020503@gmx.de> <4E74F05D.7090806@gmx.de> <4E7CD5F8.9000501@oracle.com> <4E7DA91C.2000600@gmx.de> <4E81EDE6.9050205@oracle.com> <4E82A437.30907@gmx.de> <4E86073D.9050101@gmx.de> <4E873DA0.5050906@oracle.com> <4E88C03A.90904@gmx.de> <4EA96FB4.7000502@gmx.de> <4EABE0D5.5050802@gmx.de> <4ECC7A87.1030604@gmx.de> <4ED79956.4020101@oracle.com> <4ED86811.4090804@gmx.de> <4ED8F694.8010705@oracle.com> <4EDD082E.7060803@oracle.com> <4EDE7F92.406@gmx.de> Message-ID: <4EE23236.2060606@oracle.com> On 12/6/11 3:48 PM, Sebastian Sickelmann wrote: > Am 05.12.2011 19:06, schrieb Sean Mullan: >> On 12/2/11 11:02 AM, Sean Mullan wrote: >> >>>> [0] Solution 1 >>>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html >>>> [1] Solution 2 >>>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_6/index.html >> I definitely prefer solution 2. Just a few minor comments: >> >> - Use the javadoc @inheritDoc tag instead of copying the javadoc for the >> initCause method. >> >> - PreventOverridingOfChaining >> >> lines 68, 71: what do these comments mean? >> >> one additional test that would be useful to add would be to call initCause twice >> for those ctors that don't have a Throwable parameter, and make sure initCause >> throws IllegalStateExc. >> >> --Sean >> > Updated the webrev[2] to include your review. > > [2] > http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_7/index.html You didn't add the additional test that I thought would be useful - are you going to add that? Otherwise, it looks good. --Sean From kumar.x.srinivasan at oracle.com Fri Dec 9 08:58:02 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 09 Dec 2011 16:58:02 +0000 Subject: hg: jdk8/tl/langtools: 7119032: (javac) increase visibility of JavacParser methods to improve subtyping Message-ID: <20111209165807.240024764F@hg.openjdk.java.net> Changeset: 9350d0498d21 Author: ksrini Date: 2011-12-09 08:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9350d0498d21 7119032: (javac) increase visibility of JavacParser methods to improve subtyping Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java From jim.holmlund at sun.com Fri Dec 9 13:03:08 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Fri, 09 Dec 2011 21:03:08 +0000 Subject: hg: jdk8/tl/jdk: 7117053: Fix build warnings in com/sun/tools/jdi/* Message-ID: <20111209210329.8100547653@hg.openjdk.java.net> Changeset: 77d41c0e4ffc Author: jjh Date: 2011-12-09 12:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77d41c0e4ffc 7117053: Fix build warnings in com/sun/tools/jdi/* Summary: Warnings fixed. Also reviewed by serguei.spitsyn at oracle.com, who is not yet an openjdk reviewer Reviewed-by: ksrini ! make/tools/src/build/tools/jdwpgen/ArrayRegionTypeNode.java ! make/tools/src/build/tools/jdwpgen/OutNode.java ! src/share/classes/com/sun/jdi/AbsentInformationException.java ! src/share/classes/com/sun/jdi/ClassNotLoadedException.java ! src/share/classes/com/sun/jdi/ClassNotPreparedException.java ! src/share/classes/com/sun/jdi/IncompatibleThreadStateException.java ! src/share/classes/com/sun/jdi/InconsistentDebugInfoException.java ! src/share/classes/com/sun/jdi/InternalException.java ! src/share/classes/com/sun/jdi/InvalidCodeIndexException.java ! src/share/classes/com/sun/jdi/InvalidLineNumberException.java ! src/share/classes/com/sun/jdi/InvalidStackFrameException.java ! src/share/classes/com/sun/jdi/InvalidTypeException.java ! src/share/classes/com/sun/jdi/InvocationException.java ! src/share/classes/com/sun/jdi/JDIPermission.java ! src/share/classes/com/sun/jdi/NativeMethodException.java ! src/share/classes/com/sun/jdi/ObjectCollectedException.java ! src/share/classes/com/sun/jdi/VMCannotBeModifiedException.java ! src/share/classes/com/sun/jdi/VMDisconnectedException.java ! src/share/classes/com/sun/jdi/VMMismatchException.java ! src/share/classes/com/sun/jdi/VMOutOfMemoryException.java ! src/share/classes/com/sun/jdi/connect/IllegalConnectorArgumentsException.java ! src/share/classes/com/sun/jdi/connect/TransportTimeoutException.java ! src/share/classes/com/sun/jdi/connect/VMStartException.java ! src/share/classes/com/sun/jdi/connect/spi/ClosedConnectionException.java ! src/share/classes/com/sun/jdi/request/DuplicateRequestException.java ! src/share/classes/com/sun/jdi/request/InvalidRequestStateException.java ! src/share/classes/com/sun/tools/jdi/ArrayReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/ArrayTypeImpl.java ! src/share/classes/com/sun/tools/jdi/BooleanValueImpl.java ! src/share/classes/com/sun/tools/jdi/CharValueImpl.java ! src/share/classes/com/sun/tools/jdi/ClassLoaderReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/ClassTypeImpl.java ! src/share/classes/com/sun/tools/jdi/ConcreteMethodImpl.java ! src/share/classes/com/sun/tools/jdi/ConnectorImpl.java ! src/share/classes/com/sun/tools/jdi/DoubleValueImpl.java ! src/share/classes/com/sun/tools/jdi/EventRequestManagerImpl.java ! src/share/classes/com/sun/tools/jdi/EventSetImpl.java ! src/share/classes/com/sun/tools/jdi/FloatValueImpl.java ! src/share/classes/com/sun/tools/jdi/GenericAttachingConnector.java ! src/share/classes/com/sun/tools/jdi/IntegerValueImpl.java ! src/share/classes/com/sun/tools/jdi/InterfaceTypeImpl.java ! src/share/classes/com/sun/tools/jdi/InternalEventHandler.java ! src/share/classes/com/sun/tools/jdi/JDWPException.java - src/share/classes/com/sun/tools/jdi/LinkedHashMap.java ! src/share/classes/com/sun/tools/jdi/LongValueImpl.java ! src/share/classes/com/sun/tools/jdi/MethodImpl.java ! src/share/classes/com/sun/tools/jdi/MirrorImpl.java ! src/share/classes/com/sun/tools/jdi/ObjectReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/ProcessAttachingConnector.java ! src/share/classes/com/sun/tools/jdi/RawCommandLineLauncher.java ! src/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! src/share/classes/com/sun/tools/jdi/ShortValueImpl.java ! src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java ! src/share/classes/com/sun/tools/jdi/TargetVM.java ! src/share/classes/com/sun/tools/jdi/ThreadAction.java ! src/share/classes/com/sun/tools/jdi/ThreadGroupReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/VMAction.java ! src/share/classes/com/sun/tools/jdi/VMState.java ! src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java From sebastian.sickelmann at gmx.de Sat Dec 10 04:46:34 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Sat, 10 Dec 2011 13:46:34 +0100 Subject: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException In-Reply-To: <4EE23236.2060606@oracle.com> References: <4E525386.9000207@gmx.de> <4E52758D.2020208@oracle.com> <4E5E8AE3.3070402@gmx.de> <4E5FE753.2010705@oracle.com> <4E606D1D.6050509@gmx.de> <4E613565.1080801@oracle.com> <4E625E14.9060101@gmx.de> <4E67AF3D.2090609@oracle.com> <4E68FFBD.2030601@gmx.de> <4E6A13A2.2020503@gmx.de> <4E74F05D.7090806@gmx.de> <4E7CD5F8.9000501@oracle.com> <4E7DA91C.2000600@gmx.de> <4E81EDE6.9050205@oracle.com> <4E82A437.30907@gmx.de> <4E86073D.9050101@gmx.de> <4E873DA0.5050906@oracle.com> <4E88C03A.90904@gmx.de> <4EA96FB4.7000502@gmx.de> <4EABE0D5.5050802@gmx.de> <4ECC7A87.1030604@gmx.de> <4ED79956.4020101@oracle.com> <4ED86811.4090804@gmx.de> <4ED8F694.8010705@oracle.com> <4EDD082E.7060803@oracle.com> <4EDE7F92.406@gmx.de> <4EE23236.2060606@oracle.com> Message-ID: <4EE354AA.5060002@gmx.de> Am 09.12.2011 17:07, schrieb Sean Mullan: > On 12/6/11 3:48 PM, Sebastian Sickelmann wrote: >> Am 05.12.2011 19:06, schrieb Sean Mullan: >>> On 12/2/11 11:02 AM, Sean Mullan wrote: >>> >>>>> [0] Solution 1 >>>>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html >>>>> [1] Solution 2 >>>>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_6/index.html >>> I definitely prefer solution 2. Just a few minor comments: >>> >>> - Use the javadoc @inheritDoc tag instead of copying the javadoc for the >>> initCause method. >>> >>> - PreventOverridingOfChaining >>> >>> lines 68, 71: what do these comments mean? >>> >>> one additional test that would be useful to add would be to call initCause twice >>> for those ctors that don't have a Throwable parameter, and make sure initCause >>> throws IllegalStateExc. >>> >>> --Sean >>> >> Updated the webrev[2] to include your review. >> >> [2] >> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_7/index.html > You didn't add the additional test that I thought would be useful - are you > going to add that? Otherwise, it looks good. > > --Sean Sorry, I missed this. I updated the webrev[3] [3] http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_8/index.html -- Sebastian From kumar.x.srinivasan at oracle.com Sun Dec 11 08:44:15 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Sun, 11 Dec 2011 16:44:15 +0000 Subject: hg: jdk8/tl/langtools: 7119487: JavacParserTest.java test fails on Windows platforms Message-ID: <20111211164418.455AE4766C@hg.openjdk.java.net> Changeset: e7d5e1a7cde5 Author: ksrini Date: 2011-12-10 17:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e7d5e1a7cde5 7119487: JavacParserTest.java test fails on Windows platforms Reviewed-by: jjg + test/tools/javac/parser/JavacParserTest.java - test/tools/javac/parser/netbeans/JavacParserTest.java From maurizio.cimadamore at oracle.com Sun Dec 11 09:49:07 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Sun, 11 Dec 2011 17:49:07 +0000 Subject: hg: jdk8/tl/langtools: 7120266: javac fails to compile hotspot code Message-ID: <20111211174909.921EB4766D@hg.openjdk.java.net> Changeset: e55270a7a022 Author: mcimadamore Date: 2011-12-11 17:48 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e55270a7a022 7120266: javac fails to compile hotspot code Summary: Parser changes for method references cause bad intercation with method call syntax Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/T7120266.java ! test/tools/javac/lambda/MethodReferenceParserTest.java From neil.richards at ngmr.net Mon Dec 12 03:45:09 2011 From: neil.richards at ngmr.net (neil.richards at ngmr.net) Date: Mon, 12 Dec 2011 11:45:09 +0000 Subject: hg: jdk8/tl/jdk: 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH Message-ID: <20111212114532.28EFA4766F@hg.openjdk.java.net> Changeset: c508f38245f8 Author: ngmr Date: 2011-12-12 11:41 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c508f38245f8 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH Reviewed-by: alanb, chegar Contributed-by: Charles Lee ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c From chris.hegarty at oracle.com Mon Dec 12 03:55:00 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 12 Dec 2011 11:55:00 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20111212115519.7D5DF47670@hg.openjdk.java.net> Changeset: 3216717f96f5 Author: dl Date: 2011-12-12 10:45 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3216717f96f5 7118066: Warnings in java.util.concurrent package Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListSet.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/DelayQueue.java ! src/share/classes/java/util/concurrent/Exchanger.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/Phaser.java ! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java ! test/java/util/Collections/EmptyIterator.java Changeset: d4f9d7e86a92 Author: chegar Date: 2011-12-12 03:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4f9d7e86a92 Merge From kelly.ohair at oracle.com Mon Dec 12 15:29:35 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 12 Dec 2011 23:29:35 +0000 Subject: hg: jdk8/tl: 7119829: Adjust default jprt testing configuration Message-ID: <20111212232935.6554647677@hg.openjdk.java.net> Changeset: 9acd7374ff8a Author: ohair Date: 2011-12-12 08:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9acd7374ff8a 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties ! test/Makefile From kelly.ohair at oracle.com Mon Dec 12 15:29:45 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 12 Dec 2011 23:29:45 +0000 Subject: hg: jdk8/tl/jdk: 7119829: Adjust default jprt testing configuration Message-ID: <20111212233005.ADA4047678@hg.openjdk.java.net> Changeset: 9c0a6185188f Author: ohair Date: 2011-12-12 08:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c0a6185188f 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties ! test/Makefile From kelly.ohair at oracle.com Mon Dec 12 15:30:15 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 12 Dec 2011 23:30:15 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20111212233015.6A66A47679@hg.openjdk.java.net> Changeset: a482d45c93e9 Author: ohair Date: 2011-12-12 08:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a482d45c93e9 7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac Reviewed-by: alanb ! build.xml Changeset: a49db7c01db7 Author: ohair Date: 2011-12-12 08:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a49db7c01db7 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties From kelly.ohair at oracle.com Mon Dec 12 15:30:34 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 12 Dec 2011 23:30:34 +0000 Subject: hg: jdk8/tl/corba: 7119829: Adjust default jprt testing configuration Message-ID: <20111212233035.56B714767A@hg.openjdk.java.net> Changeset: 75529c21094f Author: ohair Date: 2011-12-12 08:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/75529c21094f 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties From kelly.ohair at oracle.com Mon Dec 12 15:30:42 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 12 Dec 2011 23:30:42 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20111212233042.C6FCE4767B@hg.openjdk.java.net> Changeset: 6d622b1b4db0 Author: ohair Date: 2011-12-12 08:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6d622b1b4db0 7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac Reviewed-by: alanb ! build.xml Changeset: 6d2030eacdac Author: ohair Date: 2011-12-12 08:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6d2030eacdac 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties From kelly.ohair at oracle.com Mon Dec 12 15:31:28 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 12 Dec 2011 23:31:28 +0000 Subject: hg: jdk8/tl/langtools: 7119829: Adjust default jprt testing configuration Message-ID: <20111212233132.4EEDB4767C@hg.openjdk.java.net> Changeset: 4822dfe0922b Author: ohair Date: 2011-12-12 08:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4822dfe0922b 7119829: Adjust default jprt testing configuration Reviewed-by: alanb ! make/jprt.properties From sean.mullan at oracle.com Tue Dec 13 10:59:51 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 13 Dec 2011 13:59:51 -0500 Subject: Answer requested!!! was: Re: 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException In-Reply-To: <4EE354AA.5060002@gmx.de> References: <4E525386.9000207@gmx.de> <4E52758D.2020208@oracle.com> <4E5E8AE3.3070402@gmx.de> <4E5FE753.2010705@oracle.com> <4E606D1D.6050509@gmx.de> <4E613565.1080801@oracle.com> <4E625E14.9060101@gmx.de> <4E67AF3D.2090609@oracle.com> <4E68FFBD.2030601@gmx.de> <4E6A13A2.2020503@gmx.de> <4E74F05D.7090806@gmx.de> <4E7CD5F8.9000501@oracle.com> <4E7DA91C.2000600@gmx.de> <4E81EDE6.9050205@oracle.com> <4E82A437.30907@gmx.de> <4E86073D.9050101@gmx.de> <4E873DA0.5050906@oracle.com> <4E88C03A.90904@gmx.de> <4EA96FB4.7000502@gmx.de> <4EABE0D5.5050802@gmx.de> <4ECC7A87.1030604@gmx.de> <4ED79956.4020101@oracle.com> <4ED86811.4090804@gmx.de> <4ED8F694.8010705@oracle.com> <4EDD082E.7060803@oracle.com> <4EDE7F92.406@gmx.de> <4EE23236.2060606@oracle.com> <4EE354AA.5060002@gmx.de> Message-ID: <4EE7A0A7.4020609@oracle.com> On 12/10/11 7:46 AM, Sebastian Sickelmann wrote: > Am 09.12.2011 17:07, schrieb Sean Mullan: >> On 12/6/11 3:48 PM, Sebastian Sickelmann wrote: >>> Am 05.12.2011 19:06, schrieb Sean Mullan: >>>> On 12/2/11 11:02 AM, Sean Mullan wrote: >>>> >>>>>> [0] Solution 1 >>>>>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html >>>>>> [1] Solution 2 >>>>>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_6/index.html >>>> I definitely prefer solution 2. Just a few minor comments: >>>> >>>> - Use the javadoc @inheritDoc tag instead of copying the javadoc for the >>>> initCause method. >>>> >>>> - PreventOverridingOfChaining >>>> >>>> lines 68, 71: what do these comments mean? >>>> >>>> one additional test that would be useful to add would be to call initCause twice >>>> for those ctors that don't have a Throwable parameter, and make sure initCause >>>> throws IllegalStateExc. >>>> >>>> --Sean >>>> >>> Updated the webrev[2] to include your review. >>> >>> [2] >>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_7/index.html >> You didn't add the additional test that I thought would be useful - are you >> going to add that? Otherwise, it looks good. >> >> --Sean > Sorry, I missed this. > > I updated the webrev[3] This looks fine. Do you want me to push this on your behalf, or would you like to first wait for your discussion on core-libs-dev to reach a conclusion? --Sean > > [3] > http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_8/index.html > > -- Sebastian From jonathan.gibbons at oracle.com Tue Dec 13 11:21:56 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 13 Dec 2011 19:21:56 +0000 Subject: hg: jdk8/tl/langtools: 7120736: refactor javac option handling Message-ID: <20111213192201.41ECF4769A@hg.openjdk.java.net> Changeset: 3809292620c9 Author: jjg Date: 2011-12-13 11:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3809292620c9 7120736: refactor javac option handling Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/file/Locations.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/Options.java ! test/tools/javac/diags/examples/UnsupportedEncoding.java From jonathan.gibbons at oracle.com Tue Dec 13 14:34:13 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 13 Dec 2011 22:34:13 +0000 Subject: hg: jdk8/tl/langtools: 7121164: renamed files not committed Message-ID: <20111213223417.65FFD4769E@hg.openjdk.java.net> Changeset: 4e4fed1d02f9 Author: jjg Date: 2011-12-13 14:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4e4fed1d02f9 7121164: renamed files not committed Reviewed-by: ksrini - src/share/classes/com/sun/tools/javac/main/JavacOption.java + src/share/classes/com/sun/tools/javac/main/Option.java + src/share/classes/com/sun/tools/javac/main/OptionHelper.java - src/share/classes/com/sun/tools/javac/main/OptionName.java - src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java From naoto.sato at oracle.com Tue Dec 13 15:42:37 2011 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 13 Dec 2011 23:42:37 +0000 Subject: hg: jdk8/tl/jdk: 4808233: "Locale" not thread-safe Message-ID: <20111213234300.63D54476A1@hg.openjdk.java.net> Changeset: c647ebb3c4f7 Author: naoto Date: 2011-12-13 15:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c647ebb3c4f7 4808233: "Locale" not thread-safe Reviewed-by: okutsu ! src/share/classes/java/util/Locale.java From jonathan.gibbons at oracle.com Wed Dec 14 16:16:30 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 15 Dec 2011 00:16:30 +0000 Subject: hg: jdk8/tl/langtools: 7111022: javac no long prints last round of processing; ... Message-ID: <20111215001632.91A46476C7@hg.openjdk.java.net> Changeset: 4261dc8af622 Author: jjg Date: 2011-12-14 16:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4261dc8af622 7111022: javac no long prints last round of processing 7121323: Sqe tests using -Xstdout option fail with an invalid flag error message Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! test/tools/javac/4846262/Test.sh + test/tools/javac/processing/options/testPrintProcessorInfo/TestWithXstdout.java ! test/tools/javac/util/T6597678.java From jonathan.gibbons at oracle.com Wed Dec 14 17:52:56 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 15 Dec 2011 01:52:56 +0000 Subject: hg: jdk8/tl/langtools: 7121681: compiler message file broken for javac -fullversion Message-ID: <20111215015258.B181E476C8@hg.openjdk.java.net> Changeset: 281eeedf9755 Author: jjg Date: 2011-12-14 17:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/281eeedf9755 7121681: compiler message file broken for javac -fullversion Reviewed-by: jjh ! src/share/classes/com/sun/tools/javac/main/Option.java From jonathan.gibbons at oracle.com Wed Dec 14 21:54:05 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 15 Dec 2011 05:54:05 +0000 Subject: hg: jdk8/tl/langtools: 7121682: remove obsolete import Message-ID: <20111215055408.47894476CA@hg.openjdk.java.net> Changeset: 42ffceeceeca Author: jjg Date: 2011-12-14 21:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/42ffceeceeca 7121682: remove obsolete import Reviewed-by: jjh ! test/tools/javac/api/T6838467.java From lana.steuck at oracle.com Fri Dec 16 00:11:59 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:11:59 +0000 Subject: hg: jdk8/tl: 5 new changesets Message-ID: <20111216081159.DB44347716@hg.openjdk.java.net> Changeset: 4e06ae613e99 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4e06ae613e99 Added tag jdk8-b15 for changeset a4f28069d44a ! .hgtags Changeset: 8606f4ab62dc Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8606f4ab62dc Added tag jdk8-b17 for changeset 4e06ae613e99 ! .hgtags Changeset: d82d3bb3a2e5 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d82d3bb3a2e5 Added tag jdk8-b16 for changeset 4e06ae613e99 ! .hgtags Changeset: 7010bd24cdd0 Author: katleman Date: 2011-12-15 15:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7010bd24cdd0 Merge ! .hgtags Changeset: 00d13c40d7a7 Author: lana Date: 2011-12-15 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/00d13c40d7a7 Merge From lana.steuck at oracle.com Fri Dec 16 00:12:01 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:12:01 +0000 Subject: hg: jdk8/tl/jaxws: 7 new changesets Message-ID: <20111216081202.2C40B47717@hg.openjdk.java.net> Changeset: 76e37e606354 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/76e37e606354 Added tag jdk8-b15 for changeset c9ab96ff23d5 ! .hgtags Changeset: 23c42f40fd3e Author: katleman Date: 2011-12-06 08:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/23c42f40fd3e 7117162: jdk8/jaxws/Makefile default DROPS_DIR should set to jdk8-drops Reviewed-by: ohair, xdono, mchung ! build.properties ! make/Makefile Changeset: 3d45ab79643d Author: katleman Date: 2011-12-07 13:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/3d45ab79643d Merge Changeset: b38846b9974c Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b38846b9974c Added tag jdk8-b17 for changeset 3d45ab79643d ! .hgtags Changeset: e662b652098c Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/e662b652098c Added tag jdk8-b16 for changeset 3d45ab79643d ! .hgtags Changeset: 54928c8850f5 Author: katleman Date: 2011-12-15 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/54928c8850f5 Merge ! .hgtags Changeset: b2e4ab8b5fa3 Author: lana Date: 2011-12-15 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b2e4ab8b5fa3 Merge From lana.steuck at oracle.com Fri Dec 16 00:12:03 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:12:03 +0000 Subject: hg: jdk8/tl/jaxp: 7 new changesets Message-ID: <20111216081203.C4E6E47718@hg.openjdk.java.net> Changeset: 8181f7634e4a Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/8181f7634e4a Added tag jdk8-b15 for changeset 804f666d6d44 ! .hgtags Changeset: e32444f13774 Author: katleman Date: 2011-12-06 08:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e32444f13774 7117162: jdk8/jaxws/Makefile default DROPS_DIR should set to jdk8-drops Reviewed-by: ohair, xdono, mchung ! build.properties ! make/Makefile Changeset: 09eb517404b0 Author: katleman Date: 2011-12-07 13:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/09eb517404b0 Merge Changeset: db44484a9d6e Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/db44484a9d6e Added tag jdk8-b17 for changeset 09eb517404b0 ! .hgtags Changeset: bc3ed3122933 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/bc3ed3122933 Added tag jdk8-b16 for changeset 09eb517404b0 ! .hgtags Changeset: ebec6a7e8d4e Author: katleman Date: 2011-12-15 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ebec6a7e8d4e Merge ! .hgtags Changeset: f26e2ab2c2c7 Author: lana Date: 2011-12-15 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f26e2ab2c2c7 Merge From lana.steuck at oracle.com Fri Dec 16 00:11:59 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:11:59 +0000 Subject: hg: jdk8/tl/corba: 5 new changesets Message-ID: <20111216081205.C2F9347719@hg.openjdk.java.net> Changeset: 82dc033975bb Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/82dc033975bb Added tag jdk8-b15 for changeset 7da69e7175a7 ! .hgtags Changeset: 05f47d29b438 Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/05f47d29b438 Added tag jdk8-b17 for changeset 82dc033975bb ! .hgtags Changeset: 6e51ad8d3707 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/6e51ad8d3707 Added tag jdk8-b16 for changeset 82dc033975bb ! .hgtags Changeset: 312cf15d1657 Author: katleman Date: 2011-12-15 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/312cf15d1657 Merge ! .hgtags Changeset: 0289a94d653b Author: lana Date: 2011-12-15 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0289a94d653b Merge From lana.steuck at oracle.com Fri Dec 16 00:12:00 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:12:00 +0000 Subject: hg: jdk8/tl/hotspot: 4 new changesets Message-ID: <20111216081212.B6BDC4771A@hg.openjdk.java.net> Changeset: d1f29d4e0bc6 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d1f29d4e0bc6 Added tag jdk8-b15 for changeset fde2a39ed7f3 ! .hgtags Changeset: 698a22e99f74 Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/698a22e99f74 Added tag jdk8-b17 for changeset d1f29d4e0bc6 ! .hgtags Changeset: 09f3b8a372b2 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/09f3b8a372b2 Added tag jdk8-b16 for changeset d1f29d4e0bc6 ! .hgtags Changeset: e46c2339d0fc Author: katleman Date: 2011-12-15 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e46c2339d0fc Merge ! .hgtags From lana.steuck at oracle.com Fri Dec 16 00:12:11 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:12:11 +0000 Subject: hg: jdk8/tl/langtools: 7 new changesets Message-ID: <20111216081227.C2EAF4771B@hg.openjdk.java.net> Changeset: ec2c0973cc31 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec2c0973cc31 Added tag jdk8-b15 for changeset 07599bd780ca ! .hgtags Changeset: 2584f5358cba Author: lana Date: 2011-12-06 20:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2584f5358cba Merge Changeset: 1cbe86c11ba6 Author: lana Date: 2011-12-12 10:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1cbe86c11ba6 Merge - test/tools/javac/parser/netbeans/JavacParserTest.java Changeset: 55a49c399603 Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55a49c399603 Added tag jdk8-b17 for changeset 1cbe86c11ba6 ! .hgtags Changeset: 29a512337b79 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/29a512337b79 Added tag jdk8-b16 for changeset ec2c0973cc31 ! .hgtags Changeset: ab1b1cc78577 Author: katleman Date: 2011-12-15 15:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ab1b1cc78577 Merge ! .hgtags - test/tools/javac/parser/netbeans/JavacParserTest.java Changeset: ab2a880cc23b Author: lana Date: 2011-12-15 19:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ab2a880cc23b Merge From lana.steuck at oracle.com Fri Dec 16 00:13:06 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 16 Dec 2011 08:13:06 +0000 Subject: hg: jdk8/tl/jdk: 31 new changesets Message-ID: <20111216081812.A66194771C@hg.openjdk.java.net> Changeset: 929597c6e777 Author: katleman Date: 2011-12-01 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/929597c6e777 Added tag jdk8-b15 for changeset 3c248d0e2c48 ! .hgtags Changeset: 23acf34c80b0 Author: neugens Date: 2011-12-03 15:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23acf34c80b0 7117914: Fix javac warnings in src/share/classes/sun/java2d Summary: Fix some javac warnings in java2d related code for the Warning Cleanup Day. Reviewed-by: prr, flar ! src/share/classes/java/awt/geom/Path2D.java ! src/share/classes/sun/awt/image/BufImgSurfaceData.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/SurfaceData.java ! src/share/classes/sun/java2d/SurfaceDataProxy.java ! src/share/classes/sun/java2d/loops/GraphicsPrimitive.java ! src/share/classes/sun/java2d/loops/SurfaceType.java ! src/share/classes/sun/java2d/opengl/OGLBufImgOps.java ! src/share/classes/sun/java2d/opengl/OGLDrawImage.java ! src/share/classes/sun/java2d/opengl/OGLPaints.java ! src/share/classes/sun/java2d/opengl/OGLSurfaceData.java ! src/share/classes/sun/java2d/pipe/AAShapePipe.java ! src/share/classes/sun/java2d/pipe/BufferedPaints.java ! src/share/classes/sun/java2d/pipe/BufferedRenderPipe.java ! src/share/classes/sun/java2d/pipe/DrawImage.java ! src/share/classes/sun/java2d/pipe/GlyphListPipe.java ! src/share/classes/sun/java2d/pipe/LoopPipe.java ! src/share/classes/sun/java2d/pipe/RenderingEngine.java ! src/solaris/classes/sun/java2d/x11/X11Renderer.java ! src/solaris/classes/sun/java2d/x11/X11SurfaceData.java Changeset: 70b40ea06df0 Author: prr Date: 2011-12-03 16:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70b40ea06df0 7117199: Fix javac warnings in src/share/classes/java/awt/font Reviewed-by: jgodinez, bae ! src/share/classes/java/awt/font/StyledParagraph.java ! src/share/classes/java/awt/font/TextAttribute.java ! src/share/classes/java/awt/font/TextLayout.java ! src/share/classes/java/awt/font/TextLine.java ! src/share/classes/java/awt/font/TextMeasurer.java Changeset: 4075d524fa46 Author: lana Date: 2011-12-06 16:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4075d524fa46 Merge Changeset: e53a078c2840 Author: anthony Date: 2011-11-09 13:43 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e53a078c2840 7045370: Java Statically Determines Display Size on Linux platforms Summary: Listen to ConfigureNotify events on the root window and update the current screen size accordingly Reviewed-by: art, bae ! src/share/classes/java/awt/Component.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11GraphicsDevice.java ! src/solaris/native/sun/awt/awt_GraphicsEnv.c Changeset: 84e473cf4531 Author: rupashka Date: 2011-11-10 14:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84e473cf4531 6938583: Unexpected NullPointerException by InputContext.endComposition() Reviewed-by: rupashka Contributed-by: Charles Lee ! src/share/classes/javax/swing/text/DefaultCaret.java + test/javax/swing/text/DefaultCaret/6938583/bug6938583.java Changeset: 81f1b32f9e24 Author: malenkov Date: 2011-11-10 17:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81f1b32f9e24 7057459: Regression: Performance degradation with java.beans.XMLEncoder Reviewed-by: rupashka ! src/share/classes/java/beans/Encoder.java Changeset: e120c78cb45c Author: malenkov Date: 2011-11-10 17:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e120c78cb45c 7064279: Introspector.getBeanInfo() should release some resources in timely manner Reviewed-by: art, alexp ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyEditorManager.java + src/share/classes/java/beans/ThreadGroupContext.java ! test/java/beans/Beans/6669869/TestDesignTime.java ! test/java/beans/Beans/6669869/TestGuiAvailable.java ! test/java/beans/Introspector/6380849/TestBeanInfo.java + test/java/beans/Introspector/7064279/Test7064279.java + test/java/beans/Introspector/7064279/test.jar ! test/java/beans/Introspector/Test6660539.java ! test/java/beans/PropertyEditor/6380849/TestPropertyEditor.java Changeset: 8b6a69b2e482 Author: malenkov Date: 2011-11-10 17:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8b6a69b2e482 7087876: java/beans/PropertyDescriptor.html#createPropertyEditor() throws RE if editor cannot be created Reviewed-by: rupashka ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/PropertyEditor/Test7087876.java Changeset: b02495c51b9c Author: malenkov Date: 2011-11-10 17:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b02495c51b9c 7092744: XMLEncoder fails to encode and breaks backward compatibility Reviewed-by: rupashka ! src/share/classes/com/sun/beans/finder/AbstractFinder.java ! src/share/classes/com/sun/beans/finder/ConstructorFinder.java ! src/share/classes/com/sun/beans/finder/MethodFinder.java + test/java/beans/XMLEncoder/Test7092744.java Changeset: 16327765859c Author: malenkov Date: 2011-11-10 17:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/16327765859c 7087429: Constructor of java.beans.PropertyChangeEvent should declare thrown NPE for null source Reviewed-by: rupashka ! src/share/classes/java/beans/PropertyChangeEvent.java + test/java/beans/PropertyChangeSupport/Test7087429.java Changeset: f614bcada2a9 Author: anthony Date: 2011-11-11 15:17 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f614bcada2a9 7103610: _NET_WM_PID and WM_CLIENT_MACHINE are not set Summary: Set the properties to all top-level windows Reviewed-by: anthony Contributed-by: Danesh Dadachanji ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/native/sun/xawt/XToolkit.c Changeset: c0f3f1558a94 Author: rupashka Date: 2011-11-14 14:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0f3f1558a94 7109617: Test was writed for Metal L&F but not set it Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/plaf/metal/MetalLookAndFeel/5073047/bug5073047.java Changeset: a51777c9228a Author: malenkov Date: 2011-11-14 14:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a51777c9228a 7110521: Regression test failed: Introspector/TestTypeResolver.java Reviewed-by: rupashka ! test/java/beans/Introspector/TestTypeResolver.java Changeset: 28f768c41a90 Author: serb Date: 2011-11-12 04:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28f768c41a90 6996291: command line selection of MToolkit by -Dawt.toolkit=sun.awt.motif.MToolkit fails from jdk7 b21 on Reviewed-by: art, dcherepanov, bae, prr ! make/sun/awt/FILES_c_unix.gmk ! make/sun/awt/FILES_export_unix.gmk ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/awt/mawt.gmk - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/ListHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedChildProxyPeer.java - src/solaris/classes/sun/awt/motif/AWTLockAccess.java ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h ! src/solaris/native/sun/awt/awt.h ! src/solaris/native/sun/awt/awt_AWTEvent.c ! src/solaris/native/sun/awt/awt_Component.h - src/solaris/native/sun/awt/awt_Cursor.h ! src/solaris/native/sun/awt/awt_DrawingSurface.c ! src/solaris/native/sun/awt/awt_Font.c ! src/solaris/native/sun/awt/awt_Font.h ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/awt_InputMethod.c - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h ! src/solaris/native/sun/awt/awt_Robot.c - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h ! src/solaris/native/sun/awt/awt_p.h ! src/solaris/native/sun/awt/awt_util.c ! src/solaris/native/sun/awt/awt_util.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h ! src/solaris/native/sun/awt/canvas.h ! src/solaris/native/sun/awt/multi_font.c ! src/solaris/native/sun/awt/multi_font.h ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.h ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/xawt/XToolkit.c Changeset: 6a9d735ebd0a Author: bagiras Date: 2011-11-16 15:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a9d735ebd0a 7108598: Pogo Table Games freeze with JDK 7 Reviewed-by: art, ant ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java + test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java Changeset: 1df53949945d Author: lana Date: 2011-11-18 15:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1df53949945d Merge Changeset: 90d33a64a404 Author: rupashka Date: 2011-11-21 18:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90d33a64a404 7109085: Test use hotkeys not intended for Mac Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com ! test/javax/swing/regtesthelpers/Util.java + test/javax/swing/text/DefaultEditorKit/4278839/bug4278839.java + test/javax/swing/text/JTextComponent/5074573/bug5074573.java + test/javax/swing/text/html/HTMLEditorKit/5043626/bug5043626.java Changeset: c3c80f96cb83 Author: rupashka Date: 2011-11-25 11:52 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c3c80f96cb83 7113337: Swing closed test tries to click in the area reserved for resize by Mac OS X Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java Changeset: 9cbc208dcf08 Author: rupashka Date: 2011-11-29 12:47 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cbc208dcf08 7112925: closed/javax/swing/JTabbedPane/4624207/bug4624207.java fails on MacOS Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JTabbedPane/4624207/bug4624207.java Changeset: 051beb804b12 Author: rupashka Date: 2011-11-30 16:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/051beb804b12 7110440: closed/javax/swing/JScrollBar/4865918/bug4865918.java fails on Aqua L&F Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JScrollBar/4865918/bug4865918.java Changeset: 7dd4395fe4a5 Author: rupashka Date: 2011-11-30 19:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7dd4395fe4a5 7115357: closed/javax/swing/JTable/6263446/bug6263446Table.java fails on MacOS Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JTable/6263446/bug6263446.java Changeset: 4b416a0180dc Author: lana Date: 2011-11-29 15:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b416a0180dc Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: 45eb5a61da07 Author: lana Date: 2011-11-30 12:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45eb5a61da07 Merge Changeset: 79b5c5a8c7e9 Author: serb Date: 2011-12-05 17:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79b5c5a8c7e9 7115400: jdk 8 awt-gate build fails in headless toolkit on solaris. Reviewed-by: prr, art, bae ! make/sun/awt/FILES_c_unix.gmk + src/solaris/native/sun/awt/HeadlessToolkit.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.h Changeset: 2b1438297561 Author: lana Date: 2011-12-06 16:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b1438297561 Merge - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h Changeset: b71d1acfae52 Author: lana Date: 2011-12-06 20:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b71d1acfae52 Merge ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/Encoder.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyDescriptor.java - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh Changeset: cd95291bbbf3 Author: katleman Date: 2011-12-15 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd95291bbbf3 Added tag jdk8-b17 for changeset b71d1acfae52 ! .hgtags Changeset: 8f3d916a9164 Author: katleman Date: 2011-12-15 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f3d916a9164 Added tag jdk8-b16 for changeset 929597c6e777 ! .hgtags Changeset: e55ac966ed95 Author: katleman Date: 2011-12-15 15:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e55ac966ed95 Merge ! .hgtags - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh Changeset: e446c7d24d6c Author: lana Date: 2011-12-15 19:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e446c7d24d6c Merge - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h From chris.hegarty at oracle.com Fri Dec 16 11:16:52 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 16 Dec 2011 19:16:52 +0000 Subject: hg: jdk8/tl/jdk: 7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly cookies Message-ID: <20111216191703.283FA4773B@hg.openjdk.java.net> Changeset: 33ac7a057b9c Author: chegar Date: 2011-12-16 16:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/33ac7a057b9c 7095980: Ensure HttpURLConnection (and supporting APIs) don't expose HttpOnly cookies Reviewed-by: michaelm ! src/share/classes/java/net/HttpCookie.java + src/share/classes/sun/misc/JavaNetHttpCookieAccess.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/protocol/http/HttpOnly.java From jonathan.gibbons at oracle.com Fri Dec 16 13:50:09 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 16 Dec 2011 21:50:09 +0000 Subject: hg: jdk8/tl/langtools: 7121961: javadoc is missing a resource property Message-ID: <20111216215015.1DB0D4773C@hg.openjdk.java.net> Changeset: 6b773fdeb633 Author: jjg Date: 2011-12-16 13:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6b773fdeb633 7121961: javadoc is missing a resource property Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties From jim.holmlund at sun.com Fri Dec 16 16:42:59 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Sat, 17 Dec 2011 00:42:59 +0000 Subject: hg: jdk8/tl/langtools: 7122342: testPrintProcessorInfo/TestWithXstdout.java failed for JDK8 nightly build at 12/16/2011 Message-ID: <20111217004301.B48AA4774D@hg.openjdk.java.net> Changeset: a7a2720c7897 Author: jjh Date: 2011-12-16 16:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a7a2720c7897 7122342: testPrintProcessorInfo/TestWithXstdout.java failed for JDK8 nightly build at 12/16/2011 Summary: Do not pass empty args to javac Reviewed-by: jjg ! test/tools/javac/processing/options/testPrintProcessorInfo/TestWithXstdout.java From stuart.marks at oracle.com Sat Dec 17 08:20:54 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Sat, 17 Dec 2011 16:20:54 +0000 Subject: hg: jdk8/tl/jdk: 7122235: stop the build if javac fails Message-ID: <20111217162116.4EF5C47751@hg.openjdk.java.net> Changeset: abbca81a98a7 Author: smarks Date: 2011-12-17 08:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abbca81a98a7 7122235: stop the build if javac fails Reviewed-by: chegar, dholmes, mcimadamore, ohair ! make/common/Rules.gmk From alan.bateman at oracle.com Sat Dec 17 12:10:05 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 17 Dec 2011 20:10:05 +0000 Subject: hg: jdk8/tl/jdk: 7087549: (fs) Files.newInputStream throws UOE for custom provider options Message-ID: <20111217201024.B8B3547752@hg.openjdk.java.net> Changeset: 528eb0d43e3a Author: alanb Date: 2011-12-17 20:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/528eb0d43e3a 7087549: (fs) Files.newInputStream throws UOE for custom provider options Reviewed-by: alanb Contributed-by: brandon.passanisi at oracle.com ! src/share/classes/java/nio/file/spi/FileSystemProvider.java + test/java/nio/file/Files/CustomOptions.java From maurizio.cimadamore at oracle.com Mon Dec 19 04:07:58 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 19 Dec 2011 12:07:58 +0000 Subject: hg: jdk8/tl/langtools: 7120463: Fix method reference parser support in order to avoid ambiguities Message-ID: <20111219120803.7D0E547756@hg.openjdk.java.net> Changeset: 1ae5988e201b Author: mcimadamore Date: 2011-12-19 12:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ae5988e201b 7120463: Fix method reference parser support in order to avoid ambiguities Summary: Add lookahead routine to disambiguate between method reference in method context and binary expression Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! test/tools/javac/lambda/MethodReferenceParserTest.java From xueming.shen at oracle.com Mon Dec 19 14:15:25 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 19 Dec 2011 22:15:25 +0000 Subject: hg: jdk8/tl/jdk: 6990617: Regular expression doesn't match if unicode character next to a digit. Message-ID: <20111219221551.24C984775E@hg.openjdk.java.net> Changeset: 5b27b978ed42 Author: sherman Date: 2011-12-19 14:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5b27b978ed42 6990617: Regular expression doesn't match if unicode character next to a digit. Summary: updated RemoveQEQuotation() to deal with this case correctly Reviewed-by: sherman Contributed-by: stephen.flores at oracle.com ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java From dmitry.degrave at sun.com Sun Dec 18 10:16:47 2011 From: dmitry.degrave at sun.com (dmitry.degrave at sun.com) Date: Sun, 18 Dec 2011 18:16:47 +0000 Subject: hg: jdk8/tl/corba: 7046238: new InitialContext(); hangs Message-ID: <20111218181649.AD06647753@hg.openjdk.java.net> Changeset: 052dda3b5ce3 Author: dmeetry Date: 2011-12-18 22:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/052dda3b5ce3 7046238: new InitialContext(); hangs Summary: Synchronization on a single monitor for contactInfo parameters with identical hashCode() Reviewed-by: robm, skoppar ! src/share/classes/com/sun/corba/se/impl/protocol/CorbaClientRequestDispatcherImpl.java From weijun.wang at oracle.com Mon Dec 19 22:23:42 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 20 Dec 2011 14:23:42 +0800 Subject: code review request (Re: Some Mac JDK codes not open sourced (was Fwd: Re: Kerberos codes in Apple's Java)) In-Reply-To: <5FA024C7-8F7E-4A5A-AE0D-DA8104580AC9@apple.com> References: <4EEAB262.7090606@oracle.com> <6586F238-E84C-4EB7-8ABC-593E818C6809@apple.com> <4EEFDB8E.3070202@oracle.com> <4EEFE2B5.5020900@oracle.com> <4EEFEB5D.4040706@oracle.com> <5FA024C7-8F7E-4A5A-AE0D-DA8104580AC9@apple.com> Message-ID: <4EF029EE.9070806@oracle.com> Hi All I've created a webrev. Please anyone take a review: http://cr.openjdk.java.net/~weijun/9999999/webrev.12/ *Jeannette*: Is a formal donate-to-openjdk process needed? The file in my webrev still has the Apple copyright line. IANAL and I do not want to make any change to it myself. Thanks Max On 12/20/2011 09:58 AM, Mike Swingler wrote: > This is just a .c file. No Objective-C here. > > ~Mike > > On Dec 19, 2011, at 5:56 PM, Weijun Wang wrote: > >> Hi Bino >> >> Thank you for locating it. I would be glad if you or Scott can do an integration. I guess this .m file is almost a pure .c file but I'm really unfamiliar with compiler settings on Mac. >> >> -Max >> >> >> On 12/20/2011 09:51 AM, Bino George wrote: >>> Hi Weijun, >>> >>> It looks like we did not port over some of the native code that Scott Kovatch wrote for the Mac. Attached is the native file for JDK6 that implements the missing JNI method. Can you or Scott try to integrate it to JDK 7 ? If you have difficulty, let me know and I will take care of it some time this week. >>> >>> >>> >>> >>> >>> >>> Thanks, >>> Bino. >>> >>> >>> On Dec 19, 2011, at 5:19 PM, Weijun Wang wrote: >>> >>>> >>>> >>>> On 12/20/2011 09:10 AM, Bino George wrote: >>>>> Hi Weijun, >>>>> >>>>>> I'm testing on 10.6. >>>>> >>>>> Does JDK6 (Apple JVM) work for your test on 10.6 ??? >>>>> >>>>> The SCDynamicStoreConfig implementation only works on Lion (10.7). >>>>> >>>>> >>>>>> In fact, in src/share/classes/sun/security/krb5/Credentials.java, the >>>>>> native method declaration still exists: >>>>>> >>>>>> private static native Credentials acquireDefaultNativeCreds(); >>>>>> >>>>> >>>>> We don't do anything native on 10.6 and before we find the config file >>>>> using this logic and simply parse it in Config.java : >>>> >>>> I'm not talking about the config part at all. That part has no problem. >>>> >>>> What I said is credential cache, i.e. the little piece of private info stored on local computer (either a file or a block in memory) after kinit is called. The info is generated by kinit and can be viewed either by the native klist tool or thru the Java call >>>> >>>> sun.security.krb5,Credentials.acquireTGTFromCache() >>>> >>>> What I observed is that in Apple JDK 6 both these 2 methods return the same info but in macosx-port the Java method does not return anything. >>>> >>>> That's what I mentioned in the "Thu, 01 Dec 2011 22:54:57 +0800" mail. (scroll down to 2/3 place). >>>> >>>> Thanks >>>> Max >>>> >>>>> >>>>> private String findMacosConfigFile() { >>>>> String userHome = getProperty("user.home"); >>>>> finalString PREF_FILE = "/Library/Preferences/edu.mit.Kerberos"; >>>>> String userPrefs=userHome + PREF_FILE; >>>>> >>>>> >>>>> if (fileExists(userPrefs)) { >>>>> return userPrefs; >>>>> } >>>>> >>>>> >>>>> if (fileExists(PREF_FILE)) { >>>>> return PREF_FILE; >>>>> } >>>>> >>>>> >>>>> if (fileExists("/etc/krb5.conf")) { >>>>> return"/etc/krb5.conf"; >>>>> } >>>>> >>>>> >>>>> return ""; >>>>> } >>>>> >>>>> >>>>> >>>>> >>>>> Regards, >>>>> >>>>> Bino. >>>>> >>>>> >>>>> >>>>> On Dec 19, 2011, at 4:49 PM, Weijun Wang wrote: >>>>> >>>>>> I take a brief look at >>>>>> >>>>>> src/macosx/native/java/util/SCDynamicStoreConfig.m >>>>>> src/share/classes/sun/security/krb5/SCDynamicStoreConfig.java >>>>>> >>>>>> and it is an alternative way of specifying krb5.conf, but there is no >>>>>> line on the credentials cache. >>>>>> >>>>>> In fact, in src/share/classes/sun/security/krb5/Credentials.java, the >>>>>> native method declaration still exists: >>>>>> >>>>>> private static native Credentials acquireDefaultNativeCreds(); >>>>>> >>>>>> but I cannot find the implementation codes for it. >>>>>> >>>>>> I'm testing on 10.6. >>>>>> >>>>>> Thanks >>>>>> Max >>>>>> >>>>>> On 12/20/2011 05:30 AM, Bino George wrote: >>>>>>> Hi Mike, >>>>>>> >>>>>>>> Actually, Bino - on Lion we compile in the SCDynamicStore version, and >>>>>>>> on SnowLeopard we compile it out an just use the file version in Java. >>>>>>>> Do you know if the SCDynamicStore version is building on SnowLeopard, >>>>>>>> but just not enabled? Does it rely on new constants that are only on >>>>>>>> Lion? >>>>>>> >>>>>>> >>>>>>> The difference between JDK6 and JDK7 is that in JDK6 we do not compile >>>>>>> the SCDynamicStore code. But since SCDynamicStore does not use any new >>>>>>> API, we compile it both on Lion and SnowLeopard on JDK7 and we only load >>>>>>> the SCDynamicStore code on Lion (we check at runtime for os version). We >>>>>>> don't rely on any OS provided constants, I don't think there are any, we >>>>>>> just look for the following keys on Lion in SCDynamicStore : >>>>>>> >>>>>>> #define KERBEROS_DEFAULT_REALMS @"Kerberos-Default-Realms" >>>>>>> #define KERBEROS_DEFAULT_REALM_MAPPINGS @"Kerberos-Domain-Realm-Mappings" >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Bino. >>>>>>> >>>>>>> On Dec 19, 2011, at 11:10 AM, Mike Swingler wrote: >>>>>>> >>>>>>>> On Dec 19, 2011, at 11:05 AM, Bino George wrote: >>>>>>>> >>>>>>>>> Hi Mike, >>>>>>>>> >>>>>>>>>> Bino, I thought we contributed all of the Kerberos implementation >>>>>>>>>> (including the new SCDynamicStore implementation for Lion). Do you >>>>>>>>>> think the system kinit and the SCDynamicStore versions aren't >>>>>>>>>> playing ball with each other? >>>>>>>>> >>>>>>>>> Yes, we did contribute that code already and we tested it in JDK7 on >>>>>>>>> Lion. Not sure if this is a SnowLeopard issue. >>>>>>>>> >>>>>>>>> Weijun, does your tests work with JDK6 from Apple on the same >>>>>>>>> machine, the code should be identical. >>>>>>>> >>>>>>>> Actually, Bino - on Lion we compile in the SCDynamicStore version, and >>>>>>>> on SnowLeopard we compile it out an just use the file version in Java. >>>>>>>> Do you know if the SCDynamicStore version is building on SnowLeopard, >>>>>>>> but just not enabled? Does it rely on new constants that are only on >>>>>>>> Lion? >>>>>>>> >>>>>>>> ~Mike >>>>>>>> >>>>>>>>> On Dec 19, 2011, at 10:50 AM, Mike Swingler wrote: >>>>>>>>> >>>>>>>>>> Bino, I thought we contributed all of the Kerberos implementation >>>>>>>>>> (including the new SCDynamicStore implementation for Lion). Do you >>>>>>>>>> think the system kinit and the SCDynamicStore versions aren't >>>>>>>>>> playing ball with each other? Weijun, what version of Mac OS X are >>>>>>>>>> you testing on? 10.6 or 10.7? >>>>>>>>>> >>>>>>>>>> ~Mike >>>>>>>>>> >>>>>>>>>> On Dec 18, 2011, at 10:49 PM, Jeannette Hung wrote: >>>>>>>>>> >>>>>>>>>>> Hey Mike, >>>>>>>>>>> What's the scope with the Kerberos code in the macos port? It looks >>>>>>>>>>> like something is missing. >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> jeannette >>>>>>>>>>> >>>>>>>>>>> Begin forwarded message: >>>>>>>>>>> >>>>>>>>>>>> *From: *Weijun Wang>>>>>>>>>>> >>>>>>>>>>>> > >>>>>>>>>>>> *Subject: **Some Mac JDK codes not open sourced (was Fwd: Re: >>>>>>>>>>>> Kerberos codes in Apple's Java)* >>>>>>>>>>>> *Date: *December 15, 2011 6:52:18 PM PST >>>>>>>>>>>> *To: *Frances Ho>>>>>>>>>>> >>>>>>>>>>>> > >>>>>>>>>>>> *Cc: *Jeannette Hung>>>>>>>>>>> >>>>>>>>>>>> > >>>>>>>>>>>> >>>>>>>>>>>> Hi Frances >>>>>>>>>>>> >>>>>>>>>>>> I suspect some Kerberos native codes on Apple's JDK 6 are not >>>>>>>>>>>> included in their macosx-port OpenJDK 7 contribution. I've >>>>>>>>>>>> contacted with some Apple guys but get no answer until now. (see >>>>>>>>>>>> forwarded mail thread) >>>>>>>>>>>> >>>>>>>>>>>> Do we have a project/product manager that can talk to someone >>>>>>>>>>>> inside Apple on this? >>>>>>>>>>>> >>>>>>>>>>>> In my opinion, these are not sensitive codes that they cannot open >>>>>>>>>>>> source. >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> Max >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -------- Original Message -------- >>>>>>>>>>>> Subject: Re: Kerberos codes in Apple's Java >>>>>>>>>>>> Date: Thu, 01 Dec 2011 22:54:57 +0800 >>>>>>>>>>>> From: Weijun Wang>>>>>>>>>>> >>>>>>>>>>>> > >>>>>>>>>>>> To: Bino George >>>>>>>>>>>> > >>>>>>>>>>>> CC: security-dev at openjdk.java.net >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >, >>>>>>>>>>>> macosx-port-dev at openjdk.java.net >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Hi Bino >>>>>>>>>>>> >>>>>>>>>>>>>> 2. Reading native memory-based credentials cache into >>>>>>>>>>>>>> Credentials objects >>>>>>>>>>>>> >>>>>>>>>>>>> I don't think we do this in JDK6 either. >>>>>>>>>>>> >>>>>>>>>>>> I just tried OS X's builtin kinit and klist command: >>>>>>>>>>>> >>>>>>>>>>>> $ kinit dummy >>>>>>>>>>>> Please enter the password for dummy at THREE.LOCAL >>>>>>>>>>>> >>>>>>>>>>>> : >>>>>>>>>>>> $ klist >>>>>>>>>>>> Kerberos 5 ticket cache: 'API:Initial default ccache' >>>>>>>>>>>> ... >>>>>>>>>>>> >>>>>>>>>>>> So here the ccache name is "API:Initial default ccache", which looks >>>>>>>>>>>> like an in-memory ccache. At least I cannot find normal file-based >>>>>>>>>>>> ccache file named /tmp/krb5cc_**. >>>>>>>>>>>> >>>>>>>>>>>> There is also a difference between Apple's JDK 6u29 and the current >>>>>>>>>>>> macosx-port OpenJDK build when calling the following method: >>>>>>>>>>>> >>>>>>>>>>>> sun.security.krb5,Credentials.acquireTGTFromCache() >>>>>>>>>>>> >>>>>>>>>>>> It returns a valid credential (which is identical to the klist >>>>>>>>>>>> output) >>>>>>>>>>>> in Apple's 6u29, but the macosx-port one returns null. So it >>>>>>>>>>>> seems the >>>>>>>>>>>> Apple JDK can see the special ccache object but macosx-port cannot. >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> Max >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Regards >>>>>>>>>>>>> Bino. >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Oct 14, 2011, at 10:38 AM, Weijun Wang wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Mike >>>>>>>>>>>>>> >>>>>>>>>>>>>> I'm working in the Java SE Security Team in Oracle. Apple's >>>>>>>>>>>>>> JRE (at >>>>>>>>>>>>>> least in the JDK 6 releases) supports some extra Kerberos >>>>>>>>>>>>>> features for >>>>>>>>>>>>>> OS X. As I know, at least there are: >>>>>>>>>>>>>> >>>>>>>>>>>>>> 1. Looking for krb5.conf at /Library/Preferences/edu.mit.Kerberos >>>>>>>>>>>>>> 2. Reading native memory-based credentials cache into >>>>>>>>>>>>>> Credentials objects >>>>>>>>>>>>>> >>>>>>>>>>>>>> I didn't see them on the Project Status page [1]. Is it >>>>>>>>>>>>>> because they >>>>>>>>>>>>>> are too trivial to be listed or you're not going to support them? >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> Max >>>>>>>>>>>>>> >>>>>>>>>>>>>> [1] >>>>>>>>>>>>>> http://wikis.sun.com/display/OpenJDK/Mac+OS+X+Port+Project+Status >>>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>> >>> > From swingler at apple.com Mon Dec 19 22:27:01 2011 From: swingler at apple.com (Mike Swingler) Date: Mon, 19 Dec 2011 22:27:01 -0800 Subject: code review request (Re: Some Mac JDK codes not open sourced (was Fwd: Re: Kerberos codes in Apple's Java)) In-Reply-To: <4EF029EE.9070806@oracle.com> References: <4EEAB262.7090606@oracle.com> <6586F238-E84C-4EB7-8ABC-593E818C6809@apple.com> <4EEFDB8E.3070202@oracle.com> <4EEFE2B5.5020900@oracle.com> <4EEFEB5D.4040706@oracle.com> <5FA024C7-8F7E-4A5A-AE0D-DA8104580AC9@apple.com> <4EF029EE.9070806@oracle.com> Message-ID: <044650D5-858A-412A-8836-DEE186BC5910@apple.com> I'll be happy to change the copyright. :-) ~Mike On Dec 19, 2011, at 10:23 PM, Weijun Wang wrote: > Hi All > > I've created a webrev. Please anyone take a review: > > http://cr.openjdk.java.net/~weijun/9999999/webrev.12/ > > *Jeannette*: > > Is a formal donate-to-openjdk process needed? The file in my webrev still has the Apple copyright line. IANAL and I do not want to make any change to it myself. > > Thanks > Max > > > On 12/20/2011 09:58 AM, Mike Swingler wrote: >> This is just a .c file. No Objective-C here. >> >> ~Mike >> >> On Dec 19, 2011, at 5:56 PM, Weijun Wang wrote: >> >>> Hi Bino >>> >>> Thank you for locating it. I would be glad if you or Scott can do an integration. I guess this .m file is almost a pure .c file but I'm really unfamiliar with compiler settings on Mac. >>> >>> -Max >>> >>> >>> On 12/20/2011 09:51 AM, Bino George wrote: >>>> Hi Weijun, >>>> >>>> It looks like we did not port over some of the native code that Scott Kovatch wrote for the Mac. Attached is the native file for JDK6 that implements the missing JNI method. Can you or Scott try to integrate it to JDK 7 ? If you have difficulty, let me know and I will take care of it some time this week. >>>> >>>> >>>> >>>> >>>> >>>> >>>> Thanks, >>>> Bino. >>>> >>>> >>>> On Dec 19, 2011, at 5:19 PM, Weijun Wang wrote: >>>> >>>>> >>>>> >>>>> On 12/20/2011 09:10 AM, Bino George wrote: >>>>>> Hi Weijun, >>>>>> >>>>>>> I'm testing on 10.6. >>>>>> >>>>>> Does JDK6 (Apple JVM) work for your test on 10.6 ??? >>>>>> >>>>>> The SCDynamicStoreConfig implementation only works on Lion (10.7). >>>>>> >>>>>> >>>>>>> In fact, in src/share/classes/sun/security/krb5/Credentials.java, the >>>>>>> native method declaration still exists: >>>>>>> >>>>>>> private static native Credentials acquireDefaultNativeCreds(); >>>>>>> >>>>>> >>>>>> We don't do anything native on 10.6 and before we find the config file >>>>>> using this logic and simply parse it in Config.java : >>>>> >>>>> I'm not talking about the config part at all. That part has no problem. >>>>> >>>>> What I said is credential cache, i.e. the little piece of private info stored on local computer (either a file or a block in memory) after kinit is called. The info is generated by kinit and can be viewed either by the native klist tool or thru the Java call >>>>> >>>>> sun.security.krb5,Credentials.acquireTGTFromCache() >>>>> >>>>> What I observed is that in Apple JDK 6 both these 2 methods return the same info but in macosx-port the Java method does not return anything. >>>>> >>>>> That's what I mentioned in the "Thu, 01 Dec 2011 22:54:57 +0800" mail. (scroll down to 2/3 place). >>>>> >>>>> Thanks >>>>> Max >>>>> >>>>>> >>>>>> private String findMacosConfigFile() { >>>>>> String userHome = getProperty("user.home"); >>>>>> finalString PREF_FILE = "/Library/Preferences/edu.mit.Kerberos"; >>>>>> String userPrefs=userHome + PREF_FILE; >>>>>> >>>>>> >>>>>> if (fileExists(userPrefs)) { >>>>>> return userPrefs; >>>>>> } >>>>>> >>>>>> >>>>>> if (fileExists(PREF_FILE)) { >>>>>> return PREF_FILE; >>>>>> } >>>>>> >>>>>> >>>>>> if (fileExists("/etc/krb5.conf")) { >>>>>> return"/etc/krb5.conf"; >>>>>> } >>>>>> >>>>>> >>>>>> return ""; >>>>>> } >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Regards, >>>>>> >>>>>> Bino. >>>>>> >>>>>> >>>>>> >>>>>> On Dec 19, 2011, at 4:49 PM, Weijun Wang wrote: >>>>>> >>>>>>> I take a brief look at >>>>>>> >>>>>>> src/macosx/native/java/util/SCDynamicStoreConfig.m >>>>>>> src/share/classes/sun/security/krb5/SCDynamicStoreConfig.java >>>>>>> >>>>>>> and it is an alternative way of specifying krb5.conf, but there is no >>>>>>> line on the credentials cache. >>>>>>> >>>>>>> In fact, in src/share/classes/sun/security/krb5/Credentials.java, the >>>>>>> native method declaration still exists: >>>>>>> >>>>>>> private static native Credentials acquireDefaultNativeCreds(); >>>>>>> >>>>>>> but I cannot find the implementation codes for it. >>>>>>> >>>>>>> I'm testing on 10.6. >>>>>>> >>>>>>> Thanks >>>>>>> Max >>>>>>> >>>>>>> On 12/20/2011 05:30 AM, Bino George wrote: >>>>>>>> Hi Mike, >>>>>>>> >>>>>>>>> Actually, Bino - on Lion we compile in the SCDynamicStore version, and >>>>>>>>> on SnowLeopard we compile it out an just use the file version in Java. >>>>>>>>> Do you know if the SCDynamicStore version is building on SnowLeopard, >>>>>>>>> but just not enabled? Does it rely on new constants that are only on >>>>>>>>> Lion? >>>>>>>> >>>>>>>> >>>>>>>> The difference between JDK6 and JDK7 is that in JDK6 we do not compile >>>>>>>> the SCDynamicStore code. But since SCDynamicStore does not use any new >>>>>>>> API, we compile it both on Lion and SnowLeopard on JDK7 and we only load >>>>>>>> the SCDynamicStore code on Lion (we check at runtime for os version). We >>>>>>>> don't rely on any OS provided constants, I don't think there are any, we >>>>>>>> just look for the following keys on Lion in SCDynamicStore : >>>>>>>> >>>>>>>> #define KERBEROS_DEFAULT_REALMS @"Kerberos-Default-Realms" >>>>>>>> #define KERBEROS_DEFAULT_REALM_MAPPINGS @"Kerberos-Domain-Realm-Mappings" >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Bino. >>>>>>>> >>>>>>>> On Dec 19, 2011, at 11:10 AM, Mike Swingler wrote: >>>>>>>> >>>>>>>>> On Dec 19, 2011, at 11:05 AM, Bino George wrote: >>>>>>>>> >>>>>>>>>> Hi Mike, >>>>>>>>>> >>>>>>>>>>> Bino, I thought we contributed all of the Kerberos implementation >>>>>>>>>>> (including the new SCDynamicStore implementation for Lion). Do you >>>>>>>>>>> think the system kinit and the SCDynamicStore versions aren't >>>>>>>>>>> playing ball with each other? >>>>>>>>>> >>>>>>>>>> Yes, we did contribute that code already and we tested it in JDK7 on >>>>>>>>>> Lion. Not sure if this is a SnowLeopard issue. >>>>>>>>>> >>>>>>>>>> Weijun, does your tests work with JDK6 from Apple on the same >>>>>>>>>> machine, the code should be identical. >>>>>>>>> >>>>>>>>> Actually, Bino - on Lion we compile in the SCDynamicStore version, and >>>>>>>>> on SnowLeopard we compile it out an just use the file version in Java. >>>>>>>>> Do you know if the SCDynamicStore version is building on SnowLeopard, >>>>>>>>> but just not enabled? Does it rely on new constants that are only on >>>>>>>>> Lion? >>>>>>>>> >>>>>>>>> ~Mike >>>>>>>>> >>>>>>>>>> On Dec 19, 2011, at 10:50 AM, Mike Swingler wrote: >>>>>>>>>> >>>>>>>>>>> Bino, I thought we contributed all of the Kerberos implementation >>>>>>>>>>> (including the new SCDynamicStore implementation for Lion). Do you >>>>>>>>>>> think the system kinit and the SCDynamicStore versions aren't >>>>>>>>>>> playing ball with each other? Weijun, what version of Mac OS X are >>>>>>>>>>> you testing on? 10.6 or 10.7? >>>>>>>>>>> >>>>>>>>>>> ~Mike >>>>>>>>>>> >>>>>>>>>>> On Dec 18, 2011, at 10:49 PM, Jeannette Hung wrote: >>>>>>>>>>> >>>>>>>>>>>> Hey Mike, >>>>>>>>>>>> What's the scope with the Kerberos code in the macos port? It looks >>>>>>>>>>>> like something is missing. >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> jeannette >>>>>>>>>>>> >>>>>>>>>>>> Begin forwarded message: >>>>>>>>>>>> >>>>>>>>>>>>> *From: *Weijun Wang>>>>>>>>>>>> >>>>>>>>>>>>> > >>>>>>>>>>>>> *Subject: **Some Mac JDK codes not open sourced (was Fwd: Re: >>>>>>>>>>>>> Kerberos codes in Apple's Java)* >>>>>>>>>>>>> *Date: *December 15, 2011 6:52:18 PM PST >>>>>>>>>>>>> *To: *Frances Ho>>>>>>>>>>>> >>>>>>>>>>>>> > >>>>>>>>>>>>> *Cc: *Jeannette Hung>>>>>>>>>>>> >>>>>>>>>>>>> > >>>>>>>>>>>>> >>>>>>>>>>>>> Hi Frances >>>>>>>>>>>>> >>>>>>>>>>>>> I suspect some Kerberos native codes on Apple's JDK 6 are not >>>>>>>>>>>>> included in their macosx-port OpenJDK 7 contribution. I've >>>>>>>>>>>>> contacted with some Apple guys but get no answer until now. (see >>>>>>>>>>>>> forwarded mail thread) >>>>>>>>>>>>> >>>>>>>>>>>>> Do we have a project/product manager that can talk to someone >>>>>>>>>>>>> inside Apple on this? >>>>>>>>>>>>> >>>>>>>>>>>>> In my opinion, these are not sensitive codes that they cannot open >>>>>>>>>>>>> source. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> Max >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -------- Original Message -------- >>>>>>>>>>>>> Subject: Re: Kerberos codes in Apple's Java >>>>>>>>>>>>> Date: Thu, 01 Dec 2011 22:54:57 +0800 >>>>>>>>>>>>> From: Weijun Wang>>>>>>>>>>>> >>>>>>>>>>>>> > >>>>>>>>>>>>> To: Bino George >>>>>>>>>>>>> > >>>>>>>>>>>>> CC: security-dev at openjdk.java.net >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> >, >>>>>>>>>>>>> macosx-port-dev at openjdk.java.net >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Hi Bino >>>>>>>>>>>>> >>>>>>>>>>>>>>> 2. Reading native memory-based credentials cache into >>>>>>>>>>>>>>> Credentials objects >>>>>>>>>>>>>> >>>>>>>>>>>>>> I don't think we do this in JDK6 either. >>>>>>>>>>>>> >>>>>>>>>>>>> I just tried OS X's builtin kinit and klist command: >>>>>>>>>>>>> >>>>>>>>>>>>> $ kinit dummy >>>>>>>>>>>>> Please enter the password for dummy at THREE.LOCAL >>>>>>>>>>>>> >>>>>>>>>>>>> : >>>>>>>>>>>>> $ klist >>>>>>>>>>>>> Kerberos 5 ticket cache: 'API:Initial default ccache' >>>>>>>>>>>>> ... >>>>>>>>>>>>> >>>>>>>>>>>>> So here the ccache name is "API:Initial default ccache", which looks >>>>>>>>>>>>> like an in-memory ccache. At least I cannot find normal file-based >>>>>>>>>>>>> ccache file named /tmp/krb5cc_**. >>>>>>>>>>>>> >>>>>>>>>>>>> There is also a difference between Apple's JDK 6u29 and the current >>>>>>>>>>>>> macosx-port OpenJDK build when calling the following method: >>>>>>>>>>>>> >>>>>>>>>>>>> sun.security.krb5,Credentials.acquireTGTFromCache() >>>>>>>>>>>>> >>>>>>>>>>>>> It returns a valid credential (which is identical to the klist >>>>>>>>>>>>> output) >>>>>>>>>>>>> in Apple's 6u29, but the macosx-port one returns null. So it >>>>>>>>>>>>> seems the >>>>>>>>>>>>> Apple JDK can see the special ccache object but macosx-port cannot. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> Max >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Regards >>>>>>>>>>>>>> Bino. >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Oct 14, 2011, at 10:38 AM, Weijun Wang wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi Mike >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I'm working in the Java SE Security Team in Oracle. Apple's >>>>>>>>>>>>>>> JRE (at >>>>>>>>>>>>>>> least in the JDK 6 releases) supports some extra Kerberos >>>>>>>>>>>>>>> features for >>>>>>>>>>>>>>> OS X. As I know, at least there are: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> 1. Looking for krb5.conf at /Library/Preferences/edu.mit.Kerberos >>>>>>>>>>>>>>> 2. Reading native memory-based credentials cache into >>>>>>>>>>>>>>> Credentials objects >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I didn't see them on the Project Status page [1]. Is it >>>>>>>>>>>>>>> because they >>>>>>>>>>>>>>> are too trivial to be listed or you're not going to support them? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>> Max >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> [1] >>>>>>>>>>>>>>> http://wikis.sun.com/display/OpenJDK/Mac+OS+X+Port+Project+Status >>>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>> >>>> >> From jeannette.hung at oracle.com Mon Dec 19 22:39:03 2011 From: jeannette.hung at oracle.com (Jeannette Hung) Date: Mon, 19 Dec 2011 22:39:03 -0800 Subject: code review request (Re: Some Mac JDK codes not open sourced (was Fwd: Re: Kerberos codes in Apple's Java)) In-Reply-To: <044650D5-858A-412A-8836-DEE186BC5910@apple.com> References: <4EEAB262.7090606@oracle.com> <6586F238-E84C-4EB7-8ABC-593E818C6809@apple.com> <4EEFDB8E.3070202@oracle.com> <4EEFE2B5.5020900@oracle.com> <4EEFEB5D.4040706@oracle.com> <5FA024C7-8F7E-4A5A-AE0D-DA8104580AC9@apple.com> <4EF029EE.9070806@oracle.com> <044650D5-858A-412A-8836-DEE186BC5910@apple.com> Message-ID: <36F2AB93-D198-47BD-B6BE-8194C972FD4E@oracle.com> Thanks, Mike! On Dec 19, 2011, at 10:27 PM, Mike Swingler wrote: > I'll be happy to change the copyright. :-) > > ~Mike > > On Dec 19, 2011, at 10:23 PM, Weijun Wang wrote: > >> Hi All >> >> I've created a webrev. Please anyone take a review: >> >> http://cr.openjdk.java.net/~weijun/9999999/webrev.12/ >> >> *Jeannette*: >> >> Is a formal donate-to-openjdk process needed? The file in my webrev still has the Apple copyright line. IANAL and I do not want to make any change to it myself. >> >> Thanks >> Max >> >> >> On 12/20/2011 09:58 AM, Mike Swingler wrote: >>> This is just a .c file. No Objective-C here. >>> >>> ~Mike >>> >>> On Dec 19, 2011, at 5:56 PM, Weijun Wang wrote: >>> >>>> Hi Bino >>>> >>>> Thank you for locating it. I would be glad if you or Scott can do an integration. I guess this .m file is almost a pure .c file but I'm really unfamiliar with compiler settings on Mac. >>>> >>>> -Max >>>> >>>> >>>> On 12/20/2011 09:51 AM, Bino George wrote: >>>>> Hi Weijun, >>>>> >>>>> It looks like we did not port over some of the native code that Scott Kovatch wrote for the Mac. Attached is the native file for JDK6 that implements the missing JNI method. Can you or Scott try to integrate it to JDK 7 ? If you have difficulty, let me know and I will take care of it some time this week. >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> Thanks, >>>>> Bino. >>>>> >>>>> >>>>> On Dec 19, 2011, at 5:19 PM, Weijun Wang wrote: >>>>> >>>>>> >>>>>> >>>>>> On 12/20/2011 09:10 AM, Bino George wrote: >>>>>>> Hi Weijun, >>>>>>> >>>>>>>> I'm testing on 10.6. >>>>>>> >>>>>>> Does JDK6 (Apple JVM) work for your test on 10.6 ??? >>>>>>> >>>>>>> The SCDynamicStoreConfig implementation only works on Lion (10.7). >>>>>>> >>>>>>> >>>>>>>> In fact, in src/share/classes/sun/security/krb5/Credentials.java, the >>>>>>>> native method declaration still exists: >>>>>>>> >>>>>>>> private static native Credentials acquireDefaultNativeCreds(); >>>>>>>> >>>>>>> >>>>>>> We don't do anything native on 10.6 and before we find the config file >>>>>>> using this logic and simply parse it in Config.java : >>>>>> >>>>>> I'm not talking about the config part at all. That part has no problem. >>>>>> >>>>>> What I said is credential cache, i.e. the little piece of private info stored on local computer (either a file or a block in memory) after kinit is called. The info is generated by kinit and can be viewed either by the native klist tool or thru the Java call >>>>>> >>>>>> sun.security.krb5,Credentials.acquireTGTFromCache() >>>>>> >>>>>> What I observed is that in Apple JDK 6 both these 2 methods return the same info but in macosx-port the Java method does not return anything. >>>>>> >>>>>> That's what I mentioned in the "Thu, 01 Dec 2011 22:54:57 +0800" mail. (scroll down to 2/3 place). >>>>>> >>>>>> Thanks >>>>>> Max >>>>>> >>>>>>> >>>>>>> private String findMacosConfigFile() { >>>>>>> String userHome = getProperty("user.home"); >>>>>>> finalString PREF_FILE = "/Library/Preferences/edu.mit.Kerberos"; >>>>>>> String userPrefs=userHome + PREF_FILE; >>>>>>> >>>>>>> >>>>>>> if (fileExists(userPrefs)) { >>>>>>> return userPrefs; >>>>>>> } >>>>>>> >>>>>>> >>>>>>> if (fileExists(PREF_FILE)) { >>>>>>> return PREF_FILE; >>>>>>> } >>>>>>> >>>>>>> >>>>>>> if (fileExists("/etc/krb5.conf")) { >>>>>>> return"/etc/krb5.conf"; >>>>>>> } >>>>>>> >>>>>>> >>>>>>> return ""; >>>>>>> } >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Regards, >>>>>>> >>>>>>> Bino. >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Dec 19, 2011, at 4:49 PM, Weijun Wang wrote: >>>>>>> >>>>>>>> I take a brief look at >>>>>>>> >>>>>>>> src/macosx/native/java/util/SCDynamicStoreConfig.m >>>>>>>> src/share/classes/sun/security/krb5/SCDynamicStoreConfig.java >>>>>>>> >>>>>>>> and it is an alternative way of specifying krb5.conf, but there is no >>>>>>>> line on the credentials cache. >>>>>>>> >>>>>>>> In fact, in src/share/classes/sun/security/krb5/Credentials.java, the >>>>>>>> native method declaration still exists: >>>>>>>> >>>>>>>> private static native Credentials acquireDefaultNativeCreds(); >>>>>>>> >>>>>>>> but I cannot find the implementation codes for it. >>>>>>>> >>>>>>>> I'm testing on 10.6. >>>>>>>> >>>>>>>> Thanks >>>>>>>> Max >>>>>>>> >>>>>>>> On 12/20/2011 05:30 AM, Bino George wrote: >>>>>>>>> Hi Mike, >>>>>>>>> >>>>>>>>>> Actually, Bino - on Lion we compile in the SCDynamicStore version, and >>>>>>>>>> on SnowLeopard we compile it out an just use the file version in Java. >>>>>>>>>> Do you know if the SCDynamicStore version is building on SnowLeopard, >>>>>>>>>> but just not enabled? Does it rely on new constants that are only on >>>>>>>>>> Lion? >>>>>>>>> >>>>>>>>> >>>>>>>>> The difference between JDK6 and JDK7 is that in JDK6 we do not compile >>>>>>>>> the SCDynamicStore code. But since SCDynamicStore does not use any new >>>>>>>>> API, we compile it both on Lion and SnowLeopard on JDK7 and we only load >>>>>>>>> the SCDynamicStore code on Lion (we check at runtime for os version). We >>>>>>>>> don't rely on any OS provided constants, I don't think there are any, we >>>>>>>>> just look for the following keys on Lion in SCDynamicStore : >>>>>>>>> >>>>>>>>> #define KERBEROS_DEFAULT_REALMS @"Kerberos-Default-Realms" >>>>>>>>> #define KERBEROS_DEFAULT_REALM_MAPPINGS @"Kerberos-Domain-Realm-Mappings" >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Bino. >>>>>>>>> >>>>>>>>> On Dec 19, 2011, at 11:10 AM, Mike Swingler wrote: >>>>>>>>> >>>>>>>>>> On Dec 19, 2011, at 11:05 AM, Bino George wrote: >>>>>>>>>> >>>>>>>>>>> Hi Mike, >>>>>>>>>>> >>>>>>>>>>>> Bino, I thought we contributed all of the Kerberos implementation >>>>>>>>>>>> (including the new SCDynamicStore implementation for Lion). Do you >>>>>>>>>>>> think the system kinit and the SCDynamicStore versions aren't >>>>>>>>>>>> playing ball with each other? >>>>>>>>>>> >>>>>>>>>>> Yes, we did contribute that code already and we tested it in JDK7 on >>>>>>>>>>> Lion. Not sure if this is a SnowLeopard issue. >>>>>>>>>>> >>>>>>>>>>> Weijun, does your tests work with JDK6 from Apple on the same >>>>>>>>>>> machine, the code should be identical. >>>>>>>>>> >>>>>>>>>> Actually, Bino - on Lion we compile in the SCDynamicStore version, and >>>>>>>>>> on SnowLeopard we compile it out an just use the file version in Java. >>>>>>>>>> Do you know if the SCDynamicStore version is building on SnowLeopard, >>>>>>>>>> but just not enabled? Does it rely on new constants that are only on >>>>>>>>>> Lion? >>>>>>>>>> >>>>>>>>>> ~Mike >>>>>>>>>> >>>>>>>>>>> On Dec 19, 2011, at 10:50 AM, Mike Swingler wrote: >>>>>>>>>>> >>>>>>>>>>>> Bino, I thought we contributed all of the Kerberos implementation >>>>>>>>>>>> (including the new SCDynamicStore implementation for Lion). Do you >>>>>>>>>>>> think the system kinit and the SCDynamicStore versions aren't >>>>>>>>>>>> playing ball with each other? Weijun, what version of Mac OS X are >>>>>>>>>>>> you testing on? 10.6 or 10.7? >>>>>>>>>>>> >>>>>>>>>>>> ~Mike >>>>>>>>>>>> >>>>>>>>>>>> On Dec 18, 2011, at 10:49 PM, Jeannette Hung wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hey Mike, >>>>>>>>>>>>> What's the scope with the Kerberos code in the macos port? It looks >>>>>>>>>>>>> like something is missing. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> jeannette >>>>>>>>>>>>> >>>>>>>>>>>>> Begin forwarded message: >>>>>>>>>>>>> >>>>>>>>>>>>>> *From: *Weijun Wang>>>>>>>>>>>>> >>>>>>>>>>>>>> > >>>>>>>>>>>>>> *Subject: **Some Mac JDK codes not open sourced (was Fwd: Re: >>>>>>>>>>>>>> Kerberos codes in Apple's Java)* >>>>>>>>>>>>>> *Date: *December 15, 2011 6:52:18 PM PST >>>>>>>>>>>>>> *To: *Frances Ho>>>>>>>>>>>>> >>>>>>>>>>>>>> > >>>>>>>>>>>>>> *Cc: *Jeannette Hung>>>>>>>>>>>>> >>>>>>>>>>>>>> > >>>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Frances >>>>>>>>>>>>>> >>>>>>>>>>>>>> I suspect some Kerberos native codes on Apple's JDK 6 are not >>>>>>>>>>>>>> included in their macosx-port OpenJDK 7 contribution. I've >>>>>>>>>>>>>> contacted with some Apple guys but get no answer until now. (see >>>>>>>>>>>>>> forwarded mail thread) >>>>>>>>>>>>>> >>>>>>>>>>>>>> Do we have a project/product manager that can talk to someone >>>>>>>>>>>>>> inside Apple on this? >>>>>>>>>>>>>> >>>>>>>>>>>>>> In my opinion, these are not sensitive codes that they cannot open >>>>>>>>>>>>>> source. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> Max >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -------- Original Message -------- >>>>>>>>>>>>>> Subject: Re: Kerberos codes in Apple's Java >>>>>>>>>>>>>> Date: Thu, 01 Dec 2011 22:54:57 +0800 >>>>>>>>>>>>>> From: Weijun Wang>>>>>>>>>>>>> >>>>>>>>>>>>>> > >>>>>>>>>>>>>> To: Bino George >>>>>>>>>>>>>> > >>>>>>>>>>>>>> CC: security-dev at openjdk.java.net >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> >, >>>>>>>>>>>>>> macosx-port-dev at openjdk.java.net >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Bino >>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 2. Reading native memory-based credentials cache into >>>>>>>>>>>>>>>> Credentials objects >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I don't think we do this in JDK6 either. >>>>>>>>>>>>>> >>>>>>>>>>>>>> I just tried OS X's builtin kinit and klist command: >>>>>>>>>>>>>> >>>>>>>>>>>>>> $ kinit dummy >>>>>>>>>>>>>> Please enter the password for dummy at THREE.LOCAL >>>>>>>>>>>>>> >>>>>>>>>>>>>> : >>>>>>>>>>>>>> $ klist >>>>>>>>>>>>>> Kerberos 5 ticket cache: 'API:Initial default ccache' >>>>>>>>>>>>>> ... >>>>>>>>>>>>>> >>>>>>>>>>>>>> So here the ccache name is "API:Initial default ccache", which looks >>>>>>>>>>>>>> like an in-memory ccache. At least I cannot find normal file-based >>>>>>>>>>>>>> ccache file named /tmp/krb5cc_**. >>>>>>>>>>>>>> >>>>>>>>>>>>>> There is also a difference between Apple's JDK 6u29 and the current >>>>>>>>>>>>>> macosx-port OpenJDK build when calling the following method: >>>>>>>>>>>>>> >>>>>>>>>>>>>> sun.security.krb5,Credentials.acquireTGTFromCache() >>>>>>>>>>>>>> >>>>>>>>>>>>>> It returns a valid credential (which is identical to the klist >>>>>>>>>>>>>> output) >>>>>>>>>>>>>> in Apple's 6u29, but the macosx-port one returns null. So it >>>>>>>>>>>>>> seems the >>>>>>>>>>>>>> Apple JDK can see the special ccache object but macosx-port cannot. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> Max >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Regards >>>>>>>>>>>>>>> Bino. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Oct 14, 2011, at 10:38 AM, Weijun Wang wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi Mike >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I'm working in the Java SE Security Team in Oracle. Apple's >>>>>>>>>>>>>>>> JRE (at >>>>>>>>>>>>>>>> least in the JDK 6 releases) supports some extra Kerberos >>>>>>>>>>>>>>>> features for >>>>>>>>>>>>>>>> OS X. As I know, at least there are: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 1. Looking for krb5.conf at /Library/Preferences/edu.mit.Kerberos >>>>>>>>>>>>>>>> 2. Reading native memory-based credentials cache into >>>>>>>>>>>>>>>> Credentials objects >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I didn't see them on the Project Status page [1]. Is it >>>>>>>>>>>>>>>> because they >>>>>>>>>>>>>>>> are too trivial to be listed or you're not going to support them? >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>> Max >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> [1] >>>>>>>>>>>>>>>> http://wikis.sun.com/display/OpenJDK/Mac+OS+X+Port+Project+Status >>>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>> >>>>> >>> > From scott.kovatch at oracle.com Mon Dec 19 22:50:02 2011 From: scott.kovatch at oracle.com (Scott Kovatch) Date: Mon, 19 Dec 2011 22:50:02 -0800 Subject: code review request (Re: Some Mac JDK codes not open sourced (was Fwd: Re: Kerberos codes in Apple's Java)) In-Reply-To: <4EF029EE.9070806@oracle.com> References: <4EEAB262.7090606@oracle.com> <6586F238-E84C-4EB7-8ABC-593E818C6809@apple.com> <4EEFDB8E.3070202@oracle.com> <4EEFE2B5.5020900@oracle.com> <4EEFEB5D.4040706@oracle.com> <5FA024C7-8F7E-4A5A-AE0D-DA8104580AC9@apple.com> <4EF029EE.9070806@oracle.com> Message-ID: Be sure to mark me as author/contributor/whatever so I can get my 8 checkmarks for commit rights. :-) -- Scott On Dec 19, 2011, at 10:23 PM, Weijun Wang wrote: > Hi All > > I've created a webrev. Please anyone take a review: > > http://cr.openjdk.java.net/~weijun/9999999/webrev.12/ > > *Jeannette*: > > Is a formal donate-to-openjdk process needed? The file in my webrev still has the Apple copyright line. IANAL and I do not want to make any change to it myself. > > Thanks > Max > > > On 12/20/2011 09:58 AM, Mike Swingler wrote: >> This is just a .c file. No Objective-C here. >> >> ~Mike >> >> On Dec 19, 2011, at 5:56 PM, Weijun Wang wrote: >> >>> Hi Bino >>> >>> Thank you for locating it. I would be glad if you or Scott can do an integration. I guess this .m file is almost a pure .c file but I'm really unfamiliar with compiler settings on Mac. >>> >>> -Max >>> >>> >>> On 12/20/2011 09:51 AM, Bino George wrote: >>>> Hi Weijun, >>>> >>>> It looks like we did not port over some of the native code that Scott Kovatch wrote for the Mac. Attached is the native file for JDK6 that implements the missing JNI method. Can you or Scott try to integrate it to JDK 7 ? If you have difficulty, let me know and I will take care of it some time this week. >>>> >>>> >>>> >>>> >>>> >>>> >>>> Thanks, >>>> Bino. >>>> >>>> >>>> On Dec 19, 2011, at 5:19 PM, Weijun Wang wrote: >>>> >>>>> >>>>> >>>>> On 12/20/2011 09:10 AM, Bino George wrote: >>>>>> Hi Weijun, >>>>>> >>>>>>> I'm testing on 10.6. >>>>>> >>>>>> Does JDK6 (Apple JVM) work for your test on 10.6 ??? >>>>>> >>>>>> The SCDynamicStoreConfig implementation only works on Lion (10.7). >>>>>> >>>>>> >>>>>>> In fact, in src/share/classes/sun/security/krb5/Credentials.java, the >>>>>>> native method declaration still exists: >>>>>>> >>>>>>> private static native Credentials acquireDefaultNativeCreds(); >>>>>>> >>>>>> >>>>>> We don't do anything native on 10.6 and before we find the config file >>>>>> using this logic and simply parse it in Config.java : >>>>> >>>>> I'm not talking about the config part at all. That part has no problem. >>>>> >>>>> What I said is credential cache, i.e. the little piece of private info stored on local computer (either a file or a block in memory) after kinit is called. The info is generated by kinit and can be viewed either by the native klist tool or thru the Java call >>>>> >>>>> sun.security.krb5,Credentials.acquireTGTFromCache() >>>>> >>>>> What I observed is that in Apple JDK 6 both these 2 methods return the same info but in macosx-port the Java method does not return anything. >>>>> >>>>> That's what I mentioned in the "Thu, 01 Dec 2011 22:54:57 +0800" mail. (scroll down to 2/3 place). >>>>> >>>>> Thanks >>>>> Max >>>>> >>>>>> >>>>>> private String findMacosConfigFile() { >>>>>> String userHome = getProperty("user.home"); >>>>>> finalString PREF_FILE = "/Library/Preferences/edu.mit.Kerberos"; >>>>>> String userPrefs=userHome + PREF_FILE; >>>>>> >>>>>> >>>>>> if (fileExists(userPrefs)) { >>>>>> return userPrefs; >>>>>> } >>>>>> >>>>>> >>>>>> if (fileExists(PREF_FILE)) { >>>>>> return PREF_FILE; >>>>>> } >>>>>> >>>>>> >>>>>> if (fileExists("/etc/krb5.conf")) { >>>>>> return"/etc/krb5.conf"; >>>>>> } >>>>>> >>>>>> >>>>>> return ""; >>>>>> } >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Regards, >>>>>> >>>>>> Bino. >>>>>> >>>>>> >>>>>> >>>>>> On Dec 19, 2011, at 4:49 PM, Weijun Wang wrote: >>>>>> >>>>>>> I take a brief look at >>>>>>> >>>>>>> src/macosx/native/java/util/SCDynamicStoreConfig.m >>>>>>> src/share/classes/sun/security/krb5/SCDynamicStoreConfig.java >>>>>>> >>>>>>> and it is an alternative way of specifying krb5.conf, but there is no >>>>>>> line on the credentials cache. >>>>>>> >>>>>>> In fact, in src/share/classes/sun/security/krb5/Credentials.java, the >>>>>>> native method declaration still exists: >>>>>>> >>>>>>> private static native Credentials acquireDefaultNativeCreds(); >>>>>>> >>>>>>> but I cannot find the implementation codes for it. >>>>>>> >>>>>>> I'm testing on 10.6. >>>>>>> >>>>>>> Thanks >>>>>>> Max >>>>>>> >>>>>>> On 12/20/2011 05:30 AM, Bino George wrote: >>>>>>>> Hi Mike, >>>>>>>> >>>>>>>>> Actually, Bino - on Lion we compile in the SCDynamicStore version, and >>>>>>>>> on SnowLeopard we compile it out an just use the file version in Java. >>>>>>>>> Do you know if the SCDynamicStore version is building on SnowLeopard, >>>>>>>>> but just not enabled? Does it rely on new constants that are only on >>>>>>>>> Lion? >>>>>>>> >>>>>>>> >>>>>>>> The difference between JDK6 and JDK7 is that in JDK6 we do not compile >>>>>>>> the SCDynamicStore code. But since SCDynamicStore does not use any new >>>>>>>> API, we compile it both on Lion and SnowLeopard on JDK7 and we only load >>>>>>>> the SCDynamicStore code on Lion (we check at runtime for os version). We >>>>>>>> don't rely on any OS provided constants, I don't think there are any, we >>>>>>>> just look for the following keys on Lion in SCDynamicStore : >>>>>>>> >>>>>>>> #define KERBEROS_DEFAULT_REALMS @"Kerberos-Default-Realms" >>>>>>>> #define KERBEROS_DEFAULT_REALM_MAPPINGS @"Kerberos-Domain-Realm-Mappings" >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Bino. >>>>>>>> >>>>>>>> On Dec 19, 2011, at 11:10 AM, Mike Swingler wrote: >>>>>>>> >>>>>>>>> On Dec 19, 2011, at 11:05 AM, Bino George wrote: >>>>>>>>> >>>>>>>>>> Hi Mike, >>>>>>>>>> >>>>>>>>>>> Bino, I thought we contributed all of the Kerberos implementation >>>>>>>>>>> (including the new SCDynamicStore implementation for Lion). Do you >>>>>>>>>>> think the system kinit and the SCDynamicStore versions aren't >>>>>>>>>>> playing ball with each other? >>>>>>>>>> >>>>>>>>>> Yes, we did contribute that code already and we tested it in JDK7 on >>>>>>>>>> Lion. Not sure if this is a SnowLeopard issue. >>>>>>>>>> >>>>>>>>>> Weijun, does your tests work with JDK6 from Apple on the same >>>>>>>>>> machine, the code should be identical. >>>>>>>>> >>>>>>>>> Actually, Bino - on Lion we compile in the SCDynamicStore version, and >>>>>>>>> on SnowLeopard we compile it out an just use the file version in Java. >>>>>>>>> Do you know if the SCDynamicStore version is building on SnowLeopard, >>>>>>>>> but just not enabled? Does it rely on new constants that are only on >>>>>>>>> Lion? >>>>>>>>> >>>>>>>>> ~Mike >>>>>>>>> >>>>>>>>>> On Dec 19, 2011, at 10:50 AM, Mike Swingler wrote: >>>>>>>>>> >>>>>>>>>>> Bino, I thought we contributed all of the Kerberos implementation >>>>>>>>>>> (including the new SCDynamicStore implementation for Lion). Do you >>>>>>>>>>> think the system kinit and the SCDynamicStore versions aren't >>>>>>>>>>> playing ball with each other? Weijun, what version of Mac OS X are >>>>>>>>>>> you testing on? 10.6 or 10.7? >>>>>>>>>>> >>>>>>>>>>> ~Mike >>>>>>>>>>> >>>>>>>>>>> On Dec 18, 2011, at 10:49 PM, Jeannette Hung wrote: >>>>>>>>>>> >>>>>>>>>>>> Hey Mike, >>>>>>>>>>>> What's the scope with the Kerberos code in the macos port? It looks >>>>>>>>>>>> like something is missing. >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> jeannette >>>>>>>>>>>> >>>>>>>>>>>> Begin forwarded message: >>>>>>>>>>>> >>>>>>>>>>>>> *From: *Weijun Wang>>>>>>>>>>>> >>>>>>>>>>>>> > >>>>>>>>>>>>> *Subject: **Some Mac JDK codes not open sourced (was Fwd: Re: >>>>>>>>>>>>> Kerberos codes in Apple's Java)* >>>>>>>>>>>>> *Date: *December 15, 2011 6:52:18 PM PST >>>>>>>>>>>>> *To: *Frances Ho>>>>>>>>>>>> >>>>>>>>>>>>> > >>>>>>>>>>>>> *Cc: *Jeannette Hung>>>>>>>>>>>> >>>>>>>>>>>>> > >>>>>>>>>>>>> >>>>>>>>>>>>> Hi Frances >>>>>>>>>>>>> >>>>>>>>>>>>> I suspect some Kerberos native codes on Apple's JDK 6 are not >>>>>>>>>>>>> included in their macosx-port OpenJDK 7 contribution. I've >>>>>>>>>>>>> contacted with some Apple guys but get no answer until now. (see >>>>>>>>>>>>> forwarded mail thread) >>>>>>>>>>>>> >>>>>>>>>>>>> Do we have a project/product manager that can talk to someone >>>>>>>>>>>>> inside Apple on this? >>>>>>>>>>>>> >>>>>>>>>>>>> In my opinion, these are not sensitive codes that they cannot open >>>>>>>>>>>>> source. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> Max >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -------- Original Message -------- >>>>>>>>>>>>> Subject: Re: Kerberos codes in Apple's Java >>>>>>>>>>>>> Date: Thu, 01 Dec 2011 22:54:57 +0800 >>>>>>>>>>>>> From: Weijun Wang>>>>>>>>>>>> >>>>>>>>>>>>> > >>>>>>>>>>>>> To: Bino George >>>>>>>>>>>>> > >>>>>>>>>>>>> CC: security-dev at openjdk.java.net >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> >, >>>>>>>>>>>>> macosx-port-dev at openjdk.java.net >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Hi Bino >>>>>>>>>>>>> >>>>>>>>>>>>>>> 2. Reading native memory-based credentials cache into >>>>>>>>>>>>>>> Credentials objects >>>>>>>>>>>>>> >>>>>>>>>>>>>> I don't think we do this in JDK6 either. >>>>>>>>>>>>> >>>>>>>>>>>>> I just tried OS X's builtin kinit and klist command: >>>>>>>>>>>>> >>>>>>>>>>>>> $ kinit dummy >>>>>>>>>>>>> Please enter the password for dummy at THREE.LOCAL >>>>>>>>>>>>> >>>>>>>>>>>>> : >>>>>>>>>>>>> $ klist >>>>>>>>>>>>> Kerberos 5 ticket cache: 'API:Initial default ccache' >>>>>>>>>>>>> ... >>>>>>>>>>>>> >>>>>>>>>>>>> So here the ccache name is "API:Initial default ccache", which looks >>>>>>>>>>>>> like an in-memory ccache. At least I cannot find normal file-based >>>>>>>>>>>>> ccache file named /tmp/krb5cc_**. >>>>>>>>>>>>> >>>>>>>>>>>>> There is also a difference between Apple's JDK 6u29 and the current >>>>>>>>>>>>> macosx-port OpenJDK build when calling the following method: >>>>>>>>>>>>> >>>>>>>>>>>>> sun.security.krb5,Credentials.acquireTGTFromCache() >>>>>>>>>>>>> >>>>>>>>>>>>> It returns a valid credential (which is identical to the klist >>>>>>>>>>>>> output) >>>>>>>>>>>>> in Apple's 6u29, but the macosx-port one returns null. So it >>>>>>>>>>>>> seems the >>>>>>>>>>>>> Apple JDK can see the special ccache object but macosx-port cannot. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> Max >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Regards >>>>>>>>>>>>>> Bino. >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Oct 14, 2011, at 10:38 AM, Weijun Wang wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi Mike >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I'm working in the Java SE Security Team in Oracle. Apple's >>>>>>>>>>>>>>> JRE (at >>>>>>>>>>>>>>> least in the JDK 6 releases) supports some extra Kerberos >>>>>>>>>>>>>>> features for >>>>>>>>>>>>>>> OS X. As I know, at least there are: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> 1. Looking for krb5.conf at /Library/Preferences/edu.mit.Kerberos >>>>>>>>>>>>>>> 2. Reading native memory-based credentials cache into >>>>>>>>>>>>>>> Credentials objects >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I didn't see them on the Project Status page [1]. Is it >>>>>>>>>>>>>>> because they >>>>>>>>>>>>>>> are too trivial to be listed or you're not going to support them? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>> Max >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> [1] >>>>>>>>>>>>>>> http://wikis.sun.com/display/OpenJDK/Mac+OS+X+Port+Project+Status >>>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>> >>>> >> From weijun.wang at oracle.com Tue Dec 20 00:54:02 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 20 Dec 2011 16:54:02 +0800 Subject: code review request (Re: Some Mac JDK codes not open sourced (was Fwd: Re: Kerberos codes in Apple's Java)) In-Reply-To: References: <4EEAB262.7090606@oracle.com> <6586F238-E84C-4EB7-8ABC-593E818C6809@apple.com> <4EEFDB8E.3070202@oracle.com> <4EEFE2B5.5020900@oracle.com> <4EEFEB5D.4040706@oracle.com> <5FA024C7-8F7E-4A5A-AE0D-DA8104580AC9@apple.com> <4EF029EE.9070806@oracle.com> Message-ID: <4EF04D2A.9070308@oracle.com> None of you review my code changes. :( Here is the final version: http://cr.openjdk.java.net/~weijun/7123107/webrev.00/ I guess with the current bylaw. The jdk7u-osx belongs to the "jdk7u - JDK 7 Updates Project" and skovatch is not listed there. So I guess I will be the committer and you will be the author, and then I can add my name as reviewer if you review it for me. Hopefully I can get that correct. I've never commit something with another people's name as author. Thanks Max On 12/20/2011 02:50 PM, Scott Kovatch wrote: > Be sure to mark me as author/contributor/whatever so I can get my 8 checkmarks for commit rights. :-) > > > -- Scott > > On Dec 19, 2011, at 10:23 PM, Weijun Wang wrote: > >> Hi All >> >> I've created a webrev. Please anyone take a review: >> >> http://cr.openjdk.java.net/~weijun/9999999/webrev.12/ >> >> *Jeannette*: >> >> Is a formal donate-to-openjdk process needed? The file in my webrev still has the Apple copyright line. IANAL and I do not want to make any change to it myself. >> >> Thanks >> Max >> >> >> On 12/20/2011 09:58 AM, Mike Swingler wrote: >>> This is just a .c file. No Objective-C here. >>> >>> ~Mike >>> >>> On Dec 19, 2011, at 5:56 PM, Weijun Wang wrote: >>> >>>> Hi Bino >>>> >>>> Thank you for locating it. I would be glad if you or Scott can do an integration. I guess this .m file is almost a pure .c file but I'm really unfamiliar with compiler settings on Mac. >>>> >>>> -Max >>>> >>>> >>>> On 12/20/2011 09:51 AM, Bino George wrote: >>>>> Hi Weijun, >>>>> >>>>> It looks like we did not port over some of the native code that Scott Kovatch wrote for the Mac. Attached is the native file for JDK6 that implements the missing JNI method. Can you or Scott try to integrate it to JDK 7 ? If you have difficulty, let me know and I will take care of it some time this week. >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> Thanks, >>>>> Bino. >>>>> >>>>> >>>>> On Dec 19, 2011, at 5:19 PM, Weijun Wang wrote: >>>>> >>>>>> >>>>>> >>>>>> On 12/20/2011 09:10 AM, Bino George wrote: >>>>>>> Hi Weijun, >>>>>>> >>>>>>>> I'm testing on 10.6. >>>>>>> >>>>>>> Does JDK6 (Apple JVM) work for your test on 10.6 ??? >>>>>>> >>>>>>> The SCDynamicStoreConfig implementation only works on Lion (10.7). >>>>>>> >>>>>>> >>>>>>>> In fact, in src/share/classes/sun/security/krb5/Credentials.java, the >>>>>>>> native method declaration still exists: >>>>>>>> >>>>>>>> private static native Credentials acquireDefaultNativeCreds(); >>>>>>>> >>>>>>> >>>>>>> We don't do anything native on 10.6 and before we find the config file >>>>>>> using this logic and simply parse it in Config.java : >>>>>> >>>>>> I'm not talking about the config part at all. That part has no problem. >>>>>> >>>>>> What I said is credential cache, i.e. the little piece of private info stored on local computer (either a file or a block in memory) after kinit is called. The info is generated by kinit and can be viewed either by the native klist tool or thru the Java call >>>>>> >>>>>> sun.security.krb5,Credentials.acquireTGTFromCache() >>>>>> >>>>>> What I observed is that in Apple JDK 6 both these 2 methods return the same info but in macosx-port the Java method does not return anything. >>>>>> >>>>>> That's what I mentioned in the "Thu, 01 Dec 2011 22:54:57 +0800" mail. (scroll down to 2/3 place). >>>>>> >>>>>> Thanks >>>>>> Max >>>>>> >>>>>>> >>>>>>> private String findMacosConfigFile() { >>>>>>> String userHome = getProperty("user.home"); >>>>>>> finalString PREF_FILE = "/Library/Preferences/edu.mit.Kerberos"; >>>>>>> String userPrefs=userHome + PREF_FILE; >>>>>>> >>>>>>> >>>>>>> if (fileExists(userPrefs)) { >>>>>>> return userPrefs; >>>>>>> } >>>>>>> >>>>>>> >>>>>>> if (fileExists(PREF_FILE)) { >>>>>>> return PREF_FILE; >>>>>>> } >>>>>>> >>>>>>> >>>>>>> if (fileExists("/etc/krb5.conf")) { >>>>>>> return"/etc/krb5.conf"; >>>>>>> } >>>>>>> >>>>>>> >>>>>>> return ""; >>>>>>> } >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Regards, >>>>>>> >>>>>>> Bino. >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Dec 19, 2011, at 4:49 PM, Weijun Wang wrote: >>>>>>> >>>>>>>> I take a brief look at >>>>>>>> >>>>>>>> src/macosx/native/java/util/SCDynamicStoreConfig.m >>>>>>>> src/share/classes/sun/security/krb5/SCDynamicStoreConfig.java >>>>>>>> >>>>>>>> and it is an alternative way of specifying krb5.conf, but there is no >>>>>>>> line on the credentials cache. >>>>>>>> >>>>>>>> In fact, in src/share/classes/sun/security/krb5/Credentials.java, the >>>>>>>> native method declaration still exists: >>>>>>>> >>>>>>>> private static native Credentials acquireDefaultNativeCreds(); >>>>>>>> >>>>>>>> but I cannot find the implementation codes for it. >>>>>>>> >>>>>>>> I'm testing on 10.6. >>>>>>>> >>>>>>>> Thanks >>>>>>>> Max >>>>>>>> >>>>>>>> On 12/20/2011 05:30 AM, Bino George wrote: >>>>>>>>> Hi Mike, >>>>>>>>> >>>>>>>>>> Actually, Bino - on Lion we compile in the SCDynamicStore version, and >>>>>>>>>> on SnowLeopard we compile it out an just use the file version in Java. >>>>>>>>>> Do you know if the SCDynamicStore version is building on SnowLeopard, >>>>>>>>>> but just not enabled? Does it rely on new constants that are only on >>>>>>>>>> Lion? >>>>>>>>> >>>>>>>>> >>>>>>>>> The difference between JDK6 and JDK7 is that in JDK6 we do not compile >>>>>>>>> the SCDynamicStore code. But since SCDynamicStore does not use any new >>>>>>>>> API, we compile it both on Lion and SnowLeopard on JDK7 and we only load >>>>>>>>> the SCDynamicStore code on Lion (we check at runtime for os version). We >>>>>>>>> don't rely on any OS provided constants, I don't think there are any, we >>>>>>>>> just look for the following keys on Lion in SCDynamicStore : >>>>>>>>> >>>>>>>>> #define KERBEROS_DEFAULT_REALMS @"Kerberos-Default-Realms" >>>>>>>>> #define KERBEROS_DEFAULT_REALM_MAPPINGS @"Kerberos-Domain-Realm-Mappings" >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Bino. >>>>>>>>> >>>>>>>>> On Dec 19, 2011, at 11:10 AM, Mike Swingler wrote: >>>>>>>>> >>>>>>>>>> On Dec 19, 2011, at 11:05 AM, Bino George wrote: >>>>>>>>>> >>>>>>>>>>> Hi Mike, >>>>>>>>>>> >>>>>>>>>>>> Bino, I thought we contributed all of the Kerberos implementation >>>>>>>>>>>> (including the new SCDynamicStore implementation for Lion). Do you >>>>>>>>>>>> think the system kinit and the SCDynamicStore versions aren't >>>>>>>>>>>> playing ball with each other? >>>>>>>>>>> >>>>>>>>>>> Yes, we did contribute that code already and we tested it in JDK7 on >>>>>>>>>>> Lion. Not sure if this is a SnowLeopard issue. >>>>>>>>>>> >>>>>>>>>>> Weijun, does your tests work with JDK6 from Apple on the same >>>>>>>>>>> machine, the code should be identical. >>>>>>>>>> >>>>>>>>>> Actually, Bino - on Lion we compile in the SCDynamicStore version, and >>>>>>>>>> on SnowLeopard we compile it out an just use the file version in Java. >>>>>>>>>> Do you know if the SCDynamicStore version is building on SnowLeopard, >>>>>>>>>> but just not enabled? Does it rely on new constants that are only on >>>>>>>>>> Lion? >>>>>>>>>> >>>>>>>>>> ~Mike >>>>>>>>>> >>>>>>>>>>> On Dec 19, 2011, at 10:50 AM, Mike Swingler wrote: >>>>>>>>>>> >>>>>>>>>>>> Bino, I thought we contributed all of the Kerberos implementation >>>>>>>>>>>> (including the new SCDynamicStore implementation for Lion). Do you >>>>>>>>>>>> think the system kinit and the SCDynamicStore versions aren't >>>>>>>>>>>> playing ball with each other? Weijun, what version of Mac OS X are >>>>>>>>>>>> you testing on? 10.6 or 10.7? >>>>>>>>>>>> >>>>>>>>>>>> ~Mike >>>>>>>>>>>> >>>>>>>>>>>> On Dec 18, 2011, at 10:49 PM, Jeannette Hung wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hey Mike, >>>>>>>>>>>>> What's the scope with the Kerberos code in the macos port? It looks >>>>>>>>>>>>> like something is missing. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> jeannette >>>>>>>>>>>>> >>>>>>>>>>>>> Begin forwarded message: >>>>>>>>>>>>> >>>>>>>>>>>>>> *From: *Weijun Wang>>>>>>>>>>>>> >>>>>>>>>>>>>> > >>>>>>>>>>>>>> *Subject: **Some Mac JDK codes not open sourced (was Fwd: Re: >>>>>>>>>>>>>> Kerberos codes in Apple's Java)* >>>>>>>>>>>>>> *Date: *December 15, 2011 6:52:18 PM PST >>>>>>>>>>>>>> *To: *Frances Ho>>>>>>>>>>>>> >>>>>>>>>>>>>> > >>>>>>>>>>>>>> *Cc: *Jeannette Hung>>>>>>>>>>>>> >>>>>>>>>>>>>> > >>>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Frances >>>>>>>>>>>>>> >>>>>>>>>>>>>> I suspect some Kerberos native codes on Apple's JDK 6 are not >>>>>>>>>>>>>> included in their macosx-port OpenJDK 7 contribution. I've >>>>>>>>>>>>>> contacted with some Apple guys but get no answer until now. (see >>>>>>>>>>>>>> forwarded mail thread) >>>>>>>>>>>>>> >>>>>>>>>>>>>> Do we have a project/product manager that can talk to someone >>>>>>>>>>>>>> inside Apple on this? >>>>>>>>>>>>>> >>>>>>>>>>>>>> In my opinion, these are not sensitive codes that they cannot open >>>>>>>>>>>>>> source. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> Max >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -------- Original Message -------- >>>>>>>>>>>>>> Subject: Re: Kerberos codes in Apple's Java >>>>>>>>>>>>>> Date: Thu, 01 Dec 2011 22:54:57 +0800 >>>>>>>>>>>>>> From: Weijun Wang>>>>>>>>>>>>> >>>>>>>>>>>>>> > >>>>>>>>>>>>>> To: Bino George >>>>>>>>>>>>>> > >>>>>>>>>>>>>> CC: security-dev at openjdk.java.net >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> >, >>>>>>>>>>>>>> macosx-port-dev at openjdk.java.net >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Bino >>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 2. Reading native memory-based credentials cache into >>>>>>>>>>>>>>>> Credentials objects >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I don't think we do this in JDK6 either. >>>>>>>>>>>>>> >>>>>>>>>>>>>> I just tried OS X's builtin kinit and klist command: >>>>>>>>>>>>>> >>>>>>>>>>>>>> $ kinit dummy >>>>>>>>>>>>>> Please enter the password for dummy at THREE.LOCAL >>>>>>>>>>>>>> >>>>>>>>>>>>>> : >>>>>>>>>>>>>> $ klist >>>>>>>>>>>>>> Kerberos 5 ticket cache: 'API:Initial default ccache' >>>>>>>>>>>>>> ... >>>>>>>>>>>>>> >>>>>>>>>>>>>> So here the ccache name is "API:Initial default ccache", which looks >>>>>>>>>>>>>> like an in-memory ccache. At least I cannot find normal file-based >>>>>>>>>>>>>> ccache file named /tmp/krb5cc_**. >>>>>>>>>>>>>> >>>>>>>>>>>>>> There is also a difference between Apple's JDK 6u29 and the current >>>>>>>>>>>>>> macosx-port OpenJDK build when calling the following method: >>>>>>>>>>>>>> >>>>>>>>>>>>>> sun.security.krb5,Credentials.acquireTGTFromCache() >>>>>>>>>>>>>> >>>>>>>>>>>>>> It returns a valid credential (which is identical to the klist >>>>>>>>>>>>>> output) >>>>>>>>>>>>>> in Apple's 6u29, but the macosx-port one returns null. So it >>>>>>>>>>>>>> seems the >>>>>>>>>>>>>> Apple JDK can see the special ccache object but macosx-port cannot. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> Max >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Regards >>>>>>>>>>>>>>> Bino. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Oct 14, 2011, at 10:38 AM, Weijun Wang wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi Mike >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I'm working in the Java SE Security Team in Oracle. Apple's >>>>>>>>>>>>>>>> JRE (at >>>>>>>>>>>>>>>> least in the JDK 6 releases) supports some extra Kerberos >>>>>>>>>>>>>>>> features for >>>>>>>>>>>>>>>> OS X. As I know, at least there are: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 1. Looking for krb5.conf at /Library/Preferences/edu.mit.Kerberos >>>>>>>>>>>>>>>> 2. Reading native memory-based credentials cache into >>>>>>>>>>>>>>>> Credentials objects >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I didn't see them on the Project Status page [1]. Is it >>>>>>>>>>>>>>>> because they >>>>>>>>>>>>>>>> are too trivial to be listed or you're not going to support them? >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>> Max >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> [1] >>>>>>>>>>>>>>>> http://wikis.sun.com/display/OpenJDK/Mac+OS+X+Port+Project+Status >>>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>> >>>>> >>> > From weijun.wang at oracle.com Tue Dec 20 02:22:16 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 20 Dec 2011 18:22:16 +0800 Subject: code review request: 7122169: TcpTimeout fail for various reasons Message-ID: <4EF061D8.1040904@oracle.com> Hi Alan Do you have time to look at this fix? http://cr.openjdk.java.net/~weijun/7122169/webrev.01/ I study the test again and find out it's not the same as those BadKdc* tests, where the port number must obey a pattern (n-th server on n****). So there is no need to assign one before the server socket is created. Also, it seems simply creating a server socket can simulate a timeout, no need to call accept() in a separate thread explicitly. I've tried the new test with JPRT and it runs fine. Thanks Max -------- Original Message -------- *Change Request ID*: 7122169 *Synopsis*: TcpTimeout fail for various reasons === *Description* ============================================================ sun/security/krb5/auto/TcpTimeout.java The test fails intermittently on various systems for different reasons: 1. On all systems, it might fail if a port (random calculated) is already opened by another process. 2. In some Windows virtual machines, the wall clock might go slower than elapsed time. i.e. you can Thread.sleep() for 10 seconds but the change in System.nanoTime() results shows a smaller value. From chris.hegarty at oracle.com Tue Dec 20 04:36:59 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 20 Dec 2011 12:36:59 +0000 Subject: code review request: 7122169: TcpTimeout fail for various reasons In-Reply-To: <4EF061D8.1040904@oracle.com> References: <4EF061D8.1040904@oracle.com> Message-ID: <4EF0816B.5050701@oracle.com> I'm not familiar with the Windows VM time issue, but the other changes look fine to me. -Chris. On 12/20/11 10:22 AM, Weijun Wang wrote: > Hi Alan > > Do you have time to look at this fix? > > http://cr.openjdk.java.net/~weijun/7122169/webrev.01/ > > I study the test again and find out it's not the same as those BadKdc* > tests, where the port number must obey a pattern (n-th server on n****). > So there is no need to assign one before the server socket is created. > Also, it seems simply creating a server socket can simulate a timeout, > no need to call accept() in a separate thread explicitly. > > I've tried the new test with JPRT and it runs fine. > > Thanks > Max > > -------- Original Message -------- > *Change Request ID*: 7122169 > *Synopsis*: TcpTimeout fail for various reasons > > > === *Description* > ============================================================ > sun/security/krb5/auto/TcpTimeout.java > > The test fails intermittently on various systems for different reasons: > > 1. On all systems, it might fail if a port (random calculated) is > already opened by another process. > > 2. In some Windows virtual machines, the wall clock might go slower than > elapsed time. i.e. you can Thread.sleep() for 10 seconds but the change > in System.nanoTime() results shows a smaller value. > From weijun.wang at oracle.com Tue Dec 20 05:57:28 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 20 Dec 2011 21:57:28 +0800 Subject: code review request: 7122169: TcpTimeout fail for various reasons In-Reply-To: <4EF0816B.5050701@oracle.com> References: <4EF061D8.1040904@oracle.com> <4EF0816B.5050701@oracle.com> Message-ID: <4EF09448.3030900@oracle.com> On 12/20/2011 08:36 PM, Chris Hegarty wrote: > I'm not familiar with the Windows VM time issue, but the other changes > look fine to me. In Windows VM, if you call Thread.sleep(10000) and measure the time elapsed, the difference of System.nanoTime() is precise always, but the difference of System.getCurrentMillies() can vary between 7 and 15 seconds. Thanks Max > > -Chris. > > On 12/20/11 10:22 AM, Weijun Wang wrote: >> Hi Alan >> >> Do you have time to look at this fix? >> >> http://cr.openjdk.java.net/~weijun/7122169/webrev.01/ >> >> I study the test again and find out it's not the same as those BadKdc* >> tests, where the port number must obey a pattern (n-th server on n****). >> So there is no need to assign one before the server socket is created. >> Also, it seems simply creating a server socket can simulate a timeout, >> no need to call accept() in a separate thread explicitly. >> >> I've tried the new test with JPRT and it runs fine. >> >> Thanks >> Max >> >> -------- Original Message -------- >> *Change Request ID*: 7122169 >> *Synopsis*: TcpTimeout fail for various reasons >> >> >> === *Description* >> ============================================================ >> sun/security/krb5/auto/TcpTimeout.java >> >> The test fails intermittently on various systems for different reasons: >> >> 1. On all systems, it might fail if a port (random calculated) is >> already opened by another process. >> >> 2. In some Windows virtual machines, the wall clock might go slower than >> elapsed time. i.e. you can Thread.sleep() for 10 seconds but the change >> in System.nanoTime() results shows a smaller value. >> From Alan.Bateman at oracle.com Tue Dec 20 06:05:33 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 20 Dec 2011 14:05:33 +0000 Subject: code review request: 7122169: TcpTimeout fail for various reasons In-Reply-To: <4EF061D8.1040904@oracle.com> References: <4EF061D8.1040904@oracle.com> Message-ID: <4EF0962D.9000407@oracle.com> On 20/12/2011 10:22, Weijun Wang wrote: > Hi Alan > > Do you have time to look at this fix? > > http://cr.openjdk.java.net/~weijun/7122169/webrev.01/ > > I study the test again and find out it's not the same as those BadKdc* > tests, where the port number must obey a pattern (n-th server on > n****). So there is no need to assign one before the server socket is > created. Also, it seems simply creating a server socket can simulate a > timeout, no need to call accept() in a separate thread explicitly. > > I've tried the new test with JPRT and it runs fine. > Would it be simpler to use System.currentTimeMillis instead and that would avoid needing the Windows check? Also while you are there, can the /timeout=40 be removed from the test description? -Alan. From valerie.peng at oracle.com Tue Dec 20 15:08:44 2011 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 20 Dec 2011 15:08:44 -0800 Subject: Code review request for 6839886, 7033170, 7084025 Message-ID: <4EF1157C.7030506@oracle.com> Sean, Can you please help reviewing the fixes for 6839886: Array overrun in pkcs11 http://cr.openjdk.java.net/~valeriep/6839886/webrev.00/ (fixed to use the correct value; no regression test due to @reg-hard) 7033170: Cipher.getMaxAllowedKeyLength(String) throws NoSuchAlgorithmException http://cr.openjdk.java.net/~valeriep/7033170/webrev.00/ (changed to always use the full transformation string) 7084025: closed/sun/security/rsa/TestLimits.java doesn't compile on Windows http://cr.openjdk.java.net/~valeriep/7084025/webrev.00/ (No SunPKCS11 classes on windows 64-bit, so changed to use reflection) These fixes are quite straight forward. Please let me know if you spot any issue. Thanks, Valerie From weijun.wang at oracle.com Tue Dec 20 17:52:30 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 21 Dec 2011 09:52:30 +0800 Subject: code review request: 7122169: TcpTimeout fail for various reasons In-Reply-To: <4EF0962D.9000407@oracle.com> References: <4EF061D8.1040904@oracle.com> <4EF0962D.9000407@oracle.com> Message-ID: <4EF13BDE.1080302@oracle.com> On 12/20/2011 10:05 PM, Alan Bateman wrote: > On 20/12/2011 10:22, Weijun Wang wrote: >> Hi Alan >> >> Do you have time to look at this fix? >> >> http://cr.openjdk.java.net/~weijun/7122169/webrev.01/ >> >> I study the test again and find out it's not the same as those BadKdc* >> tests, where the port number must obey a pattern (n-th server on >> n****). So there is no need to assign one before the server socket is >> created. Also, it seems simply creating a server socket can simulate a >> timeout, no need to call accept() in a separate thread explicitly. >> >> I've tried the new test with JPRT and it runs fine. >> > Would it be simpler to use System.currentTimeMillis instead and that > would avoid needing the Windows check? I'm not sure. The time consumed is from Socket::setSoTimeout(). Do you know if it's connected to clock time (currentTimeMillis) or elapsed time (nanoTime)? > > Also while you are there, can the /timeout=40 be removed from the test > description? Yes. Thanks Max > > -Alan. > > From masayoshi.okutsu at oracle.com Wed Dec 21 00:14:39 2011 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Wed, 21 Dec 2011 08:14:39 +0000 Subject: hg: jdk8/tl/jdk: 7122054: (tz) Windows-only: tzmappings needs update for KB2633952 Message-ID: <20111221081457.59EF647777@hg.openjdk.java.net> Changeset: 1c4fffa22930 Author: okutsu Date: 2011-12-21 17:09 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c4fffa22930 7122054: (tz) Windows-only: tzmappings needs update for KB2633952 Reviewed-by: peytoia ! src/windows/lib/tzmappings From michael.x.mcmahon at oracle.com Wed Dec 21 02:07:27 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Wed, 21 Dec 2011 10:07:27 +0000 Subject: hg: jdk8/tl/jdk: 7078386: NetworkInterface.getNetworkInterfaces() may return corrupted results on linux Message-ID: <20111221100737.D926447778@hg.openjdk.java.net> Changeset: b1814b3ea6d3 Author: michaelm Date: 2011-12-21 10:06 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1814b3ea6d3 7078386: NetworkInterface.getNetworkInterfaces() may return corrupted results on linux Reviewed-by: michaelm, alanb, chegar Contributed-by: brandon.passanisi at oracle.com ! src/solaris/native/java/net/NetworkInterface.c From Alan.Bateman at oracle.com Wed Dec 21 06:08:15 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 21 Dec 2011 14:08:15 +0000 Subject: code review request: 7122169: TcpTimeout fail for various reasons In-Reply-To: <4EF13BDE.1080302@oracle.com> References: <4EF061D8.1040904@oracle.com> <4EF0962D.9000407@oracle.com> <4EF13BDE.1080302@oracle.com> Message-ID: <4EF1E84F.3060409@oracle.com> On 21/12/2011 01:52, Weijun Wang wrote: > > : > > I'm not sure. The time consumed is from Socket::setSoTimeout(). Do you > know if it's connected to clock time (currentTimeMillis) or elapsed > time (nanoTime)? > I think this timeout is specified by elapsed but the implementations use JVM_CurrentTimeMillis or in the case of Windows, a timeout provided by the kernel. My guess is that if this test is changed to use System.currentTimeMillis that it may be more robust but you will need to try it. -Alan From weijun.wang at oracle.com Wed Dec 21 07:01:54 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 21 Dec 2011 23:01:54 +0800 Subject: code review request: 7122169: TcpTimeout fail for various reasons In-Reply-To: <4EF1E84F.3060409@oracle.com> References: <4EF061D8.1040904@oracle.com> <4EF0962D.9000407@oracle.com> <4EF13BDE.1080302@oracle.com> <4EF1E84F.3060409@oracle.com> Message-ID: <4EF1F4E2.8080400@oracle.com> Great. I'll do that. Let's see if the test ever fails again. Here is updated webrev: http://cr.openjdk.java.net/~weijun/7122169/webrev.02/ Thanks Max On 12/21/2011 10:08 PM, Alan Bateman wrote: > On 21/12/2011 01:52, Weijun Wang wrote: >> >> : >> >> I'm not sure. The time consumed is from Socket::setSoTimeout(). Do you >> know if it's connected to clock time (currentTimeMillis) or elapsed >> time (nanoTime)? >> > I think this timeout is specified by elapsed but the implementations use > JVM_CurrentTimeMillis or in the case of Windows, a timeout provided by > the kernel. My guess is that if this test is changed to use > System.currentTimeMillis that it may be more robust but you will need to > try it. > > -Alan > From Alan.Bateman at oracle.com Wed Dec 21 07:09:06 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 21 Dec 2011 15:09:06 +0000 Subject: code review request: 7122169: TcpTimeout fail for various reasons In-Reply-To: <4EF1F4E2.8080400@oracle.com> References: <4EF061D8.1040904@oracle.com> <4EF0962D.9000407@oracle.com> <4EF13BDE.1080302@oracle.com> <4EF1E84F.3060409@oracle.com> <4EF1F4E2.8080400@oracle.com> Message-ID: <4EF1F692.8010606@oracle.com> On 21/12/2011 15:01, Weijun Wang wrote: > Great. I'll do that. Let's see if the test ever fails again. > > Here is updated webrev: > > http://cr.openjdk.java.net/~weijun/7122169/webrev.02/ > Hope not, the updated webrev looks good to me. -Alan From sean.mullan at oracle.com Wed Dec 21 11:15:00 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 21 Dec 2011 14:15:00 -0500 Subject: Code review request for 6839886, 7033170, 7084025 In-Reply-To: <4EF1157C.7030506@oracle.com> References: <4EF1157C.7030506@oracle.com> Message-ID: <4EF23034.8030208@oracle.com> On 12/20/11 6:08 PM, Valerie (Yu-Ching) Peng wrote: > Sean, > > Can you please help reviewing the fixes for > > 6839886: Array overrun in pkcs11 > http://cr.openjdk.java.net/~valeriep/6839886/webrev.00/ > (fixed to use the correct value; no regression test due to @reg-hard) Looks fine. > 7033170: Cipher.getMaxAllowedKeyLength(String) throws > NoSuchAlgorithmException > http://cr.openjdk.java.net/~valeriep/7033170/webrev.00/ > (changed to always use the full transformation string) Looks fine. > 7084025: closed/sun/security/rsa/TestLimits.java doesn't compile on Windows > http://cr.openjdk.java.net/~valeriep/7084025/webrev.00/ > (No SunPKCS11 classes on windows 64-bit, so changed to use reflection) Shouldn't you remove the entry from closed/ProblemList now that the test is fixed? --Sean From valerie.peng at oracle.com Wed Dec 21 13:00:38 2011 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Wed, 21 Dec 2011 13:00:38 -0800 Subject: Code review request for 6839886, 7033170, 7084025 In-Reply-To: <4EF23034.8030208@oracle.com> References: <4EF1157C.7030506@oracle.com> <4EF23034.8030208@oracle.com> Message-ID: <4EF248F6.3080000@oracle.com> Sean, Thanks for the review! I didn't update the ProblemList due to another bug 6975859. Will have to fix that before we remove the entry the ProblemList. Valerie On 12/21/11 11:15, Sean Mullan wrote: > On 12/20/11 6:08 PM, Valerie (Yu-Ching) Peng wrote: > >> Sean, >> >> Can you please help reviewing the fixes for >> >> 6839886: Array overrun in pkcs11 >> http://cr.openjdk.java.net/~valeriep/6839886/webrev.00/ >> (fixed to use the correct value; no regression test due to @reg-hard) >> > > Looks fine. > > >> 7033170: Cipher.getMaxAllowedKeyLength(String) throws >> NoSuchAlgorithmException >> http://cr.openjdk.java.net/~valeriep/7033170/webrev.00/ >> (changed to always use the full transformation string) >> > > Looks fine. > > >> 7084025: closed/sun/security/rsa/TestLimits.java doesn't compile on Windows >> http://cr.openjdk.java.net/~valeriep/7084025/webrev.00/ >> (No SunPKCS11 classes on windows 64-bit, so changed to use reflection) >> > > Shouldn't you remove the entry from closed/ProblemList now that the test is fixed? > > --Sean > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20111221/9ac97806/attachment.html From valerie.peng at oracle.com Wed Dec 21 14:22:12 2011 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Wed, 21 Dec 2011 22:22:12 +0000 Subject: hg: jdk8/tl/jdk: 6839886: Array overrun in pkcs11 Message-ID: <20111221222230.719CA47780@hg.openjdk.java.net> Changeset: a9dfdc523c2c Author: valeriep Date: 2011-12-21 14:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a9dfdc523c2c 6839886: Array overrun in pkcs11 Summary: Fix the wrong value when dealing w/ month and day. Reviewed-by: mullan ! src/share/native/sun/security/pkcs11/wrapper/p11_convert.c From weijun.wang at oracle.com Wed Dec 21 23:37:41 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 22 Dec 2011 07:37:41 +0000 Subject: hg: jdk8/tl/jdk: 7122169: TcpTimeout fail for various reasons Message-ID: <20111222073803.CAC204778C@hg.openjdk.java.net> Changeset: 11698dedbe79 Author: weijun Date: 2011-12-22 15:35 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11698dedbe79 7122169: TcpTimeout fail for various reasons Reviewed-by: alanb ! test/sun/security/krb5/auto/TcpTimeout.java From alan.bateman at oracle.com Thu Dec 22 02:54:12 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 22 Dec 2011 10:54:12 +0000 Subject: hg: jdk8/tl/jdk: 7076310: (file) AclEntry.Builder setFlags throws IllegalArgumentException if set argument is empty Message-ID: <20111222105450.9D90E4778F@hg.openjdk.java.net> Changeset: 559e07ed1f56 Author: alanb Date: 2011-12-22 10:52 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/559e07ed1f56 7076310: (file) AclEntry.Builder setFlags throws IllegalArgumentException if set argument is empty Reviewed-by: alanb Contributed-by: stephen.flores at oracle.com ! src/share/classes/java/nio/file/attribute/AclEntry.java + test/java/nio/file/attribute/AclEntry/EmptySet.java From mark.reinhold at oracle.com Thu Dec 22 12:03:45 2011 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 22 Dec 2011 12:03:45 -0800 Subject: JEP 129: NSA Suite B Cryptographic Algorithms Message-ID: <20111222200345.7F941F0B@eggemoggin.niobe.net> Posted: http://openjdk.java.net/jeps/129 - Mark From mark.reinhold at oracle.com Thu Dec 22 13:58:05 2011 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 22 Dec 2011 13:58:05 -0800 (PST) Subject: JEP 130: SHA-224 Message Digests Message-ID: <20111222215805.47094F1C@eggemoggin.niobe.net> Posted: http://openjdk.java.net/jeps/130 - Mark From mark.reinhold at oracle.com Thu Dec 22 14:41:40 2011 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 22 Dec 2011 14:41:40 -0800 (PST) Subject: JEP 131: PKCS#11 Crypto Provider for 64-bit Windows Message-ID: <20111222224140.B73CC1084@eggemoggin.niobe.net> Posted: http://openjdk.java.net/jeps/131 - Mark From daniel.daugherty at oracle.com Thu Dec 22 18:38:36 2011 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Fri, 23 Dec 2011 02:38:36 +0000 Subject: hg: jdk8/tl/jdk: 7121600: Instrumentation.redefineClasses() leaks class bytes Message-ID: <20111223023853.7AC374779F@hg.openjdk.java.net> Changeset: 3c1ab134db71 Author: dcubed Date: 2011-12-22 18:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c1ab134db71 7121600: Instrumentation.redefineClasses() leaks class bytes Summary: Call JNI ReleaseByteArrayElements() on memory returned by JNI GetByteArrayElements(). Also push test for 7122253. Reviewed-by: acorn, poonam ! src/share/instrument/JPLISAgent.c + test/java/lang/instrument/BigClass.java + test/java/lang/instrument/MakeJAR4.sh + test/java/lang/instrument/RedefineBigClass.sh + test/java/lang/instrument/RedefineBigClassAgent.java + test/java/lang/instrument/RedefineBigClassApp.java + test/java/lang/instrument/RetransformBigClass.sh + test/java/lang/instrument/RetransformBigClassAgent.java + test/java/lang/instrument/RetransformBigClassApp.java From tomas at primekey.se Fri Dec 23 00:15:57 2011 From: tomas at primekey.se (Tomas Gustavsson) Date: Fri, 23 Dec 2011 09:15:57 +0100 Subject: JEP 131: PKCS#11 Crypto Provider for 64-bit Windows In-Reply-To: <20111222224140.B73CC1084@eggemoggin.niobe.net> References: <20111222224140.B73CC1084@eggemoggin.niobe.net> Message-ID: <4EF438BD.6000107@primekey.se> Cool patches! Everything we've been looking for. There should be a few patches from us in the issue tracker for SHA224WithECDSA and some other ECDSA related stuff. Cheers, Tomas On 12/22/2011 11:41 PM, mark.reinhold at oracle.com wrote: > Posted: http://openjdk.java.net/jeps/131 > > - Mark From jonathan.gibbons at oracle.com Fri Dec 23 14:31:06 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 23 Dec 2011 22:31:06 +0000 Subject: hg: jdk8/tl/langtools: 7124605: typos in javac comments Message-ID: <20111223223110.6FA47477CE@hg.openjdk.java.net> Changeset: 116f68a5e677 Author: jjg Date: 2011-12-23 22:30 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/116f68a5e677 7124605: typos in javac comments Reviewed-by: ksrini ! test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/generics/inference/7086601/T7086601b.java ! test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java ! test/tools/javac/lambda/LambdaParserTest.java From sebastian.sickelmann at gmx.de Mon Dec 26 01:39:16 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Mon, 26 Dec 2011 10:39:16 +0100 Subject: Request for Review: Consistent Behavior of Exceptions Chaining and CR 7081804 Message-ID: <4EF840C4.5030407@gmx.de> Hi, one week ago (2011-12-15) [0] i asked for the downsides of changing the legacy Exceptions in core-libs. There where only one answer from "/Weijun Wang" who said that there may be serialisation issues. I created a webrev[1] /with the suggested change and tests. The dumps inside the test directories are created with [3a,3b]. Don't know if there is the possibility to introduce such In/Outputstreams to corelibs as well. @Sean Mullan: I updated the webrev[2] for the change in javax/xml/crypto to fit the excact behavior [0] http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-December/008721.html [1] http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/LegacyExceptions/webrev_0/index.html [2] http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7081804_9/index.html [3a] https://github.com/picpromusic/incubator/blob/master/misc/inc-utils/src/inc/main/DumpExceptions.java [3b] https://github.com/picpromusic/incubator/blob/master/misc/inc-utils/src/inc/util/HexDumpOutputstream.java -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20111226/b7d87f7b/attachment.html From weijun.wang at oracle.com Mon Dec 26 03:38:20 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 26 Dec 2011 19:38:20 +0800 Subject: Request for Review: Consistent Behavior of Exceptions Chaining and CR 7081804 In-Reply-To: <4EF840C4.5030407@gmx.de> References: <4EF840C4.5030407@gmx.de> Message-ID: <4EF85CAC.9030201@oracle.com> On 12/26/2011 05:39 PM, Sebastian Sickelmann wrote: > Hi, > > one week ago (2011-12-15) [0] i asked for the downsides of changing > the legacy Exceptions in core-libs. There where only one answer from > "/Weijun Wang" who said that there may be serialisation issues. I With your current solution still using the cause field inside the child class, there is no serialisation issue at all. > created a webrev[1] /with the suggested change and tests. The dumps > inside the test directories are created with [3a,3b]. Don't know if > there is the possibility to introduce such In/Outputstreams to I'm not sure the HexInputStream class is a good idea. There are quite a lot of different HEX output format, with different headers, sometimes ":" between successive HEX numbers, etc, etc. If the class is only able to recognize your own HexOutputStream, it might not be very useful. As for the output side, I use HexDumpEncoder. Of course, it's not a stream and it's sun-internal... -Max > corelibs as well. @Sean Mullan: I updated the webrev[2] for the > change in javax/xml/crypto to fit the excact behavior > > > [0] > http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-December/008721.html > > > [1] > http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/LegacyExceptions/webrev_0/index.html > > > [2] > http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7081804_9/index.html > > > [3a] > https://github.com/picpromusic/incubator/blob/master/misc/inc-utils/src/inc/main/DumpExceptions.java > > > [3b] > https://github.com/picpromusic/incubator/blob/master/misc/inc-utils/src/inc/util/HexDumpOutputstream.java > > From sebastian.sickelmann at gmx.de Tue Dec 27 11:13:33 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Tue, 27 Dec 2011 20:13:33 +0100 Subject: Request for Review: Consistent Behavior of Exceptions Chaining and CR 7081804 In-Reply-To: <4EF85CAC.9030201@oracle.com> References: <4EF840C4.5030407@gmx.de> <4EF85CAC.9030201@oracle.com> Message-ID: <4EFA18DD.103@gmx.de> Am 26.12.2011 12:38, schrieb Weijun Wang: > > > On 12/26/2011 05:39 PM, Sebastian Sickelmann wrote: >> Hi, >> >> one week ago (2011-12-15) [0] i asked for the downsides of changing >> the legacy Exceptions in core-libs. There where only one answer from >> "/Weijun Wang" who said that there may be serialisation issues. I > > With your current solution still using the cause field inside the > child class, there is no serialisation issue at all. I had a solution (for javax/xml/crypto) that removes the field. But that was far to complex for this simple goal. In this solution i discussed with Alan Bateman how we can check that the serialized form in jdk8 can also be deserialized by jdk7 and prio. I came to the solution that we can diff the jdk7 diff and the jdk8 diff. And if it's equals, every thing is fine. There is one minor error in this assumption. I think there is a cutom-serialization-flag so that we cannot compare the serialization result binary. So i had the idea to compare hexdumps to make the compare more "sematically" and the kind of the difference more visible/readable. Haven't done that. If someone had another good idea who we can regression test serialization-compatibility (even backward) please let us/me know. > >> created a webrev[1] /with the suggested change and tests. The dumps >> inside the test directories are created with [3a,3b]. Don't know if >> there is the possibility to introduce such In/Outputstreams to > > I'm not sure the HexInputStream class is a good idea. There are quite > a lot of different HEX output format, with different headers, > sometimes ":" between successive HEX numbers, etc, etc. If the class > is only able to recognize your own HexOutputStream, it might not be > very useful. > > As for the output side, I use HexDumpEncoder. Of course, it's not a > stream and it's sun-internal... Fine didn't know HexDumpEncoder till now. I will change the output to HexDumpEncoders version and modify my HexDumpInputStream to an HexDumpDecoder. I think an HexDumpDecoder that can only manage the internal HexDumpEncoders dumps is reasonable for the regression tests. > > -Max > > >> corelibs as well. @Sean Mullan: I updated the webrev[2] for the >> change in javax/xml/crypto to fit the excact behavior >> >> >> [0] >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-December/008721.html >> >> >> >> [1] >> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/LegacyExceptions/webrev_0/index.html >> >> >> >> [2] >> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7081804_9/index.html >> >> >> >> [3a] >> https://github.com/picpromusic/incubator/blob/master/misc/inc-utils/src/inc/main/DumpExceptions.java >> >> >> >> [3b] >> https://github.com/picpromusic/incubator/blob/master/misc/inc-utils/src/inc/util/HexDumpOutputstream.java >> >> >> From weijun.wang at oracle.com Tue Dec 27 18:20:04 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 28 Dec 2011 10:20:04 +0800 Subject: Request for Review: Consistent Behavior of Exceptions Chaining and CR 7081804 In-Reply-To: <4EFA18DD.103@gmx.de> References: <4EF840C4.5030407@gmx.de> <4EF85CAC.9030201@oracle.com> <4EFA18DD.103@gmx.de> Message-ID: <4EFA7CD4.2030309@oracle.com> On 12/28/2011 03:13 AM, Sebastian Sickelmann wrote: > Am 26.12.2011 12:38, schrieb Weijun Wang: >> >> >> On 12/26/2011 05:39 PM, Sebastian Sickelmann wrote: >>> Hi, >>> >>> one week ago (2011-12-15) [0] i asked for the downsides of changing >>> the legacy Exceptions in core-libs. There where only one answer from >>> "/Weijun Wang" who said that there may be serialisation issues. I >> >> With your current solution still using the cause field inside the >> child class, there is no serialisation issue at all. > I had a solution (for javax/xml/crypto) that removes the field. But that > was far to complex for this simple goal. > In this solution i discussed with Alan Bateman how we can check that the > serialized form in jdk8 can also be deserialized by jdk7 and prio. > I came to the solution that we can diff the jdk7 diff and the jdk8 diff. > And if it's equals, every thing is fine. There is one minor error in this > assumption. I think there is a cutom-serialization-flag so that we > cannot compare the serialization result binary. So i had the idea to > compare hexdumps to make the compare more "sematically" and the kind of > the difference more visible/readable. Haven't done that. If someone had > another good idea who we can regression test serialization-compatibility > (even backward) please let us/me know. I don't think you can compare the binary or hexdump, maybe the order of 2 fields can change. (is that possible?) It should be OK if you can serialize with one version and deserialize with the other. Given that all your changes are made on methods and not fields and all classes already have their serialVer field, I don't think there is a possibility that the serialization format would change. I had a test on a similar case: http://hg.openjdk.java.net/jdk8/tl/jdk/file/3c1ab134db71/test/sun/security/util/Oid/S11N.sh It's based on my belief that computers inside the Oracle network should see all versions of Java on /java/re/... Until now, this is still correct here. > >> >>> created a webrev[1] /with the suggested change and tests. The dumps >>> inside the test directories are created with [3a,3b]. Don't know if >>> there is the possibility to introduce such In/Outputstreams to >> >> I'm not sure the HexInputStream class is a good idea. There are quite >> a lot of different HEX output format, with different headers, >> sometimes ":" between successive HEX numbers, etc, etc. If the class >> is only able to recognize your own HexOutputStream, it might not be >> very useful. >> >> As for the output side, I use HexDumpEncoder. Of course, it's not a >> stream and it's sun-internal... > Fine didn't know HexDumpEncoder till now. I will change the output to > HexDumpEncoders version and modify my HexDumpInputStream to an > HexDumpDecoder. I think an HexDumpDecoder that can only manage the > internal HexDumpEncoders dumps is reasonable for the regression tests. Why not just serialize the byte[] objects into an ObjectOutputStream? I know a lot of people don't like binary files in a test, but the cryptic hexdump is no better than that. Thanks Max > >> >> -Max >> >> >>> corelibs as well. @Sean Mullan: I updated the webrev[2] for the >>> change in javax/xml/crypto to fit the excact behavior >>> >>> >>> [0] >>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-December/008721.html >>> >>> >>> >>> [1] >>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/LegacyExceptions/webrev_0/index.html >>> >>> >>> >>> [2] >>> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7081804_9/index.html >>> >>> >>> >>> [3a] >>> https://github.com/picpromusic/incubator/blob/master/misc/inc-utils/src/inc/main/DumpExceptions.java >>> >>> >>> >>> [3b] >>> https://github.com/picpromusic/incubator/blob/master/misc/inc-utils/src/inc/util/HexDumpOutputstream.java >>> >>> >>> > From lana.steuck at oracle.com Wed Dec 28 11:59:19 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 19:59:19 +0000 Subject: hg: jdk8/tl: 2 new changesets Message-ID: <20111228195919.EEA77477F0@hg.openjdk.java.net> Changeset: e1fc13802e0c Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e1fc13802e0c Added tag jdk8-b18 for changeset 7010bd24cdd0 ! .hgtags Changeset: 237bc29afbfc Author: lana Date: 2011-12-23 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/237bc29afbfc Merge From lana.steuck at oracle.com Wed Dec 28 11:59:21 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 19:59:21 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20111228195925.38AD7477F1@hg.openjdk.java.net> Changeset: 46bd4a46a5a8 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/46bd4a46a5a8 Added tag jdk8-b18 for changeset 312cf15d1657 ! .hgtags Changeset: e1366c5d84ef Author: lana Date: 2011-12-23 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e1366c5d84ef Merge From lana.steuck at oracle.com Wed Dec 28 11:59:26 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 19:59:26 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20111228195926.7985F477F2@hg.openjdk.java.net> Changeset: 5fb25931f1c2 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5fb25931f1c2 Added tag jdk8-b18 for changeset ebec6a7e8d4e ! .hgtags Changeset: dffeb62b1a7f Author: lana Date: 2011-12-23 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/dffeb62b1a7f Merge From lana.steuck at oracle.com Wed Dec 28 11:59:31 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 19:59:31 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20111228195931.27618477F3@hg.openjdk.java.net> Changeset: 72d410c3bab1 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/72d410c3bab1 Added tag jdk8-b18 for changeset 54928c8850f5 ! .hgtags Changeset: b73b733214aa Author: lana Date: 2011-12-23 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b73b733214aa Merge From lana.steuck at oracle.com Wed Dec 28 11:59:35 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 19:59:35 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20111228195945.CC371477F4@hg.openjdk.java.net> Changeset: 3c71fcc22b99 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3c71fcc22b99 Added tag jdk8-b18 for changeset ab1b1cc78577 ! .hgtags Changeset: 77b2c066084c Author: lana Date: 2011-12-23 16:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/77b2c066084c Merge - src/share/classes/com/sun/tools/javac/main/JavacOption.java - src/share/classes/com/sun/tools/javac/main/OptionName.java - src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java Changeset: 67512b631961 Author: lana Date: 2011-12-28 10:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67512b631961 Merge From lana.steuck at oracle.com Wed Dec 28 11:59:56 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 19:59:56 +0000 Subject: hg: jdk8/tl/hotspot: 70 new changesets Message-ID: <20111228200221.83B0B477F5@hg.openjdk.java.net> Changeset: da4182086289 Author: jcoomes Date: 2011-11-18 17:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/da4182086289 7113503: Bump the hs23 build number to 07 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 36b057451829 Author: dholmes Date: 2011-11-16 20:38 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/36b057451829 7110017: is_headless_jre should be updated to reflect the new location of awt toolkit libraries Reviewed-by: dholmes, dsamersoff Contributed-by: Chris Hegarty ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp Changeset: 002cb3fc8256 Author: coleenp Date: 2011-11-18 17:26 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/002cb3fc8256 Merge Changeset: c17bc65648de Author: brutisso Date: 2011-11-21 08:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c17bc65648de 7112308: Fix Visual Studio build for precompiled header Summary: Add the new path to precompiled.hpp in the project make file Reviewed-by: coleenp, dholmes, brutisso Contributed-by: rbackman ! make/windows/makefiles/projectcreator.make Changeset: 1d090cf33da6 Author: coleenp Date: 2011-11-21 10:22 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1d090cf33da6 Merge Changeset: 242b4e0e6f73 Author: phh Date: 2011-11-29 09:21 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/242b4e0e6f73 7116189: Export JVM_SetNativeThreadName from Hotspot Summary: Added JVM_SetNativeThreadName to linker mapfiles on Solaris and Linux. Reviewed-by: dcubed, dholmes Contributed-by: michael.x.mcmahon at oracle.com ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers Changeset: 763f01599ff4 Author: phh Date: 2011-11-29 17:00 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/763f01599ff4 7116481: Commercial features in Hotspot must be gated by a switch Summary: Add -XX:+UnlockCommercialVMOptions to gate use of commercial feature switches in the same way as -XX:UnlockDiagnosticVMOptions gates use of diagnostic feature switches. Reviewed-by: jwilhelm, kamg ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/globals_extension.hpp Changeset: 358eca91be48 Author: phh Date: 2011-11-30 12:48 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/358eca91be48 7116730: Revert 7116481: Commercial features in Hotspot must be gated by a switch Summary: Revert 7116481 to current hsx/hotspot-main Reviewed-by: kamg ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/globals_extension.hpp Changeset: 81a08cd7f6a1 Author: coleenp Date: 2011-12-01 13:42 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/81a08cd7f6a1 Merge Changeset: a88de71c4e3a Author: tonyp Date: 2011-11-18 12:52 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a88de71c4e3a 7097002: G1: remove a lot of unused / redundant code from the G1CollectorPolicy class Summary: Major cleanup of the G1CollectorPolicy class. It removes a lot of unused fields and methods and also consolidates replicated information (mainly various ways of counting the number of CSet regions) into one copy. Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: d06a2d7fcd5b Author: brutisso Date: 2011-11-21 07:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d06a2d7fcd5b 7110718: -XX:MarkSweepAlwaysCompactCount=0 crashes the JVM Summary: Interpret MarkSweepAlwaysCompactCount < 1 as never do full compaction Reviewed-by: ysr, tonyp, jmasa, johnc ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/memory/space.hpp Changeset: b5a5f30c483d Author: johnc Date: 2011-11-21 09:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b5a5f30c483d 7110173: GCNotifier::pushNotification publishes stale data. Summary: GCNotifier::pushNotification() references GCMemoryManager::_last_gc_stat but is called from GCMemoryManager::gc_end() before GCMemoryManager::_last_gc_stat is set up using the values in GCMemoryManager::_current_gc_stat. As a result the GC notification code accesses unitialized or stale data. Move the notification call after GCMemoryManager::_las_gc_stat is set, but inside the same if-block. Reviewed-by: poonam, dholmes, fparain, mchung ! src/share/vm/services/memoryManager.cpp Changeset: 6071e0581859 Author: johnc Date: 2011-11-18 12:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6071e0581859 7111795: G1: Various cleanups identified during walk through of changes for 6484965 Summary: Various cleanups and formatting changes identified during a code walk through of the changes for 6484965 ("G1: piggy-back liveness accounting phase on marking"). Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp Changeset: 3a298e04d914 Author: tonyp Date: 2011-11-22 04:47 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3a298e04d914 Merge Changeset: bca17e38de00 Author: jmasa Date: 2011-08-09 10:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bca17e38de00 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads Summary: Select number of GC threads dynamically based on heap usage and number of Java threads Reviewed-by: johnc, ysr, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.hpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/sharedHeap.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp ! src/share/vm/utilities/yieldingWorkgroup.cpp ! src/share/vm/utilities/yieldingWorkgroup.hpp Changeset: 00dd86e542eb Author: johnc Date: 2011-11-28 09:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/00dd86e542eb 7114303: G1: assert(_g1->mark_in_progress()) failed: shouldn't be here otherwise Summary: Race between the VM thread reading G1CollectedHeap::_mark_in_progress and it being set by the concurrent mark thread when concurrent marking is aborted by a full GC. Have the concurrent mark thread join the SuspendibleThreadSet before changing the marking state. Reviewed-by: tonyp, brutisso ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: dc467e8b2c5e Author: johnc Date: 2011-11-17 12:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dc467e8b2c5e 7112743: G1: Reduce overhead of marking closure during evacuation pauses Summary: Parallelize the serial code that was used to mark objects reachable from survivor objects in the collection set. Some minor improvments in the timers used to track the freeing of the collection set along with some tweaks to PrintGCDetails. Reviewed-by: tonyp, brutisso ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/oops/objArrayOop.hpp Changeset: ea640b5e949a Author: jmasa Date: 2011-11-22 14:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ea640b5e949a 7106024: CMS: Removed unused code for precleaning in remark phase Summary: Remove dead code. Reviewed-by: stefank, ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp Changeset: 7913e93dca52 Author: jmasa Date: 2011-11-22 14:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7913e93dca52 7112997: Remove obsolete code ResetObjectsClosure and VerifyUpdateClosure Summary: Remove obsolete code. Reviewed-by: brutisso, ysr, jcoomes ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp Changeset: 1bbf5b6fb7b0 Author: tonyp Date: 2011-12-02 08:52 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1bbf5b6fb7b0 Merge ! src/share/vm/runtime/globals.hpp Changeset: 6de8c9ba5907 Author: jcoomes Date: 2011-12-02 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6de8c9ba5907 Merge Changeset: aed8bf036ce2 Author: jcoomes Date: 2011-12-02 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aed8bf036ce2 Added tag hs23-b07 for changeset 6de8c9ba5907 ! .hgtags Changeset: cf4dd13bbcd3 Author: jcoomes Date: 2011-12-02 21:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cf4dd13bbcd3 7117536: new hotspot build - hs23-b08 Reviewed-by: johnc ! make/hotspot_version Changeset: cd00eaeebef6 Author: phh Date: 2011-12-05 12:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cd00eaeebef6 7117389: Add a framework for vendor-specific command line switch extensions to Hotspot Summary: Add a file, globals_ext.hpp, containing a null interface, to be replaced by a vendor in altsrc as needed. Reviewed-by: coleenp, kamg, dholmes, johnc, jrose ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp + src/share/vm/runtime/globals_ext.hpp ! src/share/vm/runtime/globals_extension.hpp Changeset: 8657ec177a14 Author: dcubed Date: 2011-12-05 14:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8657ec177a14 7117748: SA_APPLE_BOOT_JAVA and ALWAYS_PASS_TEST_GAMMA settings should not be required on MacOS X Summary: Replace SA_APPLE_BOOT_JAVA with logic that checks the boot JDK for the location of JDI classes. ALWAYS_PASS_TEST_GAMMA is true by default on Darwin. Reviewed-by: kvn, swingler ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/sa.make Changeset: 41cce03b29a8 Author: dcubed Date: 2011-12-06 05:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/41cce03b29a8 Merge Changeset: 03865c41c4f3 Author: vladidan Date: 2011-12-06 16:35 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/03865c41c4f3 Merge ! src/share/vm/runtime/globals.hpp Changeset: 55d777c0860a Author: dcubed Date: 2011-12-07 07:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/55d777c0860a 7118648: disable compressed oops by default on MacOS X until 7118647 is fixed Summary: UseCompressedOops is false by default on MacOS X; can still be set manually Reviewed-by: jmelvin, kvn, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: e8fdaf4a66cb Author: kvn Date: 2011-11-10 20:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e8fdaf4a66cb 7110586: C2 generates incorrect results Summary: Exact limit of empty loop calculated incorrectly. Reviewed-by: iveresov, never ! src/share/vm/opto/loopnode.cpp + test/compiler/7110586/Test7110586.java Changeset: 8c57262447d3 Author: kvn Date: 2011-11-14 18:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8c57262447d3 7105605: Use EA info to optimize pointers compare Summary: optimize pointers compare using EA information. Reviewed-by: never, twisti ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: 6729bbc1fcd6 Author: twisti Date: 2011-11-16 01:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6729bbc1fcd6 7003454: order constants in constant table by number of references in code Reviewed-by: kvn, never, bdelsart ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/matcher.hpp Changeset: 1bd45abaa507 Author: kvn Date: 2011-11-16 09:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1bd45abaa507 6890673: Eliminate allocations immediately after EA Summary: Try to eliminate allocations and related locks immediately after escape analysis. Reviewed-by: never ! src/share/vm/opto/block.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp Changeset: 973293defacd Author: iveresov Date: 2011-11-16 19:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/973293defacd 7112085: assert(fr.interpreter_frame_expression_stack_size()==0) failed: only handle empty stacks Summary: Move the inlinee invoke notification callback into inlinee preamble Reviewed-by: kvn, never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp ! test/compiler/6792161/Test6792161.java Changeset: a04a201f0f5a Author: twisti Date: 2011-11-17 04:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a04a201f0f5a 7108383: JSR 292: JRuby bench_define_method_methods.rb: assert(slow_jvms != NULL) failed: miss path must not Reviewed-by: kvn, never ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/doCall.cpp Changeset: 59bc0d4d9ea3 Author: never Date: 2011-11-18 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/59bc0d4d9ea3 7110489: C1: 64-bit tiered with ForceUnreachable: assert(reachable(src)) failed: Address should be reachable Reviewed-by: kvn, iveresov, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: 7793051af7d6 Author: twisti Date: 2011-11-21 00:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7793051af7d6 7110058: change default for ScavengeRootsInCode to 2 Reviewed-by: kvn, never ! src/share/vm/runtime/globals.hpp Changeset: f03a3c8bd5e5 Author: roland Date: 2011-09-14 09:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f03a3c8bd5e5 7077312: Provide a CALL effect for instruct declaration in the ad file Summary: abstracted way to declare that the MachNode has the effect of a call (kills caller save registers, preserves callee save registers) Reviewed-by: twisti, never ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/adlparse.hpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/machnode.hpp ! src/share/vm/opto/node.hpp Changeset: db2e64ca2d5a Author: roland Date: 2011-11-22 09:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/db2e64ca2d5a 7090968: Allow adlc register class to depend on runtime conditions Summary: allow reg_class definition as a function. Reviewed-by: kvn, never ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/formsopt.cpp ! src/share/vm/adlc/formsopt.hpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/matcher.hpp Changeset: cc81b9c09bbb Author: kvn Date: 2011-11-28 15:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cc81b9c09bbb 7112478: after 7105605 JRuby bench_define_method_methods.rb fails with NPE Summary: Fixed several EA issues with Connection Graph construction. Reviewed-by: never, twisti ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: 97825a4f7369 Author: iveresov Date: 2011-11-30 17:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/97825a4f7369 7116795: Tiered: enable by default for server Summary: Enable tiered compilation on server VM by default Reviewed-by: kvn, never ! make/jprt.properties ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp Changeset: f745b2be3737 Author: kvn Date: 2011-12-02 21:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f745b2be3737 7117282: assert(base == NULL || t_adr->isa_rawptr() || !phase->type(base) Summary: Delay memory node transformation until the memory is processed. Reviewed-by: iveresov, never ! src/share/vm/opto/memnode.cpp Changeset: 81f7362f7bed Author: kvn Date: 2011-12-08 10:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/81f7362f7bed Merge ! make/jprt.properties ! src/share/vm/runtime/globals.hpp Changeset: 4406629aa157 Author: johnc Date: 2011-12-02 12:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4406629aa157 7114095: G1: assert(obj == oopDesc::load_decode_heap_oop(p)) failed: p should still be pointing to obj Summary: As a result of the changes for 4965777, the G1 reference field scanning closure could be applied to the discovered field of a reference object twice. The failing assert is too strong if the result of the first application of the closure is stolen, and the referenced object, evacuated by another worker thread. Reviewed-by: ysr, tonyp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp Changeset: e37aedaedccd Author: tonyp Date: 2011-12-05 12:26 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e37aedaedccd Merge Changeset: f1391adc6681 Author: stefank Date: 2011-11-28 10:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f1391adc6681 7112034: Parallel CMS fails to properly mark reference objects Summary: Enabled reference processing when work stealing during concurrent marking Reviewed-by: jmasa, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: f4414323345f Author: stefank Date: 2011-11-28 14:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f4414323345f 7116081: USE_PRECOMPILED_HEADER=0 triggers a single threaded build of the JVM Summary: Changed the conditional to see if the precompiled header has been specified. Also, removed the unused PrecompiledOption. Reviewed-by: dholmes, brutisso ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/top.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/top.make ! make/solaris/makefiles/gcc.make Changeset: d23d2b18183e Author: tonyp Date: 2011-12-07 12:54 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d23d2b18183e 7118202: G1: eden size unnecessarily drops to a minimum Summary: An integer underflow can cause the RSet lengths to be massively overpredicted which forces the eden size to the minimum. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: e9b91fd07263 Author: jmasa Date: 2011-12-09 06:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e9b91fd07263 Merge Changeset: 6d7d0790074d Author: jmasa Date: 2011-12-09 19:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6d7d0790074d 7119584: UseParallelGC barrier task can be overwritten. Summary: Provoke a GC for a metadata allocation failure. Reviewed-by: johnc, iveresov ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp Changeset: 3b688d6ff3d0 Author: fparain Date: 2011-12-14 04:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3b688d6ff3d0 7104647: Adding a diagnostic command framework Reviewed-by: phh, dcubed ! src/share/vm/services/attachListener.cpp + src/share/vm/services/diagnosticArgument.cpp + src/share/vm/services/diagnosticArgument.hpp + src/share/vm/services/diagnosticCommand.cpp + src/share/vm/services/diagnosticCommand.hpp + src/share/vm/services/diagnosticFramework.cpp + src/share/vm/services/diagnosticFramework.hpp ! src/share/vm/services/jmm.h ! src/share/vm/services/management.cpp Changeset: 31f6f10e4379 Author: vladidan Date: 2011-12-14 20:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/31f6f10e4379 Merge Changeset: a2fef924d8e6 Author: amurillo Date: 2011-12-16 12:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a2fef924d8e6 Merge ! .hgtags Changeset: 61165f53f165 Author: amurillo Date: 2011-12-16 12:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/61165f53f165 Added tag hs23-b08 for changeset a2fef924d8e6 ! .hgtags Changeset: 7e075537835d Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7e075537835d Added tag jdk8-b18 for changeset 61165f53f165 ! .hgtags Changeset: 434acc838772 Author: amurillo Date: 2011-12-16 12:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/434acc838772 7122001: new hotspot build - hs23-b09 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 3c648b9ad052 Author: stefank Date: 2011-12-14 12:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c648b9ad052 7121373: Clean up CollectedHeap::is_in Summary: Fixed G1CollectedHeap::is_in, added tests, cleaned up comments and made Space::is_in pure virtual. Reviewed-by: brutisso, tonyp, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/generation.hpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/oops/arrayOop.cpp ! src/share/vm/oops/arrayOop.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/utilities/quickSort.cpp ! src/share/vm/utilities/quickSort.hpp Changeset: fd2b426c30db Author: johnc Date: 2011-12-14 17:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fd2b426c30db 7119908: G1: Cache CSet start region for each worker for subsequent reuse Summary: Cache workers' calculated starting heap region, used for parallel iteration over the collcection set, for subsequent reuse. Reviewed-by: tonyp, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: 41406797186b Author: tonyp Date: 2011-12-16 02:14 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/41406797186b 7113012: G1: rename not-fully-young GCs as "mixed" Summary: Renamed partially-young GCs as mixed and fully-young GCs as young. Change all external output that includes those terms (GC log and GC ergo log) as well as any comments, fields, methods, etc. The changeset also includes very minor code tidying up (added some curly brackets). Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1ErgoVerbose.cpp ! src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp ! src/share/vm/gc_implementation/g1/g1MonitoringSupport.hpp Changeset: adedfbbf0360 Author: johnc Date: 2011-12-16 11:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/adedfbbf0360 7120038: G1: ParallelGCThreads==0 is broken Summary: Running G1 with ParallelGCThreads==0 results in various crashes and asserts. Most of these are caused by unguarded references to the worker threads array or an incorrect number of active workers. Reviewed-by: jmasa, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: e7dead7e90af Author: johnc Date: 2011-12-19 10:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e7dead7e90af 7117303: VM uses non-monotonic time source and complains that it is non-monotonic Summary: Replaces calls to os::javaTimeMillis(), which does not (and cannot) guarantee monotonicity, in GC code to an equivalent expression that uses os::javaTimeNanos(). os::javaTimeNanos is guaranteed monotonically non-decreasing if the underlying platform provides a monotonic time source. Changes in OS files are to make use of the newly defined constants in globalDefinitions.hpp. Reviewed-by: dholmes, ysr ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/generation.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 129cd462ae89 Author: jmasa Date: 2011-12-20 12:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/129cd462ae89 Merge Changeset: 96ce4c27112f Author: coleenp Date: 2011-12-19 15:34 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/96ce4c27112f 7122939: TraceBytecodes broken with UseCompressedOops Summary: Disable verify_heapbase on sparc if TraceBytecodes because the latter uses r12 as a temp register Reviewed-by: coleenp, phh Contributed-by: Volker Simonis ! src/cpu/x86/vm/assembler_x86.cpp Changeset: 6c995c08526c Author: phh Date: 2011-12-19 15:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6c995c08526c 7122880: Extend vendor-specific command interface to include manageable switches Summary: Add Flag::external_ext()/writable_ext(), both return false. Reviewed-by: coleenp, zgu ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/globals_ext.hpp ! src/share/vm/services/management.cpp Changeset: 4502fd5c7698 Author: phh Date: 2011-12-19 21:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4502fd5c7698 Merge Changeset: 11c26bfcf8c7 Author: phh Date: 2011-12-21 15:48 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/11c26bfcf8c7 7091417: recvfrom's 6th input should be of type socklen_t Summary: Revamp class os's socket method formal args to match socket.h, insert casts in appropriate places, and copyin-copyout int*'s that s/b socklen_t*'s in jvm.cpp. Reviewed-by: coleenp, dholmes Contributed-by: erik.gahlin at oracle.com, rickard.backman at oracle.com, nils.loodin at oracle.com, markus.gronlund at oracle.com ! src/os/bsd/vm/jvm_bsd.h ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/jvm_linux.h ! src/os/linux/vm/os_linux.inline.hpp ! src/os/solaris/vm/jvm_solaris.h ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/vm/jvm_windows.h ! src/os/windows/vm/os_windows.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/ostream.cpp Changeset: c01e115b095e Author: coleenp Date: 2011-12-21 16:41 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c01e115b095e 7064927: retransformClasses() does not pass in LocalVariableTable of a method Summary: Handle LVT attribute in the class file reconstitutor. Reviewed-by: phh, coleenp Contributed-by: thomaswue ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: d532160c55f7 Author: coleenp Date: 2011-12-21 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d532160c55f7 Merge Changeset: 4b18532913c7 Author: vladidan Date: 2011-12-22 12:01 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4b18532913c7 Merge ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp Changeset: 4bcf61041217 Author: amurillo Date: 2011-12-23 15:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4bcf61041217 Merge Changeset: 9232e0ecbc2c Author: amurillo Date: 2011-12-23 15:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9232e0ecbc2c Added tag hs23-b09 for changeset 4bcf61041217 ! .hgtags From lana.steuck at oracle.com Wed Dec 28 12:00:51 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Dec 2011 20:00:51 +0000 Subject: hg: jdk8/tl/jdk: 19 new changesets Message-ID: <20111228200409.CB685477F7@hg.openjdk.java.net> Changeset: 134420afe9c2 Author: ngthomas Date: 2011-11-13 21:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/134420afe9c2 7109885: security baseline for 7u2 or above is not set correctly Reviewed-by: ccheung, igor, ohair ! make/common/shared/Sanity.gmk Changeset: 6f594239e9dc Author: ngthomas Date: 2011-11-15 23:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f594239e9dc 7112298: remove security baseline sanity check Reviewed-by: ccheung, igor, ohair ! make/common/shared/Sanity.gmk Changeset: fcc7cafa0027 Author: herrick Date: 2011-11-18 06:35 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fcc7cafa0027 Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/native/sun/rmi/server/MarshalInputStream.c - test/java/net/DatagramSocket/ChangingAddress.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: 526e99f06a59 Author: igor Date: 2011-12-06 16:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/526e99f06a59 Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: 334bd51fb3f3 Author: igor Date: 2011-12-19 10:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/334bd51fb3f3 Merge - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh Changeset: c6fab5332075 Author: cl Date: 2011-12-22 19:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6fab5332075 Added tag jdk8-b18 for changeset 334bd51fb3f3 ! .hgtags Changeset: 7dbc53242c2a Author: art Date: 2011-12-07 17:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7dbc53242c2a 7117008: Warnings cleanup day: reduce number of javac warnings in the sun.awt package Reviewed-by: anthony, denis, bagiras ! src/share/classes/sun/awt/AWTAutoShutdown.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/awt/CausedFocusEvent.java ! src/share/classes/sun/awt/DebugSettings.java ! src/share/classes/sun/awt/EmbeddedFrame.java ! src/share/classes/sun/awt/EventListenerAggregate.java - src/share/classes/sun/awt/FocusingTextField.java ! src/share/classes/sun/awt/HeadlessToolkit.java - src/share/classes/sun/awt/HorizBagLayout.java ! src/share/classes/sun/awt/KeyboardFocusManagerPeerImpl.java ! src/share/classes/sun/awt/ModalityEvent.java - src/share/classes/sun/awt/OrientableFlowLayout.java ! src/share/classes/sun/awt/PaintEventDispatcher.java ! src/share/classes/sun/awt/PeerEvent.java ! src/share/classes/sun/awt/SunDisplayChanger.java ! src/share/classes/sun/awt/SunGraphicsCallback.java ! src/share/classes/sun/awt/SunToolkit.java ! src/share/classes/sun/awt/UngrabEvent.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java Changeset: 18925904efc2 Author: alexsch Date: 2011-12-12 15:33 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18925904efc2 7105890: closed/javax/swing/JScrollBar/4708809/bug4708809.java deadlocks on MacOS Reviewed-by: alexp + test/javax/swing/JScrollBar/4708809/bug4708809.java Changeset: 44b26d6a55a6 Author: alexsch Date: 2011-12-13 15:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44b26d6a55a6 7112931: closed/javax/swing/JTabbedPane/6416920/bug6416920.java fails on MacOS Reviewed-by: alexp + test/javax/swing/JTabbedPane/6416920/bug6416920.java Changeset: 70233f5e909c Author: alexsch Date: 2011-12-13 17:30 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70233f5e909c 7120869: javax/swing/JScrollBar/4708809/bug4708809.java fails on Windows Summary: The robot auto-delay is increased to fix the test failing on Windows. Reviewed-by: alexp ! test/javax/swing/JScrollBar/4708809/bug4708809.java Changeset: 032a91abc540 Author: alexsch Date: 2011-12-13 18:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/032a91abc540 7116950: Reduce number of warnings in swing Reviewed-by: art ! src/share/classes/com/sun/java/swing/Painter.java ! src/share/classes/java/beans/PropertyDescriptor.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/ActionMap.java ! src/share/classes/javax/swing/ActionPropertyChangeListener.java ! src/share/classes/javax/swing/AncestorNotifier.java ! src/share/classes/javax/swing/ArrayTable.java ! src/share/classes/javax/swing/Box.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/ButtonGroup.java ! src/share/classes/javax/swing/ComponentInputMap.java ! src/share/classes/javax/swing/InputMap.java ! src/share/classes/javax/swing/JButton.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JMenuBar.java ! src/share/classes/javax/swing/JMenuItem.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JRootPane.java ! src/share/classes/javax/swing/JSeparator.java ! src/share/classes/javax/swing/JToolTip.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/MenuSelectionManager.java ! src/share/classes/javax/swing/Popup.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/javax/swing/Timer.java ! src/share/classes/javax/swing/border/AbstractBorder.java ! src/share/classes/javax/swing/border/CompoundBorder.java ! src/share/classes/javax/swing/border/EmptyBorder.java ! src/share/classes/javax/swing/border/MatteBorder.java ! src/share/classes/javax/swing/border/TitledBorder.java ! src/share/classes/javax/swing/event/AncestorEvent.java ! src/share/classes/javax/swing/event/ChangeEvent.java ! src/share/classes/javax/swing/event/EventListenerList.java ! src/share/classes/javax/swing/event/ListDataEvent.java ! src/share/classes/javax/swing/event/MenuDragMouseEvent.java ! src/share/classes/javax/swing/event/MenuEvent.java ! src/share/classes/javax/swing/event/MenuKeyEvent.java ! src/share/classes/javax/swing/event/PopupMenuEvent.java ! src/share/classes/javax/swing/plaf/ComponentUI.java ! src/share/classes/javax/swing/text/BadLocationException.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java Changeset: 282b2ce90afe Author: lana Date: 2011-12-16 12:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/282b2ce90afe Merge ! src/share/classes/java/beans/PropertyDescriptor.java - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh Changeset: 75bd7295c706 Author: bagiras Date: 2011-12-19 15:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75bd7295c706 7117334: Warnings cleanup day: reduce number of javac warnings in the java.awt package Reviewed-by: art, denis, alexsch ! src/share/classes/java/awt/AWTEvent.java ! src/share/classes/java/awt/AWTEventMulticaster.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Font.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/image/ColorModel.java Changeset: d15f38f08ce9 Author: denis Date: 2011-12-19 16:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d15f38f08ce9 7117011: Reduce number of warnings in sun/awt/windows and sun/awt/datatransfer Reviewed-by: art ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java ! src/solaris/classes/sun/awt/X11/XClipboard.java ! src/windows/classes/sun/awt/windows/TranslucentWindowPainter.java ! src/windows/classes/sun/awt/windows/WBufferStrategy.java ! src/windows/classes/sun/awt/windows/WChoicePeer.java ! src/windows/classes/sun/awt/windows/WClipboard.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WDataTransferer.java ! src/windows/classes/sun/awt/windows/WDesktopProperties.java ! src/windows/classes/sun/awt/windows/WDialogPeer.java ! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WFramePeer.java ! src/windows/classes/sun/awt/windows/WInputMethod.java ! src/windows/classes/sun/awt/windows/WMenuItemPeer.java ! src/windows/classes/sun/awt/windows/WPageDialog.java ! src/windows/classes/sun/awt/windows/WPageDialogPeer.java ! src/windows/classes/sun/awt/windows/WPrintDialog.java ! src/windows/classes/sun/awt/windows/WPrintDialogPeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: cded2429cdbf Author: anthony Date: 2011-12-20 12:48 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cded2429cdbf 7122796: SunToolkit constructor should create the EventQueue for the Main AppContext Summary: Always create an EQ for the main AppContext in SunToolkit constructor Reviewed-by: art ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/awt/SunToolkit.java + test/java/awt/EventQueue/MainAppContext/MainAppContext.java Changeset: 94d7051cca13 Author: lana Date: 2011-12-20 15:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94d7051cca13 Merge - src/share/classes/sun/awt/FocusingTextField.java - src/share/classes/sun/awt/HorizBagLayout.java - src/share/classes/sun/awt/OrientableFlowLayout.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java Changeset: 570f3d893596 Author: lana Date: 2011-12-20 15:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/570f3d893596 Merge - src/share/classes/com/sun/tools/jdi/LinkedHashMap.java Changeset: 6f19ff39cff4 Author: lana Date: 2011-12-23 16:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f19ff39cff4 Merge - src/share/classes/com/sun/tools/jdi/LinkedHashMap.java - src/share/classes/sun/awt/FocusingTextField.java - src/share/classes/sun/awt/HorizBagLayout.java - src/share/classes/sun/awt/OrientableFlowLayout.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java Changeset: 437255d15e76 Author: lana Date: 2011-12-28 10:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/437255d15e76 Merge - src/share/classes/sun/awt/FocusingTextField.java - src/share/classes/sun/awt/HorizBagLayout.java - src/share/classes/sun/awt/OrientableFlowLayout.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java From stuart.marks at oracle.com Thu Dec 29 16:38:45 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 30 Dec 2011 00:38:45 +0000 Subject: hg: jdk8/tl/jdk: 7122061: add -Xlint:all -Werror to warning-free build steps Message-ID: <20111230003923.B5B754782C@hg.openjdk.java.net> Changeset: 3a7ea63302f8 Author: smarks Date: 2011-12-29 16:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a7ea63302f8 7122061: add -Xlint:all -Werror to warning-free build steps Reviewed-by: chegar, alanb, dholmes, ohair ! make/com/sun/demo/jvmti/hprof/Makefile ! make/com/sun/java/browser/net/Makefile ! make/com/sun/tools/Makefile ! make/com/sun/tools/attach/Makefile ! make/com/sun/tracing/Makefile ! make/com/sun/tracing/dtrace/Makefile ! make/java/instrument/Makefile ! make/java/rmi/Makefile ! make/java/text/base/Makefile ! make/java/text/bidi/Makefile ! make/java/util/Makefile ! make/javax/accessibility/Makefile ! make/javax/others/Makefile ! make/javax/security/Makefile ! make/jpda/tty/Makefile ! make/sun/launcher/Makefile ! make/sun/serialver/Makefile ! make/sun/text/Makefile ! make/sun/util/Makefile