From weijun.wang at oracle.com Tue Mar 1 00:24:35 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 01 Mar 2011 08:24:35 +0000 Subject: hg: jdk7/tl/jdk: 7020531: test: java/security/cert/CertificateFactory/openssl/OpenSSLCert.java file not closed after run Message-ID: <20110301082445.754D247B64@hg.openjdk.java.net> Changeset: f8bf888edf20 Author: weijun Date: 2011-03-01 16:22 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f8bf888edf20 7020531: test: java/security/cert/CertificateFactory/openssl/OpenSSLCert.java file not closed after run Reviewed-by: alanb, smarks ! test/ProblemList.txt ! test/java/security/cert/CertificateFactory/openssl/OpenSSLCert.java ! test/sun/security/tools/keytool/NewSize7.java From alan.bateman at oracle.com Tue Mar 1 04:09:08 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 01 Mar 2011 12:09:08 +0000 Subject: hg: jdk7/tl/jdk: 7023034: Files.createTempDirectory((Path)null, "temp") does not throw NPE Message-ID: <20110301120938.E89BB47B71@hg.openjdk.java.net> Changeset: b7e763a573a4 Author: alanb Date: 2011-03-01 12:03 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b7e763a573a4 7023034: Files.createTempDirectory((Path)null, "temp") does not throw NPE Reviewed-by: forax ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/Files/TemporaryFiles.java From jonathan.gibbons at oracle.com Tue Mar 1 12:00:34 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 01 Mar 2011 20:00:34 +0000 Subject: hg: jdk7/tl/langtools: 7021183: 269: assertion failure getting enclosing element of an undefined name Message-ID: <20110301200037.108CA47B8F@hg.openjdk.java.net> Changeset: 938dda0bec17 Author: jjg Date: 2011-03-01 12:00 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/938dda0bec17 7021183: 269: assertion failure getting enclosing element of an undefined name Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symtab.java + test/tools/javac/processing/model/TestSymtabItems.java From stuart.marks at oracle.com Tue Mar 1 15:43:01 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 01 Mar 2011 23:43:01 +0000 Subject: hg: jdk7/tl/jdk: 7022624: use try-with-resources in java.io tests Message-ID: <20110301234311.C69BC47BA5@hg.openjdk.java.net> Changeset: 98d2d57d9e73 Author: smarks Date: 2011-03-01 15:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98d2d57d9e73 7022624: use try-with-resources in java.io tests Reviewed-by: alanb ! test/java/io/File/SetLastModified.java ! test/java/io/FileOutputStream/AtomicAppend.java ! test/java/io/OutputStreamWriter/Encode.java ! test/java/io/PrintStream/EncodingConstructor.java ! test/java/io/PrintStream/FailingConstructors.java ! test/java/io/Serializable/evolution/RenamePackage/install/SerialDriver.java ! test/java/io/Serializable/evolution/RenamePackage/test/SerialDriver.java From maurizio.cimadamore at oracle.com Wed Mar 2 02:57:21 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 02 Mar 2011 10:57:21 +0000 Subject: hg: jdk7/tl/langtools: 6541876: "Enclosing Instance" error new in 1.6 Message-ID: <20110302105725.7DECE47BC5@hg.openjdk.java.net> Changeset: 02b699d97a55 Author: mcimadamore Date: 2011-03-02 10:56 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/02b699d97a55 6541876: "Enclosing Instance" error new in 1.6 Summary: unqualified 'this' should not be selected in a qualified super() call in a default constructor Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/implicitThis/6541876/T6541876a.java + test/tools/javac/implicitThis/6541876/T6541876b.java ! test/tools/javac/implicitThis/NewBeforeOuterConstructed3.java ! test/tools/javac/nested/4903103/T4903103.java From alan.bateman at oracle.com Wed Mar 2 09:17:06 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 02 Mar 2011 17:17:06 +0000 Subject: hg: jdk7/tl/jdk: 7021987: native2ascii "file cannot be read" error message is broken Message-ID: <20110302171717.1A3E547BD2@hg.openjdk.java.net> Changeset: 895687e879ca Author: alanb Date: 2011-03-02 16:56 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/895687e879ca 7021987: native2ascii "file cannot be read" error message is broken Reviewed-by: lancea, mchung ! src/share/classes/sun/tools/native2ascii/Main.java ! test/sun/tools/native2ascii/Native2AsciiTests.sh From jonathan.gibbons at oracle.com Wed Mar 2 14:04:26 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 02 Mar 2011 22:04:26 +0000 Subject: hg: jdk7/tl/langtools: 6986895: compiler gives misleading message for no input files Message-ID: <20110302220428.5DDF547BE2@hg.openjdk.java.net> Changeset: 2a5c919f20b8 Author: jjg Date: 2011-03-02 14:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2a5c919f20b8 6986895: compiler gives misleading message for no input files Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/options/T6986895.java From weijun.wang at oracle.com Wed Mar 2 16:32:58 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 03 Mar 2011 08:32:58 +0800 Subject: code review request: 7012160: read SF file in signed jar in streaming mode In-Reply-To: <4D5C1391.5020107@oracle.com> References: <4D3009E6.8020003@oracle.com> <4D487041.4010605@oracle.com> <4D539D0C.7040209@oracle.com> <4D5C1391.5020107@oracle.com> Message-ID: <4D6EE1BA.1020705@oracle.com> Webrev updated http://cr.openjdk.java.net/~weijun/7012160/webrev.01/ Thanks Max On 02/17/2011 02:12 AM, Sean Mullan wrote: > Max, > > A few more comments. Did you consider instead creating an internal > subclass of Manifest (ex: sun.security.util.SignatureFileManifest) and > adding the update method and other logic to the subclass? I think this > might be a better design. Even though we would have to be careful to > monitor changes to the Manifest class in the future, it avoids making > API changes to the Manifest class. > > * SignatureFileVerifier > > [121]: Can you rename this to "needSignatureFile"? I think that matches > the description of the method better. > > [138]: Same comment as above. I think setSignatureFile is a better name. > Also can you add a comment describing what this method does? > > * JarVerifier > > [267]: this should be printed in debug only > > --Sean > > > On 2/10/11 3:08 AM, Weijun Wang wrote: >> >> >> On 02/02/2011 04:42 AM, Sean Mullan wrote: >>> Hi Max, >>> >>> This is looking good. I'm about halfway through. Here are some code >>> comments to start with. I think we'll need a couple more rounds of code >>> reviews before we finish so I wanted to get these to you now. >>> >>> * JarFile >>> >>> [329-330]: How about adding a SignatureFileVerifier.isBlock method >>> instead? That would be cleaner. >> >> Good. >> >>> >>> [338]: I believe you can replace the argument to getBytes with the local >>> variable e : >>> >>> s/getBytes(getJarEntry(names[i])),/getBytes(e), >> >> Correct. >> >>> >>> * PKCS7 >>> >>> Can we avoid duplicating code across SignerInfo and PKCS7Verifier? Can >>> SignerInfo.verify invoke methods of PKCS7Verifier? >> >> I thought SignerInfo.verify() could be removed at all, and only keep >> it there >> for your code review. Yes. It can be rewritten to -- >> >> SignerInfo verify(PKCS7 block, byte[] data) >> throws NoSuchAlgorithmException, SignatureException { >> >> PKCS7.PKCS7Verifier p7v = PKCS7.PKCS7Verifier.from(block, this); >> if (p7v == null) return null; >> if (data == null) { >> try { >> data = block.getContentInfo().getContentBytes(); >> } catch (IOException e) { >> throw new SignatureException( >> "IO error verifying signature:\n" + >> e.getMessage()); >> } >> } >> p7v.update(data, 0, data.length); >> return p7v.verify(); >> } >> >>> >>> [538-540]: fields should be marked final >> >> OK. >> >>> >>> [542]: Why is a static method necessary here? Since the method always >>> creates a PKCS7Verifier object, it doesn't seem like it is that useful >>> or necessary. >> >> The original verify() method in SignerInfo sometimes return null and >> sometimes >> throws an Exception. I don't exactly understand why there is such a >> difference >> and use this static method to precisely mimic the behavior. >> >>> >>> [661-665]: replace this code with MessageDigest.isEqual. >> >> Yes. >> >> All changes are trivial except for the new SignerInfo.verify() method. >> I guess a >> webrev is not needed. >> >> Thanks >> Max >> >>> >>> --Sean >>> >>> >>> On 1/14/11 3:31 AM, Weijun Wang wrote: >>>> Hi Sean >>>> >>>> http://cr.openjdk.java.net/~weijun/7012160/webrev.00/ >>>> >>>> I've made changes to the following classes to enable streaming mode SF >>>> file >>>> reading: >>>> >>>> - java/util/jar/JarVerifier.java: >>>> >>>> 1. New verifyBlock method. >>>> >>>> 2. Change the constructor from JarVerifier(byte[]) to >>>> JarVerifier(byte[], >>>> Manifest). In SignatureFileVerifier.processImpl(), if we already >>>> confirm the >>>> *-Digest-Manifest header in the SF file matches the whole MANIFEST.MF, >>>> there'se >>>> no need to parse the rest of the SF file, since we can be sure that >>>> entries in >>>> the SF file are identical to those in MANIFEST.MF. Of course, the >>>> content of the >>>> SF file still needs to be fed into PKCS7Verifier to verify the >>>> signature. >>>> >>>> - java/util/jar/JarFile.java: >>>> >>>> Read DSA file in byte[] and SF file in InputStream, and call >>>> JarVerifier.verifyBlock() to verify. >>>> >>>> - java/util/jar/Manifest.java: >>>> >>>> Adding update(byte[]) to read manifest in streaming mode. This is a >>>> new public API. >>>> >>>> - sun/security/pkcs/PKCS7.java: >>>> >>>> New PKCS7Verifier class to verify SignedData in streaming mode. I >>>> basically >>>> divide the SignerInfo.verify(PKCS7 block, byte[] data) method into 3 >>>> parts and >>>> make them the 3 methods of this class. >>>> >>>> - sun/security/util/SignatureFileVerifier.java: >>>> >>>> Rewrite the processImpl(*) method to make use of new methods in PKCS7 >>>> and Manifest. >>>> >>>> No new regression tests, use existing ones. >>>> >>>> I've tried NetBeans profiler to look at the memory. The program simply >>>> calls >>>> JarSigner.main(new String[]{"-verify", "x.jar"}) and the signed jar >>>> x.jar has >>>> 10000 files inside. >>>> >>>> Before After >>>> byte[] 3.6MB 2.8MB >>>> char[] 2.0MB 1.3MB >>>> String 1.1MB 650KB >>>> >>>> So it does have some difference. >>>> >>>> Thanks >>>> Max >>>> >>>> >>>> -------- Original Message -------- >>>> *Change Request ID*: 7012160 >>>> *Synopsis*: read SF file in signed jar in streaming mode >>>> >>>> >>>> === *Description* >>>> ============================================================ >>>> When a signed jar is verified, its SF file is read into a byte array >>>> and >>>> verified against the signature. When there are many files in the jar, >>>> the SF >>>> file can be very big. It will be better if the file can be read in >>>> streaming mode. >>>> >>>> *** (#1 of 1): 2011-01-13 12:23:25 GMT+00:00 weijun.wang at oracle.com >>>> From jonathan.gibbons at oracle.com Wed Mar 2 21:06:48 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 03 Mar 2011 05:06:48 +0000 Subject: hg: jdk7/tl/langtools: 6986892: confusing warning given after errors in annotation processing Message-ID: <20110303050650.DA07C47BF7@hg.openjdk.java.net> Changeset: 3085d0089546 Author: jjg Date: 2011-03-02 21:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3085d0089546 6986892: confusing warning given after errors in annotation processing Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/processing/warnings/UseImplicit/C1.java + test/tools/javac/processing/warnings/UseImplicit/TestProcUseImplicitWarning.java + test/tools/javac/processing/warnings/UseImplicit/err.out + test/tools/javac/processing/warnings/UseImplicit/p/C2.java + test/tools/javac/processing/warnings/UseImplicit/warn.out From jonathan.gibbons at oracle.com Wed Mar 2 21:14:24 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 03 Mar 2011 05:14:24 +0000 Subject: hg: jdk7/tl/langtools: 6639645: Modeling type implementing missing interfaces Message-ID: <20110303051426.EBA1B47BF8@hg.openjdk.java.net> Changeset: 4baab658f357 Author: jjg Date: 2011-03-02 21:13 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4baab658f357 6639645: Modeling type implementing missing interfaces Reviewed-by: darcy, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! test/tools/javac/api/6557752/T6557752.java + test/tools/javac/processing/model/element/TestMissingElement/InvalidSource.java + test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java + test/tools/javac/processing/model/element/TestMissingElement2/Generator.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingClass.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass1.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass2.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface1.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface2.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingInterface.java From maurizio.cimadamore at oracle.com Thu Mar 3 01:44:46 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 03 Mar 2011 09:44:46 +0000 Subject: hg: jdk7/tl/langtools: 7023233: False positive for -Xlint:try with nested try with resources blocks Message-ID: <20110303094448.E0F9447C04@hg.openjdk.java.net> Changeset: e9b8fbb30f5a Author: mcimadamore Date: 2011-03-03 09:43 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e9b8fbb30f5a 7023233: False positive for -Xlint:try with nested try with resources blocks Summary: Wrong lint warning issued about unused resource when nested try-with-resource blocks are found Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java + test/tools/javac/TryWithResources/UnusedResourcesTest.java From kelly.ohair at oracle.com Thu Mar 3 06:51:07 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Thu, 03 Mar 2011 14:51:07 +0000 Subject: hg: jdk7/tl/jaxp: 7023289: jaxp 1.4.5 development jdk7 2nd integration Message-ID: <20110303145107.3064747C13@hg.openjdk.java.net> Changeset: 877fd25c5a2f Author: ohair Date: 2011-03-02 12:00 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/877fd25c5a2f 7023289: jaxp 1.4.5 development jdk7 2nd integration Reviewed-by: joehw, mchung, alanb ! jaxp.properties From michael.x.mcmahon at oracle.com Thu Mar 3 07:35:06 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 03 Mar 2011 15:35:06 +0000 Subject: hg: jdk7/tl/jdk: 7018606: (process) test/java/lang/ProcessBuilder/Basic.java failing intermittently (win) Message-ID: <20110303153525.6893147C17@hg.openjdk.java.net> Changeset: 75064373ed6b Author: michaelm Date: 2011-03-03 15:34 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/75064373ed6b 7018606: (process) test/java/lang/ProcessBuilder/Basic.java failing intermittently (win) Reviewed-by: alanb ! test/java/lang/ProcessBuilder/Basic.java From chris.hegarty at oracle.com Thu Mar 3 08:45:27 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 03 Mar 2011 16:45:27 +0000 Subject: hg: jdk7/tl/jdk: 7018137: HTML4 compliance issues Message-ID: <20110303164537.7688347C1C@hg.openjdk.java.net> Changeset: 7cfb0693eb33 Author: chegar Date: 2011-03-03 16:44 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7cfb0693eb33 7018137: HTML4 compliance issues Summary: move end list items tags to after nested list Reviewed-by: alanb ! src/share/classes/java/net/URI.java ! src/share/classes/java/net/package.html From chris.hegarty at oracle.com Thu Mar 3 08:49:26 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 03 Mar 2011 16:49:26 +0000 Subject: hg: jdk7/tl/jdk: 6721694: java/lang/Thread/StartOOMTest.java fails with timeout or with crash Message-ID: <20110303164938.64E0247C1D@hg.openjdk.java.net> Changeset: 9b99a14375bc Author: chegar Date: 2011-03-03 16:48 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b99a14375bc 6721694: java/lang/Thread/StartOOMTest.java fails with timeout or with crash Summary: the test is not suitable to be run automatically Reviewed-by: alanb ! test/java/lang/Thread/StartOOMTest.java From sean.coffey at oracle.com Thu Mar 3 08:56:42 2011 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Thu, 03 Mar 2011 16:56:42 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110303165701.59E7147C1F@hg.openjdk.java.net> Changeset: 732faed56eb0 Author: coffeys Date: 2011-03-03 16:51 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/732faed56eb0 6750362: Very large LDAP requests throw a OOM on LDAP servers which aren't aware of Paged Results Controls 6748156: add an new JNDI property to control the boolean flag WaitForReply Reviewed-by: vinnie, robm ! src/share/classes/com/sun/jndi/ldap/Connection.java ! src/share/classes/com/sun/jndi/ldap/LdapClient.java ! src/share/classes/com/sun/jndi/ldap/LdapCtx.java ! src/share/classes/com/sun/jndi/ldap/LdapRequest.java + test/com/sun/jndi/ldap/NoWaitForReplyTest.java Changeset: 0bd32f96187d Author: coffeys Date: 2011-03-03 17:00 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bd32f96187d Merge From michael.x.mcmahon at oracle.com Thu Mar 3 09:16:35 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 03 Mar 2011 17:16:35 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110303171654.ACFAE47C21@hg.openjdk.java.net> Changeset: b645b5bc460b Author: michaelm Date: 2011-03-03 17:14 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b645b5bc460b 7024264: HttpURLConnection/NetPermission doc issue Reviewed-by: chegar ! src/share/classes/java/net/HttpURLConnection.java ! src/share/classes/java/net/NetPermission.java Changeset: 6e596210bf01 Author: michaelm Date: 2011-03-03 17:16 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6e596210bf01 Merge From maurizio.cimadamore at oracle.com Thu Mar 3 09:51:53 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 03 Mar 2011 17:51:53 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20110303175157.809A547C23@hg.openjdk.java.net> Changeset: c15d788cb381 Author: mcimadamore Date: 2011-03-03 17:32 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c15d788cb381 7023703: Valid code doesn't compile Summary: leftovers cause problems when analyzing loops in Flow.java Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java + test/tools/javac/7023703/T7023703neg.java + test/tools/javac/7023703/T7023703neg.out + test/tools/javac/7023703/T7023703pos.java Changeset: 32565546784b Author: mcimadamore Date: 2011-03-03 17:34 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/32565546784b 7022054: Invalid compiler error on covariant overriding methods with the same erasure Summary: Rules for method clash use notion of subsignature, which is sometimes too strict and incompatible with JDK 6 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/7022054/T7022054neg1.java + test/tools/javac/generics/7022054/T7022054neg1.out + test/tools/javac/generics/7022054/T7022054neg2.java + test/tools/javac/generics/7022054/T7022054neg2.out + test/tools/javac/generics/7022054/T7022054pos1.java + test/tools/javac/generics/7022054/T7022054pos2.java From maurizio.cimadamore at oracle.com Thu Mar 3 10:06:08 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 03 Mar 2011 18:06:08 +0000 Subject: hg: jdk7/tl/langtools: 7024212: TestWarnErrorCount fails Message-ID: <20110303180610.A823847C24@hg.openjdk.java.net> Changeset: 8fb48a9ac9ec Author: mcimadamore Date: 2011-03-03 18:05 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8fb48a9ac9ec 7024212: TestWarnErrorCount fails Summary: TestWarnErrorCount should be executed with -Xlint:all,-path to avoid spurious failures Reviewed-by: jjg ! test/tools/javac/processing/TestWarnErrorCount.java From alan.bateman at oracle.com Fri Mar 4 01:39:07 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 04 Mar 2011 09:39:07 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110304093928.833CF47CA2@hg.openjdk.java.net> Changeset: 2fb9e2d4ef46 Author: alanb Date: 2011-03-04 09:29 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2fb9e2d4ef46 6944810: (ch) Assert failure in sun.nio.ch.PendingIoCache.clearPendingIoMap [win] Reviewed-by: chegar ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/windows/classes/sun/nio/ch/PendingIoCache.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java ! test/ProblemList.txt Changeset: 259011d14d48 Author: alanb Date: 2011-03-04 09:33 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/259011d14d48 Merge From weijun.wang at oracle.com Fri Mar 4 02:30:02 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 04 Mar 2011 18:30:02 +0800 Subject: code review request: 7012160: read SF file in signed jar in streaming mode In-Reply-To: <4D6EE1BA.1020705@oracle.com> References: <4D3009E6.8020003@oracle.com> <4D487041.4010605@oracle.com> <4D539D0C.7040209@oracle.com> <4D5C1391.5020107@oracle.com> <4D6EE1BA.1020705@oracle.com> Message-ID: <4D70BF2A.4030604@oracle.com> Small non-functional changes: http://cr.openjdk.java.net/~weijun/7012160/webrev.02/ 1. comments 2. some new language usage, say, <> operator 3. Vector->List, Hashtable->Map Thanks Max On 03/03/2011 08:32 AM, Weijun Wang wrote: > Webrev updated > > http://cr.openjdk.java.net/~weijun/7012160/webrev.01/ > > Thanks > Max > > > On 02/17/2011 02:12 AM, Sean Mullan wrote: >> Max, >> >> A few more comments. Did you consider instead creating an internal >> subclass of Manifest (ex: sun.security.util.SignatureFileManifest) and >> adding the update method and other logic to the subclass? I think this >> might be a better design. Even though we would have to be careful to >> monitor changes to the Manifest class in the future, it avoids making >> API changes to the Manifest class. >> >> * SignatureFileVerifier >> >> [121]: Can you rename this to "needSignatureFile"? I think that matches >> the description of the method better. >> >> [138]: Same comment as above. I think setSignatureFile is a better name. >> Also can you add a comment describing what this method does? >> >> * JarVerifier >> >> [267]: this should be printed in debug only >> >> --Sean >> >> >> On 2/10/11 3:08 AM, Weijun Wang wrote: >>> >>> >>> On 02/02/2011 04:42 AM, Sean Mullan wrote: >>>> Hi Max, >>>> >>>> This is looking good. I'm about halfway through. Here are some code >>>> comments to start with. I think we'll need a couple more rounds of code >>>> reviews before we finish so I wanted to get these to you now. >>>> >>>> * JarFile >>>> >>>> [329-330]: How about adding a SignatureFileVerifier.isBlock method >>>> instead? That would be cleaner. >>> >>> Good. >>> >>>> >>>> [338]: I believe you can replace the argument to getBytes with the >>>> local >>>> variable e : >>>> >>>> s/getBytes(getJarEntry(names[i])),/getBytes(e), >>> >>> Correct. >>> >>>> >>>> * PKCS7 >>>> >>>> Can we avoid duplicating code across SignerInfo and PKCS7Verifier? Can >>>> SignerInfo.verify invoke methods of PKCS7Verifier? >>> >>> I thought SignerInfo.verify() could be removed at all, and only keep >>> it there >>> for your code review. Yes. It can be rewritten to -- >>> >>> SignerInfo verify(PKCS7 block, byte[] data) >>> throws NoSuchAlgorithmException, SignatureException { >>> >>> PKCS7.PKCS7Verifier p7v = PKCS7.PKCS7Verifier.from(block, this); >>> if (p7v == null) return null; >>> if (data == null) { >>> try { >>> data = block.getContentInfo().getContentBytes(); >>> } catch (IOException e) { >>> throw new SignatureException( >>> "IO error verifying signature:\n" + >>> e.getMessage()); >>> } >>> } >>> p7v.update(data, 0, data.length); >>> return p7v.verify(); >>> } >>> >>>> >>>> [538-540]: fields should be marked final >>> >>> OK. >>> >>>> >>>> [542]: Why is a static method necessary here? Since the method always >>>> creates a PKCS7Verifier object, it doesn't seem like it is that useful >>>> or necessary. >>> >>> The original verify() method in SignerInfo sometimes return null and >>> sometimes >>> throws an Exception. I don't exactly understand why there is such a >>> difference >>> and use this static method to precisely mimic the behavior. >>> >>>> >>>> [661-665]: replace this code with MessageDigest.isEqual. >>> >>> Yes. >>> >>> All changes are trivial except for the new SignerInfo.verify() method. >>> I guess a >>> webrev is not needed. >>> >>> Thanks >>> Max >>> >>>> >>>> --Sean >>>> >>>> >>>> On 1/14/11 3:31 AM, Weijun Wang wrote: >>>>> Hi Sean >>>>> >>>>> http://cr.openjdk.java.net/~weijun/7012160/webrev.00/ >>>>> >>>>> I've made changes to the following classes to enable streaming mode SF >>>>> file >>>>> reading: >>>>> >>>>> - java/util/jar/JarVerifier.java: >>>>> >>>>> 1. New verifyBlock method. >>>>> >>>>> 2. Change the constructor from JarVerifier(byte[]) to >>>>> JarVerifier(byte[], >>>>> Manifest). In SignatureFileVerifier.processImpl(), if we already >>>>> confirm the >>>>> *-Digest-Manifest header in the SF file matches the whole MANIFEST.MF, >>>>> there'se >>>>> no need to parse the rest of the SF file, since we can be sure that >>>>> entries in >>>>> the SF file are identical to those in MANIFEST.MF. Of course, the >>>>> content of the >>>>> SF file still needs to be fed into PKCS7Verifier to verify the >>>>> signature. >>>>> >>>>> - java/util/jar/JarFile.java: >>>>> >>>>> Read DSA file in byte[] and SF file in InputStream, and call >>>>> JarVerifier.verifyBlock() to verify. >>>>> >>>>> - java/util/jar/Manifest.java: >>>>> >>>>> Adding update(byte[]) to read manifest in streaming mode. This is a >>>>> new public API. >>>>> >>>>> - sun/security/pkcs/PKCS7.java: >>>>> >>>>> New PKCS7Verifier class to verify SignedData in streaming mode. I >>>>> basically >>>>> divide the SignerInfo.verify(PKCS7 block, byte[] data) method into 3 >>>>> parts and >>>>> make them the 3 methods of this class. >>>>> >>>>> - sun/security/util/SignatureFileVerifier.java: >>>>> >>>>> Rewrite the processImpl(*) method to make use of new methods in PKCS7 >>>>> and Manifest. >>>>> >>>>> No new regression tests, use existing ones. >>>>> >>>>> I've tried NetBeans profiler to look at the memory. The program simply >>>>> calls >>>>> JarSigner.main(new String[]{"-verify", "x.jar"}) and the signed jar >>>>> x.jar has >>>>> 10000 files inside. >>>>> >>>>> Before After >>>>> byte[] 3.6MB 2.8MB >>>>> char[] 2.0MB 1.3MB >>>>> String 1.1MB 650KB >>>>> >>>>> So it does have some difference. >>>>> >>>>> Thanks >>>>> Max >>>>> >>>>> >>>>> -------- Original Message -------- >>>>> *Change Request ID*: 7012160 >>>>> *Synopsis*: read SF file in signed jar in streaming mode >>>>> >>>>> >>>>> === *Description* >>>>> ============================================================ >>>>> When a signed jar is verified, its SF file is read into a byte array >>>>> and >>>>> verified against the signature. When there are many files in the jar, >>>>> the SF >>>>> file can be very big. It will be better if the file can be read in >>>>> streaming mode. >>>>> >>>>> *** (#1 of 1): 2011-01-13 12:23:25 GMT+00:00 weijun.wang at oracle.com >>>>> From kumar.x.srinivasan at oracle.com Fri Mar 4 09:38:54 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 04 Mar 2011 17:38:54 +0000 Subject: hg: jdk7/tl/jdk: 7023963: (misc) fix diamond anon instances in the jdk Message-ID: <20110304173918.22C8647CCC@hg.openjdk.java.net> Changeset: c4bd93431a20 Author: ksrini Date: 2011-03-04 09:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c4bd93431a20 7023963: (misc) fix diamond anon instances in the jdk Reviewed-by: alanb, mchung, mcimadamore, dholmes ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipDirectoryStream.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java From jonathan.gibbons at oracle.com Fri Mar 4 11:34:42 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 04 Mar 2011 19:34:42 +0000 Subject: hg: jdk7/tl/langtools: 6966736: javac verbose output is inconsistent Message-ID: <20110304193448.C3C9647CD3@hg.openjdk.java.net> Changeset: 7798e3a5ecf5 Author: jjg Date: 2011-03-04 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7798e3a5ecf5 6966736: javac verbose output is inconsistent Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/util/Log.java From xueming.shen at oracle.com Fri Mar 4 11:37:26 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 04 Mar 2011 19:37:26 +0000 Subject: hg: jdk7/tl/jdk: 7023244: (zipfs) langtools CompileTest fails on read-only file system Message-ID: <20110304193735.B5EEC47CD4@hg.openjdk.java.net> Changeset: 90b7926884a8 Author: sherman Date: 2011-03-04 11:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/90b7926884a8 7023244: (zipfs) langtools CompileTest fails on read-only file system Summary: replaced checkAccess with Files.isWritable() Reviewed-by: alanb ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java From alan.bateman at oracle.com Fri Mar 4 13:29:02 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 04 Mar 2011 21:29:02 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110304212922.C04E647CEC@hg.openjdk.java.net> Changeset: 7b6ad3027f3d Author: alanb Date: 2011-03-04 21:26 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b6ad3027f3d 7023403: (ch) sun.nio.ch.SolarisEventPort.startPoll failed with AssertionError Reviewed-by: forax ! src/solaris/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java Changeset: 28bedf6eba87 Author: alanb Date: 2011-03-04 21:28 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/28bedf6eba87 Merge From jonathan.gibbons at oracle.com Fri Mar 4 19:53:31 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sat, 05 Mar 2011 03:53:31 +0000 Subject: hg: jdk7/tl/langtools: 6866185: Util.getPackageSourcePath should use lastIndexOf not indexOf and related cleanup Message-ID: <20110305035338.E5CC247D31@hg.openjdk.java.net> Changeset: ebf7c13df6c0 Author: jjg Date: 2011-03-04 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ebf7c13df6c0 6866185: Util.getPackageSourcePath should use lastIndexOf not indexOf and related cleanup Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterizedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/SeeTagImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! src/share/classes/com/sun/tools/javadoc/WildcardTypeImpl.java From jonathan.gibbons at oracle.com Fri Mar 4 19:56:25 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sat, 05 Mar 2011 03:56:25 +0000 Subject: hg: jdk7/tl/langtools: 6227454: package.html and overview.html may not be read fully Message-ID: <20110305035627.6D93447D34@hg.openjdk.java.net> Changeset: 4ee7de0684f5 Author: jjg Date: 2011-03-04 19:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4ee7de0684f5 6227454: package.html and overview.html may not be read fully Reviewed-by: bpatel ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties + test/tools/javadoc/6227454/Test.java From jonathan.gibbons at oracle.com Fri Mar 4 19:59:36 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sat, 05 Mar 2011 03:59:36 +0000 Subject: hg: jdk7/tl/langtools: 6964914: javadoc does not output number of warnings using user written doclet Message-ID: <20110305035938.8C67547D37@hg.openjdk.java.net> Changeset: 5e6c661891da Author: jjg Date: 2011-03-04 19:59 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5e6c661891da 6964914: javadoc does not output number of warnings using user written doclet Reviewed-by: bpatel ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! src/share/classes/com/sun/tools/javadoc/Start.java + test/tools/javadoc/6964914/Error.java + test/tools/javadoc/6964914/JavacWarning.java + test/tools/javadoc/6964914/JavadocWarning.java + test/tools/javadoc/6964914/Test.java + test/tools/javadoc/6964914/TestStdDoclet.java + test/tools/javadoc/6964914/TestUserDoclet.java + test/tools/javadoc/T6968833.java From maurizio.cimadamore at oracle.com Mon Mar 7 06:33:07 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 07 Mar 2011 14:33:07 +0000 Subject: hg: jdk7/tl/langtools: 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes Message-ID: <20110307143309.4C84547F01@hg.openjdk.java.net> Changeset: ca32f2986301 Author: mcimadamore Date: 2011-03-07 14:31 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ca32f2986301 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes Summary: Disallow diamond on anonymous innner class creation expression (as per JSR 334's EDR) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/DiamondAndAnonClass.java - test/tools/javac/diags/examples/DiamondInvalidArg.java - test/tools/javac/diags/examples/DiamondInvalidArgs.java ! test/tools/javac/generics/diamond/6996914/T6996914a.java ! test/tools/javac/generics/diamond/6996914/T6996914b.java ! test/tools/javac/generics/diamond/T6939780.java ! test/tools/javac/generics/diamond/T6939780.out ! test/tools/javac/generics/diamond/neg/Neg01.java ! test/tools/javac/generics/diamond/neg/Neg01.out ! test/tools/javac/generics/diamond/neg/Neg02.java ! test/tools/javac/generics/diamond/neg/Neg02.out ! test/tools/javac/generics/diamond/neg/Neg03.java ! test/tools/javac/generics/diamond/neg/Neg03.out ! test/tools/javac/generics/diamond/neg/Neg04.java ! test/tools/javac/generics/diamond/neg/Neg04.out ! test/tools/javac/generics/diamond/neg/Neg05.java ! test/tools/javac/generics/diamond/neg/Neg05.out ! test/tools/javac/generics/diamond/neg/Neg06.java ! test/tools/javac/generics/diamond/neg/Neg06.out ! test/tools/javac/generics/diamond/neg/Neg07.java ! test/tools/javac/generics/diamond/neg/Neg07.out ! test/tools/javac/generics/diamond/neg/Neg08.java ! test/tools/javac/generics/diamond/neg/Neg08.out ! test/tools/javac/generics/diamond/neg/Neg09.java ! test/tools/javac/generics/diamond/neg/Neg09.out ! test/tools/javac/generics/diamond/neg/Neg10.java ! test/tools/javac/generics/diamond/neg/Neg11.java - test/tools/javac/generics/diamond/neg/Neg12.java - test/tools/javac/generics/diamond/neg/Neg12.out ! test/tools/javac/generics/diamond/pos/Pos01.java ! test/tools/javac/generics/diamond/pos/Pos02.java ! test/tools/javac/generics/diamond/pos/Pos03.java ! test/tools/javac/generics/diamond/pos/Pos04.java ! test/tools/javac/generics/diamond/pos/Pos05.java + test/tools/javac/generics/diamond/pos/Pos06.java + test/tools/javac/generics/diamond/pos/Pos07.java - test/tools/javac/multicatch/Neg05.java - test/tools/javac/multicatch/Neg05.out + test/tools/javac/multicatch/Pos09.java From maurizio.cimadamore at oracle.com Mon Mar 7 06:13:24 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 07 Mar 2011 14:13:24 +0000 Subject: hg: jdk7/tl/langtools: 7024568: Very long method resolution causing OOM error Message-ID: <20110307141329.7059F47EFA@hg.openjdk.java.net> Changeset: 74f0c05c51eb Author: mcimadamore Date: 2011-03-07 14:11 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/74f0c05c51eb 7024568: Very long method resolution causing OOM error Summary: Resolve.findMethod scans same receiver type more than once in certain inheritance graphs Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/7024568/T7024568.java + test/tools/javac/7024568/T7024568.out From sean.coffey at oracle.com Mon Mar 7 06:39:41 2011 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Mon, 07 Mar 2011 14:39:41 +0000 Subject: hg: jdk7/tl/jdk: 7025105: TEST_BUG test/com/sun/jndi/ldap/NoWaitForReplyTest.java should be cleaned up Message-ID: <20110307144018.3502747F04@hg.openjdk.java.net> Changeset: 339342f311cc Author: coffeys Date: 2011-03-07 14:43 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/339342f311cc 7025105: TEST_BUG test/com/sun/jndi/ldap/NoWaitForReplyTest.java should be cleaned up Reviewed-by: alanb ! test/com/sun/jndi/ldap/NoWaitForReplyTest.java From sean.mullan at oracle.com Mon Mar 7 10:45:05 2011 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Mon, 07 Mar 2011 18:45:05 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110307184523.DE6FD47F21@hg.openjdk.java.net> Changeset: bc0c58d65e97 Author: mullan Date: 2011-03-07 13:20 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bc0c58d65e97 7022467: SecretKeyFactory doesn't support algorithm "AES" on Windows and Linux Reviewed-by: wetmore, valeriep ! src/share/classes/javax/crypto/SecretKeyFactory.java Changeset: 62b0337d1369 Author: mullan Date: 2011-03-07 13:44 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/62b0337d1369 Merge From rama.pulavarthi at oracle.com Mon Mar 7 11:39:08 2011 From: rama.pulavarthi at oracle.com (Rama Pulavarthi) Date: Mon, 07 Mar 2011 11:39:08 -0800 Subject: Review request for 7020513 : Add com.sun.xml.internal to the "package.access" property in java.security In-Reply-To: <4D680F51.3050906@oracle.com> References: <4D64558A.6040807@oracle.com> <4D64C8EF.2050101@oracle.com> <4D654E60.9070106@oracle.com> <4D67F10B.80506@oracle.com> <4D680F51.3050906@oracle.com> Message-ID: <4D75345C.6070006@oracle.com> Thanks for the review. We had to make additional changes to run the tests. Hopefully this is the final webrev for this issue. Please review this new webrev which also has changes to jdk/test/Makefile to run the tests. http://cr.openjdk.java.net/~ramap/CR7020513-open-webrev/ thanks, Rama Pulavarthi On 02/25/2011 12:21 PM, Sean Mullan wrote: > Looks good to me. > > --Sean > > On 2/25/11 1:12 PM, Rama Pulavarthi wrote: >> Please review this updated webrev that has the patch for JDK 7 repo. >> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxws-7020513-open/webrev/ >> >> >> For background on this issue, this is not a new one. I am trying to port >> the old fixes made in jdk repo as part of earlier jax-ws integrations in >> to Open JDK 6. >> The original issue CR 6592792 was fixed in JDK 6u7 and then ported to >> Open JDK 6. When Open JDK 6 transitioned to Hg, it was committed as >> [1]. As fix for CR 6831313 >> :update jaxws in >> OpenJDK7 to 2.1 plus bug fixes from OpenJDK 6, Only the changes in jaxws >> sources are ported to JDK 7 [2]. But, there are other changes that are >> made in jdk repo required for this fix. >> >> [1] http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/586feec8273d >> >> [2] http://hg.openjdk.java.net/jdk7/build/jaxws/rev/31822b475baa >> >> >> >> thanks, >> Rama Pulavarthi From sean.mullan at oracle.com Mon Mar 7 11:54:31 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 07 Mar 2011 14:54:31 -0500 Subject: Review request for 7020513 : Add com.sun.xml.internal to the "package.access" property in java.security In-Reply-To: <4D75345C.6070006@oracle.com> References: <4D64558A.6040807@oracle.com> <4D64C8EF.2050101@oracle.com> <4D654E60.9070106@oracle.com> <4D67F10B.80506@oracle.com> <4D680F51.3050906@oracle.com> <4D75345C.6070006@oracle.com> Message-ID: <4D7537F7.6090101@oracle.com> I'll defer to Kelly on the Makefile changes :) --Sean On 03/07/2011 02:39 PM, Rama Pulavarthi wrote: > Thanks for the review. We had to make additional changes to run the > tests. Hopefully this is the final webrev for this issue. > > Please review this new webrev which also has changes to > jdk/test/Makefile to run the tests. > http://cr.openjdk.java.net/~ramap/CR7020513-open-webrev/ > > thanks, > Rama Pulavarthi > > On 02/25/2011 12:21 PM, Sean Mullan wrote: >> Looks good to me. >> >> --Sean >> >> On 2/25/11 1:12 PM, Rama Pulavarthi wrote: >>> Please review this updated webrev that has the patch for JDK 7 repo. >>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxws-7020513-open/webrev/ >>> >>> >>> For background on this issue, this is not a new one. I am trying to port >>> the old fixes made in jdk repo as part of earlier jax-ws integrations in >>> to Open JDK 6. >>> The original issue CR 6592792 was fixed in JDK 6u7 and then ported to >>> Open JDK 6. When Open JDK 6 transitioned to Hg, it was committed as >>> [1]. As fix for CR 6831313 >>> :update jaxws in >>> OpenJDK7 to 2.1 plus bug fixes from OpenJDK 6, Only the changes in jaxws >>> sources are ported to JDK 7 [2]. But, there are other changes that are >>> made in jdk repo required for this fix. >>> >>> [1] http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/586feec8273d >>> >>> [2] http://hg.openjdk.java.net/jdk7/build/jaxws/rev/31822b475baa >>> >>> >>> >>> thanks, >>> Rama Pulavarthi > From lana.steuck at oracle.com Mon Mar 7 12:07:51 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 20:07:51 +0000 Subject: hg: jdk7/tl: 4 new changesets Message-ID: <20110307200751.7E5C547F29@hg.openjdk.java.net> Changeset: da55264ff2fb Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/da55264ff2fb 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 5d86d951426a Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/5d86d951426a Merge Changeset: 0f62a65fb666 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/0f62a65fb666 Added tag jdk7-b131 for changeset 5d86d951426a ! .hgtags Changeset: b1fafacc3040 Author: katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/b1fafacc3040 Added tag jdk7-b132 for changeset 0f62a65fb666 ! .hgtags From lana.steuck at oracle.com Mon Mar 7 12:07:54 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 20:07:54 +0000 Subject: hg: jdk7/tl/corba: 4 new changesets Message-ID: <20110307200800.CCA0947F2C@hg.openjdk.java.net> Changeset: a9335b646c1c Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/a9335b646c1c 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 9d6dd2cdfcb9 Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/9d6dd2cdfcb9 Merge Changeset: 1b1e75e8f476 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/1b1e75e8f476 Added tag jdk7-b131 for changeset 9d6dd2cdfcb9 ! .hgtags Changeset: 671fe2e623ff Author: katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/671fe2e623ff Added tag jdk7-b132 for changeset 1b1e75e8f476 ! .hgtags From lana.steuck at oracle.com Mon Mar 7 12:08:00 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 20:08:00 +0000 Subject: hg: jdk7/tl/jaxp: 5 new changesets Message-ID: <20110307200800.DE16147F2F@hg.openjdk.java.net> Changeset: a57220f22751 Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/a57220f22751 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: eab6f27131e4 Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/eab6f27131e4 Merge Changeset: abe04c59a556 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/abe04c59a556 Added tag jdk7-b131 for changeset eab6f27131e4 ! .hgtags Changeset: 8e1148c7911b Author: katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/8e1148c7911b Added tag jdk7-b132 for changeset abe04c59a556 ! .hgtags Changeset: b693ccf23fb7 Author: lana Date: 2011-03-07 11:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/b693ccf23fb7 Merge From lana.steuck at oracle.com Mon Mar 7 12:08:04 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 20:08:04 +0000 Subject: hg: jdk7/tl/jaxws: 4 new changesets Message-ID: <20110307200804.E03B947F32@hg.openjdk.java.net> Changeset: 9e3904866cab Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/9e3904866cab 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 438abc0356cd Author: cl Date: 2011-02-23 15:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/438abc0356cd Merge Changeset: 0e57c3272d37 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/0e57c3272d37 Added tag jdk7-b131 for changeset 438abc0356cd ! .hgtags Changeset: 359d0c8c00a0 Author: katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/359d0c8c00a0 Added tag jdk7-b132 for changeset 0e57c3272d37 ! .hgtags From lana.steuck at oracle.com Mon Mar 7 12:08:06 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 20:08:06 +0000 Subject: hg: jdk7/tl/langtools: 7 new changesets Message-ID: <20110307200820.E106647F35@hg.openjdk.java.net> Changeset: 22ea7d483794 Author: ohair Date: 2011-02-16 13:30 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/22ea7d483794 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 67221b8643b4 Author: cl Date: 2011-02-23 15:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/67221b8643b4 Merge Changeset: 80bbd1da4a72 Author: cl Date: 2011-02-24 15:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/80bbd1da4a72 Added tag jdk7-b131 for changeset 67221b8643b4 ! .hgtags Changeset: de5524670f80 Author: lana Date: 2011-02-21 14:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/de5524670f80 Merge Changeset: e3d011d59a33 Author: lana Date: 2011-02-24 18:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e3d011d59a33 Merge Changeset: e77e98f936e8 Author: katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e77e98f936e8 Added tag jdk7-b132 for changeset e3d011d59a33 ! .hgtags Changeset: b1b898c00b71 Author: lana Date: 2011-03-07 11:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b1b898c00b71 Merge From lana.steuck at oracle.com Mon Mar 7 12:08:09 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 20:08:09 +0000 Subject: hg: jdk7/tl/hotspot: 55 new changesets Message-ID: <20110307200945.EDD4647F39@hg.openjdk.java.net> Changeset: cdef89d821bd Author: ohair Date: 2011-02-16 13:30 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cdef89d821bd 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 0aa3b4908911 Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0aa3b4908911 Merge Changeset: 2015d9b41531 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2015d9b41531 Added tag jdk7-b131 for changeset 0aa3b4908911 ! .hgtags Changeset: f3e07ceeaed9 Author: trims Date: 2011-02-25 11:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f3e07ceeaed9 Added tag hs21-b02 for changeset e9aa2ca89ad6 ! .hgtags Changeset: 7dc5384467e0 Author: coleenp Date: 2011-02-12 10:28 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7dc5384467e0 7022659: errorHandler doesn't compile without precompiled headers Summary: add proper includes in errorHandler.hpp Reviewed-by: phh, kamg ! src/share/vm/utilities/errorReporter.hpp Changeset: c798c277ddd1 Author: brutisso Date: 2011-02-03 20:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c798c277ddd1 7015169: GC Cause not always set Summary: Sometimes the gc cause was not always set. This caused JStat to print the wrong information. Reviewed-by: tonyp, ysr Contributed-by: suenaga.yasumasa at oss.ntt.co.jp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.hpp ! src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp ! src/share/vm/gc_interface/gcCause.cpp ! src/share/vm/gc_interface/gcCause.hpp ! src/share/vm/services/heapDumper.cpp Changeset: c5a923563727 Author: ysr Date: 2011-02-07 22:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c5a923563727 6912621: iCMS: Error: assert(_markBitMap.isMarked(addr + 1),"Missing Printezis bit?") Summary: Fix block_size_if_printezis_bits() so it does not expect the bits, only uses them when available. Fix block_size_no_stall() so it does not stall when the bits are missing such cases, letting the caller deal with zero size returns. Constant pool cache oops do not need to be unparsable or conc_unsafe after their klass pointer is installed. Some cosmetic clean-ups and some assertion checking for conc-usafety which, in the presence of class file redefinition, has no a-priori time boundedness, so all GCs must be able to safely deal with putatively conc-unsafe objects in a stop-world pause. Reviewed-by: jmasa, johnc ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/oops/cpCacheKlass.hpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandleWalk.cpp Changeset: e5383553fd4e Author: stefank Date: 2011-02-08 12:33 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e5383553fd4e 7014851: Remove unused parallel compaction code Summary: Removed. Reviewed-by: jcoomes, brutisso ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/oops/arrayKlassKlass.cpp ! src/share/vm/oops/compiledICHolderKlass.cpp ! src/share/vm/oops/constMethodKlass.cpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/klassKlass.cpp ! src/share/vm/oops/klassPS.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/methodDataKlass.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodKlass.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlassKlass.cpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.pcgc.inline.hpp ! src/share/vm/oops/typeArrayKlass.cpp Changeset: 59e20a452a2a Author: johnc Date: 2011-02-09 09:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/59e20a452a2a 7017008: G1: Turn on compressed oops by default. Summary: Normally compressed oops is enabled when the maximum heap size is under a certain limit, except when G1 is also enabled. Remove this limitation. Also re-enable GCBasher testing with G1 on 64 bit windows in jprt. Reviewed-by: jcoomes, brutisso, tonyp ! make/jprt.properties ! src/share/vm/runtime/arguments.cpp Changeset: 183658a2d0b3 Author: ysr Date: 2011-02-10 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/183658a2d0b3 7018302: newly added assert related to size of constantPoolOop causes secondary assertions or crashes Summary: 6912621 used a raw oop in the newly added assert following an allocation attempt that could result in a GC. Reviewed-by: jmasa ! src/share/vm/oops/constantPoolKlass.cpp Changeset: 55cc33cf55bc Author: stefank Date: 2011-02-11 14:15 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/55cc33cf55bc 7018257: jmm_DumpThreads allocates into permgen Summary: Don't allocate in permgen Reviewed-by: ysr, sla ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/services/management.cpp Changeset: f7702f8c0e25 Author: tonyp Date: 2011-02-14 22:21 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f7702f8c0e25 Merge ! make/jprt.properties ! src/share/vm/services/management.cpp Changeset: 02368ad6c63f Author: trims Date: 2011-02-16 17:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/02368ad6c63f Merge Changeset: 15d6977f04b0 Author: sla Date: 2011-02-10 13:03 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/15d6977f04b0 7017824: Add support for creating 64-bit Visual Studio projects Summary: Updated create.bat and ProjectCreator Reviewed-by: brutisso, stefank, ohair ! make/windows/create.bat ! make/windows/makefiles/compile.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/rules.make - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 ! make/windows/projectfiles/common/Makefile ! src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp ! src/share/tools/ProjectCreator/BuildConfig.java ! src/share/tools/ProjectCreator/DirectoryTree.java ! src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java ! src/share/tools/ProjectCreator/Util.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC6.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java ! src/share/vm/adlc/adlc.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp Changeset: 7aa1f99ca301 Author: coleenp Date: 2011-02-12 10:28 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7aa1f99ca301 7019157: errorHandler doesn't compile with super old gcc without precompiled headers Summary: old gccs don't support precompiled headers so have to supply includes Reviewed-by: phh, kamg ! src/share/vm/utilities/errorReporter.hpp Changeset: 54df4702df97 Author: rottenha Date: 2011-02-14 03:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/54df4702df97 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java Changeset: de14f1eee390 Author: dcubed Date: 2011-02-15 19:00 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/de14f1eee390 6954420: 2/4 jps shows "process information unavailable" sometimes Summary: Make sure the backing store file is flushed in create_sharedmem_resources() and get_user_name_slow() no longer checks the size of the backing store file. Reviewed-by: briand, swamyv, acorn, poonam ! src/os/windows/vm/perfMemory_windows.cpp Changeset: b76d12f4ab2d Author: dholmes Date: 2011-02-14 19:27 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b76d12f4ab2d 7018429: JPRT: Update Makefile to use ALT_JDK_TARGET_IMPORT_PATH for copying JDK Summary: Set JDK_IMPORT_PATH to ALT_JDK_TARGET_IMPORT_PATH if it is defined Reviewed-by: phh, ohair ! make/Makefile ! make/defs.make Changeset: 5415131bc5ab Author: dholmes Date: 2011-02-16 01:42 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5415131bc5ab Merge Changeset: c08677f98289 Author: coleenp Date: 2011-02-16 11:34 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c08677f98289 6840152: JVM crashes when heavyweight monitors are used Summary: Turn off biased locking if !UseFastLocking or UseHeavyMonitors options are requested. Reviewed-by: phh, never, dcubed, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: 3adec115d40d Author: coleenp Date: 2011-02-16 17:12 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3adec115d40d 7019689: Non-dependent name is found in dependent base class although it should be rejected Summary: fix hashtable.hpp to qualify non-dependant name with "this" Reviewed-by: phh, never, poonam Contributed-by: volker.simonis at gmail.com ! src/share/vm/utilities/hashtable.hpp Changeset: a959935a5732 Author: coleenp Date: 2011-02-16 16:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a959935a5732 Merge Changeset: 6e70f1bb7f6f Author: coleenp Date: 2011-02-18 18:26 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6e70f1bb7f6f 7019557: SharedMiscDataSize too small for 64-bit fastdebug JVM Summary: Increase default SharedMiscDataSize Reviewed-by: dcubed, kamg ! src/share/vm/runtime/globals.hpp Changeset: f77b3ec064b0 Author: rottenha Date: 2011-02-21 04:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f77b3ec064b0 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 4f26f535a225 Author: never Date: 2011-01-31 17:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4f26f535a225 6354181: nsk.logging.stress.threads.scmhml001 fails assertion in "src/share/vm/oops/instanceKlass.cpp, 111" Reviewed-by: jrose, acorn ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/classfile/loaderConstraints.cpp ! src/share/vm/classfile/systemDictionary.cpp Changeset: 638119ce7cfd Author: twisti Date: 2011-02-01 03:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/638119ce7cfd 7009309: JSR 292: compiler/6991596/Test6991596.java crashes on fastdebug JDK7/b122 Reviewed-by: kvn, never ! agent/src/share/classes/sun/jvm/hotspot/runtime/StubRoutines.java ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/interpreter_x86.hpp ! src/cpu/x86/vm/interpreter_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/zero/vm/stubRoutines_zero.cpp ! src/cpu/zero/vm/stubRoutines_zero.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fbf3184da15d Author: twisti Date: 2011-02-01 05:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/fbf3184da15d 7012339: JSR 292 crash in G1SATBCardTableModRefBS::write_ref_field_pre_work() Reviewed-by: jrose, never ! src/share/vm/oops/cpCacheOop.cpp Changeset: c52cba2a3359 Author: kvn Date: 2011-02-01 10:27 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c52cba2a3359 7014998: assert(is_T_family(features) == is_niagara(features)) failed: Niagara should be T series Summary: Use substring search instead of compare and convert string to upper case before search. Reviewed-by: never, phh, iveresov ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp Changeset: 194c9fdee631 Author: kvn Date: 2011-02-07 09:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/194c9fdee631 7017240: C2: native memory leak in nsk/regression/b4675027 on windows-x86 in comp mode with G1 Summary: Add ResourceMark into PhaseIdealLoop::build_and_optimize(). Reviewed-by: never ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp Changeset: 3763ca6579b7 Author: kvn Date: 2011-02-07 10:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3763ca6579b7 7013538: Java memory leak with escape analysis Summary: Don't allocate VectorSet iterator on C heap. Reuse resource storage in EA. Reviewed-by: never ! src/share/vm/libadt/vectset.cpp ! src/share/vm/libadt/vectset.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp ! src/share/vm/opto/phase.cpp Changeset: f7de3327c683 Author: kvn Date: 2011-02-07 10:34 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f7de3327c683 7017124: Fix some VM stats to avoid 32-bit overflow Summary: Added new method inc_stat_counter() to increment long statistic values and use atomic long load and store. Reviewed-by: dholmes, jrose, phh, never ! src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.inline.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/opto/indexSet.cpp ! src/share/vm/opto/indexSet.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp Changeset: 336d17dff7cc Author: kvn Date: 2011-02-08 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/336d17dff7cc 7014874: Incorrect COOPs modes on solaris-{sparcv9,amd64} with ParallelGC Summary: Align old gen size down to keep specified heap size. Reviewed-by: ysr ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp Changeset: 72d6c57d0658 Author: iveresov Date: 2011-02-09 16:34 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/72d6c57d0658 7017434: Tiered needs to support reprofiling Summary: Tiered needs to support proper method reprofiling after deopts. Reviewed-by: kvn ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp Changeset: 62a8557e8f36 Author: twisti Date: 2011-02-10 00:47 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/62a8557e8f36 7018277: JSR 292 change test/compiler/6987555/Test6987555.java to new MH syntax Summary: test/compiler/6987555/Test6987555.java currently does not compile because the MH return-type syntax has changed. Reviewed-by: never ! test/compiler/6987555/Test6987555.java Changeset: ab42c7e1cf83 Author: kvn Date: 2011-02-10 14:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ab42c7e1cf83 7017746: Regression : C2 compiler crash due to SIGSEGV in PhaseCFG::schedule_early() Summary: Add TEMP edges (and KILL projections) before duplicated operands are removed in Expand() methods. Reviewed-by: never ! src/cpu/sparc/vm/sparc.ad ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/node.cpp + test/compiler/7017746/Test.java Changeset: bf29934d2f4f Author: kvn Date: 2011-02-10 19:34 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/bf29934d2f4f 7018849: 7017124 fix broke VM build on some platforms Summary: Use atomic load and store in inc_stat_counter() only on SPARC and X86. Reviewed-by: iveresov ! src/share/vm/memory/allocation.inline.hpp Changeset: 173926398291 Author: twisti Date: 2011-02-11 03:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/173926398291 7018673: Zero: 6953144, 6990754 and 7009756 made some changes which broke Zero Reviewed-by: kvn, chrisphi, twisti ! src/os_cpu/linux_zero/vm/atomic_linux_zero.inline.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/oops/methodOop.cpp Changeset: 34457f6ac818 Author: never Date: 2011-02-11 12:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/34457f6ac818 7018506: CTW swallowing OOMs after symbol changes Reviewed-by: kvn, iveresov, coleenp ! src/share/vm/classfile/classLoader.cpp Changeset: 28bf941f445e Author: twisti Date: 2011-02-14 03:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/28bf941f445e 7018378: JSR 292: _bound_int_mh produces wrong result on 64-bit SPARC Reviewed-by: kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp Changeset: 2a57c59eb548 Author: never Date: 2011-02-14 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2a57c59eb548 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit Reviewed-by: acorn, kvn, dsamersoff ! src/os/solaris/vm/os_solaris.cpp Changeset: 850b2295a494 Author: kvn Date: 2011-02-14 14:36 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/850b2295a494 Merge ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 1957c1478794 Author: never Date: 2011-02-15 22:18 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1957c1478794 7019819: bare oop in ciField Reviewed-by: kvn, iveresov ! src/share/vm/ci/ciField.cpp Changeset: 6bbaedb03534 Author: never Date: 2011-02-09 15:02 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6bbaedb03534 7016474: string compare intrinsic improvements Reviewed-by: kvn ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad Changeset: 5841dc1964f0 Author: never Date: 2011-02-22 15:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5841dc1964f0 7021531: lock ordering problems after fix for 6354181 Reviewed-by: kvn, jrose ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp Changeset: a97fd181b813 Author: kvn Date: 2011-02-23 11:18 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a97fd181b813 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/runtime/globals.hpp Changeset: 162b62460264 Author: dholmes Date: 2011-02-24 21:38 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/162b62460264 7021953: Remove flags from globals.hpp inadvertently dragged in by 7016023 Summary: removed erroneous flags Reviewed-by: kvn, dcubed ! src/share/vm/runtime/globals.hpp Changeset: cf16c93393f5 Author: rottenha Date: 2011-02-25 03:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cf16c93393f5 Merge ! src/share/vm/runtime/globals.hpp Changeset: 02f78cfa4656 Author: stefank Date: 2011-02-21 11:26 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/02f78cfa4656 7020992: jmm_DumpThreads should not allocate system object arrays outside the perm gen Summary: Allocate ordinary object arrays Reviewed-by: ysr, never, mchung ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/services/management.cpp Changeset: 8bbefb9743ae Author: tonyp Date: 2011-02-25 10:58 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8bbefb9743ae Merge Changeset: 76b97f73ee91 Author: tonyp Date: 2011-02-25 08:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/76b97f73ee91 Merge Changeset: 5a4223160326 Author: trims Date: 2011-02-25 12:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5a4223160326 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java Changeset: 658d198b2e04 Author: trims Date: 2011-02-25 12:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/658d198b2e04 7022570: Bump the HS21 build number to 03 Summary: Update the HS21 build number to 03 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 0e531ab5ba04 Author: trims Date: 2011-03-01 11:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0e531ab5ba04 Merge Changeset: a8d643a4db47 Author: katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a8d643a4db47 Added tag jdk7-b132 for changeset 0e531ab5ba04 ! .hgtags Changeset: 1b3a350709e4 Author: trims Date: 2011-03-03 15:13 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1b3a350709e4 Added tag hs21-b03 for changeset a8d643a4db47 ! .hgtags From lana.steuck at oracle.com Mon Mar 7 12:10:08 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 20:10:08 +0000 Subject: hg: jdk7/tl/jdk: 49 new changesets Message-ID: <20110307201801.20BA447F3F@hg.openjdk.java.net> Changeset: 0355c60c2da4 Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0355c60c2da4 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 9b2631288894 Author: ohair Date: 2011-02-16 14:33 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b2631288894 7010594: Add /SAFESEH to links on windows to verify safe exceptions Reviewed-by: alanb ! make/common/Defs-windows.gmk ! make/common/shared/Defs-windows.gmk Changeset: 5e09deee1967 Author: andrew Date: 2011-02-23 17:10 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5e09deee1967 7021314: Build should not install javaws man page Summary: Only install javaws.1 when not building OpenJDK Reviewed-by: alanb, ohair ! make/common/Release.gmk Changeset: 8ac52c85f9e9 Author: cl Date: 2011-02-23 15:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8ac52c85f9e9 Merge Changeset: 11c9a066a5a4 Author: cl Date: 2011-02-24 15:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/11c9a066a5a4 Added tag jdk7-b131 for changeset 8ac52c85f9e9 ! .hgtags Changeset: d7de46ec011b Author: jrose Date: 2011-02-11 01:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d7de46ec011b 7013417: JSR 292 needs to support variadic method handle calls Summary: Implement MH.asVarargsCollector, etc., and remove withTypeHandler. Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandle.java ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/InvokeGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/MethodTypeImpl.java ! test/java/dyn/InvokeDynamicPrintArgs.java ! test/java/dyn/JavaDocExamplesTest.java ! test/java/dyn/MethodHandlesTest.java ! test/java/dyn/indify/Indify.java Changeset: c86c60ad8822 Author: jrose Date: 2011-02-11 01:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c86c60ad8822 7012650: implement JSR 292 EG adjustments through January 2010 Summary: misc. EG changes and polishes (excluding 7013417) Reviewed-by: twisti ! src/share/classes/java/dyn/CallSite.java ! src/share/classes/java/dyn/ClassValue.java ! src/share/classes/java/dyn/ConstantCallSite.java ! src/share/classes/java/dyn/InvokeDynamicBootstrapError.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/MethodHandle.java ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/MethodType.java ! src/share/classes/java/dyn/MutableCallSite.java + src/share/classes/java/dyn/SwitchPoint.java - src/share/classes/java/dyn/Switcher.java ! src/share/classes/java/dyn/VolatileCallSite.java ! src/share/classes/java/dyn/WrongMethodTypeException.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/InvokeGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/ToGeneric.java + src/share/classes/sun/dyn/WrapperInstance.java ! test/java/dyn/InvokeGenericTest.java ! test/java/dyn/JavaDocExamplesTest.java ! test/java/dyn/MethodHandlesTest.java Changeset: a2241b109aa1 Author: jrose Date: 2011-02-11 01:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a2241b109aa1 7013730: JSR 292 reflective operations should report errors with standard exception types Summary: remove NoAccessException, replace it by ReflectiveOperationException subtypes; adjust javadoc of exceptions Reviewed-by: twisti ! src/share/classes/java/dyn/CallSite.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/MethodHandles.java - src/share/classes/java/dyn/NoAccessException.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/FilterGeneric.java ! src/share/classes/sun/dyn/FilterOneArgument.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/InvokeGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MemberName.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/MethodHandleNatives.java ! src/share/classes/sun/dyn/SpreadGeneric.java ! src/share/classes/sun/dyn/ToGeneric.java ! src/share/classes/sun/dyn/util/ValueConversions.java ! src/share/classes/sun/dyn/util/VerifyAccess.java ! test/java/dyn/InvokeGenericTest.java ! test/java/dyn/JavaDocExamplesTest.java ! test/java/dyn/MethodHandlesTest.java Changeset: 5e4a41d0fccd Author: jrose Date: 2011-02-15 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5e4a41d0fccd 7016261: JSR 292 MethodType objects should be serializable Summary: Define private writeObject, readObject, and readResolve methods. Also add unit tests. Reviewed-by: twisti ! src/share/classes/java/dyn/MethodType.java + test/java/dyn/MethodTypeTest.java Changeset: 56cbd0504a53 Author: jrose Date: 2011-02-15 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/56cbd0504a53 7014755: JSR 292 member lookup interaction with security manager Summary: add security manager interactions for Lookup methods Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/package-info.java Changeset: 52bcd47b4521 Author: jrose Date: 2011-02-15 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/52bcd47b4521 7016520: JSR 292 rules for polymorphic signature processing must be in package-info Summary: insert rules for bytecode processors to recognize signature polymorphic names Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandle.java Changeset: f6cd84cfed70 Author: trims Date: 2011-02-25 12:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f6cd84cfed70 Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java Changeset: 7905b047a475 Author: prr Date: 2011-02-08 14:24 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7905b047a475 7006865: Regression: Corrupted output when printing images with bit depth of 4 Reviewed-by: bae, jgodinez ! src/windows/classes/sun/awt/windows/WPathGraphics.java ! src/windows/classes/sun/awt/windows/WPrinterJob.java + test/java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java Changeset: d42ce0b309ae Author: bae Date: 2011-02-09 22:24 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d42ce0b309ae 6818960: ImageFetcher ( MediaTracker) Thread leak Reviewed-by: igor, prr ! src/share/classes/sun/awt/image/ImageFetcher.java ! src/share/classes/sun/awt/image/InputStreamImageSource.java Changeset: 37d20456c54c Author: ceisserer Date: 2011-02-09 14:34 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/37d20456c54c 7018387: Xrender pipeline may leak GC's Reviewed-by: prr ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java Changeset: bcf663c292ef Author: bae Date: 2011-02-10 13:44 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bcf663c292ef 6989774: imageio compiler warnings in native code Reviewed-by: igor, prr ! make/sun/jpeg/Makefile ! make/sun/jpeg/reorder-i586 ! make/sun/jpeg/reorder-sparc ! make/sun/jpeg/reorder-sparcv9 ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/awt/image/jpeg/jdmarker.c ! src/share/native/sun/awt/image/jpeg/jmemmgr.c ! src/share/native/sun/awt/image/jpeg/jmemnobs.c ! src/share/native/sun/awt/image/jpeg/jmemsys.h ! src/share/native/sun/awt/image/jpeg/jpegdecoder.c ! src/share/native/sun/awt/image/jpeg/jpeglib.h Changeset: 1881764c4cdf Author: prr Date: 2011-02-11 10:40 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1881764c4cdf 7018364: XShmGetImage with image's > drawable's size causes BadMatch Reviewed-by: art, anthony Contributed-by: linuxhippy at gmail.com ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.h Changeset: b04dafeda706 Author: prr Date: 2011-02-16 15:58 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b04dafeda706 7019441: No lookup cache for internal composite font creation leads to java heap growth Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/FontUtilities.java Changeset: e45f7d50dbc9 Author: bae Date: 2011-02-17 13:42 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e45f7d50dbc9 7018912: [parfait] potential buffer overruns in imageio jpeg Reviewed-by: jgodinez, prr ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c Changeset: 810445ab3099 Author: prr Date: 2011-02-18 09:14 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/810445ab3099 6857592: Getting warning while moving or resizing the frame when component.printAll() is called on local JNI Reviewed-by: bae, flar ! src/windows/native/sun/java2d/windows/GDIBlitLoops.cpp Changeset: 5d8cfcb9a4e8 Author: prr Date: 2011-02-18 09:18 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5d8cfcb9a4e8 7017637: closed/java/awt/font/StyledMetrics/BoldSpace.java failed : Space char should have 0 advance Reviewed-by: igor, jgodinez + test/java/awt/font/StyledMetrics/BoldSpace.java Changeset: 4c6500d20ebf Author: jgodinez Date: 2011-02-04 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4c6500d20ebf 7014796: Regression test java/awt/PrintJob/Text/stringwidth.sh cannot be terminated on Windows. Reviewed-by: prr ! test/java/awt/PrintJob/Text/StringWidth.java Changeset: 33cd780e8989 Author: jgodinez Date: 2011-02-04 11:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/33cd780e8989 6995147: Case needs to be update. ServiceDialogTest.java failed as compilation error. Reviewed-by: prr ! test/javax/print/attribute/ServiceDialogTest.java Changeset: 1d3f3c8d7ed5 Author: jgodinez Date: 2011-02-18 11:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1d3f3c8d7ed5 6722351: sun.print.Win32PrintService.initMedia() is slow Reviewed-by: igor, prr ! src/windows/classes/sun/print/Win32PrintService.java Changeset: 059b56058cad Author: jgodinez Date: 2011-02-18 12:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/059b56058cad Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 1acdde062e92 Author: jgodinez Date: 2011-02-18 13:47 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1acdde062e92 6850806: NPE exception throws in PrintServce.getSupportedAttributeValues Reviewed-by: igor, prr ! src/windows/classes/sun/print/Win32PrintService.java Changeset: fa6547fa57e6 Author: lana Date: 2011-02-21 14:22 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa6547fa57e6 Merge Changeset: 5a6bd7df28b8 Author: lana Date: 2011-02-11 15:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5a6bd7df28b8 Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 14d9e6af8889 Author: andrew Date: 2011-02-15 15:09 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/14d9e6af8889 7017581: missing copyright header in test/sun/java2d/pipe/RegionOps.java Reviewed-by: anthony ! test/sun/java2d/pipe/RegionOps.java Changeset: 7c98b6b4e8a7 Author: dav Date: 2011-02-16 01:12 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7c98b6b4e8a7 6994933: java.awt.Desktop feature is "intermittently" supported on Solaris. Really unexpected behavior. Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XDesktopPeer.java ! src/solaris/native/sun/xawt/awt_Desktop.c Changeset: 41da8f9ea83a Author: lana Date: 2011-02-21 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/41da8f9ea83a Merge Changeset: eeaad0d340b2 Author: peytoia Date: 2011-02-09 18:00 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eeaad0d340b2 7017800: (tz) Support tzdata2011b Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java Changeset: 493a9eeb9bca Author: alexp Date: 2011-02-10 21:36 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/493a9eeb9bca 6993171: JavaTest/JDK7b114 - no help text is shown for interview questions, JavaTest HANGS UP Reviewed-by: rupashka ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JLayer.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/plaf/LayerUI.java ! test/javax/swing/JComponent/6989617/bug6989617.java Changeset: be8045e2d792 Author: lana Date: 2011-02-11 12:14 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/be8045e2d792 Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 82f7b8f6b174 Author: alexp Date: 2011-02-15 16:40 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/82f7b8f6b174 6956842: BasicTreeUI.getPreferredSize(JComp c) is delegated to getPreferredSize(c, true) not (c, false) Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java Changeset: be44bda15fcf Author: okutsu Date: 2011-02-16 16:51 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/be44bda15fcf 6936350: API clarification needed on useDaylightTime() for timezones that have defined usage dates Reviewed-by: peytoia ! src/share/classes/java/util/SimpleTimeZone.java ! src/share/classes/java/util/TimeZone.java + test/java/util/TimeZone/DaylightTimeTest.java Changeset: f326139e7fda Author: malenkov Date: 2011-02-16 18:32 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f326139e7fda 6980124: closed/javax/swing/plaf/synth/SynthPainter/unitTest/UnitTest.java fails Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java Changeset: 888baed5c55b Author: rupashka Date: 2011-02-18 00:16 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/888baed5c55b 7016693: javax/swing/JScrollBar/6542335/bug6542335.java failed on Ubuntu Reviewed-by: alexp ! test/javax/swing/JScrollBar/6542335/bug6542335.java Changeset: db0a6fd0fea9 Author: amenkov Date: 2011-02-18 13:21 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db0a6fd0fea9 6801236: test closed/javax/sound/sampled/FileWriter/WaveBigEndian.java fails Reviewed-by: alexp ! src/share/classes/com/sun/media/sound/services/javax.sound.sampled.spi.FormatConversionProvider Changeset: 64b4226f171f Author: amenkov Date: 2011-02-18 13:27 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/64b4226f171f 7000132: Misplaced description in javax.sound.sampled.AudioSystem.getTargetDataLine Reviewed-by: dav ! src/share/classes/javax/sound/sampled/AudioSystem.java Changeset: a93bb05d00fd Author: alexp Date: 2011-02-18 19:21 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a93bb05d00fd 6474153: LookAndFeel.makeKeyBindings(...) doesn't ignore last element in keyBindingList with odd size Reviewed-by: rupashka ! src/share/classes/javax/swing/LookAndFeel.java + test/javax/swing/LookAndFeel/6474153/bug6474153.java Changeset: 3772a3d90b40 Author: rupashka Date: 2011-02-18 20:09 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3772a3d90b40 6997102: Test case has hard code, so that applet thread threw exception Reviewed-by: alexp ! test/javax/swing/JFileChooser/6798062/bug6798062.html ! test/javax/swing/JFileChooser/6798062/bug6798062.java Changeset: 2cc71008b6db Author: lana Date: 2011-02-21 14:31 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2cc71008b6db Merge ! src/share/classes/javax/swing/JComponent.java Changeset: 3ebece41badd Author: lana Date: 2011-02-21 14:33 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3ebece41badd Merge - test/java/lang/Thread/StopBeforeStart.java Changeset: f046a44e92fd Author: jgodinez Date: 2011-02-24 15:00 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f046a44e92fd 7022228: JPRT failure: RuntimeException in SupportedMedia regression test Reviewed-by: igor, prr ! src/windows/classes/sun/print/Win32PrintService.java Changeset: 094c70388ab0 Author: lana Date: 2011-02-24 18:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/094c70388ab0 Merge - test/java/lang/Thread/StopBeforeStart.java Changeset: 6bbc7a473495 Author: lana Date: 2011-03-01 14:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6bbc7a473495 Merge - test/java/lang/Thread/StopBeforeStart.java Changeset: b88e4395c437 Author: katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b88e4395c437 Added tag jdk7-b132 for changeset 6bbc7a473495 ! .hgtags Changeset: 6d5a992dbac2 Author: lana Date: 2011-03-07 11:36 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6d5a992dbac2 Merge ! make/common/Release.gmk - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java From Kelly.Ohair at oracle.com Mon Mar 7 12:17:54 2011 From: Kelly.Ohair at oracle.com (Kelly O'Hair) Date: Mon, 7 Mar 2011 12:17:54 -0800 Subject: Review request for 7020513 : Add com.sun.xml.internal to the "package.access" property in java.security In-Reply-To: <4D75345C.6070006@oracle.com> References: <4D64558A.6040807@oracle.com> <4D64C8EF.2050101@oracle.com> <4D654E60.9070106@oracle.com> <4D67F10B.80506@oracle.com> <4D680F51.3050906@oracle.com> <4D75345C.6070006@oracle.com> Message-ID: Looks good to me. -kto On Mar 7, 2011, at 11:39 AM, Rama Pulavarthi wrote: > Thanks for the review. We had to make additional changes to run the > tests. Hopefully this is the final webrev for this issue. > > Please review this new webrev which also has changes to > jdk/test/Makefile to run the tests. > http://cr.openjdk.java.net/~ramap/CR7020513-open-webrev/ > > thanks, > Rama Pulavarthi > > On 02/25/2011 12:21 PM, Sean Mullan wrote: >> Looks good to me. >> >> --Sean >> >> On 2/25/11 1:12 PM, Rama Pulavarthi wrote: >>> Please review this updated webrev that has the patch for JDK 7 repo. >>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxws-7020513-open/webrev/ >>> >>> >>> For background on this issue, this is not a new one. I am trying to port >>> the old fixes made in jdk repo as part of earlier jax-ws integrations in >>> to Open JDK 6. >>> The original issue CR 6592792 was fixed in JDK 6u7 and then ported to >>> Open JDK 6. When Open JDK 6 transitioned to Hg, it was committed as >>> [1]. As fix for CR 6831313 >>> :update jaxws in >>> OpenJDK7 to 2.1 plus bug fixes from OpenJDK 6, Only the changes in jaxws >>> sources are ported to JDK 7 [2]. But, there are other changes that are >>> made in jdk repo required for this fix. >>> >>> [1] http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/586feec8273d >>> >>> [2] http://hg.openjdk.java.net/jdk7/build/jaxws/rev/31822b475baa >>> >>> >>> >>> thanks, >>> Rama Pulavarthi > From Alan.Bateman at oracle.com Mon Mar 7 12:22:53 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 07 Mar 2011 20:22:53 +0000 Subject: Review request for 7020513 : Add com.sun.xml.internal to the "package.access" property in java.security In-Reply-To: <4D75345C.6070006@oracle.com> References: <4D64558A.6040807@oracle.com> <4D64C8EF.2050101@oracle.com> <4D654E60.9070106@oracle.com> <4D67F10B.80506@oracle.com> <4D680F51.3050906@oracle.com> <4D75345C.6070006@oracle.com> Message-ID: <4D753E9D.5080801@oracle.com> Rama Pulavarthi wrote: > Thanks for the review. We had to make additional changes to run the > tests. Hopefully this is the final webrev for this issue. > > Please review this new webrev which also has changes to > jdk/test/Makefile to run the tests. > http://cr.openjdk.java.net/~ramap/CR7020513-open-webrev/ > This looks good to me too. -Alan From jonathan.gibbons at oracle.com Mon Mar 7 13:45:30 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 07 Mar 2011 21:45:30 +0000 Subject: hg: jdk7/tl/langtools: 6980021: javac should document @file command line option Message-ID: <20110307214533.AF2B047F4B@hg.openjdk.java.net> Changeset: cb9493a80341 Author: jjg Date: 2011-03-07 13:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/cb9493a80341 6980021: javac should document @file command line option Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/OptionName.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! test/tools/javac/diags/CheckResourceKeys.java From valerie.peng at oracle.com Mon Mar 7 14:32:40 2011 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Mon, 07 Mar 2011 22:32:40 +0000 Subject: hg: jdk7/tl/jdk: 6994008: PKCS11 should support "RSA" and "RSA/ECB/NoPadding" ciphers Message-ID: <20110307223311.6D48E47F55@hg.openjdk.java.net> Changeset: a52da0bada39 Author: valeriep Date: 2011-03-07 14:14 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a52da0bada39 6994008: PKCS11 should support "RSA" and "RSA/ECB/NoPadding" ciphers Summary: Add support for RSA_X_509 mechanism and aliasing of "RSA" to "RSA/ECB/PKCS1Padding". Reviewed-by: wetmore ! src/share/classes/sun/security/pkcs11/P11RSACipher.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java ! test/sun/security/pkcs11/Cipher/TestRSACipher.java ! test/sun/security/pkcs11/Cipher/TestRSACipherWrap.java + test/sun/security/pkcs11/Cipher/TestRawRSACipher.java From kumar.x.srinivasan at oracle.com Mon Mar 7 17:40:28 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Tue, 08 Mar 2011 01:40:28 +0000 Subject: hg: jdk7/tl/langtools: 7021927: javac: regression in performance Message-ID: <20110308014030.3BC9347F64@hg.openjdk.java.net> Changeset: 6970d9fb8e02 Author: ksrini Date: 2011-03-07 17:39 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6970d9fb8e02 7021927: javac: regression in performance Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/util/Options.java ! test/tools/javac/6508981/TestInferBinaryName.java ! test/tools/javac/api/6411310/Test.java ! test/tools/javac/api/T6838467.java ! test/tools/javac/api/T6877206.java + test/tools/javac/file/zip/T6836682.java + test/tools/javac/file/zip/T6865530.java + test/tools/javac/file/zip/Utils.java From alan.bateman at oracle.com Tue Mar 8 02:33:46 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 08 Mar 2011 10:33:46 +0000 Subject: hg: jdk7/tl/jdk: 7025468: Tests using diamond with anonymous inner classes needs to be reverted Message-ID: <20110308103408.67A6047F9A@hg.openjdk.java.net> Changeset: 663c7623b96b Author: alanb Date: 2011-03-08 10:32 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/663c7623b96b 7025468: Tests using diamond with anonymous inner classes needs to be reverted Reviewed-by: dholmes, forax ! test/java/nio/file/DirectoryStream/Basic.java ! test/java/util/PriorityQueue/NoNulls.java From chris.hegarty at oracle.com Tue Mar 8 09:53:48 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 08 Mar 2011 17:53:48 +0000 Subject: hg: jdk7/tl/jdk: 6495521: (doc) ConcurrentSkipListMap links to web page NOT describing SkipList Message-ID: <20110308175358.8C9B547FA9@hg.openjdk.java.net> Changeset: f251e9510e50 Author: dl Date: 2011-03-08 17:52 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f251e9510e50 6495521: (doc) ConcurrentSkipListMap links to web page NOT describing SkipList Summary: update link, and minor implementation comment in Exchanger Reviewed-by: chegar, mduigou ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/Exchanger.java From chris.hegarty at oracle.com Tue Mar 8 10:17:09 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 08 Mar 2011 18:17:09 +0000 Subject: hg: jdk7/tl/jdk: 7023006: Reduce unnecessary thread activity in ForkJoinPool Message-ID: <20110308181718.A917B47FAB@hg.openjdk.java.net> Changeset: 63509149c027 Author: dl Date: 2011-03-08 18:16 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/63509149c027 7023006: Reduce unnecessary thread activity in ForkJoinPool Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java From alexlamsl at gmail.com Tue Mar 8 10:25:42 2011 From: alexlamsl at gmail.com (Alex Lam S.L.) Date: Tue, 8 Mar 2011 18:25:42 +0000 Subject: hg: jdk7/tl/jdk: 7023006: Reduce unnecessary thread activity in ForkJoinPool In-Reply-To: <20110308181718.A917B47FAB@hg.openjdk.java.net> References: <20110308181718.A917B47FAB@hg.openjdk.java.net> Message-ID: Under ForkJoinPool.java: * readers must tolerate null slots. To avoid flailing during should it be "failing" (extraneous "l")? Alex. On Tue, Mar 8, 2011 at 6:17 PM, wrote: > Changeset: 63509149c027 > Author: ? ?dl > Date: ? ? ?2011-03-08 18:16 +0000 > URL: ? ? ? http://hg.openjdk.java.net/jdk7/tl/jdk/rev/63509149c027 > > 7023006: Reduce unnecessary thread activity in ForkJoinPool > Reviewed-by: chegar, dholmes > > ! src/share/classes/java/util/concurrent/ForkJoinPool.java > ! src/share/classes/java/util/concurrent/ForkJoinTask.java > ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java > > From chris.hegarty at oracle.com Tue Mar 8 10:35:10 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 08 Mar 2011 18:35:10 +0000 Subject: hg: jdk7/tl/jdk: 7023006: Reduce unnecessary thread activity in ForkJoinPool In-Reply-To: References: <20110308181718.A917B47FAB@hg.openjdk.java.net> Message-ID: <4D7676DE.7020101@oracle.com> On 03/ 8/11 06:25 PM, Alex Lam S.L. wrote: > Under ForkJoinPool.java: > > * readers must tolerate null slots. To avoid flailing during > > should it be "failing" (extraneous "l")? I actually flagged this in my original review, but put it aside as I guessed it was kinda correct. The array is sized large enough so as not to have it grow continuously as new workers are added. I guess 'flailing' refers to the perceived trashing if this were to happen. -Chris. > > > Alex. > > > > On Tue, Mar 8, 2011 at 6:17 PM, wrote: >> Changeset: 63509149c027 >> Author: dl >> Date: 2011-03-08 18:16 +0000 >> URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/63509149c027 >> >> 7023006: Reduce unnecessary thread activity in ForkJoinPool >> Reviewed-by: chegar, dholmes >> >> ! src/share/classes/java/util/concurrent/ForkJoinPool.java >> ! src/share/classes/java/util/concurrent/ForkJoinTask.java >> ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java >> >> From alexlamsl at gmail.com Tue Mar 8 10:51:54 2011 From: alexlamsl at gmail.com (Alex Lam S.L.) Date: Tue, 8 Mar 2011 18:51:54 +0000 Subject: hg: jdk7/tl/jdk: 7023006: Reduce unnecessary thread activity in ForkJoinPool In-Reply-To: <4D7676DE.7020101@oracle.com> References: <20110308181718.A917B47FAB@hg.openjdk.java.net> <4D7676DE.7020101@oracle.com> Message-ID: Yes, that would make sense indeed. I guess they are referring to the undesirable expansion on the array as opposed to say ArrayIndexOutOfBoundsException. Thanks a lot for the clarification. Alex. On Tue, Mar 8, 2011 at 6:35 PM, Chris Hegarty wrote: > On 03/ 8/11 06:25 PM, Alex Lam S.L. wrote: >> >> Under ForkJoinPool.java: >> >> * readers must tolerate null slots. To avoid flailing during >> >> should it be "failing" (extraneous "l")? > > I actually flagged this in my original review, but put it aside as I guessed > it was kinda correct. The array is sized large enough so as not to have it > grow continuously as new workers are added. I guess 'flailing' refers to the > perceived trashing if this were to happen. > > -Chris. > >> >> >> Alex. >> >> >> >> On Tue, Mar 8, 2011 at 6:17 PM, ?wrote: >>> >>> Changeset: 63509149c027 >>> Author: ? ?dl >>> Date: ? ? ?2011-03-08 18:16 +0000 >>> URL: ? ? ? http://hg.openjdk.java.net/jdk7/tl/jdk/rev/63509149c027 >>> >>> 7023006: Reduce unnecessary thread activity in ForkJoinPool >>> Reviewed-by: chegar, dholmes >>> >>> ! src/share/classes/java/util/concurrent/ForkJoinPool.java >>> ! src/share/classes/java/util/concurrent/ForkJoinTask.java >>> ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java >>> >>> > From mike.duigou at oracle.com Tue Mar 8 15:11:00 2011 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 08 Mar 2011 23:11:00 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110308231121.37F3647FC5@hg.openjdk.java.net> Changeset: d4a34b150597 Author: mduigou Date: 2011-03-08 15:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d4a34b150597 6611830: UUID thread-safety and performance improvements Reviewed-by: mduigou, jjb, alanb, briangoetz, dholmes, peterjones Contributed-by: Daniel Aioanei ! src/share/classes/java/util/UUID.java Changeset: 9b2761fa906b Author: mduigou Date: 2011-03-08 15:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b2761fa906b Merge From maurizio.cimadamore at oracle.com Wed Mar 9 08:48:22 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 09 Mar 2011 16:48:22 +0000 Subject: hg: jdk7/tl/langtools: 7025988: Test test/tools/javac/file/zip/T6836682.java takes too long to complete Message-ID: <20110309164824.E05B547FF4@hg.openjdk.java.net> Changeset: 4fd20d5b7295 Author: mcimadamore Date: 2011-03-09 16:47 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4fd20d5b7295 7025988: Test test/tools/javac/file/zip/T6836682.java takes too long to complete Summary: added @ignore tag to temporarily disable the test Reviewed-by: jjg ! test/tools/javac/file/zip/T6836682.java From david.holmes at oracle.com Wed Mar 9 16:54:42 2011 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Thu, 10 Mar 2011 00:54:42 +0000 Subject: hg: jdk7/tl/jdk: 7022370: Launcher ergonomics should provide simple default implementation Message-ID: <20110310005513.4B86847009@hg.openjdk.java.net> Changeset: 38626f41e458 Author: dholmes Date: 2011-03-09 19:52 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/38626f41e458 7022370: Launcher ergonomics should provide simple default implementation Summary: Use a common, platform independent, implementation unless an architecture specific implementation exists Reviewed-by: ksrini, mchung, ohair, gbenson ! make/java/jli/Makefile ! src/solaris/bin/ergo.c - src/solaris/bin/ergo_sparc.c - src/solaris/bin/ergo_zero.c From kelly.ohair at oracle.com Wed Mar 9 20:35:20 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Thu, 10 Mar 2011 04:35:20 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20110310043559.66A1D47016@hg.openjdk.java.net> Changeset: cfc05963734e Author: ramap Date: 2011-03-09 15:47 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cfc05963734e 7020513: Add com.sun.xml.internal to the "package.access" property in $JAVA_HOME/lib/security/java.security Reviewed-by: ohair, alanb ! src/share/lib/security/java.security ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/Makefile Changeset: 5da9973cdba2 Author: ramap Date: 2011-03-09 15:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5da9973cdba2 6635776: Regression in jaxb tests with JDk6 U4 6741058: Move org/relaxng/datatype sources from jdk to jaxws workspace Reviewed-by: ohair, alanb ! make/com/sun/Makefile - make/com/sun/xml/Makefile ! make/common/internal/Defs-jaxws.gmk - src/share/classes/org/relaxng/datatype/Datatype.java - src/share/classes/org/relaxng/datatype/DatatypeBuilder.java - src/share/classes/org/relaxng/datatype/DatatypeException.java - src/share/classes/org/relaxng/datatype/DatatypeLibrary.java - src/share/classes/org/relaxng/datatype/DatatypeLibraryFactory.java - src/share/classes/org/relaxng/datatype/DatatypeStreamingValidator.java - src/share/classes/org/relaxng/datatype/ValidationContext.java - src/share/classes/org/relaxng/datatype/helpers/DatatypeLibraryLoader.java - src/share/classes/org/relaxng/datatype/helpers/ParameterlessDatatypeBuilder.java - src/share/classes/org/relaxng/datatype/helpers/StreamingValidatorImpl.java Changeset: ea897f472e81 Author: ohair Date: 2011-03-09 18:01 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ea897f472e81 Merge - make/com/sun/xml/Makefile - src/share/classes/org/relaxng/datatype/Datatype.java - src/share/classes/org/relaxng/datatype/DatatypeBuilder.java - src/share/classes/org/relaxng/datatype/DatatypeException.java - src/share/classes/org/relaxng/datatype/DatatypeLibrary.java - src/share/classes/org/relaxng/datatype/DatatypeLibraryFactory.java - src/share/classes/org/relaxng/datatype/DatatypeStreamingValidator.java - src/share/classes/org/relaxng/datatype/ValidationContext.java - src/share/classes/org/relaxng/datatype/helpers/DatatypeLibraryLoader.java - src/share/classes/org/relaxng/datatype/helpers/ParameterlessDatatypeBuilder.java - src/share/classes/org/relaxng/datatype/helpers/StreamingValidatorImpl.java From sundararajan.a at sun.com Wed Mar 9 23:23:45 2011 From: sundararajan.a at sun.com (sundararajan.a at sun.com) Date: Thu, 10 Mar 2011 07:23:45 +0000 Subject: hg: jdk7/tl/jdk: 6960211: JavaScript engine allows creation of interface although methods not available Message-ID: <20110310072354.DDE4A4701C@hg.openjdk.java.net> Changeset: 090c52eebf6a Author: sundar Date: 2011-03-10 12:52 +0530 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/090c52eebf6a 6960211: JavaScript engine allows creation of interface although methods not available Reviewed-by: jjh ! src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java ! src/share/classes/com/sun/script/util/InterfaceImplementor.java + test/javax/script/GetInterfaceTest.java From cneberg at gmail.com Thu Mar 10 09:49:09 2011 From: cneberg at gmail.com (cneberg) Date: Thu, 10 Mar 2011 10:49:09 -0700 Subject: Krb5LoginModule verify TGT? Message-ID: How do I get the com.sun.security.auth.module.Krb5LoginModule login module to verify the TGT against a key in the keytab like is done in krb5_verify_init_creds() which is part of C Krb5 API? Notes on that API http://www.daemon-systems.org/man/krb5_verify_init_creds.3.html Thanks, Christopher -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20110310/63fb5da5/attachment.html From vincent.x.ryan at oracle.com Thu Mar 10 10:37:08 2011 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 10 Mar 2011 18:37:08 +0000 Subject: code review request for CR 7016078: javax.net.ssl.SSLException: Received fatal alert: internal_error starting JDK 7 b126 Message-ID: <4D791A54.4030004@oracle.com> Please review the following webrev which aids interoperability with those PKCS11 implementations that do _not_ wrap EC keys in an OCTET STRING http://cr.openjdk.java.net/~vinnie/7016078/webrev.00/ Thanks. From vincent.x.ryan at oracle.com Thu Mar 10 10:38:23 2011 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Thu, 10 Mar 2011 18:38:23 +0000 Subject: hg: jdk7/tl/jdk: 7016078: javax.net.ssl.SSLException: Received fatal alert: internal_error starting JDK 7 b126 Message-ID: <20110310183851.117344703A@hg.openjdk.java.net> Changeset: 7766633ec80f Author: vinnie Date: 2011-03-10 18:21 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7766633ec80f 7016078: javax.net.ssl.SSLException: Received fatal alert: internal_error starting JDK 7 b126 Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs11/P11Key.java From valerie.peng at oracle.com Thu Mar 10 12:12:14 2011 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Thu, 10 Mar 2011 12:12:14 -0800 Subject: code review request for CR 7016078: javax.net.ssl.SSLException: Received fatal alert: internal_error starting JDK 7 b126 In-Reply-To: <4D791A54.4030004@oracle.com> References: <4D791A54.4030004@oracle.com> Message-ID: <4D79309E.4050403@oracle.com> Looks good to me. Valerie On 03/10/11 10:37 AM, Vincent Ryan wrote: > Please review the following webrev which aids interoperability with > those PKCS11 implementations that do _not_ wrap EC keys in an OCTET STRING > > http://cr.openjdk.java.net/~vinnie/7016078/webrev.00/ > > Thanks. > From bhavesh.patel at sun.com Thu Mar 10 14:39:55 2011 From: bhavesh.patel at sun.com (bhavesh.patel at sun.com) Date: Thu, 10 Mar 2011 22:39:55 +0000 Subject: hg: jdk7/tl/langtools: 6776656: Incorrect number in 'generated' help-doc.html Message-ID: <20110310223957.0430F47047@hg.openjdk.java.net> Changeset: da10d62990a7 Author: bpatel Date: 2011-03-10 14:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/da10d62990a7 6776656: Incorrect number in 'generated' help-doc.html Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties From weijun.wang at oracle.com Thu Mar 10 17:36:29 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 11 Mar 2011 09:36:29 +0800 Subject: Krb5LoginModule verify TGT? In-Reply-To: References: Message-ID: <4D797C9D.1040700@oracle.com> Hi Christopher I'm not familiar with that function. So it reads the user's secret key from a keytab and try to decrypt the TGT to see if it can successfully get the session key inside? This is a part of the Krb5LoginModule login process: it receives a TGT from the KDC and use either the password or keytab (depending on your JAAS config file) to decrypt it. After the commit() method is called, the credentials (containing both the TGT and the session key) are stored as private credentials in the JAAS subject. All public methods we have around Kerberos are APIs defined in JAAS and JGSS. BTW, this mailing list is used to discuss the development of OpenJDK security libraries itself. For API usage or general technical support, it would be better to post a question in the forum. There are much more experts on application programming there. http://forums.oracle.com/forums/forum.jspa?forumID=963 Thanks Max On 03/11/2011 01:49 AM, cneberg wrote: > How do I get the com.sun.security.auth.module.Krb5LoginModule login > module to verify the TGT against a key in the keytab like is done in > krb5_verify_init_creds() which is part of C Krb5 API? > > Notes on that API > > http://www.daemon-systems.org/man/krb5_verify_init_creds.3.html > > Thanks, > Christopher > From cneberg at gmail.com Thu Mar 10 18:19:13 2011 From: cneberg at gmail.com (cneberg) Date: Thu, 10 Mar 2011 19:19:13 -0700 Subject: Krb5LoginModule verify TGT? In-Reply-To: <4D797C9D.1040700@oracle.com> References: <4D797C9D.1040700@oracle.com> Message-ID: >> So it reads the user's secret key from a keytab and try to decrypt the TGT to see if it can successfully get the session key inside No, it uses the user's TGT to obtain a service ticket for a known valid key in the keytab file (any valid service key would work usually HOST/hostname keys, or HTTP/hostname keys are used). When you do a successful kinit (AS request) you are validating that the user and the KDC agree that the user's key was correct, but until you actually try to use the TGT to get a service ticket for a known service you have not validated that the KDC you are talking to is not spoofed. In other words, if this extra step is not performed inside the Krb5LoginModule then it is not secure for validating passwords. Doing this extra step is standard in mod_auth_kerb, pam_krb5, etc. If it is not supported it will require a change in the openjdk code. -Christopher On Thu, Mar 10, 2011 at 6:36 PM, Weijun Wang wrote: > Hi Christopher > > I'm not familiar with that function. So it reads the user's secret key from > a keytab and try to decrypt the TGT to see if it can successfully get the > session key inside? > > This is a part of the Krb5LoginModule login process: it receives a TGT from > the KDC and use either the password or keytab (depending on your JAAS config > file) to decrypt it. After the commit() method is called, the credentials > (containing both the TGT and the session key) are stored as private > credentials in the JAAS subject. > > All public methods we have around Kerberos are APIs defined in JAAS and > JGSS. > > BTW, this mailing list is used to discuss the development of OpenJDK > security libraries itself. For API usage or general technical support, it > would be better to post a question in the forum. There are much more experts > on application programming there. > > http://forums.oracle.com/forums/forum.jspa?forumID=963 > > Thanks > Max > > > > On 03/11/2011 01:49 AM, cneberg wrote: > >> How do I get the com.sun.security.auth.module.Krb5LoginModule login >> module to verify the TGT against a key in the keytab like is done in >> krb5_verify_init_creds() which is part of C Krb5 API? >> >> Notes on that API >> >> http://www.daemon-systems.org/man/krb5_verify_init_creds.3.html >> >> Thanks, >> Christopher >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20110310/77b80d5f/attachment.html From weijun.wang at oracle.com Thu Mar 10 18:43:25 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 11 Mar 2011 10:43:25 +0800 Subject: Krb5LoginModule verify TGT? In-Reply-To: References: <4D797C9D.1040700@oracle.com> Message-ID: <4D798C4D.8060500@oracle.com> Cool. We may look at this, possibly adding more lines into the JAAS login file, something like com.sun.security.jgss.krb5.initiate { com.sun.security.auth.module.Krb5LoginModule required verifyInitCredsService=service/host at REALM verifyInitCredsKeytab=service.ktab }; We've always warned users that simply passing the Krb5LoginModule doesn't mean anything and you should always uses this subject in JGSS but not regarding itself as some kind of authenticity (say, use it in a java policy file). This new function might change that. Thanks Max On 03/11/2011 10:19 AM, cneberg wrote: > >> So it reads the user's secret key from a keytab and try to decrypt > the TGT to see if it can successfully get the session key inside > > No, it uses the user's TGT to obtain a service ticket for a known valid > key in the keytab file (any valid service key would work usually > HOST/hostname keys, or HTTP/hostname keys are used). When you do a > successful kinit (AS request) you are validating that the user and the > KDC agree that the user's key was correct, but until you actually try to > use the TGT to get a service ticket for a known service you have not > validated that the KDC you are talking to is not spoofed. In other > words, if this extra step is not performed inside the Krb5LoginModule > then it is not secure for validating passwords. Doing this extra step > is standard in mod_auth_kerb, pam_krb5, etc. If it is not supported it > will require a change in the openjdk code. > > -Christopher > > On Thu, Mar 10, 2011 at 6:36 PM, Weijun Wang > wrote: > > Hi Christopher > > I'm not familiar with that function. So it reads the user's secret > key from a keytab and try to decrypt the TGT to see if it can > successfully get the session key inside? > > This is a part of the Krb5LoginModule login process: it receives a > TGT from the KDC and use either the password or keytab (depending on > your JAAS config file) to decrypt it. After the commit() method is > called, the credentials (containing both the TGT and the session > key) are stored as private credentials in the JAAS subject. > > All public methods we have around Kerberos are APIs defined in JAAS > and JGSS. > > BTW, this mailing list is used to discuss the development of OpenJDK > security libraries itself. For API usage or general technical > support, it would be better to post a question in the forum. There > are much more experts on application programming there. > > http://forums.oracle.com/forums/forum.jspa?forumID=963 > > Thanks > Max > > > > On 03/11/2011 01:49 AM, cneberg wrote: > > How do I get the com.sun.security.auth.module.Krb5LoginModule login > module to verify the TGT against a key in the keytab like is done in > krb5_verify_init_creds() which is part of C Krb5 API? > > Notes on that API > > http://www.daemon-systems.org/man/krb5_verify_init_creds.3.html > > Thanks, > Christopher > > From chris.hegarty at oracle.com Fri Mar 11 00:47:59 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 11 Mar 2011 08:47:59 +0000 Subject: hg: jdk7/tl/jdk: 7024560: InetAddress.getLocalHost().getHostName() returns localhost for hostnames of length HOST_NAME_MAX Message-ID: <20110311084809.819FB47088@hg.openjdk.java.net> Changeset: ab13f19ee0ff Author: chegar Date: 2011-03-11 08:47 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ab13f19ee0ff 7024560: InetAddress.getLocalHost().getHostName() returns localhost for hostnames of length HOST_NAME_MAX Reviewed-by: alanb, michaelm ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c From chris.hegarty at oracle.com Fri Mar 11 00:58:08 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 11 Mar 2011 08:58:08 +0000 Subject: hg: jdk7/tl/jdk: 7026346: URLConnection.guessContentTypeFromStream does not support UTF-8 and UTF-32 xml streams with BOM Message-ID: <20110311085818.5995947089@hg.openjdk.java.net> Changeset: 107d55ecd50d Author: chegar Date: 2011-03-11 08:57 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/107d55ecd50d 7026346: URLConnection.guessContentTypeFromStream does not support UTF-8 and UTF-32 xml streams with BOM Reviewed-by: alanb Contributed-by: Charles Lee ! src/share/classes/java/net/URLConnection.java ! test/java/net/URLConnection/GetXmlContentType.java From vincent.x.ryan at oracle.com Fri Mar 11 01:57:47 2011 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Fri, 11 Mar 2011 09:57:47 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110311095806.BF4274708C@hg.openjdk.java.net> Changeset: 8ef60faa95d6 Author: vinnie Date: 2011-03-11 09:55 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8ef60faa95d6 6986477: sun/security/mscapi/AccessKeyStore.sh test is failing on jdk7 Reviewed-by: valeriep ! test/sun/security/mscapi/access.policy ! test/sun/security/mscapi/noaccess.policy Changeset: f4d3033b4b65 Author: vinnie Date: 2011-03-11 09:57 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4d3033b4b65 Merge - make/com/sun/xml/Makefile - src/share/classes/org/relaxng/datatype/Datatype.java - src/share/classes/org/relaxng/datatype/DatatypeBuilder.java - src/share/classes/org/relaxng/datatype/DatatypeException.java - src/share/classes/org/relaxng/datatype/DatatypeLibrary.java - src/share/classes/org/relaxng/datatype/DatatypeLibraryFactory.java - src/share/classes/org/relaxng/datatype/DatatypeStreamingValidator.java - src/share/classes/org/relaxng/datatype/ValidationContext.java - src/share/classes/org/relaxng/datatype/helpers/DatatypeLibraryLoader.java - src/share/classes/org/relaxng/datatype/helpers/ParameterlessDatatypeBuilder.java - src/share/classes/org/relaxng/datatype/helpers/StreamingValidatorImpl.java - src/solaris/bin/ergo_sparc.c - src/solaris/bin/ergo_zero.c From chris.hegarty at oracle.com Fri Mar 11 05:50:57 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 11 Mar 2011 13:50:57 +0000 Subject: hg: jdk7/tl/jdk: 7023363: URI("ftp", "[www.abc.com]", "/dir1/dir2", "query", "frag") should throw URISyntaxException Message-ID: <20110311135107.32A1547096@hg.openjdk.java.net> Changeset: 3fdfa11ea5ac Author: chegar Date: 2011-03-11 13:50 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3fdfa11ea5ac 7023363: URI("ftp", "[www.abc.com]", "/dir1/dir2", "query", "frag") should throw URISyntaxException Reviewed-by: alanb, michaelm ! src/share/classes/java/net/URI.java ! test/java/net/URI/Test.java From cneberg at gmail.com Fri Mar 11 08:46:52 2011 From: cneberg at gmail.com (cneberg) Date: Fri, 11 Mar 2011 09:46:52 -0700 Subject: Krb5LoginModule verify TGT? In-Reply-To: <4D798C4D.8060500@oracle.com> References: <4D797C9D.1040700@oracle.com> <4D798C4D.8060500@oracle.com> Message-ID: Yes, thank you that should work nicely. Is this a feature you would consider back porting, even to Oracle's vanilla jdk 1.6 (or even 1.5)? Since the warning against its improper usage isn't in the documentation for the module, it may not have been heard by developers. Documentation for module http://www.docjar.com/docs/api/com/sun/security/auth/module/Krb5LoginModule.html Thanks Christopher On Thu, Mar 10, 2011 at 7:43 PM, Weijun Wang wrote: > Cool. We may look at this, possibly adding more lines into the JAAS login > file, something like > > com.sun.security.jgss.krb5.initiate { > > com.sun.security.auth.module.Krb5LoginModule > required > verifyInitCredsService=service/host at REALM > verifyInitCredsKeytab=service.ktab > }; > > We've always warned users that simply passing the Krb5LoginModule doesn't > mean anything and you should always uses this subject in JGSS but not > regarding itself as some kind of authenticity (say, use it in a java policy > file). This new function might change that. > > Thanks > Max > > > > On 03/11/2011 10:19 AM, cneberg wrote: > >> >> So it reads the user's secret key from a keytab and try to decrypt >> the TGT to see if it can successfully get the session key inside >> >> No, it uses the user's TGT to obtain a service ticket for a known valid >> key in the keytab file (any valid service key would work usually >> HOST/hostname keys, or HTTP/hostname keys are used). When you do a >> successful kinit (AS request) you are validating that the user and the >> KDC agree that the user's key was correct, but until you actually try to >> use the TGT to get a service ticket for a known service you have not >> validated that the KDC you are talking to is not spoofed. In other >> words, if this extra step is not performed inside the Krb5LoginModule >> then it is not secure for validating passwords. Doing this extra step >> is standard in mod_auth_kerb, pam_krb5, etc. If it is not supported it >> will require a change in the openjdk code. >> >> -Christopher >> >> On Thu, Mar 10, 2011 at 6:36 PM, Weijun Wang > > wrote: >> >> Hi Christopher >> >> I'm not familiar with that function. So it reads the user's secret >> key from a keytab and try to decrypt the TGT to see if it can >> successfully get the session key inside? >> >> This is a part of the Krb5LoginModule login process: it receives a >> TGT from the KDC and use either the password or keytab (depending on >> your JAAS config file) to decrypt it. After the commit() method is >> called, the credentials (containing both the TGT and the session >> key) are stored as private credentials in the JAAS subject. >> >> All public methods we have around Kerberos are APIs defined in JAAS >> and JGSS. >> >> BTW, this mailing list is used to discuss the development of OpenJDK >> security libraries itself. For API usage or general technical >> support, it would be better to post a question in the forum. There >> are much more experts on application programming there. >> >> http://forums.oracle.com/forums/forum.jspa?forumID=963 >> >> Thanks >> Max >> >> >> >> On 03/11/2011 01:49 AM, cneberg wrote: >> >> How do I get the com.sun.security.auth.module.Krb5LoginModule login >> module to verify the TGT against a key in the keytab like is done >> in >> krb5_verify_init_creds() which is part of C Krb5 API? >> >> Notes on that API >> >> http://www.daemon-systems.org/man/krb5_verify_init_creds.3.html >> >> Thanks, >> Christopher >> >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20110311/6ded415a/attachment.html From kumar.x.srinivasan at oracle.com Fri Mar 11 10:12:20 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 11 Mar 2011 18:12:20 +0000 Subject: hg: jdk7/tl/jdk: 7023416: (pack200) fix parfait issues Message-ID: <20110311181248.1824A470A0@hg.openjdk.java.net> Changeset: ed87479c96c2 Author: ksrini Date: 2011-03-11 10:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ed87479c96c2 7023416: (pack200) fix parfait issues Reviewed-by: jrose ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp From naoto.sato at oracle.com Fri Mar 11 11:31:54 2011 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Fri, 11 Mar 2011 19:31:54 +0000 Subject: hg: jdk7/tl/jdk: 7023613: (lc) Incorrect string returned by Locale.toString() with non-empty script field Message-ID: <20110311193204.397E3470A7@hg.openjdk.java.net> Changeset: 8216ad5fabb8 Author: naoto Date: 2011-03-11 11:31 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8216ad5fabb8 7023613: (lc) Incorrect string returned by Locale.toString() with non-empty script field Reviewed-by: srl ! src/share/classes/java/util/Locale.java ! test/java/util/Locale/LocaleEnhanceTest.java From valerie.peng at oracle.com Fri Mar 11 14:06:58 2011 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 11 Mar 2011 14:06:58 -0800 Subject: code review request: 6894072: always refresh keytab In-Reply-To: <4CF6195A.6000301@oracle.com> References: <4CF6195A.6000301@oracle.com> Message-ID: <4D7A9D02.40106@oracle.com> Max, Here are some comments for 6894072: always refresh keytab General: 1) Copyright year should be 2011 2) You added new classes under javax.XX packages: Have you filed CCC for them? Krb5LoginModule.java 1) if useKeyTab is set to true in the config, then the if-cond on line 712 will always be false given the ktab assignment on line 692, and then it won't get to the password prompting call on line 713? This seems different than what the comment (line 671-689) described. KerberosKey.java 1) "at needed" probably should be "when needed" or "as needed" 46 * the {@link KeyTab} class, where latest keys can be read at needed. Krb5AcceptCredential.java 1) you changed it to not extending KerberosKey, potential compatibility concern? Krb5Util.java 1) When calling ServiceCreds.getInstance(), your change only checks that kt, kk can't both be null, i.e. line 221. However, at line 237, it uses kk when ktab file is missing. It looks to me that this may leads NPE if the ServiceCreds is constructed w/ a non-null (but non-existent) KeyTab object and null KerberosKey list. 2) when shall ServiceCreds.destroy() be called? For every re-read of KeyTab object, e.g. line 257 3) You replaced the Krb5Util.getKeys(GSSCaller, ...) method w/ ServicesCreds.getServiceCreds(GSSCaller,...). If you don't update JSSE source immediately, people will run into a compilation failure. Perhaps it's better to keep the Krb5Util.getKeys(GSSCaller,...) method and then remove this method together w/ the updated JSSE sources. 4) at line 291 and 299, will the KerberosPrincipal found off the Subject be different from the specified server principal? Seems somewhat strange that we just grab the first one. KrbAsReq.java 1) I can't see any change? Is it included in this webrev by mistake? KrbAsReqBuilder.java 1) Its destroy() method no longer destroys key nor clears password? Is this intentional? If yes, then the method description should be updated. Also, how/when will keys or keytab objects be destroyed and password be cleared? 2) Exception message at line 203 may be better phrased as "Required password not provided". sun.security.krb5.internal.ktab.KeyTab.java 1) your "isReading" flag is static to the KeyTab class but the way you use it seems to suggest that it should be associated w/ each entry of the "map" Hashmap. SharedSecrets.java, SubjectComber.java, Kinit.java, Klist.java, Ktab.java, EncryptionKey.java, Config.java, Krb5ProxyImpl.java, ServerHandshaker.java, KrbAsRep.java, JavaxSecurityAuthKerberosAccessImpl.java, JavaxSecurityAuthKerberosAccess.java => looks ok javax.security.auth.KeyTab.java 1) for its getInstance(File) method, the javadoc specifies that a NPE is thrown if file argument is null. However, the private constructor KeyTab(File) does not throw NPE when null is specified. 2) why not leverage getEncryptionKeys(PrincipalName) for the code of line 148-155? They seem similar enough. Thanks, Valerie * *On 12/01/10 01:46 AM, Weijun Wang wrote: > Hi Valerie > > The webrev is at -- > > http://cr.openjdk.java.net/~weijun/6894072/webrev.00/ > > Changes: > > 1. New javax..KeyTab, updated sun..KeyTab. As the impl note in > javax..KeyTab says: the former is a name with dynamic content, the > latter is a snapshot of a file. > > 2. Now Subject can have private credentials with type KeyTab. Thus the > content of Krb5AcceptCredential is not only keys. Krb5Util defines an > expandable ServiceCreds class for this purpose. > > 3. KrbAsReqBuilder was constructed with password or keys, now with > password or keytab. Kinit and Krb5LoginModule updated accordingly. > > 4. Having parallel defined KerberosKey/KerberosPrincipal and > EncrytionKey/PrincipalName is complicated. Special Unsafe methods are > defined to get EncryptionKey thru a PrincipalName from new > javax..KeyTab. Might look into consolidate data types some day. > > Thanks > Max > > > -------- The Bug -------- > *Change Request ID*: 6894072 > *Synopsis*: always refresh keytab > > Product: java > Category: jgss > Subcategory: krb5plugin > Type: RFE > > === *Description* ====================================== > info from keytab should be refreshed at every security context > establishment in Kerberos. > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20110311/7b4a08ab/attachment.html From joe.darcy at oracle.com Fri Mar 11 14:07:57 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 11 Mar 2011 22:07:57 +0000 Subject: hg: jdk7/tl/langtools: 7026868: Apply specification changes fro 6505047 Message-ID: <20110311220759.55A2A470AD@hg.openjdk.java.net> Changeset: 46ed58a098ad Author: darcy Date: 2011-03-11 14:07 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/46ed58a098ad 7026868: Apply specification changes fro 6505047 Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax/lang/model/element/TypeParameterElement.java From bhavesh.patel at sun.com Fri Mar 11 15:42:12 2011 From: bhavesh.patel at sun.com (bhavesh.patel at sun.com) Date: Fri, 11 Mar 2011 23:42:12 +0000 Subject: hg: jdk7/tl/langtools: 7006178: findbugs high priority issues in new javadoc Message-ID: <20110311234214.530FF470B1@hg.openjdk.java.net> Changeset: b60754fe206d Author: bpatel Date: 2011-03-11 15:39 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b60754fe206d 7006178: findbugs high priority issues in new javadoc Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java + test/com/sun/javadoc/testUseOption/C.java ! test/com/sun/javadoc/testUseOption/TestUseOption.java + test/com/sun/javadoc/testUseOption/UsedInC.java From weijun.wang at oracle.com Sun Mar 13 01:11:09 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Sun, 13 Mar 2011 09:11:09 +0000 Subject: hg: jdk7/tl/jdk: 6990848: JGSS/windows security code native code compiler warnings Message-ID: <20110313091119.96154470F9@hg.openjdk.java.net> Changeset: d901560d70a7 Author: weijun Date: 2011-03-13 17:09 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d901560d70a7 6990848: JGSS/windows security code native code compiler warnings Reviewed-by: valeriep ! src/windows/native/sun/security/krb5/NativeCreds.c From xuelei.fan at oracle.com Mon Mar 14 09:05:26 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 14 Mar 2011 16:05:26 +0000 Subject: hg: jdk7/tl/jdk: 7009794: misleading text in SSLHandshakeException exception message Message-ID: <20110314160556.CF8024713C@hg.openjdk.java.net> Changeset: fa9d7e241517 Author: xuelei Date: 2011-03-14 09:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa9d7e241517 7009794: misleading text in SSLHandshakeException exception message Summary: update the warning message Reviewed-by: weijun ! src/share/classes/sun/security/ssl/ClientHandshaker.java From kumar.x.srinivasan at oracle.com Mon Mar 14 10:38:34 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 14 Mar 2011 17:38:34 +0000 Subject: hg: jdk7/tl/jdk: 7027288: (launcher) remove jkernel test from MiscTests Message-ID: <20110314173843.ED9F547142@hg.openjdk.java.net> Changeset: b708c576f201 Author: ksrini Date: 2011-03-14 10:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b708c576f201 7027288: (launcher) remove jkernel test from MiscTests Reviewed-by: mchung, herrick ! test/tools/launcher/MiscTests.java From vincent.x.ryan at oracle.com Mon Mar 14 11:13:49 2011 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Mon, 14 Mar 2011 18:13:49 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110314181408.5E96747144@hg.openjdk.java.net> Changeset: 5c978a922711 Author: vinnie Date: 2011-03-14 17:50 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5c978a922711 6686215: Some mutables not defensively copied when deserializing java.security.CodeSource & Timestamp objects Reviewed-by: mullan ! src/share/classes/java/security/CodeSource.java ! src/share/classes/java/security/Timestamp.java Changeset: 2e473067520f Author: vinnie Date: 2011-03-14 18:13 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2e473067520f Merge From jonathan.gibbons at oracle.com Mon Mar 14 11:34:00 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 14 Mar 2011 18:34:00 +0000 Subject: hg: jdk7/tl/langtools: 7026414: Types.asElement() returns null for ErrorType Message-ID: <20110314183404.8C8CF47147@hg.openjdk.java.net> Changeset: 307b065ff2af Author: jjg Date: 2011-03-14 11:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/307b065ff2af 7026414: Types.asElement() returns null for ErrorType Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! test/tools/javac/api/6557752/T6557752.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java From jonathan.gibbons at oracle.com Mon Mar 14 11:42:38 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 14 Mar 2011 18:42:38 +0000 Subject: hg: jdk7/tl/langtools: 7010608: the string 'error' should appear in error messages Message-ID: <20110314184240.1B2FF47149@hg.openjdk.java.net> Changeset: e2890b8369f7 Author: jjg Date: 2011-03-14 11:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e2890b8369f7 7010608: the string 'error' should appear in error messages Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! test/tools/apt/Compile/golden.txt ! test/tools/javac/4846262/Test.out ! test/tools/javac/Diagnostics/6769027/T6769027.java + test/tools/javac/Diagnostics/7010608/Test.java ! test/tools/javac/diags/examples/CountError.java ! test/tools/javac/diags/examples/CountErrorPlural.java ! test/tools/javac/diags/examples/IdentifierExpected.java ! test/tools/javac/diags/examples/KindnameClass.java ! test/tools/javac/diags/examples/KindnameConstructor.java ! test/tools/javac/diags/examples/KindnameMethod.java ! test/tools/javac/diags/examples/KindnameVariable.java From joe.darcy at oracle.com Mon Mar 14 11:46:15 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 14 Mar 2011 18:46:15 +0000 Subject: hg: jdk7/tl/jdk: 7027362: Project Coin: warn of throwing InterruptedException in AutoCloseable.close javadoc Message-ID: <20110314184625.2C5724714A@hg.openjdk.java.net> Changeset: 1924a21184a6 Author: darcy Date: 2011-03-14 11:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1924a21184a6 7027362: Project Coin: warn of throwing InterruptedException in AutoCloseable.close javadoc Reviewed-by: jjb ! src/share/classes/java/lang/AutoCloseable.java From jonathan.gibbons at oracle.com Mon Mar 14 11:49:08 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 14 Mar 2011 18:49:08 +0000 Subject: hg: jdk7/tl/langtools: 7026509: Cannot use JavaCompiler to create multiple CompilationTasks for partial compilations Message-ID: <20110314184910.1B7054714B@hg.openjdk.java.net> Changeset: cb119107aeea Author: jjg Date: 2011-03-14 11:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/cb119107aeea 7026509: Cannot use JavaCompiler to create multiple CompilationTasks for partial compilations Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java + test/tools/javac/api/TestJavacTask_Lock.java + test/tools/javac/api/TestJavacTask_Multiple.java + test/tools/javac/api/TestJavacTask_ParseAttrGen.java From mike.duigou at oracle.com Mon Mar 14 14:50:15 2011 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Mon, 14 Mar 2011 21:50:15 +0000 Subject: hg: jdk7/tl/jdk: 7014637: Improve behavior of EnumSet Iterator.remove() Message-ID: <20110314215025.1C1FC47159@hg.openjdk.java.net> Changeset: 7d1b13126574 Author: mduigou Date: 2011-03-14 14:49 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7d1b13126574 7014637: Improve behavior of EnumSet Iterator.remove() Reviewed-by: mduigou, alanb Contributed-by: Neil Richards ! src/share/classes/java/util/JumboEnumSet.java ! src/share/classes/java/util/RegularEnumSet.java + test/java/util/EnumSet/LargeEnumIteratorRemoveResilience.java + test/java/util/EnumSet/SmallEnumIteratorRemoveResilience.java From alan.bateman at oracle.com Tue Mar 15 06:28:08 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 15 Mar 2011 13:28:08 +0000 Subject: hg: jdk7/tl/jdk: 7026376: (dc) DatagramChannel created without specifying protocol family fails to join IPv4 group Message-ID: <20110315132835.E63CC4717B@hg.openjdk.java.net> Changeset: 0ba980dc486e Author: alanb Date: 2011-03-15 13:15 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0ba980dc486e 7026376: (dc) DatagramChannel created without specifying protocol family fails to join IPv4 group Reviewed-by: chegar ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/Net.java ! src/solaris/native/sun/nio/ch/Net.c ! src/windows/native/sun/nio/ch/Net.c ! test/java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java From jonathan.gibbons at oracle.com Tue Mar 15 11:06:11 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 15 Mar 2011 18:06:11 +0000 Subject: hg: jdk7/tl/langtools: 6993311: annotations on packages are not validated Message-ID: <20110315180616.C785647186@hg.openjdk.java.net> Changeset: c9432f06d9bc Author: jjg Date: 2011-03-15 11:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c9432f06d9bc 6993311: annotations on packages are not validated Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/annotations/TestAnnotationPackageInfo.java ! test/tools/javac/annotations/pos/package-info.java ! test/tools/javac/processing/filer/TestPackageInfo.java ! test/tools/javac/processing/filer/foo/bar/package-info.java From jonathan.gibbons at oracle.com Tue Mar 15 11:41:50 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 15 Mar 2011 18:41:50 +0000 Subject: hg: jdk7/tl/langtools: 6987384: -XprintProcessorRoundsInfo message printed with different timing than previous Message-ID: <20110315184152.94EE647188@hg.openjdk.java.net> Changeset: edf03ca74991 Author: jjg Date: 2011-03-15 11:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/edf03ca74991 6987384: -XprintProcessorRoundsInfo message printed with different timing than previous Reviewed-by: darcy ! test/tools/javac/lib/JavacTestingAbstractProcessor.java ! test/tools/javac/processing/6430209/b6341534.java ! test/tools/javac/processing/environment/round/TestContext.java + test/tools/javac/processing/options/testPrintProcessorInfo/Test.java + test/tools/javac/processing/options/testPrintProcessorInfo/Test.out From jonathan.gibbons at oracle.com Tue Mar 15 11:50:36 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 15 Mar 2011 18:50:36 +0000 Subject: hg: jdk7/tl/langtools: 6988079: Errors reported via Messager.printMessage(ERROR, "error message") are not tallied correctly Message-ID: <20110315185038.34A3B4718A@hg.openjdk.java.net> Changeset: 0f9e5b7f0d7e Author: jjg Date: 2011-03-15 11:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0f9e5b7f0d7e 6988079: Errors reported via Messager.printMessage(ERROR,"error message") are not tallied correctly Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! test/tools/javac/processing/6994946/SemanticErrorTest.2.out + test/tools/javac/processing/errors/TestErrorCount.java + test/tools/javac/processing/errors/TestErrorCount.out From cneberg at gmail.com Tue Mar 15 13:25:21 2011 From: cneberg at gmail.com (cneberg) Date: Tue, 15 Mar 2011 14:25:21 -0600 Subject: Fwd: Krb5LoginModule verify TGT? In-Reply-To: References: <4D797C9D.1040700@oracle.com> <4D798C4D.8060500@oracle.com> Message-ID: Forwarding Henry's reply to the list ---------- Forwarded message ---------- From: Henry B. Hotz Sorry I can't post this back to the list directly. My "From" address doesn't match my subscription address. It's probably possible to use the existing, public, stable JGSS API to create a connection to yourself. The "transport" would be simply referencing the tokens from one end/context in the calls made to the other end/context. If such an internal connection could be established, that should be equivalent to verifying the tgt against the keys for the "server" end of the self-connection. Actually doing all that in application code seems really ugly, but it might be nice to put some sample code in the 1.4/1.5/1.6 docs if you don't back-port the new "verify" options. Just to be explicit: I second "cneberg"s request, and your proposed config options to control a built-in capability look good. You could give them default values of "host/`localhost`@DEFAULT-REALM" for verifyInitCredsService, and the default system keytab file for verifyInitCredsKeytab, but then you would need to consider if you want the check on by default. I think I would vote for having the check done by default in 1.7, but left off in 1.6- if it's backported there. Feel free to forward my reply to the list if you want. On Mar 11, 2011, at 8:46 AM, cneberg wrote: > Yes, thank you that should work nicely. Is this a feature you would consider back porting, even to Oracle's vanilla jdk 1.6 (or even 1.5)? Since the warning against its improper usage isn't in the documentation for the module, it may not have been heard by developers. > > Documentation for module > http://www.docjar.com/docs/api/com/sun/security/auth/module/Krb5LoginModule.html > > Thanks > Christopher > > On Thu, Mar 10, 2011 at 7:43 PM, Weijun Wang wrote: > Cool. We may look at this, possibly adding more lines into the JAAS login file, something like > > com.sun.security.jgss.krb5.initiate { > > com.sun.security.auth.module.Krb5LoginModule > required > verifyInitCredsService=service/host at REALM > verifyInitCredsKeytab=service.ktab > }; > > We've always warned users that simply passing the Krb5LoginModule doesn't mean anything and you should always uses this subject in JGSS but not regarding itself as some kind of authenticity (say, use it in a java policy file). This new function might change that. > > Thanks > Max > > > > On 03/11/2011 10:19 AM, cneberg wrote: > >> So it reads the user's secret key from a keytab and try to decrypt > the TGT to see if it can successfully get the session key inside > > No, it uses the user's TGT to obtain a service ticket for a known valid > key in the keytab file (any valid service key would work usually > HOST/hostname keys, or HTTP/hostname keys are used). When you do a > successful kinit (AS request) you are validating that the user and the > KDC agree that the user's key was correct, but until you actually try to > use the TGT to get a service ticket for a known service you have not > validated that the KDC you are talking to is not spoofed. In other > words, if this extra step is not performed inside the Krb5LoginModule > then it is not secure for validating passwords. Doing this extra step > is standard in mod_auth_kerb, pam_krb5, etc. If it is not supported it > will require a change in the openjdk code. > > -Christopher > > On Thu, Mar 10, 2011 at 6:36 PM, Weijun Wang > wrote: > > Hi Christopher > > I'm not familiar with that function. So it reads the user's secret > key from a keytab and try to decrypt the TGT to see if it can > successfully get the session key inside? > > This is a part of the Krb5LoginModule login process: it receives a > TGT from the KDC and use either the password or keytab (depending on > your JAAS config file) to decrypt it. After the commit() method is > called, the credentials (containing both the TGT and the session > key) are stored as private credentials in the JAAS subject. > > All public methods we have around Kerberos are APIs defined in JAAS > and JGSS. > > BTW, this mailing list is used to discuss the development of OpenJDK > security libraries itself. For API usage or general technical > support, it would be better to post a question in the forum. There > are much more experts on application programming there. > > http://forums.oracle.com/forums/forum.jspa?forumID=963 > > Thanks > Max > > > > On 03/11/2011 01:49 AM, cneberg wrote: > > How do I get the com.sun.security.auth.module.Krb5LoginModule login > module to verify the TGT against a key in the keytab like is done in > krb5_verify_init_creds() which is part of C Krb5 API? > > Notes on that API > > http://www.daemon-systems.org/man/krb5_verify_init_creds.3.html > > Thanks, > Christopher > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20110315/97e9c2a5/attachment.html From bhavesh.patel at sun.com Tue Mar 15 14:20:16 2011 From: bhavesh.patel at sun.com (bhavesh.patel at sun.com) Date: Tue, 15 Mar 2011 21:20:16 +0000 Subject: hg: jdk7/tl/langtools: 4743537: Help doesn't say what "All Classes" and other links really mean Message-ID: <20110315212018.E53D847198@hg.openjdk.java.net> Changeset: 480de7832e2f Author: bpatel Date: 2011-03-15 14:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/480de7832e2f 4743537: Help doesn't say what "All Classes" and other links really mean Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties From weijun.wang at oracle.com Tue Mar 15 18:24:39 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 16 Mar 2011 09:24:39 +0800 Subject: code review request: 6894072: always refresh keytab In-Reply-To: <4D7A9D02.40106@oracle.com> References: <4CF6195A.6000301@oracle.com> <4D7A9D02.40106@oracle.com> Message-ID: <4D801157.6070009@oracle.com> Hi Valerie Webrev updated: http://cr.openjdk.java.net/~weijun/6894072/webrev.01 On 03/12/2011 06:06 AM, Valerie (Yu-Ching) Peng wrote: > Max, > > Here are some comments for 6894072: always refresh keytab > General: > 1) Copyright year should be 2011 Updated. > 2) You added new classes under javax.XX packages: Have you filed CCC for > them? Yes, http://ccc.sfbay/6894072 > > Krb5LoginModule.java > 1) if useKeyTab is set to true in the config, then the if-cond on line > 712 will always be false given the ktab assignment on line 692, and then > it won't get to the password prompting call on line 713? This seems > different than what the comment (line 671-689) described. You're correct. "ktab = null;" added into the if check block. Also, the LoginModuleOptions.java regression test is reverted. I don't know why I made this mistake and even updated the test to "hide" it. Maybe there was a time I really wanted the opposite behavior. > > KerberosKey.java > 1) "at needed" probably should be "when needed" or "as needed" > > 46 * the {@link KeyTab} class, where latest keys can be read at needed. OK. > > Krb5AcceptCredential.java > 1) you changed it to not extending KerberosKey, potential compatibility > concern? Not compatibility concern. I only think that now Krb5AcceptCredential can be something else other than simply KerberosKey. If fact, I have no idea why the original Krb5AcceptCredential needs to extends KerberosKey. I didn't see any place where it's used as a KerberosKey. > > Krb5Util.java > 1) When calling ServiceCreds.getInstance(), your change only checks that > kt, kk can't both be null, i.e. line 221. However, at line 237, it uses > kk when ktab file is missing. It looks to me that this may leads NPE if > the ServiceCreds is constructed w/ a non-null (but non-existent) KeyTab > object and null KerberosKey list. When ktab file is missing, ktab is not null, and line 237 will not be executed. > 2) when shall ServiceCreds.destroy() be called? For every re-read of > KeyTab object, e.g. line 257 Yes, it's better to be called here. It's also called in Krb5AcceptCredential.destroy(). Hopefully this method will be called somewhere. > 3) You replaced the Krb5Util.getKeys(GSSCaller, ...) method w/ > ServicesCreds.getServiceCreds(GSSCaller,...). If you don't update JSSE > source immediately, people will run into a compilation failure. Perhaps > it's better to keep the Krb5Util.getKeys(GSSCaller,...) method and then > remove this method together w/ the updated JSSE sources. JSSE codes are also updated in the same changeset. I think such problems only happen when a pre-compiled jar is involved. Or, did I miss anything? > 4) at line 291 and 299, will the KerberosPrincipal found off the Subject > be different from the specified server principal? Seems somewhat strange > that we just grab the first one. Well, if every credentials inside the subject is a result of Krb5LoginModule commit() call, then there should be one KerberosPrincipal there. I am not using the specified server principal because it has a chance to be null. > > KrbAsReq.java > 1) I can't see any change? Is it included in this webrev by mistake? Removed. There was a small whitespace change and "hg diff" automatically added it. > > KrbAsReqBuilder.java > 1) Its destroy() method no longer destroys key nor clears password? Is > this intentional? If yes, then the method description should be updated. > Also, how/when will keys or keytab objects be destroyed and password be > cleared? Fixed. Password is now cleared. There is no need to destroy the keytab. Maybe the sun.security...KeyTab class needs a static destroy method to clean up the map, but I am not sure when to call that. > 2) Exception message at line 203 may be better phrased as "Required > password not provided". Updated. > > sun.security.krb5.internal.ktab.KeyTab.java > 1) your "isReading" flag is static to the KeyTab class but the way you > use it seems to suggest that it should be associated w/ each entry of > the "map" Hashmap. Updated. I gave up the multi-thread tuning. There is a chance an old keytab is returned even if it was updated long time ago. Now I simply made the getInstance0 method synchronized. As long as the keytab file's timestamp does not change, this method should be very fast. During the CCC approval, Dmitry Miltsov did like the "try its best" words in "Implementation of getKeys() method should try its best to get the latest info". Therefore I removed it and change the implementation as well. > > SharedSecrets.java, SubjectComber.java, Kinit.java, Klist.java, > Ktab.java, EncryptionKey.java, Config.java, Krb5ProxyImpl.java, > ServerHandshaker.java, KrbAsRep.java, > JavaxSecurityAuthKerberosAccessImpl.java, > JavaxSecurityAuthKerberosAccess.java > => looks ok > > javax.security.auth.KeyTab.java > 1) for its getInstance(File) method, the javadoc specifies that a NPE is > thrown if file argument is null. However, the private constructor > KeyTab(File) does not throw NPE when null is specified. Fixed. getInstance(file) now throws NPE when file == null. > 2) why not leverage getEncryptionKeys(PrincipalName) for the code of > line 148-155? They seem similar enough. Updated. I've also added @run main/othervm to all jgss/krb5 tests which call System.setProperty(). Thanks Max > > Thanks, > Valerie > * > *On 12/01/10 01:46 AM, Weijun Wang wrote: >> Hi Valerie >> >> The webrev is at -- >> >> http://cr.openjdk.java.net/~weijun/6894072/webrev.00/ >> >> Changes: >> >> 1. New javax..KeyTab, updated sun..KeyTab. As the impl note in >> javax..KeyTab says: the former is a name with dynamic content, the >> latter is a snapshot of a file. >> >> 2. Now Subject can have private credentials with type KeyTab. Thus the >> content of Krb5AcceptCredential is not only keys. Krb5Util defines an >> expandable ServiceCreds class for this purpose. >> >> 3. KrbAsReqBuilder was constructed with password or keys, now with >> password or keytab. Kinit and Krb5LoginModule updated accordingly. >> >> 4. Having parallel defined KerberosKey/KerberosPrincipal and >> EncrytionKey/PrincipalName is complicated. Special Unsafe methods are >> defined to get EncryptionKey thru a PrincipalName from new >> javax..KeyTab. Might look into consolidate data types some day. >> >> Thanks >> Max >> >> >> -------- The Bug -------- >> *Change Request ID*: 6894072 >> *Synopsis*: always refresh keytab >> >> Product: java >> Category: jgss >> Subcategory: krb5plugin >> Type: RFE >> >> === *Description* ====================================== >> info from keytab should be refreshed at every security context >> establishment in Kerberos. >> > > From valerie.peng at oracle.com Tue Mar 15 19:45:30 2011 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Wed, 16 Mar 2011 02:45:30 +0000 Subject: hg: jdk7/tl/jdk: 7001933: Deadlock in java.lang.classloader.getPackage() Message-ID: <20110316024605.25017471AB@hg.openjdk.java.net> Changeset: 4a7da412db38 Author: valeriep Date: 2011-03-15 18:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4a7da412db38 7001933: Deadlock in java.lang.classloader.getPackage() Summary: Modified to not holding the "packages" lock when calling parent CL. Reviewed-by: dholmes, alanb ! src/share/classes/java/lang/ClassLoader.java From xuelei.fan at oracle.com Tue Mar 15 23:09:41 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 16 Mar 2011 06:09:41 +0000 Subject: hg: jdk7/tl/jdk: 7025073: Stricter check on trust anchor makes VerifyCACerts.java test fail Message-ID: <20110316060950.A248B471B3@hg.openjdk.java.net> Changeset: 8b7f0a3a0b2e Author: xuelei Date: 2011-03-15 23:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8b7f0a3a0b2e 7025073: Stricter check on trust anchor makes VerifyCACerts.java test fail Summary: loosen the check for version 1 and 2 X.509 certificate Reviewed-by: mullan, weijun ! src/share/classes/sun/security/provider/certpath/AdaptableX509CertSelector.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java From xuelei.fan at oracle.com Tue Mar 15 23:14:04 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 16 Mar 2011 06:14:04 +0000 Subject: hg: jdk7/tl/jdk: 7022855: Export "PKIX" as the standard algorithm name of KeyManagerFactory Message-ID: <20110316061414.2CFF3471B4@hg.openjdk.java.net> Changeset: e3efbb250c0c Author: xuelei Date: 2011-03-15 23:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e3efbb250c0c 7022855: Export "PKIX" as the standard algorithm name of KeyManagerFactory Summary: export the existing "NewSunX509" algorithm implementation using the standard name "PKIX" Reviewed-by: weijun, wetmore ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/SunJSSE.java ! test/sun/security/ssl/javax/net/ssl/GetInstance.java From david.holmes at oracle.com Wed Mar 16 02:33:20 2011 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 16 Mar 2011 09:33:20 +0000 Subject: hg: jdk7/tl/jdk: 56 new changesets Message-ID: <20110316094242.32B4A471C8@hg.openjdk.java.net> Changeset: eb54e565c491 Author: ohair Date: 2011-02-26 09:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eb54e565c491 7016175: HTML generated from new JavaDoc has tags added from makefile Reviewed-by: jjg ! make/common/shared/Defs-javadoc.gmk ! make/docs/Makefile Changeset: 391a9ef69036 Author: ohair Date: 2011-02-26 10:12 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/391a9ef69036 Merge Changeset: e88c8381eaca Author: ohair Date: 2011-02-26 12:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e88c8381eaca 7022237: Fix use of \" in the new "release" file at the top of the install, windows issues Reviewed-by: ohrstrom ! make/common/Release.gmk Changeset: 123dd69407f9 Author: ohair Date: 2011-02-26 12:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/123dd69407f9 Merge Changeset: ed1d4691da29 Author: ohrstrom Date: 2011-02-28 10:56 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ed1d4691da29 7021753: Add a build times report Summary: Report the build times at end of a jdkroot build. Reviewed-by: ohair ! make/common/shared/Defs-utils.gmk Changeset: f32f0ae3d873 Author: ohair Date: 2011-03-02 12:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f32f0ae3d873 Merge Changeset: 869cba583dd4 Author: ohair Date: 2011-03-02 13:18 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/869cba583dd4 7020815: REBASE should not be required for windows jdk repo builds - can't build with VS 2010 Express Reviewed-by: prr ! make/common/shared/Defs-utils.gmk ! make/common/shared/Sanity.gmk Changeset: e5cd10425e7e Author: ohair Date: 2011-03-03 07:02 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e5cd10425e7e Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java - test/java/lang/Thread/StopBeforeStart.java Changeset: c588355b5bb7 Author: ohair Date: 2011-03-03 15:30 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c588355b5bb7 Merge Changeset: 7931291bc5d3 Author: herrick Date: 2011-03-01 17:09 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7931291bc5d3 7021567: need to create jnlp javadoc for 64 bit bundles. Summary: need to create jnlp javadoc for 64 bit bundles. Reviewed-by: igor, ohair ! make/common/Release.gmk Changeset: c53711f82bfb Author: igor Date: 2011-03-08 14:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c53711f82bfb Merge - test/java/lang/Thread/StopBeforeStart.java Changeset: 5e5f68a01d12 Author: ohair Date: 2011-03-08 16:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5e5f68a01d12 Merge ! make/common/Release.gmk Changeset: 6aeed99af874 Author: mchung Date: 2011-03-09 23:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6aeed99af874 7025631: Remove the modules build support from jdk 7 Reviewed-by: alanb, ohair ! make/Makefile ! make/com/sun/crypto/provider/Makefile ! make/com/sun/java/pack/Makefile ! make/com/sun/java/pack/prop/Makefile ! make/com/sun/jndi/cosnaming/Makefile ! make/com/sun/jndi/dns/Makefile ! make/com/sun/jndi/ldap/Makefile ! make/com/sun/jndi/rmi/registry/Makefile ! make/com/sun/nio/sctp/Makefile ! make/com/sun/org/apache/xml/Makefile ! make/com/sun/rowset/Makefile ! make/com/sun/script/Makefile ! make/com/sun/security/auth/module/Makefile ! make/com/sun/servicetag/Makefile ! make/com/sun/tools/attach/Makefile ! make/common/Defs.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/Sanity.gmk ! make/common/Subdirs.gmk ! make/common/shared/Sanity.gmk ! make/java/awt/Makefile ! make/java/fdlibm/Makefile ! make/java/instrument/Makefile ! make/java/java/Makefile ! make/java/java_crw_demo/Makefile ! make/java/java_hprof_demo/Makefile ! make/java/jli/Makefile ! make/java/jvm/Makefile ! make/java/logging/Makefile ! make/java/main/java/Makefile ! make/java/main/javaw/Makefile ! make/java/management/Makefile ! make/java/net/Makefile ! make/java/nio/Makefile ! make/java/npt/Makefile ! make/java/redist/Makefile ! make/java/redist/fonts/Makefile ! make/java/redist/sajdi/Makefile ! make/java/security/Makefile ! make/java/sql/Makefile ! make/java/text/base/Makefile ! make/java/verify/Makefile ! make/java/zip/Makefile ! make/javax/crypto/Makefile ! make/javax/imageio/Makefile ! make/javax/print/Makefile ! make/javax/sound/Makefile ! make/javax/sound/jsoundalsa/Makefile ! make/javax/sound/jsoundds/Makefile ! make/javax/sql/Makefile ! make/javax/swing/Makefile ! make/javax/swing/plaf/Makefile ! make/jpda/back/Makefile ! make/jpda/transport/Makefile ! make/jpda/transport/shmem/Makefile ! make/jpda/transport/socket/Makefile ! make/jpda/tty/Makefile ! make/launchers/Makefile ! make/mkdemo/jvmti/Makefile ! make/mkdemo/management/Makefile ! make/mksample/dtrace/Makefile ! make/mksample/jmx/jmx-scandir/Makefile ! make/mksample/nbproject/Makefile ! make/mksample/nio/file/Makefile ! make/mksample/nio/multicast/Makefile ! make/mksample/nio/server/Makefile ! make/mksample/scripting/scriptpad/Makefile ! make/mksample/webservices/EbayClient/Makefile ! make/mksample/webservices/EbayServer/Makefile ! make/sun/applet/Makefile ! make/sun/awt/Makefile ! make/sun/cmm/Makefile ! make/sun/cmm/kcms/Makefile ! make/sun/cmm/lcms/Makefile ! make/sun/dcpr/Makefile ! make/sun/font/Makefile ! make/sun/font/t2k/Makefile ! make/sun/headless/Makefile ! make/sun/image/generic/Makefile ! make/sun/image/vis/Makefile ! make/sun/jar/Makefile ! make/sun/javazic/Makefile ! make/sun/jawt/Makefile ! make/sun/jconsole/Makefile ! make/sun/jdbc/Makefile ! make/sun/jdga/Makefile ! make/sun/jpeg/Makefile ! make/sun/launcher/Makefile ! make/sun/management/Makefile ! make/sun/native2ascii/Makefile ! make/sun/net/others/Makefile ! make/sun/net/spi/nameservice/dns/Makefile ! make/sun/nio/cs/Makefile ! make/sun/org/mozilla/javascript/Makefile ! make/sun/pisces/Makefile ! make/sun/rmi/cgi/Makefile ! make/sun/rmi/oldtools/Makefile ! make/sun/rmi/registry/Makefile ! make/sun/rmi/rmi/Makefile ! make/sun/rmi/rmic/Makefile ! make/sun/rmi/rmid/Makefile ! make/sun/security/ec/Makefile ! make/sun/security/jgss/wrapper/Makefile ! make/sun/security/krb5/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile ! make/sun/security/smartcardio/Makefile ! make/sun/security/tools/Makefile ! make/sun/serialver/Makefile ! make/sun/splashscreen/Makefile ! make/sun/text/Makefile ! make/sun/tools/Makefile ! make/sun/tracing/dtrace/Makefile ! make/sun/xawt/Makefile Changeset: 1657b854c956 Author: mchung Date: 2011-03-09 23:59 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1657b854c956 7026228: Remove make/modules and make/common/Modules.gmk Reviewed-by: alanb, ohair - make/common/Modules.gmk - make/java/nio/mxbean/Makefile - make/modules/Makefile - make/modules/bootmodule.roots - make/modules/jdk7.depconfig - make/modules/modules.config - make/modules/modules.group - make/modules/optional.depconfig - make/modules/tools/Makefile - make/modules/tools/build.xml - make/modules/tools/nbproject/project.properties - make/modules/tools/nbproject/project.xml - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java - make/modules/tools/src/com/sun/classanalyzer/Klass.java - make/modules/tools/src/com/sun/classanalyzer/Module.java - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java Changeset: c28f5ac2d5f8 Author: ohair Date: 2011-03-10 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c28f5ac2d5f8 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places Reviewed-by: mchung, herrick ! make/common/shared/Defs-javadoc.gmk ! make/common/shared/Sanity.gmk ! make/docs/Makefile ! make/javax/crypto/Defs-jce.gmk Changeset: 38be400c2608 Author: asaha Date: 2011-03-09 16:44 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/38be400c2608 6908562: JFB Custom Revision Version Build/Makefile changes Reviewed-by: ohair, ksrini, katleman ! make/common/Release.gmk ! make/common/shared/Defs.gmk Changeset: fc680f496eaf Author: asaha Date: 2011-03-14 12:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fc680f496eaf Merge - make/common/Modules.gmk ! make/common/Release.gmk - make/java/nio/mxbean/Makefile - make/modules/Makefile - make/modules/bootmodule.roots - make/modules/jdk7.depconfig - make/modules/modules.config - make/modules/modules.group - make/modules/optional.depconfig - make/modules/tools/Makefile - make/modules/tools/build.xml - make/modules/tools/nbproject/project.properties - make/modules/tools/nbproject/project.xml - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java - make/modules/tools/src/com/sun/classanalyzer/Klass.java - make/modules/tools/src/com/sun/classanalyzer/Module.java - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java Changeset: e947a98ea3c1 Author: cl Date: 2011-03-10 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e947a98ea3c1 Added tag jdk7-b133 for changeset 5e5f68a01d12 ! .hgtags Changeset: 864b669d54d8 Author: lana Date: 2011-02-21 19:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/864b669d54d8 Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java - src/share/demo/zipfs - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: 196d6e802721 Author: prr Date: 2011-02-28 10:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/196d6e802721 7004728: [parfait] potential memory leaks in XRender code Reviewed-by: bae, ceisserer ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: bbbf427a9007 Author: ceisserer Date: 2011-03-01 14:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bbbf427a9007 6974985: Jave2Demo threw exceptions when xrender enabled in OEL5.5 Reviewed-by: prr ! make/sun/awt/mapfile-mawt-vers ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/java2d/x11/XRSurfaceData.c Changeset: 01dcb496946e Author: ceisserer Date: 2011-03-03 16:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/01dcb496946e 7023589: Xrender : NullPointerException in sun.font.XRGlyphCache.freeGlyphs running Java 2D demo Reviewed-by: prr ! src/share/classes/sun/font/StrikeCache.java ! src/solaris/classes/sun/font/XRGlyphCache.java Changeset: f82f0af7de5b Author: prr Date: 2011-03-04 15:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f82f0af7de5b 7023591: Xrender: java2D font demo - text highlighting tab content is black Reviewed-by: flar ! src/share/classes/sun/java2d/pipe/AAShapePipe.java Changeset: 1356371db8c9 Author: lana Date: 2011-03-06 23:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1356371db8c9 Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java - test/java/lang/Thread/StopBeforeStart.java Changeset: df0de56682b7 Author: dcherepanov Date: 2011-02-24 13:01 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df0de56682b7 6996708: The event on the tray icon does not trigger and there is no message printed. Reviewed-by: art, ant ! src/windows/native/sun/windows/awt_TrayIcon.cpp Changeset: 75d8c1200df8 Author: dcherepanov Date: 2011-02-25 13:58 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/75d8c1200df8 7020522: Need to reapply the fix for 6664512 Reviewed-by: art, mchung ! src/share/classes/sun/util/logging/PlatformLogger.java Changeset: c27520009762 Author: dcherepanov Date: 2011-02-25 15:33 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c27520009762 7009114: GTK FileDialog lies about it's Bounds Reviewed-by: art, anthony ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java ! src/solaris/native/sun/awt/gtk2_interface.c ! src/solaris/native/sun/awt/gtk2_interface.h ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.h Changeset: de0f2f8563eb Author: lana Date: 2011-02-26 23:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/de0f2f8563eb Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java - src/share/demo/zipfs - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: 024d040af4a3 Author: anthony Date: 2011-03-01 13:49 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/024d040af4a3 7022488: The security warning may disappear unexpectedly Summary: Initialize the fullScreenExclusiveModeState flag in the AwtWindow constructor Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Window.cpp Changeset: b5e609488bc8 Author: dcherepanov Date: 2011-03-01 15:24 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b5e609488bc8 6826397: PIT : Frame System Menu is not seen for when ALT + Space Bar is pressed in jdk7 b55 build. Reviewed-by: art, ant ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_Frame.h Changeset: 8cd20d3e5448 Author: lana Date: 2011-03-06 20:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8cd20d3e5448 Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java - test/java/lang/Thread/StopBeforeStart.java Changeset: 333bd91466bd Author: lana Date: 2011-03-07 14:44 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/333bd91466bd Merge ! make/sun/xawt/mapfile-vers Changeset: f8fdf9bca159 Author: okutsu Date: 2011-02-22 14:51 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f8fdf9bca159 7010379: fontconfig update for RHEL 6 Reviewed-by: peytoia ! make/sun/awt/Makefile Changeset: 5957bd3cfdc3 Author: okutsu Date: 2011-02-23 14:09 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5957bd3cfdc3 6623219: Font.canDisplayUpTo does not work with supplementary characters Reviewed-by: prr, peytoia ! src/share/classes/java/awt/Font.java + test/java/awt/FontClass/SurrogateTest/SupplementaryCanDisplayUpToTest.java Changeset: 30d112b3b6f2 Author: okutsu Date: 2011-02-23 16:50 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/30d112b3b6f2 6955047: (tz) javadoc for TimeZone.getDisplayName(boolean daylight, int style, Locale locale) is not clear 7021680: (tz) daylight savings time should be daylight saving time Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/TimeZone.java Changeset: ff611d9474cb Author: okutsu Date: 2011-02-24 15:09 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff611d9474cb 7021989: Missing observesDaylightTime override in ZoneInfo Reviewed-by: peytoia ! src/share/classes/sun/util/calendar/ZoneInfo.java Changeset: 01c752a48b51 Author: okutsu Date: 2011-02-24 16:29 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/01c752a48b51 6772689: java.sql.Date.valueOf("2042-10-xx").toString() wrong in some time zones Reviewed-by: peytoia ! src/share/classes/sun/util/calendar/ZoneInfo.java + test/java/util/TimeZone/Bug6772689.java Changeset: e390ce4509c6 Author: alexp Date: 2011-02-28 18:20 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e390ce4509c6 6826074: JScrollPane does not revalidate the component hierarchy after scrolling Reviewed-by: anthony ! src/share/classes/javax/swing/DefaultDesktopManager.java ! src/share/classes/javax/swing/JViewport.java Changeset: 1ef5b85d41f2 Author: amenkov Date: 2011-02-28 18:36 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1ef5b85d41f2 7013521: AudioSystem.write for AIFF files closes source audio stream Reviewed-by: dav ! src/share/classes/com/sun/media/sound/AiffFileWriter.java ! src/share/classes/com/sun/media/sound/AuFileWriter.java ! src/share/classes/com/sun/media/sound/SunFileWriter.java ! src/share/classes/com/sun/media/sound/WaveFileWriter.java + test/javax/sound/sampled/FileWriter/WriterCloseInput.java Changeset: d4e3c1f2177a Author: amenkov Date: 2011-03-03 15:41 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d4e3c1f2177a 6938426: Concurrency bug in ALAW encoder causes random bursts of static/noise in output. Reviewed-by: stayer ! src/share/classes/com/sun/media/sound/AlawCodec.java + test/javax/sound/sampled/FileWriter/AlawEncoderSync.java Changeset: d3df100509ad Author: amenkov Date: 2011-03-03 15:45 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3df100509ad 6801206: SoundTestSuite: test050 fails Reviewed-by: stayer ! src/share/classes/com/sun/media/sound/DirectAudioDevice.java + test/javax/sound/sampled/Clip/ClipSetPos.java Changeset: 4e732aba71bf Author: amenkov Date: 2011-03-03 15:57 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4e732aba71bf 6660470: RealTimeSequencer incorrectly opens (implicitly) synthesizer Reviewed-by: stayer ! src/share/classes/com/sun/media/sound/RealTimeSequencer.java ! src/share/classes/javax/sound/midi/MidiSystem.java + test/javax/sound/midi/Sequencer/SequencerImplicitSynthOpen.java Changeset: 67d4b2e2e5b1 Author: amenkov Date: 2011-03-03 16:40 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/67d4b2e2e5b1 6835393: MidiSystem fails to correctly read Sequence with SMPTE division Reviewed-by: stayer ! src/share/classes/com/sun/media/sound/StandardMidiFileReader.java + test/javax/sound/midi/File/SMPTESequence.java Changeset: 52bdb4237d5e Author: rupashka Date: 2011-03-03 17:47 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/52bdb4237d5e 6796710: Html content in JEditorPane is overlapping on swing components while resizing the application. Reviewed-by: alexp ! src/share/classes/javax/swing/text/html/CSSBorder.java + test/javax/swing/regtesthelpers/Util.java + test/javax/swing/text/CSSBorder/6796710/bug6796710.java Changeset: 7dfcf271b73b Author: alexp Date: 2011-03-03 18:23 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7dfcf271b73b 6653511: JComponent.safelyGetGraphics() may sometimes return null Reviewed-by: rupashka ! src/share/classes/javax/swing/JComponent.java Changeset: e4ca9353150a Author: alexp Date: 2011-03-03 18:27 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e4ca9353150a Merge Changeset: dc34da6a3fa1 Author: rupashka Date: 2011-03-05 18:27 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dc34da6a3fa1 6760148: Certain fonts are not correctly soft wrapped when using JTextComponent.print() Reviewed-by: peterz ! src/share/classes/javax/swing/text/Utilities.java ! src/share/classes/javax/swing/text/WrappedPlainView.java Changeset: ca0f223b4be7 Author: lana Date: 2011-03-05 20:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ca0f223b4be7 Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java ! src/share/classes/javax/swing/JComponent.java - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java - src/share/demo/zipfs - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc - test/java/lang/Thread/StopBeforeStart.java - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: e3a69b9be2b5 Author: lana Date: 2011-03-07 14:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e3a69b9be2b5 Merge Changeset: 0b6d82c838d4 Author: lana Date: 2011-03-07 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b6d82c838d4 Merge - src/share/classes/sun/misc/BootClassLoaderHook.java - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java - test/sun/misc/BootClassLoaderHook/TestHook.java Changeset: c0bf0f19897a Author: lana Date: 2011-03-10 19:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c0bf0f19897a Merge Changeset: c975c4fbca20 Author: lana Date: 2011-03-10 20:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c975c4fbca20 Merge ! make/common/Release.gmk - src/share/classes/sun/misc/BootClassLoaderHook.java - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java - test/sun/misc/BootClassLoaderHook/TestHook.java Changeset: b1215d1f015b Author: ohair Date: 2011-03-15 15:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b1215d1f015b Merge - make/common/Modules.gmk ! make/common/Release.gmk - make/java/nio/mxbean/Makefile - make/modules/Makefile - make/modules/bootmodule.roots - make/modules/jdk7.depconfig - make/modules/modules.config - make/modules/modules.group - make/modules/optional.depconfig - make/modules/tools/Makefile - make/modules/tools/build.xml - make/modules/tools/nbproject/project.properties - make/modules/tools/nbproject/project.xml - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java - make/modules/tools/src/com/sun/classanalyzer/Klass.java - make/modules/tools/src/com/sun/classanalyzer/Module.java - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java ! make/sun/awt/Makefile Changeset: f82a1434bf63 Author: dholmes Date: 2011-03-15 19:52 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f82a1434bf63 7027897: Build support for client-VM only configurations Summary: Support builds for which only the client VM is required and/or available Reviewed-by: ohair, andrew ! make/common/Defs.gmk ! make/common/shared/Sanity.gmk ! make/java/jvm/Makefile ! make/java/redist/Makefile Changeset: d7034302bc24 Author: dholmes Date: 2011-03-15 20:00 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d7034302bc24 Merge ! make/common/Defs.gmk - make/common/Modules.gmk ! make/common/shared/Sanity.gmk ! make/java/jli/Makefile ! make/java/jvm/Makefile - make/java/nio/mxbean/Makefile ! make/java/redist/Makefile - make/modules/Makefile - make/modules/bootmodule.roots - make/modules/jdk7.depconfig - make/modules/modules.config - make/modules/modules.group - make/modules/optional.depconfig - make/modules/tools/Makefile - make/modules/tools/build.xml - make/modules/tools/nbproject/project.properties - make/modules/tools/nbproject/project.xml - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java - make/modules/tools/src/com/sun/classanalyzer/Klass.java - make/modules/tools/src/com/sun/classanalyzer/Module.java - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java Changeset: 3a22998bc3c7 Author: dholmes Date: 2011-03-16 05:29 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3a22998bc3c7 Merge From David.Holmes at oracle.com Wed Mar 16 02:47:21 2011 From: David.Holmes at oracle.com (David Holmes) Date: Wed, 16 Mar 2011 19:47:21 +1000 Subject: hg: jdk7/tl/jdk: 56 new changesets In-Reply-To: <20110316094242.32B4A471C8@hg.openjdk.java.net> References: <20110316094242.32B4A471C8@hg.openjdk.java.net> Message-ID: <4D808729.3090704@oracle.com> Just a heads up that this changeset includes a pre-integration with changes from jdk7/build/jdk. Those changes needed to be merged with my changset so that the integrators wouldn't have to handle a larger merge down the track. The changes would have been pulled down later this week. David david.holmes at oracle.com said the following on 03/16/11 19:33: > Changeset: eb54e565c491 > Author: ohair > Date: 2011-02-26 09:45 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eb54e565c491 > > 7016175: HTML generated from new JavaDoc has tags added from makefile > Reviewed-by: jjg > > ! make/common/shared/Defs-javadoc.gmk > ! make/docs/Makefile > > Changeset: 391a9ef69036 > Author: ohair > Date: 2011-02-26 10:12 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/391a9ef69036 > > Merge > > > Changeset: e88c8381eaca > Author: ohair > Date: 2011-02-26 12:11 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e88c8381eaca > > 7022237: Fix use of \" in the new "release" file at the top of the install, windows issues > Reviewed-by: ohrstrom > > ! make/common/Release.gmk > > Changeset: 123dd69407f9 > Author: ohair > Date: 2011-02-26 12:42 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/123dd69407f9 > > Merge > > > Changeset: ed1d4691da29 > Author: ohrstrom > Date: 2011-02-28 10:56 +0100 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ed1d4691da29 > > 7021753: Add a build times report > Summary: Report the build times at end of a jdkroot build. > Reviewed-by: ohair > > ! make/common/shared/Defs-utils.gmk > > Changeset: f32f0ae3d873 > Author: ohair > Date: 2011-03-02 12:09 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f32f0ae3d873 > > Merge > > > Changeset: 869cba583dd4 > Author: ohair > Date: 2011-03-02 13:18 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/869cba583dd4 > > 7020815: REBASE should not be required for windows jdk repo builds - can't build with VS 2010 Express > Reviewed-by: prr > > ! make/common/shared/Defs-utils.gmk > ! make/common/shared/Sanity.gmk > > Changeset: e5cd10425e7e > Author: ohair > Date: 2011-03-03 07:02 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e5cd10425e7e > > Merge > > - src/share/classes/java/dyn/NoAccessException.java > - src/share/classes/java/dyn/Switcher.java > - test/java/lang/Thread/StopBeforeStart.java > > Changeset: c588355b5bb7 > Author: ohair > Date: 2011-03-03 15:30 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c588355b5bb7 > > Merge > > > Changeset: 7931291bc5d3 > Author: herrick > Date: 2011-03-01 17:09 -0500 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7931291bc5d3 > > 7021567: need to create jnlp javadoc for 64 bit bundles. > Summary: need to create jnlp javadoc for 64 bit bundles. > Reviewed-by: igor, ohair > > ! make/common/Release.gmk > > Changeset: c53711f82bfb > Author: igor > Date: 2011-03-08 14:26 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c53711f82bfb > > Merge > > - test/java/lang/Thread/StopBeforeStart.java > > Changeset: 5e5f68a01d12 > Author: ohair > Date: 2011-03-08 16:05 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5e5f68a01d12 > > Merge > > ! make/common/Release.gmk > > Changeset: 6aeed99af874 > Author: mchung > Date: 2011-03-09 23:11 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6aeed99af874 > > 7025631: Remove the modules build support from jdk 7 > Reviewed-by: alanb, ohair > > ! make/Makefile > ! make/com/sun/crypto/provider/Makefile > ! make/com/sun/java/pack/Makefile > ! make/com/sun/java/pack/prop/Makefile > ! make/com/sun/jndi/cosnaming/Makefile > ! make/com/sun/jndi/dns/Makefile > ! make/com/sun/jndi/ldap/Makefile > ! make/com/sun/jndi/rmi/registry/Makefile > ! make/com/sun/nio/sctp/Makefile > ! make/com/sun/org/apache/xml/Makefile > ! make/com/sun/rowset/Makefile > ! make/com/sun/script/Makefile > ! make/com/sun/security/auth/module/Makefile > ! make/com/sun/servicetag/Makefile > ! make/com/sun/tools/attach/Makefile > ! make/common/Defs.gmk > ! make/common/Demo.gmk > ! make/common/Library.gmk > ! make/common/Program.gmk > ! make/common/Release.gmk > ! make/common/Sanity.gmk > ! make/common/Subdirs.gmk > ! make/common/shared/Sanity.gmk > ! make/java/awt/Makefile > ! make/java/fdlibm/Makefile > ! make/java/instrument/Makefile > ! make/java/java/Makefile > ! make/java/java_crw_demo/Makefile > ! make/java/java_hprof_demo/Makefile > ! make/java/jli/Makefile > ! make/java/jvm/Makefile > ! make/java/logging/Makefile > ! make/java/main/java/Makefile > ! make/java/main/javaw/Makefile > ! make/java/management/Makefile > ! make/java/net/Makefile > ! make/java/nio/Makefile > ! make/java/npt/Makefile > ! make/java/redist/Makefile > ! make/java/redist/fonts/Makefile > ! make/java/redist/sajdi/Makefile > ! make/java/security/Makefile > ! make/java/sql/Makefile > ! make/java/text/base/Makefile > ! make/java/verify/Makefile > ! make/java/zip/Makefile > ! make/javax/crypto/Makefile > ! make/javax/imageio/Makefile > ! make/javax/print/Makefile > ! make/javax/sound/Makefile > ! make/javax/sound/jsoundalsa/Makefile > ! make/javax/sound/jsoundds/Makefile > ! make/javax/sql/Makefile > ! make/javax/swing/Makefile > ! make/javax/swing/plaf/Makefile > ! make/jpda/back/Makefile > ! make/jpda/transport/Makefile > ! make/jpda/transport/shmem/Makefile > ! make/jpda/transport/socket/Makefile > ! make/jpda/tty/Makefile > ! make/launchers/Makefile > ! make/mkdemo/jvmti/Makefile > ! make/mkdemo/management/Makefile > ! make/mksample/dtrace/Makefile > ! make/mksample/jmx/jmx-scandir/Makefile > ! make/mksample/nbproject/Makefile > ! make/mksample/nio/file/Makefile > ! make/mksample/nio/multicast/Makefile > ! make/mksample/nio/server/Makefile > ! make/mksample/scripting/scriptpad/Makefile > ! make/mksample/webservices/EbayClient/Makefile > ! make/mksample/webservices/EbayServer/Makefile > ! make/sun/applet/Makefile > ! make/sun/awt/Makefile > ! make/sun/cmm/Makefile > ! make/sun/cmm/kcms/Makefile > ! make/sun/cmm/lcms/Makefile > ! make/sun/dcpr/Makefile > ! make/sun/font/Makefile > ! make/sun/font/t2k/Makefile > ! make/sun/headless/Makefile > ! make/sun/image/generic/Makefile > ! make/sun/image/vis/Makefile > ! make/sun/jar/Makefile > ! make/sun/javazic/Makefile > ! make/sun/jawt/Makefile > ! make/sun/jconsole/Makefile > ! make/sun/jdbc/Makefile > ! make/sun/jdga/Makefile > ! make/sun/jpeg/Makefile > ! make/sun/launcher/Makefile > ! make/sun/management/Makefile > ! make/sun/native2ascii/Makefile > ! make/sun/net/others/Makefile > ! make/sun/net/spi/nameservice/dns/Makefile > ! make/sun/nio/cs/Makefile > ! make/sun/org/mozilla/javascript/Makefile > ! make/sun/pisces/Makefile > ! make/sun/rmi/cgi/Makefile > ! make/sun/rmi/oldtools/Makefile > ! make/sun/rmi/registry/Makefile > ! make/sun/rmi/rmi/Makefile > ! make/sun/rmi/rmic/Makefile > ! make/sun/rmi/rmid/Makefile > ! make/sun/security/ec/Makefile > ! make/sun/security/jgss/wrapper/Makefile > ! make/sun/security/krb5/Makefile > ! make/sun/security/mscapi/Makefile > ! make/sun/security/pkcs11/Makefile > ! make/sun/security/smartcardio/Makefile > ! make/sun/security/tools/Makefile > ! make/sun/serialver/Makefile > ! make/sun/splashscreen/Makefile > ! make/sun/text/Makefile > ! make/sun/tools/Makefile > ! make/sun/tracing/dtrace/Makefile > ! make/sun/xawt/Makefile > > Changeset: 1657b854c956 > Author: mchung > Date: 2011-03-09 23:59 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1657b854c956 > > 7026228: Remove make/modules and make/common/Modules.gmk > Reviewed-by: alanb, ohair > > - make/common/Modules.gmk > - make/java/nio/mxbean/Makefile > - make/modules/Makefile > - make/modules/bootmodule.roots > - make/modules/jdk7.depconfig > - make/modules/modules.config > - make/modules/modules.group > - make/modules/optional.depconfig > - make/modules/tools/Makefile > - make/modules/tools/build.xml > - make/modules/tools/nbproject/project.properties > - make/modules/tools/nbproject/project.xml > - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java > - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java > - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java > - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java > - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java > - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java > - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java > - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java > - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java > - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java > - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java > - make/modules/tools/src/com/sun/classanalyzer/Klass.java > - make/modules/tools/src/com/sun/classanalyzer/Module.java > - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java > - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java > - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java > - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java > > Changeset: c28f5ac2d5f8 > Author: ohair > Date: 2011-03-10 14:48 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c28f5ac2d5f8 > > 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places > Reviewed-by: mchung, herrick > > ! make/common/shared/Defs-javadoc.gmk > ! make/common/shared/Sanity.gmk > ! make/docs/Makefile > ! make/javax/crypto/Defs-jce.gmk > > Changeset: 38be400c2608 > Author: asaha > Date: 2011-03-09 16:44 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/38be400c2608 > > 6908562: JFB Custom Revision Version Build/Makefile changes > Reviewed-by: ohair, ksrini, katleman > > ! make/common/Release.gmk > ! make/common/shared/Defs.gmk > > Changeset: fc680f496eaf > Author: asaha > Date: 2011-03-14 12:01 -0700 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fc680f496eaf > > Merge > > - make/common/Modules.gmk > ! make/common/Release.gmk > - make/java/nio/mxbean/Makefile > - make/modules/Makefile > - make/modules/bootmodule.roots > - make/modules/jdk7.depconfig > - make/modules/modules.config > - make/modules/modules.group > - make/modules/optional.depconfig > - make/modules/tools/Makefile > - make/modules/tools/build.xml > - make/modules/tools/nbproject/project.properties > - make/modules/tools/nbproject/project.xml > - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java > - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java > - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java > - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java > - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java > - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java > - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java > - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java > - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java > - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java > - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java > - make/modules/tools/src/com/sun/classanalyzer/Klass.java > - make/modules/tools/src/com/sun/classanalyzer/Module.java > - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java > - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java > - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java > - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java > > Changeset: e947a98ea3c1 > Author: cl > Date: 2011-03-10 17:11 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e947a98ea3c1 > > Added tag jdk7-b133 for changeset 5e5f68a01d12 > > ! .hgtags > > Changeset: 864b669d54d8 > Author: lana > Date: 2011-02-21 19:43 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/864b669d54d8 > > Merge > > - make/sun/jkernel/FILES_c_windows.gmk > - make/sun/jkernel/FILES_java.gmk > - make/sun/jkernel/Makefile > - src/share/classes/java/io/TempFileHelper.java > - src/share/classes/java/nio/file/FileRef.java > - src/share/classes/java/nio/file/attribute/Attributes.java > - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java > - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java > - src/share/classes/sun/jkernel/BackgroundDownloader.java > - src/share/classes/sun/jkernel/Bundle.java > - src/share/classes/sun/jkernel/BundleCheck.java > - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java > - src/share/classes/sun/jkernel/DigestOutputStream.java > - src/share/classes/sun/jkernel/DownloadManager.java > - src/share/classes/sun/jkernel/KernelError.java > - src/share/classes/sun/jkernel/Mutex.java > - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java > - src/share/classes/sun/jkernel/StandaloneMessageDigest.java > - src/share/classes/sun/jkernel/StandaloneSHA.java > - src/share/demo/zipfs > - src/windows/native/sun/jkernel/DownloadDialog.cpp > - src/windows/native/sun/jkernel/DownloadDialog.h > - src/windows/native/sun/jkernel/DownloadHelper.cpp > - src/windows/native/sun/jkernel/DownloadHelper.h > - src/windows/native/sun/jkernel/graphics/bullet.bmp > - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp > - src/windows/native/sun/jkernel/graphics/java-icon.ico > - src/windows/native/sun/jkernel/graphics/masthead.bmp > - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp > - src/windows/native/sun/jkernel/kernel.cpp > - src/windows/native/sun/jkernel/kernel.def > - src/windows/native/sun/jkernel/kernel.h > - src/windows/native/sun/jkernel/kernel.rc > - src/windows/native/sun/jkernel/kernel_de.rc > - src/windows/native/sun/jkernel/kernel_en.rc > - src/windows/native/sun/jkernel/kernel_es.rc > - src/windows/native/sun/jkernel/kernel_fr.rc > - src/windows/native/sun/jkernel/kernel_it.rc > - src/windows/native/sun/jkernel/kernel_ja.rc > - src/windows/native/sun/jkernel/kernel_ko.rc > - src/windows/native/sun/jkernel/kernel_pt_BR.rc > - src/windows/native/sun/jkernel/kernel_sv.rc > - src/windows/native/sun/jkernel/kernel_zh.rc > - src/windows/native/sun/jkernel/kernel_zh_TW.rc > - src/windows/native/sun/jkernel/resource.h > - src/windows/native/sun/jkernel/stdafx.cpp > - src/windows/native/sun/jkernel/stdafx.h > - src/windows/native/sun/jkernel/version.rc > - test/java/nio/file/Files/ContentType.java > - test/java/nio/file/Files/CreateFileTree.java > - test/java/nio/file/Files/ForceLoad.java > - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector > - test/java/nio/file/Files/MaxDepth.java > - test/java/nio/file/Files/PrintFileTree.java > - test/java/nio/file/Files/SimpleFileTypeDetector.java > - test/java/nio/file/Files/SkipSiblings.java > - test/java/nio/file/Files/TerminateWalk.java > - test/java/nio/file/Files/WalkWithSecurity.java > - test/java/nio/file/Files/denyAll.policy > - test/java/nio/file/Files/grantAll.policy > - test/java/nio/file/Files/grantTopOnly.policy > - test/java/nio/file/Files/walk_file_tree.sh > - test/java/nio/file/Path/CheckPermissions.java > - test/java/nio/file/Path/CopyAndMove.java > - test/java/nio/file/Path/DeleteOnClose.java > - test/java/nio/file/Path/FileAttributes.java > - test/java/nio/file/Path/InterruptCopy.java > - test/java/nio/file/Path/Links.java > - test/java/nio/file/Path/PassThroughFileSystem.java > - test/java/nio/file/Path/SBC.java > - test/java/nio/file/Path/TemporaryFiles.java > - test/java/nio/file/Path/delete_on_close.sh > - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java > > Changeset: 196d6e802721 > Author: prr > Date: 2011-02-28 10:25 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/196d6e802721 > > 7004728: [parfait] potential memory leaks in XRender code > Reviewed-by: bae, ceisserer > > ! src/solaris/native/sun/java2d/x11/XRBackendNative.c > > Changeset: bbbf427a9007 > Author: ceisserer > Date: 2011-03-01 14:49 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bbbf427a9007 > > 6974985: Jave2Demo threw exceptions when xrender enabled in OEL5.5 > Reviewed-by: prr > > ! make/sun/awt/mapfile-mawt-vers > ! make/sun/xawt/mapfile-vers > ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java > ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c > ! src/solaris/native/sun/java2d/x11/XRSurfaceData.c > > Changeset: 01dcb496946e > Author: ceisserer > Date: 2011-03-03 16:06 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/01dcb496946e > > 7023589: Xrender : NullPointerException in sun.font.XRGlyphCache.freeGlyphs running Java 2D demo > Reviewed-by: prr > > ! src/share/classes/sun/font/StrikeCache.java > ! src/solaris/classes/sun/font/XRGlyphCache.java > > Changeset: f82f0af7de5b > Author: prr > Date: 2011-03-04 15:54 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f82f0af7de5b > > 7023591: Xrender: java2D font demo - text highlighting tab content is black > Reviewed-by: flar > > ! src/share/classes/sun/java2d/pipe/AAShapePipe.java > > Changeset: 1356371db8c9 > Author: lana > Date: 2011-03-06 23:37 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1356371db8c9 > > Merge > > - src/share/classes/java/dyn/NoAccessException.java > - src/share/classes/java/dyn/Switcher.java > - test/java/lang/Thread/StopBeforeStart.java > > Changeset: df0de56682b7 > Author: dcherepanov > Date: 2011-02-24 13:01 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df0de56682b7 > > 6996708: The event on the tray icon does not trigger and there is no message printed. > Reviewed-by: art, ant > > ! src/windows/native/sun/windows/awt_TrayIcon.cpp > > Changeset: 75d8c1200df8 > Author: dcherepanov > Date: 2011-02-25 13:58 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/75d8c1200df8 > > 7020522: Need to reapply the fix for 6664512 > Reviewed-by: art, mchung > > ! src/share/classes/sun/util/logging/PlatformLogger.java > > Changeset: c27520009762 > Author: dcherepanov > Date: 2011-02-25 15:33 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c27520009762 > > 7009114: GTK FileDialog lies about it's Bounds > Reviewed-by: art, anthony > > ! make/sun/xawt/mapfile-vers > ! src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java > ! src/solaris/native/sun/awt/gtk2_interface.c > ! src/solaris/native/sun/awt/gtk2_interface.h > ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c > ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.h > > Changeset: de0f2f8563eb > Author: lana > Date: 2011-02-26 23:46 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/de0f2f8563eb > > Merge > > - make/sun/jkernel/FILES_c_windows.gmk > - make/sun/jkernel/FILES_java.gmk > - make/sun/jkernel/Makefile > - src/share/classes/java/io/TempFileHelper.java > - src/share/classes/java/nio/file/FileRef.java > - src/share/classes/java/nio/file/attribute/Attributes.java > - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java > - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java > - src/share/classes/sun/jkernel/BackgroundDownloader.java > - src/share/classes/sun/jkernel/Bundle.java > - src/share/classes/sun/jkernel/BundleCheck.java > - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java > - src/share/classes/sun/jkernel/DigestOutputStream.java > - src/share/classes/sun/jkernel/DownloadManager.java > - src/share/classes/sun/jkernel/KernelError.java > - src/share/classes/sun/jkernel/Mutex.java > - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java > - src/share/classes/sun/jkernel/StandaloneMessageDigest.java > - src/share/classes/sun/jkernel/StandaloneSHA.java > - src/share/demo/zipfs > - src/windows/native/sun/jkernel/DownloadDialog.cpp > - src/windows/native/sun/jkernel/DownloadDialog.h > - src/windows/native/sun/jkernel/DownloadHelper.cpp > - src/windows/native/sun/jkernel/DownloadHelper.h > - src/windows/native/sun/jkernel/graphics/bullet.bmp > - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp > - src/windows/native/sun/jkernel/graphics/java-icon.ico > - src/windows/native/sun/jkernel/graphics/masthead.bmp > - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp > - src/windows/native/sun/jkernel/kernel.cpp > - src/windows/native/sun/jkernel/kernel.def > - src/windows/native/sun/jkernel/kernel.h > - src/windows/native/sun/jkernel/kernel.rc > - src/windows/native/sun/jkernel/kernel_de.rc > - src/windows/native/sun/jkernel/kernel_en.rc > - src/windows/native/sun/jkernel/kernel_es.rc > - src/windows/native/sun/jkernel/kernel_fr.rc > - src/windows/native/sun/jkernel/kernel_it.rc > - src/windows/native/sun/jkernel/kernel_ja.rc > - src/windows/native/sun/jkernel/kernel_ko.rc > - src/windows/native/sun/jkernel/kernel_pt_BR.rc > - src/windows/native/sun/jkernel/kernel_sv.rc > - src/windows/native/sun/jkernel/kernel_zh.rc > - src/windows/native/sun/jkernel/kernel_zh_TW.rc > - src/windows/native/sun/jkernel/resource.h > - src/windows/native/sun/jkernel/stdafx.cpp > - src/windows/native/sun/jkernel/stdafx.h > - src/windows/native/sun/jkernel/version.rc > - test/java/nio/file/Files/ContentType.java > - test/java/nio/file/Files/CreateFileTree.java > - test/java/nio/file/Files/ForceLoad.java > - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector > - test/java/nio/file/Files/MaxDepth.java > - test/java/nio/file/Files/PrintFileTree.java > - test/java/nio/file/Files/SimpleFileTypeDetector.java > - test/java/nio/file/Files/SkipSiblings.java > - test/java/nio/file/Files/TerminateWalk.java > - test/java/nio/file/Files/WalkWithSecurity.java > - test/java/nio/file/Files/denyAll.policy > - test/java/nio/file/Files/grantAll.policy > - test/java/nio/file/Files/grantTopOnly.policy > - test/java/nio/file/Files/walk_file_tree.sh > - test/java/nio/file/Path/CheckPermissions.java > - test/java/nio/file/Path/CopyAndMove.java > - test/java/nio/file/Path/DeleteOnClose.java > - test/java/nio/file/Path/FileAttributes.java > - test/java/nio/file/Path/InterruptCopy.java > - test/java/nio/file/Path/Links.java > - test/java/nio/file/Path/PassThroughFileSystem.java > - test/java/nio/file/Path/SBC.java > - test/java/nio/file/Path/TemporaryFiles.java > - test/java/nio/file/Path/delete_on_close.sh > - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java > > Changeset: 024d040af4a3 > Author: anthony > Date: 2011-03-01 13:49 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/024d040af4a3 > > 7022488: The security warning may disappear unexpectedly > Summary: Initialize the fullScreenExclusiveModeState flag in the AwtWindow constructor > Reviewed-by: art, dcherepanov > > ! src/windows/native/sun/windows/awt_Window.cpp > > Changeset: b5e609488bc8 > Author: dcherepanov > Date: 2011-03-01 15:24 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b5e609488bc8 > > 6826397: PIT : Frame System Menu is not seen for when ALT + Space Bar is pressed in jdk7 b55 build. > Reviewed-by: art, ant > > ! src/windows/native/sun/windows/awt_Frame.cpp > ! src/windows/native/sun/windows/awt_Frame.h > > Changeset: 8cd20d3e5448 > Author: lana > Date: 2011-03-06 20:32 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8cd20d3e5448 > > Merge > > - src/share/classes/java/dyn/NoAccessException.java > - src/share/classes/java/dyn/Switcher.java > - test/java/lang/Thread/StopBeforeStart.java > > Changeset: 333bd91466bd > Author: lana > Date: 2011-03-07 14:44 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/333bd91466bd > > Merge > > ! make/sun/xawt/mapfile-vers > > Changeset: f8fdf9bca159 > Author: okutsu > Date: 2011-02-22 14:51 +0900 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f8fdf9bca159 > > 7010379: fontconfig update for RHEL 6 > Reviewed-by: peytoia > > ! make/sun/awt/Makefile > > Changeset: 5957bd3cfdc3 > Author: okutsu > Date: 2011-02-23 14:09 +0900 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5957bd3cfdc3 > > 6623219: Font.canDisplayUpTo does not work with supplementary characters > Reviewed-by: prr, peytoia > > ! src/share/classes/java/awt/Font.java > + test/java/awt/FontClass/SurrogateTest/SupplementaryCanDisplayUpToTest.java > > Changeset: 30d112b3b6f2 > Author: okutsu > Date: 2011-02-23 16:50 +0900 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/30d112b3b6f2 > > 6955047: (tz) javadoc for TimeZone.getDisplayName(boolean daylight, int style, Locale locale) is not clear > 7021680: (tz) daylight savings time should be daylight saving time > Reviewed-by: peytoia > > ! src/share/classes/java/util/Calendar.java > ! src/share/classes/java/util/GregorianCalendar.java > ! src/share/classes/java/util/TimeZone.java > > Changeset: ff611d9474cb > Author: okutsu > Date: 2011-02-24 15:09 +0900 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff611d9474cb > > 7021989: Missing observesDaylightTime override in ZoneInfo > Reviewed-by: peytoia > > ! src/share/classes/sun/util/calendar/ZoneInfo.java > > Changeset: 01c752a48b51 > Author: okutsu > Date: 2011-02-24 16:29 +0900 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/01c752a48b51 > > 6772689: java.sql.Date.valueOf("2042-10-xx").toString() wrong in some time zones > Reviewed-by: peytoia > > ! src/share/classes/sun/util/calendar/ZoneInfo.java > + test/java/util/TimeZone/Bug6772689.java > > Changeset: e390ce4509c6 > Author: alexp > Date: 2011-02-28 18:20 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e390ce4509c6 > > 6826074: JScrollPane does not revalidate the component hierarchy after scrolling > Reviewed-by: anthony > > ! src/share/classes/javax/swing/DefaultDesktopManager.java > ! src/share/classes/javax/swing/JViewport.java > > Changeset: 1ef5b85d41f2 > Author: amenkov > Date: 2011-02-28 18:36 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1ef5b85d41f2 > > 7013521: AudioSystem.write for AIFF files closes source audio stream > Reviewed-by: dav > > ! src/share/classes/com/sun/media/sound/AiffFileWriter.java > ! src/share/classes/com/sun/media/sound/AuFileWriter.java > ! src/share/classes/com/sun/media/sound/SunFileWriter.java > ! src/share/classes/com/sun/media/sound/WaveFileWriter.java > + test/javax/sound/sampled/FileWriter/WriterCloseInput.java > > Changeset: d4e3c1f2177a > Author: amenkov > Date: 2011-03-03 15:41 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d4e3c1f2177a > > 6938426: Concurrency bug in ALAW encoder causes random bursts of static/noise in output. > Reviewed-by: stayer > > ! src/share/classes/com/sun/media/sound/AlawCodec.java > + test/javax/sound/sampled/FileWriter/AlawEncoderSync.java > > Changeset: d3df100509ad > Author: amenkov > Date: 2011-03-03 15:45 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3df100509ad > > 6801206: SoundTestSuite: test050 fails > Reviewed-by: stayer > > ! src/share/classes/com/sun/media/sound/DirectAudioDevice.java > + test/javax/sound/sampled/Clip/ClipSetPos.java > > Changeset: 4e732aba71bf > Author: amenkov > Date: 2011-03-03 15:57 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4e732aba71bf > > 6660470: RealTimeSequencer incorrectly opens (implicitly) synthesizer > Reviewed-by: stayer > > ! src/share/classes/com/sun/media/sound/RealTimeSequencer.java > ! src/share/classes/javax/sound/midi/MidiSystem.java > + test/javax/sound/midi/Sequencer/SequencerImplicitSynthOpen.java > > Changeset: 67d4b2e2e5b1 > Author: amenkov > Date: 2011-03-03 16:40 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/67d4b2e2e5b1 > > 6835393: MidiSystem fails to correctly read Sequence with SMPTE division > Reviewed-by: stayer > > ! src/share/classes/com/sun/media/sound/StandardMidiFileReader.java > + test/javax/sound/midi/File/SMPTESequence.java > > Changeset: 52bdb4237d5e > Author: rupashka > Date: 2011-03-03 17:47 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/52bdb4237d5e > > 6796710: Html content in JEditorPane is overlapping on swing components while resizing the application. > Reviewed-by: alexp > > ! src/share/classes/javax/swing/text/html/CSSBorder.java > + test/javax/swing/regtesthelpers/Util.java > + test/javax/swing/text/CSSBorder/6796710/bug6796710.java > > Changeset: 7dfcf271b73b > Author: alexp > Date: 2011-03-03 18:23 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7dfcf271b73b > > 6653511: JComponent.safelyGetGraphics() may sometimes return null > Reviewed-by: rupashka > > ! src/share/classes/javax/swing/JComponent.java > > Changeset: e4ca9353150a > Author: alexp > Date: 2011-03-03 18:27 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e4ca9353150a > > Merge > > > Changeset: dc34da6a3fa1 > Author: rupashka > Date: 2011-03-05 18:27 +0300 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dc34da6a3fa1 > > 6760148: Certain fonts are not correctly soft wrapped when using JTextComponent.print() > Reviewed-by: peterz > > ! src/share/classes/javax/swing/text/Utilities.java > ! src/share/classes/javax/swing/text/WrappedPlainView.java > > Changeset: ca0f223b4be7 > Author: lana > Date: 2011-03-05 20:54 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ca0f223b4be7 > > Merge > > - make/sun/jkernel/FILES_c_windows.gmk > - make/sun/jkernel/FILES_java.gmk > - make/sun/jkernel/Makefile > - src/share/classes/java/dyn/NoAccessException.java > - src/share/classes/java/dyn/Switcher.java > - src/share/classes/java/io/TempFileHelper.java > - src/share/classes/java/nio/file/FileRef.java > - src/share/classes/java/nio/file/attribute/Attributes.java > - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java > - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java > ! src/share/classes/javax/swing/JComponent.java > - src/share/classes/sun/jkernel/BackgroundDownloader.java > - src/share/classes/sun/jkernel/Bundle.java > - src/share/classes/sun/jkernel/BundleCheck.java > - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java > - src/share/classes/sun/jkernel/DigestOutputStream.java > - src/share/classes/sun/jkernel/DownloadManager.java > - src/share/classes/sun/jkernel/KernelError.java > - src/share/classes/sun/jkernel/Mutex.java > - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java > - src/share/classes/sun/jkernel/StandaloneMessageDigest.java > - src/share/classes/sun/jkernel/StandaloneSHA.java > - src/share/demo/zipfs > - src/windows/native/sun/jkernel/DownloadDialog.cpp > - src/windows/native/sun/jkernel/DownloadDialog.h > - src/windows/native/sun/jkernel/DownloadHelper.cpp > - src/windows/native/sun/jkernel/DownloadHelper.h > - src/windows/native/sun/jkernel/graphics/bullet.bmp > - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp > - src/windows/native/sun/jkernel/graphics/java-icon.ico > - src/windows/native/sun/jkernel/graphics/masthead.bmp > - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp > - src/windows/native/sun/jkernel/kernel.cpp > - src/windows/native/sun/jkernel/kernel.def > - src/windows/native/sun/jkernel/kernel.h > - src/windows/native/sun/jkernel/kernel.rc > - src/windows/native/sun/jkernel/kernel_de.rc > - src/windows/native/sun/jkernel/kernel_en.rc > - src/windows/native/sun/jkernel/kernel_es.rc > - src/windows/native/sun/jkernel/kernel_fr.rc > - src/windows/native/sun/jkernel/kernel_it.rc > - src/windows/native/sun/jkernel/kernel_ja.rc > - src/windows/native/sun/jkernel/kernel_ko.rc > - src/windows/native/sun/jkernel/kernel_pt_BR.rc > - src/windows/native/sun/jkernel/kernel_sv.rc > - src/windows/native/sun/jkernel/kernel_zh.rc > - src/windows/native/sun/jkernel/kernel_zh_TW.rc > - src/windows/native/sun/jkernel/resource.h > - src/windows/native/sun/jkernel/stdafx.cpp > - src/windows/native/sun/jkernel/stdafx.h > - src/windows/native/sun/jkernel/version.rc > - test/java/lang/Thread/StopBeforeStart.java > - test/java/nio/file/Files/ContentType.java > - test/java/nio/file/Files/CreateFileTree.java > - test/java/nio/file/Files/ForceLoad.java > - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector > - test/java/nio/file/Files/MaxDepth.java > - test/java/nio/file/Files/PrintFileTree.java > - test/java/nio/file/Files/SimpleFileTypeDetector.java > - test/java/nio/file/Files/SkipSiblings.java > - test/java/nio/file/Files/TerminateWalk.java > - test/java/nio/file/Files/WalkWithSecurity.java > - test/java/nio/file/Files/denyAll.policy > - test/java/nio/file/Files/grantAll.policy > - test/java/nio/file/Files/grantTopOnly.policy > - test/java/nio/file/Files/walk_file_tree.sh > - test/java/nio/file/Path/CheckPermissions.java > - test/java/nio/file/Path/CopyAndMove.java > - test/java/nio/file/Path/DeleteOnClose.java > - test/java/nio/file/Path/FileAttributes.java > - test/java/nio/file/Path/InterruptCopy.java > - test/java/nio/file/Path/Links.java > - test/java/nio/file/Path/PassThroughFileSystem.java > - test/java/nio/file/Path/SBC.java > - test/java/nio/file/Path/TemporaryFiles.java > - test/java/nio/file/Path/delete_on_close.sh > - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java > > Changeset: e3a69b9be2b5 > Author: lana > Date: 2011-03-07 14:46 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e3a69b9be2b5 > > Merge > > > Changeset: 0b6d82c838d4 > Author: lana > Date: 2011-03-07 14:48 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b6d82c838d4 > > Merge > > - src/share/classes/sun/misc/BootClassLoaderHook.java > - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java > - test/sun/misc/BootClassLoaderHook/TestHook.java > > Changeset: c0bf0f19897a > Author: lana > Date: 2011-03-10 19:38 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c0bf0f19897a > > Merge > > > Changeset: c975c4fbca20 > Author: lana > Date: 2011-03-10 20:49 -0800 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c975c4fbca20 > > Merge > > ! make/common/Release.gmk > - src/share/classes/sun/misc/BootClassLoaderHook.java > - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java > - test/sun/misc/BootClassLoaderHook/TestHook.java > > Changeset: b1215d1f015b > Author: ohair > Date: 2011-03-15 15:32 -0700 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b1215d1f015b > > Merge > > - make/common/Modules.gmk > ! make/common/Release.gmk > - make/java/nio/mxbean/Makefile > - make/modules/Makefile > - make/modules/bootmodule.roots > - make/modules/jdk7.depconfig > - make/modules/modules.config > - make/modules/modules.group > - make/modules/optional.depconfig > - make/modules/tools/Makefile > - make/modules/tools/build.xml > - make/modules/tools/nbproject/project.properties > - make/modules/tools/nbproject/project.xml > - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java > - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java > - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java > - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java > - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java > - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java > - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java > - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java > - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java > - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java > - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java > - make/modules/tools/src/com/sun/classanalyzer/Klass.java > - make/modules/tools/src/com/sun/classanalyzer/Module.java > - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java > - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java > - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java > - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java > ! make/sun/awt/Makefile > > Changeset: f82a1434bf63 > Author: dholmes > Date: 2011-03-15 19:52 -0400 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f82a1434bf63 > > 7027897: Build support for client-VM only configurations > Summary: Support builds for which only the client VM is required and/or available > Reviewed-by: ohair, andrew > > ! make/common/Defs.gmk > ! make/common/shared/Sanity.gmk > ! make/java/jvm/Makefile > ! make/java/redist/Makefile > > Changeset: d7034302bc24 > Author: dholmes > Date: 2011-03-15 20:00 -0400 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d7034302bc24 > > Merge > > ! make/common/Defs.gmk > - make/common/Modules.gmk > ! make/common/shared/Sanity.gmk > ! make/java/jli/Makefile > ! make/java/jvm/Makefile > - make/java/nio/mxbean/Makefile > ! make/java/redist/Makefile > - make/modules/Makefile > - make/modules/bootmodule.roots > - make/modules/jdk7.depconfig > - make/modules/modules.config > - make/modules/modules.group > - make/modules/optional.depconfig > - make/modules/tools/Makefile > - make/modules/tools/build.xml > - make/modules/tools/nbproject/project.properties > - make/modules/tools/nbproject/project.xml > - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java > - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java > - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java > - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java > - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java > - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java > - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java > - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java > - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java > - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java > - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java > - make/modules/tools/src/com/sun/classanalyzer/Klass.java > - make/modules/tools/src/com/sun/classanalyzer/Module.java > - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java > - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java > - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java > - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java > > Changeset: 3a22998bc3c7 > Author: dholmes > Date: 2011-03-16 05:29 -0400 > URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3a22998bc3c7 > > Merge > > From maurizio.cimadamore at oracle.com Wed Mar 16 04:13:43 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 16 Mar 2011 11:13:43 +0000 Subject: hg: jdk7/tl/langtools: 6558548: The compiler needs to be aligned with clarified specification of throws Message-ID: <20110316111347.6C8DF471CC@hg.openjdk.java.net> Changeset: 5b29f2a85085 Author: mcimadamore Date: 2011-03-16 11:12 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5b29f2a85085 6558548: The compiler needs to be aligned with clarified specification of throws Summary: Javac should issue unconditional warnings when 'dead' catch clauses are detected Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/6558548/T6558548.java + test/tools/javac/6558548/T6558548_6.out + test/tools/javac/6558548/T6558548_latest.out + test/tools/javac/diags/examples/UnreachableCatch.java + test/tools/javac/diags/examples/UnreachableCatch1.java From kumar.x.srinivasan at oracle.com Wed Mar 16 11:23:41 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Wed, 16 Mar 2011 18:23:41 +0000 Subject: hg: jdk7/tl/langtools: 7026359: (langtools) fix big jar test Message-ID: <20110316182343.6B262471DF@hg.openjdk.java.net> Changeset: f2f04935ef3f Author: ksrini Date: 2011-03-16 09:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f2f04935ef3f 7026359: (langtools) fix big jar test Reviewed-by: jjg ! test/tools/javac/file/zip/T6836682.java From xueming.shen at oracle.com Wed Mar 16 12:15:29 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 16 Mar 2011 19:15:29 +0000 Subject: hg: jdk7/tl/jdk: 6803681: RFE: Need new codeset converter for IBM Cp1364 Message-ID: <20110316191555.3B4F2471E2@hg.openjdk.java.net> Changeset: 05911dc54a67 Author: sherman Date: 2011-03-16 12:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/05911dc54a67 6803681: RFE: Need new codeset converter for IBM Cp1364 Summary: forward port the Cp1364 Reviewed-by: alanb ! make/sun/nio/cs/FILES_java.gmk + make/tools/CharsetMapping/IBM1364.c2b + make/tools/CharsetMapping/IBM1364.map ! make/tools/CharsetMapping/dbcs ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java + test/sun/nio/cs/TestIBM1364.java From david.holmes at oracle.com Wed Mar 16 15:56:01 2011 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 16 Mar 2011 22:56:01 +0000 Subject: hg: jdk7/tl/jdk: 7027910: Add basic cross-compilation support and add ARM/PPC to the known architectures in the open code Message-ID: <20110316225625.61D26471EC@hg.openjdk.java.net> Changeset: 54d8193f177b Author: dholmes Date: 2011-03-16 18:54 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/54d8193f177b 7027910: Add basic cross-compilation support and add ARM/PPC to the known architectures in the open code Summary: Cross-compilation support Reviewed-by: ohair, andrew ! make/common/Defs-linux.gmk ! make/common/Defs.gmk ! make/common/Program.gmk ! make/common/shared/Defs-linux.gmk ! make/common/shared/Defs-solaris.gmk ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-versions.gmk ! make/common/shared/Platform.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/java/instrument/Makefile ! make/java/nio/Makefile ! make/javax/sound/SoundDefs.gmk ! make/sun/jdbc/Makefile ! make/tools/Makefile ! src/share/native/com/sun/media/sound/SoundDefs.h ! src/share/native/java/lang/fdlibm/include/fdlibm.h From jonathan.gibbons at oracle.com Wed Mar 16 17:22:57 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 17 Mar 2011 00:22:57 +0000 Subject: hg: jdk7/tl/langtools: 6930508: Passing nested class names on javac command line interfere with subsequent name -> class lookup Message-ID: <20110317002301.6AB34471F1@hg.openjdk.java.net> Changeset: a2399c8db703 Author: jjg Date: 2011-03-16 17:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a2399c8db703 6930508: Passing nested class names on javac command line interfere with subsequent name -> class lookup Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! test/tools/javac/processing/model/element/TestAnonClassNames.java + test/tools/javac/processing/options/testCommandLineClasses/Test.java + test/tools/javac/processing/options/testCommandLineClasses/p/NestedExamples.java From lance.andersen at oracle.com Thu Mar 17 08:38:14 2011 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Thu, 17 Mar 2011 15:38:14 +0000 Subject: hg: jdk7/tl/jdk: 7026898: DriverManager to now use CopyOnWriteArrayList Message-ID: <20110317153840.B5F6D4721B@hg.openjdk.java.net> Changeset: df9991dc1f0d Author: lancea Date: 2011-03-17 11:37 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df9991dc1f0d 7026898: DriverManager to now use CopyOnWriteArrayList Reviewed-by: alanb, briangoetz ! src/share/classes/java/sql/DriverManager.java From xuelei.fan at oracle.com Thu Mar 17 08:56:25 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 17 Mar 2011 15:56:25 +0000 Subject: hg: jdk7/tl/jdk: 7028422: regression: SKID miss-matching Message-ID: <20110317155634.F3EBA4721D@hg.openjdk.java.net> Changeset: 320bdab4cb2a Author: xuelei Date: 2011-03-17 08:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/320bdab4cb2a 7028422: regression: SKID miss-matching Summary: Do not override the previous setting for initial selection. Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/AdaptableX509CertSelector.java From xueming.shen at oracle.com Thu Mar 17 11:40:30 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 17 Mar 2011 18:40:30 +0000 Subject: hg: jdk7/tl/jdk: 6796662: (fmt spec) Formatter spec on BigDecimal output should not reference Float a Message-ID: <20110317184040.1402A47224@hg.openjdk.java.net> Changeset: 3eb51bf7e859 Author: sherman Date: 2011-03-17 11:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3eb51bf7e859 6796662: (fmt spec) Formatter spec on BigDecimal output should not reference Float a Summary: updated the spec doc Reviewed-by: alanb ! src/share/classes/java/util/Formatter.java From mike.duigou at oracle.com Thu Mar 17 13:14:54 2011 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 17 Mar 2011 20:14:54 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110317201513.B44DA47228@hg.openjdk.java.net> Changeset: a8569f14121d Author: mduigou Date: 2011-03-17 13:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a8569f14121d 7028133: Specify serialVersionUID for RegularEnumSet and JumboEnumSet Reviewed-by: alanb, mduigou Contributed-by: Neil Richards ! src/share/classes/java/util/JumboEnumSet.java ! src/share/classes/java/util/RegularEnumSet.java Changeset: 3ad10ea6df89 Author: mduigou Date: 2011-03-17 13:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3ad10ea6df89 Merge From mike.duigou at oracle.com Thu Mar 17 14:43:31 2011 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 17 Mar 2011 21:43:31 +0000 Subject: hg: jdk7/tl/jdk: 5045147: Prevent insertion of null Key into empty TreeMap (and null element into TreeSet) when no Comparator is used. Prevent insertion of key of incorrect type into empty TreeMap and incorrect type element into TreeSet and incorrect type when Comparator is used. Message-ID: <20110317214340.9465F4722E@hg.openjdk.java.net> Changeset: bf37edb38fbb Author: mduigou Date: 2011-03-17 14:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf37edb38fbb 5045147: Prevent insertion of null Key into empty TreeMap (and null element into TreeSet) when no Comparator is used. Prevent insertion of key of incorrect type into empty TreeMap and incorrect type element into TreeSet and incorrect type when Comparator is used. Reviewed-by: alanb, dl, mduigou ! src/share/classes/java/util/TreeMap.java + test/java/util/TreeMap/cr5045147.java From valerie.peng at oracle.com Thu Mar 17 17:41:06 2011 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Thu, 17 Mar 2011 17:41:06 -0700 Subject: code review request for 6986789: Sun pkcs11 provider fails to parse path name containing "+" Message-ID: <4D82AA22.2090504@oracle.com> Hi, Max, Can you please help reviewing this following fix: 6986789: Sun pkcs11 provider fails to parse path name containing "+" It's only a one-line change, essentially adding '+' to the list of valid characters recognized by the Config file parser. Webrev at: http://cr.openjdk.java.net/~valeriep/6986789/webrev.00/ Thanks, Valerie From stuart.marks at oracle.com Thu Mar 17 18:49:20 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 18 Mar 2011 01:49:20 +0000 Subject: hg: jdk7/tl/jdk: 7022382: convert pack200 library code to use try-with-resources Message-ID: <20110318014935.CC1734724A@hg.openjdk.java.net> Changeset: 192bbf6cd5de Author: smarks Date: 2011-03-17 18:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/192bbf6cd5de 7022382: convert pack200 library code to use try-with-resources Reviewed-by: ksrini ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/Driver.java ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java From daniel.daugherty at oracle.com Fri Mar 18 07:18:25 2011 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Fri, 18 Mar 2011 14:18:25 +0000 Subject: hg: jdk7/tl/jdk: 7028668: 3/4 improve diagnosibility and robustness of sun.tools.attach.WindowsVirtualMachine.openProcess() Message-ID: <20110318141850.AAAE94727D@hg.openjdk.java.net> Changeset: a76262ab5ea6 Author: dcubed Date: 2011-03-18 07:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a76262ab5ea6 7028668: 3/4 improve diagnosibility and robustness of sun.tools.attach.WindowsVirtualMachine.openProcess() Summary: Add more info to OpenProcess default detail error message. Try a different technique when a Java process is attaching to itself. Reviewed-by: zgu, ohair, alanb ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c From lana.steuck at oracle.com Fri Mar 18 14:18:36 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Mar 2011 21:18:36 +0000 Subject: hg: jdk7/tl: 7 new changesets Message-ID: <20110318211837.212114728E@hg.openjdk.java.net> Changeset: a1c8b847b753 Author: ohrstrom Date: 2011-02-28 10:56 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/rev/a1c8b847b753 7021753: Add a build times report Summary: Report the build times at end of a jdkroot build. Reviewed-by: ohair ! Makefile ! make/Defs-internal.gmk ! make/corba-rules.gmk ! make/deploy-rules.gmk ! make/hotspot-rules.gmk ! make/install-rules.gmk ! make/jaxp-rules.gmk ! make/jaxws-rules.gmk ! make/jdk-rules.gmk ! make/langtools-rules.gmk ! make/sponsors-rules.gmk Changeset: 47ad81d343e8 Author: ohair Date: 2011-03-01 11:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/47ad81d343e8 7023111: Add webrev script to make/scripts Reviewed-by: darcy + make/scripts/webrev.ksh Changeset: 258b21c7f4af Author: ohair Date: 2011-03-01 11:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/258b21c7f4af Merge Changeset: 27384dd2d8ed Author: ohair Date: 2011-03-03 15:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/27384dd2d8ed Merge Changeset: c6f380693342 Author: ohair Date: 2011-03-09 16:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/c6f380693342 7026167: Broken fastdebug only build Reviewed-by: cl ! Makefile Changeset: ddc2fcb3682f Author: cl Date: 2011-03-10 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/ddc2fcb3682f Added tag jdk7-b133 for changeset c6f380693342 ! .hgtags Changeset: 168d9382ebab Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/168d9382ebab Added tag jdk7-b134 for changeset ddc2fcb3682f ! .hgtags From lana.steuck at oracle.com Fri Mar 18 14:18:42 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Mar 2011 21:18:42 +0000 Subject: hg: jdk7/tl/jaxp: 6 new changesets Message-ID: <20110318211842.A5F5A4728F@hg.openjdk.java.net> Changeset: 2473f7027ac5 Author: cl Date: 2011-03-10 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/2473f7027ac5 Added tag jdk7-b133 for changeset 8e1148c7911b ! .hgtags Changeset: 02d4672e8c05 Author: lana Date: 2011-03-10 20:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/02d4672e8c05 Merge Changeset: e8be6b716643 Author: ohair Date: 2011-03-10 13:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/e8be6b716643 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places Reviewed-by: mchung ! make/Makefile Changeset: 1259c6d09d09 Author: mfang Date: 2011-03-14 12:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/1259c6d09d09 Merge Changeset: d56b326ae054 Author: ohair Date: 2011-03-15 15:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/d56b326ae054 Merge Changeset: 4aa9916693dc Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/4aa9916693dc Added tag jdk7-b134 for changeset d56b326ae054 ! .hgtags From lana.steuck at oracle.com Fri Mar 18 14:18:40 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Mar 2011 21:18:40 +0000 Subject: hg: jdk7/tl/corba: 2 new changesets Message-ID: <20110318211843.06B3347290@hg.openjdk.java.net> Changeset: 918003855fa0 Author: cl Date: 2011-03-10 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/918003855fa0 Added tag jdk7-b133 for changeset 671fe2e623ff ! .hgtags Changeset: e0b72ae5dc5e Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/e0b72ae5dc5e Added tag jdk7-b134 for changeset 918003855fa0 ! .hgtags From lana.steuck at oracle.com Fri Mar 18 14:18:44 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Mar 2011 21:18:44 +0000 Subject: hg: jdk7/tl/jaxws: 4 new changesets Message-ID: <20110318211844.F3FFF47291@hg.openjdk.java.net> Changeset: 8393aae2eb24 Author: cl Date: 2011-03-10 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/8393aae2eb24 Added tag jdk7-b133 for changeset 359d0c8c00a0 ! .hgtags Changeset: ba12732b1453 Author: ohair Date: 2011-03-10 13:22 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/ba12732b1453 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places Reviewed-by: mchung ! make/Makefile Changeset: 545de8303fec Author: mfang Date: 2011-03-14 12:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/545de8303fec Merge Changeset: d5fc61f18043 Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d5fc61f18043 Added tag jdk7-b134 for changeset 545de8303fec ! .hgtags From lana.steuck at oracle.com Fri Mar 18 14:19:02 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Mar 2011 21:19:02 +0000 Subject: hg: jdk7/tl/langtools: 7 new changesets Message-ID: <20110318211917.A99AC47292@hg.openjdk.java.net> Changeset: 0d056b7b93de Author: cl Date: 2011-03-10 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0d056b7b93de Added tag jdk7-b133 for changeset e77e98f936e8 ! .hgtags Changeset: d7dfa105f159 Author: lana Date: 2011-03-10 20:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d7dfa105f159 Merge - test/tools/javac/T6900037.java - test/tools/javac/T6900037.out - test/tools/javac/diags/examples/DiamondInvalidArg.java - test/tools/javac/diags/examples/DiamondInvalidArgs.java - test/tools/javac/generics/diamond/neg/Neg12.java - test/tools/javac/generics/diamond/neg/Neg12.out - test/tools/javac/multicatch/Neg05.java - test/tools/javac/multicatch/Neg05.out Changeset: 0f19e1e98b42 Author: mfang Date: 2011-03-08 23:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0f19e1e98b42 7025324: NLS: t13y fix for 7022005 [ja,zh_CN] javadoc, part of navigation bar in generated html are not translated Reviewed-by: yhuang, ogino, jennyh ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties Changeset: 654336cabc5a Author: mfang Date: 2011-03-13 14:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/654336cabc5a Merge Changeset: 3d7acdbb72ca Author: ohair Date: 2011-03-15 15:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3d7acdbb72ca Merge Changeset: 9d0a61ac567b Author: schien Date: 2011-03-17 14:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9d0a61ac567b Added tag jdk7-b134 for changeset 3d7acdbb72ca ! .hgtags Changeset: e286ec0df754 Author: lana Date: 2011-03-18 11:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e286ec0df754 Merge ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties From lana.steuck at oracle.com Fri Mar 18 14:18:58 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Mar 2011 21:18:58 +0000 Subject: hg: jdk7/tl/hotspot: 31 new changesets Message-ID: <20110318211959.4FBAC47293@hg.openjdk.java.net> Changeset: 70b50ac7e2af Author: cl Date: 2011-03-10 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/70b50ac7e2af Added tag jdk7-b133 for changeset 1b3a350709e4 ! .hgtags Changeset: f91db74a6810 Author: kamg Date: 2011-02-26 13:33 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f91db74a6810 7017640: Fix for 6766644 deadlocks on some NSK tests when running with -Xcomp Summary: Dynamic-code generated events should be deferred and processed by service thread Reviewed-by: dsamersoff, dcubed ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiImpl.hpp Changeset: da091bb67459 Author: sla Date: 2011-02-28 14:19 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/da091bb67459 7022037: Pause when exiting if debugger is attached on windows Reviewed-by: dsamersoff, kamg, hosterda ! src/os/linux/vm/os_linux.cpp ! src/os/posix/vm/os_posix.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/vmError.cpp Changeset: c1a6154012c8 Author: kamg Date: 2011-02-28 16:01 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c1a6154012c8 7020118: Alter frame assignability to allow for exception handler coverage of invokespecial Summary: Add special rule to allow assignment of frames with uninit flags set. Reviewed-by: never, coleenp ! src/share/vm/classfile/stackMapFrame.cpp ! src/share/vm/classfile/stackMapFrame.hpp ! src/share/vm/classfile/verificationType.hpp Changeset: 23ae54207126 Author: rottenha Date: 2011-02-28 15:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/23ae54207126 Merge ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.hpp Changeset: cef8c988e7b8 Author: rottenha Date: 2011-02-28 22:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cef8c988e7b8 Merge Changeset: 5584e20db481 Author: sla Date: 2011-03-02 09:41 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5584e20db481 7023323: Build failure on VS2003: IsDebuggerPresent not found Summary: #define _WIN32_WINNT 0x500 Reviewed-by: ohrstrom, hosterda, coleenp ! src/os/windows/vm/os_windows.cpp Changeset: 4a9604cd7c5f Author: kamg Date: 2011-03-02 08:18 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4a9604cd7c5f 6878713: Verifier heap corruption, relating to backward jsrs Summary: Added overflow detection in arena Amalloc methods Reviewed-by: coleenp, phh ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp ! src/share/vm/utilities/globalDefinitions_sparcWorks.hpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp + test/runtime/6878713/Test6878713.sh + test/runtime/6878713/testcase.jar Changeset: 99bd05619fa4 Author: zgu Date: 2011-03-02 09:16 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/99bd05619fa4 7017110: Add /SAFESEH to links on windows 32bit to verify safe exceptions Summary: Ensure safe exception handler table is generated on Win32 binaries when compile with VS2010 Reviewed-by: acorn, coleenp, dcubed, sla, ohair ! make/windows/makefiles/compile.make ! make/windows/makefiles/launcher.make Changeset: a3c0ec0428a2 Author: zgu Date: 2011-03-02 16:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a3c0ec0428a2 Merge Changeset: 8c0d0510d36f Author: dcubed Date: 2011-03-03 09:31 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8c0d0510d36f Merge Changeset: 4e0069ff33df Author: johnc Date: 2011-02-28 09:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4e0069ff33df 7022200: G1: optimized build broken Summary: Make the G1 specific version of is_in_closed_subset() available in all builds. Reviewed-by: tonyp, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: 11303bede852 Author: jcoomes Date: 2011-03-03 21:02 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/11303bede852 Merge Changeset: d89a22843c62 Author: iveresov Date: 2011-02-22 15:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d89a22843c62 7020521: arraycopy stubs place prebarriers incorrectly Summary: Rearranged the pre-barrier placement in arraycopy stubs so that they are properly called in case of chained calls. Also refactored the code a little bit so that it looks uniform across the platforms and is more readable. Reviewed-by: never, kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: d5a078cf7f39 Author: iveresov Date: 2011-02-22 18:13 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d5a078cf7f39 Merge Changeset: ba5d119730dd Author: kvn Date: 2011-02-23 12:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ba5d119730dd Merge Changeset: d411927672ed Author: never Date: 2011-02-23 19:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d411927672ed 7012072: CompileTheWorld causes incorrect class initialization Reviewed-by: kvn, twisti ! src/share/vm/prims/unsafe.cpp Changeset: 5a41a201d08c Author: kvn Date: 2011-02-24 10:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5a41a201d08c 6812217: Base memory of MergeMem node violates assert during killing expanded AllocateArray node Summary: The assert in MergeMemNode::memory_at() misses the case when address is TOP. Reviewed-by: never ! src/share/vm/opto/memnode.cpp Changeset: 6f3746e69a78 Author: never Date: 2011-02-24 11:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6f3746e69a78 7021603: crash in fill_sync_handler with ExtendedDTrace probes Reviewed-by: iveresov ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: 8190d4b75e09 Author: never Date: 2011-02-24 14:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8190d4b75e09 Merge Changeset: 41d4973cf100 Author: kvn Date: 2011-02-26 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/41d4973cf100 6942326: x86 code in string_indexof() could read beyond reserved heap space Summary: copy small (<8) strings on stack if str+16 crosses a page boundary and load from stack into XMM. Back up pointer when loading string's tail. Reviewed-by: never ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.cpp + test/compiler/6942326/Test.java Changeset: 1b4e6a5d98e0 Author: twisti Date: 2011-02-28 06:07 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1b4e6a5d98e0 7012914: JSR 292 MethodHandlesTest C1: frame::verify_return_pc(return_address) failed: must be a return pc Reviewed-by: never, bdelsart ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/utilities/macros.hpp Changeset: 50c0f22d6d0e Author: never Date: 2011-02-28 17:12 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/50c0f22d6d0e 7023229: extraneous include of precompiled.hpp in hsdis.c Reviewed-by: never, jrose Contributed-by: volker.simonis at gmail.com ! src/share/tools/hsdis/hsdis-demo.c ! src/share/tools/hsdis/hsdis.c Changeset: bc6b27fb3568 Author: never Date: 2011-03-01 10:27 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/bc6b27fb3568 6725983: Assertion "method->method_holder())->is_not_initialized(),"method holder must be initialized" Reviewed-by: kvn, iveresov ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/runtime/globals.hpp Changeset: 0ac769a57c64 Author: iveresov Date: 2011-03-01 14:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0ac769a57c64 6627983: G1: Bad oop deference during marking Summary: Bulk zeroing reduction didn't work with G1, because arraycopy would call pre-barriers on uninitialized oops. The solution is to have version of arraycopy stubs that don't have pre-barriers. Also refactored arraycopy stubs generation on SPARC to be more readable and reduced the number of stubs necessary in some cases. Reviewed-by: jrose, kvn, never ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp ! src/share/vm/memory/barrierSet.cpp ! src/share/vm/memory/barrierSet.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: 8c9c9ee30d71 Author: kvn Date: 2011-03-03 23:31 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8c9c9ee30d71 Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 3e2b59ab2d07 Author: trims Date: 2011-03-04 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3e2b59ab2d07 Merge Changeset: 3c76374706ea Author: trims Date: 2011-03-04 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3c76374706ea 7024814: Bump the HS21 build number to 04 Summary: Update the HS21 build number to 04 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 447e6faab4a8 Author: trims Date: 2011-03-11 11:18 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/447e6faab4a8 Merge Changeset: 2707f76d15e3 Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2707f76d15e3 Added tag jdk7-b134 for changeset 447e6faab4a8 ! .hgtags Changeset: fc1b183bfc0a Author: trims Date: 2011-03-17 17:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/fc1b183bfc0a Added tag hs21-b04 for changeset 3c76374706ea ! .hgtags From lana.steuck at oracle.com Fri Mar 18 14:19:20 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Mar 2011 21:19:20 +0000 Subject: hg: jdk7/tl/jdk: 7 new changesets Message-ID: <20110318212031.4163D47294@hg.openjdk.java.net> Changeset: 3de1fed4b9ec Author: ohair Date: 2011-03-15 15:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3de1fed4b9ec 6710813: SwingSet2 source display tabs do not work since JDK 7 b20 6685150: make/mkdemo/jpda/Makefile creates jpda.jar and src.zip instead of examples.jar Reviewed-by: prr ! make/common/Demo.gmk ! make/mkdemo/jfc/SwingSet2/Makefile ! make/mkdemo/jpda/Makefile Changeset: f5ecfc9e274c Author: ohair Date: 2011-03-15 23:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f5ecfc9e274c Merge - src/share/classes/sun/misc/BootClassLoaderHook.java - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java - test/sun/misc/BootClassLoaderHook/TestHook.java Changeset: d6c6d9566126 Author: katleman Date: 2011-03-16 09:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d6c6d9566126 6973319: incorrect spec version in jdk 7 rt.jar manifest Reviewed-by: ohair ! make/tools/manifest.mf Changeset: 76a2ea69f47f Author: katleman Date: 2011-03-16 09:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/76a2ea69f47f 7022473: JDK7 still runs /etc/prtconf to find memory size Reviewed-by: ohair ! make/common/shared/Platform.gmk Changeset: 554adcfb615e Author: ohair Date: 2011-03-16 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/554adcfb615e 7027923: Disable VS2003 use in preparation for all VS2003 make logic removal Reviewed-by: prr ! make/common/shared/Compiler-msvc.gmk Changeset: 0653cab602f2 Author: schien Date: 2011-03-17 14:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0653cab602f2 Added tag jdk7-b134 for changeset 554adcfb615e ! .hgtags Changeset: 4085d44dc7df Author: lana Date: 2011-03-18 10:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4085d44dc7df Merge ! make/common/shared/Platform.gmk From valerie.peng at oracle.com Fri Mar 18 16:54:33 2011 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 18 Mar 2011 16:54:33 -0700 Subject: code review request: 6894072: always refresh keytab In-Reply-To: <4D801157.6070009@oracle.com> References: <4CF6195A.6000301@oracle.com> <4D7A9D02.40106@oracle.com> <4D801157.6070009@oracle.com> Message-ID: <4D83F0B9.3050201@oracle.com> Max, >> Krb5AcceptCredential.java >> 1) you changed it to not extending KerberosKey, potential compatibility >> concern? > > Not compatibility concern. I only think that now Krb5AcceptCredential > can be something else other than simply KerberosKey. > > If fact, I have no idea why the original Krb5AcceptCredential needs to > extends KerberosKey. I didn't see any place where it's used as a > KerberosKey. I am somewhat concerned about this change. If any Krb5AcceptCredential objects are added into the Subject's private credential set, with this change, they will no longer be found by apps which search for KerberosKey. We'd better be careful here. >> >> Krb5Util.java >> 1) When calling ServiceCreds.getInstance(), your change only checks that >> kt, kk can't both be null, i.e. line 221. However, at line 237, it uses >> kk when ktab file is missing. It looks to me that this may leads NPE if >> the ServiceCreds is constructed w/ a non-null (but non-existent) KeyTab >> object and null KerberosKey list. > > When ktab file is missing, ktab is not null, and line 237 will not be > executed. My comment applies to your webrev.00. I saw you changed it in your latest webrev, i.e. 01, so that the NPE won't happen. > > 3) You replaced the Krb5Util.getKeys(GSSCaller, ...) method w/ >> ServicesCreds.getServiceCreds(GSSCaller,...). If you don't update JSSE >> source immediately, people will run into a compilation failure. Perhaps >> it's better to keep the Krb5Util.getKeys(GSSCaller,...) method and then >> remove this method together w/ the updated JSSE sources. > > JSSE codes are also updated in the same changeset. I think such > problems only happen when a pre-compiled jar is involved. Or, did I > miss anything? Never mind, somehow I missed that JSSE file and thought that you didn't update it. >> 4) at line 291 and 299, will the KerberosPrincipal found off the Subject >> be different from the specified server principal? Seems somewhat strange >> that we just grab the first one. > > Well, if every credentials inside the subject is a result of > Krb5LoginModule commit() call, then there should be one > KerberosPrincipal there. I am not using the specified server principal > because it has a chance to be null. Then, how about we use the specified server principal if it's not null and if it is null, then we grab the KerberosPrincipal from the Subject? I think we should use the explicitly specified value whenever possible since that's what we'd expect. >> >> KrbAsReqBuilder.java >> 1) Its destroy() method no longer destroys key nor clears password? Is >> this intentional? If yes, then the method description should be updated. >> Also, how/when will keys or keytab objects be destroyed and password be >> cleared? > > Fixed. Password is now cleared. There is no need to destroy the > keytab. Maybe the sun.security...KeyTab class needs a static destroy > method to clean up the map, but I am not sure when to call that. Yes, it's not obvious when to clean up the map. Well, static map w/ only add and no removal may lead to memory problems later... At least add some comment in the code to remind ourself about this. >> >> sun.security.krb5.internal.ktab.KeyTab.java >> 1) your "isReading" flag is static to the KeyTab class but the way you >> use it seems to suggest that it should be associated w/ each entry of >> the "map" Hashmap. > > Updated. I gave up the multi-thread tuning. There is a chance an old > keytab is returned even if it was updated long time ago. Now I simply > made the getInstance0 method synchronized. As long as the keytab > file's timestamp does not change, this method should be very fast. > > During the CCC approval, Dmitry Miltsov did like the "try its best" > words in "Implementation of getKeys() method should try its best to > get the latest info". Therefore I removed it and change the > implementation as well. The changes look good to me. Question regarding line 124: why update the "isMissing" field of the old keytab? Also, what about the other field such as "lastModified"? Typo on line 108: "instead if" should be "instead of" Lastly, regarding "if a user want to revoke all keys, he should empty the keytab instead if deleting the file.", do you think that's what most users do? Can't we detect this by checking the existence of the KeyTab file when there is a copy in the cache? If a KeyTab file was found earlier, but later disappeared/removed, can't we take it as a sign to dispose it by calling the dispose() method and remove it from the cache? Thanks, Valerie From kumar.x.srinivasan at oracle.com Sun Mar 20 08:42:15 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Sun, 20 Mar 2011 15:42:15 +0000 Subject: hg: jdk7/tl/jdk: 7026184: (launcher) Regression: class with unicode name can't be launched by java. Message-ID: <20110320154245.1C0E047310@hg.openjdk.java.net> Changeset: 90f84ecff75c Author: ksrini Date: 2011-03-20 08:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/90f84ecff75c 7026184: (launcher) Regression: class with unicode name can't be launched by java. Reviewed-by: mchung, sherman ! src/share/bin/java.c ! src/share/classes/sun/launcher/LauncherHelper.java From alan.bateman at oracle.com Sun Mar 20 12:48:11 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 20 Mar 2011 19:48:11 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20110320194841.269B44731A@hg.openjdk.java.net> Changeset: 0fdc4553f79f Author: alanb Date: 2011-03-18 19:46 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0fdc4553f79f 7028468: (fs) FileSystems.getDefault() fails when kernel micro version contains/ends non-numeric characters Reviewed-by: forax, chegar ! src/solaris/classes/sun/nio/fs/LinuxFileSystem.java Changeset: 8d53286f1fe7 Author: alanb Date: 2011-03-19 14:21 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8d53286f1fe7 7017446: (fs) Updates to file system API (3/2011) Reviewed-by: sherman ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/WatchKey.java ! src/share/classes/java/nio/file/attribute/FileTime.java ! src/share/classes/java/nio/file/spi/FileSystemProvider.java ! src/share/classes/sun/nio/fs/AbstractAclFileAttributeView.java ! src/share/classes/sun/nio/fs/AbstractBasicFileAttributeView.java ! src/share/classes/sun/nio/fs/AbstractFileSystemProvider.java ! src/share/classes/sun/nio/fs/AbstractUserDefinedFileAttributeView.java ! src/share/classes/sun/nio/fs/AbstractWatchKey.java ! src/share/classes/sun/nio/fs/FileOwnerAttributeViewImpl.java ! src/share/classes/sun/nio/fs/Util.java ! src/share/sample/nio/file/WatchDir.java ! src/solaris/classes/sun/nio/fs/LinuxDosFileAttributeView.java ! src/solaris/classes/sun/nio/fs/UnixFileAttributeViews.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/windows/classes/sun/nio/fs/WindowsFileAttributeViews.java ! src/windows/classes/sun/nio/fs/WindowsPath.java ! test/java/nio/file/Files/FileAttributes.java ! test/java/nio/file/WatchService/Basic.java ! test/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java Changeset: be5a4198c468 Author: alanb Date: 2011-03-20 19:39 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/be5a4198c468 Merge From weijun.wang at oracle.com Sun Mar 20 22:28:55 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 21 Mar 2011 13:28:55 +0800 Subject: code review request: 6894072: always refresh keytab In-Reply-To: <4D83F0B9.3050201@oracle.com> References: <4CF6195A.6000301@oracle.com> <4D7A9D02.40106@oracle.com> <4D801157.6070009@oracle.com> <4D83F0B9.3050201@oracle.com> Message-ID: <4D86E217.7050709@oracle.com> On 03/19/2011 07:54 AM, Valerie (Yu-Ching) Peng wrote: > Max, >>> Krb5AcceptCredential.java >>> 1) you changed it to not extending KerberosKey, potential compatibility >>> concern? >> >> Not compatibility concern. I only think that now Krb5AcceptCredential >> can be something else other than simply KerberosKey. >> >> If fact, I have no idea why the original Krb5AcceptCredential needs to >> extends KerberosKey. I didn't see any place where it's used as a >> KerberosKey. > I am somewhat concerned about this change. > If any Krb5AcceptCredential objects are added into the Subject's private > credential set, with this change, they will no longer be found by apps > which search for KerberosKey. We'd better be careful here. I've searched thru the codes and didn't see this happen. The problem now is, for a typical service, now we use KeyTab instead of KerberosKey as the private credentials. I don't suggest letting Krb5AcceptCredential extend anything now. For safety, we can support Krb5AcceptCredential as a private credential, this means the SubjectComber will search for it, and if it's there, we can directly use the ServiceCreds inside. > >>> >>> Krb5Util.java > >>> 4) at line 291 and 299, will the KerberosPrincipal found off the Subject >>> be different from the specified server principal? Seems somewhat strange >>> that we just grab the first one. >> >> Well, if every credentials inside the subject is a result of >> Krb5LoginModule commit() call, then there should be one >> KerberosPrincipal there. I am not using the specified server principal >> because it has a chance to be null. > Then, how about we use the specified server principal if it's not null > and if it is null, then we grab the KerberosPrincipal from the Subject? > I think we should use the explicitly specified value whenever possible > since that's what we'd expect. I think I've made some design error here. In fact, the old code has never looked at the KerberosPrincipal inside a Subject, when the specified server principal is null, it simply uses the one inside KerberosKey (because a key is always for a pricipal, and this principal is saved into the key in Krb5LoginModule). Since I thought a KeyTab can be used by multiple principals, I haven't embedded a principal inside. This can lead to a problem: If there are 2 Krb5LoginModule in a JAAS login process (I don't know if we can support it. Of course, in this case, the specified principal cannot be null), and two different principals using different keytab files. With the old code, keys are extracted from keytabs and the principal name is attached to it, so the SubjectComber.find(non-null principal) method can locate the correct keys. But with the new code, two keytab files is put into private credentials but we don't know which one is for who. > >>> >>> KrbAsReqBuilder.java >>> 1) Its destroy() method no longer destroys key nor clears password? Is >>> this intentional? If yes, then the method description should be updated. >>> Also, how/when will keys or keytab objects be destroyed and password be >>> cleared? >> >> Fixed. Password is now cleared. There is no need to destroy the >> keytab. Maybe the sun.security...KeyTab class needs a static destroy >> method to clean up the map, but I am not sure when to call that. > Yes, it's not obvious when to clean up the map. > Well, static map w/ only add and no removal may lead to memory problems > later... > At least add some comment in the code to remind ourself about this. OK. > >>> >>> sun.security.krb5.internal.ktab.KeyTab.java >>> 1) your "isReading" flag is static to the KeyTab class but the way you >>> use it seems to suggest that it should be associated w/ each entry of >>> the "map" Hashmap. >> >> Updated. I gave up the multi-thread tuning. There is a chance an old >> keytab is returned even if it was updated long time ago. Now I simply >> made the getInstance0 method synchronized. As long as the keytab >> file's timestamp does not change, this method should be very fast. >> >> During the CCC approval, Dmitry Miltsov did like the "try its best" >> words in "Implementation of getKeys() method should try its best to >> get the latest info". Therefore I removed it and change the >> implementation as well. > The changes look good to me. > Question regarding line 124: why update the "isMissing" field of the old > keytab? Also, what about the other field such as "lastModified"? Well, I want to express the meaning that the keytab is now missing but the caller can still access its old content. Yes, this is a little confusing. When I designed the new javax...KeyTab class, I want to make sure the keytab is not affected by half-edited keytab, bad communication etc. This is why I use these words everywhere: * If there is any error (say, file missing, I/O error or * file format error) during the reading process of the * KeyTab file, a saved result should be returned. So, "file missing" means "saved result". This is why I set the isMissing field on but keep the old keytab. (continue to my reply below). > Lastly, regarding "if a user want to revoke all keys, he should empty > the keytab instead if deleting the file.", do you think that's what most > users do? > Can't we detect this by checking the existence of the KeyTab file when > there is a copy in the cache? > If a KeyTab file was found earlier, but later disappeared/removed, can't > we take it as a sign to dispose it by calling the dispose() method and > remove it from the cache? I was afraid that a file might suddenly disaappears during an update (say, someone renames it and then copies a new one). But as you said, this is a contradict to common sense. If the update is a direct copy (without renaming the old one first), the file will not disappear. I would treat "file missing" a valid case and remove it from the "error" list. This would need some changes to the CCC: 1. Remove "file missing" from error lists. 2. Add principal into KeyTab. Theoretically, a user can put multiple Krb5LoginModule all marked required for a JAAS login config named entry. They can use different keytabs and the keytabs can be both empty at the login time. We have no other way to guess which can be used by who and have to add the principal label. I'll send another mail when my edit is ready. Thanks Max > > Thanks, > Valerie From mike.duigou at oracle.com Mon Mar 21 11:49:59 2011 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Mon, 21 Mar 2011 18:49:59 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110321185018.6AD934734C@hg.openjdk.java.net> Changeset: e74e7991ba1d Author: mduigou Date: 2011-03-21 11:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e74e7991ba1d 7029491: fix broken test file committed with CR 5045147. Summary: an incorrect file was committed with CR 5045147. This commit corrects that error and also applies minor review suggestions. Reviewed-by: alanb ! test/java/util/TreeMap/EmptyMapAndNulls.java < test/java/util/TreeMap/cr5045147.java Changeset: 1d0039aea814 Author: mduigou Date: 2011-03-21 11:49 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1d0039aea814 Merge From xuelei.fan at oracle.com Mon Mar 21 22:02:52 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Tue, 22 Mar 2011 05:02:52 +0000 Subject: hg: jdk7/tl/jdk: 7027797: take care of ECDH_anon/DH_anon server key exchange for TLS 1.2 Message-ID: <20110322050318.A32FA4736A@hg.openjdk.java.net> Changeset: ef5bbbe0dd75 Author: xuelei Date: 2011-03-21 22:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ef5bbbe0dd75 7027797: take care of ECDH_anon/DH_anon server key exchange for TLS 1.2 Summary: the signature of server key exanage message could be null Reviewed-by: vinnie ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! test/sun/security/ec/TestEC.java ! test/sun/security/pkcs11/fips/CipherTest.java ! test/sun/security/pkcs11/sslecc/CipherTest.java ! test/sun/security/ssl/sanity/interop/CipherTest.java ! test/sun/security/ssl/sanity/interop/ClientJSSEServerJSSE.java From kelly.ohair at oracle.com Tue Mar 22 11:09:37 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Tue, 22 Mar 2011 18:09:37 +0000 Subject: hg: jdk7/tl/jdk: 6737397: Should support running JCK test suite with test/Makefile and JPRT Message-ID: <20110322180947.3AF0547399@hg.openjdk.java.net> Changeset: 870f7c3f0b61 Author: ohair Date: 2011-03-22 11:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/870f7c3f0b61 6737397: Should support running JCK test suite with test/Makefile and JPRT Reviewed-by: alanb ! make/jprt.properties ! test/Makefile ! test/ProblemList.txt From kelly.ohair at oracle.com Tue Mar 22 11:12:26 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Tue, 22 Mar 2011 18:12:26 +0000 Subject: hg: jdk7/tl: 6737397: Should support running JCK test suite with test/Makefile and JPRT Message-ID: <20110322181226.3A0794739A@hg.openjdk.java.net> Changeset: 970c0898ded2 Author: ohair Date: 2011-03-22 11:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/970c0898ded2 6737397: Should support running JCK test suite with test/Makefile and JPRT Reviewed-by: alanb ! make/jprt.properties ! test/Makefile From david.holmes at oracle.com Tue Mar 22 15:57:47 2011 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Tue, 22 Mar 2011 22:57:47 +0000 Subject: hg: jdk7/tl/jdk: 7025066: Build systems changes to support SE Embedded Integration Message-ID: <20110322225756.EA2E4473A7@hg.openjdk.java.net> Changeset: fe232d7e4ff1 Author: dholmes Date: 2011-03-22 18:56 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fe232d7e4ff1 7025066: Build systems changes to support SE Embedded Integration Summary: Define Embedded specific files and include them in the main files. Allow finer control over some build options. Reviewed-by: ohair, bobv, collins + make/common/Defs-embedded.gmk ! make/common/Defs.gmk ! make/common/Library.gmk + make/common/Release-embedded.gmk ! make/common/Release.gmk ! make/common/shared/Sanity-Settings.gmk ! make/java/zip/Makefile ! make/sun/nio/cs/Makefile ! src/share/classes/sun/misc/Version.java.template From bhavesh.patel at sun.com Tue Mar 22 18:34:24 2011 From: bhavesh.patel at sun.com (bhavesh.patel at sun.com) Date: Wed, 23 Mar 2011 01:34:24 +0000 Subject: hg: jdk7/tl/langtools: 7025314: NLS: translatability violation on standard.properties Message-ID: <20110323013426.44C65473BC@hg.openjdk.java.net> Changeset: 148d3dc4e1e1 Author: bpatel Date: 2011-03-22 18:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/148d3dc4e1e1 7025314: NLS: translatability violation on standard.properties Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! test/com/sun/javadoc/testJavascript/TestJavascript.java ! test/com/sun/javadoc/testNavagation/TestNavagation.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java From weijun.wang at oracle.com Wed Mar 23 02:00:46 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 23 Mar 2011 17:00:46 +0800 Subject: code review request: 6894072: always refresh keytab In-Reply-To: <4D86E217.7050709@oracle.com> References: <4CF6195A.6000301@oracle.com> <4D7A9D02.40106@oracle.com> <4D801157.6070009@oracle.com> <4D83F0B9.3050201@oracle.com> <4D86E217.7050709@oracle.com> Message-ID: <4D89B6BE.4020003@oracle.com> Hi Valerie Updated webrev: http://cr.openjdk.java.net/~weijun/6894072/webrev.02 Changes since last version: 1. A KerberosPrincipal inside javax..KeyTab class. New getInstance() arguments, new getPrincipal() method. It can only be non-null now, but I didn't say anything in the spec. I'm hoping it can be null in the future to support multiple service principal in a single service. 2. toString(), hashCode(), equals() for KeyTab, since it will be put inside private credentials set. 3. Enhancement to SubjectComber: a) Generics for find() and findMany() b) findAux() now support Krb5AcceptCredential 4. Krb5Util.ServiceCreds: since principal is already inside both KeyTab and KerberosKey, no more KerberosPrincipal argument in getInstance(), there is still a field inside to save the value. 5. sun..KeyTab and javax..KeyTab: isMissing==true is now valid. Changes to the javadoc of javax..KeyTab.getKeys(). 6. New TwoPrinces.java test, a subject with 2 KerberosPrincipal after JAAS commit. This time I'd like to first make sure implementation is correct, and then I'll update the CCC. Is this OK? Thanks Max From weijun.wang at oracle.com Wed Mar 23 03:28:19 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 23 Mar 2011 10:28:19 +0000 Subject: hg: jdk7/tl/jdk: 7028490: better suggestion for jarsigner when TSA is not accessible Message-ID: <20110323102849.0819F473D5@hg.openjdk.java.net> Changeset: c43811a602a8 Author: weijun Date: 2011-03-23 18:26 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c43811a602a8 7028490: better suggestion for jarsigner when TSA is not accessible Reviewed-by: mullan ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/JarSignerResources.java From Szabolcs.Pota at morganstanley.com Wed Mar 23 05:16:58 2011 From: Szabolcs.Pota at morganstanley.com (Szabolcs Pota) Date: Wed, 23 Mar 2011 13:16:58 +0100 Subject: Exception while processing 'no-addresses' flag in KrbApReq.java Message-ID: Hi All, I am testing Kerberos implementation in Open JDK (build 133, http://download.java.net/openjdk/jdk7/promoted/b133/) and run into an issue that maybe a bug in the KrbApReq class. I have started to investigate the issue in more details when I found that the same test setup runs without problem with JDK 6u21 to 6u23 but consistently fails with Open JDK. (I needed JDK 6u21+ because of a bug fix that caused lot of problems for us before: http://bugs.sun.com/view_bug.do?bug_id=6893158). Sorry for the verbose mail but I wanted to include all information. In my setup there is a client and a server that use the JGSS API (with Krb5LoginModule) and TCP connection to authenticate each other. However the server always fails with the following exception when it accepts client credentials: > Caused by: sun.security.krb5.internal.KrbApErrException: Incorrect net address (38) > ??????? at sun.security.krb5.KrbApReq.authenticate(KrbApReq.java:329) ~[na:na] > ??????? at sun.security.krb5.KrbApReq.(KrbApReq.java:146) ~[na:na] > ??????? at sun.security.jgss.krb5.InitSecContextToken.(InitSecContextToken.java:108) ~[na:na] > ??????? at sun.security.jgss.krb5.Krb5Context.acceptSecContext(Krb5Context.java:761) ~[na:na] I have looked into the KrbApReq class and found the Exception is related to handling the 'no-addresses' flag (coming from krb5.conf). Related code can be found from line 315 to 333 of KrbApReq.java. Analyzing the code I've managed to identify a scenario when the code cannot succeed but always throws the already mentioned exception. This scenario is when both on the client and server side the 'no-addresses' flag is set to 'false'. Here is a small table on the code behavior given the different values of the 'no-addresses' flag: +---------------------------------------------------------------------------------------------------------------------------+ | | Client ?no-addresses? true | Client ?no-addresses? false | +---------------------------------------------------------------------------------------------------------------------------+ | Server ?no-addresses? true | Success | Success | +---------------------------------------------------------------------------------------------------------------------------+ | Server ?no-addresses? false | Success | Always throws exception | +---------------------------------------------------------------------------------------------------------------------------+ Our global krb5.conf files have 'noaddresses=false' for both client and server hence we get this exception. Please correct me if someone thinks that setting this flag to false on the server side would be incorrect. To better understand what's happening in KrbApReq I've transformed the code from line 315 to 333 to have the same functionality but a more expressive structure. Besides two lines the comments are added by me. > ??????? // check to use addresses in tickets > ??????? // In my case 'noaddresses=false' hence useAddresses is true. > ??????? if (Config.getInstance().useAddresses()) { > ??????????? KDC_EMPTY_ADDRESSES_ALLOWED = false; > ??????? } > > ??????? // sender host address > ??????? HostAddress sender = null; > ??????? // If we are the client > ??????? if (initiator != null) { > ??????????? sender = new HostAddress(initiator); > ??????????? if (enc_ticketPart.caddr != null) { > ??????????????? if (!enc_ticketPart.caddr.inList(sender)) > ??????????????????? throw new KrbApErrException(Krb5.KRB_AP_ERR_BADADDR); > ??????????? } > ??????? } > ??????? // This else-if block executes only on the server side. On the server side > ??????? // if 'no-addresses' == false and on the client side it was set to false too > ??????? // (i.e. enc_ticketPart.caddr is not null) then this block will always throw > ??????? // exception. > ??????? // > ??????? // Given that sender is always null on the server side the internal if blocks > ??????? // make no sense. > ??????? // > ??????? else if (!KDC_EMPTY_ADDRESSES_ALLOWED) { > ??????????? // should we obtain sender from the connection? > ??????????? if (enc_ticketPart.caddr != null) { > ??????????????? if (sender == null) > ??????????????????? throw new KrbApErrException(Krb5.KRB_AP_ERR_BADADDR); > ??????????????? if (!enc_ticketPart.caddr.inList(sender)) > ??????????????????? throw new KrbApErrException(Krb5.KRB_AP_ERR_BADADDR); > ??????????? } > ??????? } You can deduce the same from the original code, however I think in this form it is easier to understand. At this point I am not really sure what is the correct behavior on the server side. However, reading RFC 4120 about the use of the EncTicketPart.caddr field it seems that server should identify the sender from the client connection. Though the RFC itself admits that it cannot be done reliable and only a best effort way to make stolen credential use harder (RFC 4120, page 71): > Note that the network address from which a connection is received > cannot be reliably determined.? Even if it could be, an attacker > who has compromised the client's workstation could use the > credentials from there.? Including the network addresses only > makes it more difficult, not impossible, for an attacker to walk > off with stolen credentials and then to use them from a "safe" > location. Could you please comment on this issue? Unfortunately we cannot change global krb5.conf settings easily (large financial corporation having offices world-wide) and this error prevents us using JGSS with OpenJDK. Best Regards, Szabolcs Pota From bhavesh.patel at sun.com Wed Mar 23 14:42:07 2011 From: bhavesh.patel at sun.com (bhavesh.patel at sun.com) Date: Wed, 23 Mar 2011 21:42:07 +0000 Subject: hg: jdk7/tl/langtools: 7010342: End tag for element P is not open for few html files generated using new javadoc Message-ID: <20110323214210.D2FB1473EC@hg.openjdk.java.net> Changeset: 72bdd232e0ea Author: bpatel Date: 2011-03-23 14:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/72bdd232e0ea 7010342: End tag for element P is not open for few html files generated using new javadoc Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css + test/com/sun/javadoc/testSubTitle/TestSubTitle.java + test/com/sun/javadoc/testSubTitle/pkg/C.java + test/com/sun/javadoc/testSubTitle/pkg/package.html From mike.duigou at oracle.com Wed Mar 23 15:07:02 2011 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 23 Mar 2011 22:07:02 +0000 Subject: hg: jdk7/tl/jdk: 7029997: Restyling of SortedMap Javadoc Message-ID: <20110323220726.34086473EE@hg.openjdk.java.net> Changeset: b58572df94f1 Author: mduigou Date: 2011-03-23 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b58572df94f1 7029997: Restyling of SortedMap Javadoc Reviewed-by: darcy, chegar ! src/share/classes/java/util/SortedMap.java From xuelei.fan at oracle.com Wed Mar 23 20:08:26 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 24 Mar 2011 03:08:26 +0000 Subject: hg: jdk7/tl/jdk: 7029848: KeyStoreBuilderParameters((Builder)null) does not throw NullPointerException Message-ID: <20110324030852.26A3A47404@hg.openjdk.java.net> Changeset: 3fee1c67bd10 Author: xuelei Date: 2011-03-23 20:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3fee1c67bd10 7029848: KeyStoreBuilderParameters((Builder)null) does not throw NullPointerException Summary: throws NPE for null Builder Reviewed-by: weijun ! src/share/classes/javax/net/ssl/KeyStoreBuilderParameters.java From xuelei.fan at oracle.com Wed Mar 23 20:26:23 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 24 Mar 2011 03:26:23 +0000 Subject: hg: jdk7/tl/jdk: 7030523: regression: imporper checking of paramater Message-ID: <20110324032632.BD0C047405@hg.openjdk.java.net> Changeset: b921112e39d3 Author: xuelei Date: 2011-03-23 20:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b921112e39d3 7030523: regression: imporper checking of paramater Reviewed-by: weijun ! src/share/classes/javax/net/ssl/KeyStoreBuilderParameters.java From weijun.wang at oracle.com Thu Mar 24 01:17:04 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 24 Mar 2011 08:17:04 +0000 Subject: hg: jdk7/tl/jdk: 7030174: Jarsigner should accept TSACert with an HTTPS id-ad-timeStamping SIA Message-ID: <20110324081714.1BF8147415@hg.openjdk.java.net> Changeset: 65e7fddf517f Author: weijun Date: 2011-03-24 16:16 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/65e7fddf517f 7030174: Jarsigner should accept TSACert with an HTTPS id-ad-timeStamping SIA Reviewed-by: xuelei ! src/share/classes/sun/security/tools/TimestampedSigner.java From weijun.wang at oracle.com Thu Mar 24 06:12:59 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 24 Mar 2011 21:12:59 +0800 Subject: code review request: 7023056: NPE from sun.security.util.ManifestEntryVerifier.verify during Maven build Message-ID: <4D8B435B.7050804@oracle.com> Hi Sean This is a regression made by my former treat-MANIFEST.MF-as-signed code change. Webrev here: http://cr.openjdk.java.net/~weijun/7023056/webrev.00/ For the reason, see the evaluation below. === *Description* ================================================ Running a Maven build of Glassfish sources fails using JDK 7. java.lang.NullPointerException at java.util.Hashtable.remove(Hashtable.java:474) at sun.security.util.ManifestEntryVerifier.verify(ManifestEntryVerifier.java:226) === *Evaluation* ================================================= This is a regression made by 7004035: signed jar with only META-INF/* inside is not verifiable. The jar verification has always been done in two steps: 1. verify the signature of SF file against its BLOCK file. This generates a map of entry name vs its possible signers, saved in sigFileSigners. This is performed only once for each SF file. 2. verify the digest of each entry. Each time an entry gets verified, its possible signers are moved to verified signers, saved in another map -- verifiedSigners. For each entry, this step should be performed exactly once, by looking at if it has a digest line and if it's still inside sigFileSigners. Since 7004035, the MANIFEST.MF file is treated as signed. But it's a very special signed entry: it has no digest line in itself or any SF file Therefore, in step 2 above for this file, we ignore the skip flag and always try the move (well, it has to be moved once to be treated as signed). This triggers an inconsistency: a name argument for ManifestEntryVerifier.verify() method is set to null to trigger the skip flag, but we ignore it, and then there comes a stage when this argument is used, and NPE. Solution: MANIFEST.MF is special so we treat it specially, by moving its possible signers to verifiedSigners as soon as the META-INF entries are processed, that is, in the JarFile.doneWithMeta() method. Back to ManifestEntryVerifier.verify(), we'll keep revert to the old behavior to always honoring the skip flag. In fact, this flag will be always true for the MANIFEST.MF entry. Thanks Max From sean.mullan at oracle.com Thu Mar 24 06:49:53 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 24 Mar 2011 09:49:53 -0400 Subject: Code Review Request for translatability bugs Message-ID: <4D8B4C01.6000801@oracle.com> Max, Freda, Could you please review this webrev for a batch of translatability bugs: http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.00/ Thanks, Sean From sean.mullan at oracle.com Thu Mar 24 10:09:18 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 24 Mar 2011 13:09:18 -0400 Subject: code review request: 7023056: NPE from sun.security.util.ManifestEntryVerifier.verify during Maven build In-Reply-To: <4D8B435B.7050804@oracle.com> References: <4D8B435B.7050804@oracle.com> Message-ID: <4D8B7ABE.3040400@oracle.com> Hi Max, The fix looks good. I suggest you also remove this comment in ManifestEntryVerifier: 198 // MANIFEST.MF should not be skipped. It has signers. and add a similar comment to JarSigner.doneWithMeta. Also, in the test, I think you should add a try/finally clause and close the 2 InputStreams. --Sean On 3/24/11 9:12 AM, Weijun Wang wrote: > Hi Sean > > This is a regression made by my former treat-MANIFEST.MF-as-signed code change. > Webrev here: > > http://cr.openjdk.java.net/~weijun/7023056/webrev.00/ > > For the reason, see the evaluation below. > > === *Description* ================================================ > Running a Maven build of Glassfish sources fails using JDK 7. > > java.lang.NullPointerException > at java.util.Hashtable.remove(Hashtable.java:474) > at sun.security.util.ManifestEntryVerifier.verify(ManifestEntryVerifier.java:226) > > === *Evaluation* ================================================= > This is a regression made by > 7004035: signed jar with only META-INF/* inside is not verifiable. > > The jar verification has always been done in two steps: > > 1. verify the signature of SF file against its BLOCK file. This generates a map > of entry name vs its possible signers, saved in sigFileSigners. This is > performed only once for each SF file. > > 2. verify the digest of each entry. Each time an entry gets verified, its > possible signers are moved to verified signers, saved in another map -- > verifiedSigners. For each entry, this step should be performed exactly once, by > looking at if it has a digest line and if it's still inside sigFileSigners. > > Since 7004035, the MANIFEST.MF file is treated as signed. But it's a very > special signed entry: > > it has no digest line in itself or any SF file > > Therefore, in step 2 above for this file, we ignore the skip flag and always try > the move (well, it has to be moved once to be treated as signed). This triggers > an inconsistency: a name argument for ManifestEntryVerifier.verify() method is > set to null to trigger the skip flag, but we ignore it, and then there comes a > stage when this argument is used, and NPE. > > Solution: MANIFEST.MF is special so we treat it specially, by moving its > possible signers to verifiedSigners as soon as the META-INF entries are > processed, that is, in the JarFile.doneWithMeta() method. Back to > ManifestEntryVerifier.verify(), we'll keep revert to the old behavior to always > honoring the skip flag. In fact, this flag will be always true for the > MANIFEST.MF entry. > > Thanks > Max > From jim.holmlund at sun.com Thu Mar 24 11:42:58 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Thu, 24 Mar 2011 18:42:58 +0000 Subject: hg: jdk7/tl/jdk: 7029823: (ann) test/java/lang/annotation/package-info.java no longer compiles Message-ID: <20110324184308.37E4347438@hg.openjdk.java.net> Changeset: 632a96f5752d Author: jjh Date: 2011-03-24 11:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/632a96f5752d 7029823: (ann) test/java/lang/annotation/package-info.java no longer compiles Summary: Use @Deprecated instead of @java.lang.annotation.Documented Reviewed-by: jjg, smarks ! test/java/lang/annotation/PackageMain.java ! test/java/lang/annotation/package-info.java From bradford.wetmore at oracle.com Thu Mar 24 13:15:41 2011 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Thu, 24 Mar 2011 13:15:41 -0700 Subject: Code Review Request for translatability bugs In-Reply-To: <4D8B4C01.6000801@oracle.com> References: <4D8B4C01.6000801@oracle.com> Message-ID: <4D8BA66D.7000109@oracle.com> On 3/24/2011 6:49 AM, Sean Mullan wrote: > Max, Freda, > > Could you please review this webrev for a batch of translatability bugs: > > http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.00/ KeyTool.java: ============= Looks good. Only minor comments about line length, which is kind of hard in this environment. Brad From jonathan.gibbons at oracle.com Thu Mar 24 16:14:41 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 24 Mar 2011 23:14:41 +0000 Subject: hg: jdk7/tl/langtools: 6597678: JavaCompiler.getStandardFileManager always uses default charset not the one that user specifies Message-ID: <20110324231444.02D5947452@hg.openjdk.java.net> Changeset: 83260b3305ac Author: jjg Date: 2011-03-24 16:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/83260b3305ac 6597678: JavaCompiler.getStandardFileManager always uses default charset not the one that user specifies Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/JavacMessages.java + test/tools/javac/util/T6597678.java From stuart.marks at oracle.com Thu Mar 24 17:25:45 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 25 Mar 2011 00:25:45 +0000 Subject: hg: jdk7/tl/jdk: 7029680: fix test/sun/misc/Version/Version.java build parsing Message-ID: <20110325002602.0F23247455@hg.openjdk.java.net> Changeset: f326a018fd3f Author: smarks Date: 2011-03-24 17:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f326a018fd3f 7029680: fix test/sun/misc/Version/Version.java build parsing Reviewed-by: ohair ! test/sun/misc/Version/Version.java From weijun.wang at oracle.com Thu Mar 24 18:35:32 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 25 Mar 2011 09:35:32 +0800 Subject: Code Review Request for translatability bugs In-Reply-To: <4D8BA66D.7000109@oracle.com> References: <4D8B4C01.6000801@oracle.com> <4D8BA66D.7000109@oracle.com> Message-ID: <4D8BF164.6090802@oracle.com> AuthResources.java: =================== 1. {"expected.", "expected "}, - {".read.end.of.file", ", read end of file"}, + {"expected.expect.read.end.of.file.", + "expected {0}, read end of file"}, The "expected." is now useless. At least I grep thru all jdk/src files and see none of it. 2. - {"provided.null.name", "provided null name"} This one is still used in: ./com/sun/security/auth/SolarisPrincipal.java:79 ./com/sun/security/auth/SolarisNumericGroupPrincipal.java:92 ./com/sun/security/auth/SolarisNumericUserPrincipal.java:83 ./com/sun/security/auth/X500Principal.java:90 There is an entry with the same name in Resources.java, but unfortunately our codes use both. Thanks Max On 03/25/2011 04:15 AM, Brad Wetmore wrote: > > On 3/24/2011 6:49 AM, Sean Mullan wrote: >> Max, Freda, >> >> Could you please review this webrev for a batch of translatability bugs: >> >> http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.00/ > > KeyTool.java: > ============= > Looks good. Only minor comments about line length, which is kind of hard > in this environment. > > Brad From weijun.wang at oracle.com Thu Mar 24 20:59:12 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 25 Mar 2011 03:59:12 +0000 Subject: hg: jdk7/tl/jdk: 7023056: NPE from sun.security.util.ManifestEntryVerifier.verify during Maven build Message-ID: <20110325035922.39CAA47460@hg.openjdk.java.net> Changeset: 4a64eefbfd7a Author: weijun Date: 2011-03-25 11:58 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4a64eefbfd7a 7023056: NPE from sun.security.util.ManifestEntryVerifier.verify during Maven build Reviewed-by: mullan ! src/share/classes/java/util/jar/JarVerifier.java ! src/share/classes/sun/security/util/ManifestEntryVerifier.java + test/java/util/jar/JarFile/MevNPE.java From weijun.wang at oracle.com Thu Mar 24 21:15:30 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 25 Mar 2011 12:15:30 +0800 Subject: Code Review Request for translatability bugs In-Reply-To: <4D8BF164.6090802@oracle.com> References: <4D8B4C01.6000801@oracle.com> <4D8BA66D.7000109@oracle.com> <4D8BF164.6090802@oracle.com> Message-ID: <4D8C16E2.1050402@oracle.com> Another thing, maybe you can also combine the JarSigner TSA-unavailable warnings like you did for KeyTool integrity-not-checked ones? I've attached a diff and you can directly apply it at jdk level. Thanks Max On 03/25/2011 09:35 AM, Weijun Wang wrote: > AuthResources.java: > =================== > > 1. > > {"expected.", "expected "}, > - {".read.end.of.file", ", read end of file"}, > + {"expected.expect.read.end.of.file.", > + "expected {0}, read end of file"}, > > The "expected." is now useless. At least I grep thru all jdk/src files > and see none of it. > > 2. > > - {"provided.null.name", "provided null name"} > > This one is still used in: > > ./com/sun/security/auth/SolarisPrincipal.java:79 > ./com/sun/security/auth/SolarisNumericGroupPrincipal.java:92 > ./com/sun/security/auth/SolarisNumericUserPrincipal.java:83 > ./com/sun/security/auth/X500Principal.java:90 > > There is an entry with the same name in Resources.java, but > unfortunately our codes use both. > > > Thanks > Max > > > On 03/25/2011 04:15 AM, Brad Wetmore wrote: >> >> On 3/24/2011 6:49 AM, Sean Mullan wrote: >>> Max, Freda, >>> >>> Could you please review this webrev for a batch of translatability bugs: >>> >>> http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.00/ >> >> KeyTool.java: >> ============= >> Looks good. Only minor comments about line length, which is kind of hard >> in this environment. >> >> Brad -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: p Url: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20110325/bc285ee7/p.ksh From david.holmes at oracle.com Fri Mar 25 04:10:37 2011 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Fri, 25 Mar 2011 11:10:37 +0000 Subject: hg: jdk7/tl/jdk: 7030063: AWT support for SE-Embedded integration Message-ID: <20110325111102.3AC7E47475@hg.openjdk.java.net> Changeset: a2793622a8d8 Author: dholmes Date: 2011-03-25 07:09 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a2793622a8d8 7030063: AWT support for SE-Embedded integration Summary: AWT support for SE-Embedded Reviewed-by: anthony, art, bobv, collins, alanb ! make/launchers/Makefile ! make/sun/Makefile ! make/sun/awt/mawt.gmk ! make/sun/jawt/Makefile ! make/sun/jpeg/Makefile ! make/sun/security/tools/Makefile ! make/sun/xawt/Makefile ! src/share/classes/java/awt/Toolkit.java + src/share/classes/sun/awt/HToolkit.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java ! src/solaris/native/java/lang/java_props_md.c ! src/solaris/native/sun/awt/jawt.c ! src/solaris/native/sun/xawt/XToolkit.c From Szabolcs.Pota at morganstanley.com Fri Mar 25 04:53:42 2011 From: Szabolcs.Pota at morganstanley.com (Szabolcs Pota) Date: Fri, 25 Mar 2011 12:53:42 +0100 Subject: Exception while processing 'no-addresses' flag in KrbApReq.java In-Reply-To: References: Message-ID: [+ adding back security-dev] Hi Henry, Thank you for your reply. My answers are below. On Fri, Mar 25, 2011 at 1:26 AM, Henry B. Hotz wrote: > No-list reply since I'm subscribed with an alias which my ISP won't let me > send with. > > On Mar 23, 2011, at 5:16 AM, Szabolcs Pota wrote: > > > Our global krb5.conf files have 'noaddresses=false' for both client > > and server hence we get this exception. Please correct me if someone > > thinks that setting this flag to false on the server side would be > > incorrect. > > There are two issues here. The one you're not looking at is that that > config option is different for every one of the major C implementations of > Kerberos. > > [appdefaults] > no-addresses = true # Heimdal > no_addresses = true # Sun > > [lidefaults] > noaddresses = true # MIT > > I have no idea which of these is understood by Java, though I would guess > the Sun one, and hope that all of them are. Also the default value varies > with the version. AFAIK all now default to disable address checking. > > As I've seen in sun.security.krb5.Config#useAddresses() it reads either the 'noaddresses' or the 'no-addresses' flag and indeed the default is no-addresses=true. We are using 'noaddresses' that is parsed without problems by the current code. > ------ > > As for what you are actually asking about: almost all of us have stopped > worrying about addresses because the address check does not work in the real > world with ubiquitous NAT and multiple private IP spaces. (Are you sure > you're not running into one of those?) I personally would not care if Java > simply stopped supporting address checking. > > That may not be an appropriate thing for the universal JGSS implementation > to do though. > > What's *supposed* to happen (without reading the RFC) is the endpoint gets > the IP from the socket for the other end, and compares it with the > appropriate field in the ticket. If they don't match, then the ticket *may* > have been copied and is being injected from someplace it shouldn't be. > > Since (almost) nobody is using the feature anymore I would actually be > surprised if it works on IPv6 networks. As I said it is guaranteed to fail > if there is a NAT involved. > > ----- > > To answer the specific question in the above paragraph, I would say > checking addresses on a server is actually wrong if *any* of the clients are > connecting via VPN, or through your typical home router box. It can only be > guaranteed correct if all clients are on the same corporate network as the > server. > > I agree with you that checking the client address is error prone and even the RFC says so. It could be done only on a best effort basis. At the moment I think that the server should do one of the followings: 1. If EncTicketPart.caddr is set then try to get the client IP and check if it is in the list. If it is not then it *may* throw and exception. 2. Skip the whole no-addresses processing because of the unreliable client IP check. My problem is that the current logic in KrbApReq java does non of these but throws an Exception. This prevents us using OpenJDK with 'noaddresses=false' in Kerberos configuration. Regards, Szabolcs > ------------------------------------------------------ > The opinions expressed in this message are mine, > not those of Caltech, JPL, NASA, or the US Government. > Henry.B.Hotz at jpl.nasa.gov, or hbhotz at oxy.edu > > > > -- Szabolcs Pota Morgan Stanley | MSJava, EAI (MSSM) Lechner Odon fasor 8 | Floor 07 Budapest, 1095 Phone: +36 1 881-3979 Szabolcs.Pota at morganstanley.com -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20110325/92d218b7/attachment.html From jonathan.gibbons at oracle.com Fri Mar 25 07:40:02 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 25 Mar 2011 14:40:02 +0000 Subject: hg: jdk7/tl/langtools: 7009599: javac build puts extraneous files into dist/lib/classes.jar Message-ID: <20110325144007.2DA8D47482@hg.openjdk.java.net> Changeset: 26ea2557214a Author: jjg Date: 2011-03-25 07:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/26ea2557214a 7009599: javac build puts extraneous files into dist/lib/classes.jar Reviewed-by: ohair ! make/build.xml From jonathan.gibbons at oracle.com Fri Mar 25 07:59:32 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 25 Mar 2011 14:59:32 +0000 Subject: hg: jdk7/tl/langtools: 6437138: JSR 199: Compiler doesn't diagnose crash in user code; ... Message-ID: <20110325145934.AF7D447484@hg.openjdk.java.net> Changeset: 31e5cfc5a990 Author: jjg Date: 2011-03-25 07:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/31e5cfc5a990 6437138: JSR 199: Compiler doesn't diagnose crash in user code 6482554: uncaught exception from annotation processor not reported through JavaCompiler.CompilationTask.call Reviewed-by: mcimadamore + src/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/api/T6437138.java + test/tools/javac/api/TestClientCodeWrapper.java From chris.hegarty at oracle.com Fri Mar 25 09:39:46 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 25 Mar 2011 16:39:46 +0000 Subject: hg: jdk7/tl/jdk: 7030256: Cleanup/Remove code supporting old Windows versions (98, NT, 2000, etc) Message-ID: <20110325164005.569754748A@hg.openjdk.java.net> Changeset: c250a66c3b54 Author: chegar Date: 2011-03-25 16:38 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c250a66c3b54 7030256: Cleanup/Remove code supporting old Windows versions (98, NT, 2000, etc) Reviewed-by: alanb, mduigou ! make/java/net/Makefile ! src/windows/native/java/net/Inet6AddressImpl.c ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface.h - src/windows/native/java/net/NetworkInterface_win9x.c ! src/windows/native/java/net/NetworkInterface_winXP.c ! src/windows/native/java/net/net_util_md.c ! src/windows/native/java/net/net_util_md.h ! src/windows/native/sun/net/dns/ResolverConfigurationImpl.c ! src/windows/native/sun/net/www/protocol/http/ntlm/NTLMAuthSequence.c From mike.duigou at oracle.com Fri Mar 25 11:28:46 2011 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 25 Mar 2011 18:28:46 +0000 Subject: hg: jdk7/tl/jdk: 7030442: Add missing @param tag for Collections.reverseOrder() Message-ID: <20110325182856.5C9FB47497@hg.openjdk.java.net> Changeset: d0d2c1014faa Author: mduigou Date: 2011-03-25 11:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d0d2c1014faa 7030442: Add missing @param tag for Collections.reverseOrder() Reviewed-by: darcy, alanb ! src/share/classes/java/util/Collections.java From bhavesh.patel at sun.com Fri Mar 25 15:20:51 2011 From: bhavesh.patel at sun.com (bhavesh.patel at sun.com) Date: Fri, 25 Mar 2011 22:20:51 +0000 Subject: hg: jdk7/tl/langtools: 7001086: NLS: un-used resources should be removed from standard.properties and improper concatenation Message-ID: <20110325222053.8C166474A2@hg.openjdk.java.net> Changeset: 442b1366cfdf Author: bpatel Date: 2011-03-25 15:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/442b1366cfdf 7001086: NLS: un-used resources should be removed from standard.properties and improper concatenation Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties + test/com/sun/javadoc/testNonFrameWarning/TestNonFrameWarning.java + test/com/sun/javadoc/testNonFrameWarning/pkg/C.java From valerie.peng at oracle.com Fri Mar 25 17:20:13 2011 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 25 Mar 2011 17:20:13 -0700 Subject: code review request: 6894072: always refresh keytab In-Reply-To: <4D89B6BE.4020003@oracle.com> References: <4CF6195A.6000301@oracle.com> <4D7A9D02.40106@oracle.com> <4D801157.6070009@oracle.com> <4D83F0B9.3050201@oracle.com> <4D86E217.7050709@oracle.com> <4D89B6BE.4020003@oracle.com> Message-ID: <4D8D313D.4080808@oracle.com> Max, Well, I find it a bit awkward that the KeyTab class has to have the KerberosPrincipal info which "intends" to use it. Have you considered a different approach like: Instead of adding the whole KeyTab object into the Subject's private credential set, we add a "to-be-resolved" KerberosKey object. When we need to use this kind of key, we'd check the associated KeyTab object to re-fresh its value if needed. This approach is conceptually closer to what we had and the changes aren't as dramatic and seems to meet the need required by 6894072. I'll continue to review your webrev, but just want to kick this idea off w/ you and see if it may work. Valerie On 03/23/11 02:00 AM, Weijun Wang wrote: > Hi Valerie > > Updated webrev: > > http://cr.openjdk.java.net/~weijun/6894072/webrev.02 > > Changes since last version: > > 1. A KerberosPrincipal inside javax..KeyTab class. New getInstance() > arguments, new getPrincipal() method. > > It can only be non-null now, but I didn't say anything in the spec. > I'm hoping it can be null in the future to support multiple service > principal in a single service. > > 2. toString(), hashCode(), equals() for KeyTab, since it will be put > inside private credentials set. > > 3. Enhancement to SubjectComber: > a) Generics for find() and findMany() > b) findAux() now support Krb5AcceptCredential > > 4. Krb5Util.ServiceCreds: since principal is already inside both > KeyTab and KerberosKey, no more KerberosPrincipal argument in > getInstance(), there is still a field inside to save the value. > > 5. sun..KeyTab and javax..KeyTab: isMissing==true is now valid. > Changes to the javadoc of javax..KeyTab.getKeys(). > > 6. New TwoPrinces.java test, a subject with 2 KerberosPrincipal after > JAAS commit. > > This time I'd like to first make sure implementation is correct, and > then I'll update the CCC. Is this OK? > > Thanks > Max From joe.darcy at oracle.com Fri Mar 25 18:27:26 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 26 Mar 2011 01:27:26 +0000 Subject: hg: jdk7/tl/jdk: 7031371: Clarify javadoc of Throwable, including addSuppressed Message-ID: <20110326012736.DEBC0474AC@hg.openjdk.java.net> Changeset: cf743d5ca712 Author: darcy Date: 2011-03-25 18:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cf743d5ca712 7031371: Clarify javadoc of Throwable, including addSuppressed Reviewed-by: smarks, mduigou ! src/share/classes/java/lang/Throwable.java From joe.darcy at oracle.com Fri Mar 25 18:48:22 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 26 Mar 2011 01:48:22 +0000 Subject: hg: jdk7/tl/jdk: 7031376: Typos in javadoc of TimSort classes Message-ID: <20110326014832.35F07474AE@hg.openjdk.java.net> Changeset: e4e3dd6a7930 Author: darcy Date: 2011-03-25 18:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e4e3dd6a7930 7031376: Typos in javadoc of TimSort classes Reviewed-by: darcy Contributed-by: jjb at google.com ! src/share/classes/java/util/ComparableTimSort.java ! src/share/classes/java/util/TimSort.java From alta.gome at gmail.com Fri Mar 25 23:36:01 2011 From: alta.gome at gmail.com (A. Gomes) Date: Sat, 26 Mar 2011 03:36:01 -0300 Subject: Problem with OpenJDK Java runtime (6b20) and Superdonate Message-ID: There's a security issue which prevents Superdonate app ( http://www.superdonate.org/) from loading. Following message appears at trial: $ ./run_superdonate_linux.sh Error occurred during initialization of VM java.lang.InternalError: Could not create SecurityManager: com.superdonate.application.PluraSecurityManager at sun.misc.Launcher.(Launcher.java:106) at sun.misc.Launcher.(Launcher.java:59) at java.lang.ClassLoader.initSystemClassLoader(ClassLoader.java:1304) at java.lang.ClassLoader.getSystemClassLoader(ClassLoader.java:1286) -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20110326/c9720d7f/attachment.html From weijun.wang at oracle.com Sun Mar 27 22:26:16 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 28 Mar 2011 13:26:16 +0800 Subject: code review request: 7019384: Realm.getRealmsList returns realms list in wrong (reverse) order Message-ID: <4D901BF8.1060600@oracle.com> Hi Xuelei We fixed an [capaths] bug some time ago: 6789935: cross-realm capath search error http://hg.openjdk.java.net/jdk7/tl/jdk/rev/33bc32405045 Unfortunately, it's still not correct. Here is a new webrev: http://cr.openjdk.java.net/~weijun/7019384/webrev.00/ As described in the bug report, we searched paths from target(sRealm) to initiator(cRealm), but the capaths returned by the method *should* be from cRealm to sRealm. I reversed the tempList in the fix. Also, the first item in tempList is now sRealm, this order has a consistent meaning, and avoids some extra loop check. Another "!intermediaries.equals(cRealm)" check is added to be more robust. Thanks Max -------- Original Message -------- *Change Request ID*: 7019384 *Synopsis*: Realm.getRealmsList returns realms list in wrong (reverse) order === *Description* ============================================================ FULL PRODUCT VERSION : Checked on Java SE 6.23 and OpenJDK 7. A DESCRIPTION OF THE PROBLEM : sun.security.krb5.Realm.getRealmsList returns realms list in wrong order: - cRealm is always first (this is OK) - the rest however is in reverse order For one intermediate realm nothing happens. For two or more intermediate realms sun.security.krb5.internal.CredentialsUtil.acquireServiceCreds traverses realms in wrong order and cann't get service ticket. Checked on Java SE 6.23 and OpenJDK 7. STEPS TO FOLLOW TO REPRODUCE THE PROBLEM : [capaths] A9.PRAGUE.XXX.CZ = { PRAGUE.XXX.CZ = . ROOT.XXX.CZ = PRAGUE.XXX.CZ SERVIS.XXX.CZ = ROOT.XXX.CZ } EXPECTED VERSUS ACTUAL BEHAVIOR : EXPECTED - >>> Realm parseCapaths [0]=A9.PRAGUE.XXX.CZ >>> Realm parseCapaths [1]=PRAGUE.XXX.CZ >>> Realm parseCapaths [2]=ROOT.XXX.CZ ACTUAL - >>> Realm parseCapaths [0]=A9.PRAGUE.XXX.CZ >>> Realm parseCapaths [1]=ROOT.XXX.CZ >>> Realm parseCapaths [2]=PRAGUE.XXX.CZ ERROR MESSAGES/STACK TRACES THAT OCCUR : >>> Realm doInitialParse: cRealm=[A9.PRAGUE.XXX.CZ], sRealm=[SERVIS.XXX.CZ] >>> Realm parseCapaths: loop 1: target=SERVIS.XXX.CZ >>> Realm parseCapaths: loop 1: intermediaries=[ROOT.XXX.CZ] >>> Realm parseCapaths: loop 1: pushed realm on to stack: ROOT.XXX.CZ >>> Realm parseCapaths: loop 1: added intermediary to list: ROOT.XXX.CZ >>> Realm parseCapaths: loop 2: target=ROOT.XXX.CZ >>> Realm parseCapaths: loop 2: intermediaries=[PRAGUE.XXX.CZ] >>> Realm parseCapaths: loop 2: pushed realm on to stack: PRAGUE.XXX.CZ >>> Realm parseCapaths: loop 2: added intermediary to list: PRAGUE.XXX.CZ >>> Realm parseCapaths: loop 3: target=PRAGUE.XXX.CZ >>> Realm parseCapaths: loop 3: no intermediaries >>> Realm parseCapaths [0]=A9.PRAGUE.XXX.CZ >>> Realm parseCapaths [1]=ROOT.XXX.CZ >>> Realm parseCapaths [2]=PRAGUE.XXX.CZ REPRODUCIBILITY : This bug can be reproduced always. ---------- BEGIN SOURCE ---------- Enhancements for OpenJDK 7 test suite: Add to b/test/sun/security/krb5/krb5-capaths.conf: [capaths] A9.PRAGUE.XXX.CZ = { PRAGUE.XXX.CZ = . ROOT.XXX.CZ = PRAGUE.XXX.CZ SERVIS.XXX.CZ = ROOT.XXX.CZ } Add to b/test/sun/security/krb5/ParseCAPaths.java: // Multiple intermediate realms check("A9.PRAGUE.XXX.CZ", "SERVIS.XXX.CZ", "A9.PRAGUE.XXX.CZ", "PRAGUE.XXX.CZ", "ROOT.XXX.CZ"); From xuelei.fan at oracle.com Sun Mar 27 23:35:23 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 28 Mar 2011 14:35:23 +0800 Subject: code review request: 7019384: Realm.getRealmsList returns realms list in wrong (reverse) order In-Reply-To: <4D901BF8.1060600@oracle.com> References: <4D901BF8.1060600@oracle.com> Message-ID: <4D902C2B.9050605@oracle.com> Looks fine to me. Andrew On 3/28/2011 1:26 PM, Weijun Wang wrote: > Hi Xuelei > > We fixed an [capaths] bug some time ago: > > 6789935: cross-realm capath search error > http://hg.openjdk.java.net/jdk7/tl/jdk/rev/33bc32405045 > > Unfortunately, it's still not correct. Here is a new webrev: > > http://cr.openjdk.java.net/~weijun/7019384/webrev.00/ > > As described in the bug report, we searched paths from target(sRealm) > to initiator(cRealm), but the capaths returned by the method *should* > be from cRealm to sRealm. > > I reversed the tempList in the fix. > > Also, the first item in tempList is now sRealm, this order has a > consistent meaning, and avoids some extra loop check. > > Another "!intermediaries.equals(cRealm)" check is added to be more > robust. > > Thanks > Max > > -------- Original Message -------- > *Change Request ID*: 7019384 > *Synopsis*: Realm.getRealmsList returns realms list in wrong (reverse) > order > > > === *Description* > ============================================================ > FULL PRODUCT VERSION : > Checked on Java SE 6.23 and OpenJDK 7. > > A DESCRIPTION OF THE PROBLEM : > sun.security.krb5.Realm.getRealmsList returns realms list in wrong order: > - cRealm is always first (this is OK) > - the rest however is in reverse order > > For one intermediate realm nothing happens. For two or more > intermediate realms > sun.security.krb5.internal.CredentialsUtil.acquireServiceCreds > traverses realms in wrong order and cann't get service ticket. > > Checked on Java SE 6.23 and OpenJDK 7. > > > > STEPS TO FOLLOW TO REPRODUCE THE PROBLEM : > [capaths] > A9.PRAGUE.XXX.CZ = { > PRAGUE.XXX.CZ = . > ROOT.XXX.CZ = PRAGUE.XXX.CZ > SERVIS.XXX.CZ = ROOT.XXX.CZ > } > > EXPECTED VERSUS ACTUAL BEHAVIOR : > EXPECTED - >>>> Realm parseCapaths [0]=A9.PRAGUE.XXX.CZ >>>> Realm parseCapaths [1]=PRAGUE.XXX.CZ >>>> Realm parseCapaths [2]=ROOT.XXX.CZ > > ACTUAL - >>>> Realm parseCapaths [0]=A9.PRAGUE.XXX.CZ >>>> Realm parseCapaths [1]=ROOT.XXX.CZ >>>> Realm parseCapaths [2]=PRAGUE.XXX.CZ > > ERROR MESSAGES/STACK TRACES THAT OCCUR : >>>> Realm doInitialParse: cRealm=[A9.PRAGUE.XXX.CZ], >>>> sRealm=[SERVIS.XXX.CZ] >>>> Realm parseCapaths: loop 1: target=SERVIS.XXX.CZ >>>> Realm parseCapaths: loop 1: intermediaries=[ROOT.XXX.CZ] >>>> Realm parseCapaths: loop 1: pushed realm on to stack: ROOT.XXX.CZ >>>> Realm parseCapaths: loop 1: added intermediary to list: ROOT.XXX.CZ >>>> Realm parseCapaths: loop 2: target=ROOT.XXX.CZ >>>> Realm parseCapaths: loop 2: intermediaries=[PRAGUE.XXX.CZ] >>>> Realm parseCapaths: loop 2: pushed realm on to stack: PRAGUE.XXX.CZ >>>> Realm parseCapaths: loop 2: added intermediary to list: PRAGUE.XXX.CZ >>>> Realm parseCapaths: loop 3: target=PRAGUE.XXX.CZ >>>> Realm parseCapaths: loop 3: no intermediaries >>>> Realm parseCapaths [0]=A9.PRAGUE.XXX.CZ >>>> Realm parseCapaths [1]=ROOT.XXX.CZ >>>> Realm parseCapaths [2]=PRAGUE.XXX.CZ > > REPRODUCIBILITY : > This bug can be reproduced always. > > ---------- BEGIN SOURCE ---------- > Enhancements for OpenJDK 7 test suite: > > Add to b/test/sun/security/krb5/krb5-capaths.conf: > > [capaths] > A9.PRAGUE.XXX.CZ = { > PRAGUE.XXX.CZ = . > ROOT.XXX.CZ = PRAGUE.XXX.CZ > SERVIS.XXX.CZ = ROOT.XXX.CZ > } > > > Add to b/test/sun/security/krb5/ParseCAPaths.java: > > // Multiple intermediate realms > check("A9.PRAGUE.XXX.CZ", "SERVIS.XXX.CZ", "A9.PRAGUE.XXX.CZ", > "PRAGUE.XXX.CZ", "ROOT.XXX.CZ"); From weijun.wang at oracle.com Mon Mar 28 01:23:29 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 28 Mar 2011 16:23:29 +0800 Subject: code review request: 7031536: test/sun/security/krb5/auto/HttpNegotiateServer.java should not use static ports Message-ID: <4D904581.6040300@oracle.com> Hi Xuelei This webrev includes 2 kinds of code changes: http://cr.openjdk.java.net/~weijun/7031536/webrev.00/ 1. HttpNegotiateServer: now servers open on port 0. 2. Others: I add run/othervm for all tests in jgss and krb5 that call System.setProperty Thanks Max -------- Original Message -------- *Change Request ID*: 7031536 *Synopsis*: test/sun/security/krb5/auto/HttpNegotiateServer.java should not use static ports === *Description* ============================================================ test/sun/security/krb5/auto/HttpNegotiateServer.java uses static port numbers when starting web and proxy servers. If another process uses the same ports, test would fail. From xuelei.fan at oracle.com Mon Mar 28 02:22:29 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 28 Mar 2011 17:22:29 +0800 Subject: code review request: 7031536: test/sun/security/krb5/auto/HttpNegotiateServer.java should not use static ports In-Reply-To: <4D904581.6040300@oracle.com> References: <4D904581.6040300@oracle.com> Message-ID: <4D905355.3070902@oracle.com> On 3/28/2011 4:23 PM, Weijun Wang wrote: > Hi Xuelei > > This webrev includes 2 kinds of code changes: > > http://cr.openjdk.java.net/~weijun/7031536/webrev.00/ > > 1. HttpNegotiateServer: now servers open on port 0. Looks fine. > > 2. Others: I add run/othervm for all tests in jgss and krb5 that call > System.setProperty > As it only impact the test cases, I did not look into the code very carefully. There is no bad impact to add the "run/othervm" for all test. So generally, those update looks good to me, too. Xuelei > Thanks > Max > > > -------- Original Message -------- > *Change Request ID*: 7031536 > > *Synopsis*: test/sun/security/krb5/auto/HttpNegotiateServer.java > should not use static ports > > > === *Description* > ============================================================ > test/sun/security/krb5/auto/HttpNegotiateServer.java uses static port > numbers when starting web and proxy servers. If another process uses > the same ports, test would fail. > From weijun.wang at oracle.com Mon Mar 28 03:05:39 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 28 Mar 2011 10:05:39 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110328100619.80C9247534@hg.openjdk.java.net> Changeset: 86ace035d04d Author: weijun Date: 2011-03-28 18:04 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/86ace035d04d 7019384: Realm.getRealmsList returns realms list in wrong (reverse) order Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/Realm.java ! test/sun/security/krb5/ParseCAPaths.java ! test/sun/security/krb5/krb5-capaths.conf Changeset: 79cd9368b555 Author: weijun Date: 2011-03-28 18:04 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/79cd9368b555 7031536: test/sun/security/krb5/auto/HttpNegotiateServer.java should not use static ports Reviewed-by: xuelei ! test/sun/security/jgss/GssNPE.java ! test/sun/security/jgss/spnego/NoSpnegoAsDefMech.java ! test/sun/security/krb5/ConfPlusProp.java ! test/sun/security/krb5/ConfigWithQuotations.java ! test/sun/security/krb5/DnsFallback.java ! test/sun/security/krb5/IPv6.java ! test/sun/security/krb5/ParseConfig.java ! test/sun/security/krb5/RFC396xTest.java ! test/sun/security/krb5/TimeInCCache.java ! test/sun/security/krb5/auto/HttpNegotiateServer.java ! test/sun/security/krb5/etype/ETypeOrder.java ! test/sun/security/krb5/ktab/HighestKvno.java From weijun.wang at oracle.com Mon Mar 28 05:21:13 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 28 Mar 2011 20:21:13 +0800 Subject: Exception while processing 'no-addresses' flag in KrbApReq.java In-Reply-To: References: Message-ID: <4D907D39.5040603@oracle.com> Sorry for the late reply. I suppose your client side program is not in Java? Because in JDK a service ticker's addresses field is always null. Thanks Max On 03/25/2011 07:53 PM, Szabolcs Pota wrote: > [+ adding back security-dev] > > Hi Henry, > > Thank you for your reply. My answers are below. > > On Fri, Mar 25, 2011 at 1:26 AM, Henry B. Hotz > wrote: > > No-list reply since I'm subscribed with an alias which my ISP won't > let me send with. > > On Mar 23, 2011, at 5:16 AM, Szabolcs Pota wrote: > > > Our global krb5.conf files have 'noaddresses=false' for both client > > and server hence we get this exception. Please correct me if someone > > thinks that setting this flag to false on the server side would be > > incorrect. > > There are two issues here. The one you're not looking at is that > that config option is different for every one of the major C > implementations of Kerberos. > > [appdefaults] > no-addresses = true # Heimdal > no_addresses = true # Sun > > [lidefaults] > noaddresses = true # MIT > > I have no idea which of these is understood by Java, though I would > guess the Sun one, and hope that all of them are. Also the default > value varies with the version. AFAIK all now default to disable > address checking. > > > As I've seen in sun.security.krb5.Config#useAddresses() it reads either > the 'noaddresses' or the 'no-addresses' flag and indeed the default is > no-addresses=true. We are using 'noaddresses' that is parsed without > problems by the current code. > > ------ > > As for what you are actually asking about: almost all of us have > stopped worrying about addresses because the address check does not > work in the real world with ubiquitous NAT and multiple private IP > spaces. (Are you sure you're not running into one of those?) I > personally would not care if Java simply stopped supporting address > checking. > > That may not be an appropriate thing for the universal JGSS > implementation to do though. > > What's *supposed* to happen (without reading the RFC) is the > endpoint gets the IP from the socket for the other end, and compares > it with the appropriate field in the ticket. If they don't match, > then the ticket *may* have been copied and is being injected from > someplace it shouldn't be. > > Since (almost) nobody is using the feature anymore I would actually > be surprised if it works on IPv6 networks. As I said it is > guaranteed to fail if there is a NAT involved. > > ----- > > To answer the specific question in the above paragraph, I would say > checking addresses on a server is actually wrong if *any* of the > clients are connecting via VPN, or through your typical home router > box. It can only be guaranteed correct if all clients are on the > same corporate network as the server. > > > I agree with you that checking the client address is error prone and > even the RFC says so. It could be done only on a best effort basis. At > the moment I think that the server should do one of the followings: > > 1. If EncTicketPart.caddr is set then try to get the client IP and > check if it is in the list. If it is not then it *may* throw and > exception. > 2. Skip the whole no-addresses processing because of the unreliable > client IP check. > > My problem is that the current logic in KrbApReq java does non of these > but throws an Exception. This prevents us using OpenJDK with > 'noaddresses=false' in Kerberos configuration. > > Regards, > > Szabolcs > > ------------------------------------------------------ > The opinions expressed in this message are mine, > not those of Caltech, JPL, NASA, or the US Government. > Henry.B.Hotz at jpl.nasa.gov , or > hbhotz at oxy.edu > > > > > > > -- > Szabolcs Pota > Morgan Stanley | MSJava, EAI (MSSM) > Lechner Odon fasor 8 | Floor 07 > Budapest, 1095 > Phone: +36 1 881-3979 > Szabolcs.Pota at morganstanley.com > From sean.mullan at oracle.com Mon Mar 28 11:46:07 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 28 Mar 2011 14:46:07 -0400 Subject: Code Review Request for translatability bugs In-Reply-To: <4D8C16E2.1050402@oracle.com> References: <4D8B4C01.6000801@oracle.com> <4D8BA66D.7000109@oracle.com> <4D8BF164.6090802@oracle.com> <4D8C16E2.1050402@oracle.com> Message-ID: <4D90D76F.8070203@oracle.com> I have addressed all of your comments and posted another webrev at: http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.01/ Max, can you check that I integrated your patch ok? Thanks, Sean On 3/25/11 12:15 AM, Weijun Wang wrote: > Another thing, maybe you can also combine the JarSigner TSA-unavailable warnings > like you did for KeyTool integrity-not-checked ones? > > I've attached a diff and you can directly apply it at jdk level. > > Thanks > Max > > > On 03/25/2011 09:35 AM, Weijun Wang wrote: >> AuthResources.java: >> =================== >> >> 1. >> >> {"expected.", "expected "}, >> - {".read.end.of.file", ", read end of file"}, >> + {"expected.expect.read.end.of.file.", >> + "expected {0}, read end of file"}, >> >> The "expected." is now useless. At least I grep thru all jdk/src files >> and see none of it. >> >> 2. >> >> - {"provided.null.name", "provided null name"} >> >> This one is still used in: >> >> ./com/sun/security/auth/SolarisPrincipal.java:79 >> ./com/sun/security/auth/SolarisNumericGroupPrincipal.java:92 >> ./com/sun/security/auth/SolarisNumericUserPrincipal.java:83 >> ./com/sun/security/auth/X500Principal.java:90 >> >> There is an entry with the same name in Resources.java, but >> unfortunately our codes use both. >> >> >> Thanks >> Max >> >> >> On 03/25/2011 04:15 AM, Brad Wetmore wrote: >>> >>> On 3/24/2011 6:49 AM, Sean Mullan wrote: >>>> Max, Freda, >>>> >>>> Could you please review this webrev for a batch of translatability bugs: >>>> >>>> http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.00/ >>> >>> KeyTool.java: >>> ============= >>> Looks good. Only minor comments about line length, which is kind of hard >>> in this environment. >>> >>> Brad From kumar.x.srinivasan at oracle.com Mon Mar 28 14:02:56 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 28 Mar 2011 21:02:56 +0000 Subject: hg: jdk7/tl/jdk: 7031166: (pack200) tools/pack200/CommandLineTests.java fail with testsdk on RO filesystem Message-ID: <20110328210306.C97014754C@hg.openjdk.java.net> Changeset: a42760dae179 Author: ksrini Date: 2011-03-28 13:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a42760dae179 7031166: (pack200) tools/pack200/CommandLineTests.java fail with testsdk on RO filesystem Reviewed-by: alanb ! test/tools/pack200/CommandLineTests.java ! test/tools/pack200/TimeStamp.java ! test/tools/pack200/Utils.java From weijun.wang at oracle.com Mon Mar 28 18:49:33 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 29 Mar 2011 09:49:33 +0800 Subject: Code Review Request for translatability bugs In-Reply-To: <4D90D76F.8070203@oracle.com> References: <4D8B4C01.6000801@oracle.com> <4D8BA66D.7000109@oracle.com> <4D8BF164.6090802@oracle.com> <4D8C16E2.1050402@oracle.com> <4D90D76F.8070203@oracle.com> Message-ID: <4D913AAD.8070408@oracle.com> Looks fine. Thanks Max On 03/29/2011 02:46 AM, Sean Mullan wrote: > I have addressed all of your comments and posted another webrev at: > > http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.01/ > > Max, can you check that I integrated your patch ok? > > Thanks, > Sean > > On 3/25/11 12:15 AM, Weijun Wang wrote: >> Another thing, maybe you can also combine the JarSigner >> TSA-unavailable warnings >> like you did for KeyTool integrity-not-checked ones? >> >> I've attached a diff and you can directly apply it at jdk level. >> >> Thanks >> Max >> >> >> On 03/25/2011 09:35 AM, Weijun Wang wrote: >>> AuthResources.java: >>> =================== >>> >>> 1. >>> >>> {"expected.", "expected "}, >>> - {".read.end.of.file", ", read end of file"}, >>> + {"expected.expect.read.end.of.file.", >>> + "expected {0}, read end of file"}, >>> >>> The "expected." is now useless. At least I grep thru all jdk/src files >>> and see none of it. >>> >>> 2. >>> >>> - {"provided.null.name", "provided null name"} >>> >>> This one is still used in: >>> >>> ./com/sun/security/auth/SolarisPrincipal.java:79 >>> ./com/sun/security/auth/SolarisNumericGroupPrincipal.java:92 >>> ./com/sun/security/auth/SolarisNumericUserPrincipal.java:83 >>> ./com/sun/security/auth/X500Principal.java:90 >>> >>> There is an entry with the same name in Resources.java, but >>> unfortunately our codes use both. >>> >>> >>> Thanks >>> Max >>> >>> >>> On 03/25/2011 04:15 AM, Brad Wetmore wrote: >>>> >>>> On 3/24/2011 6:49 AM, Sean Mullan wrote: >>>>> Max, Freda, >>>>> >>>>> Could you please review this webrev for a batch of translatability >>>>> bugs: >>>>> >>>>> http://cr.openjdk.java.net/~mullan/webrevs/7019937_et_al/webrev.00/ >>>> >>>> KeyTool.java: >>>> ============= >>>> Looks good. Only minor comments about line length, which is kind of >>>> hard >>>> in this environment. >>>> >>>> Brad From david.holmes at oracle.com Tue Mar 29 05:16:11 2011 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Tue, 29 Mar 2011 12:16:11 +0000 Subject: hg: jdk7/tl/jdk: 7031929: Variable names typos in Release-embedded.gmk Message-ID: <20110329121655.199244756E@hg.openjdk.java.net> Changeset: 19567f9d6962 Author: dholmes Date: 2011-03-29 08:15 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/19567f9d6962 7031929: Variable names typos in Release-embedded.gmk Reviewed-by: alanb ! make/common/Release-embedded.gmk From Szabolcs.Pota at morganstanley.com Tue Mar 29 06:18:49 2011 From: Szabolcs.Pota at morganstanley.com (Szabolcs Pota) Date: Tue, 29 Mar 2011 15:18:49 +0200 Subject: Exception while processing 'no-addresses' flag in KrbApReq.java In-Reply-To: <4D907D39.5040603@oracle.com> References: <4D907D39.5040603@oracle.com> Message-ID: Hi Max, The client was Java in all cases. I've tried with the following combinations: - Open JDK b133 with JGSS - Open JDK b133 with MIT native Kerberos - JDK 6u23 with JGSS - JDK 6u23with MIT native Kerberos The result is always the same: Caused by: sun.security.krb5.internal.KrbApErrException: Incorrect net address (38) at sun.security.krb5.KrbApReq.authenticate(KrbApReq.java:329) ~[na:na] at sun.security.krb5.KrbApReq.(KrbApReq.java:146) ~[na:na] at sun.security.jgss.krb5.InitSecContextToken.(InitSecContextToken.java:108) ~[na:na] at sun.security.jgss.krb5.Krb5Context.acceptSecContext(Krb5Context.java:761) ~[na:na] Regards, Szabolcs On Mon, Mar 28, 2011 at 2:21 PM, Weijun Wang wrote: > Sorry for the late reply. > > I suppose your client side program is not in Java? Because in JDK a service > ticker's addresses field is always null. > > Thanks > Max > > > > > > On 03/25/2011 07:53 PM, Szabolcs Pota wrote: > >> [+ adding back security-dev] >> >> Hi Henry, >> >> Thank you for your reply. My answers are below. >> >> On Fri, Mar 25, 2011 at 1:26 AM, Henry B. Hotz > > wrote: >> >> No-list reply since I'm subscribed with an alias which my ISP won't >> let me send with. >> >> On Mar 23, 2011, at 5:16 AM, Szabolcs Pota wrote: >> >> > Our global krb5.conf files have 'noaddresses=false' for both client >> > and server hence we get this exception. Please correct me if someone >> > thinks that setting this flag to false on the server side would be >> > incorrect. >> >> There are two issues here. The one you're not looking at is that >> that config option is different for every one of the major C >> implementations of Kerberos. >> >> [appdefaults] >> no-addresses = true # Heimdal >> no_addresses = true # Sun >> >> [lidefaults] >> noaddresses = true # MIT >> >> I have no idea which of these is understood by Java, though I would >> guess the Sun one, and hope that all of them are. Also the default >> value varies with the version. AFAIK all now default to disable >> address checking. >> >> >> As I've seen in sun.security.krb5.Config#useAddresses() it reads either >> the 'noaddresses' or the 'no-addresses' flag and indeed the default is >> no-addresses=true. We are using 'noaddresses' that is parsed without >> problems by the current code. >> >> ------ >> >> As for what you are actually asking about: almost all of us have >> stopped worrying about addresses because the address check does not >> work in the real world with ubiquitous NAT and multiple private IP >> spaces. (Are you sure you're not running into one of those?) I >> personally would not care if Java simply stopped supporting address >> checking. >> >> That may not be an appropriate thing for the universal JGSS >> implementation to do though. >> >> What's *supposed* to happen (without reading the RFC) is the >> endpoint gets the IP from the socket for the other end, and compares >> it with the appropriate field in the ticket. If they don't match, >> then the ticket *may* have been copied and is being injected from >> someplace it shouldn't be. >> >> Since (almost) nobody is using the feature anymore I would actually >> be surprised if it works on IPv6 networks. As I said it is >> guaranteed to fail if there is a NAT involved. >> >> ----- >> >> To answer the specific question in the above paragraph, I would say >> checking addresses on a server is actually wrong if *any* of the >> clients are connecting via VPN, or through your typical home router >> box. It can only be guaranteed correct if all clients are on the >> same corporate network as the server. >> >> >> I agree with you that checking the client address is error prone and >> even the RFC says so. It could be done only on a best effort basis. At >> the moment I think that the server should do one of the followings: >> >> 1. If EncTicketPart.caddr is set then try to get the client IP and >> >> check if it is in the list. If it is not then it *may* throw and >> exception. >> 2. Skip the whole no-addresses processing because of the unreliable >> >> client IP check. >> >> My problem is that the current logic in KrbApReq java does non of these >> but throws an Exception. This prevents us using OpenJDK with >> 'noaddresses=false' in Kerberos configuration. >> >> Regards, >> >> Szabolcs >> >> ------------------------------------------------------ >> The opinions expressed in this message are mine, >> not those of Caltech, JPL, NASA, or the US Government. >> Henry.B.Hotz at jpl.nasa.gov , or >> hbhotz at oxy.edu >> >> >> >> >> >> >> >> -- >> Szabolcs Pota >> Morgan Stanley | MSJava, EAI (MSSM) >> Lechner Odon fasor 8 | Floor 07 >> Budapest, 1095 >> Phone: +36 1 881-3979 >> Szabolcs.Pota at morganstanley.com >> >> -- Szabolcs Pota Morgan Stanley | MSJava, EAI (MSSM) Lechner Odon fasor 8 | Floor 07 Budapest, 1095 Phone: +36 1 881-3979 Szabolcs.Pota at morganstanley.com -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20110329/acc8adbd/attachment.html From weijun.wang at oracle.com Tue Mar 29 07:13:29 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 29 Mar 2011 22:13:29 +0800 Subject: Exception while processing 'no-addresses' flag in KrbApReq.java In-Reply-To: References: <4D907D39.5040603@oracle.com> Message-ID: <4D91E909.9030606@oracle.com> Hi Szabolcs On 03/29/2011 09:18 PM, Szabolcs Pota wrote: > Hi Max, > > The client was Java in all cases. I've tried with the following > combinations: > > * Open JDK b133 with JGSS > * Open JDK b133 with MIT native Kerberos I guess this means using the native GSS provider with -Dsun.security.jgss.native=true. > * JDK 6u23 with JGSS > * JDK 6u23with MIT native Kerberos > > The result is always the same: This is a little strange. I do think the service ticket on the client should not have the caddr field. If your client is using JAAS, can you print out the KerberosTicket in its private credentials set after the first initSecContext() is called? Anyway, I've made some code changes to my own OpenJDK code repository and is now supporting this field in a service ticket. However, since JGSS is token-based, it has no way to get the IP address of the client from a socket object. In order to support no-addresses=false, both the client and server have to turn on channel bindings, and then the server will be able to get the client's IP address from it. Do you build OpenJDK? If so, you can try out my attached patch. Thanks Max > > Caused by: sun.security.krb5.internal.KrbApErrException: Incorrect net > address (38) > at sun.security.krb5.KrbApReq.authenticate(KrbApReq.java:329) > ~[na:na] > at sun.security.krb5.KrbApReq.(KrbApReq.java:146) ~[na:na] > at > sun.security.jgss.krb5.InitSecContextToken.(InitSecContextToken.java:108) > ~[na:na] > at > sun.security.jgss.krb5.Krb5Context.acceptSecContext(Krb5Context.java:761) ~[na:na] > > Regards, > > Szabolcs > > On Mon, Mar 28, 2011 at 2:21 PM, Weijun Wang > wrote: > > Sorry for the late reply. > > I suppose your client side program is not in Java? Because in JDK a > service ticker's addresses field is always null. > > Thanks > Max > > > > > > On 03/25/2011 07:53 PM, Szabolcs Pota wrote: > > [+ adding back security-dev] > > Hi Henry, > > Thank you for your reply. My answers are below. > > On Fri, Mar 25, 2011 at 1:26 AM, Henry B. Hotz > > >> > wrote: > > No-list reply since I'm subscribed with an alias which my > ISP won't > let me send with. > > On Mar 23, 2011, at 5:16 AM, Szabolcs Pota wrote: > > > Our global krb5.conf files have 'noaddresses=false' for both > client > > and server hence we get this exception. Please correct me if > someone > > thinks that setting this flag to false on the server side > would be > > incorrect. > > There are two issues here. The one you're not looking at is > that > that config option is different for every one of the major C > implementations of Kerberos. > > [appdefaults] > no-addresses = true # Heimdal > no_addresses = true # Sun > > [lidefaults] > noaddresses = true # MIT > > I have no idea which of these is understood by Java, though > I would > guess the Sun one, and hope that all of them are. Also the > default > value varies with the version. AFAIK all now default to disable > address checking. > > > As I've seen in sun.security.krb5.Config#useAddresses() it reads > either > the 'noaddresses' or the 'no-addresses' flag and indeed the > default is > no-addresses=true. We are using 'noaddresses' that is parsed without > problems by the current code. > > ------ > > As for what you are actually asking about: almost all of us > have > stopped worrying about addresses because the address check > does not > work in the real world with ubiquitous NAT and multiple > private IP > spaces. (Are you sure you're not running into one of those?) I > personally would not care if Java simply stopped supporting > address > checking. > > That may not be an appropriate thing for the universal JGSS > implementation to do though. > > What's *supposed* to happen (without reading the RFC) is the > endpoint gets the IP from the socket for the other end, and > compares > it with the appropriate field in the ticket. If they don't > match, > then the ticket *may* have been copied and is being injected > from > someplace it shouldn't be. > > Since (almost) nobody is using the feature anymore I would > actually > be surprised if it works on IPv6 networks. As I said it is > guaranteed to fail if there is a NAT involved. > > ----- > > To answer the specific question in the above paragraph, I > would say > checking addresses on a server is actually wrong if *any* of the > clients are connecting via VPN, or through your typical home > router > box. It can only be guaranteed correct if all clients are > on the > same corporate network as the server. > > > I agree with you that checking the client address is error prone and > even the RFC says so. It could be done only on a best effort > basis. At > the moment I think that the server should do one of the followings: > > 1. If EncTicketPart.caddr is set then try to get the client > IP and > > check if it is in the list. If it is not then it *may* > throw and > exception. > 2. Skip the whole no-addresses processing because of the > unreliable > > client IP check. > > My problem is that the current logic in KrbApReq java does non > of these > but throws an Exception. This prevents us using OpenJDK with > 'noaddresses=false' in Kerberos configuration. > > Regards, > > Szabolcs > > ------------------------------------------------------ > The opinions expressed in this message are mine, > not those of Caltech, JPL, NASA, or the US Government. > Henry.B.Hotz at jpl.nasa.gov > >, or > hbhotz at oxy.edu > > > > > > > > > -- > Szabolcs Pota > Morgan Stanley | MSJava, EAI (MSSM) > Lechner Odon fasor 8 | Floor 07 > Budapest, 1095 > Phone: +36 1 881-3979 > Szabolcs.Pota at morganstanley.com > > > > > > > > -- > Szabolcs Pota > Morgan Stanley | MSJava, EAI (MSSM) > Lechner Odon fasor 8 | Floor 07 > Budapest, 1095 > Phone: +36 1 881-3979 > Szabolcs.Pota at morganstanley.com > -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: cbandcaddr Url: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20110329/46075406/cbandcaddr.ksh From weijun.wang at oracle.com Tue Mar 29 07:35:46 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 29 Mar 2011 22:35:46 +0800 Subject: Exception while processing 'no-addresses' flag in KrbApReq.java In-Reply-To: <4D91E909.9030606@oracle.com> References: <4D907D39.5040603@oracle.com> <4D91E909.9030606@oracle.com> Message-ID: <4D91EE42.7030701@oracle.com> Update: I think I was wrong about caddr in a service ticket. JRE does not provide the address field in its TGS-REQ packet, but the KDC can still set the caddr in a ticket. So forget about that patch. Anyway, my previous mail on address from channel binding is still valid. You can try calling setChannelBinding() on both side and there will be no exception. We can relax this check a little: if there is no channel binding then there is no way to get the client's IP. In this case, we can skip the caddr check. I'll think about this more. Thanks Max On 03/29/2011 10:13 PM, Weijun Wang wrote: > Hi Szabolcs > > On 03/29/2011 09:18 PM, Szabolcs Pota wrote: >> Hi Max, >> >> The client was Java in all cases. I've tried with the following >> combinations: >> >> * Open JDK b133 with JGSS >> * Open JDK b133 with MIT native Kerberos > > I guess this means using the native GSS provider with > -Dsun.security.jgss.native=true. > >> * JDK 6u23 with JGSS >> * JDK 6u23with MIT native Kerberos >> >> The result is always the same: > > This is a little strange. I do think the service ticket on the client > should not have the caddr field. If your client is using JAAS, can you > print out the KerberosTicket in its private credentials set after the > first initSecContext() is called? > > Anyway, I've made some code changes to my own OpenJDK code repository > and is now supporting this field in a service ticket. However, since > JGSS is token-based, it has no way to get the IP address of the client > from a socket object. In order to support no-addresses=false, both the > client and server have to turn on channel bindings, and then the server > will be able to get the client's IP address from it. > > Do you build OpenJDK? If so, you can try out my attached patch. > > Thanks > Max > >> >> Caused by: sun.security.krb5.internal.KrbApErrException: Incorrect net >> address (38) >> at sun.security.krb5.KrbApReq.authenticate(KrbApReq.java:329) >> ~[na:na] >> at sun.security.krb5.KrbApReq.(KrbApReq.java:146) ~[na:na] >> at >> sun.security.jgss.krb5.InitSecContextToken.(InitSecContextToken.java:108) >> >> ~[na:na] >> at >> sun.security.jgss.krb5.Krb5Context.acceptSecContext(Krb5Context.java:761) >> ~[na:na] >> >> Regards, >> >> Szabolcs >> >> On Mon, Mar 28, 2011 at 2:21 PM, Weijun Wang > > wrote: >> >> Sorry for the late reply. >> >> I suppose your client side program is not in Java? Because in JDK a >> service ticker's addresses field is always null. >> >> Thanks >> Max >> >> >> >> >> >> On 03/25/2011 07:53 PM, Szabolcs Pota wrote: >> >> [+ adding back security-dev] >> >> Hi Henry, >> >> Thank you for your reply. My answers are below. >> >> On Fri, Mar 25, 2011 at 1:26 AM, Henry B. Hotz >> >> >> >> wrote: >> >> No-list reply since I'm subscribed with an alias which my >> ISP won't >> let me send with. >> >> On Mar 23, 2011, at 5:16 AM, Szabolcs Pota wrote: >> >> > Our global krb5.conf files have 'noaddresses=false' for both >> client >> > and server hence we get this exception. Please correct me if >> someone >> > thinks that setting this flag to false on the server side >> would be >> > incorrect. >> >> There are two issues here. The one you're not looking at is >> that >> that config option is different for every one of the major C >> implementations of Kerberos. >> >> [appdefaults] >> no-addresses = true # Heimdal >> no_addresses = true # Sun >> >> [lidefaults] >> noaddresses = true # MIT >> >> I have no idea which of these is understood by Java, though >> I would >> guess the Sun one, and hope that all of them are. Also the >> default >> value varies with the version. AFAIK all now default to disable >> address checking. >> >> >> As I've seen in sun.security.krb5.Config#useAddresses() it reads >> either >> the 'noaddresses' or the 'no-addresses' flag and indeed the >> default is >> no-addresses=true. We are using 'noaddresses' that is parsed without >> problems by the current code. >> >> ------ >> >> As for what you are actually asking about: almost all of us >> have >> stopped worrying about addresses because the address check >> does not >> work in the real world with ubiquitous NAT and multiple >> private IP >> spaces. (Are you sure you're not running into one of those?) I >> personally would not care if Java simply stopped supporting >> address >> checking. >> >> That may not be an appropriate thing for the universal JGSS >> implementation to do though. >> >> What's *supposed* to happen (without reading the RFC) is the >> endpoint gets the IP from the socket for the other end, and >> compares >> it with the appropriate field in the ticket. If they don't >> match, >> then the ticket *may* have been copied and is being injected >> from >> someplace it shouldn't be. >> >> Since (almost) nobody is using the feature anymore I would >> actually >> be surprised if it works on IPv6 networks. As I said it is >> guaranteed to fail if there is a NAT involved. >> >> ----- >> >> To answer the specific question in the above paragraph, I >> would say >> checking addresses on a server is actually wrong if *any* of the >> clients are connecting via VPN, or through your typical home >> router >> box. It can only be guaranteed correct if all clients are >> on the >> same corporate network as the server. >> >> >> I agree with you that checking the client address is error prone and >> even the RFC says so. It could be done only on a best effort >> basis. At >> the moment I think that the server should do one of the followings: >> >> 1. If EncTicketPart.caddr is set then try to get the client >> IP and >> >> check if it is in the list. If it is not then it *may* >> throw and >> exception. >> 2. Skip the whole no-addresses processing because of the >> unreliable >> >> client IP check. >> >> My problem is that the current logic in KrbApReq java does non >> of these >> but throws an Exception. This prevents us using OpenJDK with >> 'noaddresses=false' in Kerberos configuration. >> >> Regards, >> >> Szabolcs >> >> ------------------------------------------------------ >> The opinions expressed in this message are mine, >> not those of Caltech, JPL, NASA, or the US Government. >> Henry.B.Hotz at jpl.nasa.gov >> > >, or >> hbhotz at oxy.edu > > >> >> >> >> >> >> >> >> -- >> Szabolcs Pota >> Morgan Stanley | MSJava, EAI (MSSM) >> Lechner Odon fasor 8 | Floor 07 >> Budapest, 1095 >> Phone: +36 1 881-3979 >> Szabolcs.Pota at morganstanley.com >> >> > > >> >> >> >> >> -- >> Szabolcs Pota >> Morgan Stanley | MSJava, EAI (MSSM) >> Lechner Odon fasor 8 | Floor 07 >> Budapest, 1095 >> Phone: +36 1 881-3979 >> Szabolcs.Pota at morganstanley.com >> From sean.mullan at oracle.com Tue Mar 29 08:38:23 2011 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 29 Mar 2011 15:38:23 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110329153844.8699E4757A@hg.openjdk.java.net> Changeset: b8259e08543b Author: mullan Date: 2011-03-29 10:39 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8259e08543b 7019937: Translatability bug - Remove Unused String - String ID , read end of file 7019938: Translatability bug - Remove Unused String - String ID can not specify Principal with a 7019940: Translatability bug - Remove unused string - String ID: provided null name 7019942: Translatability bug - String ID: trustedCertEntry, 7019945: Translatability bug - Translatability issue - String ID: * has NOT been verified! In order to veri 7019947: Translatability bug - Translatability issue - String ID: * The integrity of the information stored i 7019949: Translatability bug - Translatability issue - String ID: * you must provide your keystore password. Reviewed-by: weijun, wetmore ! src/share/classes/com/sun/security/auth/PolicyParser.java ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/JarSignerResources.java ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/util/AuthResources.java ! src/share/classes/sun/security/util/Resources.java Changeset: 77077940fad6 Author: mullan Date: 2011-03-29 11:37 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/77077940fad6 Merge From maurizio.cimadamore at oracle.com Tue Mar 29 08:44:52 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 29 Mar 2011 15:44:52 +0000 Subject: hg: jdk7/tl/langtools: 4 new changesets Message-ID: <20110329154503.AA0DB4757B@hg.openjdk.java.net> Changeset: 2007998f89f2 Author: mcimadamore Date: 2011-03-29 16:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2007998f89f2 7030687: Diamond: compiler accepts erroneous code where diamond is used with non-generic inner class Summary: Diamond accepts non-parameterized member inner classes with parameterized outer because of a bad check Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/generics/diamond/7030687/ParserTest.java + test/tools/javac/generics/diamond/7030687/T7030687.java + test/tools/javac/generics/diamond/7030687/T7030687.out Changeset: ddec8c712e85 Author: mcimadamore Date: 2011-03-29 16:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ddec8c712e85 7030606: Project-coin: multi-catch types should be pairwise disjoint Summary: Bring javac in sync with latest Project Coin EDR Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/MulticatchTypesMustBeDisjoint.java + test/tools/javac/multicatch/7030606/DisjunctiveTypeWellFormednessTest.java + test/tools/javac/multicatch/7030606/T7030606.java + test/tools/javac/multicatch/7030606/T7030606.out Changeset: f5b5112ee1cc Author: mcimadamore Date: 2011-03-29 16:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f5b5112ee1cc 7030150: Type inference for generic instance creation failed for formal type parameter Summary: Problem when explicit generic constructor type-arguments are used in conjunction with diamond Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/generics/diamond/7030150/GenericConstructorAndDiamondTest.java + test/tools/javac/generics/diamond/7030150/Neg01.java + test/tools/javac/generics/diamond/7030150/Neg01.out + test/tools/javac/generics/diamond/7030150/Neg02.java + test/tools/javac/generics/diamond/7030150/Neg02.out + test/tools/javac/generics/diamond/7030150/Neg03.java + test/tools/javac/generics/diamond/7030150/Neg03.out + test/tools/javac/generics/diamond/7030150/Pos01.java + test/tools/javac/generics/diamond/7030150/Pos02.java Changeset: de1c65ecfec2 Author: mcimadamore Date: 2011-03-29 16:41 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/de1c65ecfec2 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException Summary: javac should warn about use/declaration of AutoCloseable subclasses that can throw InterruptedException Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/TryWithResources/InterruptedExceptionTest.java + test/tools/javac/diags/examples/TryResourceThrowsInterruptedExc.java From Szabolcs.Pota at morganstanley.com Tue Mar 29 10:09:21 2011 From: Szabolcs.Pota at morganstanley.com (Szabolcs Pota) Date: Tue, 29 Mar 2011 19:09:21 +0200 Subject: Exception while processing 'no-addresses' flag in KrbApReq.java In-Reply-To: <4D91EE42.7030701@oracle.com> References: <4D907D39.5040603@oracle.com> <4D91E909.9030606@oracle.com> <4D91EE42.7030701@oracle.com> Message-ID: Hi Max, On Tue, Mar 29, 2011 at 4:35 PM, Weijun Wang wrote: > Update: > > I think I was wrong about caddr in a service ticket. JRE does not provide > the address field in its TGS-REQ packet, but the KDC can still set the caddr > in a ticket. > Yes. I've tested and the client addresses are indeed set. > > So forget about that patch. > > Anyway, my previous mail on address from channel binding is still valid. > You can try calling setChannelBinding() on both side and there will be no > exception. > Unfortunately we don't have control over both sides. The client could be any kerberos enabled client in any language. We have a custom protocol for ticket exchange and leverage the GSS API to process those. > > We can relax this check a little: if there is no channel binding then there > is no way to get the client's IP. In this case, we can skip the caddr check. > This is exactly what I think would be appropriate until there is no better way to get the client IP. Or at least some config option that could switch the check on or off. > I'll think about this more. > > Thanks > Max > > Thanks, Szabolcs > > > On 03/29/2011 10:13 PM, Weijun Wang wrote: > >> Hi Szabolcs >> >> On 03/29/2011 09:18 PM, Szabolcs Pota wrote: >> >>> Hi Max, >>> >>> The client was Java in all cases. I've tried with the following >>> combinations: >>> >>> * Open JDK b133 with JGSS >>> * Open JDK b133 with MIT native Kerberos >>> >> >> I guess this means using the native GSS provider with >> -Dsun.security.jgss.native=true. >> >> * JDK 6u23 with JGSS >>> * JDK 6u23with MIT native Kerberos >>> >>> The result is always the same: >>> >> >> This is a little strange. I do think the service ticket on the client >> should not have the caddr field. If your client is using JAAS, can you >> print out the KerberosTicket in its private credentials set after the >> first initSecContext() is called? >> >> Anyway, I've made some code changes to my own OpenJDK code repository >> and is now supporting this field in a service ticket. However, since >> JGSS is token-based, it has no way to get the IP address of the client >> from a socket object. In order to support no-addresses=false, both the >> client and server have to turn on channel bindings, and then the server >> will be able to get the client's IP address from it. >> >> Do you build OpenJDK? If so, you can try out my attached patch. >> >> Thanks >> Max >> >> >>> Caused by: sun.security.krb5.internal.KrbApErrException: Incorrect net >>> address (38) >>> at sun.security.krb5.KrbApReq.authenticate(KrbApReq.java:329) >>> ~[na:na] >>> at sun.security.krb5.KrbApReq.(KrbApReq.java:146) ~[na:na] >>> at >>> >>> sun.security.jgss.krb5.InitSecContextToken.(InitSecContextToken.java:108) >>> >>> ~[na:na] >>> at >>> sun.security.jgss.krb5.Krb5Context.acceptSecContext(Krb5Context.java:761) >>> ~[na:na] >>> >>> Regards, >>> >>> Szabolcs >>> >>> On Mon, Mar 28, 2011 at 2:21 PM, Weijun Wang >> > wrote: >>> >>> Sorry for the late reply. >>> >>> I suppose your client side program is not in Java? Because in JDK a >>> service ticker's addresses field is always null. >>> >>> Thanks >>> Max >>> >>> >>> >>> >>> >>> On 03/25/2011 07:53 PM, Szabolcs Pota wrote: >>> >>> [+ adding back security-dev] >>> >>> Hi Henry, >>> >>> Thank you for your reply. My answers are below. >>> >>> On Fri, Mar 25, 2011 at 1:26 AM, Henry B. Hotz >>> >>> >> >>> wrote: >>> >>> No-list reply since I'm subscribed with an alias which my >>> ISP won't >>> let me send with. >>> >>> On Mar 23, 2011, at 5:16 AM, Szabolcs Pota wrote: >>> >>> > Our global krb5.conf files have 'noaddresses=false' for both >>> client >>> > and server hence we get this exception. Please correct me if >>> someone >>> > thinks that setting this flag to false on the server side >>> would be >>> > incorrect. >>> >>> There are two issues here. The one you're not looking at is >>> that >>> that config option is different for every one of the major C >>> implementations of Kerberos. >>> >>> [appdefaults] >>> no-addresses = true # Heimdal >>> no_addresses = true # Sun >>> >>> [lidefaults] >>> noaddresses = true # MIT >>> >>> I have no idea which of these is understood by Java, though >>> I would >>> guess the Sun one, and hope that all of them are. Also the >>> default >>> value varies with the version. AFAIK all now default to disable >>> address checking. >>> >>> >>> As I've seen in sun.security.krb5.Config#useAddresses() it reads >>> either >>> the 'noaddresses' or the 'no-addresses' flag and indeed the >>> default is >>> no-addresses=true. We are using 'noaddresses' that is parsed without >>> problems by the current code. >>> >>> ------ >>> >>> As for what you are actually asking about: almost all of us >>> have >>> stopped worrying about addresses because the address check >>> does not >>> work in the real world with ubiquitous NAT and multiple >>> private IP >>> spaces. (Are you sure you're not running into one of those?) I >>> personally would not care if Java simply stopped supporting >>> address >>> checking. >>> >>> That may not be an appropriate thing for the universal JGSS >>> implementation to do though. >>> >>> What's *supposed* to happen (without reading the RFC) is the >>> endpoint gets the IP from the socket for the other end, and >>> compares >>> it with the appropriate field in the ticket. If they don't >>> match, >>> then the ticket *may* have been copied and is being injected >>> from >>> someplace it shouldn't be. >>> >>> Since (almost) nobody is using the feature anymore I would >>> actually >>> be surprised if it works on IPv6 networks. As I said it is >>> guaranteed to fail if there is a NAT involved. >>> >>> ----- >>> >>> To answer the specific question in the above paragraph, I >>> would say >>> checking addresses on a server is actually wrong if *any* of the >>> clients are connecting via VPN, or through your typical home >>> router >>> box. It can only be guaranteed correct if all clients are >>> on the >>> same corporate network as the server. >>> >>> >>> I agree with you that checking the client address is error prone and >>> even the RFC says so. It could be done only on a best effort >>> basis. At >>> the moment I think that the server should do one of the followings: >>> >>> 1. If EncTicketPart.caddr is set then try to get the client >>> IP and >>> >>> check if it is in the list. If it is not then it *may* >>> throw and >>> exception. >>> 2. Skip the whole no-addresses processing because of the >>> unreliable >>> >>> client IP check. >>> >>> My problem is that the current logic in KrbApReq java does non >>> of these >>> but throws an Exception. This prevents us using OpenJDK with >>> 'noaddresses=false' in Kerberos configuration. >>> >>> Regards, >>> >>> Szabolcs >>> >>> ------------------------------------------------------ >>> The opinions expressed in this message are mine, >>> not those of Caltech, JPL, NASA, or the US Government. >>> Henry.B.Hotz at jpl.nasa.gov >>> >> >, or >>> hbhotz at oxy.edu >> > >>> >>> >>> >>> >>> >>> >>> >>> -- >>> Szabolcs Pota >>> Morgan Stanley | MSJava, EAI (MSSM) >>> Lechner Odon fasor 8 | Floor 07 >>> Budapest, 1095 >>> Phone: +36 1 881-3979 >>> Szabolcs.Pota at morganstanley.com >>> >>> >> > >>> >>> >>> >>> >>> -- >>> Szabolcs Pota >>> Morgan Stanley | MSJava, EAI (MSSM) >>> Lechner Odon fasor 8 | Floor 07 >>> Budapest, 1095 >>> Phone: +36 1 881-3979 >>> Szabolcs.Pota at morganstanley.com >>> >>> -- Szabolcs Pota Morgan Stanley | MSJava, EAI (MSSM) Lechner Odon fasor 8 | Floor 07 Budapest, 1095 Phone: +36 1 881-3979 Szabolcs.Pota at morganstanley.com -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20110329/ec89c934/attachment.html From mandy.chung at oracle.com Tue Mar 29 15:51:12 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 29 Mar 2011 22:51:12 +0000 Subject: hg: jdk7/tl/jdk: 7024172: Move BufferPoolMXBean and PlatformLoggingMXBean java.lang.management Message-ID: <20110329225121.C6C6047596@hg.openjdk.java.net> Changeset: 3e001dd50408 Author: mchung Date: 2011-03-29 15:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3e001dd50408 7024172: Move BufferPoolMXBean and PlatformLoggingMXBean java.lang.management Reviewed-by: alanb + src/share/classes/java/lang/management/BufferPoolMXBean.java ! src/share/classes/java/lang/management/ManagementFactory.java ! src/share/classes/java/lang/management/PlatformComponent.java + src/share/classes/java/lang/management/PlatformLoggingMXBean.java ! src/share/classes/java/lang/management/PlatformManagedObject.java ! src/share/classes/java/lang/management/package.html - src/share/classes/java/nio/BufferPoolMXBean.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/LoggingMXBean.java - src/share/classes/java/util/logging/PlatformLoggingMXBean.java ! src/share/classes/sun/management/ManagementFactoryHelper.java ! test/Makefile + test/java/lang/management/BufferPoolMXBean/Basic.java ! test/java/lang/management/ManagementFactory/GetPlatformMXBeans.java + test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java + test/java/lang/management/PlatformLoggingMXBean/PlatformLoggingMXBeanTest.java - test/java/nio/BufferPoolMXBean/Basic.java ! test/java/nio/channels/AsynchronousSocketChannel/Leaky.java - test/java/util/logging/PlatformLoggingMXBean/PlatformLoggingMXBeanTest.java From mandy.chung at oracle.com Tue Mar 29 15:58:30 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 29 Mar 2011 22:58:30 +0000 Subject: hg: jdk7/tl/jdk: 6381464: SimpleFormatter should use one single line format Message-ID: <20110329225840.4F64447597@hg.openjdk.java.net> Changeset: d2bbdd709307 Author: mchung Date: 2011-03-29 15:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d2bbdd709307 6381464: SimpleFormatter should use one single line format Summary: Define a new logging properties to support custom output format Reviewed-by: alanb ! src/share/classes/java/util/logging/LoggingProxyImpl.java ! src/share/classes/java/util/logging/SimpleFormatter.java ! src/share/classes/sun/util/logging/LoggingProxy.java ! src/share/classes/sun/util/logging/LoggingSupport.java ! src/share/classes/sun/util/logging/PlatformLogger.java ! src/share/lib/logging.properties + test/java/util/logging/SimpleFormatterFormat.java ! test/sun/util/logging/PlatformLoggerTest.java From alan.bateman at oracle.com Tue Mar 29 17:01:04 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 30 Mar 2011 00:01:04 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110330000124.CC7AE4759B@hg.openjdk.java.net> Changeset: 646047d77db9 Author: alanb Date: 2011-03-30 00:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/646047d77db9 7026507: Bidi initialization fails if AWT not present Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java Changeset: a40982a82291 Author: alanb Date: 2011-03-30 01:00 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a40982a82291 Merge - src/share/classes/java/nio/BufferPoolMXBean.java - src/share/classes/java/util/logging/PlatformLoggingMXBean.java - test/java/nio/BufferPoolMXBean/Basic.java - test/java/util/logging/PlatformLoggingMXBean/PlatformLoggingMXBeanTest.java From weijun.wang at oracle.com Tue Mar 29 22:25:51 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 30 Mar 2011 13:25:51 +0800 Subject: code review request: 7032354: no-addresses should not be used on acceptor side Message-ID: <4D92BEDF.3040605@oracle.com> Hi Valerie http://cr.openjdk.java.net/~weijun/7032354/webrev.00/ I've removed the use of this setting on the acceptor side, now host address check is only performed if caddr is inside service ticket and the acceptor has a way to get the initiator's address (currently, thru channel binding only). Thanks Max ---------------- *Change Request ID*: 7032354 *Synopsis*: no-addresses should not be used on acceptor side === *Description* =============================================== We now uses the no-addresses setting in krb5.conf on the acceptor side to check if the caddr field in an incoming service ticket matches the initiator's host address. According to available docs on krb5.conf, this setting is only used by the initiator side when requesting for the initial TGT. http://www.daemon-systems.org/man/krb5.conf.5.html no-addresses = boolean When obtaining initial credentials, request them for an empty set of addresses, making the tickets valid from any address. http://web.mit.edu/kerberos/krb5-1.4/krb5-1.4.1/doc/krb5-admin/libdefaults.html#libdefaults noaddresses Setting this flag causes the initial Kerberos ticket to be addressless. The default for the flag is set. From jonathan.gibbons at oracle.com Wed Mar 30 18:18:40 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 31 Mar 2011 01:18:40 +0000 Subject: hg: jdk7/tl/langtools: 7031108: NPE in javac.jvm.ClassReader.findMethod in PackageElement.enclosedElements from AP in incr build Message-ID: <20110331011847.D9B164764A@hg.openjdk.java.net> Changeset: 02ba4ff98742 Author: jjg Date: 2011-03-30 18:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/02ba4ff98742 7031108: NPE in javac.jvm.ClassReader.findMethod in PackageElement.enclosedElements from AP in incr build Reviewed-by: darcy, mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/classreader/T7031108.java ! test/tools/javac/diags/examples.not-yet.txt From jonathan.gibbons at oracle.com Wed Mar 30 18:32:40 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 31 Mar 2011 01:32:40 +0000 Subject: hg: jdk7/tl/langtools: 7031005: javap prints "extends java.lang.Object" Message-ID: <20110331013242.B339D4764B@hg.openjdk.java.net> Changeset: c55928005af4 Author: jjg Date: 2011-03-30 18:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c55928005af4 7031005: javap prints "extends java.lang.Object" Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/classfile/Type.java ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! test/tools/javap/6937244/T6937244A.java ! test/tools/javap/T4880663.java ! test/tools/javap/T4880672.java + test/tools/javap/TestSuperclass.java From david.holmes at oracle.com Wed Mar 30 19:21:47 2011 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Thu, 31 Mar 2011 02:21:47 +0000 Subject: hg: jdk7/tl/jdk: 7032364: Add jvm.cfg file for ARM and PPC architectures Message-ID: <20110331022205.165FA4764E@hg.openjdk.java.net> Changeset: 5107fb3a9c06 Author: dholmes Date: 2011-03-30 22:20 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5107fb3a9c06 7032364: Add jvm.cfg file for ARM and PPC architectures Reviewed-by: darcy, bdelsart, alanb, mduigou + src/solaris/bin/arm/jvm.cfg + src/solaris/bin/ppc/jvm.cfg From daniel.daugherty at oracle.com Wed Mar 30 21:10:43 2011 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Thu, 31 Mar 2011 04:10:43 +0000 Subject: hg: jdk7/tl/jdk: 7030400: 3/4 PrivateTransportTest.sh needs adjustment to work with 7003964 Message-ID: <20110331041053.2569347653@hg.openjdk.java.net> Changeset: e2862ac26354 Author: dcubed Date: 2011-03-30 21:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e2862ac26354 7030400: 3/4 PrivateTransportTest.sh needs adjustment to work with 7003964 Summary: Fix typo in GetModuleHandle() function lookup. Reviewed-by: dholmes, alanb, acorn, zgu ! test/com/sun/jdi/PrivateTransportTest.sh From weijun.wang at oracle.com Thu Mar 31 03:41:21 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 31 Mar 2011 18:41:21 +0800 Subject: code review request: 6894072: always refresh keytab In-Reply-To: <4D8D313D.4080808@oracle.com> References: <4CF6195A.6000301@oracle.com> <4D7A9D02.40106@oracle.com> <4D801157.6070009@oracle.com> <4D83F0B9.3050201@oracle.com> <4D86E217.7050709@oracle.com> <4D89B6BE.4020003@oracle.com> <4D8D313D.4080808@oracle.com> Message-ID: <4D945A51.30100@oracle.com> Hi Valerie Sorry for the late reply. I've considered some alternatives. A "to-be-resolved" KerberosKey is quite difficult. When it's resolved, we have a list of keys with different etypes as the private credentials. If it's not resolved, we can only create one, whose encoding and etype are both unresolved, and when it finally gets resolved, it's resolved into multiple keys. Also, there was a simple mapping between KerberosKey and EncryptionKey. The resolving process is not always at the same time as the mapping (converting from one to another) time, so it seems EncryptionKey might also needs to be unresolved. Another solution is to revert back to my original KeyTab without an intended user. This means several changes: In my latest version of ServiceCreds, there were multiple keys and *one* keytab, now we also need multiple keytabs, because there might be multiple keytabs in the subject's private credentials set and we cannot tell which is for who. Therefore we collect all of them, when the keys are needed at AP-REP time, we call getKeys() on all of them, and return the combination. Hopefully there won't be two keys for the same principal with same kvno and same etype. I regard that as an abuse. Currently when there is no serverPrincipal specified in the Krb5AcceptCredential construction, we pick a KerberosKey from the private credentials set and use the KerberosPrincipal info inside, and then get all KerberosKeys for the same principal. We have never really looked at any KerberosPrincipal objects in the subject's principal set. I had tried to do the same to KeyTabs in my webrev.02. Now this will have a big change: the first step is always finding a KerberosPrincipal in the principal sets first. If serverPrincipal is specified, we find a matched one, otherwise, we just pick one and use it. And then, from the private credentials set, we fetch all KerberosKeys for this principal and all KeyTabs. I think this is the correct way to go. Of course, for compatibility reason, we assume there are third party codes that put KerberosKeys inside a subject's private credentials set but hasn't put any KerberosPrincipal there. Our Krb5LoginModule will never do it, but we can accept it. Here is a partial webrev: http://cr.openjdk.java.net/~weijun/6894072/webrev.03 It only contains changes for Krb5Util.java, and hasn't included the compatibility codes I mentioned above. As you can see, the KeyTab objects are now retrieved by + sc.ktabs = SubjectComber.findMany( + subj, null, null, KeyTab.class); so no principal name is used, and we retrive "many". If you think this is OK, I'll clean up other codes. One benefit is that we don't need to update CCC with this solution. Yes we do introduce new hashCode/equals/toString methods, but I think they do not deserve a CCC. Thanks Max On 03/26/2011 08:20 AM, Valerie (Yu-Ching) Peng wrote: > Max, > > Well, I find it a bit awkward that the KeyTab class has to have the > KerberosPrincipal info which "intends" to use it. > Have you considered a different approach like: > Instead of adding the whole KeyTab object into the Subject's private > credential set, we add a "to-be-resolved" KerberosKey object. When we > need to use this kind of key, we'd check the associated KeyTab object to > re-fresh its value if needed. This approach is conceptually closer to > what we had and the changes aren't as dramatic and seems to meet the > need required by 6894072. > > I'll continue to review your webrev, but just want to kick this idea off > w/ you and see if it may work. > Valerie > > On 03/23/11 02:00 AM, Weijun Wang wrote: >> Hi Valerie >> >> Updated webrev: >> >> http://cr.openjdk.java.net/~weijun/6894072/webrev.02 >> >> Changes since last version: >> >> 1. A KerberosPrincipal inside javax..KeyTab class. New getInstance() >> arguments, new getPrincipal() method. >> >> It can only be non-null now, but I didn't say anything in the spec. >> I'm hoping it can be null in the future to support multiple service >> principal in a single service. >> >> 2. toString(), hashCode(), equals() for KeyTab, since it will be put >> inside private credentials set. >> >> 3. Enhancement to SubjectComber: >> a) Generics for find() and findMany() >> b) findAux() now support Krb5AcceptCredential >> >> 4. Krb5Util.ServiceCreds: since principal is already inside both >> KeyTab and KerberosKey, no more KerberosPrincipal argument in >> getInstance(), there is still a field inside to save the value. >> >> 5. sun..KeyTab and javax..KeyTab: isMissing==true is now valid. >> Changes to the javadoc of javax..KeyTab.getKeys(). >> >> 6. New TwoPrinces.java test, a subject with 2 KerberosPrincipal after >> JAAS commit. >> >> This time I'd like to first make sure implementation is correct, and >> then I'll update the CCC. Is this OK? >> >> Thanks >> Max > From michael.x.mcmahon at oracle.com Thu Mar 31 13:11:29 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 31 Mar 2011 20:11:29 +0000 Subject: hg: jdk7/tl/jdk: 7032866: Problem with fix for 7030256 Message-ID: <20110331201155.E57754768D@hg.openjdk.java.net> Changeset: 683957148bab Author: michaelm Date: 2011-03-31 17:37 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/683957148bab 7032866: Problem with fix for 7030256 Reviewed-by: alanb ! src/windows/native/java/net/net_util_md.c From valerie.peng at oracle.com Thu Mar 31 19:09:01 2011 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Thu, 31 Mar 2011 19:09:01 -0700 Subject: code review request: 6894072: always refresh keytab In-Reply-To: <4D945A51.30100@oracle.com> References: <4CF6195A.6000301@oracle.com> <4D7A9D02.40106@oracle.com> <4D801157.6070009@oracle.com> <4D83F0B9.3050201@oracle.com> <4D86E217.7050709@oracle.com> <4D89B6BE.4020003@oracle.com> <4D8D313D.4080808@oracle.com> <4D945A51.30100@oracle.com> Message-ID: <4D9533BD.7040709@oracle.com> Max, I like this new approach of yours better. As for compatibility, you mentioned only one aspect, i.e. apps which put KerberosKeys inside a subject's private cred set. There is also a possibility that apps may read the subject's private credentials set for KerberosKeys that we used to put in and they won't find the keys anymore since it's the KeyTab objects that we put into the private cred set after this dynamic keytab support. Thoughts? Valerie On 03/31/11 03:41 AM, Weijun Wang wrote: > Hi Valerie > > Sorry for the late reply. I've considered some alternatives. > > A "to-be-resolved" KerberosKey is quite difficult. When it's resolved, > we have a list of keys with different etypes as the private > credentials. If it's not resolved, we can only create one, whose > encoding and etype are both unresolved, and when it finally gets > resolved, it's resolved into multiple keys. Also, there was a simple > mapping between KerberosKey and EncryptionKey. The resolving process > is not always at the same time as the mapping (converting from one to > another) time, so it seems EncryptionKey might also needs to be > unresolved. > > Another solution is to revert back to my original KeyTab without an > intended user. This means several changes: > > In my latest version of ServiceCreds, there were multiple keys and > *one* keytab, now we also need multiple keytabs, because there might > be multiple keytabs in the subject's private credentials set and we > cannot tell which is for who. Therefore we collect all of them, when > the keys are needed at AP-REP time, we call getKeys() on all of them, > and return the combination. Hopefully there won't be two keys for the > same principal with same kvno and same etype. I regard that as an abuse. > > Currently when there is no serverPrincipal specified in the > Krb5AcceptCredential construction, we pick a KerberosKey from the > private credentials set and use the KerberosPrincipal info inside, and > then get all KerberosKeys for the same principal. We have never really > looked at any KerberosPrincipal objects in the subject's principal > set. I had tried to do the same to KeyTabs in my webrev.02. Now this > will have a big change: the first step is always finding a > KerberosPrincipal in the principal sets first. If serverPrincipal is > specified, we find a matched one, otherwise, we just pick one and use > it. And then, from the private credentials set, we fetch all > KerberosKeys for this principal and all KeyTabs. > > I think this is the correct way to go. Of course, for compatibility > reason, we assume there are third party codes that put KerberosKeys > inside a subject's private credentials set but hasn't put any > KerberosPrincipal there. Our Krb5LoginModule will never do it, but we > can accept it. > > Here is a partial webrev: > > http://cr.openjdk.java.net/~weijun/6894072/webrev.03 > > It only contains changes for Krb5Util.java, and hasn't included the > compatibility codes I mentioned above. As you can see, the KeyTab > objects are now retrieved by > > + sc.ktabs = SubjectComber.findMany( > + subj, null, null, KeyTab.class); > > so no principal name is used, and we retrive "many". > > If you think this is OK, I'll clean up other codes. One benefit is > that we don't need to update CCC with this solution. Yes we do > introduce new hashCode/equals/toString methods, but I think they do > not deserve a CCC. > > Thanks > Max > > > On 03/26/2011 08:20 AM, Valerie (Yu-Ching) Peng wrote: >> Max, >> >> Well, I find it a bit awkward that the KeyTab class has to have the >> KerberosPrincipal info which "intends" to use it. >> Have you considered a different approach like: >> Instead of adding the whole KeyTab object into the Subject's private >> credential set, we add a "to-be-resolved" KerberosKey object. When we >> need to use this kind of key, we'd check the associated KeyTab object to >> re-fresh its value if needed. This approach is conceptually closer to >> what we had and the changes aren't as dramatic and seems to meet the >> need required by 6894072. >> >> I'll continue to review your webrev, but just want to kick this idea off >> w/ you and see if it may work. >> Valerie >> >> On 03/23/11 02:00 AM, Weijun Wang wrote: >>> Hi Valerie >>> >>> Updated webrev: >>> >>> http://cr.openjdk.java.net/~weijun/6894072/webrev.02 >>> >>> Changes since last version: >>> >>> 1. A KerberosPrincipal inside javax..KeyTab class. New getInstance() >>> arguments, new getPrincipal() method. >>> >>> It can only be non-null now, but I didn't say anything in the spec. >>> I'm hoping it can be null in the future to support multiple service >>> principal in a single service. >>> >>> 2. toString(), hashCode(), equals() for KeyTab, since it will be put >>> inside private credentials set. >>> >>> 3. Enhancement to SubjectComber: >>> a) Generics for find() and findMany() >>> b) findAux() now support Krb5AcceptCredential >>> >>> 4. Krb5Util.ServiceCreds: since principal is already inside both >>> KeyTab and KerberosKey, no more KerberosPrincipal argument in >>> getInstance(), there is still a field inside to save the value. >>> >>> 5. sun..KeyTab and javax..KeyTab: isMissing==true is now valid. >>> Changes to the javadoc of javax..KeyTab.getKeys(). >>> >>> 6. New TwoPrinces.java test, a subject with 2 KerberosPrincipal after >>> JAAS commit. >>> >>> This time I'd like to first make sure implementation is correct, and >>> then I'll update the CCC. Is this OK? >>> >>> Thanks >>> Max >> From joe.darcy at oracle.com Thu Mar 31 19:11:37 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 01 Apr 2011 02:11:37 +0000 Subject: hg: jdk7/tl/jdk: 7005628: Clarify NPE behavior of Throwable.addSuppressed(null) Message-ID: <20110401021209.1D8834769E@hg.openjdk.java.net> Changeset: 856cc9e97aea Author: darcy Date: 2011-03-31 19:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/856cc9e97aea 7005628: Clarify NPE behavior of Throwable.addSuppressed(null) Reviewed-by: dholmes, mchung, jjb ! src/share/classes/java/lang/ArithmeticException.java ! src/share/classes/java/lang/NullPointerException.java ! src/share/classes/java/lang/OutOfMemoryError.java ! src/share/classes/java/lang/Throwable.java ! test/java/lang/Throwable/SuppressedExceptions.java From weijun.wang at oracle.com Thu Mar 31 19:23:08 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 01 Apr 2011 10:23:08 +0800 Subject: code review request: 6894072: always refresh keytab In-Reply-To: <4D9533BD.7040709@oracle.com> References: <4CF6195A.6000301@oracle.com> <4D7A9D02.40106@oracle.com> <4D801157.6070009@oracle.com> <4D83F0B9.3050201@oracle.com> <4D86E217.7050709@oracle.com> <4D89B6BE.4020003@oracle.com> <4D8D313D.4080808@oracle.com> <4D945A51.30100@oracle.com> <4D9533BD.7040709@oracle.com> Message-ID: <4D95370C.6090107@oracle.com> On 04/01/2011 10:09 AM, Valerie (Yu-Ching) Peng wrote: > Max, > > I like this new approach of yours better. > As for compatibility, you mentioned only one aspect, i.e. apps which put > KerberosKeys inside a subject's private cred set. > There is also a possibility that apps may read the subject's private > credentials set for KerberosKeys that we used to put in and they won't > find the keys anymore since it's the KeyTab objects that we put into the > private cred set after this dynamic keytab support. Thoughts? No, I haven't thought about it. We can put a snapshot of keys there at the beginning and refresh them whenever a getKeys() is called. This should be harmless because we don't really use the keys if keytab objects (not keytab files) exist. I can do that. Thanks Max > > Valerie > > > On 03/31/11 03:41 AM, Weijun Wang wrote: >> Hi Valerie >> >> Sorry for the late reply. I've considered some alternatives. >> >> A "to-be-resolved" KerberosKey is quite difficult. When it's resolved, >> we have a list of keys with different etypes as the private >> credentials. If it's not resolved, we can only create one, whose >> encoding and etype are both unresolved, and when it finally gets >> resolved, it's resolved into multiple keys. Also, there was a simple >> mapping between KerberosKey and EncryptionKey. The resolving process >> is not always at the same time as the mapping (converting from one to >> another) time, so it seems EncryptionKey might also needs to be >> unresolved. >> >> Another solution is to revert back to my original KeyTab without an >> intended user. This means several changes: >> >> In my latest version of ServiceCreds, there were multiple keys and >> *one* keytab, now we also need multiple keytabs, because there might >> be multiple keytabs in the subject's private credentials set and we >> cannot tell which is for who. Therefore we collect all of them, when >> the keys are needed at AP-REP time, we call getKeys() on all of them, >> and return the combination. Hopefully there won't be two keys for the >> same principal with same kvno and same etype. I regard that as an abuse. >> >> Currently when there is no serverPrincipal specified in the >> Krb5AcceptCredential construction, we pick a KerberosKey from the >> private credentials set and use the KerberosPrincipal info inside, and >> then get all KerberosKeys for the same principal. We have never really >> looked at any KerberosPrincipal objects in the subject's principal >> set. I had tried to do the same to KeyTabs in my webrev.02. Now this >> will have a big change: the first step is always finding a >> KerberosPrincipal in the principal sets first. If serverPrincipal is >> specified, we find a matched one, otherwise, we just pick one and use >> it. And then, from the private credentials set, we fetch all >> KerberosKeys for this principal and all KeyTabs. >> >> I think this is the correct way to go. Of course, for compatibility >> reason, we assume there are third party codes that put KerberosKeys >> inside a subject's private credentials set but hasn't put any >> KerberosPrincipal there. Our Krb5LoginModule will never do it, but we >> can accept it. >> >> Here is a partial webrev: >> >> http://cr.openjdk.java.net/~weijun/6894072/webrev.03 >> >> It only contains changes for Krb5Util.java, and hasn't included the >> compatibility codes I mentioned above. As you can see, the KeyTab >> objects are now retrieved by >> >> + sc.ktabs = SubjectComber.findMany( >> + subj, null, null, KeyTab.class); >> >> so no principal name is used, and we retrive "many". >> >> If you think this is OK, I'll clean up other codes. One benefit is >> that we don't need to update CCC with this solution. Yes we do >> introduce new hashCode/equals/toString methods, but I think they do >> not deserve a CCC. >> >> Thanks >> Max >> >> >> On 03/26/2011 08:20 AM, Valerie (Yu-Ching) Peng wrote: >>> Max, >>> >>> Well, I find it a bit awkward that the KeyTab class has to have the >>> KerberosPrincipal info which "intends" to use it. >>> Have you considered a different approach like: >>> Instead of adding the whole KeyTab object into the Subject's private >>> credential set, we add a "to-be-resolved" KerberosKey object. When we >>> need to use this kind of key, we'd check the associated KeyTab object to >>> re-fresh its value if needed. This approach is conceptually closer to >>> what we had and the changes aren't as dramatic and seems to meet the >>> need required by 6894072. >>> >>> I'll continue to review your webrev, but just want to kick this idea off >>> w/ you and see if it may work. >>> Valerie >>> >>> On 03/23/11 02:00 AM, Weijun Wang wrote: >>>> Hi Valerie >>>> >>>> Updated webrev: >>>> >>>> http://cr.openjdk.java.net/~weijun/6894072/webrev.02 >>>> >>>> Changes since last version: >>>> >>>> 1. A KerberosPrincipal inside javax..KeyTab class. New getInstance() >>>> arguments, new getPrincipal() method. >>>> >>>> It can only be non-null now, but I didn't say anything in the spec. >>>> I'm hoping it can be null in the future to support multiple service >>>> principal in a single service. >>>> >>>> 2. toString(), hashCode(), equals() for KeyTab, since it will be put >>>> inside private credentials set. >>>> >>>> 3. Enhancement to SubjectComber: >>>> a) Generics for find() and findMany() >>>> b) findAux() now support Krb5AcceptCredential >>>> >>>> 4. Krb5Util.ServiceCreds: since principal is already inside both >>>> KeyTab and KerberosKey, no more KerberosPrincipal argument in >>>> getInstance(), there is still a field inside to save the value. >>>> >>>> 5. sun..KeyTab and javax..KeyTab: isMissing==true is now valid. >>>> Changes to the javadoc of javax..KeyTab.getKeys(). >>>> >>>> 6. New TwoPrinces.java test, a subject with 2 KerberosPrincipal after >>>> JAAS commit. >>>> >>>> This time I'd like to first make sure implementation is correct, and >>>> then I'll update the CCC. Is this OK? >>>> >>>> Thanks >>>> Max >>> > From weijun.wang at oracle.com Thu Mar 31 21:38:07 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 01 Apr 2011 12:38:07 +0800 Subject: code review request: 7030180: AES 128/256 decrypt exception Message-ID: <4D9556AF.4060206@oracle.com> Hi Valerie http://cr.openjdk.java.net/~weijun/7030180/webrev.00/ A bug in MIT krb5 1.8 triggers this exception (read evaluation below). They will fix it in 1.8.4 and 1.9. At the mean time, we can check both the session key and the subkey on the acceptor side. I think this does not deserve a backport to 6u releases. Your opinion? Thanks Max -------- Original Message -------- *Change Request ID*: 7030180 *Synopsis*: AES 128/256 decrypt exception === *Description* ============================================================ I tried to use SPNEGO. When I use DES3 It works for a principal. When I try to use AES 128/256 It crashes. ERROR MESSAGES/STACK TRACES THAT OCCUR : GSSException: Failure unspecified at GSS-API level (Mechanism level: Checksum failed) at sun.security.jgss.krb5.Krb5Context.acceptSecContext(Krb5Context.java:741) .... === *Evaluation* ============================================================= The customer is using krb5 1.8 on the client side. There is a known issue that KRB-CRED inside AP-REQ is encrypted with the authenticator subkey instead of the ticket session key: http://krbdev.mit.edu/rt/Ticket/Display.html?id=6768&user=guest&pass=guest At the same time, we can try both the session key and the sub key in Java, this is also what MIT and Heimdal have done for years.