From frederic.parain at oracle.com Wed Feb 1 14:41:59 2012 From: frederic.parain at oracle.com (frederic.parain at oracle.com) Date: Wed, 01 Feb 2012 14:41:59 +0000 Subject: hg: jdk8/tl/jdk: 7120974: ManagementPermission "control" needs clarification Message-ID: <20120201144209.CB370472DA@hg.openjdk.java.net> Changeset: ac26d04e76c3 Author: fparain Date: 2012-02-01 03:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac26d04e76c3 7120974: ManagementPermission "control" needs clarification Reviewed-by: mchung, dholmes ! src/share/classes/java/lang/management/ManagementPermission.java From bradford.wetmore at oracle.com Wed Feb 1 22:13:51 2012 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Wed, 01 Feb 2012 14:13:51 -0800 Subject: Code review request: Copyright update. Message-ID: <4F29B91F.20302@oracle.com> 7141910: Incorrect copyright dates on new test cases. http://cr.openjdk.java.net/~wetmore/7141910/ Big sigh, Brad From sean.mullan at oracle.com Wed Feb 1 22:28:44 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 01 Feb 2012 17:28:44 -0500 Subject: Code review request: Copyright update. In-Reply-To: <4F29B91F.20302@oracle.com> References: <4F29B91F.20302@oracle.com> Message-ID: <4F29BC9C.8080600@oracle.com> Looks fine to me. --Sean On 2/1/12 5:13 PM, Brad Wetmore wrote: > > 7141910: Incorrect copyright dates on new test cases. > http://cr.openjdk.java.net/~wetmore/7141910/ > > Big sigh, > Brad > > From bradford.wetmore at oracle.com Thu Feb 2 00:01:09 2012 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Thu, 02 Feb 2012 00:01:09 +0000 Subject: hg: jdk8/tl/jdk: 7141910: Incorrect copyright dates on new test cases. Message-ID: <20120202000134.BD9E2472E6@hg.openjdk.java.net> Changeset: 55a82eba1986 Author: wetmore Date: 2012-02-01 16:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55a82eba1986 7141910: Incorrect copyright dates on new test cases. Reviewed-by: mullan ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh From weijun.wang at oracle.com Thu Feb 2 04:48:25 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 02 Feb 2012 12:48:25 +0800 Subject: Fix for: 6415637: PKCS#12 key stores with empty passwords In-Reply-To: <82aa54dlv4.fsf@mid.bfk.de> References: <82aa54dlv4.fsf@mid.bfk.de> Message-ID: <4F2A1599.5080002@oracle.com> I've created a webrev for Florain at http://cr.openjdk.java.net/~weijun/6415637/webrev.00/ Very tiny format changes, removing trailing whitespaces, change TABs to spaces, and add braces for one-line block in two places. The code change looks fine, but I would like to get a confirmation from someone in the JCE team. Thanks Max On 01/31/2012 09:47 PM, Florian Weimer wrote: > I've ported my previous patch to fix bug 6415637 to the current jdk8-tl > forrest. > > There are two related changes (quoting from the initial submission): > > 1. The password and salt expansion resulted in a division by zero for > empty password strings. > > 2. Practically speaking, there are two different ways of deriving keys > from an empty passphrase: the terminating NUL character is required > by the specification, but is left out by some implementations > (including OpenJDK if the first bug is fixed). OpenSSL tries to > decrypt with both encodings, and the patch implements that as well. > It is difficult to properly implement the retry behavior without > changing any interfaces, so this patch uses "\0" for the password > *without* a NUL terminator. This is a bit confusing, but it ensures > that passing an empty string as the password creates a PKCS#12 store > which is compliant with the specification. > > Because of the division of zero issue, the second change does not > actually modify visible behavior. > > To my knowledge, there is now an OCA which covers this change. > From vincent.x.ryan at oracle.com Thu Feb 2 12:05:57 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 02 Feb 2012 12:05:57 +0000 Subject: Fix for: 6415637: PKCS#12 key stores with empty passwords In-Reply-To: <4F2A1599.5080002@oracle.com> References: <82aa54dlv4.fsf@mid.bfk.de> <4F2A1599.5080002@oracle.com> Message-ID: <4F2A7C25.3000109@oracle.com> That fix looks fine. On 02/ 2/12 04:48 AM, Weijun Wang wrote: > I've created a webrev for Florain at > > http://cr.openjdk.java.net/~weijun/6415637/webrev.00/ > > Very tiny format changes, removing trailing whitespaces, change TABs to spaces, > and add braces for one-line block in two places. > > The code change looks fine, but I would like to get a confirmation from someone > in the JCE team. > > Thanks > Max > > On 01/31/2012 09:47 PM, Florian Weimer wrote: >> I've ported my previous patch to fix bug 6415637 to the current jdk8-tl >> forrest. >> >> There are two related changes (quoting from the initial submission): >> >> 1. The password and salt expansion resulted in a division by zero for >> empty password strings. >> >> 2. Practically speaking, there are two different ways of deriving keys >> from an empty passphrase: the terminating NUL character is required >> by the specification, but is left out by some implementations >> (including OpenJDK if the first bug is fixed). OpenSSL tries to >> decrypt with both encodings, and the patch implements that as well. >> It is difficult to properly implement the retry behavior without >> changing any interfaces, so this patch uses "\0" for the password >> *without* a NUL terminator. This is a bit confusing, but it ensures >> that passing an empty string as the password creates a PKCS#12 store >> which is compliant with the specification. >> >> Because of the division of zero issue, the second change does not >> actually modify visible behavior. >> >> To my knowledge, there is now an OCA which covers this change. >> From vincent.x.ryan at oracle.com Thu Feb 2 15:19:44 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 02 Feb 2012 15:19:44 +0000 Subject: code review request: 7133495: [macosx] KeyChain KeyStore implementation retrieves only one private key entry Message-ID: <4F2AA990.5050800@oracle.com> Please review the following fix to Mac OSX keychain support: http://cr.openjdk.java.net/~vinnie/7133495/webrev.00/ Thanks. From kumar.x.srinivasan at oracle.com Thu Feb 2 23:39:04 2012 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 02 Feb 2012 23:39:04 +0000 Subject: hg: jdk8/tl/jdk: 7141141: Add 3 new test scenarios for testing Main-Class attribute in jar manifest file Message-ID: <20120202233921.C8DF147321@hg.openjdk.java.net> Changeset: 24478d62d068 Author: ksrini Date: 2012-02-02 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/24478d62d068 7141141: Add 3 new test scenarios for testing Main-Class attribute in jar manifest file Reviewed-by: ksrini, darcy Contributed-by: sonali.goel at oracle.com ! test/tools/launcher/Arrrghs.java + test/tools/launcher/MainClassAttributeTest.java From weijun.wang at oracle.com Fri Feb 3 14:26:05 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 03 Feb 2012 22:26:05 +0800 Subject: code review request: 7133495: [macosx] KeyChain KeyStore implementation retrieves only one private key entry In-Reply-To: <4F2AA990.5050800@oracle.com> References: <4F2AA990.5050800@oracle.com> Message-ID: <4F2BEE7D.6000902@oracle.com> Hi Vinnie The code change is fine. However, I noticed something weird when trying out your test. It seems for each PrivateKeyEntry, there is a TrustedCertificateEntry with the same cert: x, Feb 3, 2012, PrivateKeyEntry, Certificate fingerprint (SHA1): DB:8F:DC:61:EF:A6:CC:FE:FB:66:6F:6A:E6:32:71:0C:DD:E1:E7:3D x 1, Feb 3, 2012, trustedCertEntry, Certificate fingerprint (SHA1): DB:8F:DC:61:EF:A6:CC:FE:FB:66:6F:6A:E6:32:71:0C:DD:E1:E7:3D Should the "x 1" one be removed? I haven't tried what will happen if the private entry contains more than one certs in its chain. Thanks Max On 02/02/2012 11:19 PM, Vincent Ryan wrote: > Please review the following fix to Mac OSX keychain support: > http://cr.openjdk.java.net/~vinnie/7133495/webrev.00/ > > Thanks. From chris.hegarty at oracle.com Sat Feb 4 12:05:55 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Sat, 04 Feb 2012 12:05:55 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20120204120631.896834736E@hg.openjdk.java.net> Changeset: bbadb6605a1c Author: chegar Date: 2012-02-04 07:29 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbadb6605a1c 7041778: Move SCTP implementation out of sun.nio.ch and into its own package Reviewed-by: alanb ! make/com/sun/nio/sctp/Exportedfiles.gmk ! make/com/sun/nio/sctp/FILES_java.gmk ! make/com/sun/nio/sctp/Makefile ! make/com/sun/nio/sctp/mapfile-vers ! src/share/classes/com/sun/nio/sctp/MessageInfo.java ! src/share/classes/com/sun/nio/sctp/SctpChannel.java ! src/share/classes/com/sun/nio/sctp/SctpMultiChannel.java ! src/share/classes/com/sun/nio/sctp/SctpServerChannel.java ! src/share/classes/com/sun/nio/sctp/SctpStandardSocketOptions.java ! src/share/classes/sun/nio/ch/AbstractPollArrayWrapper.java ! src/share/classes/sun/nio/ch/AbstractPollSelectorImpl.java ! src/share/classes/sun/nio/ch/IOStatus.java ! src/share/classes/sun/nio/ch/IOUtil.java ! src/share/classes/sun/nio/ch/Net.java - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java ! src/share/classes/sun/nio/ch/SelChImpl.java ! src/share/classes/sun/nio/ch/SelectionKeyImpl.java ! src/share/classes/sun/nio/ch/SelectorImpl.java ! src/share/classes/sun/nio/ch/Util.java + src/share/classes/sun/nio/ch/sctp/MessageInfoImpl.java + src/share/classes/sun/nio/ch/sctp/SctpStdSocketOption.java ! src/solaris/classes/sun/nio/ch/DevPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/NativeThread.java ! src/solaris/classes/sun/nio/ch/PollArrayWrapper.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java + src/solaris/classes/sun/nio/ch/sctp/AssociationChange.java + src/solaris/classes/sun/nio/ch/sctp/AssociationImpl.java + src/solaris/classes/sun/nio/ch/sctp/PeerAddrChange.java + src/solaris/classes/sun/nio/ch/sctp/ResultContainer.java + src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java + src/solaris/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java + src/solaris/classes/sun/nio/ch/sctp/SctpNet.java + src/solaris/classes/sun/nio/ch/sctp/SctpNotification.java + src/solaris/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java + src/solaris/classes/sun/nio/ch/sctp/SendFailed.java + src/solaris/classes/sun/nio/ch/sctp/Shutdown.java - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c + src/solaris/native/sun/nio/ch/sctp/Sctp.h + src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c + src/solaris/native/sun/nio/ch/sctp/SctpNet.c + src/solaris/native/sun/nio/ch/sctp/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java + src/windows/classes/sun/nio/ch/sctp/SctpChannelImpl.java + src/windows/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java + src/windows/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java Changeset: e528a64dd21b Author: chegar Date: 2012-02-04 07:36 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e528a64dd21b Merge From weijun.wang at oracle.com Sun Feb 5 04:38:55 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Sun, 05 Feb 2012 12:38:55 +0800 Subject: code review request: 7133112: [macosx] org.ietf.jgss.GSSException while sun.security.jgss.GSSManagerImpl.createName In-Reply-To: <18100302.1328390474311.JavaMail.sbladm@swsblss4-new.central.sun.com> References: <18100302.1328390474311.JavaMail.sbladm@swsblss4-new.central.sun.com> Message-ID: <4F2E07DF.6010808@oracle.com> Hi Valerie Please review this code change http://cr.openjdk.java.net/~weijun/7133112/webrev.00/ Basically the reason is that native the GSS provider is not turned on (GSSManagerImpl::USE_NATIVE is false), so we should not test it on Mac. The Mac does include native gss libs. I try to return true there, and load either /usr/lib/libgssapi_krb5.dylib or /usr/lib/sasl2/libgssapiv2.2.so in SunNativeProvider, always core dumped. So seems it's not simple and I created a new bug (7142798) on it. Thanks Max -------- Original Message -------- *Change Request ID*: 7133112 *Synopsis*: [macosx] org.ietf.jgss.GSSException while sun.security.jgss.GSSManagerImpl.createName === *Description* ============================================================ Please see test: sun/security/krb5/runNameEquals.sh. Following exception is thrown: Exception in thread "main" GSSException: Invalid name provided (Mechanism level: Cannot locate default realm) at sun.security.jgss.krb5.Krb5NameElement.getInstance(Krb5NameElement.java:127) at sun.security.jgss.krb5.Krb5MechFactory.getNameElement(Krb5MechFactory.java:95) at sun.security.jgss.GSSManagerImpl.getNameElement(GSSManagerImpl.java:202) at sun.security.jgss.GSSNameImpl.getElement(GSSNameImpl.java:472) at sun.security.jgss.GSSNameImpl.init(GSSNameImpl.java:201) at sun.security.jgss.GSSNameImpl.(GSSNameImpl.java:170) at sun.security.jgss.GSSManagerImpl.createName(GSSManagerImpl.java:137) at Krb5NameEquals.main(Krb5NameEquals.java:53) JIRA Equivalent: http://java.net/jira/browse/MACOSX_PORT-146 From alan.bateman at oracle.com Sun Feb 5 12:32:02 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 05 Feb 2012 12:32:02 +0000 Subject: hg: jdk8/tl/jaxws: 7140918: Remove dependency on apt and com.sun.mirror API Message-ID: <20120205123202.B14F64737E@hg.openjdk.java.net> Changeset: 6a8f54fb5f15 Author: alanb Date: 2012-02-05 12:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6a8f54fb5f15 7140918: Remove dependency on apt and com.sun.mirror API Reviewed-by: darcy Contributed-by: miroslav.kos at oracle.com, martin.grebac at oracle.com ! build-defs.xml ! jaxws.properties From alan.bateman at oracle.com Sun Feb 5 12:32:51 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 05 Feb 2012 12:32:51 +0000 Subject: hg: jdk8/tl/jdk: 7140918: Remove dependency on apt and com.sun.mirror API Message-ID: <20120205123319.F18E54737F@hg.openjdk.java.net> Changeset: ce5ffdb2be25 Author: alanb Date: 2012-02-05 12:29 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce5ffdb2be25 7140918: Remove dependency on apt and com.sun.mirror API Reviewed-by: darcy Contributed-by: miroslav.kos at oracle.com, martin.grebac at oracle.com ! make/common/Release.gmk ! make/common/internal/Defs-jaxws.gmk From joe.darcy at oracle.com Mon Feb 6 05:50:37 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 06 Feb 2012 05:50:37 +0000 Subject: hg: jdk8/tl/jdk: 7041249: Remove apt tool and API from the JDK Message-ID: <20120206055055.1861847389@hg.openjdk.java.net> Changeset: e55522710586 Author: darcy Date: 2012-02-05 21:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e55522710586 7041249: Remove apt tool and API from the JDK Reviewed-by: jjg, ohair ! make/com/sun/Makefile ! make/common/Release.gmk ! make/common/internal/Defs-langtools.gmk ! make/docs/Makefile ! make/docs/NON_CORE_PKGS.gmk ! make/launchers/Makefile ! make/launchers/Makefile.launcher - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 From joe.darcy at oracle.com Mon Feb 6 06:00:02 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 06 Feb 2012 06:00:02 +0000 Subject: hg: jdk8/tl/langtools: 7041249: Remove apt tool and API from the JDK Message-ID: <20120206060007.1C28F4738A@hg.openjdk.java.net> Changeset: 2360c8213989 Author: darcy Date: 2012-02-05 21:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2360c8213989 7041249: Remove apt tool and API from the JDK Reviewed-by: jjg, ohair ! make/Makefile-classic ! make/build.properties ! make/build.xml ! make/netbeans/README - make/test/lib/apt.sh ! make/test/lib/src.gold.txt - src/share/classes/com/sun/mirror/apt/AnnotationProcessor.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorEnvironment.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorFactory.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorListener.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessors.java - src/share/classes/com/sun/mirror/apt/Filer.java - src/share/classes/com/sun/mirror/apt/Messager.java - src/share/classes/com/sun/mirror/apt/RoundCompleteEvent.java - src/share/classes/com/sun/mirror/apt/RoundCompleteListener.java - src/share/classes/com/sun/mirror/apt/RoundState.java - src/share/classes/com/sun/mirror/apt/package-info.java - src/share/classes/com/sun/mirror/declaration/AnnotationMirror.java - src/share/classes/com/sun/mirror/declaration/AnnotationTypeDeclaration.java - src/share/classes/com/sun/mirror/declaration/AnnotationTypeElementDeclaration.java - src/share/classes/com/sun/mirror/declaration/AnnotationValue.java - src/share/classes/com/sun/mirror/declaration/ClassDeclaration.java - src/share/classes/com/sun/mirror/declaration/ConstructorDeclaration.java - src/share/classes/com/sun/mirror/declaration/Declaration.java - src/share/classes/com/sun/mirror/declaration/EnumConstantDeclaration.java - src/share/classes/com/sun/mirror/declaration/EnumDeclaration.java - src/share/classes/com/sun/mirror/declaration/ExecutableDeclaration.java - src/share/classes/com/sun/mirror/declaration/FieldDeclaration.java - src/share/classes/com/sun/mirror/declaration/InterfaceDeclaration.java - src/share/classes/com/sun/mirror/declaration/MemberDeclaration.java - src/share/classes/com/sun/mirror/declaration/MethodDeclaration.java - src/share/classes/com/sun/mirror/declaration/Modifier.java - src/share/classes/com/sun/mirror/declaration/PackageDeclaration.java - src/share/classes/com/sun/mirror/declaration/ParameterDeclaration.java - src/share/classes/com/sun/mirror/declaration/TypeDeclaration.java - src/share/classes/com/sun/mirror/declaration/TypeParameterDeclaration.java - src/share/classes/com/sun/mirror/declaration/package-info.java - src/share/classes/com/sun/mirror/overview.html - src/share/classes/com/sun/mirror/type/AnnotationType.java - src/share/classes/com/sun/mirror/type/ArrayType.java - src/share/classes/com/sun/mirror/type/ClassType.java - src/share/classes/com/sun/mirror/type/DeclaredType.java - src/share/classes/com/sun/mirror/type/EnumType.java - src/share/classes/com/sun/mirror/type/InterfaceType.java - src/share/classes/com/sun/mirror/type/MirroredTypeException.java - src/share/classes/com/sun/mirror/type/MirroredTypesException.java - src/share/classes/com/sun/mirror/type/PrimitiveType.java - src/share/classes/com/sun/mirror/type/ReferenceType.java - src/share/classes/com/sun/mirror/type/TypeMirror.java - src/share/classes/com/sun/mirror/type/TypeVariable.java - src/share/classes/com/sun/mirror/type/VoidType.java - src/share/classes/com/sun/mirror/type/WildcardType.java - src/share/classes/com/sun/mirror/type/package-info.java - src/share/classes/com/sun/mirror/util/DeclarationFilter.java - src/share/classes/com/sun/mirror/util/DeclarationScanner.java - src/share/classes/com/sun/mirror/util/DeclarationVisitor.java - src/share/classes/com/sun/mirror/util/DeclarationVisitors.java - src/share/classes/com/sun/mirror/util/Declarations.java - src/share/classes/com/sun/mirror/util/SimpleDeclarationVisitor.java - src/share/classes/com/sun/mirror/util/SimpleTypeVisitor.java - src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java - src/share/classes/com/sun/mirror/util/SourcePosition.java - src/share/classes/com/sun/mirror/util/TypeVisitor.java - src/share/classes/com/sun/mirror/util/Types.java - src/share/classes/com/sun/mirror/util/package-info.java - src/share/classes/com/sun/tools/apt/Main.java - src/share/classes/com/sun/tools/apt/comp/AnnotationProcessingError.java - src/share/classes/com/sun/tools/apt/comp/Apt.java - src/share/classes/com/sun/tools/apt/comp/BootstrapAPF.java - src/share/classes/com/sun/tools/apt/comp/PrintAP.java - src/share/classes/com/sun/tools/apt/comp/UsageMessageNeededException.java - src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java - src/share/classes/com/sun/tools/apt/main/CommandLine.java - src/share/classes/com/sun/tools/apt/main/Main.java - src/share/classes/com/sun/tools/apt/mirror/AptEnv.java - src/share/classes/com/sun/tools/apt/mirror/apt/AnnotationProcessorEnvironmentImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/FilerImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/MessagerImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/RoundCompleteEventImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/RoundStateImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationMirrorImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationTypeDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationTypeElementDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationValueImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ClassDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/Constants.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ConstructorDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationMaker.java - src/share/classes/com/sun/tools/apt/mirror/declaration/EnumConstantDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/EnumDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ExecutableDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/FieldDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/InterfaceDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/MemberDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/MethodDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/PackageDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ParameterDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/TypeDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/TypeParameterDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/AnnotationTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/ArrayTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/ClassTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/DeclaredTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/EnumTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/InterfaceTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/PrimitiveTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeMaker.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeMirrorImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeVariableImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/VoidTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/WildcardTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/DeclarationsImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/SourcePositionImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/TypesImpl.java - src/share/classes/com/sun/tools/apt/resources/apt.properties - src/share/classes/com/sun/tools/apt/resources/apt_ja.properties - src/share/classes/com/sun/tools/apt/resources/apt_zh_CN.properties - src/share/classes/com/sun/tools/apt/util/Bark.java - test/tools/apt/Basics/Aggregate.java - test/tools/apt/Basics/ClassAnnotations.java - test/tools/apt/Basics/FreshnessApf.java - test/tools/apt/Basics/GenClass.java - test/tools/apt/Basics/Indirect.java - test/tools/apt/Basics/Lacuna.java - test/tools/apt/Basics/MethodAnnotations.java - test/tools/apt/Basics/Milk.java - test/tools/apt/Basics/MisMatch.java - test/tools/apt/Basics/Misc.java - test/tools/apt/Basics/MyMarker.java - test/tools/apt/Basics/MySimple.java - test/tools/apt/Basics/NestedClassAnnotations.java - test/tools/apt/Basics/ParameterAnnotations.java - test/tools/apt/Basics/StaticFieldAnnotations.java - test/tools/apt/Basics/StaticMethodAnnotations.java - test/tools/apt/Basics/TestGetPackageApf.java - test/tools/apt/Basics/TestGetTypeDeclarationApf.java - test/tools/apt/Basics/annot/AnnotMarker.java - test/tools/apt/Basics/annot/AnnotShangri_la.java - test/tools/apt/Basics/annot/AnnotSimple.java - test/tools/apt/Basics/annot/annot2/AnnotMarker2.java - test/tools/apt/Basics/annot/annot2/AnnotSimple2.java ! test/tools/apt/Basics/apt.sh - test/tools/apt/Basics/com.sun.mirror.apt.AnnotationProcessorFactory - test/tools/apt/Basics/foo/bar/Baz.java - test/tools/apt/Basics/foo/bar/Quux.java - test/tools/apt/Basics/golden.txt - test/tools/apt/Basics/goldenAggregate.txt - test/tools/apt/Basics/p1/p2.java - test/tools/apt/Basics/p1/p2/C1.java - test/tools/apt/Basics/print.sh - test/tools/apt/Compile/ClassDeclApf.java - test/tools/apt/Compile/ClassDeclApf2.java - test/tools/apt/Compile/Dummy1.java - test/tools/apt/Compile/ErrorAPF.java - test/tools/apt/Compile/HelloAnnotation.java - test/tools/apt/Compile/HelloWorld.java - test/tools/apt/Compile/Round1Apf.java - test/tools/apt/Compile/Round2Apf.java - test/tools/apt/Compile/Round3Apf.java - test/tools/apt/Compile/Round4Apf.java - test/tools/apt/Compile/Rounds.java - test/tools/apt/Compile/StaticApf.java - test/tools/apt/Compile/WarnAPF.java - test/tools/apt/Compile/WrappedStaticApf.java - test/tools/apt/Compile/compile.sh - test/tools/apt/Compile/golden.txt - test/tools/apt/Compile/goldenFactory.txt - test/tools/apt/Compile/goldenWarn.txt - test/tools/apt/Compile/servicesRound1 - test/tools/apt/Compile/servicesRound2 - test/tools/apt/Compile/servicesRound3 - test/tools/apt/Compile/servicesRound4 - test/tools/apt/Compile/servicesStaticApf - test/tools/apt/Compile/src/AhOneClass.java - test/tools/apt/Compile/src/AndAhTwoClass.java - test/tools/apt/Compile/src/Round1Class.java - test/tools/apt/Discovery/Dee.java - test/tools/apt/Discovery/Dum.java - test/tools/apt/Discovery/Empty.java - test/tools/apt/Discovery/PhantomTouch.java - test/tools/apt/Discovery/PhantomUpdate.java - test/tools/apt/Discovery/Touch.java - test/tools/apt/Discovery/discovery.sh - test/tools/apt/Discovery/servicesBadTouch - test/tools/apt/Discovery/servicesPhantomTouch - test/tools/apt/Discovery/servicesTouch - test/tools/apt/Discovery/servicesTweedle - test/tools/apt/Misc/Marked.java - test/tools/apt/Misc/Marker.java - test/tools/apt/Misc/Misc.java - test/tools/apt/Misc/misc.sh - test/tools/apt/Misc/servicesMisc - test/tools/apt/Options/Marked.java - test/tools/apt/Options/Marker.java - test/tools/apt/Options/OptionChecker.java - test/tools/apt/Options/options.sh - test/tools/apt/Options/servicesOptions - test/tools/apt/Scanners/Counter.java - test/tools/apt/Scanners/MemberOrderApf.java - test/tools/apt/Scanners/Order.java - test/tools/apt/Scanners/Scanner.java - test/tools/apt/Scanners/TestEnum.java - test/tools/apt/Scanners/VisitOrder.java - test/tools/apt/Scanners/scanner.sh - test/tools/apt/Scanners/servicesScanner - test/tools/apt/lib/Ignore.java - test/tools/apt/lib/Test.java - test/tools/apt/lib/TestProcessor.java - test/tools/apt/lib/TestProcessorFactory.java - test/tools/apt/lib/Tester.java - test/tools/apt/mirror/declaration/AnnoMirror.java - test/tools/apt/mirror/declaration/AnnoTypeDecl.java - test/tools/apt/mirror/declaration/AnnoTypeElemDecl.java - test/tools/apt/mirror/declaration/AnnoVal.java - test/tools/apt/mirror/declaration/ClassDecl.java - test/tools/apt/mirror/declaration/ConstExpr.java - test/tools/apt/mirror/declaration/ConstructorDecl.java - test/tools/apt/mirror/declaration/EnumDecl.java - test/tools/apt/mirror/declaration/FieldDecl.java - test/tools/apt/mirror/declaration/GetAnno.java - test/tools/apt/mirror/declaration/InterfaceDecl.java - test/tools/apt/mirror/declaration/MethodDecl.java - test/tools/apt/mirror/declaration/PackageDecl.java - test/tools/apt/mirror/declaration/ParameterDecl.java - test/tools/apt/mirror/declaration/pkg1/AClass.java - test/tools/apt/mirror/declaration/pkg1/AnAnnoType.java - test/tools/apt/mirror/declaration/pkg1/AnEnum.java - test/tools/apt/mirror/declaration/pkg1/AnInterface.java - test/tools/apt/mirror/declaration/pkg1/package-info.java - test/tools/apt/mirror/declaration/pkg1/pkg2/AnInterface.java - test/tools/apt/mirror/declaration/pkg1/pkg2/package.html - test/tools/apt/mirror/type/AnnoTyp.java - test/tools/apt/mirror/type/ArrayTyp.java - test/tools/apt/mirror/type/ClassTyp.java - test/tools/apt/mirror/type/EnumTyp.java - test/tools/apt/mirror/type/InterfaceTyp.java - test/tools/apt/mirror/type/PrimitiveTyp.java - test/tools/apt/mirror/type/TypeVar.java - test/tools/apt/mirror/type/WildcardTyp.java - test/tools/apt/mirror/util/Overrides.java - test/tools/apt/mirror/util/TypeCreation.java From vincent.x.ryan at oracle.com Mon Feb 6 12:01:41 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Mon, 06 Feb 2012 12:01:41 +0000 Subject: code review request: 7133495: [macosx] KeyChain KeyStore implementation retrieves only one private key entry In-Reply-To: <4F2BEE7D.6000902@oracle.com> References: <4F2AA990.5050800@oracle.com> <4F2BEE7D.6000902@oracle.com> Message-ID: <4F2FC125.5030506@oracle.com> On 02/ 3/12 02:26 PM, Weijun Wang wrote: > Hi Vinnie > > The code change is fine. > Thanks. > However, I noticed something weird when trying out your test. It seems for each > PrivateKeyEntry, there is a TrustedCertificateEntry with the same cert: > > x, Feb 3, 2012, PrivateKeyEntry, > Certificate fingerprint (SHA1): > DB:8F:DC:61:EF:A6:CC:FE:FB:66:6F:6A:E6:32:71:0C:DD:E1:E7:3D > x 1, Feb 3, 2012, trustedCertEntry, > Certificate fingerprint (SHA1): > DB:8F:DC:61:EF:A6:CC:FE:FB:66:6F:6A:E6:32:71:0C:DD:E1:E7:3D > > Should the "x 1" one be removed? I haven't tried what will happen if the private > entry contains more than one certs in its chain. > When a private key and associated certificate chain is imported into a MacOS keychain then a separate certificate entry gets created for each certificate in the private key's certificate chain. > Thanks > Max > > On 02/02/2012 11:19 PM, Vincent Ryan wrote: >> Please review the following fix to Mac OSX keychain support: >> http://cr.openjdk.java.net/~vinnie/7133495/webrev.00/ >> >> Thanks. From weijun.wang at oracle.com Tue Feb 7 13:11:14 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 07 Feb 2012 21:11:14 +0800 Subject: code review request: 6880619: reg test for 6879540 In-Reply-To: <6203641.1328619679128.JavaMail.sbladm@swsblss4-new.central.sun.com> References: <6203641.1328619679128.JavaMail.sbladm@swsblss4-new.central.sun.com> Message-ID: <4F3122F2.8040206@oracle.com> Hi Valerie Please review this code change: http://cr.openjdk.java.net/~weijun/6880619/webrev.00/ 6879540 was about enabling empty password in kerberos. It did not have any reg test. This is for it. Thanks Max -------- Original Message -------- *Change Request ID*: 6880619 *Synopsis*: reg test for 6879540 === *Description* ============================================================ This test checks for the correctness of 6879540. From alan.bateman at oracle.com Tue Feb 7 13:28:48 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 07 Feb 2012 13:28:48 +0000 Subject: hg: jdk8/tl/jdk: 7142847: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java has incorrect @run tag, runs Basic Message-ID: <20120207132908.58363473BC@hg.openjdk.java.net> Changeset: c6d6ef8ec2bf Author: alanb Date: 2012-02-07 13:28 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6d6ef8ec2bf 7142847: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java has incorrect @run tag, runs Basic Reviewed-by: chegar ! test/java/nio/file/WatchService/Basic.java ! test/java/nio/file/WatchService/SensitivityModifier.java From joe.darcy at oracle.com Wed Feb 8 01:40:05 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 08 Feb 2012 01:40:05 +0000 Subject: hg: jdk8/tl/jdk: 7143629: JDK jar/zip code should use unsigned library support Message-ID: <20120208014023.43199473D2@hg.openjdk.java.net> Changeset: 946056e6116e Author: darcy Date: 2012-02-07 17:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/946056e6116e 7143629: JDK jar/zip code should use unsigned library support Reviewed-by: sherman ! src/share/classes/java/util/jar/JarOutputStream.java ! src/share/classes/java/util/jar/Manifest.java ! src/share/classes/java/util/zip/InflaterInputStream.java ! src/share/classes/java/util/zip/ZipInputStream.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipConstants.java From valerie.peng at oracle.com Wed Feb 8 03:25:02 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 07 Feb 2012 19:25:02 -0800 Subject: code review request: 6880619: reg test for 6879540 In-Reply-To: <4F3122F2.8040206@oracle.com> References: <6203641.1328619679128.JavaMail.sbladm@swsblss4-new.central.sun.com> <4F3122F2.8040206@oracle.com> Message-ID: <4F31EB0E.4010905@oracle.com> Looks ok to me. Thanks, Valerie On 02/07/12 05:11, Weijun Wang wrote: > Hi Valerie > > Please review this code change: > > http://cr.openjdk.java.net/~weijun/6880619/webrev.00/ > > 6879540 was about enabling empty password in kerberos. It did not have > any reg test. This is for it. > > Thanks > Max > > -------- Original Message -------- > *Change Request ID*: 6880619 > *Synopsis*: reg test for 6879540 > > === *Description* > ============================================================ > This test checks for the correctness of 6879540. > From weijun.wang at oracle.com Wed Feb 8 03:45:21 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 08 Feb 2012 03:45:21 +0000 Subject: hg: jdk8/tl/jdk: 6880619: reg tests for 6879540 Message-ID: <20120208034540.77D12473DC@hg.openjdk.java.net> Changeset: 085c4f780d4e Author: weijun Date: 2012-02-08 11:44 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/085c4f780d4e 6880619: reg tests for 6879540 Reviewed-by: valeriep + test/sun/security/krb5/auto/EmptyPassword.java From valerie.peng at oracle.com Wed Feb 8 03:51:09 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 07 Feb 2012 19:51:09 -0800 Subject: code review request: 7133112: [macosx] org.ietf.jgss.GSSException while sun.security.jgss.GSSManagerImpl.createName In-Reply-To: <4F2E07DF.6010808@oracle.com> References: <18100302.1328390474311.JavaMail.sbladm@swsblss4-new.central.sun.com> <4F2E07DF.6010808@oracle.com> Message-ID: <4F31F12D.80802@oracle.com> Changes look good. Yes, since nativeGSS has only been tested previously on Solaris and Linux, it can only be enabled on these 2 OS. I suspect the core dump is due to some missing API support from the native GSS libs on Mac, but I have not had the cycles to look into this more. Filing a separate bug to track this support sounds reasonable. Thanks, Valerie On 02/04/12 20:38, Weijun Wang wrote: > Hi Valerie > > Please review this code change > > http://cr.openjdk.java.net/~weijun/7133112/webrev.00/ > > Basically the reason is that native the GSS provider is not turned on > (GSSManagerImpl::USE_NATIVE is false), so we should not test it on Mac. > > The Mac does include native gss libs. I try to return true there, and > load either /usr/lib/libgssapi_krb5.dylib or > /usr/lib/sasl2/libgssapiv2.2.so in SunNativeProvider, always core > dumped. So seems it's not simple and I created a new bug (7142798) on it. > > Thanks > Max > > -------- Original Message -------- > > *Change Request ID*: 7133112 > > *Synopsis*: [macosx] org.ietf.jgss.GSSException while > sun.security.jgss.GSSManagerImpl.createName > > === *Description* > ============================================================ > Please see test: sun/security/krb5/runNameEquals.sh. > Following exception is thrown: > Exception in thread "main" GSSException: Invalid name provided > (Mechanism level: Cannot locate default realm) > at > sun.security.jgss.krb5.Krb5NameElement.getInstance(Krb5NameElement.java:127) > at > sun.security.jgss.krb5.Krb5MechFactory.getNameElement(Krb5MechFactory.java:95) > at > sun.security.jgss.GSSManagerImpl.getNameElement(GSSManagerImpl.java:202) > at sun.security.jgss.GSSNameImpl.getElement(GSSNameImpl.java:472) > at sun.security.jgss.GSSNameImpl.init(GSSNameImpl.java:201) > at sun.security.jgss.GSSNameImpl.(GSSNameImpl.java:170) > at sun.security.jgss.GSSManagerImpl.createName(GSSManagerImpl.java:137) > at Krb5NameEquals.main(Krb5NameEquals.java:53) > > JIRA Equivalent: http://java.net/jira/browse/MACOSX_PORT-146 > From vincent.x.ryan at oracle.com Wed Feb 8 09:18:22 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 08 Feb 2012 09:18:22 +0000 Subject: Code review request: 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done Message-ID: <4F323DDE.2060400@oracle.com> Please review the following change: http://cr.openjdk.java.net/~vinnie/7142339/webrev.00/ for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142339 It employs lazy initialization to avoid the overhead of creating a secure random number generator in code that never uses signature timestamping. Thanks. From xuelei.fan at oracle.com Wed Feb 8 09:35:25 2012 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 08 Feb 2012 17:35:25 +0800 Subject: Code review request: 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done In-Reply-To: <4F323DDE.2060400@oracle.com> References: <4F323DDE.2060400@oracle.com> Message-ID: <4F3241DD.8040504@oracle.com> Looks fine to me. Interesting fix that making use of the class loading priorities. Xuelei On 2/8/2012 5:18 PM, Vincent Ryan wrote: > Please review the following change: > http://cr.openjdk.java.net/~vinnie/7142339/webrev.00/ > > for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142339 > > It employs lazy initialization to avoid the overhead of creating a secure > random number generator in code that never uses signature timestamping. > > Thanks. From chris.hegarty at oracle.com Wed Feb 8 10:47:59 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 08 Feb 2012 10:47:59 +0000 Subject: Code review request: 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done In-Reply-To: <4F3241DD.8040504@oracle.com> References: <4F323DDE.2060400@oracle.com> <4F3241DD.8040504@oracle.com> Message-ID: <4F3252DF.7010702@oracle.com> On 08/02/2012 09:35, Xuelei Fan wrote: > Looks fine to me. > > Interesting fix that making use of the class loading priorities. The 'Initialization on Demand Holder idiom' is used in other places in the platform. I think it suits well here, if creating a SecureRandom at this point is expensive. Especially if it may not be needed. Not directly related but "// should not happen". Should this throw an Error? I've seen this in other places too, certainly can be handled separately and not a blocker for this particular fix. -Chris. > > Xuelei > > On 2/8/2012 5:18 PM, Vincent Ryan wrote: >> Please review the following change: >> http://cr.openjdk.java.net/~vinnie/7142339/webrev.00/ >> >> for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142339 >> >> It employs lazy initialization to avoid the overhead of creating a secure >> random number generator in code that never uses signature timestamping. >> >> Thanks. > From chris.hegarty at oracle.com Wed Feb 8 11:20:44 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 08 Feb 2012 11:20:44 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20120208112123.3591B473E4@hg.openjdk.java.net> Changeset: c64c815974ff Author: chegar Date: 2012-02-08 11:16 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c64c815974ff 7105929: java/util/concurrent/FutureTask/BlockingTaskExecutor.java fails on solaris sparc Reviewed-by: dholmes ! test/java/util/concurrent/FutureTask/BlockingTaskExecutor.java Changeset: 7289599216fe Author: gadams Date: 2012-02-08 11:18 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7289599216fe 6736316: Timeout value in java/util/concurrent/locks/Lock/FlakyMutex.java is insufficient Reviewed-by: chegar, dholmes, alanb ! test/java/util/concurrent/locks/Lock/FlakyMutex.java Changeset: 72d8f91514d1 Author: gadams Date: 2012-02-08 11:19 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72d8f91514d1 6957683: test/java/util/concurrent/ThreadPoolExecutor/Custom.java failing Reviewed-by: chegar, dholmes, alanb ! test/java/util/concurrent/ThreadPoolExecutor/Custom.java From vincent.x.ryan at oracle.com Wed Feb 8 11:42:58 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 08 Feb 2012 11:42:58 +0000 Subject: Code review request: 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done In-Reply-To: <4F3241DD.8040504@oracle.com> References: <4F323DDE.2060400@oracle.com> <4F3241DD.8040504@oracle.com> Message-ID: <4F325FC2.1000009@oracle.com> Thanks for your review. On 02/ 8/12 09:35 AM, Xuelei Fan wrote: > Looks fine to me. > > Interesting fix that making use of the class loading priorities. > > Xuelei > > On 2/8/2012 5:18 PM, Vincent Ryan wrote: >> Please review the following change: >> http://cr.openjdk.java.net/~vinnie/7142339/webrev.00/ >> >> for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142339 >> >> It employs lazy initialization to avoid the overhead of creating a secure >> random number generator in code that never uses signature timestamping. >> >> Thanks. > From vincent.x.ryan at oracle.com Wed Feb 8 11:44:28 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 08 Feb 2012 11:44:28 +0000 Subject: Code review request: 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done In-Reply-To: <4F3252DF.7010702@oracle.com> References: <4F323DDE.2060400@oracle.com> <4F3241DD.8040504@oracle.com> <4F3252DF.7010702@oracle.com> Message-ID: <4F32601C.80800@oracle.com> Thanks Chris. On 02/ 8/12 10:47 AM, Chris Hegarty wrote: > On 08/02/2012 09:35, Xuelei Fan wrote: >> Looks fine to me. >> >> Interesting fix that making use of the class loading priorities. > > The 'Initialization on Demand Holder idiom' is used in other places in the > platform. I think it suits well here, if creating a SecureRandom at this point > is expensive. Especially if it may not be needed. > > Not directly related but "// should not happen". Should this throw an Error? > I've seen this in other places too, certainly can be handled separately and not > a blocker for this particular fix. I don't throw an error because it is permitted to generate a timestamp token without a secure random number. Of course, if the generator cannot be initialized successfully then that suggests a JRE configuration problem which may eventually result in an error. > > -Chris. > >> >> Xuelei >> >> On 2/8/2012 5:18 PM, Vincent Ryan wrote: >>> Please review the following change: >>> http://cr.openjdk.java.net/~vinnie/7142339/webrev.00/ >>> >>> for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142339 >>> >>> It employs lazy initialization to avoid the overhead of creating a secure >>> random number generator in code that never uses signature timestamping. >>> >>> Thanks. >> From bradford.wetmore at oracle.com Wed Feb 8 20:54:36 2012 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Wed, 08 Feb 2012 12:54:36 -0800 Subject: Code review request: 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done In-Reply-To: <4F323DDE.2060400@oracle.com> References: <4F323DDE.2060400@oracle.com> Message-ID: <4F32E10C.9000909@oracle.com> Still looks good, thanks for making the minor style corrections. :) Cheers, Brad On 2/8/2012 1:18 AM, Vincent Ryan wrote: > Please review the following change: > http://cr.openjdk.java.net/~vinnie/7142339/webrev.00/ > > for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142339 > > It employs lazy initialization to avoid the overhead of creating a secure > random number generator in code that never uses signature timestamping. > > Thanks. From alan.bateman at oracle.com Thu Feb 9 13:45:50 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 09 Feb 2012 13:45:50 +0000 Subject: hg: jdk8/tl/jdk: 7114611: (fs) DirectoryStream fails with SIGBUS on some embedded platforms, dirent alignment Message-ID: <20120209134626.6B1D94740E@hg.openjdk.java.net> Changeset: 184b9cb4f13a Author: alanb Date: 2012-02-09 13:43 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/184b9cb4f13a 7114611: (fs) DirectoryStream fails with SIGBUS on some embedded platforms, dirent alignment Reviewed-by: dholmes, alanb Contributed-by: carlos.lucasius at oracle.com ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c From alan.bateman at oracle.com Thu Feb 9 16:39:29 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 09 Feb 2012 16:39:29 +0000 Subject: hg: jdk8/tl/jdk: 7144086: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java failing intermittently Message-ID: <20120209163946.4821447413@hg.openjdk.java.net> Changeset: 8326d434681d Author: alanb Date: 2012-02-09 16:38 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8326d434681d 7144086: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java failing intermittently Reviewed-by: chegar ! test/java/nio/file/WatchService/SensitivityModifier.java From weijun.wang at oracle.com Fri Feb 10 03:42:30 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 10 Feb 2012 03:42:30 +0000 Subject: hg: jdk8/tl/jdk: 6879539: enable empty password support for pkcs12 keystore Message-ID: <20120210034249.51BB64742A@hg.openjdk.java.net> Changeset: bdd1dd1e1462 Author: weijun Date: 2012-02-10 11:41 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bdd1dd1e1462 6879539: enable empty password support for pkcs12 keystore Reviewed-by: vinnie, weijun Contributed-by: Florian Weimer ! src/share/classes/com/sun/crypto/provider/PBEKey.java ! src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java + test/sun/security/pkcs12/Bug6415637.java From bradford.wetmore at oracle.com Fri Feb 10 06:43:02 2012 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Thu, 09 Feb 2012 22:43:02 -0800 Subject: Code review request Message-ID: <4F34BC76.1010507@oracle.com> Two line code fix, but an important couple of lines. :) The underlying cipher still had buffered data when using Direct ByteBuffers. This changes makes sure that data is read out. 7142509: Cipher.doFinal(ByteBuffer,ByteBuffer) fails to process when in.remaining() == 0 Description: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142509 Codereview: http://cr.openjdk.java.net/~wetmore/7142509/ Thanks, Brad From lana.steuck at oracle.com Fri Feb 10 18:43:54 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:43:54 +0000 Subject: hg: jdk8/tl: 3 new changesets Message-ID: <20120210184354.84E8547465@hg.openjdk.java.net> Changeset: 5350cd6e0cc0 Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5350cd6e0cc0 Added tag jdk8-b24 for changeset 1a5f1d6b98d6 ! .hgtags Changeset: 221a378e06a3 Author: lana Date: 2012-02-07 10:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/221a378e06a3 Merge Changeset: 2accafff224a Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/2accafff224a Added tag jdk8-b25 for changeset 221a378e06a3 ! .hgtags From lana.steuck at oracle.com Fri Feb 10 18:43:58 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:43:58 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20120210184358.74B1847466@hg.openjdk.java.net> Changeset: bb694c151fc7 Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/bb694c151fc7 Added tag jdk8-b24 for changeset 7836655e2495 ! .hgtags Changeset: dbb7283c197b Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/dbb7283c197b Added tag jdk8-b25 for changeset bb694c151fc7 ! .hgtags From lana.steuck at oracle.com Fri Feb 10 18:43:54 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:43:54 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20120210184359.2EBE547467@hg.openjdk.java.net> Changeset: e45d6b406d5f Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e45d6b406d5f Added tag jdk8-b24 for changeset b98f0e6dddf9 ! .hgtags Changeset: 79f709a099f4 Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/79f709a099f4 Added tag jdk8-b25 for changeset e45d6b406d5f ! .hgtags From lana.steuck at oracle.com Fri Feb 10 18:44:02 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:44:02 +0000 Subject: hg: jdk8/tl/jaxws: 3 new changesets Message-ID: <20120210184402.CD0A847468@hg.openjdk.java.net> Changeset: b376d901e006 Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b376d901e006 Added tag jdk8-b24 for changeset e0d90803439b ! .hgtags Changeset: 3518639eab6c Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/3518639eab6c Added tag jdk8-b25 for changeset b376d901e006 ! .hgtags Changeset: 65977d8d348e Author: lana Date: 2012-02-09 22:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/65977d8d348e Merge From lana.steuck at oracle.com Fri Feb 10 18:44:06 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:44:06 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20120210184418.4484B47469@hg.openjdk.java.net> Changeset: 5a784dab75f1 Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5a784dab75f1 Added tag jdk8-b24 for changeset 6c9d21ca92c4 ! .hgtags Changeset: 520c30f85bb5 Author: lana Date: 2012-02-07 10:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/520c30f85bb5 Merge Changeset: b556aa8a99c3 Author: katleman Date: 2012-02-09 12:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b556aa8a99c3 Added tag jdk8-b25 for changeset 520c30f85bb5 ! .hgtags Changeset: 2ac31f40741d Author: lana Date: 2012-02-09 22:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2ac31f40741d Merge From lana.steuck at oracle.com Fri Feb 10 18:44:36 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:44:36 +0000 Subject: hg: jdk8/tl/hotspot: 74 new changesets Message-ID: <20120210184717.ADD984746B@hg.openjdk.java.net> Changeset: 5f3fcd591768 Author: amurillo Date: 2012-01-20 17:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5f3fcd591768 7131979: new hotspot build - hs23-b12 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 53a127075045 Author: kvn Date: 2012-01-20 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/53a127075045 7131302: connode.cpp:205 Error: ShouldNotReachHere() Summary: Add Value() methods to short and byte Load nodes to truncate constants which does not fit. Reviewed-by: jrose ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp Changeset: 9164b8236699 Author: iveresov Date: 2012-01-20 15:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9164b8236699 7131028: Switch statement takes wrong path Summary: Pass correct type to branch in LIRGenerator::do_SwitchRanges() Reviewed-by: kvn, never ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp Changeset: a81f60ddab06 Author: never Date: 2012-01-22 14:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a81f60ddab06 7130676: Tiered: assert(bci == 0 || 0<= bci && bciis_loaded() Summary: handle not loaded array klass in Parse::do_checkcast(). Reviewed-by: kvn, never ! src/share/vm/opto/parseHelper.cpp Changeset: 5dbed2f542ff Author: bdelsart Date: 2012-01-26 16:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5dbed2f542ff 7120468: SPARC/x86: use frame::describe to enhance trace_method_handle Summary: improvements of TraceMethodHandles for JSR292 Reviewed-by: never, twisti ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/cpu/zero/vm/frame_zero.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp Changeset: 20334ed5ed3c Author: iveresov Date: 2012-01-26 12:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/20334ed5ed3c 7131259: compile_method and CompilationPolicy::event shouldn't be declared TRAPS Summary: Make sure that CompilationPolicy::event() doesn't throw exceptions Reviewed-by: kvn, never ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/advancedThresholdPolicy.hpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/compilationPolicy.hpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp ! src/share/vm/utilities/exceptions.hpp Changeset: 072384a61312 Author: jrose Date: 2012-01-26 19:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/072384a61312 Merge Changeset: 2e966d967c5c Author: johnc Date: 2012-01-13 13:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2e966d967c5c 7121547: G1: High number mispredicted branches while iterating over the marking bitmap Summary: There is a high number of mispredicted branches associated with calling BitMap::iteratate() from within CMBitMapRO::iterate(). Implement a version of CMBitMapRO::iterate() directly using inline-able routines. Reviewed-by: tonyp, iveresov ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/utilities/bitMap.inline.hpp Changeset: 851b58c26def Author: brutisso Date: 2012-01-16 11:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/851b58c26def 7130334: G1: Change comments and error messages that refer to CMS in g1/concurrentMark.cpp/hpp Summary: Removed references to CMS in the concurrentMark.cpp/hpp files. Reviewed-by: tonyp, jmasa, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp Changeset: 9509c20bba28 Author: brutisso Date: 2012-01-16 22:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9509c20bba28 6976060: G1: humongous object allocations should initiate marking cycles when necessary Reviewed-by: tonyp, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp ! src/share/vm/gc_interface/gcCause.cpp ! src/share/vm/gc_interface/gcCause.hpp Changeset: 0b3d1ec6eaee Author: tonyp Date: 2012-01-18 10:30 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0b3d1ec6eaee 7097586: G1: improve the per-space output when using jmap -heap Summary: Extend the jmap -heap output for G1 to include some more G1-specific information. Reviewed-by: brutisso, johnc, poonam ! agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/G1CollectedHeap.java ! agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/G1MonitoringSupport.java + agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/HeapRegionSetBase.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/vmStructs_g1.hpp Changeset: 7ca7be5a6a0b Author: johnc Date: 2012-01-17 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7ca7be5a6a0b 7129271: G1: Interference from multiple threads in PrintGC/PrintGCDetails output Summary: During an initial mark pause, signal the Concurrent Mark thread after the pause output from PrintGC/PrintGCDetails is complete. Reviewed-by: tonyp, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: a8a126788ea0 Author: tonyp Date: 2012-01-19 09:13 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a8a126788ea0 7078465: G1: Don't use the undefined value (-1) for the G1 old memory pool max size Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/g1/g1MonitoringSupport.hpp ! src/share/vm/services/g1MemoryPool.hpp Changeset: 57025542827f Author: brutisso Date: 2012-01-20 18:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/57025542827f 7131791: G1: Asserts in nightly testing due to 6976060 Summary: Create a handle and fake an object to make sure that we don't loose the memory we just allocated Reviewed-by: tonyp, stefank ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: 6a78aa6ac1ff Author: brutisso Date: 2012-01-23 20:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6a78aa6ac1ff 7132311: G1: assert((s == klass->oop_size(this)) || (Universe::heap()->is_gc_active() && ((is_typeArray()... Summary: Move the check for when to call collect() to before we do a humongous object allocation Reviewed-by: stefank, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: 877914d90c57 Author: tonyp Date: 2012-01-24 17:08 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/877914d90c57 7132398: G1: java.lang.IllegalArgumentException: Invalid threshold: 9223372036854775807 > max (1073741824) Summary: Was not passing the right old pool max to the memory pool constructor in the fix for 7078465. Reviewed-by: brutisso, johnc ! src/share/vm/services/g1MemoryPool.cpp Changeset: d30fa85f9994 Author: johnc Date: 2012-01-12 00:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d30fa85f9994 6484965: G1: piggy-back liveness accounting phase on marking Summary: Remove the separate counting phase of concurrent marking by tracking the amount of marked bytes and the cards spanned by marked objects in marking task/worker thread local data structures, which are updated as individual objects are marked. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1EvacFailure.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp Changeset: eff609af17d7 Author: tonyp Date: 2012-01-25 12:58 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eff609af17d7 7127706: G1: re-enable survivors during the initial-mark pause Summary: Re-enable survivors during the initial-mark pause. Afterwards, the concurrent marking threads have to scan them and mark everything reachable from them. The next GC will have to wait for the survivors to be scanned. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1EvacFailure.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegion.inline.hpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp Changeset: a5244e07b761 Author: jcoomes Date: 2012-01-25 21:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a5244e07b761 7112413: JVM Crash, possibly GC-related Summary: disable UseAdaptiveSizePolicy with the CMS and ParNew Reviewed-by: johnc, brutisso ! src/share/vm/runtime/arguments.cpp Changeset: b4ebad3520bb Author: johnc Date: 2012-01-26 14:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b4ebad3520bb 7133038: G1: Some small profile based optimizations Summary: Some minor profile based optimizations. Reduce the number of branches and branch mispredicts by removing some virtual calls, through closure specalization, and refactoring some conditional statements. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp Changeset: 0a10d80352d5 Author: brutisso Date: 2012-01-27 09:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0a10d80352d5 Merge - src/os/bsd/vm/decoder_bsd.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp Changeset: af739d5ab23c Author: bpittore Date: 2012-01-21 23:02 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/af739d5ab23c 6972759: Step over not working after thrown exception and Pop Summary: reset jvmtithreadstate exception state after frame pop and forceearlyreturn processed Reviewed-by: minqi, dholmes, dlong Contributed-by: bill.pittore at oracle.com ! src/share/vm/prims/jvmtiThreadState.cpp ! src/share/vm/prims/jvmtiThreadState.hpp Changeset: 583b428aa858 Author: coleenp Date: 2012-01-23 17:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/583b428aa858 Merge - src/os/bsd/vm/decoder_bsd.cpp Changeset: d6660fedbab5 Author: phh Date: 2012-01-24 14:07 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d6660fedbab5 7126732: MAC: Require Mac OS X builds/tests for JPRT integrate jobs for HotSpot Summary: Modify jprt.properties to run OSX builds and tests. Reviewed-by: dcubed, kamg, ohair, dholmes Contributed-by: james.melvin at oracle.com ! make/jprt.properties Changeset: bf864f701a4a Author: dsamersoff Date: 2012-01-25 02:29 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bf864f701a4a 7066129: GarbageCollectorMXBean#getLastGcInfo leaks native memory Summary: Make GCStatInfo a resource object Reviewed-by: phh, coleenp ! src/share/vm/services/gcNotifier.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/memoryManager.cpp ! src/share/vm/services/memoryManager.hpp Changeset: df88f58f3b61 Author: dsamersoff Date: 2012-01-24 20:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/df88f58f3b61 Merge Changeset: e8a4934564b2 Author: phh Date: 2012-01-24 19:33 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e8a4934564b2 7125793: MAC: test_gamma should always work Summary: Fix gamma launcher on Mac OS X and reconcile test_gamma script on Unix platforms Reviewed-by: dcubed, ohair, jcoomes, dholmes, ksrini Contributed-by: james.melvin at oracle.com ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make ! make/linux/makefiles/buildtree.make ! make/solaris/makefiles/buildtree.make ! src/os/bsd/vm/os_bsd.cpp ! src/os/posix/launcher/java_md.c Changeset: 78dadb7b16ab Author: phh Date: 2012-01-25 01:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/78dadb7b16ab Merge Changeset: d708a8cdd022 Author: kamg Date: 2012-01-25 10:08 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d708a8cdd022 Merge Changeset: 520830f632e7 Author: fparain Date: 2012-01-25 10:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/520830f632e7 7131346: Parsing of boolean arguments to diagnostic commands is broken Reviewed-by: dholmes, dcubed ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp Changeset: 24ec1a6d6ef3 Author: fparain Date: 2012-01-25 16:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/24ec1a6d6ef3 Merge Changeset: a42c07c38c47 Author: dsamersoff Date: 2012-01-25 21:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a42c07c38c47 7132515: Add dcmd to manage UnlockingCommercialFeature flag Summary: Added dcmd to unlock or check status of UnlockingCommercialFeature flag Reviewed-by: fparain, rottenha ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp + src/share/vm/services/diagnosticCommand_ext.hpp ! src/share/vm/services/diagnosticFramework.hpp ! src/share/vm/services/management.cpp Changeset: 6d00795f99a1 Author: dsamersoff Date: 2012-01-25 15:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6d00795f99a1 Merge Changeset: 6db63e782d3d Author: dsamersoff Date: 2012-01-25 18:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6db63e782d3d Merge Changeset: de268c8a8075 Author: phh Date: 2012-01-26 20:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/de268c8a8075 7082553: Interpret Thread.setPriority(Thread.MAX_PRIORITY) to mean FX60 on Solaris 10 and 11 Summary: Add CriticalPriority == MaxPriority+1 and enable scheduling class as well as thread priority to change on Solaris. Reviewed-by: dholmes, dcubed ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/osThread_solaris.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp Changeset: bf5da1648543 Author: kamg Date: 2012-01-27 10:42 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bf5da1648543 Merge ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/globals.hpp Changeset: 9e177d44b10f Author: amurillo Date: 2012-01-27 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9e177d44b10f Merge Changeset: a80fd4f45d7a Author: amurillo Date: 2012-01-27 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a80fd4f45d7a Added tag hs23-b12 for changeset 9e177d44b10f ! .hgtags Changeset: 905945c5913e Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/905945c5913e Added tag jdk8-b24 for changeset a80fd4f45d7a ! .hgtags Changeset: 9f1c2b7cdfb6 Author: amurillo Date: 2012-01-27 14:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9f1c2b7cdfb6 7135385: new hotspot build - hs23-b13 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 34e2e90e7182 Author: rbackman Date: 2012-01-24 14:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/34e2e90e7182 7130476: Remove use of #ifdef TRACE_DEFINE_KLASS_TRACE_ID from klass.hpp Reviewed-by: kamg, phh, dsamersoff Contributed-by: Rickard Backman ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/trace/traceMacros.hpp Changeset: 26a08cbbf042 Author: stefank Date: 2012-01-27 13:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/26a08cbbf042 7022100: Method annotations are incorrectly set when redefining classes Summary: Changed to the correct annotation arrays Reviewed-by: kamg, dholmes, sla ! src/share/vm/oops/instanceKlass.hpp Changeset: f457154eee8b Author: brutisso Date: 2012-01-30 12:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f457154eee8b 7140882: Don't return booleans from methods returning pointers Summary: Changed "return false" to "return NULL" Reviewed-by: dholmes, rottenha Contributed-by: dbhole at redhat.com ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/opto/loopnode.cpp Changeset: d96c130c9399 Author: brutisso Date: 2012-01-30 05:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d96c130c9399 Merge Changeset: b2cd0ee8f778 Author: acorn Date: 2012-01-30 23:27 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b2cd0ee8f778 7114376: Make system dictionary hashtable bucket array size configurable Summary: 7u4 new experimental flag -XX:PredictedClassLoadedCount=# Reviewed-by: dholmes, phh, dcubed ! agent/src/share/classes/sun/jvm/hotspot/memory/LoaderConstraintTable.java ! agent/src/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/hashtable.hpp Changeset: 481a9443f721 Author: phh Date: 2012-02-01 15:01 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/481a9443f721 7123386: RFE: Preserve universal builds of HotSpot on Mac OS X Summary: Add support for packaging HotSpot JVM builds in universal binaries Reviewed-by: dholmes, kamg, dcubed, phh Contributed-by: james.melvin at oracle.com ! make/Makefile ! make/bsd/makefiles/defs.make + make/bsd/makefiles/universal.gmk ! make/defs.make Changeset: 527cf36f4a20 Author: fparain Date: 2012-02-03 14:04 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/527cf36f4a20 Merge ! src/share/vm/runtime/globals.hpp Changeset: 1a2723f7ad8e Author: never Date: 2012-01-29 16:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1a2723f7ad8e 7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale Reviewed-by: kvn, iveresov, dholmes ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/gcLocker.inline.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/safepoint.hpp ! src/share/vm/runtime/thread.hpp Changeset: 5f17b16b3219 Author: iveresov Date: 2012-01-30 19:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5f17b16b3219 7141059: 7116795 broke pure c2 builds Summary: Fix pure c2 builds Reviewed-by: kvn, brutisso, never ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c2_globals_x86.hpp ! src/cpu/x86/vm/frame_x86.cpp ! src/share/vm/runtime/globals.hpp Changeset: 5ed8f599a788 Author: kvn Date: 2012-01-31 07:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5ed8f599a788 7140924: SIGSEGV in compiled code for sun.awt.X11.XDecoratedPeer.updateMinSizeHints Summary: Use unknown_obj instead of empty_map for NULL or Constant Pool object constants in bytecode Escape Analyzer. Reviewed-by: iveresov, never ! src/share/vm/ci/bcEscapeAnalyzer.cpp Changeset: 2f5980b127e3 Author: twisti Date: 2012-01-31 09:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2f5980b127e3 7132180: JSR 292: C1 JVM crash with ClassValue/MethodHandle Reviewed-by: never ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: f067b4e0e04b Author: roland Date: 2012-02-01 10:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f067b4e0e04b 7090976: Eclipse/CDT causes a JVM crash while indexing C++ code Summary: too optimistic inlining decision confuses local value numbering. Reviewed-by: never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_ValueMap.cpp + test/compiler/7090976/Test7090976.java Changeset: aa3d708d67c4 Author: never Date: 2012-02-01 07:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aa3d708d67c4 7141200: log some interesting information in ring buffers for crashes Reviewed-by: kvn, jrose, kevinw, brutisso, twisti, jmasa ! src/os/windows/vm/os_windows.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/debug.hpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/events.hpp ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/vmError.cpp Changeset: 0382d2b469b2 Author: never Date: 2012-02-01 16:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0382d2b469b2 7013347: allow crypto functions to be called inline to enhance performance Reviewed-by: kvn ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/oops/arrayOop.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/prims/nativeLookup.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/safepoint.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 392a3f07d567 Author: twisti Date: 2012-02-02 09:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/392a3f07d567 7141637: JSR 292: MH spread invoker crashes with NULL argument on x86_32 Reviewed-by: twisti Contributed-by: Volker Simonis ! src/cpu/x86/vm/methodHandles_x86.cpp + test/compiler/7141637/SpreadNullArg.java Changeset: 379b22e03c32 Author: jcoomes Date: 2012-02-03 12:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/379b22e03c32 Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/globals.hpp Changeset: be649fefcdc2 Author: stefank Date: 2012-01-27 14:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/be649fefcdc2 7134655: Crash in reference processing when doing single-threaded remarking Summary: Temporarily disabled multi-threaded reference discovery when entering a single-threaded remark phase. Reviewed-by: brutisso, tonyp, jmasa, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: c03e06373b47 Author: stefank Date: 2012-01-28 01:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c03e06373b47 Merge - src/os/bsd/vm/decoder_bsd.cpp Changeset: 2eeebe4b4213 Author: brutisso Date: 2012-01-30 15:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2eeebe4b4213 7140909: Visual Studio project builds broken: need to define INCLUDE_TRACE Summary: Add define of INCLUDE_TRACE Reviewed-by: sla, kamg ! src/share/tools/ProjectCreator/BuildConfig.java Changeset: 24cae3e4cbaa Author: jcoomes Date: 2012-02-02 16:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/24cae3e4cbaa 6679764: enable parallel compaction by default Reviewed-by: phh, jmasa ! src/share/vm/runtime/arguments.cpp Changeset: 5ab44ceb4d57 Author: jcoomes Date: 2012-02-03 12:20 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5ab44ceb4d57 Merge Changeset: b22de8247499 Author: amurillo Date: 2012-02-03 18:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b22de8247499 Merge Changeset: 4e9b30938cbf Author: amurillo Date: 2012-02-03 18:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4e9b30938cbf Added tag hs23-b13 for changeset b22de8247499 ! .hgtags Changeset: 1f22b536808b Author: amurillo Date: 2012-02-03 18:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1f22b536808b 7142393: new hotspot build - hs23-b14 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 585feefad374 Author: phh Date: 2012-02-06 14:01 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/585feefad374 7142852: MAC: Comment out JPRT jbb tests on Mac OS X until 7142850 is resolved Summary: Comment out JPRT jbb tests on Mac OS X until GUI hang can be fixed Reviewed-by: dholmes, brutisso, phh Contributed-by: james.melvin at oracle.com ! make/jprt.properties Changeset: 64b46f975ab8 Author: phh Date: 2012-02-06 14:02 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/64b46f975ab8 7142616: MAC: Honor ALT_EXPORT_PATH overrides from JDK control builds Summary: Fix EXPORT_PATH overrides on Mac OS X and only change default. Reviewed-by: phh, dcubed Contributed-by: james.melvin at oracle.com ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/universal.gmk Changeset: 9ad8feb5afbd Author: amurillo Date: 2012-02-06 12:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9ad8feb5afbd Added tag hs23-b14 for changeset 64b46f975ab8 ! .hgtags Changeset: aaceb8ddf2e2 Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aaceb8ddf2e2 Added tag jdk8-b25 for changeset 9ad8feb5afbd ! .hgtags From lana.steuck at oracle.com Fri Feb 10 18:44:54 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 10 Feb 2012 18:44:54 +0000 Subject: hg: jdk8/tl/jdk: 26 new changesets Message-ID: <20120210184942.23C1C4746C@hg.openjdk.java.net> Changeset: 8da468cf037b Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8da468cf037b Added tag jdk8-b24 for changeset 34029a0c69bb ! .hgtags Changeset: ad9f1c8970da Author: prr Date: 2012-01-19 12:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ad9f1c8970da 7131153: GetDC called way too many times - causes bad performance. Reviewed-by: igor, jgodinez ! src/windows/native/sun/font/fontpath.c Changeset: f7dda4bbf1f9 Author: lana Date: 2012-01-28 22:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7dda4bbf1f9 Merge - test/java/io/File/BlockIsDirectory.java Changeset: 84b153cd9bd4 Author: denis Date: 2012-01-19 14:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84b153cd9bd4 7121761: creation of java.awt.DataFlavour fails for turkish locale Reviewed-by: anthony ! src/share/classes/java/awt/datatransfer/MimeType.java Changeset: e32db6535c05 Author: alexsch Date: 2012-01-23 13:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e32db6535c05 7112854: [macosx] closed/javax/swing/JPopupMenu/Test6827786.java unstable on MacOS Reviewed-by: rupashka + test/javax/swing/JPopupMenu/6827786/bug6827786.java Changeset: cc88a9c0474f Author: alexsch Date: 2012-01-23 13:53 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc88a9c0474f 7116634: [macosx] closed/javax/swing/JTree/6263446/bug6263446Tree.java fails on MacOS Reviewed-by: rupashka + test/javax/swing/JTree/6263446/bug6263446.java Changeset: 19431d07bc19 Author: denis Date: 2012-01-23 17:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19431d07bc19 7130140: using horizontal scroll button on mouse causes a message to be printed on stdout Reviewed-by: art ! src/share/classes/java/awt/event/MouseEvent.java Changeset: 5255fd5b0418 Author: denis Date: 2012-01-24 18:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5255fd5b0418 7078460: JDialog is shown as separate icon on the taskbar Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: b4589ff4457c Author: malenkov Date: 2012-01-24 19:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4589ff4457c 7121905: grammatically incorrect apostrophe in BeanInfo javadoc Reviewed-by: rupashka ! src/share/classes/java/beans/BeanInfo.java Changeset: 4f2a2bf0ce84 Author: rupashka Date: 2012-01-26 17:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f2a2bf0ce84 7010561: Tab text position with Synth based LaF is different to Java 5/6 Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java + test/javax/swing/JTabbedPane/7010561/bug7010561.java Changeset: cc9ff174a1c3 Author: alexsch Date: 2012-01-27 16:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc9ff174a1c3 7122173: [macosx] Several Regression tests fail on MacOS Reviewed-by: rupashka + test/javax/swing/SwingUtilities/4917669/bug4917669.java + test/javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java + test/javax/swing/text/html/CSS/4530474/bug4530474.java + test/javax/swing/text/html/CSS/4530474/test.css + test/javax/swing/text/html/CSS/4530474/test.html Changeset: 96b5999af66b Author: alexsch Date: 2012-01-27 17:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/96b5999af66b 7109962: [macosx] closed/javax/swing/JList/6462008/bug6462008.java fails on MacOS Reviewed-by: rupashka + test/javax/swing/JList/6462008/bug6462008.java Changeset: 6a7109f52966 Author: alexsch Date: 2012-01-27 17:36 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a7109f52966 7105040: [macosx] closed/javax/swing/JPopupMenu/4966112/bug4966112.java deadlocks on MacOS Reviewed-by: rupashka + test/javax/swing/JPopupMenu/4966112/bug4966112.java Changeset: bc1c20ac8676 Author: chegar Date: 2012-01-27 13:48 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc1c20ac8676 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt Reviewed-by: art, prr, dholmes, alanb ! make/common/Release-embedded.gmk ! make/sun/font/Makefile ! make/sun/font/t2k/Makefile ! make/sun/headless/Makefile ! make/sun/jawt/Makefile ! make/sun/xawt/Makefile ! src/solaris/native/java/lang/java_props_md.c ! src/solaris/native/sun/awt/awt_LoadLibrary.c Changeset: 5dab2d55bc5b Author: lana Date: 2012-01-28 22:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5dab2d55bc5b Merge - test/java/io/File/BlockIsDirectory.java Changeset: 39b661c5867a Author: alexsch Date: 2012-01-30 12:52 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39b661c5867a 7122149: [macosx] closed/javax/swing/UITest/UITest.java fails on MacOS Reviewed-by: rupashka ! src/share/classes/sun/awt/OSInfo.java + test/javax/swing/UITest/UITest.java Changeset: 7d6c7dd72e25 Author: malenkov Date: 2012-01-31 14:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d6c7dd72e25 7122138: IAE thrown because Introspector ignores synthetic methods Reviewed-by: rupashka ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/Introspector/7122138/Test7122138.java + test/java/beans/Introspector/7122138/pack/Sub.java + test/java/beans/Introspector/7122138/pack/Super.java Changeset: c5c78f293ff8 Author: rupashka Date: 2012-01-31 17:30 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c5c78f293ff8 7082443: JComboBox not backward compatible (with Java 6) Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java + test/javax/swing/JComboBox/7082443/bug7082443.java Changeset: 363086137375 Author: lana Date: 2012-01-31 19:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/363086137375 Merge Changeset: 533bc0a10233 Author: lana Date: 2012-01-31 19:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/533bc0a10233 Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: ce62fb7aa1b8 Author: lana Date: 2012-02-07 10:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce62fb7aa1b8 Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: 1a99dad28223 Author: yhuang Date: 2012-02-06 18:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1a99dad28223 7129382: change minor unit of VND to 0 Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! test/java/util/Currency/tablea1.txt Changeset: 930756e55285 Author: yhuang Date: 2012-02-06 18:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/930756e55285 Merge Changeset: ec17fbe5b8fb Author: katleman Date: 2012-02-08 19:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ec17fbe5b8fb Merge Changeset: 5aca406e87cb Author: katleman Date: 2012-02-09 12:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5aca406e87cb Added tag jdk8-b25 for changeset ec17fbe5b8fb ! .hgtags Changeset: 7fc2797cbb4c Author: lana Date: 2012-02-09 22:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7fc2797cbb4c Merge From Xuelei.Fan at Oracle.COM Sat Feb 11 02:50:41 2012 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Sat, 11 Feb 2012 10:50:41 +0800 Subject: Code review request: CR 7144781, jsse/doc, incorrect URLs in JSSE java doc Message-ID: <4F35D781.9060909@Oracle.COM> webrev: http://cr.openjdk.java.net/~xuelei/7144781/webrev.00/ In javax.net.ssl java doc, the URL for the "Java Cryptography Architecture API Specification & Reference" should be: http://docs.oracle.com/javase/7/docs/technotes/guides/security/crypto/CryptoSpec.html, but not http://docs.oracle.com/javase/7/docs/api/technotes/guides/security/crypto/CryptoSpec.html. There is an additional "api" section in the path. Thanks, Xuelei From bradford.wetmore at oracle.com Sat Feb 11 03:11:51 2012 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Fri, 10 Feb 2012 19:11:51 -0800 Subject: Code review request: CR 7144781, jsse/doc, incorrect URLs in JSSE java doc In-Reply-To: <4F35D781.9060909@Oracle.COM> References: <4F35D781.9060909@Oracle.COM> Message-ID: <4F35DC77.8010007@oracle.com> Have you done a full pubs/javadoc target to make sure the path will resolve correctly? The location seems to be ok. Brad On 2/10/2012 6:50 PM, Xuelei Fan wrote: > webrev: http://cr.openjdk.java.net/~xuelei/7144781/webrev.00/ > > In javax.net.ssl java doc, the URL for the "Java Cryptography > Architecture API Specification & Reference" should be: > http://docs.oracle.com/javase/7/docs/technotes/guides/security/crypto/CryptoSpec.html, > but not > http://docs.oracle.com/javase/7/docs/api/technotes/guides/security/crypto/CryptoSpec.html. > > > There is an additional "api" section in the path. > > Thanks, > Xuelei From bradford.wetmore at oracle.com Sat Feb 11 03:13:49 2012 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Sat, 11 Feb 2012 03:13:49 +0000 Subject: hg: jdk8/tl/jdk: 7142509: Cipher.doFinal(ByteBuffer, ByteBuffer) fails to process when in.remaining() == 0 Message-ID: <20120211031422.DFCF347479@hg.openjdk.java.net> Changeset: b16cbeb0d213 Author: wetmore Date: 2012-02-10 19:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b16cbeb0d213 7142509: Cipher.doFinal(ByteBuffer,ByteBuffer) fails to process when in.remaining() == 0 Reviewed-by: valeriep ! src/share/classes/javax/crypto/CipherSpi.java + test/javax/crypto/CipherSpi/DirectBBRemaining.java From Xuelei.Fan at Oracle.COM Sat Feb 11 04:05:21 2012 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Sat, 11 Feb 2012 12:05:21 +0800 Subject: Code review request: CR 7144781, jsse/doc, incorrect URLs in JSSE java doc In-Reply-To: <4F35DC77.8010007@oracle.com> References: <4F35D781.9060909@Oracle.COM> <4F35DC77.8010007@oracle.com> Message-ID: <4F35E901.4080701@Oracle.COM> CC Sowmya. I did not build and verify the "pubs" docs. But from the javadoc of "jdk", the paths refer to the right URLs. Xuelei On 2/11/2012 11:11 AM, Brad Wetmore wrote: > Have you done a full pubs/javadoc target to make sure the path will > resolve correctly? The location seems to be ok. > > Brad > > > > On 2/10/2012 6:50 PM, Xuelei Fan wrote: >> webrev: http://cr.openjdk.java.net/~xuelei/7144781/webrev.00/ >> >> In javax.net.ssl java doc, the URL for the "Java Cryptography >> Architecture API Specification & Reference" should be: >> http://docs.oracle.com/javase/7/docs/technotes/guides/security/crypto/CryptoSpec.html, >> >> but not >> http://docs.oracle.com/javase/7/docs/api/technotes/guides/security/crypto/CryptoSpec.html. >> >> >> >> There is an additional "api" section in the path. >> >> Thanks, >> Xuelei From Xuelei.Fan at Oracle.COM Sat Feb 11 04:12:54 2012 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Sat, 11 Feb 2012 12:12:54 +0800 Subject: Code review request: CR 7144781, jsse/doc, incorrect URLs in JSSE java doc In-Reply-To: <4F35E901.4080701@Oracle.COM> References: <4F35D781.9060909@Oracle.COM> <4F35DC77.8010007@oracle.com> <4F35E901.4080701@Oracle.COM> Message-ID: <4F35EAC6.2090500@Oracle.COM> The paths/URLs work when I integrated the "pubs" docs with javadoc of "JDK". Thanks, Xuelei On 2/11/2012 12:05 PM, Xuelei Fan wrote: > CC Sowmya. > > I did not build and verify the "pubs" docs. But from the javadoc of > "jdk", the paths refer to the right URLs. > > Xuelei > > On 2/11/2012 11:11 AM, Brad Wetmore wrote: >> Have you done a full pubs/javadoc target to make sure the path will >> resolve correctly? The location seems to be ok. >> >> Brad >> >> >> >> On 2/10/2012 6:50 PM, Xuelei Fan wrote: >>> webrev: http://cr.openjdk.java.net/~xuelei/7144781/webrev.00/ >>> >>> In javax.net.ssl java doc, the URL for the "Java Cryptography >>> Architecture API Specification & Reference" should be: >>> http://docs.oracle.com/javase/7/docs/technotes/guides/security/crypto/CryptoSpec.html, >>> >>> >>> but not >>> http://docs.oracle.com/javase/7/docs/api/technotes/guides/security/crypto/CryptoSpec.html. >>> >>> >>> >>> >>> There is an additional "api" section in the path. >>> >>> Thanks, >>> Xuelei > From xuelei.fan at oracle.com Sat Feb 11 06:19:33 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Sat, 11 Feb 2012 06:19:33 +0000 Subject: hg: jdk8/tl/jdk: 7144781: incorrect URLs in JSSE java doc Message-ID: <20120211061952.1900B4747D@hg.openjdk.java.net> Changeset: da8b8ee281f9 Author: xuelei Date: 2012-02-10 22:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da8b8ee281f9 7144781: incorrect URLs in JSSE java doc Reviewed-by: wetmore, skannan ! src/share/classes/javax/net/ssl/ExtendedSSLSession.java ! src/share/classes/javax/net/ssl/SSLParameters.java From chris.hegarty at oracle.com Sun Feb 12 08:49:04 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Sun, 12 Feb 2012 08:49:04 +0000 Subject: hg: jdk8/tl/jdk: 7133367: ResponseCache.put should not be called when setUseCaches(false) Message-ID: <20120212084914.C214A4748E@hg.openjdk.java.net> Changeset: 27a6b299ed6a Author: chegar Date: 2012-02-12 08:47 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27a6b299ed6a 7133367: ResponseCache.put should not be called when setUseCaches(false) Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/protocol/http/NoCache.java From alan.bateman at oracle.com Sun Feb 12 21:11:23 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 12 Feb 2012 21:11:23 +0000 Subject: hg: jdk8/tl/jdk: 7144895: ProblemList.txt updates (2/2012) Message-ID: <20120212211144.D5B8447493@hg.openjdk.java.net> Changeset: 27e746e6f3fe Author: alanb Date: 2012-02-12 21:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27e746e6f3fe 7144895: ProblemList.txt updates (2/2012) Reviewed-by: darcy, ohair ! test/Makefile ! test/ProblemList.txt ! test/TEST.ROOT From mstjohns at comcast.net Sun Feb 12 21:47:22 2012 From: mstjohns at comcast.net (Michael StJohns) Date: Sun, 12 Feb 2012 16:47:22 -0500 Subject: Possible changes to javax.smartcardio Message-ID: <20120212214728.49F8167A2@mail.openjdk.java.net> Hi - I've been looking javax.smartcardio with an eye to making two changes - one that can be handled completely within the sun.security.smartcard.SunPCSC provider, and one that will need an API change. The first is adding support in the provider for the plug and play pseudo-terminal. Basically, I've seen a number of tokens that look like both smart cards and terminals - using the current code, I have to loop looking for a change in the set of connected terminals, rather than just waiting on CardTerminals.waitForChange(). The second is adding ".cancel()" methods to both CardTerminals and CardTerminal to cause any wait's to terminate cleanly. For PCSC, this would be calling SCardCancel and returning InteruptedException if the error code from the native SCardGetStatusChange is SCARD_E_CANCELLED. The reason for this one is to allow user input in another thread cause the smart card waiting to return cleanly. The former I implemented and tested a while back, but didn't submit the changes. The functionality is enabled by calling TerminalFactory.getInstance() with a Properties object consisting of a trackterminals=yes mapping. The latter looks pretty simple to implement, but is an API change to javax.smartcardio - albeit a backwards compatible one. The body of the cancel method isn't much more than the call to PCSC.ScardCancel (which will be needed to be added to the native code). Is this a useful change? And what's the best way to get this in? The process in http://openjdk.java.net/contribute/ doesn't actually seem to reflect reality as a previous patch I submitted using that process (https://bugs.openjdk.java.net/show_bug.cgi?id=100048) didn't seem to result in the desired change. Eventually, it was implemented, but not using this patch. Thanks - Mike From jonathan.gibbons at oracle.com Mon Feb 13 00:44:48 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 13 Feb 2012 00:44:48 +0000 Subject: hg: jdk8/tl/langtools: 7144979: incorrect path separator in make/build.xml for Windows when running jtreg tests Message-ID: <20120213004453.0CCFF47494@hg.openjdk.java.net> Changeset: cd5ca700da4c Author: jjg Date: 2012-02-12 16:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cd5ca700da4c 7144979: incorrect path separator in make/build.xml for Windows when running jtreg tests Reviewed-by: jjg Contributed-by: jan.valenta at oracle.com ! make/build.xml From stuart.marks at oracle.com Mon Feb 13 05:55:05 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Mon, 13 Feb 2012 05:55:05 +0000 Subject: hg: jdk8/tl/jdk: 7143230: fix warnings in java.util.jar, sun.tools.jar, zipfs demo, etc. Message-ID: <20120213055527.1501647499@hg.openjdk.java.net> Changeset: 445ada5e6b4a Author: smarks Date: 2012-02-12 21:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/445ada5e6b4a 7143230: fix warnings in java.util.jar, sun.tools.jar, zipfs demo, etc. Reviewed-by: alanb, chegar, lancea, smarks Contributed-by: Mani Sarkar , Michael Barker , Carl Jokl , Dinuk Weerasinghe , Markus Stoy , Tom Anderson ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/jar/JarVerifier.java ! src/share/classes/sun/tools/jar/CommandLine.java ! src/share/classes/sun/tools/jar/Manifest.java ! src/share/classes/sun/tools/jar/SignatureFile.java ! src/share/demo/management/MemoryMonitor/MemoryMonitor.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileStore.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystemProvider.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipInfo.java From vincent.x.ryan at oracle.com Mon Feb 13 14:32:27 2012 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Mon, 13 Feb 2012 14:32:27 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20120213143305.349E3474A4@hg.openjdk.java.net> Changeset: 3554f175341a Author: vinnie Date: 2012-02-13 14:26 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3554f175341a 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done Reviewed-by: xuelei, wetmore ! src/share/classes/sun/security/pkcs/PKCS7.java Changeset: 59bd472746d6 Author: vinnie Date: 2012-02-13 14:31 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59bd472746d6 Merge - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java From vincent.x.ryan at oracle.com Mon Feb 13 16:47:12 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Mon, 13 Feb 2012 16:47:12 +0000 Subject: Code review request: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc Message-ID: <4F393E90.5080709@oracle.com> Please review the following change: http://cr.openjdk.java.net/~vinnie/7142888/webrev.00/ for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142888 Some implementations of the SHA512withECDSA signing algorithm require that the signing/validation key is at least 512 bits. Thanks. From Xuelei.Fan at Oracle.Com Mon Feb 13 17:04:19 2012 From: Xuelei.Fan at Oracle.Com (Xuelei Fan) Date: Tue, 14 Feb 2012 01:04:19 +0800 Subject: Code review request: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc In-Reply-To: <4F393E90.5080709@oracle.com> References: <4F393E90.5080709@oracle.com> Message-ID: On Feb 14, 2012, at 12:47 AM, Vincent Ryan wrote: > Please review the following change: > http://cr.openjdk.java.net/~vinnie/7142888/webrev.00/ > > for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142888 > > Some implementations of the SHA512withECDSA signing algorithm require > that the signing/validation key is at least 512 bits. > If I am correct, RSA algorithms have such limitation, but for EC algorithms, there is no such require. Is it a intend design, or a bug of the implementation? Xuelei > Thanks. From vincent.x.ryan at oracle.com Mon Feb 13 17:24:08 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Mon, 13 Feb 2012 17:24:08 +0000 Subject: Code review request: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc In-Reply-To: References: <4F393E90.5080709@oracle.com> Message-ID: <4F394738.8030703@oracle.com> On 02/13/12 05:04 PM, Xuelei Fan wrote: > On Feb 14, 2012, at 12:47 AM, Vincent Ryan wrote: > >> Please review the following change: >> http://cr.openjdk.java.net/~vinnie/7142888/webrev.00/ >> >> for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142888 >> >> Some implementations of the SHA512withECDSA signing algorithm require >> that the signing/validation key is at least 512 bits. >> > If I am correct, RSA algorithms have such limitation, but for EC algorithms, there is no such require. Is it a intend design, or a bug of the implementation? > It's not a bug. I believe it is a FIPS recommendation. > Xuelei > >> Thanks. From mstjohns at comcast.net Mon Feb 13 17:40:34 2012 From: mstjohns at comcast.net (Michael StJohns) Date: Mon, 13 Feb 2012 12:40:34 -0500 Subject: Code review request: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc In-Reply-To: <4F394738.8030703@oracle.com> References: <4F393E90.5080709@oracle.com> <4F394738.8030703@oracle.com> Message-ID: <20120213174038.E7CC16966@mail.openjdk.java.net> At 12:24 PM 2/13/2012, Vincent Ryan wrote: >On 02/13/12 05:04 PM, Xuelei Fan wrote: >> On Feb 14, 2012, at 12:47 AM, Vincent Ryan wrote: >> >>> Please review the following change: >>> http://cr.openjdk.java.net/~vinnie/7142888/webrev.00/ >>> >>> for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142888 >>> >>> Some implementations of the SHA512withECDSA signing algorithm require >>> that the signing/validation key is at least 512 bits. >>> >> If I am correct, RSA algorithms have such limitation, but for EC algorithms, there is no such require. Is it a intend design, or a bug of the implementation? >> > >It's not a bug. I believe it is a FIPS recommendation. Well sort of - FIPS 186-3 *requires* the HASH function to meet or exceed the security strength of the key. It *recommends* they be the same (e.g. use SHA256 for NIST P-256). But the controlling document is actually ANSI X9.62 which says if your hash is longer than your key then trim the hash to the key length before performing the public key operations. >d) Use the selected hash function (see 7.2) to compute H = Hash (M), a bit string of length hashlen bits. >e) Derive an integer e from H as follows: >1) If .floor(log2n) >= hashlen, set E = H. Otherwise, set E equal to the leftmost .floor(log2n). bits of H. 'n' is the prime order of the curve generator G. So I'd actually say - bug. >> Xuelei >> >>> Thanks. -------------- next part -------------- An HTML attachment was scrubbed... URL: From vincent.x.ryan at oracle.com Mon Feb 13 18:49:26 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Mon, 13 Feb 2012 18:49:26 +0000 Subject: Code review request: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc In-Reply-To: <201202131740.q1DHedQ8012503@rcsinet11.oracle.com> References: <4F393E90.5080709@oracle.com> <4F394738.8030703@oracle.com> <201202131740.q1DHedQ8012503@rcsinet11.oracle.com> Message-ID: <4F395B36.2020102@oracle.com> Hello Michael, Thanks for providing those details. This specific fix is a workaround for a test failure using SunPKCS11-Solaris provider on Sparc. I'll file a separate bug to correct the issue of matching hash length to key length. On 02/13/12 05:40 PM, Michael StJohns wrote: > At 12:24 PM 2/13/2012, Vincent Ryan wrote: >> On 02/13/12 05:04 PM, Xuelei Fan wrote: >> > On Feb 14, 2012, at 12:47 AM, Vincent Ryan wrote: >> > >> >> Please review the following change: >> >> http://cr.openjdk.java.net/~vinnie/7142888/webrev.00/ >> >> >> >> for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142888 >> >> >> >> Some implementations of the SHA512withECDSA signing algorithm require >> >> that the signing/validation key is at least 512 bits. >> >> >> > If I am correct, RSA algorithms have such limitation, but for EC algorithms, >> there is no such require. Is it a intend design, or a bug of the implementation? >> > >> >> It's not a bug. I believe it is a FIPS recommendation. > > Well sort of - FIPS 186-3 *requires* the HASH function to meet or exceed the > security strength of the key. It *recommends* they be the same (e.g. use SHA256 > for NIST P-256). But the controlling document is actually ANSI X9.62 which says > if your hash is longer than your key then trim the hash to the key length before > performing the public key operations. > >> d) Use the selected hash function (see 7.2) to compute /H = Hash /(/M/), a bit >> string of length /hashlen /bits. >> e) Derive an integer /e /from /H /as follows: >> 1) If .floor(log2/n/) >= /hashlen/, set /E /= /H/. Otherwise, set /E /equal to >> the leftmost .floor(log2/n)/. bits of /H/. > > 'n' is the prime order of the curve generator G. > > > > So I'd actually say - bug. > > > >> > Xuelei >> > >> >> Thanks. > From sean.mullan at oracle.com Mon Feb 13 20:27:21 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 13 Feb 2012 15:27:21 -0500 Subject: Code Review Request: 7024604 OID.1 causes IAE in X500Principal constructor Message-ID: <4F397229.7000709@oracle.com> Hi Vinnie, Could you please review my fix for 7024604? http://cr.openjdk.java.net/~mullan/webrevs/7024604/webrev.00/ A CCC has been approved and I will post the final revision after you have reviewed the code. Thanks, Sean From valerie.peng at oracle.com Mon Feb 13 20:35:48 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Mon, 13 Feb 2012 12:35:48 -0800 Subject: Code review request In-Reply-To: <4F34BC76.1010507@oracle.com> References: <4F34BC76.1010507@oracle.com> Message-ID: <4F397424.7030002@oracle.com> Looks good to me. Thanks, Valerie On 02/09/12 22:43, Brad Wetmore wrote: > > Two line code fix, but an important couple of lines. :) > > The underlying cipher still had buffered data when using Direct > ByteBuffers. This changes makes sure that data is read out. > > 7142509: Cipher.doFinal(ByteBuffer,ByteBuffer) fails to process > when in.remaining() == 0 > > Description: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142509 > > Codereview: > http://cr.openjdk.java.net/~wetmore/7142509/ > > Thanks, > > Brad > From jim.holmlund at sun.com Tue Feb 14 00:02:52 2012 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Tue, 14 Feb 2012 00:02:52 +0000 Subject: hg: jdk8/tl/langtools: 7142672: Problems with the value passed to the 'classes' param of JavaCompiler.CompilationTask.getTask(...) Message-ID: <20120214000256.8A6B1474B4@hg.openjdk.java.net> Changeset: 237198ef45f5 Author: jjh Date: 2012-02-13 16:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/237198ef45f5 7142672: Problems with the value passed to the 'classes' param of JavaCompiler.CompilationTask.getTask(...) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/T7142672/AnnoProcessor.java + test/tools/javac/T7142672/Bug.java + test/tools/javac/T7142672/Test2.java + test/tools/javac/T7142672/Test3.java From Xuelei.Fan at Oracle.COM Tue Feb 14 02:18:59 2012 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Tue, 14 Feb 2012 10:18:59 +0800 Subject: Code review request: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc In-Reply-To: <4F395B36.2020102@oracle.com> References: <4F393E90.5080709@oracle.com> <4F394738.8030703@oracle.com> <201202131740.q1DHedQ8012503@rcsinet11.oracle.com> <4F395B36.2020102@oracle.com> Message-ID: <4F39C493.40800@Oracle.COM> The fix looks fine to me. Xuelei On 2/14/2012 2:49 AM, Vincent Ryan wrote: > Hello Michael, > > Thanks for providing those details. > > This specific fix is a workaround for a test failure using SunPKCS11-Solaris > provider on Sparc. I'll file a separate bug to correct the issue of matching > hash length to key length. > > > > On 02/13/12 05:40 PM, Michael StJohns wrote: >> At 12:24 PM 2/13/2012, Vincent Ryan wrote: >>> On 02/13/12 05:04 PM, Xuelei Fan wrote: >>>> On Feb 14, 2012, at 12:47 AM, Vincent Ryan wrote: >>>> >>>>> Please review the following change: >>>>> http://cr.openjdk.java.net/~vinnie/7142888/webrev.00/ >>>>> >>>>> for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142888 >>>>> >>>>> Some implementations of the SHA512withECDSA signing algorithm require >>>>> that the signing/validation key is at least 512 bits. >>>>> >>>> If I am correct, RSA algorithms have such limitation, but for EC algorithms, >>> there is no such require. Is it a intend design, or a bug of the implementation? >>>> >>> >>> It's not a bug. I believe it is a FIPS recommendation. >> >> Well sort of - FIPS 186-3 *requires* the HASH function to meet or exceed the >> security strength of the key. It *recommends* they be the same (e.g. use SHA256 >> for NIST P-256). But the controlling document is actually ANSI X9.62 which says >> if your hash is longer than your key then trim the hash to the key length before >> performing the public key operations. >> >>> d) Use the selected hash function (see 7.2) to compute /H = Hash /(/M/), a bit >>> string of length /hashlen /bits. >>> e) Derive an integer /e /from /H /as follows: >>> 1) If .floor(log2/n/)>= /hashlen/, set /E /= /H/. Otherwise, set /E /equal to >>> the leftmost .floor(log2/n)/. bits of /H/. >> >> 'n' is the prime order of the curve generator G. >> >> >> >> So I'd actually say - bug. >> >> >> >>>> Xuelei >>>> >>>>> Thanks. >> > From vincent.x.ryan at oracle.com Tue Feb 14 11:48:04 2012 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Tue, 14 Feb 2012 11:48:04 +0000 Subject: hg: jdk8/tl/jdk: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc Message-ID: <20120214114829.7A0B1474C0@hg.openjdk.java.net> Changeset: f62077973f9b Author: vinnie Date: 2012-02-14 11:47 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f62077973f9b 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc Reviewed-by: xuelei ! test/sun/security/tools/jarsigner/ec.sh From vincent.x.ryan at oracle.com Tue Feb 14 14:07:48 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 14 Feb 2012 14:07:48 +0000 Subject: Code Review Request: 7024604 OID.1 causes IAE in X500Principal constructor In-Reply-To: <4F397229.7000709@oracle.com> References: <4F397229.7000709@oracle.com> Message-ID: <4F3A6AB4.3000003@oracle.com> Those changes look fine. On 02/13/12 08:27 PM, Sean Mullan wrote: > Hi Vinnie, > > Could you please review my fix for 7024604? > > http://cr.openjdk.java.net/~mullan/webrevs/7024604/webrev.00/ > > A CCC has been approved and I will post the final revision after you have > reviewed the code. > > Thanks, > Sean From maurizio.cimadamore at oracle.com Tue Feb 14 23:54:11 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 14 Feb 2012 23:54:11 +0000 Subject: hg: jdk8/tl/langtools: 7142086: performance problem in Check.checkOverrideClashes(...) Message-ID: <20120214235415.85ADC474DA@hg.openjdk.java.net> Changeset: 84b61130cbed Author: mcimadamore Date: 2012-02-14 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84b61130cbed 7142086: performance problem in Check.checkOverrideClashes(...) Summary: Code in Check.checkOverrideClashes() causes too many calls to MethodSymbol.overrides Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/7142086/T7142086.java From frederic.parain at oracle.com Wed Feb 15 10:20:18 2012 From: frederic.parain at oracle.com (frederic.parain at oracle.com) Date: Wed, 15 Feb 2012 10:20:18 +0000 Subject: hg: jdk8/tl/jdk: 7140868: TEST_BUG: jcmd tests need to use -XX:+UsePerfData Message-ID: <20120215102030.50B12474E7@hg.openjdk.java.net> Changeset: 13aef38438d8 Author: fparain Date: 2012-02-14 07:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13aef38438d8 7140868: TEST_BUG: jcmd tests need to use -XX:+UsePerfData Reviewed-by: fparain, dholmes ! test/sun/tools/jcmd/jcmd-Defaults.sh ! test/sun/tools/jcmd/jcmd-f.sh ! test/sun/tools/jcmd/jcmd-help-help.sh ! test/sun/tools/jcmd/jcmd-help.sh ! test/sun/tools/jcmd/jcmd-pid.sh From sean.mullan at oracle.com Wed Feb 15 13:02:08 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Wed, 15 Feb 2012 13:02:08 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20120215130235.9079D474EA@hg.openjdk.java.net> Changeset: 0720542d6c1e Author: mullan Date: 2012-02-15 07:45 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0720542d6c1e 7024604: OID.1 causes IAE in X500Principal constructor Reviewed-by: vinnie ! src/share/classes/javax/security/auth/x500/X500Principal.java ! src/share/classes/javax/security/auth/x500/package.html ! test/javax/security/auth/x500/X500Principal/Parse.java Changeset: 3207b3e271f2 Author: mullan Date: 2012-02-15 07:52 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3207b3e271f2 Merge From Xuelei.Fan at Oracle.COM Wed Feb 15 14:21:34 2012 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Wed, 15 Feb 2012 22:21:34 +0800 Subject: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom Message-ID: <4F3BBF6E.9090007@Oracle.COM> webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev/ To use only one instance of SecureRandom for dummy/useless CipherBox initialization. Thanks, Xuelei From chris.hegarty at oracle.com Wed Feb 15 15:06:05 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 15 Feb 2012 15:06:05 +0000 Subject: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom In-Reply-To: <4F3BBF6E.9090007@Oracle.COM> References: <4F3BBF6E.9090007@Oracle.COM> Message-ID: <4F3BC9DD.50200@oracle.com> Just out of curiosity, why is secureRandom defined in the outer class rather than privately in BulkCipher?? -Chris. On 15/02/2012 14:21, Xuelei Fan wrote: > webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev/ > > To use only one instance of SecureRandom for dummy/useless CipherBox > initialization. > > Thanks, > Xuelei From Xuelei.Fan at Oracle.COM Wed Feb 15 15:05:30 2012 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Wed, 15 Feb 2012 23:05:30 +0800 Subject: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom In-Reply-To: <4F3BC9DD.50200@oracle.com> References: <4F3BBF6E.9090007@Oracle.COM> <4F3BC9DD.50200@oracle.com> Message-ID: <4F3BC9BA.4050400@Oracle.COM> On 2/15/2012 11:06 PM, Chris Hegarty wrote: > Just out of curiosity, why is secureRandom defined in the outer class > rather than privately in BulkCipher?? > Good point. It should be in BulkCipher. Thanks, Xuelei > -Chris. > > On 15/02/2012 14:21, Xuelei Fan wrote: >> webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev/ >> >> To use only one instance of SecureRandom for dummy/useless CipherBox >> initialization. >> >> Thanks, >> Xuelei From Xuelei.Fan at Oracle.COM Wed Feb 15 15:45:50 2012 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Wed, 15 Feb 2012 23:45:50 +0800 Subject: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom In-Reply-To: <4F3BC9DD.50200@oracle.com> References: <4F3BBF6E.9090007@Oracle.COM> <4F3BC9DD.50200@oracle.com> Message-ID: <4F3BD32E.3090802@Oracle.COM> I believe I have replied the mail. But cannot find the mail in the mail system. It's weird. New webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev.01/. Moved secureRandom into BulkCipher block. Thanks, Xuelei On 2/15/2012 11:06 PM, Chris Hegarty wrote: > Just out of curiosity, why is secureRandom defined in the outer class > rather than privately in BulkCipher?? > > -Chris. > > On 15/02/2012 14:21, Xuelei Fan wrote: >> webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev/ >> >> To use only one instance of SecureRandom for dummy/useless CipherBox >> initialization. >> >> Thanks, >> Xuelei From chris.hegarty at oracle.com Wed Feb 15 16:03:51 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 15 Feb 2012 16:03:51 +0000 Subject: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom In-Reply-To: <4F3BD32E.3090802@Oracle.COM> References: <4F3BBF6E.9090007@Oracle.COM> <4F3BC9DD.50200@oracle.com> <4F3BD32E.3090802@Oracle.COM> Message-ID: <4F3BD767.30206@oracle.com> Looks fine to me, but I'm sure someone closer to the security area may also want to review. -Chris. On 15/02/2012 15:45, Xuelei Fan wrote: > I believe I have replied the mail. But cannot find the mail in the mail > system. It's weird. > > New webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev.01/. > > Moved secureRandom into BulkCipher block. > > Thanks, > Xuelei > > > On 2/15/2012 11:06 PM, Chris Hegarty wrote: >> Just out of curiosity, why is secureRandom defined in the outer class >> rather than privately in BulkCipher?? >> >> -Chris. >> >> On 15/02/2012 14:21, Xuelei Fan wrote: >>> webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev/ >>> >>> To use only one instance of SecureRandom for dummy/useless CipherBox >>> initialization. >>> >>> Thanks, >>> Xuelei From frederic.parain at oracle.com Wed Feb 15 17:29:42 2012 From: frederic.parain at oracle.com (frederic.parain at oracle.com) Date: Wed, 15 Feb 2012 17:29:42 +0000 Subject: hg: jdk8/tl/jdk: 7144833: sun/tools/jcmd/jcmd-Defaults.sh failing intermittently Message-ID: <20120215173008.2669A474F4@hg.openjdk.java.net> Changeset: 59884f656b7d Author: fparain Date: 2012-02-15 09:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59884f656b7d 7144833: sun/tools/jcmd/jcmd-Defaults.sh failing intermittently Reviewed-by: alanb ! test/ProblemList.txt ! test/sun/tools/jcmd/jcmd_Output1.awk From alan.bateman at oracle.com Wed Feb 15 17:33:14 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 15 Feb 2012 17:33:14 +0000 Subject: hg: jdk8/tl/jaxws: 7145910: Remove dependency on apt and com.sun.mirror API (breaks boot cycle builds) Message-ID: <20120215173314.75D1F474F5@hg.openjdk.java.net> Changeset: b962e9c3eba2 Author: alanb Date: 2012-02-15 17:32 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b962e9c3eba2 7145910: Remove dependency on apt and com.sun.mirror API (breaks boot cycle builds) Reviewed-by: ohair ! jaxws.properties From frederic.parain at oracle.com Wed Feb 15 18:47:40 2012 From: frederic.parain at oracle.com (frederic.parain at oracle.com) Date: Wed, 15 Feb 2012 18:47:40 +0000 Subject: hg: jdk8/tl/jdk: 7145925: Removing remote access to diagnostic commands in the HotSpotDiagnosticMBean Message-ID: <20120215184750.89476474F9@hg.openjdk.java.net> Changeset: 20d39a0e6fdc Author: fparain Date: 2012-02-15 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/20d39a0e6fdc 7145925: Removing remote access to diagnostic commands in the HotSpotDiagnosticMBean Reviewed-by: acorn, mchung, phh ! make/java/management/mapfile-vers - src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java - src/share/classes/com/sun/management/DiagnosticCommandInfo.java ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/sun/management/HotSpotDiagnostic.java ! src/share/native/sun/management/HotSpotDiagnostic.c - test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java From bradford.wetmore at oracle.com Wed Feb 15 23:28:43 2012 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Wed, 15 Feb 2012 15:28:43 -0800 Subject: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom In-Reply-To: <4F3BD767.30206@oracle.com> References: <4F3BBF6E.9090007@Oracle.COM> <4F3BC9DD.50200@oracle.com> <4F3BD32E.3090802@Oracle.COM> <4F3BD767.30206@oracle.com> Message-ID: <4F3C3FAB.5050900@oracle.com> Looks ok to me too, but it seems a shame to keep this SecureRandom instance for a single test (AES_256) during cipher initialization. Once the condition is test, and the result is added to the cache, the SecureRandom instance is never used again. Brad On 2/15/2012 8:03 AM, Chris Hegarty wrote: > Looks fine to me, but I'm sure someone closer to the security area may > also want to review. > > -Chris. > > On 15/02/2012 15:45, Xuelei Fan wrote: >> I believe I have replied the mail. But cannot find the mail in the mail >> system. It's weird. >> >> New webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev.01/. >> >> Moved secureRandom into BulkCipher block. >> >> Thanks, >> Xuelei >> >> >> On 2/15/2012 11:06 PM, Chris Hegarty wrote: >>> Just out of curiosity, why is secureRandom defined in the outer class >>> rather than privately in BulkCipher?? >>> >>> -Chris. >>> >>> On 15/02/2012 14:21, Xuelei Fan wrote: >>>> webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev/ >>>> >>>> To use only one instance of SecureRandom for dummy/useless CipherBox >>>> initialization. >>>> >>>> Thanks, >>>> Xuelei From Xuelei.Fan at Oracle.Com Thu Feb 16 00:15:23 2012 From: Xuelei.Fan at Oracle.Com (Xuelei Fan) Date: Thu, 16 Feb 2012 08:15:23 +0800 Subject: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom In-Reply-To: <4F3C3FAB.5050900@oracle.com> References: <4F3BBF6E.9090007@Oracle.COM> <4F3BC9DD.50200@oracle.com> <4F3BD32E.3090802@Oracle.COM> <4F3BD767.30206@oracle.com> <4F3C3FAB.5050900@oracle.com> Message-ID: Thanks for the review. On Feb 16, 2012, at 7:28 AM, Brad Wetmore wrote: > Looks ok to me too, but it seems a shame to keep this SecureRandom instance for a single test (AES_256) during cipher initialization. Once the condition is test, and the result is added to the cache, the SecureRandom instance is never used again. > I think why we wanted to check the condition every time is that the cache may be cleaned, and the security provider may be dynamically changed during JVM. As the new generated cipherBox is never used, so we don't care about its secure random generator. And the real secureRandom in the SSLContext will be used in the following operations. Thanks, Xuelei > Brad > > > > On 2/15/2012 8:03 AM, Chris Hegarty wrote: >> Looks fine to me, but I'm sure someone closer to the security area may >> also want to review. >> >> -Chris. >> >> On 15/02/2012 15:45, Xuelei Fan wrote: >>> I believe I have replied the mail. But cannot find the mail in the mail >>> system. It's weird. >>> >>> New webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev.01/. >>> >>> Moved secureRandom into BulkCipher block. >>> >>> Thanks, >>> Xuelei >>> >>> >>> On 2/15/2012 11:06 PM, Chris Hegarty wrote: >>>> Just out of curiosity, why is secureRandom defined in the outer class >>>> rather than privately in BulkCipher?? >>>> >>>> -Chris. >>>> >>>> On 15/02/2012 14:21, Xuelei Fan wrote: >>>>> webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev/ >>>>> >>>>> To use only one instance of SecureRandom for dummy/useless CipherBox >>>>> initialization. >>>>> >>>>> Thanks, >>>>> Xuelei From xuelei.fan at oracle.com Thu Feb 16 07:55:16 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 16 Feb 2012 07:55:16 +0000 Subject: hg: jdk8/tl/jdk: 7145837: a little performance improvement on the usage of SecureRandom Message-ID: <20120216075542.114C147516@hg.openjdk.java.net> Changeset: 45804d661008 Author: xuelei Date: 2012-02-15 23:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45804d661008 7145837: a little performance improvement on the usage of SecureRandom Reviewed-by: chegar, wetmore ! src/share/classes/sun/security/ssl/CipherSuite.java From xueming.shen at oracle.com Thu Feb 16 19:38:48 2012 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 16 Feb 2012 19:38:48 +0000 Subject: hg: jdk8/tl/jdk: 6708398: Support integer overflow Message-ID: <20120216193906.57FC347522@hg.openjdk.java.net> Changeset: b971b51bec01 Author: sherman Date: 2012-02-16 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b971b51bec01 6708398: Support integer overflow Summary: Added add/sub/multiply/toIntExact methods to j.l.Math and StrictMath classes Reviewed-by: emcmanus Contributed-by: roger.riggs at oracle.com ! src/share/classes/java/lang/Math.java ! src/share/classes/java/lang/StrictMath.java + test/java/lang/Math/ExactArithTests.java + test/java/lang/StrictMath/ExactArithTests.java From xueming.shen at oracle.com Fri Feb 17 06:08:11 2012 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 17 Feb 2012 06:08:11 +0000 Subject: hg: jdk8/tl/jdk: 4153167: separate between ANSI and OEM code pages on Windows Message-ID: <20120217060835.1958E4755D@hg.openjdk.java.net> Changeset: d38fed7d2ea7 Author: sherman Date: 2012-02-16 22:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d38fed7d2ea7 4153167: separate between ANSI and OEM code pages on Windows Summary: To use OEM code page for System.out&err when not redirected Reviewed-by: alanb ! src/share/classes/java/lang/System.java ! src/share/native/java/lang/System.c ! src/share/native/java/lang/java_props.h ! src/windows/native/java/lang/java_props_md.c From alan.bateman at oracle.com Sun Feb 19 16:56:53 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 19 Feb 2012 16:56:53 +0000 Subject: hg: jdk8/tl/jdk: 7146152: File.path should be final Message-ID: <20120219165725.8D0CE4758B@hg.openjdk.java.net> Changeset: 24c298ef20a8 Author: forax Date: 2012-02-19 16:51 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/24c298ef20a8 7146152: File.path should be final Reviewed-by: alanb, dholmes, mduigou ! src/share/classes/java/io/File.java From weijun.wang at oracle.com Mon Feb 20 04:37:01 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 20 Feb 2012 12:37:01 +0800 Subject: code review request: 7144530: KeyTab.getInstance(String) no longer handles keyTabNames with "file:" prefix In-Reply-To: <5743251.1329213664655.JavaMail.sbladm@swsblss4-new.central.sun.com> References: <5743251.1329213664655.JavaMail.sbladm@swsblss4-new.central.sun.com> Message-ID: <4F41CDED.3020307@oracle.com> Hi Valerie Please take a review on this fix: http://cr.openjdk.java.net/~weijun/7144530/webrev.00/ I plan to backport it to jdk7u6 once the dev workspace is re-opened. Thanks Max On 02/14/2012 06:01 PM, weijun.wang at oracle.com wrote: > > *Change Request ID*: 7144530 > > *Synopsis*: KeyTab.getInstance(String) no longer handles keyTabNames with "file:" prefix > > > === *Description* ============================================================ > FULL PRODUCT VERSION : > java version "1.7.0_02" > Java(TM) SE Runtime Environment (build 1.7.0_02-b13) > Java HotSpot(TM) 64-Bit Server VM (build 22.0-b10, mixed mode) > > ADDITIONAL OS VERSION INFORMATION : > Microsoft Windows [Version 6.1.7600] > > A DESCRIPTION OF THE PROBLEM : > Under JDK6, sun.security.krb5.internal.ktab.KeyTab.getInstance() used to remove prefixes like "file:" from the keyTabName. > > Using JDK7 this is no longer the case. Passing a File URI like "file:/..." now results in an empty KeyTab. What happens, is a FileNotFoundException is thrown when reading from the FileInputStream in the constructor. The exception is caught in the constructor and the "isMissing" flag is set to true. > > However, when the default_keytab_name property is resolved in getDefaultTabName(), prefixes like "file:" *are* removed (by calling the parse method). > > STEPS TO FOLLOW TO REPRODUCE THE PROBLEM : > 1. Construct a dummy keytab file using ktab.exe. > ktab.exe -a host/user at DOMAIN password -k dummy.keytab > > 2. Construct a KeyTab using a File URI. > KeyTab keyTab = KeyTab.getInstance("file:/C:/workspace/dummy.keytab"); > > 3. Retrieve the entries from the KeyTab. > keyTab.getEntries() > > EXPECTED VERSUS ACTUAL BEHAVIOR : > EXPECTED - > keyTab.getEntries() should contain the entries of the keytab. > ACTUAL - > keyTab.getEntries() is always empty, i.e. keyTab.getEntries().length is always zero. > > However, when using with the absolute path to the same file, i.e. KeyTab.getInstance("C:/workspace/dummy.keytab"), it will correctly read its entries. > > REPRODUCIBILITY : > This bug can be reproduced always. > > ---------- BEGIN SOURCE ---------- > import static org.junit.Assert.assertTrue; > > import org.junit.Test; > > import sun.security.krb5.internal.ktab.KeyTab; > > public class KeyTabPrefixBug { > > private static final String PATH_TO_KEY_TAB = "C:/workspace/dummy.keytab"; > > @Test > public void withUriPrefix() throws Exception { > KeyTab keyTab = KeyTab.getInstance("file:/" + PATH_TO_KEY_TAB); > assertTrue(keyTab.getEntries().length> 0); // fails > } > > @Test > public void withoutUriPrefix() throws Exception { > KeyTab keyTab = KeyTab.getInstance(PATH_TO_KEY_TAB); > assertTrue(keyTab.getEntries().length> 0); // succeeds > } > } > ---------- END SOURCE ---------- > > CUSTOMER SUBMITTED WORKAROUND : > Always use file paths (never URIs) when using the Kerberos API. From weijun.wang at oracle.com Mon Feb 20 08:35:23 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 20 Feb 2012 16:35:23 +0800 Subject: Certificate validity check (was 7144564: jarsigner should report timestamp failure as a warning) In-Reply-To: <13797435.1329214258285.JavaMail.sbladm@swsblss4-new.central.sun.com> References: <13797435.1329214258285.JavaMail.sbladm@swsblss4-new.central.sun.com> Message-ID: <4F4205CB.8090307@oracle.com> Hi All I'm looking at this bug report. The jar is recently signed on 2/9/12 but the cert expired long time ago on 10/14/03, and jarsigner -verify shows [CertPath not validated: timestamp check failed] This failure message is totally correct. However, because the test was about timestamping, the bug reporter mistakenly believe the error is about the timestamping authority (TSA), instead of the notAfter and/or notBefore attributes of the signer. The words above is from the verifyTimestamp() method from lines 176 of sun/security/provider/certpath/BasicChecker.java. Is it possible to change the message to something like "validity check failed"? If anyone in the PKI/CertPath team thinks this makes sense, please take the bug and make some change. Otherwise, I will close it as NOT-A-BUG. Thanks Max -------- Original Message -------- *Change Request ID*: 7144564 *Synopsis*: jarsigner should report timestamp failure as a warning === *Description* ============================================================ jarsigner -verify on a jar, signed with a expired certificate, with a timestamp, shows "[CertPath not validated: timestamp check failed]" But this is not reported as a warning. This should also be reported. -bash-3.00$ $JDK8_HOME/bin/jarsigner -keystore srikar.p12.data -storepass password -storetype pkcs12 -verify -verify -verbose -certs SignedWithTimeStamp.jar s k 161 Thu Feb 09 13:59:26 PST 2012 META-INF/MANIFEST.MF [entry was signed on 2/9/12 1:59 PM] X.509, CN=SRIKAR, O=SMI, OU=BGR, ST=KAR, C=IN, UID=srikar, EMAILADDRESS=srikar.sagi at sun.com (srikarcert) [certificate expired on 10/14/03 7:10 AM] [CertPath not validated: timestamp check failed] 323 Thu Feb 09 13:59:26 PST 2012 META-INF/SRIKARCE.SF 2786 Thu Feb 09 13:59:26 PST 2012 META-INF/SRIKARCE.RSA 0 Thu Feb 09 13:59:24 PST 2012 META-INF/ smk 4448 Thu Feb 09 13:59:12 PST 2012 CheckJarEntries.class [entry was signed on 2/9/12 1:59 PM] X.509, CN=SRIKAR, O=SMI, OU=BGR, ST=KAR, C=IN, UID=srikar, EMAILADDRESS=srikar.sagi at sun.com (srikarcert) [certificate expired on 10/14/03 7:10 AM] [CertPath not validated: timestamp check failed] s = signature was verified m = entry is listed in manifest k = at least one certificate was found in keystore i = at least one certificate was found in identity scope jar verified. Warning: This jar contains entries whose signer certificate has expired. This jar contains entries whose certificate chain is not validated. From sean.mullan at oracle.com Mon Feb 20 15:07:55 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 20 Feb 2012 10:07:55 -0500 Subject: Certificate validity check (was 7144564: jarsigner should report timestamp failure as a warning) In-Reply-To: <4F4205CB.8090307@oracle.com> References: <13797435.1329214258285.JavaMail.sbladm@swsblss4-new.central.sun.com> <4F4205CB.8090307@oracle.com> Message-ID: <4F4261CB.1030806@oracle.com> I could see how that exception message could be confused with a timestamp applied to the signed jar. I'd probably suggest changing the exception message to: "certificate expired" or "certificate not yet valid" depending on how the check failed. I suggest lowering the priority, leaving the bug open to make this change, and leave it unassigned for now. --Sean On 02/20/2012 03:35 AM, Weijun Wang wrote: > Hi All > > I'm looking at this bug report. The jar is recently signed on 2/9/12 but > the cert expired long time ago on 10/14/03, and jarsigner -verify shows > > [CertPath not validated: timestamp check failed] > > This failure message is totally correct. However, because the test was > about timestamping, the bug reporter mistakenly believe the error is > about the timestamping authority (TSA), instead of the notAfter and/or > notBefore attributes of the signer. > > The words above is from the verifyTimestamp() method from lines 176 of > sun/security/provider/certpath/BasicChecker.java. Is it possible to > change the message to something like "validity check failed"? > > If anyone in the PKI/CertPath team thinks this makes sense, please take > the bug and make some change. Otherwise, I will close it as NOT-A-BUG. > > Thanks > Max > > -------- Original Message -------- > > *Change Request ID*: 7144564 > *Synopsis*: jarsigner should report timestamp failure as a warning > > > === *Description* > ============================================================ > jarsigner -verify on a jar, signed with a expired certificate, with a > timestamp, > shows "[CertPath not validated: timestamp check failed]" > But this is not reported as a warning. > This should also be reported. > > > -bash-3.00$ $JDK8_HOME/bin/jarsigner -keystore srikar.p12.data > -storepass password -storetype pkcs12 -verify -verify -verbose -certs > SignedWithTimeStamp.jar > > s k 161 Thu Feb 09 13:59:26 PST 2012 META-INF/MANIFEST.MF > > [entry was signed on 2/9/12 1:59 PM] > X.509, CN=SRIKAR, O=SMI, OU=BGR, ST=KAR, C=IN, UID=srikar, > EMAILADDRESS=srikar.sagi at sun.com (srikarcert) > [certificate expired on 10/14/03 7:10 AM] > [CertPath not validated: timestamp check failed] > > 323 Thu Feb 09 13:59:26 PST 2012 META-INF/SRIKARCE.SF > 2786 Thu Feb 09 13:59:26 PST 2012 META-INF/SRIKARCE.RSA > 0 Thu Feb 09 13:59:24 PST 2012 META-INF/ > smk 4448 Thu Feb 09 13:59:12 PST 2012 CheckJarEntries.class > > [entry was signed on 2/9/12 1:59 PM] > X.509, CN=SRIKAR, O=SMI, OU=BGR, ST=KAR, C=IN, UID=srikar, > EMAILADDRESS=srikar.sagi at sun.com (srikarcert) > [certificate expired on 10/14/03 7:10 AM] > [CertPath not validated: timestamp check failed] > > > s = signature was verified > m = entry is listed in manifest > k = at least one certificate was found in keystore > i = at least one certificate was found in identity scope > > jar verified. > > Warning: > This jar contains entries whose signer certificate has expired. > This jar contains entries whose certificate chain is not validated. > From weijun.wang at oracle.com Mon Feb 20 15:22:22 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 20 Feb 2012 23:22:22 +0800 Subject: Certificate validity check (was 7144564: jarsigner should report timestamp failure as a warning) In-Reply-To: <4F4261CB.1030806@oracle.com> References: <13797435.1329214258285.JavaMail.sbladm@swsblss4-new.central.sun.com> <4F4205CB.8090307@oracle.com> <4F4261CB.1030806@oracle.com> Message-ID: <4F42652E.3050601@oracle.com> Hi Sean OK, updated the bug status as suggested. In fact, I've just tried jarsigner on a signed jar that was signed some time ago with a cert which was valid at that time but is expired now. Jarsigner still reports some warning like cert expired or certpath validation failed. This is not very friendly. I'll file another bug on it. Thanks Max On 02/20/2012 11:07 PM, Sean Mullan wrote: > I could see how that exception message could be confused with a > timestamp applied to the signed jar. > > I'd probably suggest changing the exception message to: "certificate > expired" or "certificate not yet valid" depending on how the check failed. > > I suggest lowering the priority, leaving the bug open to make this > change, and leave it unassigned for now. > > --Sean > > On 02/20/2012 03:35 AM, Weijun Wang wrote: >> Hi All >> >> I'm looking at this bug report. The jar is recently signed on 2/9/12 but >> the cert expired long time ago on 10/14/03, and jarsigner -verify shows >> >> [CertPath not validated: timestamp check failed] >> >> This failure message is totally correct. However, because the test was >> about timestamping, the bug reporter mistakenly believe the error is >> about the timestamping authority (TSA), instead of the notAfter and/or >> notBefore attributes of the signer. >> >> The words above is from the verifyTimestamp() method from lines 176 of >> sun/security/provider/certpath/BasicChecker.java. Is it possible to >> change the message to something like "validity check failed"? >> >> If anyone in the PKI/CertPath team thinks this makes sense, please take >> the bug and make some change. Otherwise, I will close it as NOT-A-BUG. >> >> Thanks >> Max >> >> -------- Original Message -------- >> >> *Change Request ID*: 7144564 >> *Synopsis*: jarsigner should report timestamp failure as a warning >> >> >> === *Description* >> ============================================================ >> jarsigner -verify on a jar, signed with a expired certificate, with a >> timestamp, >> shows "[CertPath not validated: timestamp check failed]" >> But this is not reported as a warning. >> This should also be reported. >> >> >> -bash-3.00$ $JDK8_HOME/bin/jarsigner -keystore srikar.p12.data >> -storepass password -storetype pkcs12 -verify -verify -verbose -certs >> SignedWithTimeStamp.jar >> >> s k 161 Thu Feb 09 13:59:26 PST 2012 META-INF/MANIFEST.MF >> >> [entry was signed on 2/9/12 1:59 PM] >> X.509, CN=SRIKAR, O=SMI, OU=BGR, ST=KAR, C=IN, UID=srikar, >> EMAILADDRESS=srikar.sagi at sun.com (srikarcert) >> [certificate expired on 10/14/03 7:10 AM] >> [CertPath not validated: timestamp check failed] >> >> 323 Thu Feb 09 13:59:26 PST 2012 META-INF/SRIKARCE.SF >> 2786 Thu Feb 09 13:59:26 PST 2012 META-INF/SRIKARCE.RSA >> 0 Thu Feb 09 13:59:24 PST 2012 META-INF/ >> smk 4448 Thu Feb 09 13:59:12 PST 2012 CheckJarEntries.class >> >> [entry was signed on 2/9/12 1:59 PM] >> X.509, CN=SRIKAR, O=SMI, OU=BGR, ST=KAR, C=IN, UID=srikar, >> EMAILADDRESS=srikar.sagi at sun.com (srikarcert) >> [certificate expired on 10/14/03 7:10 AM] >> [CertPath not validated: timestamp check failed] >> >> >> s = signature was verified >> m = entry is listed in manifest >> k = at least one certificate was found in keystore >> i = at least one certificate was found in identity scope >> >> jar verified. >> >> Warning: >> This jar contains entries whose signer certificate has expired. >> This jar contains entries whose certificate chain is not validated. >> > From littlee at linux.vnet.ibm.com Mon Feb 20 03:25:10 2012 From: littlee at linux.vnet.ibm.com (littlee at linux.vnet.ibm.com) Date: Mon, 20 Feb 2012 03:25:10 +0000 Subject: hg: jdk8/tl/jdk: 7146506: (fc) Add EACCES check to the return of fcntl native method Message-ID: <20120220032520.DF77C47592@hg.openjdk.java.net> Changeset: de7f6d5841b6 Author: littlee Date: 2012-02-20 11:24 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de7f6d5841b6 7146506: (fc) Add EACCES check to the return of fcntl native method Summary: Add EACCES check according to the spec of fcntl Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/FileDispatcherImpl.c From alan.bateman at oracle.com Mon Feb 20 19:17:49 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 20 Feb 2012 19:17:49 +0000 Subject: hg: jdk8/tl/jdk: 6346658: (se) Selector briefly spins when asynchronously closing a registered channel [win] Message-ID: <20120220191811.BFD3E4759A@hg.openjdk.java.net> Changeset: 7326971f09af Author: alanb Date: 2012-02-20 18:55 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7326971f09af 6346658: (se) Selector briefly spins when asynchronously closing a registered channel [win] Reviewed-by: chegar, coffeys ! src/share/classes/sun/nio/ch/NativeThreadSet.java ! src/windows/classes/sun/nio/ch/NativeThread.java ! src/windows/classes/sun/nio/ch/SocketDispatcher.java ! src/windows/native/sun/nio/ch/SocketDispatcher.c From alan.bateman at oracle.com Mon Feb 20 19:46:44 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 20 Feb 2012 19:46:44 +0000 Subject: hg: jdk8/tl/jdk: 7147087: Remove AWT/Swing/client tests from ProblemList Message-ID: <20120220194653.9333B4759B@hg.openjdk.java.net> Changeset: 5e56d498e913 Author: alanb Date: 2012-02-20 19:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e56d498e913 7147087: Remove AWT/Swing/client tests from ProblemList Reviewed-by: ohair ! test/Makefile ! test/ProblemList.txt From valerie.peng at oracle.com Tue Feb 21 00:13:33 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Mon, 20 Feb 2012 16:13:33 -0800 Subject: code review request: 7144530: KeyTab.getInstance(String) no longer handles keyTabNames with "file:" prefix In-Reply-To: <4F41CDED.3020307@oracle.com> References: <5743251.1329213664655.JavaMail.sbladm@swsblss4-new.central.sun.com> <4F41CDED.3020307@oracle.com> Message-ID: <4F42E1AD.50805@oracle.com> Looks fine to me. Thanks, Valerie On 02/19/12 20:37, Weijun Wang wrote: > Hi Valerie > > Please take a review on this fix: > > http://cr.openjdk.java.net/~weijun/7144530/webrev.00/ > > I plan to backport it to jdk7u6 once the dev workspace is re-opened. > > Thanks > Max > > On 02/14/2012 06:01 PM, weijun.wang at oracle.com wrote: >> >> *Change Request ID*: 7144530 >> >> *Synopsis*: KeyTab.getInstance(String) no longer handles keyTabNames >> with "file:" prefix >> >> >> === *Description* >> ============================================================ >> FULL PRODUCT VERSION : >> java version "1.7.0_02" >> Java(TM) SE Runtime Environment (build 1.7.0_02-b13) >> Java HotSpot(TM) 64-Bit Server VM (build 22.0-b10, mixed mode) >> >> ADDITIONAL OS VERSION INFORMATION : >> Microsoft Windows [Version 6.1.7600] >> >> A DESCRIPTION OF THE PROBLEM : >> Under JDK6, sun.security.krb5.internal.ktab.KeyTab.getInstance() used >> to remove prefixes like "file:" from the keyTabName. >> >> Using JDK7 this is no longer the case. Passing a File URI like >> "file:/..." now results in an empty KeyTab. What happens, is a >> FileNotFoundException is thrown when reading from the FileInputStream >> in the constructor. The exception is caught in the constructor and >> the "isMissing" flag is set to true. >> >> However, when the default_keytab_name property is resolved in >> getDefaultTabName(), prefixes like "file:" *are* removed (by calling >> the parse method). >> >> STEPS TO FOLLOW TO REPRODUCE THE PROBLEM : >> 1. Construct a dummy keytab file using ktab.exe. >> ktab.exe -a host/user at DOMAIN password -k dummy.keytab >> >> 2. Construct a KeyTab using a File URI. >> KeyTab keyTab = KeyTab.getInstance("file:/C:/workspace/dummy.keytab"); >> >> 3. Retrieve the entries from the KeyTab. >> keyTab.getEntries() >> >> EXPECTED VERSUS ACTUAL BEHAVIOR : >> EXPECTED - >> keyTab.getEntries() should contain the entries of the keytab. >> ACTUAL - >> keyTab.getEntries() is always empty, i.e. keyTab.getEntries().length >> is always zero. >> >> However, when using with the absolute path to the same file, i.e. >> KeyTab.getInstance("C:/workspace/dummy.keytab"), it will correctly >> read its entries. >> >> REPRODUCIBILITY : >> This bug can be reproduced always. >> >> ---------- BEGIN SOURCE ---------- >> import static org.junit.Assert.assertTrue; >> >> import org.junit.Test; >> >> import sun.security.krb5.internal.ktab.KeyTab; >> >> public class KeyTabPrefixBug { >> >> private static final String PATH_TO_KEY_TAB = >> "C:/workspace/dummy.keytab"; >> >> @Test >> public void withUriPrefix() throws Exception { >> KeyTab keyTab = KeyTab.getInstance("file:/" + PATH_TO_KEY_TAB); >> assertTrue(keyTab.getEntries().length> 0); // fails >> } >> >> @Test >> public void withoutUriPrefix() throws Exception { >> KeyTab keyTab = KeyTab.getInstance(PATH_TO_KEY_TAB); >> assertTrue(keyTab.getEntries().length> 0); // succeeds >> } >> } >> ---------- END SOURCE ---------- >> >> CUSTOMER SUBMITTED WORKAROUND : >> Always use file paths (never URIs) when using the Kerberos API. From weijun.wang at oracle.com Tue Feb 21 00:51:46 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 21 Feb 2012 00:51:46 +0000 Subject: hg: jdk8/tl/jdk: 7144530: KeyTab.getInstance(String) no longer handles keyTabNames with "file:" prefix Message-ID: <20120221005205.244BC475A7@hg.openjdk.java.net> Changeset: 0243e7c0b0fb Author: weijun Date: 2012-02-21 08:51 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0243e7c0b0fb 7144530: KeyTab.getInstance(String) no longer handles keyTabNames with "file:" prefix Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java + test/sun/security/krb5/ktab/FileKeyTab.java From weijun.wang at oracle.com Tue Feb 21 06:19:43 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 21 Feb 2012 14:19:43 +0800 Subject: code review request: 7147336: clarification on warning of keytool -printcrl In-Reply-To: <1132073.1329804651140.JavaMail.sbladm@swsblss4-new.central.sun.com> References: <1132073.1329804651140.JavaMail.sbladm@swsblss4-new.central.sun.com> Message-ID: <4F43377F.5010002@oracle.com> Please review this code change: http://cr.openjdk.java.net/~weijun/7147336/webrev.00/ No regression test, trivial fix. Thanks Max -------- Original Message -------- *Change Request ID*: 7147336 *Synopsis*: clarification on warning of keytool -printcrl === *Description* ============================================================ The keytool -printcrl command tries to verify the input CRL file using a cert in cacerts for the specified keystore (or ~/.keystore is not specified). If no cert can be found that signs the CRL, it would print out WARNING: not verified. Make sure -keystore and -alias are correct. This is not entirely correct, because -alias is not used here. From Xuelei.Fan at Oracle.COM Tue Feb 21 06:36:43 2012 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Tue, 21 Feb 2012 14:36:43 +0800 Subject: code review request: 7147336: clarification on warning of keytool -printcrl In-Reply-To: <4F43377F.5010002@oracle.com> References: <1132073.1329804651140.JavaMail.sbladm@swsblss4-new.central.sun.com> <4F43377F.5010002@oracle.com> Message-ID: <4F433B7B.3070603@Oracle.COM> Looks fine to me. Xuelei On 2/21/2012 2:19 PM, Weijun Wang wrote: > Please review this code change: > > http://cr.openjdk.java.net/~weijun/7147336/webrev.00/ > > No regression test, trivial fix. > > Thanks > Max > > > -------- Original Message -------- > *Change Request ID*: 7147336 > *Synopsis*: clarification on warning of keytool -printcrl > > === *Description* > ============================================================ > The keytool -printcrl command tries to verify the input CRL file using a > cert in cacerts for the specified keystore (or ~/.keystore is not > specified). If no cert can be found that signs the CRL, it would print out > > WARNING: not verified. Make sure -keystore and -alias are correct. > > This is not entirely correct, because -alias is not used here. > From weijun.wang at oracle.com Tue Feb 21 07:12:04 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 21 Feb 2012 07:12:04 +0000 Subject: hg: jdk8/tl/jdk: 7147336: clarification on warning of keytool -printcrl Message-ID: <20120221071214.6B8A9475AC@hg.openjdk.java.net> Changeset: b739dd7ce59c Author: weijun Date: 2012-02-21 15:11 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b739dd7ce59c 7147336: clarification on warning of keytool -printcrl Reviewed-by: xuelei ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/util/Resources.java From xuelei.fan at oracle.com Tue Feb 21 13:45:19 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Tue, 21 Feb 2012 13:45:19 +0000 Subject: hg: jdk8/tl/jdk: 7147407: remove never used debug code in DnsClient.java Message-ID: <20120221134528.F0E75475B5@hg.openjdk.java.net> Changeset: a4e3dde9a8a7 Author: xuelei Date: 2012-02-21 05:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4e3dde9a8a7 7147407: remove never used debug code in DnsClient.java Reviewed-by: vinnie ! src/share/classes/com/sun/jndi/dns/DnsClient.java From mark.reinhold at oracle.com Tue Feb 21 23:32:54 2012 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Tue, 21 Feb 2012 15:32:54 -0800 (PST) Subject: JEP 140: Limited doPrivileged Message-ID: <20120221233254.932C71637@eggemoggin.niobe.net> Posted: http://openjdk.java.net/jeps/140 - Mark From valerie.peng at oracle.com Wed Feb 22 01:33:55 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 21 Feb 2012 17:33:55 -0800 Subject: Code Review Request for 7146728 and 7130959 Message-ID: <4F444603.3040409@oracle.com> Brad, Can you please review the fixes for the following 2 bugs: * 7146728: Inconsistent length for the generated secret using DH key agreement impl from SunJCE and PKCS11 o http://cr.openjdk.java.net/~valeriep/7146728/webrev.00/ This impacts both SunJCE provider and SunPKCS11 provider. The implementations are inconsistent within SunJCE provider itself between the engineGenerateSecret() and engineGenerateSecret(byte[], int). Given that RFC 2631 specifies the leading 0s must be preserved so the generated secret has as many octets as the prime P, I have changed both SunJCE and SunPKCS11 provider to do so. When testing against Solaris and NSS libraries, Solaris preserves the leading 0s while NSS trims it off, thus similar handling is also needed in SunPKCS11 provider. * 7130959: Tweak 7058133 fix for JDK 8 (javah makefile changes) o http://cr.openjdk.java.net/~valeriep/7130959/webrev.00/ Instead of using the -Xbootclasspath, switching over to use -boothclasspath for consistency with the backported changes in the update releases for earlier JDK, e.g. 7u. Thanks, Valerie -------------- next part -------------- An HTML attachment was scrubbed... URL: From lana.steuck at oracle.com Thu Feb 23 05:25:59 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 05:25:59 +0000 Subject: hg: jdk8/tl: Added tag jdk8-b26 for changeset 2accafff224a Message-ID: <20120223052559.7CF2F47648@hg.openjdk.java.net> Changeset: 1533dfab9903 Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1533dfab9903 Added tag jdk8-b26 for changeset 2accafff224a ! .hgtags From lana.steuck at oracle.com Thu Feb 23 05:25:59 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 05:25:59 +0000 Subject: hg: jdk8/tl/corba: Added tag jdk8-b26 for changeset 79f709a099f4 Message-ID: <20120223052601.C861347649@hg.openjdk.java.net> Changeset: 4fffe75e4edd Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/4fffe75e4edd Added tag jdk8-b26 for changeset 79f709a099f4 ! .hgtags From lana.steuck at oracle.com Thu Feb 23 05:26:03 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 05:26:03 +0000 Subject: hg: jdk8/tl/jaxp: Added tag jdk8-b26 for changeset dbb7283c197b Message-ID: <20120223052603.12C034764A@hg.openjdk.java.net> Changeset: 80c47eb83d24 Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/80c47eb83d24 Added tag jdk8-b26 for changeset dbb7283c197b ! .hgtags From lana.steuck at oracle.com Thu Feb 23 05:26:07 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 05:26:07 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20120223052608.070D04764B@hg.openjdk.java.net> Changeset: 329ace7198ac Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/329ace7198ac Added tag jdk8-b26 for changeset 3518639eab6c ! .hgtags Changeset: 38c037af4127 Author: lana Date: 2012-02-18 16:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/38c037af4127 Merge From lana.steuck at oracle.com Thu Feb 23 05:26:12 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 05:26:12 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20120223052620.EA04C4764C@hg.openjdk.java.net> Changeset: fba3cbee0fa3 Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fba3cbee0fa3 Added tag jdk8-b26 for changeset b556aa8a99c3 ! .hgtags Changeset: e127334a64fe Author: darcy Date: 2012-02-17 15:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e127334a64fe 7143910: test/tools/apt/Basics/apt.sh fails with 'real' sh Reviewed-by: darcy Contributed-by: sonali.goel at oracle.com ! test/tools/apt/Basics/apt.sh Changeset: be456f9c64e8 Author: lana Date: 2012-02-18 16:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/be456f9c64e8 Merge - make/test/lib/apt.sh - src/share/classes/com/sun/mirror/apt/AnnotationProcessor.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorEnvironment.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorFactory.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorListener.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessors.java - src/share/classes/com/sun/mirror/apt/Filer.java - src/share/classes/com/sun/mirror/apt/Messager.java - src/share/classes/com/sun/mirror/apt/RoundCompleteEvent.java - src/share/classes/com/sun/mirror/apt/RoundCompleteListener.java - src/share/classes/com/sun/mirror/apt/RoundState.java - src/share/classes/com/sun/mirror/apt/package-info.java - src/share/classes/com/sun/mirror/declaration/AnnotationMirror.java - src/share/classes/com/sun/mirror/declaration/AnnotationTypeDeclaration.java - src/share/classes/com/sun/mirror/declaration/AnnotationTypeElementDeclaration.java - src/share/classes/com/sun/mirror/declaration/AnnotationValue.java - src/share/classes/com/sun/mirror/declaration/ClassDeclaration.java - src/share/classes/com/sun/mirror/declaration/ConstructorDeclaration.java - src/share/classes/com/sun/mirror/declaration/Declaration.java - src/share/classes/com/sun/mirror/declaration/EnumConstantDeclaration.java - src/share/classes/com/sun/mirror/declaration/EnumDeclaration.java - src/share/classes/com/sun/mirror/declaration/ExecutableDeclaration.java - src/share/classes/com/sun/mirror/declaration/FieldDeclaration.java - src/share/classes/com/sun/mirror/declaration/InterfaceDeclaration.java - src/share/classes/com/sun/mirror/declaration/MemberDeclaration.java - src/share/classes/com/sun/mirror/declaration/MethodDeclaration.java - src/share/classes/com/sun/mirror/declaration/Modifier.java - src/share/classes/com/sun/mirror/declaration/PackageDeclaration.java - src/share/classes/com/sun/mirror/declaration/ParameterDeclaration.java - src/share/classes/com/sun/mirror/declaration/TypeDeclaration.java - src/share/classes/com/sun/mirror/declaration/TypeParameterDeclaration.java - src/share/classes/com/sun/mirror/declaration/package-info.java - src/share/classes/com/sun/mirror/overview.html - src/share/classes/com/sun/mirror/type/AnnotationType.java - src/share/classes/com/sun/mirror/type/ArrayType.java - src/share/classes/com/sun/mirror/type/ClassType.java - src/share/classes/com/sun/mirror/type/DeclaredType.java - src/share/classes/com/sun/mirror/type/EnumType.java - src/share/classes/com/sun/mirror/type/InterfaceType.java - src/share/classes/com/sun/mirror/type/MirroredTypeException.java - src/share/classes/com/sun/mirror/type/MirroredTypesException.java - src/share/classes/com/sun/mirror/type/PrimitiveType.java - src/share/classes/com/sun/mirror/type/ReferenceType.java - src/share/classes/com/sun/mirror/type/TypeMirror.java - src/share/classes/com/sun/mirror/type/TypeVariable.java - src/share/classes/com/sun/mirror/type/VoidType.java - src/share/classes/com/sun/mirror/type/WildcardType.java - src/share/classes/com/sun/mirror/type/package-info.java - src/share/classes/com/sun/mirror/util/DeclarationFilter.java - src/share/classes/com/sun/mirror/util/DeclarationScanner.java - src/share/classes/com/sun/mirror/util/DeclarationVisitor.java - src/share/classes/com/sun/mirror/util/DeclarationVisitors.java - src/share/classes/com/sun/mirror/util/Declarations.java - src/share/classes/com/sun/mirror/util/SimpleDeclarationVisitor.java - src/share/classes/com/sun/mirror/util/SimpleTypeVisitor.java - src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java - src/share/classes/com/sun/mirror/util/SourcePosition.java - src/share/classes/com/sun/mirror/util/TypeVisitor.java - src/share/classes/com/sun/mirror/util/Types.java - src/share/classes/com/sun/mirror/util/package-info.java - src/share/classes/com/sun/tools/apt/Main.java - src/share/classes/com/sun/tools/apt/comp/AnnotationProcessingError.java - src/share/classes/com/sun/tools/apt/comp/Apt.java - src/share/classes/com/sun/tools/apt/comp/BootstrapAPF.java - src/share/classes/com/sun/tools/apt/comp/PrintAP.java - src/share/classes/com/sun/tools/apt/comp/UsageMessageNeededException.java - src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java - src/share/classes/com/sun/tools/apt/main/CommandLine.java - src/share/classes/com/sun/tools/apt/main/Main.java - src/share/classes/com/sun/tools/apt/mirror/AptEnv.java - src/share/classes/com/sun/tools/apt/mirror/apt/AnnotationProcessorEnvironmentImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/FilerImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/MessagerImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/RoundCompleteEventImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/RoundStateImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationMirrorImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationTypeDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationTypeElementDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationValueImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ClassDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/Constants.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ConstructorDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationMaker.java - src/share/classes/com/sun/tools/apt/mirror/declaration/EnumConstantDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/EnumDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ExecutableDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/FieldDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/InterfaceDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/MemberDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/MethodDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/PackageDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ParameterDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/TypeDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/TypeParameterDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/AnnotationTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/ArrayTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/ClassTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/DeclaredTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/EnumTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/InterfaceTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/PrimitiveTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeMaker.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeMirrorImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeVariableImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/VoidTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/WildcardTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/DeclarationsImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/SourcePositionImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/TypesImpl.java - src/share/classes/com/sun/tools/apt/resources/apt.properties - src/share/classes/com/sun/tools/apt/resources/apt_ja.properties - src/share/classes/com/sun/tools/apt/resources/apt_zh_CN.properties - src/share/classes/com/sun/tools/apt/util/Bark.java - test/tools/apt/Basics/Aggregate.java - test/tools/apt/Basics/ClassAnnotations.java - test/tools/apt/Basics/FreshnessApf.java - test/tools/apt/Basics/GenClass.java - test/tools/apt/Basics/Indirect.java - test/tools/apt/Basics/Lacuna.java - test/tools/apt/Basics/MethodAnnotations.java - test/tools/apt/Basics/Milk.java - test/tools/apt/Basics/MisMatch.java - test/tools/apt/Basics/Misc.java - test/tools/apt/Basics/MyMarker.java - test/tools/apt/Basics/MySimple.java - test/tools/apt/Basics/NestedClassAnnotations.java - test/tools/apt/Basics/ParameterAnnotations.java - test/tools/apt/Basics/StaticFieldAnnotations.java - test/tools/apt/Basics/StaticMethodAnnotations.java - test/tools/apt/Basics/TestGetPackageApf.java - test/tools/apt/Basics/TestGetTypeDeclarationApf.java - test/tools/apt/Basics/annot/AnnotMarker.java - test/tools/apt/Basics/annot/AnnotShangri_la.java - test/tools/apt/Basics/annot/AnnotSimple.java - test/tools/apt/Basics/annot/annot2/AnnotMarker2.java - test/tools/apt/Basics/annot/annot2/AnnotSimple2.java - test/tools/apt/Basics/com.sun.mirror.apt.AnnotationProcessorFactory - test/tools/apt/Basics/foo/bar/Baz.java - test/tools/apt/Basics/foo/bar/Quux.java - test/tools/apt/Basics/golden.txt - test/tools/apt/Basics/goldenAggregate.txt - test/tools/apt/Basics/p1/p2.java - test/tools/apt/Basics/p1/p2/C1.java - test/tools/apt/Basics/print.sh - test/tools/apt/Compile/ClassDeclApf.java - test/tools/apt/Compile/ClassDeclApf2.java - test/tools/apt/Compile/Dummy1.java - test/tools/apt/Compile/ErrorAPF.java - test/tools/apt/Compile/HelloAnnotation.java - test/tools/apt/Compile/HelloWorld.java - test/tools/apt/Compile/Round1Apf.java - test/tools/apt/Compile/Round2Apf.java - test/tools/apt/Compile/Round3Apf.java - test/tools/apt/Compile/Round4Apf.java - test/tools/apt/Compile/Rounds.java - test/tools/apt/Compile/StaticApf.java - test/tools/apt/Compile/WarnAPF.java - test/tools/apt/Compile/WrappedStaticApf.java - test/tools/apt/Compile/compile.sh - test/tools/apt/Compile/golden.txt - test/tools/apt/Compile/goldenFactory.txt - test/tools/apt/Compile/goldenWarn.txt - test/tools/apt/Compile/servicesRound1 - test/tools/apt/Compile/servicesRound2 - test/tools/apt/Compile/servicesRound3 - test/tools/apt/Compile/servicesRound4 - test/tools/apt/Compile/servicesStaticApf - test/tools/apt/Compile/src/AhOneClass.java - test/tools/apt/Compile/src/AndAhTwoClass.java - test/tools/apt/Compile/src/Round1Class.java - test/tools/apt/Discovery/Dee.java - test/tools/apt/Discovery/Dum.java - test/tools/apt/Discovery/Empty.java - test/tools/apt/Discovery/PhantomTouch.java - test/tools/apt/Discovery/PhantomUpdate.java - test/tools/apt/Discovery/Touch.java - test/tools/apt/Discovery/discovery.sh - test/tools/apt/Discovery/servicesBadTouch - test/tools/apt/Discovery/servicesPhantomTouch - test/tools/apt/Discovery/servicesTouch - test/tools/apt/Discovery/servicesTweedle - test/tools/apt/Misc/Marked.java - test/tools/apt/Misc/Marker.java - test/tools/apt/Misc/Misc.java - test/tools/apt/Misc/misc.sh - test/tools/apt/Misc/servicesMisc - test/tools/apt/Options/Marked.java - test/tools/apt/Options/Marker.java - test/tools/apt/Options/OptionChecker.java - test/tools/apt/Options/options.sh - test/tools/apt/Options/servicesOptions - test/tools/apt/Scanners/Counter.java - test/tools/apt/Scanners/MemberOrderApf.java - test/tools/apt/Scanners/Order.java - test/tools/apt/Scanners/Scanner.java - test/tools/apt/Scanners/TestEnum.java - test/tools/apt/Scanners/VisitOrder.java - test/tools/apt/Scanners/scanner.sh - test/tools/apt/Scanners/servicesScanner - test/tools/apt/lib/Ignore.java - test/tools/apt/lib/Test.java - test/tools/apt/lib/TestProcessor.java - test/tools/apt/lib/TestProcessorFactory.java - test/tools/apt/lib/Tester.java - test/tools/apt/mirror/declaration/AnnoMirror.java - test/tools/apt/mirror/declaration/AnnoTypeDecl.java - test/tools/apt/mirror/declaration/AnnoTypeElemDecl.java - test/tools/apt/mirror/declaration/AnnoVal.java - test/tools/apt/mirror/declaration/ClassDecl.java - test/tools/apt/mirror/declaration/ConstExpr.java - test/tools/apt/mirror/declaration/ConstructorDecl.java - test/tools/apt/mirror/declaration/EnumDecl.java - test/tools/apt/mirror/declaration/FieldDecl.java - test/tools/apt/mirror/declaration/GetAnno.java - test/tools/apt/mirror/declaration/InterfaceDecl.java - test/tools/apt/mirror/declaration/MethodDecl.java - test/tools/apt/mirror/declaration/PackageDecl.java - test/tools/apt/mirror/declaration/ParameterDecl.java - test/tools/apt/mirror/declaration/pkg1/AClass.java - test/tools/apt/mirror/declaration/pkg1/AnAnnoType.java - test/tools/apt/mirror/declaration/pkg1/AnEnum.java - test/tools/apt/mirror/declaration/pkg1/AnInterface.java - test/tools/apt/mirror/declaration/pkg1/package-info.java - test/tools/apt/mirror/declaration/pkg1/pkg2/AnInterface.java - test/tools/apt/mirror/declaration/pkg1/pkg2/package.html - test/tools/apt/mirror/type/AnnoTyp.java - test/tools/apt/mirror/type/ArrayTyp.java - test/tools/apt/mirror/type/ClassTyp.java - test/tools/apt/mirror/type/EnumTyp.java - test/tools/apt/mirror/type/InterfaceTyp.java - test/tools/apt/mirror/type/PrimitiveTyp.java - test/tools/apt/mirror/type/TypeVar.java - test/tools/apt/mirror/type/WildcardTyp.java - test/tools/apt/mirror/util/Overrides.java - test/tools/apt/mirror/util/TypeCreation.java From lana.steuck at oracle.com Thu Feb 23 05:26:31 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 05:26:31 +0000 Subject: hg: jdk8/tl/hotspot: 69 new changesets Message-ID: <20120223052854.021A74764D@hg.openjdk.java.net> Changeset: 3c4621be5149 Author: amurillo Date: 2012-02-06 12:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c4621be5149 7143122: new hotspot build - hs23-b15 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 869be5c8882e Author: phh Date: 2012-02-03 17:21 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/869be5c8882e 7142586: Cannot build on Solaris 11 due to use of ia_nice Summary: Delete the single use of ia_nice in os_solaris.cpp Reviewed-by: kamg, kvn ! src/os/solaris/vm/os_solaris.cpp Changeset: c77d473e71f7 Author: ohrstrom Date: 2012-01-31 13:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c77d473e71f7 7132779: build-infra merge: Enable ccache to work for most developer builds. Summary: When a build number is not specified, the JRE_RELEASE_VERSION define contains a date and timestamp. Thus ccache cannot cache the object files for longer than a minute since the define is passed to the compilation of all source files. This change passes JRE_RELEASE_VERSION only to vm_version.cpp and adds a function jre_release_version() to Abstract_VM_Version. This allows all other source files to be ccached. Reviewed-by: ohair, rottenha Contributed-by: fredrik.ohrstrom at oracle.com ! make/bsd/makefiles/vm.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/vm.make ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp Changeset: 719f7007c8e8 Author: erikj Date: 2012-02-06 09:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/719f7007c8e8 7141242: build-infra merge: Rename CPP->CXX and LINK->LD Summary: Cleaned up make variables for compilers and linker to consistently use CXX for C++ compiler, CC for C compiler and LD for linker. Reviewed-by: dholmes, ohrstrom ! make/bsd/makefiles/adlc.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/product.make ! make/bsd/makefiles/rules.make ! make/bsd/makefiles/sparcWorks.make ! make/bsd/makefiles/vm.make ! make/linux/makefiles/adlc.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/launcher.make ! make/linux/makefiles/product.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/sparcWorks.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/adlc.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/gcc.make ! make/solaris/makefiles/launcher.make ! make/solaris/makefiles/product.make ! make/solaris/makefiles/rules.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make ! make/windows/build_vm_def.sh ! make/windows/get_msc_ver.sh ! make/windows/makefiles/adlc.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/launcher.make ! make/windows/makefiles/product.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/sa.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/shared.make ! make/windows/makefiles/vm.make Changeset: ea677dbdd883 Author: fparain Date: 2012-02-07 12:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ea677dbdd883 Merge Changeset: 5e9fba4e8718 Author: kvn Date: 2012-02-07 11:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5e9fba4e8718 7142167: MAC: _get_previous_fp broken on bsd with llvm-gcc Summary: LLVM-GCC (__llvm__) should use the same _get_previous_fp implementation as __clang__ (as is the case for os::current_stack_pointer). Reviewed-by: twisti, never, dcubed ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Changeset: b9bc6cae88f2 Author: kvn Date: 2012-02-07 16:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b9bc6cae88f2 7143491: G1 C2 CTW: assert(p2x->outcnt() == 2) failed: expects 2 users: Xor and URShift nodes Summary: Adjust the assert and code in eliminate_card_mark() method for case when stored value is NULL. Reviewed-by: iveresov, never ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/macro.cpp Changeset: c742b0b47fe5 Author: roland Date: 2012-02-08 09:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c742b0b47fe5 7119286: JSR292: SIGSEGV in JNIHandleBlock::release_block(JNIHandleBlock*, Thread*)+0x3c Summary: unaligned stack in throw_NullPointerException_at_call_entry(). Reviewed-by: twisti, never, kvn ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: 2f985b6ce7ff Author: jrose Date: 2012-02-09 18:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2f985b6ce7ff Merge Changeset: 1ac084126285 Author: dlong Date: 2012-01-24 18:00 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1ac084126285 7130319: C2: running with -XX:+PrintOptoAssembly crashes the VM with assert(false) failed: bad tag in log Summary: Relax assert to allow the VMThread to close the log while the compiler thread is still writing to it. Reviewed-by: dholmes, never Contributed-by: dean.long at oracle.com ! src/share/vm/utilities/xmlstream.cpp Changeset: d851f3714641 Author: dholmes Date: 2012-01-25 19:26 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d851f3714641 Merge - src/os/bsd/vm/decoder_bsd.cpp Changeset: a79cb7c55012 Author: jiangli Date: 2012-01-25 17:40 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a79cb7c55012 7132690: InstanceKlass:_reference_type should be u1 type Summary: Change InstanceKlass::_reference_type to u1 type. Reviewed-by: dholmes, coleenp, acorn Contributed-by: Jiangli Zhou ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: f3fa16bd7159 Author: bobv Date: 2012-01-25 21:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f3fa16bd7159 Merge Changeset: b7b8b6d2f97d Author: bpittore Date: 2012-02-06 10:57 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b7b8b6d2f97d Merge ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: f174909614bd Author: bpittore Date: 2012-02-10 10:55 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f174909614bd Merge ! src/share/vm/opto/library_call.cpp Changeset: d71e662fe037 Author: amurillo Date: 2012-02-10 11:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d71e662fe037 Merge Changeset: fd3060701216 Author: amurillo Date: 2012-02-10 11:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fd3060701216 Added tag hs23-b15 for changeset d71e662fe037 ! .hgtags Changeset: 087daaec688d Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/087daaec688d Added tag jdk8-b26 for changeset fd3060701216 ! .hgtags Changeset: 094138495da4 Author: amurillo Date: 2012-02-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/094138495da4 7144322: new hotspot build - hs23-b16 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 77a488cd4af2 Author: dlong Date: 2012-02-15 00:51 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/77a488cd4af2 7140866: assert(covered) failed: Card for end of new region not committed Summary: resize covered region only after successfully mapping shared archive Reviewed-by: brutisso, ysr Contributed-by: dean.long at oracle.com ! src/share/vm/memory/compactingPermGenGen.cpp Changeset: f9961b6498f9 Author: bpittore Date: 2012-02-15 16:09 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f9961b6498f9 Merge Changeset: 95f6641e38e0 Author: iveresov Date: 2012-02-10 17:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/95f6641e38e0 7144296: PS: Optimize nmethods processing Summary: Prunes scavenge roots in code list every young GC, promote objects directly pointed by the code immediately Reviewed-by: johnc, jcoomes ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp Changeset: caa4652b4414 Author: tonyp Date: 2012-02-14 08:21 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/caa4652b4414 7129892: G1: explicit marking cycle initiation might fail to initiate a marking cycle Summary: If we try to schedule an initial-mark GC in order to explicit start a conc mark cycle and it gets pre-empted by antoher GC, we should retry the attempt as long as it's appropriate for the GC cause. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: d903bf750e9f Author: johnc Date: 2012-01-18 09:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d903bf750e9f 7129514: time warp warnings after 7117303 Summary: Replace calls to os::javaTimeMillis() that are used to update the milliseconds since the last GC to an equivalent that uses a monotonically non-decreasing time source. Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genMarkSweep.cpp Changeset: a9647476d1a4 Author: tonyp Date: 2012-02-15 13:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a9647476d1a4 7132029: G1: mixed GC phase lasts for longer than it should Summary: Revamp of the mechanism that chooses old regions for inclusion in the CSet. It simplifies the code and introduces min and max bounds on the number of old regions added to the CSet at each mixed GC to avoid pathological cases. It also ensures that when we do a mixed GC we'll always find old regions to add to the CSet (i.e., it eliminates the case where a mixed GC will collect no old regions which can happen today). Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp Changeset: ab4422d0ed59 Author: jcoomes Date: 2012-02-16 13:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ab4422d0ed59 7146343: PS invoke methods should indicate the type of gc done Reviewed-by: stefank, jmasa ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp Changeset: 23c0eb012d6f Author: jcoomes Date: 2012-02-16 13:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/23c0eb012d6f 6330863: vm/gc/InfiniteList.java fails intermittently due to timeout Summary: in some cases, allocate from the old gen before doing a full gc Reviewed-by: stefank, jmasa ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.inline.hpp Changeset: be398bba40e9 Author: stefank Date: 2012-02-17 13:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/be398bba40e9 Merge Changeset: 1b0e0f8be510 Author: minqi Date: 2012-02-09 00:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1b0e0f8be510 7131006: java/lang/management/ThreadMXBean/ThreadLists.java Reviewed-by: dholmes, acorn ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/utilities/preserveException.cpp Changeset: db006a85bf91 Author: zgu Date: 2012-02-09 10:16 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/db006a85bf91 7141259: Native stack is missing in hs_err Summary: Code cleanup and creating a private decoder for error handler, since it can be triggered from in signal handler, where no lock can be taken Reviewed-by: dholmes, kamg, acorn, coleenp ! src/os/bsd/vm/decoder_machO.hpp ! src/os/windows/vm/decoder_windows.hpp ! src/share/vm/utilities/decoder.cpp ! src/share/vm/utilities/decoder.hpp ! src/share/vm/utilities/decoder_elf.hpp ! src/share/vm/utilities/vmError.hpp Changeset: ea527c5cde03 Author: zgu Date: 2012-02-09 07:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ea527c5cde03 Merge Changeset: 54d3535a6dd3 Author: poonam Date: 2012-02-12 19:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/54d3535a6dd3 7009098: SA cannot open core files larger than 2GB on Linux 32-bit Summary: Added Large File Support by compiling libsaproc.so with -D_FILE_OFFSET_BITS=64, and a small change with which SA should first load libraries from the path specified with SA_ALTROOT. Reviewed-by: dholmes, kevinw, dcubed, minqi ! agent/src/os/linux/Makefile ! agent/src/os/linux/libproc_impl.c ! make/linux/makefiles/saproc.make Changeset: 1bb2838e2fc1 Author: fparain Date: 2012-02-13 06:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1bb2838e2fc1 Merge Changeset: 849412a95e45 Author: coleenp Date: 2012-02-13 12:30 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/849412a95e45 7059899: Stack overflows in Java code cause 64-bit JVMs to exit due to SIGSEGV Summary: Increase StackShadowPages to accomodate the JDK changes to increase buffer size in socketWrite Reviewed-by: acorn, phh ! src/cpu/x86/vm/globals_x86.hpp Changeset: 1891640ca63f Author: fparain Date: 2012-02-14 06:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1891640ca63f 7143760: Memory leak in GarbageCollectionNotifications Reviewed-by: dholmes, dcubed, kamg ! src/share/vm/services/gcNotifier.cpp ! src/share/vm/services/gcNotifier.hpp Changeset: a9831b955a0a Author: kamg Date: 2012-02-13 14:03 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a9831b955a0a 7069991: Setup make/jprt.properties files for jdk8 Summary: Change default release value to jdk8 (but overrideable) Reviewed-by: phh, jcoomes, dholmes, ohair ! make/jprt.properties Changeset: a9ac4910e7f2 Author: kamg Date: 2012-02-14 15:52 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a9ac4910e7f2 Merge Changeset: 28d91e43ab6d Author: coleenp Date: 2012-02-14 16:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/28d91e43ab6d 7145587: Stack overflows in Java code cause 64-bit JVMs to exit due to SIGSEGV (sparc version) Summary: Increase StackShadowPages to accomodate the JDK changes to increase buffer size in socketWrite Reviewed-by: acorn, phh, dcubed, kamg, dsamersoff ! src/cpu/sparc/vm/globals_sparc.hpp Changeset: cf772dff4bfd Author: coleenp Date: 2012-02-14 18:35 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cf772dff4bfd Merge Changeset: b8a4e1d372a0 Author: kamg Date: 2012-02-14 20:02 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b8a4e1d372a0 7145589: First JSDT provider creation fails Summary: 0 is a successful return from an ioctl() call Reviewed-by: dcubed, phh, dsamersoff ! src/share/vm/runtime/dtraceJSDT.cpp Changeset: 91a81502a27d Author: kamg Date: 2012-02-15 00:09 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/91a81502a27d Merge Changeset: 2b150750d53d Author: sspitsyn Date: 2012-02-14 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2b150750d53d 7130993: nsk/jdi/ReferenceType/instances/instances004 fails with JFR: assert(ServiceUtil::visible_oop(obj)) Summary: Skip reporting invisible refs in iterate_over_object to avoid assert(ServiceUtil::visible_oop(obj)) Reviewed-by: dcubed, mgronlun, rbackman Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: cd239a88b90c Author: minqi Date: 2012-02-14 20:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cd239a88b90c Merge Changeset: 64fc5ac1b770 Author: minqi Date: 2012-02-14 23:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/64fc5ac1b770 Merge Changeset: f1cb6f9cfe21 Author: fparain Date: 2012-02-15 12:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f1cb6f9cfe21 7145243: Need additional specializations for argument parsing framework Reviewed-by: acorn, fparain Contributed-by: nils.loodin at oracle.com ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/services/diagnosticArgument.hpp ! src/share/vm/services/diagnosticFramework.cpp ! src/share/vm/services/diagnosticFramework.hpp Changeset: 4a24c4f648bd Author: phh Date: 2012-02-16 13:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4a24c4f648bd 7142113: Add Ivy Bridge to the known Intel x86 cpu families Summary: In vm_version_x86.hpp, add and use CPU_MODEL_IVYBRIDGE_EP, and restrict is_intel_tsc_synced_at_init() to EP models. Reviewed-by: kvn, acorn ! src/cpu/x86/vm/vm_version_x86.hpp Changeset: 7df3125953cb Author: coleenp Date: 2012-02-16 15:52 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7df3125953cb 7146354: Re-enable Compressed OOPs after 7118647 is resolved Summary: Relax the assertion to simply check for COOP mode rather than an exact address. Reviewed-by: coleenp, kvn, phh, dcubed Contributed-by: james.melvin at oracle.com ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/virtualspace.cpp Changeset: df4927a3b82e Author: coleenp Date: 2012-02-16 17:19 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/df4927a3b82e Merge Changeset: d3384450b649 Author: fparain Date: 2012-02-17 06:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d3384450b649 Merge Changeset: 73df3733f2eb Author: kvn Date: 2012-02-10 12:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/73df3733f2eb 7129284: +DoEscapeAnalysis regression w/ early build of 7u4 (HotSpot 23) on Linux Summary: Removed code which tried to create edges from fields of destination objects of arraycopy to fields of source objects. Added 30 sec time limit for EA graph construction. Reviewed-by: never ! src/share/vm/opto/escape.cpp Changeset: de34c646c3f7 Author: kvn Date: 2012-02-10 17:20 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/de34c646c3f7 7140985: HSDIS does not handle caller options correctly Summary: Fix typo. Reviewed-by: jrose, kvn Contributed-by: Andrew Haley ! src/share/tools/hsdis/hsdis.c Changeset: 45a1bf98f1bb Author: twisti Date: 2012-02-13 02:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/45a1bf98f1bb 7141329: Strange values of stack_size in -XX:+TraceMethodHandles output Reviewed-by: kvn, never ! src/cpu/x86/vm/methodHandles_x86.cpp Changeset: f09ae3853e3b Author: twisti Date: 2012-02-13 04:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f09ae3853e3b 7143766: add ALT_JDK_IMAGE_DIR and improve test_jdk Reviewed-by: rbackman, jrose, dholmes ! make/Makefile ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/top.make ! make/defs.make ! make/linux/makefiles/top.make ! make/solaris/makefiles/top.make Changeset: b522995d91f0 Author: roland Date: 2012-02-14 09:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b522995d91f0 7144405: JumbleGC002 assert(m->offset() == pc_offset) failed: oopmap not found Summary: oop map needs pc stored in frame anchor in StubGenerator::generate_throw_exception() Reviewed-by: twisti, never, kvn ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: 8f4eb44b3b76 Author: never Date: 2012-02-14 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8f4eb44b3b76 7143061: nsk/stress/stack/b4525850 crash VM Reviewed-by: kvn, twisti ! src/cpu/x86/vm/globals_x86.hpp Changeset: 80107dc493db Author: roland Date: 2012-02-15 09:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/80107dc493db 7126041: jdk7u4 b05 and b06 crash with RubyMine 3.2.4, works well with b04 Summary: Goto that replaces a If mistaken to be a back branch and triggers erroneous OSR compilation. Reviewed-by: never, iveresov ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: 09d00c18e323 Author: never Date: 2012-02-15 10:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/09d00c18e323 7145537: minor tweaks to LogEvents Reviewed-by: kvn, twisti ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/events.hpp Changeset: cfdfbeac0a5b Author: iveresov Date: 2012-02-15 12:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cfdfbeac0a5b 7145345: Code cache sweeper must cooperate with safepoints Summary: Safepoint in the sweeper loop in necessary Reviewed-by: kvn, never ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp Changeset: 69333a2fbae2 Author: iveresov Date: 2012-02-15 16:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/69333a2fbae2 7142680: default GC affected by jvm path Summary: Removed old tiered code Reviewed-by: never, kvn ! src/share/vm/runtime/arguments.cpp Changeset: fd8114661503 Author: kvn Date: 2012-02-15 21:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fd8114661503 7125136: SIGILL on linux amd64 in gc/ArrayJuggle/Juggle29 Summary: For C2 moved saving EBP after ESP adjustment. For C1 generated 5 byte nop instruction first if needed. Reviewed-by: never, twisti, azeemj ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/output.cpp Changeset: c7401dcad8bf Author: roland Date: 2012-02-16 09:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c7401dcad8bf 7143038: SIGSEGV in assert_equal / LinearScan::assign_reg_num Summary: forced exit may destory global objects that are still in use. Reviewed-by: twisti, never, kvn ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp Changeset: ad3b47344802 Author: never Date: 2012-02-16 11:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ad3b47344802 7144318: GCLocker assert failure: assert(_needs_gc || SafepointSynchronize::is_at_safepoint( Reviewed-by: kvn, twisti ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/gcLocker.inline.hpp Changeset: 9b8ce46870df Author: kvn Date: 2012-02-16 17:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9b8ce46870df 7145346: VerifyStackAtCalls is broken Summary: Replace call_epilog() encoding with macroassembler use. Moved duplicated code to x86.ad. Fixed return_addr() definition. Reviewed-by: never ! src/cpu/x86/vm/x86.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os_cpu/bsd_x86/vm/bsd_x86_32.ad ! src/os_cpu/bsd_x86/vm/bsd_x86_64.ad ! src/os_cpu/linux_x86/vm/linux_x86_32.ad ! src/os_cpu/linux_x86/vm/linux_x86_64.ad ! src/os_cpu/solaris_x86/vm/solaris_x86_32.ad ! src/os_cpu/solaris_x86/vm/solaris_x86_64.ad ! src/os_cpu/windows_x86/vm/windows_x86_32.ad ! src/os_cpu/windows_x86/vm/windows_x86_64.ad ! src/share/vm/opto/chaitin.cpp Changeset: 72c425c46102 Author: never Date: 2012-02-17 12:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/72c425c46102 7146729: nightly failure after 7141200: tty is sometimes null during shutdown of main thread Reviewed-by: kvn ! src/share/vm/utilities/events.hpp Changeset: 15085a6eb50c Author: never Date: 2012-02-17 12:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/15085a6eb50c Merge ! src/cpu/x86/vm/globals_x86.hpp ! src/share/vm/runtime/arguments.cpp Changeset: f92a171cf007 Author: amurillo Date: 2012-02-17 15:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f92a171cf007 Merge Changeset: 98cd09d11a21 Author: amurillo Date: 2012-02-17 15:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/98cd09d11a21 Added tag hs23-b16 for changeset f92a171cf007 ! .hgtags Changeset: 931e5f39e365 Author: kvn Date: 2012-02-20 13:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/931e5f39e365 7147064: assert(allocates2(pc)) failed: not in CodeBuffer memory: 0xffffffff778d9d60 <= 0xffffffff778da69c Summary: Increase size of deopt_blob and uncommon_trap_blob by size of stack bang code (SPARC). Reviewed-by: azeemj, iveresov, never, phh ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp Changeset: 3b24e7e01d20 Author: jcoomes Date: 2012-02-20 22:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3b24e7e01d20 Added tag hs23-b16 for changeset 931e5f39e365 ! .hgtags From lana.steuck at oracle.com Thu Feb 23 05:26:54 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 23 Feb 2012 05:26:54 +0000 Subject: hg: jdk8/tl/jdk: 21 new changesets Message-ID: <20120223053034.269E347650@hg.openjdk.java.net> Changeset: 4196fc971f65 Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4196fc971f65 Added tag jdk8-b26 for changeset 5aca406e87cb ! .hgtags Changeset: 7a5c8c6f1c6b Author: prr Date: 2012-02-03 09:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a5c8c6f1c6b 7141914: Draw glyph cause JVM crash Reviewed-by: bae, igor ! src/share/classes/sun/font/FileFont.java ! src/share/classes/sun/font/StandardGlyphVector.java ! src/share/classes/sun/font/SunFontManager.java ! src/share/classes/sun/font/TrueTypeFont.java Changeset: 996cd6e8d00e Author: lana Date: 2012-02-09 19:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/996cd6e8d00e Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: a06fd6ada85c Author: prr Date: 2012-02-14 14:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a06fd6ada85c 7143612: improve backwards compatibility of OSIS post-CR6887286 Reviewed-by: flar, prr Contributed-by: david.buck at oracle.com ! src/share/classes/sun/awt/image/OffScreenImageSource.java Changeset: 45ce82d366ec Author: anthony Date: 2012-02-02 17:49 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45ce82d366ec 7132194: GtkFileDialog does not point to the correct file(s) is Recent Files are used. Summary: Handle the file list differently if gtk_file_chooser_get_current_folder() returns NULL Reviewed-by: anthony Contributed-by: Matthew Smith ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c Changeset: 10fa63972ad5 Author: rupashka Date: 2012-02-03 17:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/10fa63972ad5 7141573: JProgressBar resize exception, if setStringPainted in Windows LAF Reviewed-by: malenkov ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsProgressBarUI.java + test/javax/swing/JProgressBar/7141573/bug7141573.java Changeset: 34571be262e9 Author: rupashka Date: 2012-02-03 18:01 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/34571be262e9 7071775: javax/swing/JFileChooser/6396844/TwentyThousandTest.java failed on winxp Reviewed-by: alexp ! test/javax/swing/JFileChooser/6396844/TwentyThousandTest.java Changeset: 1880e8cc89b8 Author: rupashka Date: 2012-02-08 16:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1880e8cc89b8 7138665: JOptionPane.getValue() unexpected change between JRE 1.6 and JRE 1.7 Reviewed-by: alexp ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java + test/javax/swing/JOptionPane/7138665/bug7138665.java Changeset: d2e067142112 Author: bagiras Date: 2012-02-08 18:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d2e067142112 7132367: [macosx] ChoiceMouseWheelTest should be adapted for mac toolkit Reviewed-by: art ! test/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java Changeset: d43447758eba Author: rupashka Date: 2012-02-09 14:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d43447758eba 7143857: Memory leak in javax.swing.plaf.synth.SynthTreeUI Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java Changeset: 403e3bb8a162 Author: rupashka Date: 2012-02-09 18:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/403e3bb8a162 7142955: DefaultTreeCellRenderer doesn't honor 'Tree.rendererFillBackground' LAF property Reviewed-by: malenkov ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java + test/javax/swing/tree/DefaultTreeCellRenderer/7142955/bug7142955.java Changeset: a3b50244bd10 Author: chegar Date: 2012-02-10 11:03 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3b50244bd10 7144475: fix some warnings in java.awt, javax.print.attribute.standard, and sun.beans.infos Reviewed-by: chegar, prr, alanb, anthony Contributed-by: Prasannaa , Martijn Verburg , Goerge Albrecht , Graham Allan , Iordanis Giannakakis , Jose Llarena , Abrahamn Marin Perez ! src/share/classes/java/awt/List.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java ! src/share/classes/javax/print/attribute/standard/ReferenceUriSchemesSupported.java ! src/share/classes/sun/beans/infos/ComponentBeanInfo.java Changeset: 55adee49df8e Author: alexsch Date: 2012-02-10 18:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55adee49df8e 7109991: SwingUtilities.isXMouseButton behaves unexpectedly starting from JDK8 b08 Reviewed-by: rupashka ! src/share/classes/java/awt/event/InputEvent.java ! src/share/classes/java/awt/event/MouseEvent.java Changeset: de74d3310e96 Author: lana Date: 2012-02-09 23:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de74d3310e96 Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: 081a44952699 Author: lana Date: 2012-02-10 10:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/081a44952699 Merge Changeset: 3f4701d08418 Author: bagiras Date: 2012-02-13 17:49 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f4701d08418 7143070: test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit Reviewed-by: anthony ! test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java Changeset: a1dc74291966 Author: alexsch Date: 2012-02-14 18:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a1dc74291966 7133577: [macosx] closed/javax/swing/JTree/4314199/bug4314199.java fails on MacOS Reviewed-by: rupashka + test/javax/swing/JTree/4314199/bug4314199.html + test/javax/swing/JTree/4314199/bug4314199.java Changeset: 24e30ae2a192 Author: lana Date: 2012-02-15 15:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/24e30ae2a192 Merge Changeset: 2a3f026b3a29 Author: lana Date: 2012-02-15 15:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a3f026b3a29 Merge - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java - src/share/classes/com/sun/management/DiagnosticCommandInfo.java - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java - test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java Changeset: c68342532e2e Author: lana Date: 2012-02-18 16:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c68342532e2e Merge - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java - src/share/classes/com/sun/management/DiagnosticCommandInfo.java - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java - test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java Changeset: 6a5d6b2800f6 Author: lana Date: 2012-02-22 16:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a5d6b2800f6 Merge From joe.darcy at oracle.com Thu Feb 23 17:53:29 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 23 Feb 2012 17:53:29 +0000 Subject: hg: jdk8/tl/langtools: 7148025: javac should not warn about InterrupttedException on the declaration of AutoCloseable itself Message-ID: <20120223175333.927C347658@hg.openjdk.java.net> Changeset: 3ad851a7e884 Author: darcy Date: 2012-02-23 09:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ad851a7e884 7148025: javac should not warn about InterrupttedException on the declaration of AutoCloseable itself Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java From sean.coffey at oracle.com Fri Feb 24 09:11:01 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Fri, 24 Feb 2012 09:11:01 +0000 Subject: hg: jdk8/tl/jdk: 7133138: Improve io performance around timezone lookups Message-ID: <20120224091125.C4DCC47689@hg.openjdk.java.net> Changeset: a589a8dbde79 Author: coffeys Date: 2012-02-24 09:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a589a8dbde79 7133138: Improve io performance around timezone lookups Reviewed-by: okutsu ! make/tools/src/build/tools/javazic/Mappings.java ! src/share/classes/sun/util/calendar/ZoneInfo.java ! src/share/classes/sun/util/calendar/ZoneInfoFile.java From sean.coffey at oracle.com Fri Feb 24 09:16:34 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Fri, 24 Feb 2012 09:16:34 +0000 Subject: hg: jdk8/tl/jdk: 7144488: Infinite recursion for some equals tests in Collections Message-ID: <20120224091644.B9B114768A@hg.openjdk.java.net> Changeset: 0a350fb8b174 Author: coffeys Date: 2012-02-24 09:17 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a350fb8b174 7144488: Infinite recursion for some equals tests in Collections Reviewed-by: alanb, dholmes, mduigou ! src/share/classes/java/util/Collections.java + test/java/util/Collections/EqualsTest.java From christopher.meyer at rub.de Fri Feb 24 13:31:56 2012 From: christopher.meyer at rub.de (Christopher Meyer) Date: 24 Feb 2012 14:31:56 +0100 Subject: Changeset 5052 a589a8dbde79 question Message-ID: <3124408.7LPvBc21Bb@bender> Hi, please correct me if I'm wrong, but the Changeset 5052 in ZoneInfoFile could maybe draw an unexpected SideChannel at System.err. Please have a look at the following: TimeZone tzExistent = TimeZone.getTimeZone("/.\56/.\56/.\56/etc/passwd"); will walk the following path: java.util.TimeZone: public static synchronized TimeZone getTimeZone(String ID) private static TimeZone getTimeZone(String ID, boolean fallback) private static final TimeZone parseCustomTimeZone(String id) sun.util.calendar.ZoneInfo public static ZoneInfo getZoneInfo(String id) private static ZoneInfo createZoneInfo(String id) private static byte[] readZoneInfoFile(final String fileName) where it is checked if it contains ".." ileName.indexOf("..") >= 0 (which indeed it doesn't) - no more checking at this point, necessary path checks are dropped for the sake of performance. When passed to File file = new File(ziDir, fileName); it will evalute fine to /../../../etc/passwd. Since the operation takes place inside a doPrivileged block the file could be read (if present) without SecurityException, even in an Applet. The attacker would succeed with a directory traversal. No big deal due to this point, since no information is handled to a potential attacker. But when looking at the return path we find the following in private static ZoneInfo createZoneInfo(String id): System.err.println("ZoneInfo: wrong magic number: " + id); or System.err.println("ZoneInfo: incompatible version (" + buf[index - 1] + "): " + id); So if an attacker manages to access System.err (one could think about capabilities of LiveConnect or some related technologies...) he would be able to detect the presence of files on the victims system. This would be clearly a violation of the applet sandbox. In my opinion the impact is not that big, but it increases an attackers surface. Do I miss something or got something wrong or this this an issue that should be fixed? Regards from Germany, Chris Blog on Java security and related topics: armoredbarista.blogspot.com ______________________________________ Dipl.-Ing. Christopher Meyer Horst G?rtz Institute for IT-Security Chair for Network and Data Security Ruhr-University Bochum, Germany Universit?tsstr. 150, ID 2/415 D-44801 Bochum, Germany http:// www.nds.rub.de Phone: (+49) (0)234 / 32 - 29815 Fax: (+49) (0)234 / 32 - 14347 From sean.coffey at oracle.com Fri Feb 24 14:09:28 2012 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Fri, 24 Feb 2012 14:09:28 +0000 Subject: Changeset 5052 a589a8dbde79 question In-Reply-To: <3124408.7LPvBc21Bb@bender> References: <3124408.7LPvBc21Bb@bender> Message-ID: <4F479A18.3020600@oracle.com> thanks for raising this point Chris. we certainly don't want any windows for such an attack. I'll revisit this. regards, Sean. On 24/02/12 13:31, Christopher Meyer wrote: > Hi, > please correct me if I'm wrong, but the Changeset 5052 in ZoneInfoFile could > maybe draw an unexpected SideChannel at System.err. > > Please have a look at the following: > TimeZone tzExistent = TimeZone.getTimeZone("/.\56/.\56/.\56/etc/passwd"); > will walk the following path: > > java.util.TimeZone: > public static synchronized TimeZone getTimeZone(String ID) > private static TimeZone getTimeZone(String ID, boolean fallback) > private static final TimeZone parseCustomTimeZone(String id) > sun.util.calendar.ZoneInfo > public static ZoneInfo getZoneInfo(String id) > private static ZoneInfo createZoneInfo(String id) > private static byte[] readZoneInfoFile(final String fileName) > > where it is checked if it contains ".." > > ileName.indexOf("..")>= 0 > (which indeed it doesn't) - no more checking at this point, necessary path > checks are dropped for the sake of performance. When passed to > > File file = new File(ziDir, fileName); > > it will evalute fine to /../../../etc/passwd. Since the operation takes place > inside a doPrivileged block the file could be read (if present) without > SecurityException, even in an Applet. The attacker would succeed with a > directory traversal. No big deal due to this point, since no information is > handled to a potential attacker. > > But when looking at the return path we find the following in private static > ZoneInfo createZoneInfo(String id): > > System.err.println("ZoneInfo: wrong magic number: " + id); > or > System.err.println("ZoneInfo: incompatible version (" > + buf[index - 1] + "): " + id); > > So if an attacker manages to access System.err (one could think about > capabilities of LiveConnect or some related technologies...) he would be able > to detect the presence of files on the victims system. This would be clearly a > violation of the applet sandbox. > > In my opinion the impact is not that big, but it increases an attackers > surface. > > Do I miss something or got something wrong or this this an issue that should > be fixed? > > Regards from Germany, > Chris > > > Blog on Java security and related topics: > armoredbarista.blogspot.com > > ______________________________________ > > Dipl.-Ing. Christopher Meyer > > Horst G?rtz Institute for IT-Security > Chair for Network and Data Security > Ruhr-University Bochum, Germany > > Universit?tsstr. 150, ID 2/415 > D-44801 Bochum, Germany > http:// www.nds.rub.de > > Phone: (+49) (0)234 / 32 - 29815 > Fax: (+49) (0)234 / 32 - 14347 > > From sean.coffey at oracle.com Fri Feb 24 15:31:06 2012 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Fri, 24 Feb 2012 15:31:06 +0000 Subject: Changeset 5052 a589a8dbde79 question In-Reply-To: <4F479A18.3020600@oracle.com> References: <3124408.7LPvBc21Bb@bender> <4F479A18.3020600@oracle.com> Message-ID: <4F47AD3A.9080104@oracle.com> hold on, the indexOf test will match with those ASCII format chars. i.e "/.\56/.\56/.\56/etc/passwd".indexOf("..") returns 1. Is the fix still ok then ?christopher.meyer at rub.de regards, Sean On 24/02/12 14:09, Se?n Coffey wrote: > thanks for raising this point Chris. > > we certainly don't want any windows for such an attack. I'll revisit > this. > > regards, > Sean. > > On 24/02/12 13:31, Christopher Meyer wrote: >> Hi, >> please correct me if I'm wrong, but the Changeset 5052 in >> ZoneInfoFile could >> maybe draw an unexpected SideChannel at System.err. >> >> Please have a look at the following: >> TimeZone tzExistent = >> TimeZone.getTimeZone("/.\56/.\56/.\56/etc/passwd"); >> will walk the following path: >> >> java.util.TimeZone: >> public static synchronized TimeZone getTimeZone(String ID) >> private static TimeZone getTimeZone(String ID, boolean fallback) >> private static final TimeZone parseCustomTimeZone(String id) >> sun.util.calendar.ZoneInfo >> public static ZoneInfo getZoneInfo(String id) >> private static ZoneInfo createZoneInfo(String id) >> private static byte[] readZoneInfoFile(final String fileName) >> >> where it is checked if it contains ".." >> >> ileName.indexOf("..")>= 0 >> (which indeed it doesn't) - no more checking at this point, necessary >> path >> checks are dropped for the sake of performance. When passed to >> >> File file = new File(ziDir, fileName); >> >> it will evalute fine to /../../../etc/passwd. Since the operation >> takes place >> inside a doPrivileged block the file could be read (if present) without >> SecurityException, even in an Applet. The attacker would succeed with a >> directory traversal. No big deal due to this point, since no >> information is >> handled to a potential attacker. >> >> But when looking at the return path we find the following in private >> static >> ZoneInfo createZoneInfo(String id): >> >> System.err.println("ZoneInfo: wrong magic number: " + id); >> or >> System.err.println("ZoneInfo: incompatible version (" >> + buf[index - 1] + "): " + id); >> >> So if an attacker manages to access System.err (one could think about >> capabilities of LiveConnect or some related technologies...) he would >> be able >> to detect the presence of files on the victims system. This would be >> clearly a >> violation of the applet sandbox. >> >> In my opinion the impact is not that big, but it increases an attackers >> surface. >> >> Do I miss something or got something wrong or this this an issue that >> should >> be fixed? >> >> Regards from Germany, >> Chris >> >> >> Blog on Java security and related topics: >> armoredbarista.blogspot.com >> >> ______________________________________ >> >> Dipl.-Ing. Christopher Meyer >> >> Horst G?rtz Institute for IT-Security >> Chair for Network and Data Security >> Ruhr-University Bochum, Germany >> >> Universit?tsstr. 150, ID 2/415 >> D-44801 Bochum, Germany >> http:// www.nds.rub.de >> >> Phone: (+49) (0)234 / 32 - 29815 >> Fax: (+49) (0)234 / 32 - 14347 >> >> From christopher.meyer at rub.de Fri Feb 24 16:10:38 2012 From: christopher.meyer at rub.de (Christopher Meyer) Date: 24 Feb 2012 17:10:38 +0100 Subject: Changeset 5052 a589a8dbde79 question In-Reply-To: <4F47AD3A.9080104@oracle.com> References: <3124408.7LPvBc21Bb@bender> <4F479A18.3020600@oracle.com> <4F47AD3A.9080104@oracle.com> Message-ID: <2299367.opPH7QAo7B@bender> Hi Se?n, you're absolutely right. That's the thing I missed.... I wasn't aware of the fact that indexOf deals with ASCII format chars. The fix seems to be absolutely ok. In any case, a smart solution to safe operation calls! Sorry for the confusion. Regards, Chris On Friday 24 February 2012 15:31:06 Se?n Coffey wrote: > hold on, > > the indexOf test will match with those ASCII format chars. > > i.e > "/.\56/.\56/.\56/etc/passwd".indexOf("..") returns 1. > > Is the fix still ok then ?christopher.meyer at rub.de > > regards, > Sean > > On 24/02/12 14:09, Se?n Coffey wrote: > > thanks for raising this point Chris. > > > > we certainly don't want any windows for such an attack. I'll revisit > > this. > > > > regards, > > Sean. > > > > On 24/02/12 13:31, Christopher Meyer wrote: > >> Hi, > >> please correct me if I'm wrong, but the Changeset 5052 in > >> ZoneInfoFile could > >> maybe draw an unexpected SideChannel at System.err. > >> > >> Please have a look at the following: > >> TimeZone tzExistent = > >> TimeZone.getTimeZone("/.\56/.\56/.\56/etc/passwd"); > >> will walk the following path: > >> > >> java.util.TimeZone: > >> public static synchronized TimeZone getTimeZone(String ID) > >> private static TimeZone getTimeZone(String ID, boolean fallback) > >> private static final TimeZone parseCustomTimeZone(String id) > >> sun.util.calendar.ZoneInfo > >> public static ZoneInfo getZoneInfo(String id) > >> private static ZoneInfo createZoneInfo(String id) > >> private static byte[] readZoneInfoFile(final String fileName) > >> > >> where it is checked if it contains ".." > >> > >> ileName.indexOf("..")>= 0 > >> (which indeed it doesn't) - no more checking at this point, necessary > >> path > >> checks are dropped for the sake of performance. When passed to > >> > >> File file = new File(ziDir, fileName); > >> > >> it will evalute fine to /../../../etc/passwd. Since the operation > >> takes place > >> inside a doPrivileged block the file could be read (if present) > >> without > >> SecurityException, even in an Applet. The attacker would succeed with > >> a > >> directory traversal. No big deal due to this point, since no > >> information is > >> handled to a potential attacker. > >> > >> But when looking at the return path we find the following in private > >> static > >> ZoneInfo createZoneInfo(String id): > >> > >> System.err.println("ZoneInfo: wrong magic number: " + id); > >> or > >> System.err.println("ZoneInfo: incompatible version (" > >> > >> + > >> > >> b > >> u > >> f > >> [ > >> i > >> n > >> d > >> e > >> x > >> > >> - > >> > >> 1 > >> ] > >> > >> + > >> > >> " > >> ) > >> : > >> > >> " > >> > >> + > >> > >> i > >> d > >> ) > >> ; > >> > >> So if an attacker manages to access System.err (one could think about > >> capabilities of LiveConnect or some related technologies...) he would > >> be able > >> to detect the presence of files on the victims system. This would be > >> clearly a > >> violation of the applet sandbox. > >> > >> In my opinion the impact is not that big, but it increases an > >> attackers > >> surface. > >> > >> Do I miss something or got something wrong or this this an issue that > >> should > >> be fixed? > >> > >> Regards from Germany, > >> Chris > >> > >> > >> Blog on Java security and related topics: > >> armoredbarista.blogspot.com > >> > >> ______________________________________ > >> > >> Dipl.-Ing. Christopher Meyer > >> > >> Horst G?rtz Institute for IT-Security > >> Chair for Network and Data Security > >> Ruhr-University Bochum, Germany > >> > >> Universit?tsstr. 150, ID 2/415 > >> D-44801 Bochum, Germany > >> http:// www.nds.rub.de > >> > >> Phone: (+49) (0)234 / 32 - 29815 > >> Fax: (+49) (0)234 / 32 - 14347 ______________________________________ Dipl.-Ing. Christopher Meyer Horst G?rtz Institute for IT-Security Chair for Network and Data Security Ruhr-University Bochum, Germany Universit?tsstr. 150, ID 2/415 D-44801 Bochum, Germany http:// www.nds.rub.de Phone: (+49) (0)234 / 32 - 29815 Fax: (+49) (0)234 / 32 - 14347 From jonathan.gibbons at oracle.com Fri Feb 24 18:40:46 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 24 Feb 2012 18:40:46 +0000 Subject: hg: jdk8/tl/langtools: 7137836: tidy up Names.java Message-ID: <20120224184049.000AA4769A@hg.openjdk.java.net> Changeset: e6b5c3aff85c Author: jjg Date: 2012-02-24 10:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e6b5c3aff85c 7137836: tidy up Names.java Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/util/Names.java From alan.bateman at oracle.com Sun Feb 26 17:26:47 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 26 Feb 2012 17:26:47 +0000 Subject: hg: jdk8/tl/jdk: 7148921: More ProblemList updates (2/2012) Message-ID: <20120226172716.20F87476C2@hg.openjdk.java.net> Changeset: 434e680b444f Author: alanb Date: 2012-02-26 17:25 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/434e680b444f 7148921: More ProblemList updates (2/2012) Reviewed-by: chegar ! test/ProblemList.txt From weijun.wang at oracle.com Mon Feb 27 03:18:45 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 27 Feb 2012 11:18:45 +0800 Subject: code review request: 7133068: java.security code comments have issues with Accessibility compliance In-Reply-To: <7322998.1329373282934.JavaMail.sbladm@swsblss4-new.central.sun.com> References: <7322998.1329373282934.JavaMail.sbladm@swsblss4-new.central.sun.com> Message-ID: <4F4AF615.7090407@oracle.com> Hi All Please review this code change http://cr.openjdk.java.net/~weijun/7133068/webrev.00/ Basically, for a nice accessibility compliance, a TABLE needs a "summary" attribute, a TH needs an "id", and then a TH needs a "headers" that links to its corresponding TD. (By headers I guess it's because a COLSPAN TD can have multiple corresponding THs). The same patch applies to both JDK 8 and 7u. Thanks Max -------- Original Message -------- Subject: CR 7133068 Updated, P3 java/classes_secu java.security code comments have issues with Accessibility compliance Date: Wed, 15 Feb 2012 23:21:22 -0700 (MST) From: weijun.wang at oracle.com To: yulian.xu at oracle.com, artem.smotrakov at oracle.com, ludmila.shikhvarg at oracle.com, weijun.wang at oracle.com, mala.bankal at oracle.com, nithya.srinivasan at oracle.com, xuelei.fan at oracle.com Sun Confidential: Internal only *Synopsis*: java.security code comments have issues with Accessibility compliance Bugster: http://bt2ws.central.sun.com/loadcr.jnlp?jnlp_url=http://bugster.central.sun.com/&arg=7133068 CrPrint: http://bt2ws.central.sun.com/CrPrint?id=7133068 Monaco: http://monaco.us.oracle.com/detail.jsf?cr=7133068 CR 7133068 changed on Feb 16 2012 by weijun.wang at oracle.com === Field ============ === New Value ============= === Old Value ============= Comments New Note Status 3-Accepted 1-Dispatched ====================== =========================== =========================== *Change Request ID*: 7133068 *Synopsis*: java.security code comments have issues with Accessibility compliance Product: java Category: java Subcategory: classes_security Type: Defect Subtype: Status: 3-Accepted Substatus: Priority: 3-Medium Introduced In Release: Introduced In Build: Responsible Manager: frances.ho at oracle.com Responsible Engineer: weijun.wang at oracle.com Initial Evaluator: jsn-sec-bugs at sun.com Keywords: oghag === *Description* ============================================================ API files for this bug are from packages:api.java.security, api.java.security.acl, api.java.security.cert, api.java.security.interfaces, api.java.security.spec and included in jar available at http://jsqalab.us.oracle.com/results/JDKCompatibility/Accessibility/7u4/b225/jar_files/java_security.jar Accessibility report: http://jsqalab.us.oracle.com/results/JDKCompatibility/Accessibility/7u4/b225/report_files/java_security.htm Tested with 7u4 b225 *** (#1 of 1): 2012-01-25 00:13:36 GMT+00:00 ludmila.shikhvarg at oracle.com === *Public Comments* ======================================================== === *Comments* =============================================================== This seems to be a false alarm: http://oac-v2.us.oracle.com/report.jsp?p_action=URLRun&p_urlrunid=25780113 The link here is . Looks like the validator mistakenly treated it as a skipping repetitive navigation link because there is a word "skip" in the link. *** (#1 of 1): 2012-02-16 06:10:52 GMT+00:00 weijun.wang at oracle.com === *Evaluation* ============================================================= === *Suggested Fix* ========================================================== === *Workaround* ============================================================= === *Justification* ========================================================== Priority changed from [] to [3-Medium] java.security code comments have issues with Accessibility compliance ludmila.shikhvarg at oracle.com 2012-01-25 00:13:36 GMT *** (#1 of 1): 2012-01-25 00:13:36 GMT+00:00 ludmila.shikhvarg at oracle.com === *Additional Details* ===================================================== Targeted Release: Commit To Fix In Build: Fixed In Build: Integrated In Build: Verified In Build: See Also: Duplicate of: Hooks: Hook1: Hook2: Hook3: Hook4: Hook5: Hook6: Interest List: Program Management: Root Cause: Is a Security Vulnerability?: No Fix Affects Documentation: No Fix Affects Localization: No Reported by: === *History* ================================================================ Date Submitted: 2012-01-25 00:13:36 GMT+00:00 Submitted By: ludmila.shikhvarg at oracle.com Status Changed Date Updated Updated By 3-Accepted 2012-02-16 06:11:01 GMT+00:00 weijun.wang at oracle.com === *Solution* =============================================================== === *Service Request* ======================================================== ID: 1-787886406 Customer: Account Name: Oracle Corporation Customer Contact: javase-sqe Customer Contact Role: S-System Test Customer Contact Type: I-Internal (SMI) Customer Impact: Significant Functionality: Secondary Severity: 3 Synopsis: Product Name: java Product Release: 7u4 Product Build: Operating System: generic Hardware: generic Reference Number: Sun Contact: ludmila.shikhvarg at oracle.com Status: Open Source: BugTraq2 Reproducible: Submitted By: ludmila.shikhvarg at oracle.com Submitted Date: 2012-01-25 00:13:36 GMT+00:00 Description: === *Activity* =============================================================== === *Multiple Release (MR) Cluster* - 0 ====================================== === *Escalations* ============================================================ From weijun.wang at oracle.com Mon Feb 27 07:00:15 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 27 Feb 2012 15:00:15 +0800 Subject: code review request: 7149012: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp In-Reply-To: <17630768.1330324887119.JavaMail.sbladm@swsblss4-new.central.sun.com> References: <17630768.1330324887119.JavaMail.sbladm@swsblss4-new.central.sun.com> Message-ID: <4F4B29FF.2030309@oracle.com> Hi All Please take a look at this code change: http://cr.openjdk.java.net/~weijun/7149012/webrev.00/ Jarsigner will not print a warning if the signer cert is expired but a timestamp shows the jar was signed before the expiration date. Another change is that the chainNotValidated flag now does not cover hasExpiredCert and notYetValidCert anymore. The result is that when trying to sign (or verify) with an expired cert, instead of the duplicated and somewhat confusing The signer certificate has expired. The signer's certificate chain is not validated. warnings, user will only see The signer certificate has expired. User will still see the chainNotValidated warning if the CertPath is not validated because of other reasons. On the other hand, since these 3 flags share the same exit code (4), users will not notice the exit code change when -strict is on. There is no regression test added to the openjdk repository because it's not easy to generate a timestamp with an old date. I have found an old signed jar with a timestamp and signed by a now-expired cert. I will include these binary files into the jdk/test/closed repository and the test is a simple "jarsigner -verify -strict" call. Thanks Max -------- Original Message -------- *Change Request ID*: 7149012 *Synopsis*: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp === *Description* ============================================================ If the cert used to sign a jar is expired, jarsigner will print out a warning, and if -strict is specified, exits with an error. However, if there is a TSA timestamp attached to the jar (and the timestamp is shown to be before the expiration), it's completely valid and jarsigner should not report any warning or error. From sean.mullan at oracle.com Mon Feb 27 16:35:52 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 27 Feb 2012 11:35:52 -0500 Subject: Code Review Request, 7147830: NullPointerException in java.security.Policy.implies() ... Message-ID: <4F4BB0E8.7090506@oracle.com> Hi Vinnie, Could you review the following trivial fix for 7147830: NullPointerException in java.security.Policy.implies() when the ProtectionDomain has a null code sou webrev: http://cr.openjdk.java.net/~mullan/webrevs/7147830/webrev.00/ Thanks, Sean From vincent.x.ryan at oracle.com Mon Feb 27 16:34:49 2012 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Mon, 27 Feb 2012 16:34:49 +0000 Subject: Code Review Request, 7147830: NullPointerException in java.security.Policy.implies() ... In-Reply-To: <4F4BB0E8.7090506@oracle.com> References: <4F4BB0E8.7090506@oracle.com> Message-ID: <4F4BB0A9.5010304@oracle.com> Fix looks good. On 02/27/12 04:35 PM, Sean Mullan wrote: > Hi Vinnie, > > Could you review the following trivial fix for 7147830: NullPointerException in > java.security.Policy.implies() when the ProtectionDomain has a null code sou > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/7147830/webrev.00/ > > Thanks, > Sean From sean.mullan at oracle.com Mon Feb 27 18:51:45 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Mon, 27 Feb 2012 18:51:45 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20120227185215.8C0DA476D6@hg.openjdk.java.net> Changeset: 805fc337bbe8 Author: mullan Date: 2012-02-27 11:44 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/805fc337bbe8 7147830: NullPointerException in java.security.Policy.implies() when the ProtectionDomain has a null code sou Reviewed-by: vinnie ! src/share/classes/sun/security/provider/PolicyFile.java + test/sun/security/provider/PolicyFile/NullCodeSource.java Changeset: cdf6184a7d5c Author: mullan Date: 2012-02-27 13:53 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdf6184a7d5c Merge From staffan.larsen at oracle.com Fri Feb 24 19:06:28 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 24 Feb 2012 19:06:28 +0000 Subject: hg: jdk8/tl/jdk: 7073626: RmiBootstrapTest.sh and RmiSslBootstrapTest.sh fail under Cygwin Message-ID: <20120224190646.BA9E74769B@hg.openjdk.java.net> Changeset: 585f2c72d042 Author: sla Date: 2012-02-24 20:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/585f2c72d042 7073626: RmiBootstrapTest.sh and RmiSslBootstrapTest.sh fail under Cygwin Summary: Detect and handle cygwin correctly Reviewed-by: alanb, sspitsyn ! test/ProblemList.txt ! test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh From staffan.larsen at oracle.com Fri Feb 24 19:09:54 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 24 Feb 2012 19:09:54 +0000 Subject: hg: jdk8/tl/jdk: 7079093: TEST_BUG: java/lang/instrument/ManifestTest.sh fails with cygwin Message-ID: <20120224191004.765204769C@hg.openjdk.java.net> Changeset: 4893a89b4916 Author: sla Date: 2012-02-24 20:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4893a89b4916 7079093: TEST_BUG: java/lang/instrument/ManifestTest.sh fails with cygwin Summary: Work around problems in some cygwin installations Reviewed-by: alanb, sspitsyn ! test/ProblemList.txt ! test/java/lang/instrument/ManifestTest.sh From dmitriy.samersoff at oracle.com Mon Feb 27 11:21:51 2012 From: dmitriy.samersoff at oracle.com (dmitriy.samersoff at oracle.com) Date: Mon, 27 Feb 2012 11:21:51 +0000 Subject: hg: jdk8/tl/jdk: 7110104: It should be possible to stop and start JMX Agent at runtime Message-ID: <20120227112243.C879E476CF@hg.openjdk.java.net> Changeset: 1e737abbff6f Author: dsamersoff Date: 2012-02-27 15:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e737abbff6f 7110104: It should be possible to stop and start JMX Agent at runtime Summary: Added a capability to start and stop JMX Agent by jcmd Reviewed-by: acorn, mchung ! src/share/classes/sun/management/Agent.java ! src/share/classes/sun/management/AgentConfigurationError.java ! src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java ! src/share/classes/sun/management/resources/agent.properties ! test/sun/management/AgentCheckTest.java + test/sun/management/jmxremote/startstop/JMXStartStopDoSomething.java + test/sun/management/jmxremote/startstop/JMXStartStopTest.java + test/sun/management/jmxremote/startstop/JMXStartStopTest.sh + test/sun/management/jmxremote/startstop/REMOTE_TESTING.txt + test/sun/management/jmxremote/startstop/management_cl.properties + test/sun/management/jmxremote/startstop/management_jcmd.properties From mike.duigou at oracle.com Tue Feb 28 02:20:50 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 28 Feb 2012 02:20:50 +0000 Subject: hg: jdk8/tl/jdk: 7143162: Allow disable building of jdk demos and samples Message-ID: <20120228022101.E996C476D9@hg.openjdk.java.net> Changeset: 323abe0e8973 Author: mduigou Date: 2012-02-27 18:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/323abe0e8973 7143162: Allow disable building of jdk demos and samples Reviewed-by: ohair ! make/Makefile ! make/common/Release.gmk ! make/common/shared/Sanity-Settings.gmk From mike.duigou at oracle.com Tue Feb 28 02:22:59 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 28 Feb 2012 02:22:59 +0000 Subject: hg: jdk8/tl: 7143162: Allow disable building of jdk demos and samples Message-ID: <20120228022259.4B308476DA@hg.openjdk.java.net> Changeset: 28f2fe471725 Author: mduigou Date: 2012-02-27 18:09 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/28f2fe471725 7143162: Allow disable building of jdk demos and samples Reviewed-by: ohair ! make/sanity-rules.gmk From Xuelei.Fan at Oracle.Com Tue Feb 28 14:11:49 2012 From: Xuelei.Fan at Oracle.Com (Xuelei Fan) Date: Tue, 28 Feb 2012 06:11:49 -0800 Subject: code review request: 7149012: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp In-Reply-To: <4F4B29FF.2030309@oracle.com> References: <17630768.1330324887119.JavaMail.sbladm@swsblss4-new.central.sun.com> <4F4B29FF.2030309@oracle.com> Message-ID: I have not read the changes, just some minor comments about the description. On Feb 26, 2012, at 11:00 PM, Weijun Wang wrote: > Hi All > > Please take a look at this code change: > > http://cr.openjdk.java.net/~weijun/7149012/webrev.00/ > > Jarsigner will not print a warning if the signer cert is expired but a timestamp shows the jar was signed before the expiration date. > > Another change is that the chainNotValidated flag now does not cover hasExpiredCert and notYetValidCert anymore. The result is that when trying to sign (or verify) with an expired cert, instead of the duplicated and somewhat confusing > > The signer certificate has expired. > The signer's certificate chain is not validated. > > warnings, user will only see > > The signer certificate has expired. > It seems that we allow the singer sigh jars with expired certificate. It's flexible, but as may not comply to the policy of certificate authority. At most of the time, CA will not take any responsibility to expired certificate. I know the compatibility may be the concerns, but I really think we should forbid the sign behaviors by default, and allow the verification behaviors by default if time stamped. Xuelei > User will still see the chainNotValidated warning if the CertPath is not validated because of other reasons. > > On the other hand, since these 3 flags share the same exit code (4), users will not notice the exit code change when -strict is on. > > There is no regression test added to the openjdk repository because it's not easy to generate a timestamp with an old date. I have found an old signed jar with a timestamp and signed by a now-expired cert. I will include these binary files into the jdk/test/closed repository and the test is a simple "jarsigner -verify -strict" call. > > Thanks > Max > > -------- Original Message -------- > *Change Request ID*: 7149012 > > *Synopsis*: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp > > === *Description* ============================================================ > If the cert used to sign a jar is expired, jarsigner will print out a warning, and if -strict is specified, exits with an error. However, if there is a TSA timestamp attached to the jar (and the timestamp is shown to be before the expiration), it's completely valid and jarsigner should not report any warning or error. > From weijun.wang at oracle.com Tue Feb 28 14:19:22 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 28 Feb 2012 22:19:22 +0800 Subject: code review request: 7149012: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp In-Reply-To: References: <17630768.1330324887119.JavaMail.sbladm@swsblss4-new.central.sun.com> <4F4B29FF.2030309@oracle.com> Message-ID: <4F4CE26A.2020506@oracle.com> Hi Andrew Well, this code change is to make jarsigner behaviors to be consistent with Java Plugin, that is to say, if Java Plugin allows something jarsigner should also. If you believe that Java Plugin's behavior itself is problematic, we can suspend this code change for a while and focus on Java Plugin. Thanks Max On 02/28/2012 10:11 PM, Xuelei Fan wrote: > I have not read the changes, just some minor comments about the description. > > On Feb 26, 2012, at 11:00 PM, Weijun Wang wrote: > >> Hi All >> >> Please take a look at this code change: >> >> http://cr.openjdk.java.net/~weijun/7149012/webrev.00/ >> >> Jarsigner will not print a warning if the signer cert is expired but a timestamp shows the jar was signed before the expiration date. >> >> Another change is that the chainNotValidated flag now does not cover hasExpiredCert and notYetValidCert anymore. The result is that when trying to sign (or verify) with an expired cert, instead of the duplicated and somewhat confusing >> >> The signer certificate has expired. >> The signer's certificate chain is not validated. >> >> warnings, user will only see >> >> The signer certificate has expired. >> > It seems that we allow the singer sigh jars with expired certificate. It's flexible, but as may not comply to the policy of certificate authority. At most of the time, CA will not take any responsibility to expired certificate. I know the compatibility may be the concerns, but I really think we should forbid the sign behaviors by default, and allow the verification behaviors by default if time stamped. > > Xuelei > >> User will still see the chainNotValidated warning if the CertPath is not validated because of other reasons. >> >> On the other hand, since these 3 flags share the same exit code (4), users will not notice the exit code change when -strict is on. >> >> There is no regression test added to the openjdk repository because it's not easy to generate a timestamp with an old date. I have found an old signed jar with a timestamp and signed by a now-expired cert. I will include these binary files into the jdk/test/closed repository and the test is a simple "jarsigner -verify -strict" call. >> >> Thanks >> Max >> >> -------- Original Message -------- >> *Change Request ID*: 7149012 >> >> *Synopsis*: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp >> >> === *Description* ============================================================ >> If the cert used to sign a jar is expired, jarsigner will print out a warning, and if -strict is specified, exits with an error. However, if there is a TSA timestamp attached to the jar (and the timestamp is shown to be before the expiration), it's completely valid and jarsigner should not report any warning or error. >> From Xuelei.Fan at Oracle.Com Tue Feb 28 14:29:31 2012 From: Xuelei.Fan at Oracle.Com (Xuelei Fan) Date: Tue, 28 Feb 2012 06:29:31 -0800 Subject: code review request: 7149012: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp In-Reply-To: <4F4CE26A.2020506@oracle.com> References: <17630768.1330324887119.JavaMail.sbladm@swsblss4-new.central.sun.com> <4F4B29FF.2030309@oracle.com> <4F4CE26A.2020506@oracle.com> Message-ID: <828796F8-E43F-4DBD-98ED-8915D28CD54D@Oracle.Com> On Feb 28, 2012, at 6:19 AM, Weijun Wang wrote: > Hi Andrew > > Well, this code change is to make jarsigner behaviors to be consistent with Java Plugin, that is to say, if Java Plugin allows something jarsigner should also. > > If you believe that Java Plugin's behavior itself is problematic, we can suspend this code change for a while and focus on Java Plugin. > Please don't. My previous comment only a suggestion to rethink about the signer's behaviors. It may be a potential enhancement. Please go on with the bug fix. BTW, I thought java plugin only do validation. It also do jobs to sign something, is it? Thanks, Xuelei > Thanks > Max > > On 02/28/2012 10:11 PM, Xuelei Fan wrote: >> I have not read the changes, just some minor comments about the description. >> >> On Feb 26, 2012, at 11:00 PM, Weijun Wang wrote: >> >>> Hi All >>> >>> Please take a look at this code change: >>> >>> http://cr.openjdk.java.net/~weijun/7149012/webrev.00/ >>> >>> Jarsigner will not print a warning if the signer cert is expired but a timestamp shows the jar was signed before the expiration date. >>> >>> Another change is that the chainNotValidated flag now does not cover hasExpiredCert and notYetValidCert anymore. The result is that when trying to sign (or verify) with an expired cert, instead of the duplicated and somewhat confusing >>> >>> The signer certificate has expired. >>> The signer's certificate chain is not validated. >>> >>> warnings, user will only see >>> >>> The signer certificate has expired. >>> >> It seems that we allow the singer sigh jars with expired certificate. It's flexible, but as may not comply to the policy of certificate authority. At most of the time, CA will not take any responsibility to expired certificate. I know the compatibility may be the concerns, but I really think we should forbid the sign behaviors by default, and allow the verification behaviors by default if time stamped. >> >> Xuelei >> >>> User will still see the chainNotValidated warning if the CertPath is not validated because of other reasons. >>> >>> On the other hand, since these 3 flags share the same exit code (4), users will not notice the exit code change when -strict is on. >>> >>> There is no regression test added to the openjdk repository because it's not easy to generate a timestamp with an old date. I have found an old signed jar with a timestamp and signed by a now-expired cert. I will include these binary files into the jdk/test/closed repository and the test is a simple "jarsigner -verify -strict" call. >>> >>> Thanks >>> Max >>> >>> -------- Original Message -------- >>> *Change Request ID*: 7149012 >>> >>> *Synopsis*: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp >>> >>> === *Description* ============================================================ >>> If the cert used to sign a jar is expired, jarsigner will print out a warning, and if -strict is specified, exits with an error. However, if there is a TSA timestamp attached to the jar (and the timestamp is shown to be before the expiration), it's completely valid and jarsigner should not report any warning or error. >>> From weijun.wang at oracle.com Tue Feb 28 14:43:42 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 28 Feb 2012 22:43:42 +0800 Subject: code review request: 7149012: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp In-Reply-To: <828796F8-E43F-4DBD-98ED-8915D28CD54D@Oracle.Com> References: <17630768.1330324887119.JavaMail.sbladm@swsblss4-new.central.sun.com> <4F4B29FF.2030309@oracle.com> <4F4CE26A.2020506@oracle.com> <828796F8-E43F-4DBD-98ED-8915D28CD54D@Oracle.Com> Message-ID: <4F4CE81E.5050902@oracle.com> On 02/28/2012 10:29 PM, Xuelei Fan wrote: > On Feb 28, 2012, at 6:19 AM, Weijun Wang wrote: > >> Hi Andrew >> >> Well, this code change is to make jarsigner behaviors to be consistent with Java Plugin, that is to say, if Java Plugin allows something jarsigner should also. >> >> If you believe that Java Plugin's behavior itself is problematic, we can suspend this code change for a while and focus on Java Plugin. >> > Please don't. My previous comment only a suggestion to rethink about the signer's behaviors. It may be a potential enhancement. Please go on with the bug fix. > > BTW, I thought java plugin only do validation. It also do jobs to sign something, is it? No, it does not sign. My fix is also mainly on verification side of jarsigner. -Max > > Thanks, > Xuelei > >> Thanks >> Max >> >> On 02/28/2012 10:11 PM, Xuelei Fan wrote: >>> I have not read the changes, just some minor comments about the description. >>> >>> On Feb 26, 2012, at 11:00 PM, Weijun Wang wrote: >>> >>>> Hi All >>>> >>>> Please take a look at this code change: >>>> >>>> http://cr.openjdk.java.net/~weijun/7149012/webrev.00/ >>>> >>>> Jarsigner will not print a warning if the signer cert is expired but a timestamp shows the jar was signed before the expiration date. >>>> >>>> Another change is that the chainNotValidated flag now does not cover hasExpiredCert and notYetValidCert anymore. The result is that when trying to sign (or verify) with an expired cert, instead of the duplicated and somewhat confusing >>>> >>>> The signer certificate has expired. >>>> The signer's certificate chain is not validated. >>>> >>>> warnings, user will only see >>>> >>>> The signer certificate has expired. >>>> >>> It seems that we allow the singer sigh jars with expired certificate. It's flexible, but as may not comply to the policy of certificate authority. At most of the time, CA will not take any responsibility to expired certificate. I know the compatibility may be the concerns, but I really think we should forbid the sign behaviors by default, and allow the verification behaviors by default if time stamped. >>> >>> Xuelei >>> >>>> User will still see the chainNotValidated warning if the CertPath is not validated because of other reasons. >>>> >>>> On the other hand, since these 3 flags share the same exit code (4), users will not notice the exit code change when -strict is on. >>>> >>>> There is no regression test added to the openjdk repository because it's not easy to generate a timestamp with an old date. I have found an old signed jar with a timestamp and signed by a now-expired cert. I will include these binary files into the jdk/test/closed repository and the test is a simple "jarsigner -verify -strict" call. >>>> >>>> Thanks >>>> Max >>>> >>>> -------- Original Message -------- >>>> *Change Request ID*: 7149012 >>>> >>>> *Synopsis*: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp >>>> >>>> === *Description* ============================================================ >>>> If the cert used to sign a jar is expired, jarsigner will print out a warning, and if -strict is specified, exits with an error. However, if there is a TSA timestamp attached to the jar (and the timestamp is shown to be before the expiration), it's completely valid and jarsigner should not report any warning or error. >>>> From sean.mullan at oracle.com Tue Feb 28 15:04:56 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 28 Feb 2012 10:04:56 -0500 Subject: code review request: 7133068: java.security code comments have issues with Accessibility compliance In-Reply-To: <4F4AF615.7090407@oracle.com> References: <7322998.1329373282934.JavaMail.sbladm@swsblss4-new.central.sun.com> <4F4AF615.7090407@oracle.com> Message-ID: <4F4CED18.8080806@oracle.com> Looks ok to me but I'm also copying Sowmya to see if she could review this. Thanks, Sean On 2/26/12 10:18 PM, Weijun Wang wrote: > Hi All > > Please review this code change > > http://cr.openjdk.java.net/~weijun/7133068/webrev.00/ > > Basically, for a nice accessibility compliance, a TABLE needs a > "summary" attribute, a TH needs an "id", and then a TH needs a "headers" > that links to its corresponding TD. (By headers I guess it's because a > COLSPAN TD can have multiple corresponding THs). > > The same patch applies to both JDK 8 and 7u. > > Thanks > Max > > > -------- Original Message -------- > Subject: CR 7133068 Updated, P3 java/classes_secu java.security code > comments have issues with Accessibility compliance > Date: Wed, 15 Feb 2012 23:21:22 -0700 (MST) > From: weijun.wang at oracle.com > To: yulian.xu at oracle.com, artem.smotrakov at oracle.com, > ludmila.shikhvarg at oracle.com, weijun.wang at oracle.com, > mala.bankal at oracle.com, nithya.srinivasan at oracle.com, > xuelei.fan at oracle.com > > Sun Confidential: Internal only > > *Synopsis*: java.security code comments have issues with Accessibility > compliance > > Bugster: > http://bt2ws.central.sun.com/loadcr.jnlp?jnlp_url=http://bugster.central.sun.com/&arg=7133068 > CrPrint: http://bt2ws.central.sun.com/CrPrint?id=7133068 > Monaco: http://monaco.us.oracle.com/detail.jsf?cr=7133068 > > CR 7133068 changed on Feb 16 2012 by weijun.wang at oracle.com > > === Field ============ === New Value ============= === Old Value > ============= > > Comments New Note > > Status 3-Accepted 1-Dispatched > > ====================== =========================== > =========================== > > > *Change Request ID*: 7133068 > > *Synopsis*: java.security code comments have issues with Accessibility > compliance > > Product: java > Category: java > Subcategory: classes_security > Type: Defect > Subtype: > Status: 3-Accepted > Substatus: > Priority: 3-Medium > Introduced In Release: > Introduced In Build: > Responsible Manager: frances.ho at oracle.com > Responsible Engineer: weijun.wang at oracle.com > Initial Evaluator: jsn-sec-bugs at sun.com > Keywords: oghag > > === *Description* > ============================================================ > API files for this bug are from packages:api.java.security, > api.java.security.acl, api.java.security.cert, > api.java.security.interfaces, api.java.security.spec and included in jar > available at > http://jsqalab.us.oracle.com/results/JDKCompatibility/Accessibility/7u4/b225/jar_files/java_security.jar > Accessibility report: > http://jsqalab.us.oracle.com/results/JDKCompatibility/Accessibility/7u4/b225/report_files/java_security.htm > > Tested with 7u4 b225 > > *** (#1 of 1): 2012-01-25 00:13:36 GMT+00:00 ludmila.shikhvarg at oracle.com > > > === *Public Comments* > ======================================================== > > === *Comments* > =============================================================== > This seems to be a false alarm: > > > http://oac-v2.us.oracle.com/report.jsp?p_action=URLRun&p_urlrunid=25780113 > > The link here is href="../../java/io/FilterInputStream.html#skip(long)">. Looks like the > validator mistakenly treated it as a skipping repetitive navigation link > because there is a word "skip" in the link. > > *** (#1 of 1): 2012-02-16 06:10:52 GMT+00:00 weijun.wang at oracle.com > > > === *Evaluation* > ============================================================= > > === *Suggested Fix* > ========================================================== > > === *Workaround* > ============================================================= > > === *Justification* > ========================================================== > Priority changed from [] to [3-Medium] > java.security code comments have issues with Accessibility compliance > ludmila.shikhvarg at oracle.com 2012-01-25 00:13:36 GMT > > *** (#1 of 1): 2012-01-25 00:13:36 GMT+00:00 ludmila.shikhvarg at oracle.com > > > === *Additional Details* > ===================================================== > Targeted Release: > Commit To Fix In Build: > Fixed In Build: > Integrated In Build: > Verified In Build: > See Also: > Duplicate of: > Hooks: > Hook1: > Hook2: > Hook3: > Hook4: > Hook5: > Hook6: > Interest List: > Program Management: > Root Cause: > Is a Security Vulnerability?: No > Fix Affects Documentation: No > Fix Affects Localization: No > Reported by: > > === *History* > ================================================================ > Date Submitted: 2012-01-25 00:13:36 GMT+00:00 > Submitted By: ludmila.shikhvarg at oracle.com > > Status Changed Date Updated Updated By > 3-Accepted 2012-02-16 06:11:01 GMT+00:00 > weijun.wang at oracle.com > > > === *Solution* > =============================================================== > > > === *Service Request* > ======================================================== > ID: 1-787886406 > Customer: > Account Name: Oracle Corporation > Customer Contact: javase-sqe > Customer Contact Role: S-System Test > Customer Contact Type: I-Internal (SMI) Customer > Impact: Significant > Functionality: Secondary > Severity: 3 > Synopsis: > Product Name: java > Product Release: 7u4 > Product Build: > Operating System: generic > Hardware: generic > Reference Number: > Sun Contact: ludmila.shikhvarg at oracle.com > Status: Open > Source: BugTraq2 > Reproducible: > Submitted By: ludmila.shikhvarg at oracle.com > Submitted Date: 2012-01-25 00:13:36 GMT+00:00 > Description: > > > === *Activity* > =============================================================== > > > === *Multiple Release (MR) Cluster* - 0 > ====================================== > > > === *Escalations* > ============================================================ > From chris.hegarty at oracle.com Tue Feb 28 16:21:36 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 28 Feb 2012 16:21:36 +0000 Subject: CR 7149144 - rt.jar: missing sun.security.x509.X500Signer class In-Reply-To: <4F4CFF3C.40507@oracle.com> References: <4F4CFBBA.2090007@oracle.com> <4F4CFF3C.40507@oracle.com> Message-ID: <4F4CFF10.9000707@oracle.com> [cc'ing security-dev at o.j.n, they may be able to suggest a suitable alternative, supported, API to use]. -Chris. On 02/28/12 04:22 PM, Se?n Coffey wrote: > The issue would lie with the OpenDS team then. They need to update their > code and use supported JDK APIs. > > regards, > Sean. > > On 28/02/2012 16:10, Lindner, B?rbel wrote: >> sun.security.x509.x500Signer is used from OpenDS (our version is >> v2.2.0). That is one reason that OpenDS is not runnable with JRE7. >> >> Regards >> Baerbel >> >> -----Original Message----- >> From: Se?n Coffey [mailto:sean.coffey at oracle.com] >> Sent: Dienstag, 28. Februar 2012 17:07 >> To: Lindner, B?rbel >> Cc: jdk7u-dev at openjdk.java.net >> Subject: Re: CR 7149144 - rt.jar: missing sun.security.x509.X500Signer >> class >> >> See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6876158 >> >> sun.security.x509 package is JRE private and should not be used by 3rd >> party applications. >> >> regards, >> Sean. >> >> On 28/02/2012 15:38, Lindner, B?rbel wrote: >>> Please readd class "sun.security.x509.X500Signer" in rt.jar. The >>> class was available in JRE 1.6 rt.jar. >>> >>> Thanks >>> Baerbel >>> -- >>> Baerbel Lindner >>> Fujitsu Technology Solutions >>> >>> >>> From sean.mullan at oracle.com Tue Feb 28 16:54:52 2012 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 28 Feb 2012 11:54:52 -0500 Subject: CR 7149144 - rt.jar: missing sun.security.x509.X500Signer class In-Reply-To: <4F4CFF10.9000707@oracle.com> References: <4F4CFBBA.2090007@oracle.com> <4F4CFF3C.40507@oracle.com> <4F4CFF10.9000707@oracle.com> Message-ID: <4F4D06DC.1030102@oracle.com> On 2/28/12 11:21 AM, Chris Hegarty wrote: > [cc'ing security-dev at o.j.n, they may be able to suggest a suitable > alternative, supported, API to use]. I would recommend they implement the functionality entirely in the OpenDS product. X500Signer is a very simple class and can be implemented using the existing java.security.Signature and javax.security.auth.x500.X500Principal classes. --Sean > > -Chris. > > On 02/28/12 04:22 PM, Se?n Coffey wrote: >> The issue would lie with the OpenDS team then. They need to update their >> code and use supported JDK APIs. >> >> regards, >> Sean. >> >> On 28/02/2012 16:10, Lindner, B?rbel wrote: >>> sun.security.x509.x500Signer is used from OpenDS (our version is >>> v2.2.0). That is one reason that OpenDS is not runnable with JRE7. >>> >>> Regards >>> Baerbel >>> >>> -----Original Message----- >>> From: Se?n Coffey [mailto:sean.coffey at oracle.com] >>> Sent: Dienstag, 28. Februar 2012 17:07 >>> To: Lindner, B?rbel >>> Cc: jdk7u-dev at openjdk.java.net >>> Subject: Re: CR 7149144 - rt.jar: missing sun.security.x509.X500Signer >>> class >>> >>> See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6876158 >>> >>> sun.security.x509 package is JRE private and should not be used by 3rd >>> party applications. >>> >>> regards, >>> Sean. >>> >>> On 28/02/2012 15:38, Lindner, B?rbel wrote: >>>> Please readd class "sun.security.x509.X500Signer" in rt.jar. The >>>> class was available in JRE 1.6 rt.jar. >>>> >>>> Thanks >>>> Baerbel >>>> -- >>>> Baerbel Lindner >>>> Fujitsu Technology Solutions >>>> >>>> >>>> From dmitriy.samersoff at oracle.com Tue Feb 28 13:04:12 2012 From: dmitriy.samersoff at oracle.com (dmitriy.samersoff at oracle.com) Date: Tue, 28 Feb 2012 13:04:12 +0000 Subject: hg: jdk8/tl/jdk: 7149181: sun/management/jmxremote/startstop/JMXStartStopTest.sh failing on all platforms Message-ID: <20120228130438.7119F476E2@hg.openjdk.java.net> Changeset: c0a5140c641c Author: dsamersoff Date: 2012-02-28 17:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0a5140c641c 7149181: sun/management/jmxremote/startstop/JMXStartStopTest.sh failing on all platforms Summary: Disable test until JDK and hotspot changes meet each other. Reviewed-by: alanb, acorn ! test/ProblemList.txt From jonathan.gibbons at oracle.com Tue Feb 28 18:26:38 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 28 Feb 2012 18:26:38 +0000 Subject: hg: jdk8/tl/langtools: 7144951: fix minor javadoc issues Message-ID: <20120228182643.4D8E7476E5@hg.openjdk.java.net> Changeset: c4d6a8884ed8 Author: jjg Date: 2012-02-28 10:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c4d6a8884ed8 7144951: fix minor javadoc issues Reviewed-by: darcy ! src/share/classes/com/sun/source/tree/MemberReferenceTree.java ! src/share/classes/com/sun/tools/doclets/package.html From jonathan.gibbons at oracle.com Tue Feb 28 18:34:17 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 28 Feb 2012 18:34:17 +0000 Subject: hg: jdk8/tl/langtools: 7093891: support multiple task listeners Message-ID: <20120228183419.3A7AF476E6@hg.openjdk.java.net> Changeset: 62e611704863 Author: jjg Date: 2012-02-28 10:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/62e611704863 7093891: support multiple task listeners Reviewed-by: darcy, mcimadamore ! src/share/classes/com/sun/source/util/JavacTask.java + src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java + src/share/classes/com/sun/tools/javac/api/MultiTaskListener.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/api/taskListeners/TestSimpleAddRemove.java ! test/tools/javac/processing/loader/testClose/TestClose.java From jonathan.gibbons at oracle.com Tue Feb 28 18:48:24 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 28 Feb 2012 18:48:24 +0000 Subject: hg: jdk8/tl/langtools: 7147183: test/tools/javac/apt.sh can be removed from tl/langtools repository Message-ID: <20120228184826.F249C476E7@hg.openjdk.java.net> Changeset: 6b86f7274c0a Author: jjg Date: 2012-02-28 10:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6b86f7274c0a 7147183: test/tools/javac/apt.sh can be removed from tl/langtools repository Reviewed-by: jjg Contributed-by: sonali.goel at oracle.com - test/tools/javac/apt.sh From joe.darcy at oracle.com Tue Feb 28 21:15:01 2012 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 28 Feb 2012 21:15:01 +0000 Subject: hg: jdk8/tl/jdk: 7149626: (reflect) Improve javadoc of java.lang.reflect.Executable Message-ID: <20120228211510.AFF94476F3@hg.openjdk.java.net> Changeset: b62922b54170 Author: darcy Date: 2012-02-28 13:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b62922b54170 7149626: (reflect) Improve javadoc of java.lang.reflect.Executable Reviewed-by: mduigou ! src/share/classes/java/lang/reflect/Executable.java From lana.steuck at oracle.com Wed Feb 29 05:13:40 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 05:13:40 +0000 Subject: hg: jdk8/tl: 5 new changesets Message-ID: <20120229051340.B1D6147701@hg.openjdk.java.net> Changeset: 97bb465be99d Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/97bb465be99d Added tag jdk8-b27 for changeset 1533dfab9903 ! .hgtags Changeset: 9760a2114f51 Author: asaha Date: 2012-02-14 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9760a2114f51 Merge Changeset: d47bf204f34d Author: asaha Date: 2012-02-17 14:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d47bf204f34d Merge Changeset: 6e2541d60f4e Author: lana Date: 2012-02-24 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6e2541d60f4e Merge Changeset: d74f01115fb8 Author: lana Date: 2012-02-28 17:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d74f01115fb8 Merge From lana.steuck at oracle.com Wed Feb 29 05:13:40 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 05:13:40 +0000 Subject: hg: jdk8/tl/corba: 5 new changesets Message-ID: <20120229051347.DB93E47702@hg.openjdk.java.net> Changeset: 7bf4278af030 Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7bf4278af030 Added tag jdk8-b27 for changeset 4fffe75e4edd ! .hgtags Changeset: 66c7161ee588 Author: coffeys Date: 2011-11-17 10:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/66c7161ee588 7110704: Issues with some method in corba Reviewed-by: mbankal ! src/share/classes/com/sun/corba/se/impl/dynamicany/DynAnyFactoryImpl.java ! src/share/classes/com/sun/corba/se/impl/dynamicany/DynAnyImpl.java ! src/share/classes/com/sun/org/omg/SendingContext/_CodeBaseImplBase.java Changeset: c4afff3939d8 Author: asaha Date: 2012-02-14 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/c4afff3939d8 Merge Changeset: 695408e22b29 Author: asaha Date: 2012-02-17 14:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/695408e22b29 Merge Changeset: 2082eb35d49a Author: lana Date: 2012-02-24 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/2082eb35d49a Merge From lana.steuck at oracle.com Wed Feb 29 05:13:49 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 05:13:49 +0000 Subject: hg: jdk8/tl/jaxp: 4 new changesets Message-ID: <20120229051349.2F80247703@hg.openjdk.java.net> Changeset: 38cc4c09b847 Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/38cc4c09b847 Added tag jdk8-b27 for changeset 80c47eb83d24 ! .hgtags Changeset: 6fc515ab48c3 Author: asaha Date: 2012-02-14 10:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6fc515ab48c3 Merge Changeset: a8e76ac83b62 Author: asaha Date: 2012-02-17 14:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a8e76ac83b62 Merge Changeset: f3244c1f0486 Author: lana Date: 2012-02-24 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f3244c1f0486 Merge From lana.steuck at oracle.com Wed Feb 29 05:13:51 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 05:13:51 +0000 Subject: hg: jdk8/tl/jaxws: 5 new changesets Message-ID: <20120229051351.93C1947704@hg.openjdk.java.net> Changeset: 6a2e8a833460 Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6a2e8a833460 Added tag jdk8-b27 for changeset 38c037af4127 ! .hgtags Changeset: 4289a81ba085 Author: asaha Date: 2012-02-14 10:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/4289a81ba085 Merge Changeset: 456621c5d797 Author: asaha Date: 2012-02-17 14:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/456621c5d797 Merge Changeset: c88e83be4b1a Author: lana Date: 2012-02-23 00:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c88e83be4b1a Merge Changeset: 88b85470e72c Author: lana Date: 2012-02-24 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/88b85470e72c Merge From lana.steuck at oracle.com Wed Feb 29 05:13:44 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 05:13:44 +0000 Subject: hg: jdk8/tl/hotspot: Added tag jdk8-b27 for changeset 3b24e7e01d20 Message-ID: <20120229051351.D38E547705@hg.openjdk.java.net> Changeset: 0ed0960af27d Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0ed0960af27d Added tag jdk8-b27 for changeset 3b24e7e01d20 ! .hgtags From lana.steuck at oracle.com Wed Feb 29 05:13:56 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 05:13:56 +0000 Subject: hg: jdk8/tl/langtools: 6 new changesets Message-ID: <20120229051412.1140847706@hg.openjdk.java.net> Changeset: 8503479162bd Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8503479162bd Added tag jdk8-b27 for changeset be456f9c64e8 ! .hgtags Changeset: 3b168225dfc0 Author: asaha Date: 2012-02-14 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b168225dfc0 Merge - src/share/classes/com/sun/tools/javac/Launcher.java Changeset: d903497bf389 Author: asaha Date: 2012-02-17 14:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d903497bf389 Merge Changeset: a696a8610b2a Author: lana Date: 2012-02-23 07:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a696a8610b2a Merge Changeset: 5bed623b0c77 Author: lana Date: 2012-02-24 18:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5bed623b0c77 Merge Changeset: 3d3350aea968 Author: lana Date: 2012-02-28 18:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d3350aea968 Merge From lana.steuck at oracle.com Wed Feb 29 05:14:12 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 29 Feb 2012 05:14:12 +0000 Subject: hg: jdk8/tl/jdk: 18 new changesets Message-ID: <20120229051711.E42E047707@hg.openjdk.java.net> Changeset: 7d683ab46571 Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d683ab46571 Added tag jdk8-b27 for changeset c68342532e2e ! .hgtags Changeset: 2152ac3e4575 Author: dl Date: 2011-10-12 16:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2152ac3e4575 7082299: AtomicReferenceArray should ensure that array is Object[] Reviewed-by: chegar, dholmes, alanb ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java Changeset: 23c3d1a0e150 Author: amenkov Date: 2011-10-26 14:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23c3d1a0e150 7088367: JavaSound security issue (12865443) Reviewed-by: denis ! src/share/classes/com/sun/media/sound/DirectAudioDevice.java ! src/share/classes/com/sun/media/sound/SoftMixingSourceDataLine.java + test/javax/sound/sampled/DataLine/DataLine_ArrayIndexOutOfBounds.java Changeset: 3ee041967af6 Author: smarks Date: 2011-11-11 15:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3ee041967af6 7110700: Enhance exception throwing mechanism in ObjectStreamClass Reviewed-by: dmeetry, hawtin ! src/share/classes/java/io/ObjectStreamClass.java ! test/java/io/Serializable/expectedStackTrace/ExpectedStackTrace.java Changeset: 18335c98ab8b Author: smarks Date: 2011-11-17 15:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18335c98ab8b 7112267: clean up fix for 7110700 Reviewed-by: dmeetry ! test/java/io/Serializable/expectedStackTrace/ExpectedStackTrace.java Changeset: 4b98d2682c31 Author: okutsu Date: 2011-12-14 11:23 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b98d2682c31 6351654: Problem with java/classes_util_i18n Reviewed-by: hawtin, coffeys ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/TimeZone.java ! src/share/classes/sun/awt/AppContext.java + src/share/classes/sun/misc/JavaAWTAccess.java ! src/share/classes/sun/misc/SharedSecrets.java Changeset: 5d7e49a3a2f9 Author: bagiras Date: 2011-12-14 14:43 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d7e49a3a2f9 7112642: Incorrect checking for graphics rendering object Reviewed-by: art, bae ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/opengl/OGLRenderer.java ! src/share/classes/sun/java2d/pipe/BufferedContext.java ! src/windows/classes/sun/java2d/d3d/D3DRenderer.java ! src/windows/classes/sun/java2d/windows/GDIRenderer.java ! src/windows/native/sun/java2d/windows/GDIRenderer.cpp Changeset: a7cb0afadbee Author: sherman Date: 2011-12-15 14:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7cb0afadbee 7118283: Better input parameter checking in zip file processing Summary: Fixed off-by-one bug in zip_util.c Reviewed-by: alanb ! src/share/native/java/util/zip/zip_util.c Changeset: d544965b59fe Author: bagiras Date: 2011-12-28 14:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d544965b59fe 7121482: some sun/java2d and sun/awt tests failed with InvalidPipeException since 1.7.0_03b02, 6u31b02 Reviewed-by: art, bae ! src/share/classes/sun/java2d/SunGraphics2D.java Changeset: 5e6f3c8646cf Author: xuelei Date: 2012-01-09 20:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e6f3c8646cf 7123519: problems with certification path Summary: Also including the contribution from Dennis Gu Reviewed-by: mullan, weijun ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/ReverseBuilder.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java + src/share/classes/sun/security/provider/certpath/UntrustedChecker.java + src/share/classes/sun/security/util/UntrustedCertificates.java ! src/share/classes/sun/security/validator/SimpleValidator.java ! src/share/classes/sun/security/validator/ValidatorException.java + test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java + test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java + test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/ComodoHacker.java Changeset: d9897e95323c Author: chegar Date: 2012-01-18 15:35 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9897e95323c 7126960: Add property to limit number of request headers to the HTTP Server Reviewed-by: michaelm ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/httpserver/ServerConfig.java Changeset: 7699f0a9c6d7 Author: asaha Date: 2012-02-20 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7699f0a9c6d7 Merge ! make/java/java/FILES_java.gmk ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/httpserver/ServerConfig.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/validator/SimpleValidator.java Changeset: f525c1e9e12c Author: lana Date: 2012-02-23 00:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f525c1e9e12c Merge Changeset: fcdd5a4bae0e Author: lana Date: 2012-02-23 07:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fcdd5a4bae0e Merge Changeset: ca2218135bac Author: asaha Date: 2012-02-24 17:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca2218135bac 7148758: Resolve merge issue which caused testcase failure Reviewed-by: alanb, chegar ! src/share/classes/sun/net/httpserver/ServerConfig.java Changeset: 39dcb3264fb3 Author: lana Date: 2012-02-24 17:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39dcb3264fb3 Merge Changeset: 1e1d41daaded Author: lana Date: 2012-02-24 18:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e1d41daaded Merge Changeset: 61c36875de46 Author: lana Date: 2012-02-28 18:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/61c36875de46 Merge From Xuelei.Fan at Oracle.COM Wed Feb 29 15:32:46 2012 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Wed, 29 Feb 2012 23:32:46 +0800 Subject: code review request: 7149012: jarsigner needs not warn about cert expiration if the jar has a TSA timestamp In-Reply-To: <4F4B29FF.2030309@oracle.com> References: <17630768.1330324887119.JavaMail.sbladm@swsblss4-new.central.sun.com> <4F4B29FF.2030309@oracle.com> Message-ID: <4F4E451E.2080502@Oracle.COM> So far, I only have a very minor comment: The block from line 875 to 880 is a little overlapped with lines 884 to 889. Is it possible to improve the code? I'm not sure whether it is better to not-show the warning for timestamped signatures with expired certificates. Need more time to understand the scenarios of time-stamping in JarSigner. Does the validity of TSA certificate is also checked? Xuelei On 2/27/2012 3:00 PM, Weijun Wang wrote: > Hi All > > Please take a look at this code change: > > http://cr.openjdk.java.net/~weijun/7149012/webrev.00/ > > Jarsigner will not print a warning if the signer cert is expired but a > timestamp shows the jar was signed before the expiration date. > > Another change is that the chainNotValidated flag now does not cover > hasExpiredCert and notYetValidCert anymore. The result is that when > trying to sign (or verify) with an expired cert, instead of the > duplicated and somewhat confusing > > The signer certificate has expired. > The signer's certificate chain is not validated. > > warnings, user will only see > > The signer certificate has expired. > > User will still see the chainNotValidated warning if the CertPath is not > validated because of other reasons. > > On the other hand, since these 3 flags share the same exit code (4), > users will not notice the exit code change when -strict is on. > > There is no regression test added to the openjdk repository because it's > not easy to generate a timestamp with an old date. I have found an old > signed jar with a timestamp and signed by a now-expired cert. I will > include these binary files into the jdk/test/closed repository and the > test is a simple "jarsigner -verify -strict" call. > > Thanks > Max > > -------- Original Message -------- > *Change Request ID*: 7149012 > > *Synopsis*: jarsigner needs not warn about cert expiration if the jar > has a TSA timestamp > > === *Description* > ============================================================ > If the cert used to sign a jar is expired, jarsigner will print out a > warning, and if -strict is specified, exits with an error. However, if > there is a TSA timestamp attached to the jar (and the timestamp is shown > to be before the expiration), it's completely valid and jarsigner should > not report any warning or error. > From kumar.x.srinivasan at oracle.com Wed Feb 29 16:21:53 2012 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Wed, 29 Feb 2012 16:21:53 +0000 Subject: hg: jdk8/tl/jdk: 7148499: Stack size in tools/launcher/Settings.java needs to be increased Message-ID: <20120229162215.EAD964771C@hg.openjdk.java.net> Changeset: bd43a6f59c9b Author: ksrini Date: 2012-02-29 08:20 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd43a6f59c9b 7148499: Stack size in tools/launcher/Settings.java needs to be increased Reviewed-by: alanb ! test/ProblemList.txt ! test/tools/launcher/Settings.java