From weijun.wang at oracle.com Mon Jul 1 02:01:28 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 01 Jul 2013 17:01:28 +0800 Subject: Smart Cards in Java Kerberos In-Reply-To: References: <242A9B19-F133-4D77-8AE3-E47D46392046@lavenderwine.com> <51CA37D1.1030802@oracle.com> Message-ID: <51D14568.40502@oracle.com> On 7/1/13 4:50 PM, Ostap Andrusiv wrote: > Thanks everyone for the responses. > I can't use allowtgtsessionkey on Windows, because I want to achieve a > cross-platform solution. Allowtgtsessionkey (Google it) is a windows registry key you need to configure, which means you cannot simply deploy your app on a Windows box and it automatically works. Expect for this, I don't think the solution is not cross-platform. > > I'll look into the option, provided by Weijun Wang and create > KerberosTicket/KerberosPrincipal. I hope it would do the job. You need to get the ticket anyway. Either from an existing one (possibly thru the login process) or get it yourself (thru a kinit command that understands PKINIT). After that, as Henry said, "Just set useTicketCache=true in the JAAS config". Best luck. --Weijun > > > 2013/6/26 Henry B. Hotz > > > Even easier. Just set useTicketCache=true in the JAAS config. > > On Jun 25, 2013, at 5:37 PM, Weijun Wang > wrote: > > > Java (at least Oracle JDK) does not support PKINIT. > > > > Yes, you can do it outside, create a KerberosTicket and a > KerberosPrincipal, create a JAAS Subject containing them, and call > Subject.doAs() later. It should work. > > > > On Windows, if you manage to use Windows' own login and have the > ticket stored inside LSA, Java should be able to read it. There is a > registry key allowtgtsessionkey you need to take care of. Or maybe > you can use any third party kinit to save a ccache file which can > also be picked up by Java. > > > > --Max > > > > On 6/26/13 7:29 AM, Henry B. Hotz wrote: > >> I'm not authoritative, but AFAIK there is no smart card support > in Java, though there is pkcs11 support. > >> > >> If I had to do it, I would do the smart card/PKINIT stuff > outside Java, and then let Java use the acquired tgt. > >> > >> On Jun 25, 2013, at 5:52 AM, Ostap Andrusiv > wrote: > >> > >>> Hi everyone, > >>> > >>> I've been playing with smart cards and faced some issues. > >>> Long story short: > >>> > >>> Prerequisites: > >>> > >>> ? I set up a basic Kerberos realm via Windows Active Directory. > >>> ? I managed to successfully login into service via > login/password pair using Java Kerberos(Krb5LoginModule), which is > provided via JAAS. > >>> Now I try to implement Kerberos login via smart card. Smart > card preauthentication in Kerberos is done via AS-REQ/AS-REP > messages (PA-PK-AS-REQ/P extensions). Unfortunately, JAAS Kerberos > hasn't used the smartcard. As far as I have seen, there were no > PA-PK-AS-REQ/P extensions in openjdk sources. Maybe, I missed something. > >>> > >>> Question: > >>> > >>> 1. Does Java Kerberos support smart card preauthentication out > of the box? > >>> > >>> 2. If it doesn't, can I somehow extends existing Kerberos > module or should I implement whole Kerberos from the ground up? > >>> > >>> > >>> > >>> Thanks in advance, > >>> Ostap Andrusiv > >>> > >>> > >>> web: http://andrusiv.com > >>> skype: ostap.andrusiv > >>> ::p!F > >> > > > > > -- > Best regards, > Ostap Andrusiv > > web: http://andrusiv.com > skype: ostap.andrusiv > ::p!F From vincent.x.ryan at oracle.com Mon Jul 1 05:56:10 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Mon, 1 Jul 2013 13:56:10 +0100 Subject: [8] code review request: 8019259: Failover to CRL checking does not happen if wrong OCSP responder URL is set In-Reply-To: <51CE300F.2000004@oracle.com> References: <13934190-3690-485E-998C-20CE6D8B53BA@oracle.com> <51CE300F.2000004@oracle.com> Message-ID: <4CEF6692-021D-4C93-A5F0-3D64D0FA03C2@oracle.com> I think that wrapping a RuntimeException (in CPVE) is acceptable in this case because the goal is to activate the failover mechanism from OCSP to CRL. Do you want RuntimeException to be re-thrown? On 29 Jun 2013, at 01:53, Xuelei Fan wrote: > Looks fine to me. > > Hmm, it is a case to learn that RuntimeException should be token care of > sometimes. > > Thanks, > Xuelei > > On 6/29/2013 2:41 AM, Vincent Ryan wrote: >> Hello, >> >> Please review the following JDK 8 fix: >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019259 >> Webrev: http://cr.openjdk.java.net/~vinnie/8019259/webrev.00/ >> >> It corrects a problem during X.509 certificate revocation checking where failover to using CRLs is not >> performed in the case when a malformed URL has been supplied as the URL of the OCSP responder. >> The fix ensures all exceptions during OCSP are caught and wrapped so that the failover mechanism >> does not get skipped. >> >> Thanks. >> > From vincent.x.ryan at oracle.com Mon Jul 1 06:41:46 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Mon, 01 Jul 2013 13:41:46 +0000 Subject: hg: jdk8/tl/jdk: 8019259: Failover to CRL checking does not happen if wrong OCSP responder URL is set Message-ID: <20130701134210.1FE1F486C5@hg.openjdk.java.net> Changeset: dfb37cc30a67 Author: vinnie Date: 2013-07-01 14:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfb37cc30a67 8019259: Failover to CRL checking does not happen if wrong OCSP responder URL is set Reviewed-by: xuelei ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! test/java/security/cert/CertPathValidator/OCSP/FailoverToCRL.java From maurizio.cimadamore at oracle.com Mon Jul 1 06:57:26 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 01 Jul 2013 13:57:26 +0000 Subject: hg: jdk8/tl/langtools: 7034798: Ambiguity error for abstract method call is too eager Message-ID: <20130701135732.8E158486C6@hg.openjdk.java.net> Changeset: f559ef7568ce Author: mcimadamore Date: 2013-07-01 14:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f559ef7568ce 7034798: Ambiguity error for abstract method call is too eager Summary: Javac should wait and see if ambiguous methods can be reconciled at the end of an overload resolution round Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/resolve/ResolveHarness.java + test/tools/javac/resolve/tests/AbstractMerge.java ! test/tools/javac/resolve/tests/InnerOverOuter.java From daniel.fuchs at oracle.com Mon Jul 1 02:27:19 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Mon, 01 Jul 2013 09:27:19 +0000 Subject: hg: jdk8/tl/jdk: 8014045: test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently Message-ID: <20130701092807.71C8C486BA@hg.openjdk.java.net> Changeset: 3aa541b50a64 Author: dfuchs Date: 2013-07-01 11:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3aa541b50a64 8014045: test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently Summary: this test was failing because it didn't take into account the fact that Loggers could be garbage collected. Reviewed-by: mchung ! test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java From pifostap at gmail.com Mon Jul 1 01:50:57 2013 From: pifostap at gmail.com (Ostap Andrusiv) Date: Mon, 1 Jul 2013 11:50:57 +0300 Subject: Smart Cards in Java Kerberos In-Reply-To: References: <242A9B19-F133-4D77-8AE3-E47D46392046@lavenderwine.com> <51CA37D1.1030802@oracle.com> Message-ID: Thanks everyone for the responses. I can't use allowtgtsessionkey on Windows, because I want to achieve a cross-platform solution. I'll look into the option, provided by Weijun Wang and create KerberosTicket/KerberosPrincipal. I hope it would do the job. 2013/6/26 Henry B. Hotz > Even easier. Just set useTicketCache=true in the JAAS config. > > On Jun 25, 2013, at 5:37 PM, Weijun Wang wrote: > > > Java (at least Oracle JDK) does not support PKINIT. > > > > Yes, you can do it outside, create a KerberosTicket and a > KerberosPrincipal, create a JAAS Subject containing them, and call > Subject.doAs() later. It should work. > > > > On Windows, if you manage to use Windows' own login and have the ticket > stored inside LSA, Java should be able to read it. There is a registry key > allowtgtsessionkey you need to take care of. Or maybe you can use any third > party kinit to save a ccache file which can also be picked up by Java. > > > > --Max > > > > On 6/26/13 7:29 AM, Henry B. Hotz wrote: > >> I'm not authoritative, but AFAIK there is no smart card support in > Java, though there is pkcs11 support. > >> > >> If I had to do it, I would do the smart card/PKINIT stuff outside Java, > and then let Java use the acquired tgt. > >> > >> On Jun 25, 2013, at 5:52 AM, Ostap Andrusiv wrote: > >> > >>> Hi everyone, > >>> > >>> I've been playing with smart cards and faced some issues. > >>> Long story short: > >>> > >>> Prerequisites: > >>> > >>> ? I set up a basic Kerberos realm via Windows Active Directory. > >>> ? I managed to successfully login into service via login/password > pair using Java Kerberos(Krb5LoginModule), which is provided via JAAS. > >>> Now I try to implement Kerberos login via smart card. Smart card > preauthentication in Kerberos is done via AS-REQ/AS-REP messages > (PA-PK-AS-REQ/P extensions). Unfortunately, JAAS Kerberos hasn't used the > smartcard. As far as I have seen, there were no PA-PK-AS-REQ/P extensions > in openjdk sources. Maybe, I missed something. > >>> > >>> Question: > >>> > >>> 1. Does Java Kerberos support smart card preauthentication out of the > box? > >>> > >>> 2. If it doesn't, can I somehow extends existing Kerberos module or > should I implement whole Kerberos from the ground up? > >>> > >>> > >>> > >>> Thanks in advance, > >>> Ostap Andrusiv > >>> > >>> > >>> web: http://andrusiv.com > >>> skype: ostap.andrusiv > >>> ::p!F > >> > > -- Best regards, Ostap Andrusiv web: http://andrusiv.com skype: ostap.andrusiv ::p!F -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130701/d0723465/attachment-0001.html From joe.darcy at oracle.com Mon Jul 1 11:59:03 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 01 Jul 2013 18:59:03 +0000 Subject: hg: jdk8/tl/langtools: 7162089: Add support for repeating annotations to javax.annotation.processing Message-ID: <20130701185910.5457F486D4@hg.openjdk.java.net> Changeset: 1908e86ee49a Author: darcy Date: 2013-07-01 11:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1908e86ee49a 7162089: Add support for repeating annotations to javax.annotation.processing Reviewed-by: abuckley, jjg, jfranck ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/javax/annotation/processing/AbstractProcessor.java ! src/share/classes/javax/annotation/processing/Processor.java ! test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java + test/tools/javac/processing/environment/round/TpAnno.java + test/tools/javac/processing/environment/round/TypeParameterAnnotations.java From alan.bateman at oracle.com Mon Jul 1 12:41:10 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 01 Jul 2013 19:41:10 +0000 Subject: hg: jdk8/tl/jdk: 8017540: Improve multi-threaded contention behavior of radix conversion cache Message-ID: <20130701194122.08C8B486DC@hg.openjdk.java.net> Changeset: c8cf01de8fa8 Author: bpb Date: 2013-07-01 11:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8cf01de8fa8 8017540: Improve multi-threaded contention behavior of radix conversion cache Summary: Replace array of ArrayList of BigIntegers with a volatile two-dimensional BigInteger array eliminate the synchronization of getRadixConversionCache() Reviewed-by: plevart, shade, bpb, alanb Contributed-by: Peter Levart , Dmitry Nadezhin , Aleksey Shipilev ! src/share/classes/java/math/BigInteger.java From joe.darcy at oracle.com Mon Jul 1 13:30:53 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 01 Jul 2013 20:30:53 +0000 Subject: hg: jdk8/tl/jdk: 8019527: Fix doclint issues in java.lang.instrument Message-ID: <20130701203106.934D4486DE@hg.openjdk.java.net> Changeset: 3736ad2636aa Author: darcy Date: 2013-07-01 13:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3736ad2636aa 8019527: Fix doclint issues in java.lang.instrument Reviewed-by: lancea, alanb ! src/share/classes/java/lang/instrument/Instrumentation.java From joe.darcy at oracle.com Mon Jul 1 13:43:20 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 01 Jul 2013 20:43:20 +0000 Subject: hg: jdk8/tl/jdk: 8019529: Fix doclint issues in java.util.spi Message-ID: <20130701204333.CB309486DF@hg.openjdk.java.net> Changeset: 8e5376324e4b Author: darcy Date: 2013-07-01 13:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e5376324e4b 8019529: Fix doclint issues in java.util.spi Reviewed-by: lancea ! src/share/classes/java/util/spi/LocaleServiceProvider.java From joe.darcy at oracle.com Mon Jul 1 14:34:19 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 01 Jul 2013 21:34:19 +0000 Subject: hg: jdk8/tl/jdk: 8019535: Fix doclint issues in java.time.format Message-ID: <20130701213430.EA27D486E0@hg.openjdk.java.net> Changeset: 5427f7316633 Author: darcy Date: 2013-07-01 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5427f7316633 8019535: Fix doclint issues in java.time.format Reviewed-by: lancea, rriggs ! src/share/classes/java/time/format/DateTimeFormatter.java From jason.uh at oracle.com Mon Jul 1 15:22:49 2013 From: jason.uh at oracle.com (Jason Uh) Date: Mon, 01 Jul 2013 15:22:49 -0700 Subject: [8] Request for review: 8019539: Fix doclint errors in java.security and its subpackages Message-ID: <51D20139.8010307@oracle.com> Joe, Could I please get a review of this changeset? These changes fixed all (40) doclint errors in java.security and its subpackages. Webrev: http://cr.openjdk.java.net/~juh/8019539/webrev.00/ No undesirable changes were detected by specdiff. Thanks, Jason From xuelei.fan at oracle.com Mon Jul 1 16:02:22 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 02 Jul 2013 07:02:22 +0800 Subject: [8] code review request: 8019259: Failover to CRL checking does not happen if wrong OCSP responder URL is set In-Reply-To: <4CEF6692-021D-4C93-A5F0-3D64D0FA03C2@oracle.com> References: <13934190-3690-485E-998C-20CE6D8B53BA@oracle.com> <51CE300F.2000004@oracle.com> <4CEF6692-021D-4C93-A5F0-3D64D0FA03C2@oracle.com> Message-ID: <51D20A7E.90106@oracle.com> On 7/1/2013 8:56 PM, Vincent Ryan wrote: > I think that wrapping a RuntimeException (in CPVE) is acceptable in this case > because the goal is to activate the failover mechanism from OCSP to CRL. > > Do you want RuntimeException to be re-thrown? > No. It is acceptable to me to wrap the RuntimeException. It is not a real runtime exception, but a wrong message. I prefer to use CPVE. Xuelei > On 29 Jun 2013, at 01:53, Xuelei Fan wrote: > >> Looks fine to me. >> >> Hmm, it is a case to learn that RuntimeException should be token care of >> sometimes. >> >> Thanks, >> Xuelei >> >> On 6/29/2013 2:41 AM, Vincent Ryan wrote: >>> Hello, >>> >>> Please review the following JDK 8 fix: >>> >>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019259 >>> Webrev: http://cr.openjdk.java.net/~vinnie/8019259/webrev.00/ >>> >>> It corrects a problem during X.509 certificate revocation checking where failover to using CRLs is not >>> performed in the case when a malformed URL has been supplied as the URL of the OCSP responder. >>> The fix ensures all exceptions during OCSP are caught and wrapped so that the failover mechanism >>> does not get skipped. >>> >>> Thanks. >>> >> > From joe.darcy at oracle.com Mon Jul 1 16:16:01 2013 From: joe.darcy at oracle.com (Joseph Darcy) Date: Mon, 01 Jul 2013 16:16:01 -0700 Subject: [8] Request for review: 8019539: Fix doclint errors in java.security and its subpackages In-Reply-To: <51D20139.8010307@oracle.com> References: <51D20139.8010307@oracle.com> Message-ID: <51D20DB1.3020705@oracle.com> On 7/1/2013 3:22 PM, Jason Uh wrote: > Joe, > > Could I please get a review of this changeset? > > These changes fixed all (40) doclint errors in java.security and its > subpackages. > > Webrev: http://cr.openjdk.java.net/~juh/8019539/webrev.00/ > > No undesirable changes were detected by specdiff. > > Thanks, > Jason In src/share/classes/java/security/Security.java, instead of 495 *
  • <crypto_service>.<algorithm_or_type>

    The please see if something like 495 *

  • {@literal .}

    The will work. In src/share/classes/java/security/cert/X509CRL.java, rather than replacing 416 * signatureAlgorithm AlgorithmIdentifier

    with 417 * signatureAlgorithm AlgorithmIdentifier 418 *

    
    can the trailing "

    " just be removed? Same comment for X509CRLEntry.java and X509Certificate.java. If you are not tied to a particular ASN.1 syntax, I've used HTML definition lists for this purpose; there are samples in java.lang.Integer. Thanks, -Joe From jason.uh at oracle.com Mon Jul 1 16:11:28 2013 From: jason.uh at oracle.com (Jason Uh) Date: Mon, 01 Jul 2013 16:11:28 -0700 Subject: [8] Request for review: 8019539: Fix doclint errors in java.security and its subpackages In-Reply-To: <51D20139.8010307@oracle.com> References: <51D20139.8010307@oracle.com> Message-ID: <51D20CA0.6000500@oracle.com> Please see instead an updated webrev at: http://cr.openjdk.java.net/~juh/8019539/webrev.01/ Updates in this webrev: 1. Moved the

    in Security.java:495 to the next line. 2. Security.java:562: Split a line with >80 characters. 3. X509CRL.java and X509Certificate.java: Simply removed

    tags instead of creating multiple

     blocks.
    
    Thanks,
    Jason
    
    On 07/01/2013 03:22 PM, Jason Uh wrote:
    > Joe,
    >
    > Could I please get a review of this changeset?
    >
    > These changes fixed all (40) doclint errors in java.security and its
    > subpackages.
    >
    > Webrev: http://cr.openjdk.java.net/~juh/8019539/webrev.00/
    >
    > No undesirable changes were detected by specdiff.
    >
    > Thanks,
    > Jason
    
    From jason.uh at oracle.com  Mon Jul  1 16:14:28 2013
    From: jason.uh at oracle.com (Jason Uh)
    Date: Mon, 01 Jul 2013 16:14:28 -0700
    Subject: [8] Request for review: 8019539: Fix doclint errors in
    	java.security and its subpackages
    In-Reply-To: <51D20DB1.3020705@oracle.com>
    References: <51D20139.8010307@oracle.com> <51D20DB1.3020705@oracle.com>
    Message-ID: <51D20D54.4060208@oracle.com>
    
    Joe,
    
    Thanks for your comments. I just sent out an updated webrev, but let me 
    put out a new one including my updates and changes to address your comments.
    
    Thanks,
    Jason
    
    On 07/01/2013 04:16 PM, Joseph Darcy wrote:
    >
    > On 7/1/2013 3:22 PM, Jason Uh wrote:
    >> Joe,
    >>
    >> Could I please get a review of this changeset?
    >>
    >> These changes fixed all (40) doclint errors in java.security and its
    >> subpackages.
    >>
    >> Webrev: http://cr.openjdk.java.net/~juh/8019539/webrev.00/
    >>
    >> No undesirable changes were detected by specdiff.
    >>
    >> Thanks,
    >> Jason
    >
    > In src/share/classes/java/security/Security.java, instead of
    >
    >       495      * 
  • > <crypto_service>.<algorithm_or_type>

    The > > please see if something like > > 495 *

  • {@literal > .}

    The > > will work. > > In src/share/classes/java/security/cert/X509CRL.java, rather than replacing > > 416 * signatureAlgorithm AlgorithmIdentifier

    > > with > > 417 * signatureAlgorithm AlgorithmIdentifier > 418 *

  • >
    > can the trailing "

    " just be removed? Same comment for > X509CRLEntry.java and X509Certificate.java. > > If you are not tied to a particular ASN.1 syntax, I've used HTML > definition lists for this purpose; there are samples in java.lang.Integer. > > Thanks, > > -Joe > > > > From jason.uh at oracle.com Mon Jul 1 17:25:04 2013 From: jason.uh at oracle.com (Jason Uh) Date: Mon, 01 Jul 2013 17:25:04 -0700 Subject: [8] Request for review: 8019539: Fix doclint errors in java.security and its subpackages In-Reply-To: <51D20DB1.3020705@oracle.com> References: <51D20139.8010307@oracle.com> <51D20DB1.3020705@oracle.com> Message-ID: <51D21DE0.6080301@oracle.com> Hi Joe, Here's an update to my changes to address your comments below. http://cr.openjdk.java.net/~juh/8019539/webrev.02/ Thanks, Jason On 07/01/2013 04:16 PM, Joseph Darcy wrote: > > On 7/1/2013 3:22 PM, Jason Uh wrote: >> Joe, >> >> Could I please get a review of this changeset? >> >> These changes fixed all (40) doclint errors in java.security and its >> subpackages. >> >> Webrev: http://cr.openjdk.java.net/~juh/8019539/webrev.00/ >> >> No undesirable changes were detected by specdiff. >> >> Thanks, >> Jason > > In src/share/classes/java/security/Security.java, instead of > > 495 *

  • > <crypto_service>.<algorithm_or_type>

    The > > please see if something like > > 495 *

  • {@literal > .}

    The > > will work. > > In src/share/classes/java/security/cert/X509CRL.java, rather than replacing > > 416 * signatureAlgorithm AlgorithmIdentifier

    > > with > > 417 * signatureAlgorithm AlgorithmIdentifier > 418 *

  • >
    > can the trailing "

    " just be removed? Same comment for > X509CRLEntry.java and X509Certificate.java. > > If you are not tied to a particular ASN.1 syntax, I've used HTML > definition lists for this purpose; there are samples in java.lang.Integer. > > Thanks, > > -Joe > > > > From joe.darcy at oracle.com Mon Jul 1 17:32:37 2013 From: joe.darcy at oracle.com (Joe Darcy) Date: Mon, 01 Jul 2013 17:32:37 -0700 Subject: [8] Request for review: 8019539: Fix doclint errors in java.security and its subpackages In-Reply-To: <51D21DE0.6080301@oracle.com> References: <51D20139.8010307@oracle.com> <51D20DB1.3020705@oracle.com> <51D21DE0.6080301@oracle.com> Message-ID: <51D21FA5.8030103@oracle.com> Hi Jason, Looks good; approved to go back. Please include "doclint" and "noreg-doc" labels on the bug. Thanks, -Joe On 07/01/2013 05:25 PM, Jason Uh wrote: > Hi Joe, > > Here's an update to my changes to address your comments below. > http://cr.openjdk.java.net/~juh/8019539/webrev.02/ > > Thanks, > Jason > > On 07/01/2013 04:16 PM, Joseph Darcy wrote: >> >> On 7/1/2013 3:22 PM, Jason Uh wrote: >>> Joe, >>> >>> Could I please get a review of this changeset? >>> >>> These changes fixed all (40) doclint errors in java.security and its >>> subpackages. >>> >>> Webrev: http://cr.openjdk.java.net/~juh/8019539/webrev.00/ >>> >>> No undesirable changes were detected by specdiff. >>> >>> Thanks, >>> Jason >> >> In src/share/classes/java/security/Security.java, instead of >> >> 495 *

  • >> <crypto_service>.<algorithm_or_type>

    The >> >> please see if something like >> >> 495 *

  • {@literal >> .}

    The >> >> will work. >> >> In src/share/classes/java/security/cert/X509CRL.java, rather than >> replacing >> >> 416 * signatureAlgorithm AlgorithmIdentifier

    >> >> with >> >> 417 * signatureAlgorithm AlgorithmIdentifier >> 418 *

  • >>
    >> can the trailing "

    " just be removed? Same comment for >> X509CRLEntry.java and X509Certificate.java. >> >> If you are not tied to a particular ASN.1 syntax, I've used HTML >> definition lists for this purpose; there are samples in >> java.lang.Integer. >> >> Thanks, >> >> -Joe >> >> >> >> From jason.uh at oracle.com Mon Jul 1 17:46:46 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Tue, 02 Jul 2013 00:46:46 +0000 Subject: hg: jdk8/tl/jdk: 8019539: Fix doclint errors in java.security and its subpackages Message-ID: <20130702004713.5D7BC486E3@hg.openjdk.java.net> Changeset: 17f44b2dde41 Author: juh Date: 2013-07-01 17:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17f44b2dde41 8019539: Fix doclint errors in java.security and its subpackages Reviewed-by: darcy ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/Provider.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/cert/X509CRL.java ! src/share/classes/java/security/cert/X509CRLEntry.java ! src/share/classes/java/security/cert/X509Certificate.java From vicente.romero at oracle.com Tue Jul 2 02:22:30 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 02 Jul 2013 09:22:30 +0000 Subject: hg: jdk8/tl/langtools: 8019397: javap does not show SourceDebugExtension properly Message-ID: <20130702092238.4CEA6486F9@hg.openjdk.java.net> Changeset: 27a2e8c78bd0 Author: vromero Date: 2013-07-02 10:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/27a2e8c78bd0 8019397: javap does not show SourceDebugExtension properly Reviewed-by: jjg Contributed-by: dmytro_sheyko at hotmail.com ! src/share/classes/com/sun/tools/classfile/SourceDebugExtension_attribute.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java From daniel.fuchs at oracle.com Tue Jul 2 03:07:24 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Tue, 02 Jul 2013 10:07:24 +0000 Subject: hg: jdk8/tl/jdk: 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger Message-ID: <20130702100749.8AFAA486FB@hg.openjdk.java.net> Changeset: 020f023f87d1 Author: dfuchs Date: 2013-07-02 11:30 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/020f023f87d1 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger Summary: This patch makes sure that LoggerContext instances created for applets have a root and global logger. Reviewed-by: mchung ! src/share/classes/java/util/logging/LogManager.java ! test/java/util/logging/LogManagerInstanceTest.java + test/java/util/logging/TestAppletLoggerContext.java From vincent.x.ryan at oracle.com Tue Jul 2 03:19:06 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 2 Jul 2013 11:19:06 +0100 Subject: [8] code review request: 8019259: Failover to CRL checking does not happen if wrong OCSP responder URL is set In-Reply-To: <51D20A7E.90106@oracle.com> References: <13934190-3690-485E-998C-20CE6D8B53BA@oracle.com> <51CE300F.2000004@oracle.com> <4CEF6692-021D-4C93-A5F0-3D64D0FA03C2@oracle.com> <51D20A7E.90106@oracle.com> Message-ID: <16B2CC5F-5851-400B-B8BA-C7B81BCAA3F1@oracle.com> OK. Thanks. On 2 Jul 2013, at 00:02, Xuelei Fan wrote: > On 7/1/2013 8:56 PM, Vincent Ryan wrote: >> I think that wrapping a RuntimeException (in CPVE) is acceptable in this case >> because the goal is to activate the failover mechanism from OCSP to CRL. >> >> Do you want RuntimeException to be re-thrown? >> > No. It is acceptable to me to wrap the RuntimeException. It is not a > real runtime exception, but a wrong message. I prefer to use CPVE. > > Xuelei > >> On 29 Jun 2013, at 01:53, Xuelei Fan wrote: >> >>> Looks fine to me. >>> >>> Hmm, it is a case to learn that RuntimeException should be token care of >>> sometimes. >>> >>> Thanks, >>> Xuelei >>> >>> On 6/29/2013 2:41 AM, Vincent Ryan wrote: >>>> Hello, >>>> >>>> Please review the following JDK 8 fix: >>>> >>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019259 >>>> Webrev: http://cr.openjdk.java.net/~vinnie/8019259/webrev.00/ >>>> >>>> It corrects a problem during X.509 certificate revocation checking where failover to using CRLs is not >>>> performed in the case when a malformed URL has been supplied as the URL of the OCSP responder. >>>> The fix ensures all exceptions during OCSP are caught and wrapped so that the failover mechanism >>>> does not get skipped. >>>> >>>> Thanks. >>>> >>> >> > From kumar.x.srinivasan at oracle.com Tue Jul 2 05:30:26 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Tue, 02 Jul 2013 12:30:26 +0000 Subject: hg: jdk8/tl/jdk: 8017463: [TEST_BUG] 2 tests from tools/pack200/ remain about 1 GB of data in work directory after execution Message-ID: <20130702123051.57A2948703@hg.openjdk.java.net> Changeset: b1fffbbdf58c Author: ksrini Date: 2013-07-02 05:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1fffbbdf58c 8017463: [TEST_BUG] 2 tests from tools/pack200/ remain about 1 GB of data in work directory after execution Reviewed-by: mchung ! test/tools/pack200/AttributeTests.java ! test/tools/pack200/BandIntegrity.java ! test/tools/pack200/CommandLineTests.java ! test/tools/pack200/InstructionTests.java ! test/tools/pack200/Pack200Props.java ! test/tools/pack200/Pack200Test.java ! test/tools/pack200/PackageVersionTest.java ! test/tools/pack200/RepackTest.java ! test/tools/pack200/T7007157.java ! test/tools/pack200/TestExceptions.java ! test/tools/pack200/TimeStamp.java ! test/tools/pack200/UnpackerMemoryTest.java ! test/tools/pack200/Utils.java ! test/tools/pack200/typeannos/TestTypeAnnotations.java From sundararajan.athijegannathan at oracle.com Tue Jul 2 06:21:03 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 02 Jul 2013 13:21:03 +0000 Subject: hg: jdk8/tl/nashorn: 12 new changesets Message-ID: <20130702132114.5AF2E48706@hg.openjdk.java.net> Changeset: 218c2833c344 Author: sundar Date: 2013-06-28 19:36 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/218c2833c344 8019365: Error stack format Reviewed-by: hannesw ! src/jdk/nashorn/api/scripting/NashornException.java ! src/jdk/nashorn/internal/objects/NativeError.java ! test/script/basic/JDK-8014781.js.EXPECTED ! test/script/basic/JDK-8017950.js.EXPECTED ! test/script/basic/JDK-8019226.js ! test/script/basic/JDK-8019226.js.EXPECTED Changeset: 02588d68399d Author: sundar Date: 2013-07-01 12:38 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/02588d68399d 8019473: Parser issues related to functions and blocks Reviewed-by: lagergren ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8019473.js Changeset: 10c7a1e9e24f Author: sundar Date: 2013-07-01 14:15 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/10c7a1e9e24f 8019478: Object.prototype.toString.call(/a/.exec("a")) === "[object Array]" should be true Reviewed-by: hannesw ! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java + test/script/basic/JDK-8019478.js Changeset: 47099609a48b Author: sundar Date: 2013-07-01 17:21 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/47099609a48b 8019482: Number("0x0.0p0") should evaluate to NaN Reviewed-by: lagergren ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/runtime/ECMAException.java ! src/jdk/nashorn/internal/runtime/JSType.java + test/script/basic/JDK-8019482.js Changeset: ab3ea5b3e507 Author: sundar Date: 2013-07-01 19:52 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ab3ea5b3e507 8019488: switch on literals result in NoSuchMethodError or VerifyError Reviewed-by: hannesw ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8019488.js Changeset: 9165138b427c Author: sundar Date: 2013-07-01 23:36 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9165138b427c 8019508: Comma handling in object literal parsing is wrong Reviewed-by: hannesw ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/JDK-8019508.js + test/script/basic/JDK-8019508.js.EXPECTED Changeset: 5f9abeb0bb50 Author: jlaskey Date: 2013-07-02 07:45 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5f9abeb0bb50 8019580: Build Script Change for Nashorn promotion testing Reviewed-by: jlaskey Contributed-by: eugene.drobitko at oracle.com ! make/build.xml Changeset: a7b82e333c31 Author: lagergren Date: 2013-07-02 13:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a7b82e333c31 8016667: Wrong bytecode when testing/setting due to null check shortcut checking against primitive too Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8016667.js Changeset: 74049fe3ba46 Author: sundar Date: 2013-07-02 18:00 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/74049fe3ba46 8019553: NPE on illegal l-value for increment and decrement Reviewed-by: jlaskey, attila, lagergren ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/JDK-8019553.js + test/script/basic/JDK-8019553.js.EXPECTED ! test/script/basic/NASHORN-51.js ! test/script/basic/NASHORN-51.js.EXPECTED ! test/script/error/NASHORN-57.js.EXPECTED Changeset: 9396e42bae4f Author: lagergren Date: 2013-07-02 14:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9396e42bae4f 8017082: Long array literals were slightly broken Reviewed-by: sundar, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/LiteralNode.java + test/script/basic/JDK-8017082.js Changeset: 69ec02d12a31 Author: lagergren Date: 2013-07-02 15:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/69ec02d12a31 Merge Changeset: 16c4535abcf8 Author: sundar Date: 2013-07-02 18:39 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/16c4535abcf8 Merge From sean.mullan at oracle.com Tue Jul 2 08:19:45 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 02 Jul 2013 11:19:45 -0400 Subject: [8] code review request: 8019259: Failover to CRL checking does not happen if wrong OCSP responder URL is set In-Reply-To: <51D20A7E.90106@oracle.com> References: <13934190-3690-485E-998C-20CE6D8B53BA@oracle.com> <51CE300F.2000004@oracle.com> <4CEF6692-021D-4C93-A5F0-3D64D0FA03C2@oracle.com> <51D20A7E.90106@oracle.com> Message-ID: <51D2EF91.3080006@oracle.com> On 07/01/2013 07:02 PM, Xuelei Fan wrote: > On 7/1/2013 8:56 PM, Vincent Ryan wrote: >> I think that wrapping a RuntimeException (in CPVE) is acceptable in this case >> because the goal is to activate the failover mechanism from OCSP to CRL. >> >> Do you want RuntimeException to be re-thrown? >> > No. It is acceptable to me to wrap the RuntimeException. It is not a > real runtime exception, but a wrong message. I prefer to use CPVE. Sorry I was on vacation yesterday and was unable to review this until now. I'm not sure I like the fix. Catching a runtime exception and rethrowing it as a checked exception is generally not a good idea. In this case you have a situation where someone has misconfigured the property to specify an OCSP responder. Hiding that exception and allowing the revocation check to fallback to CRLs is dubious, even if we still capture the exception in a log file. I think it should be thrown as is, so the user knows about the issue immediately and can fix the configuration. So, even though it is technically a change in behavior from JDK 7, I think the current behavior is more correct, and I doubt this would cause many compatibility issues since it is a configuration error that needs manual intervention to be properly fixed. Thanks, Sean > > Xuelei > >> On 29 Jun 2013, at 01:53, Xuelei Fan wrote: >> >>> Looks fine to me. >>> >>> Hmm, it is a case to learn that RuntimeException should be token care of >>> sometimes. >>> >>> Thanks, >>> Xuelei >>> >>> On 6/29/2013 2:41 AM, Vincent Ryan wrote: >>>> Hello, >>>> >>>> Please review the following JDK 8 fix: >>>> >>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019259 >>>> Webrev: http://cr.openjdk.java.net/~vinnie/8019259/webrev.00/ >>>> >>>> It corrects a problem during X.509 certificate revocation checking where failover to using CRLs is not >>>> performed in the case when a malformed URL has been supplied as the URL of the OCSP responder. >>>> The fix ensures all exceptions during OCSP are caught and wrapped so that the failover mechanism >>>> does not get skipped. >>>> >>>> Thanks. >>>> >>> >> > From kumar.x.srinivasan at oracle.com Tue Jul 2 11:02:51 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Tue, 02 Jul 2013 18:02:51 +0000 Subject: hg: jdk8/tl/langtools: 8019460: tests in changeset do not have @bug tag Message-ID: <20130702180256.6783C48710@hg.openjdk.java.net> Changeset: 565341d436e2 Author: ksrini Date: 2013-07-01 16:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/565341d436e2 8019460: tests in changeset do not have @bug tag Reviewed-by: darcy ! test/tools/javac/warnings/AuxiliaryClass/ClassUsingAnotherAuxiliary.java ! test/tools/javac/warnings/AuxiliaryClass/ClassUsingAnotherAuxiliary.out ! test/tools/javac/warnings/AuxiliaryClass/ClassUsingAuxiliary.java ! test/tools/javac/warnings/AuxiliaryClass/ClassUsingAuxiliary1.out ! test/tools/javac/warnings/AuxiliaryClass/ClassUsingAuxiliary2.out ! test/tools/javac/warnings/AuxiliaryClass/SelfClassWithAux.java From daniel.fuchs at oracle.com Tue Jul 2 11:26:15 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Tue, 02 Jul 2013 18:26:15 +0000 Subject: hg: jdk8/tl/jdk: 7184195: java.util.logging.Logger.getGlobal().info() doesn't log without configuration Message-ID: <20130702182637.740EA48712@hg.openjdk.java.net> Changeset: 70bff2d12af0 Author: dfuchs Date: 2013-07-02 19:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70bff2d12af0 7184195: java.util.logging.Logger.getGlobal().info() doesn't log without configuration Summary: Due to subtle synchronization issues between LogManager & Logger class initialization the global logger doesn't have its 'manager' field initialized until the LogManager is initialized. This fix will ensure that the global logger has its 'manager' field set when getGlobal() is called. Reviewed-by: mchung, plevart ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/Logger/getGlobal/TestGetGlobal.java + test/java/util/logging/Logger/getGlobal/TestGetGlobalByName.java + test/java/util/logging/Logger/getGlobal/TestGetGlobalConcurrent.java + test/java/util/logging/Logger/getGlobal/logging.properties + test/java/util/logging/Logger/getGlobal/policy + test/java/util/logging/Logger/getGlobal/testgetglobal/BadLogManagerImpl.java + test/java/util/logging/Logger/getGlobal/testgetglobal/DummyLogManagerImpl.java + test/java/util/logging/Logger/getGlobal/testgetglobal/HandlerImpl.java + test/java/util/logging/Logger/getGlobal/testgetglobal/LogManagerImpl1.java + test/java/util/logging/Logger/getGlobal/testgetglobal/LogManagerImpl2.java + test/java/util/logging/Logger/getGlobal/testgetglobal/LogManagerImpl3.java From vincent.x.ryan at oracle.com Tue Jul 2 11:49:36 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 2 Jul 2013 19:49:36 +0100 Subject: [8] code review request: 8019259: Failover to CRL checking does not happen if wrong OCSP responder URL is set In-Reply-To: <51D2EF91.3080006@oracle.com> References: <13934190-3690-485E-998C-20CE6D8B53BA@oracle.com> <51CE300F.2000004@oracle.com> <4CEF6692-021D-4C93-A5F0-3D64D0FA03C2@oracle.com> <51D20A7E.90106@oracle.com> <51D2EF91.3080006@oracle.com> Message-ID: <004FD6E6-ABDC-4E19-AE33-D1560D4D8F51@oracle.com> I see your point Sean. My motivation for wrapping the RuntimeException was to ensure that the failover mechanism (from OCSP to CRLs) did not get interrupted. But this is a case when the failover should be interrupted. I've filed a new bug to address the issue: Bug: 8019627: RuntimeException gets obscured during OCSP cert revocation checking Webrev: http://cr.openjdk.java.net/~vinnie/8019627/webrev.00/ It simply re-throws RuntimeExceptions. On 2 Jul 2013, at 16:19, Sean Mullan wrote: > On 07/01/2013 07:02 PM, Xuelei Fan wrote: >> On 7/1/2013 8:56 PM, Vincent Ryan wrote: >>> I think that wrapping a RuntimeException (in CPVE) is acceptable in this case >>> because the goal is to activate the failover mechanism from OCSP to CRL. >>> >>> Do you want RuntimeException to be re-thrown? >>> >> No. It is acceptable to me to wrap the RuntimeException. It is not a >> real runtime exception, but a wrong message. I prefer to use CPVE. > > Sorry I was on vacation yesterday and was unable to review this until now. I'm not sure I like the fix. Catching a runtime exception and rethrowing it as a checked exception is generally not a good idea. In this case you have a situation where someone has misconfigured the property to specify an OCSP responder. Hiding that exception and allowing the revocation check to fallback to CRLs is dubious, even if we still capture the exception in a log file. I think it should be thrown as is, so the user knows about the issue immediately and can fix the configuration. So, even though it is technically a change in behavior from JDK 7, I think the current behavior is more correct, and I doubt this would cause many compatibility issues since it is a configuration error that needs manual intervention to be properly fixed. > > Thanks, > Sean > >> >> Xuelei >> >>> On 29 Jun 2013, at 01:53, Xuelei Fan wrote: >>> >>>> Looks fine to me. >>>> >>>> Hmm, it is a case to learn that RuntimeException should be token care of >>>> sometimes. >>>> >>>> Thanks, >>>> Xuelei >>>> >>>> On 6/29/2013 2:41 AM, Vincent Ryan wrote: >>>>> Hello, >>>>> >>>>> Please review the following JDK 8 fix: >>>>> >>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019259 >>>>> Webrev: http://cr.openjdk.java.net/~vinnie/8019259/webrev.00/ >>>>> >>>>> It corrects a problem during X.509 certificate revocation checking where failover to using CRLs is not >>>>> performed in the case when a malformed URL has been supplied as the URL of the OCSP responder. >>>>> The fix ensures all exceptions during OCSP are caught and wrapped so that the failover mechanism >>>>> does not get skipped. >>>>> >>>>> Thanks. >>>>> >>>> >>> >> > From sean.mullan at oracle.com Tue Jul 2 13:38:14 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 02 Jul 2013 16:38:14 -0400 Subject: [8] code review request: 8019259: Failover to CRL checking does not happen if wrong OCSP responder URL is set In-Reply-To: <004FD6E6-ABDC-4E19-AE33-D1560D4D8F51@oracle.com> References: <13934190-3690-485E-998C-20CE6D8B53BA@oracle.com> <51CE300F.2000004@oracle.com> <4CEF6692-021D-4C93-A5F0-3D64D0FA03C2@oracle.com> <51D20A7E.90106@oracle.com> <51D2EF91.3080006@oracle.com> <004FD6E6-ABDC-4E19-AE33-D1560D4D8F51@oracle.com> Message-ID: <51D33A36.7090405@oracle.com> On 07/02/2013 02:49 PM, Vincent Ryan wrote: > > I see your point Sean. My motivation for wrapping the RuntimeException was to ensure > that the failover mechanism (from OCSP to CRLs) did not get interrupted. But this is a > case when the failover should be interrupted. I've filed a new bug to address the issue: > > Bug: 8019627: RuntimeException gets obscured during OCSP cert revocation checking > Webrev: http://cr.openjdk.java.net/~vinnie/8019627/webrev.00/ > > It simply re-throws RuntimeExceptions. I would prefer to just revert to the previous code (before 8019259). The only checked exception thrown in that block is an IOException, so the extra try/catch blocks for RuntimeException and Exception are unnecessary. --Sean > > > > On 2 Jul 2013, at 16:19, Sean Mullan wrote: > >> On 07/01/2013 07:02 PM, Xuelei Fan wrote: >>> On 7/1/2013 8:56 PM, Vincent Ryan wrote: >>>> I think that wrapping a RuntimeException (in CPVE) is acceptable in this case >>>> because the goal is to activate the failover mechanism from OCSP to CRL. >>>> >>>> Do you want RuntimeException to be re-thrown? >>>> >>> No. It is acceptable to me to wrap the RuntimeException. It is not a >>> real runtime exception, but a wrong message. I prefer to use CPVE. >> >> Sorry I was on vacation yesterday and was unable to review this until now. I'm not sure I like the fix. Catching a runtime exception and rethrowing it as a checked exception is generally not a good idea. In this case you have a situation where someone has misconfigured the property to specify an OCSP responder. Hiding that exception and allowing the revocation check to fallback to CRLs is dubious, even if we still capture the exception in a log file. I think it should be thrown as is, so the user knows about the issue immediately and can fix the configuration. So, even though it is technically a change in behavior from JDK 7, I think the current behavior is more correct, and I doubt this would cause many compatibility issues since it is a configuration error that needs manual intervention to be properly fixed. >> >> Thanks, >> Sean >> >>> >>> Xuelei >>> >>>> On 29 Jun 2013, at 01:53, Xuelei Fan wrote: >>>> >>>>> Looks fine to me. >>>>> >>>>> Hmm, it is a case to learn that RuntimeException should be token care of >>>>> sometimes. >>>>> >>>>> Thanks, >>>>> Xuelei >>>>> >>>>> On 6/29/2013 2:41 AM, Vincent Ryan wrote: >>>>>> Hello, >>>>>> >>>>>> Please review the following JDK 8 fix: >>>>>> >>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019259 >>>>>> Webrev: http://cr.openjdk.java.net/~vinnie/8019259/webrev.00/ >>>>>> >>>>>> It corrects a problem during X.509 certificate revocation checking where failover to using CRLs is not >>>>>> performed in the case when a malformed URL has been supplied as the URL of the OCSP responder. >>>>>> The fix ensures all exceptions during OCSP are caught and wrapped so that the failover mechanism >>>>>> does not get skipped. >>>>>> >>>>>> Thanks. >>>>>> >>>>> >>>> >>> >> > From bradford.wetmore at oracle.com Tue Jul 2 14:20:51 2013 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Tue, 02 Jul 2013 14:20:51 -0700 Subject: Code review request: 6755701 SecretKeySpec & DES In-Reply-To: <51CE2B4B.4060306@oracle.com> References: <51BA5F09.4040405@oracle.com> <51CDCA89.6040409@oracle.com> <51CE2B4B.4060306@oracle.com> Message-ID: <51D34433.9050603@oracle.com> It's not common to use this style: 74 throw new InvalidKeySpecException 75 ("Inappropriate key specification"); but rather: throw new InvalidKeySpecException( "Inapp..."); Also, what happens in the case that the size doesn't match up with what DESKey's constructor needs? For example, if you provide 7 bytes, won't that throw a InvalidKeyException and thus you get a null back from engineGenerateSecret? The SecretKeyFactory.generateSecret() API doesn't mention anything about possibly getting a null back. I know that's the existing behavior, but that seems fishy to me. Bug in API? Brad On 6/28/2013 5:33 PM, Xuelei Fan wrote: > Looks fine to me. > > Xuelei > > On 6/29/2013 1:40 AM, Anthony Scarpino wrote: >> ping... >> >> On 06/13/2013 05:08 PM, Anthony Scarpino wrote: >>> Hi all, >>> >>> I'm requesting a code review for the below bug >>> >>> 6755701 SunJCE DES/DESede SecretKeyFactory.generateSecret throws >>> InvalidKeySpecExc if passed SecretKeySpec >>> >>> http://cr.openjdk.java.net/~ascarpino/6755701/webrev.00/ >>> >>> Thanks >>> >>> Tony >> > From anthony.scarpino at oracle.com Tue Jul 2 14:48:52 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Tue, 02 Jul 2013 14:48:52 -0700 Subject: Code review request: 6755701 SecretKeySpec & DES In-Reply-To: <51D34433.9050603@oracle.com> References: <51BA5F09.4040405@oracle.com> <51CDCA89.6040409@oracle.com> <51CE2B4B.4060306@oracle.com> <51D34433.9050603@oracle.com> Message-ID: <51D34AC4.2000403@oracle.com> On 07/02/2013 02:20 PM, Brad Wetmore wrote: > It's not common to use this style: > > 74 throw new InvalidKeySpecException > 75 ("Inappropriate key specification"); > > but rather: > > throw new InvalidKeySpecException( > "Inapp..."); That was preexisting code. I have no problem fixing the style, I'm just not taking the fall :) > > Also, what happens in the case that the size doesn't match up with what > DESKey's constructor needs? For example, if you provide 7 bytes, won't > that throw a InvalidKeyException and thus you get a null back from > engineGenerateSecret? The SecretKeyFactory.generateSecret() API doesn't > mention anything about possibly getting a null back. > > I know that's the existing behavior, but that seems fishy to me. Bug in > API? > It does seem a bit strange to not be throwing a InvalidKeyException. Looks like a bug in the API. > Brad > > > > On 6/28/2013 5:33 PM, Xuelei Fan wrote: >> Looks fine to me. >> >> Xuelei >> >> On 6/29/2013 1:40 AM, Anthony Scarpino wrote: >>> ping... >>> >>> On 06/13/2013 05:08 PM, Anthony Scarpino wrote: >>>> Hi all, >>>> >>>> I'm requesting a code review for the below bug >>>> >>>> 6755701 SunJCE DES/DESede SecretKeyFactory.generateSecret throws >>>> InvalidKeySpecExc if passed SecretKeySpec >>>> >>>> http://cr.openjdk.java.net/~ascarpino/6755701/webrev.00/ >>>> >>>> Thanks >>>> >>>> Tony >>> >> From vicente.romero at oracle.com Tue Jul 2 14:50:44 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 02 Jul 2013 21:50:44 +0000 Subject: hg: jdk8/tl/langtools: 6326693: variable x might already have been assigned, when assignment is in catch block Message-ID: <20130702215049.B6D8C48724@hg.openjdk.java.net> Changeset: 3b4f92a3797f Author: vromero Date: 2013-07-02 22:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b4f92a3797f 6326693: variable x might already have been assigned, when assignment is in catch block Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Flow.java + test/tools/javac/T6326693/FinalVariableAssignedToInCatchBlockTest.java + test/tools/javac/T6326693/FinalVariableAssignedToInCatchBlockTest.out From valerie.peng at oracle.com Tue Jul 2 15:31:47 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 02 Jul 2013 15:31:47 -0700 Subject: Code review request: 6755701 SecretKeySpec & DES In-Reply-To: <51D34AC4.2000403@oracle.com> References: <51BA5F09.4040405@oracle.com> <51CDCA89.6040409@oracle.com> <51CE2B4B.4060306@oracle.com> <51D34433.9050603@oracle.com> <51D34AC4.2000403@oracle.com> Message-ID: <51D354D3.90609@oracle.com> Well, I don't think there is anything wrong with the SecretKeyFactory.generateSecret API. DESKeySpec/DESedeKeySpec do check the length of the key bytes when constructed. If we were to accept the SecretKeySpec object as generic key spec, then we should add additional checkings and throw InvalidKeySpec exception before passing the key bytes to the underlying key impl classes, i.e. DESKey/DESedeKey. Valerie On 07/02/13 14:48, Anthony Scarpino wrote: > On 07/02/2013 02:20 PM, Brad Wetmore wrote: >> It's not common to use this style: >> >> 74 throw new InvalidKeySpecException >> 75 ("Inappropriate key specification"); >> >> but rather: >> >> throw new InvalidKeySpecException( >> "Inapp..."); > > That was preexisting code. I have no problem fixing the style, I'm > just not taking the fall :) > > >> >> Also, what happens in the case that the size doesn't match up with what >> DESKey's constructor needs? For example, if you provide 7 bytes, won't >> that throw a InvalidKeyException and thus you get a null back from >> engineGenerateSecret? The SecretKeyFactory.generateSecret() API doesn't >> mention anything about possibly getting a null back. >> >> I know that's the existing behavior, but that seems fishy to me. Bug in >> API? >> > > It does seem a bit strange to not be throwing a InvalidKeyException. > Looks like a bug in the API. > >> Brad >> >> >> >> On 6/28/2013 5:33 PM, Xuelei Fan wrote: >>> Looks fine to me. >>> >>> Xuelei >>> >>> On 6/29/2013 1:40 AM, Anthony Scarpino wrote: >>>> ping... >>>> >>>> On 06/13/2013 05:08 PM, Anthony Scarpino wrote: >>>>> Hi all, >>>>> >>>>> I'm requesting a code review for the below bug >>>>> >>>>> 6755701 SunJCE DES/DESede SecretKeyFactory.generateSecret throws >>>>> InvalidKeySpecExc if passed SecretKeySpec >>>>> >>>>> http://cr.openjdk.java.net/~ascarpino/6755701/webrev.00/ >>>>> >>>>> Thanks >>>>> >>>>> Tony >>>> >>> > From jason.uh at oracle.com Tue Jul 2 15:50:57 2013 From: jason.uh at oracle.com (Jason Uh) Date: Tue, 02 Jul 2013 15:50:57 -0700 Subject: [8] Request for Review: 8019772: Fix doclint issues in javax.crypto and javax.security subpackages Message-ID: <51D35951.7000108@oracle.com> Hi Joe, Please review this changeset, which fixes doclint errors and warnings in javax.crypto, javax.security.auth, and javax.security.cert. Webrev: http://cr.openjdk.java.net/~juh/8019772/webrev.00/ Changeset have been checked for undesirable changes with specdiff. Thanks, Jason From mandy.chung at oracle.com Tue Jul 2 16:01:31 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 02 Jul 2013 23:01:31 +0000 Subject: hg: jdk8/tl/jdk: 8007035: deprecate public void SecurityManager.checkMemberAccess(Class clazz, int which) Message-ID: <20130702230213.79CF848732@hg.openjdk.java.net> Changeset: cf7202b32a34 Author: mchung Date: 2013-07-02 15:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf7202b32a34 8007035: deprecate public void SecurityManager.checkMemberAccess(Class clazz, int which) Reviewed-by: jrose, alanb, dfuchs ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/SecurityManager.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/reflect/Member.java ! test/java/lang/invoke/InvokeDynamicPrintArgs.java + test/java/lang/invoke/TestPrivateMember.java From d.stirling at massey.ac.nz Tue Jul 2 15:51:37 2013 From: d.stirling at massey.ac.nz (Doug Stiring) Date: Tue, 2 Jul 2013 22:51:37 +0000 (UTC) Subject: getCodeBase broken locally in 7 update 25 References: <000601ce6d3a$e3822110$aa866330$@segal.org> <0DB9525D-F31B-46AF-9303-116E8088CB51@oracle.com> <000c01ce6d53$016ce530$0446af90$@segal.org> Message-ID: > From: Sandeep Konchady [mailto:sandeep.konchady- QHcLZuEGTsvQT0dZR+AlfA at public.gmane.org] Sent: Wednesday, June 19, 2013 7:40 PM To: Mickey SegalCc: Java SecuritySubject: Re: getCodeBase broken locally in 7 update 25 > ? > Hi Mickey, > ? > The issue you are seeing is intended behavior. This was caused because of a vulnerability that was fixed in 7u25 in which which a getCodeBase call against all local?applet/jnlp apps will return null. > ? > Thanks, > Sandeep > ? > Hi, Is there a way that works to read a PNG file in the "codebase" directory into a Java Image, when the applet is locally installed? I have tried a few alternatives to "getCodeBase()" such as "getClass().getResource()" but all end up with a null URL. If a locally installed applet can use nothing but its ".class" files, you might as well forbid local applet. Doug. From joe.darcy at oracle.com Tue Jul 2 17:43:49 2013 From: joe.darcy at oracle.com (Joseph Darcy) Date: Tue, 02 Jul 2013 17:43:49 -0700 Subject: [8] Request for Review: 8019772: Fix doclint issues in javax.crypto and javax.security subpackages In-Reply-To: <51D35951.7000108@oracle.com> References: <51D35951.7000108@oracle.com> Message-ID: <51D373C5.2090007@oracle.com> Hi Jason, Looks good; approved. Thanks, -Joe On 7/2/2013 3:50 PM, Jason Uh wrote: > Hi Joe, > > Please review this changeset, which fixes doclint errors and warnings > in javax.crypto, javax.security.auth, and javax.security.cert. > > Webrev: http://cr.openjdk.java.net/~juh/8019772/webrev.00/ > > Changeset have been checked for undesirable changes with specdiff. > > Thanks, > Jason From xuelei.fan at oracle.com Tue Jul 2 18:29:18 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 03 Jul 2013 09:29:18 +0800 Subject: [8] code review request: 8019259: Failover to CRL checking does not happen if wrong OCSP responder URL is set In-Reply-To: <51D33A36.7090405@oracle.com> References: <13934190-3690-485E-998C-20CE6D8B53BA@oracle.com> <51CE300F.2000004@oracle.com> <4CEF6692-021D-4C93-A5F0-3D64D0FA03C2@oracle.com> <51D20A7E.90106@oracle.com> <51D2EF91.3080006@oracle.com> <004FD6E6-ABDC-4E19-AE33-D1560D4D8F51@oracle.com> <51D33A36.7090405@oracle.com> Message-ID: <51D37E6E.3060605@oracle.com> On 7/3/2013 4:38 AM, Sean Mullan wrote: > On 07/02/2013 02:49 PM, Vincent Ryan wrote: >> >> I see your point Sean. My motivation for wrapping the RuntimeException >> was to ensure >> that the failover mechanism (from OCSP to CRLs) did not get >> interrupted. But this is a >> case when the failover should be interrupted. I've filed a new bug to >> address the issue: >> I had a mis-understanding here. I thought the URL is coming from the X.509 certificate. I agree with you that if it is a mis-configuration issue, it's better to throw RuntimeException. >> Bug: 8019627: RuntimeException gets obscured during OCSP cert >> revocation checking >> Webrev: http://cr.openjdk.java.net/~vinnie/8019627/webrev.00/ >> >> It simply re-throws RuntimeExceptions. > > I would prefer to just revert to the previous code (before 8019259). The > only checked exception thrown in that block is an IOException, so the > extra try/catch blocks for RuntimeException and Exception are unnecessary. > +1. Xuelei > --Sean > >> >> >> >> On 2 Jul 2013, at 16:19, Sean Mullan wrote: >> >>> On 07/01/2013 07:02 PM, Xuelei Fan wrote: >>>> On 7/1/2013 8:56 PM, Vincent Ryan wrote: >>>>> I think that wrapping a RuntimeException (in CPVE) is acceptable in >>>>> this case >>>>> because the goal is to activate the failover mechanism from OCSP to >>>>> CRL. >>>>> >>>>> Do you want RuntimeException to be re-thrown? >>>>> >>>> No. It is acceptable to me to wrap the RuntimeException. It is not a >>>> real runtime exception, but a wrong message. I prefer to use CPVE. >>> >>> Sorry I was on vacation yesterday and was unable to review this until >>> now. I'm not sure I like the fix. Catching a runtime exception and >>> rethrowing it as a checked exception is generally not a good idea. In >>> this case you have a situation where someone has misconfigured the >>> property to specify an OCSP responder. Hiding that exception and >>> allowing the revocation check to fallback to CRLs is dubious, even if >>> we still capture the exception in a log file. I think it should be >>> thrown as is, so the user knows about the issue immediately and can >>> fix the configuration. So, even though it is technically a change in >>> behavior from JDK 7, I think the current behavior is more correct, >>> and I doubt this would cause many compatibility issues since it is a >>> configuration error that needs manual intervention to be properly fixed. >>> >>> Thanks, >>> Sean >>> >>>> >>>> Xuelei >>>> >>>>> On 29 Jun 2013, at 01:53, Xuelei Fan wrote: >>>>> >>>>>> Looks fine to me. >>>>>> >>>>>> Hmm, it is a case to learn that RuntimeException should be token >>>>>> care of >>>>>> sometimes. >>>>>> >>>>>> Thanks, >>>>>> Xuelei >>>>>> >>>>>> On 6/29/2013 2:41 AM, Vincent Ryan wrote: >>>>>>> Hello, >>>>>>> >>>>>>> Please review the following JDK 8 fix: >>>>>>> >>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019259 >>>>>>> Webrev: http://cr.openjdk.java.net/~vinnie/8019259/webrev.00/ >>>>>>> >>>>>>> It corrects a problem during X.509 certificate revocation >>>>>>> checking where failover to using CRLs is not >>>>>>> performed in the case when a malformed URL has been supplied as >>>>>>> the URL of the OCSP responder. >>>>>>> The fix ensures all exceptions during OCSP are caught and wrapped >>>>>>> so that the failover mechanism >>>>>>> does not get skipped. >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>> >>>>> >>>> >>> >> > From xuelei.fan at oracle.com Tue Jul 2 19:44:54 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 03 Jul 2013 10:44:54 +0800 Subject: Code Review Request: 8011547 : Update XML Signature implementation to Apache Santuario 1.5.4 In-Reply-To: <51CDB326.7000400@oracle.com> References: <51CDB326.7000400@oracle.com> Message-ID: <51D39026.7060902@oracle.com> Looks fine to me. It's a huge update. I mainly focus on the new features introduced in this update. In the update of GCM cipher operations, I did not find Cipher.updateAAD() and GCMParameterSpec get called in XMLCipher. It's OK because the default value in Oracle provider just meet the requirement of XML Encryption specification (a 128 bit Authentication Tag (T)), and the XML Encryption specification does not specify the Additional Authentication Data (AAD). However, I would suggest to use explicit Tag length (128 bits, with GCMParameterSpec) so that it won't depend on the behaviors of a particular provider. As this is a sync up with Apache, I would suggest to push the changeset. We can submit a new bug to use GCMParameterSpec and add new GCM based test cases later if necessary. Thanks, Xuelei On 6/29/2013 12:00 AM, Sean Mullan wrote: > Hi Xuelei, > > Please review my JDK 8 code changes to bring our XML Signature > implementation up-to-date with Apache Santuario version 1.5.4. > > The changes are extensive, but many of them are simple formatting or > refactoring changes. Any questions, let me know. > > http://cr.openjdk.java.net/~mullan/webrevs/8011547/webrev.00/ > > Thanks, > Sean From paul.sandoz at oracle.com Wed Jul 3 05:54:18 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Wed, 03 Jul 2013 12:54:18 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130703125507.2369B4875F@hg.openjdk.java.net> Changeset: dfd7fb0ce54b Author: psandoz Date: 2013-07-03 11:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfd7fb0ce54b 8011427: java.util.concurrent collection Spliterator implementations Reviewed-by: martin Contributed-by: Doug Lea

    ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/BlockingDeque.java ! src/share/classes/java/util/concurrent/BlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListSet.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/CopyOnWriteArraySet.java ! src/share/classes/java/util/concurrent/DelayQueue.java ! src/share/classes/java/util/concurrent/Delayed.java ! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java Changeset: bb4ae17c98cf Author: psandoz Date: 2013-07-03 11:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb4ae17c98cf 8019481: Sync misc j.u.c classes from 166 to tl Reviewed-by: martin Contributed-by: Doug Lea
    ! src/share/classes/java/util/concurrent/BrokenBarrierException.java ! src/share/classes/java/util/concurrent/CountDownLatch.java ! src/share/classes/java/util/concurrent/CyclicBarrier.java ! src/share/classes/java/util/concurrent/Exchanger.java ! src/share/classes/java/util/concurrent/Phaser.java ! src/share/classes/java/util/concurrent/TimeUnit.java ! src/share/classes/java/util/concurrent/TimeoutException.java ! src/share/classes/java/util/concurrent/package-info.java From anthony.scarpino at oracle.com Wed Jul 3 11:46:38 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Wed, 03 Jul 2013 11:46:38 -0700 Subject: Code review request: 6755701 SecretKeySpec & DES In-Reply-To: <51D34433.9050603@oracle.com> References: <51BA5F09.4040405@oracle.com> <51CDCA89.6040409@oracle.com> <51CE2B4B.4060306@oracle.com> <51D34433.9050603@oracle.com> Message-ID: <51D4718E.90500@oracle.com> I updated the webrev to reflect the simple style change you mention below. I'm going to proceed with the pre-push jar signing procedures figuring the discussion regarding InvalidKeyException is not related to this exact fix. http://cr.openjdk.java.net/~ascarpino/6755701/webrev.01/ Tony On 07/02/2013 02:20 PM, Brad Wetmore wrote: > It's not common to use this style: > > 74 throw new InvalidKeySpecException > 75 ("Inappropriate key specification"); > > but rather: > > throw new InvalidKeySpecException( > "Inapp..."); > > Also, what happens in the case that the size doesn't match up with what > DESKey's constructor needs? For example, if you provide 7 bytes, won't > that throw a InvalidKeyException and thus you get a null back from > engineGenerateSecret? The SecretKeyFactory.generateSecret() API doesn't > mention anything about possibly getting a null back. > > I know that's the existing behavior, but that seems fishy to me. Bug in > API? > > Brad > > > > On 6/28/2013 5:33 PM, Xuelei Fan wrote: >> Looks fine to me. >> >> Xuelei >> >> On 6/29/2013 1:40 AM, Anthony Scarpino wrote: >>> ping... >>> >>> On 06/13/2013 05:08 PM, Anthony Scarpino wrote: >>>> Hi all, >>>> >>>> I'm requesting a code review for the below bug >>>> >>>> 6755701 SunJCE DES/DESede SecretKeyFactory.generateSecret throws >>>> InvalidKeySpecExc if passed SecretKeySpec >>>> >>>> http://cr.openjdk.java.net/~ascarpino/6755701/webrev.00/ >>>> >>>> Thanks >>>> >>>> Tony >>> >> From christian.thalinger at oracle.com Wed Jul 3 11:35:35 2013 From: christian.thalinger at oracle.com (christian.thalinger at oracle.com) Date: Wed, 03 Jul 2013 18:35:35 +0000 Subject: hg: jdk8/tl/jdk: 8019184: MethodHandles.catchException() fails when methods have 8 args + varargs Message-ID: <20130703183551.94D184877E@hg.openjdk.java.net> Changeset: bd6949f9dbb2 Author: twisti Date: 2013-07-03 11:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd6949f9dbb2 8019184: MethodHandles.catchException() fails when methods have 8 args + varargs Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MethodHandleImpl.java + test/java/lang/invoke/TestCatchExceptionWithVarargs.java From valerie.peng at oracle.com Wed Jul 3 12:13:26 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Wed, 03 Jul 2013 12:13:26 -0700 Subject: Code review request: 6755701 SecretKeySpec & DES In-Reply-To: <51D4718E.90500@oracle.com> References: <51BA5F09.4040405@oracle.com> <51CDCA89.6040409@oracle.com> <51CE2B4B.4060306@oracle.com> <51D34433.9050603@oracle.com> <51D4718E.90500@oracle.com> Message-ID: <51D477D6.1060502@oracle.com> As I mentioned in my earlier email, I think you should add a check to ensure that the result from theSecretKeySpec.getEncoded() has the right length (i.e. 8 for DES, 24 for DESede) before passing them to DESKey/DESedeKey. Valerie On 07/03/13 11:46, Anthony Scarpino wrote: > I updated the webrev to reflect the simple style change you mention > below. I'm going to proceed with the pre-push jar signing procedures > figuring the discussion regarding InvalidKeyException is not related > to this exact fix. > > http://cr.openjdk.java.net/~ascarpino/6755701/webrev.01/ > > Tony > > On 07/02/2013 02:20 PM, Brad Wetmore wrote: >> It's not common to use this style: >> >> 74 throw new InvalidKeySpecException >> 75 ("Inappropriate key specification"); >> >> but rather: >> >> throw new InvalidKeySpecException( >> "Inapp..."); >> >> Also, what happens in the case that the size doesn't match up with what >> DESKey's constructor needs? For example, if you provide 7 bytes, won't >> that throw a InvalidKeyException and thus you get a null back from >> engineGenerateSecret? The SecretKeyFactory.generateSecret() API doesn't >> mention anything about possibly getting a null back. >> >> I know that's the existing behavior, but that seems fishy to me. Bug in >> API? >> >> Brad >> >> >> >> On 6/28/2013 5:33 PM, Xuelei Fan wrote: >>> Looks fine to me. >>> >>> Xuelei >>> >>> On 6/29/2013 1:40 AM, Anthony Scarpino wrote: >>>> ping... >>>> >>>> On 06/13/2013 05:08 PM, Anthony Scarpino wrote: >>>>> Hi all, >>>>> >>>>> I'm requesting a code review for the below bug >>>>> >>>>> 6755701 SunJCE DES/DESede SecretKeyFactory.generateSecret throws >>>>> InvalidKeySpecExc if passed SecretKeySpec >>>>> >>>>> http://cr.openjdk.java.net/~ascarpino/6755701/webrev.00/ >>>>> >>>>> Thanks >>>>> >>>>> Tony >>>> >>> > From paul.sandoz at oracle.com Wed Jul 3 12:45:33 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Wed, 03 Jul 2013 19:45:33 +0000 Subject: hg: jdk8/tl/jdk: 8017329: 8b92-lambda regression: TreeSet("a", "b").stream().substream(1).parallel().iterator() is empty Message-ID: <20130703194555.B9B5748789@hg.openjdk.java.net> Changeset: 7532bb2d6476 Author: psandoz Date: 2013-07-03 21:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7532bb2d6476 8017329: 8b92-lambda regression: TreeSet("a", "b").stream().substream(1).parallel().iterator() is empty Reviewed-by: alanb ! src/share/classes/java/util/stream/SliceOps.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java From jason.uh at oracle.com Wed Jul 3 12:52:27 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Wed, 03 Jul 2013 19:52:27 +0000 Subject: hg: jdk8/tl/jdk: 8019772: Fix doclint issues in javax.crypto and javax.security subpackages Message-ID: <20130703195302.91BF24878A@hg.openjdk.java.net> Changeset: d5de500c99a3 Author: juh Date: 2013-07-03 12:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5de500c99a3 8019772: Fix doclint issues in javax.crypto and javax.security subpackages Reviewed-by: darcy ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/CipherInputStream.java ! src/share/classes/javax/crypto/ExemptionMechanism.java ! src/share/classes/javax/crypto/KeyAgreement.java ! src/share/classes/javax/crypto/KeyGenerator.java ! src/share/classes/javax/crypto/NullCipher.java ! src/share/classes/javax/security/auth/Subject.java ! src/share/classes/javax/security/cert/X509Certificate.java From anthony.scarpino at oracle.com Wed Jul 3 13:55:09 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Wed, 03 Jul 2013 13:55:09 -0700 Subject: Code review request: 6755701 SecretKeySpec & DES In-Reply-To: <51D477D6.1060502@oracle.com> References: <51BA5F09.4040405@oracle.com> <51CDCA89.6040409@oracle.com> <51CE2B4B.4060306@oracle.com> <51D34433.9050603@oracle.com> <51D4718E.90500@oracle.com> <51D477D6.1060502@oracle.com> Message-ID: <51D48FAD.4040002@oracle.com> Just to follow up, we discussed the change offline and I added the checks.. Tony On 07/03/2013 12:13 PM, Valerie (Yu-Ching) Peng wrote: > > As I mentioned in my earlier email, I think you should add a check to > ensure that the result from theSecretKeySpec.getEncoded() has the right > length (i.e. 8 for DES, 24 for DESede) before passing them to > DESKey/DESedeKey. > Valerie > > On 07/03/13 11:46, Anthony Scarpino wrote: >> I updated the webrev to reflect the simple style change you mention >> below. I'm going to proceed with the pre-push jar signing procedures >> figuring the discussion regarding InvalidKeyException is not related >> to this exact fix. >> >> http://cr.openjdk.java.net/~ascarpino/6755701/webrev.01/ >> >> Tony >> >> On 07/02/2013 02:20 PM, Brad Wetmore wrote: >>> It's not common to use this style: >>> >>> 74 throw new InvalidKeySpecException >>> 75 ("Inappropriate key specification"); >>> >>> but rather: >>> >>> throw new InvalidKeySpecException( >>> "Inapp..."); >>> >>> Also, what happens in the case that the size doesn't match up with what >>> DESKey's constructor needs? For example, if you provide 7 bytes, won't >>> that throw a InvalidKeyException and thus you get a null back from >>> engineGenerateSecret? The SecretKeyFactory.generateSecret() API doesn't >>> mention anything about possibly getting a null back. >>> >>> I know that's the existing behavior, but that seems fishy to me. Bug in >>> API? >>> >>> Brad >>> >>> >>> >>> On 6/28/2013 5:33 PM, Xuelei Fan wrote: >>>> Looks fine to me. >>>> >>>> Xuelei >>>> >>>> On 6/29/2013 1:40 AM, Anthony Scarpino wrote: >>>>> ping... >>>>> >>>>> On 06/13/2013 05:08 PM, Anthony Scarpino wrote: >>>>>> Hi all, >>>>>> >>>>>> I'm requesting a code review for the below bug >>>>>> >>>>>> 6755701 SunJCE DES/DESede SecretKeyFactory.generateSecret throws >>>>>> InvalidKeySpecExc if passed SecretKeySpec >>>>>> >>>>>> http://cr.openjdk.java.net/~ascarpino/6755701/webrev.00/ >>>>>> >>>>>> Thanks >>>>>> >>>>>> Tony >>>>> >>>> >> > From vincent.x.ryan at oracle.com Wed Jul 3 14:38:21 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Wed, 03 Jul 2013 21:38:21 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130703213902.CE2F048792@hg.openjdk.java.net> Changeset: e594ee7a7c2f Author: vinnie Date: 2013-07-02 16:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e594ee7a7c2f 7165807: Non optimized initialization of NSS crypto library leads to scalability issues Reviewed-by: mullan, valeriep ! make/sun/security/pkcs11/mapfile-vers ! makefiles/mapfiles/libj2pkcs11/mapfile-vers ! src/share/classes/sun/security/pkcs11/Config.java ! src/share/classes/sun/security/pkcs11/Secmod.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java ! src/share/native/sun/security/pkcs11/j2secmod.c ! src/solaris/native/sun/security/pkcs11/j2secmod_md.h ! src/windows/native/sun/security/pkcs11/j2secmod_md.h Changeset: cbee2e595600 Author: vinnie Date: 2013-07-03 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cbee2e595600 Merge From joe.darcy at oracle.com Wed Jul 3 14:42:32 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 03 Jul 2013 21:42:32 +0000 Subject: hg: jdk8/tl/jdk: 8019857: Fix doclint errors in java.util.Format* Message-ID: <20130703214302.B967148793@hg.openjdk.java.net> Changeset: a49208237599 Author: bpb Date: 2013-07-03 13:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a49208237599 8019857: Fix doclint errors in java.util.Format* Summary: Fix doclint errors in java.util.Format*. Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/util/Formattable.java ! src/share/classes/java/util/Formatter.java From eric.mccorkle at oracle.com Wed Jul 3 16:47:43 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Wed, 03 Jul 2013 23:47:43 +0000 Subject: hg: jdk8/tl/jdk: 8016285: Add java.lang.reflect.Parameter.isNamePresent() Message-ID: <20130703234807.76FD2487A5@hg.openjdk.java.net> Changeset: a8f51c3341a5 Author: emc Date: 2013-07-03 19:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8f51c3341a5 8016285: Add java.lang.reflect.Parameter.isNamePresent() Summary: Add isNamePresent method to parameter reflection library, which indicates whether or real parameter data is available Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Parameter.java ! test/java/lang/reflect/Parameter/WithParameters.java ! test/java/lang/reflect/Parameter/WithoutParameters.java From joe.darcy at oracle.com Wed Jul 3 17:20:39 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 04 Jul 2013 00:20:39 +0000 Subject: hg: jdk8/tl/jdk: 8019862: Fix doclint errors in java.lang.*. Message-ID: <20130704002121.C1D9D487A6@hg.openjdk.java.net> Changeset: 043b2eb76b0e Author: bpb Date: 2013-07-03 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/043b2eb76b0e 8019862: Fix doclint errors in java.lang.*. Summary: Fix doclint errors in java.lang.* Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/lang/CharSequence.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/ProcessBuilder.java ! src/share/classes/java/lang/Runtime.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/lang/ThreadLocal.java From vicente.romero at oracle.com Thu Jul 4 02:36:38 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 04 Jul 2013 09:36:38 +0000 Subject: hg: jdk8/tl/langtools: 8009924: some langtools tools do not accept -cp as an alias for -classpath Message-ID: <20130704093643.35F32487C1@hg.openjdk.java.net> Changeset: d6158f8d7235 Author: vromero Date: 2013-07-04 10:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d6158f8d7235 8009924: some langtools tools do not accept -cp as an alias for -classpath Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! src/share/classes/com/sun/tools/javadoc/ToolOption.java ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javah/resources/l10n.properties ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/resources/javap.properties ! test/tools/doclint/tool/HelpTest.out From vicente.romero at oracle.com Thu Jul 4 02:43:43 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 04 Jul 2013 09:43:43 +0000 Subject: hg: jdk8/tl/langtools: 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members Message-ID: <20130704094348.55780487C2@hg.openjdk.java.net> Changeset: 79c3146e417b Author: vromero Date: 2013-07-04 10:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79c3146e417b 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/T6356530/SerializableAbstractClassWithNonAbstractMethodsTest.java + test/tools/javac/T6356530/SerializableAbstractClassWithNonAbstractMethodsTest.out From xuelei.fan at oracle.com Thu Jul 4 06:20:02 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 04 Jul 2013 21:20:02 +0800 Subject: Code Review Requests for 8012900: CICO ignores AAD in GCM mode In-Reply-To: <51B7AFC0.6050900@oracle.com> References: <51B7AFC0.6050900@oracle.com> Message-ID: <51D57682.40206@oracle.com> Hi Valerie, CC Brad. We start to run into the pain to get authentication tag appended in the tail of cipher text in our design. I looked back the discussion when we designed the APIs for GCM cipher in JDK 7. I found that when we run into GCM mode cipher operations, we may need to update the source code here or there because GCM cipher operation is a lot different than the old cipher modes. For example, in JSSE, we have to update the cipher operations to accept GCM mode ciphers. I two major concerns about buffering all cipher text in the underlying crypto library. One is about the performance impact, another one is about compatibility issues. When the size of cipher text/data is huge or the application is running in a heavy loaded system, there is a big impact on memory load and may impact the performance a lot. Even if we have to buffer the data in some special context, it would be better to do it in the particular context, but not in the crypto library level. There is two issues about compatibility. One is about how to use the Cipher.getOutputSize(). Yes, it is supposed to call this method before doing any update operation. But in practice, I think there is a lot applications that does not call this method. For example, in JSSE, it is supposed that the output size is not too much longer than the current input data length. In this fix, the application would have to heavily depends on the Cipher.getOutputSize() because the cipher text is buffered. And the return value of Cipher.getOutputSize() may be huge, which will prevent the reuse of memory (for example, ByteBuffer and array). Here is another performance impact. Another issue about compatibility is about the return value of Cipher.update(). In the past, it may be always can return a positive value if the input data is big enough (bigger than the block size). For example, in JSSE provider, we have code: int newLen = cipher.update(buf, offset, len, buf, offset); if (newLen != len) { throw new RuntimeException("Cipher buffering error " + "in JCE provider " + cipher.getProvider().getName()); } int newLen = cipher.update(dup, bb); if (newLen != len) { // catch BouncyCastle buffering error throw new RuntimeException("Cipher buffering error " + "in JCE provider " + cipher.getProvider().getName()); } If I'm correct, the above code will run into problems with this fix, because the return value the Cipehr.update() for GCM will return 0. I believe it is common in practice. Backing to this bug, if you want to buffering, I would suggest to doing the buffering in CI/CO classes rather than in GCM cipher implementation (performance issue is still a concern of mine, but the scope of the impact is limited). I think it is accept to me that we only checking the authentication tag at the end (CI/CO.close(), with IOException to catch authentication tag checking failure). The data may have been write to the I/O, therefor, applications who want to use GCM and CI/CO may need to take additional actions to handle the IOException. Xuelei On 6/12/2013 7:16 AM, Valerie (Yu-Ching) Peng wrote: > Xuelei, > > Here is another GCM and CipherInputStream/CipherOutputStream related > fix, i.e. for > 8012900: CICO ignores AAD in GCM mode > > The key changes are in CipherCore.java, GalorisCounterMode.java, the > rest files only have minor changes. > Essentially, when using AES/GCM cipher in decryption mode, the data will > be buffered and processed AFTER the tag has been verified. Otherwise, > most of the recovered text would be returned even if tag verification > failed later. > Given that CipherCore is shared by most modes, this particular buffering > is done inside the GCM impl. But then some more methods have to be > added/modified slightly so CipherCore will include this additional > buffering from the underneath level in its output size calculations, etc. > > The webrev is at: http://cr.openjdk.java.net/~valeriep/8012900/webrev.00/ > > Thanks, > Valerie > > From alan.bateman at oracle.com Thu Jul 4 06:56:02 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 04 Jul 2013 13:56:02 +0000 Subject: hg: jdk8/tl/jdk: 8019622: (sl) ServiceLoader.next incorrect when creation and usages are in different contexts Message-ID: <20130704135636.738E3487CA@hg.openjdk.java.net> Changeset: dd69273a0240 Author: alanb Date: 2013-07-04 14:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd69273a0240 8019622: (sl) ServiceLoader.next incorrect when creation and usages are in different contexts Reviewed-by: mchung, ahgross, forax, psandoz ! src/share/classes/java/util/ServiceLoader.java From mhall at mhcomputing.net Thu Jul 4 10:04:00 2013 From: mhall at mhcomputing.net (Matthew Hall) Date: Thu, 04 Jul 2013 10:04:00 -0700 Subject: Code Review Requests for 8012900: CICO ignores AAD in GCM mode In-Reply-To: <51D57682.40206@oracle.com> References: <51B7AFC0.6050900@oracle.com> <51D57682.40206@oracle.com> Message-ID: <961414a8-153a-4dbf-b5f5-293b5195bb97@email.android.com> I think the RFC might require that the auth tag gets checked first before any data from the block gets released to the application, to prevent performing any processing on any data that turns out to be insecure. Matthew. -- Sent from my mobile device. Xuelei Fan wrote: >Hi Valerie, > >CC Brad. > >We start to run into the pain to get authentication tag appended in the >tail of cipher text in our design. > >I looked back the discussion when we designed the APIs for GCM cipher >in >JDK 7. I found that when we run into GCM mode cipher operations, we >may >need to update the source code here or there because GCM cipher >operation is a lot different than the old cipher modes. For example, >in >JSSE, we have to update the cipher operations to accept GCM mode >ciphers. > >I two major concerns about buffering all cipher text in the underlying >crypto library. One is about the performance impact, another one is >about compatibility issues. > >When the size of cipher text/data is huge or the application is running >in a heavy loaded system, there is a big impact on memory load and may >impact the performance a lot. Even if we have to buffer the data in >some special context, it would be better to do it in the particular >context, but not in the crypto library level. > >There is two issues about compatibility. One is about how to use the >Cipher.getOutputSize(). Yes, it is supposed to call this method before >doing any update operation. But in practice, I think there is a lot >applications that does not call this method. For example, in JSSE, it >is >supposed that the output size is not too much longer than the current >input data length. In this fix, the application would have to heavily >depends on the Cipher.getOutputSize() because the cipher text is >buffered. And the return value of Cipher.getOutputSize() may be huge, >which will prevent the reuse of memory (for example, ByteBuffer and >array). Here is another performance impact. > >Another issue about compatibility is about the return value of >Cipher.update(). In the past, it may be always can return a positive >value if the input data is big enough (bigger than the block size). >For >example, in JSSE provider, we have code: > > int newLen = cipher.update(buf, offset, len, buf, offset); > if (newLen != len) { > throw new RuntimeException("Cipher buffering error " + > "in JCE provider " + cipher.getProvider().getName()); > } > > int newLen = cipher.update(dup, bb); > if (newLen != len) { > // catch BouncyCastle buffering error > throw new RuntimeException("Cipher buffering error " + > "in JCE provider " + cipher.getProvider().getName()); > } > >If I'm correct, the above code will run into problems with this fix, >because the return value the Cipehr.update() for GCM will return 0. I >believe it is common in practice. > >Backing to this bug, if you want to buffering, I would suggest to doing >the buffering in CI/CO classes rather than in GCM cipher implementation >(performance issue is still a concern of mine, but the scope of the >impact is limited). I think it is accept to me that we only checking >the authentication tag at the end (CI/CO.close(), with IOException to >catch authentication tag checking failure). The data may have been >write to the I/O, therefor, applications who want to use GCM and CI/CO >may need to take additional actions to handle the IOException. > >Xuelei > >On 6/12/2013 7:16 AM, Valerie (Yu-Ching) Peng wrote: >> Xuelei, >> >> Here is another GCM and CipherInputStream/CipherOutputStream related >> fix, i.e. for >> 8012900: CICO ignores AAD in GCM mode >> >> The key changes are in CipherCore.java, GalorisCounterMode.java, the >> rest files only have minor changes. >> Essentially, when using AES/GCM cipher in decryption mode, the data >will >> be buffered and processed AFTER the tag has been verified. Otherwise, >> most of the recovered text would be returned even if tag verification >> failed later. >> Given that CipherCore is shared by most modes, this particular >buffering >> is done inside the GCM impl. But then some more methods have to be >> added/modified slightly so CipherCore will include this additional >> buffering from the underneath level in its output size calculations, >etc. >> >> The webrev is at: >http://cr.openjdk.java.net/~valeriep/8012900/webrev.00/ >> >> Thanks, >> Valerie >> >> From alan.bateman at oracle.com Thu Jul 4 12:07:10 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 04 Jul 2013 19:07:10 +0000 Subject: hg: jdk8/tl/jdk: 8017231: Add StringJoiner.merge Message-ID: <20130704190737.15232487DD@hg.openjdk.java.net> Changeset: aa9fefb5d9c4 Author: alanb Date: 2013-07-04 20:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aa9fefb5d9c4 8017231: Add StringJoiner.merge Reviewed-by: psandoz, alanb Contributed-by: brian.goetz at oracle.com, henry.jen at oracle.com ! src/share/classes/java/util/StringJoiner.java + test/java/util/StringJoiner/MergeTest.java ! test/java/util/StringJoiner/StringJoinerTest.java From luchsh at linux.vnet.ibm.com Thu Jul 4 19:53:29 2013 From: luchsh at linux.vnet.ibm.com (luchsh at linux.vnet.ibm.com) Date: Fri, 05 Jul 2013 02:53:29 +0000 Subject: hg: jdk8/tl/jdk: 8019381: HashMap.isEmpty is non-final, potential issues for get/remove Message-ID: <20130705025350.81E7F487E6@hg.openjdk.java.net> Changeset: ed111451b77a Author: zhangshj Date: 2013-07-05 10:51 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ed111451b77a 8019381: HashMap.isEmpty is non-final, potential issues for get/remove Reviewed-by: chegar, mduigou ! src/share/classes/java/util/HashMap.java + test/java/util/HashMap/OverrideIsEmpty.java From maurizio.cimadamore at oracle.com Fri Jul 5 03:08:01 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Fri, 05 Jul 2013 10:08:01 +0000 Subject: hg: jdk8/tl/langtools: 5 new changesets Message-ID: <20130705100822.11A394881A@hg.openjdk.java.net> Changeset: 7b756b307e12 Author: mcimadamore Date: 2013-07-05 11:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7b756b307e12 8017618: NullPointerException in RichDiagnosticFormatter for bad input program Summary: RDF crashes when diagnostic contains type 'void' Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java + test/tools/javac/lambda/BadNestedLambda.java + test/tools/javac/lambda/BadNestedLambda.out Changeset: 70b37cdb19d5 Author: mcimadamore Date: 2013-07-05 11:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/70b37cdb19d5 8019480: Javac crashes when method is called on a type-variable receiver from lambda expression Summary: Logic for shortcircuiting speculative attribution doesn't handle type-variable receivers Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java + test/tools/javac/lambda/8019480/T8019480.java + test/tools/javac/lambda/8019480/T8019480.out Changeset: b0386f0dc28e Author: mcimadamore Date: 2013-07-05 11:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0386f0dc28e 8016059: Cannot compile following lambda 8016060: Lambda isn't compiled with return statement Summary: Spurious error triggered during unnecessary recovery round Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java + test/tools/javac/lambda/TargetType75.java Changeset: bfbedbfc522a Author: mcimadamore Date: 2013-07-05 11:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bfbedbfc522a 8016702: use of ternary operator in lambda expression gives incorrect results Summary: Constant types erroneously creep in during inference Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/conditional/T8016702.java Changeset: 42b3c5e92461 Author: mcimadamore Date: 2013-07-05 11:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/42b3c5e92461 8019824: very long error messages on inference error Summary: Inference error messages shows several spurious captured variables generated during an inference loop Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/8019824/T8019824.java + test/tools/javac/generics/inference/8019824/T8019824.out From valerie.peng at oracle.com Fri Jul 5 13:30:27 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 05 Jul 2013 13:30:27 -0700 Subject: Code Review Requests for 8012900: CICO ignores AAD in GCM mode In-Reply-To: <51D57682.40206@oracle.com> References: <51B7AFC0.6050900@oracle.com> <51D57682.40206@oracle.com> Message-ID: <51D72CE3.3030002@oracle.com> The purpose of the buffering is for security or conforming to the spec as far as I am concerned. We can't do the buffering in CICO classes as JCE Cipher class can be used directly. It seems best to handle this in the internal GCM implementation classes since CipherCore is somewhat general and I'd like to avoid the potentially-extensive (isGCM) check if we were to add the handling at the CipherCore level. As for the tag being appended to the cipher text, I think that's somewhat an industry convention for GCM impl, at least Solaris native Ucrypto library also assumes that the tag is appended after cipher text. It's true that some existing code have problem handing GCM due to its different nature, i.e. AEAD cipher which has AAD and generate/verify tag. We can only do our best to fit GCM into the current model. When people start using GCM and encounter problems, they'd have to fix problems in their code accordingly. Nothing we can do on our end. Once we agree on the buffering is necessary, then we can see how to minimize the performance impact, e.g. perhaps place an upper limit on input size, etc. Thanks, Valerie On 07/04/13 06:20, Xuelei Fan wrote: > Hi Valerie, > > CC Brad. > > We start to run into the pain to get authentication tag appended in the > tail of cipher text in our design. > > I looked back the discussion when we designed the APIs for GCM cipher in > JDK 7. I found that when we run into GCM mode cipher operations, we may > need to update the source code here or there because GCM cipher > operation is a lot different than the old cipher modes. For example, in > JSSE, we have to update the cipher operations to accept GCM mode ciphers. > > I two major concerns about buffering all cipher text in the underlying > crypto library. One is about the performance impact, another one is > about compatibility issues. > > When the size of cipher text/data is huge or the application is running > in a heavy loaded system, there is a big impact on memory load and may > impact the performance a lot. Even if we have to buffer the data in > some special context, it would be better to do it in the particular > context, but not in the crypto library level. > > There is two issues about compatibility. One is about how to use the > Cipher.getOutputSize(). Yes, it is supposed to call this method before > doing any update operation. But in practice, I think there is a lot > applications that does not call this method. For example, in JSSE, it is > supposed that the output size is not too much longer than the current > input data length. In this fix, the application would have to heavily > depends on the Cipher.getOutputSize() because the cipher text is > buffered. And the return value of Cipher.getOutputSize() may be huge, > which will prevent the reuse of memory (for example, ByteBuffer and > array). Here is another performance impact. > > Another issue about compatibility is about the return value of > Cipher.update(). In the past, it may be always can return a positive > value if the input data is big enough (bigger than the block size). For > example, in JSSE provider, we have code: > > int newLen = cipher.update(buf, offset, len, buf, offset); > if (newLen != len) { > throw new RuntimeException("Cipher buffering error " + > "in JCE provider " + cipher.getProvider().getName()); > } > > int newLen = cipher.update(dup, bb); > if (newLen != len) { > // catch BouncyCastle buffering error > throw new RuntimeException("Cipher buffering error " + > "in JCE provider " + cipher.getProvider().getName()); > } > > If I'm correct, the above code will run into problems with this fix, > because the return value the Cipehr.update() for GCM will return 0. I > believe it is common in practice. > > Backing to this bug, if you want to buffering, I would suggest to doing > the buffering in CI/CO classes rather than in GCM cipher implementation > (performance issue is still a concern of mine, but the scope of the > impact is limited). I think it is accept to me that we only checking > the authentication tag at the end (CI/CO.close(), with IOException to > catch authentication tag checking failure). The data may have been > write to the I/O, therefor, applications who want to use GCM and CI/CO > may need to take additional actions to handle the IOException. > > Xuelei > > On 6/12/2013 7:16 AM, Valerie (Yu-Ching) Peng wrote: >> Xuelei, >> >> Here is another GCM and CipherInputStream/CipherOutputStream related >> fix, i.e. for >> 8012900: CICO ignores AAD in GCM mode >> >> The key changes are in CipherCore.java, GalorisCounterMode.java, the >> rest files only have minor changes. >> Essentially, when using AES/GCM cipher in decryption mode, the data will >> be buffered and processed AFTER the tag has been verified. Otherwise, >> most of the recovered text would be returned even if tag verification >> failed later. >> Given that CipherCore is shared by most modes, this particular buffering >> is done inside the GCM impl. But then some more methods have to be >> added/modified slightly so CipherCore will include this additional >> buffering from the underneath level in its output size calculations, etc. >> >> The webrev is at: http://cr.openjdk.java.net/~valeriep/8012900/webrev.00/ >> >> Thanks, >> Valerie >> >> From sean.mullan at oracle.com Fri Jul 5 14:16:21 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Fri, 05 Jul 2013 21:16:21 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130705211658.8363648850@hg.openjdk.java.net> Changeset: 028ef97797c1 Author: mullan Date: 2013-07-05 15:54 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/028ef97797c1 8011547: Update XML Signature implementation to Apache Santuario 1.5.4 Reviewed-by: xuelei ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/Algorithm.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/JCEMapper.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/MessageDigestAlgorithm.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/SignatureAlgorithm.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/SignatureAlgorithmSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/IntegrityHmac.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureBaseRSA.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureDSA.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureECDSA.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/CanonicalizationException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/Canonicalizer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/CanonicalizerSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/InvalidCanonicalizerException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/helper/AttrCompare.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/helper/C14nHelper.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer11.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer11_OmitComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer11_WithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315Excl.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315ExclOmitComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315ExclWithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315OmitComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer20010315WithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/CanonicalizerBase.java + src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/CanonicalizerPhysical.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/NameSpaceSymbTable.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/UtfHelpper.java + src/share/classes/com/sun/org/apache/xml/internal/security/encryption/AbstractSerializer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/AgreementMethod.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/CipherData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/CipherReference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/CipherValue.java + src/share/classes/com/sun/org/apache/xml/internal/security/encryption/DocumentSerializer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptedData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptedKey.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptedType.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionMethod.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionProperties.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionProperty.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/Reference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/ReferenceList.java + src/share/classes/com/sun/org/apache/xml/internal/security/encryption/Serializer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/Transforms.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipherInput.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipherParameters.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLEncryptionException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/exceptions/AlgorithmAlreadyRegisteredException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/exceptions/Base64DecodingException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/exceptions/XMLSecurityException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/exceptions/XMLSecurityRuntimeException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/ContentHandlerAlreadyRegisteredException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/KeyInfo.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/KeyUtils.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/DEREncodedKeyValue.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyInfoContent.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyInfoReference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyName.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/KeyValue.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/MgmtData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/PGPData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/RetrievalMethod.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/SPKIData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/X509Data.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/DSAKeyValue.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/KeyValueContent.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/RSAKeyValue.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509CRL.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509Certificate.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509DataContent.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509Digest.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509IssuerSerial.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509SKI.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509SubjectName.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/InvalidKeyResolverException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolverException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolverSpi.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/DEREncodedKeyValueResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/DSAKeyValueResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/EncryptedKeyResolver.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/KeyInfoReferenceResolver.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/PrivateKeyResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/RSAKeyValueResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/RetrievalMethodResolver.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/SecretKeyResolver.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/SingleKeyResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509CertificateResolver.java + src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509DigestResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509IssuerSerialResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509SKIResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/X509SubjectNameResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/StorageResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/StorageResolverException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/StorageResolverSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/CertsInFilesystemDirectoryResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/KeyStoreResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/SingleCertificateResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/config.xml - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/xmlsecurity_de.properties ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/xmlsecurity_en.properties ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/InvalidDigestValueException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/InvalidSignatureValueException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/Manifest.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/MissingResourceFailureException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/NodeFilter.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/ObjectContainer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/Reference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/ReferenceNotInitializedException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/SignatureProperties.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/SignatureProperty.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/SignedInfo.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignature.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignatureException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignatureInput.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignatureInputDebugger.java + src/share/classes/com/sun/org/apache/xml/internal/security/signature/reference/ReferenceData.java + src/share/classes/com/sun/org/apache/xml/internal/security/signature/reference/ReferenceNodeSetData.java + src/share/classes/com/sun/org/apache/xml/internal/security/signature/reference/ReferenceOctetStreamData.java + src/share/classes/com/sun/org/apache/xml/internal/security/signature/reference/ReferenceSubTreeData.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/InvalidTransformException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/Transform.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/TransformParam.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/TransformSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/TransformationException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/Transforms.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHere.java - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformBase64Decode.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14N.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14N11.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14N11_WithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14NExclusive.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14NExclusiveWithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformC14NWithComments.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformEnvelopedSignature.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXPath.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXPath2Filter.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXPointer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXSLT.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/InclusiveNamespaces.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPath2FilterContainer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPath2FilterContainer04.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPathContainer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/params/XPathFilterCHGPContainer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/Base64.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/ClassLoaderUtils.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/Constants.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/DOMNamespaceContext.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/DigesterOutputStream.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementChecker.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementCheckerImpl.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementProxy.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionConstants.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionElementProxy.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/HelperNodeList.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/IdResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/IgnoreAllErrorHandler.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/JDKXPathAPI.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/JDKXPathFactory.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/JavaUtils.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/RFC2253Parser.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/Signature11ElementProxy.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/SignatureElementProxy.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/SignerOutputStream.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/UnsyncBufferedOutputStream.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/UnsyncByteArrayOutputStream.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/XMLUtils.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathAPI.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFactory.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/XalanXPathAPI.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/XalanXPathFactory.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolver.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolverContext.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolverException.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolverSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverAnonymous.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverDirectHTTP.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverFragment.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverLocalFilesystem.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverXPointer.java ! src/share/classes/org/jcp/xml/dsig/internal/DigesterOutputStream.java ! src/share/classes/org/jcp/xml/dsig/internal/MacOutputStream.java ! src/share/classes/org/jcp/xml/dsig/internal/SignerOutputStream.java + src/share/classes/org/jcp/xml/dsig/internal/dom/AbstractDOMSignatureMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheNodeSetData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheOctetStreamData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMBase64Transform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14N11Method.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14NMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalizationMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCryptoBinary.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMDigestMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMEnvelopedTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMExcC14NMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMHMACSignatureMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfo.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfoFactory.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyName.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyValue.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMPGPData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperty.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMStructure.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSubTreeData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMURIDereferencer.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509Data.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509IssuerSerial.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLObject.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXSLTTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/Utils.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java Changeset: e3208dbf6926 Author: mullan Date: 2013-07-05 16:30 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3208dbf6926 Merge - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java - test/java/util/Comparators/BasicTest.java - test/sun/security/krb5/auto/ReplayCache.java From lana.steuck at oracle.com Fri Jul 5 14:40:23 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 05 Jul 2013 21:40:23 +0000 Subject: hg: jdk8/tl/corba: Added tag jdk8-b97 for changeset 469995a8e974 Message-ID: <20130705214025.361BE48859@hg.openjdk.java.net> Changeset: 3370fb6146e4 Author: cl Date: 2013-07-04 01:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/3370fb6146e4 Added tag jdk8-b97 for changeset 469995a8e974 ! .hgtags From lana.steuck at oracle.com Fri Jul 5 14:40:29 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 05 Jul 2013 21:40:29 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20130705214032.7F3144885B@hg.openjdk.java.net> Changeset: da63a99481da Author: cl Date: 2013-07-04 01:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/da63a99481da Added tag jdk8-b97 for changeset 1bf1d6ce3042 ! .hgtags Changeset: 542b7803f038 Author: lana Date: 2013-07-05 11:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/542b7803f038 Merge From lana.steuck at oracle.com Fri Jul 5 14:40:32 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 05 Jul 2013 21:40:32 +0000 Subject: hg: jdk8/tl/jaxws: Added tag jdk8-b97 for changeset dcde7f049111 Message-ID: <20130705214036.0BA464885C@hg.openjdk.java.net> Changeset: b1fb4612a2ca Author: cl Date: 2013-07-04 01:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b1fb4612a2ca Added tag jdk8-b97 for changeset dcde7f049111 ! .hgtags From lana.steuck at oracle.com Fri Jul 5 14:40:28 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 05 Jul 2013 21:40:28 +0000 Subject: hg: jdk8/tl: 9 new changesets Message-ID: <20130705214029.033E44885A@hg.openjdk.java.net> Changeset: f5eb23490e6a Author: erikj Date: 2013-06-27 09:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/f5eb23490e6a 8017047: Can't use --with-java-devtools and --with-devkit at the same time Reviewed-by: tbell ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: e5cf1735638c Author: erikj Date: 2013-06-28 11:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e5cf1735638c 8016605: New files dont apear in src.zip Reviewed-by: tbell ! common/makefiles/JavaCompilation.gmk Changeset: 0871b5799149 Author: erikj Date: 2013-06-28 11:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0871b5799149 8019229: Build Configuration Fail in Windows Platform Reviewed-by: chegar, tbell, dxu ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: 0e533ceee717 Author: erikj Date: 2013-06-28 12:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0e533ceee717 8016303: make CONF= isn't working Reviewed-by: tbell ! NewMakefile.gmk Changeset: 78aaf5d3314d Author: erikj Date: 2013-06-28 12:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/78aaf5d3314d 8010385: build with LOG=trace broken on mac Reviewed-by: dholmes, tbell, prr ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/MakeBase.gmk Changeset: dd3b314f4471 Author: erikj Date: 2013-07-01 15:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/dd3b314f4471 8009744: build-infra: REGRESSION: Publisher was NOT set for some JDK files Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: b2b87e9e8683 Author: erikj Date: 2013-07-02 15:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b2b87e9e8683 8019537: jdk8-build prebuild fails in source bundle generation, The path of TOOLS_DIR ... is not found Reviewed-by: tbell ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: a1c1e8bf71f3 Author: katleman Date: 2013-07-02 15:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a1c1e8bf71f3 Merge Changeset: 99ad803f8c4e Author: cl Date: 2013-07-04 01:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/99ad803f8c4e Added tag jdk8-b97 for changeset a1c1e8bf71f3 ! .hgtags From lana.steuck at oracle.com Fri Jul 5 14:40:33 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 05 Jul 2013 21:40:33 +0000 Subject: hg: jdk8/tl/jaxp: 3 new changesets Message-ID: <20130705214043.3469B4885D@hg.openjdk.java.net> Changeset: c96691d84a7c Author: katleman Date: 2013-06-28 16:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c96691d84a7c 8019347: JDK8 b96 source with GPL header errors Reviewed-by: iris, alanb, lancea ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_de.properties ! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_es.properties ! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_it.properties ! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_zh_TW.properties Changeset: 6c830db28d21 Author: katleman Date: 2013-07-02 15:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6c830db28d21 Merge Changeset: 15e5bb51bc0c Author: cl Date: 2013-07-04 01:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/15e5bb51bc0c Added tag jdk8-b97 for changeset 6c830db28d21 ! .hgtags From lana.steuck at oracle.com Fri Jul 5 14:40:32 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 05 Jul 2013 21:40:32 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20130705214045.302BB4885E@hg.openjdk.java.net> Changeset: 2364e94ae67b Author: cl Date: 2013-07-04 01:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2364e94ae67b Added tag jdk8-b97 for changeset 6a11a81a8824 ! .hgtags Changeset: ce5a90df517b Author: lana Date: 2013-07-05 11:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ce5a90df517b Merge Changeset: 49654c9c705b Author: lana Date: 2013-07-05 13:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/49654c9c705b Merge From lana.steuck at oracle.com Fri Jul 5 14:40:39 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 05 Jul 2013 21:40:39 +0000 Subject: hg: jdk8/tl/hotspot: 26 new changesets Message-ID: <20130705214136.249194885F@hg.openjdk.java.net> Changeset: fc8a1a5de78e Author: amurillo Date: 2013-06-21 00:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fc8a1a5de78e 8017253: new hotspot build - hs25-b39 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 91acb82a8b7a Author: dholmes Date: 2013-06-19 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/91acb82a8b7a 8014326: [OSX] All libjvm symbols are exported Summary: Add support for a MacOS X compatible form of the libjvm mapfile. Reviewed-by: dcubed, rdurbin, coleenp ! make/bsd/makefiles/build_vm_def.sh ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product Changeset: b9f4c4ec0f50 Author: iklam Date: 2013-06-19 20:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b9f4c4ec0f50 8008964: NPG: Memory regression: Thread::_metadata_handles uses 1 KB per thread. Summary: Reduce default size of Thread::_metadata_handles from 300 to 30 Reviewed-by: coleenp, sspitsyn ! src/share/vm/runtime/thread.cpp Changeset: b3cd8b58b798 Author: mgronlun Date: 2013-06-20 11:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b3cd8b58b798 8016735: Remove superfluous EnableInvokeDynamic warning from UnlockDiagnosticVMOptions check Reviewed-by: sla, dholmes ! src/share/vm/runtime/globals.cpp Changeset: 9ba41a4a71ff Author: coleenp Date: 2013-06-21 10:50 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9ba41a4a71ff 8004124: Handle and/or warn about SI_KERNEL Summary: Detect this crash in the signal handler and give a fatal error message instead of making us chase down bugs that don't reproduce Reviewed-by: kvn, mgerdin, dholmes ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: bed34a7a3b9b Author: coleenp Date: 2013-06-21 10:57 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bed34a7a3b9b 8017177: more explicit code location information in hs_err crash log Summary: Add code pc location for compiled code Reviewed-by: kvn, coleenp Contributed-by: doug.simon at oracle.com ! src/share/vm/runtime/frame.cpp Changeset: bb6c7f2f10fd Author: dcubed Date: 2013-06-21 08:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bb6c7f2f10fd Merge Changeset: b7bc7c94b4b5 Author: dcubed Date: 2013-06-21 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b7bc7c94b4b5 Merge - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp Changeset: d9eed26d638a Author: iklam Date: 2013-06-23 22:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d9eed26d638a 8009575: Reduce Symbol::_refcount from 4 bytes to 2 bytes Summary: Added Atomic::inc(short*) to support this change. Reviewed-by: coleenp, dcubed, dholmes, minqi ! src/share/vm/oops/symbol.cpp ! src/share/vm/oops/symbol.hpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/atomic.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: e0c9a1d29eb4 Author: coleenp Date: 2013-06-24 18:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e0c9a1d29eb4 8016325: JVM hangs verifying system dictionary Summary: Minimize redundant verifications of Klasses. Reviewed-by: hseigel, jmasa ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/code/debugInfo.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/arrayKlass.hpp ! src/share/vm/oops/compiledICHolder.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/shark/sharkBuilder.cpp Changeset: 01e10b366055 Author: sla Date: 2013-06-25 14:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/01e10b366055 8017561: Build errors caused by missing .PHONY Reviewed-by: stefank, brutisso ! make/excludeSrc.make Changeset: feae15578b2f Author: tamao Date: 2013-06-07 09:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/feae15578b2f 7122222: GC log is limited to 2G for 32-bit Summary: Enable large file support for generated 32-bit ostream.o on Linux and Solaris (as only the two need this) by setting -D_FILE_OFFSET_BITS=64 in compilation Reviewed-by: tbell, mgerdin, dcubed Contributed-by: tamao ! make/linux/makefiles/vm.make ! make/solaris/makefiles/vm.make ! src/os/solaris/vm/os_solaris.inline.hpp Changeset: df7e1c0e3dc1 Author: jmasa Date: 2013-06-25 09:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/df7e1c0e3dc1 8014546: MetaspaceAux print_metaspace_change() should print "used" after GC not capacity Reviewed-by: johnc, tschatzl ! src/share/vm/memory/metaspace.cpp Changeset: f99cd6e20ab1 Author: jmasa Date: 2013-06-25 15:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f99cd6e20ab1 8014851: UseAdaptiveGCBoundary is broken Reviewed-by: tschatzl, brutisso ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.hpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.hpp + test/gc/parallelScavenge/AdaptiveGCBoundary.java Changeset: 71963b3f802a Author: ehelin Date: 2013-06-26 16:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/71963b3f802a 8013590: NPG: Add a memory pool MXBean for Metaspace Reviewed-by: jmasa, mgerdin ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/memoryManager.cpp ! src/share/vm/services/memoryManager.hpp ! src/share/vm/services/memoryPool.cpp ! src/share/vm/services/memoryPool.hpp ! src/share/vm/services/memoryService.cpp ! src/share/vm/services/memoryService.hpp + test/gc/metaspace/TestMetaspaceMemoryPool.java Changeset: f8972b867ded Author: ehelin Date: 2013-06-27 10:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f8972b867ded Merge Changeset: 7875ea94bea5 Author: goetz Date: 2013-06-24 11:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7875ea94bea5 8017308: Remove unused breakpoint relocation type Summary: remove unused breakpoint relocation type Reviewed-by: kvn ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/x86/vm/relocInfo_x86.cpp ! src/cpu/zero/vm/relocInfo_zero.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/code/relocInfo.hpp Changeset: cc63bcb47cce Author: twisti Date: 2013-06-24 17:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cc63bcb47cce 8017538: Clang support broke slowdebug build for i586 Reviewed-by: kvn ! make/linux/makefiles/gcc.make Changeset: a023da4ffc15 Author: twisti Date: 2013-06-24 18:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a023da4ffc15 Merge Changeset: 3aa636f2a743 Author: adlertz Date: 2013-06-25 12:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3aa636f2a743 8017243: 8001345 is incomplete Summary: Replaces unused decodeN at MemBarAcquire with its corresponding loadN if loadN is used at more than one place. Reviewed-by: kvn, twisti ! src/share/vm/opto/memnode.cpp Changeset: 9347cae673f0 Author: adlertz Date: 2013-06-26 00:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9347cae673f0 8017510: Add a regression test for 8005956 Summary: Regression test for 8005956 Reviewed-by: kvn, twisti + test/compiler/8005956/PolynomialRoot.java Changeset: 6a0ead6dc6db Author: goetz Date: 2013-06-24 16:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6a0ead6dc6db 8017531: 8010460 changes broke bytecodeInterpreter.cpp Summary: Replace _indy by _jsr292 and also fix VERIFY_OOP macros. Reviewed-by: kvn ! src/share/vm/interpreter/bytecodeInterpreter.cpp Changeset: be0600ec1102 Author: kvn Date: 2013-06-27 11:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/be0600ec1102 Merge Changeset: 2b9380b0bf0b Author: amurillo Date: 2013-06-28 02:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2b9380b0bf0b Merge ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/universe.cpp Changeset: d197d377ab2e Author: amurillo Date: 2013-06-28 02:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d197d377ab2e Added tag hs25-b39 for changeset 2b9380b0bf0b ! .hgtags Changeset: 2bfa00fac03f Author: cl Date: 2013-07-04 01:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2bfa00fac03f Added tag jdk8-b97 for changeset d197d377ab2e ! .hgtags From lana.steuck at oracle.com Fri Jul 5 14:44:30 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 05 Jul 2013 21:44:30 +0000 Subject: hg: jdk8/tl/jdk: 20 new changesets Message-ID: <20130705214839.9E12248860@hg.openjdk.java.net> Changeset: 8339c83b16c6 Author: ehelin Date: 2013-07-02 13:06 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8339c83b16c6 8019500: Exclude MemoryTest.java and MemoryTestAllGC.sh to enable integration Reviewed-by: erikj, alanb ! test/ProblemList.txt Changeset: 87cab043cb5e Author: katleman Date: 2013-06-28 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/87cab043cb5e 8019347: JDK8 b96 source with GPL header errors Reviewed-by: iris, alanb, lancea ! makefiles/sun/awt/ToBin.java ! src/share/classes/javax/xml/crypto/dsig/dom/DOMValidateContext.java ! test/java/awt/Mouse/EnterExitEvents/FullscreenEnterEventTest.java ! test/java/lang/ThreadGroup/Suspend.java Changeset: 978a95239044 Author: katleman Date: 2013-07-02 15:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/978a95239044 Merge Changeset: 4b21dcfdcc3b Author: cl Date: 2013-07-04 01:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b21dcfdcc3b Added tag jdk8-b97 for changeset 978a95239044 ! .hgtags Changeset: 5cfcd545ce4a Author: vadim Date: 2013-06-26 13:49 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5cfcd545ce4a 8016254: several sun/java2d/OpenGL tests failed with SIGFPE Reviewed-by: prr, bae ! src/share/native/sun/java2d/opengl/OGLContext.c Changeset: 3ffa38871143 Author: lana Date: 2013-06-28 19:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3ffa38871143 Merge - make/sun/xawt/ToBin.java - makefiles/sun/awt/X11/ToBin.java - src/share/classes/sun/misc/FDBigInt.java - src/share/classes/sun/misc/Hashing.java - src/solaris/classes/sun/awt/X11/XIconInfo.java - src/solaris/classes/sun/awt/X11/security-icon-bw16.png - src/solaris/classes/sun/awt/X11/security-icon-bw24.png - src/solaris/classes/sun/awt/X11/security-icon-bw32.png - src/solaris/classes/sun/awt/X11/security-icon-bw48.png - src/solaris/classes/sun/awt/X11/security-icon-interim16.png - src/solaris/classes/sun/awt/X11/security-icon-interim24.png - src/solaris/classes/sun/awt/X11/security-icon-interim32.png - src/solaris/classes/sun/awt/X11/security-icon-interim48.png - src/solaris/classes/sun/awt/X11/security-icon-yellow16.png - src/solaris/classes/sun/awt/X11/security-icon-yellow24.png - src/solaris/classes/sun/awt/X11/security-icon-yellow32.png - src/solaris/classes/sun/awt/X11/security-icon-yellow48.png - test/java/lang/invoke/7196190/MHProxyTest.java - test/sun/misc/Hashing.java Changeset: 6dda4a069a83 Author: prr Date: 2013-07-01 12:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6dda4a069a83 8015144: Performance regression in ICU OpenType Layout library Reviewed-by: srl, jgodinez ! make/sun/font/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/native/sun/font/layout/GlyphIterator.cpp ! src/share/native/sun/font/layout/GlyphIterator.h ! src/share/native/sun/font/layout/LETableReference.h ! src/share/native/sun/font/layout/OpenTypeUtilities.cpp Changeset: 6d2b5ec2ec79 Author: prr Date: 2013-07-02 14:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d2b5ec2ec79 8019692: JDK build CC_OPT_HIGHEST setting isn't valid for Sun C++ compiler Reviewed-by: jgodinez ! make/sun/font/Makefile ! makefiles/CompileNativeLibraries.gmk Changeset: 1c607ebfc180 Author: leonidr Date: 2013-06-20 18:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c607ebfc180 8014264: The applet pathguy_TimeDead throws java.lang.NullPointerException in java console once click drop-down check box. Reviewed-by: art, anthony, serb ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java ! src/solaris/classes/sun/awt/X11/XListPeer.java Changeset: b7b95b7ab2cb Author: malenkov Date: 2013-06-21 17:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7b95b7ab2cb 8016545: java.beans.XMLEncoder.writeObject output is wrong Reviewed-by: alexsch ! src/share/classes/java/beans/XMLEncoder.java + test/java/beans/XMLEncoder/Test8016545.java Changeset: eed321190272 Author: alitvinov Date: 2013-06-21 21:30 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eed321190272 8007642: Media Names on Java Print Do Not Match the Printer???s and Confuse Users Reviewed-by: prr, jgodinez ! src/windows/classes/sun/print/Win32PrintService.java Changeset: e5bac76282f7 Author: pchelko Date: 2013-06-27 13:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e5bac76282f7 8019236: [macosx] Add javadoc to the handleWindowFocusEvent in CEmbeddedFrame Reviewed-by: serb, ant ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java Changeset: 72f167edf630 Author: dmarkov Date: 2013-06-28 18:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72f167edf630 8016534: javax/swing/text/View/8014863/bug8014863.java failed Reviewed-by: alexp, alexsch ! test/javax/swing/text/View/8014863/bug8014863.java Changeset: 228ec4b9111a Author: lana Date: 2013-06-28 18:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/228ec4b9111a Merge - make/sun/xawt/ToBin.java - makefiles/sun/awt/X11/ToBin.java ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java - src/share/classes/sun/misc/FDBigInt.java - src/share/classes/sun/misc/Hashing.java ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java - src/solaris/classes/sun/awt/X11/XIconInfo.java ! src/solaris/classes/sun/awt/X11/XListPeer.java - src/solaris/classes/sun/awt/X11/security-icon-bw16.png - src/solaris/classes/sun/awt/X11/security-icon-bw24.png - src/solaris/classes/sun/awt/X11/security-icon-bw32.png - src/solaris/classes/sun/awt/X11/security-icon-bw48.png - src/solaris/classes/sun/awt/X11/security-icon-interim16.png - src/solaris/classes/sun/awt/X11/security-icon-interim24.png - src/solaris/classes/sun/awt/X11/security-icon-interim32.png - src/solaris/classes/sun/awt/X11/security-icon-interim48.png - src/solaris/classes/sun/awt/X11/security-icon-yellow16.png - src/solaris/classes/sun/awt/X11/security-icon-yellow24.png - src/solaris/classes/sun/awt/X11/security-icon-yellow32.png - src/solaris/classes/sun/awt/X11/security-icon-yellow48.png ! src/windows/classes/sun/print/Win32PrintService.java - test/java/lang/invoke/7196190/MHProxyTest.java - test/sun/misc/Hashing.java Changeset: 6fc558b41d8e Author: lana Date: 2013-07-02 15:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6fc558b41d8e Merge Changeset: 11c074904fce Author: lana Date: 2013-07-02 15:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11c074904fce Merge - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java - test/java/util/Comparators/BasicTest.java - test/sun/security/krb5/auto/ReplayCache.java Changeset: 974b94f944ce Author: lana Date: 2013-07-03 19:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/974b94f944ce Merge - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java - test/java/util/Comparators/BasicTest.java - test/sun/security/krb5/auto/ReplayCache.java Changeset: f2342dedf04a Author: lana Date: 2013-07-05 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2342dedf04a Merge Changeset: 49c5547d9e8e Author: lana Date: 2013-07-05 13:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49c5547d9e8e Merge Changeset: 4fcabe8e22ce Author: lana Date: 2013-07-05 14:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4fcabe8e22ce Merge - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java From bradford.wetmore at oracle.com Fri Jul 5 18:24:01 2013 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Sat, 06 Jul 2013 01:24:01 +0000 Subject: hg: jdk8/tl/jdk: 8019341: Update CookieHttpsClientTest to use the newer framework. Message-ID: <20130706012427.9957D4886A@hg.openjdk.java.net> Changeset: 11c15607e43f Author: wetmore Date: 2013-07-05 18:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11c15607e43f 8019341: Update CookieHttpsClientTest to use the newer framework. Reviewed-by: xuelei, smarks, michaelm ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java ! test/sun/security/ssl/templates/SSLEngineTemplate.java ! test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.java ! test/sun/security/ssl/templates/SSLSocketTemplate.java From sundararajan.athijegannathan at oracle.com Mon Jul 8 06:31:03 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 08 Jul 2013 13:31:03 +0000 Subject: hg: jdk8/tl/nashorn: 20 new changesets Message-ID: <20130708133120.3DFB54889B@hg.openjdk.java.net> Changeset: 313bdcd2fd22 Author: sundar Date: 2013-07-03 00:08 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/313bdcd2fd22 8019629: void operator should always evaluate to undefined Reviewed-by: jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8019629.js Changeset: 9d3a9fdab668 Author: sundar Date: 2013-07-03 13:13 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9d3a9fdab668 8019783: typeof does not work properly for java methods and foreign objects Reviewed-by: hannesw ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8019783.js + test/script/basic/JDK-8019783.js.EXPECTED ! test/script/basic/NASHORN-759.js.EXPECTED Changeset: 4afdc5bec43b Author: sundar Date: 2013-07-03 14:08 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4afdc5bec43b 8019791: ~ is a unary operator Reviewed-by: hannesw ! src/jdk/nashorn/internal/parser/TokenType.java + test/script/basic/JDK-8019791.js + test/script/basic/JDK-8019791.js.EXPECTED Changeset: 18d467e94150 Author: attila Date: 2013-07-03 12:39 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/18d467e94150 8010946: AccessControl.doPrivileged is broken when called from js script Reviewed-by: jlaskey, sundar ! make/build.xml ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/beans/ApplicableOverloadedMethods.java + src/jdk/internal/dynalink/beans/CallerSensitiveDetector.java + src/jdk/internal/dynalink/beans/CallerSensitiveDynamicMethod.java ! src/jdk/internal/dynalink/beans/ClassString.java ! src/jdk/internal/dynalink/beans/DynamicMethod.java ! src/jdk/internal/dynalink/beans/DynamicMethodLinker.java ! src/jdk/internal/dynalink/beans/FacetIntrospector.java ! src/jdk/internal/dynalink/beans/MaximallySpecific.java ! src/jdk/internal/dynalink/beans/OverloadedDynamicMethod.java ! src/jdk/internal/dynalink/beans/OverloadedMethod.java ! src/jdk/internal/dynalink/beans/SimpleDynamicMethod.java + src/jdk/internal/dynalink/beans/SingleDynamicMethod.java ! src/jdk/internal/dynalink/beans/StaticClassIntrospector.java ! src/jdk/internal/dynalink/beans/StaticClassLinker.java ! src/jdk/internal/dynalink/support/AbstractCallSiteDescriptor.java ! src/jdk/internal/dynalink/support/Lookup.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java + test/script/basic/JDK-8010946-2.js + test/script/basic/JDK-8010946-2.js.EXPECTED + test/script/basic/JDK-8010946-privileged.js + test/script/basic/JDK-8010946.js + test/script/basic/JDK-8010946.js.EXPECTED Changeset: b1980b5f00a1 Author: lagergren Date: 2013-07-03 13:03 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b1980b5f00a1 8019585: Sometimes a var declaration using itself in its init wasn't declared as canBeUndefined, causing erroneous bytecode Reviewed-by: sundar, attila ! src/jdk/nashorn/api/scripting/NashornException.java ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java + test/script/basic/JDK-8019585.js Changeset: eb1437d16ab4 Author: sundar Date: 2013-07-03 17:26 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/eb1437d16ab4 8019805: for each (init; test; modify) is invalid Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/JDK-8019805.js + test/script/basic/JDK-8019805.js.EXPECTED ! test/script/basic/forin.js ! test/script/basic/forin.js.EXPECTED Changeset: 961cffae0828 Author: lagergren Date: 2013-07-03 15:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/961cffae0828 8019811: Static calls - self referential functions needed a return type conversion if they were specialized, as they can't use the same mechanism as indy calls Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! test/script/basic/JDK-8016667.js + test/script/basic/JDK-8019808.js + test/script/basic/JDK-8019810.js + test/script/basic/JDK-8019810.js.EXPECTED + test/script/basic/JDK-8019811.js + test/script/basic/JDK-8019817.js + test/script/currently-failing/JDK-8019809.js Changeset: fcb484c43348 Author: sundar Date: 2013-07-03 19:20 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fcb484c43348 8019814: Add regression test for passing cases Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/ListAdapter.java + test/script/basic/JDK-8019814.js + test/script/basic/JDK-8019814.js.EXPECTED Changeset: 29b2b2ed954c Author: attila Date: 2013-07-03 18:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/29b2b2ed954c 8017768: allow dot as inner class name separator for Java.type Reviewed-by: jlaskey, sundar ! docs/JavaScriptingProgrammersGuide.html ! src/jdk/nashorn/internal/objects/NativeJava.java + test/script/basic/JDK-8017768.js + test/script/basic/JDK-8017768.js.EXPECTED ! test/src/jdk/nashorn/test/models/OuterClass.java Changeset: 7b072ebdf5aa Author: jlaskey Date: 2013-07-03 13:41 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7b072ebdf5aa 8011629: Object.defineProperty performance issue Reviewed-by: sundar, attila Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/AccessorProperty.java Changeset: ad6b18ee4666 Author: attila Date: 2013-07-04 14:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ad6b18ee4666 8019809: return after break incorrectly sets the block as terminal Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java + test/script/basic/JDK-8019809.js - test/script/currently-failing/JDK-8019809.js Changeset: be2087629eb9 Author: lagergren Date: 2013-07-04 17:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/be2087629eb9 8019821: allInteger switches were confused by boolean cases, as they are a narrower type than int Reviewed-by: sundar, hannesw ! src/jdk/nashorn/internal/codegen/Attr.java + test/script/basic/JDK-8019821.js Changeset: 8c4a6d9b8a23 Author: lagergren Date: 2013-07-04 17:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8c4a6d9b8a23 Merge - test/script/currently-failing/JDK-8019809.js Changeset: ec84ba68ad39 Author: sundar Date: 2013-07-05 14:38 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ec84ba68ad39 8019947: inherited property invalidation does not work with two globals in same context Reviewed-by: jlaskey, lagergren, hannesw, attila ! make/build-nasgen.xml ! make/build.xml ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/BoundScriptFunctionImpl.java ! src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeArrayBuffer.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeEvalError.java ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/NativeJavaImporter.java ! src/jdk/nashorn/internal/objects/NativeMath.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/objects/NativeRangeError.java ! src/jdk/nashorn/internal/objects/NativeReferenceError.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/objects/NativeSyntaxError.java ! src/jdk/nashorn/internal/objects/NativeTypeError.java ! src/jdk/nashorn/internal/objects/NativeURIError.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/GlobalFunctions.java ! src/jdk/nashorn/internal/runtime/GlobalObject.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java ! src/jdk/nashorn/internal/scripts/JO.java ! src/jdk/nashorn/tools/Shell.java + test/script/basic/JDK-8019947.js + test/script/basic/JDK-8019947.js.EXPECTED Changeset: edca88d3a03e Author: hannesw Date: 2013-07-05 14:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/edca88d3a03e 8017084: Use spill properties for large object literals Reviewed-by: lagergren, sundar ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java + src/jdk/nashorn/internal/codegen/SpillObjectCreator.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/scripts/JO.java + test/script/basic/JDK-8017084.js + test/script/basic/JDK-8017084.js.EXPECTED Changeset: ce9cbe70f915 Author: attila Date: 2013-07-05 15:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ce9cbe70f915 8019819: scope symbol didn't get a slot in certain cases Reviewed-by: hannesw, jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8019819.js Changeset: 20b2c2dc20e8 Author: lagergren Date: 2013-07-05 19:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/20b2c2dc20e8 8019983: Void returns combined with return with expression picked the wrong return type Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java + test/script/basic/JDK-8019983.js + test/script/basic/JDK-8019983.js.EXPECTED Changeset: 36d6b6a3fbe0 Author: sundar Date: 2013-07-08 16:33 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/36d6b6a3fbe0 8020015: shared PropertyMaps should not be used without duplication Reviewed-by: hannesw, attila ! buildtools/nasgen/build.xml ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/MethodGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/PrototypeGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java ! make/code_coverage.xml ! make/project.properties ! src/jdk/nashorn/internal/lookup/Lookup.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeMath.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/PropertyListenerManager.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! src/jdk/nashorn/internal/scripts/JO.java ! src/jdk/nashorn/tools/Shell.java Changeset: a75e75cc6a61 Author: sundar Date: 2013-07-08 18:36 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a75e75cc6a61 8020035: nashorn jdk buildfile BuildNashorn.gmk still renamed jdk.nashorn.internal.objects package Reviewed-by: attila, jlaskey ! makefiles/BuildNashorn.gmk Changeset: c96745616167 Author: sundar Date: 2013-07-08 18:43 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c96745616167 Merge From jesper.wilhelmsson at oracle.com Mon Jul 8 03:56:47 2013 From: jesper.wilhelmsson at oracle.com (jesper.wilhelmsson at oracle.com) Date: Mon, 08 Jul 2013 10:56:47 +0000 Subject: hg: jdk8/tl/jdk: 8010734: NPG: The test MemoryTest.java needs to be updated to support metaspace Message-ID: <20130708105700.286CF48890@hg.openjdk.java.net> Changeset: 715d00c95fb2 Author: ehelin Date: 2013-07-08 11:30 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/715d00c95fb2 8010734: NPG: The test MemoryTest.java needs to be updated to support metaspace Reviewed-by: alanb ! test/ProblemList.txt ! test/java/lang/management/MemoryMXBean/MemoryTest.java From sean.mullan at oracle.com Mon Jul 8 13:48:00 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 08 Jul 2013 16:48:00 -0400 Subject: 7u40 Review Request for 8017173: XMLCipher with RSA_OAEP Key Transport algorithm can't be instantiated Message-ID: <51DB2580.2040909@oracle.com> Hi Xuelei, Can you please review my fix for JDK-8017173? This is a regression introduced in 7u25. It does not affect JDK 8, because the recent fix for JDK-8011547 to integrate the Apache Santuario release 1.5.4 also fixed this issue. However, I am not backporting the JDK 8 code, which is more complicated and higher risk (see the comments in the bug for more information). For 7u40, this is a one line fix which reverts to the code in 7u21 to minimize the risk. webrev: http://cr.openjdk.java.net/~mullan/webrevs/8017173/webrev.00/ Thanks, Sean From jason.uh at oracle.com Mon Jul 8 17:17:42 2013 From: jason.uh at oracle.com (Jason Uh) Date: Mon, 08 Jul 2013 17:17:42 -0700 Subject: [8] Request for review: 8020091: Fix HTML doclint issues in java.io Message-ID: <51DB56A6.2040300@oracle.com> Hi Joe, Please review this changeset, which fixes the HTML doclint issues in java.io. Webrev: http://cr.openjdk.java.net/~juh/8020091/webrev.00/ No undesirable changes detected by specdiff. Thanks! Jason From joe.darcy at oracle.com Mon Jul 8 18:37:13 2013 From: joe.darcy at oracle.com (Joseph Darcy) Date: Mon, 08 Jul 2013 18:37:13 -0700 Subject: [8] Request for review: 8020091: Fix HTML doclint issues in java.io In-Reply-To: <51DB56A6.2040300@oracle.com> References: <51DB56A6.2040300@oracle.com> Message-ID: <51DB6949.1070500@oracle.com> Hi Jason; Looks good; approved to go back. Thanks, -Joe On 7/8/2013 5:17 PM, Jason Uh wrote: > Hi Joe, > > Please review this changeset, which fixes the HTML doclint issues in > java.io. > > Webrev: http://cr.openjdk.java.net/~juh/8020091/webrev.00/ > > No undesirable changes detected by specdiff. > > Thanks! > > Jason From xuelei.fan at oracle.com Mon Jul 8 18:53:15 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 09 Jul 2013 09:53:15 +0800 Subject: 7u40 Review Request for 8017173: XMLCipher with RSA_OAEP Key Transport algorithm can't be instantiated In-Reply-To: <51DB2580.2040909@oracle.com> References: <51DB2580.2040909@oracle.com> Message-ID: <51DB6D0B.4090709@oracle.com> Looks fine to me. Xuelei On 7/9/2013 4:48 AM, Sean Mullan wrote: > Hi Xuelei, > > Can you please review my fix for JDK-8017173? This is a regression > introduced in 7u25. It does not affect JDK 8, because the recent fix for > JDK-8011547 to integrate the Apache Santuario release 1.5.4 also fixed > this issue. However, I am not backporting the JDK 8 code, which is more > complicated and higher risk (see the comments in the bug for more > information). For 7u40, this is a one line fix which reverts to the code > in 7u21 to minimize the risk. > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/8017173/webrev.00/ > > Thanks, > Sean From jason.uh at oracle.com Mon Jul 8 19:23:20 2013 From: jason.uh at oracle.com (Jason Uh) Date: Mon, 08 Jul 2013 19:23:20 -0700 Subject: [8] Request for review: 8020091: Fix HTML doclint issues in java.io In-Reply-To: <51DB6949.1070500@oracle.com> References: <51DB56A6.2040300@oracle.com> <51DB6949.1070500@oracle.com> Message-ID: <51DB7418.2050702@oracle.com> Yikes. Just realized I copied the wrong list. My apologies, all. Thanks for the review, Joe! Jason On 07/08/2013 06:37 PM, Joseph Darcy wrote: > Hi Jason; > > Looks good; approved to go back. > > Thanks, > > -Joe > > On 7/8/2013 5:17 PM, Jason Uh wrote: >> Hi Joe, >> >> Please review this changeset, which fixes the HTML doclint issues in >> java.io. >> >> Webrev: http://cr.openjdk.java.net/~juh/8020091/webrev.00/ >> >> No undesirable changes detected by specdiff. >> >> Thanks! >> >> Jason > From jason.uh at oracle.com Mon Jul 8 19:25:11 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Tue, 09 Jul 2013 02:25:11 +0000 Subject: hg: jdk8/tl/jdk: 8020091: Fix HTML doclint issues in java.io Message-ID: <20130709022534.4BB75488D3@hg.openjdk.java.net> Changeset: 52454985425d Author: juh Date: 2013-07-08 19:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/52454985425d 8020091: Fix HTML doclint issues in java.io Reviewed-by: darcy ! src/share/classes/java/io/DataInput.java ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/InputStreamReader.java ! src/share/classes/java/io/OutputStreamWriter.java ! src/share/classes/java/io/PipedInputStream.java ! src/share/classes/java/io/RandomAccessFile.java From joe.darcy at oracle.com Mon Jul 8 22:43:47 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 09 Jul 2013 05:43:47 +0000 Subject: hg: jdk8/tl/jdk: 8020095: Fix doclint warnings in java.util.regex Message-ID: <20130709054443.B2F2A488DC@hg.openjdk.java.net> Changeset: eab8f4e29f5e Author: darcy Date: 2013-07-08 22:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eab8f4e29f5e 8020095: Fix doclint warnings in java.util.regex Reviewed-by: mchung ! src/share/classes/java/util/regex/MatchResult.java ! src/share/classes/java/util/regex/Matcher.java ! src/share/classes/java/util/regex/Pattern.java From paul.sandoz at oracle.com Tue Jul 9 00:22:39 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Tue, 09 Jul 2013 07:22:39 +0000 Subject: hg: jdk8/tl/jdk: 8017141: java.util/stream Spliterators from sequential sources should not catch OOME Message-ID: <20130709072304.6DB76488DF@hg.openjdk.java.net> Changeset: 628432ee4d68 Author: henryjen Date: 2013-07-09 09:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/628432ee4d68 8017141: java.util/stream Spliterators from sequential sources should not catch OOME Reviewed-by: mchung Contributed-by: paul.sandoz at oracle.com ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/Spliterators.java From weijun.wang at oracle.com Tue Jul 9 00:32:34 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 09 Jul 2013 15:32:34 +0800 Subject: Request for review: 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5 Message-ID: <51DBBC92.6040305@oracle.com> Hi All An NPE was suppressed in jdk8 with a simple if. This new fix tries to output useful info even for a null argument. Please review the code changes at http://cr.openjdk.java.net/~weijun/8019267/webrev.01/ The added test makes sure logging does not crash and the output is informational. Thanks Max From paul.sandoz at oracle.com Tue Jul 9 01:45:21 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Tue, 09 Jul 2013 08:45:21 +0000 Subject: hg: jdk8/tl/jdk: 8019551: Make BaseStream public Message-ID: <20130709084547.A32E2488E5@hg.openjdk.java.net> Changeset: 44a634c1edc4 Author: psandoz Date: 2013-07-09 10:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44a634c1edc4 8019551: Make BaseStream public Reviewed-by: chegar, psandoz Contributed-by: brian goetz ! src/share/classes/java/util/stream/AbstractPipeline.java ! src/share/classes/java/util/stream/BaseStream.java From sean.mullan at oracle.com Tue Jul 9 05:16:23 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 09 Jul 2013 08:16:23 -0400 Subject: Request for review: 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5 In-Reply-To: <51DBBC92.6040305@oracle.com> References: <51DBBC92.6040305@oracle.com> Message-ID: <51DBFF17.4010607@oracle.com> Looks fine. --Sean On 07/09/2013 03:32 AM, Weijun Wang wrote: > Hi All > > An NPE was suppressed in jdk8 with a simple if. This new fix tries to > output useful info even for a null argument. > > Please review the code changes at > > http://cr.openjdk.java.net/~weijun/8019267/webrev.01/ > > The added test makes sure logging does not crash and the output is > informational. > > Thanks > Max From vincent.x.ryan at oracle.com Tue Jul 9 05:43:46 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 9 Jul 2013 13:43:46 +0100 Subject: 7u40 Review Request for 8017173: XMLCipher with RSA_OAEP Key Transport algorithm can't be instantiated In-Reply-To: <51DB2580.2040909@oracle.com> References: <51DB2580.2040909@oracle.com> Message-ID: <2072CF42-23D1-43A0-8DB5-C907BF2DF562@oracle.com> Your fix looks good. On 8 Jul 2013, at 21:48, Sean Mullan wrote: > Hi Xuelei, > > Can you please review my fix for JDK-8017173? This is a regression introduced in 7u25. It does not affect JDK 8, because the recent fix for JDK-8011547 to integrate the Apache Santuario release 1.5.4 also fixed this issue. However, I am not backporting the JDK 8 code, which is more complicated and higher risk (see the comments in the bug for more information). For 7u40, this is a one line fix which reverts to the code in 7u21 to minimize the risk. > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/8017173/webrev.00/ > > Thanks, > Sean From sean.coffey at oracle.com Tue Jul 9 06:28:15 2013 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Tue, 09 Jul 2013 14:28:15 +0100 Subject: RFR : 8019979 : Replace CheckPackageAccess test with better one from closed repo Message-ID: <51DC0FEF.3050507@oracle.com> I'd like to move this testcase from our internal test repo and replace the current "test/java/lang/SecurityManager/CheckPackageAccess.java" testcase . It's a straightforward test to ensure that the package restrictions enforced via the java.security file are those expected. The testcase should be updated any time the package.access or package.definition properties are updated. webrev : http://cr.openjdk.java.net/~coffeys/webrev.8019979/webrev/ bug report : http://bugs.sun.com/view_bug.do?bug_id=8019979 regards, Sean. From sean.mullan at oracle.com Tue Jul 9 06:49:57 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 09 Jul 2013 09:49:57 -0400 Subject: RFR : 8019979 : Replace CheckPackageAccess test with better one from closed repo In-Reply-To: <51DC0FEF.3050507@oracle.com> References: <51DC0FEF.3050507@oracle.com> Message-ID: <51DC1505.4040909@oracle.com> Looks good to me. --Sean On 07/09/2013 09:28 AM, Se?n Coffey wrote: > I'd like to move this testcase from our internal test repo and replace > the current "test/java/lang/SecurityManager/CheckPackageAccess.java" > testcase . It's a straightforward test to ensure that the package > restrictions enforced via the java.security file are those expected. > > The testcase should be updated any time the package.access or > package.definition properties are updated. > > webrev : http://cr.openjdk.java.net/~coffeys/webrev.8019979/webrev/ > > bug report : http://bugs.sun.com/view_bug.do?bug_id=8019979 > > regards, > Sean. > > > > From paul.sandoz at oracle.com Tue Jul 9 07:15:23 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Tue, 09 Jul 2013 14:15:23 +0000 Subject: hg: jdk8/tl/jdk: 8019370: Sync j.u.c Fork/Join from 166 to tl Message-ID: <20130709141553.2B297488F7@hg.openjdk.java.net> Changeset: 43134e79c0bb Author: psandoz Date: 2013-07-09 16:04 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43134e79c0bb 8019370: Sync j.u.c Fork/Join from 166 to tl Reviewed-by: chegar, martin Contributed-by: Doug Lea
    ! src/share/classes/java/util/concurrent/AbstractExecutorService.java ! src/share/classes/java/util/concurrent/Callable.java ! src/share/classes/java/util/concurrent/CancellationException.java ! src/share/classes/java/util/concurrent/CompletableFuture.java ! src/share/classes/java/util/concurrent/CompletionService.java ! src/share/classes/java/util/concurrent/CountedCompleter.java ! src/share/classes/java/util/concurrent/ExecutionException.java ! src/share/classes/java/util/concurrent/Executor.java ! src/share/classes/java/util/concurrent/ExecutorService.java ! src/share/classes/java/util/concurrent/Executors.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java ! src/share/classes/java/util/concurrent/Future.java ! src/share/classes/java/util/concurrent/FutureTask.java ! src/share/classes/java/util/concurrent/RecursiveAction.java ! src/share/classes/java/util/concurrent/RecursiveTask.java ! src/share/classes/java/util/concurrent/RejectedExecutionException.java ! src/share/classes/java/util/concurrent/RunnableFuture.java ! src/share/classes/java/util/concurrent/RunnableScheduledFuture.java ! src/share/classes/java/util/concurrent/ScheduledExecutorService.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/ThreadPoolExecutor.java From sean.coffey at oracle.com Tue Jul 9 08:04:04 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 09 Jul 2013 15:04:04 +0000 Subject: hg: jdk8/tl/jdk: 8019979: Replace CheckPackageAccess test with better one from closed repo Message-ID: <20130709150434.9A466488FA@hg.openjdk.java.net> Changeset: 83c2976ef8ee Author: coffeys Date: 2013-07-09 16:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83c2976ef8ee 8019979: Replace CheckPackageAccess test with better one from closed repo Reviewed-by: mullan ! test/java/lang/SecurityManager/CheckPackageAccess.java From kumar.x.srinivasan at oracle.com Tue Jul 9 14:55:00 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Tue, 09 Jul 2013 21:55:00 +0000 Subject: hg: jdk8/tl/langtools: 8020214: TEST_BUG: test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java broken Message-ID: <20130709215503.592024891D@hg.openjdk.java.net> Changeset: aedb3bb327d5 Author: ksrini Date: 2013-07-09 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aedb3bb327d5 8020214: TEST_BUG: test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java broken Reviewed-by: jjg ! test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java From huizhe.wang at oracle.com Tue Jul 9 16:35:26 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 09 Jul 2013 23:35:26 +0000 Subject: hg: jdk8/tl/jaxp: 8016648: FEATURE_SECURE_PROCESSING set to true or false causes SAXParseException to be thrown Message-ID: <20130709233528.C625748920@hg.openjdk.java.net> Changeset: 3b071f506ab9 Author: joehw Date: 2013-07-09 16:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/3b071f506ab9 8016648: FEATURE_SECURE_PROCESSING set to true or false causes SAXParseException to be thrown Summary: jaxp 1.5 feature update Reviewed-by: alanb, dfuchs, lancea ! src/com/sun/org/apache/xalan/internal/XalanConstants.java ! src/com/sun/org/apache/xalan/internal/utils/SecuritySupport.java + src/com/sun/org/apache/xalan/internal/utils/XMLSecurityPropertyManager.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java ! src/com/sun/org/apache/xerces/internal/impl/Constants.java ! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java ! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java ! src/com/sun/org/apache/xerces/internal/parsers/DOMParser.java ! src/com/sun/org/apache/xerces/internal/parsers/SAXParser.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/com/sun/org/apache/xerces/internal/utils/SecuritySupport.java + src/com/sun/org/apache/xerces/internal/utils/XMLSecurityPropertyManager.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java From valerie.peng at oracle.com Tue Jul 9 17:33:06 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 09 Jul 2013 17:33:06 -0700 Subject: Code Review Requests for 7196382 and 8010134 In-Reply-To: <517B933D.5010707@oracle.com> References: <5170AF43.10708@oracle.com> <5170CC01.7000001@oracle.com> <51796EEF.1060005@oracle.com> <517B0DD2.6030500@oracle.com> <517B933D.5010707@oracle.com> Message-ID: <51DCABC2.6080006@oracle.com> Xuelei, I got side-tracked w/ other bugs before coming back to this one. I have updated the webrev to incorporate your review comments, including 1) auto-adjust the default keysize when it's out of range 2) apply our own range checking besides the native limit checking I also noticed that the DH parameter generator from SunJCE provider relies on DSA, so I checked its keysize checking to match the DSA keysize. The webrev is updated at: http://cr.openjdk.java.net/~valeriep/7196382/webrev.02/ Thanks, Valerie On 04/27/13 01:58, Xuelei Fan wrote: > I like this update. > > On 4/27/2013 7:29 AM, Valerie (Yu-Ching) Peng wrote: >> Xuelei, >> >> I have updated the webrev for 7196382 so it uses the key size range info >> from the underlying PKCS library for key size checking: >> http://cr.openjdk.java.net/~valeriep/7196382/webrev.01/ >> > 107 //TBD: auto-adjust default keysize in case it's out-of-range? > > I think it's nice to enable this following block. The key size will be > checked in initialize(), so I think it is a little bit reasonable to > select a proper default key size instead of throwing an exception later. > > > 209 private void checkKeySize(int ks, RSAKeyGenParameterSpec params) > > I think when minKeySize is -1, we need to consider the default key size > limit (EC 112, RSA/DH/DSA 512). In this update, it seems that if > minKeySize is -1, we can generate small keys. I don't think it is the > intended design. It is similar when maxKeySize is -1. > > I was wondering that if minKeySize is -1 (or less than the default > hard-coded key size), or maxKeySize is -1 (or greater than the > hard-coded default key size), we may be able to reset them to the > default hard-coded sizes. > > Thanks, > Xuelei > >> Thanks, >> Valerie >> >> On 04/25/13 10:59, Valerie (Yu-Ching) Peng wrote: >>> Xuelei, >>> >>> Thanks for the review and comments. >>> >>> Supposedly, we don't have to have default parameters for all valid key >>> sizes. >>> The pre-generated default parameters are for the most-commonly used >>> keysizes. >>> As for the rest of supported key sizes, the needed parameters will be >>> generated at runtime upon request. >>> >>> Well, I don't quite like the current approach of hardcoding ranges >>> inside the checkKeySize(...) method. >>> There is a way to query the supported keysize ranges from the PKCS11 >>> library and I think that should be the values that we base the key >>> size check on, plus any additional algorithm-specific check (e.g. >>> multiples of 64 bits) that can't be expressed through the ranges. I am >>> still testing out the changes. Will post an updated webrev for 7196382 >>> once I am done testing... >>> >>> Thanks! >>> Valerie >>> >>> On 04/18/13 21:45, Xuelei Fan wrote: >>>> On 4/19/2013 10:43 AM, Valerie (Yu-Ching) Peng wrote: >>>>> Xuelei, >>>>> >>>>> Do you have time to review the following two fixes? >>>>> 7196382: PKCS11 provider should support 2048-bit DH >>>>> 8010134: A finalizer in sun.security.pkcs11.wrapper.PKCS11 perhaps >>>>> should be protected >>>>> >>>>> The first one removes the hardcoded limit of 1024 for DH and the second >>>>> one is making the finalize() method protected. >>>>> >>>>> Webrevs: >>>>> http://cr.openjdk.java.net/~valeriep/7196382/webrev.00/ >>>> Looks fine. >>>> >>>> Do we plan to support DH keys bwteen 1024 and 2048 with default (null) >>>> parameters, for example 1536, in PKCS11 provider? Recently, I run into >>>> a case that uses DH public keys of 1536 bits. I was wondering we may >>>> also want to support more. >>>> >>>>> http://cr.openjdk.java.net/~valeriep/8010134/webrev.00/ >>>> Looks fine. >>>> >>>> Xuelei >>>> >>>>> Thanks! >>>>> Valerie From david.holmes at oracle.com Tue Jul 9 19:04:09 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 10 Jul 2013 02:04:09 +0000 Subject: hg: jdk8/tl/jdk: 8016341: java/lang/ref/OOMEInReferenceHandler.java failing intermittently Message-ID: <20130710020433.BEABE48927@hg.openjdk.java.net> Changeset: 7bb17aa9a09f Author: dholmes Date: 2013-07-09 22:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bb17aa9a09f 8016341: java/lang/ref/OOMEInReferenceHandler.java failing intermittently Summary: Ensure WeakRef object can't be prematurely gc'd Reviewed-by: chegar, plevart ! test/java/lang/ref/OOMEInReferenceHandler.java From weijun.wang at oracle.com Wed Jul 10 00:13:03 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 10 Jul 2013 07:13:03 +0000 Subject: hg: jdk8/tl/jdk: 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5 Message-ID: <20130710071327.63CE44892F@hg.openjdk.java.net> Changeset: 780a64979c8d Author: weijun Date: 2013-07-10 15:11 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/780a64979c8d 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5 Reviewed-by: mullan ! src/share/classes/com/sun/security/sasl/util/AbstractSaslImpl.java ! test/sun/security/krb5/auto/SaslGSS.java From weijun.wang at oracle.com Wed Jul 10 00:42:35 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 10 Jul 2013 15:42:35 +0800 Subject: Request for review: 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5 In-Reply-To: <51DBFF17.4010607@oracle.com> References: <51DBBC92.6040305@oracle.com> <51DBFF17.4010607@oracle.com> Message-ID: <51DD106B.4070500@oracle.com> Hi Sean Can you take a look at the webrev for jdk7u-dev. The only difference is that in 7u there is no check for output == null at all so an NPE is thrown. http://cr.openjdk.java.net/~weijun/8019267/7u-dev/webrev.00/ Thanks Max On 7/9/13 8:16 PM, Sean Mullan wrote: > Looks fine. > > --Sean > > On 07/09/2013 03:32 AM, Weijun Wang wrote: >> Hi All >> >> An NPE was suppressed in jdk8 with a simple if. This new fix tries to >> output useful info even for a null argument. >> >> Please review the code changes at >> >> http://cr.openjdk.java.net/~weijun/8019267/webrev.01/ >> >> The added test makes sure logging does not crash and the output is >> informational. >> >> Thanks >> Max > From paul.sandoz at oracle.com Wed Jul 10 00:53:00 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Wed, 10 Jul 2013 07:53:00 +0000 Subject: hg: jdk8/tl/jdk: 8017447: Unmodifiable map entry becomes modifiable if taken from a stream of map entries Message-ID: <20130710075325.715E148935@hg.openjdk.java.net> Changeset: ff5df05222d1 Author: psandoz Date: 2013-07-10 09:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff5df05222d1 8017447: Unmodifiable map entry becomes modifiable if taken from a stream of map entries Reviewed-by: briangoetz ! src/share/classes/java/util/Collections.java + test/java/util/Collections/UnmodifiableMapEntrySet.java From paul.sandoz at oracle.com Wed Jul 10 01:25:56 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Wed, 10 Jul 2013 08:25:56 +0000 Subject: hg: jdk8/tl/jdk: 8020040: Improve and generalize the F/J tasks to handle right or left-balanced trees Message-ID: <20130710082620.9896A4893A@hg.openjdk.java.net> Changeset: 882baa1e0a38 Author: psandoz Date: 2013-07-10 10:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/882baa1e0a38 8020040: Improve and generalize the F/J tasks to handle right or left-balanced trees Reviewed-by: briangoetz Contributed-by: doug lea
    , paul sandoz ! src/share/classes/java/util/stream/AbstractShortCircuitTask.java ! src/share/classes/java/util/stream/AbstractTask.java ! src/share/classes/java/util/stream/ForEachOps.java ! src/share/classes/java/util/stream/Nodes.java From sean.mullan at oracle.com Wed Jul 10 04:29:43 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 10 Jul 2013 07:29:43 -0400 Subject: Request for review: 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5 In-Reply-To: <51DD106B.4070500@oracle.com> References: <51DBBC92.6040305@oracle.com> <51DBFF17.4010607@oracle.com> <51DD106B.4070500@oracle.com> Message-ID: <51DD45A7.8010702@oracle.com> Looks fine too. --Sean On 07/10/2013 03:42 AM, Weijun Wang wrote: > Hi Sean > > Can you take a look at the webrev for jdk7u-dev. The only difference is > that in 7u there is no check for output == null at all so an NPE is thrown. > > http://cr.openjdk.java.net/~weijun/8019267/7u-dev/webrev.00/ > > Thanks > Max > > On 7/9/13 8:16 PM, Sean Mullan wrote: >> Looks fine. >> >> --Sean >> >> On 07/09/2013 03:32 AM, Weijun Wang wrote: >>> Hi All >>> >>> An NPE was suppressed in jdk8 with a simple if. This new fix tries to >>> output useful info even for a null argument. >>> >>> Please review the code changes at >>> >>> http://cr.openjdk.java.net/~weijun/8019267/webrev.01/ >>> >>> The added test makes sure logging does not crash and the output is >>> informational. >>> >>> Thanks >>> Max >> From joe.darcy at oracle.com Wed Jul 10 11:05:56 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 10 Jul 2013 18:05:56 +0000 Subject: hg: jdk8/tl/jdk: 8020294: Fix doclint issues in java.util.Spliterator Message-ID: <20130710180609.DF00048965@hg.openjdk.java.net> Changeset: 7c44ea602cc8 Author: darcy Date: 2013-07-10 11:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c44ea602cc8 8020294: Fix doclint issues in java.util.Spliterator Reviewed-by: psandoz ! src/share/classes/java/util/Spliterator.java From rob.mckenna at oracle.com Wed Jul 10 11:54:22 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Wed, 10 Jul 2013 18:54:22 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130710185506.7F13C4896A@hg.openjdk.java.net> Changeset: 607fa1ff3de2 Author: bpb Date: 2013-07-09 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/607fa1ff3de2 6178739: (fmt) Formatter.format("%0.4f\n", 56789.456789) generates MissingFormatWidthException Summary: Change the field width specification to require a positive value. The exception is still thrown but that is now explicitly consistent with the specification. Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/util/Formatter.java Changeset: 2ee772cda1d6 Author: bpb Date: 2013-07-09 12:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ee772cda1d6 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself ("0.0") Summary: Make stripTrailingZeros() return BigDecimal.ZERO if the BigDecimal is numerically equal to zero. Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/math/BigDecimal.java ! test/java/math/BigDecimal/StrippingZerosTest.java From joe.darcy at oracle.com Wed Jul 10 14:20:34 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 10 Jul 2013 21:20:34 +0000 Subject: hg: jdk8/tl/jdk: 8020308: Fix doclint issues in java.lang.management Message-ID: <20130710212057.488B34897A@hg.openjdk.java.net> Changeset: 69d9fe8175a0 Author: sspitsyn Date: 2013-07-10 14:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69d9fe8175a0 8020308: Fix doclint issues in java.lang.management Reviewed-by: darcy Contributed-by: serguei.spitsyn at oracle.com ! src/share/classes/java/lang/management/LockInfo.java ! src/share/classes/java/lang/management/ManagementFactory.java ! src/share/classes/java/lang/management/MemoryMXBean.java ! src/share/classes/java/lang/management/MemoryNotificationInfo.java ! src/share/classes/java/lang/management/MemoryPoolMXBean.java ! src/share/classes/java/lang/management/MemoryUsage.java ! src/share/classes/java/lang/management/MonitorInfo.java ! src/share/classes/java/lang/management/RuntimeMXBean.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/lang/management/ThreadMXBean.java From valerie.peng at oracle.com Wed Jul 10 16:04:27 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Wed, 10 Jul 2013 16:04:27 -0700 Subject: Code Review Request for 8020310: JDK-6356530 broke the old build Message-ID: <51DDE87B.4090308@oracle.com> While working w/ Dave for a JCE provider build, I ran into a build failure due to a javac change, i.e. 6356530 " -Xlint:serial does not flag abstract classes with concrete methods/members". The new-infra build does not have this problem, only the old build does. Here is the bug id and its webrev: 8020310: JDK-6356530 broke the old build http://cr.openjdk.java.net/~valeriep/8020310/webrev.00/ Can someone please help review this trivial fix quickly? No regression test since it's trivial and the old build passes with the fix. Thanks, Valerie From jason.uh at oracle.com Wed Jul 10 18:01:55 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Thu, 11 Jul 2013 01:01:55 +0000 Subject: hg: jdk8/tl/jdk: 8020318: Fix doclint issues in java.net Message-ID: <20130711010218.031D448981@hg.openjdk.java.net> Changeset: 702556f7977e Author: juh Date: 2013-07-10 18:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/702556f7977e 8020318: Fix doclint issues in java.net Reviewed-by: darcy, khazra ! src/share/classes/java/net/CookieStore.java ! src/share/classes/java/net/HttpURLPermission.java ! src/share/classes/java/net/Inet4Address.java ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/ProtocolFamily.java ! src/share/classes/java/net/SocketOption.java ! src/share/classes/java/net/URI.java From xuelei.fan at oracle.com Wed Jul 10 18:07:11 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 11 Jul 2013 09:07:11 +0800 Subject: Code Review Request for 8020310: JDK-6356530 broke the old build In-Reply-To: <51DDE87B.4090308@oracle.com> References: <51DDE87B.4090308@oracle.com> Message-ID: <51DE053F.3020407@oracle.com> Looks fine. Xuelei On 7/11/2013 7:04 AM, Valerie (Yu-Ching) Peng wrote: > While working w/ Dave for a JCE provider build, I ran into a build > failure due to a javac change, i.e. 6356530 " -Xlint:serial does not > flag abstract classes with concrete methods/members". The new-infra > build does not have this problem, only the old build does. > > Here is the bug id and its webrev: > > 8020310: JDK-6356530 broke the old build > http://cr.openjdk.java.net/~valeriep/8020310/webrev.00/ > > > Can someone please help review this trivial fix quickly? No regression > test since it's trivial and the old build passes with the fix. > > Thanks, > Valerie From valerie.peng at oracle.com Wed Jul 10 18:07:27 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Wed, 10 Jul 2013 18:07:27 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51C891D6.1080401@oracle.com> References: <51C891D6.1080401@oracle.com> Message-ID: <51DE054F.10303@oracle.com> Tony, Did someone review this yet? Since there are 3 bug fixes, can you separate them out into 3 webrevs? I believe that has been the convention to have one webrev corresponding to one bug. Otherwise, things can get confusing for both reviewers as well as sustaining if later they tried to backport. Thanks, Valerie On 06/24/13 11:37, Anthony Scarpino wrote: > I need a code review for some test changes. They include the follow > bugs: > JDK-8012971 PKCS11Test hiding exception failures > JDK-7193793 sun/security/pkcs11/ec/TestECDH.java failing intermittently > JDK-7198198 sun/security/pkcs11/ec/ReadCertificates.java fails on Suse > Linux > > A significant change is reading the NSS version. The test can now > avoid old NSS libraries or a bug in a version of NSS that generate > false jdk failures. This greatly helps ECC support and curve support > are varied. > > The fix to expose the exceptions that were being hidden did generate > new test failures that already had filed bugs. The failures were > added to the ProblemList. > > http://cr.openjdk.java.net/~ascarpino/8012971/webrev.00/ > > Tony > > From valerie.peng at oracle.com Wed Jul 10 18:10:11 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Wed, 10 Jul 2013 18:10:11 -0700 Subject: Code Review Request for 8020321: Problem in PKCS11 regression test TestRSAKeyLength Message-ID: <51DE05F3.2080309@oracle.com> Anyone has one minute to review this trivial and straight forward fix to existing PKCS11 regression test? 8020321: Problem in PKCS11 regression test TestRSAKeyLength webrev: http://cr.openjdk.java.net/~valeriep/8020321/webrev.00/ Thanks, Valerie From xuelei.fan at oracle.com Wed Jul 10 18:30:00 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 11 Jul 2013 09:30:00 +0800 Subject: Code Review Request for 8020321: Problem in PKCS11 regression test TestRSAKeyLength In-Reply-To: <51DE05F3.2080309@oracle.com> References: <51DE05F3.2080309@oracle.com> Message-ID: <51DE0A98.4060009@oracle.com> Wow, you are so careful about the hard-coded arrays. Looks fine. Xuelei On 7/11/2013 9:10 AM, Valerie (Yu-Ching) Peng wrote: > > Anyone has one minute to review this trivial and straight forward fix to > existing PKCS11 regression test? > > 8020321: Problem in PKCS11 regression test TestRSAKeyLength > webrev: http://cr.openjdk.java.net/~valeriep/8020321/webrev.00/ > > Thanks, > Valerie From valerie.peng at oracle.com Wed Jul 10 18:37:11 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Wed, 10 Jul 2013 18:37:11 -0700 Subject: Code Review Request for 8020321: Problem in PKCS11 regression test TestRSAKeyLength In-Reply-To: <51DE0A98.4060009@oracle.com> References: <51DE05F3.2080309@oracle.com> <51DE0A98.4060009@oracle.com> Message-ID: <51DE0C47.5040904@oracle.com> Need to make sure this won't happen again by adding a check. Thanks for another quick review, Valerie On 07/10/13 18:30, Xuelei Fan wrote: > Wow, you are so careful about the hard-coded arrays. Looks fine. > > Xuelei > > On 7/11/2013 9:10 AM, Valerie (Yu-Ching) Peng wrote: >> Anyone has one minute to review this trivial and straight forward fix to >> existing PKCS11 regression test? >> >> 8020321: Problem in PKCS11 regression test TestRSAKeyLength >> webrev: http://cr.openjdk.java.net/~valeriep/8020321/webrev.00/ >> >> Thanks, >> Valerie From xuelei.fan at oracle.com Wed Jul 10 19:23:52 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 11 Jul 2013 10:23:52 +0800 Subject: Code Review Requests for 7196382 and 8010134 In-Reply-To: <51DCABC2.6080006@oracle.com> References: <5170AF43.10708@oracle.com> <5170CC01.7000001@oracle.com> <51796EEF.1060005@oracle.com> <517B0DD2.6030500@oracle.com> <517B933D.5010707@oracle.com> <51DCABC2.6080006@oracle.com> Message-ID: <51DE1738.7040302@oracle.com> src/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java ============================================================== -------- It is instinctive and easy to maintain to code if we have the comment: + // RSA, DH, and DSA 104 keySize = 1024; -------- I'm not sure, just a double check. Do we really allow DSA keysize is not a multiple of 64 bits when it is bigger than or equal to 1024? 240 } else if (algorithm.equals("DSA")) { 241 if ((ks < 1024) && ((ks & 0x3f) != 0)) { 242 throw new InvalidAlgorithmParameterException 243 ("DSA key must be a multiple of 64 bits"); -------- If the mechanism info is not specified in the underlying device (minKeySize/maxKeySize is -1), do we still want to reserve the minimal length checking (112 for EC, 512 for non-EC)? I think we may still want the constraints. For example: 226 } else { + // The key size is too small. + if (algorithm.equals("EC")) { + // keysize < 112, throws exception + } else { + // keysizse < 512, throws exception + } Xuelei On 7/10/2013 8:33 AM, Valerie (Yu-Ching) Peng wrote: > Xuelei, > > I got side-tracked w/ other bugs before coming back to this one. > > I have updated the webrev to incorporate your review comments, including > 1) auto-adjust the default keysize when it's out of range > 2) apply our own range checking besides the native limit checking > > I also noticed that the DH parameter generator from SunJCE provider > relies on DSA, so I checked its keysize checking to match the DSA keysize. > > The webrev is updated at: > http://cr.openjdk.java.net/~valeriep/7196382/webrev.02/ > Thanks, > Valerie > > On 04/27/13 01:58, Xuelei Fan wrote: >> I like this update. >> >> On 4/27/2013 7:29 AM, Valerie (Yu-Ching) Peng wrote: >>> Xuelei, >>> >>> I have updated the webrev for 7196382 so it uses the key size range info >>> from the underlying PKCS library for key size checking: >>> http://cr.openjdk.java.net/~valeriep/7196382/webrev.01/ >>> >> 107 //TBD: auto-adjust default keysize in case it's out-of-range? >> >> I think it's nice to enable this following block. The key size will be >> checked in initialize(), so I think it is a little bit reasonable to >> select a proper default key size instead of throwing an exception later. >> >> >> 209 private void checkKeySize(int ks, RSAKeyGenParameterSpec params) >> >> I think when minKeySize is -1, we need to consider the default key size >> limit (EC 112, RSA/DH/DSA 512). In this update, it seems that if >> minKeySize is -1, we can generate small keys. I don't think it is the >> intended design. It is similar when maxKeySize is -1. >> >> I was wondering that if minKeySize is -1 (or less than the default >> hard-coded key size), or maxKeySize is -1 (or greater than the >> hard-coded default key size), we may be able to reset them to the >> default hard-coded sizes. >> >> Thanks, >> Xuelei >> >>> Thanks, >>> Valerie >>> >>> On 04/25/13 10:59, Valerie (Yu-Ching) Peng wrote: >>>> Xuelei, >>>> >>>> Thanks for the review and comments. >>>> >>>> Supposedly, we don't have to have default parameters for all valid key >>>> sizes. >>>> The pre-generated default parameters are for the most-commonly used >>>> keysizes. >>>> As for the rest of supported key sizes, the needed parameters will be >>>> generated at runtime upon request. >>>> >>>> Well, I don't quite like the current approach of hardcoding ranges >>>> inside the checkKeySize(...) method. >>>> There is a way to query the supported keysize ranges from the PKCS11 >>>> library and I think that should be the values that we base the key >>>> size check on, plus any additional algorithm-specific check (e.g. >>>> multiples of 64 bits) that can't be expressed through the ranges. I am >>>> still testing out the changes. Will post an updated webrev for 7196382 >>>> once I am done testing... >>>> >>>> Thanks! >>>> Valerie >>>> >>>> On 04/18/13 21:45, Xuelei Fan wrote: >>>>> On 4/19/2013 10:43 AM, Valerie (Yu-Ching) Peng wrote: >>>>>> Xuelei, >>>>>> >>>>>> Do you have time to review the following two fixes? >>>>>> 7196382: PKCS11 provider should support 2048-bit DH >>>>>> 8010134: A finalizer in sun.security.pkcs11.wrapper.PKCS11 perhaps >>>>>> should be protected >>>>>> >>>>>> The first one removes the hardcoded limit of 1024 for DH and the >>>>>> second >>>>>> one is making the finalize() method protected. >>>>>> >>>>>> Webrevs: >>>>>> http://cr.openjdk.java.net/~valeriep/7196382/webrev.00/ >>>>> Looks fine. >>>>> >>>>> Do we plan to support DH keys bwteen 1024 and 2048 with default (null) >>>>> parameters, for example 1536, in PKCS11 provider? Recently, I run >>>>> into >>>>> a case that uses DH public keys of 1536 bits. I was wondering we may >>>>> also want to support more. >>>>> >>>>>> http://cr.openjdk.java.net/~valeriep/8010134/webrev.00/ >>>>> Looks fine. >>>>> >>>>> Xuelei >>>>> >>>>>> Thanks! >>>>>> Valerie > From xuelei.fan at oracle.com Wed Jul 10 19:25:12 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 11 Jul 2013 10:25:12 +0800 Subject: Code Review Requests for 7196382 and 8010134 In-Reply-To: <51DE1738.7040302@oracle.com> References: <5170AF43.10708@oracle.com> <5170CC01.7000001@oracle.com> <51796EEF.1060005@oracle.com> <517B0DD2.6030500@oracle.com> <517B933D.5010707@oracle.com> <51DCABC2.6080006@oracle.com> <51DE1738.7040302@oracle.com> Message-ID: <51DE1788.6060106@oracle.com> Ooops, please ignore this mail. I went into the wrong webrev. Xuelei On 7/11/2013 10:23 AM, Xuelei Fan wrote: > src/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java > ============================================================== > -------- > It is instinctive and easy to maintain to code if we have the comment: > + // RSA, DH, and DSA > 104 keySize = 1024; > > > -------- > I'm not sure, just a double check. Do we really allow DSA keysize is > not a multiple of 64 bits when it is bigger than or equal to 1024? > > 240 } else if (algorithm.equals("DSA")) { > 241 if ((ks < 1024) && ((ks & 0x3f) != 0)) { > 242 throw new InvalidAlgorithmParameterException > 243 ("DSA key must be a multiple of 64 bits"); > > -------- > If the mechanism info is not specified in the underlying device > (minKeySize/maxKeySize is -1), do we still want to reserve the minimal > length checking (112 for EC, 512 for non-EC)? I think we may still want > the constraints. For example: > > 226 } else { > + // The key size is too small. > + if (algorithm.equals("EC")) { > + // keysize < 112, throws exception > + } else { > + // keysizse < 512, throws exception > + } > > > Xuelei > > On 7/10/2013 8:33 AM, Valerie (Yu-Ching) Peng wrote: >> Xuelei, >> >> I got side-tracked w/ other bugs before coming back to this one. >> >> I have updated the webrev to incorporate your review comments, including >> 1) auto-adjust the default keysize when it's out of range >> 2) apply our own range checking besides the native limit checking >> >> I also noticed that the DH parameter generator from SunJCE provider >> relies on DSA, so I checked its keysize checking to match the DSA keysize. >> >> The webrev is updated at: >> http://cr.openjdk.java.net/~valeriep/7196382/webrev.02/ >> Thanks, >> Valerie >> >> On 04/27/13 01:58, Xuelei Fan wrote: >>> I like this update. >>> >>> On 4/27/2013 7:29 AM, Valerie (Yu-Ching) Peng wrote: >>>> Xuelei, >>>> >>>> I have updated the webrev for 7196382 so it uses the key size range info >>>> from the underlying PKCS library for key size checking: >>>> http://cr.openjdk.java.net/~valeriep/7196382/webrev.01/ >>>> >>> 107 //TBD: auto-adjust default keysize in case it's out-of-range? >>> >>> I think it's nice to enable this following block. The key size will be >>> checked in initialize(), so I think it is a little bit reasonable to >>> select a proper default key size instead of throwing an exception later. >>> >>> >>> 209 private void checkKeySize(int ks, RSAKeyGenParameterSpec params) >>> >>> I think when minKeySize is -1, we need to consider the default key size >>> limit (EC 112, RSA/DH/DSA 512). In this update, it seems that if >>> minKeySize is -1, we can generate small keys. I don't think it is the >>> intended design. It is similar when maxKeySize is -1. >>> >>> I was wondering that if minKeySize is -1 (or less than the default >>> hard-coded key size), or maxKeySize is -1 (or greater than the >>> hard-coded default key size), we may be able to reset them to the >>> default hard-coded sizes. >>> >>> Thanks, >>> Xuelei >>> >>>> Thanks, >>>> Valerie >>>> >>>> On 04/25/13 10:59, Valerie (Yu-Ching) Peng wrote: >>>>> Xuelei, >>>>> >>>>> Thanks for the review and comments. >>>>> >>>>> Supposedly, we don't have to have default parameters for all valid key >>>>> sizes. >>>>> The pre-generated default parameters are for the most-commonly used >>>>> keysizes. >>>>> As for the rest of supported key sizes, the needed parameters will be >>>>> generated at runtime upon request. >>>>> >>>>> Well, I don't quite like the current approach of hardcoding ranges >>>>> inside the checkKeySize(...) method. >>>>> There is a way to query the supported keysize ranges from the PKCS11 >>>>> library and I think that should be the values that we base the key >>>>> size check on, plus any additional algorithm-specific check (e.g. >>>>> multiples of 64 bits) that can't be expressed through the ranges. I am >>>>> still testing out the changes. Will post an updated webrev for 7196382 >>>>> once I am done testing... >>>>> >>>>> Thanks! >>>>> Valerie >>>>> >>>>> On 04/18/13 21:45, Xuelei Fan wrote: >>>>>> On 4/19/2013 10:43 AM, Valerie (Yu-Ching) Peng wrote: >>>>>>> Xuelei, >>>>>>> >>>>>>> Do you have time to review the following two fixes? >>>>>>> 7196382: PKCS11 provider should support 2048-bit DH >>>>>>> 8010134: A finalizer in sun.security.pkcs11.wrapper.PKCS11 perhaps >>>>>>> should be protected >>>>>>> >>>>>>> The first one removes the hardcoded limit of 1024 for DH and the >>>>>>> second >>>>>>> one is making the finalize() method protected. >>>>>>> >>>>>>> Webrevs: >>>>>>> http://cr.openjdk.java.net/~valeriep/7196382/webrev.00/ >>>>>> Looks fine. >>>>>> >>>>>> Do we plan to support DH keys bwteen 1024 and 2048 with default (null) >>>>>> parameters, for example 1536, in PKCS11 provider? Recently, I run >>>>>> into >>>>>> a case that uses DH public keys of 1536 bits. I was wondering we may >>>>>> also want to support more. >>>>>> >>>>>>> http://cr.openjdk.java.net/~valeriep/8010134/webrev.00/ >>>>>> Looks fine. >>>>>> >>>>>> Xuelei >>>>>> >>>>>>> Thanks! >>>>>>> Valerie >> > From xuelei.fan at oracle.com Wed Jul 10 19:44:33 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 11 Jul 2013 10:44:33 +0800 Subject: Code Review Requests for 7196382 and 8010134 In-Reply-To: <51DE1788.6060106@oracle.com> References: <5170AF43.10708@oracle.com> <5170CC01.7000001@oracle.com> <51796EEF.1060005@oracle.com> <517B0DD2.6030500@oracle.com> <517B933D.5010707@oracle.com> <51DCABC2.6080006@oracle.com> <51DE1738.7040302@oracle.com> <51DE1788.6060106@oracle.com> Message-ID: <51DE1C11.4050000@oracle.com> > http://cr.openjdk.java.net/~valeriep/7196382/webrev.02/ This is the latest webrev. ;-) Looks fine to me. Xuelei On 7/11/2013 10:25 AM, Xuelei Fan wrote: > Ooops, please ignore this mail. I went into the wrong webrev. > > Xuelei > > On 7/11/2013 10:23 AM, Xuelei Fan wrote: >> src/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java >> ============================================================== >> -------- >> It is instinctive and easy to maintain to code if we have the comment: >> + // RSA, DH, and DSA >> 104 keySize = 1024; >> >> >> -------- >> I'm not sure, just a double check. Do we really allow DSA keysize is >> not a multiple of 64 bits when it is bigger than or equal to 1024? >> >> 240 } else if (algorithm.equals("DSA")) { >> 241 if ((ks < 1024) && ((ks & 0x3f) != 0)) { >> 242 throw new InvalidAlgorithmParameterException >> 243 ("DSA key must be a multiple of 64 bits"); >> >> -------- >> If the mechanism info is not specified in the underlying device >> (minKeySize/maxKeySize is -1), do we still want to reserve the minimal >> length checking (112 for EC, 512 for non-EC)? I think we may still want >> the constraints. For example: >> >> 226 } else { >> + // The key size is too small. >> + if (algorithm.equals("EC")) { >> + // keysize < 112, throws exception >> + } else { >> + // keysizse < 512, throws exception >> + } >> >> >> Xuelei >> >> On 7/10/2013 8:33 AM, Valerie (Yu-Ching) Peng wrote: >>> Xuelei, >>> >>> I got side-tracked w/ other bugs before coming back to this one. >>> >>> I have updated the webrev to incorporate your review comments, including >>> 1) auto-adjust the default keysize when it's out of range >>> 2) apply our own range checking besides the native limit checking >>> >>> I also noticed that the DH parameter generator from SunJCE provider >>> relies on DSA, so I checked its keysize checking to match the DSA keysize. >>> >>> The webrev is updated at: >>> http://cr.openjdk.java.net/~valeriep/7196382/webrev.02/ >>> Thanks, >>> Valerie >>> >>> On 04/27/13 01:58, Xuelei Fan wrote: >>>> I like this update. >>>> >>>> On 4/27/2013 7:29 AM, Valerie (Yu-Ching) Peng wrote: >>>>> Xuelei, >>>>> >>>>> I have updated the webrev for 7196382 so it uses the key size range info >>>>> from the underlying PKCS library for key size checking: >>>>> http://cr.openjdk.java.net/~valeriep/7196382/webrev.01/ >>>>> >>>> 107 //TBD: auto-adjust default keysize in case it's out-of-range? >>>> >>>> I think it's nice to enable this following block. The key size will be >>>> checked in initialize(), so I think it is a little bit reasonable to >>>> select a proper default key size instead of throwing an exception later. >>>> >>>> >>>> 209 private void checkKeySize(int ks, RSAKeyGenParameterSpec params) >>>> >>>> I think when minKeySize is -1, we need to consider the default key size >>>> limit (EC 112, RSA/DH/DSA 512). In this update, it seems that if >>>> minKeySize is -1, we can generate small keys. I don't think it is the >>>> intended design. It is similar when maxKeySize is -1. >>>> >>>> I was wondering that if minKeySize is -1 (or less than the default >>>> hard-coded key size), or maxKeySize is -1 (or greater than the >>>> hard-coded default key size), we may be able to reset them to the >>>> default hard-coded sizes. >>>> >>>> Thanks, >>>> Xuelei >>>> >>>>> Thanks, >>>>> Valerie >>>>> >>>>> On 04/25/13 10:59, Valerie (Yu-Ching) Peng wrote: >>>>>> Xuelei, >>>>>> >>>>>> Thanks for the review and comments. >>>>>> >>>>>> Supposedly, we don't have to have default parameters for all valid key >>>>>> sizes. >>>>>> The pre-generated default parameters are for the most-commonly used >>>>>> keysizes. >>>>>> As for the rest of supported key sizes, the needed parameters will be >>>>>> generated at runtime upon request. >>>>>> >>>>>> Well, I don't quite like the current approach of hardcoding ranges >>>>>> inside the checkKeySize(...) method. >>>>>> There is a way to query the supported keysize ranges from the PKCS11 >>>>>> library and I think that should be the values that we base the key >>>>>> size check on, plus any additional algorithm-specific check (e.g. >>>>>> multiples of 64 bits) that can't be expressed through the ranges. I am >>>>>> still testing out the changes. Will post an updated webrev for 7196382 >>>>>> once I am done testing... >>>>>> >>>>>> Thanks! >>>>>> Valerie >>>>>> >>>>>> On 04/18/13 21:45, Xuelei Fan wrote: >>>>>>> On 4/19/2013 10:43 AM, Valerie (Yu-Ching) Peng wrote: >>>>>>>> Xuelei, >>>>>>>> >>>>>>>> Do you have time to review the following two fixes? >>>>>>>> 7196382: PKCS11 provider should support 2048-bit DH >>>>>>>> 8010134: A finalizer in sun.security.pkcs11.wrapper.PKCS11 perhaps >>>>>>>> should be protected >>>>>>>> >>>>>>>> The first one removes the hardcoded limit of 1024 for DH and the >>>>>>>> second >>>>>>>> one is making the finalize() method protected. >>>>>>>> >>>>>>>> Webrevs: >>>>>>>> http://cr.openjdk.java.net/~valeriep/7196382/webrev.00/ >>>>>>> Looks fine. >>>>>>> >>>>>>> Do we plan to support DH keys bwteen 1024 and 2048 with default (null) >>>>>>> parameters, for example 1536, in PKCS11 provider? Recently, I run >>>>>>> into >>>>>>> a case that uses DH public keys of 1536 bits. I was wondering we may >>>>>>> also want to support more. >>>>>>> >>>>>>>> http://cr.openjdk.java.net/~valeriep/8010134/webrev.00/ >>>>>>> Looks fine. >>>>>>> >>>>>>> Xuelei >>>>>>> >>>>>>>> Thanks! >>>>>>>> Valerie >>> >> > From anthony.scarpino at oracle.com Wed Jul 10 21:55:28 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Wed, 10 Jul 2013 21:55:28 -0700 Subject: Code Review Request for 8020321: Problem in PKCS11 regression test TestRSAKeyLength In-Reply-To: <51DE05F3.2080309@oracle.com> References: <51DE05F3.2080309@oracle.com> Message-ID: <51DE3AC0.1050804@oracle.com> On 07/10/2013 06:10 PM, Valerie (Yu-Ching) Peng wrote: > > Anyone has one minute to review this trivial and straight forward fix to > existing PKCS11 regression test? > > 8020321: Problem in PKCS11 regression test TestRSAKeyLength > webrev: http://cr.openjdk.java.net/~valeriep/8020321/webrev.00/ > > Thanks, > Valerie I certainly agree with the fix, I've had the array change in my PKCS11Test changes that has been out for review for a long time.. minus your extra check of course.. Tony From anthony.scarpino at oracle.com Wed Jul 10 21:56:37 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Wed, 10 Jul 2013 21:56:37 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51DE054F.10303@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> Message-ID: <51DE3B05.4090202@oracle.com> Sure I'll break it up if that's easier and someone will review it. thanks Tony On 07/10/2013 06:07 PM, Valerie (Yu-Ching) Peng wrote: > Tony, > > Did someone review this yet? > > Since there are 3 bug fixes, can you separate them out into 3 webrevs? > I believe that has been the convention to have one webrev corresponding > to one bug. > Otherwise, things can get confusing for both reviewers as well as > sustaining if later they tried to backport. > > Thanks, > Valerie > > On 06/24/13 11:37, Anthony Scarpino wrote: >> I need a code review for some test changes. They include the follow >> bugs: >> JDK-8012971 PKCS11Test hiding exception failures >> JDK-7193793 sun/security/pkcs11/ec/TestECDH.java failing intermittently >> JDK-7198198 sun/security/pkcs11/ec/ReadCertificates.java fails on Suse >> Linux >> >> A significant change is reading the NSS version. The test can now >> avoid old NSS libraries or a bug in a version of NSS that generate >> false jdk failures. This greatly helps ECC support and curve support >> are varied. >> >> The fix to expose the exceptions that were being hidden did generate >> new test failures that already had filed bugs. The failures were >> added to the ProblemList. >> >> http://cr.openjdk.java.net/~ascarpino/8012971/webrev.00/ >> >> Tony >> >> > From paul.sandoz at oracle.com Thu Jul 11 04:20:31 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Thu, 11 Jul 2013 11:20:31 +0000 Subject: hg: jdk8/tl/jdk: 8019484: Sync j.u.c.ConcurrentHashMap from 166 to tl Message-ID: <20130711112056.05A2248993@hg.openjdk.java.net> Changeset: 05b164788aab Author: psandoz Date: 2013-07-11 13:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/05b164788aab 8019484: Sync j.u.c.ConcurrentHashMap from 166 to tl Reviewed-by: martin Contributed-by: Doug Lea
    ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentMap.java ! src/share/classes/java/util/concurrent/ConcurrentNavigableMap.java From sundararajan.athijegannathan at oracle.com Thu Jul 11 06:21:13 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 11 Jul 2013 13:21:13 +0000 Subject: hg: jdk8/tl/jdk: 7187144: JavaDoc for ScriptEngineFactory.getProgram() contains an error Message-ID: <20130711132141.246B8489A8@hg.openjdk.java.net> Changeset: dadcfd84d33f Author: sundar Date: 2013-07-11 18:50 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dadcfd84d33f 7187144: JavaDoc for ScriptEngineFactory.getProgram() contains an error Reviewed-by: mcimadamore, jlaskey, hannesw, attila ! src/share/classes/javax/script/ScriptEngineFactory.java From maurizio.cimadamore at oracle.com Thu Jul 11 07:37:38 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 11 Jul 2013 14:37:38 +0000 Subject: hg: jdk8/tl/langtools: 8013404: Unclear spec for target typing with conditional operator (?:) Message-ID: <20130711143747.6555B489AC@hg.openjdk.java.net> Changeset: 87a951c88a33 Author: mcimadamore Date: 2013-07-11 15:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/87a951c88a33 8013404: Unclear spec for target typing with conditional operator (?:) Summary: Fix previously ignored test Reviewed-by: jjg, vromero ! test/tools/javac/lambda/TargetType36.java + test/tools/javac/lambda/TargetType36.out From valerie.peng at oracle.com Thu Jul 11 10:46:52 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Thu, 11 Jul 2013 10:46:52 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51DE3B05.4090202@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> Message-ID: <51DEEF8C.4010604@oracle.com> Yes, I think it'll help immensely if you have separate webrevs for each bug. As the patches/changes are recorded into each bug record, I think we should always separate the changes out. As far as I am concerned, this is more critical then the coding-style convention. But personal opinion may vary. Thanks, Valerie On 07/10/13 21:56, Anthony Scarpino wrote: > Sure I'll break it up if that's easier and someone will review it. > > thanks > > Tony > > On 07/10/2013 06:07 PM, Valerie (Yu-Ching) Peng wrote: >> Tony, >> >> Did someone review this yet? >> >> Since there are 3 bug fixes, can you separate them out into 3 webrevs? >> I believe that has been the convention to have one webrev corresponding >> to one bug. >> Otherwise, things can get confusing for both reviewers as well as >> sustaining if later they tried to backport. >> >> Thanks, >> Valerie >> >> On 06/24/13 11:37, Anthony Scarpino wrote: >>> I need a code review for some test changes. They include the follow >>> bugs: >>> JDK-8012971 PKCS11Test hiding exception failures >>> JDK-7193793 sun/security/pkcs11/ec/TestECDH.java failing intermittently >>> JDK-7198198 sun/security/pkcs11/ec/ReadCertificates.java fails on Suse >>> Linux >>> >>> A significant change is reading the NSS version. The test can now >>> avoid old NSS libraries or a bug in a version of NSS that generate >>> false jdk failures. This greatly helps ECC support and curve support >>> are varied. >>> >>> The fix to expose the exceptions that were being hidden did generate >>> new test failures that already had filed bugs. The failures were >>> added to the ProblemList. >>> >>> http://cr.openjdk.java.net/~ascarpino/8012971/webrev.00/ >>> >>> Tony >>> >>> >> > From valerie.peng at oracle.com Thu Jul 11 11:44:10 2013 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Thu, 11 Jul 2013 18:44:10 +0000 Subject: hg: jdk8/tl/jdk: 8020321: Problem in PKCS11 regression test TestRSAKeyLength Message-ID: <20130711184439.929B2489D1@hg.openjdk.java.net> Changeset: 162c015c434a Author: valeriep Date: 2013-07-11 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/162c015c434a 8020321: Problem in PKCS11 regression test TestRSAKeyLength Summary: Corrected the "isValidKeyLength" array Reviewed-by: xuelei ! test/sun/security/pkcs11/Signature/TestRSAKeyLength.java From kumar.x.srinivasan at oracle.com Thu Jul 11 13:05:09 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 11 Jul 2013 20:05:09 +0000 Subject: hg: jdk8/tl/jdk: 8019799: api/java_util/jar/Pack200 test failed with compactX profiles. Message-ID: <20130711200529.BA5C5489E7@hg.openjdk.java.net> Changeset: 0bd48087e2dc Author: ksrini Date: 2013-07-11 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0bd48087e2dc 8019799: api/java_util/jar/Pack200 test failed with compactX profiles. Reviewed-by: dholmes ! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java From dan.xu at oracle.com Thu Jul 11 13:41:02 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Thu, 11 Jul 2013 20:41:02 +0000 Subject: hg: jdk8/tl/jdk: 8017212: File.createTempFile requires unnecessary "read" permission Message-ID: <20130711204146.D9245489F1@hg.openjdk.java.net> Changeset: 10d2a4b1e576 Author: dxu Date: 2013-07-11 13:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/10d2a4b1e576 8017212: File.createTempFile requires unnecessary "read" permission Summary: Directly call FileSystem method to check a file existence. Also reviewed by tom.hawtin at oracle.com Reviewed-by: alanb ! src/share/classes/java/io/File.java + test/java/io/File/CheckPermission.java ! test/java/io/File/NulFile.java ! test/java/io/File/createTempFile/SpecialTempFile.java From anthony.scarpino at oracle.com Thu Jul 11 14:12:04 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Thu, 11 Jul 2013 14:12:04 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51DEEF8C.4010604@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> Message-ID: <51DF1FA4.8060609@oracle.com> I think I will create a bug for the NSS version checking and then close as a duplicate the other individual bugs related to the particular test cases. There are at least 9 test cases that are modified because of the NSS version checking and it would be unwieldy to have about 10 webrevs. So in the end, I'd have 2 webrevs. The first is the PKCS11Test hiding the failures, and the second the NSS version checking. Resulting in 7193793 & 7198198 to be closed as duplicates. Tony On 07/11/2013 10:46 AM, Valerie (Yu-Ching) Peng wrote: > Yes, I think it'll help immensely if you have separate webrevs for each > bug. > As the patches/changes are recorded into each bug record, I think we > should always separate the changes out. > As far as I am concerned, this is more critical then the coding-style > convention. But personal opinion may vary. > Thanks, > Valerie > > > On 07/10/13 21:56, Anthony Scarpino wrote: >> Sure I'll break it up if that's easier and someone will review it. >> >> thanks >> >> Tony >> >> On 07/10/2013 06:07 PM, Valerie (Yu-Ching) Peng wrote: >>> Tony, >>> >>> Did someone review this yet? >>> >>> Since there are 3 bug fixes, can you separate them out into 3 webrevs? >>> I believe that has been the convention to have one webrev corresponding >>> to one bug. >>> Otherwise, things can get confusing for both reviewers as well as >>> sustaining if later they tried to backport. >>> >>> Thanks, >>> Valerie >>> >>> On 06/24/13 11:37, Anthony Scarpino wrote: >>>> I need a code review for some test changes. They include the follow >>>> bugs: >>>> JDK-8012971 PKCS11Test hiding exception failures >>>> JDK-7193793 sun/security/pkcs11/ec/TestECDH.java failing intermittently >>>> JDK-7198198 sun/security/pkcs11/ec/ReadCertificates.java fails on Suse >>>> Linux >>>> >>>> A significant change is reading the NSS version. The test can now >>>> avoid old NSS libraries or a bug in a version of NSS that generate >>>> false jdk failures. This greatly helps ECC support and curve support >>>> are varied. >>>> >>>> The fix to expose the exceptions that were being hidden did generate >>>> new test failures that already had filed bugs. The failures were >>>> added to the ProblemList. >>>> >>>> http://cr.openjdk.java.net/~ascarpino/8012971/webrev.00/ >>>> >>>> Tony >>>> >>>> >>> >> > From jaroslav.bachorik at oracle.com Thu Jul 11 01:31:18 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Thu, 11 Jul 2013 08:31:18 +0000 Subject: hg: jdk8/tl/jdk: 8019826: Test com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java fails with NPE Message-ID: <20130711083140.7F3214898B@hg.openjdk.java.net> Changeset: a46982a212e0 Author: jbachorik Date: 2013-07-11 09:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a46982a212e0 8019826: Test com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java fails with NPE Reviewed-by: sjiang, dholmes, mchung ! test/com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java From jaroslav.bachorik at oracle.com Thu Jul 11 13:02:00 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Thu, 11 Jul 2013 20:02:00 +0000 Subject: hg: jdk8/tl/jdk: 8010285: Enforce the requirement of Management Interfaces being public Message-ID: <20130711200242.7F884489E6@hg.openjdk.java.net> Changeset: f3211af79339 Author: jbachorik Date: 2013-07-11 21:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3211af79339 8010285: Enforce the requirement of Management Interfaces being public Reviewed-by: sjiang, dfuchs, mchung ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanAnalyzer.java ! src/share/classes/javax/management/JMX.java ! src/share/classes/javax/management/MBeanServerInvocationHandler.java ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/package.html ! src/share/classes/sun/management/ManagementFactoryHelper.java + test/javax/management/MBeanServer/MBeanFallbackTest.java + test/javax/management/MBeanServer/MBeanTest.java + test/javax/management/mxbean/MXBeanFallbackTest.java ! test/javax/management/mxbean/MXBeanTest.java + test/javax/management/proxy/JMXProxyFallbackTest.java + test/javax/management/proxy/JMXProxyTest.java From valerie.peng at oracle.com Thu Jul 11 17:54:15 2013 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Fri, 12 Jul 2013 00:54:15 +0000 Subject: hg: jdk8/tl/jdk: 7 new changesets Message-ID: <20130712005547.CEC3448A0B@hg.openjdk.java.net> Changeset: f225da733291 Author: valeriep Date: 2013-07-05 13:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f225da733291 8012637: Adjust CipherInputStream class to work in AEAD/GCM mode Summary: Ensure the Cipher.doFinal() is called only once Reviewed-by: xuelei ! src/share/classes/javax/crypto/CipherInputStream.java + test/com/sun/crypto/provider/Cipher/AES/TestCICOWithGCM.java Changeset: 6e2a5637b286 Author: valeriep Date: 2013-07-05 13:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6e2a5637b286 7196805: DH Key interoperability testing between SunJCE and JsafeJCE not successful Summary: Check equality based on component values instead of encoding which may vary due to optional components Reviewed-by: weijun ! src/share/classes/com/sun/crypto/provider/DHKeyFactory.java ! src/share/classes/com/sun/crypto/provider/DHKeyPairGenerator.java ! src/share/classes/com/sun/crypto/provider/DHPrivateKey.java ! src/share/classes/com/sun/crypto/provider/DHPublicKey.java ! src/share/classes/sun/security/pkcs11/P11Key.java Changeset: f321b78c7009 Author: ascarpino Date: 2013-07-08 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f321b78c7009 6755701: SunJCE DES/DESede SecretKeyFactory.generateSecret throws InvalidKeySpecExc if passed SecretKeySpec Reviewed-by: valeriep, wetmore, xuelei ! src/share/classes/com/sun/crypto/provider/DESKeyFactory.java ! src/share/classes/com/sun/crypto/provider/DESedeKeyFactory.java + test/com/sun/crypto/provider/Cipher/DES/DESSecretKeySpec.java Changeset: 869bfa39d923 Author: valeriep Date: 2013-07-08 11:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/869bfa39d923 Merge - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java Changeset: 4fcac826628c Author: valeriep Date: 2013-07-09 15:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4fcac826628c Merge Changeset: 7bd2993e03fa Author: valeriep Date: 2013-07-10 18:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bd2993e03fa 8020310: JDK-6356530 broke the old build Summary: Add serialVersionUID to AuthProvider and P11Key class. Reviewed-by: xuelei ! src/share/classes/java/security/AuthProvider.java ! src/share/classes/sun/security/pkcs11/P11Key.java Changeset: 4c95c032c395 Author: valeriep Date: 2013-07-11 17:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c95c032c395 Merge From weijun.wang at oracle.com Fri Jul 12 00:19:58 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 12 Jul 2013 15:19:58 +0800 Subject: Code review reqest: 8019410: sun/security/krb5/auto/ReplayCacheTestProc.java Message-ID: <51DFAE1E.7000603@oracle.com> Please take a look at http://cr.openjdk.java.net/~weijun/8019410/webrev.00/ The ReplayCacheTestProc test fails on linux-i586 with MIT krb5 1.6.1 installed. The reason is that the acceptor does not start at all using native JGSS. This fix adds a sanity check on it and if the check does not pass only Java servers are started. We would consider adding tests on basic functions of native JGSS. But they probably belongs to SQE test suite because only there the test can talk to a real KDC. Thanks Max From mandy.chung at oracle.com Fri Jul 12 04:21:17 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 12 Jul 2013 11:21:17 +0000 Subject: hg: jdk8/tl/jdk: 8014890: (ref) Reference queues may return more entries than expected Message-ID: <20130712112200.49AF248A2E@hg.openjdk.java.net> Changeset: 858c75eb83b5 Author: mchung Date: 2013-07-08 14:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/858c75eb83b5 8014890: (ref) Reference queues may return more entries than expected Summary: When enqueuing references check whether the j.l.r.Reference has already been enqeued or removed in the lock. Do not enqueue them again. This occurs because multiple threads may try to enqueue the same j.l.r.Reference at the same time. Reviewed-by: mchung, dholmes, plevart, shade Contributed-by: thomas.schatzl at oracle.com ! src/share/classes/java/lang/ref/Reference.java ! src/share/classes/java/lang/ref/ReferenceQueue.java + test/java/lang/ref/EnqueuePollRace.java From sean.mullan at oracle.com Fri Jul 12 04:39:14 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 12 Jul 2013 07:39:14 -0400 Subject: Code review reqest: 8019410: sun/security/krb5/auto/ReplayCacheTestProc.java In-Reply-To: <51DFAE1E.7000603@oracle.com> References: <51DFAE1E.7000603@oracle.com> Message-ID: <51DFEAE2.3080004@oracle.com> Looks fine to me. --Sean On 07/12/2013 03:19 AM, Weijun Wang wrote: > Please take a look at > > http://cr.openjdk.java.net/~weijun/8019410/webrev.00/ > > The ReplayCacheTestProc test fails on linux-i586 with MIT krb5 1.6.1 > installed. The reason is that the acceptor does not start at all using > native JGSS. This fix adds a sanity check on it and if the check does > not pass only Java servers are started. > > We would consider adding tests on basic functions of native JGSS. But > they probably belongs to SQE test suite because only there the test can > talk to a real KDC. > > Thanks > Max > From sundararajan.athijegannathan at oracle.com Fri Jul 12 08:22:59 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 12 Jul 2013 15:22:59 +0000 Subject: hg: jdk8/tl/nashorn: 18 new changesets Message-ID: <20130712152315.667E148A38@hg.openjdk.java.net> Changeset: 5106d43feed7 Author: hannesw Date: 2013-07-08 19:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5106d43feed7 8019963: empty char range in regex Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java + test/script/basic/JDK-8019963.js + test/script/basic/JDK-8019963.js.EXPECTED Changeset: d3f4e5dea634 Author: attila Date: 2013-07-09 13:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d3f4e5dea634 8009758: reactivate the 8006529 test. Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/FunctionScope.java - test/script/currently-failing/JDK-8006529.js + test/script/trusted/JDK-8006529.js Changeset: 7538a59ca241 Author: sundar Date: 2013-07-09 17:37 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7538a59ca241 8014785: Ability to extend global instance by binding properties of another object Reviewed-by: attila, hannesw, jlaskey, lagergren ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/linker/InvokeByName.java + test/script/basic/JDK-8014785.js + test/script/basic/JDK-8014785.js.EXPECTED Changeset: d480015ab732 Author: lagergren Date: 2013-07-09 15:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d480015ab732 8020124: In the case of an eval switch, we might need explicit conversions of the tag store, as it was not known in the surrounding environment. Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8020124.js Changeset: 997a3215744a Author: sundar Date: 2013-07-10 13:25 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/997a3215744a 8020224: LinkageError: attempted duplicate class definition when --loader-per-compiler=false Reviewed-by: hannesw ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/runtime/CodeInstaller.java ! src/jdk/nashorn/internal/runtime/Context.java ! test/src/jdk/nashorn/internal/runtime/TrustedScriptEngineTest.java Changeset: a9b74daed4f9 Author: hannesw Date: 2013-07-10 10:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a9b74daed4f9 8016681: regex capture behaves differently than on V8 Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java + test/script/basic/JDK-8016681.js + test/script/basic/JDK-8016681.js.EXPECTED Changeset: c501b1666bda Author: sundar Date: 2013-07-10 19:08 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c501b1666bda 8020276: interface checks in Invocable.getInterface implementation Reviewed-by: jlaskey, hannesw, attila ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: 798e3aa19718 Author: sundar Date: 2013-07-11 16:34 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/798e3aa19718 8020325: static property does not work on accessible, public classes Reviewed-by: attila, hannesw, lagergren ! make/build.xml ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/lookup/Lookup.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java + test/script/basic/JDK-8020325.js + test/script/basic/JDK-8020325.js.EXPECTED ! test/script/trusted/JDK-8006529.js ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: 58614b556a0d Author: sundar Date: 2013-07-11 18:23 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/58614b556a0d 8020380: __noSuchProperty__ defined in mozilla_compat.js script should be non-enumerable Reviewed-by: jlaskey, hannesw, attila ! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js + test/script/basic/JDK-8020380.js Changeset: 2c007a8bb0e7 Author: attila Date: 2013-07-11 18:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2c007a8bb0e7 8013925: Remove symbol fields from nodes that don't need them Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/BranchOptimizer.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/FunctionSignature.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/RangeAnalyzer.java ! src/jdk/nashorn/internal/codegen/SpillObjectCreator.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/Assignment.java ! src/jdk/nashorn/internal/ir/BaseNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java + src/jdk/nashorn/internal/ir/BlockStatement.java ! src/jdk/nashorn/internal/ir/BreakableNode.java + src/jdk/nashorn/internal/ir/BreakableStatement.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java - src/jdk/nashorn/internal/ir/ExecuteNode.java + src/jdk/nashorn/internal/ir/Expression.java + src/jdk/nashorn/internal/ir/ExpressionStatement.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java + src/jdk/nashorn/internal/ir/LexicalContextExpression.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java + src/jdk/nashorn/internal/ir/LexicalContextStatement.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/LoopNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/TemporarySymbols.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/ASTWriter.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java ! test/script/trusted/JDK-8006529.js Changeset: 9083af56bbcb Author: sundar Date: 2013-07-11 22:58 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9083af56bbcb 8012191: noSuchProperty can't cope with vararg functions Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/runtime/ScriptFunction.java + test/script/basic/JDK-8012191.js + test/script/basic/JDK-8012191.js.EXPECTED Changeset: 289923785ada Author: attila Date: 2013-07-11 22:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/289923785ada 8020125: PrintVisitor wasn't printing bodies of FunctionNode within UnaryNode Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java Changeset: d763da247244 Author: sundar Date: 2013-07-12 15:01 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d763da247244 8020437: Wrong handling of line numbers with multiline string literals Reviewed-by: attila, lagergren ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8020437.js + test/script/basic/JDK-8020437.js.EXPECTED + test/script/error/JDK-8020437-2.js + test/script/error/JDK-8020437-2.js.EXPECTED + test/script/error/JDK-8020437.js + test/script/error/JDK-8020437.js.EXPECTED Changeset: 1a6b1799f533 Author: sundar Date: 2013-07-12 15:27 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1a6b1799f533 8020223: ClassCastException: String can not be casted to ScriptFunction Reviewed-by: attila, lagergren ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8020223.js Changeset: e27ebcfed6fa Author: attila Date: 2013-07-12 11:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e27ebcfed6fa 8019822: Duplicate name and signature in finally block Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8019822.js Changeset: 8108ba8366fd Author: sundar Date: 2013-07-12 20:12 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8108ba8366fd Merge - src/jdk/nashorn/internal/ir/ExecuteNode.java - test/script/currently-failing/JDK-8006529.js Changeset: 5cdf4352ee0b Author: sundar Date: 2013-07-12 20:06 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5cdf4352ee0b 8020463: Input argument array wrapping in loadWithNewGlobal is wrong Reviewed-by: attila, jlaskey ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/Context.java + test/script/basic/JDK-8020463.js ! test/src/jdk/nashorn/api/scripting/ScriptEngineSecurityTest.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: cbfeffbcd3f2 Author: sundar Date: 2013-07-12 20:13 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/cbfeffbcd3f2 Merge From huizhe.wang at oracle.com Fri Jul 12 11:13:44 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Fri, 12 Jul 2013 18:13:44 +0000 Subject: hg: jdk8/tl/jaxp: 8020430: NullPointerException in xml sqe nightly result on 2013-07-12 Message-ID: <20130712181348.5E00248A3F@hg.openjdk.java.net> Changeset: aabe15fc346f Author: joehw Date: 2013-07-12 11:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/aabe15fc346f 8020430: NullPointerException in xml sqe nightly result on 2013-07-12 Reviewed-by: chegar, lancea ! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java From huizhe.wang at oracle.com Fri Jul 12 11:20:30 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Fri, 12 Jul 2013 18:20:30 +0000 Subject: hg: jdk8/tl/jdk: 8020430: NullPointerException in xml sqe nightly result on 2013-07-12 Message-ID: <20130712182052.C7B9648A40@hg.openjdk.java.net> Changeset: 2504f01bc83f Author: joehw Date: 2013-07-12 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2504f01bc83f 8020430: NullPointerException in xml sqe nightly result on 2013-07-12 Reviewed-by: chegar, lancea + test/javax/xml/jaxp/common/8020430/JAXP15RegTest.java + test/javax/xml/jaxp/common/8020430/TestBase.java From joe.darcy at oracle.com Fri Jul 12 11:48:40 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 12 Jul 2013 18:48:40 +0000 Subject: hg: jdk8/tl/jdk: 8010679: Clarify "present" and annotation ordering in Core Reflection for Annotations Message-ID: <20130712184852.8A73348A41@hg.openjdk.java.net> Changeset: af62c6175f92 Author: darcy Date: 2013-07-12 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af62c6175f92 8010679: Clarify "present" and annotation ordering in Core Reflection for Annotations Reviewed-by: abuckley, jfranck ! src/share/classes/java/lang/reflect/AnnotatedElement.java From paul.sandoz at oracle.com Fri Jul 12 12:32:38 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Fri, 12 Jul 2013 19:32:38 +0000 Subject: hg: jdk8/tl/jdk: 8019395: Consolidate StreamSupport.{stream, parallelStream} into a single method Message-ID: <20130712193250.978A848A46@hg.openjdk.java.net> Changeset: be096613bfb5 Author: psandoz Date: 2013-07-03 21:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be096613bfb5 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method Reviewed-by: henryjen, briangoetz ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/lang/CharSequence.java ! src/share/classes/java/nio/X-Buffer.java.template ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/BitSet.java ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/StreamSupport.java ! src/share/classes/java/util/stream/Streams.java ! src/share/classes/java/util/zip/ZipFile.java ! test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestScenario.java ! test/java/util/stream/bootlib/java/util/stream/IntStreamTestScenario.java ! test/java/util/stream/bootlib/java/util/stream/LongStreamTestScenario.java ! test/java/util/stream/bootlib/java/util/stream/StreamTestScenario.java ! test/java/util/stream/bootlib/java/util/stream/TestData.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/MatchOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamSpliteratorTest.java From vincent.x.ryan at oracle.com Fri Jul 12 12:45:49 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Fri, 12 Jul 2013 19:45:49 +0000 Subject: hg: jdk8/tl/jdk: 8019627: RuntimeException gets obscured during OCSP cert revocation checking Message-ID: <20130712194602.3A5D648A47@hg.openjdk.java.net> Changeset: b3ca5fb77e2c Author: vinnie Date: 2013-07-12 20:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3ca5fb77e2c 8019627: RuntimeException gets obscured during OCSP cert revocation checking Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! test/java/security/cert/CertPathValidator/OCSP/FailoverToCRL.java From mike.duigou at oracle.com Fri Jul 12 12:16:52 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 12 Jul 2013 19:16:52 +0000 Subject: hg: jdk8/tl/jdk: 4 new changesets Message-ID: <20130712191742.313E348A42@hg.openjdk.java.net> Changeset: fe6e4e2c367d Author: mduigou Date: 2013-07-12 11:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe6e4e2c367d 7129185: Add Collections.{checked|empty|unmodifiable}Navigable{Map|Set} Reviewed-by: dmocek, martin, smarks ! src/share/classes/java/util/AbstractMap.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/NavigableSet.java ! test/java/util/Collection/MOAT.java ! test/java/util/Collections/CheckedIdentityMap.java ! test/java/util/Collections/CheckedMapBash.java ! test/java/util/Collections/CheckedSetBash.java ! test/java/util/Collections/EmptyCollectionSerialization.java + test/java/util/Collections/EmptyNavigableMap.java + test/java/util/Collections/EmptyNavigableSet.java - test/java/util/Collections/EmptySortedSet.java ! test/java/util/Map/LockStep.java ! test/java/util/NavigableMap/LockStep.java Changeset: 623a10b23ed8 Author: mduigou Date: 2013-07-12 11:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/623a10b23ed8 8015317: Optional.filter, map, and flatMap Reviewed-by: psandoz, mduigou Contributed-by: brian.goetz at oracle.com, henry.jen at oracle.com ! src/share/classes/java/util/Optional.java ! src/share/classes/java/util/OptionalDouble.java ! src/share/classes/java/util/OptionalInt.java ! src/share/classes/java/util/OptionalLong.java ! test/java/util/Optional/Basic.java Changeset: 06749efce430 Author: mduigou Date: 2013-07-12 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/06749efce430 8015315: Stream.concat methods Reviewed-by: psandoz, mduigou Contributed-by: brian.goetz at oracle.com, henry.jen at oracle.com ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/Streams.java ! test/java/util/stream/bootlib/java/util/stream/LambdaTestHelpers.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ConcatOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ConcatTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest.java Changeset: 5b6f94559589 Author: mduigou Date: 2013-07-12 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5b6f94559589 Merge - test/java/util/Collections/EmptySortedSet.java From jonathan.gibbons at oracle.com Fri Jul 12 13:11:17 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 12 Jul 2013 20:11:17 +0000 Subject: hg: jdk8/tl/langtools: 8020278: NPE in javadoc Message-ID: <20130712201123.E123248A48@hg.openjdk.java.net> Changeset: 37031963493e Author: jjg Date: 2013-07-12 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37031963493e 8020278: NPE in javadoc Reviewed-by: mcimadamore, vromero ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/Env.java + test/tools/doclint/BadPackageCommentTest.java + test/tools/doclint/BadPackageCommentTest.out From mike.duigou at oracle.com Fri Jul 12 15:45:01 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 12 Jul 2013 22:45:01 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130712224538.1056A48A4C@hg.openjdk.java.net> Changeset: 9b17939958e7 Author: henryjen Date: 2013-07-12 15:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b17939958e7 8015320: Pull spliterator() up from Collection to Iterable Reviewed-by: psandoz, mduigou Contributed-by: brian.goetz at oracle.com ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/ConcurrentModificationException.java ! test/java/util/Spliterator/SpliteratorCollisions.java ! test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java Changeset: 37c37361a7ad Author: henryjen Date: 2013-07-08 15:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37c37361a7ad 8020062: Nest StreamBuilder interfaces inside relevant Stream interfaces Reviewed-by: psandoz, mduigou Contributed-by: brian goetz ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java - src/share/classes/java/util/stream/StreamBuilder.java ! src/share/classes/java/util/stream/Streams.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamBuilderTest.java From weijun.wang at oracle.com Fri Jul 12 17:48:23 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Sat, 13 Jul 2013 00:48:23 +0000 Subject: hg: jdk8/tl/jdk: 8019410: sun/security/krb5/auto/ReplayCacheTestProc.java Message-ID: <20130713004834.DA19248A54@hg.openjdk.java.net> Changeset: 5f2a8db78aca Author: weijun Date: 2013-07-13 08:47 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f2a8db78aca 8019410: sun/security/krb5/auto/ReplayCacheTestProc.java Reviewed-by: mullan ! test/sun/security/krb5/auto/ReplayCacheTestProc.java From weijun.wang at oracle.com Sun Jul 14 20:58:47 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 15 Jul 2013 11:58:47 +0800 Subject: Suggested update to RFC 5653 JGSS-API: Provide a way to return a token when context establishment fails In-Reply-To: <51B1E355.2090301@oracle.com> References: <51B1E355.2090301@oracle.com> Message-ID: <51E37377.1030704@oracle.com> Hi All I am Weijun Wang from the Java SE Seurity Team at Oracle, and this mail is about a design flaw in the initSecContext and acceptSecContext methods of the GSSContext class defined in RFC 5653 7.4.3 [1] and 7.4.9 [2]. The GSSContext::initSecContext() method could either return a token (possibly null if no more token is needed) when the call succeeds or throw a GSSException if there is a failure, but not *both*. The same applies to acceptSecContext(). On the other hand, the C bindings of GSS-API has a chance to return both, and it does try to make use of both of them (according to RFC 2743 2.2.1 [3]): It is the caller's responsibility to establish a communications path to the target, and to transmit any returned output_token (independent of the accompanying returned major_status value) to the target over that path. Without the ability to send a token when there is a failure, a Java program has no chance to tell the other side what's happening. This is very user-unfriendly. Also, in the case of SPNEGO, a "reject" NegTokenResp token will never be able to sent out. My current proposal is to add a new method getOutputToken() to the GSSException class (which will be thrown when an error occurs) to return this last token. This means the method calls will be something like try { send(initSecContext(inToken)); } catch (GSSException e) { if (e.getOutputToken() != null) { send(e.getOutputToken()); } throw e; } The getOutputToken() method can only return a non-null value when it's thrown by an initSecContext or acceptSecContext call. The method won't throw another GSSException even if the exception was thrown in other calls. We can use the new JDK 8 default method feature [1] to add this new method to the existing GSSException interface. Thanks Weijun [1] http://tools.ietf.org/html/rfc5653#section-7.4.3[2] http://tools.ietf.org/html/rfc5653#section-7.4.9 [3] http://tools.ietf.org/html/rfc2743#page-46 [4] http://tools.ietf.org/html/rfc5653#section-7.4.5 From weijun.wang at oracle.com Mon Jul 15 04:02:16 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 15 Jul 2013 19:02:16 +0800 Subject: Code review request: 8016594: Native Windows ccache still reads DES tickets Message-ID: <51E3D6B8.5000907@oracle.com> Please take a look at http://cr.openjdk.java.net/~weijun/8016594/webrev.00/ Instead of always reading tickets with session key of DES/RC4 etypes, it should accept any ticket in the default_tkt_enctypes setting. No reg test, needs a SQE test running with Windows 2008 as server. Thanks Max From sean.coffey at oracle.com Mon Jul 15 05:45:53 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Mon, 15 Jul 2013 12:45:53 +0000 Subject: hg: jdk8/tl/jdk: 8017566: Backout 8000450 - Cannot access to com.sun.corba.se.impl.orb.ORBImpl Message-ID: <20130715124606.E31EC480AE@hg.openjdk.java.net> Changeset: 7cc35dd1885d Author: coffeys Date: 2013-07-15 13:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cc35dd1885d 8017566: Backout 8000450 - Cannot access to com.sun.corba.se.impl.orb.ORBImpl Reviewed-by: mchung ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/lang/SecurityManager/CheckPackageAccess.java From joel.franck at oracle.com Mon Jul 15 02:27:10 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Mon, 15 Jul 2013 09:27:10 +0000 Subject: hg: jdk8/tl/jdk: 7122142: (ann) Race condition between isAnnotationPresent and getAnnotations Message-ID: <20130715092739.9D7D8480AA@hg.openjdk.java.net> Changeset: e4ce6502eac0 Author: plevart Date: 2013-07-15 10:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4ce6502eac0 7122142: (ann) Race condition between isAnnotationPresent and getAnnotations Reviewed-by: dholmes, jfranck ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/System.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/reflect/annotation/AnnotationParser.java ! src/share/classes/sun/reflect/annotation/AnnotationType.java + test/java/lang/annotation/AnnotationType/AnnotationTypeDeadlockTest.java + test/java/lang/annotation/AnnotationType/AnnotationTypeRuntimeAssumptionTest.java From jhutz at cmu.edu Mon Jul 15 10:33:41 2013 From: jhutz at cmu.edu (Jeffrey Hutzelman) Date: Mon, 15 Jul 2013 13:33:41 -0400 Subject: [kitten] Suggested update to RFC 5653 JGSS-API: Provide a way to return a token when context establishment fails In-Reply-To: <16819_1373860748_r6F3x7Tp017281_51E37377.1030704@oracle.com> References: <51B1E355.2090301@oracle.com> <16819_1373860748_r6F3x7Tp017281_51E37377.1030704@oracle.com> Message-ID: <1373909621.23365.286.camel@minbar.fac.cs.cmu.edu> On Mon, 2013-07-15 at 11:58 +0800, Weijun Wang wrote: > My current proposal is to add a new method getOutputToken() to the > GSSException class (which will be thrown when an error occurs) to return > this last token. This means the method calls will be something like This seems like an elegant solution to the problem. -- Jeff From jason.uh at oracle.com Mon Jul 15 17:50:00 2013 From: jason.uh at oracle.com (Jason Uh) Date: Mon, 15 Jul 2013 17:50:00 -0700 Subject: [8] Request for Review: 8020557: javadoc cleanup in javax.security Message-ID: <51E498B8.1020405@oracle.com> Hi Joe, Could you please review this changeset? This change converts the javadoc "..." and "..." HTML tags to "{@code ...}" and also converts package.html files to package-info.java files. Webrev: http://cr.openjdk.java.net/~juh/8020557/webrev.00/ No changes detected by specdiff. Thanks, Jason From joe.darcy at oracle.com Mon Jul 15 18:16:08 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 16 Jul 2013 01:16:08 +0000 Subject: hg: jdk8/tl/jdk: 8020409: Clean up doclint problems in java.util package, part 1 Message-ID: <20130716011631.A0175480D3@hg.openjdk.java.net> Changeset: 94e1a4b10811 Author: bpb Date: 2013-07-15 14:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94e1a4b10811 8020409: Clean up doclint problems in java.util package, part 1 Summary: Clean up doclint problems in java.util package, part 1 Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Base64.java ! src/share/classes/java/util/BitSet.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/EnumSet.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/ResourceBundle.java From joe.darcy at oracle.com Mon Jul 15 18:33:53 2013 From: joe.darcy at oracle.com (Joseph Darcy) Date: Mon, 15 Jul 2013 18:33:53 -0700 Subject: [8] Request for Review: 8020557: javadoc cleanup in javax.security In-Reply-To: <51E498B8.1020405@oracle.com> References: <51E498B8.1020405@oracle.com> Message-ID: <51E4A301.3030403@oracle.com> Hi Jason, Everything looks fine; approved to go back. Thanks, -Joe On 7/15/2013 5:50 PM, Jason Uh wrote: > Hi Joe, > > Could you please review this changeset? This change converts the > javadoc "..." and "..." HTML tags to "{@code > ...}" and also converts package.html files to package-info.java files. > > Webrev: http://cr.openjdk.java.net/~juh/8020557/webrev.00/ > > No changes detected by specdiff. > > Thanks, > Jason From sundararajan.athijegannathan at oracle.com Mon Jul 15 22:27:55 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 16 Jul 2013 05:27:55 +0000 Subject: hg: jdk8/tl/nashorn: 7 new changesets Message-ID: <20130716052801.71484480DA@hg.openjdk.java.net> Changeset: 973d78ee0728 Author: attila Date: 2013-07-15 12:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/973d78ee0728 8020324: Implement Object.bindProperties(target, source) for beans Reviewed-by: hannesw, sundar ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/beans/BeansLinker.java ! src/jdk/internal/dynalink/beans/StaticClassLinker.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java + src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethod.java + src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethodLinker.java + test/script/basic/JDK-8020324.js + test/script/basic/JDK-8020324.js.EXPECTED + test/src/jdk/nashorn/test/models/PropertyBind.java Changeset: 62c552bcc342 Author: hannesw Date: 2013-07-15 15:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/62c552bcc342 8020354: Object literal property initialization is not done in source order Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8020354.js + test/script/basic/JDK-8020354.js.EXPECTED Changeset: ede320e13c82 Author: attila Date: 2013-07-15 16:31 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ede320e13c82 8020508: Enforce reflection access restrictions on Object.bindProperties Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java + test/script/basic/JDK-8020508.js + test/script/basic/JDK-8020508.js.EXPECTED Changeset: e5505f0b10de Author: hannesw Date: 2013-07-15 16:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e5505f0b10de 8020283: Don't use exceptions for widening of ArrayData Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java Changeset: 01212f5e7dad Author: attila Date: 2013-07-15 16:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/01212f5e7dad 8011210: fix reporting of call site locations; print them on -tcs=miss Reviewed-by: jlaskey, hannesw ! src/jdk/internal/dynalink/DynamicLinker.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java Changeset: 28f1f2374004 Author: hannesw Date: 2013-07-15 18:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/28f1f2374004 8020358: Array(0xfffffff) throws OutOfMemoryError Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java + test/script/basic/JDK-8020358.js + test/script/basic/JDK-8020358.js.EXPECTED Changeset: d685fec24d13 Author: sundar Date: 2013-07-16 09:54 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d685fec24d13 Merge From vincent.x.ryan at oracle.com Tue Jul 16 08:45:45 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 16 Jul 2013 16:45:45 +0100 Subject: [8] code review for 7084026: sun/security/mscapi/KeytoolChangeAlias.sh fails consistently on win2003 Message-ID: <01101DEF-FCDE-47EA-A402-6671E1E08F7F@oracle.com> Please review the following fix that adds cleanup code to a failing testcase: Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7084026 Webrev: http://cr.openjdk.java.net/~vinnie/7084026/webrev.00/ Thanks. From sundararajan.athijegannathan at oracle.com Tue Jul 16 09:16:30 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 16 Jul 2013 16:16:30 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20130716161634.5657648103@hg.openjdk.java.net> Changeset: 965d876853ec Author: attila Date: 2013-07-16 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/965d876853ec 8020357: throw RangeError for too large NativeArrayBuffer size Reviewed-by: jlaskey, hannesw, sundar ! src/jdk/nashorn/internal/objects/ArrayBufferView.java + test/script/basic/JDK-8020357.js + test/script/basic/JDK-8020357.js.EXPECTED Changeset: 7503f30c1355 Author: hannesw Date: 2013-07-16 16:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7503f30c1355 8010821: [findbugs] Some classes in jdk.nashorn.internal.runtime.regexp expose mutable objects Reviewed-by: attila, jlaskey, sundar ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Analyser.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ArrayCompiler.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodePrinter.java ! src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java ! src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Lexer.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Regex.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ScanEnvironment.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ScannerSupport.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Token.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/BackRefNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/CClassNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/StateNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/StringNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/constants/OPCode.java Changeset: 78bdb8a7f1e7 Author: attila Date: 2013-07-16 17:03 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/78bdb8a7f1e7 8015356: array concatenation should skip empty elements Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8015356.js + test/script/basic/JDK-8015356.js.EXPECTED From sean.mullan at oracle.com Tue Jul 16 12:11:29 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 16 Jul 2013 15:11:29 -0400 Subject: [8] Code Review Request: 8010748: Add PKIXRevocationChecker NO_FALLBACK option and improve SOFT_FAIL option Message-ID: <51E59AE1.5050001@oracle.com> Please review my JDK 8 fix for 8010748: http://bugs.sun.com/view_bug.do?bug_id=8010748 This add a few useful API additions to JEP 124 (Enhance the Certificate Revocation-Checking API) from experience with using the API. webrev: http://cr.openjdk.java.net/~mullan/webrevs/8010748/webrev.00/ Thanks, Sean From jason.uh at oracle.com Tue Jul 16 12:20:18 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Tue, 16 Jul 2013 19:20:18 +0000 Subject: hg: jdk8/tl/jdk: 8020557: javadoc cleanup in javax.security Message-ID: <20130716192100.E667548112@hg.openjdk.java.net> Changeset: f7af15e2c95b Author: juh Date: 2013-07-16 12:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7af15e2c95b 8020557: javadoc cleanup in javax.security Reviewed-by: darcy ! src/share/classes/javax/security/auth/AuthPermission.java ! src/share/classes/javax/security/auth/DestroyFailedException.java ! src/share/classes/javax/security/auth/Destroyable.java ! src/share/classes/javax/security/auth/Policy.java ! src/share/classes/javax/security/auth/PrivateCredentialPermission.java ! src/share/classes/javax/security/auth/RefreshFailedException.java ! src/share/classes/javax/security/auth/Refreshable.java ! src/share/classes/javax/security/auth/Subject.java ! src/share/classes/javax/security/auth/SubjectDomainCombiner.java ! src/share/classes/javax/security/auth/callback/Callback.java ! src/share/classes/javax/security/auth/callback/CallbackHandler.java ! src/share/classes/javax/security/auth/callback/ChoiceCallback.java ! src/share/classes/javax/security/auth/callback/ConfirmationCallback.java ! src/share/classes/javax/security/auth/callback/LanguageCallback.java ! src/share/classes/javax/security/auth/callback/NameCallback.java ! src/share/classes/javax/security/auth/callback/PasswordCallback.java ! src/share/classes/javax/security/auth/callback/TextInputCallback.java ! src/share/classes/javax/security/auth/callback/TextOutputCallback.java ! src/share/classes/javax/security/auth/callback/UnsupportedCallbackException.java + src/share/classes/javax/security/auth/callback/package-info.java - src/share/classes/javax/security/auth/callback/package.html ! src/share/classes/javax/security/auth/kerberos/DelegationPermission.java ! src/share/classes/javax/security/auth/kerberos/KerberosKey.java ! src/share/classes/javax/security/auth/kerberos/KerberosPrincipal.java ! src/share/classes/javax/security/auth/kerberos/KerberosTicket.java ! src/share/classes/javax/security/auth/kerberos/KeyImpl.java ! src/share/classes/javax/security/auth/kerberos/KeyTab.java ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java + src/share/classes/javax/security/auth/kerberos/package-info.java - src/share/classes/javax/security/auth/kerberos/package.html ! src/share/classes/javax/security/auth/login/AccountExpiredException.java ! src/share/classes/javax/security/auth/login/AppConfigurationEntry.java ! src/share/classes/javax/security/auth/login/Configuration.java ! src/share/classes/javax/security/auth/login/ConfigurationSpi.java ! src/share/classes/javax/security/auth/login/CredentialExpiredException.java ! src/share/classes/javax/security/auth/login/FailedLoginException.java ! src/share/classes/javax/security/auth/login/LoginContext.java + src/share/classes/javax/security/auth/login/package-info.java - src/share/classes/javax/security/auth/login/package.html + src/share/classes/javax/security/auth/package-info.java - src/share/classes/javax/security/auth/package.html ! src/share/classes/javax/security/auth/spi/LoginModule.java + src/share/classes/javax/security/auth/spi/package-info.java - src/share/classes/javax/security/auth/spi/package.html ! src/share/classes/javax/security/auth/x500/X500Principal.java ! src/share/classes/javax/security/auth/x500/X500PrivateCredential.java + src/share/classes/javax/security/auth/x500/package-info.java - src/share/classes/javax/security/auth/x500/package.html ! src/share/classes/javax/security/cert/Certificate.java ! src/share/classes/javax/security/cert/CertificateEncodingException.java ! src/share/classes/javax/security/cert/CertificateException.java ! src/share/classes/javax/security/cert/CertificateExpiredException.java ! src/share/classes/javax/security/cert/CertificateNotYetValidException.java ! src/share/classes/javax/security/cert/CertificateParsingException.java ! src/share/classes/javax/security/cert/X509Certificate.java + src/share/classes/javax/security/cert/package-info.java - src/share/classes/javax/security/cert/package.html ! src/share/classes/javax/security/sasl/AuthenticationException.java ! src/share/classes/javax/security/sasl/AuthorizeCallback.java ! src/share/classes/javax/security/sasl/RealmCallback.java ! src/share/classes/javax/security/sasl/RealmChoiceCallback.java ! src/share/classes/javax/security/sasl/Sasl.java ! src/share/classes/javax/security/sasl/SaslClient.java ! src/share/classes/javax/security/sasl/SaslClientFactory.java ! src/share/classes/javax/security/sasl/SaslException.java ! src/share/classes/javax/security/sasl/SaslServer.java ! src/share/classes/javax/security/sasl/SaslServerFactory.java + src/share/classes/javax/security/sasl/package-info.java - src/share/classes/javax/security/sasl/package.html From xuelei.fan at oracle.com Tue Jul 16 18:18:08 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 17 Jul 2013 09:18:08 +0800 Subject: [8] code review for 7084026: sun/security/mscapi/KeytoolChangeAlias.sh fails consistently on win2003 In-Reply-To: <01101DEF-FCDE-47EA-A402-6671E1E08F7F@oracle.com> References: <01101DEF-FCDE-47EA-A402-6671E1E08F7F@oracle.com> Message-ID: <51E5F0D0.8010908@oracle.com> Looks fine. Xuelei On 7/16/2013 11:45 PM, Vincent Ryan wrote: > Please review the following fix that adds cleanup code to a failing testcase: > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7084026 > Webrev: http://cr.openjdk.java.net/~vinnie/7084026/webrev.00/ > > Thanks. > From maurizio.cimadamore at oracle.com Wed Jul 17 07:28:47 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 17 Jul 2013 14:28:47 +0000 Subject: hg: jdk8/tl/langtools: 10 new changesets Message-ID: <20130717142920.800FD48153@hg.openjdk.java.net> Changeset: 44e27378f523 Author: mcimadamore Date: 2013-07-17 14:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/44e27378f523 8012242: Lambda compatibility and checked exceptions Summary: Inference variables in 'throws' clause with no constraints should be inferred as RuntimeException Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! test/tools/javac/generics/6723444/T6723444.java - test/tools/javac/generics/6723444/T6723444.out + test/tools/javac/generics/6723444/T6723444_1.out + test/tools/javac/generics/6723444/T6723444_2.out ! test/tools/javac/generics/7015430/T7015430.java - test/tools/javac/generics/7015430/T7015430.out + test/tools/javac/generics/7015430/T7015430_1.out + test/tools/javac/generics/7015430/T7015430_2.out + test/tools/javac/lambda/TargetType63.java + test/tools/javac/lambda/TargetType63.out Changeset: 866c87c01285 Author: mcimadamore Date: 2013-07-17 14:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/866c87c01285 8016175: Add bottom-up type-checking support for unambiguous method references Summary: Type-checking of non-overloaded method references should be independent from target-type Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/MethodReference68.java + test/tools/javac/lambda/MethodReference68.out + test/tools/javac/lambda/MethodReference69.java + test/tools/javac/lambda/MethodReference69.out + test/tools/javac/lambda/MethodReference70.java + test/tools/javac/lambda/MethodReference70.out + test/tools/javac/lambda/MethodReference71.java + test/tools/javac/lambda/MethodReference71.out + test/tools/javac/lambda/MethodReference72.java + test/tools/javac/lambda/MethodReference72.out ! test/tools/javac/lambda/TargetType60.out + test/tools/javac/lambda/TargetType76.java Changeset: a204cf7aab7e Author: mcimadamore Date: 2013-07-17 14:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a204cf7aab7e 8012238: Nested method capture and inference 8008200: java/lang/Class/asSubclass/BasicUnit.java fails to compile Summary: Inference support should be more flexible w.r.t. nested method calls returning captured types Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/NestedCapture01.java + test/tools/javac/lambda/NestedCapture02.java + test/tools/javac/lambda/NestedCapture03.java Changeset: c60a5099863a Author: mcimadamore Date: 2013-07-17 14:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c60a5099863a 8020147: Spurious errors when compiling nested stuck lambdas Summary: Scope of deferred types is not copied correctly; postAttr analyzer should not run on stuck expressions Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java + test/tools/javac/lambda/8020147/T8020147.java + test/tools/javac/lambda/8020147/T8020147.out Changeset: 328896931b98 Author: mcimadamore Date: 2013-07-17 14:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/328896931b98 8020286: Wrong diagnostic after compaction Summary: compact diagnostic shows the least relevant method in the list Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/Diagnostics/compressed/T8020286.java + test/tools/javac/Diagnostics/compressed/T8020286.out Changeset: db2c539819dd Author: mcimadamore Date: 2013-07-17 14:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/db2c539819dd 7041019: Bogus type-variable substitution with array types with dependencies on accessibility check Summary: call to upperBound() when performing type-variable substitution on element type leads to unsoundness Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/generics/7034511/T7034511a.java ! test/tools/javac/generics/7034511/T7034511a.out ! test/tools/javac/generics/7034511/T7034511b.java ! test/tools/javac/generics/7034511/T7034511b.out + test/tools/javac/generics/7034511/T7041019.java Changeset: fae8f309ff80 Author: mcimadamore Date: 2013-07-17 14:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fae8f309ff80 8016640: compiler hangs if the generics arity of a base class is wrong Summary: Check.checkCompatibleConcretes hang when javac creates synthetic supertypes for 269 model API Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java + test/tools/javac/generics/8016640/T8016640.java + test/tools/javac/generics/8016640/T8016640.out Changeset: 155809b1b969 Author: mcimadamore Date: 2013-07-17 14:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/155809b1b969 8020149: Graph inference: wrong logic for picking best variable to solve Summary: Replace logic for selecting best inference leaf in the graph during an unsticking round Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/8020149/T8020149.java Changeset: b577222ef7b3 Author: mcimadamore Date: 2013-07-17 14:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b577222ef7b3 8019340: varargs-related warnings are meaningless on signature-polymorphic methods such as MethodHandle.invokeExact Summary: Disable certain varargs warnings when compiling polymorphic signature calls Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/meth/VarargsWarn.java + test/tools/javac/meth/VarargsWarn.out Changeset: f65a807714ba Author: mcimadamore Date: 2013-07-17 14:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f65a807714ba 8019942: Graph inference: avoid redundant computation during bound incorporation Summary: Bound incorporation should not perform same operation multiple times Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! test/tools/javac/generics/inference/8019824/T8019824.out From maurizio.cimadamore at oracle.com Wed Jul 17 07:46:04 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 17 Jul 2013 14:46:04 +0000 Subject: hg: jdk8/tl/langtools: 8020586: Warning produced for an incorrect file Message-ID: <20130717144608.EDAB948154@hg.openjdk.java.net> Changeset: 10711bd8bb2d Author: jlahoda Date: 2013-07-17 15:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/10711bd8bb2d 8020586: Warning produced for an incorrect file Summary: Always using DeferredLintHandler.immediateHandler when processing import classes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/warnings/6594914/Auxiliary.java + test/tools/javac/warnings/6594914/ExplicitCompilation.out + test/tools/javac/warnings/6594914/ImplicitCompilation.java + test/tools/javac/warnings/6594914/ImplicitCompilation.out From lana.steuck at oracle.com Wed Jul 17 12:01:57 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 17 Jul 2013 19:01:57 +0000 Subject: hg: jdk8/tl/jaxws: Added tag jdk8-b98 for changeset b1fb4612a2ca Message-ID: <20130717190204.104B048166@hg.openjdk.java.net> Changeset: 8ef83d4b23c9 Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/8ef83d4b23c9 Added tag jdk8-b98 for changeset b1fb4612a2ca ! .hgtags From lana.steuck at oracle.com Wed Jul 17 12:01:55 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 17 Jul 2013 19:01:55 +0000 Subject: hg: jdk8/tl: 2 new changesets Message-ID: <20130717190156.42B3148163@hg.openjdk.java.net> Changeset: 0d0c983a817b Author: tbell Date: 2013-07-09 08:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0d0c983a817b 8009315: F# on PATH breaks Cygwin tools (mkdir, echo, mktemp ...) Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 59dc9da81379 Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/59dc9da81379 Added tag jdk8-b98 for changeset 0d0c983a817b ! .hgtags From lana.steuck at oracle.com Wed Jul 17 12:01:57 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 17 Jul 2013 19:01:57 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20130717190203.3C39348165@hg.openjdk.java.net> Changeset: 10a1ab9e20a4 Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/10a1ab9e20a4 Added tag jdk8-b98 for changeset 542b7803f038 ! .hgtags Changeset: 81cbb18d558a Author: lana Date: 2013-07-17 00:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/81cbb18d558a Merge From lana.steuck at oracle.com Wed Jul 17 12:02:09 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 17 Jul 2013 19:02:09 +0000 Subject: hg: jdk8/tl/jdk: 5 new changesets Message-ID: <20130717190344.40F0348169@hg.openjdk.java.net> Changeset: 2c26ccf0a85b Author: tbell Date: 2013-07-08 07:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c26ccf0a85b 8012925: [parfait] Missing return value in jdk/src/macosx/native/sun/awt/AWTEvent.m Reviewed-by: katleman, leonidr Contributed-by: petr.pchelko at oracle.com ! src/macosx/native/sun/awt/AWTEvent.m Changeset: c4908732fef5 Author: katleman Date: 2013-07-08 14:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4908732fef5 Merge Changeset: 758c21301545 Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/758c21301545 Added tag jdk8-b98 for changeset c4908732fef5 ! .hgtags Changeset: f83794805201 Author: mcimadamore Date: 2013-07-11 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f83794805201 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle 8020010: Move lambda bridge creation from metafactory and VM to compiler Summary: JDK/metafactory component of the bridge fix and and MethodType vs. MethodHandle changes. Reviewed-by: twisti, briangoetz, forax Contributed-by: robert.field at oracle.com ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/share/classes/java/lang/invoke/LambdaMetafactory.java ! src/share/classes/java/lang/invoke/SerializedLambda.java Changeset: cbdd2529d93a Author: lana Date: 2013-07-17 00:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cbdd2529d93a Merge From lana.steuck at oracle.com Wed Jul 17 12:01:54 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 17 Jul 2013 19:01:54 +0000 Subject: hg: jdk8/tl/corba: Added tag jdk8-b98 for changeset 3370fb6146e4 Message-ID: <20130717190158.9338448164@hg.openjdk.java.net> Changeset: 3f67804ab613 Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/3f67804ab613 Added tag jdk8-b98 for changeset 3370fb6146e4 ! .hgtags From lana.steuck at oracle.com Wed Jul 17 12:02:06 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 17 Jul 2013 19:02:06 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20130717190220.0D7F948168@hg.openjdk.java.net> Changeset: bdeef606be8e Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bdeef606be8e Added tag jdk8-b98 for changeset ce5a90df517b ! .hgtags Changeset: 39ec5d8a691b Author: mcimadamore Date: 2013-07-11 14:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/39ec5d8a691b 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle 8020010: Move lambda bridge creation from metafactory and VM to compiler Summary: langtools/javac component of the bridge support and MethodType vs. MethodHandle changes. Reviewed-by: jjg, vromero, briangoetz, forax Contributed-by: robert.field at oracle.com ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/util/Names.java + test/tools/javac/generics/bridges/Bridge.java + test/tools/javac/generics/bridges/BridgeHarness.java + test/tools/javac/generics/bridges/Bridges.java + test/tools/javac/generics/bridges/tests/TestBridgeWithDefault.java + test/tools/javac/generics/bridges/tests/TestClassAndInterfaceBridgeIdentical01.java + test/tools/javac/generics/bridges/tests/TestClassAndInterfaceBridgeIdentical02.java + test/tools/javac/generics/bridges/tests/TestNoBridgeInSiblingsSuper.java + test/tools/javac/generics/bridges/tests/TestNoDuplicateBridges01.java + test/tools/javac/generics/bridges/tests/TestNoDuplicateBridges02.java + test/tools/javac/lambda/bridge/TestMetafactoryBridges.java ! test/tools/javac/lambda/lambdaExpression/LambdaTest6.java ! test/tools/javac/lambda/methodReference/BridgeMethod.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java Changeset: e990e6bcecbe Author: lana Date: 2013-07-17 10:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e990e6bcecbe Merge ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java From lana.steuck at oracle.com Wed Jul 17 12:02:29 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 17 Jul 2013 19:02:29 +0000 Subject: hg: jdk8/tl/hotspot: 69 new changesets Message-ID: <20130717190504.8CA854816A@hg.openjdk.java.net> Changeset: 8c4424890028 Author: amurillo Date: 2013-06-28 02:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8c4424890028 8019302: new hotspot build - hs25-b40 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8cff1de240de Author: zgu Date: 2013-06-25 17:22 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8cff1de240de 8017478: Kitchensink crashed with SIGSEGV in BaselineReporter::diff_callsites Summary: Fixed possible NULL pointer that caused SIGSEGV Reviewed-by: coleenp, acorn, ctornqvi ! src/share/vm/services/memReporter.cpp Changeset: c14867f95c60 Author: zgu Date: 2013-06-25 14:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c14867f95c60 Merge Changeset: 38ea2efa32a7 Author: kevinw Date: 2013-06-26 00:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/38ea2efa32a7 8010278: SA: provide mechanism for using an alternative SA debugger back-end. Reviewed-by: sla, dsamersoff ! agent/src/share/classes/sun/jvm/hotspot/CLHSDB.java ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/HSDB.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxOopHandle.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/tools/ClassLoaderStats.java ! agent/src/share/classes/sun/jvm/hotspot/tools/FinalizerInfo.java ! agent/src/share/classes/sun/jvm/hotspot/tools/FlagDumper.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapDumper.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JInfo.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JMap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JSnap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JStack.java ! agent/src/share/classes/sun/jvm/hotspot/tools/ObjectHistogram.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java ! agent/src/share/classes/sun/jvm/hotspot/tools/StackTrace.java ! agent/src/share/classes/sun/jvm/hotspot/tools/SysPropsDumper.java ! agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java ! agent/src/share/classes/sun/jvm/hotspot/tools/soql/JSDB.java ! agent/src/share/classes/sun/jvm/hotspot/tools/soql/SOQL.java Changeset: 8eb40545e209 Author: kevinw Date: 2013-06-26 11:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8eb40545e209 Merge Changeset: 221df7e37535 Author: iklam Date: 2013-06-27 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/221df7e37535 8016075: Win32 crash with CDS enabled and small heap size Summary: Fixed MetaspaceShared::is_in_shared_space Reviewed-by: coleenp, hseigel ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/filemap.hpp ! src/share/vm/memory/metaspaceShared.cpp Changeset: e0fe0c9a88da Author: nloodin Date: 2013-06-28 14:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e0fe0c9a88da Merge Changeset: bb4f2b27e824 Author: dcubed Date: 2013-06-29 11:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bb4f2b27e824 Merge Changeset: 97c5acae48be Author: hseigel Date: 2013-06-30 09:59 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/97c5acae48be 7007040: Check of capacity paramenters in JNI_PushLocalFrame is wrong Summary: changed AND to OR Reviewed-by: coleenp, hseigel Contributed-by: lois.foltan at oracle.com ! src/share/vm/prims/jni.cpp Changeset: 068b406e307f Author: fparain Date: 2013-07-01 09:13 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/068b406e307f 7060111: race condition in VMError::report_and_die() Reviewed-by: zgu, coleenp Contributed-by: volker.simonis at gmail.com ! src/share/vm/utilities/vmError.cpp ! src/share/vm/utilities/vmError.hpp Changeset: acfa2cc19146 Author: rbackman Date: 2013-06-12 09:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/acfa2cc19146 8016444: Duplicate zombie check in safe_for_sender Reviewed-by: dholmes, sla ! src/cpu/sparc/vm/frame_sparc.cpp ! src/share/vm/memory/referenceProcessorStats.hpp Changeset: 993dfb57c575 Author: egahlin Date: 2013-06-26 17:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/993dfb57c575 8016331: Minor issues in event tracing metadata Reviewed-by: stefank, brutisso, mgronlun ! src/share/vm/trace/trace.xml Changeset: 7f11c12d7a90 Author: sspitsyn Date: 2013-07-01 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7f11c12d7a90 8009204: [dtrace] signatures returned by Java 7 jstack() are corrupted on Solaris Summary: The fix is basically a backport of JDK-7019165 (pstack issue) to jhelper.d. Reviewed-by: coleenp, sspitsyn Contributed-by: tomas.hurka at oracle.com ! src/os/solaris/dtrace/jhelper.d Changeset: de2d15ce3d4a Author: coleenp Date: 2013-07-02 08:42 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/de2d15ce3d4a 8015391: NPG: With -XX:+UseCompressedKlassPointers OOME due to exhausted metadata space could occur when metaspace is almost empty Summary: Allocate medium chunks for class metaspace when class loader has lots of classes Reviewed-by: mgerdin, jmasa ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: cedf20e2a655 Author: coleenp Date: 2013-07-02 16:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cedf20e2a655 Merge - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: c92b74c62d97 Author: brutisso Date: 2013-06-27 09:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c92b74c62d97 8017483: G1 tests fail with native OOME on Solaris x86 after HeapBaseMinAddress has been increased Summary: Set HeapBaseMinAddress as default rather than ergo Reviewed-by: stefank, jmasa, kvn ! src/share/vm/runtime/arguments.cpp Changeset: 3ea89789ba39 Author: ehelin Date: 2013-06-28 18:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3ea89789ba39 Merge Changeset: b30744960351 Author: brutisso Date: 2013-06-30 21:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b30744960351 8014022: G1: Non Java threads should lock the shared SATB queue lock without safepoint checks. Reviewed-by: tschatzl, brutisso, jmasa, ysr Contributed-by: per.liden at oracle.com ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp Changeset: 5ea20b3bd249 Author: johnc Date: 2013-07-01 09:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5ea20b3bd249 8017070: G1: assert(_card_counts[card_num] <= G1ConcRSHotCardLimit) failed Summary: The assert is invalid when a card is being refined by two different threads and its count crosses the hot threshold - the refinement count will be updated once by each thread triggering the assert. Remove the assert and update the count using a bounded expression. Reviewed-by: jmasa, tamao, brutisso ! src/share/vm/gc_implementation/g1/g1CardCounts.cpp Changeset: 6e3634222155 Author: tamao Date: 2013-06-28 20:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6e3634222155 8017611: Auto corrector for mistyped vm options Summary: The auto corrector for mistyped vm options fuzzy-matches existing flags based on string similarity (Dice's coefficient). Reviewed-by: kvn, dsamersoff, hseigel, johnc ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp + test/gc/arguments/TestUnrecognizedVMOptionsHandling.java Changeset: 536976a22f5f Author: tamao Date: 2013-07-03 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/536976a22f5f Merge Changeset: 70bea4a43c6d Author: tamao Date: 2013-07-03 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/70bea4a43c6d Merge Changeset: ac7193063af8 Author: jiangli Date: 2013-07-01 19:44 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ac7193063af8 8006023: Embedded Builds fail management test because of requirement for UsePerfData being enabled. Summary: Added -XX:+UsePerfData to Test7196045.java. Reviewed-by: dholmes, collins ! test/runtime/7196045/Test7196045.java Changeset: 94aa8de029c5 Author: clucasius Date: 2013-07-03 22:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/94aa8de029c5 Merge Changeset: fea6a49c2762 Author: bdelsart Date: 2013-07-04 01:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fea6a49c2762 Merge Changeset: f765bfec8f07 Author: kvn Date: 2013-07-01 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f765bfec8f07 8006629: NEED_TEST: need test for JDK-8001071 Summary: added regression test Reviewed-by: kvn, coleenp Contributed-by: Filipp Zhinkin + test/runtime/8001071/Test8001071.java + test/runtime/8001071/Test8001071.sh Changeset: a023ec3452c7 Author: simonis Date: 2013-07-01 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a023ec3452c7 8019382: PPC64: Fix bytecodeInterpreter to compile with '-Wunused-value' Summary: cast the offending expressions to (void) Reviewed-by: kvn, coleenp ! src/share/vm/interpreter/bytecodeInterpreter.cpp Changeset: 2b3fe74309b6 Author: kvn Date: 2013-07-02 10:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2b3fe74309b6 8019247: SIGSEGV in compiled method c8e.e.t_.getArray(Ljava/lang/Class;)[Ljava/lang/Object Summary: Undo recent changes (and add more comments) in Ideal_allocation(). Reviewed-by: roland ! src/share/vm/opto/graphKit.cpp Changeset: 738e04fb1232 Author: anoll Date: 2013-07-02 07:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/738e04fb1232 8014972: Crash with specific values for -XX:InitialCodeCacheSize=500K -XX:ReservedCodeCacheSize=500k Summary: Introduce a minimum code cache size that guarantees that the VM can startup. Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/c1_globals_sparc.hpp ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/x86/vm/c1_globals_x86.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp ! src/cpu/zero/vm/shark_globals_zero.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: b800986664f4 Author: drchase Date: 2013-07-02 20:42 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b800986664f4 7088419: Use x86 Hardware CRC32 Instruction with java.util.zip.CRC32 Summary: add intrinsics using new instruction to interpreter, C1, C2, for suitable x86; add test Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/x86/vm/interpreterGenerator_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp + src/cpu/x86/vm/stubRoutines_x86.cpp + src/cpu/x86/vm/stubRoutines_x86.hpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp + test/compiler/7088419/CRCTest.java Changeset: c1bd7b5bdc70 Author: twisti Date: 2013-07-02 20:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c1bd7b5bdc70 8017571: JSR292: JVM crashing on assert "cast to instanceKlass" while producing MethodHandle for array methods with MethodHandle.findVirtual Reviewed-by: kvn ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/reflection.cpp Changeset: bed0eddd82cd Author: twisti Date: 2013-07-02 22:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bed0eddd82cd Merge Changeset: 8b789ce47503 Author: roland Date: 2013-07-04 01:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8b789ce47503 Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: fece0ee013fc Author: roland Date: 2013-07-04 03:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fece0ee013fc Merge Changeset: c9dd82da51ed Author: amurillo Date: 2013-07-04 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c9dd82da51ed Merge Changeset: 30b5b75c42ac Author: amurillo Date: 2013-07-04 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/30b5b75c42ac Added tag hs25-b40 for changeset c9dd82da51ed ! .hgtags Changeset: 1a3390aa8326 Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1a3390aa8326 Added tag jdk8-b98 for changeset 30b5b75c42ac ! .hgtags Changeset: ea4d24c1e0c6 Author: amurillo Date: 2013-07-04 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ea4d24c1e0c6 8019934: new hotspot build - hs25-b41 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f323bbb0e6c1 Author: coleenp Date: 2013-07-03 13:45 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f323bbb0e6c1 8019833: Wrong JNI error code for preexisting JVM Summary: Return the appropriate JNI error message (instead of the generic one) when the JVM is already started Reviewed-by: coleenp, hseigel Contributed-by: sylvestre at debian.org ! src/share/vm/prims/jni.cpp Changeset: 5f7a4367c787 Author: zgu Date: 2013-07-04 06:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5f7a4367c787 8016074: NMT: assertion failed: assert(thread->thread_state() == from) failed: coming from wrong thread state Summary: Uses os::NakedYield() on Solaris instead of os::yield_all() Reviewed-by: acorn, coleenp, hseigel ! src/share/vm/services/memTracker.hpp Changeset: a55aa67bce1a Author: zgu Date: 2013-07-04 04:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a55aa67bce1a Merge Changeset: 59b052799158 Author: dcubed Date: 2013-07-04 21:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/59b052799158 8015884: runThese crashed with SIGSEGV, hs_err has an error instead of stacktrace Summary: Dl_info struct should only be used if dladdr() has returned non-zero (no errors) and always check the dladdr() return value; Dl_info.dli_sname and Dl_info.dli_saddr fields should only be used if non-NULL; update/improve runtime/6888954/vmerrors.sh test Reviewed-by: dsamersoff, zgu, hseigel, coleenp ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/os/windows/vm/os_windows.inline.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/debug.hpp ! test/runtime/6888954/vmerrors.sh Changeset: 93e6dce53ba7 Author: fparain Date: 2013-07-05 08:26 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/93e6dce53ba7 8016465: The hs_err file gets wrong name Reviewed-by: dcubed, dholmes, rdurbin ! src/share/vm/utilities/vmError.cpp Changeset: cc5b7915104e Author: fparain Date: 2013-07-05 08:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cc5b7915104e Merge Changeset: cf9d71d3e474 Author: iklam Date: 2013-07-08 10:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cf9d71d3e474 8016903: Thread::_handle_area initial size too big Summary: Changed initial size to Chunk::tiny_size (216 bytes) Reviewed-by: coleenp, dholmes, sspitsyn ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/runtime/handles.hpp Changeset: 71180a6e5080 Author: jiangli Date: 2013-07-03 17:26 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/71180a6e5080 7133260: AllocationProfiler uses space in metadata and doesn't seem to do anything useful. Summary: Remove -Xaprof and Klass::_alloc_count & ArrayKlass::_alloc_size. Reviewed-by: stefank, coleenp ! agent/src/share/classes/sun/jvm/hotspot/oops/ArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Klass.java ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/generation.cpp ! src/share/vm/memory/generation.hpp ! src/share/vm/memory/sharedHeap.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/arrayKlass.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fa6929d0b0a9 Author: jiangli Date: 2013-07-08 14:21 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fa6929d0b0a9 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 3c7b4b7b2625 Author: jiangli Date: 2013-07-08 14:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c7b4b7b2625 Merge - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp Changeset: ba9dacff9c9d Author: hseigel Date: 2013-07-08 19:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ba9dacff9c9d 8014399: Remove JVM_SetProtectionDomain from hotspot Summary: JVM_SetProtectionDomain has been deprecated since 1.5 and is being removed Reviewed-by: coleenp, hseigel Contributed-by: eric.mccorkle at oracle.com ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h Changeset: 26037663c2a6 Author: hseigel Date: 2013-07-08 16:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/26037663c2a6 Merge Changeset: e79a9f26ba2e Author: hseigel Date: 2013-07-08 18:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e79a9f26ba2e Merge Changeset: 72fce0b2d341 Author: zgu Date: 2013-07-09 13:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/72fce0b2d341 8011760: assert(delta != 0) failed: dup pointer in MemBaseline::malloc_sort_by_addr Summary: Some of qsort implementation on Linux x86 compares element to itself, which is mistakenly treated as duplicate pointer Reviewed-by: dcubed, acorn ! src/share/vm/services/memBaseline.cpp Changeset: 2839ce15e450 Author: zgu Date: 2013-07-09 19:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2839ce15e450 Merge - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp Changeset: 50257d6f5aaa Author: acorn Date: 2013-07-09 14:02 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/50257d6f5aaa 8013635: VM should no longer create bridges for generic signatures. Summary: Requires: 8013789: Compiler bridges, 8015402: metafactory Reviewed-by: sspitsyn, coleenp, bharadwaj ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/runtime/globals.hpp Changeset: 22baec423e2f Author: acorn Date: 2013-07-09 22:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/22baec423e2f Merge Changeset: e50be1620201 Author: goetz Date: 2013-07-08 14:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e50be1620201 8020059: The flag introduced by 8014972 is not defined if Hotspot is built without a compiler (zero, ppc64 core build). Summary: define CodeCacheMinimumUseSpace flag for cppInterpeter build. Reviewed-by: kvn ! src/share/vm/runtime/globals.hpp Changeset: e554162ab094 Author: adlertz Date: 2013-07-09 17:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e554162ab094 8019625: Test compiler/8005956/PolynomialRoot.java timeouts on Solaris SPARCs Summary: Disable the test for SPARC and reduce the number of test iterations Reviewed-by: kvn ! test/compiler/8005956/PolynomialRoot.java Changeset: b42fe1a8e180 Author: drchase Date: 2013-07-09 08:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b42fe1a8e180 8017578: Hotspot compilation error with latest Studio compiler Summary: Make the destructor virtual (note more non-compiler hotspot errors occur downstream) Reviewed-by: kvn, twisti ! src/share/vm/adlc/forms.hpp Changeset: 7ac80525ece9 Author: anoll Date: 2013-07-09 11:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7ac80525ece9 8015635: Crash when specifying very large code cache size Summary: Limit the size of the code cache to at most 2G when arguments are checked; added regression test Reviewed-by: kvn, twisti ! src/share/vm/runtime/arguments.cpp + test/compiler/codecache/CheckUpperLimit.java Changeset: 5f533e38e7d5 Author: twisti Date: 2013-07-09 22:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5f533e38e7d5 Merge Changeset: dec841e0c9aa Author: anoll Date: 2013-07-10 13:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dec841e0c9aa 8016749: -XX:+UseISM fails an assert(obj->is_oop()) when running SPECjbb2005 Summary: Remove obsolete code that relates to ISM which was used only on Solaris 8. Reviewed-by: kvn, twisti ! src/os/solaris/vm/globals_solaris.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/share/vm/runtime/arguments.cpp Changeset: ec173c8f3739 Author: roland Date: 2013-07-11 01:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ec173c8f3739 Merge ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 2cbc8f3011a0 Author: ehelin Date: 2013-06-05 09:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2cbc8f3011a0 8015972: Refactor the sending of the object count after GC event Reviewed-by: brutisso, pliden ! src/share/vm/gc_implementation/shared/gcTrace.cpp ! src/share/vm/gc_implementation/shared/gcTrace.hpp ! src/share/vm/gc_implementation/shared/gcTraceSend.cpp + src/share/vm/gc_implementation/shared/objectCountEventSender.cpp + src/share/vm/gc_implementation/shared/objectCountEventSender.hpp ! src/share/vm/memory/heapInspection.hpp - src/share/vm/memory/klassInfoClosure.hpp Changeset: 63cffb381adc Author: ehelin Date: 2013-06-12 15:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/63cffb381adc 8016170: GC id variable in gcTrace.cpp should use typedef GCId Reviewed-by: johnc, jwilhelm, jmasa ! src/share/vm/gc_implementation/shared/gcTrace.cpp Changeset: 6aa440bc1125 Author: ehelin Date: 2013-06-12 15:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6aa440bc1125 8015683: object_count_after_gc should have the same timestamp for all events Reviewed-by: mgerdin, stefank ! src/share/vm/gc_implementation/shared/gcTrace.cpp ! src/share/vm/gc_implementation/shared/objectCountEventSender.cpp ! src/share/vm/gc_implementation/shared/objectCountEventSender.hpp Changeset: 27c53c9f3a7e Author: ehelin Date: 2013-07-10 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/27c53c9f3a7e 8013939: Metaspace capacity not available Reviewed-by: tschatzl, mgerdin, stefank ! src/share/vm/gc_interface/collectedHeap.cpp Changeset: 0f631140d13b Author: tamao Date: 2013-07-11 11:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0f631140d13b Merge - src/share/vm/memory/klassInfoClosure.hpp Changeset: 2b9946e10587 Author: amurillo Date: 2013-07-12 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2b9946e10587 Merge - src/share/vm/memory/klassInfoClosure.hpp - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp Changeset: ea979302bb70 Author: amurillo Date: 2013-07-12 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ea979302bb70 Added tag hs25-b41 for changeset 2b9946e10587 ! .hgtags From lana.steuck at oracle.com Wed Jul 17 12:02:00 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 17 Jul 2013 19:02:00 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20130717190211.4493348167@hg.openjdk.java.net> Changeset: adf49c3ef83c Author: katleman Date: 2013-07-11 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/adf49c3ef83c Added tag jdk8-b98 for changeset 15e5bb51bc0c ! .hgtags Changeset: 74ec7b48e3be Author: lana Date: 2013-07-17 00:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/74ec7b48e3be Merge From anthony.scarpino at oracle.com Wed Jul 17 13:51:28 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Wed, 17 Jul 2013 13:51:28 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51DEEF8C.4010604@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> Message-ID: <51E703D0.4090505@oracle.com> I have broken these into two webrev. The first: JDK-8012971 PKCS11Test hiding exception failures http://cr.openjdk.java.net/~ascarpino/8012971/webrev.01/ handles the minimum changes needed for PKCS11Test to function and the Problemlist updated to reflect the failures that would show up. The second, are the test changes that fix the problems uncovered by the above change: JDK-8020424 The NSS version should be detected before running crypto tests http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ Tony From jonathan.gibbons at oracle.com Wed Jul 17 18:19:24 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 18 Jul 2013 01:19:24 +0000 Subject: hg: jdk8/tl/langtools: 8014636: TestLiteralCodeInPre fails on windows Message-ID: <20130718011931.069B048183@hg.openjdk.java.net> Changeset: 80e75aa6a707 Author: jjg Date: 2013-07-17 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/80e75aa6a707 8014636: TestLiteralCodeInPre fails on windows Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! test/com/sun/javadoc/testCRLineSeparator/TestCRLineSeparator.java ! test/com/sun/javadoc/testLeadingSpaces/LeadingSpaces.java ! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java ! test/com/sun/javadoc/testLiteralCodeInPre/TestLiteralCodeInPre.java ! test/com/sun/javadoc/testRelativeLinks/TestRelativeLinks.java From jonathan.gibbons at oracle.com Wed Jul 17 19:16:35 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 18 Jul 2013 02:16:35 +0000 Subject: hg: jdk8/tl/langtools: 8020664: doclint gives incorrect warnings on normal package statements Message-ID: <20130718021638.82C1748189@hg.openjdk.java.net> Changeset: 1476d54fdc61 Author: jjg Date: 2013-07-17 19:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1476d54fdc61 8020664: doclint gives incorrect warnings on normal package statements Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! test/tools/doclint/BadPackageCommentTest.out ! test/tools/doclint/DocLintTester.java + test/tools/doclint/packageTests/bad/Test.java + test/tools/doclint/packageTests/bad/Test.out + test/tools/doclint/packageTests/bad/package-info.java + test/tools/doclint/packageTests/bad/package-info.out + test/tools/doclint/packageTests/good/Test.java + test/tools/doclint/packageTests/good/package-info.java From jonathan.gibbons at oracle.com Wed Jul 17 19:12:28 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 18 Jul 2013 02:12:28 +0000 Subject: hg: jdk8/tl/langtools: 8020313: doclint doesn't reset HTML anchors correctly Message-ID: <20130718021233.D097348187@hg.openjdk.java.net> Changeset: 1e533c1bfb01 Author: jjg Date: 2013-07-17 19:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e533c1bfb01 8020313: doclint doesn't reset HTML anchors correctly Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/Checker.java + test/tools/doclint/AnchorTest2.java + test/tools/doclint/AnchorTest2.out + test/tools/doclint/AnchorTest2a.java From chris.hegarty at oracle.com Thu Jul 18 02:48:58 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 18 Jul 2013 10:48:58 +0100 Subject: Fwd: Re: TLS and Pre-shared Keys In-Reply-To: <20130717195259.GA24976@mhcomputing.net> References: <20130717195259.GA24976@mhcomputing.net> Message-ID: <51E7BA0A.2030601@oracle.com> Forward to security-dev. -------- Original Message -------- Subject: Re: TLS and Pre-shared Keys Date: Wed, 17 Jul 2013 12:52:59 -0700 From: Matthew Hall To: roger riggs CC: net-dev at openjdk.java.net On Wed, Jul 17, 2013 at 03:45:19PM -0400, roger riggs wrote: > Hi, > > Is there support in SSLEngine/TLS to support Pre-Shared Keys? > I have been looking for relevant doc and have not stumbled upon it. > > Thanks, Roger No, there isn't any support for PSK Ciphers yet, although some of the constants for them appear in grep output. It would be really nice if it were supported for deploying new cluster nodes in distributed systems, etc. Matthew. From jason.uh at oracle.com Thu Jul 18 10:50:03 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Thu, 18 Jul 2013 17:50:03 +0000 Subject: hg: jdk8/tl/jdk: 8020426: Fix doclint accessibility issues in java.io Message-ID: <20130718175031.52C09481C6@hg.openjdk.java.net> Changeset: 6e10d93273d0 Author: juh Date: 2013-07-18 10:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6e10d93273d0 8020426: Fix doclint accessibility issues in java.io Reviewed-by: mduigou, darcy, chegar ! src/share/classes/java/io/DataInput.java ! src/share/classes/java/io/File.java ! src/share/classes/java/io/ObjectStreamField.java ! src/share/classes/java/io/RandomAccessFile.java From xueming.shen at oracle.com Thu Jul 18 11:01:30 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 18 Jul 2013 18:01:30 +0000 Subject: hg: jdk8/tl/jdk: 8016025: JSR 310 DateTime API Updates IV; ... Message-ID: <20130718180152.D2595481CE@hg.openjdk.java.net> Changeset: b39797bb86c0 Author: sherman Date: 2013-07-18 11:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b39797bb86c0 8016025: JSR 310 DateTime API Updates IV 8020418: Cleanup of -Xlint warnings in java.time 8016623: test/java/time/format/TestDateTimeTextProvider.java failing Summary: Integration of JSR310 Date/Time API update IV Reviewed-by: sherman Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, masayoshi.okutsu at oracle.com, patrick.zhang at oracle.com, chand.basha at oracle.com ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/HijrahChronology.java ! src/share/classes/java/time/chrono/HijrahDate.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/JapaneseChronology.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/chrono/JapaneseEra.java ! src/share/classes/java/time/chrono/MinguoChronology.java ! src/share/classes/java/time/chrono/MinguoDate.java ! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java ! src/share/classes/java/time/chrono/ThaiBuddhistDate.java ! src/share/classes/java/time/chrono/package-info.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/Parsed.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/lib/hijrah-config-umalqura.properties ! test/java/time/tck/java/time/MockSimplePeriod.java ! test/java/time/tck/java/time/TCKClock_Fixed.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKPeriod.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneId.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/chrono/CopticDate.java ! test/java/time/tck/java/time/chrono/TCKChronoLocalDate.java ! test/java/time/tck/java/time/chrono/TCKChronoLocalDateTime.java ! test/java/time/tck/java/time/chrono/TCKChronoZonedDateTime.java ! test/java/time/tck/java/time/chrono/TCKChronology.java ! test/java/time/tck/java/time/chrono/TCKHijrahChronology.java ! test/java/time/tck/java/time/chrono/TCKHijrahEra.java ! test/java/time/tck/java/time/chrono/TCKIsoChronology.java ! test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java ! test/java/time/tck/java/time/chrono/TCKJapaneseEra.java ! test/java/time/tck/java/time/chrono/TCKMinguoChronology.java ! test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java + test/java/time/tck/java/time/format/TCKFormatStyle.java + test/java/time/tck/java/time/format/TCKResolverStyle.java + test/java/time/tck/java/time/format/TCKSignStyle.java ! test/java/time/tck/java/time/format/TCKTextStyle.java ! test/java/time/tck/java/time/format/TCKZoneIdPrinterParser.java + test/java/time/tck/java/time/temporal/TCKChronoField.java + test/java/time/tck/java/time/temporal/TCKChronoUnit.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java ! test/java/time/tck/java/time/zone/TCKZoneRules.java ! test/java/time/test/java/time/MockSimplePeriod.java ! test/java/time/test/java/time/chrono/TestChronoLocalDate.java ! test/java/time/test/java/time/chrono/TestExampleCode.java ! test/java/time/test/java/time/chrono/TestJapaneseChronoImpl.java ! test/java/time/test/java/time/chrono/TestJapaneseChronology.java ! test/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java ! test/java/time/test/java/time/format/TestDateTimeTextProvider.java ! test/java/time/test/java/time/format/TestNonIsoFormatter.java ! test/java/time/test/java/time/format/TestNumberPrinter.java ! test/java/time/test/java/time/format/TestReducedPrinter.java ! test/java/time/test/java/time/temporal/MockFieldNoValue.java ! test/java/time/test/java/time/temporal/MockFieldValue.java From vincent.x.ryan at oracle.com Thu Jul 18 11:43:36 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 18 Jul 2013 19:43:36 +0100 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51E703D0.4090505@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> <51E703D0.4090505@oracle.com> Message-ID: <76933DAB-30E8-4E9A-A9F6-05FD2B7AD1BA@oracle.com> The first one looks fine. I haven't finished reviewing the second one yet. On 17 Jul 2013, at 21:51, Anthony Scarpino wrote: > I have broken these into two webrev. The first: > > JDK-8012971 PKCS11Test hiding exception failures > http://cr.openjdk.java.net/~ascarpino/8012971/webrev.01/ > > handles the minimum changes needed for PKCS11Test to function and the Problemlist updated to reflect the failures that would show up. > > > The second, are the test changes that fix the problems uncovered by the above change: > > JDK-8020424 The NSS version should be detected before running crypto tests > http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ > > Tony > From valerie.peng at oracle.com Thu Jul 18 14:49:48 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Thu, 18 Jul 2013 14:49:48 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51E703D0.4090505@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> <51E703D0.4090505@oracle.com> Message-ID: <51E862FC.5060807@oracle.com> Please find comments inline. On 07/17/13 13:51, Anthony Scarpino wrote: > I have broken these into two webrev. The first: > > JDK-8012971 PKCS11Test hiding exception failures > http://cr.openjdk.java.net/~ascarpino/8012971/webrev.01/ > > handles the minimum changes needed for PKCS11Test to function and the > Problemlist updated to reflect the failures that would show up. Looks fine in general, I only have some nit comments, and questions since I have not touched NSS much. PKCS11Test.java 1) line 88, change "this finally block" to "any finally block" 2) line 192, add space before and after the "+" for consistency with the rest of the source, e.g. line 213. 3) The comments from line 58-60 say the default value is "nss3" but the default value set on line 61 is "softokn3". Seems conflicting? 4) Is "nss3" only used for Secmod? It seems that everywhere else you use the "softokn3" value. If yes, perhaps using "setSecmod()" would be clearer than "useNSS()". Will look at 8020424 later today. Thanks, Valerie > > > The second, are the test changes that fix the problems uncovered by > the above change: > > JDK-8020424 The NSS version should be detected before running crypto > tests > http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ > > Tony > From anthony.scarpino at oracle.com Thu Jul 18 15:17:04 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Thu, 18 Jul 2013 15:17:04 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51E862FC.5060807@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> <51E703D0.4090505@oracle.com> <51E862FC.5060807@oracle.com> Message-ID: <51E86960.10707@oracle.com> On 07/18/2013 02:49 PM, Valerie (Yu-Ching) Peng wrote: > > Please find comments inline. > > On 07/17/13 13:51, Anthony Scarpino wrote: >> I have broken these into two webrev. The first: >> >> JDK-8012971 PKCS11Test hiding exception failures >> http://cr.openjdk.java.net/~ascarpino/8012971/webrev.01/ >> >> handles the minimum changes needed for PKCS11Test to function and the >> Problemlist updated to reflect the failures that would show up. > Looks fine in general, I only have some nit comments, and questions > since I have not touched NSS much. > PKCS11Test.java > 1) line 88, change "this finally block" to "any finally block" yep > 2) line 192, add space before and after the "+" for consistency with the > rest of the source, e.g. line 213. yep > 3) The comments from line 58-60 say the default value is "nss3" but the > default value set on line 61 is "softokn3". Seems conflicting? yep. it nss3 use to be the default, must have forgot the change the comment > 4) Is "nss3" only used for Secmod? It seems that everywhere else you use > the "softokn3" value. If yes, perhaps using "setSecmod()" would be > clearer than "useNSS()". Secmod is the only one currently, but I would rather leave it as NSS because I named it for the library it's looking for. If another test comes around that is not a Secmod test, then setSecmod() doesn't seem logical. webrev is updated in place. > > Will look at 8020424 later today. > Thanks, > Valerie >> >> >> The second, are the test changes that fix the problems uncovered by >> the above change: >> >> JDK-8020424 The NSS version should be detected before running crypto >> tests >> http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ >> >> Tony >> > From valerie.peng at oracle.com Thu Jul 18 15:40:25 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Thu, 18 Jul 2013 15:40:25 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51E86960.10707@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> <51E703D0.4090505@oracle.com> <51E862FC.5060807@oracle.com> <51E86960.10707@oracle.com> Message-ID: <51E86ED9.7040403@oracle.com> Just noticed that the newly-added import statement on line 32 seems redundant? Webrev seems the same? Thanks, Valerie On 07/18/13 15:17, Anthony Scarpino wrote: > On 07/18/2013 02:49 PM, Valerie (Yu-Ching) Peng wrote: >> >> Please find comments inline. >> >> On 07/17/13 13:51, Anthony Scarpino wrote: >>> I have broken these into two webrev. The first: >>> >>> JDK-8012971 PKCS11Test hiding exception failures >>> http://cr.openjdk.java.net/~ascarpino/8012971/webrev.01/ >>> >>> handles the minimum changes needed for PKCS11Test to function and the >>> Problemlist updated to reflect the failures that would show up. >> Looks fine in general, I only have some nit comments, and questions >> since I have not touched NSS much. >> PKCS11Test.java >> 1) line 88, change "this finally block" to "any finally block" > yep > >> 2) line 192, add space before and after the "+" for consistency with the >> rest of the source, e.g. line 213. > yep > >> 3) The comments from line 58-60 say the default value is "nss3" but the >> default value set on line 61 is "softokn3". Seems conflicting? > > yep. it nss3 use to be the default, must have forgot the change the > comment > >> 4) Is "nss3" only used for Secmod? It seems that everywhere else you use >> the "softokn3" value. If yes, perhaps using "setSecmod()" would be >> clearer than "useNSS()". > > Secmod is the only one currently, but I would rather leave it as NSS > because I named it for the library it's looking for. If another test > comes around that is not a Secmod test, then setSecmod() doesn't seem > logical. > > webrev is updated in place. > >> >> Will look at 8020424 later today. >> Thanks, >> Valerie >>> >>> >>> The second, are the test changes that fix the problems uncovered by >>> the above change: >>> >>> JDK-8020424 The NSS version should be detected before running crypto >>> tests >>> http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ >>> >>> Tony >>> >> > From joe.darcy at oracle.com Thu Jul 18 23:17:08 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 19 Jul 2013 06:17:08 +0000 Subject: hg: jdk8/tl/jdk: 8020810: Typo in javadoc for Class.toGenericString() Message-ID: <20130719061730.5701448202@hg.openjdk.java.net> Changeset: 2323b973adaa Author: darcy Date: 2013-07-18 23:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2323b973adaa 8020810: Typo in javadoc for Class.toGenericString() Reviewed-by: dholmes ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Parameter.java From weijun.wang at oracle.com Thu Jul 18 23:48:17 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 19 Jul 2013 14:48:17 +0800 Subject: [kitten] Suggested update to RFC 5653 JGSS-API: Provide a way to return a token when context establishment fails In-Reply-To: References: Message-ID: <51E8E131.3050105@oracle.com> Hi Mayank On 7/19/2013 1:37 PM, Mayank Upadhyay wrote: > (My apologies for resending, but with the right subject this time.) > > Hi Weijun, > > You point out a legitimate problem, but I want to understand a couple of > assumptions: > > 1. Why allow only initSecContext() and acceptSecContext() to have this > new behavior? Imagine a mechanism built on top of TLS which is > renegotiating the session intermixed with actual payload, and had > some error it wanted to communicate to the peer (e.g., a TLS Alert). > Is there any particular reason you'd like to avoid that scenario? No, there isn't. I just haven't expected any usage outside these 2 methods. In the final spec, I think I would write something like "If the underlying mechanism defines any error token to be sent to the peer, ....". > > 2. I didn't quite follow the comment about the default method (maybe it > shows that my Java is dated :). GSSException is not an interface but > a concrete class, and adding a method to it adds it in the JRE > starting at some particular version. What happens when applications > that call the new method are run on an older JRE? Oh, I was wrong. I thought everything in JGSS is an interface. We can just add the method there. If someone call the new method on an older JRE, a NoSuchMethodException is thrown. I had thought about creating a new ExtendedGSSException, but I really don't want to create ExtendedExtendedGSSException one day. > > 3. Don't we also need to set this token when the mechanism creates a > GSSException instance? Note that the concrete class has no setter > methods of any kind at this time, but two constructors. New constructors will be provided. Thanks Weijun > > Thanks, > Mayank > > ---------- Forwarded message ---------- > From: **> > Date: Mon, Jul 15, 2013 at 12:01 PM > > Message: 4 > Date: Mon, 15 Jul 2013 11:58:47 +0800 > From: Weijun Wang > > To: kitten at ietf.org , OpenJDK > > > Subject: [kitten] Suggested update to RFC 5653 JGSS-API: Provide a way > to return a token when context establishment fails > Message-ID: <51E37377.1030704 at oracle.com > > > Content-Type: text/plain; charset=ISO-8859-1; format=flowed > > Hi All > > I am Weijun Wang from the Java SE Seurity Team at Oracle, and this mail > is about a design flaw in the initSecContext and acceptSecContext > methods of the GSSContext class defined in RFC 5653 7.4.3 [1] and 7.4.9 [2]. > > The GSSContext::initSecContext() method could either return a token > (possibly null if no more token is needed) when the call succeeds or > throw a GSSException if there is a failure, but not *both*. The same > applies to acceptSecContext(). > > On the other hand, the C bindings of GSS-API has a chance to return > both, and it does try to make use of both of them (according to RFC 2743 > 2.2.1 [3]): > > It is the caller's responsibility to establish a communications path > to the target, and to transmit any returned output_token (independent > of the accompanying returned major_status value) to the target over > that path. > > Without the ability to send a token when there is a failure, a Java > program has no chance to tell the other side what's happening. This is > very user-unfriendly. Also, in the case of SPNEGO, a "reject" > NegTokenResp token will never be able to sent out. > > My current proposal is to add a new method getOutputToken() to the > GSSException class (which will be thrown when an error occurs) to return > this last token. This means the method calls will be something like > > try { > send(initSecContext(inToken)); > } catch (GSSException e) { > if (e.getOutputToken() != null) { > send(e.getOutputToken()); > } > throw e; > } > > The getOutputToken() method can only return a non-null value when it's > thrown by an initSecContext or acceptSecContext call. The method won't > throw another GSSException even if the exception was thrown in other calls. > > We can use the new JDK 8 default method feature [1] to add this new > method to the existing GSSException interface. > > Thanks > Weijun > > [1] http://tools.ietf.org/html/rfc5653#section-7.4.3[2] > http://tools.ietf.org/html/rfc5653#section-7.4.9 > [3] http://tools.ietf.org/html/rfc2743#page-46 > [4] http://tools.ietf.org/html/rfc5653#section-7.4.5 > > > ------------------------------ > > Message: 5 > Date: Mon, 15 Jul 2013 13:33:41 -0400 > From: Jeffrey Hutzelman > > To: Weijun Wang > > Cc: kitten at ietf.org , OpenJDK > >, > jhutz at cmu.edu > Subject: Re: [kitten] Suggested update to RFC 5653 JGSS-API: Provide a > way to return a token when context establishment fails > Message-ID: <1373909621.23365.286.camel at minbar.fac.cs.cmu.edu > > > Content-Type: text/plain; charset="UTF-8" > > On Mon, 2013-07-15 at 11:58 +0800, Weijun Wang wrote: > > > My current proposal is to add a new method getOutputToken() to the > > GSSException class (which will be thrown when an error occurs) to return > > this last token. This means the method calls will be something like > > This seems like an elegant solution to the problem. > > -- Jeff From alexey.utkin at oracle.com Fri Jul 19 01:55:44 2013 From: alexey.utkin at oracle.com (alexey.utkin at oracle.com) Date: Fri, 19 Jul 2013 08:55:44 +0000 Subject: hg: jdk8/tl/jdk: 8016579: (process) IOException thrown by ProcessBuilder.start() method is incorrectly encoded Message-ID: <20130719085621.7F4FA48207@hg.openjdk.java.net> Changeset: e6aeeec33e53 Author: uta Date: 2013-07-19 12:53 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6aeeec33e53 8016579: (process) IOException thrown by ProcessBuilder.start() method is incorrectly encoded Reviewed-by: martin, dxu ! src/share/native/java/io/io_util.c ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/lang/ProcessImpl_md.c From vincent.x.ryan at oracle.com Fri Jul 19 09:39:47 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 19 Jul 2013 17:39:47 +0100 Subject: [7u] 8020940: Valid OCSP responses are rejected for backdated enquiries Message-ID: Please review the following change to correct the handling of backdated OCSP requests: Bug: http://bugs.sun.com/view_bug.do?bug_id=8020940 [not yet visible] Webrev: http://cr.openjdk.java.net/~vinnie/8020940/webrev.00 It modifies the OCSP client to verify the validity interval for an OCSP response relative to the current time. Previously it was relative to the requested time. Thanks. From joe.darcy at oracle.com Fri Jul 19 09:46:25 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 19 Jul 2013 16:46:25 +0000 Subject: hg: jdk8/tl/jdk: 8020948: Fix doclint issues in misc package-info.java files Message-ID: <20130719164653.CD04D4821F@hg.openjdk.java.net> Changeset: e013b32118af Author: darcy Date: 2013-07-19 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e013b32118af 8020948: Fix doclint issues in misc package-info.java files Reviewed-by: dholmes, chegar ! src/share/classes/java/nio/file/attribute/package-info.java ! src/share/classes/java/util/function/package-info.java From kumar.x.srinivasan at oracle.com Fri Jul 19 10:00:46 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 19 Jul 2013 17:00:46 +0000 Subject: hg: jdk8/tl/langtools: 8017216: javac doesn't fill in end position for some errors of type not found; ... Message-ID: <20130719170052.0282148220@hg.openjdk.java.net> Changeset: 0a9f5cbe37d9 Author: ksrini Date: 2013-07-19 07:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0a9f5cbe37d9 8017216: javac doesn't fill in end position for some errors of type not found 8019421: Javac doesn't fill in end position for some annotation related errors 8019422: Javac doesn't fill in end position for uninitialized variable errors Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/EndPosTable.java + test/tools/javac/diags/examples/VarNotIntializedInDefaultConstructor.java + test/tools/javac/positions/TreeEndPosTest.java From sean.mullan at oracle.com Fri Jul 19 10:03:20 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 19 Jul 2013 13:03:20 -0400 Subject: [7u] 8020940: Valid OCSP responses are rejected for backdated enquiries In-Reply-To: References: Message-ID: <51E97158.1000206@oracle.com> Looks good. --Sean On 07/19/2013 12:39 PM, Vincent Ryan wrote: > Please review the following change to correct the handling of backdated OCSP requests: > > Bug: http://bugs.sun.com/view_bug.do?bug_id=8020940 [not yet visible] > Webrev: http://cr.openjdk.java.net/~vinnie/8020940/webrev.00 > > It modifies the OCSP client to verify the validity interval for an OCSP response relative to the current time. > Previously it was relative to the requested time. > Thanks. > From vincent.x.ryan at oracle.com Fri Jul 19 11:08:51 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 19 Jul 2013 19:08:51 +0100 Subject: [8] Code Review Request: 8010748: Add PKIXRevocationChecker NO_FALLBACK option and improve SOFT_FAIL option In-Reply-To: <51E59AE1.5050001@oracle.com> References: <51E59AE1.5050001@oracle.com> Message-ID: Your changes look good. Thanks. On 16 Jul 2013, at 20:11, Sean Mullan wrote: > Please review my JDK 8 fix for 8010748: > > http://bugs.sun.com/view_bug.do?bug_id=8010748 > > This add a few useful API additions to JEP 124 (Enhance the Certificate Revocation-Checking API) from experience with using the API. > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/8010748/webrev.00/ > > Thanks, > Sean > From anthony.scarpino at oracle.com Fri Jul 19 11:19:17 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Fri, 19 Jul 2013 11:19:17 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51E86ED9.7040403@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> <51E703D0.4090505@oracle.com> <51E862FC.5060807@oracle.com> <51E86960.10707@oracle.com> <51E86ED9.7040403@oracle.com> Message-ID: <51E98325.3030205@oracle.com> It was necessary, but I found the unused variable that was triggering the compile error without it. Tony On 07/18/2013 03:40 PM, Valerie (Yu-Ching) Peng wrote: > > Just noticed that the newly-added import statement on line 32 seems > redundant? > Webrev seems the same? > Thanks, > Valerie > > On 07/18/13 15:17, Anthony Scarpino wrote: >> On 07/18/2013 02:49 PM, Valerie (Yu-Ching) Peng wrote: >>> >>> Please find comments inline. >>> >>> On 07/17/13 13:51, Anthony Scarpino wrote: >>>> I have broken these into two webrev. The first: >>>> >>>> JDK-8012971 PKCS11Test hiding exception failures >>>> http://cr.openjdk.java.net/~ascarpino/8012971/webrev.01/ >>>> >>>> handles the minimum changes needed for PKCS11Test to function and the >>>> Problemlist updated to reflect the failures that would show up. >>> Looks fine in general, I only have some nit comments, and questions >>> since I have not touched NSS much. >>> PKCS11Test.java >>> 1) line 88, change "this finally block" to "any finally block" >> yep >> >>> 2) line 192, add space before and after the "+" for consistency with the >>> rest of the source, e.g. line 213. >> yep >> >>> 3) The comments from line 58-60 say the default value is "nss3" but the >>> default value set on line 61 is "softokn3". Seems conflicting? >> >> yep. it nss3 use to be the default, must have forgot the change the >> comment >> >>> 4) Is "nss3" only used for Secmod? It seems that everywhere else you use >>> the "softokn3" value. If yes, perhaps using "setSecmod()" would be >>> clearer than "useNSS()". >> >> Secmod is the only one currently, but I would rather leave it as NSS >> because I named it for the library it's looking for. If another test >> comes around that is not a Secmod test, then setSecmod() doesn't seem >> logical. >> >> webrev is updated in place. >> >>> >>> Will look at 8020424 later today. >>> Thanks, >>> Valerie >>>> >>>> >>>> The second, are the test changes that fix the problems uncovered by >>>> the above change: >>>> >>>> JDK-8020424 The NSS version should be detected before running crypto >>>> tests >>>> http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ >>>> >>>> Tony >>>> >>> >> > From mayank+ietf-kitten at google.com Thu Jul 18 22:34:04 2013 From: mayank+ietf-kitten at google.com (Mayank Upadhyay) Date: Thu, 18 Jul 2013 22:34:04 -0700 Subject: Fwd: Kitten Digest, Vol 104, Issue 14 In-Reply-To: References: Message-ID: Hi Weijun, You point out a legitimate problem, but I want to understand a couple of assumptions: 1. Why allow only initSecContext() and acceptSecContext() to have this new behavior? Imagine a mechanism built on top of TLS which is renegotiating the session intermixed with actual payload, and had some error it wanted to communicate to the peer (e.g., a TLS Alert). Is there any particular reason you'd like to avoid that scenario? 2. I didn't quite follow the comment about the default method (maybe it shows that my Java is dated :). GSSException is not an interface but a concrete class, and adding a method to it adds it in the JRE starting at some particular version. What happens when applications that call the new method are run on an older JRE? 3. Don't we also need to set this token when the mechanism creates a GSSException instance? Note that the concrete class has no setter methods of any kind at this time, but two constructors. Thanks, Mayank ---------- Forwarded message ---------- From: Date: Mon, Jul 15, 2013 at 12:01 PM Message: 4 Date: Mon, 15 Jul 2013 11:58:47 +0800 From: Weijun Wang To: kitten at ietf.org, OpenJDK Subject: [kitten] Suggested update to RFC 5653 JGSS-API: Provide a way to return a token when context establishment fails Message-ID: <51E37377.1030704 at oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Hi All I am Weijun Wang from the Java SE Seurity Team at Oracle, and this mail is about a design flaw in the initSecContext and acceptSecContext methods of the GSSContext class defined in RFC 5653 7.4.3 [1] and 7.4.9 [2]. The GSSContext::initSecContext() method could either return a token (possibly null if no more token is needed) when the call succeeds or throw a GSSException if there is a failure, but not *both*. The same applies to acceptSecContext(). On the other hand, the C bindings of GSS-API has a chance to return both, and it does try to make use of both of them (according to RFC 2743 2.2.1 [3]): It is the caller's responsibility to establish a communications path to the target, and to transmit any returned output_token (independent of the accompanying returned major_status value) to the target over that path. Without the ability to send a token when there is a failure, a Java program has no chance to tell the other side what's happening. This is very user-unfriendly. Also, in the case of SPNEGO, a "reject" NegTokenResp token will never be able to sent out. My current proposal is to add a new method getOutputToken() to the GSSException class (which will be thrown when an error occurs) to return this last token. This means the method calls will be something like try { send(initSecContext(inToken)); } catch (GSSException e) { if (e.getOutputToken() != null) { send(e.getOutputToken()); } throw e; } The getOutputToken() method can only return a non-null value when it's thrown by an initSecContext or acceptSecContext call. The method won't throw another GSSException even if the exception was thrown in other calls. We can use the new JDK 8 default method feature [1] to add this new method to the existing GSSException interface. Thanks Weijun [1] http://tools.ietf.org/html/rfc5653#section-7.4.3[2] http://tools.ietf.org/html/rfc5653#section-7.4.9 [3] http://tools.ietf.org/html/rfc2743#page-46 [4] http://tools.ietf.org/html/rfc5653#section-7.4.5 ------------------------------ Message: 5 Date: Mon, 15 Jul 2013 13:33:41 -0400 From: Jeffrey Hutzelman To: Weijun Wang Cc: kitten at ietf.org, OpenJDK , jhutz at cmu.edu Subject: Re: [kitten] Suggested update to RFC 5653 JGSS-API: Provide a way to return a token when context establishment fails Message-ID: <1373909621.23365.286.camel at minbar.fac.cs.cmu.edu> Content-Type: text/plain; charset="UTF-8" On Mon, 2013-07-15 at 11:58 +0800, Weijun Wang wrote: > My current proposal is to add a new method getOutputToken() to the > GSSException class (which will be thrown when an error occurs) to return > this last token. This means the method calls will be something like This seems like an elegant solution to the problem. -- Jeff -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130718/1b83d02b/attachment-0001.html From mayank+ietf-kitten at google.com Thu Jul 18 22:37:40 2013 From: mayank+ietf-kitten at google.com (Mayank Upadhyay) Date: Thu, 18 Jul 2013 22:37:40 -0700 Subject: [kitten] Suggested update to RFC 5653 JGSS-API: Provide a way to return a token when context establishment fails Message-ID: (My apologies for resending, but with the right subject this time.) Hi Weijun, You point out a legitimate problem, but I want to understand a couple of assumptions: 1. Why allow only initSecContext() and acceptSecContext() to have this new behavior? Imagine a mechanism built on top of TLS which is renegotiating the session intermixed with actual payload, and had some error it wanted to communicate to the peer (e.g., a TLS Alert). Is there any particular reason you'd like to avoid that scenario? 2. I didn't quite follow the comment about the default method (maybe it shows that my Java is dated :). GSSException is not an interface but a concrete class, and adding a method to it adds it in the JRE starting at some particular version. What happens when applications that call the new method are run on an older JRE? 3. Don't we also need to set this token when the mechanism creates a GSSException instance? Note that the concrete class has no setter methods of any kind at this time, but two constructors. Thanks, Mayank ---------- Forwarded message ---------- From: Date: Mon, Jul 15, 2013 at 12:01 PM Message: 4 Date: Mon, 15 Jul 2013 11:58:47 +0800 From: Weijun Wang To: kitten at ietf.org, OpenJDK Subject: [kitten] Suggested update to RFC 5653 JGSS-API: Provide a way to return a token when context establishment fails Message-ID: <51E37377.1030704 at oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Hi All I am Weijun Wang from the Java SE Seurity Team at Oracle, and this mail is about a design flaw in the initSecContext and acceptSecContext methods of the GSSContext class defined in RFC 5653 7.4.3 [1] and 7.4.9 [2]. The GSSContext::initSecContext() method could either return a token (possibly null if no more token is needed) when the call succeeds or throw a GSSException if there is a failure, but not *both*. The same applies to acceptSecContext(). On the other hand, the C bindings of GSS-API has a chance to return both, and it does try to make use of both of them (according to RFC 2743 2.2.1 [3]): It is the caller's responsibility to establish a communications path to the target, and to transmit any returned output_token (independent of the accompanying returned major_status value) to the target over that path. Without the ability to send a token when there is a failure, a Java program has no chance to tell the other side what's happening. This is very user-unfriendly. Also, in the case of SPNEGO, a "reject" NegTokenResp token will never be able to sent out. My current proposal is to add a new method getOutputToken() to the GSSException class (which will be thrown when an error occurs) to return this last token. This means the method calls will be something like try { send(initSecContext(inToken)); } catch (GSSException e) { if (e.getOutputToken() != null) { send(e.getOutputToken()); } throw e; } The getOutputToken() method can only return a non-null value when it's thrown by an initSecContext or acceptSecContext call. The method won't throw another GSSException even if the exception was thrown in other calls. We can use the new JDK 8 default method feature [1] to add this new method to the existing GSSException interface. Thanks Weijun [1] http://tools.ietf.org/html/rfc5653#section-7.4.3[2] http://tools.ietf.org/html/rfc5653#section-7.4.9 [3] http://tools.ietf.org/html/rfc2743#page-46 [4] http://tools.ietf.org/html/rfc5653#section-7.4.5 ------------------------------ Message: 5 Date: Mon, 15 Jul 2013 13:33:41 -0400 From: Jeffrey Hutzelman To: Weijun Wang Cc: kitten at ietf.org, OpenJDK , jhutz at cmu.edu Subject: Re: [kitten] Suggested update to RFC 5653 JGSS-API: Provide a way to return a token when context establishment fails Message-ID: <1373909621.23365.286.camel at minbar.fac.cs.cmu.edu> Content-Type: text/plain; charset="UTF-8" On Mon, 2013-07-15 at 11:58 +0800, Weijun Wang wrote: > My current proposal is to add a new method getOutputToken() to the > GSSException class (which will be thrown when an error occurs) to return > this last token. This means the method calls will be something like This seems like an elegant solution to the problem. -- Jeff -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130718/52469d6f/attachment-0001.html From nico at cryptonector.com Thu Jul 18 23:37:52 2013 From: nico at cryptonector.com (Nico Williams) Date: Fri, 19 Jul 2013 01:37:52 -0500 Subject: [kitten] Suggested update to RFC 5653 JGSS-API: Provide a way to return a token when context establishment fails In-Reply-To: <51E37377.1030704@oracle.com> References: <51B1E355.2090301@oracle.com> <51E37377.1030704@oracle.com> Message-ID: On Sun, Jul 14, 2013 at 10:58 PM, Weijun Wang wrote: > Without the ability to send a token when there is a failure, a Java program > has no chance to tell the other side what's happening. This is very > user-unfriendly. Also, in the case of SPNEGO, a "reject" NegTokenResp token > will never be able to sent out. I agree. > My current proposal is to add a new method getOutputToken() to the > GSSException class (which will be thrown when an error occurs) to return > this last token. This means the method calls will be something like > > try { > send(initSecContext(inToken)); > } catch (GSSException e) { > if (e.getOutputToken() != null) { > send(e.getOutputToken()); > } > throw e; > } > > The getOutputToken() method can only return a non-null value when it's > thrown by an initSecContext or acceptSecContext call. The method won't throw > another GSSException even if the exception was thrown in other calls. I support this. > We can use the new JDK 8 default method feature [1] to add this new method > to the existing GSSException interface. Excellent, Nico -- From valerie.peng at oracle.com Fri Jul 19 16:21:01 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 19 Jul 2013 16:21:01 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51E98325.3030205@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> <51E703D0.4090505@oracle.com> <51E862FC.5060807@oracle.com> <51E86960.10707@oracle.com> <51E86ED9.7040403@oracle.com> <51E98325.3030205@oracle.com> Message-ID: <51E9C9DD.6080202@oracle.com> Oh, another thing, I noticed that for ProblemList.txt, line 261 is a duplicate of line 289. Otherwise, looks fine. BTW, I didn't get to finish reviewing your second fix today, may take a few more days to get that done... Thanks, Valerie On 07/19/13 11:19, Anthony Scarpino wrote: > It was necessary, but I found the unused variable that was triggering > the compile error without it. > > Tony > > On 07/18/2013 03:40 PM, Valerie (Yu-Ching) Peng wrote: >> >> Just noticed that the newly-added import statement on line 32 seems >> redundant? >> Webrev seems the same? >> Thanks, >> Valerie >> >> On 07/18/13 15:17, Anthony Scarpino wrote: >>> On 07/18/2013 02:49 PM, Valerie (Yu-Ching) Peng wrote: >>>> >>>> Please find comments inline. >>>> >>>> On 07/17/13 13:51, Anthony Scarpino wrote: >>>>> I have broken these into two webrev. The first: >>>>> >>>>> JDK-8012971 PKCS11Test hiding exception failures >>>>> http://cr.openjdk.java.net/~ascarpino/8012971/webrev.01/ >>>>> >>>>> handles the minimum changes needed for PKCS11Test to function and the >>>>> Problemlist updated to reflect the failures that would show up. >>>> Looks fine in general, I only have some nit comments, and questions >>>> since I have not touched NSS much. >>>> PKCS11Test.java >>>> 1) line 88, change "this finally block" to "any finally block" >>> yep >>> >>>> 2) line 192, add space before and after the "+" for consistency >>>> with the >>>> rest of the source, e.g. line 213. >>> yep >>> >>>> 3) The comments from line 58-60 say the default value is "nss3" but >>>> the >>>> default value set on line 61 is "softokn3". Seems conflicting? >>> >>> yep. it nss3 use to be the default, must have forgot the change the >>> comment >>> >>>> 4) Is "nss3" only used for Secmod? It seems that everywhere else >>>> you use >>>> the "softokn3" value. If yes, perhaps using "setSecmod()" would be >>>> clearer than "useNSS()". >>> >>> Secmod is the only one currently, but I would rather leave it as NSS >>> because I named it for the library it's looking for. If another test >>> comes around that is not a Secmod test, then setSecmod() doesn't seem >>> logical. >>> >>> webrev is updated in place. >>> >>>> >>>> Will look at 8020424 later today. >>>> Thanks, >>>> Valerie >>>>> >>>>> >>>>> The second, are the test changes that fix the problems uncovered by >>>>> the above change: >>>>> >>>>> JDK-8020424 The NSS version should be detected before running crypto >>>>> tests >>>>> http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ >>>>> >>>>> Tony >>>>> >>>> >>> >> > From anthony.scarpino at oracle.com Fri Jul 19 16:35:34 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Fri, 19 Jul 2013 16:35:34 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51E9C9DD.6080202@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> <51E703D0.4090505@oracle.com> <51E862FC.5060807@oracle.com> <51E86960.10707@oracle.com> <51E86ED9.7040403@oracle.com> <51E98325.3030205@oracle.com> <51E9C9DD.6080202@oracle.com> Message-ID: <51E9CD46.5070600@oracle.com> Both of them get removed in the next webrev. Tony On 07/19/2013 04:21 PM, Valerie (Yu-Ching) Peng wrote: > > Oh, another thing, I noticed that for ProblemList.txt, line 261 is a > duplicate of line 289. > Otherwise, looks fine. > > BTW, I didn't get to finish reviewing your second fix today, may take a > few more days to get that done... > Thanks, > Valerie > > On 07/19/13 11:19, Anthony Scarpino wrote: >> It was necessary, but I found the unused variable that was triggering >> the compile error without it. >> >> Tony >> >> On 07/18/2013 03:40 PM, Valerie (Yu-Ching) Peng wrote: >>> >>> Just noticed that the newly-added import statement on line 32 seems >>> redundant? >>> Webrev seems the same? >>> Thanks, >>> Valerie >>> >>> On 07/18/13 15:17, Anthony Scarpino wrote: >>>> On 07/18/2013 02:49 PM, Valerie (Yu-Ching) Peng wrote: >>>>> >>>>> Please find comments inline. >>>>> >>>>> On 07/17/13 13:51, Anthony Scarpino wrote: >>>>>> I have broken these into two webrev. The first: >>>>>> >>>>>> JDK-8012971 PKCS11Test hiding exception failures >>>>>> http://cr.openjdk.java.net/~ascarpino/8012971/webrev.01/ >>>>>> >>>>>> handles the minimum changes needed for PKCS11Test to function and the >>>>>> Problemlist updated to reflect the failures that would show up. >>>>> Looks fine in general, I only have some nit comments, and questions >>>>> since I have not touched NSS much. >>>>> PKCS11Test.java >>>>> 1) line 88, change "this finally block" to "any finally block" >>>> yep >>>> >>>>> 2) line 192, add space before and after the "+" for consistency >>>>> with the >>>>> rest of the source, e.g. line 213. >>>> yep >>>> >>>>> 3) The comments from line 58-60 say the default value is "nss3" but >>>>> the >>>>> default value set on line 61 is "softokn3". Seems conflicting? >>>> >>>> yep. it nss3 use to be the default, must have forgot the change the >>>> comment >>>> >>>>> 4) Is "nss3" only used for Secmod? It seems that everywhere else >>>>> you use >>>>> the "softokn3" value. If yes, perhaps using "setSecmod()" would be >>>>> clearer than "useNSS()". >>>> >>>> Secmod is the only one currently, but I would rather leave it as NSS >>>> because I named it for the library it's looking for. If another test >>>> comes around that is not a Secmod test, then setSecmod() doesn't seem >>>> logical. >>>> >>>> webrev is updated in place. >>>> >>>>> >>>>> Will look at 8020424 later today. >>>>> Thanks, >>>>> Valerie >>>>>> >>>>>> >>>>>> The second, are the test changes that fix the problems uncovered by >>>>>> the above change: >>>>>> >>>>>> JDK-8020424 The NSS version should be detected before running crypto >>>>>> tests >>>>>> http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ >>>>>> >>>>>> Tony >>>>>> >>>>> >>>> >>> >> > From xuelei.fan at oracle.com Fri Jul 19 20:31:24 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Sat, 20 Jul 2013 11:31:24 +0800 Subject: TLS and Pre-shared Keys In-Reply-To: <20130717195259.GA24976@mhcomputing.net> References: <51E6F44F.7030503@oracle.com> <20130717195259.GA24976@mhcomputing.net> Message-ID: <51EA048C.6050001@oracle.com> It is not supported at present. Will consider it in the future. Xuelei On 7/18/2013 3:52 AM, Matthew Hall wrote: > On Wed, Jul 17, 2013 at 03:45:19PM -0400, roger riggs wrote: >> Hi, >> >> Is there support in SSLEngine/TLS to support Pre-Shared Keys? >> I have been looking for relevant doc and have not stumbled upon it. >> >> Thanks, Roger > > No, there isn't any support for PSK Ciphers yet, although some of the > constants for them appear in grep output. > > It would be really nice if it were supported for deploying new cluster nodes > in distributed systems, etc. > > Matthew. > From joe.darcy at oracle.com Sat Jul 20 11:40:28 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 20 Jul 2013 18:40:28 +0000 Subject: hg: jdk8/tl/jdk: 8020971: Fix doclint issues in java.nio.* Message-ID: <20130720184054.B221A48243@hg.openjdk.java.net> Changeset: 4bd04969a228 Author: darcy Date: 2013-07-20 11:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bd04969a228 8020971: Fix doclint issues in java.nio.* Reviewed-by: lancea ! src/share/classes/java/nio/channels/package-info.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/nio/charset/MalformedInputException.java ! src/share/classes/java/nio/charset/UnmappableCharacterException.java ! src/share/classes/java/nio/file/package-info.java From chris.hegarty at oracle.com Mon Jul 22 07:27:04 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 22 Jul 2013 14:27:04 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130722142742.13EDF48264@hg.openjdk.java.net> Changeset: dcd89e60051a Author: khazra Date: 2013-07-22 15:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dcd89e60051a 8020498: Crash when both libnet.so and libmawt.so are loaded Reviewed-by: chegar, dsamersoff ! src/share/native/java/net/net_util.c Changeset: a3a2889b1049 Author: dl Date: 2013-07-22 15:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3a2889b1049 8020976: Ensure consistent insertion for ConcurrentHashMap Reviewed-by: chegar ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java From mike.duigou at oracle.com Mon Jul 22 14:04:03 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Mon, 22 Jul 2013 21:04:03 +0000 Subject: hg: jdk8/tl/jdk: 6799426: Adds constructor PriorityQueue(Comparator) Message-ID: <20130722210415.583074827A@hg.openjdk.java.net> Changeset: a6cbb9808e4b Author: mduigou Date: 2013-07-22 12:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a6cbb9808e4b 6799426: Adds constructor PriorityQueue(Comparator) Reviewed-by: lancea ! src/share/classes/java/util/PriorityQueue.java From valerie.peng at oracle.com Mon Jul 22 15:11:44 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Mon, 22 Jul 2013 15:11:44 -0700 Subject: [7u] 8020940: Valid OCSP responses are rejected for backdated enquiries In-Reply-To: References: Message-ID: <51EDAE20.4050206@oracle.com> The changes look fine. However, the dateCheckedAgainst argument for method SingleResponse constructor becomes obsolete and not used at all. Should it be removed from the method signature, i.e. any reason to keep this? Thanks, Valerie On 07/19/13 09:39, Vincent Ryan wrote: > Please review the following change to correct the handling of backdated OCSP requests: > > Bug: http://bugs.sun.com/view_bug.do?bug_id=8020940 [not yet visible] > Webrev: http://cr.openjdk.java.net/~vinnie/8020940/webrev.00 > > It modifies the OCSP client to verify the validity interval for an OCSP response relative to the current time. > Previously it was relative to the requested time. > Thanks. > From vincent.x.ryan at oracle.com Mon Jul 22 16:43:37 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 23 Jul 2013 00:43:37 +0100 Subject: [7u] 8020940: Valid OCSP responses are rejected for backdated enquiries In-Reply-To: <51EDAE20.4050206@oracle.com> References: <51EDAE20.4050206@oracle.com> Message-ID: <51EDC3A9.4090503@oracle.com> Thanks for the review Valerie. Since this is a late change for 7u40 I wanted to minimize the code changes. I will examine removing that additional construction in a later change. On 22/07/2013 23:11, Valerie (Yu-Ching) Peng wrote: > The changes look fine. > > However, the dateCheckedAgainst argument for method SingleResponse > constructor becomes obsolete and not used at all. > Should it be removed from the method signature, i.e. any reason to keep > this? > > Thanks, > Valerie > On 07/19/13 09:39, Vincent Ryan wrote: >> Please review the following change to correct the handling of >> backdated OCSP requests: >> >> Bug: http://bugs.sun.com/view_bug.do?bug_id=8020940 [not yet visible] >> Webrev: http://cr.openjdk.java.net/~vinnie/8020940/webrev.00 >> >> It modifies the OCSP client to verify the validity interval for an >> OCSP response relative to the current time. >> Previously it was relative to the requested time. >> Thanks. >> > From joe.darcy at oracle.com Mon Jul 22 22:12:03 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 23 Jul 2013 05:12:03 +0000 Subject: hg: jdk8/tl/jdk: 8021109: Add serialVersionUID to LambdaConversionException.java Message-ID: <20130723051217.A34E548288@hg.openjdk.java.net> Changeset: 7716beb127d4 Author: darcy Date: 2013-07-22 22:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7716beb127d4 8021109: Add serialVersionUID to LambdaConversionException.java Reviewed-by: jrose ! src/share/classes/java/lang/invoke/LambdaConversionException.java From sean.mullan at oracle.com Tue Jul 23 06:05:23 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 23 Jul 2013 09:05:23 -0400 Subject: [8] Request for review: 8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo Message-ID: <51EE7F93.3070200@oracle.com> Xuelei, Could you please review my fix for 8012288: http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.00/ There is already an SQE test for this, so I have added the noreg-sqe label. Thanks, Sean From daniel.daugherty at oracle.com Tue Jul 23 08:39:44 2013 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Tue, 23 Jul 2013 15:39:44 +0000 Subject: hg: jdk8/tl/jdk: 8016838: improvement of RedefineBigClass and RetransformBigClass tests Message-ID: <20130723154031.60C6C482A3@hg.openjdk.java.net> Changeset: 6f3b940fe9f8 Author: igerasim Date: 2013-07-23 18:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f3b940fe9f8 8016838: improvement of RedefineBigClass and RetransformBigClass tests Reviewed-by: dcubed ! test/ProblemList.txt ! test/java/lang/instrument/RedefineBigClass.sh ! test/java/lang/instrument/RedefineBigClassApp.java ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/RetransformBigClassApp.java From sundararajan.athijegannathan at oracle.com Tue Jul 23 11:15:19 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 23 Jul 2013 18:15:19 +0000 Subject: hg: jdk8/tl/nashorn: 10 new changesets Message-ID: <20130723181528.83B96482AE@hg.openjdk.java.net> Changeset: e1d19f9fd5a9 Author: jlaskey Date: 2013-07-16 17:40 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e1d19f9fd5a9 8017585: Exclude two failing tests from Nashorn CC run Reviewed-by: jlaskey, sundar, attila Contributed-by: konstantin.shefov at oracle.com + exclude/exclude_list.txt + exclude/exclude_list_cc.txt ! make/build.xml Changeset: 71cfe4e66bcb Author: jlaskey Date: 2013-07-17 11:53 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/71cfe4e66bcb 8020596: Initialization of white space strings in scanner should be done with \u strings Reviewed-by: attila, hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/parser/Lexer.java Changeset: 3d6f6b8d8bc8 Author: hannesw Date: 2013-07-17 18:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3d6f6b8d8bc8 8020356: ClassCastException Undefined->Scope on spiltter class generated for a large switch statement Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Label.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java + test/script/basic/JDK-8020356.js + test/script/basic/JDK-8020356.js.EXPECTED Changeset: e3307f1a30e5 Author: sundar Date: 2013-07-18 18:08 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e3307f1a30e5 8020731: Revisit checkPermission calls in Context class Reviewed-by: attila, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java - src/jdk/nashorn/internal/runtime/linker/JavaAdapterGeneratorBase.java Changeset: 624f8be5c3fe Author: attila Date: 2013-07-18 16:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/624f8be5c3fe 8020809: Java adapter should not allow overriding of caller sensitive methods Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java + test/script/trusted/JDK-8020809.js + test/script/trusted/JDK-8020809.js.EXPECTED Changeset: 4b06441b7624 Author: attila Date: 2013-07-18 16:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4b06441b7624 8020820: Limit access to static members of reflective classes Reviewed-by: jlaskey, sundar ! make/build.xml ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java ! test/script/basic/JDK-8010946-2.js ! test/script/basic/JDK-8010946-2.js.EXPECTED ! test/script/basic/NASHORN-473.js + test/script/basic/classloader.js + test/script/basic/classloader.js.EXPECTED ! test/script/basic/javaarray.js ! test/script/sandbox/classloader.js.EXPECTED ! test/script/sandbox/reflection.js ! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java Changeset: 0cfa27ed82fe Author: sundar Date: 2013-07-23 18:17 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0cfa27ed82fe 8021122: Not all callables are handled for toString and other function valued properties Reviewed-by: attila, hannesw, jlaskey ! src/jdk/nashorn/internal/ir/debug/ASTWriter.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java + test/script/basic/JDK-8021122.js + test/script/basic/JDK-8021122.js.EXPECTED Changeset: e86b297d26aa Author: jlaskey Date: 2013-07-23 12:00 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e86b297d26aa 8021130: Comments need to be tokens Reviewed-by: lagergren, attila Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/parser/TokenType.java Changeset: ccbea9172aa5 Author: sundar Date: 2013-07-23 21:45 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ccbea9172aa5 8021164: REGRESSION: test262 failures after JDK-8021122 Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java Changeset: 4cb1780bc385 Author: sundar Date: 2013-07-23 21:51 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4cb1780bc385 Merge - src/jdk/nashorn/internal/runtime/linker/JavaAdapterGeneratorBase.java From mike.duigou at oracle.com Tue Jul 23 13:32:27 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 23 Jul 2013 20:32:27 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130723203305.B1E3C482BE@hg.openjdk.java.net> Changeset: 8156630c1ed3 Author: mduigou Date: 2013-07-23 13:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8156630c1ed3 8019840: Spec updates for java.util.function Reviewed-by: mduigou, chegar Contributed-by: brian.goetz at oracle.com ! src/share/classes/java/util/function/BiConsumer.java ! src/share/classes/java/util/function/BiFunction.java ! src/share/classes/java/util/function/BiPredicate.java ! src/share/classes/java/util/function/BinaryOperator.java ! src/share/classes/java/util/function/BooleanSupplier.java ! src/share/classes/java/util/function/Consumer.java ! src/share/classes/java/util/function/DoubleBinaryOperator.java ! src/share/classes/java/util/function/DoubleConsumer.java ! src/share/classes/java/util/function/DoubleFunction.java ! src/share/classes/java/util/function/DoublePredicate.java ! src/share/classes/java/util/function/DoubleSupplier.java ! src/share/classes/java/util/function/DoubleToIntFunction.java ! src/share/classes/java/util/function/DoubleToLongFunction.java ! src/share/classes/java/util/function/DoubleUnaryOperator.java ! src/share/classes/java/util/function/Function.java ! src/share/classes/java/util/function/IntBinaryOperator.java ! src/share/classes/java/util/function/IntConsumer.java ! src/share/classes/java/util/function/IntFunction.java ! src/share/classes/java/util/function/IntPredicate.java ! src/share/classes/java/util/function/IntSupplier.java ! src/share/classes/java/util/function/IntToDoubleFunction.java ! src/share/classes/java/util/function/IntToLongFunction.java ! src/share/classes/java/util/function/IntUnaryOperator.java ! src/share/classes/java/util/function/LongBinaryOperator.java ! src/share/classes/java/util/function/LongConsumer.java ! src/share/classes/java/util/function/LongFunction.java ! src/share/classes/java/util/function/LongPredicate.java ! src/share/classes/java/util/function/LongSupplier.java ! src/share/classes/java/util/function/LongToDoubleFunction.java ! src/share/classes/java/util/function/LongToIntFunction.java ! src/share/classes/java/util/function/LongUnaryOperator.java ! src/share/classes/java/util/function/ObjDoubleConsumer.java ! src/share/classes/java/util/function/ObjIntConsumer.java ! src/share/classes/java/util/function/ObjLongConsumer.java ! src/share/classes/java/util/function/Predicate.java ! src/share/classes/java/util/function/Supplier.java ! src/share/classes/java/util/function/ToDoubleBiFunction.java ! src/share/classes/java/util/function/ToDoubleFunction.java ! src/share/classes/java/util/function/ToIntBiFunction.java ! src/share/classes/java/util/function/ToIntFunction.java ! src/share/classes/java/util/function/ToLongBiFunction.java ! src/share/classes/java/util/function/ToLongFunction.java ! src/share/classes/java/util/function/UnaryOperator.java ! src/share/classes/java/util/function/package-info.java Changeset: 012996e9259f Author: mduigou Date: 2013-07-23 13:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/012996e9259f Merge From zhong.j.yu at gmail.com Tue Jul 23 15:41:52 2013 From: zhong.j.yu at gmail.com (Zhong Yu) Date: Tue, 23 Jul 2013 17:41:52 -0500 Subject: TLS extension needed for HTTP/2.0 Message-ID: Hi there, HTTP/2.0 draft (based on google's SPDY) requires the use of a new TLS extension (ALPN), see http://tools.ietf.org/html/draft-ietf-httpbis-http2-04#section-3.3 The current javax.net.ssl API does not support that, so it'll be a problem for someone trying to implement the HTTP/2.0 draft on Java platform. Is there a remedy to that? If javax.net.ssl needs further development to be able to support ALPN, would you give a rough estimate on when it could be released? And would it be back ported to earlier versions of Java? What kind of API change do you envision that's necessary to expose ALPN negotiation process to applications? Note that HTTP/2.0 is in very early stage; it's possible that the requirement of ALPN could be relaxed if there's difficulty to implement it on popular platforms; see this thread: http://lists.w3.org/Archives/Public/ietf-http-wg/2013JulSep/0425.html Thank you very much, Zhong Yu From mhall at mhcomputing.net Tue Jul 23 15:50:16 2013 From: mhall at mhcomputing.net (Matthew Hall) Date: Tue, 23 Jul 2013 15:50:16 -0700 Subject: TLS extension needed for HTTP/2.0 In-Reply-To: References: Message-ID: <20130723225016.GA17552@mhcomputing.net> On Tue, Jul 23, 2013 at 05:41:52PM -0500, Zhong Yu wrote: > Note that HTTP/2.0 is in very early stage; it's possible that the > requirement of ALPN could be relaxed if there's difficulty to > implement it on popular platforms; see this thread: > http://lists.w3.org/Archives/Public/ietf-http-wg/2013JulSep/0425.html I'm not sure putting ALPN in there is the best idea, if you want this to work right on millions of already deployed but un-upgradeable mobile devices around the world. I think maybe it makes more sense to have an HTTP/2.0 string like what's seen with HTTP/1.0 and HTTP/1.1 or some other such mechanism that doesn't cause contamination between the layers of the protocol stack. Matthew. From zhong.j.yu at gmail.com Tue Jul 23 16:00:07 2013 From: zhong.j.yu at gmail.com (Zhong Yu) Date: Tue, 23 Jul 2013 18:00:07 -0500 Subject: TLS extension needed for HTTP/2.0 In-Reply-To: <20130723225016.GA17552@mhcomputing.net> References: <20130723225016.GA17552@mhcomputing.net> Message-ID: On Tue, Jul 23, 2013 at 5:50 PM, Matthew Hall wrote: > On Tue, Jul 23, 2013 at 05:41:52PM -0500, Zhong Yu wrote: >> Note that HTTP/2.0 is in very early stage; it's possible that the >> requirement of ALPN could be relaxed if there's difficulty to >> implement it on popular platforms; see this thread: >> http://lists.w3.org/Archives/Public/ietf-http-wg/2013JulSep/0425.html > > I'm not sure putting ALPN in there is the best idea, if you want this to work > right on millions of already deployed but un-upgradeable mobile devices around > the world. > > I think maybe it makes more sense to have an HTTP/2.0 string like what's seen > with HTTP/1.0 and HTTP/1.1 or some other such mechanism that doesn't cause > contamination between the layers of the protocol stack. These are very good points and you probably should raise them on the http list. My objection to the ALPN mandate is that Java doesn't have out-of-box support, and the http people like to get an understanding just how difficult/distant it would be to to deploy ALPN on Java platforms. Zhong Yu From jonathan.gibbons at oracle.com Tue Jul 23 16:06:37 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 23 Jul 2013 23:06:37 +0000 Subject: hg: jdk8/tl/langtools: 8021215: javac gives incorrect doclint warnings on normal package statements Message-ID: <20130723230640.439AB482C9@hg.openjdk.java.net> Changeset: 129751018061 Author: jjg Date: 2013-07-23 16:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/129751018061 8021215: javac gives incorrect doclint warnings on normal package statements Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/DocLint.java ! test/tools/doclint/packageTests/bad/Test.java + test/tools/doclint/packageTests/bad/Test.javac.out ! test/tools/doclint/packageTests/bad/Test.out ! test/tools/doclint/packageTests/bad/package-info.java + test/tools/doclint/packageTests/bad/package-info.javac.out ! test/tools/doclint/packageTests/bad/package-info.out ! test/tools/doclint/packageTests/good/Test.java ! test/tools/doclint/packageTests/good/package-info.java From jason.uh at oracle.com Tue Jul 23 17:35:53 2013 From: jason.uh at oracle.com (Jason Uh) Date: Tue, 23 Jul 2013 17:35:53 -0700 Subject: [8] Request for Review: 8016916: UnstructuredName should support DirectoryString Message-ID: <51EF2169.1080007@oracle.com> Can I please get a review of this changeset? Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016916 Webrev: http://cr.openjdk.java.net/~juh/8016916/webrev.00/ This change adds PrintableString to the list of ASN.1 tags that PKCS9Attribute accepts for the UnstructuredName attribute. Also, the 'keytool -printcertreq' output has been enhanced because the way it was before, it would have printed: 1.2.840.113549.1.9.2 [Ljava.lang.String;@4e0e2f2a for an UnstructuredName attribute. Thanks, Jason From eric.mccorkle at oracle.com Tue Jul 23 17:44:03 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Wed, 24 Jul 2013 00:44:03 +0000 Subject: hg: jdk8/tl/langtools: 8016880: 42 tests in annot102* fail with compile-time errors. Message-ID: <20130724004410.DD60C482CB@hg.openjdk.java.net> Changeset: 558fe98d1ac0 Author: emc Date: 2013-07-23 20:42 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/558fe98d1ac0 8016880: 42 tests in annot102* fail with compile-time errors. Summary: Fixes error in type equality when bounds of type variables have annotations. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/annotations/typeAnnotations/ErasureTest.java From valerie.peng at oracle.com Tue Jul 23 18:00:14 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 23 Jul 2013 18:00:14 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51E703D0.4090505@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> <51E703D0.4090505@oracle.com> Message-ID: <51EF271E.80509@oracle.com> 263 System.arraycopy(data, 900, data, 0, 100); 264 is.read(data, 0, 900); Do you really mean to overwrite the data[0..99] that you just copied on line 263 with line 264? In addition, don't you want to know how much is read in order to exclude the data from earlier read(...) calls in case that the current read only returns a few bytes? Do you have the list of supported curves does NSS ECC Basic and Extensive? Some tests you check the curves and some tests you return immediately. Also, do you know if there is a mozilla bug# for the DER issue that you referred in several files? Seems hard to tell which call would trigger this NSS bug, i.e. when to add this check, until the test actually failed using the older NSS library. After seeing all these checks and list of known bugs for testing against NSS, I think we probably need a README or some wiki page to keep track all this... Thanks, Valerie On 07/17/13 13:51, Anthony Scarpino wrote: > JDK-8020424 The NSS version should be detected before running crypto > tests > http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ > > Tony > From sean.mullan at oracle.com Wed Jul 24 06:18:33 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 24 Jul 2013 09:18:33 -0400 Subject: [8] Request for Review: 8016916: UnstructuredName should support DirectoryString In-Reply-To: <51EF2169.1080007@oracle.com> References: <51EF2169.1080007@oracle.com> Message-ID: <51EFD429.2080601@oracle.com> Looks good to me. --Sean On 07/23/2013 08:35 PM, Jason Uh wrote: > Can I please get a review of this changeset? > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016916 > Webrev: http://cr.openjdk.java.net/~juh/8016916/webrev.00/ > > This change adds PrintableString to the list of ASN.1 tags that > PKCS9Attribute accepts for the UnstructuredName attribute. Also, the > 'keytool -printcertreq' output has been enhanced because the way it was > before, it would have printed: > > 1.2.840.113549.1.9.2 > [Ljava.lang.String;@4e0e2f2a > > for an UnstructuredName attribute. > > Thanks, > Jason From Xuelei.Fan at Oracle.COM Wed Jul 24 07:16:38 2013 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Wed, 24 Jul 2013 22:16:38 +0800 Subject: [8] Request for review: 8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo In-Reply-To: <51EE7F93.3070200@oracle.com> References: <51EE7F93.3070200@oracle.com> Message-ID: <51EFE1C6.4010408@Oracle.COM> DOMUtils.java ============= It might be a little bit better to reuse the node local name checking with a new private static method. Otherwise, looks fine. A minor comment is a very personal preference. I may prefer to return null instead of throw exception in the new methods of class DOMUtils, when there is no such node. And the caller throw the exception instead. For example: public static Element getFirstChildElement(Node node, String localName) throws MarshalException Xuelei On 7/23/2013 9:05 PM, Sean Mullan wrote: > Xuelei, > > Could you please review my fix for 8012288: > > http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.00/ > > There is already an SQE test for this, so I have added the noreg-sqe label. > > Thanks, > Sean From jason.uh at oracle.com Wed Jul 24 12:50:33 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Wed, 24 Jul 2013 19:50:33 +0000 Subject: hg: jdk8/tl/jdk: 8016916: UnstructuredName should support DirectoryString Message-ID: <20130724195115.5085E48320@hg.openjdk.java.net> Changeset: f9224fb49890 Author: juh Date: 2013-07-24 12:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9224fb49890 8016916: UnstructuredName should support DirectoryString Reviewed-by: mullan ! src/share/classes/sun/security/pkcs/PKCS9Attribute.java ! src/share/classes/sun/security/tools/keytool/Main.java + test/sun/security/pkcs/pkcs9/UnstructuredName.java From anthony.scarpino at oracle.com Wed Jul 24 13:53:20 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Wed, 24 Jul 2013 13:53:20 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51EF271E.80509@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> <51E703D0.4090505@oracle.com> <51EF271E.80509@oracle.com> Message-ID: <51F03EC0.6070800@oracle.com> On 07/23/2013 06:00 PM, Valerie (Yu-Ching) Peng wrote: > > > > 263 System.arraycopy(data, 900, data, 0, 100); > 264 is.read(data, 0, 900); > > Do you really mean to overwrite the data[0..99] that you just copied on > line 263 with line 264? Good catch.. I would have thought all my testing would have tripped me up on this, but it appears it didn't. > In addition, don't you want to know how much is read in order to exclude > the data from earlier read(...) calls in case that the current read only > returns a few bytes? Yeah, the end of the file read is a bit sloppy, even though it should never see the end of the file as all the nss libraries have the header in it. > > Do you have the list of supported curves does NSS ECC Basic and Extensive? > Some tests you check the curves and some tests you return immediately. There are three. In TestCurves.java is one example where the test now to distinguish between Basic and Extended, and to know the proper PKCS11 error code (CKR_DOMAIN_PARAMS_INVALID) if it is not supported. > > Also, do you know if there is a mozilla bug# for the DER issue that you > referred in several files? > Seems hard to tell which call would trigger this NSS bug, i.e. when to > add this check, until the test actually failed using the older NSS library. I was never comfortable in the NSS DER bug.. My guess was it is 480280, but I was not confident and thought it was better to not list if I wasn't sure. It is a trial-and-error process in finding the NSS bugs. The easiest is finding an older version of NSS failing and a new one working, > > After seeing all these checks and list of known bugs for testing against > NSS, I think we probably need a README or some wiki page to keep track > all this... I can throw a readme in the directory with the bug IDs and even my theory that the DER is 480280. webrev updated at: http://cr.openjdk.java.net/~ascarpino/8020424/webrev.01/ > Thanks, > Valerie > > On 07/17/13 13:51, Anthony Scarpino wrote: >> JDK-8020424 The NSS version should be detected before running crypto >> tests >> http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ >> >> Tony >> > From shanliang.jiang at oracle.com Wed Jul 24 06:51:29 2013 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Wed, 24 Jul 2013 13:51:29 +0000 Subject: hg: jdk8/tl/jdk: 8016221: A unit test should not use a fix port to run a jmx connector Message-ID: <20130724135234.0309948303@hg.openjdk.java.net> Changeset: 187a1f2613c0 Author: sjiang Date: 2013-07-24 15:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/187a1f2613c0 8016221: A unit test should not use a fix port to run a jmx connector Reviewed-by: jbachorik, dfuchs ! test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanDoubleInvocationTest.java ! test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanInvocationTest.java ! test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanTest.java From chris.hegarty at oracle.com Wed Jul 24 14:53:05 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 24 Jul 2013 21:53:05 +0000 Subject: hg: jdk8/tl/jdk: 8021261: ProblemList.txt updates (7/2013) Message-ID: <20130724215333.7F7EE48325@hg.openjdk.java.net> Changeset: fd1b5adcfdf0 Author: chegar Date: 2013-07-24 22:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd1b5adcfdf0 8021261: ProblemList.txt updates (7/2013) Reviewed-by: alanb, mcimadamore ! test/ProblemList.txt From jonathan.gibbons at oracle.com Wed Jul 24 17:36:13 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 25 Jul 2013 00:36:13 +0000 Subject: hg: jdk8/tl/langtools: 8020556: doclint does not check type variables for @throws Message-ID: <20130725003619.3FE3D48339@hg.openjdk.java.net> Changeset: 2fbe77c38802 Author: jjg Date: 2013-07-24 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fbe77c38802 8020556: doclint does not check type variables for @throws Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Env.java ! test/tools/doclint/ReferenceTest.java From valerie.peng at oracle.com Wed Jul 24 18:37:41 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Wed, 24 Jul 2013 18:37:41 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51F03EC0.6070800@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> <51E703D0.4090505@oracle.com> <51EF271E.80509@oracle.com> <51F03EC0.6070800@oracle.com> Message-ID: <51F08165.7020504@oracle.com> On 07/24/13 13:53, Anthony Scarpino wrote: > On 07/23/2013 06:00 PM, Valerie (Yu-Ching) Peng wrote: >> >> >> >> 263 System.arraycopy(data, 900, data, 0, 100); >> 264 is.read(data, 0, 900); >> >> Do you really mean to overwrite the data[0..99] that you just copied on >> line 263 with line 264? > > > Good catch.. I would have thought all my testing would have tripped me > up on this, but it appears it didn't. > >> In addition, don't you want to know how much is read in order to exclude >> the data from earlier read(...) calls in case that the current read only >> returns a few bytes? > > Yeah, the end of the file read is a bit sloppy, even though it should > never see the end of the file as all the nss libraries have the header > in it. Hmm, I think the String object should be constructed w/ the bytes that's just read, i.e. new String(data, 0, read) 256 s = new String(data); And line 272 should be update to "read = 100 + is.read(data, 100, 900);" Also, the value of variable s is only set once on line 256 and yet the content of 'data' may change on line 271-272. This may lead to inconsistency between 's' and 'data' if the while-loop (line 255) is exited due to read <= 0 on line 272. >> >> After seeing all these checks and list of known bugs for testing against >> NSS, I think we probably need a README or some wiki page to keep track >> all this... > > I can throw a readme in the directory with the bug IDs and even my > theory that the DER is 480280. > I didn't find the NSS pre-3.12 check in TestECDH.java? Thanks, Valerie > webrev updated at: > http://cr.openjdk.java.net/~ascarpino/8020424/webrev.01/ > >> Thanks, >> Valerie >> >> On 07/17/13 13:51, Anthony Scarpino wrote: >>> JDK-8020424 The NSS version should be detected before running crypto >>> tests >>> http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ >>> >>> Tony >>> >> > From sundararajan.athijegannathan at oracle.com Wed Jul 24 21:45:09 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 25 Jul 2013 04:45:09 +0000 Subject: hg: jdk8/tl/nashorn: 7 new changesets Message-ID: <20130725044516.6B74148346@hg.openjdk.java.net> Changeset: 8b97fe2b7c98 Author: attila Date: 2013-07-23 18:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8b97fe2b7c98 8021129: Use public lookup again Reviewed-by: lagergren, sundar ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/beans/FacetIntrospector.java - src/jdk/internal/dynalink/beans/SafeUnreflector.java - src/jdk/internal/dynalink/beans/SafeUnreflectorImpl.java - src/jdk/internal/dynalink/beans/SandboxClassLoader.java - src/jdk/internal/dynalink/beans/sandbox/Unreflector.java + test/script/trusted/JDK-8021129.js + test/script/trusted/JDK-8021129.js.EXPECTED + test/src/jdk/nashorn/internal/test/models/InternalRunnable.java + test/src/jdk/nashorn/internal/test/models/RestrictedRunnable.java + test/src/jdk/nashorn/test/models/InternalRunnableSuperclass.java Changeset: a58a07a00122 Author: attila Date: 2013-07-24 11:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a58a07a00122 8021189: Prevent access to constructors of restricted classes Reviewed-by: lagergren, sundar ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/beans/FacetIntrospector.java ! src/jdk/internal/dynalink/beans/StaticClassLinker.java ! test/script/trusted/JDK-8006529.js ! test/script/trusted/JDK-8021129.js + test/script/trusted/JDK-8021189.js + test/script/trusted/JDK-8021189.js.EXPECTED Changeset: e4efb3ce97b2 Author: attila Date: 2013-07-24 12:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e4efb3ce97b2 8021246: Fix regression for 8021189 Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! test/script/trusted/JDK-8006529.js Changeset: 2a25917777f7 Author: hannesw Date: 2013-07-24 13:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2a25917777f7 8020718: RETURN symbol has wrong type in split functions Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/SplitMethodEmitter.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/Symbol.java Changeset: 573cc6eb66ae Author: jlaskey Date: 2013-07-24 08:25 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/573cc6eb66ae Merge - src/jdk/internal/dynalink/beans/SafeUnreflector.java - src/jdk/internal/dynalink/beans/SafeUnreflectorImpl.java - src/jdk/internal/dynalink/beans/SandboxClassLoader.java - src/jdk/internal/dynalink/beans/sandbox/Unreflector.java Changeset: dc54df348a58 Author: sundar Date: 2013-07-24 20:28 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/dc54df348a58 8021262: Make nashorn access checks consistent with underlying dynalink Reviewed-by: jlaskey, lagergren, attila ! make/code_coverage.xml ! src/jdk/nashorn/internal/codegen/SpillObjectCreator.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/NashornLoader.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/Source.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java ! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java ! test/script/sandbox/nashorninternals.js ! test/script/trusted/JDK-8006529.js ! test/script/trusted/JDK-8021129.js ! test/script/trusted/JDK-8021189.js ! test/script/trusted/JDK-8021189.js.EXPECTED ! test/src/jdk/nashorn/test/models/InternalRunnableSuperclass.java Changeset: d203d68f6624 Author: sundar Date: 2013-07-24 21:01 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d203d68f6624 8021294: --verify-code option results in AnalyzerException Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/runtime/Context.java From Xuelei.Fan at Oracle.COM Thu Jul 25 02:11:30 2013 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Thu, 25 Jul 2013 17:11:30 +0800 Subject: Code review request, 8013809 deadlock in SSLSocketImpl between between write and close Message-ID: <51F0EBC2.3050908@Oracle.COM> Hi Brad, Are you available to review this fix? Webrev: http://cr.openjdk.java.net/~xuelei/8013809/webrev.00/ No new regression test, hard to reproduce the issue. Thanks, Xuelei From maurizio.cimadamore at oracle.com Thu Jul 25 06:52:31 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 25 Jul 2013 13:52:31 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20130725135244.67F7B4836A@hg.openjdk.java.net> Changeset: 3155e77d2676 Author: mcimadamore Date: 2013-07-25 14:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3155e77d2676 8020804: javac crashes when speculative attribution infers intersection type with array component Summary: Assertion is causing javac to crash because of lack of support for arrays in intersection types Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/lambda/8020804/T8020804.java Changeset: b02f28bf7f1c Author: mcimadamore Date: 2013-07-25 14:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b02f28bf7f1c 8016081: field initialized with lambda in annotation types doesn't compile Summary: check for annotation attributes should skip over synthetic methods Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/lambda/8016081/T8016081.java Changeset: dae52d74c1fc Author: mcimadamore Date: 2013-07-25 14:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dae52d74c1fc 8020843: javac crashes on accessibility check with method reference with typevar receiver Summary: method reference overload check doesn't walk through type-variable receivers Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/ReportAccessFragment.java + test/tools/javac/lambda/8020843/T8020843a.java + test/tools/javac/lambda/8020843/T8020843a.out + test/tools/javac/lambda/8020843/T8020843b.java + test/tools/javac/lambda/8020843/T8020843b.out ! test/tools/javac/lambda/MethodReference28.out From zhong.j.yu at gmail.com Thu Jul 25 07:15:33 2013 From: zhong.j.yu at gmail.com (Zhong Yu) Date: Thu, 25 Jul 2013 09:15:33 -0500 Subject: TLS extension needed for HTTP/2.0 In-Reply-To: References: Message-ID: Hi, can someone shed some light on the questions? Any information will be greatly appreciated. Thanks, Zhong Yu On Tue, Jul 23, 2013 at 5:41 PM, Zhong Yu wrote: > Hi there, > > HTTP/2.0 draft (based on google's SPDY) requires the use of a new TLS > extension (ALPN), see > http://tools.ietf.org/html/draft-ietf-httpbis-http2-04#section-3.3 > > The current javax.net.ssl API does not support that, so it'll be a > problem for someone trying to implement the HTTP/2.0 draft on Java > platform. Is there a remedy to that? > > If javax.net.ssl needs further development to be able to support ALPN, > would you give a rough estimate on when it could be released? And > would it be back ported to earlier versions of Java? > > What kind of API change do you envision that's necessary to expose > ALPN negotiation process to applications? > > Note that HTTP/2.0 is in very early stage; it's possible that the > requirement of ALPN could be relaxed if there's difficulty to > implement it on popular platforms; see this thread: > http://lists.w3.org/Archives/Public/ietf-http-wg/2013JulSep/0425.html > > Thank you very much, > Zhong Yu From sundararajan.athijegannathan at oracle.com Thu Jul 25 09:21:11 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 25 Jul 2013 16:21:11 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20130725162115.0DB0B4836F@hg.openjdk.java.net> Changeset: 5c035c4ccc61 Author: sundar Date: 2013-07-25 14:05 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5c035c4ccc61 8021252: invokeMethod throws NoSuchMethodException when script object is from different script context Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: f74faac51bfb Author: hannesw Date: 2013-07-25 11:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f74faac51bfb 8021244: Inconsistent stackmap with splitter threshold set very low Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/ir/Block.java Changeset: f22ca0f9b6ee Author: sundar Date: 2013-07-25 20:10 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f22ca0f9b6ee 8021361: ClassCastException:.ScriptObjectMirror -> ScriptObject when getInterface called on object from different ScriptContext Reviewed-by: jlaskey, attila ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java + src/jdk/nashorn/api/scripting/resources/Messages.properties ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java From sean.mullan at oracle.com Thu Jul 25 09:58:17 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Thu, 25 Jul 2013 16:58:17 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130725165931.644E848373@hg.openjdk.java.net> Changeset: a834ab2c1354 Author: mullan Date: 2013-07-25 10:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a834ab2c1354 8010748: Add PKIXRevocationChecker NO_FALLBACK option and improve SOFT_FAIL option Reviewed-by: vinnie ! src/share/classes/java/security/cert/PKIXRevocationChecker.java ! src/share/classes/sun/security/provider/certpath/OCSP.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java ! test/java/security/cert/PKIXRevocationChecker/UnitTest.java Changeset: 22a391706a0b Author: mullan Date: 2013-07-25 11:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/22a391706a0b Merge - make/sun/xawt/ToBin.java - makefiles/sun/awt/X11/ToBin.java - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/java/util/stream/StreamBuilder.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html - src/share/classes/sun/misc/Hashing.java - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java - src/solaris/classes/sun/awt/X11/XIconInfo.java - src/solaris/classes/sun/awt/X11/security-icon-bw16.png - src/solaris/classes/sun/awt/X11/security-icon-bw24.png - src/solaris/classes/sun/awt/X11/security-icon-bw32.png - src/solaris/classes/sun/awt/X11/security-icon-bw48.png - src/solaris/classes/sun/awt/X11/security-icon-interim16.png - src/solaris/classes/sun/awt/X11/security-icon-interim24.png - src/solaris/classes/sun/awt/X11/security-icon-interim32.png - src/solaris/classes/sun/awt/X11/security-icon-interim48.png - src/solaris/classes/sun/awt/X11/security-icon-yellow16.png - src/solaris/classes/sun/awt/X11/security-icon-yellow24.png - src/solaris/classes/sun/awt/X11/security-icon-yellow32.png - src/solaris/classes/sun/awt/X11/security-icon-yellow48.png - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.SuSE.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.properties - test/java/lang/invoke/7196190/MHProxyTest.java - test/java/util/Collections/EmptySortedSet.java - test/java/util/Comparators/BasicTest.java - test/sun/misc/Hashing.java - test/sun/security/krb5/auto/ReplayCache.java From joe.darcy at oracle.com Thu Jul 25 10:00:14 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 25 Jul 2013 17:00:14 +0000 Subject: hg: jdk8/tl/jdk: 8021408: Fix misc doclint issues in java.util and java.io Message-ID: <20130725170036.1CC8A48374@hg.openjdk.java.net> Changeset: 21120e3682ef Author: darcy Date: 2013-07-25 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21120e3682ef 8021408: Fix misc doclint issues in java.util and java.io Reviewed-by: dholmes, chegar, psandoz ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/jar/JarEntry.java ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/stream/StreamSupport.java From chris.hegarty at oracle.com Thu Jul 25 11:39:28 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 25 Jul 2013 18:39:28 +0000 Subject: hg: jdk8/tl/jdk: 8021417: Fix doclint issues in java.util.concurrent Message-ID: <20130725183956.0B76E48382@hg.openjdk.java.net> Changeset: 690dcbaa69b7 Author: chegar Date: 2013-07-25 19:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/690dcbaa69b7 8021417: Fix doclint issues in java.util.concurrent Reviewed-by: chegar, lancea Contributed-by: Doug Lea
    ! src/share/classes/java/util/concurrent/AbstractExecutorService.java ! src/share/classes/java/util/concurrent/ExecutorService.java ! src/share/classes/java/util/concurrent/Executors.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ScheduledExecutorService.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/TimeUnit.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java From chris.hegarty at oracle.com Thu Jul 25 11:45:59 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 25 Jul 2013 18:45:59 +0000 Subject: hg: jdk8/tl/jdk: 8021421: More doclint fixes in java.net Message-ID: <20130725184635.1F4FD48383@hg.openjdk.java.net> Changeset: 9cd5159fa870 Author: chegar Date: 2013-07-25 19:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cd5159fa870 8021421: More doclint fixes in java.net Reviewed-by: lancea, darcy ! src/share/classes/java/net/URI.java From joel.franck at oracle.com Thu Jul 25 02:27:41 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Thu, 25 Jul 2013 09:27:41 +0000 Subject: hg: jdk8/tl/langtools: 8007961: javax.lang.model tests for repeating annotations fail in getAnnotationsByType Message-ID: <20130725092748.37DDC4834F@hg.openjdk.java.net> Changeset: a218f7befd55 Author: jfranck Date: 2013-07-25 11:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a218f7befd55 8007961: javax.lang.model tests for repeating annotations fail in getAnnotationsByType Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/model/JavacAnnoConstructs.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA1Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB1Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB2Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideATest.java ! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideBTest.java + test/tools/javac/processing/model/inheritedByType/EnsureOrder.java From sean.mullan at oracle.com Thu Jul 25 12:28:19 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 25 Jul 2013 15:28:19 -0400 Subject: [8] Request for review: 8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo In-Reply-To: <51EFE1C6.4010408@Oracle.COM> References: <51EE7F93.3070200@oracle.com> <51EFE1C6.4010408@Oracle.COM> Message-ID: <51F17C53.1060902@oracle.com> On 07/24/2013 10:16 AM, Xuelei Fan wrote: > DOMUtils.java > ============= > It might be a little bit better to reuse the node local name checking > with a new private static method. Good suggestion. > Otherwise, looks fine. > > A minor comment is a very personal preference. I may prefer to return > null instead of throw exception in the new methods of class DOMUtils, > when there is no such node. And the caller throw the exception instead. > For example: > public static Element getFirstChildElement(Node node, > String localName) throws MarshalException I considered that, but most of the time null is an exception, so it's more concise to have the method handle this case, than the other way around. I have updated the webrev: http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.01/ Can you take a quick look at DOMUtils to see if it looks ok? Thanks, Sean > > > Xuelei > > On 7/23/2013 9:05 PM, Sean Mullan wrote: >> Xuelei, >> >> Could you please review my fix for 8012288: >> >> http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.00/ >> >> There is already an SQE test for this, so I have added the noreg-sqe >> label. >> >> Thanks, >> Sean > From huizhe.wang at oracle.com Thu Jul 25 13:08:49 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Thu, 25 Jul 2013 20:08:49 +0000 Subject: hg: jdk8/tl/jaxp: 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE) Message-ID: <20130725200856.A53EC4839E@hg.openjdk.java.net> Changeset: 251ca1e2ccd3 Author: joehw Date: 2013-07-25 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/251ca1e2ccd3 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE) Reviewed-by: chegar, lancea, dfuchs ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java From huizhe.wang at oracle.com Thu Jul 25 13:20:59 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Thu, 25 Jul 2013 20:20:59 +0000 Subject: hg: jdk8/tl/jdk: 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE) Message-ID: <20130725202149.07ABC483A0@hg.openjdk.java.net> Changeset: 662ec7782102 Author: joehw Date: 2013-07-25 13:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/662ec7782102 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE) Reviewed-by: chegar, lancea, dfuchs + test/javax/xml/jaxp/parsers/8021148/JAXPSAXParserTest.java + test/javax/xml/jaxp/parsers/8021148/TestBase.java From bernd-2013 at eckenfels.net Thu Jul 25 14:06:12 2013 From: bernd-2013 at eckenfels.net (Bernd Eckenfels) Date: Thu, 25 Jul 2013 23:06:12 +0200 Subject: TLS extension needed for HTTP/2.0 In-Reply-To: References: Message-ID: Hello, no direct response, but just a pointer: there is a third party Project by Ben Murphy which brings NPN to JSSE. I guess the same codebase can be used to add ALPN. This will allow to do experiments. https://github.com/benmmurphy/ssl_npn It is btw very unfortunate that there is no clear SPI for SSLSocket and the java package namespace makes it necesary to actually touch all classes to get them compiled in parallel to a normal JDK. Gruss Bernd Am 25.07.2013, 16:15 Uhr, schrieb Zhong Yu : > Hi, can someone shed some light on the questions? Any information will > be greatly appreciated. Thanks, > Zhong Yu > > On Tue, Jul 23, 2013 at 5:41 PM, Zhong Yu wrote: >> Hi there, >> >> HTTP/2.0 draft (based on google's SPDY) requires the use of a new TLS >> extension (ALPN), see >> http://tools.ietf.org/html/draft-ietf-httpbis-http2-04#section-3.3 >> >> The current javax.net.ssl API does not support that, so it'll be a >> problem for someone trying to implement the HTTP/2.0 draft on Java >> platform. Is there a remedy to that? >> >> If javax.net.ssl needs further development to be able to support ALPN, >> would you give a rough estimate on when it could be released? And >> would it be back ported to earlier versions of Java? >> >> What kind of API change do you envision that's necessary to expose >> ALPN negotiation process to applications? >> >> Note that HTTP/2.0 is in very early stage; it's possible that the >> requirement of ALPN could be relaxed if there's difficulty to >> implement it on popular platforms; see this thread: >> http://lists.w3.org/Archives/Public/ietf-http-wg/2013JulSep/0425.html >> >> Thank you very much, >> Zhong Yu -- http://bernd.eckenfels.net From sean.mullan at oracle.com Thu Jul 25 14:08:11 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 25 Jul 2013 17:08:11 -0400 Subject: [8] Request for review: 8001319: Add SecurityPermission "insertProvider" target name Message-ID: <51F193BB.9030206@oracle.com> Hello, Could you please review my fix for 8001319: webrev: http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.00/ bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001319 In this fix, we are adding a new SecurityPermission "insertProvider" target name for adding new security providers, and discouraging use of the existing "insertProvider.{provider name}" target name. Please read the bug report for more information. Thanks, Sean From anthony.scarpino at oracle.com Thu Jul 25 15:17:00 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Thu, 25 Jul 2013 15:17:00 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51F08165.7020504@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> <51E703D0.4090505@oracle.com> <51EF271E.80509@oracle.com> <51F03EC0.6070800@oracle.com> <51F08165.7020504@oracle.com> Message-ID: <51F1A3DC.2030105@oracle.com> On 07/24/2013 06:37 PM, Valerie (Yu-Ching) Peng wrote: > On 07/24/13 13:53, Anthony Scarpino wrote: >> On 07/23/2013 06:00 PM, Valerie (Yu-Ching) Peng wrote: >>> >>> >>> >>> 263 System.arraycopy(data, 900, data, 0, 100); >>> 264 is.read(data, 0, 900); >>> >>> Do you really mean to overwrite the data[0..99] that you just copied on >>> line 263 with line 264? >> >> >> Good catch.. I would have thought all my testing would have tripped me >> up on this, but it appears it didn't. >> >>> In addition, don't you want to know how much is read in order to exclude >>> the data from earlier read(...) calls in case that the current read only >>> returns a few bytes? >> >> Yeah, the end of the file read is a bit sloppy, even though it should >> never see the end of the file as all the nss libraries have the header >> in it. > > Hmm, I think the String object should be constructed w/ the bytes that's > just read, i.e. new String(data, 0, read) > > 256 s = new String(data); > > And line 272 should be update to "read = 100 + is.read(data, 100, 900);" > Also, the value of variable s is only set once on line 256 and yet the > content of 'data' may change on line 271-272. This may lead to > inconsistency between 's' and 'data' if the while-loop (line 255) is > exited due to read <= 0 on line 272. I wasn't overly concerned about what happens at the end of the file because it shouldn't get to that point. There should always be a header and if one was not found, the check has for the most part failed. 'data' is not used outside the loop, so any inconsistency with the String isn't a problem. That being said, I'm fine with changing it. I couldn't add 100 to the read because the while-loop looks for read to equal 0, and the inconsistency on the read length made the original code troublesome, so I rewrote it and I think it looks cleaner now. http://cr.openjdk.java.net/~ascarpino/8020424/webrev.02/ >>> >>> After seeing all these checks and list of known bugs for testing against >>> NSS, I think we probably need a README or some wiki page to keep track >>> all this... >> >> I can throw a readme in the directory with the bug IDs and even my >> theory that the DER is 480280. >> > I didn't find the NSS pre-3.12 check in TestECDH.java? Yeah, that one has a different check. I'll remove it from that comment. > Thanks, > Valerie > >> webrev updated at: >> http://cr.openjdk.java.net/~ascarpino/8020424/webrev.01/ >> >>> Thanks, >>> Valerie >>> >>> On 07/17/13 13:51, Anthony Scarpino wrote: >>>> JDK-8020424 The NSS version should be detected before running crypto >>>> tests >>>> http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ >>>> >>>> Tony >>>> >>> >> > From rajan.halade at oracle.com Thu Jul 25 15:17:04 2013 From: rajan.halade at oracle.com (Rajan Halade) Date: Thu, 25 Jul 2013 15:17:04 -0700 Subject: Code Review Request:8019544: Need to run ProviderTest.java in othervm mode Message-ID: <51F1A3E0.3000606@oracle.com> Could you please review the small fix for 8019544: http://cr.openjdk.java.net/~juh/rajan/8019544/webrev.00/ This is a test only fix for test stabilization. -- Rajan Halade, CISSP | Senior Member of Technical Staff Phone: +1 4082763359 Oracle JAVA Platform Group 4220 Network Circle, Bldg 22, #2155 | Santa Clara, CA 94538 Oracle is committed to developing practices and products that help protect the environment -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130725/e607374a/attachment.html From bradford.wetmore at oracle.com Thu Jul 25 15:32:17 2013 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Thu, 25 Jul 2013 15:32:17 -0700 Subject: Code Review Request:8019544: Need to run ProviderTest.java in othervm mode In-Reply-To: <51F1A3E0.3000606@oracle.com> References: <51F1A3E0.3000606@oracle.com> Message-ID: <51F1A771.9090300@oracle.com> Looks good. brad On 7/25/2013 3:17 PM, Rajan Halade wrote: > Could you please review the small fix for 8019544: > > http://cr.openjdk.java.net/~juh/rajan/8019544/webrev.00/ > > > This is a test only fix for test stabilization. > > -- > Rajan Halade, CISSP | Senior Member of Technical > Staff > Phone: +1 4082763359 > Oracle JAVA Platform Group > 4220 Network Circle, Bldg 22, #2155 | Santa Clara, CA 94538 > Oracle is committed to developing > practices and products that help protect the environment From Xuelei.Fan at Oracle.COM Thu Jul 25 15:42:03 2013 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Fri, 26 Jul 2013 06:42:03 +0800 Subject: [8] Request for review: 8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo In-Reply-To: <51F17C53.1060902@oracle.com> References: <51EE7F93.3070200@oracle.com> <51EFE1C6.4010408@Oracle.COM> <51F17C53.1060902@oracle.com> Message-ID: <51F1A9BB.6060805@Oracle.COM> On 7/26/2013 3:28 AM, Sean Mullan wrote: > On 07/24/2013 10:16 AM, Xuelei Fan wrote: >> DOMUtils.java >> ============= >> It might be a little bit better to reuse the node local name checking >> with a new private static method. > > Good suggestion. > >> Otherwise, looks fine. >> >> A minor comment is a very personal preference. I may prefer to return >> null instead of throw exception in the new methods of class DOMUtils, >> when there is no such node. And the caller throw the exception instead. >> For example: >> public static Element getFirstChildElement(Node node, >> String localName) throws MarshalException > > I considered that, but most of the time null is an exception, so it's > more concise to have the method handle this case, than the other way > around. > ok. > I have updated the webrev: > http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.01/ > > Can you take a quick look at DOMUtils to see if it looks ok? > Looks fine to me. Xuelei > Thanks, > Sean > >> >> >> Xuelei >> >> On 7/23/2013 9:05 PM, Sean Mullan wrote: >>> Xuelei, >>> >>> Could you please review my fix for 8012288: >>> >>> http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.00/ >>> >>> There is already an SQE test for this, so I have added the noreg-sqe >>> label. >>> >>> Thanks, >>> Sean >> > From Xuelei.Fan at Oracle.COM Thu Jul 25 15:45:25 2013 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Fri, 26 Jul 2013 06:45:25 +0800 Subject: Code Review Request:8019544: Need to run ProviderTest.java in othervm mode In-Reply-To: <51F1A3E0.3000606@oracle.com> References: <51F1A3E0.3000606@oracle.com> Message-ID: <51F1AA85.6080303@Oracle.COM> Looks fine to me. Thanks! Xuelei On 7/26/2013 6:17 AM, Rajan Halade wrote: > Could you please review the small fix for 8019544: > > http://cr.openjdk.java.net/~juh/rajan/8019544/webrev.00/ > > > This is a test only fix for test stabilization. > > -- > Rajan Halade, CISSP | Senior Member of Technical > Staff > Phone: +1 4082763359 > Oracle JAVA Platform Group > 4220 Network Circle, Bldg 22, #2155 | Santa Clara, CA 94538 > Oracle is committed to developing > practices and products that help protect the environment From Xuelei.Fan at Oracle.COM Thu Jul 25 16:47:34 2013 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Fri, 26 Jul 2013 07:47:34 +0800 Subject: TLS extension needed for HTTP/2.0 In-Reply-To: References: Message-ID: <51F1B916.9010702@Oracle.COM> On 7/24/2013 6:41 AM, Zhong Yu wrote: > Hi there, > > HTTP/2.0 draft (based on google's SPDY) requires the use of a new TLS > extension (ALPN), see > http://tools.ietf.org/html/draft-ietf-httpbis-http2-04#section-3.3 > > The current javax.net.ssl API does not support that, so it'll be a > problem for someone trying to implement the HTTP/2.0 draft on Java > platform. Is there a remedy to that? > Both HTTP 2.0 and ALPN extension are in early stage. Java does not support ALPN at present. But for a none-product environment, it is doable with a few update to OpenJDK by making use of the handshaking session. > If javax.net.ssl needs further development to be able to support ALPN, > would you give a rough estimate on when it could be released? And > would it be back ported to earlier versions of Java? > Looks like, to support ALPN, javax.net.ssl needs to design new APIs. As make it hard to backport to earlier releases of Java. Marketing and customer requirements are important factors when we design new features. > What kind of API change do you envision that's necessary to expose > ALPN negotiation process to applications? > I have no think about this too much. Probably, we might only need pulic APIs to expose the ALPN in handshaking session (SSLSession), and an handler to accept or reject the request (or have TrustManager do it instead). SSLSocket.getHandshakeSession() ExtendedSSLSession.getAppProtocols() > Note that HTTP/2.0 is in very early stage; it's possible that the > requirement of ALPN could be relaxed if there's difficulty to > implement it on popular platforms; see this thread: > http://lists.w3.org/Archives/Public/ietf-http-wg/2013JulSep/0425.html > I have not read this thread. Is there any one suggest to use START TLS as an alternative solution? Xuelei > Thank you very much, > Zhong Yu > From sean.mullan at oracle.com Thu Jul 25 17:33:53 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 25 Jul 2013 20:33:53 -0400 Subject: [8] Request for review: 8001319: Add SecurityPermission "insertProvider" target name In-Reply-To: <51F193BB.9030206@oracle.com> References: <51F193BB.9030206@oracle.com> Message-ID: <51F1C3F1.6040305@oracle.com> On 07/25/2013 05:08 PM, Sean Mullan wrote: > Hello, > > Could you please review my fix for 8001319: > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.00/ Correction above webrev: http://cr.openjdk.java.net/~mullan/webrevs/8001319/webrev.00/ > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001319 > > In this fix, we are adding a new SecurityPermission "insertProvider" > target name for adding new security providers, and discouraging use of > the existing "insertProvider.{provider name}" target name. Please read > the bug report for more information. > > Thanks, > Sean From valerie.peng at oracle.com Thu Jul 25 17:45:04 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Thu, 25 Jul 2013 17:45:04 -0700 Subject: code review request: 8012971 PKCS11Test hiding exception failures In-Reply-To: <51F1A3DC.2030105@oracle.com> References: <51C891D6.1080401@oracle.com> <51DE054F.10303@oracle.com> <51DE3B05.4090202@oracle.com> <51DEEF8C.4010604@oracle.com> <51E703D0.4090505@oracle.com> <51EF271E.80509@oracle.com> <51F03EC0.6070800@oracle.com> <51F08165.7020504@oracle.com> <51F1A3DC.2030105@oracle.com> Message-ID: <51F1C690.4050500@oracle.com> Looks good~ Thanks, Valerie On 07/25/13 15:17, Anthony Scarpino wrote: > On 07/24/2013 06:37 PM, Valerie (Yu-Ching) Peng wrote: >> On 07/24/13 13:53, Anthony Scarpino wrote: >>> On 07/23/2013 06:00 PM, Valerie (Yu-Ching) Peng wrote: >>>> >>>> >>>> >>>> 263 System.arraycopy(data, 900, data, 0, 100); >>>> 264 is.read(data, 0, 900); >>>> >>>> Do you really mean to overwrite the data[0..99] that you just >>>> copied on >>>> line 263 with line 264? >>> >>> >>> Good catch.. I would have thought all my testing would have tripped me >>> up on this, but it appears it didn't. >>> >>>> In addition, don't you want to know how much is read in order to >>>> exclude >>>> the data from earlier read(...) calls in case that the current read >>>> only >>>> returns a few bytes? >>> >>> Yeah, the end of the file read is a bit sloppy, even though it should >>> never see the end of the file as all the nss libraries have the header >>> in it. >> >> Hmm, I think the String object should be constructed w/ the bytes that's >> just read, i.e. new String(data, 0, read) >> >> 256 s = new String(data); >> >> And line 272 should be update to "read = 100 + is.read(data, 100, 900);" >> Also, the value of variable s is only set once on line 256 and yet the >> content of 'data' may change on line 271-272. This may lead to >> inconsistency between 's' and 'data' if the while-loop (line 255) is >> exited due to read <= 0 on line 272. > > I wasn't overly concerned about what happens at the end of the file > because it shouldn't get to that point. There should always be a > header and if one was not found, the check has for the most part failed. > 'data' is not used outside the loop, so any inconsistency with the > String isn't a problem. > > That being said, I'm fine with changing it. I couldn't add 100 to the > read because the while-loop looks for read to equal 0, and the > inconsistency on the read length made the original code troublesome, > so I rewrote it and I think it looks cleaner now. > > http://cr.openjdk.java.net/~ascarpino/8020424/webrev.02/ > >>>> >>>> After seeing all these checks and list of known bugs for testing >>>> against >>>> NSS, I think we probably need a README or some wiki page to keep track >>>> all this... >>> >>> I can throw a readme in the directory with the bug IDs and even my >>> theory that the DER is 480280. >>> >> I didn't find the NSS pre-3.12 check in TestECDH.java? > > Yeah, that one has a different check. I'll remove it from that comment. > >> Thanks, >> Valerie >> >>> webrev updated at: >>> http://cr.openjdk.java.net/~ascarpino/8020424/webrev.01/ >>> >>>> Thanks, >>>> Valerie >>>> >>>> On 07/17/13 13:51, Anthony Scarpino wrote: >>>>> JDK-8020424 The NSS version should be detected before running crypto >>>>> tests >>>>> http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ >>>>> >>>>> Tony >>>>> >>>> >>> >> > From sean.mullan at oracle.com Thu Jul 25 18:04:39 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Fri, 26 Jul 2013 01:04:39 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130726010515.80F4D483B6@hg.openjdk.java.net> Changeset: 1744a32d3db3 Author: mullan Date: 2013-07-25 20:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1744a32d3db3 8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo Reviewed-by: xuelei ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyValue.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509IssuerSerial.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java Changeset: 4100ab44ba4f Author: mullan Date: 2013-07-25 20:30 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4100ab44ba4f Merge From joe.darcy at oracle.com Thu Jul 25 20:03:44 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 26 Jul 2013 03:03:44 +0000 Subject: hg: jdk8/tl/jdk: 8021429: Fix lint warnings in java.lang.ref Message-ID: <20130726030410.E8ADB483BC@hg.openjdk.java.net> Changeset: 86a827321c39 Author: darcy Date: 2013-07-25 20:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86a827321c39 8021429: Fix lint warnings in java.lang.ref Reviewed-by: lancea, mduigou, alanb ! src/share/classes/java/lang/ref/FinalReference.java ! src/share/classes/java/lang/ref/Finalizer.java ! src/share/classes/java/lang/ref/Reference.java ! src/share/classes/java/lang/ref/ReferenceQueue.java From yuka.kamiya at oracle.com Fri Jul 26 01:23:33 2013 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Fri, 26 Jul 2013 08:23:33 +0000 Subject: hg: jdk8/tl/jdk: 8021108: Clean up doclint warnings and errors in java.text package Message-ID: <20130726082414.DB45D483C7@hg.openjdk.java.net> Changeset: 6cc15a808b93 Author: peytoia Date: 2013-07-26 17:22 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cc15a808b93 8021108: Clean up doclint warnings and errors in java.text package Reviewed-by: darcy, okutsu ! src/share/classes/java/text/Annotation.java ! src/share/classes/java/text/AttributedCharacterIterator.java ! src/share/classes/java/text/Bidi.java ! src/share/classes/java/text/BreakIterator.java ! src/share/classes/java/text/ChoiceFormat.java ! src/share/classes/java/text/CollationElementIterator.java ! src/share/classes/java/text/CollationKey.java ! src/share/classes/java/text/DateFormat.java ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/DecimalFormatSymbols.java ! src/share/classes/java/text/FieldPosition.java ! src/share/classes/java/text/Format.java ! src/share/classes/java/text/MessageFormat.java ! src/share/classes/java/text/Normalizer.java ! src/share/classes/java/text/NumberFormat.java ! src/share/classes/java/text/ParseException.java ! src/share/classes/java/text/ParsePosition.java ! src/share/classes/java/text/RuleBasedCollator.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/text/StringCharacterIterator.java From vincent.x.ryan at oracle.com Fri Jul 26 02:28:15 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 26 Jul 2013 10:28:15 +0100 Subject: Code Review Request:8019544: Need to run ProviderTest.java in othervm mode In-Reply-To: <51F1A3E0.3000606@oracle.com> References: <51F1A3E0.3000606@oracle.com> Message-ID: <5AA75119-469D-4123-B592-72AB8E60D3D0@oracle.com> Your fix looks fine. On 25 Jul 2013, at 23:17, Rajan Halade wrote: > Could you please review the small fix for 8019544: > > http://cr.openjdk.java.net/~juh/rajan/8019544/webrev.00/ > > This is a test only fix for test stabilization. > > -- > Rajan Halade, CISSP | Senior Member of Technical Staff > Phone: +1 4082763359 > Oracle JAVA Platform Group > 4220 Network Circle, Bldg 22, #2155 | Santa Clara, CA 94538 > Oracle is committed to developing practices and products that help protect the environment -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130726/6b77cf31/attachment-0001.html From vincent.x.ryan at oracle.com Fri Jul 26 06:52:20 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 26 Jul 2013 14:52:20 +0100 Subject: [8] Request for review: 8001319: Add SecurityPermission "insertProvider" target name In-Reply-To: <51F1C3F1.6040305@oracle.com> References: <51F193BB.9030206@oracle.com> <51F1C3F1.6040305@oracle.com> Message-ID: <31F88156-DE91-4BA3-B3C2-63D16BDC7C75@oracle.com> Your fix looks good. On 26 Jul 2013, at 01:33, Sean Mullan wrote: > On 07/25/2013 05:08 PM, Sean Mullan wrote: >> Hello, >> >> Could you please review my fix for 8001319: >> >> webrev: http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.00/ > > Correction above > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/8001319/webrev.00/ > >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001319 >> >> In this fix, we are adding a new SecurityPermission "insertProvider" >> target name for adding new security providers, and discouraging use of >> the existing "insertProvider.{provider name}" target name. Please read >> the bug report for more information. >> >> Thanks, >> Sean > From jaroslav.bachorik at oracle.com Fri Jul 26 01:37:20 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Fri, 26 Jul 2013 08:37:20 +0000 Subject: hg: jdk8/tl/jdk: 8020875: java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently Message-ID: <20130726083758.10299483C9@hg.openjdk.java.net> Changeset: 952476b80fa7 Author: jbachorik Date: 2013-07-26 10:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/952476b80fa7 8020875: java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently Reviewed-by: dfuchs, chegar ! test/java/lang/management/ThreadMXBean/ResetPeakThreadCount.java From jason.uh at oracle.com Fri Jul 26 14:17:52 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Fri, 26 Jul 2013 21:17:52 +0000 Subject: hg: jdk8/tl/jdk: 8019544: Need to run ProviderTest.java in othervm mode. Message-ID: <20130726211833.668D6483EC@hg.openjdk.java.net> Changeset: 7ae061cfd4be Author: juh Date: 2013-07-26 14:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ae061cfd4be 8019544: Need to run ProviderTest.java in othervm mode. Reviewed-by: wetmore, xuelei, vinnie Contributed-by: rajan.halade at oracle.com ! test/sun/security/ssl/com/sun/net/ssl/SSLSecurity/ProviderTest.java From lana.steuck at oracle.com Fri Jul 26 15:18:33 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 26 Jul 2013 22:18:33 +0000 Subject: hg: jdk8/tl/hotspot: 15 new changesets Message-ID: <20130726221912.4DA9A483F6@hg.openjdk.java.net> Changeset: dc8afa03e5c9 Author: katleman Date: 2013-07-11 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dc8afa03e5c9 8020414: JDK8 b98 source with GPL header errors Reviewed-by: darcy, lancea, iris ! test/runtime/8001071/Test8001071.sh Changeset: 1c474723a324 Author: katleman Date: 2013-07-11 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1c474723a324 Merge Changeset: 81b6cb70717c Author: katleman Date: 2013-07-16 15:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/81b6cb70717c Merge Changeset: bb416ee2a79b Author: cl Date: 2013-07-18 03:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bb416ee2a79b Added tag jdk8-b99 for changeset 81b6cb70717c ! .hgtags Changeset: bd1dc81da579 Author: amurillo Date: 2013-07-12 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bd1dc81da579 8020382: new hotspot build - hs25-b42 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f4311079200c Author: brutisso Date: 2013-07-11 11:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f4311079200c 8020155: PSR:PERF G1 not collecting old regions when humongous allocations interfer Summary: Take _last_young_gc into account when deciding on starting a concurrent mark. Also reviewed-by: per.liden at oracle.com. Reviewed-by: tschatzl, johnc ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: e7a47f226600 Author: tamao Date: 2013-07-15 15:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e7a47f226600 Merge - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp Changeset: 980532a806a5 Author: goetz Date: 2013-06-20 15:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/980532a806a5 8016697: Use stubs to implement safefetch Summary: Implement Safefetch as stub routines. This reduces compiler and os dependencies. Reviewed-by: twisti, kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/bsd_x86_32.s ! src/os_cpu/bsd_x86/vm/bsd_x86_64.s ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/linux_sparc.s ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/linux_x86_32.s ! src/os_cpu/linux_x86/vm/linux_x86_64.s ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/solaris_sparc.s ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/solaris_x86_32.s ! src/os_cpu/solaris_x86/vm/solaris_x86_64.s ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: a74ec8831c7b Author: clucasius Date: 2013-07-15 12:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a74ec8831c7b Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/os.hpp Changeset: 16b10327b00d Author: jprovino Date: 2013-07-16 10:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/16b10327b00d 8011569: ARM -- avoid native stack walking Summary: ARM compilers do not emit FramePointer on each native frame by default Reviewed-by: dholmes, zgu ! make/linux/makefiles/vm.make ! src/share/vm/services/memTracker.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 90d6c221d4e5 Author: jprovino Date: 2013-07-16 12:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/90d6c221d4e5 Merge ! make/linux/makefiles/vm.make - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp ! src/share/vm/services/memTracker.cpp - src/share/vm/trace/traceEventTypes.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 9d18d92e54b5 Author: clucasius Date: 2013-07-18 00:52 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9d18d92e54b5 Merge Changeset: 9f71e36a471a Author: amurillo Date: 2013-07-18 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9f71e36a471a Merge Changeset: 5787fac72e76 Author: amurillo Date: 2013-07-18 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5787fac72e76 Added tag hs25-b42 for changeset 9f71e36a471a ! .hgtags Changeset: 9d7b55c8a0c4 Author: cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9d7b55c8a0c4 Added tag jdk8-b100 for changeset 5787fac72e76 ! .hgtags From lana.steuck at oracle.com Fri Jul 26 15:18:15 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 26 Jul 2013 22:18:15 +0000 Subject: hg: jdk8/tl/langtools: 5 new changesets Message-ID: <20130726221844.A957B483F5@hg.openjdk.java.net> Changeset: 6d85acab769e Author: mcimadamore Date: 2013-07-17 19:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6d85acab769e 8013638: Few policy tests are failing in Lambda nightly Summary: BridgeHarness test is leaving files open Reviewed-by: ksrini ! test/tools/javac/generics/bridges/BridgeHarness.java Changeset: e73f00139fb5 Author: cl Date: 2013-07-18 03:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e73f00139fb5 Added tag jdk8-b99 for changeset 6d85acab769e ! .hgtags Changeset: 82f68da70e47 Author: lana Date: 2013-07-22 17:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/82f68da70e47 Merge - test/tools/javac/generics/6723444/T6723444.out - test/tools/javac/generics/7015430/T7015430.out Changeset: 0324dbf07b0f Author: cl Date: 2013-07-25 03:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0324dbf07b0f Added tag jdk8-b100 for changeset 82f68da70e47 ! .hgtags Changeset: 37048aa3ac19 Author: lana Date: 2013-07-26 14:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37048aa3ac19 Merge From lana.steuck at oracle.com Fri Jul 26 15:18:14 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 26 Jul 2013 22:18:14 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20130726221822.F3C45483F3@hg.openjdk.java.net> Changeset: 10503ced6cc2 Author: cl Date: 2013-07-18 03:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/10503ced6cc2 Added tag jdk8-b99 for changeset 10a1ab9e20a4 ! .hgtags Changeset: 598321c438b5 Author: lana Date: 2013-07-22 17:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/598321c438b5 Merge - src/jdk/nashorn/internal/ir/ExecuteNode.java - test/script/currently-failing/JDK-8006529.js Changeset: a302b05d0ee4 Author: cl Date: 2013-07-25 03:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a302b05d0ee4 Added tag jdk8-b100 for changeset 598321c438b5 ! .hgtags Changeset: d55856f82352 Author: lana Date: 2013-07-26 14:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d55856f82352 Merge From lana.steuck at oracle.com Fri Jul 26 15:18:01 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 26 Jul 2013 22:18:01 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20130726221818.6CB78483F2@hg.openjdk.java.net> Changeset: 4fd722afae5c Author: cl Date: 2013-07-18 03:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/4fd722afae5c Added tag jdk8-b99 for changeset 8ef83d4b23c9 ! .hgtags Changeset: 60b623a36164 Author: cl Date: 2013-07-25 03:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/60b623a36164 Added tag jdk8-b100 for changeset 4fd722afae5c ! .hgtags From lana.steuck at oracle.com Fri Jul 26 15:18:02 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 26 Jul 2013 22:18:02 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20130726221808.52A5D483F1@hg.openjdk.java.net> Changeset: 8d492f1dfd1b Author: cl Date: 2013-07-18 03:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/8d492f1dfd1b Added tag jdk8-b99 for changeset 3f67804ab613 ! .hgtags Changeset: a013024b0747 Author: cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a013024b0747 Added tag jdk8-b100 for changeset 8d492f1dfd1b ! .hgtags From lana.steuck at oracle.com Fri Jul 26 15:18:01 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 26 Jul 2013 22:18:01 +0000 Subject: hg: jdk8/tl: 2 new changesets Message-ID: <20130726221803.289C8483F0@hg.openjdk.java.net> Changeset: d2dcb110e9db Author: cl Date: 2013-07-18 03:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d2dcb110e9db Added tag jdk8-b99 for changeset 59dc9da81379 ! .hgtags Changeset: 9f74a220677d Author: cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9f74a220677d Added tag jdk8-b100 for changeset d2dcb110e9db ! .hgtags From lana.steuck at oracle.com Fri Jul 26 15:18:06 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 26 Jul 2013 22:18:06 +0000 Subject: hg: jdk8/tl/jaxp: 4 new changesets Message-ID: <20130726221828.4E289483F4@hg.openjdk.java.net> Changeset: 043da456d316 Author: cl Date: 2013-07-18 03:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/043da456d316 Added tag jdk8-b99 for changeset adf49c3ef83c ! .hgtags Changeset: 5d1974c1d7b9 Author: lana Date: 2013-07-22 17:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5d1974c1d7b9 Merge Changeset: 0a7432f898e5 Author: cl Date: 2013-07-25 03:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0a7432f898e5 Added tag jdk8-b100 for changeset 5d1974c1d7b9 ! .hgtags Changeset: 467e1948612d Author: lana Date: 2013-07-26 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/467e1948612d Merge From lana.steuck at oracle.com Fri Jul 26 15:21:35 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 26 Jul 2013 22:21:35 +0000 Subject: hg: jdk8/tl/jdk: 26 new changesets Message-ID: <20130726223123.DF0AD483F8@hg.openjdk.java.net> Changeset: 56bc019a0525 Author: katleman Date: 2013-07-11 14:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56bc019a0525 8020414: JDK8 b98 source with GPL header errors Reviewed-by: darcy, lancea, iris ! test/sun/security/krb5/auto/NoneReplayCacheTest.java Changeset: 030d1ca7432f Author: katleman Date: 2013-07-11 14:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/030d1ca7432f Merge Changeset: 6a099a36589b Author: katleman Date: 2013-07-16 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a099a36589b Merge Changeset: 9b6070690e50 Author: cl Date: 2013-07-18 03:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b6070690e50 Added tag jdk8-b99 for changeset 6a099a36589b ! .hgtags Changeset: cacfc77655c8 Author: serb Date: 2013-07-03 19:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cacfc77655c8 8004859: Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform Reviewed-by: prr, flar ! src/share/classes/sun/java2d/SunGraphics2D.java + test/java/awt/Graphics2D/Test8004859/Test8004859.java Changeset: 75844b444879 Author: jchen Date: 2013-07-03 10:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75844b444879 8014497: [parfait] Potential null pointer dereference in jdk/src/share/native/sun/java2d/cmm/lcms/cmsgamma.c Reviewed-by: bae, prr ! src/share/native/sun/java2d/cmm/lcms/cmsopt.c Changeset: d32757b7060c Author: lana Date: 2013-07-05 12:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d32757b7060c Merge - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java - test/java/util/Comparators/BasicTest.java - test/sun/security/krb5/auto/ReplayCache.java Changeset: dead66347eca Author: jgodinez Date: 2013-07-10 11:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dead66347eca 8016737: After clicking on "Print UNCOLLATED" button, the print out come in order 'Page 1', 'Page 2', 'Page 1' Reviewed-by: jchen, prr ! src/solaris/classes/sun/print/IPPPrintService.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: fabcccc003d2 Author: lana Date: 2013-07-17 12:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fabcccc003d2 Merge Changeset: f41758d12409 Author: alitvinov Date: 2013-07-04 16:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f41758d12409 8015730: PIT: On Linux, OGL=true and fbobject=false leads to deadlock or infinite loop Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java ! src/solaris/native/sun/awt/awt_util.h ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c Changeset: 523815540788 Author: lana Date: 2013-07-05 11:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/523815540788 Merge - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java - test/java/util/Comparators/BasicTest.java - test/sun/security/krb5/auto/ReplayCache.java Changeset: b7cbad879d63 Author: leonidr Date: 2013-07-08 19:47 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7cbad879d63 8019265: [macosx] apple.laf.useScreenMenuBar regression comparing with jdk6 Reviewed-by: anthony ! src/macosx/native/sun/awt/CMenuItem.m ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java Changeset: 7e291fc61cad Author: malenkov Date: 2013-07-09 18:01 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7e291fc61cad 6707231: Wrong read Method returned for boolen properties Reviewed-by: alexsch ! src/share/classes/java/beans/Introspector.java + test/java/beans/Introspector/Test6707231.java Changeset: e7ca6e259dc2 Author: serb Date: 2013-07-09 21:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7ca6e259dc2 8019587: [macosx] Possibility to set the same frame for the different screens Reviewed-by: art, anthony ! src/share/classes/java/awt/GraphicsDevice.java + test/java/awt/GraphicsDevice/IncorrectDisplayModeExitFullscreen.java Changeset: 46826d248616 Author: pchelko Date: 2013-07-11 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46826d248616 8020210: [macosx] JVM crashes in CWrapper$NSWindow.screen(long) Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/native/sun/awt/CWrapper.m + test/java/awt/Window/MaximizeOffscreen/MaximizeOffscreenTest.java Changeset: c566daef4877 Author: leonidr Date: 2013-07-11 18:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c566daef4877 8020038: [macosx] Incorrect usage of invokeLater() and likes in callbacks called via JNI from AppKit thread Reviewed-by: art, anthony ! src/macosx/classes/com/apple/eawt/FullScreenHandler.java ! src/macosx/classes/com/apple/eawt/_AppEventHandler.java ! src/macosx/classes/com/apple/eawt/event/GestureHandler.java ! src/macosx/classes/com/apple/laf/ScreenMenu.java ! src/macosx/classes/sun/lwawt/macosx/CCheckboxMenuItem.java ! src/macosx/classes/sun/lwawt/macosx/CViewEmbeddedFrame.java Changeset: c3268a602a50 Author: raginip Date: 2013-07-12 14:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c3268a602a50 8009168: accessibility.properties syntax issue Reviewed-by: ptbrunet, mfang, alexsch ! src/share/classes/com/sun/accessibility/internal/resources/accessibility.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_de.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_es.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_fr.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_it.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_ja.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_ko.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_pt_BR.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_sv.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_zh_CN.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_zh_TW.properties ! src/share/classes/javax/accessibility/AccessibleAction.java Changeset: f7ea38893138 Author: serb Date: 2013-07-12 21:33 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7ea38893138 8020298: [macosx] Incorrect merge in the lwawt code Reviewed-by: art, anthony ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: d52fc9384765 Author: pchelko Date: 2013-07-15 12:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d52fc9384765 8020371: [macosx] applets with Drag and Drop fail with IllegalArgumentException Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java ! src/macosx/classes/sun/lwawt/macosx/CDropTarget.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: 0967103c1b65 Author: malenkov Date: 2013-07-15 17:33 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0967103c1b65 8017492: Static field in HTML parser affects all applications Reviewed-by: art ! src/share/classes/javax/swing/text/html/parser/ContentModel.java ! src/share/classes/javax/swing/text/html/parser/Element.java + test/javax/swing/text/html/parser/Test8017492.java Changeset: 15ea601e707a Author: lana Date: 2013-07-17 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/15ea601e707a Merge Changeset: f2558ef87d5a Author: lana Date: 2013-07-17 13:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2558ef87d5a Merge - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java - src/share/classes/java/util/stream/StreamBuilder.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html - test/java/util/Collections/EmptySortedSet.java Changeset: 5be9c5bfcfe9 Author: lana Date: 2013-07-22 17:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5be9c5bfcfe9 Merge - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java - src/share/classes/java/util/stream/StreamBuilder.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html - test/java/util/Collections/EmptySortedSet.java Changeset: 690161232823 Author: cl Date: 2013-07-25 03:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/690161232823 Added tag jdk8-b100 for changeset 5be9c5bfcfe9 ! .hgtags Changeset: 25575c3c209d Author: lana Date: 2013-07-26 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/25575c3c209d Merge Changeset: 9f9ffe6be557 Author: lana Date: 2013-07-26 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f9ffe6be557 Merge From mike.duigou at oracle.com Fri Jul 26 20:36:58 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Sat, 27 Jul 2013 03:36:58 +0000 Subject: hg: jdk8/tl/jdk: 8021601: Add unit test for PriorityQueue(Comparator) constructor Message-ID: <20130727033742.27D2948411@hg.openjdk.java.net> Changeset: f056728871f8 Author: mduigou Date: 2013-07-26 17:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f056728871f8 8021601: Add unit test for PriorityQueue(Comparator) constructor Reviewed-by: darcy, alanb ! src/share/classes/java/util/PriorityQueue.java ! test/java/util/PriorityQueue/RemoveContains.java From alan.bateman at oracle.com Sat Jul 27 08:45:00 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 27 Jul 2013 15:45:00 +0000 Subject: hg: jdk8/tl/jdk: 8014319: Faster division of large integers Message-ID: <20130727154550.747C748417@hg.openjdk.java.net> Changeset: d4b2436892c8 Author: bpb Date: 2013-07-26 17:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4b2436892c8 8014319: Faster division of large integers Summary: Implement Burnickel-Ziegler division algorithm in BigInteger Reviewed-by: bpb, martin Contributed-by: Tim Buktu ! src/share/classes/java/math/BigInteger.java ! src/share/classes/java/math/MutableBigInteger.java ! test/java/math/BigInteger/BigIntegerTest.java From alan.bateman at oracle.com Sat Jul 27 08:47:44 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 27 Jul 2013 15:47:44 +0000 Subject: hg: jdk8/tl/jdk: 8020641: Clean up some code style in recent BigInteger contributions Message-ID: <20130727154756.2893548418@hg.openjdk.java.net> Changeset: a1c01457cf6c Author: bpb Date: 2013-07-26 17:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a1c01457cf6c 8020641: Clean up some code style in recent BigInteger contributions Summary: Some minor cleanup to adhere better to Java coding conventions. Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/math/BigInteger.java ! src/share/classes/java/math/MutableBigInteger.java ! test/java/math/BigInteger/BigIntegerTest.java From joe.darcy at oracle.com Sat Jul 27 10:27:22 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 27 Jul 2013 17:27:22 +0000 Subject: hg: jdk8/tl/jdk: 8021609: Fix doclint issues in java.nio.charset Message-ID: <20130727172747.319F64841B@hg.openjdk.java.net> Changeset: eb1dc65162e8 Author: darcy Date: 2013-07-27 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb1dc65162e8 8021609: Fix doclint issues in java.nio.charset Reviewed-by: alanb ! src/share/classes/java/nio/charset/Charset-X-Coder.java.template From mike.duigou at oracle.com Sat Jul 27 14:24:24 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Sat, 27 Jul 2013 21:24:24 +0000 Subject: hg: jdk8/tl/jdk: 8021588: Remove explicit othervm execution from jdk/test/Makefile Message-ID: <20130727212448.DF2464841E@hg.openjdk.java.net> Changeset: 5d4a35823071 Author: mduigou Date: 2013-07-27 12:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d4a35823071 8021588: Remove explicit othervm execution from jdk/test/Makefile Reviewed-by: alanb ! test/Makefile From sundararajan.athijegannathan at oracle.com Sun Jul 28 23:30:34 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 29 Jul 2013 06:30:34 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20130729063038.3ACD648438@hg.openjdk.java.net> Changeset: f6588f168d79 Author: hannesw Date: 2013-07-26 13:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f6588f168d79 8020719: Run tests with reduced splitter threshold Reviewed-by: lagergren, sundar, jlaskey ! make/build.xml ! make/project.properties + test/script/basic/NASHORN-592-dual.js + test/script/basic/NASHORN-592-dual.js.EXPECTED + test/script/basic/compile-octane-splitter.js + test/script/basic/compile-octane-splitter.js.EXPECTED + test/script/basic/splitter.js + test/script/basic/splitter.js.EXPECTED - test/script/representations/NASHORN-592a.js ! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/ScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/TestConfig.java ! test/src/jdk/nashorn/internal/test/framework/TestFinder.java Changeset: 17a947418e65 Author: jlaskey Date: 2013-07-26 09:17 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/17a947418e65 8021321: Two runsunspider tests fail after updating sunspider to 1.0 Reviewed-by: jlaskey, sundar Contributed-by: michael.horowitz at oracle.com ! test/script/basic/runsunspider.js Changeset: fbd21b00197b Author: sundar Date: 2013-07-26 20:10 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fbd21b00197b 8021571: @fork tests should use VM options passed from project.properties Reviewed-by: lagergren, hannesw, jlaskey ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/PrototypeGenerator.java ! make/project.properties ! src/jdk/nashorn/internal/objects/BoundScriptFunctionImpl.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/PropertyListenerManager.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/linker/AdaptationException.java ! src/jdk/nashorn/internal/runtime/linker/AdaptationResult.java ! src/jdk/nashorn/internal/runtime/linker/InvokeByName.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterServices.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java ! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java ! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java ! src/jdk/nashorn/internal/runtime/options/KeyValueOption.java ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java ! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/ScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/TestConfig.java Changeset: 5fc6b7f11289 Author: sundar Date: 2013-07-29 10:28 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5fc6b7f11289 Merge - test/script/representations/NASHORN-592a.js From weijun.wang at oracle.com Mon Jul 29 02:11:42 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 29 Jul 2013 17:11:42 +0800 Subject: Code review request: 8012615: Realm.getRealmsList returns realms list in wrong Message-ID: <51F631CE.7080502@oracle.com> Hi Valerie Please review the capaths code change at http://cr.openjdk.java.net/~weijun/8012615/webrev.01/ It includes: Config.java =========== Add method to check if a sub-stanza exists. Realm.java ========== Rewrite reading cross-realm path for both [capaths] and hierarchy. The [capaths] part implements the chaining process. CredentialsUtils.java ===================== When reading cross-realm TGT for a path A->B->C->D->SERVERREALM, the current impl first gets krbtgt/SERVERREALM at A, and then fallback to krbtgt/D at A, krbtgt/C at A and krbtgt/B at A. In fact, since the capath is already there, krbtgt/B at A should be the first to check. I don't know about the history of this code and dare not change much. But I at least reverse the order of the fallback (what the code calls inner loop) to try krbtgt/B at A first. Tried on a local setup of 5 MIT KDC realms configured with a one-direction cross-auth from K1 to K5. The MIT kvno command starts with kinit in K1 and goes thru krbtgt/K2 at K1, krbtgt/K3 at K2, krbtgt/K4 at K3, krbtgt/K5 at K4 and finally get service ticket to host/host.k5 at K5. Now Java can do the same with the same krb5.conf. Thanks Max From sundararajan.athijegannathan at oracle.com Mon Jul 29 09:10:35 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 29 Jul 2013 16:10:35 +0000 Subject: hg: jdk8/tl/jdk: 8021773: print function as defined by jrunscript's init.js script is incompatible with nashorn's definition Message-ID: <20130729161123.A3A2548445@hg.openjdk.java.net> Changeset: 24bda55fca48 Author: sundar Date: 2013-07-29 21:39 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/24bda55fca48 8021773: print function as defined by jrunscript's init.js script is incompatible with nashorn's definition Reviewed-by: hannesw, lagergren ! src/share/classes/com/sun/tools/script/shell/init.js From maurizio.cimadamore at oracle.com Mon Jul 29 09:21:18 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 29 Jul 2013 16:21:18 +0000 Subject: hg: jdk8/tl/langtools: 8021338: Diamond finder may mark a required type argument as unnecessary Message-ID: <20130729162121.693DA48448@hg.openjdk.java.net> Changeset: cd9e8cea1b3c Author: jlahoda Date: 2013-07-28 10:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cd9e8cea1b3c 8021338: Diamond finder may mark a required type argument as unnecessary Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! test/tools/javac/generics/diamond/6939780/T6939780.java From maurizio.cimadamore at oracle.com Mon Jul 29 09:17:43 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 29 Jul 2013 16:17:43 +0000 Subject: hg: jdk8/tl/langtools: 8020689: Missing LineNumberTable entries in compiled class files Message-ID: <20130729161746.5CB0548446@hg.openjdk.java.net> Changeset: 8c4b2987edac Author: jlahoda Date: 2013-07-28 10:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8c4b2987edac 8020689: Missing LineNumberTable entries in compiled class files Reviewed-by: ksrini, mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/jvm/T8020689.java From sundararajan.athijegannathan at oracle.com Mon Jul 29 10:55:23 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 29 Jul 2013 17:55:23 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20130729175526.51ED448454@hg.openjdk.java.net> Changeset: 0532397d0732 Author: sundar Date: 2013-07-29 18:07 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0532397d0732 8012792: print function defined in engine.js does not handle multiple arguments Reviewed-by: hannesw ! src/jdk/nashorn/api/scripting/resources/engine.js ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: 7d5d24bdb671 Author: sundar Date: 2013-07-29 21:56 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7d5d24bdb671 Merge From paul.sandoz at oracle.com Mon Jul 29 11:52:40 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Mon, 29 Jul 2013 18:52:40 +0000 Subject: hg: jdk8/tl/jdk: 8020156: TreeMap.values().spliterator() does not report ORDERED; ... Message-ID: <20130729185304.6C75748456@hg.openjdk.java.net> Changeset: e83fc6d9cf03 Author: psandoz Date: 2013-07-29 19:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e83fc6d9cf03 8020156: TreeMap.values().spliterator() does not report ORDERED 8020009: TreeMap.entrySet().spliterator() reports SORTED + null comparator but the elements are not Comparable Reviewed-by: mduigou ! src/share/classes/java/util/TreeMap.java + test/java/util/Spliterator/SpliteratorCharacteristics.java From jason.uh at oracle.com Mon Jul 29 14:31:49 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Mon, 29 Jul 2013 21:31:49 +0000 Subject: hg: jdk8/tl/jdk: 8012971: PKCS11Test hiding exception failures Message-ID: <20130729213215.976924845E@hg.openjdk.java.net> Changeset: c042fd498f79 Author: ascarpino Date: 2013-07-19 11:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c042fd498f79 8012971: PKCS11Test hiding exception failures Reviewed-by: vinnie, valeriep ! test/ProblemList.txt ! test/sun/security/pkcs11/PKCS11Test.java ! test/sun/security/pkcs11/SecmodTest.java From jason.uh at oracle.com Mon Jul 29 14:33:20 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Mon, 29 Jul 2013 21:33:20 +0000 Subject: hg: jdk8/tl/jdk: 8020424: The NSS version should be detected before running crypto tests Message-ID: <20130729213332.186E64845F@hg.openjdk.java.net> Changeset: e47569593fa0 Author: ascarpino Date: 2013-07-29 13:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e47569593fa0 8020424: The NSS version should be detected before running crypto tests Reviewed-by: valeriep ! test/ProblemList.txt ! test/sun/security/pkcs11/KeyStore/SecretKeysBasic.java ! test/sun/security/pkcs11/PKCS11Test.java + test/sun/security/pkcs11/README ! test/sun/security/pkcs11/ec/ReadCertificates.java ! test/sun/security/pkcs11/ec/TestCurves.java ! test/sun/security/pkcs11/ec/TestECDH.java ! test/sun/security/pkcs11/ec/TestECDH2.java ! test/sun/security/pkcs11/ec/TestECDSA.java ! test/sun/security/pkcs11/ec/TestECDSA2.java ! test/sun/security/pkcs11/ec/TestECGenSpec.java ! test/sun/security/pkcs11/ec/TestKeyFactory.java From xuelei.fan at oracle.com Mon Jul 29 19:38:52 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Tue, 30 Jul 2013 02:38:52 +0000 Subject: hg: jdk8/tl/jdk: 8021841: Remove SSLEngineDeadlock.java from problem list Message-ID: <20130730023918.2F77B48467@hg.openjdk.java.net> Changeset: 613cc7beba64 Author: xuelei Date: 2013-07-29 19:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/613cc7beba64 8021841: Remove SSLEngineDeadlock.java from problem list Reviewed-by: wetmore ! test/ProblemList.txt From jason.uh at oracle.com Tue Jul 30 11:05:19 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Tue, 30 Jul 2013 18:05:19 +0000 Subject: hg: jdk8/tl/jdk: 8021833: javadoc cleanup in java.net Message-ID: <20130730180543.A4C1A48485@hg.openjdk.java.net> Changeset: c76f89695c90 Author: juh Date: 2013-07-30 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c76f89695c90 8021833: javadoc cleanup in java.net Summary: and converted to {@code }; package.html to package-info.java Reviewed-by: darcy, chegar ! src/share/classes/java/net/Authenticator.java ! src/share/classes/java/net/ContentHandler.java ! src/share/classes/java/net/ContentHandlerFactory.java ! src/share/classes/java/net/CookieHandler.java ! src/share/classes/java/net/CookieManager.java ! src/share/classes/java/net/CookiePolicy.java ! src/share/classes/java/net/CookieStore.java ! src/share/classes/java/net/DatagramPacket.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/DatagramSocketImpl.java ! src/share/classes/java/net/DatagramSocketImplFactory.java ! src/share/classes/java/net/FileNameMap.java ! src/share/classes/java/net/HttpCookie.java ! src/share/classes/java/net/HttpRetryException.java ! src/share/classes/java/net/HttpURLConnection.java ! src/share/classes/java/net/IDN.java ! src/share/classes/java/net/Inet4Address.java ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/InetSocketAddress.java ! src/share/classes/java/net/InterfaceAddress.java ! src/share/classes/java/net/JarURLConnection.java ! src/share/classes/java/net/MalformedURLException.java ! src/share/classes/java/net/MulticastSocket.java ! src/share/classes/java/net/NetPermission.java ! src/share/classes/java/net/NetworkInterface.java ! src/share/classes/java/net/PasswordAuthentication.java ! src/share/classes/java/net/PortUnreachableException.java ! src/share/classes/java/net/ProtocolException.java ! src/share/classes/java/net/Proxy.java ! src/share/classes/java/net/ProxySelector.java ! src/share/classes/java/net/ResponseCache.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/Socket.java ! src/share/classes/java/net/SocketException.java ! src/share/classes/java/net/SocketImpl.java ! src/share/classes/java/net/SocketImplFactory.java ! src/share/classes/java/net/SocketInputStream.java ! src/share/classes/java/net/SocketOptions.java ! src/share/classes/java/net/SocketOutputStream.java ! src/share/classes/java/net/SocketPermission.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/URI.java ! src/share/classes/java/net/URISyntaxException.java ! src/share/classes/java/net/URL.java ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/net/URLDecoder.java ! src/share/classes/java/net/URLEncoder.java ! src/share/classes/java/net/URLStreamHandler.java ! src/share/classes/java/net/URLStreamHandlerFactory.java ! src/share/classes/java/net/UnknownHostException.java ! src/share/classes/java/net/UnknownServiceException.java + src/share/classes/java/net/package-info.java - src/share/classes/java/net/package.html From xueming.shen at oracle.com Tue Jul 30 14:41:44 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 30 Jul 2013 21:41:44 +0000 Subject: hg: jdk8/tl/jdk: 8021767: test/java/time/tck/java/time/format/TCKFormatStyle.java failing Message-ID: <20130730214210.B172D48490@hg.openjdk.java.net> Changeset: 8bc1bbd5b659 Author: sherman Date: 2013-07-30 14:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8bc1bbd5b659 8021767: test/java/time/tck/java/time/format/TCKFormatStyle.java failing Summary: Correct to use fixed locale, not locale of test environment Reviewed-by: alanb, okutsu Contributed-by: roger.riggs at oracle.com ! test/java/time/tck/java/time/format/TCKFormatStyle.java From stuart.marks at oracle.com Tue Jul 30 16:23:59 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 30 Jul 2013 23:23:59 +0000 Subject: hg: jdk8/tl/jdk: 8020977: StringJoiner merges with itself not as expected Message-ID: <20130730232423.2F97748491@hg.openjdk.java.net> Changeset: 09a77a1bdbc3 Author: henryjen Date: 2013-07-30 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09a77a1bdbc3 8020977: StringJoiner merges with itself not as expected Reviewed-by: psandoz, chegar, mduigou, smarks ! src/share/classes/java/util/StringJoiner.java ! test/java/util/StringJoiner/MergeTest.java From paul.sandoz at oracle.com Tue Jul 30 23:54:09 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Wed, 31 Jul 2013 06:54:09 +0000 Subject: hg: jdk8/tl/jdk: 8021863: Stream.concat incorrectly calculates unsized state Message-ID: <20130731065435.5AA1748499@hg.openjdk.java.net> Changeset: 76d88a752a03 Author: psandoz Date: 2013-07-30 11:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/76d88a752a03 8021863: Stream.concat incorrectly calculates unsized state Reviewed-by: chegar ! src/share/classes/java/util/stream/Streams.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ConcatOpTest.java From weijun.wang at oracle.com Wed Jul 31 00:04:04 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 31 Jul 2013 15:04:04 +0800 Subject: Code review request: 8021789: jarsigner parses alias as command line option (depending on locale) Message-ID: <51F8B6E4.50201@oracle.com> Hi All Please review the fix at http://cr.openjdk.java.net/~weijun/8021789/webrev.00/ The problem is that jarsigner uses Collator::compare to check for command line options, and if that Collator uses Collator.PRIMARY as strength it treats "-debug" and "debug" the same (in some locales?). I have no idea how people depend on other features of Collator.PRIMARY, so I move the filename/alias check to the beginning of the long if block. Also I fixed a small bug on empty argument. Of course, an empty argument is always useless but StringIndexOutOfBoundsException is not a friendly response. Thanks Max From paul.sandoz at oracle.com Wed Jul 31 00:14:52 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Wed, 31 Jul 2013 07:14:52 +0000 Subject: hg: jdk8/tl/jdk: 8021883: j.u.Random/RandomStream.java test needs more robust timeout duration Message-ID: <20130731071533.EF3144849A@hg.openjdk.java.net> Changeset: d30f357c6050 Author: psandoz Date: 2013-07-30 14:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d30f357c6050 8021883: j.u.Random/RandomStream.java test needs more robust timeout duration Reviewed-by: chegar ! test/java/util/Random/RandomStreamTest.java From vicente.romero at oracle.com Wed Jul 31 02:53:34 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 31 Jul 2013 09:53:34 +0000 Subject: hg: jdk8/tl/langtools: 8013179: assertion failure in javac when compiling with -source 1.6 -target 1.6 Message-ID: <20130731095340.41BED484A2@hg.openjdk.java.net> Changeset: 7696282873f6 Author: vromero Date: 2013-07-31 10:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7696282873f6 8013179: assertion failure in javac when compiling with -source 1.6 -target 1.6 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/MethodInvokedWithWrongNumberOfArgs.java From chris.hegarty at oracle.com Wed Jul 31 08:12:32 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 31 Jul 2013 15:12:32 +0000 Subject: hg: jdk8/tl/jdk: 8020539: Clean up doclint problems in java.util package, part 2 Message-ID: <20130731151331.5A430484B8@hg.openjdk.java.net> Changeset: 5561b34f6d4c Author: bpb Date: 2013-07-30 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5561b34f6d4c 8020539: Clean up doclint problems in java.util package, part 2 Summary: Clean up doclint errors and warnings in classes in java.util Reviewed-by: darcy, chegar Contributed-by: Brian Burkhalter ! src/share/classes/java/util/List.java ! src/share/classes/java/util/Map.java ! src/share/classes/java/util/Optional.java ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/java/util/ServiceLoader.java ! src/share/classes/java/util/StringJoiner.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/UUID.java ! src/share/classes/java/util/Vector.java From rickard.backman at oracle.com Wed Jul 31 10:00:24 2013 From: rickard.backman at oracle.com (rickard.backman at oracle.com) Date: Wed, 31 Jul 2013 17:00:24 +0000 Subject: hg: jdk8/tl/jdk: 8006324: [TEST_BUG] sun/invoke/util/ValueConversionsTest.java should be modified Message-ID: <20130731170109.E1992484BC@hg.openjdk.java.net> Changeset: 4bd51f6268f4 Author: rbackman Date: 2013-07-24 10:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bd51f6268f4 8006324: [TEST_BUG] sun/invoke/util/ValueConversionsTest.java should be modified Reviewed-by: kvn, twisti ! test/sun/invoke/util/ValueConversionsTest.java From kumar.x.srinivasan at oracle.com Wed Jul 31 14:47:18 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Wed, 31 Jul 2013 21:47:18 +0000 Subject: hg: jdk8/tl/langtools: 8014826: c.s.t.javac.tree.Pretty.visitNewArray() prints duplicate dimension markers Message-ID: <20130731214726.BCE15484D0@hg.openjdk.java.net> Changeset: 05370ef9dccb Author: ksrini Date: 2013-07-31 08:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/05370ef9dccb 8014826: c.s.t.javac.tree.Pretty.visitNewArray() prints duplicate dimension markers Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/tree/Pretty.java + test/tools/javac/tree/NewArrayPretty.java