From chris.hegarty at oracle.com Wed May 1 02:05:22 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 01 May 2013 09:05:22 +0000 Subject: hg: jdk8/tl/jdk: 6594296: NetworkInterface.getHardwareAddress returns zero length byte array Message-ID: <20130501090606.88DF148727@hg.openjdk.java.net> Changeset: dddd17cf61ff Author: chegar Date: 2013-05-01 10:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dddd17cf61ff 6594296: NetworkInterface.getHardwareAddress returns zero length byte array Reviewed-by: alanb ! src/windows/native/java/net/NetworkInterface_winXP.c ! test/java/net/NetworkInterface/Test.java From chris.hegarty at oracle.com Wed May 1 03:16:55 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 01 May 2013 10:16:55 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130501101742.C20AA4872A@hg.openjdk.java.net> Changeset: 73793f2af80a Author: msheppar Date: 2013-04-30 16:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/73793f2af80a 8007799: Base64.getEncoder(0, byte[]) returns an encoder that unexpectedly inserts line separators Reviewed-by: sherman, iris ! src/share/classes/java/util/Base64.java + test/java/util/Base64/Base64GetEncoderTest.java Changeset: 5941f7c9c76a Author: chegar Date: 2013-05-01 11:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5941f7c9c76a 8013723: ProblemList.txt updates (5/2013) Reviewed-by: alanb ! test/ProblemList.txt From weijun.wang at oracle.com Wed May 1 03:31:21 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 01 May 2013 18:31:21 +0800 Subject: Code review request: 8012082: SASL auth-conf negotiated, but unencrypted data is accepted, reset to unencrypt In-Reply-To: <5170964C.3030407@oracle.com> References: <516E7BEB.1090500@oracle.com> <516F7441.1010001@oracle.com> <5170964C.3030407@oracle.com> Message-ID: <5180EEF9.8050103@oracle.com> Ping again. On 4/19/13 8:56 AM, Weijun Wang wrote: > Resubmitted at http://cr.openjdk.java.net/~weijun/8012082/webrev.01/. > > Now, when unwrap is called, it does *not* check if the message received > matches the QoP. So when auth-conf is negotiated, one side can send an > unencrypted token and the other side will accept it. It just will not > forget its own QoP. > > This is the same behavior as Cyrus SASL and GNU SASL. > > Thanks > Max > > On 4/18/13 12:19 PM, Weijun Wang wrote: >> Webrev withdrawn. I'm studying the behavior of several third-party SASL >> impls to see how they deal with this. >> >> Stay tuned. >> >> -Max >> >> On 4/17/13 6:39 PM, Weijun Wang wrote: >>> Hi Valerie or Vinnie >>> >>> Please take a review on this fix >>> >>> http://cr.openjdk.java.net/~weijun/8012082/webrev.00/ >>> >>> Bug is >>> >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012082 >>> >>> The problem is that a single MessageProp is used in all wrap and unwrap >>> calls and the output value is not checked. >>> >>> After the output check, it looks like it's OK to share the MessageProp >>> object (because once it's changed, an exception is thrown), but I create >>> one for each wrap/unwrap to be safe and clean, and I don't know if there >>> are applications trying to "recover" from an exception. >>> >>> This is not a security issue, it's after the peer establishing the >>> security context, therefore already authenticated. >>> >>> Thanks >>> Max From Vincent.X.Ryan at Oracle.Com Wed May 1 04:26:28 2013 From: Vincent.X.Ryan at Oracle.Com (Vincent Ryan) Date: Wed, 1 May 2013 12:26:28 +0100 Subject: Code review request: 8012082: SASL auth-conf negotiated, but unencrypted data is accepted, reset to unencrypt In-Reply-To: <5180EEF9.8050103@oracle.com> References: <516E7BEB.1090500@oracle.com> <516F7441.1010001@oracle.com> <5170964C.3030407@oracle.com> <5180EEF9.8050103@oracle.com> Message-ID: <244268CE-7769-4AB5-B86E-E10D2FD11F21@Oracle.Com> Your fix looks good Max. On 1 May 2013, at 11:31, Weijun Wang wrote: > Ping again. > > On 4/19/13 8:56 AM, Weijun Wang wrote: >> Resubmitted at http://cr.openjdk.java.net/~weijun/8012082/webrev.01/. >> >> Now, when unwrap is called, it does *not* check if the message received >> matches the QoP. So when auth-conf is negotiated, one side can send an >> unencrypted token and the other side will accept it. It just will not >> forget its own QoP. >> >> This is the same behavior as Cyrus SASL and GNU SASL. >> >> Thanks >> Max >> >> On 4/18/13 12:19 PM, Weijun Wang wrote: >>> Webrev withdrawn. I'm studying the behavior of several third-party SASL >>> impls to see how they deal with this. >>> >>> Stay tuned. >>> >>> -Max >>> >>> On 4/17/13 6:39 PM, Weijun Wang wrote: >>>> Hi Valerie or Vinnie >>>> >>>> Please take a review on this fix >>>> >>>> http://cr.openjdk.java.net/~weijun/8012082/webrev.00/ >>>> >>>> Bug is >>>> >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012082 >>>> >>>> The problem is that a single MessageProp is used in all wrap and unwrap >>>> calls and the output value is not checked. >>>> >>>> After the output check, it looks like it's OK to share the MessageProp >>>> object (because once it's changed, an exception is thrown), but I create >>>> one for each wrap/unwrap to be safe and clean, and I don't know if there >>>> are applications trying to "recover" from an exception. >>>> >>>> This is not a security issue, it's after the peer establishing the >>>> security context, therefore already authenticated. >>>> >>>> Thanks >>>> Max From weijun.wang at oracle.com Wed May 1 06:11:40 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 01 May 2013 13:11:40 +0000 Subject: hg: jdk8/tl/jdk: 8012082: SASL: auth-conf negotiated, but unencrypted data is accepted, reset to unencrypt Message-ID: <20130501131206.472EC4872D@hg.openjdk.java.net> Changeset: ae4a82e69da2 Author: weijun Date: 2013-05-01 21:05 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae4a82e69da2 8012082: SASL: auth-conf negotiated, but unencrypted data is accepted, reset to unencrypt Reviewed-by: vinnie ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Base.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Server.java + test/sun/security/krb5/auto/SaslGSS.java From mike.duigou at oracle.com Wed May 1 08:37:19 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 01 May 2013 15:37:19 +0000 Subject: hg: jdk8/tl/jdk: 8012665: add CharSequence.chars, CharSequence.codePoints Message-ID: <20130501153732.3B74448732@hg.openjdk.java.net> Changeset: c6aef650e615 Author: mduigou Date: 2013-05-01 08:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6aef650e615 8012665: add CharSequence.chars, CharSequence.codePoints Reviewed-by: martin, alanb, ulfzibis, mduigou Contributed-by: Stuart Marks , Henry Jen ! src/share/classes/java/lang/CharSequence.java + test/java/lang/CharSequence/DefaultTest.java ! test/java/lang/StringBuffer/TestSynchronization.java From robert.field at oracle.com Wed May 1 08:46:50 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Wed, 01 May 2013 15:46:50 +0000 Subject: hg: jdk8/tl/langtools: 8011591: BootstrapMethodError when capturing constructor ref to local classes Message-ID: <20130501154653.7F0E64873C@hg.openjdk.java.net> Changeset: 8e27e84de2e9 Author: rfield Date: 2013-05-01 08:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8e27e84de2e9 8011591: BootstrapMethodError when capturing constructor ref to local classes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestNewInnerImplicitArgs.java From erik.joelsson at oracle.com Thu May 2 00:46:57 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 02 May 2013 09:46:57 +0200 Subject: RFR: 8009280: JCE jurisdiction policy files not copied into jdk/lib/security In-Reply-To: <97A613D6-5F6F-4433-91B7-D1E2B75B2479@oracle.com> References: <517FD910.6050908@oracle.com> <97A613D6-5F6F-4433-91B7-D1E2B75B2479@oracle.com> Message-ID: <518219F1.1020302@oracle.com> I agree the dependencies in BuildJdk.gmk are messed up but I didn't think this bug was the correct place to clean it up so I just followed the existing pattern, which is a strict linear dependency chain. /Erik On 2013-04-30 17:58, Mike Duigou wrote: > It's very nice to see this resolved. Hopefully one more nail in the old build's coffin. > > The jdk target should depend upon genclasses. It seems really strange to have this as a dependency for securityjars and not jdk. > > Mike > > On Apr 30 2013, at 07:45 , Erik Joelsson wrote: > >> With this patch the security tests will again be runnable on the exploded jdk image. The main changes are: >> >> * The security classes are compiled separately to a different output directory. >> * The security jars are created in the jdk target (instead of images) and put in the jdk/lib/... directories. >> >> Also did: >> * Removed now redundant entries in rt.jar exclude list >> * Changed source location for signing unsigned jars >> * Made the SetupJavaCompilation macro more friendly with multiple setups sharing output directories. >> >> http://cr.openjdk.java.net/~erikj/8009280/webrev.jdk.01/ >> http://cr.openjdk.java.net/~erikj/8009280/webrev.root.01/ >> >> /Erik From kumar.x.srinivasan at oracle.com Thu May 2 05:49:58 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 02 May 2013 12:49:58 +0000 Subject: hg: jdk8/tl/jdk: 8013225: Refresh jdk's private ASM to the latest. Message-ID: <20130502125032.62CF048777@hg.openjdk.java.net> Changeset: 167d2dcaeeee Author: ksrini Date: 2013-05-01 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/167d2dcaeeee 8013225: Refresh jdk's private ASM to the latest. Reviewed-by: mduigou, sundar ! src/share/classes/jdk/internal/org/objectweb/asm/AnnotationVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/AnnotationWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Attribute.java ! src/share/classes/jdk/internal/org/objectweb/asm/ByteVector.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/Context.java ! src/share/classes/jdk/internal/org/objectweb/asm/FieldVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/FieldWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/Handle.java ! src/share/classes/jdk/internal/org/objectweb/asm/Handler.java ! src/share/classes/jdk/internal/org/objectweb/asm/Item.java ! src/share/classes/jdk/internal/org/objectweb/asm/Label.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Opcodes.java ! src/share/classes/jdk/internal/org/objectweb/asm/Type.java + src/share/classes/jdk/internal/org/objectweb/asm/TypePath.java + src/share/classes/jdk/internal/org/objectweb/asm/TypeReference.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AdviceAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AnalyzerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/CodeSizeEvaluator.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/GeneratorAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/InstructionAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/JSRInlinerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/LocalVariablesSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/Method.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/Remapper.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingAnnotationAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingClassAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingFieldAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingSignatureAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/SerialVersionUIDAdder.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/StaticInitMerger.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/TableSwitchGenerator.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/TryCatchBlockSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureReader.java ! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/AbstractInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/AnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/ClassNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FrameNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/IincInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InnerClassNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnList.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/IntInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/InvokeDynamicInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/JumpInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LdcInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LineNumberNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableAnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/LookupSwitchInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MultiANewArrayInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/ParameterNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TableSwitchInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TryCatchBlockNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeAnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/VarInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Analyzer.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/AnalyzerException.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicInterpreter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicValue.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicVerifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Interpreter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SimpleVerifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceInterpreter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceValue.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Subroutine.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifiable.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckAnnotationAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckFieldAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckSignatureAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Printer.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifiable.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceAnnotationVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceClassVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceFieldVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceMethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceSignatureVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/version.txt From mike.duigou at oracle.com Thu May 2 09:25:01 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 02 May 2013 16:25:01 +0000 Subject: hg: jdk8/tl/jdk: 8012645: Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile Message-ID: <20130502162514.B703948781@hg.openjdk.java.net> Changeset: 5045eb04a579 Author: mduigou Date: 2013-05-02 09:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5045eb04a579 8012645: Stream methods on BitSet, Random, ThreadLocalRandom, ZipFile Reviewed-by: mduigou, henryjen, alanb, martin, psandoz Contributed-by: akhil.arora at oracle.com, brian.goetz at oracle.com ! src/share/classes/java/util/BitSet.java ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/zip/ZipFile.java + test/java/util/BitSet/BitSetStreamTest.java + test/java/util/Random/RandomStreamTest.java + test/java/util/zip/ZipFile/StreamZipEntriesTest.java From alexander.zuev at oracle.com Thu May 2 10:24:16 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Thu, 02 May 2013 17:24:16 +0000 Subject: hg: jdk8/tl/jdk: 8013155: [pack200] improve performance of pack200 Message-ID: <20130502172428.6F15048787@hg.openjdk.java.net> Changeset: a6ff4a823164 Author: kizune Date: 2013-05-02 21:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a6ff4a823164 8013155: [pack200] improve performance of pack200 Reviewed-by: ksrini, jrose ! src/share/classes/com/sun/java/util/jar/pack/Code.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java From kurchi.subhra.hazra at oracle.com Thu May 2 14:17:51 2013 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Thu, 02 May 2013 21:17:51 +0000 Subject: hg: jdk8/tl/jdk: 8013140: Heap corruption with NetworkInterface.getByInetAddress() and long i/f name Message-ID: <20130502211812.21CA248793@hg.openjdk.java.net> Changeset: 3062bf908281 Author: khazra Date: 2013-05-02 14:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3062bf908281 8013140: Heap corruption with NetworkInterface.getByInetAddress() and long i/f name Summary: Remove buffer overruns in native code Reviewed-by: alanb, chegar ! src/solaris/native/java/net/NetworkInterface.c From weijun.wang at oracle.com Thu May 2 19:44:40 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 03 May 2013 02:44:40 +0000 Subject: hg: jdk8/tl/jdk: 8013855: DigestMD5Client has not checked RealmChoiceCallback value Message-ID: <20130503024453.7B540487AC@hg.openjdk.java.net> Changeset: 81be41c7323f Author: weijun Date: 2013-05-03 10:43 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81be41c7323f 8013855: DigestMD5Client has not checked RealmChoiceCallback value Reviewed-by: xuelei, mullan ! src/share/classes/com/sun/security/sasl/digest/DigestMD5Client.java + test/com/sun/security/sasl/digest/AuthRealmChoices.java From jason.uh at oracle.com Thu May 2 22:44:27 2013 From: jason.uh at oracle.com (Jason Uh) Date: Thu, 02 May 2013 22:44:27 -0700 Subject: [8] Code review request for 8005922: TEST_BUG: There is no /tmp directory for windows system. Message-ID: <51834EBB.8010508@oracle.com> Could I please get a review for this fix for 8005922: Edits to the manual test instructions for some policytool tests to accommodate Windows-style paths. Webrev: http://cr.openjdk.java.net/~juh/8005922/webrev.00/ Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005922 Thanks, Jason From weijun.wang at oracle.com Fri May 3 00:33:50 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 03 May 2013 15:33:50 +0800 Subject: [8] Code review request for 8005922: TEST_BUG: There is no /tmp directory for windows system. In-Reply-To: <51834EBB.8010508@oracle.com> References: <51834EBB.8010508@oracle.com> Message-ID: <5183685E.5010300@oracle.com> Hi Jason One question: why is this necessary in i18n.html and ChangeUI.html: -
    +
      Neither test mentions step #. Otherwise, the changes look fine. Thanks Max On 5/3/13 1:44 PM, Jason Uh wrote: > Could I please get a review for this fix for 8005922: > > Edits to the manual test instructions for some policytool tests to > accommodate Windows-style paths. > > Webrev: http://cr.openjdk.java.net/~juh/8005922/webrev.00/ > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005922 > > Thanks, > Jason From jason.uh at oracle.com Fri May 3 02:52:41 2013 From: jason.uh at oracle.com (Jason Uh) Date: Fri, 03 May 2013 02:52:41 -0700 Subject: [8] Code review request for 8005922: TEST_BUG: There is no /tmp directory for windows system. In-Reply-To: <5183685E.5010300@oracle.com> References: <51834EBB.8010508@oracle.com> <5183685E.5010300@oracle.com> Message-ID: <518388E9.1020503@oracle.com> Hi Max, On 05/03/2013 12:33 AM, Weijun Wang wrote: > Hi Jason > > One question: why is this necessary in i18n.html and ChangeUI.html: > > -
        > +
          > > Neither test mentions step #. Using a zero-based list was just a stylistic choice, especially as Step 0 would be a case-specific ("If Windows...") step. I did reference it later on. For example: -and click "OK".

          +and click "OK".
          +If testing on Windows, use the temporary directory created in Step 0. +(Example: Save as "C:\foo\tmp\ptool.test")

          Do you have a strong preference for me to change it back so that the first step is numbered as "1."? > Otherwise, the changes look fine. Thanks, Jason > Thanks > Max > > > On 5/3/13 1:44 PM, Jason Uh wrote: >> Could I please get a review for this fix for 8005922: >> >> Edits to the manual test instructions for some policytool tests to >> accommodate Windows-style paths. >> >> Webrev: http://cr.openjdk.java.net/~juh/8005922/webrev.00/ >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005922 >> >> Thanks, >> Jason From weijun.wang at oracle.com Fri May 3 02:56:38 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 03 May 2013 17:56:38 +0800 Subject: [8] Code review request for 8005922: TEST_BUG: There is no /tmp directory for windows system. In-Reply-To: <518388E9.1020503@oracle.com> References: <51834EBB.8010508@oracle.com> <5183685E.5010300@oracle.com> <518388E9.1020503@oracle.com> Message-ID: <518389D6.3030107@oracle.com> On 5/3/13 5:52 PM, Jason Uh wrote: > Hi Max, > > On 05/03/2013 12:33 AM, Weijun Wang wrote: >> Hi Jason >> >> One question: why is this necessary in i18n.html and ChangeUI.html: >> >> -
            >> +
              >> >> Neither test mentions step #. > > Using a zero-based list was just a stylistic choice, especially as Step > 0 would be a case-specific ("If Windows...") step. I did reference it > later on. For example: > > -and click "OK".

              > +and click "OK".
              > +If testing on Windows, use the temporary directory created in Step 0. > +(Example: Save as "C:\foo\tmp\ptool.test")

              Sorry I missed that. > > Do you have a strong preference for me to change it back so that the > first step is numbered as "1."? Not really. Choose whatever you prefer. Thanks Max > >> Otherwise, the changes look fine. > > Thanks, > Jason > >> Thanks >> Max >> >> >> On 5/3/13 1:44 PM, Jason Uh wrote: >>> Could I please get a review for this fix for 8005922: >>> >>> Edits to the manual test instructions for some policytool tests to >>> accommodate Windows-style paths. >>> >>> Webrev: http://cr.openjdk.java.net/~juh/8005922/webrev.00/ >>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005922 >>> >>> Thanks, >>> Jason From jonathan.gibbons at oracle.com Fri May 3 09:57:40 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 03 May 2013 16:57:40 +0000 Subject: hg: jdk8/tl/langtools: 8012728: Normalize @ignore comments on langtools tests Message-ID: <20130503165746.D12F5487F0@hg.openjdk.java.net> Changeset: abd153854f16 Author: jjg Date: 2013-05-03 09:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abd153854f16 8012728: Normalize @ignore comments on langtools tests Reviewed-by: vromero, mcimadamore ! test/com/sun/javadoc/_template/Template.java ! test/com/sun/javadoc/_template/TemplateComplete.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java ! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java ! test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java ! test/tools/javac/generics/7034511/T7034511a.java ! test/tools/javac/generics/7034511/T7034511b.java ! test/tools/javac/generics/OverrideBridge.java ! test/tools/javac/lambda/TargetType36.java ! test/tools/javac/lambda/TargetType53.java ! test/tools/javac/lambda/TargetType54.java ! test/tools/javac/lambda/TargetType58.java ! test/tools/javac/lambda/TargetType59.java ! test/tools/javac/lambda/TargetType62.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA1Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB1Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB2Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideATest.java ! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideBTest.java ! test/tools/javap/output/RepeatingTypeAnnotations.java ! test/tools/javap/output/Tester.java From jonathan.gibbons at oracle.com Fri May 3 10:17:25 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 03 May 2013 17:17:25 +0000 Subject: hg: jdk8/tl/langtools: 8002387: Improve rendered HTML formatting for {@code} Message-ID: <20130503171727.C503F487F1@hg.openjdk.java.net> Changeset: 38c4bade0ec1 Author: jjg Date: 2013-05-03 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/38c4bade0ec1 8002387: Improve rendered HTML formatting for {@code} Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javadoc/Comment.java + test/com/sun/javadoc/testLiteralCodeInPre/TestLiteralCodeInPre.java + test/com/sun/javadoc/testLiteralCodeInPre/pkg/Test.java From valerie.peng at oracle.com Fri May 3 11:23:03 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 03 May 2013 11:23:03 -0700 Subject: Code review request: 8010192: Enable native JGSS provider on Mac In-Reply-To: <51470ADD.1040001@oracle.com> References: <5146F3CD.3000903@oracle.com> <51470ADD.1040001@oracle.com> Message-ID: <51840087.6090703@oracle.com> So, has this changes been tested against the existing regression tests on Mac? After this, is the native JGSS provider get used on Mac for most if not all Kerberos operation or is it still Java Kerberos? Otherwise, changes look ok to me. Valerie On 03/18/13 05:38, Erik Joelsson wrote: > The build changes look ok. > > /Erik > > On 2013-03-18 12:00, Weijun Wang wrote: >> Please take a look at >> >> http://cr.openjdk.java.net/~weijun/8010192/webrev.00/ >> >> The Mac native JGSS provider is back. Besides reverting changes made >> in http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5a2ab2c3f106, there are: >> >> 1. GSSManagerImpl.java: enable the provider >> 2. SunNativeProvider.java: library name from MIT added >> 3. Update gssapi.h, new lines copied from Mac's gssapi.h >> 4. Liberate a test. >> >> Thanks >> Max From valerie.peng at oracle.com Fri May 3 11:58:19 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 03 May 2013 11:58:19 -0700 Subject: [8] code review request 4634141: PBE Cipher should have the ability to use params from PBE Key In-Reply-To: <0448BD84-B2B8-46CB-B9D0-EFA2834E672B@oracle.com> References: <0448BD84-B2B8-46CB-B9D0-EFA2834E672B@oracle.com> Message-ID: <518408CB.2000407@oracle.com> Vinnie, Hmm, so, are we taking the salt and ic value from the key object for decrypt mode? If yes, then the if-cond checking on line 214 will have to be deferred to a later point where we checked both key and the parameters. Do we check for consistent values of salt and ic if both key and parameters supply them? Depending on the mode, i.e. encrypt or decrypt, we will have to take different actions when either salt and ic isn't supplied. Also, I think it'd be good to set aside the salt and ic checking code, i.e. lines 257-260 + lines 262-265, to a separate static utility method for both code-reuse as well as readability. Thanks, Valerie On 04/26/13 09:59, Vincent Ryan wrote: > Please review the following fix for: > > 4634141: PBE Cipher should have the ability to use params from PBE Key > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4634141 > > Webrev: http://cr.openjdk.java.net/~vinnie/4634141/webrev.00/ > > This problem is that the parameters required by PBE-style ciphers may be > supplied in the PBE key object directly or in the PBE parameters object. > For PBES1 ciphers parameters supplied in the key are ignored. > > This doesn't happen for the new PBES2 ciphers available in JDK 8 so > this fix will ensure that the behaviour is consistent across all PBE ciphers. > > The fix examines the PBE key for the salt and iteration count parameters > when no PBE parameters object has been supplied. If parameters are not > present at either location then the cipher generates the necessary parameters > itself, as before. > > Thanks. > From mike.duigou at oracle.com Fri May 3 14:33:27 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 03 May 2013 21:33:27 +0000 Subject: hg: jdk8/tl/jdk: 8013528: Provide SharedSecrets access to String(char[], boolean) constructor Message-ID: <20130503213340.41D60487FF@hg.openjdk.java.net> Changeset: fc156b925259 Author: mduigou Date: 2013-05-03 10:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc156b925259 8013528: Provide SharedSecrets access to String(char[], boolean) constructor Reviewed-by: martin, alanb, chegar, plevart ! src/share/classes/java/lang/System.java ! src/share/classes/sun/misc/JavaLangAccess.java + test/sun/misc/JavaLangAccess/NewUnsafeString.java From jason.uh at oracle.com Fri May 3 15:05:11 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Fri, 03 May 2013 22:05:11 +0000 Subject: hg: jdk8/tl/jdk: 8005922: TEST_BUG: There is no /tmp directory for windows system. Message-ID: <20130503220525.0E4E348800@hg.openjdk.java.net> Changeset: d7f3d5659c46 Author: juh Date: 2013-05-03 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d7f3d5659c46 8005922: TEST_BUG: There is no /tmp directory for windows system. Reviewed-by: weijun ! test/sun/security/tools/policytool/ChangeUI.html ! test/sun/security/tools/policytool/UpdatePermissions.html ! test/sun/security/tools/policytool/i18n.html From jonathan.gibbons at oracle.com Fri May 3 15:11:26 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 03 May 2013 22:11:26 +0000 Subject: hg: jdk8/tl/langtools: 8000407: remove @GenerateNativeHeader Message-ID: <20130503221128.F392D48801@hg.openjdk.java.net> Changeset: a2889739cf21 Author: jjg Date: 2013-05-03 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a2889739cf21 8000407: remove @GenerateNativeHeader Reviewed-by: vromero, darcy ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java - src/share/classes/javax/tools/annotation/GenerateNativeHeader.java ! test/tools/javac/nativeHeaders/NativeHeaderTest.java ! test/tools/javac/nativeHeaders/javahComparison/CompareTest.java - test/tools/javac/nativeHeaders/javahComparison/TestClass2.java - test/tools/javac/nativeHeaders/javahComparison/TestClass3.java From weijun.wang at oracle.com Fri May 3 17:09:25 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Sat, 04 May 2013 08:09:25 +0800 Subject: Code review request: 8010192: Enable native JGSS provider on Mac In-Reply-To: <51840087.6090703@oracle.com> References: <5146F3CD.3000903@oracle.com> <51470ADD.1040001@oracle.com> <51840087.6090703@oracle.com> Message-ID: <518451B5.7010904@oracle.com> On 5/4/13 2:23 AM, Valerie (Yu-Ching) Peng wrote: > > So, has this changes been tested against the existing regression tests > on Mac? Yes, but there is only one current test using native lib, that is runNameEquals.sh. However, I've experienced it a lot with the ReplayCacheTestProc test in my recent rcache work. The native JGSS lib works fine on my Mac as well as JPRT clients. > After this, is the native JGSS provider get used on Mac for most if not > all Kerberos operation or is it still Java Kerberos? It's still java kerberos. You still have to set -Dsun.security.jgss.native=true to make native provider work. Thanks Max > > Otherwise, changes look ok to me. > Valerie > > On 03/18/13 05:38, Erik Joelsson wrote: >> The build changes look ok. >> >> /Erik >> >> On 2013-03-18 12:00, Weijun Wang wrote: >>> Please take a look at >>> >>> http://cr.openjdk.java.net/~weijun/8010192/webrev.00/ >>> >>> The Mac native JGSS provider is back. Besides reverting changes made >>> in http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5a2ab2c3f106, there are: >>> >>> 1. GSSManagerImpl.java: enable the provider >>> 2. SunNativeProvider.java: library name from MIT added >>> 3. Update gssapi.h, new lines copied from Mac's gssapi.h >>> 4. Liberate a test. >>> >>> Thanks >>> Max > From jonathan.gibbons at oracle.com Fri May 3 17:46:41 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sat, 04 May 2013 00:46:41 +0000 Subject: hg: jdk8/tl/langtools: 8008768: Using {@inheritDoc} in simple tag defined via -tag fails Message-ID: <20130504004644.180ED48807@hg.openjdk.java.net> Changeset: d918b63a5509 Author: jjg Date: 2013-05-03 17:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d918b63a5509 8008768: Using {@inheritDoc} in simple tag defined via -tag fails Reviewed-by: jjg, mduigou Contributed-by: jonathan.gibbons at oracle.com, mike.duigou at oracle.com ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFinder.java + test/com/sun/javadoc/InheritDocForUserTags/DocTest.java + test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java + test/com/sun/javadoc/testSimpleTagInherit/p/BaseClass.java + test/com/sun/javadoc/testSimpleTagInherit/p/TestClass.java From dag.wanvik at oracle.com Sun May 5 21:06:13 2013 From: dag.wanvik at oracle.com (dag.wanvik at oracle.com) Date: Mon, 06 May 2013 04:06:13 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130506040646.ADA004882A@hg.openjdk.java.net> Changeset: d8f01bfb1da4 Author: dwanvik Date: 2013-05-06 05:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8f01bfb1da4 8013403: Update JDK8 with Java DB 10.10.1.1. Summary: Drop Java DB 10.10.1.1 bits into JDK 8 and update image builds Reviewed-by: tbell ! make/common/Release.gmk ! makefiles/CompileDemos.gmk ! makefiles/Images.gmk Changeset: 398fe07f530f Author: dwanvik Date: 2013-05-06 06:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/398fe07f530f Merge - test/sun/reflect/CallerSensitive/MethodFinder.java From joe.darcy at oracle.com Sun May 5 21:05:14 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 06 May 2013 04:05:14 +0000 Subject: hg: jdk8/tl/langtools: 8013909: Fix doclint issues in javax.lang.model Message-ID: <20130506040520.B9DF648829@hg.openjdk.java.net> Changeset: e8987ce7fb4b Author: darcy Date: 2013-05-05 21:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e8987ce7fb4b 8013909: Fix doclint issues in javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/SupportedAnnotationTypes.java ! src/share/classes/javax/annotation/processing/SupportedOptions.java ! src/share/classes/javax/annotation/processing/SupportedSourceVersion.java ! src/share/classes/javax/lang/model/AnnotatedConstruct.java ! src/share/classes/javax/lang/model/element/NestingKind.java ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes/javax/lang/model/util/Elements.java ! src/share/classes/javax/lang/model/util/Types.java From dan.xu at oracle.com Mon May 6 14:18:54 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Mon, 06 May 2013 21:18:54 +0000 Subject: hg: jdk8/tl/jdk: 8003992: File and other classes in java.io do not handle embedded nulls properly Message-ID: <20130506211907.94A234884E@hg.openjdk.java.net> Changeset: bd118033e44c Author: dxu Date: 2013-05-06 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd118033e44c 8003992: File and other classes in java.io do not handle embedded nulls properly Summary: Have every file operation done with File, FileInputStream, FileOutputStream, or RandomAccessFile that involves a file path containing NUL fail. Also reviewed by fweimer at redhat.com Reviewed-by: alanb, sherman, ahgross, mduigou, dholmes, aph, plevart, martin ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/RandomAccessFile.java + test/java/io/File/NulFile.java From weijun.wang at oracle.com Mon May 6 19:47:09 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 07 May 2013 10:47:09 +0800 Subject: Code review request: 8012679: Let allow_weak_crypto default to false Message-ID: <51886B2D.70901@oracle.com> Webrev at http://cr.openjdk.java.net/~weijun/8012679/webrev.00/ Thanks Max From mike.duigou at oracle.com Mon May 6 20:56:18 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 07 May 2013 03:56:18 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20130507035652.E8C7F4885D@hg.openjdk.java.net> Changeset: e13cf31e5a96 Author: mduigou Date: 2013-05-06 20:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e13cf31e5a96 8013712: Add Objects.nonNull and Objects.isNull Reviewed-by: mchung, darcy ! src/share/classes/java/util/Objects.java ! test/java/util/Objects/BasicObjectsTest.java Changeset: 3cbb65d9af9e Author: mduigou Date: 2013-05-06 20:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3cbb65d9af9e 8013150: Iterator.remove and forEachRemaining relationship not specified Reviewed-by: mduigou Contributed-by: Akhil Arora ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/Vector.java + test/java/util/Iterator/IteratorDefaults.java Changeset: 8221c421490f Author: mduigou Date: 2013-05-06 20:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8221c421490f 8003258: BufferedReader.lines() Reviewed-by: alanb, mduigou, psandoz Contributed-by: Brian Goetz , Henry Jen ! src/share/classes/java/io/BufferedReader.java + src/share/classes/java/io/UncheckedIOException.java + test/java/io/BufferedReader/Lines.java From xueming.shen at oracle.com Mon May 6 21:25:15 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 07 May 2013 04:25:15 +0000 Subject: hg: jdk8/tl/jdk: 8013252: Regex Matcher .start and .end should be accessible by group name; ... Message-ID: <20130507042526.D8ED64885E@hg.openjdk.java.net> Changeset: b4a013f4eff4 Author: sherman Date: 2013-05-06 21:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4a013f4eff4 8013252: Regex Matcher .start and .end should be accessible by group name 8013254: Constructor \w need update to add the support of \p{Join_Control} Summary: added the requested methods and updated the \w constructor Reviewed-by: mchung, alanb ! src/share/classes/java/util/regex/Matcher.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/java/util/regex/UnicodeProp.java ! test/java/util/regex/POSIX_Unicode.java ! test/java/util/regex/RegExTest.java From weijun.wang at oracle.com Mon May 6 21:32:02 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 07 May 2013 04:32:02 +0000 Subject: hg: jdk8/tl/jdk: 8010192: Enable native JGSS provider on Mac Message-ID: <20130507043213.AB25048861@hg.openjdk.java.net> Changeset: 814dcc08df52 Author: weijun Date: 2013-05-07 12:30 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/814dcc08df52 8010192: Enable native JGSS provider on Mac Reviewed-by: valeriep ! make/sun/security/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/sun/security/jgss/GSSManagerImpl.java ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java ! src/share/native/sun/security/jgss/wrapper/gssapi.h ! test/sun/security/krb5/runNameEquals.sh From david.holmes at oracle.com Mon May 6 22:33:29 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 07 May 2013 15:33:29 +1000 Subject: RFR: 8009280: JCE jurisdiction policy files not copied into jdk/lib/security In-Reply-To: <517FD910.6050908@oracle.com> References: <517FD910.6050908@oracle.com> Message-ID: <51889229.9090801@oracle.com> Erik, Was this tested with a Profiles build? The changes to the RT_JAR_INCLUDES variable has me concerned. Thanks, David On 1/05/2013 12:45 AM, Erik Joelsson wrote: > With this patch the security tests will again be runnable on the > exploded jdk image. The main changes are: > > * The security classes are compiled separately to a different output > directory. > * The security jars are created in the jdk target (instead of images) > and put in the jdk/lib/... directories. > > Also did: > * Removed now redundant entries in rt.jar exclude list > * Changed source location for signing unsigned jars > * Made the SetupJavaCompilation macro more friendly with multiple setups > sharing output directories. > > http://cr.openjdk.java.net/~erikj/8009280/webrev.jdk.01/ > http://cr.openjdk.java.net/~erikj/8009280/webrev.root.01/ > > /Erik From jonathan.gibbons at oracle.com Mon May 6 22:52:07 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 07 May 2013 05:52:07 +0000 Subject: hg: jdk8/tl/langtools: 8009724: Enhance the DocTree API with DocTreePath Message-ID: <20130507055210.2F0D948865@hg.openjdk.java.net> Changeset: a7ff36d06fa2 Author: jlahoda Date: 2013-05-06 16:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a7ff36d06fa2 8009724: Enhance the DocTree API with DocTreePath Summary: Adding DocTreePath and DocTreePathScanner similar to TreePath and TreePathScanner, respectively Reviewed-by: jjg Contributed-by: Ralph Benjamin Ruijs , Jan Lahoda + src/share/classes/com/sun/source/util/DocTreePath.java + src/share/classes/com/sun/source/util/DocTreePathScanner.java ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java + test/tools/javac/doctree/DocTreePathScannerTest.java ! test/tools/javac/doctree/ReferenceTest.java From erik.joelsson at oracle.com Tue May 7 02:22:04 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 07 May 2013 11:22:04 +0200 Subject: RFR: 8009280: JCE jurisdiction policy files not copied into jdk/lib/security In-Reply-To: <51889229.9090801@oracle.com> References: <517FD910.6050908@oracle.com> <51889229.9090801@oracle.com> Message-ID: <5188C7BC.7020804@oracle.com> It seems to work for me. The reason I removed things from RT_JAR_EXCLUDES that are no longer present in jdk/classes outputdir. /Erik On 2013-05-07 07:33, David Holmes wrote: > Erik, > > Was this tested with a Profiles build? The changes to the > RT_JAR_INCLUDES variable has me concerned. > > Thanks, > David > > On 1/05/2013 12:45 AM, Erik Joelsson wrote: >> With this patch the security tests will again be runnable on the >> exploded jdk image. The main changes are: >> >> * The security classes are compiled separately to a different output >> directory. >> * The security jars are created in the jdk target (instead of images) >> and put in the jdk/lib/... directories. >> >> Also did: >> * Removed now redundant entries in rt.jar exclude list >> * Changed source location for signing unsigned jars >> * Made the SetupJavaCompilation macro more friendly with multiple setups >> sharing output directories. >> >> http://cr.openjdk.java.net/~erikj/8009280/webrev.jdk.01/ >> http://cr.openjdk.java.net/~erikj/8009280/webrev.root.01/ >> >> /Erik From david.holmes at oracle.com Tue May 7 02:37:41 2013 From: david.holmes at oracle.com (David Holmes) Date: Tue, 07 May 2013 19:37:41 +1000 Subject: RFR: 8009280: JCE jurisdiction policy files not copied into jdk/lib/security In-Reply-To: <5188C7BC.7020804@oracle.com> References: <517FD910.6050908@oracle.com> <51889229.9090801@oracle.com> <5188C7BC.7020804@oracle.com> Message-ID: <5188CB65.8040107@oracle.com> On 7/05/2013 7:22 PM, Erik Joelsson wrote: > It seems to work for me. > > The reason I removed things from RT_JAR_EXCLUDES that are no longer > present in jdk/classes outputdir. Ah okay that should be fine then. If they aren't there in the first place then no need to exclude :) Thanks, David > /Erik > > On 2013-05-07 07:33, David Holmes wrote: >> Erik, >> >> Was this tested with a Profiles build? The changes to the >> RT_JAR_INCLUDES variable has me concerned. >> >> Thanks, >> David >> >> On 1/05/2013 12:45 AM, Erik Joelsson wrote: >>> With this patch the security tests will again be runnable on the >>> exploded jdk image. The main changes are: >>> >>> * The security classes are compiled separately to a different output >>> directory. >>> * The security jars are created in the jdk target (instead of images) >>> and put in the jdk/lib/... directories. >>> >>> Also did: >>> * Removed now redundant entries in rt.jar exclude list >>> * Changed source location for signing unsigned jars >>> * Made the SetupJavaCompilation macro more friendly with multiple setups >>> sharing output directories. >>> >>> http://cr.openjdk.java.net/~erikj/8009280/webrev.jdk.01/ >>> http://cr.openjdk.java.net/~erikj/8009280/webrev.root.01/ >>> >>> /Erik From robert.field at oracle.com Tue May 7 06:40:47 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Tue, 07 May 2013 13:40:47 +0000 Subject: hg: jdk8/tl/langtools: 8014023: When a method reference to a local class constructor is contained in a method whose number of parameters matches the number of constructor parameters compilation fails Message-ID: <20130507134050.5103F48876@hg.openjdk.java.net> Changeset: 68142e69cafb Author: rfield Date: 2013-05-07 06:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/68142e69cafb 8014023: When a method reference to a local class constructor is contained in a method whose number of parameters matches the number of constructor parameters compilation fails Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/methodReference/TreeMakerParamsIsGoofy.java From erik.joelsson at oracle.com Tue May 7 06:56:35 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 07 May 2013 15:56:35 +0200 Subject: RFR: 8009280: JCE jurisdiction policy files not copied into jdk/lib/security In-Reply-To: <517FD910.6050908@oracle.com> References: <517FD910.6050908@oracle.com> Message-ID: <51890813.3050707@oracle.com> This patch didn't work with sjavac enabled. Back to the drawing board. /Erik On 2013-04-30 16:45, Erik Joelsson wrote: > With this patch the security tests will again be runnable on the > exploded jdk image. The main changes are: > > * The security classes are compiled separately to a different output > directory. > * The security jars are created in the jdk target (instead of images) > and put in the jdk/lib/... directories. > > Also did: > * Removed now redundant entries in rt.jar exclude list > * Changed source location for signing unsigned jars > * Made the SetupJavaCompilation macro more friendly with multiple > setups sharing output directories. > > http://cr.openjdk.java.net/~erikj/8009280/webrev.jdk.01/ > http://cr.openjdk.java.net/~erikj/8009280/webrev.root.01/ > > /Erik From naoto.sato at oracle.com Tue May 7 11:31:45 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 07 May 2013 18:31:45 +0000 Subject: hg: jdk8/tl/jdk: 8013086: NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied Message-ID: <20130507183159.253EB48896@hg.openjdk.java.net> Changeset: e30396e22c6f Author: naoto Date: 2013-05-07 11:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e30396e22c6f 8013086: NPE thrown by SimpleDateFormat with TimeZoneNameProvider supplied Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh From valerie.peng at oracle.com Tue May 7 12:07:05 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 07 May 2013 12:07:05 -0700 Subject: Code review request: 8012679: Let allow_weak_crypto default to false In-Reply-To: <51886B2D.70901@oracle.com> References: <51886B2D.70901@oracle.com> Message-ID: <518950D9.5030001@oracle.com> Changes look fine. Thanks, Valerie On 05/06/13 19:47, Weijun Wang wrote: > Webrev at > > http://cr.openjdk.java.net/~weijun/8012679/webrev.00/ > > Thanks > Max From mike.duigou at oracle.com Tue May 7 12:06:45 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 07 May 2013 19:06:45 +0000 Subject: hg: jdk8/tl/jdk: 4802647: Throw required NPEs from removeAll()/retainAll() Message-ID: <20130507190659.5BB8D4889A@hg.openjdk.java.net> Changeset: fe4e9bc2186f Author: mduigou Date: 2013-05-07 12:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe4e9bc2186f 4802647: Throw required NPEs from removeAll()/retainAll() Reviewed-by: mduigou, chegar, dholmes Contributed-by: Brandon Passanisi ! src/share/classes/java/util/AbstractCollection.java ! src/share/classes/java/util/AbstractSet.java ! src/share/classes/java/util/ArrayList.java ! test/java/util/Collection/MOAT.java From jonathan.gibbons at oracle.com Tue May 7 14:28:36 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 07 May 2013 21:28:36 +0000 Subject: hg: jdk8/tl/langtools: 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar Message-ID: <20130507212839.A34B0488A1@hg.openjdk.java.net> Changeset: 43c2f7cb9c76 Author: jjg Date: 2013-05-07 14:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/43c2f7cb9c76 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg can't delete plugin.jar Reviewed-by: vromero, mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + src/share/classes/com/sun/tools/javac/util/ServiceLoader.java ! test/tools/javac/plugin/showtype/Test.java From mike.duigou at oracle.com Tue May 7 16:19:54 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 07 May 2013 23:19:54 +0000 Subject: hg: jdk8/tl/jdk: 8012664: Add tests for java.util.stream and lambda translation Message-ID: <20130507232015.C328D488B7@hg.openjdk.java.net> Changeset: 6feee75b0a8b Author: briangoetz Date: 2013-05-06 11:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6feee75b0a8b 8012664: Add tests for java.util.stream and lambda translation Reviewed-by: mduigou, briangoetz Contributed-by: Brian Goetz , Paul Sandoz , Mike Duigou , Robert Field , Jim Gish ! test/Makefile + test/java/util/concurrent/atomic/AtomicReferenceTest.java + test/java/util/stream/bootlib/TEST.properties + test/java/util/stream/bootlib/java/util/stream/CollectorOps.java + test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/FlagDeclaringOp.java + test/java/util/stream/bootlib/java/util/stream/IntStreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/IntStreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/IntermediateTestOp.java + test/java/util/stream/bootlib/java/util/stream/LambdaTestHelpers.java + test/java/util/stream/bootlib/java/util/stream/LongStreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/LongStreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/OpTestCase.java + test/java/util/stream/bootlib/java/util/stream/SpliteratorTestHelper.java + test/java/util/stream/bootlib/java/util/stream/StatefulTestOp.java + test/java/util/stream/bootlib/java/util/stream/StatelessTestOp.java + test/java/util/stream/bootlib/java/util/stream/StreamOpFlagTestHelper.java + test/java/util/stream/bootlib/java/util/stream/StreamTestDataProvider.java + test/java/util/stream/bootlib/java/util/stream/StreamTestScenario.java + test/java/util/stream/bootlib/java/util/stream/TestData.java + test/java/util/stream/bootlib/java/util/stream/TestFlagExpectedOp.java + test/java/util/stream/boottest/TEST.properties + test/java/util/stream/boottest/java/util/stream/DoubleNodeTest.java + test/java/util/stream/boottest/java/util/stream/FlagOpTest.java + test/java/util/stream/boottest/java/util/stream/IntNodeTest.java + test/java/util/stream/boottest/java/util/stream/LongNodeTest.java + test/java/util/stream/boottest/java/util/stream/NodeBuilderTest.java + test/java/util/stream/boottest/java/util/stream/NodeTest.java + test/java/util/stream/boottest/java/util/stream/SpinedBufferTest.java + test/java/util/stream/boottest/java/util/stream/StreamFlagsTest.java + test/java/util/stream/boottest/java/util/stream/StreamOpFlagsTest.java + test/java/util/stream/boottest/java/util/stream/StreamReuseTest.java + test/java/util/stream/boottest/java/util/stream/UnorderedTest.java + test/java/util/stream/test/TEST.properties + test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/DeserializeMethodTest.java + test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/MHProxiesTest.java + test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/FillableStringTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/MapTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/NullArgsTestCase.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/CollectionAndMapModifyStreamTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/DoublePrimitiveOpsTests.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ExplodeOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/FilterOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/FindAnyOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/FindFirstOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ForEachOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/GroupByOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntPrimitiveOpsTests.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntReduceTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntSliceOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntUniqOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/LongPrimitiveOpsTests.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/MapOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/MatchOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/MinMaxTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/PrimitiveAverageOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/PrimitiveSumTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ReduceByOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ReduceTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorLateBindingFailFastTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTraversingAndSplittingTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamBuilderTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamLinkTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamParSeqTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamSpliteratorTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/SummaryStatisticsTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/TeeOpTest.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/ToArrayOpTest.java + test/jdk/lambda/ArrayCtorRefTest.java + test/jdk/lambda/FDTest.java + test/jdk/lambda/LambdaTranslationCompoundSamTest.java + test/jdk/lambda/LambdaTranslationInInterface.java + test/jdk/lambda/LambdaTranslationInnerConstructor.java + test/jdk/lambda/LambdaTranslationTest1.java + test/jdk/lambda/LambdaTranslationTest2.java + test/jdk/lambda/MethodReferenceTestFDCCE.java + test/jdk/lambda/MethodReferenceTestInnerDefault.java + test/jdk/lambda/MethodReferenceTestInnerInstance.java + test/jdk/lambda/MethodReferenceTestInnerVarArgsThis.java + test/jdk/lambda/MethodReferenceTestInstance.java + test/jdk/lambda/MethodReferenceTestInstanceMethod.java + test/jdk/lambda/MethodReferenceTestKinds.java + test/jdk/lambda/MethodReferenceTestNew.java + test/jdk/lambda/MethodReferenceTestNewInner.java + test/jdk/lambda/MethodReferenceTestSueCase1.java + test/jdk/lambda/MethodReferenceTestSueCase2.java + test/jdk/lambda/MethodReferenceTestSueCase4.java + test/jdk/lambda/MethodReferenceTestSuper.java + test/jdk/lambda/MethodReferenceTestSuperDefault.java + test/jdk/lambda/MethodReferenceTestTypeConversion.java + test/jdk/lambda/MethodReferenceTestVarArgs.java + test/jdk/lambda/MethodReferenceTestVarArgsExt.java + test/jdk/lambda/MethodReferenceTestVarArgsSuper.java + test/jdk/lambda/MethodReferenceTestVarArgsSuperDefault.java + test/jdk/lambda/MethodReferenceTestVarArgsThis.java + test/jdk/lambda/TEST.properties + test/jdk/lambda/TestInnerCtorRef.java + test/jdk/lambda/TestPrivateCtorRef.java + test/jdk/lambda/separate/AttributeInjector.java + test/jdk/lambda/separate/ClassFile.java + test/jdk/lambda/separate/ClassFilePreprocessor.java + test/jdk/lambda/separate/ClassToInterfaceConverter.java + test/jdk/lambda/separate/Compiler.java + test/jdk/lambda/separate/DirectedClassLoader.java + test/jdk/lambda/separate/SourceModel.java + test/jdk/lambda/separate/TestHarness.java + test/jdk/lambda/shapegen/ClassCase.java + test/jdk/lambda/shapegen/Hierarchy.java + test/jdk/lambda/shapegen/HierarchyGenerator.java + test/jdk/lambda/shapegen/Rule.java + test/jdk/lambda/shapegen/RuleGroup.java + test/jdk/lambda/shapegen/TTNode.java + test/jdk/lambda/shapegen/TTParser.java + test/jdk/lambda/shapegen/TTShape.java + test/jdk/lambda/vm/DefaultMethodRegressionTests.java + test/jdk/lambda/vm/DefaultMethodsTest.java + test/jdk/lambda/vm/InterfaceAccessFlagsTest.java + test/jdk/lambda/vm/StrictfpDefault.java From weijun.wang at oracle.com Tue May 7 17:26:14 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 08 May 2013 00:26:14 +0000 Subject: hg: jdk8/tl/jdk: 8012679: Let allow_weak_crypto default to false Message-ID: <20130508002627.168F2488BB@hg.openjdk.java.net> Changeset: 7d89b0dd973c Author: weijun Date: 2013-05-08 08:25 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d89b0dd973c 8012679: Let allow_weak_crypto default to false Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/crypto/EType.java ! test/sun/security/krb5/auto/DupEtypes.java ! test/sun/security/krb5/etype/WeakCrypto.java From valerie.peng at oracle.com Tue May 7 18:08:49 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 07 May 2013 18:08:49 -0700 Subject: Code Review Request for 8013069: javax.crypto tests fail with new PBE algorithm names Message-ID: <5189A5A1.5040707@oracle.com> Vinnie, Could you please help reviewing the fixes for 8013069 "javax.crypto tests fail with new PBE algorithm names"? Given that the current javax.crypto.Mac API doesn't provide a way to return algorithm parameters (unlike most of other crypto engine classes), I think it's better to error out when the needed parameters are missing. Webrev: http://cr.openjdk.java.net/~valeriep/8013069/webrev.00/ Thanks! Valerie From alan.bateman at oracle.com Wed May 8 10:03:43 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 08 May 2013 17:03:43 +0000 Subject: hg: jdk8/tl/jdk: 8013652: (profiles) Add javax.script to compact1 Message-ID: <20130508170355.73850488E2@hg.openjdk.java.net> Changeset: c8f47674d105 Author: alanb Date: 2013-05-08 18:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8f47674d105 8013652: (profiles) Add javax.script to compact1 Reviewed-by: mchung, dholmes ! makefiles/profile-rtjar-includes.txt From Vincent.X.Ryan at oracle.com Wed May 8 10:30:44 2013 From: Vincent.X.Ryan at oracle.com (Vincent Ryan) Date: Wed, 8 May 2013 18:30:44 +0100 Subject: Code Review Request for 8013069: javax.crypto tests fail with new PBE algorithm names In-Reply-To: <5189A5A1.5040707@oracle.com> References: <5189A5A1.5040707@oracle.com> Message-ID: Your fix looks good. Just a minor comment: should 'ic' be expanded to 'iteration count' in the exception message in HmacPKCS12PBESHA1.java and PBMAC1Core.java? On 8 May 2013, at 02:08, Valerie (Yu-Ching) Peng wrote: > Vinnie, > > Could you please help reviewing the fixes for 8013069 "javax.crypto tests fail with new PBE algorithm names"? > > Given that the current javax.crypto.Mac API doesn't provide a way to return algorithm parameters (unlike most of other crypto engine classes), I think it's better to error out when the needed parameters are missing. > > Webrev: http://cr.openjdk.java.net/~valeriep/8013069/webrev.00/ > > Thanks! > Valerie From jaroslav.bachorik at oracle.com Thu May 2 23:24:33 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Fri, 03 May 2013 06:24:33 +0000 Subject: hg: jdk8/tl/jdk: 7199324: Connection ID for IPv6 addresses is not generated accordingly to the specification Message-ID: <20130503062446.788CD487BA@hg.openjdk.java.net> Changeset: 470f19b6bfdd Author: jbachorik Date: 2013-05-02 13:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/470f19b6bfdd 7199324: Connection ID for IPv6 addresses is not generated accordingly to the specification Summary: RemoteServer.getClientHost is returning a String with an IPv6 literal address and we need to enclose it in [] when building the connection id Reviewed-by: alanb, sjiang ! src/share/classes/javax/management/remote/rmi/RMIServerImpl.java ! test/javax/management/remote/mandatory/connection/ConnectionTest.java From joel.franck at oracle.com Tue May 7 01:00:33 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 07 May 2013 08:00:33 +0000 Subject: hg: jdk8/tl/jdk: 8013541: Revise javadoc for Executable.getAnnotatedReturnType() Message-ID: <20130507080055.CBAA04886A@hg.openjdk.java.net> Changeset: 9c9b2385c1b0 Author: jfranck Date: 2013-05-07 09:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c9b2385c1b0 8013541: Revise javadoc for Executable.getAnnotatedReturnType() Reviewed-by: abuckley, darcy ! src/share/classes/java/lang/reflect/Executable.java From daniel.fuchs at oracle.com Tue May 7 02:58:24 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Tue, 07 May 2013 09:58:24 +0000 Subject: hg: jdk8/tl/jaxp: 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Message-ID: <20130507095833.BA0374886F@hg.openjdk.java.net> Changeset: 452e1a182907 Author: dfuchs Date: 2013-05-06 18:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/452e1a182907 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Summary: Encodings.java sometimes creates EncodingInfo objects whose java names are not recognized by the Charset API. This patch fixes that issue. Reviewed-by: joehw, alanb ! src/com/sun/org/apache/xml/internal/serializer/Encodings.java From daniel.fuchs at oracle.com Tue May 7 02:59:09 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Tue, 07 May 2013 09:59:09 +0000 Subject: hg: jdk8/tl/jdk: 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Message-ID: <20130507100036.C35C948870@hg.openjdk.java.net> Changeset: 2602eab5f086 Author: dfuchs Date: 2013-05-07 11:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2602eab5f086 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Summary: Encodings.java sometimes creates EncodingInfo objects whose java names are not recognized by the Charset API. This patch fixes that issue. Reviewed-by: joehw, alanb + test/javax/xml/jaxp/Encodings/CheckEncodingPropertiesFile.java From staffan.larsen at oracle.com Tue May 7 10:58:16 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 07 May 2013 17:58:16 +0000 Subject: hg: jdk8/tl/jdk: 6980985: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage is not robust when getMax() returns -1; ... Message-ID: <20130507175848.2F40E48885@hg.openjdk.java.net> Changeset: 7b40394ad944 Author: sla Date: 2013-05-07 19:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b40394ad944 6980985: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage is not robust when getMax() returns -1 7181907: TEST_BUG: j/l/management/MemoryMXBean/ResetPeakMemoryUsage fails with NegativeArraySizeException 7148492: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java failing since update to hs23-b15 or b16 Reviewed-by: mchung, brutisso ! test/ProblemList.txt ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java From staffan.larsen at oracle.com Tue May 7 11:02:05 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 07 May 2013 18:02:05 +0000 Subject: hg: jdk8/tl/jdk: 8004007: test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true Message-ID: <20130507180217.528FF48886@hg.openjdk.java.net> Changeset: 100027950b05 Author: sla Date: 2013-05-07 20:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/100027950b05 8004007: test/sun/tools/jinfo/Basic.sh fails on when runSA is set to true Reviewed-by: alanb, dsamersoff ! test/sun/tools/jinfo/Basic.sh From joel.franck at oracle.com Wed May 8 05:12:25 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Wed, 08 May 2013 12:12:25 +0000 Subject: hg: jdk8/tl/langtools: 8013485: javac can't handle annotations with a from a previous compilation unit Message-ID: <20130508121228.4FF20488D6@hg.openjdk.java.net> Changeset: 780014a234fa Author: jfranck Date: 2013-05-08 14:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/780014a234fa 8013485: javac can't handle annotations with a from a previous compilation unit Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/annotations/clinit/AnnoWithClinit1.java + test/tools/javac/annotations/clinit/AnnoWithClinitFail.java + test/tools/javac/annotations/clinit/AnnoWithClinitFail.out From valerie.peng at oracle.com Wed May 8 10:52:38 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Wed, 08 May 2013 10:52:38 -0700 Subject: Code Review Request for 8013069: javax.crypto tests fail with new PBE algorithm names In-Reply-To: References: <5189A5A1.5040707@oracle.com> Message-ID: <518A90E6.4000208@oracle.com> Sure, I have updated the webrev to expand ic into "iteration count" in the exception message to be consistent of other existing exception messages. Thanks for the quick review, Valerie On 05/08/13 10:30, Vincent Ryan wrote: > Your fix looks good. > > Just a minor comment: should 'ic' be expanded to 'iteration count' in the exception message > in HmacPKCS12PBESHA1.java and PBMAC1Core.java? > > > On 8 May 2013, at 02:08, Valerie (Yu-Ching) Peng wrote: > >> Vinnie, >> >> Could you please help reviewing the fixes for 8013069 "javax.crypto tests fail with new PBE algorithm names"? >> >> Given that the current javax.crypto.Mac API doesn't provide a way to return algorithm parameters (unlike most of other crypto engine classes), I think it's better to error out when the needed parameters are missing. >> >> Webrev: http://cr.openjdk.java.net/~valeriep/8013069/webrev.00/ >> >> Thanks! >> Valerie From mike.duigou at oracle.com Wed May 8 21:43:23 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 09 May 2013 04:43:23 +0000 Subject: hg: jdk8/tl: 8014269: Add missing .PHONY targets to Main.gmk Message-ID: <20130509044323.7ECAC4891F@hg.openjdk.java.net> Changeset: e2eb6bc06621 Author: mduigou Date: 2013-05-08 21:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e2eb6bc06621 8014269: Add missing .PHONY targets to Main.gmk Reviewed-by: mchung, tbell ! common/makefiles/Main.gmk From huizhe.wang at oracle.com Wed May 8 23:38:54 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Thu, 09 May 2013 06:38:54 +0000 Subject: hg: jdk8/tl/jaxp: 8011653: Upgrade JDK8 to JAXP 1.5 Message-ID: <20130509063858.C4C2148920@hg.openjdk.java.net> Changeset: 1e8d98012ab8 Author: joehw Date: 2013-05-08 23:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1e8d98012ab8 8011653: Upgrade JDK8 to JAXP 1.5 Reviewed-by: alanb, dfuchs ! src/com/sun/org/apache/xalan/internal/XalanConstants.java ! src/com/sun/org/apache/xalan/internal/utils/SecuritySupport.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Import.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Include.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ca.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_cs.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_de.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_es.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_fr.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_it.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ja.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ko.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_pt_BR.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sk.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sv.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_CN.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_TW.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMsg.java ! src/com/sun/org/apache/xalan/internal/xsltc/dom/LoadDocument.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java ! src/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java ! src/com/sun/org/apache/xerces/internal/impl/Constants.java ! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java ! src/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java ! src/com/sun/org/apache/xerces/internal/impl/xs/XSDDescription.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/AbstractXMLSchema.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XSGrammarPoolContainer.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/com/sun/org/apache/xerces/internal/utils/SecuritySupport.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java ! src/com/sun/xml/internal/stream/StaxXMLInputSource.java ! src/javax/xml/XMLConstants.java ! src/javax/xml/parsers/DocumentBuilderFactory.java ! src/javax/xml/parsers/SAXParser.java ! src/javax/xml/stream/XMLInputFactory.java ! src/javax/xml/transform/TransformerFactory.java ! src/javax/xml/validation/SchemaFactory.java ! src/javax/xml/validation/Validator.java From xuelei.fan at oracle.com Thu May 9 07:39:52 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 09 May 2013 22:39:52 +0800 Subject: Code review request, JDK-8005535: SSLSessionImpl should have protected finalize() Message-ID: <518BB538.4070605@oracle.com> Hi Max, Please review the simple fix to properly override the finalize() method. http://cr.openjdk.java.net/~xuelei/8005535/webrev.00/ Trivial update, no new regression test. Thanks, Xuelei From weijun.wang at oracle.com Thu May 9 07:45:33 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 09 May 2013 22:45:33 +0800 Subject: Code review request, JDK-8005535: SSLSessionImpl should have protected finalize() In-Reply-To: <518BB538.4070605@oracle.com> References: <518BB538.4070605@oracle.com> Message-ID: <518BB68D.7020202@oracle.com> There is no need to add final there. -Max On 5/9/13 10:39 PM, Xuelei Fan wrote: > Hi Max, > > Please review the simple fix to properly override the finalize() method. > > http://cr.openjdk.java.net/~xuelei/8005535/webrev.00/ > > Trivial update, no new regression test. > > Thanks, > Xuelei > From xuelei.fan at oracle.com Thu May 9 07:49:35 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 09 May 2013 22:49:35 +0800 Subject: Code review request, JDK-8005535: SSLSessionImpl should have protected finalize() In-Reply-To: <518BB68D.7020202@oracle.com> References: <518BB538.4070605@oracle.com> <518BB68D.7020202@oracle.com> Message-ID: <518BB77F.3040508@oracle.com> On 5/9/2013 10:45 PM, Weijun Wang wrote: > There is no need to add final there. > No, it is not necessary. I added the keyword just to make it "feel" more match the Object.finalize() declaration. Thanks, Xuelei > -Max > > On 5/9/13 10:39 PM, Xuelei Fan wrote: >> Hi Max, >> >> Please review the simple fix to properly override the finalize() method. >> >> http://cr.openjdk.java.net/~xuelei/8005535/webrev.00/ >> >> Trivial update, no new regression test. >> >> Thanks, >> Xuelei >> From kumar.x.srinivasan at oracle.com Thu May 9 08:10:16 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 09 May 2013 15:10:16 +0000 Subject: hg: jdk8/tl/jdk: 8013736: [launcher] cleanup code for correctness; ... Message-ID: <20130509151028.762904892B@hg.openjdk.java.net> Changeset: 3fd83f282c61 Author: ksrini Date: 2013-05-07 13:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fd83f282c61 8013736: [launcher] cleanup code for correctness 8005735: [parfait] False positive integer overflow in jdk/src/solaris/bin/jexec.c 8009873: [parfait] Memory leak at jdk/src/share/bin/wildcard.c 8005807: [parfait] Undefined return value at jdk/src/share/bin/java.c Reviewed-by: alanb, martin ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/bin/wildcard.c ! src/solaris/bin/jexec.c From jason.uh at oracle.com Thu May 9 12:02:00 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Thu, 09 May 2013 19:02:00 +0000 Subject: hg: jdk8/tl/jdk: 8007699: Move some tests from test/sun/security/provider/certpath/X509CertPath to closed repo Message-ID: <20130509190224.0881348939@hg.openjdk.java.net> Changeset: bb9cdfac1a7d Author: juh Date: 2013-05-09 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb9cdfac1a7d 8007699: Move some tests from test/sun/security/provider/certpath/X509CertPath to closed repo Reviewed-by: mullan - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java From mike.duigou at oracle.com Thu May 9 14:18:50 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 09 May 2013 21:18:50 +0000 Subject: hg: jdk8/tl/jdk: 8012646: Pattern.splitAsStream Message-ID: <20130509211915.77F494894C@hg.openjdk.java.net> Changeset: 498ea4c3a4c6 Author: psandoz Date: 2013-05-01 18:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/498ea4c3a4c6 8012646: Pattern.splitAsStream Reviewed-by: forax, plevart, alanb Contributed-by: Ben Evans , Paul Sandoz ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java From lana.steuck at oracle.com Thu May 9 16:22:19 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:22:19 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20130509232223.5EDBE48971@hg.openjdk.java.net> Changeset: 1f13a798d1b8 Author: katleman Date: 2013-05-02 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/1f13a798d1b8 Added tag jdk8-b88 for changeset 4e3a881ebb1e ! .hgtags Changeset: fe4150590ee5 Author: lana Date: 2013-05-06 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/fe4150590ee5 Merge From lana.steuck at oracle.com Thu May 9 16:22:21 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:22:21 +0000 Subject: hg: jdk8/tl: 8 new changesets Message-ID: <20130509232222.9079848970@hg.openjdk.java.net> Changeset: 1dfcc874461e Author: omajid Date: 2013-04-29 12:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1dfcc874461e 8013480: fix zero build on arm Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in Changeset: 7e7582e961ba Author: jwilhelm Date: 2013-04-25 16:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7e7582e961ba 7074926: create Solaris Studio IDE (Netbeans) project for hotspot sources Summary: Project files for hotspot delevopment in Solaris Studio and NetBeans. Also reviewed by vladimir.voskresensky at oracle.com Reviewed-by: erikj, dsamersoff + common/nb_native/nbproject/configurations.xml + common/nb_native/nbproject/project.xml Changeset: b9bf111a9547 Author: katleman Date: 2013-04-30 14:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b9bf111a9547 Merge Changeset: e404d321abc6 Author: erikj Date: 2013-05-02 15:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e404d321abc6 8013786: JDK-8013480 broke configure on solaris Reviewed-by: tbell ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/toolchain.m4 Changeset: e1a929afcfc4 Author: erikj Date: 2013-05-02 15:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e1a929afcfc4 8011687: Support correct dependencies from header files on windows and solaris Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 ! common/makefiles/NativeCompilation.gmk Changeset: 8fb91165e596 Author: katleman Date: 2013-05-02 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8fb91165e596 Added tag jdk8-b88 for changeset e1a929afcfc4 ! .hgtags Changeset: 892a0196d10c Author: lana Date: 2013-05-06 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/892a0196d10c Merge ! common/makefiles/NativeCompilation.gmk Changeset: 49ea9293fa49 Author: lana Date: 2013-05-09 14:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/49ea9293fa49 Merge From lana.steuck at oracle.com Thu May 9 16:22:19 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:22:19 +0000 Subject: hg: jdk8/tl/jaxws: Added tag jdk8-b88 for changeset 24fa5452e5d4 Message-ID: <20130509232229.8D32B48972@hg.openjdk.java.net> Changeset: 88838e08e4ef Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/88838e08e4ef Added tag jdk8-b88 for changeset 24fa5452e5d4 ! .hgtags From lana.steuck at oracle.com Thu May 9 16:22:23 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:22:23 +0000 Subject: hg: jdk8/tl/jaxp: 4 new changesets Message-ID: <20130509232240.7620248974@hg.openjdk.java.net> Changeset: 21f75e572cb3 Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/21f75e572cb3 Added tag jdk8-b88 for changeset 7122f7bb0fcc ! .hgtags Changeset: 893d2ba8bbea Author: lana Date: 2013-05-06 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/893d2ba8bbea Merge Changeset: 6976616f5753 Author: lana Date: 2013-05-08 22:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6976616f5753 Merge Changeset: 9e4dfe933ba9 Author: lana Date: 2013-05-09 14:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/9e4dfe933ba9 Merge From lana.steuck at oracle.com Thu May 9 16:22:27 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:22:27 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20130509232230.915E148973@hg.openjdk.java.net> Changeset: 501bc4aeb1b1 Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/501bc4aeb1b1 Added tag jdk8-b88 for changeset 40c107d1ae6f ! .hgtags Changeset: 45ce27fbe272 Author: lana Date: 2013-05-06 11:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/45ce27fbe272 Merge - src/jdk/nashorn/internal/codegen/Frame.java - src/jdk/nashorn/internal/ir/DoWhileNode.java - src/jdk/nashorn/internal/ir/LabeledNode.java From lana.steuck at oracle.com Thu May 9 16:22:27 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:22:27 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20130509232242.33B1148975@hg.openjdk.java.net> Changeset: adec2a5d510a Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/adec2a5d510a Added tag jdk8-b88 for changeset a1e10f3adc47 ! .hgtags Changeset: ec434cfd2752 Author: lana Date: 2013-05-06 11:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec434cfd2752 Merge - make/Makefile-classic Changeset: c68834236058 Author: lana Date: 2013-05-08 23:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c68834236058 Merge From lana.steuck at oracle.com Thu May 9 16:23:06 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:23:06 +0000 Subject: hg: jdk8/tl/hotspot: 66 new changesets Message-ID: <20130509232912.050B148978@hg.openjdk.java.net> Changeset: d0081bfc425c Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d0081bfc425c Added tag jdk8-b88 for changeset 8482058e74bc ! .hgtags Changeset: 57ac6a688ae6 Author: amurillo Date: 2013-04-26 00:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/57ac6a688ae6 8013227: new hotspot build - hs25-b31 Reviewed-by: jcoomes ! make/hotspot_version Changeset: cc70cbbd422e Author: hseigel Date: 2013-04-24 09:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cc70cbbd422e 8012695: Assertion message displays %u and %s text instead of actual values Summary: USe err_msg() to create a proper assertion message. Reviewed-by: twisti, coleenp, iklam ! src/share/vm/classfile/classFileParser.hpp Changeset: fbca7eaeac2e Author: zgu Date: 2013-04-24 14:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fbca7eaeac2e 8011218: Kitchensink hanged, likely NMT is to blame Summary: Made NMT query safepoint aware. Reviewed-by: dholmes, coleenp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memBaseline.hpp ! src/share/vm/services/memTracker.cpp Changeset: d587a5c30bd8 Author: coleenp Date: 2013-04-24 16:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d587a5c30bd8 8011803: release_C_heap_structures is never called for anonymous classes. Summary: Call this function from the ClassLoaderData destructor instead of the system dictionary walk. Reviewed-by: stefank, mgerdin ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: d66a24adbe3f Author: coleenp Date: 2013-04-24 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d66a24adbe3f Merge Changeset: 15a99ca4ee34 Author: sspitsyn Date: 2013-04-25 03:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/15a99ca4ee34 8007037: JSR 292: the VM_RedefineClasses::append_entry() should do cross-checks with indy operands Summary: References from operands to CP entries and back must be correct after CP merge Reviewed-by: coleenp, twisti Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp Changeset: c115fac239eb Author: iklam Date: 2013-04-25 12:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c115fac239eb 8008962: NPG: Memory regression: One extra Monitor per ConstantPool Summary: Re-use InstanceKlass::_init_lock locking ConstantPool as well. Reviewed-by: dholmes, coleenp, acorn ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiEnv.cpp Changeset: 3c9b7ef92c61 Author: dcubed Date: 2013-04-26 08:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c9b7ef92c61 Merge Changeset: d1644a010f52 Author: emc Date: 2013-04-26 07:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d1644a010f52 8007154: Remove support for u4 MethodParameter flags fields Summary: Remove support for parsing class files with four-byte flags fields in MethodParameters attributes Reviewed-by: jrose, coleenp ! src/share/vm/classfile/classFileParser.cpp Changeset: f258c5828eb8 Author: hseigel Date: 2013-04-29 16:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f258c5828eb8 8011773: Some tests on Interned String crashed JVM with OOM Summary: Instead of terminating the VM, throw OutOfMemoryError exceptions. Reviewed-by: coleenp, dholmes ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/oops/oop.cpp ! src/share/vm/prims/whitebox.cpp Changeset: c53e49efe6a8 Author: hseigel Date: 2013-04-29 16:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c53e49efe6a8 Merge Changeset: f32b6c267d2e Author: mikael Date: 2013-04-29 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f32b6c267d2e 8012015: Use PROT_NONE when reserving memory Summary: Reserved memory had PROT_READ+PROT_WRITE access on Linux/bsd, now changed to PROT_NONE. Reviewed-by: dholmes, ctornqvi ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/share/vm/prims/whitebox.cpp + test/runtime/memory/ReserveMemory.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: 9f96b7a853bc Author: sla Date: 2013-04-30 10:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9f96b7a853bc 8013466: SA crashes when attaching to a process on OS X Reviewed-by: coleenp, rbackman, minqi ! agent/src/os/bsd/MacosxDebuggerLocal.m Changeset: 409d4b59e095 Author: sla Date: 2013-04-30 02:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/409d4b59e095 Merge Changeset: ed5a590835a4 Author: zgu Date: 2013-04-30 09:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ed5a590835a4 8013214: BigApps fails due to 'fatal error: Illegal threadstate encountered: 6' Summary: Grab and drop SR_lock to get the thread to honor the safepoint protocol Reviewed-by: dcubed, coleenp ! src/share/vm/services/memBaseline.cpp Changeset: 746b070f5022 Author: ccheung Date: 2013-04-30 11:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/746b070f5022 8011661: Insufficient memory message says "malloc" when sometimes it should say "mmap" Reviewed-by: coleenp, zgu, hseigel ! src/os/solaris/vm/os_solaris.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/code/stubs.cpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/objectStartArray.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/blockOffsetTable.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/oops/oop.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/debug.hpp ! src/share/vm/utilities/vmError.cpp ! src/share/vm/utilities/vmError.hpp ! src/share/vm/utilities/workgroup.cpp Changeset: e4614b063fe1 Author: sla Date: 2013-04-30 21:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e4614b063fe1 8013364: SA-JDI exceptions caused by lack of permissions on OSX should be more verbose about issue cause Reviewed-by: coleenp, rbackman ! agent/src/os/bsd/MacosxDebuggerLocal.m Changeset: 376ff861f611 Author: sla Date: 2013-05-01 01:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/376ff861f611 Merge Changeset: b4081e9714ec Author: vladidan Date: 2013-04-30 17:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b4081e9714ec 8013398: Adjust number of stack guard pages on systems with large memory page size Summary: Auto adjust number of stack guard pages on systems with large memory page size Reviewed-by: bobv, coleenp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp Changeset: 1847df492437 Author: vladidan Date: 2013-05-01 10:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1847df492437 Merge Changeset: 08236d966eea Author: bharadwaj Date: 2013-05-01 08:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/08236d966eea 8013418: assert(i == total_args_passed) in AdapterHandlerLibrary::get_adapter since 8-b87 Summary: Do not treat static methods as miranda methods. Reviewed-by: dholmes, acorn ! src/share/vm/oops/klassVtable.cpp + test/runtime/lambda-features/PublicStaticInterfaceMethodHandling.java Changeset: 8fe2542bdc8d Author: bharadwaj Date: 2013-05-01 09:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8fe2542bdc8d Merge Changeset: a6e09d6dd8e5 Author: dlong Date: 2013-04-24 20:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a6e09d6dd8e5 8003853: specify offset of IC load in java_to_interp stub Summary: refactored code to allow platform-specific differences Reviewed-by: dlong, twisti Contributed-by: Goetz Lindenmaier + src/cpu/sparc/vm/compiledIC_sparc.cpp ! src/cpu/sparc/vm/sparc.ad + src/cpu/x86/vm/compiledIC_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad + src/cpu/zero/vm/compiledIC_zero.cpp ! src/share/vm/adlc/main.cpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/compiledIC.hpp ! src/share/vm/opto/output.cpp Changeset: e10e43e58e92 Author: dlong Date: 2013-04-24 21:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e10e43e58e92 Merge - make/bsd/makefiles/jvmg.make - make/bsd/makefiles/profiled.make - make/linux/makefiles/jvmg.make - make/linux/makefiles/profiled.make - make/solaris/makefiles/jvmg.make - make/solaris/makefiles/profiled.make ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad - src/os/bsd/vm/chaitin_bsd.cpp - src/os/linux/vm/chaitin_linux.cpp - src/os/solaris/vm/chaitin_solaris.cpp - src/os/windows/vm/chaitin_windows.cpp ! src/share/vm/opto/output.cpp - test/gc/6941923/test6941923.sh - test/gc/TestVerifyBeforeGCDuringStartup.java - test/runtime/NMT/AllocTestType.java Changeset: 3c0584fec1e6 Author: dholmes Date: 2013-04-28 18:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c0584fec1e6 8010428: Special -agentpath checks needed with minimal VM to produce proper error message Reviewed-by: dholmes, alanb, cjplummer, olagneau Contributed-by: Carlos Lucasius ! src/share/vm/runtime/arguments.cpp Changeset: 78603aa58b1e Author: jiangli Date: 2013-04-26 16:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/78603aa58b1e Merge ! src/cpu/x86/vm/x86_64.ad Changeset: e01e02a9fcb6 Author: jiangli Date: 2013-04-29 01:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e01e02a9fcb6 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 052caeaeb771 Author: jiangli Date: 2013-05-02 12:16 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/052caeaeb771 Merge Changeset: 8f9fae155577 Author: jiangli Date: 2013-05-02 13:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8f9fae155577 Merge Changeset: c23dbf0e8ab7 Author: jmasa Date: 2013-03-01 10:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c23dbf0e8ab7 8011268: NPG: Free unused VirtualSpaceNodes Reviewed-by: mgerdin, coleenp, johnc ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp Changeset: bfe3be9ebd6c Author: kevinw Date: 2013-04-18 17:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bfe3be9ebd6c 7109087: gc/7072527/TestFullGCCount.java fails when GC is set in command-line Reviewed-by: mgerdin ! test/gc/7072527/TestFullGCCount.java Changeset: 12927badda81 Author: kevinw Date: 2013-04-19 05:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/12927badda81 Merge Changeset: d391427ddc29 Author: mgerdin Date: 2013-04-22 10:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d391427ddc29 Merge Changeset: a08c80e9e1e5 Author: stefank Date: 2013-04-22 20:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a08c80e9e1e5 8012687: Remove unused is_root checks and closures Reviewed-by: tschatzl, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/sharedHeap.hpp Changeset: ebded0261dfc Author: jmasa Date: 2013-04-22 22:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ebded0261dfc 8012111: Remove warning about CMS generation shrinking. Reviewed-by: johnc, brutisso, stefank ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp + test/gc/concurrentMarkSweep/GuardShrinkWarning.java Changeset: 1cb4795305b9 Author: mgerdin Date: 2013-04-23 08:39 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1cb4795305b9 8011802: NPG: init_dependencies in class loader data graph can cause invalid CLD Summary: Restructure initialization of ClassLoaderData to not add a new instance if init_dependencies fail Reviewed-by: stefank, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/classfile/classLoaderData.inline.hpp Changeset: 5c93c1f61226 Author: johnc Date: 2013-04-18 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5c93c1f61226 8011724: G1: Stack allocate instances of HeapRegionRemSetIterator Summary: Stack allocate instances of HeapRegionRemSetIterator during RSet scanning. Reviewed-by: brutisso, jwilhelm ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp Changeset: 868d87ed63c8 Author: jmasa Date: 2013-02-12 14:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/868d87ed63c8 8008966: NPG: Inefficient Metaspace counter functions cause large young GC regressions Reviewed-by: mgerdin, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/metaspaceCounters.hpp ! src/share/vm/memory/metaspaceShared.cpp Changeset: 9d75bcd7c890 Author: mgerdin Date: 2013-04-24 19:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9d75bcd7c890 8013136: NPG: Parallel class loading tests fail after fix for JDK-8011802 Summary: Move initialization of dependencies to before allocation of CLD Reviewed-by: stefank, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp Changeset: d50cc62e94ff Author: johnc Date: 2013-04-24 14:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d50cc62e94ff 8012715: G1: GraphKit accesses PtrQueue::_index as int but is size_t Summary: In graphKit INT operations were generated to access PtrQueue::_index which has type size_t. This is 64 bit on 64-bit machines. No problems occur on little endian machines as long as the index fits into 32 bit, but on big endian machines the upper part is read, which is zero. This leads to unnecessary branches to the slow path in the runtime. Reviewed-by: twisti, johnc Contributed-by: Martin Doerr ! src/share/vm/opto/graphKit.cpp Changeset: b06ac540229e Author: stefank Date: 2013-04-24 20:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b06ac540229e 8013132: Add a flag to turn off the output of the verbose verification code Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vm_operations.hpp Changeset: b294421fa3c5 Author: brutisso Date: 2013-04-26 09:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b294421fa3c5 8012915: ReservedSpace::align_reserved_region() broken on Windows Summary: remove unused constructors and helper methods for ReservedHeapSpace and ReservedSpace Reviewed-by: mgerdin, jmasa, johnc, tschatzl ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp Changeset: 2f50bc369470 Author: stefank Date: 2013-04-26 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2f50bc369470 8013160: NPG: Remove unnecessary mark stack draining after CodeCache::do_unloading Reviewed-by: coleenp, mgerdin ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/memory/genMarkSweep.cpp Changeset: 3edf23423bb2 Author: johnc Date: 2013-04-26 10:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3edf23423bb2 8011898: gc/TestVerifyBeforeGCDuringStartup.java: java.lang.RuntimeException: '[Verifying' missing from stdout/stderr: [Error: Could not find or load main class] Summary: System.getProperty("test.java.opts") can return NULL, which gets converted to to the empty string, and the child java command then interprets that as the name of the main class. Reviewed-by: jmasa, brutisso ! test/gc/TestVerifyDuringStartup.java Changeset: caac22686b17 Author: mgerdin Date: 2013-04-29 09:31 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/caac22686b17 Merge ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/runtime/thread.cpp Changeset: 601183f604b2 Author: mgerdin Date: 2013-04-29 13:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/601183f604b2 8013129: Possible deadlock with Metaspace locks due to mixed usage of safepoint aware and non-safepoint aware locking Summary: Change Metaspace::deallocate to take lock with _no_safepoint_check_flag Reviewed-by: coleenp, jmasa, dholmes ! src/share/vm/memory/metaspace.cpp Changeset: 9075044ed66b Author: ehelin Date: 2013-04-30 16:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9075044ed66b 8008541: Remove old code in HotSpot that supported the jmap -permstat functionality Reviewed-by: sla, brutisso ! agent/src/share/classes/sun/jvm/hotspot/tools/JMap.java Changeset: d58c62b7447d Author: mgerdin Date: 2013-05-02 19:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d58c62b7447d Merge ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp Changeset: cbd4ce58f1f3 Author: mgerdin Date: 2013-05-02 16:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cbd4ce58f1f3 Merge Changeset: e12c9b3740db Author: vlivanov Date: 2013-04-25 11:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e12c9b3740db 8012260: ciReplay: Include PID into the name of replay data file Reviewed-by: kvn, twisti ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/posix/vm/os_posix.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/ostream.hpp ! src/share/vm/utilities/vmError.cpp Changeset: dc7db03f5aa2 Author: iignatyev Date: 2013-04-25 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dc7db03f5aa2 8012337: Change Whitebox implementation to make absence of method in Whitebox.class not fatal Reviewed-by: kvn, vlivanov ! src/share/vm/prims/whitebox.cpp + test/sanity/WhiteBox.java Changeset: 7b23cb975cf2 Author: iignatyev Date: 2013-04-25 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7b23cb975cf2 8011675: adding compilation level to replay data Reviewed-by: kvn, vlivanov - agent/doc/c2replay.html + agent/doc/cireplay.html ! agent/doc/clhsdb.html ! agent/src/share/classes/sun/jvm/hotspot/ci/ciEnv.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/CompileTask.java ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp + test/compiler/ciReplay/TestSA.sh + test/compiler/ciReplay/TestVM.sh + test/compiler/ciReplay/TestVM_no_comp_level.sh + test/compiler/ciReplay/common.sh Changeset: 247342108a11 Author: neliasso Date: 2013-04-23 13:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/247342108a11 8010332: removed unused method: ciMethod::uses_monitors Reviewed-by: twisti, roland Contributed-by: albert.noll at oracle.com ! src/share/vm/ci/ciMethod.hpp Changeset: a5c95fcf7cb7 Author: neliasso Date: 2013-04-23 18:06 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a5c95fcf7cb7 8012157: removed unused code in SharedRuntime::handle_wrong_method Reviewed-by: kvn, roland, rbackman Contributed-by: albert.noll at oracle.com ! src/share/vm/runtime/sharedRuntime.cpp Changeset: d1c9384eecb4 Author: iignatyev Date: 2013-04-26 07:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d1c9384eecb4 8012322: Tiered: CompilationPolicy::can_be_compiled(CompLevel_all) mistakenly return false Reviewed-by: kvn, vlivanov ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! test/compiler/whitebox/CompilerWhiteBoxTest.java ! test/compiler/whitebox/MakeMethodNotCompilableTest.java Changeset: 93b8272814cf Author: vlivanov Date: 2013-04-26 08:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/93b8272814cf Merge Changeset: 0b55a78c6be5 Author: bharadwaj Date: 2013-04-26 10:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0b55a78c6be5 Merge - agent/doc/c2replay.html ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fd49109d0d88 Author: bharadwaj Date: 2013-04-26 14:50 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fd49109d0d88 Merge Changeset: 487d442ef257 Author: jiangli Date: 2013-04-26 16:21 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/487d442ef257 8013036: vm/runtime/simpleThresholdPolicy.cpp: assert(mcs != NULL). Summary: Change the assert to if check as MethodCounters could be NULL under TieredCompilation. Reviewed-by: kvn, twisti ! src/share/vm/runtime/simpleThresholdPolicy.cpp Changeset: 62b683108582 Author: jiangli Date: 2013-04-26 14:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/62b683108582 Merge Changeset: 0cfa93c2fcc4 Author: neliasso Date: 2013-04-29 13:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0cfa93c2fcc4 8012547: Code cache flushing can get stuck reclaming of memory Summary: Keep sweeping regardless of if we are flushing Reviewed-by: kvn, twisti ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp Changeset: e4e131b15d5c Author: roland Date: 2013-05-02 10:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e4e131b15d5c 8013532: Remove unused parameter "compiler" from DTRACE_METHOD_COMPILE* macros Summary: remove unused parameter in dtrace macros Reviewed-by: kvn, roland Contributed-by: albert.noll at oracle.com ! src/share/vm/compiler/compileBroker.cpp Changeset: 9ce110b1d14a Author: kvn Date: 2013-05-02 18:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9ce110b1d14a Merge - agent/doc/c2replay.html ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/vmError.cpp Changeset: 4ec913499722 Author: amurillo Date: 2013-05-03 08:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4ec913499722 Merge - agent/doc/c2replay.html Changeset: 9c1fe0b419b4 Author: amurillo Date: 2013-05-03 08:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9c1fe0b419b4 Added tag hs25-b31 for changeset 4ec913499722 ! .hgtags From lana.steuck at oracle.com Thu May 9 16:26:02 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 09 May 2013 23:26:02 +0000 Subject: hg: jdk8/tl/jdk: 30 new changesets Message-ID: <20130509233415.263C54897B@hg.openjdk.java.net> Changeset: 78d08fc2dd12 Author: mullan Date: 2013-04-25 11:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78d08fc2dd12 8011313: OCSP timeout set to wrong value if com.sun.security.ocsp.timeout not defined Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/OCSP.java Changeset: 3e282678a885 Author: mullan Date: 2013-04-25 15:48 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e282678a885 8013228: Create new system properties to control allowable OCSP clock skew and CRL connection timeout Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/CertPathHelper.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java Changeset: 7c4eb715c5e8 Author: ngthomas Date: 2013-04-30 21:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c4eb715c5e8 Merge Changeset: 12af7c32c648 Author: omajid Date: 2013-04-29 12:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12af7c32c648 8013480: fix zero build on arm Reviewed-by: erikj ! makefiles/GensrcX11Wrappers.gmk Changeset: 7a96ead5ea89 Author: katleman Date: 2013-04-30 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a96ead5ea89 Merge Changeset: 55c7b90fe57e Author: katleman Date: 2013-05-01 14:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55c7b90fe57e Merge Changeset: 8dbb4b159e04 Author: erikj Date: 2013-05-02 15:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8dbb4b159e04 8013552: Add build support for different man pages for OpenJDK and OracleJDK Reviewed-by: tbell, omajid ! makefiles/Images.gmk Changeset: 1daef88acff2 Author: katleman Date: 2013-05-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1daef88acff2 Added tag jdk8-b88 for changeset 8dbb4b159e04 ! .hgtags Changeset: b0c41789f500 Author: jgodinez Date: 2013-04-25 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b0c41789f500 8009199: Printed text become garbage on Mac OSX Reviewed-by: bae, prr ! src/macosx/native/sun/awt/CTextPipe.m Changeset: f4aa34a7a44d Author: jchen Date: 2013-04-29 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4aa34a7a44d 8005302: [findbugs] public methods return internal arrays; may be private Reviewed-by: bae, prr ! src/share/classes/sun/java2d/pipe/AAShapePipe.java Changeset: 46686202aa23 Author: lana Date: 2013-04-30 22:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46686202aa23 Merge Changeset: c70346f4c0a9 Author: pchelko Date: 2013-04-18 15:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c70346f4c0a9 8011686: AWT accidentally disables the NSApplicationDelegate of SWT, causing loss of OS X integration functionality Reviewed-by: anthony, serb Contributed-by: Markus Persson ! src/macosx/native/sun/awt/awt.m Changeset: ac92ac05dde4 Author: kshefov Date: 2013-04-22 18:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac92ac05dde4 8011230: [TEST_BUG] java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java failed on solaris Reviewed-by: serb, anthony ! test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.sh Changeset: 578fb8766200 Author: leonidr Date: 2013-04-22 19:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/578fb8766200 8008366: [macosx] ActionListener called twice for JMenuItem using ScreenMenuBar Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/AWTEvent.h ! src/macosx/native/sun/awt/AWTEvent.m ! src/macosx/native/sun/awt/CMenuItem.m ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java Changeset: 0894b8476a49 Author: lana Date: 2013-04-23 15:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0894b8476a49 Merge - src/share/classes/java/time/chrono/HijrahDeviationReader.java - src/share/classes/java/time/format/DateTimeBuilder.java - src/share/classes/java/time/format/DateTimeFormatStyleProvider.java - src/share/classes/java/time/temporal/Adjusters.java - src/share/classes/java/time/temporal/Queries.java - src/share/classes/sun/java2d/cmm/lcms/META-INF/services/sun.java2d.cmm.PCMM - src/share/native/java/lang/ResourceBundle.c - test/java/time/tck/java/time/TestChronology.java - test/java/time/tck/java/time/chrono/TestChronoLocalDate.java - test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java - test/java/time/tck/java/time/chrono/TestHijrahChronology.java - test/java/time/tck/java/time/chrono/TestJapaneseChronology.java - test/java/time/tck/java/time/chrono/TestMinguoChronology.java - test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java - test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java - test/java/time/tck/java/time/temporal/TestChronoLocalDate.java - test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java - test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java - test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java - test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java - test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java - test/java/util/ComparatorsTest.java Changeset: 7103434eefe2 Author: kshefov Date: 2013-04-24 11:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7103434eefe2 8011186: [TEST_BUG] java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java failed on windows 8 Reviewed-by: anthony, serb, ant - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java + test/java/awt/Focus/SimpleWindowActivationTest/SimpleWindowActivationTest.java Changeset: 854f60ec4bfb Author: anthony Date: 2013-04-26 18:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/854f60ec4bfb 8012586: [x11] Modal dialogs for fullscreen window may show behind its owner Summary: Use the _NET_WM_WINDOW_TYPE_DIALOG type for owned windows Reviewed-by: anthony, art, serb Contributed-by: Vladimir Kravets ! src/solaris/classes/sun/awt/X11/XWindowPeer.java + test/java/awt/WMSpecificTests/Metacity/FullscreenDialogModality.java Changeset: e76f3e8e653f Author: malenkov Date: 2013-04-29 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e76f3e8e653f 8007458: [findbugs] One more beans issue, with ReflectionUtils Reviewed-by: art, alexsch ! src/share/classes/java/beans/MetaData.java - src/share/classes/java/beans/ReflectionUtils.java ! src/share/classes/java/beans/XMLEncoder.java ! test/java/beans/XMLEncoder/AbstractTest.java ! test/java/beans/XMLEncoder/BeanValidator.java ! test/java/beans/XMLEncoder/Test4631471.java ! test/java/beans/XMLEncoder/Test4679556.java ! test/java/beans/XMLEncoder/java_awt_BorderLayout.java + test/java/beans/XMLEncoder/java_awt_CardLayout.java + test/java/beans/XMLEncoder/java_awt_GridBagLayout.java ! test/java/beans/XMLEncoder/javax_swing_DefaultCellEditor.java Changeset: 358acb00cb2d Author: mcherkas Date: 2013-04-30 13:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/358acb00cb2d 8012004: JInternalFrame not being finalized after closing Reviewed-by: alexsch, alexp ! src/share/classes/javax/swing/JDesktopPane.java + test/javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java Changeset: 31e111f82993 Author: serb Date: 2013-04-30 17:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31e111f82993 7166296: closed/java/awt/Frame/DisabledParentOfToplevel/DisabledParentOfToplevel.html failed since 1.8.0b36 Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Window.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: caeedce39396 Author: serb Date: 2013-05-01 12:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/caeedce39396 8009012: [macosx] DisplayChangedListener is not implemented in LWWindowPeer/CGraphicsEnvironment Reviewed-by: anthony, bae ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/classes/sun/awt/CGraphicsEnvironment.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/CGraphicsEnv.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m Changeset: c357c11f076f Author: lana Date: 2013-05-01 09:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c357c11f076f Merge Changeset: 920ad6c95d93 Author: lana Date: 2013-05-01 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/920ad6c95d93 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java Changeset: f6f2802f980c Author: lana Date: 2013-05-01 11:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6f2802f980c Merge - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: 336a110f1196 Author: lana Date: 2013-05-06 11:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/336a110f1196 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: 88125d32eb06 Author: andrew Date: 2013-05-04 17:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88125d32eb06 8011366: Enable debug info on all libraries for OpenJDK builds Summary: The build should not be turning off debugging if it has been requested. Reviewed-by: erikj, dholmes ! makefiles/CompileNativeLibraries.gmk Changeset: 7ba77fff0ef6 Author: katleman Date: 2013-05-07 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ba77fff0ef6 Merge Changeset: 845025546e35 Author: katleman Date: 2013-05-07 13:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/845025546e35 Merge Changeset: 573a593379cb Author: lana Date: 2013-05-08 23:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/573a593379cb Merge ! makefiles/CompileNativeLibraries.gmk ! makefiles/Images.gmk - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java Changeset: 2023e3d573eb Author: lana Date: 2013-05-09 14:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2023e3d573eb Merge - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java From weijun.wang at oracle.com Fri May 10 01:56:06 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 10 May 2013 16:56:06 +0800 Subject: doPrivileged with lambda Message-ID: <518CB626.9090000@oracle.com> So we have been writing x = AccessController.doPrivileged( new PrivilegedAction() { public Object run() { return some(); } } ); Using jdk8 lambda, it seems we can write x = AccessController.doPrivileged(() -> some()); But it does not compile, because () -> some() matches both PrivilegedAction and PrivilegedExceptionAction. So it has to be x = AccessController.doPrivileged( (PrivilegedAction)(() -> some())); which is cumbersome again. I'm not requesting for any new API at the moment, just talking about my frustration. -Max From eronenp at gmail.com Fri May 10 02:00:44 2013 From: eronenp at gmail.com (Pasi Eronen) Date: Fri, 10 May 2013 12:00:44 +0300 Subject: 9001039?: DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times Message-ID: AKA "1 out of 256 SSL/TLS handshakes fails with DHE cipher suites" I reported this bug over a month of ago, but for some reason, it's not yet visible at bugs.sun.com. I've included the bug report below just in case. It seems this commit from March 2012 inadvertently broke SSL/TLS DHE cipher suites, causing the SSL/TLS handshake to fail approximately 1 out of 256 times: http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 The commit was done to fix this bug: http://bugs.sun.com/view_bug.do?bug_id=7146728 While generating a secret of the same length as modulus may be the right choice generally speaking (and it's what e.g. IPsec uses), SSL/TLS uses a different convention: leading zeroes must be stripped. This is currently blocking us from updating our production systems to Java 7, so although I have not contributed to OpenJDK before, I'd like to submit a patch and a test case for this (I've signed the OCA already). But before I do this, I'd like to check that the approach is agreeable. We have a separate "algorithm" value "TlsPremasterSecret", so behavior for other cases could stay the same. Would a patch like this: } else if (algorithm.equals("TlsPremasterSecret")) { // remove leading zero bytes per RFC 5246 Section 8.1.2 int i = 0; while ((i < secret.length - 1) && (secret[i] == 0)) { i++; } if (i == 0) { return new SecretKeySpec(secret, "TlsPremasterSecret"); } else { byte[] secret2 = new byte[secret.length - i]; System.arraycopy(secret, i, secret2, 0, secret2.length); return new SecretKeySpec(secret2, "TlsPremasterSecret"); } } Plus a test case (with fixed keys) that checks that leading zero is stripped for TlsPremasterSecret and is not stripped otherwise, be sufficient? Best regards, Pasi ---snip--- Synopsis: DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times Full OS version: Tested on Windows 7 (Microsoft Windows [Version 6.1.7601]), but occurs in e..g OpenJDK 7 as well. Development Kit or Runtime version: java version "1.7.0_17" Java(TM) SE Runtime Environment (build 1.7.0_17-b02) Java HotSpot(TM) Client VM (build 23.7-b01, mixed mode, sharing) Description: When performing Diffie-Hellman key agreement for SSL/TLS, the TLS specification (RFC 5246) says that "Leading bytes of Z that contain all zero bits are stripped before it is used as the pre_master_secret." However, com.sun.crypto.provider.DHKeyAgreement.java does not strip leading zero bytes. This causes approximately 1 out 256 SSL/TLS handshakes with DH/DHE cipher suites to fail (when the leading byte happens, by chance, to be zero). Steps to Reproduce: 1. Start a simple JSSE socket server with -Djavax.net.debug=all. 2. Connect to the server with e.g. OpenSSL command line tool, ensuring that DHE cipher suite gets selected (e.g. "openssl s_client -cipher DHE-RSA-AES128-SHA -connect 192.168.81.1:9999") repeatedly. Other SSL clients can be used -- this is not an OpenSSL bug (see below). 3. Repeat the connection. After a couple of hundred successful connections, the connection will fail with handshake_failure alert. 4. Examine the JSSE debug logs produced by the server: the failed connection will have a PreMaster secret that begins with zero byte (while all other connections have non-zero byte here). For example: SESSION KEYGEN: PreMaster Secret: 0000: 00 70 C5 7E 91 38 C8 DE ED 75 3D 76 8A B5 44 69 .p...8...u=v..Di 0010: E7 32 1C EE 80 77 50 C7 A9 51 24 2E E3 15 11 30 .2...wP..Q$....0 0020: 9D F6 9F BC 9D EB 5C 18 F7 A4 19 ED 1A AC 2E 0C ......\......... 0030: E3 18 C5 11 B1 80 07 7D B1 C6 70 A8 D7 EB CF DD ..........p..... 0040: 2D B5 1D BC 01 3E 28 2A 2B 5B 38 8F EB 20 F2 A2 -....>(*+[8.. .. 0050: 00 07 47 F7 87 B8 99 CB EF B4 13 04 C8 8B 82 FB ..G............. Expected Result: Expected result is that every connection succeed. Actual Result: Roughly one out of 256 connections fail. Source code for an executable test case: Java server: import javax.net.ssl.SSLServerSocket; import javax.net.ssl.SSLServerSocketFactory; import javax.net.ssl.SSLSocket; public class TestServer { public static void main(String args[]) throws Exception { SSLServerSocketFactory ssf = (SSLServerSocketFactory) SSLServerSocketFactory.getDefault(); SSLServerSocket ss = (SSLServerSocket) ssf.createServerSocket(9999); System.out.println("Listening on port 9999"); for (String cs : ss.getEnabledCipherSuites()) { System.out.println(cs); } while (true) { SSLSocket s = (SSLSocket) ss.accept(); System.out.println("Connected with "+s.getSession().getCipherSuite()); s.close(); } } } Run as as follows: keytool -storepass "password" -keypass "password" -genkey -keyalg RSA -keystore test_keystore.jks -dname CN=test javac TestServer.java java -Djavax.net.debug=all -Djavax.net.ssl.keyStore=./test_keystore.jks -Djavax.net.ssl.keyStorePassword=password TestServer OpenSSL client: set -e while true; do openssl s_client -cipher DHE-RSA-AES128-SHA -connect 127.0.0.1:9999-quiet -no_ign_eof < /dev/null done Workaround: Disable Diffie-Hellman cipher suites. ---snip--- -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130510/5439be6d/attachment-0001.html From alan.bateman at oracle.com Fri May 10 06:56:10 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 10 May 2013 13:56:10 +0000 Subject: hg: jdk8/tl/jdk: 8011128: (fs) Files.createDirectory fails if the resolved path is exactly 248 characters long Message-ID: <20130510135635.C1221489AC@hg.openjdk.java.net> Changeset: 09a3b08c986f Author: alanb Date: 2013-05-10 14:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09a3b08c986f 8011128: (fs) Files.createDirectory fails if the resolved path is exactly 248 characters long Reviewed-by: khazra, chegar ! src/windows/classes/sun/nio/fs/WindowsFileCopy.java ! src/windows/classes/sun/nio/fs/WindowsLinkSupport.java ! src/windows/classes/sun/nio/fs/WindowsPath.java + test/java/nio/file/Files/NameLimits.java From alan.bateman at oracle.com Fri May 10 08:15:09 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 10 May 2013 15:15:09 +0000 Subject: hg: jdk8/tl/langtools: 8014318: tools/javac/profiles/ProfileOptionTest.java needs modifying now that javax.script is in compact1 Message-ID: <20130510151517.4C2C5489AD@hg.openjdk.java.net> Changeset: ce7e1674eb73 Author: alanb Date: 2013-05-10 16:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ce7e1674eb73 8014318: tools/javac/profiles/ProfileOptionTest.java needs modifying now that javax.script is in compact1 Reviewed-by: mchung ! test/tools/javac/profiles/ProfileOptionTest.java From joe.darcy at oracle.com Fri May 10 08:56:31 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 10 May 2013 15:56:31 +0000 Subject: hg: jdk8/tl/jdk: 8014249: Add Modifer.parameterModifiers() Message-ID: <20130510155653.EED71489B2@hg.openjdk.java.net> Changeset: ece61e21782d Author: darcy Date: 2013-05-10 08:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ece61e21782d 8014249: Add Modifer.parameterModifiers() Reviewed-by: mduigou, mchung ! src/share/classes/java/lang/reflect/Modifier.java From joe.darcy at oracle.com Fri May 10 09:07:16 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 10 May 2013 16:07:16 +0000 Subject: hg: jdk8/tl/jdk: 8014296: DivModTests should not compare pointers Message-ID: <20130510160728.8CBAC489B3@hg.openjdk.java.net> Changeset: c26e0d29249a Author: rriggs Date: 2013-05-10 09:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c26e0d29249a 8014296: DivModTests should not compare pointers Reviewed-by: darcy ! test/java/lang/Math/DivModTests.java From huizhe.wang at oracle.com Fri May 10 09:24:11 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Fri, 10 May 2013 16:24:11 +0000 Subject: hg: jdk8/tl/jaxp: 8014333: javadoc error in JAXP 1.5 patch Message-ID: <20130510162417.DA3C9489B5@hg.openjdk.java.net> Changeset: a229726149b4 Author: joehw Date: 2013-05-10 09:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a229726149b4 8014333: javadoc error in JAXP 1.5 patch Reviewed-by: lancea ! src/javax/xml/stream/XMLInputFactory.java From mike.duigou at oracle.com Fri May 10 10:13:33 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 10 May 2013 17:13:33 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130510171357.D0F0C489D3@hg.openjdk.java.net> Changeset: 2490769abdfa Author: mduigou Date: 2013-05-10 09:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2490769abdfa 8014316: Use Method Refs in j.u.stream.MatchOps Reviewed-by: dholmes ! src/share/classes/java/util/stream/MatchOps.java Changeset: 9891e4d7d5b3 Author: mduigou Date: 2013-05-10 10:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9891e4d7d5b3 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java From joe.darcy at oracle.com Fri May 10 12:25:50 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 10 May 2013 19:25:50 +0000 Subject: hg: jdk8/tl/jdk: 8014357: Minor refactorings to sun.reflect.generics.reflectiveObjects.* Message-ID: <20130510192612.8D50F489E7@hg.openjdk.java.net> Changeset: f84b5498b2bb Author: darcy Date: 2013-05-10 12:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f84b5498b2bb 8014357: Minor refactorings to sun.reflect.generics.reflectiveObjects.* Reviewed-by: mchung ! src/share/classes/sun/reflect/generics/reflectiveObjects/GenericArrayTypeImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/WildcardTypeImpl.java From joel.franck at oracle.com Fri May 10 02:06:56 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Fri, 10 May 2013 09:06:56 +0000 Subject: hg: jdk8/tl/jdk: 8007073: Implement Core Reflection for Type Annotations on parameters Message-ID: <20130510090725.83EF1489A7@hg.openjdk.java.net> Changeset: ba74cd79e4f6 Author: jfranck Date: 2013-05-10 10:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba74cd79e4f6 8007073: Implement Core Reflection for Type Annotations on parameters Reviewed-by: darcy, abuckley ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/sun/reflect/annotation/TypeAnnotation.java ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java ! test/java/lang/annotation/TypeAnnotationReflection.java From joe.darcy at oracle.com Fri May 10 14:32:00 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 10 May 2013 21:32:00 +0000 Subject: hg: jdk8/tl/langtools: 8014365: Restore Objects.requireNonNull(T, Supplier) Message-ID: <20130510213206.719BD489F4@hg.openjdk.java.net> Changeset: 1c43236f6d69 Author: darcy Date: 2013-05-10 14:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1c43236f6d69 8014365: Restore Objects.requireNonNull(T, Supplier) Reviewed-by: jjg ! makefiles/BuildLangtools.gmk From dmitry.degrave at oracle.com Sun May 12 07:54:37 2013 From: dmitry.degrave at oracle.com (dmitry.degrave at oracle.com) Date: Sun, 12 May 2013 14:54:37 +0000 Subject: hg: jdk8/tl/jdk: 7021870: GzipInputStream closes underlying stream during reading Message-ID: <20130512145515.EF53A48A18@hg.openjdk.java.net> Changeset: 90f715cceaae Author: dmeetry Date: 2013-05-10 23:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90f715cceaae 7021870: GzipInputStream closes underlying stream during reading Reviewed-by: mduigou Contributed-by: ivan.gerasimov at oracle.com ! src/share/classes/java/util/zip/GZIPInputStream.java + test/java/util/zip/GZIP/GZIPInZip.java From jonathan.gibbons at oracle.com Sun May 12 18:19:58 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 13 May 2013 01:19:58 +0000 Subject: hg: jdk8/tl/langtools: 8014363: javac test class ToolTester handles classpath incorrectly Message-ID: <20130513012005.3FE4948A1E@hg.openjdk.java.net> Changeset: e39669aea0bd Author: jjg Date: 2013-05-12 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39669aea0bd 8014363: javac test class ToolTester handles classpath incorrectly Reviewed-by: ksrini ! test/tools/javac/api/6406133/T6406133.java ! test/tools/javac/api/6410643/T6410643.java ! test/tools/javac/api/6411310/T6411310.java ! test/tools/javac/api/6411333/T6411333.java ! test/tools/javac/api/6412656/T6412656.java ! test/tools/javac/api/6415780/T6415780.java ! test/tools/javac/api/6418694/T6418694.java ! test/tools/javac/api/6421111/T6421111.java ! test/tools/javac/api/6421756/T6421756.java ! test/tools/javac/api/6422215/T6422215.java ! test/tools/javac/api/6422327/T6422327.java ! test/tools/javac/api/6423003/T6423003.java ! test/tools/javac/api/6431257/T6431257.java ! test/tools/javac/api/6437349/T6437349.java ! test/tools/javac/api/6437999/T6437999.java ! test/tools/javac/api/6440333/T6440333.java ! test/tools/javac/api/6440528/T6440528.java ! test/tools/javac/api/6468404/T6468404.java ! test/tools/javac/api/6731573/T6731573.java ! test/tools/javac/api/6733837/T6733837.java ! test/tools/javac/api/TestJavacTaskScanner.java ! test/tools/javac/api/guide/Test.java ! test/tools/javac/api/lib/ToolTester.java From weijun.wang at oracle.com Sun May 12 22:39:47 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 13 May 2013 13:39:47 +0800 Subject: Code review request: 8014196: ktab creates a file with zero kt_vno Message-ID: <51907CA3.4000409@oracle.com> Hi Valerie Please take a look at http://cr.openjdk.java.net/~weijun/8014196/webrev.01/ KeyTab.getInstance() used to return null if the keytab file does not exists, but since we supported dynamic ktab, the result is never null. But the KeyTab object has not initialize its kt_vno. The fix includes two parts: 1. Initialize kt_vno in KeyTab even if isMissing or !isValid 2. Make clear in what cases ktab.exe should fail. Thanks Max From xuelei.fan at oracle.com Mon May 13 05:43:32 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 13 May 2013 12:43:32 +0000 Subject: hg: jdk8/tl/jdk: 8005535: SSLSessionImpl should have protected finalize() Message-ID: <20130513124354.6003748A28@hg.openjdk.java.net> Changeset: 76998d11a643 Author: xuelei Date: 2013-05-13 05:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/76998d11a643 8005535: SSLSessionImpl should have protected finalize() Reviewed-by: weijun, wetmore ! src/share/classes/sun/security/ssl/SSLSessionImpl.java From xuelei.fan at oracle.com Mon May 13 06:07:03 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 13 May 2013 13:07:03 +0000 Subject: hg: jdk8/tl/jdk: 8005598: (reopened) Need to clone array of input/output parameters Message-ID: <20130513130715.CBCE148A2C@hg.openjdk.java.net> Changeset: 46db0e633240 Author: xuelei Date: 2013-05-13 06:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46db0e633240 8005598: (reopened) Need to clone array of input/output parameters Reviewed-by: weijun ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java From sundararajan.athijegannathan at oracle.com Mon May 13 10:13:06 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 13 May 2013 17:13:06 +0000 Subject: hg: jdk8/tl/jdk: 8012975: Remove rhino from jdk8 Message-ID: <20130513171327.CD6EB48A31@hg.openjdk.java.net> Changeset: 536678dffa97 Author: sundar Date: 2013-05-13 22:23 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/536678dffa97 8012975: Remove rhino from jdk8 Reviewed-by: alanb, tbell ! make/com/sun/Makefile - make/com/sun/script/Makefile ! make/sun/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile ! make/tools/src/build/tools/deps/refs.allowed ! makefiles/CopyFiles.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/profile-rtjar-includes.txt - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java From mike.duigou at oracle.com Mon May 13 13:29:10 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Mon, 13 May 2013 20:29:10 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130513202933.B2B9C48A3A@hg.openjdk.java.net> Changeset: 6175fe5b07aa Author: bharadwaj Date: 2013-05-13 12:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6175fe5b07aa 8008687: MethodHandle code: allow static and invokespecial calls to interface methods Summary: Changes to support invocation of lambda methods compiled either as static interface methods and or private instance methods. Reviewed-by: jrose, twisti ! src/share/classes/java/lang/invoke/MemberName.java Changeset: f7fcfb204a69 Author: mduigou Date: 2013-05-13 13:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7fcfb204a69 Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java From kurchi.subhra.hazra at oracle.com Mon May 13 13:38:48 2013 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Mon, 13 May 2013 20:38:48 +0000 Subject: hg: jdk8/tl/jdk: 8014254: Selector in HttpServer introduces a 1000 ms delay when using KeepAlive Message-ID: <20130513203900.39ACD48A3B@hg.openjdk.java.net> Changeset: 86c1e8c799f5 Author: khazra Date: 2013-05-13 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86c1e8c799f5 8014254: Selector in HttpServer introduces a 1000 ms delay when using KeepAlive Summary: Rearrange event-handling code to remove bottle-neck. Also reviewed by mhall at mhcomputing.net. Reviewed-by: chegar, alanb ! src/share/classes/sun/net/httpserver/ServerImpl.java From jonathan.gibbons at oracle.com Mon May 13 15:29:30 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 13 May 2013 22:29:30 +0000 Subject: hg: jdk8/tl/langtools: 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees Message-ID: <20130513222934.CF4D748A3E@hg.openjdk.java.net> Changeset: 8dd528992c15 Author: jlahoda Date: 2013-05-10 15:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8dd528992c15 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees Reviewed-by: jjg Contributed-by: Dusan Balek , Jan Lahoda ! src/share/classes/com/sun/tools/doclint/Env.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/javac/api/TestGetElementReference.java + test/tools/javac/api/TestGetElementReferenceData.java From xueming.shen at oracle.com Mon May 13 20:37:16 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 14 May 2013 03:37:16 +0000 Subject: hg: jdk8/tl/jdk: 8013386: (tz) Support tzdata2013c Message-ID: <20130514033738.288CA48A4A@hg.openjdk.java.net> Changeset: ae35fdbab949 Author: sherman Date: 2013-05-13 20:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae35fdbab949 8013386: (tz) Support tzdata2013c Summary: updated tz data to version 2013c Reviewed-by: peytoia, okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/sun/util/calendar/zi/Rule.java ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/antarctica ! test/sun/util/calendar/zi/tzdata/asia ! test/sun/util/calendar/zi/tzdata/australasia ! test/sun/util/calendar/zi/tzdata/europe ! test/sun/util/calendar/zi/tzdata/northamerica ! test/sun/util/calendar/zi/tzdata/southamerica ! test/sun/util/calendar/zi/tzdata/zone.tab From youdwei at linux.vnet.ibm.com Mon May 13 21:46:42 2013 From: youdwei at linux.vnet.ibm.com (Deven You) Date: Tue, 14 May 2013 12:46:42 +0800 Subject: Signature.getAlogrithm return null in special case Message-ID: <5191C1B2.4030900@linux.vnet.ibm.com> Hi All, I find in a special case: If you create a SignatureSpi service through extending Signature rather than SignatureSpi, the returned signature instance will lose its algortithm name. Though the fix[1] is simple I think it's valuable. Could anyone take a look? [1] http://cr.openjdk.java.net/~youdwei/ojdk-809/webrev/ Thanks a lot -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130514/91a26018/attachment.html From youdwei at linux.vnet.ibm.com Mon May 13 21:40:28 2013 From: youdwei at linux.vnet.ibm.com (Deven You) Date: Tue, 14 May 2013 12:40:28 +0800 Subject: Signature.getAlogrithm return null in special case In-Reply-To: <5191A926.8020502@linux.vent.ibm.com> References: <5191A926.8020502@linux.vent.ibm.com> Message-ID: <5191C03C.7040905@linux.vnet.ibm.com> Hi All, I didn't see this mail is posted to mailing list for 2 ~ 3 hours, I am not sure why so just re-send it. Thanks a lot! On 05/14/2013 11:01 AM, Deven You wrote: > Hi All, > > I find in a special case: If you create a SignatureSpi service through > extending Signature rather than SignatureSpi, the returned signature > instance will lose its algortithm name. > > Though the fix[1] is simple I think it's valuable. Could anyone take a > look? > > [1] http://cr.openjdk.java.net/~youdwei/ojdk-809/webrev/ > > > Thanks a lot -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130514/372659bd/attachment.html From joe.darcy at oracle.com Mon May 13 22:17:06 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 14 May 2013 05:17:06 +0000 Subject: hg: jdk8/tl/jdk: 8014365: Restore Objects.requireNonNull(T, Supplier) Message-ID: <20130514051719.2348548A4D@hg.openjdk.java.net> Changeset: a50bad038f31 Author: darcy Date: 2013-05-13 22:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a50bad038f31 8014365: Restore Objects.requireNonNull(T, Supplier) Reviewed-by: mduigou ! src/share/classes/java/util/Objects.java ! test/java/util/Objects/BasicObjectsTest.java From alan.bateman at oracle.com Tue May 14 06:34:06 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 14 May 2013 13:34:06 +0000 Subject: hg: jdk8/tl/jdk: 8014500: bootcycle-images fails after upgrade to JAXP 1.5 Message-ID: <20130514133439.831AD48A64@hg.openjdk.java.net> Changeset: b315cb9a7544 Author: alanb Date: 2013-05-14 14:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b315cb9a7544 8014500: bootcycle-images fails after upgrade to JAXP 1.5 Reviewed-by: lancea ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java From anthony.scarpino at oracle.com Tue May 14 08:15:33 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Tue, 14 May 2013 08:15:33 -0700 Subject: Code Review: 7160837 DigestOutputStream does not turn off digest calculation when "close()" is called Message-ID: <51925515.9010702@oracle.com> Hi, Below is the link to code changes for: DigestOutputStream does not turn off digest calculation when "close()" is called. The more significant change is to the Cipher streams to prevent extra doFinal() calls. http://cr.openjdk.java.net/~ascarpino/7160837/webrev.00/ thanks Tony From sundararajan.athijegannathan at oracle.com Tue May 14 10:07:18 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 14 May 2013 17:07:18 +0000 Subject: hg: jdk8/tl/jdk: 8014519: scriptpad sample does not work with nashorn Message-ID: <20130514170742.64A4448A7A@hg.openjdk.java.net> Changeset: e0135f1a8627 Author: sundar Date: 2013-05-14 22:36 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0135f1a8627 8014519: scriptpad sample does not work with nashorn Reviewed-by: attila, jlaskey Contributed-by: rieberandreas at gmail.com ! src/share/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java ! src/share/sample/scripting/scriptpad/src/resources/Main.js ! src/share/sample/scripting/scriptpad/src/resources/conc.js ! src/share/sample/scripting/scriptpad/src/resources/gui.js ! src/share/sample/scripting/scriptpad/src/resources/mm.js ! src/share/sample/scripting/scriptpad/src/resources/scriptpad.js ! src/share/sample/scripting/scriptpad/src/scripts/browse.js ! src/share/sample/scripting/scriptpad/src/scripts/insertfile.js ! src/share/sample/scripting/scriptpad/src/scripts/linewrap.js ! src/share/sample/scripting/scriptpad/src/scripts/mail.js ! src/share/sample/scripting/scriptpad/src/scripts/memmonitor.js ! src/share/sample/scripting/scriptpad/src/scripts/memory.js ! src/share/sample/scripting/scriptpad/src/scripts/memory.sh ! src/share/sample/scripting/scriptpad/src/scripts/textcolor.js From jonathan.gibbons at oracle.com Tue May 14 10:17:50 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 14 May 2013 17:17:50 +0000 Subject: hg: jdk8/tl/langtools: 17 new changesets Message-ID: <20130514171841.689DE48A7C@hg.openjdk.java.net> Changeset: 8ea30d59ac41 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8ea30d59ac41 8010440: Replace int constants in LinkInfoImpl with enum Reviewed-by: bpatel, darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java Changeset: 74cd21f2c2fe Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/74cd21f2c2fe 8011642: Remove LinkOutput in favor of direct use of Content Reviewed-by: bpatel, darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletConstants.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java Changeset: 7a9ef837e57f Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7a9ef837e57f 8011650: reduce use of RawHtml nodes in doclet Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java Changeset: 6ea964c78845 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6ea964c78845 8011651: simplify LinkInfoImpl API Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java Changeset: e6c5b5ee9fac Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e6c5b5ee9fac 8011662: Remove single instance of resource with HTML from doclet resource bundle Reviewed-by: bpatel, darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties Changeset: ce4f0769b4b2 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ce4f0769b4b2 8011668: Allow HTMLWriter.getResource to take Content args Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java Changeset: 4c43e51433ba Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4c43e51433ba 8011288: Erratic/inconsistent indentation of signatures Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java + test/com/sun/javadoc/testIndentation/TestIndentation.java + test/com/sun/javadoc/testIndentation/p/Indent.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/testTypeParams/TestTypeParameters.java Changeset: 7af0fa419a2b Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7af0fa419a2b 8012174: {@literal} and {@code} should use \"new\" Taglet, not old. Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java Changeset: 6a5288a298fd Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6a5288a298fd 8012175: Convert TagletOutputImpl to use ContentBuilder instead of StringBuilder Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/Taglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testHref/TestHref.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java ! test/com/sun/javadoc/testSinceTag/TestSinceTag.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java Changeset: 76a691e3e961 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/76a691e3e961 8012176: reduce use of TagletOutputImpl.toString Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSinceTag/TestSinceTag.java Changeset: 937aa020c667 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/937aa020c667 8012177: HTMLDocletWriter methods should generate Content, not Strings Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java Changeset: bd51ca92c013 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bd51ca92c013 8012178: Cleanup use of Util.escapeHtmlChars Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java Changeset: df4f44800923 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/df4f44800923 8012183: replace some uses of Configuration.getText with Configuration.getResource Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java Changeset: 051b728cfe90 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/051b728cfe90 8012180: Speed up removeNonInlineHtmlTags Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java Changeset: 25c89a492f14 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/25c89a492f14 8012295: Cleanup JavaFX features in standard doclet Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java Changeset: 081d7c72ee92 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/081d7c72ee92 8012311: Cleanup names and duplicatre code in TagletManager Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java Changeset: ca8808c88f94 Author: jjg Date: 2013-05-14 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ca8808c88f94 8012308: Remove TagletOutput in favor of direct use of Content Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java - src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DeprecatedTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DocRootTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LegacyTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/Taglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! test/com/sun/javadoc/testNestedInlineTag/testtaglets/BoldTaglet.java ! test/com/sun/javadoc/testNestedInlineTag/testtaglets/GreenTaglet.java ! test/com/sun/javadoc/testNestedInlineTag/testtaglets/UnderlineTaglet.java ! test/com/sun/javadoc/testTaglets/taglets/Foo.java From robert.field at oracle.com Tue May 14 11:11:56 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Tue, 14 May 2013 18:11:56 +0000 Subject: hg: jdk8/tl/langtools: 8012556: Implement lambda methods on interfaces as static; ... Message-ID: <20130514181201.B1A5B48A7F@hg.openjdk.java.net> Changeset: c09b7234cded Author: rfield Date: 2013-05-14 11:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c09b7234cded 8012556: Implement lambda methods on interfaces as static 8006140: Javac NPE compiling Lambda expression on initialization expression of static field in interface Summary: Lambdas occurring in static contexts or those not needing instance information should be generated into static methods. This has long been the case for classes. However, as a work-around to the lack of support for statics on interfaces, interface lambda methods have been generated into default methods. For lambdas in interface static contexts (fields and static methods) this causes an NPE in javac because there is no 'this'. MethodHandles now support static methods on interfaces. This changeset allows lambda methods to be generated as static interface methods. An existing bug in Hotspot (8013875) is exposed in a test when the "-esa" flag is used. This test and another test that already exposed this bug have been marked with @ignore. Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaInterfaceStaticField.java ! test/tools/javac/lambda/MethodReference66.java ! test/tools/javac/lambda/bytecode/TestLambdaBytecode.java ! test/tools/javac/lambda/lambdaExecution/InInterface.java From alexey.utkin at oracle.com Tue May 14 09:24:25 2013 From: alexey.utkin at oracle.com (alexey.utkin at oracle.com) Date: Tue, 14 May 2013 16:24:25 +0000 Subject: hg: jdk8/tl/jdk: 8012453: (process) Runtime.exec(String) fails if command contains spaces [win] Message-ID: <20130514162448.4EEF748A74@hg.openjdk.java.net> Changeset: 5ea5f5dfb96a Author: uta Date: 2013-05-14 20:16 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ea5f5dfb96a 8012453: (process) Runtime.exec(String) fails if command contains spaces [win] Reviewed-by: alanb ! src/share/classes/java/lang/ProcessBuilder.java ! src/windows/classes/java/lang/ProcessImpl.java + test/java/lang/Runtime/exec/ExecCommand.java From james.laskey at oracle.com Tue May 14 09:43:37 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 14 May 2013 16:43:37 +0000 Subject: hg: jdk8/tl/nashorn: 17 new changesets Message-ID: <20130514164351.74D8648A78@hg.openjdk.java.net> Changeset: b754fb89367d Author: jlaskey Date: 2013-04-30 10:05 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b754fb89367d 8006220: Simplify PropertyMaps Reviewed-by: hannesw, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/PropertyHashMap.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java - src/jdk/nashorn/internal/runtime/SpillProperty.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! src/jdk/nashorn/internal/scripts/JO.java ! src/jdk/nashorn/tools/Shell.java Changeset: 80cb02dedc83 Author: hannesw Date: 2013-05-02 09:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/80cb02dedc83 8013729: SwitchPoint invalidation not working over prototype chain Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8013729.js + test/script/basic/JDK-8013729.js.EXPECTED Changeset: 7563c56ca565 Author: jlaskey Date: 2013-05-02 13:22 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7563c56ca565 8013794: JDK-8006220 caused an octane performance regression. Reviewed-by: lagergren, sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/codegen/ObjectCreator.java Changeset: 9c2376a250b6 Author: jlaskey Date: 2013-05-02 13:23 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9c2376a250b6 Merge Changeset: c8023561505b Author: jlaskey Date: 2013-05-02 15:01 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c8023561505b 8013796: load("fx:base.js") should not be in fx:bootstrap.js Reviewed-by: sundar, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/resources/fx/bootstrap.js Changeset: 5a3f7867e19c Author: lagergren Date: 2013-05-03 15:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5a3f7867e19c 8013477: Node.setSymbol needs to be copy on write - enable IR snapshots for recompilation based on callsite type specialization. [not enabled by default, hidden by a flag for now] Reviewed-by: jlaskey, hannesw ! bin/jjs ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/CompiledFunction.java ! src/jdk/nashorn/internal/runtime/CompiledFunctions.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! src/jdk/nashorn/tools/Shell.java + test/script/basic/paramspec.js + test/script/basic/paramspec.js.EXPECTED ! test/script/basic/runsunspider.js + test/script/currently-failing/logcoverage.js - test/script/trusted/logcoverage.js Changeset: 829b06307fb2 Author: lagergren Date: 2013-05-03 16:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/829b06307fb2 8013871: mem usage histograms enabled with compiler logging level set to more specific than or equals to info when --print-mem-usage flag is used Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/codegen/Compiler.java + src/jdk/nashorn/internal/ir/debug/ClassHistogramElement.java + src/jdk/nashorn/internal/ir/debug/ObjectSizeCalculator.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! src/jdk/nashorn/tools/Shell.java Changeset: c0f0033d7b08 Author: hannesw Date: 2013-05-03 22:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c0f0033d7b08 8013878: ClassCastException in Regex Reviewed-by: jlaskey ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8013878.js + test/script/basic/JDK-8013878.js.EXPECTED Changeset: f98d22fa3cbc Author: hannesw Date: 2013-05-03 22:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f98d22fa3cbc 8013873: Regexp regression for escaped dash in character class Reviewed-by: jlaskey ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java + test/script/basic/JDK-8013873.js + test/script/basic/JDK-8013873.js.EXPECTED Changeset: f3dcb12c8439 Author: hannesw Date: 2013-05-03 22:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f3dcb12c8439 8013874: Function argument's prototype seem cached and wrongly reused Reviewed-by: jlaskey ! src/jdk/nashorn/internal/runtime/PropertyMap.java + test/script/basic/JDK-8013874.js + test/script/basic/JDK-8013874.js.EXPECTED Changeset: 544e17632e96 Author: lagergren Date: 2013-05-07 14:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/544e17632e96 8013913: Removed Source field from all nodes except FunctionNode in order to save footprint Reviewed-by: jlaskey, attila ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BaseNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LineNumberNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java - src/jdk/nashorn/internal/ir/Location.java ! src/jdk/nashorn/internal/ir/LoopNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/tools/Shell.java Changeset: fb1d7ea3e1b6 Author: lagergren Date: 2013-05-07 14:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fb1d7ea3e1b6 8013914: Removed explicit LineNumberNodes that were too brittle when code moves around, and also introduced unnecessary footprint. Introduced the Statement node and fixed dead code elimination issues that were discovered by the absense of labels for LineNumberNodes. Reviewed-by: jlaskey, attila ! make/project.properties ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Label.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java - src/jdk/nashorn/internal/ir/LineNumberNode.java ! src/jdk/nashorn/internal/ir/LoopNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java + src/jdk/nashorn/internal/ir/Statement.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/tools/Shell.java + test/script/basic/no_line_numbers.js + test/script/basic/no_line_numbers.js.EXPECTED Changeset: d28180d97c61 Author: attila Date: 2013-05-08 15:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d28180d97c61 8013912: Nashorn needs to reuse temporary symbols Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/Symbol.java + src/jdk/nashorn/internal/ir/TemporarySymbols.java ! src/jdk/nashorn/internal/ir/TypeOverride.java Changeset: 18ce1cd3026c Author: attila Date: 2013-05-08 16:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/18ce1cd3026c 8014225: Rerun only failed 262 tests Reviewed-by: jlaskey, lagergren ! make/project.properties ! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/ParallelTestRunner.java ! test/src/jdk/nashorn/internal/test/framework/TestConfig.java ! test/src/jdk/nashorn/internal/test/framework/TestFinder.java Changeset: 9073bcc4307b Author: lagergren Date: 2013-05-10 13:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9073bcc4307b 8014329: Slim down the label stack structure in CodeGenerator Reviewed-by: attila, jlaskey ! .hgignore ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/Label.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java Changeset: 098a4cedcaf2 Author: attila Date: 2013-05-14 12:39 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/098a4cedcaf2 8014492: Make NashornLinker public Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java Changeset: 264bb0af9e4e Author: jlaskey Date: 2013-05-14 09:05 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/264bb0af9e4e Merge - src/jdk/nashorn/internal/ir/LineNumberNode.java - src/jdk/nashorn/internal/ir/Location.java - src/jdk/nashorn/internal/runtime/SpillProperty.java - test/script/trusted/logcoverage.js From kurchi.subhra.hazra at oracle.com Tue May 14 11:51:57 2013 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Tue, 14 May 2013 18:51:57 +0000 Subject: hg: jdk8/tl/jdk: 6328537: Improve javadocs for Socket class by adding references to SocketOptions Message-ID: <20130514185220.F24EA48A80@hg.openjdk.java.net> Changeset: 790d292ee761 Author: khazra Date: 2013-05-14 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/790d292ee761 6328537: Improve javadocs for Socket class by adding references to SocketOptions Summary: Insert references to SocketOptions.java where applicable Reviewed-by: alanb, chegar ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/Socket.java From jonathan.gibbons at oracle.com Tue May 14 12:57:22 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 14 May 2013 19:57:22 +0000 Subject: hg: jdk8/tl/langtools: 8014461: genstubs creates default native methods Message-ID: <20130514195727.3331448A8C@hg.openjdk.java.net> Changeset: 46b9c25f7024 Author: jjg Date: 2013-05-14 12:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/46b9c25f7024 8014461: genstubs creates default native methods Reviewed-by: alanb ! make/tools/genstubs/GenStubs.java From jonathan.gibbons at oracle.com Tue May 14 13:55:46 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 14 May 2013 20:55:46 +0000 Subject: hg: jdk8/tl/langtools: 8014557: Mutable static field in HtmlDocletWriter Message-ID: <20130514205552.B3A5848A90@hg.openjdk.java.net> Changeset: 0384683c64be Author: jjg Date: 2013-05-14 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0384683c64be 8014557: Mutable static field in HtmlDocletWriter Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java From xueming.shen at oracle.com Tue May 14 14:11:20 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 14 May 2013 21:11:20 +0000 Subject: hg: jdk8/tl/jdk: 8012326: Deadlock occurs when Charset.availableCharsets() is called by several threads at the same time Message-ID: <20130514211142.A5B6C48A92@hg.openjdk.java.net> Changeset: 08ef70f60e0d Author: sherman Date: 2013-05-14 14:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/08ef70f60e0d 8012326: Deadlock occurs when Charset.availableCharsets() is called by several threads at the same time Summary: removed the race condition risk from ExtendedCahrset access code Reviewed-by: mchung, alanb ! make/sun/nio/cs/Makefile ! makefiles/CreateJars.gmk ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/sun/nio/cs/ext/ISO2022_JP_2.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider ! src/share/classes/sun/nio/cs/ext/MSISO2022JP.java From xueming.shen at oracle.com Tue May 14 14:21:54 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 14 May 2013 21:21:54 +0000 Subject: hg: jdk8/tl/jdk: 8014217: Base64.getXDecoder().wrap(...).read() doesn't throw exception for an incorrect number of padding chars in the final unit Message-ID: <20130514212206.9FF1848A93@hg.openjdk.java.net> Changeset: c70fff3db913 Author: sherman Date: 2013-05-14 14:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c70fff3db913 8014217: Base64.getXDecoder().wrap(...).read() doesn't throw exception for an incorrect number of padding chars in the final unit Summary: to throw IOE for malformed final unit in base64 stream Reviewed-by: chegar, alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java From jonathan.gibbons at oracle.com Tue May 14 15:05:12 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 14 May 2013 22:05:12 +0000 Subject: hg: jdk8/tl/langtools: 8013852: update reference impl for type-annotations Message-ID: <20130514220518.77FDF48A96@hg.openjdk.java.net> Changeset: ddb4a2bfcd82 Author: jjg Date: 2013-05-14 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ddb4a2bfcd82 8013852: update reference impl for type-annotations Reviewed-by: jjg Contributed-by: wdietl at gmail.com, steve.sides at oracle.com, joel.franck at oracle.com, alex.buckley at oracle.com ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/TypeAnnotation.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java ! test/com/sun/javadoc/typeAnnotations/smoke/pkg/TargetTypes.java ! test/tools/javac/annotations/typeAnnotations/attribution/Scopes.java ! test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java + test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest3.java ! test/tools/javac/annotations/typeAnnotations/classfile/DeadCode.java ! test/tools/javac/annotations/typeAnnotations/classfile/NewTypeArguments.java + test/tools/javac/annotations/typeAnnotations/classfile/T8008762.java + test/tools/javac/annotations/typeAnnotations/classfile/T8008769.java + test/tools/javac/annotations/typeAnnotations/classfile/T8010015.java + test/tools/javac/annotations/typeAnnotations/classfile/TestNewCastArray.java ! test/tools/javac/annotations/typeAnnotations/classfile/TypeCasts.java ! test/tools/javac/annotations/typeAnnotations/classfile/Wildcards.java ! test/tools/javac/annotations/typeAnnotations/failures/LazyConstantValue.java + test/tools/javac/annotations/typeAnnotations/failures/LazyConstantValue.out ! test/tools/javac/annotations/typeAnnotations/failures/LintCast.out ! test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.java ! test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.out + test/tools/javac/annotations/typeAnnotations/failures/T8008751.java + test/tools/javac/annotations/typeAnnotations/failures/T8009360.java + test/tools/javac/annotations/typeAnnotations/failures/T8011722.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DeclarationAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DeclarationAnnotation.out ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/Nesting.java ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.out ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.java ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.out ! test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.java ! test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DeclarationAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DeclarationAnnotation.out + test/tools/javac/annotations/typeAnnotations/newlocations/AnonymousClass.java ! test/tools/javac/annotations/typeAnnotations/newlocations/Lambda.java ! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ExceptionParameters.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Initializers.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Lambda.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodThrows.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/NestedTypes.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/NewObjects.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ReferenceInfoUtil.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Test.java ! test/tools/javac/api/TestJavacTaskScanner.java + test/tools/javac/diags/examples/ArrayAndReceiver.java + test/tools/javac/diags/examples/IncorrectConstructorReceiverName.java + test/tools/javac/diags/examples/IncorrectConstructorReceiverType.java + test/tools/javac/diags/examples/IncorrectReceiverName.java + test/tools/javac/diags/examples/ReceiverParameterNotApplicableConstructor.java + test/tools/javac/diags/examples/VarargsAndReceiver.java ! test/tools/javac/lib/DPrinter.java + test/tools/javac/processing/model/type/BasicAnnoTests.java ! test/tools/javac/tree/SourceTreeScannerTest.java ! test/tools/javap/output/RepeatingTypeAnnotations.java ! test/tools/javap/typeAnnotations/NewArray.java ! test/tools/javap/typeAnnotations/Presence.java ! test/tools/javap/typeAnnotations/TypeCasts.java From bradford.wetmore at oracle.com Tue May 14 17:28:55 2013 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Tue, 14 May 2013 17:28:55 -0700 Subject: Signature.getAlogrithm return null in special case In-Reply-To: <5191C1B2.4030900@linux.vnet.ibm.com> References: <5191C1B2.4030900@linux.vnet.ibm.com> Message-ID: <5192D6C7.6050900@oracle.com> Offhand, this seems reasonable. Since you are an OpenJDK author, I've filed: JDK-8014620: Signature.getAlogrithm return null in special case and stocked it with your patch. Thanks, Brad On 5/13/2013 9:46 PM, Deven You wrote: > Hi All, > > I find in a special case: If you create a SignatureSpi service through > extending Signature rather than SignatureSpi, the returned signature > instance will lose its algortithm name. > > Though the fix[1] is simple I think it's valuable. Could anyone take a look? > > [1] http://cr.openjdk.java.net/~youdwei/ojdk-809/webrev/ > > > Thanks a lot From jonathan.gibbons at oracle.com Tue May 14 18:03:21 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 15 May 2013 01:03:21 +0000 Subject: hg: jdk8/tl/langtools: 8013163: Convert 4 tools multicatch tests to jtreg format Message-ID: <20130515010324.C4E7048A9D@hg.openjdk.java.net> Changeset: 53b389eb39c1 Author: sogoel Date: 2013-05-14 18:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/53b389eb39c1 8013163: Convert 4 tools multicatch tests to jtreg format Reviewed-by: jjg + test/tools/javac/multicatch/Pos11.java + test/tools/javac/multicatch/Pos12.java From john.zavgren at oracle.com Tue May 14 19:19:16 2013 From: john.zavgren at oracle.com (John Zavgren) Date: Tue, 14 May 2013 19:19:16 -0700 (PDT) Subject: RFR JDK-8014307 Message-ID: <65e33d22-079a-49fd-b321-cbf8ea8d84bf@default> Greetings: Please review the following change to the file: jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c that fixes two memory leaks. http://cr.openjdk.java.net/~jzavgren/8014307/webrev.01/ Thanks! John Zavgren -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130514/657d0f1e/attachment.html From jonathan.gibbons at oracle.com Tue May 14 21:10:15 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 15 May 2013 04:10:15 +0000 Subject: hg: jdk8/tl/langtools: 8014323: Add VariableTree.getNameExpression Message-ID: <20130515041020.ED5C348AA0@hg.openjdk.java.net> Changeset: 529fb3ed5d2a Author: jjg Date: 2013-05-14 21:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/529fb3ed5d2a 8014323: Add VariableTree.getNameExpression Reviewed-by: darcy ! src/share/classes/com/sun/source/tree/VariableTree.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! test/tools/javac/tree/SourceTreeScannerTest.java From david.holmes at oracle.com Tue May 14 21:46:51 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 15 May 2013 04:46:51 +0000 Subject: hg: jdk8/tl/jdk: 8013395: StringBuffer.toString performance regression impacting embedded benchmarks Message-ID: <20130515044703.2C79148AA4@hg.openjdk.java.net> Changeset: a3d79a4c2a24 Author: dholmes Date: 2013-05-15 00:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3d79a4c2a24 8013395: StringBuffer.toString performance regression impacting embedded benchmarks Summary: cache a copy of the char[] to use with toString() and clear it when ever the sb content is modified Reviewed-by: alanb, plevart, mduigou, forax ! src/share/classes/java/lang/StringBuffer.java + test/java/lang/StringBuffer/ToStringCache.java From joe.darcy at oracle.com Wed May 15 00:01:03 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 15 May 2013 07:01:03 +0000 Subject: hg: jdk8/tl/langtools: 8004133: Provide javax.lang.model.* implementation backed by core reflection Message-ID: <20130515070112.226A448AA6@hg.openjdk.java.net> Changeset: bcd927639039 Author: darcy Date: 2013-05-15 00:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bcd927639039 8004133: Provide javax.lang.model.* implementation backed by core reflection Summary: Joint work by darcy and jfranck to provide sample code for JEP 119. Reviewed-by: jjg Contributed-by: joe.darcy at oracle.com, joel.franck at oracle.com + src/share/sample/language/model/CoreReflectionFactory.java From maurizio.cimadamore at oracle.com Wed May 15 06:04:19 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 15 May 2013 13:04:19 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20130515130430.BE5EE48AC0@hg.openjdk.java.net> Changeset: 05ec778794d0 Author: mcimadamore Date: 2013-05-15 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/05ec778794d0 8012003: Method diagnostics resolution need to be simplified in some cases Summary: Unfold method resolution diagnostics when they mention errors in poly expressions Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/Diagnostics/compressed/T8012003a.java + test/tools/javac/Diagnostics/compressed/T8012003a.out + test/tools/javac/Diagnostics/compressed/T8012003b.java + test/tools/javac/Diagnostics/compressed/T8012003b.out + test/tools/javac/Diagnostics/compressed/T8012003c.java + test/tools/javac/Diagnostics/compressed/T8012003c.out ! test/tools/javac/diags/examples/BadArgTypesInLambda.java + test/tools/javac/diags/examples/CompressedDiags.java ! test/tools/javac/diags/examples/KindnameConstructor.java + test/tools/javac/diags/examples/ProbFoundReqFragment.java ! test/tools/javac/lambda/TargetType66.out Changeset: 33d1937af1a3 Author: mcimadamore Date: 2013-05-15 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/33d1937af1a3 8012685: Spurious raw types warning when using unbound method references Summary: Spurious raw type warning when unbound method reference qualifier parameter types are inferred from target Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/lambda/MethodReference67.java + test/tools/javac/lambda/MethodReference67.out Changeset: 78717f2d00e8 Author: mcimadamore Date: 2013-05-15 14:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/78717f2d00e8 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types Summary: Bad warnings and position for lambda inferred parameter types Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/lambda/NoWarnOnImplicitParams.java + test/tools/javac/lambda/NoWarnOnImplicitParams.out From robert.field at oracle.com Wed May 15 06:53:42 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Wed, 15 May 2013 13:53:42 +0000 Subject: hg: jdk8/tl/langtools: 8010006: NPE in javac with interface super in lambda Message-ID: <20130515135345.9330248AC2@hg.openjdk.java.net> Changeset: 31ef33db5e0e Author: rfield Date: 2013-05-15 06:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/31ef33db5e0e 8010006: NPE in javac with interface super in lambda Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaWithInterfaceSuper.java From michael.x.mcmahon at oracle.com Wed May 15 07:02:29 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Wed, 15 May 2013 14:02:29 +0000 Subject: hg: jdk8/tl/jdk: 8010464: Evolve java networking same origin policy Message-ID: <20130515140249.4F36C48AC3@hg.openjdk.java.net> Changeset: 93a268759ec3 Author: michaelm Date: 2013-05-15 15:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93a268759ec3 8010464: Evolve java networking same origin policy Reviewed-by: alanb, chegar, dsamersoff, weijun ! src/share/classes/java/net/HttpURLConnection.java + src/share/classes/java/net/HttpURLPermission.java ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/java/net/HttpURLPermission/HttpURLPermissionTest.java + test/java/net/HttpURLPermission/URLTest.java + test/java/net/HttpURLPermission/policy.1 + test/java/net/HttpURLPermission/policy.2 + test/java/net/HttpURLPermission/policy.3 From xueming.shen at oracle.com Wed May 15 07:50:54 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 15 May 2013 14:50:54 +0000 Subject: hg: jdk8/tl/jdk: 8013730: JSR 310 DateTime API Updates III Message-ID: <20130515145126.167A448AC6@hg.openjdk.java.net> Changeset: ef04044f77d2 Author: sherman Date: 2013-05-15 07:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef04044f77d2 8013730: JSR 310 DateTime API Updates III Summary: Integration of JSR310 Date/Time API update III Reviewed-by: naoto Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, masayoshi.okutsu at oracle.com, patrick.zhang at oracle.com ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/DateTimeException.java ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/HijrahChronology.java ! src/share/classes/java/time/chrono/HijrahDate.java ! src/share/classes/java/time/chrono/HijrahEra.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/IsoEra.java ! src/share/classes/java/time/chrono/JapaneseChronology.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/chrono/JapaneseEra.java ! src/share/classes/java/time/chrono/MinguoChronology.java ! src/share/classes/java/time/chrono/MinguoDate.java ! src/share/classes/java/time/chrono/MinguoEra.java ! src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java ! src/share/classes/java/time/chrono/ThaiBuddhistDate.java ! src/share/classes/java/time/chrono/ThaiBuddhistEra.java - src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimeParseException.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/DateTimeTextProvider.java + src/share/classes/java/time/format/DecimalStyle.java ! src/share/classes/java/time/format/FormatStyle.java ! src/share/classes/java/time/format/Parsed.java ! src/share/classes/java/time/format/ResolverStyle.java ! src/share/classes/java/time/format/SignStyle.java ! src/share/classes/java/time/format/TextStyle.java ! src/share/classes/java/time/format/package-info.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalAmount.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/UnsupportedTemporalTypeException.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesException.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/chrono/TCKChronology.java ! test/java/time/tck/java/time/chrono/TCKChronologySerialization.java ! test/java/time/tck/java/time/chrono/TCKHijrahChronology.java ! test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java ! test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/tck/java/time/format/TCKDateTimeParseResolver.java + test/java/time/tck/java/time/format/TCKDecimalStyle.java + test/java/time/tck/java/time/format/TCKInstantPrinterParser.java ! test/java/time/tck/java/time/format/TCKTextStyle.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java ! test/java/time/test/java/time/chrono/TestChronologyPerf.java ! test/java/time/test/java/time/chrono/TestExampleCode.java + test/java/time/test/java/time/chrono/TestJapaneseChronology.java ! test/java/time/test/java/time/format/AbstractTestPrinterParser.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java ! test/java/time/test/java/time/format/TestDateTimeFormatter.java ! test/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java + test/java/time/test/java/time/format/TestDecimalStyle.java ! test/java/time/test/java/time/format/TestFractionPrinterParser.java ! test/java/time/test/java/time/format/TestNonIsoFormatter.java ! test/java/time/test/java/time/format/TestNumberParser.java ! test/java/time/test/java/time/format/TestReducedParser.java ! test/java/time/test/java/time/format/TestReducedPrinter.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java From joe.darcy at oracle.com Wed May 15 09:54:45 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 15 May 2013 16:54:45 +0000 Subject: hg: jdk8/tl/jdk: 8014677: Correct docs warning for Objects.requireNonNull(T, Supplier) Message-ID: <20130515165503.95F7C48AD2@hg.openjdk.java.net> Changeset: bad8f5237f10 Author: darcy Date: 2013-05-15 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bad8f5237f10 8014677: Correct docs warning for Objects.requireNonNull(T, Supplier) Reviewed-by: alanb ! src/share/classes/java/util/Objects.java From jonathan.gibbons at oracle.com Wed May 15 10:40:05 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 15 May 2013 17:40:05 +0000 Subject: hg: jdk8/tl/langtools: 8006879: Detection of windows in sjavac fails. Message-ID: <20130515174013.9F55448AD3@hg.openjdk.java.net> Changeset: 445b8b5ae9f4 Author: jjg Date: 2013-05-15 10:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/445b8b5ae9f4 8006879: Detection of windows in sjavac fails. Reviewed-by: jjg Contributed-by: erik.joelsson at oracle.com ! src/share/classes/com/sun/tools/sjavac/server/CompilerThread.java From valerie.peng at oracle.com Wed May 15 11:05:50 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Wed, 15 May 2013 11:05:50 -0700 Subject: RFR JDK-8014307 In-Reply-To: <65e33d22-079a-49fd-b321-cbf8ea8d84bf@default> References: <65e33d22-079a-49fd-b321-cbf8ea8d84bf@default> Message-ID: <5193CE7E.6060209@oracle.com> John, 1) 332-333 can be replaced w/ a deleteGSSOID(nameType) call. Also, with this deleteGSSOID(nameType) call, we should also add the following line: resetGSSBuffer(env, jnameVal, &nameVal); 2) I think the ExceptionCheck block on line 932 should also be enhanced w/ resetGSSBuffer(env, jinToken, &inToken) call as well as free(cb) call. Same goes for another ExceptionCheck blocks on line 984, 998, 1024. Thanks, Valerie On 05/14/13 19:19, John Zavgren wrote: > Greetings: Please review the following change to the file: > jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c that fixes > two memory leaks. > http://cr.openjdk.java.net/~jzavgren/8014307/webrev.01/ Thanks! John > Zavgren From naoto.sato at oracle.com Wed May 15 16:49:20 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 15 May 2013 23:49:20 +0000 Subject: hg: jdk8/tl/jdk: 8013233: java/util/Locale/LocaleProviders.sh fails Message-ID: <20130515234940.4A42048AE0@hg.openjdk.java.net> Changeset: 3d9f25dc630c Author: naoto Date: 2013-05-15 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3d9f25dc630c 8013233: java/util/Locale/LocaleProviders.sh fails Reviewed-by: okutsu ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh From valerie.peng at oracle.com Wed May 15 18:43:12 2013 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Thu, 16 May 2013 01:43:12 +0000 Subject: hg: jdk8/tl/jdk: 5 new changesets Message-ID: <20130516014410.ECFD148AE4@hg.openjdk.java.net> Changeset: 2ec31660cc0e Author: valeriep Date: 2013-05-07 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ec31660cc0e 8010134: A finalizer in sun.security.pkcs11.wrapper.PKCS11 perhaps should be protected Summary: Change the finalize method of PKCS11 class to be protected. Reviewed-by: xuelei ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java Changeset: 991420add35d Author: valeriep Date: 2013-05-07 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/991420add35d 7196009: SunPkcs11 provider fails to parse config path containing parenthesis Summary: Enhanced to allow quoted string as library path values. Reviewed-by: weijun ! src/share/classes/sun/security/pkcs11/Config.java ! test/sun/security/pkcs11/Provider/ConfigShortPath.java + test/sun/security/pkcs11/Provider/cspQuotedPath.cfg Changeset: 804da1e9bd04 Author: ascarpino Date: 2013-05-07 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/804da1e9bd04 8001284: Buffer problems with SunPKCS11-Solaris and CKM_AES_CTR Summary: Changed output length calculation to include incomplete blocks for CTR mode. Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs11/P11Cipher.java ! test/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java Changeset: fc70416beef3 Author: valeriep Date: 2013-05-13 16:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc70416beef3 Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: 59357ea7f131 Author: valeriep Date: 2013-05-15 18:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59357ea7f131 Merge - src/share/classes/java/time/format/DateTimeFormatSymbols.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java From xuelei.fan at oracle.com Thu May 16 00:56:51 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 16 May 2013 15:56:51 +0800 Subject: 9001039?: DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times In-Reply-To: References: Message-ID: <51949143.2020208@oracle.com> Hi Pasi, Thank you for your patience, and contribution to OpenJDK. The bug is accepted, and you should be able to review it at: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014618 Let's use the above bug ID to track the issue. Your patch looks fine in general (I may have some very minor comments later). We also have similar problems in PKCS11 provider because of the update of P11KeyAgreement.java in changeset: http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 Would you like to also fix it in your patch? Thanks again for your nice work. Regards, Xuelei On 5/10/2013 5:00 PM, Pasi Eronen wrote: > AKA "1 out of 256 SSL/TLS handshakes fails with DHE cipher suites" > > I reported this bug over a month of ago, but for some reason, it's not > yet visible at bugs.sun.com . I've included the bug > report below just in > case. > > It seems this commit from March 2012 inadvertently broke SSL/TLS DHE > cipher suites, causing the SSL/TLS handshake to fail approximately > 1 out of 256 times: > > http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 > > The commit was done to fix this bug: > > http://bugs.sun.com/view_bug.do?bug_id=7146728 > > While generating a secret of the same length as modulus may be the right > choice generally speaking (and it's what e.g. IPsec uses), SSL/TLS uses > a different convention: leading zeroes must be stripped. > > This is currently blocking us from updating our production systems to > Java 7, so although I have not contributed to OpenJDK before, I'd like > to submit a patch and a test case for this (I've signed the OCA > already). But before I do this, I'd like to check that the approach is > agreeable. > > We have a separate "algorithm" value "TlsPremasterSecret", so > behavior for other cases could stay the same. Would a patch > like this: > > } else if (algorithm.equals("TlsPremasterSecret")) { > // remove leading zero bytes per RFC 5246 Section 8.1.2 > int i = 0; > while ((i < secret.length - 1) && (secret[i] == 0)) { > i++; > } > if (i == 0) { > return new SecretKeySpec(secret, "TlsPremasterSecret"); > } else { > byte[] secret2 = new byte[secret.length - i]; > System.arraycopy(secret, i, secret2, 0, secret2.length); > return new SecretKeySpec(secret2, "TlsPremasterSecret"); > } > } > > Plus a test case (with fixed keys) that checks that leading zero is > stripped > for TlsPremasterSecret and is not stripped otherwise, be sufficient? > > Best regards, > Pasi > > ---snip--- > > Synopsis: > DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times > > Full OS version: > Tested on Windows 7 (Microsoft Windows [Version 6.1.7601]), but occurs in > e..g OpenJDK 7 as well. > > Development Kit or Runtime version: > java version "1.7.0_17" > Java(TM) SE Runtime Environment (build 1.7.0_17-b02) > Java HotSpot(TM) Client VM (build 23.7-b01, mixed mode, sharing) > > Description: > When performing Diffie-Hellman key agreement for SSL/TLS, the TLS > specification (RFC 5246) says that "Leading bytes of Z that contain all zero > bits are stripped before it is used as the pre_master_secret." > > However, com.sun.crypto.provider.DHKeyAgreement.java does not strip leading > zero bytes. This causes approximately 1 out 256 SSL/TLS handshakes with > DH/DHE cipher suites to fail (when the leading byte happens, by chance, to > be zero). > > Steps to Reproduce: > 1. Start a simple JSSE socket server with -Djavax.net.debug=all. > > 2. Connect to the server with e.g. OpenSSL command line tool, ensuring that > DHE cipher suite gets selected (e.g. "openssl s_client -cipher > DHE-RSA-AES128-SHA -connect 192.168.81.1:9999 > ") repeatedly. Other SSL > clients can be used -- this is not an OpenSSL bug (see below). > > 3. Repeat the connection. After a couple of hundred successful connections, > the connection will fail with handshake_failure alert. > > 4. Examine the JSSE debug logs produced by the server: the failed connection > will have a PreMaster secret that begins with zero byte > (while all other connections have non-zero byte here). For example: > > SESSION KEYGEN: > PreMaster Secret: > 0000: 00 70 C5 7E 91 38 C8 DE ED 75 3D 76 8A B5 44 69 .p...8...u=v..Di > 0010: E7 32 1C EE 80 77 50 C7 A9 51 24 2E E3 15 11 30 .2...wP..Q$....0 > 0020: 9D F6 9F BC 9D EB 5C 18 F7 A4 19 ED 1A AC 2E 0C ......\......... > 0030: E3 18 C5 11 B1 80 07 7D B1 C6 70 A8 D7 EB CF DD ..........p..... > 0040: 2D B5 1D BC 01 3E 28 2A 2B 5B 38 8F EB 20 F2 A2 -....>(*+[8.. .. > 0050: 00 07 47 F7 87 B8 99 CB EF B4 13 04 C8 8B 82 FB ..G............. > > Expected Result: > Expected result is that every connection succeed. > > Actual Result: > Roughly one out of 256 connections fail. > > Source code for an executable test case: > > Java server: > > import javax.net.ssl.SSLServerSocket; > import javax.net.ssl.SSLServerSocketFactory; > import javax.net.ssl.SSLSocket; > > public class TestServer { > public static void main(String args[]) throws Exception { > SSLServerSocketFactory ssf = (SSLServerSocketFactory) > SSLServerSocketFactory.getDefault(); > SSLServerSocket ss = (SSLServerSocket) ssf.createServerSocket(9999); > System.out.println("Listening on port 9999"); > for (String cs : ss.getEnabledCipherSuites()) { > System.out.println(cs); > } > while (true) { > SSLSocket s = (SSLSocket) ss.accept(); > System.out.println("Connected with > "+s.getSession().getCipherSuite()); > s.close(); > } > } > } > > Run as as follows: > > keytool -storepass "password" -keypass "password" -genkey -keyalg RSA > -keystore test_keystore.jks -dname CN=test > javac TestServer.java > java -Djavax.net.debug=all -Djavax.net.ssl.keyStore=./test_keystore.jks > -Djavax.net.ssl.keyStorePassword=password TestServer > > OpenSSL client: > > set -e > while true; do > openssl s_client -cipher DHE-RSA-AES128-SHA -connect 127.0.0.1:9999 > -quiet -no_ign_eof < /dev/null > done > > Workaround: > Disable Diffie-Hellman cipher suites. > > ---snip--- > From chris.hegarty at oracle.com Thu May 16 03:06:05 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 16 May 2013 10:06:05 +0000 Subject: hg: jdk8/tl/jdk: 8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up Message-ID: <20130516100639.24F4548AF8@hg.openjdk.java.net> Changeset: bb01cc14223c Author: ewang Date: 2013-05-16 10:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb01cc14223c 8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up Reviewed-by: alanb, dholmes, chegar ! test/java/lang/Thread/GenerifyStackTraces.java - test/java/lang/Thread/StackTraces.java From xuelei.fan at oracle.com Thu May 16 04:32:05 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 16 May 2013 11:32:05 +0000 Subject: hg: jdk8/tl/jdk: 8010814: More buffers are stored or returned without cloning Message-ID: <20130516113218.341CD48AF9@hg.openjdk.java.net> Changeset: b198389f9da4 Author: xuelei Date: 2013-05-16 04:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b198389f9da4 8010814: More buffers are stored or returned without cloning Reviewed-by: lancea ! src/share/classes/com/sun/jndi/ldap/BerDecoder.java ! src/share/classes/com/sun/jndi/ldap/BerEncoder.java ! src/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java From dmitry.degrave at oracle.com Thu May 16 09:30:48 2013 From: dmitry.degrave at oracle.com (dmitry.degrave at oracle.com) Date: Thu, 16 May 2013 16:30:48 +0000 Subject: hg: jdk8/tl/jdk: 8014676: Java debugger may fail to run Message-ID: <20130516163105.B15E948B04@hg.openjdk.java.net> Changeset: 81c449fd18fe Author: dmeetry Date: 2013-05-16 19:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81c449fd18fe 8014676: Java debugger may fail to run Summary: The problem is observed when the binaries for windows are placed under a path which contains a space Reviewed-by: sla, alanb Contributed-by: ivan.gerasimov at oracle.com ! src/share/classes/com/sun/tools/jdi/AbstractLauncher.java ! src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java From michael.x.mcmahon at oracle.com Thu May 16 09:32:08 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 16 May 2013 16:32:08 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130516163231.64FEE48B05@hg.openjdk.java.net> Changeset: 74f91b7f4b66 Author: michaelm Date: 2013-05-16 17:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74f91b7f4b66 8012625: Incorrect handling of HTTP/1.1 " Expect: 100-continue " in HttpURLConnection Reviewed-by: alanb, chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/protocol/http/B8012625.java Changeset: d02d1b18d828 Author: michaelm Date: 2013-05-16 17:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d02d1b18d828 Merge From kurchi.subhra.hazra at oracle.com Thu May 16 10:48:47 2013 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Thu, 16 May 2013 17:48:47 +0000 Subject: hg: jdk8/tl/jdk: 7150552: network test hangs [macosx] Message-ID: <20130516174910.E623248B08@hg.openjdk.java.net> Changeset: a8be9405bb4b Author: khazra Date: 2013-05-16 10:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8be9405bb4b 7150552: network test hangs [macosx] Summary: Remove usage of test/sun/net/www/httptest Reviewed-by: chegar ! test/ProblemList.txt ! test/java/net/CookieHandler/CookieManagerTest.java ! test/sun/net/www/protocol/http/B6299712.java From kumar.x.srinivasan at oracle.com Thu May 16 11:13:57 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 16 May 2013 18:13:57 +0000 Subject: hg: jdk8/tl/jdk: 8001163: [pack200] should support attributes introduced by JSR-308 Message-ID: <20130516181409.97BD148B0A@hg.openjdk.java.net> Changeset: a13de892cefd Author: ksrini Date: 2013-05-15 18:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a13de892cefd 8001163: [pack200] should support attributes introduced by JSR-308 Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Fixups.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/native/com/sun/java/util/jar/pack/constants.h ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! test/tools/pack200/AttributeTests.java + test/tools/pack200/BandIntegrity.java ! test/tools/pack200/InstructionTests.java ! test/tools/pack200/Utils.java ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java + test/tools/pack200/typeannos/Lambda.java + test/tools/pack200/typeannos/Readme.txt + test/tools/pack200/typeannos/TargetTypes.java + test/tools/pack200/typeannos/TestTypeAnnotations.java + test/tools/pack200/typeannos/TypeUseTarget.java From daniel.fuchs at oracle.com Thu May 16 09:41:20 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Thu, 16 May 2013 16:41:20 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130516164146.B2CAB48B06@hg.openjdk.java.net> Changeset: da203779cb33 Author: jgish Date: 2013-05-16 11:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da203779cb33 8013380: Removal of stack walk to find resource bundle breaks Glassfish startup Summary: Use caller's classloader to load resource as an alternative to thread context classloader and system classloader Reviewed-by: mchung, alanb ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java ! test/java/util/logging/bundlesearch/IndirectlyLoadABundle.java - test/java/util/logging/bundlesearch/LoadItUp.java + test/java/util/logging/bundlesearch/LoadItUp1.java + test/java/util/logging/bundlesearch/LoadItUp2.java + test/java/util/logging/bundlesearch/LoadItUp2Invoker.java ! test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java + test/java/util/logging/bundlesearch/TwiceIndirectlyLoadABundle.java + test/java/util/logging/bundlesearch/resources/CallerSearchableResource_en.properties Changeset: df133f9cc4c9 Author: dfuchs Date: 2013-05-16 18:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df133f9cc4c9 Merge From vincent.x.ryan at oracle.com Thu May 16 13:27:29 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Thu, 16 May 2013 20:27:29 +0000 Subject: hg: jdk8/tl/jdk: 6 new changesets Message-ID: <20130516202851.8AD0048B18@hg.openjdk.java.net> Changeset: 9abf5dc83823 Author: vinnie Date: 2013-05-14 18:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9abf5dc83823 7194075: Various classes of sunec.jar are duplicated in rt.jar Reviewed-by: mullan, vinnie Contributed-by: Stephen Flores ! make/sun/security/ec/Makefile ! make/sun/security/other/Makefile ! makefiles/CreateJars.gmk + src/share/classes/sun/security/ec/CurveDB.java ! src/share/classes/sun/security/ec/ECDHKeyAgreement.java ! src/share/classes/sun/security/ec/ECDSASignature.java ! src/share/classes/sun/security/ec/ECKeyPairGenerator.java ! src/share/classes/sun/security/ec/ECParameters.java ! src/share/classes/sun/security/ec/ECPrivateKeyImpl.java ! src/share/classes/sun/security/ec/ECPublicKeyImpl.java ! src/share/classes/sun/security/ec/NamedCurve.java ! src/share/classes/sun/security/ec/SunECEntries.java ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11Key.java ! src/share/classes/sun/security/pkcs11/P11KeyStore.java ! src/share/classes/sun/security/ssl/JsseJce.java + src/share/classes/sun/security/util/ECKeySizeParameterSpec.java + src/share/classes/sun/security/util/ECUtil.java ! test/sun/security/pkcs11/ec/TestCurves.java ! test/sun/security/pkcs11/ec/TestECDH2.java ! test/sun/security/pkcs11/ec/TestECDSA2.java Changeset: fdf082cddb69 Author: vinnie Date: 2013-05-14 18:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fdf082cddb69 Merge Changeset: a399b8be56ae Author: vinnie Date: 2013-05-15 14:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a399b8be56ae Merge ! makefiles/CreateJars.gmk - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider Changeset: 5153f5154162 Author: vinnie Date: 2013-05-15 15:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5153f5154162 Merge Changeset: 0465f27f19f5 Author: vinnie Date: 2013-05-16 02:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0465f27f19f5 Merge - src/share/classes/java/time/format/DateTimeFormatSymbols.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java Changeset: 9783f07d43e6 Author: vinnie Date: 2013-05-16 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9783f07d43e6 Merge - test/java/lang/Thread/StackTraces.java - test/java/util/logging/bundlesearch/LoadItUp.java From mandy.chung at oracle.com Thu May 16 15:09:08 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 16 May 2013 22:09:08 +0000 Subject: hg: jdk8/tl/jdk: 4487672: (proxy) Proxy constructor should check for null argument Message-ID: <20130516220926.D7A1648B1C@hg.openjdk.java.net> Changeset: 5e8959ab64af Author: mchung Date: 2013-05-16 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e8959ab64af 4487672: (proxy) Proxy constructor should check for null argument Reviewed-by: alanb, lancea ! src/share/classes/java/lang/reflect/Proxy.java ! test/java/lang/reflect/Proxy/Basic1.java From weijun.wang at oracle.com Thu May 16 19:17:05 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 17 May 2013 10:17:05 +0800 Subject: RFR: 8012261: update policytool to support java.net.HttpURLPermission Message-ID: <51959321.9030204@oracle.com> Hi All Please take a look at http://cr.openjdk.java.net/~weijun/8012261/webrev.00/ which supports the new HttpURLPermission type introduced in 8010464: Evolve java networking same origin policy http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93a268759ec3 Noreg-trivial. Thanks Max From sean.mullan at oracle.com Fri May 17 05:19:07 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 17 May 2013 08:19:07 -0400 Subject: RFR: 8012261: update policytool to support java.net.HttpURLPermission In-Reply-To: <51959321.9030204@oracle.com> References: <51959321.9030204@oracle.com> Message-ID: <5196203B.1060508@oracle.com> Looks fine to me. --Sean On 05/16/2013 10:17 PM, Weijun Wang wrote: > Hi All > > Please take a look at > > http://cr.openjdk.java.net/~weijun/8012261/webrev.00/ > > which supports the new HttpURLPermission type introduced in > > 8010464: Evolve java networking same origin policy > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93a268759ec3 > > Noreg-trivial. > > Thanks > Max From chris.hegarty at oracle.com Fri May 17 07:22:39 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 17 May 2013 14:22:39 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130517142318.6ED9548B6D@hg.openjdk.java.net> Changeset: 3981ad7ec458 Author: chegar Date: 2013-05-17 15:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3981ad7ec458 8014791: More ProblemList.txt updates (5/2013) Reviewed-by: alanb ! test/ProblemList.txt Changeset: fab0e4b682e8 Author: chegar Date: 2013-05-17 15:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fab0e4b682e8 Merge ! test/ProblemList.txt - test/java/util/logging/bundlesearch/LoadItUp.java From chris.hegarty at oracle.com Fri May 17 08:46:14 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 17 May 2013 15:46:14 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130517154656.85C3548B6F@hg.openjdk.java.net> Changeset: 222da3d4692a Author: chegar Date: 2013-05-17 16:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/222da3d4692a 8014783: java/net/HttpURLPermission/HttpURLPermissionTest.java leaves files open Reviewed-by: michaelm ! test/java/net/HttpURLPermission/HttpURLPermissionTest.java Changeset: fed779a87670 Author: chegar Date: 2013-05-17 16:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fed779a87670 Merge - test/java/util/logging/bundlesearch/LoadItUp.java From dan.xu at oracle.com Fri May 17 12:04:51 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Fri, 17 May 2013 19:04:51 +0000 Subject: hg: jdk8/tl/jdk: 8011136: FileInputStream.available and skip inconsistencies Message-ID: <20130517190511.F304148B7B@hg.openjdk.java.net> Changeset: 3b1450ee2bb9 Author: dxu Date: 2013-05-17 12:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b1450ee2bb9 8011136: FileInputStream.available and skip inconsistencies Summary: Correct the behavior of available() and update related java specs for available() and skip() in InputStream and FileInputStream classes. Reviewed-by: alanb ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/InputStream.java ! src/share/native/java/io/FileInputStream.c ! test/java/io/FileInputStream/LargeFileAvailable.java ! test/java/io/FileInputStream/NegativeAvailable.java From jonathan.gibbons at oracle.com Fri May 17 13:49:09 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 17 May 2013 20:49:09 +0000 Subject: hg: jdk8/tl/langtools: 6885876: add comments to javac/util/Convert.java Message-ID: <20130517204912.98CB448B82@hg.openjdk.java.net> Changeset: 0928f2cfbf8e Author: jjg Date: 2013-05-17 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0928f2cfbf8e 6885876: add comments to javac/util/Convert.java Reviewed-by: mduigou ! src/share/classes/com/sun/tools/javac/util/Convert.java From christophe.ravel at oracle.com Fri May 17 14:01:32 2013 From: christophe.ravel at oracle.com (Christophe Ravel) Date: Fri, 17 May 2013 14:01:32 -0700 Subject: RFR: 8012261: update policytool to support java.net.HttpURLPermission In-Reply-To: <51959321.9030204@oracle.com> References: <51959321.9030204@oracle.com> Message-ID: <51969AAC.7050000@oracle.com> Hi Max, What is your plan for regression tests for this change ? Regards, Christophe. > Weijun Wang > May 16, 2013 7:17 PM > Hi All > > Please take a look at > > http://cr.openjdk.java.net/~weijun/8012261/webrev.00/ > > which supports the new HttpURLPermission type introduced in > > 8010464: Evolve java networking same origin policy > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93a268759ec3 > > Noreg-trivial. > > Thanks > Max -- Christophe Ravel | Principal Member of Technical Staff | +1.650.506.2162 OracleJava SQE - Security 4220 Network Circle, Office 2140, Santa Clara, CA 95054 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130517/53165221/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: compose-unknown-contact.jpg Type: image/jpeg Size: 770 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130517/53165221/compose-unknown-contact.jpg From daniel.fuchs at oracle.com Fri May 17 03:22:15 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Fri, 17 May 2013 10:22:15 +0000 Subject: hg: jdk8/tl/jdk: 8013900: More warnings compiling jaxp. Message-ID: <20130517102228.AD98548B64@hg.openjdk.java.net> Changeset: 68209420aac2 Author: dfuchs Date: 2013-05-17 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68209420aac2 8013900: More warnings compiling jaxp. Summary: Some internal implementation classes in Jaxp were redefining equals() without redefining hashCode(). This patch adds hashCode() methods that are consistent with equals(). Reviewed-by: chegar, joehw + test/javax/xml/jaxp/PrecisionDecimalDV/XPrecisionDecimalToString.java From daniel.fuchs at oracle.com Fri May 17 03:21:54 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Fri, 17 May 2013 10:21:54 +0000 Subject: hg: jdk8/tl/jaxp: 8013900: More warnings compiling jaxp. Message-ID: <20130517102159.5ACAF48B63@hg.openjdk.java.net> Changeset: 6443f5627744 Author: dfuchs Date: 2013-05-17 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6443f5627744 8013900: More warnings compiling jaxp. Summary: Some internal implementation classes in Jaxp were redefining equals() without redefining hashCode(). This patch adds hashCode() methods that are consistent with equals(). Reviewed-by: chegar, joehw ! src/com/sun/org/apache/bcel/internal/generic/BasicType.java ! src/com/sun/org/apache/bcel/internal/generic/BranchInstruction.java ! src/com/sun/org/apache/bcel/internal/generic/CodeExceptionGen.java ! src/com/sun/org/apache/bcel/internal/generic/LineNumberGen.java ! src/com/sun/org/apache/bcel/internal/generic/LocalVariableGen.java ! src/com/sun/org/apache/bcel/internal/generic/ReturnaddressType.java ! src/com/sun/org/apache/bcel/internal/generic/Select.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/VariableRefBase.java ! src/com/sun/org/apache/xerces/internal/impl/dv/xs/AbstractDateTimeDV.java ! src/com/sun/org/apache/xerces/internal/impl/dv/xs/DecimalDV.java ! src/com/sun/org/apache/xerces/internal/impl/dv/xs/PrecisionDecimalDV.java ! src/com/sun/org/apache/xerces/internal/util/URI.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeProxy.java ! src/com/sun/org/apache/xml/internal/serializer/utils/URI.java ! src/com/sun/org/apache/xml/internal/utils/URI.java ! src/com/sun/org/apache/xpath/internal/Arg.java From weijun.wang at oracle.com Fri May 17 19:13:16 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Sat, 18 May 2013 10:13:16 +0800 Subject: RFR: 8012261: update policytool to support java.net.HttpURLPermission In-Reply-To: <51969AAC.7050000@oracle.com> References: <51959321.9030204@oracle.com> <51969AAC.7050000@oracle.com> Message-ID: <5196E3BC.8070201@oracle.com> Hi Christophe No regression test. If there is an existing manual test checking all permissions supported, I'll be glad to update the description to cover this new type. Thanks Max On 5/18/13 5:01 AM, Christophe Ravel wrote: > Hi Max, > > What is your plan for regression tests for this change ? > > Regards, > Christophe. > >> Weijun Wang >> May 16, 2013 7:17 PM >> Hi All >> >> Please take a look at >> >> http://cr.openjdk.java.net/~weijun/8012261/webrev.00/ >> >> which supports the new HttpURLPermission type introduced in >> >> 8010464: Evolve java networking same origin policy >> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93a268759ec3 >> >> Noreg-trivial. >> >> Thanks >> Max > > -- > Christophe Ravel | Principal Member of Technical Staff | +1.650.506.2162 > OracleJava SQE - Security > 4220 Network Circle, Office 2140, Santa Clara, CA 95054 > From weijun.wang at oracle.com Fri May 17 19:16:13 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Sat, 18 May 2013 02:16:13 +0000 Subject: hg: jdk8/tl/jdk: 8012261: update policytool to support java.net.HttpURLPermission Message-ID: <20130518021637.F2CF848B91@hg.openjdk.java.net> Changeset: 0f7aaabed25f Author: weijun Date: 2013-05-18 10:15 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f7aaabed25f 8012261: update policytool to support java.net.HttpURLPermission Reviewed-by: mullan ! src/share/classes/sun/security/tools/policytool/PolicyTool.java ! src/share/classes/sun/security/tools/policytool/Resources.java From mike.duigou at oracle.com Sat May 18 18:58:34 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Sun, 19 May 2013 01:58:34 +0000 Subject: hg: jdk8/tl/jdk: 5 new changesets Message-ID: <20130519020304.C0B5148B9F@hg.openjdk.java.net> Changeset: e8b40b034fcd Author: psandoz Date: 2013-05-15 10:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8b40b034fcd 8013334: Spliterator behavior for LinkedList contradicts Spliterator.trySplit Summary: this changeset also contains some minor, non spec, related fixes to tidy up other areas of the JavaDoc. Reviewed-by: plevart, darcy Contributed-by: John Rose , Mike Duigou , Paul Sandoz ! src/share/classes/java/util/Spliterator.java Changeset: 6bbc2816d936 Author: psandoz Date: 2013-05-15 10:25 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6bbc2816d936 8014133: Spliterator.OfPrimitive Reviewed-by: mduigou, forax Contributed-by: Paul Sandoz , Brian Goetz ! src/share/classes/java/util/Spliterator.java Changeset: dc5cf74c8c9c Author: mduigou Date: 2013-05-17 10:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dc5cf74c8c9c 8004015: Additional static and instance utils for functional interfaces. 8011010: Spec j.u.f.Predicate doesn't specify NPEs thrown by the SE8's Reference Implementation Reviewed-by: briangoetz, dholmes, chegar ! src/share/classes/java/util/function/BiConsumer.java ! src/share/classes/java/util/function/BiFunction.java ! src/share/classes/java/util/function/BiPredicate.java ! src/share/classes/java/util/function/BooleanSupplier.java ! src/share/classes/java/util/function/Consumer.java ! src/share/classes/java/util/function/DoubleBinaryOperator.java ! src/share/classes/java/util/function/DoubleConsumer.java ! src/share/classes/java/util/function/DoubleFunction.java ! src/share/classes/java/util/function/DoublePredicate.java ! src/share/classes/java/util/function/DoubleSupplier.java ! src/share/classes/java/util/function/DoubleUnaryOperator.java ! src/share/classes/java/util/function/Function.java ! src/share/classes/java/util/function/IntBinaryOperator.java ! src/share/classes/java/util/function/IntConsumer.java ! src/share/classes/java/util/function/IntFunction.java ! src/share/classes/java/util/function/IntPredicate.java ! src/share/classes/java/util/function/IntSupplier.java ! src/share/classes/java/util/function/IntUnaryOperator.java ! src/share/classes/java/util/function/LongBinaryOperator.java ! src/share/classes/java/util/function/LongConsumer.java ! src/share/classes/java/util/function/LongFunction.java ! src/share/classes/java/util/function/LongPredicate.java ! src/share/classes/java/util/function/LongSupplier.java ! src/share/classes/java/util/function/LongUnaryOperator.java ! src/share/classes/java/util/function/ObjDoubleConsumer.java ! src/share/classes/java/util/function/ObjIntConsumer.java ! src/share/classes/java/util/function/ObjLongConsumer.java ! src/share/classes/java/util/function/Predicate.java ! src/share/classes/java/util/function/Supplier.java ! src/share/classes/java/util/function/ToDoubleBiFunction.java ! src/share/classes/java/util/function/ToDoubleFunction.java ! src/share/classes/java/util/function/ToIntBiFunction.java ! src/share/classes/java/util/function/ToIntFunction.java ! src/share/classes/java/util/function/ToLongBiFunction.java ! src/share/classes/java/util/function/ToLongFunction.java ! src/share/classes/java/util/function/UnaryOperator.java Changeset: 23e75751554a Author: henryjen Date: 2013-05-09 14:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23e75751554a 8006884: (fs) Add Files.list, lines and find Reviewed-by: briangoetz, mduigou Contributed-by: alan.bateman at oracle.com, henry.jen at oracle.com + src/share/classes/java/nio/file/FileTreeIterator.java ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/Files.java + test/java/nio/file/Files/FaultyFileSystem.java ! test/java/nio/file/Files/PassThroughFileSystem.java + test/java/nio/file/Files/StreamTest.java Changeset: b9b26b424bfc Author: mduigou Date: 2013-05-18 18:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b9b26b424bfc Merge From david.holmes at oracle.com Sun May 19 20:58:45 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Mon, 20 May 2013 03:58:45 +0000 Subject: hg: jdk8/tl/jdk: 8014477: (str) Race condition in String.contentEquals when comparing with StringBuffer Message-ID: <20130520035909.51B0A48BAE@hg.openjdk.java.net> Changeset: 08ebdb2b53cc Author: plevart Date: 2013-05-17 14:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/08ebdb2b53cc 8014477: (str) Race condition in String.contentEquals when comparing with StringBuffer Reviewed-by: alanb, mduigou, dholmes ! src/share/classes/java/lang/String.java + test/java/lang/String/StringContentEqualsBug.java From pe at iki.fi Mon May 20 02:28:59 2013 From: pe at iki.fi (Pasi Eronen) Date: Mon, 20 May 2013 12:28:59 +0300 Subject: 9001039?: DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times In-Reply-To: <51949143.2020208@oracle.com> References: <51949143.2020208@oracle.com> Message-ID: Hi Xuelei, It seems the PKSC11 doesn't actually have this bug. P11KeyAgreement has a separate code path for the "TlsPremasterSecret" algorithm, which strips leading zeroes if the key can be extracted from the token. (And if the key cannot be extracted, then the token is doing the premaster secret->master secret computation, and has to do the stripping -- it can't be done from the Java PKSC11 provider.) To make sure this behavior doesn't change, I added a test case for the PKSC11 provider to the Bugzilla (which passes with the "SunPKCS11-NSS" provider without any changes). Best regards, Pasi On Thu, May 16, 2013 at 10:56 AM, Xuelei Fan wrote: > Hi Pasi, > > Thank you for your patience, and contribution to OpenJDK. The bug is > accepted, and you should be able to review it at: > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014618 > > Let's use the above bug ID to track the issue. > > Your patch looks fine in general (I may have some very minor comments > later). We also have similar problems in PKCS11 provider because of the > update of P11KeyAgreement.java in changeset: > > http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 > > Would you like to also fix it in your patch? > > Thanks again for your nice work. > > Regards, > Xuelei > > > On 5/10/2013 5:00 PM, Pasi Eronen wrote: > > AKA "1 out of 256 SSL/TLS handshakes fails with DHE cipher suites" > > > > I reported this bug over a month of ago, but for some reason, it's not > > yet visible at bugs.sun.com . I've included the bug > > report below just in > > case. > > > > It seems this commit from March 2012 inadvertently broke SSL/TLS DHE > > cipher suites, causing the SSL/TLS handshake to fail approximately > > 1 out of 256 times: > > > > http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 > > > > The commit was done to fix this bug: > > > > http://bugs.sun.com/view_bug.do?bug_id=7146728 > > > > While generating a secret of the same length as modulus may be the right > > choice generally speaking (and it's what e.g. IPsec uses), SSL/TLS uses > > a different convention: leading zeroes must be stripped. > > > > This is currently blocking us from updating our production systems to > > Java 7, so although I have not contributed to OpenJDK before, I'd like > > to submit a patch and a test case for this (I've signed the OCA > > already). But before I do this, I'd like to check that the approach is > > agreeable. > > > > We have a separate "algorithm" value "TlsPremasterSecret", so > > behavior for other cases could stay the same. Would a patch > > like this: > > > > } else if (algorithm.equals("TlsPremasterSecret")) { > > // remove leading zero bytes per RFC 5246 Section 8.1.2 > > int i = 0; > > while ((i < secret.length - 1) && (secret[i] == 0)) { > > i++; > > } > > if (i == 0) { > > return new SecretKeySpec(secret, "TlsPremasterSecret"); > > } else { > > byte[] secret2 = new byte[secret.length - i]; > > System.arraycopy(secret, i, secret2, 0, secret2.length); > > return new SecretKeySpec(secret2, "TlsPremasterSecret"); > > } > > } > > > > Plus a test case (with fixed keys) that checks that leading zero is > > stripped > > for TlsPremasterSecret and is not stripped otherwise, be sufficient? > > > > Best regards, > > Pasi > > > > ---snip--- > > > > Synopsis: > > DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times > > > > Full OS version: > > Tested on Windows 7 (Microsoft Windows [Version 6.1.7601]), but occurs in > > e..g OpenJDK 7 as well. > > > > Development Kit or Runtime version: > > java version "1.7.0_17" > > Java(TM) SE Runtime Environment (build 1.7.0_17-b02) > > Java HotSpot(TM) Client VM (build 23.7-b01, mixed mode, sharing) > > > > Description: > > When performing Diffie-Hellman key agreement for SSL/TLS, the TLS > > specification (RFC 5246) says that "Leading bytes of Z that contain all > zero > > bits are stripped before it is used as the pre_master_secret." > > > > However, com.sun.crypto.provider.DHKeyAgreement.java does not strip > leading > > zero bytes. This causes approximately 1 out 256 SSL/TLS handshakes with > > DH/DHE cipher suites to fail (when the leading byte happens, by chance, > to > > be zero). > > > > Steps to Reproduce: > > 1. Start a simple JSSE socket server with -Djavax.net.debug=all. > > > > 2. Connect to the server with e.g. OpenSSL command line tool, ensuring > that > > DHE cipher suite gets selected (e.g. "openssl s_client -cipher > > DHE-RSA-AES128-SHA -connect 192.168.81.1:9999 > > ") repeatedly. Other SSL > > clients can be used -- this is not an OpenSSL bug (see below). > > > > 3. Repeat the connection. After a couple of hundred successful > connections, > > the connection will fail with handshake_failure alert. > > > > 4. Examine the JSSE debug logs produced by the server: the failed > connection > > will have a PreMaster secret that begins with zero byte > > (while all other connections have non-zero byte here). For example: > > > > SESSION KEYGEN: > > PreMaster Secret: > > 0000: 00 70 C5 7E 91 38 C8 DE ED 75 3D 76 8A B5 44 69 .p...8...u=v..Di > > 0010: E7 32 1C EE 80 77 50 C7 A9 51 24 2E E3 15 11 30 .2...wP..Q$....0 > > 0020: 9D F6 9F BC 9D EB 5C 18 F7 A4 19 ED 1A AC 2E 0C ......\......... > > 0030: E3 18 C5 11 B1 80 07 7D B1 C6 70 A8 D7 EB CF DD ..........p..... > > 0040: 2D B5 1D BC 01 3E 28 2A 2B 5B 38 8F EB 20 F2 A2 -....>(*+[8.. .. > > 0050: 00 07 47 F7 87 B8 99 CB EF B4 13 04 C8 8B 82 FB ..G............. > > > > Expected Result: > > Expected result is that every connection succeed. > > > > Actual Result: > > Roughly one out of 256 connections fail. > > > > Source code for an executable test case: > > > > Java server: > > > > import javax.net.ssl.SSLServerSocket; > > import javax.net.ssl.SSLServerSocketFactory; > > import javax.net.ssl.SSLSocket; > > > > public class TestServer { > > public static void main(String args[]) throws Exception { > > SSLServerSocketFactory ssf = (SSLServerSocketFactory) > > SSLServerSocketFactory.getDefault(); > > SSLServerSocket ss = (SSLServerSocket) > ssf.createServerSocket(9999); > > System.out.println("Listening on port 9999"); > > for (String cs : ss.getEnabledCipherSuites()) { > > System.out.println(cs); > > } > > while (true) { > > SSLSocket s = (SSLSocket) ss.accept(); > > System.out.println("Connected with > > "+s.getSession().getCipherSuite()); > > s.close(); > > } > > } > > } > > > > Run as as follows: > > > > keytool -storepass "password" -keypass "password" -genkey -keyalg RSA > > -keystore test_keystore.jks -dname CN=test > > javac TestServer.java > > java -Djavax.net.debug=all -Djavax.net.ssl.keyStore=./test_keystore.jks > > -Djavax.net.ssl.keyStorePassword=password TestServer > > > > OpenSSL client: > > > > set -e > > while true; do > > openssl s_client -cipher DHE-RSA-AES128-SHA -connect 127.0.0.1:9999 > > -quiet -no_ign_eof < /dev/null > > done > > > > Workaround: > > Disable Diffie-Hellman cipher suites. > > > > ---snip--- > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130520/c427955f/attachment.html From sundararajan.athijegannathan at oracle.com Mon May 20 06:56:42 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 20 May 2013 13:56:42 +0000 Subject: hg: jdk8/tl/nashorn: 15 new changesets Message-ID: <20130520135653.CBBAA48BB9@hg.openjdk.java.net> Changeset: 80d4db063d5a Author: jlaskey Date: 2013-05-14 11:15 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/80d4db063d5a 8014512: Exclude testing and infrastructure packages from code coverage Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! make/code_coverage.xml Changeset: eeed4db61215 Author: jlaskey Date: 2013-05-14 11:16 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/eeed4db61215 Merge - src/jdk/nashorn/internal/ir/LineNumberNode.java - src/jdk/nashorn/internal/ir/Location.java - test/script/trusted/logcoverage.js Changeset: fc20983ef38e Author: attila Date: 2013-05-14 19:18 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fc20983ef38e 8011718: binding already bound function with extra arguments fails Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java + test/script/basic/JDK-8011718.js + test/script/basic/JDK-8011718.js.EXPECTED Changeset: f88a4818a4dc Author: lagergren Date: 2013-05-14 19:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f88a4818a4dc 8014426: Original exception no longer thrown away when a finally rethrows Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8014426.js + test/script/basic/JDK-8014426.js.EXPECTED Changeset: 64ef1aeaeb4e Author: attila Date: 2013-05-15 10:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/64ef1aeaeb4e 8014639: Remove debug flag from test runs Reviewed-by: hannesw, lagergren ! make/project.properties Changeset: b37eb709ae27 Author: attila Date: 2013-05-15 14:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b37eb709ae27 8014646: Update the Java interop documentation in the Java Scripting Programmer's Guide Reviewed-by: jlaskey, hannesw, lagergren ! docs/JavaScriptingProgrammersGuide.html Changeset: 1eaa542cc8e2 Author: sundar Date: 2013-05-15 19:45 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1eaa542cc8e2 8012305: Function.bind can't be called on prototype function inside constructor Reviewed-by: lagergren, attila + test/script/basic/JDK-8012305.js + test/script/basic/JDK-8012305.js.EXPECTED Changeset: 6344644b81ec Author: jlaskey Date: 2013-05-15 12:09 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6344644b81ec 8014648: Exclude testing and infrastructure packages from code coverage, round two Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! make/code_coverage.xml ! src/jdk/nashorn/internal/runtime/options/Option.java ! src/jdk/nashorn/internal/runtime/options/Options.java - src/jdk/nashorn/internal/runtime/options/ValueOption.java ! test/script/basic/allgettersetters.js Changeset: 19e9cd9c7010 Author: attila Date: 2013-05-15 20:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/19e9cd9c7010 8014647: Allow class-based overrides to be initialized with a ScriptFunction Reviewed-by: hannesw, jlaskey, sundar ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java + test/script/basic/JDK-8014647.js + test/script/basic/JDK-8014647.js.EXPECTED Changeset: ac14a1fb0cab Author: sundar Date: 2013-05-16 14:52 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ac14a1fb0cab 8009141: Avoid netscape.javascript.JSObject in nashorn code Reviewed-by: lagergren, hannesw + src/jdk/nashorn/api/scripting/JSObject.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java - src/netscape/javascript/JSObject.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: 4c67a692ef97 Author: lagergren Date: 2013-05-16 13:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4c67a692ef97 8013919: Original exception no longer thrown away when a finally rethrows Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/ir/FunctionNode.java + test/script/basic/JDK-8013919.js + test/script/basic/JDK-8013919.js.EXPECTED Changeset: 98798a6336de Author: hannesw Date: 2013-05-16 19:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/98798a6336de 8012359: Increase code coverage in Joni Reviewed-by: jlaskey, lagergren ! make/build.xml - src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java + src/jdk/nashorn/internal/runtime/regexp/JdkRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/RegExpFactory.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Analyser.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ArrayCompiler.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompiler.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompilerSupport.java ! src/jdk/nashorn/internal/runtime/regexp/joni/BitSet.java ! src/jdk/nashorn/internal/runtime/regexp/joni/BitStatus.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodePrinter.java - src/jdk/nashorn/internal/runtime/regexp/joni/CaptureTreeNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Compiler.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Config.java ! src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Lexer.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Matcher.java - src/jdk/nashorn/internal/runtime/regexp/joni/NameEntry.java - src/jdk/nashorn/internal/runtime/regexp/joni/NativeMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Regex.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Region.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ScanEnvironment.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ScannerSupport.java ! src/jdk/nashorn/internal/runtime/regexp/joni/StackMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Syntax.java - src/jdk/nashorn/internal/runtime/regexp/joni/UnsetAddrList.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/CClassNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CTypeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CallNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/EncloseNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/QuantifierNode.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ast/StateNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/AbstractBench.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchGreedyBacktrack.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchRailsRegs.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchSeveralRegexps.java ! src/jdk/nashorn/internal/runtime/regexp/joni/constants/OPCode.java - src/jdk/nashorn/internal/runtime/regexp/joni/constants/Reduce.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java ! src/jdk/nashorn/internal/runtime/regexp/joni/encoding/ObjPtr.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/PosixBracket.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/Ptr.java ! src/jdk/nashorn/internal/runtime/regexp/joni/exception/ErrorMessages.java ! src/jdk/nashorn/internal/runtime/regexp/joni/exception/ValueException.java + test/src/jdk/nashorn/internal/runtime/regexp/JdkRegExpTest.java + test/src/jdk/nashorn/internal/runtime/regexp/joni/JoniTest.java Changeset: aa1b6e8c51a0 Author: jlaskey Date: 2013-05-17 14:30 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/aa1b6e8c51a0 8012694: Smoke test fail: Windows JDK-8008554.js - access denied ("java.io.FilePermission" "//C/aurora/sandbox/nashorn~source/test/script/basic/NASHORN-99.js" "read") Reviewed-by: jlaskey Contributed-by: konstantin.shefov at oracle.com Changeset: a92be4c0063b Author: jlaskey Date: 2013-05-17 16:12 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a92be4c0063b Merge - src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompiler.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompilerSupport.java - src/jdk/nashorn/internal/runtime/regexp/joni/CaptureTreeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/NameEntry.java - src/jdk/nashorn/internal/runtime/regexp/joni/NativeMachine.java - src/jdk/nashorn/internal/runtime/regexp/joni/UnsetAddrList.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CTypeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CallNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/AbstractBench.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchGreedyBacktrack.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchRailsRegs.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchSeveralRegexps.java - src/jdk/nashorn/internal/runtime/regexp/joni/constants/Reduce.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/PosixBracket.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/Ptr.java - src/netscape/javascript/JSObject.java Changeset: 1d5a8f1f416e Author: jlaskey Date: 2013-05-17 16:44 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1d5a8f1f416e 8014823: Reprise - Smoke test fail: Windows JDK-8008554.js - access denied ("java.io.FilePermission" "//C/aurora/sandbox/nashorn~source/test/script/basic/NASHORN-99.js" "read") Reviewed-by: jlaskey Contributed-by: konstantin.shefov at oracle.com ! test/script/basic/JDK-8008554.js From xueming.shen at oracle.com Mon May 20 11:59:29 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 20 May 2013 18:59:29 +0000 Subject: hg: jdk8/tl/jdk: 8004789: (zipfs) zip provider doesn't work correctly with file systems providers rather than the default Message-ID: <20130520185952.A40F548BC7@hg.openjdk.java.net> Changeset: 6a9148865139 Author: sherman Date: 2013-05-20 11:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a9148865139 8004789: (zipfs) zip provider doesn't work correctly with file systems providers rather than the default Summary: to use Files.createTempFile(...) to create the temp file on the same fs as the targeted path. Reviewed-by: alanb, sherman Contributed-by: philippe.marschall at gmail.com ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java From huizhe.wang at oracle.com Mon May 20 16:12:35 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Mon, 20 May 2013 23:12:35 +0000 Subject: hg: jdk8/tl/jaxp: 8014891: Redundant setting of external access properties in setFeatures Message-ID: <20130520231237.47F0948BD0@hg.openjdk.java.net> Changeset: a7cec93e4682 Author: joehw Date: 2013-05-20 16:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a7cec93e4682 8014891: Redundant setting of external access properties in setFeatures Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java From david.holmes at oracle.com Mon May 20 22:18:38 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Tue, 21 May 2013 05:18:38 +0000 Subject: hg: jdk8/tl/jdk: 8014857: Enable ergonomic VM selection in arm/jvm.cfg Message-ID: <20130521051851.0FA6348BDB@hg.openjdk.java.net> Changeset: 1baf3d7fe2f1 Author: dholmes Date: 2013-05-21 01:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1baf3d7fe2f1 8014857: Enable ergonomic VM selection in arm/jvm.cfg Reviewed-by: darcy ! src/solaris/bin/arm/jvm.cfg From huizhe.wang at oracle.com Mon May 20 23:47:43 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 21 May 2013 06:47:43 +0000 Subject: hg: jdk8/tl/jaxp: 8012683: Remove unused, obsolete ObjectFactory classes Message-ID: <20130521064745.7E3E248BDF@hg.openjdk.java.net> Changeset: 37b73984640a Author: joehw Date: 2013-05-20 23:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/37b73984640a 8012683: Remove unused, obsolete ObjectFactory classes Reviewed-by: lancea - src/com/sun/org/apache/xerces/internal/xinclude/ObjectFactory.java - src/com/sun/org/apache/xml/internal/serialize/ObjectFactory.java From sundararajan.athijegannathan at oracle.com Tue May 21 00:27:37 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 21 May 2013 07:27:37 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20130521072740.0FC5B48BE0@hg.openjdk.java.net> Changeset: 92164a5742db Author: lagergren Date: 2013-05-20 16:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/92164a5742db 8006069: Range analysis first iteration, runtime specializations Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java + src/jdk/nashorn/internal/codegen/RangeAnalyzer.java + src/jdk/nashorn/internal/codegen/types/Range.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/runtime/CompiledFunction.java ! src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties + test/script/basic/ranges_disabled.js + test/script/basic/ranges_disabled.js.EXPECTED + test/script/basic/ranges_enabled.js + test/script/basic/ranges_enabled.js.EXPECTED + test/script/basic/ranges_payload.js Changeset: b558e19d5de5 Author: sundar Date: 2013-05-20 23:04 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b558e19d5de5 8014909: ant test compilation error with JoniTest.java Reviewed-by: jlaskey ! make/build.xml Changeset: 1fd18f40ab52 Author: attila Date: 2013-05-20 21:25 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1fd18f40ab52 8014797: rename Java.toJavaArray/toJavaScriptArray to Java.to/from, respectively. Reviewed-by: jlaskey, sundar ! docs/JavaScriptingProgrammersGuide.html ! docs/source/javaarray.js ! src/jdk/nashorn/api/scripting/resources/engine.js ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties ! test/script/basic/NASHORN-556.js ! test/script/basic/javaarrayconversion.js ! test/script/currently-failing/logcoverage.js ! test/script/trusted/NASHORN-638.js ! test/script/trusted/NASHORN-653.js From alan.bateman at oracle.com Tue May 21 00:58:57 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 21 May 2013 07:58:57 +0000 Subject: hg: jdk8/tl/jdk: 8014892: More ProblemList.txt updates (5/2013) Message-ID: <20130521075910.6E4FC48BE3@hg.openjdk.java.net> Changeset: 20925206aef8 Author: alanb Date: 2013-05-21 08:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/20925206aef8 8014892: More ProblemList.txt updates (5/2013) Reviewed-by: alanb Contributed-by: amy.lu at oracle.com ! test/ProblemList.txt From youdwei at linux.vnet.ibm.com Tue May 21 02:07:53 2013 From: youdwei at linux.vnet.ibm.com (Deven You) Date: Tue, 21 May 2013 17:07:53 +0800 Subject: Signature.getAlogrithm return null in special case In-Reply-To: <5192D6C7.6050900@oracle.com> References: <5191C1B2.4030900@linux.vnet.ibm.com> <5192D6C7.6050900@oracle.com> Message-ID: <519B3969.3020807@linux.vnet.ibm.com> Hi Brad, Thanks for your reply, is there any progress on this problem? I see the last comments on JDK-8014620 is six days before. Thanks a lot! On 05/15/2013 08:28 AM, Brad Wetmore wrote: > Offhand, this seems reasonable. > > Since you are an OpenJDK author, I've filed: > > JDK-8014620: Signature.getAlogrithm return null in special case > > and stocked it with your patch. > > Thanks, > > Brad > > > On 5/13/2013 9:46 PM, Deven You wrote: >> Hi All, >> >> I find in a special case: If you create a SignatureSpi service through >> extending Signature rather than SignatureSpi, the returned signature >> instance will lose its algortithm name. >> >> Though the fix[1] is simple I think it's valuable. Could anyone take >> a look? >> >> [1] http://cr.openjdk.java.net/~youdwei/ojdk-809/webrev/ >> >> >> Thanks a lot > From vicente.romero at oracle.com Tue May 21 03:42:05 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 21 May 2013 10:42:05 +0000 Subject: hg: jdk8/tl/langtools: 7177168: Redundant array copy in UnsharedNameTable Message-ID: <20130521104209.7400548BEB@hg.openjdk.java.net> Changeset: 824932ecdbc8 Author: vromero Date: 2013-05-21 11:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/824932ecdbc8 7177168: Redundant array copy in UnsharedNameTable Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/util/UnsharedNameTable.java From vicente.romero at oracle.com Tue May 21 04:18:20 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 21 May 2013 11:18:20 +0000 Subject: hg: jdk8/tl/langtools: 7060779: test/tools/javac/diags/Example.java leaves directories in tempdir Message-ID: <20130521111823.EE51348BEC@hg.openjdk.java.net> Changeset: 3d9750039fff Author: vromero Date: 2013-05-21 12:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d9750039fff 7060779: test/tools/javac/diags/Example.java leaves directories in tempdir Reviewed-by: mcimadamore ! test/tools/javac/diags/Example.java From vicente.romero at oracle.com Tue May 21 05:51:37 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 21 May 2013 12:51:37 +0000 Subject: hg: jdk8/tl/langtools: 8005207: test has 2 @bug tags Message-ID: <20130521125141.2FAA948BF3@hg.openjdk.java.net> Changeset: 37295244f534 Author: vromero Date: 2013-05-21 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37295244f534 8005207: test has 2 @bug tags Reviewed-by: mcimadamore ! test/tools/doclint/RunTest.java ! test/tools/javac/5045412/Bar.java ! test/tools/javac/5045412/Foo.java ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java ! test/tools/javac/mandatoryWarnings/deprecated/Test.java ! test/tools/javac/mandatoryWarnings/unchecked/Test.java ! test/tools/javac/policy/test3/Test.java From vicente.romero at oracle.com Tue May 21 06:33:41 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 21 May 2013 13:33:41 +0000 Subject: hg: jdk8/tl/langtools: 7164114: Two jtreg tests are not run due to no file extension on the test files Message-ID: <20130521133343.D6F9F48BF5@hg.openjdk.java.net> Changeset: 08daea43a7f8 Author: vromero Date: 2013-05-21 14:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/08daea43a7f8 7164114: Two jtreg tests are not run due to no file extension on the test files Reviewed-by: mcimadamore - test/tools/javac/HiddenAbstractMethod/Test + test/tools/javac/HiddenAbstractMethod/Test.java - test/tools/javac/NonAmbiguousField/Test + test/tools/javac/NonAmbiguousField/Test.java ! test/tools/javac/NonAmbiguousField/two/Child2.java From anthony.scarpino at oracle.com Tue May 21 10:42:03 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Tue, 21 May 2013 10:42:03 -0700 Subject: Code Review: 7160837 DigestOutputStream does not turn off digest calculation when "close()" is called In-Reply-To: <51925515.9010702@oracle.com> References: <51925515.9010702@oracle.com> Message-ID: <971073AF-FA55-4C8F-9EE5-AD9524ABCAE6@oracle.com> ping... No comments? Perfect? :-) On May 14, 2013, at 8:15 AM, Anthony Scarpino wrote: > Hi, > > Below is the link to code changes for: DigestOutputStream does not turn off digest calculation when "close()" is called. > > The more significant change is to the Cipher streams to prevent extra doFinal() calls. > > http://cr.openjdk.java.net/~ascarpino/7160837/webrev.00/ > > thanks > > Tony From yong.huang at oracle.com Tue May 21 01:53:42 2013 From: yong.huang at oracle.com (yong.huang at oracle.com) Date: Tue, 21 May 2013 08:53:42 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130521085406.EFDE748BE7@hg.openjdk.java.net> Changeset: 63c7e92e5e6d Author: yhuang Date: 2013-05-20 23:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/63c7e92e5e6d 7074882: Locale data needs correction (Month names for Maltese language) Reviewed-by: naoto ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 1fba35ef4360 Author: yhuang Date: 2013-05-21 01:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1fba35ef4360 Merge From joel.franck at oracle.com Tue May 21 03:02:59 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 21 May 2013 10:02:59 +0000 Subject: hg: jdk8/tl/langtools: 8013180: Qualified type reference with annotations in throws list crashes compiler Message-ID: <20130521100302.A893E48BE8@hg.openjdk.java.net> Changeset: 67cbd6d756f4 Author: jfranck Date: 2013-05-21 12:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67cbd6d756f4 8013180: Qualified type reference with annotations in throws list crashes compiler Reviewed-by: jjg + test/tools/javac/annotations/typeAnnotations/8013180/QualifiedName.java From xuelei.fan at oracle.com Tue May 21 19:34:53 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 22 May 2013 10:34:53 +0800 Subject: 9001039?: DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times In-Reply-To: References: <51949143.2020208@oracle.com> Message-ID: <519C2ECD.7040207@oracle.com> On 5/20/2013 5:28 PM, Pasi Eronen wrote: > Hi Xuelei, > > It seems the PKSC11 doesn't actually have this bug. > > P11KeyAgreement has a separate code path for the "TlsPremasterSecret" > algorithm, which strips leading zeroes if the key can be extracted from > the token. (And if the key cannot be extracted, then the token is doing > the premaster secret->master secret computation, and has to do the > stripping -- it can't be done from the Java PKSC11 provider.) > It makes sense to me. > To make sure this behavior doesn't change, I added a test case > for the PKSC11 provider to the Bugzilla (which passes with the > "SunPKCS11-NSS" provider without any changes). > That's great. Would you mind to contribute the regression test for PKCS11 provider? Thanks, Xuelei > Best regards, > Pasi > > > > On Thu, May 16, 2013 at 10:56 AM, Xuelei Fan > wrote: > > Hi Pasi, > > Thank you for your patience, and contribution to OpenJDK. The bug is > accepted, and you should be able to review it at: > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014618 > > Let's use the above bug ID to track the issue. > > Your patch looks fine in general (I may have some very minor comments > later). We also have similar problems in PKCS11 provider because of the > update of P11KeyAgreement.java in changeset: > > http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 > > Would you like to also fix it in your patch? > > Thanks again for your nice work. > > Regards, > Xuelei > > > On 5/10/2013 5:00 PM, Pasi Eronen wrote: > > AKA "1 out of 256 SSL/TLS handshakes fails with DHE cipher suites" > > > > I reported this bug over a month of ago, but for some reason, it's not > > yet visible at bugs.sun.com > . I've included the bug > > report below just in > > case. > > > > It seems this commit from March 2012 inadvertently broke SSL/TLS DHE > > cipher suites, causing the SSL/TLS handshake to fail approximately > > 1 out of 256 times: > > > > http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 > > > > The commit was done to fix this bug: > > > > http://bugs.sun.com/view_bug.do?bug_id=7146728 > > > > While generating a secret of the same length as modulus may be the > right > > choice generally speaking (and it's what e.g. IPsec uses), SSL/TLS > uses > > a different convention: leading zeroes must be stripped. > > > > This is currently blocking us from updating our production systems to > > Java 7, so although I have not contributed to OpenJDK before, I'd like > > to submit a patch and a test case for this (I've signed the OCA > > already). But before I do this, I'd like to check that the approach is > > agreeable. > > > > We have a separate "algorithm" value "TlsPremasterSecret", so > > behavior for other cases could stay the same. Would a patch > > like this: > > > > } else if (algorithm.equals("TlsPremasterSecret")) { > > // remove leading zero bytes per RFC 5246 Section 8.1.2 > > int i = 0; > > while ((i < secret.length - 1) && (secret[i] == 0)) { > > i++; > > } > > if (i == 0) { > > return new SecretKeySpec(secret, "TlsPremasterSecret"); > > } else { > > byte[] secret2 = new byte[secret.length - i]; > > System.arraycopy(secret, i, secret2, 0, secret2.length); > > return new SecretKeySpec(secret2, "TlsPremasterSecret"); > > } > > } > > > > Plus a test case (with fixed keys) that checks that leading zero is > > stripped > > for TlsPremasterSecret and is not stripped otherwise, be sufficient? > > > > Best regards, > > Pasi > > > > ---snip--- > > > > Synopsis: > > DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times > > > > Full OS version: > > Tested on Windows 7 (Microsoft Windows [Version 6.1.7601]), but > occurs in > > e..g OpenJDK 7 as well. > > > > Development Kit or Runtime version: > > java version "1.7.0_17" > > Java(TM) SE Runtime Environment (build 1.7.0_17-b02) > > Java HotSpot(TM) Client VM (build 23.7-b01, mixed mode, sharing) > > > > Description: > > When performing Diffie-Hellman key agreement for SSL/TLS, the TLS > > specification (RFC 5246) says that "Leading bytes of Z that > contain all zero > > bits are stripped before it is used as the pre_master_secret." > > > > However, com.sun.crypto.provider.DHKeyAgreement.java does not > strip leading > > zero bytes. This causes approximately 1 out 256 SSL/TLS handshakes > with > > DH/DHE cipher suites to fail (when the leading byte happens, by > chance, to > > be zero). > > > > Steps to Reproduce: > > 1. Start a simple JSSE socket server with -Djavax.net.debug=all. > > > > 2. Connect to the server with e.g. OpenSSL command line tool, > ensuring that > > DHE cipher suite gets selected (e.g. "openssl s_client -cipher > > DHE-RSA-AES128-SHA -connect 192.168.81.1:9999 > > > ") repeatedly. Other SSL > > clients can be used -- this is not an OpenSSL bug (see below). > > > > 3. Repeat the connection. After a couple of hundred successful > connections, > > the connection will fail with handshake_failure alert. > > > > 4. Examine the JSSE debug logs produced by the server: the failed > connection > > will have a PreMaster secret that begins with zero byte > > (while all other connections have non-zero byte here). For example: > > > > SESSION KEYGEN: > > PreMaster Secret: > > 0000: 00 70 C5 7E 91 38 C8 DE ED 75 3D 76 8A B5 44 69 > .p...8...u=v..Di > > 0010: E7 32 1C EE 80 77 50 C7 A9 51 24 2E E3 15 11 30 > .2...wP..Q$....0 > > 0020: 9D F6 9F BC 9D EB 5C 18 F7 A4 19 ED 1A AC 2E 0C > ......\......... > > 0030: E3 18 C5 11 B1 80 07 7D B1 C6 70 A8 D7 EB CF DD > ..........p..... > > 0040: 2D B5 1D BC 01 3E 28 2A 2B 5B 38 8F EB 20 F2 A2 > -....>(*+[8.. .. > > 0050: 00 07 47 F7 87 B8 99 CB EF B4 13 04 C8 8B 82 FB > ..G............. > > > > Expected Result: > > Expected result is that every connection succeed. > > > > Actual Result: > > Roughly one out of 256 connections fail. > > > > Source code for an executable test case: > > > > Java server: > > > > import javax.net.ssl.SSLServerSocket; > > import javax.net.ssl.SSLServerSocketFactory; > > import javax.net.ssl.SSLSocket; > > > > public class TestServer { > > public static void main(String args[]) throws Exception { > > SSLServerSocketFactory ssf = (SSLServerSocketFactory) > > SSLServerSocketFactory.getDefault(); > > SSLServerSocket ss = (SSLServerSocket) > ssf.createServerSocket(9999); > > System.out.println("Listening on port 9999"); > > for (String cs : ss.getEnabledCipherSuites()) { > > System.out.println(cs); > > } > > while (true) { > > SSLSocket s = (SSLSocket) ss.accept(); > > System.out.println("Connected with > > "+s.getSession().getCipherSuite()); > > s.close(); > > } > > } > > } > > > > Run as as follows: > > > > keytool -storepass "password" -keypass "password" -genkey -keyalg RSA > > -keystore test_keystore.jks -dname CN=test > > javac TestServer.java > > java -Djavax.net.debug=all > -Djavax.net.ssl.keyStore=./test_keystore.jks > > -Djavax.net.ssl.keyStorePassword=password TestServer > > > > OpenSSL client: > > > > set -e > > while true; do > > openssl s_client -cipher DHE-RSA-AES128-SHA -connect > 127.0.0.1:9999 > > -quiet -no_ign_eof < /dev/null > > done > > > > Workaround: > > Disable Diffie-Hellman cipher suites. > > > > ---snip--- > > > > From chris.hegarty at oracle.com Wed May 22 05:52:14 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 22 May 2013 12:52:14 +0000 Subject: hg: jdk8/tl/jdk: 8010182: Thread safety of Thread get/setName() Message-ID: <20130522125238.761DE48C39@hg.openjdk.java.net> Changeset: 48e8a6e0c805 Author: chegar Date: 2013-05-22 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48e8a6e0c805 8010182: Thread safety of Thread get/setName() Reviewed-by: dholmes, alanb, mduigou ! src/share/classes/java/lang/Thread.java From mike.duigou at oracle.com Wed May 22 10:01:19 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 22 May 2013 17:01:19 +0000 Subject: hg: jdk8/tl/jdk: 8014819: set max size for jtreg testvms Message-ID: <20130522170130.DB0FB48C45@hg.openjdk.java.net> Changeset: 4b555b53dc57 Author: mduigou Date: 2013-05-22 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b555b53dc57 8014819: set max size for jtreg testvms Reviewed-by: alanb, darcy ! test/Makefile From john.zavgren at oracle.com Wed May 22 11:54:28 2013 From: john.zavgren at oracle.com (John Zavgren) Date: Wed, 22 May 2013 14:54:28 -0400 Subject: RFR JDK-8014307 Message-ID: <519D1464.2080800@oracle.com> Greetings: I just updated: /jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c /with the recommended changes. http://cr.openjdk.java.net/~jzavgren/8014307/webrev.02/ Thanks! John Zavgren ---------------------------------------------------------------------- John, 1) 332-333 can be replaced w/ a deleteGSSOID(nameType) call. Also, with this deleteGSSOID(nameType) call, we should also add the following line: resetGSSBuffer(env, jnameVal, &nameVal); 2) I think the ExceptionCheck block on line 932 should also be enhanced w/ resetGSSBuffer(env, jinToken, &inToken) call as well as free(cb) call. Same goes for another ExceptionCheck blocks on line 984, 998, 1024. Thanks, Valerie On 05/14/13 19:19, John Zavgren wrote: >/ Greetings: Please review the following change to the file: />/ jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c that fixes />/ two memory leaks. />/ http://cr.openjdk.java.net/~jzavgren/8014307/webrev.01/ Thanks! John />/ Zavgren/ -- John Zavgren john.zavgren at oracle.com 603-821-0904 US-Burlington-MA -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130522/3f0fdfaa/attachment.html From lana.steuck at oracle.com Wed May 22 12:10:35 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:10:35 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20130522191041.2549C48C48@hg.openjdk.java.net> Changeset: c8286839d0df Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/c8286839d0df Added tag jdk8-b89 for changeset fe4150590ee5 ! .hgtags Changeset: 8f7ffb296385 Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/8f7ffb296385 Added tag jdk8-b90 for changeset c8286839d0df ! .hgtags From lana.steuck at oracle.com Wed May 22 12:10:46 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:10:46 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20130522191052.83F2548C4A@hg.openjdk.java.net> Changeset: 67ca019e3713 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/67ca019e3713 Added tag jdk8-b89 for changeset 45ce27fbe272 ! .hgtags Changeset: 4ce88eec5078 Author: katleman Date: 2013-05-16 12:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4ce88eec5078 Added tag jdk8-b90 for changeset 67ca019e3713 ! .hgtags Changeset: 6b9f41203800 Author: lana Date: 2013-05-17 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6b9f41203800 Merge - src/jdk/nashorn/internal/ir/LineNumberNode.java - src/jdk/nashorn/internal/ir/Location.java - src/jdk/nashorn/internal/runtime/SpillProperty.java - test/script/trusted/logcoverage.js Changeset: e955e64fd15d Author: lana Date: 2013-05-22 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e955e64fd15d Merge From lana.steuck at oracle.com Wed May 22 12:10:39 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:10:39 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20130522191052.0425148C49@hg.openjdk.java.net> Changeset: 3e5b9ea5ac35 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/3e5b9ea5ac35 Added tag jdk8-b89 for changeset 88838e08e4ef ! .hgtags Changeset: 0bb1a9fa56b0 Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/0bb1a9fa56b0 Added tag jdk8-b90 for changeset 3e5b9ea5ac35 ! .hgtags From lana.steuck at oracle.com Wed May 22 12:10:36 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:10:36 +0000 Subject: hg: jdk8/tl: 3 new changesets Message-ID: <20130522191037.28CF948C47@hg.openjdk.java.net> Changeset: 69b773a221b9 Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/69b773a221b9 Added tag jdk8-b89 for changeset 892a0196d10c ! .hgtags Changeset: 83b519cafa68 Author: katleman Date: 2013-05-16 12:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/83b519cafa68 Added tag jdk8-b90 for changeset 69b773a221b9 ! .hgtags Changeset: 40bba0507f76 Author: lana Date: 2013-05-17 10:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/40bba0507f76 Merge From lana.steuck at oracle.com Wed May 22 12:10:43 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:10:43 +0000 Subject: hg: jdk8/tl/jaxp: 4 new changesets Message-ID: <20130522191101.4839A48C4B@hg.openjdk.java.net> Changeset: 668acc0e1034 Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/668acc0e1034 Added tag jdk8-b89 for changeset 893d2ba8bbea ! .hgtags Changeset: f39d61028d2f Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f39d61028d2f Added tag jdk8-b90 for changeset 668acc0e1034 ! .hgtags Changeset: e3065fb07877 Author: lana Date: 2013-05-17 10:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e3065fb07877 Merge Changeset: 0765806dcc58 Author: lana Date: 2013-05-22 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0765806dcc58 Merge From lana.steuck at oracle.com Wed May 22 12:11:05 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:11:05 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20130522191126.05AF248C4C@hg.openjdk.java.net> Changeset: e19283cd30a4 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e19283cd30a4 Added tag jdk8-b89 for changeset ec434cfd2752 ! .hgtags Changeset: 9717b9523d46 Author: katleman Date: 2013-05-16 12:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9717b9523d46 Added tag jdk8-b90 for changeset e19283cd30a4 ! .hgtags Changeset: 997c0fae2b12 Author: lana Date: 2013-05-17 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/997c0fae2b12 Merge - src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java - src/share/classes/javax/tools/annotation/GenerateNativeHeader.java - test/tools/javac/nativeHeaders/javahComparison/TestClass2.java - test/tools/javac/nativeHeaders/javahComparison/TestClass3.java Changeset: 31344e8e3343 Author: lana Date: 2013-05-22 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/31344e8e3343 Merge From lana.steuck at oracle.com Wed May 22 12:11:40 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:11:40 +0000 Subject: hg: jdk8/tl/hotspot: 86 new changesets Message-ID: <20130522191500.B5E4848C4D@hg.openjdk.java.net> Changeset: 7d56b68a9672 Author: katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7d56b68a9672 Added tag jdk8-b89 for changeset 9c1fe0b419b4 ! .hgtags Changeset: 625ddb0052e1 Author: amurillo Date: 2013-05-03 08:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/625ddb0052e1 8013800: new hotspot build - hs25-b32 Reviewed-by: jcoomes ! make/hotspot_version Changeset: c456f4510385 Author: sla Date: 2013-05-03 12:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c456f4510385 8008453: JvmtiClassFileReconstituter does not recognize default methods Reviewed-by: acorn, sspitsyn ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp Changeset: 0380df7c3cd0 Author: sla Date: 2013-05-03 12:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0380df7c3cd0 8013785: Respect EXTRA_CFLAGS on windows Reviewed-by: mgronlun, rbackman, kvn ! make/windows/makefiles/compile.make ! make/windows/makefiles/defs.make Changeset: 31a4e55f8c9d Author: fparain Date: 2013-05-03 05:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/31a4e55f8c9d 8004095: Add support for JMX interface to Diagnostic Framework and Commands Reviewed-by: acorn, sla ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/serviceThread.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp ! src/share/vm/services/diagnosticFramework.cpp ! src/share/vm/services/diagnosticFramework.hpp ! src/share/vm/services/jmm.h ! src/share/vm/services/management.cpp ! src/share/vm/services/management.hpp ! src/share/vm/services/nmtDCmd.cpp ! src/share/vm/services/nmtDCmd.hpp Changeset: 39fba0d6d9ad Author: fparain Date: 2013-05-03 05:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/39fba0d6d9ad Merge Changeset: bf089b838c9e Author: ccheung Date: 2013-05-02 16:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bf089b838c9e 8012641: Perf_CreateLong creates perf counter of incorrect type Reviewed-by: mchung, hseigel, coleenp ! src/share/vm/prims/perf.cpp Changeset: a55b7b8c34af Author: zgu Date: 2013-05-03 13:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a55b7b8c34af Merge Changeset: 9c8e2f44228d Author: dcubed Date: 2013-05-03 15:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9c8e2f44228d Merge Changeset: 800078be49d2 Author: hseigel Date: 2013-05-06 09:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/800078be49d2 8013648: Guarantee(VerifyBeforeGC || VerifyDuringGC || VerifyBeforeExit || VerifyAfterGC) failed: too expensive Summary: Fix code to call correct version of function find_class(). Reviewed-by: coleenp, rdurbin, dcubed ! src/share/vm/classfile/systemDictionary.cpp Changeset: c18152e0554e Author: zgu Date: 2013-05-06 11:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c18152e0554e 8013120: NMT: Kitchensink crashes with assert(next_region == NULL || !next_region->is_committed_region()) failed: Sanity check Summary: Fixed NMT to deal with releasing virtual memory region when there are still committed regions within it Reviewed-by: acorn, coleenp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/services/memSnapshot.cpp + test/runtime/NMT/ReleaseCommittedMemory.java Changeset: da4d87770781 Author: zgu Date: 2013-05-06 08:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/da4d87770781 Merge Changeset: d9b08d62b95e Author: acorn Date: 2013-05-02 10:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d9b08d62b95e 8010783: assert(s->refcount() != 0) failed: for create_overpasses Reviewed-by: kvn, dcubed ! src/share/vm/classfile/bytecodeAssembler.cpp Changeset: b7f3bf2ba33b Author: acorn Date: 2013-05-06 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b7f3bf2ba33b Merge - agent/doc/c2replay.html Changeset: f916d5986c86 Author: acorn Date: 2013-05-06 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f916d5986c86 Merge Changeset: 187154b7a226 Author: sla Date: 2013-05-06 19:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/187154b7a226 8009615: JvmtiClassFileReconstituter does not create BootstrapMethod attributes Reviewed-by: coleenp, sspitsyn ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: 3ecc6b9940de Author: sla Date: 2013-05-07 01:25 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3ecc6b9940de Merge Changeset: b5fef8013a95 Author: sla Date: 2013-05-07 14:04 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b5fef8013a95 8014044: Spelling error in JDK-8009615: boostrapmethod Reviewed-by: sspitsyn, coleenp ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: f6a055fcf47d Author: sla Date: 2013-05-07 14:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f6a055fcf47d 8005038: remove crufty '_g' support from SA Reviewed-by: coleenp, mgronlun, rbackman ! agent/src/os/bsd/ps_core.c ! agent/src/os/linux/ps_core.c ! agent/src/os/solaris/proc/saproc.cpp ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/LinuxVtblAccess.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java Changeset: 33bcd9ead1d5 Author: ctornqvi Date: 2013-05-07 21:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/33bcd9ead1d5 8009577: Test test/closed/runtime/classunload broken Summary: Fixed tests to use new way of utilizing the WB API, fixed issue with where custom classloader got the classes from Reviewed-by: collins, mgerdin, zgu + test/runtime/ClassUnload/KeepAliveClass.java + test/runtime/ClassUnload/KeepAliveClassLoader.java + test/runtime/ClassUnload/KeepAliveObject.java + test/runtime/ClassUnload/KeepAliveSoftReference.java + test/runtime/ClassUnload/UnloadTest.java + test/runtime/ClassUnload/classes/test/Empty.java + test/runtime/testlibrary/ClassUnloadCommon.java Changeset: 58bb870a0cbd Author: emc Date: 2013-05-07 13:45 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/58bb870a0cbd 8009729: Refix hotspot jni_.h JNIEXPORT and JNIIMPORT definitions to match jdk version Summary: Update JNIEXPORT and JNIIMPORT to work with other compilers that don't necessarily have the __attribute__ type qualifier Reviewed-by: dholmes, dcubed, coleenp ! src/cpu/sparc/vm/jni_sparc.h ! src/cpu/x86/vm/jni_x86.h ! src/cpu/zero/vm/jni_zero.h Changeset: 7243490a6847 Author: coleenp Date: 2013-05-07 14:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7243490a6847 Merge Changeset: e60b3fce2b02 Author: jiangli Date: 2013-05-06 19:57 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e60b3fce2b02 8013067: Zero builds are broken after 8010862. Summary: Fixed broken Zero build. Reviewed-by: twisti, coleenp, kvn ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/oops/method.hpp Changeset: 27d2d456cd96 Author: jiangli Date: 2013-05-06 20:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/27d2d456cd96 Merge Changeset: 6b388e7d4905 Author: bpittore Date: 2013-05-07 10:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6b388e7d4905 8013633: Cleanup platform ifdefs in unsafe.cpp Summary: Replace ifdefs with SUPPORTS_NATIVE_CX8 set in platform include file Reviewed-by: dholmes, dlong ! src/cpu/sparc/vm/globalDefinitions_sparc.hpp ! src/cpu/x86/vm/globalDefinitions_x86.hpp ! src/share/vm/prims/unsafe.cpp Changeset: a258a8351528 Author: vladidan Date: 2013-05-07 10:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a258a8351528 Merge - agent/doc/c2replay.html Changeset: d3c98423c146 Author: jiangli Date: 2013-05-09 16:27 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d3c98423c146 Merge Changeset: 1d0fba8a2a6d Author: brutisso Date: 2013-05-02 22:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1d0fba8a2a6d 8013574: PrintMalloc conflicts with the command line parsing Summary: Make sure that _num_jvm_args is not updated until the new entry to _jvm_args_array has been added Reviewed-by: johnc, tamao, tschatzl ! src/share/vm/runtime/arguments.cpp Changeset: f14063dcd52a Author: brutisso Date: 2013-05-06 09:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f14063dcd52a 8013791: G1: G1CollectorPolicy::initialize_flags() may set min_alignment > max_alignment Summary: Make sure max alignemnt is at least as large as min alignment Reviewed-by: johnc, jmasa, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.cpp + test/gc/g1/TestRegionAlignment.java Changeset: 30860066ae8f Author: jwilhelm Date: 2013-05-06 13:03 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/30860066ae8f Merge ! src/share/vm/runtime/arguments.cpp Changeset: d17700c82d7d Author: tschatzl Date: 2013-05-06 17:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d17700c82d7d 8006088: Incompatible heap size flags accepted by VM Summary: Make processing of minimum, initial and maximum heap size more intiutive by removing previous limitations on allowed values, and make error reporting consistent. Further, fix errors in ergonomic heap sizing. Reviewed-by: johnc, jwilhelm, tamao ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: b0d20fa374b4 Author: brutisso Date: 2013-05-06 21:30 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b0d20fa374b4 8013872: G1: HeapRegionSeq::shrink_by() has invalid assert Summary: Refactored shrink_by() to only use region counts and not byte sizes Reviewed-by: johnc, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp + test/gc/g1/TestShrinkToOneRegion.java Changeset: a9d568b7df60 Author: jmasa Date: 2013-05-08 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a9d568b7df60 8013032: CMS: assert(used() == used_after_gc && used_after_gc <= capacity()) failed: used: 0 used_after_gc: 292080 capacity: 1431699456 Reviewed-by: tschatzl, mgerdin, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp + test/gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java Changeset: 06ab37f08701 Author: jmasa Date: 2013-05-08 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/06ab37f08701 8013184: CMS: Call reset_after_compaction() only if a compaction has been done Reviewed-by: mgerdin, johnc, tschatzl ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp + test/gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java Changeset: 923ac8d1df95 Author: jwilhelm Date: 2013-05-09 12:23 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/923ac8d1df95 Merge Changeset: 194f52aa2f23 Author: johnc Date: 2013-05-09 11:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/194f52aa2f23 7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap Summary: Refactor G1's hot card cache and card counts table into their own files. Simplify the card counts table, including removing the encoding of the card index in each entry. The card counts table now has a 1:1 correspondence with the cards spanned by heap. Space for the card counts table is reserved from virtual memory (rather than C heap) during JVM startup and is committed/expanded when the heap is expanded. Changes were also reviewed-by Vitaly Davidovich. Reviewed-by: tschatzl, jmasa ! make/excludeSrc.make ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp + src/share/vm/gc_implementation/g1/g1CardCounts.cpp + src/share/vm/gc_implementation/g1/g1CardCounts.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp + src/share/vm/gc_implementation/g1/g1HotCardCache.cpp + src/share/vm/gc_implementation/g1/g1HotCardCache.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 73652d89e7c4 Author: stefank Date: 2013-05-10 09:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/73652d89e7c4 Merge Changeset: 69494caf5790 Author: amurillo Date: 2013-05-10 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/69494caf5790 Merge Changeset: 1ae0472ff3a0 Author: amurillo Date: 2013-05-10 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1ae0472ff3a0 Added tag hs25-b32 for changeset 69494caf5790 ! .hgtags Changeset: 1cdbd42c3e49 Author: katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1cdbd42c3e49 Added tag jdk8-b90 for changeset 1ae0472ff3a0 ! .hgtags Changeset: 6114c49b31b5 Author: amurillo Date: 2013-05-10 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6114c49b31b5 8014279: new hotspot build - hs25-b33 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 712a1e9c91f3 Author: coleenp Date: 2013-05-07 09:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/712a1e9c91f3 8013063: nsk/jvmti/RetransformClasses/retransform001 failed debug version on os::free Summary: Clear out class_file_bytes so they aren't deallocated twice Reviewed-by: dcubed, sspitsyn ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 4674e409a9e6 Author: coleenp Date: 2013-05-07 18:51 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4674e409a9e6 8014024: NPG: keep compiled ic methods from being deallocated in redefine classes Summary: Walk the compiledIC relocation records to keep Method* from being deallocated. Reviewed-by: dlong, kvn ! src/share/vm/code/nmethod.cpp Changeset: a1cc1d1e7ce5 Author: coleenp Date: 2013-05-07 16:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a1cc1d1e7ce5 Merge Changeset: 28ae1d38d296 Author: coleenp Date: 2013-05-07 18:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/28ae1d38d296 Merge Changeset: 64340da5b68c Author: hseigel Date: 2013-05-08 08:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/64340da5b68c 8007018: RFE: -XX:+UseLargePages does not work with CDS Summary: Remove command line restriction. It should just work. Reviewed-by: ctornqvi, coleenp, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: cbfe859bd244 Author: sla Date: 2013-05-08 15:37 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cbfe859bd244 8013591: compiler/ciReplay/TestSA.sh fails in nightly Reviewed-by: coleenp, rbackman, dholmes ! agent/src/share/classes/sun/jvm/hotspot/ci/ciMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java Changeset: 0dc028fd5101 Author: sla Date: 2013-05-08 10:14 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0dc028fd5101 Merge Changeset: 39ead0411f07 Author: bharadwaj Date: 2013-05-08 14:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/39ead0411f07 8013875: Incorrect vtable index being set during methodHandle creation for static Summary: Set vtable index as appropriate for static interface methods and for interface methods invoked via invokespecial. To be improved in a later enhancement to CallInfo. Reviewed-by: jrose, twisti ! src/share/vm/prims/methodHandles.cpp Changeset: 711016f146fd Author: dholmes Date: 2013-05-08 19:28 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/711016f146fd 8006997: ContendedPaddingWidth should be range-checked Summary: Constrain between zero and 8K Reviewed-by: dholmes, rbackman Contributed-by: Aleksey Shipilev ! src/share/vm/runtime/arguments.cpp Changeset: 9b77ca4ce35e Author: dholmes Date: 2013-05-08 19:38 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9b77ca4ce35e Merge ! src/share/vm/runtime/arguments.cpp Changeset: c272092594bd Author: dholmes Date: 2013-05-08 21:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c272092594bd Merge Changeset: 0b7f78069732 Author: rbackman Date: 2013-05-08 11:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0b7f78069732 8008255: jvmtiExport.cpp::post_to_env() does not check malloc() return Reviewed-by: coleenp, dholmes, sla ! src/share/vm/prims/jvmtiExport.cpp Changeset: 735c995bf1a1 Author: rbackman Date: 2013-05-13 07:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/735c995bf1a1 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 92ef81e2f571 Author: minqi Date: 2013-05-10 08:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/92ef81e2f571 8003557: NPG: Klass* const k should be const Klass* k. Summary: With NPG, const KlassOop klass which is in fact a definition converted to Klass* const, which is not the original intention. The right usage is converting them to const Klass*. Reviewed-by: coleenp, kvn Contributed-by: yumin.qi at oracle.com ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/verifier.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: 1fcfc045b229 Author: minqi Date: 2013-05-10 19:30 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1fcfc045b229 Merge Changeset: 8b40495b9381 Author: minqi Date: 2013-05-13 18:08 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8b40495b9381 Merge ! src/share/vm/oops/method.hpp Changeset: 43083e670adf Author: coleenp Date: 2013-05-13 15:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/43083e670adf 8005056: NPG: Crash after redefining java.lang.Object Summary: Need to walk array class vtables replacing old methods too if j.l.o redefined Reviewed-by: sspitsyn, dcubed, ctornqvi ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/dictionary.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/oops/klass.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp + test/runtime/RedefineObject/Agent.java + test/runtime/RedefineObject/TestRedefineObject.java ! test/testlibrary/ClassFileInstaller.java Changeset: a9270d9ecb13 Author: shade Date: 2013-05-14 11:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a9270d9ecb13 8014448: Purge PrintCompactFieldsSavings Summary: Remove obsolete debugging code. Reviewed-by: dholmes, kvn Contributed-by: Aleksey Shipilev ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/runtime/globals.hpp Changeset: f944ba972151 Author: hseigel Date: 2013-05-14 09:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f944ba972151 8014138: Add VM option to facilitate the writing of CDS tests Summary: Added the -XX:SharedArchiveFile option. Reviewed-by: coleenp, ccheung, acorn, dcubed, zgu ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp + test/runtime/SharedArchiveFile/SharedArchiveFile.java Changeset: f9be75d21404 Author: minqi Date: 2013-05-14 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f9be75d21404 8012902: remove use of global operator new - take 2 Summary: The fix of 8010992, disable use of global operator new and new[] which caused failure on some tests. This takes two of the bugs also add ALLOW_OPERATOR_NEW_USAGE to prevent crash for third party code calling operator new of jvm on certain platforms. Reviewed-by: coleenp, dholmes, zgu Contributed-by: yumin.qi at oracle.com ! make/bsd/makefiles/fastdebug.make ! make/bsd/makefiles/vm.make ! src/os/windows/vm/os_windows.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/classfile/altHashing.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/cardTableRS.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/memRegion.cpp ! src/share/vm/memory/memRegion.hpp ! src/share/vm/opto/idealGraphPrinter.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/objectMonitor.hpp ! src/share/vm/runtime/reflectionUtils.hpp ! src/share/vm/runtime/unhandledOops.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/events.hpp ! src/share/vm/utilities/quickSort.cpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp Changeset: 513a5298c1dd Author: minqi Date: 2013-05-14 17:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/513a5298c1dd Merge Changeset: d15464bfd4d0 Author: roland Date: 2013-05-03 09:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d15464bfd4d0 8012037: Test8009761.java "Failed: init recursive calls: 7224. After deopt 58824" Summary: test shouldn't be run with a modified CompileThreshold Reviewed-by: kvn ! test/compiler/8009761/Test8009761.java Changeset: e76dd894b984 Author: roland Date: 2013-04-24 14:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e76dd894b984 8012292: optimized build with GCC broken Summary: Some #ifndef PRODUCT should be #ifdef ASSERT Reviewed-by: kvn, twisti Contributed-by: gdub ! make/jprt.properties ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/utilities/quickSort.cpp Changeset: d73c88e524ff Author: kvn Date: 2013-05-03 15:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d73c88e524ff Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: f0bc60565ba8 Author: twisti Date: 2013-05-06 13:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f0bc60565ba8 7196277: JSR 292: Two jck/runtime tests crash on java.lang.invoke.MethodHandle.invokeExact Reviewed-by: jrose, kvn ! src/share/vm/oops/method.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: aabf54ccedb1 Author: twisti Date: 2013-05-06 19:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aabf54ccedb1 8008772: remove gamma launcher Reviewed-by: kvn, neliasso, ctornqvi ! make/Makefile ! make/bsd/makefiles/buildtree.make - make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make + make/hotspot.script ! make/linux/makefiles/buildtree.make - make/linux/makefiles/launcher.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/buildtree.make - make/solaris/makefiles/launcher.make ! make/solaris/makefiles/vm.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/fastdebug.make - make/windows/makefiles/launcher.make ! make/windows/makefiles/product.make ! make/windows/makefiles/projectcreator.make ! make/windows/projectfiles/common/Makefile - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h ! src/share/tools/ProjectCreator/BuildConfig.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC10.java - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h Changeset: 6f3fd5150b67 Author: kvn Date: 2013-05-08 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6f3fd5150b67 6934604: enable parts of EliminateAutoBox by default Summary: Resurrected autobox elimination code and enabled part of it by default. Reviewed-by: roland, twisti ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/multnode.cpp ! src/share/vm/opto/multnode.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/phase.cpp ! src/share/vm/opto/phase.hpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/vmStructs.cpp + test/compiler/6934604/TestByteBoxing.java + test/compiler/6934604/TestDoubleBoxing.java + test/compiler/6934604/TestFloatBoxing.java + test/compiler/6934604/TestIntBoxing.java + test/compiler/6934604/TestLongBoxing.java + test/compiler/6934604/TestShortBoxing.java Changeset: 70120f47d403 Author: kvn Date: 2013-05-09 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/70120f47d403 8014189: JVM crash with SEGV in ConnectionGraph::record_for_escape_analysis() Summary: Add NULL checks and asserts for Type::make_ptr() returned value. Reviewed-by: twisti ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/subnode.cpp Changeset: 8bcfd9ce2c6b Author: twisti Date: 2013-05-13 12:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8bcfd9ce2c6b Merge - make/bsd/makefiles/launcher.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 1da5d70655e9 Author: kvn Date: 2013-05-13 14:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1da5d70655e9 8014286: failed java/lang/Math/DivModTests.java after 6934604 changes Summary: Corrected escape state for the result of boxing method. Added force inlining executed boxing methods. Reviewed-by: twisti ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/escape.cpp Changeset: cd6f6fccd287 Author: iignatyev Date: 2013-05-15 22:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cd6f6fccd287 8014068: TEST_BUG: compiler/ciReplay/TestSA.sh fails on Windows: core wasn't generated Reviewed-by: kvn ! test/compiler/ciReplay/TestSA.sh ! test/compiler/ciReplay/common.sh Changeset: e484fe2abebd Author: twisti Date: 2013-05-16 13:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e484fe2abebd Merge - make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/quickSort.cpp Changeset: 7a95933197d0 Author: tschatzl Date: 2013-05-13 09:45 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7a95933197d0 8014058: Regression tests for 8006088 Summary: The patch for 8006088 misses regression tests after a merge error, this CR provides them. Reviewed-by: jwilhelm, tamao, jmasa ! src/share/vm/memory/collectorPolicy.cpp + test/gc/arguments/TestCMSHeapSizeFlags.java + test/gc/arguments/TestG1HeapSizeFlags.java + test/gc/arguments/TestMaxHeapSizeTools.java + test/gc/arguments/TestMinInitialErgonomics.java + test/gc/arguments/TestParallelHeapSizeFlags.java + test/gc/arguments/TestSerialHeapSizeFlags.java Changeset: 4868caa99ecf Author: brutisso Date: 2013-05-13 14:09 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4868caa99ecf 8014339: Improve assert and remove some dead code from parMarkBitMap.hpp/cpp Reviewed-by: stefank, tschatzl ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp Changeset: 0a2986f36965 Author: tschatzl Date: 2013-05-14 17:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0a2986f36965 8014489: tests/gc/arguments/Test(Serial|CMS|Parallel|G1)HeapSizeFlags jtreg tests invoke wrong class Summary: Some jtreg tests reference unknown classes in the @run and @build lines. This change fixes them. Reviewed-by: stefank, ehelin ! test/gc/arguments/TestCMSHeapSizeFlags.java ! test/gc/arguments/TestG1HeapSizeFlags.java ! test/gc/arguments/TestParallelHeapSizeFlags.java ! test/gc/arguments/TestSerialHeapSizeFlags.java Changeset: 12f651e29f6b Author: tschatzl Date: 2013-05-15 11:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/12f651e29f6b 6843347: Boundary values in some public GC options cause crashes Summary: Setting some public integer options to specific values causes crashes or undefined GC behavior. This patchset adds the necessary argument checking for these options. Reviewed-by: jmasa, brutisso ! src/cpu/sparc/vm/globals_sparc.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/zero/vm/globals_zero.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: eba99d16dc6f Author: tamao Date: 2013-05-15 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eba99d16dc6f 8007763: Refactoring: split up compute_generation_free_space() into two functions for class PSAdaptiveSizePolicy Summary: split up compute_generation_free_space() into two functions: compute_eden_space_size() + compute_old_gen_free_space(), each of which (if needed) can be reused without executing an overhead of the other. Reviewed-by: jmasa, tschatzl Contributed-by: tamao ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp Changeset: bed55d125e37 Author: johnc Date: 2013-05-15 22:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bed55d125e37 8014408: G1: crashes with assert assert(prev_committed_card_num == _committed_max_card_num) failed Summary: Mismatch in the card number calculation between next and previous committed sizes of the card counts table. Reviewed-by: jmasa, tschatzl ! src/share/vm/gc_implementation/g1/g1CardCounts.cpp ! src/share/vm/gc_implementation/g1/g1CardCounts.hpp Changeset: 05a17f270c7e Author: tschatzl Date: 2013-05-16 13:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/05a17f270c7e 8014240: G1: Add remembered set size information to output of G1PrintRegionLivenessInfo Summary: Improve the output of G1PrintRegionLivenessInfo by adding a per-region remembered set size information column Reviewed-by: jwilhelm, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp + test/gc/g1/TestPrintRegionRememberedSetInfo.java Changeset: 48391ab0687e Author: johnc Date: 2013-05-16 09:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/48391ab0687e 8010738: G1: Output for full GCs with +PrintGCDetails should contain perm gen size/meta data change info Summary: Include metaspace information (used, allocated, reserved) in the PrintGCDetails output for full GCs. Reviewed-by: poonam, jmasa, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp + test/gc/g1/TestPrintGCDetails.java Changeset: acac2b03a07f Author: tschatzl Date: 2013-05-16 23:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/acac2b03a07f 8014765: VM exits if MaxTenuringThreshold is set below the default InitialTenuringThreshold, and InitialTenuringThreshold is not set Summary: The VM exits when the condition in the subject line applies. The fix sets InitialTenuringThreshold to MaxTenuringThreshold if it is larger than MaxTenuringThreshold and InitialTenuringThreshold has not been set (is default). Reviewed-by: jwilhelm, jmasa, brutisso, johnc ! src/share/vm/runtime/arguments.cpp + test/gc/arguments/TestInitialTenuringThreshold.java Changeset: 2958af1d8c5a Author: jwilhelm Date: 2013-05-17 06:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2958af1d8c5a Merge ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 2f9ac66165e6 Author: jwilhelm Date: 2013-05-17 08:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2f9ac66165e6 Merge - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/runtime/arguments.cpp Changeset: b19517cecc2e Author: amurillo Date: 2013-05-17 08:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b19517cecc2e Merge - make/bsd/makefiles/launcher.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp Changeset: 7cbdf0e3725c Author: amurillo Date: 2013-05-17 08:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7cbdf0e3725c Added tag hs25-b33 for changeset b19517cecc2e ! .hgtags From lana.steuck at oracle.com Wed May 22 12:12:58 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 22 May 2013 19:12:58 +0000 Subject: hg: jdk8/tl/jdk: 23 new changesets Message-ID: <20130522191804.C371B48C4E@hg.openjdk.java.net> Changeset: b8e7d145abc2 Author: katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b8e7d145abc2 Added tag jdk8-b89 for changeset 845025546e35 ! .hgtags Changeset: 1f1699686504 Author: katleman Date: 2013-05-09 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f1699686504 8014289: JDK8 b89 source with GPL header errors Reviewed-by: mchung, mduigou, tbell, dsamersoff ! src/share/classes/java/util/Base64.java ! src/share/classes/java/util/StringJoiner.java ! test/java/lang/CharSequence/DefaultTest.java ! test/java/util/StringJoiner/StringJoinerTest.java Changeset: c63eda8f6300 Author: katleman Date: 2013-05-14 12:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c63eda8f6300 Merge Changeset: 08c28cdacd7b Author: katleman Date: 2013-05-16 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/08c28cdacd7b Added tag jdk8-b90 for changeset c63eda8f6300 ! .hgtags Changeset: 4dd6f7bb8bbd Author: simonis Date: 2013-05-06 12:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4dd6f7bb8bbd 7191872: Xrender: No text displayed using 64 bit JDK on solaris11-sparc Reviewed-by: prr, ceisserer ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/GlyphList.java ! src/solaris/classes/sun/font/XRGlyphCacheEntry.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 23f7ff502a89 Author: jgodinez Date: 2013-05-07 09:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23f7ff502a89 8011069: Printing: NullPointerException since jdk8 b82 showing native Page Setup Dialog. Reviewed-by: bae, prr ! src/macosx/classes/sun/lwawt/macosx/CPrinterJob.java ! src/share/classes/sun/print/RasterPrinterJob.java Changeset: 8a995d335d59 Author: lana Date: 2013-05-09 19:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a995d335d59 Merge - src/share/classes/java/beans/ReflectionUtils.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: 103f492d8ce7 Author: vadim Date: 2013-05-17 17:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/103f492d8ce7 4892259: GIF ImageReader does not call passComplete in IIOReadUpdateListener Reviewed-by: prr, bae ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java + test/javax/imageio/plugins/gif/GIFPassListenerTest.java Changeset: 4ee85e865a83 Author: vadim Date: 2013-05-17 14:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ee85e865a83 8000936: Enable Java2D D3D pipeline on newer Intel chipsets : Intel HD and later Reviewed-by: prr, bae ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h Changeset: 51f5e544c88b Author: lana Date: 2013-05-17 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51f5e544c88b Merge Changeset: 90b67c9a7eb2 Author: serb Date: 2013-05-06 16:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90b67c9a7eb2 7161575: [macosx] On MacOSX port java.awt.Toolkit.is/setDynamicLayout() are not consistent Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWToolkit.java Changeset: 7982299cd11c Author: serb Date: 2013-05-08 15:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7982299cd11c 8013841: [macosx] Animations not disabled for CALayers used via JAWT Reviewed-by: anthony, alexsch ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m Changeset: 5fe0a4da863d Author: lana Date: 2013-05-09 18:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5fe0a4da863d Merge - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: a466a4192fea Author: pchelko Date: 2013-05-14 16:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a466a4192fea 8002045: Auto failed and threw exception:java.lang.UnsatisfiedLinkError: Reviewed-by: serb, anthony ! make/sun/awt/mapfile-vers ! make/sun/awt/mapfile-vers-bsd ! make/sun/awt/mapfile-vers-linux ! makefiles/mapfiles/libawt/mapfile-vers ! makefiles/mapfiles/libawt/mapfile-vers-linux Changeset: b1a7cc79f13d Author: serb Date: 2013-05-14 17:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1a7cc79f13d 8014423: [macosx] The scrollbar's block increment performs incorrectly Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWScrollBarPeer.java Changeset: 722ee3129ce0 Author: ant Date: 2013-05-15 16:49 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/722ee3129ce0 8014227: JLightweightFrame needs another synchronization policy Reviewed-by: art ! src/share/classes/sun/swing/JLightweightFrame.java Changeset: 7a8a8e31a126 Author: pchelko Date: 2013-05-17 11:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a8a8e31a126 7079254: Toolkit eventListener leaks memory Reviewed-by: serb, art ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java + test/java/awt/LightweightDispatcher/LWDispatcherMemoryLeakTest.java Changeset: e944b78812a8 Author: kshefov Date: 2013-05-17 14:08 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e944b78812a8 8014721: TEST_BUG: java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with java.lang.UnsupportedOperationException Reviewed-by: anthony, serb ! test/java/awt/TrayIcon/DragEventSource/DragEventSource.java Changeset: 281add053efe Author: kshefov Date: 2013-05-17 14:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/281add053efe 8013426: TEST_BUG: java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java fails with "RuntimeException: The data should be available" on Linux Reviewed-by: anthony, serb ! test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java Changeset: 49871f1581b8 Author: lana Date: 2013-05-17 10:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49871f1581b8 Merge Changeset: 30101f69e66f Author: lana Date: 2013-05-17 10:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30101f69e66f Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java - src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/util/Base64.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider - test/java/lang/Thread/StackTraces.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java - test/java/util/logging/bundlesearch/LoadItUp.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: bcfab7056195 Author: lana Date: 2013-05-22 09:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcfab7056195 Merge Changeset: 760d4187597a Author: lana Date: 2013-05-22 12:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/760d4187597a Merge From joe.darcy at oracle.com Wed May 22 13:34:18 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 22 May 2013 20:34:18 +0000 Subject: hg: jdk8/tl/langtools: 8010680: Clarify "present" and annotation ordering in javax.lang.model Message-ID: <20130522203421.0DEDA48C59@hg.openjdk.java.net> Changeset: 3bd22f99d408 Author: darcy Date: 2013-05-22 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3bd22f99d408 8010680: Clarify "present" and annotation ordering in javax.lang.model Reviewed-by: abuckley, jjg ! src/share/classes/javax/lang/model/AnnotatedConstruct.java ! src/share/classes/javax/lang/model/util/Elements.java From valerie.peng at oracle.com Wed May 22 16:18:33 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Wed, 22 May 2013 16:18:33 -0700 Subject: RFR JDK-8014307 In-Reply-To: <519D1464.2080800@oracle.com> References: <519D1464.2080800@oracle.com> Message-ID: <519D5249.1050605@oracle.com> The resetGSSBuffer(..) call on line 829 should be removed as the inToken structure isn't even initialized yet (initGSSBuffer call is on line 833). Rest looks fine. Thanks, Valerie On 05/22/13 11:54, John Zavgren wrote: > Greetings: > I just updated: > /jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c > /with the recommended changes. > > http://cr.openjdk.java.net/~jzavgren/8014307/webrev.02/ > > Thanks! > John Zavgren > ---------------------------------------------------------------------- > > > John, > > 1) 332-333 can be replaced w/ a deleteGSSOID(nameType) call. Also, with > this deleteGSSOID(nameType) call, we should also add the following line: > resetGSSBuffer(env, jnameVal,&nameVal); > > 2) I think the ExceptionCheck block on line 932 should also be enhanced > w/ resetGSSBuffer(env, jinToken,&inToken) call as well as free(cb) > call. Same goes for another ExceptionCheck blocks on line 984, 998, 1024. > > Thanks, > Valerie > On 05/14/13 19:19, John Zavgren wrote: > >/ Greetings: Please review the following change to the file: > />/ jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c that fixes > />/ two memory leaks. > />/ http://cr.openjdk.java.net/~jzavgren/8014307/webrev.01/ Thanks! John > />/ Zavgren/ > -- > John Zavgren > john.zavgren at oracle.com > 603-821-0904 > US-Burlington-MA -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130522/b3728b5e/attachment.html From naoto.sato at oracle.com Wed May 22 16:43:48 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 22 May 2013 23:43:48 +0000 Subject: hg: jdk8/tl/jdk: 7056126: DateFormatSymbols documentation has incorrect description about DateFormat; ... Message-ID: <20130522234408.E489648C66@hg.openjdk.java.net> Changeset: 50fde3eeb48c Author: naoto Date: 2013-05-22 16:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50fde3eeb48c 7056126: DateFormatSymbols documentation has incorrect description about DateFormat 7083668: Sample code in ListResourceBundle is still not correct Reviewed-by: okutsu ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/util/ListResourceBundle.java From david.holmes at oracle.com Wed May 22 17:22:14 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Thu, 23 May 2013 00:22:14 +0000 Subject: hg: jdk8/tl/jdk: 8014814: (str) StringBuffer "null" is not appended Message-ID: <20130523002227.DFDD648C67@hg.openjdk.java.net> Changeset: a1a8e71e130a Author: dholmes Date: 2013-05-22 20:21 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a1a8e71e130a 8014814: (str) StringBuffer "null" is not appended Reviewed-by: alanb ! src/share/classes/java/lang/StringBuffer.java ! test/java/lang/StringBuffer/ToStringCache.java From joe.darcy at oracle.com Wed May 22 20:04:11 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 23 May 2013 03:04:11 +0000 Subject: hg: jdk8/tl/jdk: 8014836: Have GenericDeclaration extend AnnotatedElement Message-ID: <20130523030435.BAA4248C7C@hg.openjdk.java.net> Changeset: e764bb01567e Author: darcy Date: 2013-05-22 20:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e764bb01567e 8014836: Have GenericDeclaration extend AnnotatedElement Reviewed-by: abuckley, jfranck ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/GenericDeclaration.java From sean.coffey at oracle.com Thu May 23 01:25:49 2013 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 23 May 2013 09:25:49 +0100 Subject: [7u40] Resolve ambiguity in OCSPChecker & CrlRevocationChecker In-Reply-To: <2040348525.6176636.1369247132435.JavaMail.root@redhat.com> References: <2040348525.6176636.1369247132435.JavaMail.root@redhat.com> Message-ID: <519DD28D.4040300@oracle.com> Andrew, Bug report just created : JDK-8015275 : Resolve ambiguity in OCSPChecker & CrlRevocationChecker Looks like both classes being modified for jdk8 don't exist any longer. Regards, Sean. On 22/05/2013 19:25, Andrew Hughes wrote: > Webrev: http://cr.openjdk.java.net/~andrew/7u/webrev/ > > There's an ambiguity that applies when building OpenJDK 7 with OpenJDK 6 > (and hence I haven't posted this for 8 as it can't be built with 6). > > OpenJDK 6 has a class sun.security.provider.certpath.CertificateRevokedException. > OpenJDK 7 has a class java.security.cert.CertificateRevokedException. > > Two classes in sun.security.provider.certpath in OpenJDK 7 import > java.security.cert.CertificateRevokedException indirectly via > java.security.cert.*. This appears to cause a compilation failure > in some cases if the ambiguity is resolved to the CertificateRevokedException > in the bootstrap JDK instead of the new one in java.security.cert. > > This is easily fixed by explicitly importing the classes required as in the > above webrev. > > Is this ok for 7u? If so, can I have a bug ID for it? > > Thanks, From sean.coffey at oracle.com Thu May 23 03:00:57 2013 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 23 May 2013 11:00:57 +0100 Subject: [7u40] Resolve ambiguity in OCSPChecker & CrlRevocationChecker In-Reply-To: <269657463.6472801.1369302334712.JavaMail.root@redhat.com> References: <2040348525.6176636.1369247132435.JavaMail.root@redhat.com> <519DD28D.4040300@oracle.com> <269657463.6472801.1369302334712.JavaMail.root@redhat.com> Message-ID: <519DE8D9.2050009@oracle.com> On 23/05/2013 10:45, Andrew Hughes wrote: > ---- Original Message ----- >> Andrew, >> >> Bug report just created : >> JDK-8015275 : Resolve ambiguity in OCSPChecker & CrlRevocationChecker >> >> Looks like both classes being modified for jdk8 don't exist any longer. > Ah, even better. Seems they were removed in: > > changeset: 5475:0c6830e7241f > parent: 4964:d383b5d128e3 > user: mullan > date: Wed May 30 17:19:46 2012 -0400 > summary: 6854712: Revocation checking enhancements (JEP-124) > > so no need to even apply this there just to keep the two in sync. Well it's not just to keep to the two in sync. The "jdk8 first" rule is there to avoid regressions being encountered in future upgrades. I've marked JDK-8015275 with '8-na' > > Is this ok to push then? Can you get a review from an official reviewer first? Preferably someone from security team. To keep in line with process them, a simple approval request can be logged. regards, Sean. > >> Regards, >> Sean. >> >> On 22/05/2013 19:25, Andrew Hughes wrote: >>> Webrev: http://cr.openjdk.java.net/~andrew/7u/webrev/ >>> >>> There's an ambiguity that applies when building OpenJDK 7 with OpenJDK 6 >>> (and hence I haven't posted this for 8 as it can't be built with 6). >>> >>> OpenJDK 6 has a class >>> sun.security.provider.certpath.CertificateRevokedException. >>> OpenJDK 7 has a class java.security.cert.CertificateRevokedException. >>> >>> Two classes in sun.security.provider.certpath in OpenJDK 7 import >>> java.security.cert.CertificateRevokedException indirectly via >>> java.security.cert.*. This appears to cause a compilation failure >>> in some cases if the ambiguity is resolved to the >>> CertificateRevokedException >>> in the bootstrap JDK instead of the new one in java.security.cert. >>> >>> This is easily fixed by explicitly importing the classes required as in the >>> above webrev. >>> >>> Is this ok for 7u? If so, can I have a bug ID for it? >>> >>> Thanks, >> From gnu.andrew at redhat.com Thu May 23 03:03:49 2013 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Thu, 23 May 2013 06:03:49 -0400 (EDT) Subject: 9001039?: DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times In-Reply-To: <519C2ECD.7040207@oracle.com> References: <51949143.2020208@oracle.com> <519C2ECD.7040207@oracle.com> Message-ID: <62927056.6480176.1369303429423.JavaMail.root@redhat.com> ----- Original Message ----- > On 5/20/2013 5:28 PM, Pasi Eronen wrote: > > Hi Xuelei, > > > > It seems the PKSC11 doesn't actually have this bug. > > > > P11KeyAgreement has a separate code path for the "TlsPremasterSecret" > > algorithm, which strips leading zeroes if the key can be extracted from > > the token. (And if the key cannot be extracted, then the token is doing > > the premaster secret->master secret computation, and has to do the > > stripping -- it can't be done from the Java PKSC11 provider.) > > > It makes sense to me. > > > To make sure this behavior doesn't change, I added a test case > > for the PKSC11 provider to the Bugzilla (which passes with the > > "SunPKCS11-NSS" provider without any changes). > > > That's great. Would you mind to contribute the regression test for > PKCS11 provider? > It's been attached to the bug report: https://bugs.openjdk.java.net/show_bug.cgi?id=100316 Is there any reason the original patch can't be committed? I haven't seen any mentioned. > Thanks, > Xuelei > > > Best regards, > > Pasi > > > > > > > > On Thu, May 16, 2013 at 10:56 AM, Xuelei Fan > > wrote: > > > > Hi Pasi, > > > > Thank you for your patience, and contribution to OpenJDK. The bug is > > accepted, and you should be able to review it at: > > > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014618 > > > > Let's use the above bug ID to track the issue. > > > > Your patch looks fine in general (I may have some very minor comments > > later). We also have similar problems in PKCS11 provider because of > > the > > update of P11KeyAgreement.java in changeset: > > > > http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 > > > > Would you like to also fix it in your patch? > > > > Thanks again for your nice work. > > > > Regards, > > Xuelei > > > > > > On 5/10/2013 5:00 PM, Pasi Eronen wrote: > > > AKA "1 out of 256 SSL/TLS handshakes fails with DHE cipher suites" > > > > > > I reported this bug over a month of ago, but for some reason, it's > > > not > > > yet visible at bugs.sun.com > > . I've included the bug > > > report below just in > > > case. > > > > > > It seems this commit from March 2012 inadvertently broke SSL/TLS DHE > > > cipher suites, causing the SSL/TLS handshake to fail approximately > > > 1 out of 256 times: > > > > > > http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 > > > > > > The commit was done to fix this bug: > > > > > > http://bugs.sun.com/view_bug.do?bug_id=7146728 > > > > > > While generating a secret of the same length as modulus may be the > > right > > > choice generally speaking (and it's what e.g. IPsec uses), SSL/TLS > > uses > > > a different convention: leading zeroes must be stripped. > > > > > > This is currently blocking us from updating our production systems to > > > Java 7, so although I have not contributed to OpenJDK before, I'd > > > like > > > to submit a patch and a test case for this (I've signed the OCA > > > already). But before I do this, I'd like to check that the approach > > > is > > > agreeable. > > > > > > We have a separate "algorithm" value "TlsPremasterSecret", so > > > behavior for other cases could stay the same. Would a patch > > > like this: > > > > > > } else if (algorithm.equals("TlsPremasterSecret")) { > > > // remove leading zero bytes per RFC 5246 Section 8.1.2 > > > int i = 0; > > > while ((i < secret.length - 1) && (secret[i] == 0)) { > > > i++; > > > } > > > if (i == 0) { > > > return new SecretKeySpec(secret, "TlsPremasterSecret"); > > > } else { > > > byte[] secret2 = new byte[secret.length - i]; > > > System.arraycopy(secret, i, secret2, 0, secret2.length); > > > return new SecretKeySpec(secret2, "TlsPremasterSecret"); > > > } > > > } > > > > > > Plus a test case (with fixed keys) that checks that leading zero is > > > stripped > > > for TlsPremasterSecret and is not stripped otherwise, be sufficient? > > > > > > Best regards, > > > Pasi > > > > > > ---snip--- > > > > > > Synopsis: > > > DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times > > > > > > Full OS version: > > > Tested on Windows 7 (Microsoft Windows [Version 6.1.7601]), but > > occurs in > > > e..g OpenJDK 7 as well. > > > > > > Development Kit or Runtime version: > > > java version "1.7.0_17" > > > Java(TM) SE Runtime Environment (build 1.7.0_17-b02) > > > Java HotSpot(TM) Client VM (build 23.7-b01, mixed mode, sharing) > > > > > > Description: > > > When performing Diffie-Hellman key agreement for SSL/TLS, the TLS > > > specification (RFC 5246) says that "Leading bytes of Z that > > contain all zero > > > bits are stripped before it is used as the pre_master_secret." > > > > > > However, com.sun.crypto.provider.DHKeyAgreement.java does not > > strip leading > > > zero bytes. This causes approximately 1 out 256 SSL/TLS handshakes > > with > > > DH/DHE cipher suites to fail (when the leading byte happens, by > > chance, to > > > be zero). > > > > > > Steps to Reproduce: > > > 1. Start a simple JSSE socket server with -Djavax.net.debug=all. > > > > > > 2. Connect to the server with e.g. OpenSSL command line tool, > > ensuring that > > > DHE cipher suite gets selected (e.g. "openssl s_client -cipher > > > DHE-RSA-AES128-SHA -connect 192.168.81.1:9999 > > > > > ") repeatedly. Other SSL > > > clients can be used -- this is not an OpenSSL bug (see below). > > > > > > 3. Repeat the connection. After a couple of hundred successful > > connections, > > > the connection will fail with handshake_failure alert. > > > > > > 4. Examine the JSSE debug logs produced by the server: the failed > > connection > > > will have a PreMaster secret that begins with zero byte > > > (while all other connections have non-zero byte here). For example: > > > > > > SESSION KEYGEN: > > > PreMaster Secret: > > > 0000: 00 70 C5 7E 91 38 C8 DE ED 75 3D 76 8A B5 44 69 > > .p...8...u=v..Di > > > 0010: E7 32 1C EE 80 77 50 C7 A9 51 24 2E E3 15 11 30 > > .2...wP..Q$....0 > > > 0020: 9D F6 9F BC 9D EB 5C 18 F7 A4 19 ED 1A AC 2E 0C > > ......\......... > > > 0030: E3 18 C5 11 B1 80 07 7D B1 C6 70 A8 D7 EB CF DD > > ..........p..... > > > 0040: 2D B5 1D BC 01 3E 28 2A 2B 5B 38 8F EB 20 F2 A2 > > -....>(*+[8.. .. > > > 0050: 00 07 47 F7 87 B8 99 CB EF B4 13 04 C8 8B 82 FB > > ..G............. > > > > > > Expected Result: > > > Expected result is that every connection succeed. > > > > > > Actual Result: > > > Roughly one out of 256 connections fail. > > > > > > Source code for an executable test case: > > > > > > Java server: > > > > > > import javax.net.ssl.SSLServerSocket; > > > import javax.net.ssl.SSLServerSocketFactory; > > > import javax.net.ssl.SSLSocket; > > > > > > public class TestServer { > > > public static void main(String args[]) throws Exception { > > > SSLServerSocketFactory ssf = (SSLServerSocketFactory) > > > SSLServerSocketFactory.getDefault(); > > > SSLServerSocket ss = (SSLServerSocket) > > ssf.createServerSocket(9999); > > > System.out.println("Listening on port 9999"); > > > for (String cs : ss.getEnabledCipherSuites()) { > > > System.out.println(cs); > > > } > > > while (true) { > > > SSLSocket s = (SSLSocket) ss.accept(); > > > System.out.println("Connected with > > > "+s.getSession().getCipherSuite()); > > > s.close(); > > > } > > > } > > > } > > > > > > Run as as follows: > > > > > > keytool -storepass "password" -keypass "password" -genkey -keyalg RSA > > > -keystore test_keystore.jks -dname CN=test > > > javac TestServer.java > > > java -Djavax.net.debug=all > > -Djavax.net.ssl.keyStore=./test_keystore.jks > > > -Djavax.net.ssl.keyStorePassword=password TestServer > > > > > > OpenSSL client: > > > > > > set -e > > > while true; do > > > openssl s_client -cipher DHE-RSA-AES128-SHA -connect > > 127.0.0.1:9999 > > > -quiet -no_ign_eof < /dev/null > > > done > > > > > > Workaround: > > > Disable Diffie-Hellman cipher suites. > > > > > > ---snip--- > > > > > > > > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From gnu.andrew at redhat.com Thu May 23 02:45:34 2013 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Thu, 23 May 2013 05:45:34 -0400 (EDT) Subject: [7u40] Resolve ambiguity in OCSPChecker & CrlRevocationChecker In-Reply-To: <519DD28D.4040300@oracle.com> References: <2040348525.6176636.1369247132435.JavaMail.root@redhat.com> <519DD28D.4040300@oracle.com> Message-ID: <269657463.6472801.1369302334712.JavaMail.root@redhat.com> ---- Original Message ----- > Andrew, > > Bug report just created : > JDK-8015275 : Resolve ambiguity in OCSPChecker & CrlRevocationChecker > > Looks like both classes being modified for jdk8 don't exist any longer. Ah, even better. Seems they were removed in: changeset: 5475:0c6830e7241f parent: 4964:d383b5d128e3 user: mullan date: Wed May 30 17:19:46 2012 -0400 summary: 6854712: Revocation checking enhancements (JEP-124) so no need to even apply this there just to keep the two in sync. Is this ok to push then? > > Regards, > Sean. > > On 22/05/2013 19:25, Andrew Hughes wrote: > > Webrev: http://cr.openjdk.java.net/~andrew/7u/webrev/ > > > > There's an ambiguity that applies when building OpenJDK 7 with OpenJDK 6 > > (and hence I haven't posted this for 8 as it can't be built with 6). > > > > OpenJDK 6 has a class > > sun.security.provider.certpath.CertificateRevokedException. > > OpenJDK 7 has a class java.security.cert.CertificateRevokedException. > > > > Two classes in sun.security.provider.certpath in OpenJDK 7 import > > java.security.cert.CertificateRevokedException indirectly via > > java.security.cert.*. This appears to cause a compilation failure > > in some cases if the ambiguity is resolved to the > > CertificateRevokedException > > in the bootstrap JDK instead of the new one in java.security.cert. > > > > This is easily fixed by explicitly importing the classes required as in the > > above webrev. > > > > Is this ok for 7u? If so, can I have a bug ID for it? > > > > Thanks, > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From xuelei.fan at oracle.com Thu May 23 03:39:57 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 23 May 2013 18:39:57 +0800 Subject: 9001039?: DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times In-Reply-To: <62927056.6480176.1369303429423.JavaMail.root@redhat.com> References: <51949143.2020208@oracle.com> <519C2ECD.7040207@oracle.com> <62927056.6480176.1369303429423.JavaMail.root@redhat.com> Message-ID: <519DF1FD.2060206@oracle.com> On 5/23/2013 6:03 PM, Andrew Hughes wrote: > ----- Original Message ----- >> On 5/20/2013 5:28 PM, Pasi Eronen wrote: >>> Hi Xuelei, >>> >>> It seems the PKSC11 doesn't actually have this bug. >>> >>> P11KeyAgreement has a separate code path for the "TlsPremasterSecret" >>> algorithm, which strips leading zeroes if the key can be extracted from >>> the token. (And if the key cannot be extracted, then the token is doing >>> the premaster secret->master secret computation, and has to do the >>> stripping -- it can't be done from the Java PKSC11 provider.) >>> >> It makes sense to me. >> >>> To make sure this behavior doesn't change, I added a test case >>> for the PKSC11 provider to the Bugzilla (which passes with the >>> "SunPKCS11-NSS" provider without any changes). >>> >> That's great. Would you mind to contribute the regression test for >> PKCS11 provider? >> > > It's been attached to the bug report: https://bugs.openjdk.java.net/show_bug.cgi?id=100316 > Thanks Andrew! > Is there any reason the original patch can't be committed? I haven't seen any mentioned. > It is accepted. The minor comment I mentioned in the previous mail is that we may want to merge the functions to trim leading zeros in one method. There is a method sun.security.pkcs11.P11Util.trimZeroes(byte[] b) which is used to trim leading zeros. I think it would be nice to move the method to sun.security.util.KeyUtil, and make use of this method in the patch of DHKeyAgreement.engineGenerateSecret(String algorithm) as well. Pasi, what do you think? Otherwise, the patch looks fine to me. I can be the sponsor if you won't able to merge the changes into openJDk workspace. Thanks, Xuelei >> Thanks, >> Xuelei >> >>> Best regards, >>> Pasi >>> >>> >>> >>> On Thu, May 16, 2013 at 10:56 AM, Xuelei Fan >> > wrote: >>> >>> Hi Pasi, >>> >>> Thank you for your patience, and contribution to OpenJDK. The bug is >>> accepted, and you should be able to review it at: >>> >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014618 >>> >>> Let's use the above bug ID to track the issue. >>> >>> Your patch looks fine in general (I may have some very minor comments >>> later). We also have similar problems in PKCS11 provider because of >>> the >>> update of P11KeyAgreement.java in changeset: >>> >>> http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 >>> >>> Would you like to also fix it in your patch? >>> >>> Thanks again for your nice work. >>> >>> Regards, >>> Xuelei >>> >>> >>> On 5/10/2013 5:00 PM, Pasi Eronen wrote: >>> > AKA "1 out of 256 SSL/TLS handshakes fails with DHE cipher suites" >>> > >>> > I reported this bug over a month of ago, but for some reason, it's >>> > not >>> > yet visible at bugs.sun.com >>> . I've included the bug >>> > report below just in >>> > case. >>> > >>> > It seems this commit from March 2012 inadvertently broke SSL/TLS DHE >>> > cipher suites, causing the SSL/TLS handshake to fail approximately >>> > 1 out of 256 times: >>> > >>> > http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 >>> > >>> > The commit was done to fix this bug: >>> > >>> > http://bugs.sun.com/view_bug.do?bug_id=7146728 >>> > >>> > While generating a secret of the same length as modulus may be the >>> right >>> > choice generally speaking (and it's what e.g. IPsec uses), SSL/TLS >>> uses >>> > a different convention: leading zeroes must be stripped. >>> > >>> > This is currently blocking us from updating our production systems to >>> > Java 7, so although I have not contributed to OpenJDK before, I'd >>> > like >>> > to submit a patch and a test case for this (I've signed the OCA >>> > already). But before I do this, I'd like to check that the approach >>> > is >>> > agreeable. >>> > >>> > We have a separate "algorithm" value "TlsPremasterSecret", so >>> > behavior for other cases could stay the same. Would a patch >>> > like this: >>> > >>> > } else if (algorithm.equals("TlsPremasterSecret")) { >>> > // remove leading zero bytes per RFC 5246 Section 8.1.2 >>> > int i = 0; >>> > while ((i < secret.length - 1) && (secret[i] == 0)) { >>> > i++; >>> > } >>> > if (i == 0) { >>> > return new SecretKeySpec(secret, "TlsPremasterSecret"); >>> > } else { >>> > byte[] secret2 = new byte[secret.length - i]; >>> > System.arraycopy(secret, i, secret2, 0, secret2.length); >>> > return new SecretKeySpec(secret2, "TlsPremasterSecret"); >>> > } >>> > } >>> > >>> > Plus a test case (with fixed keys) that checks that leading zero is >>> > stripped >>> > for TlsPremasterSecret and is not stripped otherwise, be sufficient? >>> > >>> > Best regards, >>> > Pasi >>> > >>> > ---snip--- >>> > >>> > Synopsis: >>> > DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times >>> > >>> > Full OS version: >>> > Tested on Windows 7 (Microsoft Windows [Version 6.1.7601]), but >>> occurs in >>> > e..g OpenJDK 7 as well. >>> > >>> > Development Kit or Runtime version: >>> > java version "1.7.0_17" >>> > Java(TM) SE Runtime Environment (build 1.7.0_17-b02) >>> > Java HotSpot(TM) Client VM (build 23.7-b01, mixed mode, sharing) >>> > >>> > Description: >>> > When performing Diffie-Hellman key agreement for SSL/TLS, the TLS >>> > specification (RFC 5246) says that "Leading bytes of Z that >>> contain all zero >>> > bits are stripped before it is used as the pre_master_secret." >>> > >>> > However, com.sun.crypto.provider.DHKeyAgreement.java does not >>> strip leading >>> > zero bytes. This causes approximately 1 out 256 SSL/TLS handshakes >>> with >>> > DH/DHE cipher suites to fail (when the leading byte happens, by >>> chance, to >>> > be zero). >>> > >>> > Steps to Reproduce: >>> > 1. Start a simple JSSE socket server with -Djavax.net.debug=all. >>> > >>> > 2. Connect to the server with e.g. OpenSSL command line tool, >>> ensuring that >>> > DHE cipher suite gets selected (e.g. "openssl s_client -cipher >>> > DHE-RSA-AES128-SHA -connect 192.168.81.1:9999 >>> >>> > ") repeatedly. Other SSL >>> > clients can be used -- this is not an OpenSSL bug (see below). >>> > >>> > 3. Repeat the connection. After a couple of hundred successful >>> connections, >>> > the connection will fail with handshake_failure alert. >>> > >>> > 4. Examine the JSSE debug logs produced by the server: the failed >>> connection >>> > will have a PreMaster secret that begins with zero byte >>> > (while all other connections have non-zero byte here). For example: >>> > >>> > SESSION KEYGEN: >>> > PreMaster Secret: >>> > 0000: 00 70 C5 7E 91 38 C8 DE ED 75 3D 76 8A B5 44 69 >>> .p...8...u=v..Di >>> > 0010: E7 32 1C EE 80 77 50 C7 A9 51 24 2E E3 15 11 30 >>> .2...wP..Q$....0 >>> > 0020: 9D F6 9F BC 9D EB 5C 18 F7 A4 19 ED 1A AC 2E 0C >>> ......\......... >>> > 0030: E3 18 C5 11 B1 80 07 7D B1 C6 70 A8 D7 EB CF DD >>> ..........p..... >>> > 0040: 2D B5 1D BC 01 3E 28 2A 2B 5B 38 8F EB 20 F2 A2 >>> -....>(*+[8.. .. >>> > 0050: 00 07 47 F7 87 B8 99 CB EF B4 13 04 C8 8B 82 FB >>> ..G............. >>> > >>> > Expected Result: >>> > Expected result is that every connection succeed. >>> > >>> > Actual Result: >>> > Roughly one out of 256 connections fail. >>> > >>> > Source code for an executable test case: >>> > >>> > Java server: >>> > >>> > import javax.net.ssl.SSLServerSocket; >>> > import javax.net.ssl.SSLServerSocketFactory; >>> > import javax.net.ssl.SSLSocket; >>> > >>> > public class TestServer { >>> > public static void main(String args[]) throws Exception { >>> > SSLServerSocketFactory ssf = (SSLServerSocketFactory) >>> > SSLServerSocketFactory.getDefault(); >>> > SSLServerSocket ss = (SSLServerSocket) >>> ssf.createServerSocket(9999); >>> > System.out.println("Listening on port 9999"); >>> > for (String cs : ss.getEnabledCipherSuites()) { >>> > System.out.println(cs); >>> > } >>> > while (true) { >>> > SSLSocket s = (SSLSocket) ss.accept(); >>> > System.out.println("Connected with >>> > "+s.getSession().getCipherSuite()); >>> > s.close(); >>> > } >>> > } >>> > } >>> > >>> > Run as as follows: >>> > >>> > keytool -storepass "password" -keypass "password" -genkey -keyalg RSA >>> > -keystore test_keystore.jks -dname CN=test >>> > javac TestServer.java >>> > java -Djavax.net.debug=all >>> -Djavax.net.ssl.keyStore=./test_keystore.jks >>> > -Djavax.net.ssl.keyStorePassword=password TestServer >>> > >>> > OpenSSL client: >>> > >>> > set -e >>> > while true; do >>> > openssl s_client -cipher DHE-RSA-AES128-SHA -connect >>> 127.0.0.1:9999 >>> > -quiet -no_ign_eof < /dev/null >>> > done >>> > >>> > Workaround: >>> > Disable Diffie-Hellman cipher suites. >>> > >>> > ---snip--- >>> > >>> >>> >> >> > From nils.loodin at oracle.com Thu May 23 06:54:01 2013 From: nils.loodin at oracle.com (nils.loodin at oracle.com) Date: Thu, 23 May 2013 13:54:01 +0000 Subject: hg: jdk8/tl/jdk: 8014048: Online user guide of jconsole points incorrect link Message-ID: <20130523135413.A8A2B48CA9@hg.openjdk.java.net> Changeset: 0da6485cf656 Author: nloodin Date: 2013-05-23 15:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0da6485cf656 8014048: Online user guide of jconsole points incorrect link Reviewed-by: mchung, sla, jbachorik ! src/share/classes/sun/tools/jconsole/AboutDialog.java ! src/share/classes/sun/tools/jconsole/resources/messages.properties ! src/share/classes/sun/tools/jconsole/resources/messages_ja.properties ! src/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties From chris.hegarty at oracle.com Thu May 23 10:36:06 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 23 May 2013 17:36:06 +0000 Subject: hg: jdk8/tl/jdk: 8014076: Arrays parallel and serial sorting improvements Message-ID: <20130523173631.03B9748CB0@hg.openjdk.java.net> Changeset: 3b23e3529ab3 Author: dl Date: 2013-05-23 18:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b23e3529ab3 8014076: Arrays parallel and serial sorting improvements Reviewed-by: chegar, mduigou ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/ArraysParallelSortHelpers.java ! src/share/classes/java/util/ComparableTimSort.java ! src/share/classes/java/util/DualPivotQuicksort.java ! src/share/classes/java/util/TimSort.java ! test/java/util/Arrays/ParallelSorting.java From james.laskey at oracle.com Thu May 23 05:54:03 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Thu, 23 May 2013 12:54:03 +0000 Subject: hg: jdk8/tl/nashorn: 9 new changesets Message-ID: <20130523125410.DE26E48C9B@hg.openjdk.java.net> Changeset: 833a9a584b64 Author: attila Date: 2013-05-21 13:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/833a9a584b64 8014953: Have NativeJavaPackage throw a ClassNotFoundException when invoked Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java + test/script/basic/JDK-8014953.js + test/script/basic/JDK-8014953.js.EXPECTED Changeset: 288ff54da2a5 Author: jlaskey Date: 2013-05-21 10:17 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/288ff54da2a5 8014827: readLine should accept a prompt as an argument Reviewed-by: sundar, hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java Changeset: 07cefc062032 Author: sundar Date: 2013-05-22 16:39 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/07cefc062032 8008947: ScriptEnvironment ctor should be public Reviewed-by: lagergren, attila ! .hgignore ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java Changeset: 66685c69bdb3 Author: sundar Date: 2013-05-22 19:33 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/66685c69bdb3 8014735: Typed Array, BYTES_PER_ELEMENT should be a class property Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java + test/script/basic/JDK-8014735.js + test/script/basic/JDK-8014735.js.EXPECTED ! test/script/basic/NASHORN-377.js Changeset: 8f7553df4503 Author: hannesw Date: 2013-05-22 16:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8f7553df4503 8010804: Review long and integer usage conventions Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/runtime/JSType.java + test/script/basic/JDK-8010804.js + test/script/basic/JDK-8010804.js.EXPECTED Changeset: 1c1453863ea8 Author: attila Date: 2013-05-23 12:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1c1453863ea8 8015267: Allow conversion of JS arrays to Java List/Deque Reviewed-by: lagergren, sundar ! make/build.xml ! src/jdk/nashorn/internal/objects/NativeJava.java + src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/linker/InvokeByName.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/JDK-8015267.js + test/script/basic/JDK-8015267.js.EXPECTED Changeset: f7eb4436410e Author: lagergren Date: 2013-05-23 13:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f7eb4436410e 8012083: Array literal constant folding issue Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java + test/script/basic/JDK-8012083.js + test/script/basic/JDK-8012083.js.EXPECTED Changeset: 704bc91a0c41 Author: attila Date: 2013-05-23 13:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/704bc91a0c41 8015278: Revert accidental changes to build.xml Reviewed-by: jlaskey, lagergren ! make/build.xml Changeset: 8af550dee961 Author: jlaskey Date: 2013-05-23 09:49 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8af550dee961 Merge From valerie.peng at oracle.com Thu May 23 14:14:59 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Thu, 23 May 2013 14:14:59 -0700 Subject: Code review request: 8014196: ktab creates a file with zero kt_vno In-Reply-To: <51907CA3.4000409@oracle.com> References: <51907CA3.4000409@oracle.com> Message-ID: <519E86D3.8020000@oracle.com> On 05/12/13 22:39, Weijun Wang wrote: > Hi Valerie > > Please take a look at > > http://cr.openjdk.java.net/~weijun/8014196/webrev.01/ > > KeyTab.getInstance() used to return null if the keytab file does not > exists, but since we supported dynamic ktab, the result is never null. > But the KeyTab object has not initialize its kt_vno. > > The fix includes two parts: > > 1. Initialize kt_vno in KeyTab even if isMissing or !isValid Why not just directly set the default value to KRB5_KT_VNO on line 81? Seem easier this way. The rest looks fine. Thanks, Valerie > > 2. Make clear in what cases ktab.exe should fail. > > Thanks > Max From weijun.wang at oracle.com Thu May 23 16:07:43 2013 From: weijun.wang at oracle.com (Wang Weijun) Date: Fri, 24 May 2013 07:07:43 +0800 Subject: Code review request: 8014196: ktab creates a file with zero kt_vno In-Reply-To: <519E86D3.8020000@oracle.com> References: <51907CA3.4000409@oracle.com> <519E86D3.8020000@oracle.com> Message-ID: <4FA73178-845E-4AE8-A85B-407D3476FE86@oracle.com> ?? May 24, 2013??5:14??"Valerie (Yu-Ching) Peng" ?????? > On 05/12/13 22:39, Weijun Wang wrote: >> Hi Valerie >> >> Please take a look at >> >> http://cr.openjdk.java.net/~weijun/8014196/webrev.01/ >> >> KeyTab.getInstance() used to return null if the keytab file does not exists, but since we supported dynamic ktab, the result is never null. But the KeyTab object has not initialize its kt_vno. >> >> The fix includes two parts: >> >> 1. Initialize kt_vno in KeyTab even if isMissing or !isValid > Why not just directly set the default value to KRB5_KT_VNO on line 81? Seem easier this way. > The rest looks fine. Yes, that looks better. Thanks Max > Thanks, > Valerie > >> >> 2. Make clear in what cases ktab.exe should fail. >> >> Thanks >> Max > From weijun.wang at oracle.com Fri May 24 02:34:50 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 24 May 2013 09:34:50 +0000 Subject: hg: jdk8/tl/jdk: 8014196: ktab creates a file with zero kt_vno Message-ID: <20130524093523.B5AC848D07@hg.openjdk.java.net> Changeset: 6816afd70a68 Author: weijun Date: 2013-05-24 17:15 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6816afd70a68 8014196: ktab creates a file with zero kt_vno Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/windows/classes/sun/security/krb5/internal/tools/Ktab.java + test/sun/security/krb5/tools/KtabZero.java + test/sun/security/krb5/tools/ktzero.sh From maurizio.cimadamore at oracle.com Fri May 24 07:29:32 2013 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Fri, 24 May 2013 14:29:32 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20130524142952.35A1E48D10@hg.openjdk.java.net> Changeset: 58329d9f6b68 Author: mcimadamore Date: 2013-05-24 15:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/58329d9f6b68 8014643: Parser regression in JDK 8 when compiling super.x Summary: Fixed latent bug in JavacParser.analyzeParens() Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/parser/8014643/T8014643.java Changeset: 97a9b4b3e63a Author: mcimadamore Date: 2013-05-24 15:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97a9b4b3e63a 8014649: Regression: bug in Resolve.resolveOperator Summary: Missing curly braces causes Resolve.findMethod to be called spuriously Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/resolve/ResolveHarness.java + test/tools/javac/resolve/tests/PrimitiveBinopOverload.java Changeset: 6e5076af4660 Author: mcimadamore Date: 2013-05-24 15:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6e5076af4660 8014494: javac crashes when varargs element of a method reference is inferred from the context Summary: varargs element is not refreshed after type-inference Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/lambda/TargetType73.java From joe.darcy at oracle.com Fri May 24 11:26:28 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 24 May 2013 18:26:28 +0000 Subject: hg: jdk8/tl/langtools: 8014836: Have GenericDeclaration extend AnnotatedElement Message-ID: <20130524182635.1F03048D20@hg.openjdk.java.net> Changeset: 0f8e9a0e5d9a Author: darcy Date: 2013-05-24 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0f8e9a0e5d9a 8014836: Have GenericDeclaration extend AnnotatedElement Reviewed-by: jfranck ! src/share/sample/language/model/CoreReflectionFactory.java From john.zavgren at oracle.com Fri May 24 12:56:11 2013 From: john.zavgren at oracle.com (John Zavgren) Date: Fri, 24 May 2013 15:56:11 -0400 Subject: RFR JDK-8014307 In-Reply-To: <519FB1DE.90607@oracle.com> References: <519D5249.1050605@oracle.com> <519FB1DE.90607@oracle.com> Message-ID: <519FC5DB.7020402@oracle.com> Thanks, Valerie. I removed the unnecessary resetGSSBuffer(...) call. The revised webrev is viewable at: http://cr.openjdk.java.net/~jzavgren/8014307/webrev.03/ John > -------- Original Message -------- > Subject: Re: RFR JDK-8014307 > Date: Wed, 22 May 2013 16:18:33 -0700 > From: Valerie (Yu-Ching) Peng > Reply-To: valerie.peng at oracle.com > To: security-dev at openjdk.java.net > > > > The resetGSSBuffer(..) call on line 829 should be removed as the inToken > structure isn't even initialized yet (initGSSBuffer call is on line 833). > Rest looks fine. > Thanks, > Valerie > > On 05/22/13 11:54, John Zavgren wrote: >> Greetings: >> I just updated: >> /jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c >> /with the recommended changes. >> >> http://cr.openjdk.java.net/~jzavgren/8014307/webrev.02/ >> >> Thanks! >> John Zavgren >> ---------------------------------------------------------------------- >> >> >> John, >> >> 1) 332-333 can be replaced w/ a deleteGSSOID(nameType) call. Also, with >> this deleteGSSOID(nameType) call, we should also add the following >> line: >> resetGSSBuffer(env, jnameVal, &nameVal); >> >> 2) I think the ExceptionCheck block on line 932 should also be enhanced >> w/ resetGSSBuffer(env, jinToken, &inToken) call as well as free(cb) >> call. Same goes for another ExceptionCheck blocks on line 984, 998, >> 1024. >> >> Thanks, >> Valerie >> On 05/14/13 19:19, John Zavgren wrote: >> >/ Greetings: Please review the following change to the file: >> />/ jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c that >> fixes >> />/ two memory leaks. >> />/ http://cr.openjdk.java.net/~jzavgren/8014307/webrev.01/ >> Thanks! John >> />/ Zavgren/ >> -- >> John Zavgren >> john.zavgren at oracle.com >> 603-821-0904 >> US-Burlington-MA > > > -- John Zavgren john.zavgren at oracle.com 603-821-0904 US-Burlington-MA -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130524/6e64b2b9/attachment.html From ricardo_martin_camarero at yahoo.es Fri May 24 02:31:35 2013 From: ricardo_martin_camarero at yahoo.es (Ricardo Martin Camarero) Date: Fri, 24 May 2013 11:31:35 +0200 Subject: PATCH: possible bug in OCSP check Message-ID: <519F3377.9000902@yahoo.es> Hi everybody, I have been struggling for some months with a weird issue about how Java validates OCSP responses. Following the RFC2560 standard the responses sent by the responder should be signed following one of these three possibilities: > All definitive response messages SHALL be digitally signed. The key > used to sign the response MUST belong to one of the following: > > -- the CA who issued the certificate in question > -- a Trusted Responder whose public key is trusted by the requester > -- a CA Designated Responder (Authorized Responder) who holds a > specially marked certificate issued directly by the CA, indicating > that the responder may issue OCSP responses for that CA In current java implementation (openjdk 6, 7 and 8) the case (1) and (3) are considered by default and case (2) can be configured using some properties ("ocsp.responderCertSubjectName" for example). But the problem is that both configurations are exclusive, if your application accepts responses for the cases (1) and (3) it fails with the case (2) and vice-versa. I faced an OCSP responder that in some cases it answered using the case (1) and in others using the case (2). The case (1) was used to sign responses for their own certificates and the case (2) was used to sign responses for foreign certificates (spanish national id certificates specifically). I'm not completely sure if the standard admits this situation but I haven't read anything against that. Besides why not to take the configured certificate ("ocsp.responderCertSubjectName" or any of the other properties) as a failback and not as the unique valid signer. Looking at the code the problem is that only one certificate is passed as the valid signer for responses (the one configured via properties or the issuer cert). Following Andrew advise I have made a little patch against current openjdk-8 that just considers both of them (OCSPResponse class receives both certs and this way can check the three cases). Thanks in advance! -------------- next part -------------- A non-text attachment was scrubbed... Name: ocsp-jdk8.patch Type: text/x-patch Size: 7223 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130524/c0286f7d/ocsp-jdk8.patch From kumar.x.srinivasan at oracle.com Fri May 24 18:54:53 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Sat, 25 May 2013 01:54:53 +0000 Subject: hg: jdk8/tl/jdk: 8007333: [launcher] removes multiple back slashes Message-ID: <20130525015529.0B9A248D30@hg.openjdk.java.net> Changeset: 5e769206f036 Author: ksrini Date: 2013-05-24 17:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e769206f036 8007333: [launcher] removes multiple back slashes Reviewed-by: alanb, akhil ! src/windows/bin/cmdtoargs.c ! test/tools/launcher/Arrrghs.java From weijun.wang at oracle.com Sun May 26 19:06:36 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 27 May 2013 10:06:36 +0800 Subject: Code review request: 8014310: JAAS/Krb5LoginModule using des encytypes failure with NPE after JDK-8012679 Message-ID: <51A2BFAC.3020607@oracle.com> Please review the code changes at http://cr.openjdk.java.net/~weijun/8014310/webrev.00/ The reason is that since we set allow_weak_crypto to false, if the user only had DES keys or only has DES-related etypes enabled, there will be no working etype at all. Soon or later, an NPE is thrown. This fix includes: 1. Instead of returning null in Config::defaultEtype(configName), a KrbException is thrown. 2. Removes useless if-null-then-KrbException checks. 3. Not related to the bug: remove sort-by-etype in KeyTab::readServiceKeys(princ). It was meant to make sure a preferred etype appears before another one. In fact, the order of etypes returned by EType::getDefaults(configName,keys) are determined by the order of Config::defaultEtype(configName) instead of keys. Therefore it's actually useless. The sort-by-kvno is preserved. This does not matter when the key is used to decrypt an EncryptedData structure (which knows what kvno should be used). Sometime we still have to pick one with no hint at all, say, creating the encrypted timestamp in preauth AS-REQ. A key with higher kvno is normally more likely to be the current one. Thanks Max From xuelei.fan at oracle.com Sun May 26 21:52:31 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 27 May 2013 12:52:31 +0800 Subject: Code Review: 7160837 DigestOutputStream does not turn off digest calculation when "close()" is called In-Reply-To: <971073AF-FA55-4C8F-9EE5-AD9524ABCAE6@oracle.com> References: <51925515.9010702@oracle.com> <971073AF-FA55-4C8F-9EE5-AD9524ABCAE6@oracle.com> Message-ID: <51A2E68F.8060503@oracle.com> Looks fine to me, except a very minor coding style comment: CipherInputStream.java ====================== 307 } 308 catch (BadPaddingException | IllegalBlockSizeException ex) {} I would prefer a style as: 307 } catch (BadPaddingException | IllegalBlockSizeException ex) { 308 } Xuelei On 5/22/2013 1:42 AM, Anthony Scarpino wrote: > ping... > > No comments? Perfect? :-) > > On May 14, 2013, at 8:15 AM, Anthony Scarpino wrote: > >> Hi, >> >> Below is the link to code changes for: DigestOutputStream does not turn off digest calculation when "close()" is called. >> >> The more significant change is to the Cipher streams to prevent extra doFinal() calls. >> >> http://cr.openjdk.java.net/~ascarpino/7160837/webrev.00/ >> >> thanks >> >> Tony From sundararajan.athijegannathan at oracle.com Mon May 27 01:21:17 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 27 May 2013 08:21:17 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20130527082121.4BF8A48D51@hg.openjdk.java.net> Changeset: 6fc7b51e83d6 Author: lagergren Date: 2013-05-23 15:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6fc7b51e83d6 8012522: Clean up lexical contexts - split out stack based functionality in CodeGenerator and generify NodeVisitors based on their LexicalContext type to avoid casts Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + src/jdk/nashorn/internal/codegen/CodeGeneratorLexicalContext.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/RangeAnalyzer.java ! src/jdk/nashorn/internal/codegen/SharedScopeCall.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterGeneratorBase.java Changeset: fdfb4edd78d6 Author: hannesw Date: 2013-05-24 13:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fdfb4edd78d6 8011630: JSON parsing performance issue Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/FindProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java Changeset: 4d2eca4d4d66 Author: sundar Date: 2013-05-24 18:39 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4d2eca4d4d66 8015354: JSON.parse should not use [[Put]] but use [[DefineOwnProperty]] instead Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/Property.java + test/script/basic/JDK-8015354.js Changeset: 751cfefff5eb Author: sundar Date: 2013-05-24 23:27 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/751cfefff5eb 8015351: Nashorn shell does not start with Turkish locale Reviewed-by: jlaskey ! make/project.properties ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java From tomas at primekey.se Mon May 27 01:31:30 2013 From: tomas at primekey.se (Tomas Gustavsson) Date: Mon, 27 May 2013 10:31:30 +0200 Subject: Status of old sun tracker issues? Message-ID: <51A319E2.6020201@primekey.se> Hi, What is the master issue tracker for OpenJDK these days? We have reported https://bugs.openjdk.java.net/show_bug.cgi?id=100162 Which is closed referencing a "sun bug" id. Is the oracle tracker (which was off line for a long time) the main issue tracker for OpenJDK still? Cheers, Tomas Gustavsson From david.holmes at oracle.com Mon May 27 04:34:19 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Mon, 27 May 2013 11:34:19 +0000 Subject: hg: jdk8/tl/jdk: 7038914: VM could throw uncaught OOME in ReferenceHandler thread Message-ID: <20130527113433.001D348D5A@hg.openjdk.java.net> Changeset: 0b8dab7fec54 Author: plevart Date: 2013-05-27 09:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0b8dab7fec54 7038914: VM could throw uncaught OOME in ReferenceHandler thread Summary: Catch OutOfMemoryError in reference handler thread if caused by allocation of an InterruptedException Reviewed-by: dholmes, alanb ! src/share/classes/java/lang/ref/Reference.java + test/java/lang/ref/OOMEInReferenceHandler.java From vicente.romero at oracle.com Mon May 27 05:44:46 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Mon, 27 May 2013 12:44:46 +0000 Subject: hg: jdk8/tl/langtools: 7030476: Fix conflicting use of JCTree/JCExpression Message-ID: <20130527124449.5A3AB48D5F@hg.openjdk.java.net> Changeset: b391ecea538e Author: vromero Date: 2013-05-27 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b391ecea538e 7030476: Fix conflicting use of JCTree/JCExpression Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java From chris.hegarty at oracle.com Mon May 27 07:26:11 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 27 May 2013 14:26:11 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130527142657.20B0548D61@hg.openjdk.java.net> Changeset: a2dc42667df3 Author: chegar Date: 2013-05-27 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a2dc42667df3 8015439: Minor/sync/cleanup of ConcurrentHashMap Reviewed-by: chegar Contributed-by: Doug Lea
              , Chris Hegarty ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java Changeset: 9bbf2237071e Author: chegar Date: 2013-05-27 15:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bbf2237071e Merge From sean.coffey at oracle.com Mon May 27 08:16:23 2013 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Mon, 27 May 2013 16:16:23 +0100 Subject: Status of old sun tracker issues? In-Reply-To: <51A319E2.6020201@primekey.se> References: <51A319E2.6020201@primekey.se> Message-ID: <51A378C7.9080706@oracle.com> A JIRA system is now the system of record for OpenJDK issues.[1] Work on getting that system open to external audience is ongoing. In the meantime you can reference the bug via bugs.sun.com : http://bugs.sun.com/view_bug.do?bug_id=7007966 regards, Sean. [1] https://blogs.oracle.com/darcy/entry/milestone_jira_system_of_record On 27/05/13 09:31, Tomas Gustavsson wrote: > > Hi, > > What is the master issue tracker for OpenJDK these days? > We have reported https://bugs.openjdk.java.net/show_bug.cgi?id=100162 > Which is closed referencing a "sun bug" id. Is the oracle tracker > (which was off line for a long time) the main issue tracker for > OpenJDK still? > > Cheers, > Tomas Gustavsson -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130527/f587bbe0/attachment.html From nils.loodin at oracle.com Mon May 27 08:18:33 2013 From: nils.loodin at oracle.com (nils.loodin at oracle.com) Date: Mon, 27 May 2013 15:18:33 +0000 Subject: hg: jdk8/tl/jdk: 6470730: Disconnect button leads to wrong popup message Message-ID: <20130527151845.4F89448D64@hg.openjdk.java.net> Changeset: bbf6e6222726 Author: nloodin Date: 2013-05-27 17:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbf6e6222726 6470730: Disconnect button leads to wrong popup message Reviewed-by: dcubed, sla, egahlin ! src/share/classes/sun/tools/jconsole/VMPanel.java From anthony.scarpino at oracle.com Mon May 27 10:30:32 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Mon, 27 May 2013 10:30:32 -0700 Subject: Code Review: 7160837 DigestOutputStream does not turn off digest calculation when "close()" is called In-Reply-To: <51A2E68F.8060503@oracle.com> References: <51925515.9010702@oracle.com> <971073AF-FA55-4C8F-9EE5-AD9524ABCAE6@oracle.com> <51A2E68F.8060503@oracle.com> Message-ID: <51A39838.6080505@oracle.com> Sure.. Tony On 05/26/2013 09:52 PM, Xuelei Fan wrote: > Looks fine to me, except a very minor coding style comment: > > CipherInputStream.java > ====================== > 307 } > 308 catch (BadPaddingException | IllegalBlockSizeException ex) {} > > I would prefer a style as: > 307 } catch (BadPaddingException | IllegalBlockSizeException ex) { > 308 } > > Xuelei > > On 5/22/2013 1:42 AM, Anthony Scarpino wrote: >> ping... >> >> No comments? Perfect? :-) >> >> On May 14, 2013, at 8:15 AM, Anthony Scarpino wrote: >> >>> Hi, >>> >>> Below is the link to code changes for: DigestOutputStream does not turn off digest calculation when "close()" is called. >>> >>> The more significant change is to the Cipher streams to prevent extra doFinal() calls. >>> >>> http://cr.openjdk.java.net/~ascarpino/7160837/webrev.00/ >>> >>> thanks >>> >>> Tony > From bradford.wetmore at oracle.com Mon May 27 12:11:38 2013 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Mon, 27 May 2013 12:11:38 -0700 Subject: Signature.getAlogrithm return null in special case In-Reply-To: <519B3969.3020807@linux.vnet.ibm.com> References: <5191C1B2.4030900@linux.vnet.ibm.com> <5192D6C7.6050900@oracle.com> <519B3969.3020807@linux.vnet.ibm.com> Message-ID: <51A3AFEA.3090406@oracle.com> Hi Deven, I just got back from a short break, hope to return back to this shortly. I tweaked your test a bit before I left, but the builds were failing (unrelated issue) so I couldn't check in. Still need to check the actual Signature code for a couple things, but I think it's ok. Brad On 5/21/2013 2:07 AM, Deven You wrote: > Hi Brad, > > Thanks for your reply, is there any progress on this problem? > > I see the last comments on JDK-8014620 is six days before. > > Thanks a lot! > > On 05/15/2013 08:28 AM, Brad Wetmore wrote: >> Offhand, this seems reasonable. >> >> Since you are an OpenJDK author, I've filed: >> >> JDK-8014620: Signature.getAlogrithm return null in special case >> >> and stocked it with your patch. >> >> Thanks, >> >> Brad >> >> >> On 5/13/2013 9:46 PM, Deven You wrote: >>> Hi All, >>> >>> I find in a special case: If you create a SignatureSpi service through >>> extending Signature rather than SignatureSpi, the returned signature >>> instance will lose its algortithm name. >>> >>> Though the fix[1] is simple I think it's valuable. Could anyone take >>> a look? >>> >>> [1] http://cr.openjdk.java.net/~youdwei/ojdk-809/webrev/ >>> >>> >>> Thanks a lot >> > From weijun.wang at oracle.com Tue May 28 01:45:26 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 28 May 2013 16:45:26 +0800 Subject: Code review request: 8001326: Improve Kerberos replay caching Message-ID: <51A46EA6.3090100@oracle.com> Please review the code changes at http://cr.openjdk.java.net/~weijun/8001326/webrev.00/ Two new system properties are introduced. sun.security.krb5.rcache to control what rcache type should be used. Besides the original one (which does not need this system property to be set), we support dfl and none now. Also, sun.security.krb5.acceptor.subkey can be set to true to let acceptor generate a sub-key, so that even if a replayed authenticator is not detected, a replayed message won't work. Thanks Max From vincent.x.ryan at oracle.com Tue May 28 04:30:13 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 28 May 2013 12:30:13 +0100 Subject: [8] 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate Message-ID: Please review the fix for: http://bugs.sun.com/view_bug.do?bug_id=7174966 The problem occurs when validating the signature of an OCSP response from the Comodo CA. The Signature class tests for the presence of the digitalSignature keyUsage setting when examining a signer's certificate. One solution is for the sun.security.provider.certpath.OCSPResponse class to pass the signer's public key rather than the signer's certificate. Webrev: http://cr.openjdk.java.net/~vinnie/7174966/webrev.00/ Thanks. From vicente.romero at oracle.com Tue May 28 04:46:48 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 28 May 2013 11:46:48 +0000 Subject: hg: jdk8/tl/langtools: 6970173: Debug pointer at bad position Message-ID: <20130528114652.D07EF48D80@hg.openjdk.java.net> Changeset: c6df5b20f9eb Author: vromero Date: 2013-05-28 12:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c6df5b20f9eb 6970173: Debug pointer at bad position Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/T6970173/DebugPointerAtBadPositionTest.java From tomas at primekey.se Tue May 28 06:39:13 2013 From: tomas at primekey.se (Tomas Gustavsson) Date: Tue, 28 May 2013 15:39:13 +0200 Subject: Status of old sun tracker issues? In-Reply-To: <51A378C7.9080706@oracle.com> References: <51A319E2.6020201@primekey.se> <51A378C7.9080706@oracle.com> Message-ID: <51A4B381.7010009@primekey.se> Awesome. Thanks for the info! On 05/27/2013 05:16 PM, Se?n Coffey wrote: > A JIRA system is now the system of record for OpenJDK issues.[1] > > Work on getting that system open to external audience is ongoing. In the > meantime you can reference the bug via bugs.sun.com : > > http://bugs.sun.com/view_bug.do?bug_id=7007966 > > regards, > Sean. > > [1] https://blogs.oracle.com/darcy/entry/milestone_jira_system_of_record > > On 27/05/13 09:31, Tomas Gustavsson wrote: >> >> Hi, >> >> What is the master issue tracker for OpenJDK these days? >> We have reported https://bugs.openjdk.java.net/show_bug.cgi?id=100162 >> Which is closed referencing a "sun bug" id. Is the oracle tracker >> (which was off line for a long time) the main issue tracker for >> OpenJDK still? >> >> Cheers, >> Tomas Gustavsson > From dmitry.samersoff at oracle.com Tue May 28 07:47:20 2013 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Tue, 28 May 2013 14:47:20 +0000 Subject: hg: jdk8/tl/jdk: 8014420: Default JDP address does not match the one assigned by IANA Message-ID: <20130528144753.CA50E48D8D@hg.openjdk.java.net> Changeset: 7d7bfce34a79 Author: dsamersoff Date: 2013-05-28 18:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d7bfce34a79 8014420: Default JDP address does not match the one assigned by IANA Summary: JDP protocol defaults changed to IANA assigned values Reviewed-by: dholmes, jbachorik, hirt Contributed-by: fweimer at redhat.com ! src/share/classes/sun/management/Agent.java ! src/share/classes/sun/management/jdp/package-info.java ! test/sun/management/jdp/JdpTest.sh From rob.mckenna at oracle.com Tue May 28 08:35:11 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Tue, 28 May 2013 15:35:11 +0000 Subject: hg: jdk8/tl/jdk: 7038105: File.isHidden() should return true for pagefile.sys and hiberfil.sys Message-ID: <20130528153537.D27B148D8F@hg.openjdk.java.net> Changeset: b16a8b4ae6b4 Author: robm Date: 2013-05-28 16:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b16a8b4ae6b4 7038105: File.isHidden() should return true for pagefile.sys and hiberfil.sys Reviewed-by: alanb ! src/windows/native/java/io/WinNTFileSystem_md.c ! test/java/io/File/IsHidden.java From vicente.romero at oracle.com Tue May 28 09:40:30 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 28 May 2013 16:40:30 +0000 Subject: hg: jdk8/tl/langtools: 8012333: javac, ClassFile should have a read(Path) method Message-ID: <20130528164037.CB39048D96@hg.openjdk.java.net> Changeset: d042cba65eab Author: vromero Date: 2013-05-28 17:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d042cba65eab 8012333: javac, ClassFile should have a read(Path) method Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/ClassFile.java From alexey.utkin at oracle.com Mon May 27 04:26:54 2013 From: alexey.utkin at oracle.com (alexey.utkin at oracle.com) Date: Mon, 27 May 2013 11:26:54 +0000 Subject: hg: jdk8/tl/jdk: 8014394: (fs) WatchService failing when watching \\server\$d Message-ID: <20130527112721.034A448D58@hg.openjdk.java.net> Changeset: d78f91ab0e96 Author: uta Date: 2013-05-27 15:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d78f91ab0e96 8014394: (fs) WatchService failing when watching \\server\$d Reviewed-by: alanb ! src/windows/classes/sun/nio/fs/WindowsConstants.java ! src/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java ! src/windows/classes/sun/nio/fs/WindowsWatchService.java ! src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c From jaroslav.bachorik at oracle.com Tue May 28 07:06:25 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Tue, 28 May 2013 14:06:25 +0000 Subject: hg: jdk8/tl/jdk: 8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows Message-ID: <20130528140637.E54C248D8B@hg.openjdk.java.net> Changeset: 7d9fab5d86cd Author: jbachorik Date: 2013-05-28 15:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d9fab5d86cd 8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows Reviewed-by: chegar, smarks, dfuchs ! test/ProblemList.txt ! test/com/sun/jmx/remote/NotificationMarshalVersions/Client/Client.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Server.java + test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java - test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh From xueming.shen at oracle.com Tue May 28 10:45:00 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 28 May 2013 17:45:00 +0000 Subject: hg: jdk8/tl/jdk: 8001750: CharsetDecoder.replacement should not be changeable except via replaceWith method Message-ID: <20130528174551.2A37B48D9A@hg.openjdk.java.net> Changeset: 7fa2d1dcb8f6 Author: sherman Date: 2013-05-28 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7fa2d1dcb8f6 8001750: CharsetDecoder.replacement should not be changeable except via replaceWith method Summary: to make defensive copy for set/get replacement byte array Reviewed-by: martin ! src/share/classes/java/nio/charset/Charset-X-Coder.java.template ! src/share/classes/sun/nio/cs/UTF_8.java ! src/share/classes/sun/nio/cs/ext/DoubleByte.java ! src/share/classes/sun/nio/cs/ext/HKSCS.java From christophe.ravel at oracle.com Tue May 28 11:23:31 2013 From: christophe.ravel at oracle.com (Christophe Ravel) Date: Tue, 28 May 2013 11:23:31 -0700 Subject: PATCH: possible bug in OCSP check In-Reply-To: <519F3377.9000902@yahoo.es> References: <519F3377.9000902@yahoo.es> Message-ID: <51A4F623.9070005@oracle.com> Is there a bug open for this issue ? Regards, Christophe. > Ricardo Martin Camarero > May 24, 2013 2:31 AM > Hi everybody, > > I have been struggling for some months with a weird issue about how Java > validates OCSP responses. Following the RFC2560 standard the responses > sent by the responder should be signed following one of these three > > In current java implementation (openjdk 6, 7 and 8) the case (1) and (3) > are considered by default and case (2) can be configured using some > properties ("ocsp.responderCertSubjectName" for example). But the > problem is that both configurations are exclusive, if your application > accepts responses for the cases (1) and (3) it fails with the case (2) > and vice-versa. > > I faced an OCSP responder that in some cases it answered using the case > (1) and in others using the case (2). The case (1) was used to sign > responses for their own certificates and the case (2) was used to sign > responses for foreign certificates (spanish national id certificates > specifically). I'm not completely sure if the standard admits this > situation but I haven't read anything against that. Besides why not to > take the configured certificate ("ocsp.responderCertSubjectName" or any > of the other properties) as a failback and not as the unique valid signer. > > Looking at the code the problem is that only one certificate is passed > as the valid signer for responses (the one configured via properties or > the issuer cert). Following Andrew advise I have made a little patch > against current openjdk-8 that just considers both of them (OCSPResponse > class receives both certs and this way can check the three cases). > > Thanks in advance! -- Christophe Ravel | Principal Member of Technical Staff | +1.650.506.2162 OracleJava SQE - Security 4220 Network Circle, Office 2140, Santa Clara, CA 95054 -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130528/8336dd68/attachment-0001.html -------------- next part -------------- A non-text attachment was scrubbed... Name: compose-unknown-contact.jpg Type: image/jpeg Size: 770 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130528/8336dd68/compose-unknown-contact-0001.jpg From naoto.sato at oracle.com Tue May 28 14:03:16 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 28 May 2013 21:03:16 +0000 Subject: hg: jdk8/tl/jdk: 6251788: (rb) PropertyResourceBundle doesn't document exceptions Message-ID: <20130528210343.3E15D48DA6@hg.openjdk.java.net> Changeset: b99d56d1aa3f Author: naoto Date: 2013-05-28 14:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b99d56d1aa3f 6251788: (rb) PropertyResourceBundle doesn't document exceptions Reviewed-by: okutsu ! src/share/classes/java/util/PropertyResourceBundle.java From ricardo_martin_camarero at yahoo.es Tue May 28 13:08:48 2013 From: ricardo_martin_camarero at yahoo.es (Ricardo Martin Camarero) Date: Tue, 28 May 2013 22:08:48 +0200 Subject: PATCH: possible bug in OCSP check In-Reply-To: <51A4F623.9070005@oracle.com> References: <519F3377.9000902@yahoo.es> <51A4F623.9070005@oracle.com> Message-ID: <51A50ED0.4080508@yahoo.es> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130528/fb432634/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: compose-unknown-contact.jpg Type: image/jpeg Size: 770 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130528/fb432634/compose-unknown-contact.jpg From xuelei.fan at oracle.com Tue May 28 17:55:25 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 29 May 2013 08:55:25 +0800 Subject: PATCH: possible bug in OCSP check In-Reply-To: <51A50ED0.4080508@yahoo.es> References: <519F3377.9000902@yahoo.es> <51A4F623.9070005@oracle.com> <51A50ED0.4080508@yahoo.es> Message-ID: <51A551FD.6040705@oracle.com> I just open a new bug JDK-8015571 for it. Thanks, Xuelei On 5/29/2013 4:08 AM, Ricardo Martin Camarero wrote: > Hi Christophe, > > I opened one some months ago (it was opened against openjdk 6). I > received an email saying the the bug has been accepted with the Bug Id: > 9000381 but the bug was never public. > > Regards! > > > On 05/28/2013 08:23 PM, Christophe Ravel wrote: >> Is there a bug open for this issue ? >> >> Regards, >> Christophe. >> >>> Ricardo Martin Camarero >>> May 24, 2013 2:31 AM >>> Hi everybody, >>> >>> I have been struggling for some months with a weird issue about how Java >>> validates OCSP responses. Following the RFC2560 standard the responses >>> sent by the responder should be signed following one of these three >>> >>> In current java implementation (openjdk 6, 7 and 8) the case (1) and (3) >>> are considered by default and case (2) can be configured using some >>> properties ("ocsp.responderCertSubjectName" for example). But the >>> problem is that both configurations are exclusive, if your application >>> accepts responses for the cases (1) and (3) it fails with the case (2) >>> and vice-versa. >>> >>> I faced an OCSP responder that in some cases it answered using the case >>> (1) and in others using the case (2). The case (1) was used to sign >>> responses for their own certificates and the case (2) was used to sign >>> responses for foreign certificates (spanish national id certificates >>> specifically). I'm not completely sure if the standard admits this >>> situation but I haven't read anything against that. Besides why not to >>> take the configured certificate ("ocsp.responderCertSubjectName" or any >>> of the other properties) as a failback and not as the unique valid >>> signer. >>> >>> Looking at the code the problem is that only one certificate is passed >>> as the valid signer for responses (the one configured via properties or >>> the issuer cert). Following Andrew advise I have made a little patch >>> against current openjdk-8 that just considers both of them (OCSPResponse >>> class receives both certs and this way can check the three cases). >>> >>> Thanks in advance! >> >> -- >> Christophe Ravel | Principal Member of Technical Staff | +1.650.506.2162 >> Oracle Java SQE - Security >> 4220 Network Circle, Office 2140, Santa Clara, CA 95054 >> From xuelei.fan at oracle.com Tue May 28 18:16:09 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 29 May 2013 09:16:09 +0800 Subject: PATCH: possible bug in OCSP check In-Reply-To: <519F3377.9000902@yahoo.es> References: <519F3377.9000902@yahoo.es> Message-ID: <51A556D9.2030601@oracle.com> Hi Ricardo, Have you or your organization signed the signed the Oracle Contributor Agreement (OCA) per the request of OpenJDK bylaws? http://openjdk.java.net/bylaws#_2 Thanks, Xuelei On 5/24/2013 5:31 PM, Ricardo Martin Camarero wrote: > Hi everybody, > > I have been struggling for some months with a weird issue about how Java > validates OCSP responses. Following the RFC2560 standard the responses > sent by the responder should be signed following one of these three > possibilities: > >> All definitive response messages SHALL be digitally signed. The key >> used to sign the response MUST belong to one of the following: >> >> -- the CA who issued the certificate in question >> -- a Trusted Responder whose public key is trusted by the requester >> -- a CA Designated Responder (Authorized Responder) who holds a >> specially marked certificate issued directly by the CA, indicating >> that the responder may issue OCSP responses for that CA > > In current java implementation (openjdk 6, 7 and 8) the case (1) and (3) > are considered by default and case (2) can be configured using some > properties ("ocsp.responderCertSubjectName" for example). But the > problem is that both configurations are exclusive, if your application > accepts responses for the cases (1) and (3) it fails with the case (2) > and vice-versa. > > I faced an OCSP responder that in some cases it answered using the case > (1) and in others using the case (2). The case (1) was used to sign > responses for their own certificates and the case (2) was used to sign > responses for foreign certificates (spanish national id certificates > specifically). I'm not completely sure if the standard admits this > situation but I haven't read anything against that. Besides why not to > take the configured certificate ("ocsp.responderCertSubjectName" or any > of the other properties) as a failback and not as the unique valid signer. > > Looking at the code the problem is that only one certificate is passed > as the valid signer for responses (the one configured via properties or > the issuer cert). Following Andrew advise I have made a little patch > against current openjdk-8 that just considers both of them (OCSPResponse > class receives both certs and this way can check the three cases). > > Thanks in advance! > From valerie.peng at oracle.com Tue May 28 18:25:48 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 28 May 2013 18:25:48 -0700 Subject: Code Review Request for 7196805: DH Key interoperability testing between SunJCE and JsafeJCE not successful Message-ID: <51A5591C.6080006@oracle.com> Vinnie, Can you help reviewing my fix for 7196805 "DH Key interoperability testing between SunJCE and JsafeJCE not successful"? In SunJCE provider, the equality check for DH private/public keys is based on DER encoding which may not be correct all the time due to the optional L value defined in the DER syntax. In addition, JsafeJCE provider sometimes encode the optional L value incorrectly which leads to unexpected IOException when parsing the DER bytes. I have changed the comparison to based on component values rather than DER encodings which may vary due to the presence or missing of optional values. In addition, I made the changes to DHKeyPairGenerator to ensure that generated private value has the requested length/size. Webrev: http://cr.openjdk.java.net/~valeriep/7196805/webrev.00/ Thanks, Valerie From xuelei.fan at oracle.com Tue May 28 18:48:31 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 29 May 2013 01:48:31 +0000 Subject: hg: jdk8/tl/jdk: 8010815: some constructors issues in com.sun.jndi.toolkit Message-ID: <20130529014906.C8A5548DBA@hg.openjdk.java.net> Changeset: 1652a22cf6e7 Author: xuelei Date: 2013-05-28 18:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1652a22cf6e7 8010815: some constructors issues in com.sun.jndi.toolkit Reviewed-by: alanb ! src/share/classes/com/sun/jndi/toolkit/ctx/Continuation.java ! src/share/classes/com/sun/jndi/toolkit/dir/LazySearchEnumerationImpl.java ! src/share/classes/com/sun/jndi/toolkit/url/GenericURLContext.java From dan.xu at oracle.com Tue May 28 22:25:24 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Wed, 29 May 2013 05:25:24 +0000 Subject: hg: jdk8/tl/jdk: 8009258: TEST_BUG:java/io/pathNames/GeneralWin32.java fails intermittently Message-ID: <20130529052537.1FE4848DBF@hg.openjdk.java.net> Changeset: e59d7f0f36f7 Author: ewang Date: 2013-05-28 22:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e59d7f0f36f7 8009258: TEST_BUG:java/io/pathNames/GeneralWin32.java fails intermittently Reviewed-by: dxu, alanb Contributed-by: yiming.wang at oracle.com ! test/java/io/pathNames/General.java ! test/java/io/pathNames/GeneralWin32.java From jeffrey.nisewanger at oracle.com Tue May 28 22:56:54 2013 From: jeffrey.nisewanger at oracle.com (Jeff Nisewanger) Date: Tue, 28 May 2013 22:56:54 -0700 Subject: Code Review Request: JEP 140 Limited doPrivileged Message-ID: <51A598A6.7040505@oracle.com> This is the implementation of the JEP 140 feature for a limited privilege form of doPrivileged(). A test will be added in an updated webrev within the next day. The JEP is: http://openjdk.java.net/jeps/140 The webrev is: http://cr.openjdk.java.net/~jdn/8014097/webrev.0/ From pe at iki.fi Wed May 29 00:33:53 2013 From: pe at iki.fi (Pasi Eronen) Date: Wed, 29 May 2013 10:33:53 +0300 Subject: 9001039?: DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times In-Reply-To: <519DF1FD.2060206@oracle.com> References: <51949143.2020208@oracle.com> <519C2ECD.7040207@oracle.com> <62927056.6480176.1369303429423.JavaMail.root@redhat.com> <519DF1FD.2060206@oracle.com> Message-ID: Hi Xuelei, I did notice that P11Util has a trimZeroes() function, but I didn't call it since I didn't want to add a new package dependency. But now that you mention it, moving it to KeyUtil seems like the best solution. I have submitted a revised patch to the Bugzilla ticket which does just this: https://bugs.openjdk.java.net/attachment.cgi?id=307&action=diff Best regards, Pasi On Thu, May 23, 2013 at 1:39 PM, Xuelei Fan wrote: > > On 5/23/2013 6:03 PM, Andrew Hughes wrote: > > ----- Original Message ----- > >> On 5/20/2013 5:28 PM, Pasi Eronen wrote: > >>> Hi Xuelei, > >>> > >>> It seems the PKSC11 doesn't actually have this bug. > >>> > >>> P11KeyAgreement has a separate code path for the "TlsPremasterSecret" > >>> algorithm, which strips leading zeroes if the key can be extracted from > >>> the token. (And if the key cannot be extracted, then the token is doing > >>> the premaster secret->master secret computation, and has to do the > >>> stripping -- it can't be done from the Java PKSC11 provider.) > >>> > >> It makes sense to me. > >> > >>> To make sure this behavior doesn't change, I added a test case > >>> for the PKSC11 provider to the Bugzilla (which passes with the > >>> "SunPKCS11-NSS" provider without any changes). > >>> > >> That's great. Would you mind to contribute the regression test for > >> PKCS11 provider? > >> > > > > It's been attached to the bug report: > https://bugs.openjdk.java.net/show_bug.cgi?id=100316 > > > Thanks Andrew! > > > Is there any reason the original patch can't be committed? I haven't > seen any mentioned. > > > It is accepted. The minor comment I mentioned in the previous mail is > that we may want to merge the functions to trim leading zeros in one > method. > > There is a method sun.security.pkcs11.P11Util.trimZeroes(byte[] b) which > is used to trim leading zeros. I think it would be nice to move the > method to sun.security.util.KeyUtil, and make use of this method in the > patch of DHKeyAgreement.engineGenerateSecret(String algorithm) as well. > > Pasi, what do you think? > > Otherwise, the patch looks fine to me. > > I can be the sponsor if you won't able to merge the changes into openJDk > workspace. > > Thanks, > Xuelei > > >> Thanks, > >> Xuelei > >> > >>> Best regards, > >>> Pasi > >>> > >>> > >>> > >>> On Thu, May 16, 2013 at 10:56 AM, Xuelei Fan >>> > wrote: > >>> > >>> Hi Pasi, > >>> > >>> Thank you for your patience, and contribution to OpenJDK. The bug > is > >>> accepted, and you should be able to review it at: > >>> > >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014618 > >>> > >>> Let's use the above bug ID to track the issue. > >>> > >>> Your patch looks fine in general (I may have some very minor > comments > >>> later). We also have similar problems in PKCS11 provider because > of > >>> the > >>> update of P11KeyAgreement.java in changeset: > >>> > >>> > http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 > >>> > >>> Would you like to also fix it in your patch? > >>> > >>> Thanks again for your nice work. > >>> > >>> Regards, > >>> Xuelei > >>> > >>> > >>> On 5/10/2013 5:00 PM, Pasi Eronen wrote: > >>> > AKA "1 out of 256 SSL/TLS handshakes fails with DHE cipher > suites" > >>> > > >>> > I reported this bug over a month of ago, but for some reason, > it's > >>> > not > >>> > yet visible at bugs.sun.com > >>> . I've included the bug > >>> > report below just in > >>> > case. > >>> > > >>> > It seems this commit from March 2012 inadvertently broke SSL/TLS > DHE > >>> > cipher suites, causing the SSL/TLS handshake to fail > approximately > >>> > 1 out of 256 times: > >>> > > >>> > http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 > >>> > > >>> > The commit was done to fix this bug: > >>> > > >>> > http://bugs.sun.com/view_bug.do?bug_id=7146728 > >>> > > >>> > While generating a secret of the same length as modulus may be > the > >>> right > >>> > choice generally speaking (and it's what e.g. IPsec uses), > SSL/TLS > >>> uses > >>> > a different convention: leading zeroes must be stripped. > >>> > > >>> > This is currently blocking us from updating our production > systems to > >>> > Java 7, so although I have not contributed to OpenJDK before, I'd > >>> > like > >>> > to submit a patch and a test case for this (I've signed the OCA > >>> > already). But before I do this, I'd like to check that the > approach > >>> > is > >>> > agreeable. > >>> > > >>> > We have a separate "algorithm" value "TlsPremasterSecret", so > >>> > behavior for other cases could stay the same. Would a patch > >>> > like this: > >>> > > >>> > } else if (algorithm.equals("TlsPremasterSecret")) { > >>> > // remove leading zero bytes per RFC 5246 Section 8.1.2 > >>> > int i = 0; > >>> > while ((i < secret.length - 1) && (secret[i] == 0)) { > >>> > i++; > >>> > } > >>> > if (i == 0) { > >>> > return new SecretKeySpec(secret, > "TlsPremasterSecret"); > >>> > } else { > >>> > byte[] secret2 = new byte[secret.length - i]; > >>> > System.arraycopy(secret, i, secret2, 0, > secret2.length); > >>> > return new SecretKeySpec(secret2, > "TlsPremasterSecret"); > >>> > } > >>> > } > >>> > > >>> > Plus a test case (with fixed keys) that checks that leading zero > is > >>> > stripped > >>> > for TlsPremasterSecret and is not stripped otherwise, be > sufficient? > >>> > > >>> > Best regards, > >>> > Pasi > >>> > > >>> > ---snip--- > >>> > > >>> > Synopsis: > >>> > DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 > times > >>> > > >>> > Full OS version: > >>> > Tested on Windows 7 (Microsoft Windows [Version 6.1.7601]), but > >>> occurs in > >>> > e..g OpenJDK 7 as well. > >>> > > >>> > Development Kit or Runtime version: > >>> > java version "1.7.0_17" > >>> > Java(TM) SE Runtime Environment (build 1.7.0_17-b02) > >>> > Java HotSpot(TM) Client VM (build 23.7-b01, mixed mode, sharing) > >>> > > >>> > Description: > >>> > When performing Diffie-Hellman key agreement for SSL/TLS, the TLS > >>> > specification (RFC 5246) says that "Leading bytes of Z that > >>> contain all zero > >>> > bits are stripped before it is used as the pre_master_secret." > >>> > > >>> > However, com.sun.crypto.provider.DHKeyAgreement.java does not > >>> strip leading > >>> > zero bytes. This causes approximately 1 out 256 SSL/TLS > handshakes > >>> with > >>> > DH/DHE cipher suites to fail (when the leading byte happens, by > >>> chance, to > >>> > be zero). > >>> > > >>> > Steps to Reproduce: > >>> > 1. Start a simple JSSE socket server with -Djavax.net.debug=all. > >>> > > >>> > 2. Connect to the server with e.g. OpenSSL command line tool, > >>> ensuring that > >>> > DHE cipher suite gets selected (e.g. "openssl s_client -cipher > >>> > DHE-RSA-AES128-SHA -connect 192.168.81.1:9999 > >>> > >>> > ") repeatedly. Other SSL > >>> > clients can be used -- this is not an OpenSSL bug (see below). > >>> > > >>> > 3. Repeat the connection. After a couple of hundred successful > >>> connections, > >>> > the connection will fail with handshake_failure alert. > >>> > > >>> > 4. Examine the JSSE debug logs produced by the server: the failed > >>> connection > >>> > will have a PreMaster secret that begins with zero byte > >>> > (while all other connections have non-zero byte here). For > example: > >>> > > >>> > SESSION KEYGEN: > >>> > PreMaster Secret: > >>> > 0000: 00 70 C5 7E 91 38 C8 DE ED 75 3D 76 8A B5 44 69 > >>> .p...8...u=v..Di > >>> > 0010: E7 32 1C EE 80 77 50 C7 A9 51 24 2E E3 15 11 30 > >>> .2...wP..Q$....0 > >>> > 0020: 9D F6 9F BC 9D EB 5C 18 F7 A4 19 ED 1A AC 2E 0C > >>> ......\......... > >>> > 0030: E3 18 C5 11 B1 80 07 7D B1 C6 70 A8 D7 EB CF DD > >>> ..........p..... > >>> > 0040: 2D B5 1D BC 01 3E 28 2A 2B 5B 38 8F EB 20 F2 A2 > >>> -....>(*+[8.. .. > >>> > 0050: 00 07 47 F7 87 B8 99 CB EF B4 13 04 C8 8B 82 FB > >>> ..G............. > >>> > > >>> > Expected Result: > >>> > Expected result is that every connection succeed. > >>> > > >>> > Actual Result: > >>> > Roughly one out of 256 connections fail. > >>> > > >>> > Source code for an executable test case: > >>> > > >>> > Java server: > >>> > > >>> > import javax.net.ssl.SSLServerSocket; > >>> > import javax.net.ssl.SSLServerSocketFactory; > >>> > import javax.net.ssl.SSLSocket; > >>> > > >>> > public class TestServer { > >>> > public static void main(String args[]) throws Exception { > >>> > SSLServerSocketFactory ssf = (SSLServerSocketFactory) > >>> > SSLServerSocketFactory.getDefault(); > >>> > SSLServerSocket ss = (SSLServerSocket) > >>> ssf.createServerSocket(9999); > >>> > System.out.println("Listening on port 9999"); > >>> > for (String cs : ss.getEnabledCipherSuites()) { > >>> > System.out.println(cs); > >>> > } > >>> > while (true) { > >>> > SSLSocket s = (SSLSocket) ss.accept(); > >>> > System.out.println("Connected with > >>> > "+s.getSession().getCipherSuite()); > >>> > s.close(); > >>> > } > >>> > } > >>> > } > >>> > > >>> > Run as as follows: > >>> > > >>> > keytool -storepass "password" -keypass "password" -genkey > -keyalg RSA > >>> > -keystore test_keystore.jks -dname CN=test > >>> > javac TestServer.java > >>> > java -Djavax.net.debug=all > >>> -Djavax.net.ssl.keyStore=./test_keystore.jks > >>> > -Djavax.net.ssl.keyStorePassword=password TestServer > >>> > > >>> > OpenSSL client: > >>> > > >>> > set -e > >>> > while true; do > >>> > openssl s_client -cipher DHE-RSA-AES128-SHA -connect > >>> 127.0.0.1:9999 > >>> > -quiet -no_ign_eof < /dev/null > >>> > done > >>> > > >>> > Workaround: > >>> > Disable Diffie-Hellman cipher suites. > >>> > > >>> > ---snip--- > >>> > > >>> > >>> > >> > >> > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20130529/682035e3/attachment.html From xuelei.fan at oracle.com Wed May 29 01:14:52 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 29 May 2013 16:14:52 +0800 Subject: 9001039?: DHKeyAgreement calculates wrong TlsPremasterSecret 1 out of 256 times In-Reply-To: References: <51949143.2020208@oracle.com> <519C2ECD.7040207@oracle.com> <62927056.6480176.1369303429423.JavaMail.root@redhat.com> <519DF1FD.2060206@oracle.com> Message-ID: <51A5B8FC.90105@oracle.com> Thank you for considering this improvement. I'm planing to integrate the patch into OpenJDK workspace this week. Thanks & Regards, Xuelei On 5/29/2013 3:33 PM, Pasi Eronen wrote: > Hi Xuelei, > > I did notice that P11Util has a trimZeroes() function, but I didn't call > it since I didn't want to add a new package dependency. But now that you > mention it, moving it to KeyUtil seems like the best solution. > > I have submitted a revised patch to the Bugzilla ticket which does > just this: > > https://bugs.openjdk.java.net/attachment.cgi?id=307&action=diff > > Best regards, > Pasi > > > > On Thu, May 23, 2013 at 1:39 PM, Xuelei Fan > wrote: > > > On 5/23/2013 6:03 PM, Andrew Hughes wrote: > > ----- Original Message ----- > >> On 5/20/2013 5:28 PM, Pasi Eronen wrote: > >>> Hi Xuelei, > >>> > >>> It seems the PKSC11 doesn't actually have this bug. > >>> > >>> P11KeyAgreement has a separate code path for the > "TlsPremasterSecret" > >>> algorithm, which strips leading zeroes if the key can be > extracted from > >>> the token. (And if the key cannot be extracted, then the token > is doing > >>> the premaster secret->master secret computation, and has to do the > >>> stripping -- it can't be done from the Java PKSC11 provider.) > >>> > >> It makes sense to me. > >> > >>> To make sure this behavior doesn't change, I added a test case > >>> for the PKSC11 provider to the Bugzilla (which passes with the > >>> "SunPKCS11-NSS" provider without any changes). > >>> > >> That's great. Would you mind to contribute the regression test for > >> PKCS11 provider? > >> > > > > It's been attached to the bug report: > https://bugs.openjdk.java.net/show_bug.cgi?id=100316 > > > Thanks Andrew! > > > Is there any reason the original patch can't be committed? I > haven't seen any mentioned. > > > It is accepted. The minor comment I mentioned in the previous mail is > that we may want to merge the functions to trim leading zeros in one > method. > > There is a method sun.security.pkcs11.P11Util.trimZeroes(byte[] b) which > is used to trim leading zeros. I think it would be nice to move the > method to sun.security.util.KeyUtil, and make use of this method in the > patch of DHKeyAgreement.engineGenerateSecret(String algorithm) as well. > > Pasi, what do you think? > > Otherwise, the patch looks fine to me. > > I can be the sponsor if you won't able to merge the changes into openJDk > workspace. > > Thanks, > Xuelei > > >> Thanks, > >> Xuelei > >> > >>> Best regards, > >>> Pasi > >>> > >>> > >>> > >>> On Thu, May 16, 2013 at 10:56 AM, Xuelei Fan > > >>> >> > wrote: > >>> > >>> Hi Pasi, > >>> > >>> Thank you for your patience, and contribution to OpenJDK. > The bug is > >>> accepted, and you should be able to review it at: > >>> > >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014618 > >>> > >>> Let's use the above bug ID to track the issue. > >>> > >>> Your patch looks fine in general (I may have some very minor > comments > >>> later). We also have similar problems in PKCS11 provider > because of > >>> the > >>> update of P11KeyAgreement.java in changeset: > >>> > >>> > http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 > >>> > >>> Would you like to also fix it in your patch? > >>> > >>> Thanks again for your nice work. > >>> > >>> Regards, > >>> Xuelei > >>> > >>> > >>> On 5/10/2013 5:00 PM, Pasi Eronen wrote: > >>> > AKA "1 out of 256 SSL/TLS handshakes fails with DHE cipher > suites" > >>> > > >>> > I reported this bug over a month of ago, but for some > reason, it's > >>> > not > >>> > yet visible at bugs.sun.com > > >>> . I've included the bug > >>> > report below just in > >>> > case. > >>> > > >>> > It seems this commit from March 2012 inadvertently broke > SSL/TLS DHE > >>> > cipher suites, causing the SSL/TLS handshake to fail > approximately > >>> > 1 out of 256 times: > >>> > > >>> > > http://hg.openjdk.java.net/jdk7u/jdk7u-gate/jdk/rev/e574e475c8a6 > >>> > > >>> > The commit was done to fix this bug: > >>> > > >>> > http://bugs.sun.com/view_bug.do?bug_id=7146728 > >>> > > >>> > While generating a secret of the same length as modulus > may be the > >>> right > >>> > choice generally speaking (and it's what e.g. IPsec uses), > SSL/TLS > >>> uses > >>> > a different convention: leading zeroes must be stripped. > >>> > > >>> > This is currently blocking us from updating our production > systems to > >>> > Java 7, so although I have not contributed to OpenJDK > before, I'd > >>> > like > >>> > to submit a patch and a test case for this (I've signed > the OCA > >>> > already). But before I do this, I'd like to check that the > approach > >>> > is > >>> > agreeable. > >>> > > >>> > We have a separate "algorithm" value "TlsPremasterSecret", so > >>> > behavior for other cases could stay the same. Would a patch > >>> > like this: > >>> > > >>> > } else if (algorithm.equals("TlsPremasterSecret")) { > >>> > // remove leading zero bytes per RFC 5246 Section > 8.1.2 > >>> > int i = 0; > >>> > while ((i < secret.length - 1) && (secret[i] == 0)) { > >>> > i++; > >>> > } > >>> > if (i == 0) { > >>> > return new SecretKeySpec(secret, > "TlsPremasterSecret"); > >>> > } else { > >>> > byte[] secret2 = new byte[secret.length - i]; > >>> > System.arraycopy(secret, i, secret2, 0, > secret2.length); > >>> > return new SecretKeySpec(secret2, > "TlsPremasterSecret"); > >>> > } > >>> > } > >>> > > >>> > Plus a test case (with fixed keys) that checks that > leading zero is > >>> > stripped > >>> > for TlsPremasterSecret and is not stripped otherwise, be > sufficient? > >>> > > >>> > Best regards, > >>> > Pasi > >>> > > >>> > ---snip--- > >>> > > >>> > Synopsis: > >>> > DHKeyAgreement calculates wrong TlsPremasterSecret 1 out > of 256 times > >>> > > >>> > Full OS version: > >>> > Tested on Windows 7 (Microsoft Windows [Version > 6.1.7601]), but > >>> occurs in > >>> > e..g OpenJDK 7 as well. > >>> > > >>> > Development Kit or Runtime version: > >>> > java version "1.7.0_17" > >>> > Java(TM) SE Runtime Environment (build 1.7.0_17-b02) > >>> > Java HotSpot(TM) Client VM (build 23.7-b01, mixed mode, > sharing) > >>> > > >>> > Description: > >>> > When performing Diffie-Hellman key agreement for SSL/TLS, > the TLS > >>> > specification (RFC 5246) says that "Leading bytes of Z that > >>> contain all zero > >>> > bits are stripped before it is used as the pre_master_secret." > >>> > > >>> > However, com.sun.crypto.provider.DHKeyAgreement.java does not > >>> strip leading > >>> > zero bytes. This causes approximately 1 out 256 SSL/TLS > handshakes > >>> with > >>> > DH/DHE cipher suites to fail (when the leading byte > happens, by > >>> chance, to > >>> > be zero). > >>> > > >>> > Steps to Reproduce: > >>> > 1. Start a simple JSSE socket server with > -Djavax.net.debug=all. > >>> > > >>> > 2. Connect to the server with e.g. OpenSSL command line tool, > >>> ensuring that > >>> > DHE cipher suite gets selected (e.g. "openssl s_client -cipher > >>> > DHE-RSA-AES128-SHA -connect 192.168.81.1:9999 > > >>> > >>> > ") repeatedly. Other SSL > >>> > clients can be used -- this is not an OpenSSL bug (see below). > >>> > > >>> > 3. Repeat the connection. After a couple of hundred successful > >>> connections, > >>> > the connection will fail with handshake_failure alert. > >>> > > >>> > 4. Examine the JSSE debug logs produced by the server: the > failed > >>> connection > >>> > will have a PreMaster secret that begins with zero byte > >>> > (while all other connections have non-zero byte here). For > example: > >>> > > >>> > SESSION KEYGEN: > >>> > PreMaster Secret: > >>> > 0000: 00 70 C5 7E 91 38 C8 DE ED 75 3D 76 8A B5 44 69 > >>> .p...8...u=v..Di > >>> > 0010: E7 32 1C EE 80 77 50 C7 A9 51 24 2E E3 15 11 30 > >>> .2...wP..Q$....0 > >>> > 0020: 9D F6 9F BC 9D EB 5C 18 F7 A4 19 ED 1A AC 2E 0C > >>> ......\......... > >>> > 0030: E3 18 C5 11 B1 80 07 7D B1 C6 70 A8 D7 EB CF DD > >>> ..........p..... > >>> > 0040: 2D B5 1D BC 01 3E 28 2A 2B 5B 38 8F EB 20 F2 A2 > >>> -....>(*+[8.. .. > >>> > 0050: 00 07 47 F7 87 B8 99 CB EF B4 13 04 C8 8B 82 FB > >>> ..G............. > >>> > > >>> > Expected Result: > >>> > Expected result is that every connection succeed. > >>> > > >>> > Actual Result: > >>> > Roughly one out of 256 connections fail. > >>> > > >>> > Source code for an executable test case: > >>> > > >>> > Java server: > >>> > > >>> > import javax.net.ssl.SSLServerSocket; > >>> > import javax.net.ssl.SSLServerSocketFactory; > >>> > import javax.net.ssl.SSLSocket; > >>> > > >>> > public class TestServer { > >>> > public static void main(String args[]) throws Exception { > >>> > SSLServerSocketFactory ssf = (SSLServerSocketFactory) > >>> > SSLServerSocketFactory.getDefault(); > >>> > SSLServerSocket ss = (SSLServerSocket) > >>> ssf.createServerSocket(9999); > >>> > System.out.println("Listening on port 9999"); > >>> > for (String cs : ss.getEnabledCipherSuites()) { > >>> > System.out.println(cs); > >>> > } > >>> > while (true) { > >>> > SSLSocket s = (SSLSocket) ss.accept(); > >>> > System.out.println("Connected with > >>> > "+s.getSession().getCipherSuite()); > >>> > s.close(); > >>> > } > >>> > } > >>> > } > >>> > > >>> > Run as as follows: > >>> > > >>> > keytool -storepass "password" -keypass "password" -genkey > -keyalg RSA > >>> > -keystore test_keystore.jks -dname CN=test > >>> > javac TestServer.java > >>> > java -Djavax.net.debug=all > >>> -Djavax.net.ssl.keyStore=./test_keystore.jks > >>> > -Djavax.net.ssl.keyStorePassword=password TestServer > >>> > > >>> > OpenSSL client: > >>> > > >>> > set -e > >>> > while true; do > >>> > openssl s_client -cipher DHE-RSA-AES128-SHA -connect > >>> 127.0.0.1:9999 > >>> > -quiet -no_ign_eof < /dev/null > >>> > done > >>> > > >>> > Workaround: > >>> > Disable Diffie-Hellman cipher suites. > >>> > > >>> > ---snip--- > >>> > > >>> > >>> > >> > >> > > > > From alan.bateman at oracle.com Wed May 29 02:28:15 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 29 May 2013 09:28:15 +0000 Subject: hg: jdk8/tl/jdk: 8014928: (fs) Files.readAllBytes() copies content to new array when content completely read Message-ID: <20130529092901.8F87148DCF@hg.openjdk.java.net> Changeset: 2b3242a69a44 Author: alanb Date: 2013-05-29 10:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b3242a69a44 8014928: (fs) Files.readAllBytes() copies content to new array when content completely read Reviewed-by: martin ! src/share/classes/java/nio/file/Files.java From vicente.romero at oracle.com Wed May 29 02:58:03 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 29 May 2013 09:58:03 +0000 Subject: hg: jdk8/tl/langtools: 7053059: VerifyError with double Assignment using a Generic Member of a Superclass Message-ID: <20130529095809.94FF848DD1@hg.openjdk.java.net> Changeset: 92e420e9807d Author: vromero Date: 2013-05-29 10:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/92e420e9807d 7053059: VerifyError with double Assignment using a Generic Member of a Superclass Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java + test/tools/javac/T7053059/VerifyErrorWithDoubleAssignmentTest.java From xuelei.fan at oracle.com Wed May 29 05:42:06 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 29 May 2013 20:42:06 +0800 Subject: [8] 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate In-Reply-To: References: Message-ID: <51A5F79E.6000502@oracle.com> What's the key usage of the OCSP responder? I think it is more like a problem of Comodo CA. This fix may loosen the checking of the validity of the OCSP responder's certificate. Xuelei On 5/28/2013 7:30 PM, Vincent Ryan wrote: > Please review the fix for: http://bugs.sun.com/view_bug.do?bug_id=7174966 > > The problem occurs when validating the signature of an OCSP response from the Comodo CA. > The Signature class tests for the presence of the digitalSignature keyUsage setting when examining > a signer's certificate. One solution is for the sun.security.provider.certpath.OCSPResponse class to > pass the signer's public key rather than the signer's certificate. > > Webrev: http://cr.openjdk.java.net/~vinnie/7174966/webrev.00/ > > Thanks. > From fweimer at redhat.com Wed May 29 05:44:46 2013 From: fweimer at redhat.com (Florian Weimer) Date: Wed, 29 May 2013 14:44:46 +0200 Subject: Code Review Request: JEP 140 Limited doPrivileged In-Reply-To: <51A598A6.7040505@oracle.com> References: <51A598A6.7040505@oracle.com> Message-ID: <51A5F83E.1010303@redhat.com> On 05/29/2013 07:56 AM, Jeff Nisewanger wrote: > The webrev is: http://cr.openjdk.java.net/~jdn/8014097/webrev.0/ The overloads make it cumbersome to use this feature with lambda expressions: http://mail.openjdk.java.net/pipermail/security-dev/2013-May/007434.html Could you rename the variant which take a PrivilegedExceptionAction argument to avoid this? -- Florian Weimer / Red Hat Product Security Team From vincent.x.ryan at oracle.com Wed May 29 05:59:47 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 29 May 2013 13:59:47 +0100 Subject: [8] 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate In-Reply-To: <51A5F79E.6000502@oracle.com> References: <51A5F79E.6000502@oracle.com> Message-ID: <9F6E03E2-BF13-49A9-8E44-5DC63A4A24CF@oracle.com> The Comodo cert has the 'keyCertSign' and 'cRLSign' keyUsage bits set. That's unusual but permitted by RFC 5280. I could have changed the Signature.initVerify method to also accept that combination of keyUsage bits but that would affect all signatures. Sean suggested the approach where the OCSP client supplies the signer's public key rather than the signer's cert. It does mean that the signer's 'digitalSignature' keyUsage bit is no longer checked but since the RFC allows other bit combinations to be set then I think that skipping that check is acceptable. On 29 May 2013, at 13:42, Xuelei Fan wrote: > What's the key usage of the OCSP responder? I think it is more like a > problem of Comodo CA. This fix may loosen the checking of the validity > of the OCSP responder's certificate. > > Xuelei > > On 5/28/2013 7:30 PM, Vincent Ryan wrote: >> Please review the fix for: http://bugs.sun.com/view_bug.do?bug_id=7174966 >> >> The problem occurs when validating the signature of an OCSP response from the Comodo CA. >> The Signature class tests for the presence of the digitalSignature keyUsage setting when examining >> a signer's certificate. One solution is for the sun.security.provider.certpath.OCSPResponse class to >> pass the signer's public key rather than the signer's certificate. >> >> Webrev: http://cr.openjdk.java.net/~vinnie/7174966/webrev.00/ >> >> Thanks. >> > From xuelei.fan at oracle.com Wed May 29 06:27:12 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 29 May 2013 21:27:12 +0800 Subject: [8] 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate In-Reply-To: <9F6E03E2-BF13-49A9-8E44-5DC63A4A24CF@oracle.com> References: <51A5F79E.6000502@oracle.com> <9F6E03E2-BF13-49A9-8E44-5DC63A4A24CF@oracle.com> Message-ID: <51A60230.8020004@oracle.com> It's OK to me. At present. there is no risk I can see to loosen the check. I just worried that if we want to tighten the check again in the future, we may run into compatibility issues. But for now, it is fine to me. Thanks, Xuelei On 5/29/2013 8:59 PM, Vincent Ryan wrote: > The Comodo cert has the 'keyCertSign' and 'cRLSign' keyUsage bits set. > That's unusual but permitted by RFC 5280. > > I could have changed the Signature.initVerify method to also accept that combination of > keyUsage bits but that would affect all signatures. Sean suggested the approach where > the OCSP client supplies the signer's public key rather than the signer's cert. > > It does mean that the signer's 'digitalSignature' keyUsage bit is no longer checked but > since the RFC allows other bit combinations to be set then I think that skipping that > check is acceptable. > > > > On 29 May 2013, at 13:42, Xuelei Fan wrote: > >> What's the key usage of the OCSP responder? I think it is more like a >> problem of Comodo CA. This fix may loosen the checking of the validity >> of the OCSP responder's certificate. >> >> Xuelei >> >> On 5/28/2013 7:30 PM, Vincent Ryan wrote: >>> Please review the fix for: http://bugs.sun.com/view_bug.do?bug_id=7174966 >>> >>> The problem occurs when validating the signature of an OCSP response from the Comodo CA. >>> The Signature class tests for the presence of the digitalSignature keyUsage setting when examining >>> a signer's certificate. One solution is for the sun.security.provider.certpath.OCSPResponse class to >>> pass the signer's public key rather than the signer's certificate. >>> >>> Webrev: http://cr.openjdk.java.net/~vinnie/7174966/webrev.00/ >>> >>> Thanks. >>> >> > From vincent.x.ryan at oracle.com Wed May 29 06:52:28 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 29 May 2013 14:52:28 +0100 Subject: [8] 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate In-Reply-To: <51A60230.8020004@oracle.com> References: <51A5F79E.6000502@oracle.com> <9F6E03E2-BF13-49A9-8E44-5DC63A4A24CF@oracle.com> <51A60230.8020004@oracle.com> Message-ID: <457E34D0-39AE-4D5C-B207-EC25079D9B84@oracle.com> Thanks for your review. On 29 May 2013, at 14:27, Xuelei Fan wrote: > It's OK to me. > > At present. there is no risk I can see to loosen the check. I just > worried that if we want to tighten the check again in the future, we may > run into compatibility issues. But for now, it is fine to me. > > Thanks, > Xuelei > > On 5/29/2013 8:59 PM, Vincent Ryan wrote: >> The Comodo cert has the 'keyCertSign' and 'cRLSign' keyUsage bits set. >> That's unusual but permitted by RFC 5280. >> >> I could have changed the Signature.initVerify method to also accept that combination of >> keyUsage bits but that would affect all signatures. Sean suggested the approach where >> the OCSP client supplies the signer's public key rather than the signer's cert. >> >> It does mean that the signer's 'digitalSignature' keyUsage bit is no longer checked but >> since the RFC allows other bit combinations to be set then I think that skipping that >> check is acceptable. >> >> >> >> On 29 May 2013, at 13:42, Xuelei Fan wrote: >> >>> What's the key usage of the OCSP responder? I think it is more like a >>> problem of Comodo CA. This fix may loosen the checking of the validity >>> of the OCSP responder's certificate. >>> >>> Xuelei >>> >>> On 5/28/2013 7:30 PM, Vincent Ryan wrote: >>>> Please review the fix for: http://bugs.sun.com/view_bug.do?bug_id=7174966 >>>> >>>> The problem occurs when validating the signature of an OCSP response from the Comodo CA. >>>> The Signature class tests for the presence of the digitalSignature keyUsage setting when examining >>>> a signer's certificate. One solution is for the sun.security.provider.certpath.OCSPResponse class to >>>> pass the signer's public key rather than the signer's certificate. >>>> >>>> Webrev: http://cr.openjdk.java.net/~vinnie/7174966/webrev.00/ >>>> >>>> Thanks. >>>> >>> >> > From vincent.x.ryan at oracle.com Wed May 29 06:59:02 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Wed, 29 May 2013 13:59:02 +0000 Subject: hg: jdk8/tl/jdk: 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate Message-ID: <20130529135914.E179548DDF@hg.openjdk.java.net> Changeset: 00ad19610e75 Author: vinnie Date: 2013-05-29 14:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/00ad19610e75 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate Reviewed-by: xuelei ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java From xuelei.fan at oracle.com Wed May 29 07:00:43 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 29 May 2013 22:00:43 +0800 Subject: [8] 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate In-Reply-To: <457E34D0-39AE-4D5C-B207-EC25079D9B84@oracle.com> References: <51A5F79E.6000502@oracle.com> <9F6E03E2-BF13-49A9-8E44-5DC63A4A24CF@oracle.com> <51A60230.8020004@oracle.com> <457E34D0-39AE-4D5C-B207-EC25079D9B84@oracle.com> Message-ID: <51A60A0B.8040506@oracle.com> You are welcome. BTW, would you like to add a comment in the update so that we won't tighten the check in the future unintentionally? Xuelei On 5/29/2013 9:52 PM, Vincent Ryan wrote: > Thanks for your review. > > On 29 May 2013, at 14:27, Xuelei Fan wrote: > >> It's OK to me. >> >> At present. there is no risk I can see to loosen the check. I just >> worried that if we want to tighten the check again in the future, we may >> run into compatibility issues. But for now, it is fine to me. >> >> Thanks, >> Xuelei >> >> On 5/29/2013 8:59 PM, Vincent Ryan wrote: >>> The Comodo cert has the 'keyCertSign' and 'cRLSign' keyUsage bits set. >>> That's unusual but permitted by RFC 5280. >>> >>> I could have changed the Signature.initVerify method to also accept that combination of >>> keyUsage bits but that would affect all signatures. Sean suggested the approach where >>> the OCSP client supplies the signer's public key rather than the signer's cert. >>> >>> It does mean that the signer's 'digitalSignature' keyUsage bit is no longer checked but >>> since the RFC allows other bit combinations to be set then I think that skipping that >>> check is acceptable. >>> >>> >>> >>> On 29 May 2013, at 13:42, Xuelei Fan wrote: >>> >>>> What's the key usage of the OCSP responder? I think it is more like a >>>> problem of Comodo CA. This fix may loosen the checking of the validity >>>> of the OCSP responder's certificate. >>>> >>>> Xuelei >>>> >>>> On 5/28/2013 7:30 PM, Vincent Ryan wrote: >>>>> Please review the fix for: http://bugs.sun.com/view_bug.do?bug_id=7174966 >>>>> >>>>> The problem occurs when validating the signature of an OCSP response from the Comodo CA. >>>>> The Signature class tests for the presence of the digitalSignature keyUsage setting when examining >>>>> a signer's certificate. One solution is for the sun.security.provider.certpath.OCSPResponse class to >>>>> pass the signer's public key rather than the signer's certificate. >>>>> >>>>> Webrev: http://cr.openjdk.java.net/~vinnie/7174966/webrev.00/ >>>>> >>>>> Thanks. >>>>> >>>> >>> >> > From mhall at mhcomputing.net Wed May 29 07:55:21 2013 From: mhall at mhcomputing.net (Matthew Hall) Date: Wed, 29 May 2013 07:55:21 -0700 Subject: [8] 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate In-Reply-To: <51A5F79E.6000502@oracle.com> References: <51A5F79E.6000502@oracle.com> Message-ID: <25e383d9-d9b0-4537-a0e5-2c126b4b858e@email.android.com> Comodo used the root cert to sign the responses, which the RFC allows. I think Java is getting carried away with strictness on this. -- Sent from my mobile device. Xuelei Fan wrote: >What's the key usage of the OCSP responder? I think it is more like a >problem of Comodo CA. This fix may loosen the checking of the validity >of the OCSP responder's certificate. > >Xuelei > >On 5/28/2013 7:30 PM, Vincent Ryan wrote: >> Please review the fix for: >http://bugs.sun.com/view_bug.do?bug_id=7174966 >> >> The problem occurs when validating the signature of an OCSP response >from the Comodo CA. >> The Signature class tests for the presence of the digitalSignature >keyUsage setting when examining >> a signer's certificate. One solution is for the >sun.security.provider.certpath.OCSPResponse class to >> pass the signer's public key rather than the signer's certificate. >> >> Webrev: http://cr.openjdk.java.net/~vinnie/7174966/webrev.00/ >> >> Thanks. >> From vincent.x.ryan at oracle.com Wed May 29 08:17:56 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 29 May 2013 16:17:56 +0100 Subject: [8] 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate In-Reply-To: <25e383d9-d9b0-4537-a0e5-2c126b4b858e@email.android.com> References: <51A5F79E.6000502@oracle.com> <25e383d9-d9b0-4537-a0e5-2c126b4b858e@email.android.com> Message-ID: Right. The Comodo cert is certainly valid. I've modified the OCSP client to avoid the strict check. On 29 May 2013, at 15:55, Matthew Hall wrote: > Comodo used the root cert to sign the responses, which the RFC allows. I think Java is getting carried away with strictness on this. > -- > Sent from my mobile device. > > Xuelei Fan wrote: > >> What's the key usage of the OCSP responder? I think it is more like a >> problem of Comodo CA. This fix may loosen the checking of the validity >> of the OCSP responder's certificate. >> >> Xuelei >> >> On 5/28/2013 7:30 PM, Vincent Ryan wrote: >>> Please review the fix for: >> http://bugs.sun.com/view_bug.do?bug_id=7174966 >>> >>> The problem occurs when validating the signature of an OCSP response >> from the Comodo CA. >>> The Signature class tests for the presence of the digitalSignature >> keyUsage setting when examining >>> a signer's certificate. One solution is for the >> sun.security.provider.certpath.OCSPResponse class to >>> pass the signer's public key rather than the signer's certificate. >>> >>> Webrev: http://cr.openjdk.java.net/~vinnie/7174966/webrev.00/ >>> >>> Thanks. >>> > From xuelei.fan at oracle.com Wed May 29 08:39:19 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 29 May 2013 23:39:19 +0800 Subject: Code review request, 7188658 Add possibility to disable client initiated renegotiation Message-ID: <51A62127.2000406@oracle.com> Hi, This fix is an enhancement to add the ability in JSSE server side to reject client initialized renegotiation. webrev: http://cr.openjdk.java.net/~xuelei/7188658/webrev.00/ Thanks, Xuelei From xuelei.fan at oracle.com Wed May 29 08:43:22 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 29 May 2013 23:43:22 +0800 Subject: Code review request, 7188658 Add possibility to disable client initiated renegotiation In-Reply-To: <51A62127.2000406@oracle.com> References: <51A62127.2000406@oracle.com> Message-ID: <51A6221A.4000205@oracle.com> A new system property, "jsse.rejectClientInitializedRenego", is introduced to reject client initialized renegotiation in server side. If the system property is set to "true", server side should not accept client initialized renegotiation, and is expected to fail with a fatal handshake_failure alert if receiving client initialized renegotiation request. The default value of the system property is "false". It is expected that other JSSE providers also comply to this specification. The usage of the system property in client side is not defined. >From the long run, the industry should move forward to secure renegotiation. So we will not consider to support this enhancement with new Java class or method. Xuelei On 5/29/2013 11:39 PM, Xuelei Fan wrote: > Hi, > > This fix is an enhancement to add the ability in JSSE server side to > reject client initialized renegotiation. > > webrev: http://cr.openjdk.java.net/~xuelei/7188658/webrev.00/ > > Thanks, > Xuelei > From bernd-2013 at eckenfels.net Wed May 29 10:06:41 2013 From: bernd-2013 at eckenfels.net (Bernd Eckenfels) Date: Wed, 29 May 2013 19:06:41 +0200 Subject: Code review request, 7188658 Add possibility to disable client initiated renegotiation In-Reply-To: <51A62127.2000406@oracle.com> References: <51A62127.2000406@oracle.com> Message-ID: Hello Xuelei, This is nice to hear. BTW: my own Bug in that direction never made it through review, maybe you want to reference ist a well. Not Public: 2381456 There is a number of Security Advisories for this weakness (generic ones, mainly mentioning other implementations). It might be worth to acknowlege one of the CVEs or Issue your own one (I certainly have customers which noticed lack of it). As I understand the spec you could, instead of rejecting also ignore the request. Did you consider making it a 3-state? (you can currently force the Same terminating behaviour with an empty cipher suite). You mentioned industry will move to a secure handshake - are you aware of any initiative in that direction? PS: i still would prefer to allow applications deal with this by having a syncronous handshake listener (would could then count handshake frequency and close the socket). Bernd -- bernd.eckenfels.net Am 29.05.2013 um 17:39 schrieb Xuelei Fan : > Hi, > > This fix is an enhancement to add the ability in JSSE server side to > reject client initialized renegotiation. > > webrev: http://cr.openjdk.java.net/~xuelei/7188658/webrev.00/ > > Thanks, > Xuelei From mhall at mhcomputing.net Wed May 29 10:11:24 2013 From: mhall at mhcomputing.net (Matthew Hall) Date: Wed, 29 May 2013 10:11:24 -0700 Subject: Code review request, 7188658 Add possibility to disable client initiated renegotiation In-Reply-To: References: <51A62127.2000406@oracle.com> Message-ID: <20130529171124.GA26361@mhcomputing.net> On Wed, May 29, 2013 at 07:06:41PM +0200, Bernd Eckenfels wrote: > PS: i still would prefer to allow applications deal with this by having a > syncronous handshake listener (would could then count handshake frequency > and close the socket). Expecting applications to do this would not be secure by default, and would result in a lot of cut-and-paste code. At minimum there should be a reasonable default implementation which does something sane, that an app could choose to manually override if there was a good reason for it. Matthew. From staffan.larsen at oracle.com Wed May 29 00:43:11 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 29 May 2013 07:43:11 +0000 Subject: hg: jdk8/tl/jdk: 8015440: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException Message-ID: <20130529074332.6E97C48DC3@hg.openjdk.java.net> Changeset: bd6d3801347b Author: sla Date: 2013-05-29 09:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd6d3801347b 8015440: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails with RuntimeException Summary: Make sure serial gc compacts heap every time Reviewed-by: mchung, brutisso, nloodin ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java From ricardo_martin_camarero at yahoo.es Wed May 29 01:22:05 2013 From: ricardo_martin_camarero at yahoo.es (Ricardo Martin Camarero) Date: Wed, 29 May 2013 10:22:05 +0200 Subject: PATCH: possible bug in OCSP check In-Reply-To: <51A556D9.2030601@oracle.com> References: <519F3377.9000902@yahoo.es> <51A556D9.2030601@oracle.com> Message-ID: <51A5BAAD.5080602@yahoo.es> Hi Xuelei, I suppose my company had, cos I also work for Oracle. :-) But I'm not related with openjdk and this issue was discovered outside my work (I was asked by an ex-colleague about the ocsp responder I commented previously). Regards! On 05/29/2013 03:16 AM, Xuelei Fan wrote: > Hi Ricardo, > > Have you or your organization signed the signed the Oracle Contributor > Agreement (OCA) per the request of OpenJDK bylaws? > > http://openjdk.java.net/bylaws#_2 > > Thanks, > Xuelei > > On 5/24/2013 5:31 PM, Ricardo Martin Camarero wrote: >> Hi everybody, >> >> I have been struggling for some months with a weird issue about how Java >> validates OCSP responses. Following the RFC2560 standard the responses >> sent by the responder should be signed following one of these three >> possibilities: >> >>> All definitive response messages SHALL be digitally signed. The key >>> used to sign the response MUST belong to one of the following: >>> >>> -- the CA who issued the certificate in question >>> -- a Trusted Responder whose public key is trusted by the requester >>> -- a CA Designated Responder (Authorized Responder) who holds a >>> specially marked certificate issued directly by the CA, indicating >>> that the responder may issue OCSP responses for that CA >> In current java implementation (openjdk 6, 7 and 8) the case (1) and (3) >> are considered by default and case (2) can be configured using some >> properties ("ocsp.responderCertSubjectName" for example). But the >> problem is that both configurations are exclusive, if your application >> accepts responses for the cases (1) and (3) it fails with the case (2) >> and vice-versa. >> >> I faced an OCSP responder that in some cases it answered using the case >> (1) and in others using the case (2). The case (1) was used to sign >> responses for their own certificates and the case (2) was used to sign >> responses for foreign certificates (spanish national id certificates >> specifically). I'm not completely sure if the standard admits this >> situation but I haven't read anything against that. Besides why not to >> take the configured certificate ("ocsp.responderCertSubjectName" or any >> of the other properties) as a failback and not as the unique valid signer. >> >> Looking at the code the problem is that only one certificate is passed >> as the valid signer for responses (the one configured via properties or >> the issuer cert). Following Andrew advise I have made a little patch >> against current openjdk-8 that just considers both of them (OCSPResponse >> class receives both certs and this way can check the three cases). >> >> Thanks in advance! >> From james.laskey at oracle.com Wed May 29 09:24:52 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Wed, 29 May 2013 16:24:52 +0000 Subject: hg: jdk8/tl/nashorn: 9 new changesets Message-ID: <20130529162459.4942D48DE8@hg.openjdk.java.net> Changeset: 0bf451c0678d Author: hannesw Date: 2013-05-27 12:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0bf451c0678d 8015348: RegExp("[") results in StackOverflowError Reviewed-by: sundar, attila ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java + test/script/basic/JDK-8015348.js + test/script/basic/JDK-8015348.js.EXPECTED Changeset: 1f57afd14cc1 Author: lagergren Date: 2013-05-27 13:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1f57afd14cc1 8014219: Make the run-octane harness more deterministic by not measuring elapsed time every iteration. Also got rid of most of the run logic in base.js and call benchmarks directly for the same purpose Reviewed-by: jlaskey, attila ! make/build-benchmark.xml ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! test/script/basic/compile-octane.js.EXPECTED ! test/script/basic/run-octane.js Changeset: 910fd2849c4c Author: lagergren Date: 2013-05-27 13:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/910fd2849c4c Merge Changeset: 343fd0450802 Author: sundar Date: 2013-05-27 20:41 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/343fd0450802 8015352: "i".toUpperCase() => currently returns "??", but should be "I" (with Turkish locale) Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties + test/script/basic/JDK-8015352.js Changeset: e6193dcfe36c Author: lagergren Date: 2013-05-27 17:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e6193dcfe36c 8015447: Octane harness fixes for rhino and entire test runs: ant octane, ant octane-v8, ant octane-rhino Reviewed-by: sundar, jlaskey ! make/build-benchmark.xml ! test/script/basic/run-octane.js Changeset: d56168970de1 Author: sundar Date: 2013-05-28 16:37 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d56168970de1 8015459: Octane test run fails on Turkish locale Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/objects/DateParser.java ! src/jdk/nashorn/internal/parser/TokenType.java ! src/jdk/nashorn/internal/runtime/GlobalFunctions.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/Logging.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java Changeset: f472f7046ec9 Author: sundar Date: 2013-05-29 15:41 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f472f7046ec9 8005979: A lot of tests are named "runTest" in reports Reviewed-by: jlaskey ! make/project.properties Changeset: f69e76417211 Author: lagergren Date: 2013-05-29 14:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f69e76417211 8011023: Math round didn't conform to ECMAScript 5 spec Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/objects/NativeMath.java + test/script/basic/JDK-8011023.js + test/script/basic/JDK-8011023.js.EXPECTED Changeset: a2e2797392b3 Author: sundar Date: 2013-05-29 21:27 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a2e2797392b3 8015349: "abc".lastIndexOf("a",-1) should evaluate to 0 and not -1 Reviewed-by: lagergren, attila, jlaskey ! src/jdk/nashorn/internal/objects/NativeString.java + test/script/basic/JDK-8015349.js + test/script/basic/JDK-8015349.js.EXPECTED From jonathan.gibbons at oracle.com Wed May 29 15:42:33 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 29 May 2013 22:42:33 +0000 Subject: hg: jdk8/tl/langtools: 8015641: genstubs needs to cope with static interface methods Message-ID: <20130529224240.5958B48E07@hg.openjdk.java.net> Changeset: d685b12b62a4 Author: jjg Date: 2013-05-29 15:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d685b12b62a4 8015641: genstubs needs to cope with static interface methods Reviewed-by: ksrini ! make/tools/genstubs/GenStubs.java From xuelei.fan at oracle.com Wed May 29 17:18:27 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 30 May 2013 08:18:27 +0800 Subject: Code review request, 7188658 Add possibility to disable client initiated renegotiation In-Reply-To: References: <51A62127.2000406@oracle.com> Message-ID: <51A69AD3.9010001@oracle.com> On 5/30/2013 1:06 AM, Bernd Eckenfels wrote: > Hello Xuelei, > > This is nice to hear. BTW: my own Bug in that direction never made it through review, maybe you want to reference ist a well. Not Public: 2381456 > Would you mind send me the link of the bug, or the code review request mail? I may miss some mails about this direction. > There is a number of Security Advisories for this weakness (generic ones, mainly mentioning other implementations). It might be worth to acknowlege one of the CVEs or Issue your own one (I certainly have customers which noticed lack of it). > Good suggestion. Oracle provider of JSSE had addressed the TLS renegotiation issue in JDK 1.4.2 update 26, JDK 1.5.0 update 24 and JDK 6u 19 around the end of 2009 and the beginning of 2010. Here is the readme of the fix: http://www.oracle.com/technetwork/java/javase/documentation/tlsreadme2-176330.html. > As I understand the spec you could, instead of rejecting also ignore the request. Did you consider making it a 3-state? (you can currently force the Same terminating behaviour with an empty cipher suite). > I did consider to ignore or warning the request instead of a fatal closure. But it bring in extra complexity, and hard to handle in both client and server. > You mentioned industry will move to a secure handshake - are you aware of any initiative in that direction? > See http://www.rfc.org/rfc/rfc5746.txt. As far as I know, nearly all major vendors of SSL protocols has support RFC5746. Xuelei > PS: i still would prefer to allow applications deal with this by having a syncronous handshake listener (would could then count handshake frequency and close the socket). > > Bernd > From bernd-2013 at eckenfels.net Wed May 29 19:04:08 2013 From: bernd-2013 at eckenfels.net (Bernd Eckenfels) Date: Thu, 30 May 2013 04:04:08 +0200 Subject: Code review request, 7188658 Add possibility to disable client initiated renegotiation In-Reply-To: <51A69AD3.9010001@oracle.com> References: <51A62127.2000406@oracle.com> <51A69AD3.9010001@oracle.com> Message-ID: Am 30.05.2013, 02:18 Uhr, schrieb Xuelei Fan : >> 2381456 > Would you mind send me the link of the bug, or the code review request > mail? I may miss some mails about this direction. I am afraid I cant sent the link, the Bug is in review state and therefore not visible for me. It was acknowledged 2012-11-12, see attached. I guess the link would be http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=2381456 (not sure if the numbers are the same in the new bug tool). > Good suggestion. Oracle provider of JSSE had addressed the TLS > renegotiation issue in JDK 1.4.2 update 26, JDK 1.5.0 update 24 and JDK > 6u 19 around the end of 2009 and the beginning of 2010. Here is the > readme of the fix: > http://www.oracle.com/technetwork/java/javase/documentation/tlsreadme2-176330.html. Thats a different problem, I was thinking about preventing execessive client initiated renegotiations. This is for example CVE-2011-1473 from THC. >> You mentioned industry will move to a secure handshake - are you aware >> of any initiative in that direction? >> > See http://www.rfc.org/rfc/rfc5746.txt. As far as I know, nearly all > major vendors of SSL protocols has support RFC5746. Ok, but thats a different issue. I was expecting 7188658 to address another point, but I might be wrong. I understand that as of Oracle policy we cannot discuss it. Even if this is a very well known issue. :-/ Greetings Bernd -- http://bernd.eckenfels.net Date Created: Mon Nov 12 12:13:08 MST 2012 Type: bug Customer Name: Bernd Eckenfels SDN ID: status: Waiting Category: jsse Subcategory: runtime release: 7 hardware: x64 OSversion: linux_sles11 priority: 4 Synopsis: Excessive SSL renegotiation possible Description: FULL PRODUCT VERSION : java version "1.7.0_09" Java(TM) SE Runtime Environment (build 1.7.0_09-b05) Java HotSpot(TM) 64-Bit Server VM (build 23.5-b02, mixed mode) ADDITIONAL OS VERSION INFORMATION : Various Versions A DESCRIPTION OF THE PROBLEM : The SSL/TLS Server Socket (and SSLEngine) of JSSE seems not to protect itself from excessive handshake requests and renegotiations. This leads to a high CPU load. For other products this is filed as CVE-2011-1473 or CVE-2011-5094. A minimum solution would be to actually turn the renegotiation support off, IBM JDK for example offers the option "com.ibm.jsse2.renegotiate" STEPS TO FOLLOW TO REPRODUCE THE PROBLEM : - set up a JSSE ServerSocket - connect with openssl s_client (use "R" command) or thc tool EXPECTED VERSUS ACTUAL BEHAVIOR : EXPECTED - after a small number of consecutive renegotiates the server should ignore them ACTUAL - server-cpu is fully used REPRODUCIBILITY : This bug can be reproduced always. From xuelei.fan at oracle.com Wed May 29 19:05:55 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 30 May 2013 10:05:55 +0800 Subject: Code review request, 7188658 Add possibility to disable client initiated renegotiation In-Reply-To: References: <51A62127.2000406@oracle.com> <51A69AD3.9010001@oracle.com> Message-ID: <51A6B403.4060907@oracle.com> Got it. Yes, this fix is addressing a different issue from you mentioned below. Thanks, Xuelei On 5/30/2013 9:53 AM, Bernd Eckenfels wrote: > Am 30.05.2013, 02:18 Uhr, schrieb Xuelei Fan : >>> 2381456 >> Would you mind send me the link of the bug, or the code review request >> mail? I may miss some mails about this direction. > > I am afraid I cant sent the link, the Bug is in review state and > therefore not visible for me. It was acknowledged 2012-11-12, see > attached. I guess the link would be > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=2381456 (not sure if > the numbers are the same in the new bug tool). > >> Good suggestion. Oracle provider of JSSE had addressed the TLS >> renegotiation issue in JDK 1.4.2 update 26, JDK 1.5.0 update 24 and JDK >> 6u 19 around the end of 2009 and the beginning of 2010. Here is the >> readme of the fix: >> http://www.oracle.com/technetwork/java/javase/documentation/tlsreadme2-176330.html. >> > > Thats a different problem, I was thinking about preventing execessive > client initiated renegotiations. This is for example CVE-2011-1473 from > THC. > >>> You mentioned industry will move to a secure handshake - are you >>> aware of any initiative in that direction? >>> >> See http://www.rfc.org/rfc/rfc5746.txt. As far as I know, nearly all >> major vendors of SSL protocols has support RFC5746. > > Ok, but thats a different issue. I was expecting 7188658 to address > another point, but I might be wrong. > > I understand that as of Oracle policy we cannot discuss it. Even if this > is a very well known issue. :-/ > > Greetings > Bernd From xueming.shen at oracle.com Wed May 29 19:53:10 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 30 May 2013 02:53:10 +0000 Subject: hg: jdk8/tl/jdk: 4759491: method ZipEntry.setTime(long) works incorrectly; ... Message-ID: <20130530025333.AE19648E12@hg.openjdk.java.net> Changeset: 90df6756406f Author: sherman Date: 2013-05-29 19:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90df6756406f 4759491: method ZipEntry.setTime(long) works incorrectly 6303183: Support NTFS and Unix-style timestamps for entries in Zip files 7012856: (zipfs) Newly created entry in zip file system should set all file times non-null values. 7012868: (zipfs) file times of entry in zipfs should always be the same regardless of TimeZone. Summary: to add suuport of Info-ZIP extended timestamp in extra data fields Reviewed-by: martin, alanb ! src/share/classes/java/util/zip/ZipConstants.java ! src/share/classes/java/util/zip/ZipEntry.java ! src/share/classes/java/util/zip/ZipFile.java ! src/share/classes/java/util/zip/ZipInputStream.java ! src/share/classes/java/util/zip/ZipOutputStream.java + src/share/classes/java/util/zip/ZipUtils.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipInfo.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh ! test/java/util/jar/TestExtra.java ! test/java/util/zip/StoredCRC.java + test/java/util/zip/TestExtraTime.java ! test/java/util/zip/ZipFile/Assortment.java From tomas at primekey.se Thu May 30 03:51:28 2013 From: tomas at primekey.se (Tomas Gustavsson) Date: Thu, 30 May 2013 12:51:28 +0200 Subject: [8] 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate In-Reply-To: <25e383d9-d9b0-4537-a0e5-2c126b4b858e@email.android.com> References: <51A5F79E.6000502@oracle.com> <25e383d9-d9b0-4537-a0e5-2c126b4b858e@email.android.com> Message-ID: <51A72F30.2070602@primekey.se> It was at some point common to require digitalSignature. Many years ago when we developed support for OCSP in EJBCA, Mozilla browsers would not accept OCSP responses with only keyCertSign and crlSign. DigitalSignature was needed as well. So at least it was common behaviour some years ago. I don't know if FireFox ha changed that, I guess so as it seems unlikely Comodo would not work with FireFox. RFC2560 does not specify anything about key usage, so my guess is that the CABForum has determined what browsers and public CAs should/could use. Will try without digitalSignature in FireFox now :-) Cheers, Tomas On 05/29/2013 04:55 PM, Matthew Hall wrote: > Comodo used the root cert to sign the responses, which the RFC allows. I think Java is getting carried away with strictness on this. > From chris.hegarty at oracle.com Thu May 30 04:21:39 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 30 May 2013 11:21:39 +0000 Subject: hg: jdk8/tl/jdk: 8015299: Memory leak in jdk/src/solaris/bin/java_md_solinux.c Message-ID: <20130530112205.4794848E23@hg.openjdk.java.net> Changeset: 6df9b071b04d Author: jzavgren Date: 2013-05-30 12:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6df9b071b04d 8015299: Memory leak in jdk/src/solaris/bin/java_md_solinux.c Reviewed-by: martin, dholmes, chegar, ksrini ! src/solaris/bin/java_md_solinux.c From chris.hegarty at oracle.com Thu May 30 09:09:48 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 30 May 2013 17:09:48 +0100 Subject: RFR JDK-8003245 In-Reply-To: <24356968-438c-495a-859a-bab0af138c23@default> References: <24356968-438c-495a-859a-bab0af138c23@default> Message-ID: <51A779CC.9070101@oracle.com> [cc'ing security-dev since this change is in their area] John, http://cr.openjdk.java.net/~jzavgren/8003245/webrev.01/ The changes in your above webrev look fine to me. I can sponsor this for you, unless someone from the security area wants to, or even additional reviews. -Chris. On 03/27/2013 04:30 PM, John Zavgren wrote: > Florian: > > Yes, the uninitialized memory will be accessed in some cases, for example: > @@ -1733,10 +1747,12 @@ > CK_X9_42_DH1_DERIVE_PARAMS ckParam; > jfieldID fieldID; > jlong jKdf; > jobject jOtherInfo, jPublicData; > > + memset(&ckParam, 0, sizeof(CK_X9_42_DH1_DERIVE_PARAMS));<--- added initialization > + > /* get kdf */ > jX942Dh1DeriveParamsClass = (*env)->FindClass(env, CLASS_X9_42_DH1_DERIVE_PARAMS); > if (jX942Dh1DeriveParamsClass == NULL) { return ckParam; } > fieldID = (*env)->GetFieldID(env, jX942Dh1DeriveParamsClass, "kdf", "J"); > if (fieldID == NULL) { return ckParam; } > > ----- Original Message ----- > From: fweimer at redhat.com > To: john.zavgren at oracle.com > Cc: core-libs-dev at openjdk.java.net > Sent: Wednesday, March 27, 2013 11:48:57 AM GMT -05:00 US/Canada Eastern > Subject: Re: RFR JDK-8003245 > > On 03/20/2013 04:27 PM, John Zavgren wrote: >> Please consider the following changes that eliminate the use of uninitialized memory. > >> http://cr.openjdk.java.net/~jzavgren/8003245/webrev.01/ > > Is the uninitialized memory accessed on the error paths? > From jaroslav.bachorik at oracle.com Thu May 30 04:59:00 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Thu, 30 May 2013 11:59:00 +0000 Subject: hg: jdk8/tl/jdk: 8015627: test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails in agentvm mode Message-ID: <20130530115914.63A4F48E25@hg.openjdk.java.net> Changeset: dc22b7241a70 Author: jbachorik Date: 2013-05-30 13:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dc22b7241a70 8015627: test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails in agentvm mode Reviewed-by: alanb, chegar ! test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java From paul.sandoz at oracle.com Thu May 30 07:26:18 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Thu, 30 May 2013 14:26:18 +0000 Subject: hg: jdk8/tl/jdk: 8014409: Spec typo: extra } in the spec for j.u.s.StreamBuilder Message-ID: <20130530142644.D115248E2A@hg.openjdk.java.net> Changeset: 156ee44cd456 Author: psandoz Date: 2013-05-30 16:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/156ee44cd456 8014409: Spec typo: extra } in the spec for j.u.s.StreamBuilder Summary: Also fixes documentation on StreamBuilder.OfDouble Reviewed-by: alanb, chegar, mduigou ! src/share/classes/java/util/stream/StreamBuilder.java From paul.sandoz at oracle.com Thu May 30 07:34:17 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Thu, 30 May 2013 14:34:17 +0000 Subject: hg: jdk8/tl/jdk: 8014393: Minor typo in the spec for j.u.stream.Stream.findFirst() Message-ID: <20130530143434.2119C48E2D@hg.openjdk.java.net> Changeset: b4742d038100 Author: psandoz Date: 2013-05-28 15:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4742d038100 8014393: Minor typo in the spec for j.u.stream.Stream.findFirst() Reviewed-by: alanb, chegar ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java From xueming.shen at oracle.com Thu May 30 14:50:30 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 30 May 2013 21:50:30 +0000 Subject: hg: jdk8/tl/jdk: 8015271: Conversion table for EUC-KR is incorrect Message-ID: <20130530215045.E507448E36@hg.openjdk.java.net> Changeset: b588955b7e5b Author: sherman Date: 2013-05-30 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b588955b7e5b 8015271: Conversion table for EUC-KR is incorrect Summary: to add the requested postal code mark character u+327e Reviewed-by: alanb ! make/tools/CharsetMapping/EUC_KR.map From bradford.wetmore at oracle.com Thu May 30 16:53:29 2013 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Thu, 30 May 2013 16:53:29 -0700 Subject: Code review: 8001284 & 8012971 In-Reply-To: <51770549.3070707@oracle.com> References: <5175A932.1090107@oracle.com> <51770549.3070707@oracle.com> Message-ID: <51A7E679.6080306@oracle.com> Tony, >> NOTE: the diffs in webrev are hiding the change in indention for the >> "if (found)" change. Don't know why webrev is set this way, but >> looking at the non-diff links shows the proper indention. FYI: webrev's -b option will cause webrev to not ignore changes in the amount of white space. I'm guessing the concern is more for the actual code than whitespace, and listing whitespace changes just adds "useless" noise/overhead to the review. (But I do notice that kind of stuff! ;)) Brad > On 04/22/13 14:18, Anthony Scarpino wrote: >> This code review is for the following two bugs: >> - 8001284 Buffer problems with SunPKCS11-Solaris and CKM_AES_CTR >> - 8012971 PKCS11Test hiding exception failures >> >> The first fix is simple as it prevents the method from enforcing AES >> block lengths on CTR, a stream cipher. >> >> The second fix is a test problem that is suppressing test failures. >> NOTE: the diffs in webrev are hiding the change in indention for the >> "if (found)" change. Don't know why webrev is set this way, but >> looking at the non-diff links shows the proper indention. >> >> http://cr.openjdk.java.net/~ascarpino/8001284/webrev.00/ >> >> thanks >> >> Tony >> > From valerie.peng at oracle.com Thu May 30 18:16:02 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Thu, 30 May 2013 18:16:02 -0700 Subject: Code review request: 8001326: Improve Kerberos replay caching In-Reply-To: <51A46EA6.3090100@oracle.com> References: <51A46EA6.3090100@oracle.com> Message-ID: <51A7F9D2.5090509@oracle.com> One question: In DflCache.java, you mentioned that the old style block is always created even if a new style is available. When both are present, Is it always new style before old one? The impl in DflCache.java seems to assume this. Thanks, Valerie On 05/28/13 01:45, Weijun Wang wrote: > Please review the code changes at > > http://cr.openjdk.java.net/~weijun/8001326/webrev.00/ > > Two new system properties are introduced. sun.security.krb5.rcache to > control what rcache type should be used. Besides the original one > (which does not need this system property to be set), we support dfl > and none now. Also, sun.security.krb5.acceptor.subkey can be set to > true to let acceptor generate a sub-key, so that even if a replayed > authenticator is not detected, a replayed message won't work. > > Thanks > Max From weijun.wang at oracle.com Thu May 30 18:41:45 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 31 May 2013 09:41:45 +0800 Subject: Code review request: 8015274 and 8015276: policytool manual test problems Message-ID: <51A7FFD9.30702@oracle.com> Please review the fix at http://cr.openjdk.java.net/~weijun/8015274/webrev.00/ It's for two bugs: 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TEST_BUG: The 'ptool.test' can't be saved in the 'tmp' folder. Thanks Max From xuelei.fan at oracle.com Thu May 30 22:03:51 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 31 May 2013 05:03:51 +0000 Subject: hg: jdk8/tl/jdk: 8014618: Need to strip leading zeros in TlsPremasterSecret of DHKeyAgreement Message-ID: <20130531050404.EA02048E4B@hg.openjdk.java.net> Changeset: 6407106f1b1c Author: xuelei Date: 2013-05-30 22:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6407106f1b1c 8014618: Need to strip leading zeros in TlsPremasterSecret of DHKeyAgreement Reviewed-by: xuelei Contributed-by: Pasi Eronen ! src/share/classes/com/sun/crypto/provider/DHKeyAgreement.java ! src/share/classes/sun/security/pkcs11/P11KeyAgreement.java ! src/share/classes/sun/security/pkcs11/P11Signature.java ! src/share/classes/sun/security/pkcs11/P11Util.java ! src/share/classes/sun/security/util/KeyUtil.java + test/com/sun/crypto/provider/TLS/TestLeadingZeroes.java + test/sun/security/pkcs11/tls/TestLeadingZeroesP11.java From xuelei.fan at oracle.com Thu May 30 22:21:24 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 31 May 2013 05:21:24 +0000 Subject: hg: jdk8/tl/jdk: 7160837: DigestOutputStream does not turn off digest calculation when "close()" is called Message-ID: <20130531052135.DD0F348E4D@hg.openjdk.java.net> Changeset: 8402ef8fabde Author: ascarpino Date: 2013-05-30 22:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8402ef8fabde 7160837: DigestOutputStream does not turn off digest calculation when "close()" is called Reviewed-by: mullan, xuelei ! src/share/classes/java/security/DigestOutputStream.java ! src/share/classes/javax/crypto/CipherInputStream.java ! src/share/classes/javax/crypto/CipherOutputStream.java + test/javax/crypto/Cipher/CipherStreamClose.java From xuelei.fan at oracle.com Thu May 30 22:26:24 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 31 May 2013 05:26:24 +0000 Subject: hg: jdk8/tl/jdk: 8013069: javax.crypto tests fail with new PBE algorithm names Message-ID: <20130531052636.127B448E4E@hg.openjdk.java.net> Changeset: 6cb09d3cd309 Author: valeriep Date: 2013-05-29 20:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cb09d3cd309 8013069: javax.crypto tests fail with new PBE algorithm names Summary: Shouldn't auto-generate default parameters for MAC objects. Reviewed-by: vinnie ! src/share/classes/com/sun/crypto/provider/HmacPKCS12PBESHA1.java ! src/share/classes/com/sun/crypto/provider/PBMAC1Core.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java ! test/com/sun/crypto/provider/Mac/HmacPBESHA1.java ! test/com/sun/crypto/provider/Mac/MacClone.java From xuelei.fan at oracle.com Thu May 30 22:36:11 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 31 May 2013 05:36:11 +0000 Subject: hg: jdk8/tl/jdk: 6750584: Cipher.wrap/unwrap methods should define UnsupportedOperationException Message-ID: <20130531053622.DB15D48E4F@hg.openjdk.java.net> Changeset: 918d9ac17740 Author: ascarpino Date: 2013-05-30 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/918d9ac17740 6750584: Cipher.wrap/unwrap methods should define UnsupportedOperationException Reviewed-by: mullan ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/CipherSpi.java From chris.hegarty at oracle.com Fri May 31 01:32:00 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 31 May 2013 08:32:00 +0000 Subject: hg: jdk8/tl/jdk: 7107883: getNetworkPrefixLength() does not return correct prefix length Message-ID: <20130531083225.EF21548E58@hg.openjdk.java.net> Changeset: dcf42861b5b1 Author: chegar Date: 2013-05-31 09:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dcf42861b5b1 7107883: getNetworkPrefixLength() does not return correct prefix length Reviewed-by: alanb, michaelm ! src/solaris/native/java/net/NetworkInterface.c ! test/java/net/InterfaceAddress/NetworkPrefixLength.java From vicente.romero at oracle.com Fri May 31 02:05:52 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Fri, 31 May 2013 09:05:52 +0000 Subject: hg: jdk8/tl/langtools: 7179353: try-with-resources fails to compile with generic exception parameters Message-ID: <20130531090604.168F148E79@hg.openjdk.java.net> Changeset: 9f11c7676cd5 Author: vromero Date: 2013-05-31 10:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f11c7676cd5 7179353: try-with-resources fails to compile with generic exception parameters Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/T7179353/GenericsAndTWRCompileErrorTest.java From erik.joelsson at oracle.com Fri May 31 03:14:00 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 31 May 2013 12:14:00 +0200 Subject: RFR: 8010785: JDK 8 build on Linux fails with new build mechanism In-Reply-To: <5166961E.3090607@oracle.com> References: <5166961E.3090607@oracle.com> Message-ID: <51A877E8.1090105@oracle.com> Finally getting back to this. Updated webrevs: http://cr.openjdk.java.net/~erikj/8010785/webrev.jdk.02/ http://cr.openjdk.java.net/~erikj/8010785/webrev.root.02/ The javascript part is no longer needed since it has been removed. /Erik On 2013-04-11 12:53, Erik Joelsson wrote: > Open part of this review. > > The licensee bundles aren't buildable with the new build for several > reasons. I've tried to fix all the issues that I've found and have now > successfully built them on linux, windows and solaris. Here is a list > of the changes that I had to do to OpenJDK: > > * Filter out javascript src when the rhino source isn't available. > Also do not copy rhino resource files when not available. This is > controlled by a new variable, INCLUDE_JAVASCRIPT, which we control > from closed configure and shouldn't affect the OpenJDK build. I also > moved the copying of the resources to the correct makefile, > CopyIntoClasses.gmk. > > * If javax/crypto isn't available, jce.jar needs to be added to the > bootclasspath of the main java compilation. Also, a number of security > jar files shouldn't be built at all. (Normally these are built just to > exercise the logic, but not used.) The kerberos library is also > excluded by this. Introduced the variable BUILD_CRYPTO, also set by > closed configure to control this. I used the logic ifneq > ($(BUILD_CRYPTO),no) to not change the behavior if the variable isn't > set, which it won't be in the open case. > > * I removed the logic for setting the closed cacerts file in the open > configure script. > > * Also fixing JDK-8005655 by adding logic for unzipping sec-bin (and > friends) if available. > > http://cr.openjdk.java.net/~erikj/8010785/webrev.jdk.01/ > http://cr.openjdk.java.net/~erikj/8010785/webrev.root.01/ > > /Erik From alan.bateman at oracle.com Fri May 31 04:22:33 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 31 May 2013 11:22:33 +0000 Subject: hg: jdk8/tl/jdk: 8014854: (bf) CharBuffer.chars too slow with default implementation Message-ID: <20130531112303.ED0E148E83@hg.openjdk.java.net> Changeset: 243cd682c47b Author: alanb Date: 2013-05-31 12:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/243cd682c47b 8014854: (bf) CharBuffer.chars too slow with default implementation Reviewed-by: erikj, briangoetz, henryjen, psandoz, mduigou ! makefiles/CompileJavaClasses.gmk ! makefiles/GensrcBuffer.gmk ! src/share/classes/java/nio/Buffer.java ! src/share/classes/java/nio/ByteBufferAs-X-Buffer.java.template + src/share/classes/java/nio/CharBufferSpliterator.java ! src/share/classes/java/nio/Direct-X-Buffer.java.template ! src/share/classes/java/nio/Heap-X-Buffer.java.template ! src/share/classes/java/nio/StringCharBuffer.java ! src/share/classes/java/nio/X-Buffer.java.template + test/java/nio/Buffer/Chars.java From naoto.sato at oracle.com Fri May 31 11:21:40 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Fri, 31 May 2013 18:21:40 +0000 Subject: hg: jdk8/tl/jdk: 7006052: awt_InputMethod.c cleanup is needed Message-ID: <20130531182153.1C22F48E95@hg.openjdk.java.net> Changeset: 933b1338b99c Author: naoto Date: 2013-05-31 11:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/933b1338b99c 7006052: awt_InputMethod.c cleanup is needed Reviewed-by: anthony ! src/solaris/native/sun/awt/awt_InputMethod.c From mandy.chung at oracle.com Fri May 31 11:53:09 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 31 May 2013 11:53:09 -0700 Subject: Code Review Request: JEP 140 Limited doPrivileged In-Reply-To: <51A598A6.7040505@oracle.com> References: <51A598A6.7040505@oracle.com> Message-ID: <51A8F195.6020901@oracle.com> Jeff, The limited doPrivilege is very useful and I'm hoping the libraries can begin using the limited doPrivileged once this is in jdk8. It's non-trivial stuff and I know that you're working on the unit tests and I can look at them when they are available. It looks fine to me and I don't see anything obviously wrong. This extends the wrapper implementation for the combiner and the new comments you added make it easier to understand. I think it'd be good to extend the javadoc of package-private AccessControlContext constructor about "wrapped" ACC and some summary on how they will be used in determining limited privilege scope. I don't spot anything obviously wrong. Just a few minor comments: AccessController.java You fixed up a couple of @see #doPrivileged in existing methods. Looks like L393-394, 445-446 were copied before the change. I'm not sure how these @see tags were decided to be included and it seems worth taking a pass and clean that up if appropriate. You can call java.util.Objects.requireNonNull(perms) to replacethe null argument check (e.g. L403-405). Might be good to move the null argument check at the beginning? AccessControlContext.java L214-231: I wonder if it might be better to move this validation to AccessController.createWrapperbefore constructing the ACC wrapper. The comments in the combine method e.g. L618-196, 622-623 need update after the refactoring. L740-744: FYI this can be replaced by a simple call to: Objects.equals(this.combiner, that.combiner) Same comment can apply to the equality check for this.permission and this.parent. checkPermission2 is checking the limited privilege scope. Maybe good to rename it to something like checkLimitedPrivilegeScope to make it explicit. Mandy On 5/28/2013 10:56 PM, Jeff Nisewanger wrote: > > This is the implementation of the JEP 140 feature for a limited > privilege form of doPrivileged(). A test will be added in an > updated webrev within the next day. > > The JEP is: http://openjdk.java.net/jeps/140 > > The webrev is: http://cr.openjdk.java.net/~jdn/8014097/webrev.0/ > From dan.xu at oracle.com Fri May 31 13:35:00 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Fri, 31 May 2013 20:35:00 +0000 Subject: hg: jdk8/tl/jdk: 8015628: Test Failure in closed/java/io/pathNames/GeneralSolaris.java Message-ID: <20130531203521.796F148E9A@hg.openjdk.java.net> Changeset: f522bbdf2859 Author: dxu Date: 2013-05-31 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f522bbdf2859 8015628: Test Failure in closed/java/io/pathNames/GeneralSolaris.java Reviewed-by: alanb ! test/java/io/pathNames/General.java ! test/java/io/pathNames/GeneralWin32.java From kurchi.subhra.hazra at oracle.com Fri May 31 13:59:32 2013 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Fri, 31 May 2013 20:59:32 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130531205955.2370E48E9D@hg.openjdk.java.net> Changeset: 11cdcf87ad5d Author: jzavgren Date: 2013-05-31 15:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11cdcf87ad5d 8008972: Memory leak: Java_java_net_TwoStacksPlainDatagramSocketImpl_receive0 [parfait] Summary: Modified the code so that "jumbo frames" are truncated before buffer allocation is considered. This makes the buffer length a reliable indication that a buffer has been allocated, and it can then be used during clean up. Reviewed-by: chegar, khazra, alanb Contributed-by: john.zavgren at oracle.com ! src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c Changeset: f6e6c27c19f3 Author: jzavgren Date: 2013-05-31 15:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6e6c27c19f3 7188517: Check on '$' character is missing in the HttpCookie class constructor Summary: Modified the constructor code so that the cookie names are examined for leading dollar signs and if they do, an illegal argument exception is thrown. Reviewed-by: chegar, khazra, michaelm Contributed-by: john.zavgren at oracle.com ! src/share/classes/java/net/HttpCookie.java ! test/java/net/CookieHandler/TestHttpCookie.java From mike.duigou at oracle.com Fri May 31 17:32:07 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Sat, 01 Jun 2013 00:32:07 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20130601003239.7507A48EA2@hg.openjdk.java.net> Changeset: fc0b3e86fdcf Author: mduigou Date: 2013-05-31 11:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc0b3e86fdcf 8015686: {Int|Long}SummaryStatistics toString() throws IllegalFormatConversionException Reviewed-by: dholmes, alanb, psandoz ! src/share/classes/java/util/IntSummaryStatistics.java ! src/share/classes/java/util/LongSummaryStatistics.java Changeset: 198de8103df2 Author: mduigou Date: 2013-05-31 17:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/198de8103df2 Merge From paul.sandoz at oracle.com Fri May 31 01:03:03 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Fri, 31 May 2013 08:03:03 +0000 Subject: hg: jdk8/tl/jdk: 8014732: Minor spec issue: java.util.Spliterator.getExactSizeIfKnown Message-ID: <20130531080318.5C1D448E53@hg.openjdk.java.net> Changeset: b47044426bcd Author: psandoz Date: 2013-05-31 09:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b47044426bcd 8014732: Minor spec issue: java.util.Spliterator.getExactSizeIfKnown Summary: A minor documentation issue (not a spec issue). Reviewed-by: chegar, dl ! src/share/classes/java/util/Spliterator.java