From staffan.larsen at oracle.com Fri Nov 1 02:09:04 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 01 Nov 2013 09:09:04 +0000 Subject: hg: jdk8/tl/jdk: 8027692: Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt Message-ID: <20131101090942.EDA7B628D9@hg.openjdk.java.net> Changeset: c35f6df5bce9 Author: sla Date: 2013-11-01 10:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c35f6df5bce9 8027692: Remove java/lang/management/MemoryMXBean/LowMemoryTest2.sh from ProblemList.txt Reviewed-by: stefank, alanb ! test/ProblemList.txt From staffan.larsen at oracle.com Fri Nov 1 07:14:56 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 01 Nov 2013 14:14:56 +0000 Subject: hg: jdk8/tl/jdk: 8027705: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events. Message-ID: <20131101141514.DF43A628DC@hg.openjdk.java.net> Changeset: c59ccad6eb72 Author: sla Date: 2013-11-01 15:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c59ccad6eb72 8027705: com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events. Reviewed-by: dcubed ! test/com/sun/jdi/JdbMethodExitTest.sh ! test/com/sun/jdi/ShellScaffold.sh From vicente.romero at oracle.com Fri Nov 1 12:09:26 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Fri, 01 Nov 2013 19:09:26 +0000 Subject: hg: jdk8/tl/langtools: 8027660: javac crash while creating LVT entry for a local variable defined in an inner block Message-ID: <20131101190930.08985628E7@hg.openjdk.java.net> Changeset: cc80c03c41e4 Author: vromero Date: 2013-11-01 19:08 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cc80c03c41e4 8027660: javac crash while creating LVT entry for a local variable defined in an inner block Reviewed-by: jjg Contributed-by: vicente.romero at oracle.com, jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! test/tools/javac/flow/LVTHarness.java + test/tools/javac/flow/tests/TestCaseLocalInInnerBlock.java From jan.lahoda at oracle.com Fri Nov 1 13:48:45 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Fri, 01 Nov 2013 20:48:45 +0000 Subject: hg: jdk8/tl/langtools: 8027310: Annotation Processor crashes with NPE Message-ID: <20131101204857.4FF35628F2@hg.openjdk.java.net> Changeset: 8b4e1421a9b7 Author: jlahoda Date: 2013-11-01 21:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8b4e1421a9b7 8027310: Annotation Processor crashes with NPE Summary: JCAnnotation.attribute is null when annotation type is unavailable Reviewed-by: jjg, jfranck ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/processing/errors/CrashOnNonExistingAnnotation/Processor.java + test/tools/javac/processing/errors/CrashOnNonExistingAnnotation/Source.java From dan.xu at oracle.com Fri Nov 1 14:40:15 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Fri, 01 Nov 2013 21:40:15 +0000 Subject: hg: jdk8/tl/jdk: 8027624: com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again Message-ID: <20131101214044.2D64662907@hg.openjdk.java.net> Changeset: 6a6faa00acc4 Author: dxu Date: 2013-11-01 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a6faa00acc4 8027624: com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again Reviewed-by: wetmore ! test/com/sun/crypto/provider/KeyFactory/TestProviderLeak.java From john.r.rose at oracle.com Sun Nov 3 01:08:40 2013 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Sun, 03 Nov 2013 08:08:40 +0000 Subject: hg: jdk8/tl/jdk: 8024635: Caching MethodType's descriptor string improves lambda linkage performance Message-ID: <20131103080921.8CA856294D@hg.openjdk.java.net> Changeset: adcc01f5bc93 Author: jrose Date: 2013-11-02 20:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/adcc01f5bc93 8024635: Caching MethodType's descriptor string improves lambda linkage performance Summary: Better interpreted and compiled performance of operations in MethodType important to LambdaMetafactory. Reviewed-by: jrose, twisti, mchung Contributed-by: sergey.kuksenko at oracle.com ! src/share/classes/java/lang/invoke/MethodType.java From sundararajan.athijegannathan at oracle.com Sun Nov 3 21:01:48 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 04 Nov 2013 05:01:48 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20131104050151.57EF26295C@hg.openjdk.java.net> Changeset: ae5f2130c3b9 Author: sundar Date: 2013-11-01 19:54 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ae5f2130c3b9 8027700: function redeclaration checks missing for declaration binding instantiation Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! test/script/basic/JDK-8015355.js + test/script/basic/JDK-8027700.js Changeset: 98bab0cdd7bf Author: attila Date: 2013-11-01 15:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/98bab0cdd7bf 8027236: Ensure ScriptObject and ConsString aren't visible to Java Reviewed-by: lagergren, sundar ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/ConsString.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethodLinker.java ! src/jdk/nashorn/internal/runtime/linker/JavaSuperAdapterLinker.java + src/jdk/nashorn/internal/runtime/linker/NashornBeansLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java + test/script/basic/JDK-8027236.js + test/script/basic/JDK-8027236.js.EXPECTED + test/src/jdk/nashorn/api/javaaccess/ConsStringTest.java Changeset: 144861e24260 Author: sundar Date: 2013-11-04 09:29 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/144861e24260 Merge From david.holmes at oracle.com Mon Nov 4 04:01:06 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Mon, 04 Nov 2013 12:01:06 +0000 Subject: hg: jdk8/tl/jdk: 8025198: Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java Message-ID: <20131104120130.640326296D@hg.openjdk.java.net> Changeset: d19ab5da83cc Author: dholmes Date: 2013-11-04 06:58 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d19ab5da83cc 8025198: Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java Reviewed-by: martin, dholmes Contributed-by: Tristan Yan ! makefiles/CompileLaunchers.gmk ! makefiles/lib/CoreLibraries.gmk ! src/share/bin/java.c ! test/java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java From david.holmes at oracle.com Mon Nov 4 04:10:16 2013 From: david.holmes at oracle.com (David Holmes) Date: Mon, 04 Nov 2013 22:10:16 +1000 Subject: URGENT - In correct push Fwd: [JBS] (JDK-8025198) Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java In-Reply-To: References: Message-ID: <52778EA8.7020800@oracle.com> My commit pulled in a bunch of local changes that should never have been pushed (the import commit failed due to whitespace and when I re-issued the commit I didn't restrict it to the single test file). Can anyone roll this back on the actual server? Thanks, David -------- Original Message -------- Subject: [JBS] (JDK-8025198) Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java Date: Mon, 4 Nov 2013 12:03:22 +0000 (UTC) From: HG Updates (JBS) To: david.holmes at oracle.com [ https://bugs.openjdk.java.net/browse/JDK-8025198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HG Updates resolved JDK-8025198. -------------------------------- Resolved In Build: team Fix Version/s: 8 Resolution: Fixed URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d19ab5da83cc User: dholmes Date: 2013-11-04 12:01:30 +0000 > Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java > ------------------------------------------------------------------------------------- > > Key: JDK-8025198 > URL: https://bugs.openjdk.java.net/browse/JDK-8025198 > Project: JDK > Issue Type: Bug > Components: core-libs > Affects Versions: 8 > Reporter: Amy Lu > Assignee: Tristan Yan > Labels: same-binary, sqebug, teststabilization > Fix For: 8 > > > TESTFAIL:java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java > java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java failing intermittently: > #section:main > ----------messages:(3/175)---------- > command: main -XX:-UseVMInterruptibleIO ThrowingTasks > reason: User specified action: run main/othervm -XX:-UseVMInterruptibleIO ThrowingTasks > elapsed time (seconds): 480.015 > ----------System.out:(0/0)---------- > ----------System.err:(0/0)---------- > result: Error. Program `/Users/aurora/sandbox_keepme/jdk/bin/java' interrupted! (timed out?) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://bugs.openjdk.java.net/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira From Alan.Bateman at oracle.com Mon Nov 4 04:35:18 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 04 Nov 2013 12:35:18 +0000 Subject: URGENT - In correct push Fwd: [JBS] (JDK-8025198) Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java In-Reply-To: <52778EA8.7020800@oracle.com> References: <52778EA8.7020800@oracle.com> Message-ID: <52779486.3000609@oracle.com> On 04/11/2013 12:10, David Holmes wrote: > My commit pulled in a bunch of local changes that should never have > been pushed (the import commit failed due to whitespace and when I > re-issued the commit I didn't restrict it to the single test file). > > Can anyone roll this back on the actual server? It might be simpler to just push another change that anti-deltas the launcher/other changes. That would get jdk8/tl fixed up before too many people are impacted. -Alan. From david.holmes at oracle.com Mon Nov 4 04:37:47 2013 From: david.holmes at oracle.com (David Holmes) Date: Mon, 04 Nov 2013 22:37:47 +1000 Subject: URGENT - In correct push Fwd: [JBS] (JDK-8025198) Intermittent test failure: java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java In-Reply-To: <52779486.3000609@oracle.com> References: <52778EA8.7020800@oracle.com> <52779486.3000609@oracle.com> Message-ID: <5277951B.1040404@oracle.com> On 4/11/2013 10:35 PM, Alan Bateman wrote: > On 04/11/2013 12:10, David Holmes wrote: >> My commit pulled in a bunch of local changes that should never have >> been pushed (the import commit failed due to whitespace and when I >> re-issued the commit I didn't restrict it to the single test file). >> >> Can anyone roll this back on the actual server? > It might be simpler to just push another change that anti-deltas the > launcher/other changes. That would get jdk8/tl fixed up before too many > people are impacted. Okay RFR sent out to core-libs. Thanks Alan. Apologies for the mess and the noise. David > -Alan. From david.holmes at oracle.com Mon Nov 4 04:41:25 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Mon, 04 Nov 2013 12:41:25 +0000 Subject: hg: jdk8/tl/jdk: 8027755: Anti-delta incorrect push for 8025198 Message-ID: <20131104124146.37BAE6296E@hg.openjdk.java.net> Changeset: 23982079ad49 Author: dholmes Date: 2013-11-04 07:39 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23982079ad49 8027755: Anti-delta incorrect push for 8025198 Reviewed-by: alanb ! makefiles/CompileLaunchers.gmk ! makefiles/lib/CoreLibraries.gmk ! src/share/bin/java.c From brian.burkhalter at oracle.com Mon Nov 4 08:06:07 2013 From: brian.burkhalter at oracle.com (brian.burkhalter at oracle.com) Date: Mon, 04 Nov 2013 16:06:07 +0000 Subject: hg: jdk8/tl/jdk: 8027625: test/java/math/BigInteger/ExtremeShiftingTests.java needs @run tag to specify heap size Message-ID: <20131104160626.8E14E62976@hg.openjdk.java.net> Changeset: 92fb6baaebc4 Author: bpb Date: 2013-11-04 08:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92fb6baaebc4 8027625: test/java/math/BigInteger/ExtremeShiftingTests.java needs @run tag to specify heap size Summary: Add @run tag to specify heap size Reviewed-by: alanb, dxu ! test/java/math/BigInteger/ExtremeShiftingTests.java From michael.x.mcmahon at oracle.com Mon Nov 4 09:49:36 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Mon, 04 Nov 2013 17:49:36 +0000 Subject: hg: jdk8/tl/jdk: 8027687: The constructors of URLPermission class do not behave as described in javad Message-ID: <20131104174948.41A6662979@hg.openjdk.java.net> Changeset: 48449b5390fa Author: michaelm Date: 2013-11-04 17:47 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48449b5390fa 8027687: The constructors of URLPermission class do not behave as described in javad Reviewed-by: chegar, mduigou ! src/share/classes/java/net/HostPortrange.java ! src/share/classes/java/net/URLPermission.java ! test/java/net/URLPermission/URLPermissionTest.java From mark.reinhold at oracle.com Mon Nov 4 10:05:48 2013 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Mon, 04 Nov 2013 10:05:48 -0800 Subject: hg: jdk8/tl/jdk: 8027687: The constructors of URLPermission class do not behave as described in javad In-Reply-To: <20131104174948.41A6662979@hg.openjdk.java.net> References: <20131104174948.41A6662979@hg.openjdk.java.net> Message-ID: <20131104100548.539058@eggemoggin.niobe.net> 2013/11/4 1:49 -0800, michael.x.mcmahon at oracle.com: > Changeset: 48449b5390fa > Author: michaelm > Date: 2013-11-04 17:47 +0000 > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48449b5390fa > > 8027687: The constructors of URLPermission class do not behave as described in javad > Reviewed-by: chegar, mduigou What is "javad"? - Mark From robert.field at oracle.com Mon Nov 4 10:12:43 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Mon, 04 Nov 2013 18:12:43 +0000 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... Message-ID: <20131104181255.459946297B@hg.openjdk.java.net> Changeset: 51b002381b35 Author: rfield Date: 2013-11-04 10:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class 8027681: Lambda serialization fails once reflection proxy generation kicks in Reviewed-by: ksrini, briangoetz, jfranck Contributed-by: joel.franck at oracle.com, brian.goetz at oracle.com, robert.field at oracle.com ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java + test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java + test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java From joel.franck at oracle.com Mon Nov 4 10:48:27 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Mon, 04 Nov 2013 18:48:27 +0000 Subject: hg: jdk8/tl/jdk: 8016725: TEST_BUG: java/lang/reflect/Method/DefaultMethodModeling.java failing intermittently Message-ID: <20131104184839.09ABA6297C@hg.openjdk.java.net> Changeset: 78a0dcde6b67 Author: alundblad Date: 2013-11-04 15:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78a0dcde6b67 8016725: TEST_BUG: java/lang/reflect/Method/DefaultMethodModeling.java failing intermittently Summary: Moved DefaultMethodModeling.java to its own directory to avoid conflicts with Equals.java. Reviewed-by: darcy - test/java/lang/reflect/Method/DefaultMethodModeling.java + test/java/lang/reflect/Method/defaultMethodModeling/DefaultMethodModeling.java From dan.xu at oracle.com Mon Nov 4 15:48:23 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Mon, 04 Nov 2013 23:48:23 +0000 Subject: hg: jdk8/tl/jdk: 8027612: java/io/File/MaxPathLength.java fails intermittently in the clean-up stage Message-ID: <20131104234835.23B0562A32@hg.openjdk.java.net> Changeset: 6d1f3ba68db2 Author: dxu Date: 2013-11-04 15:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d1f3ba68db2 8027612: java/io/File/MaxPathLength.java fails intermittently in the clean-up stage Reviewed-by: chegar ! test/java/io/File/MaxPathLength.java From sundararajan.athijegannathan at oracle.com Mon Nov 4 20:39:17 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 05 Nov 2013 04:39:17 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20131105043919.E62D762A4D@hg.openjdk.java.net> Changeset: dcedc753fd09 Author: sundar Date: 2013-11-04 18:52 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/dcedc753fd09 8027753: Support ScriptObject to JSObject, ScriptObjectMirror, Map, Bindings auto-conversion as well as explicit wrap, unwrap Reviewed-by: jlaskey, hannesw, attila ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/api/scripting/ScriptUtils.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java + test/script/basic/JDK-8027753.js + test/script/basic/JDK-8027753.js.EXPECTED ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java ! test/src/jdk/nashorn/api/scripting/Window.java Changeset: b0d4ef6fb2db Author: sundar Date: 2013-11-05 09:13 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b0d4ef6fb2db Merge From brian.goetz at oracle.com Tue Nov 5 01:10:23 2013 From: brian.goetz at oracle.com (Brian Goetz) Date: Tue, 5 Nov 2013 09:10:23 +0000 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: <5278B27C.30303@gmail.com> References: <20131104181255.459946297B@hg.openjdk.java.net> <5278B27C.30303@gmail.com> Message-ID: <8A0932AA-6460-4E9D-8C31-3B3D26A0F2DF@oracle.com> Ineexof(char) sounds like as fast and simpler? Sent from my iPhone On Nov 5, 2013, at 8:55 AM, Peter Levart wrote: > On 11/04/2013 07:12 PM, robert.field at oracle.com wrote: >> Changeset: 51b002381b35 >> Author: rfield >> Date: 2013-11-04 10:12 -0800 >> URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35 >> >> 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class >> 8027681: Lambda serialization fails once reflection proxy generation kicks in >> Reviewed-by: ksrini, briangoetz, jfranck >> Contributed-by: joel.franck at oracle.com, brian.goetz at oracle.com, robert.field at oracle.com >> >> ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java >> ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java >> ! src/share/classes/sun/reflect/misc/ReflectUtil.java >> + test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java >> ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java >> + test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java >> > Hi Robert, > > I also propose a much faster variant of: > > + /** > + * Checks if {@code Class cls} is a VM-anonymous class > + * as defined by {@link sun.misc.Unsafe#defineAnonymousClass} > + * (not to be confused with a Java Language anonymous inner class). > + */ > + public static boolean isVMAnonymousClass(Class cls) { > + return cls.getSimpleName().contains("/"); > + } > > > The following: > > public static boolean isVMAnonymousClassFAST(Class cls) { > String name = cls.getName(); > for (int i = name.length() - 1; i >= 0; i--) { > char c = name.charAt(i); > if (c == '.') return false; > if (c == '/') return true; > } > return false; // root package > } > > It's about 12..25x faster for typical class names and doesn't produce any garbage. > > > Regards, Peter > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131105/3c6f732e/attachment.html From paul.sandoz at oracle.com Tue Nov 5 03:09:13 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Tue, 05 Nov 2013 11:09:13 +0000 Subject: hg: jdk8/tl/jdk: 8027712: DistinctOpTest fails for unordered test Message-ID: <20131105111041.08F5862A5C@hg.openjdk.java.net> Changeset: d5b3f83ffc40 Author: psandoz Date: 2013-11-05 12:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5b3f83ffc40 8027712: DistinctOpTest fails for unordered test Reviewed-by: henryjen, alanb ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java From huizhe.wang at oracle.com Tue Nov 5 11:44:50 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 05 Nov 2013 19:44:50 +0000 Subject: hg: jdk8/tl/jdk: 8027860: [TEST_BUG] File not closed in javax/xml/jaxp/parsers/8022548/XOMParserTest.java Message-ID: <20131105194503.8AA7C62A6C@hg.openjdk.java.net> Changeset: a8a044db575c Author: joehw Date: 2013-11-05 11:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8a044db575c 8027860: [TEST_BUG] File not closed in javax/xml/jaxp/parsers/8022548/XOMParserTest.java Reviewed-by: alanb ! test/javax/xml/jaxp/parsers/8022548/XOMParserTest.java From christine.lu at oracle.com Mon Nov 4 17:39:26 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Tue, 05 Nov 2013 01:39:26 +0000 Subject: hg: jdk8/tl/langtools: 8025844: Need test to provide coverage for new DocumentationTool.Location enum Message-ID: <20131105013930.5E02C62A44@hg.openjdk.java.net> Changeset: 106b8fa32d71 Author: cl Date: 2013-11-04 17:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/106b8fa32d71 8025844: Need test to provide coverage for new DocumentationTool.Location enum Reviewed-by: jjg + test/tools/javadoc/api/basic/DocumentationToolLocationTest.java From christine.lu at oracle.com Mon Nov 4 18:05:45 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Tue, 05 Nov 2013 02:05:45 +0000 Subject: hg: jdk8/tl/langtools: 8027411: javap tonga tests cleanup: write a java program to test invalid options -h and -b Message-ID: <20131105020548.ACB8262A47@hg.openjdk.java.net> Changeset: 658861d1b36e Author: cl Date: 2013-11-04 18:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/658861d1b36e 8027411: javap tonga tests cleanup: write a java program to test invalid options -h and -b Reviewed-by: jjg + test/tools/javap/InvalidOptions.java From christine.lu at oracle.com Mon Nov 4 18:52:45 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Tue, 05 Nov 2013 02:52:45 +0000 Subject: hg: jdk8/tl/langtools: 8027530: javap tonga tests cleanup: test -public, -protected, -package, -private options Message-ID: <20131105025248.5695E62A4C@hg.openjdk.java.net> Changeset: 126dc007ba3f Author: cl Date: 2013-11-04 18:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/126dc007ba3f 8027530: javap tonga tests cleanup: test -public, -protected, -package, -private options Reviewed-by: jjg + test/tools/javap/AccessModifiers.java From peter.levart at gmail.com Tue Nov 5 00:25:57 2013 From: peter.levart at gmail.com (Peter Levart) Date: Tue, 05 Nov 2013 09:25:57 +0100 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: <20131104181255.459946297B@hg.openjdk.java.net> References: <20131104181255.459946297B@hg.openjdk.java.net> Message-ID: <5278AB95.6000707@gmail.com> Hi Robert, I think this fix is not complete. When one sets the system property sun.reflect.noInflation=true, reflection proxy is still attempted to be generated for anonymous classes (see ReflectionFactory.newMethodAccessor/newConstructorAccessor). I would also restructure the Method/Constructor accessor logic differently. The check for ReflectUtil.isVMAnonymousClass() can be performed just once (in the newMethodAccessor/newConstructorAccessor methods) and based on this check, create accessor: - for classic declaring class - as is / unchanged - for anonymous declaring class - just create and return NativeMethodAccessorImpl without a parent Then in NativeMethodAccessorImpl (and same for constructor), modify the inflation checking logic: if (*parent != null && *++numInvocations > ReflectionFactory.inflationThreshold()) { MethodAccessorImpl acc = (MethodAccessorImpl) new MethodAccessorGenerator(). generateMethod(method.getDeclaringClass(), method.getName(), method.getParameterTypes(), method.getReturnType(), method.getExceptionTypes(), method.getModifiers()); parent.setDelegate(acc); } Regards, Peter On 11/04/2013 07:12 PM, robert.field at oracle.com wrote: > Changeset: 51b002381b35 > Author: rfield > Date: 2013-11-04 10:12 -0800 > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35 > > 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class > 8027681: Lambda serialization fails once reflection proxy generation kicks in > Reviewed-by: ksrini, briangoetz, jfranck > Contributed-by: joel.franck at oracle.com, brian.goetz at oracle.com, robert.field at oracle.com > > ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java > ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java > ! src/share/classes/sun/reflect/misc/ReflectUtil.java > + test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java > ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java > + test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131105/843ef925/attachment.html From peter.levart at gmail.com Tue Nov 5 00:55:24 2013 From: peter.levart at gmail.com (Peter Levart) Date: Tue, 05 Nov 2013 09:55:24 +0100 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: <20131104181255.459946297B@hg.openjdk.java.net> References: <20131104181255.459946297B@hg.openjdk.java.net> Message-ID: <5278B27C.30303@gmail.com> On 11/04/2013 07:12 PM, robert.field at oracle.com wrote: > Changeset: 51b002381b35 > Author: rfield > Date: 2013-11-04 10:12 -0800 > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35 > > 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class > 8027681: Lambda serialization fails once reflection proxy generation kicks in > Reviewed-by: ksrini, briangoetz, jfranck > Contributed-by: joel.franck at oracle.com, brian.goetz at oracle.com, robert.field at oracle.com > > ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java > ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java > ! src/share/classes/sun/reflect/misc/ReflectUtil.java > + test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java > ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java > + test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java > Hi Robert, I also propose a much faster variant of: + /** + * Checks if {@code Class cls} is a VM-anonymous class + * as defined by {@link sun.misc.Unsafe#defineAnonymousClass} + * (not to be confused with a Java Language anonymous inner class). + */ + public static boolean isVMAnonymousClass(Class cls) { + return cls.getSimpleName().contains("/"); + } The following: public static boolean isVMAnonymousClassFAST(Class cls) { String name = cls.getName(); for (int i = name.length() - 1; i >= 0; i--) { char c = name.charAt(i); if (c == '.') return false; if (c == '/') return true; } return false; // root package } It's about 12..25x faster for typical class names and doesn't produce any garbage. Regards, Peter -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131105/bc633df5/attachment.html From konstantin.shefov at oracle.com Tue Nov 5 01:10:22 2013 From: konstantin.shefov at oracle.com (konstantin.shefov at oracle.com) Date: Tue, 05 Nov 2013 09:10:22 +0000 Subject: hg: jdk8/tl/nashorn: 8027708: NASHORN TEST: Create Nashorn test that draws image step-by-step using JavaFX canvas. Message-ID: <20131105091023.DAE5162A58@hg.openjdk.java.net> Changeset: bda654c6d59c Author: kshefov Date: 2013-11-05 13:09 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bda654c6d59c 8027708: NASHORN TEST: Create Nashorn test that draws image step-by-step using JavaFX canvas. Reviewed-by: jlaskey, lagergren ! make/build.xml ! make/project.properties ! test/script/jfx.js ! test/script/jfx/flyingimage.js ! test/script/jfx/flyingimage/flyingimage.png ! test/script/jfx/flyingimage/golden/linux.png ! test/script/jfx/flyingimage/golden/macosx.png ! test/script/jfx/flyingimage/golden/windows.png ! test/script/jfx/kaleidoscope.js ! test/script/jfx/kaleidoscope/golden/linux.png ! test/script/jfx/kaleidoscope/golden/macosx.png ! test/script/jfx/kaleidoscope/golden/windows.png + test/script/jfx/spread.js + test/script/jfx/spread/golden/linux.png + test/script/jfx/spread/golden/macosx.png + test/script/jfx/spread/golden/windows.png From mandy.chung at oracle.com Tue Nov 5 17:33:35 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 06 Nov 2013 01:33:35 +0000 Subject: hg: jdk8/tl/jdk: 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java; ... Message-ID: <20131106013347.C2A5E62A89@hg.openjdk.java.net> Changeset: 85fd2ae0a845 Author: mchung Date: 2013-11-05 17:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85fd2ae0a845 8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java 6944188: ThreadMXBean/ThreadStateTest.java fails intermittently Reviewed-by: dholmes, chegar + test/java/lang/Thread/ThreadStateController.java ! test/java/lang/Thread/ThreadStateTest.java + test/java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java - test/java/lang/management/ThreadMXBean/ThreadStateTest.java From jan.lahoda at oracle.com Wed Nov 6 08:50:37 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Wed, 06 Nov 2013 16:50:37 +0000 Subject: hg: jdk8/tl/langtools: 8027281: Incorrect invokespecial generated for JCK lang EXPR/expr636/expr63602m* tests Message-ID: <20131106165047.9E584623C6@hg.openjdk.java.net> Changeset: 75c8cde12ab6 Author: jlahoda Date: 2013-11-06 17:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/75c8cde12ab6 8027281: Incorrect invokespecial generated for JCK lang EXPR/expr636/expr63602m* tests Summary: When invoking interface default method via a superclass, use the direct superclass in the reference. Reviewed-by: vromero, dlsmith, jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/defaultMethods/super/TestDirectSuperInterfaceInvoke.java From mike.duigou at oracle.com Wed Nov 6 09:50:48 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 06 Nov 2013 17:50:48 +0000 Subject: hg: jdk8/tl/jdk: 8021309: replace test/Makefile jdk_* targets with jtreg groups; ... Message-ID: <20131106175102.D607F623C9@hg.openjdk.java.net> Changeset: 9c30cbc316e9 Author: mduigou Date: 2013-11-05 19:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c30cbc316e9 8021309: replace test/Makefile jdk_* targets with jtreg groups 8015068: Use jtreg -exclude for handling problemList.txt exclusions Reviewed-by: jjg, smarks, chegar, alanb, dholmes ! .hgignore ! test/Makefile From dan.xu at oracle.com Wed Nov 6 13:26:25 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Wed, 06 Nov 2013 21:26:25 +0000 Subject: hg: jdk8/tl/jdk: 8025698: (fs) Typo in exception thrown by encode() in UnixPath.java Message-ID: <20131106212658.DEC6E623DA@hg.openjdk.java.net> Changeset: 6ea1f9d8ec78 Author: dxu Date: 2013-11-06 13:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ea1f9d8ec78 8025698: (fs) Typo in exception thrown by encode() in UnixPath.java Reviewed-by: dxu, mduigou, henryjen, weijun Contributed-by: ajuckel at gmail.com ! src/solaris/classes/sun/nio/fs/UnixPath.java From peter.levart at gmail.com Wed Nov 6 11:30:25 2013 From: peter.levart at gmail.com (Peter Levart) Date: Wed, 06 Nov 2013 20:30:25 +0100 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: <8A0932AA-6460-4E9D-8C31-3B3D26A0F2DF@oracle.com> References: <20131104181255.459946297B@hg.openjdk.java.net> <5278B27C.30303@gmail.com> <8A0932AA-6460-4E9D-8C31-3B3D26A0F2DF@oracle.com> Message-ID: <527A98D1.4080906@gmail.com> On 11/05/2013 10:10 AM, Brian Goetz wrote: > Ineexof(char) sounds like as fast and simpler? Well, indexOf(char) or lastIndexOf(char) searches for a single char. We can do better searching backwards for two chars at the same time. If the "name" of VM-anonymous class is always ending with pattern: "slash followed by some decimal digits" then the following would be even faster: public static boolean isVMAnonymousClassFAST(Class cls) { String name = cls.getName(); for (int i = name.length() - 1; i >= 0; i--) { char c = name.charAt(i); if (c == '/') return true; if (c < '0' || c > '9') return false; } return false; } Regards, Peter > > Sent from my iPhone > > On Nov 5, 2013, at 8:55 AM, Peter Levart > wrote: > >> On 11/04/2013 07:12 PM, robert.field at oracle.com wrote: >>> Changeset: 51b002381b35 >>> Author: rfield >>> Date: 2013-11-04 10:12 -0800 >>> URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35 >>> >>> 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class >>> 8027681: Lambda serialization fails once reflection proxy generation kicks in >>> Reviewed-by: ksrini, briangoetz, jfranck >>> Contributed-by:joel.franck at oracle.com,brian.goetz at oracle.com,robert.field at oracle.com >>> >>> ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java >>> ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java >>> ! src/share/classes/sun/reflect/misc/ReflectUtil.java >>> + test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java >>> ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java >>> + test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java >>> >> Hi Robert, >> >> I also propose a much faster variant of: >> >> + /** >> + * Checks if {@code Class cls} is a VM-anonymous class >> + * as defined by {@link sun.misc.Unsafe#defineAnonymousClass} >> + * (not to be confused with a Java Language anonymous inner class). >> + */ >> + public static boolean isVMAnonymousClass(Class cls) { >> + return cls.getSimpleName().contains("/"); >> + } >> >> >> The following: >> >> public static boolean isVMAnonymousClassFAST(Class cls) { >> String name = cls.getName(); >> for (int i = name.length() - 1; i >= 0; i--) { >> char c = name.charAt(i); >> if (c == '.') return false; >> if (c == '/') return true; >> } >> return false; // root package >> } >> >> It's about 12..25x faster for typical class names and doesn't produce >> any garbage. >> >> >> Regards, Peter >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131106/af56a34a/attachment.html From kumar.x.srinivasan at oracle.com Wed Nov 6 15:34:56 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Wed, 06 Nov 2013 23:34:56 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131106233521.C1A77623E4@hg.openjdk.java.net> Changeset: 81cbdd5876e8 Author: ksrini Date: 2013-11-06 11:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81cbdd5876e8 8027227: [asm] generate CONSTANT_InterfaceMethodref for invoke{special/static) of non-abstract methods on ifaces Reviewed-by: ksrini, lagergren Contributed-by: ebruneton at free.fr, forax at univ-mlv.fr, john.r.rose at oracle.com, paul.sandoz at oracle.com ! src/share/classes/jdk/internal/org/objectweb/asm/ByteVector.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java ! src/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/Handle.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/MethodWriter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AdviceAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/AnalyzerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/CodeSizeEvaluator.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/GeneratorAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/InstructionAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/JSRInlinerAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/LocalVariablesSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingSignatureAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/SerialVersionUIDAdder.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/StaticInitMerger.java ! src/share/classes/jdk/internal/org/objectweb/asm/commons/TryCatchBlockSorter.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/AnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/ClassNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodInsnNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeAnnotationNode.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckFieldAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/CheckMethodAdapter.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Printer.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/Textifier.java ! src/share/classes/jdk/internal/org/objectweb/asm/util/TraceMethodVisitor.java ! src/share/classes/jdk/internal/org/objectweb/asm/version.txt Changeset: dbda97d6aa3a Author: ksrini Date: 2013-11-06 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dbda97d6aa3a 8027232: Update j.l.invoke code generating class files to use ASM enhancements for invocation of non-abstract methods on ifaces Reviewed-by: ksrini, rfield Contributed-by: john.r.rose at oracle.com, paul.sandoz at oracle.com ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/TypeConvertingMethodAdapter.java + test/java/lang/invoke/lambda/LambdaAsm.java From john.r.rose at oracle.com Wed Nov 6 17:20:39 2013 From: john.r.rose at oracle.com (John Rose) Date: Wed, 6 Nov 2013 17:20:39 -0800 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: <527A98D1.4080906@gmail.com> References: <20131104181255.459946297B@hg.openjdk.java.net> <5278B27C.30303@gmail.com> <8A0932AA-6460-4E9D-8C31-3B3D26A0F2DF@oracle.com> <527A98D1.4080906@gmail.com> Message-ID: <5AAEA553-6A71-43FD-A7BA-A001BA2D5128@oracle.com> On Nov 6, 2013, at 11:30 AM, Peter Levart wrote: > Well, indexOf(char) or lastIndexOf(char) searches for a single char. We can do better searching backwards for two chars at the same time. > > If the "name" of VM-anonymous class is always ending with pattern: "slash followed by some decimal digits" then the following would be even faster: Although this reasoning is plausible, it is not a reliable conclusion, and should not drive edits of Java code without careful measurement. The reasoning assumes a performance model based on the interpreter and bytecode count. But performance depends on native code produced by the JIT. An optimizing JIT will usually transform the code deeply. For string scanning, for example, HotSpot has an intrinsic for String.indexOf(String) that uses totally different code from a user-coded loop. (It is not currently so for String.indexOf(int), but String.indexOf("/") is potentially very fast.) Also, with your example code, the combined loop may often be faster than two back-to-back loops, but simpler loops can sometimes be vectorized more robustly, to the point where back-to-back simple loops, if vectorized, may be competitive with a hand-fused loop. So loop complexity and method intrinsics can create surprises for those who rely on simple performance modesl Some day we will get to a world where loops are specified stream-wise, and robustly optimized without this sort of manual intervention. In the mean time, be careful about advising hand-optimizations of Java code. They can backfire, by confusing the JIT and preventing optimizations that would apply to simpler code. ? John -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131106/d25bc1bb/attachment.html From vitalyd at gmail.com Wed Nov 6 17:32:26 2013 From: vitalyd at gmail.com (Boris Davidovich) Date: Wed, 6 Nov 2013 20:32:26 -0500 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: <5AAEA553-6A71-43FD-A7BA-A001BA2D5128@oracle.com> References: <20131104181255.459946297B@hg.openjdk.java.net> <5278B27C.30303@gmail.com> <8A0932AA-6460-4E9D-8C31-3B3D26A0F2DF@oracle.com> <527A98D1.4080906@gmail.com> <5AAEA553-6A71-43FD-A7BA-A001BA2D5128@oracle.com> Message-ID: John, Just curious here - the String.indexOf(String) will have to fetch the arg string from memory somewhere (how are constant pool entries handled by the way? Is their address patched in or is it a lookup into the StringTable?). If it's not in cache, that could be tens if not hundreds of cycles. With char, the search value is an immediate so no additional mem fetches. For short strings (I'm assuming this case falls into that category) I don't think intrinsic is all that beneficial given that it can miss on memory. I agree that measurement is needed, but mental model (even taking intrinsic into account) seems to imply that char code would run faster, especially if searching backwards is more likely to terminate loop sooner. Am I missing something? Thanks Sent from my phone On Nov 6, 2013 8:21 PM, "John Rose" wrote: > On Nov 6, 2013, at 11:30 AM, Peter Levart wrote: > > > Well, indexOf(char) or lastIndexOf(char) searches for a single char. We > can do better searching backwards for two chars at the same time. > > > > If the "name" of VM-anonymous class is always ending with pattern: > "slash followed by some decimal digits" then the following would be even > faster: > > Although this reasoning is plausible, it is not a reliable conclusion, and > should not drive edits of Java code without careful measurement. The > reasoning assumes a performance model based on the interpreter and bytecode > count. But performance depends on native code produced by the JIT. > > An optimizing JIT will usually transform the code deeply. For string > scanning, for example, HotSpot has an intrinsic for String.indexOf(String) > that uses totally different code from a user-coded loop. (It is not > currently so for String.indexOf(int), but String.indexOf("/") is > potentially very fast.) > > Also, with your example code, the combined loop may often be faster than > two back-to-back loops, but simpler loops can sometimes be vectorized more > robustly, to the point where back-to-back simple loops, if vectorized, may > be competitive with a hand-fused loop. > > So loop complexity and method intrinsics can create surprises for those > who rely on simple performance modesl > > Some day we will get to a world where loops are specified stream-wise, and > robustly optimized without this sort of manual intervention. In the mean > time, be careful about advising hand-optimizations of Java code. They can > backfire, by confusing the JIT and preventing optimizations that would > apply to simpler code. > > ? John -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131106/7f97bb37/attachment-0001.html From john.r.rose at oracle.com Wed Nov 6 20:35:05 2013 From: john.r.rose at oracle.com (John Rose) Date: Wed, 6 Nov 2013 20:35:05 -0800 Subject: hg: jdk8/tl/jdk: 7194897: JSR 292: Cannot create more than 16 instances of an anonymous class; ... In-Reply-To: References: <20131104181255.459946297B@hg.openjdk.java.net> <5278B27C.30303@gmail.com> <8A0932AA-6460-4E9D-8C31-3B3D26A0F2DF@oracle.com> <527A98D1.4080906@gmail.com> <5AAEA553-6A71-43FD-A7BA-A001BA2D5128@oracle.com> Message-ID: <6A6625E5-57F7-416B-B0C2-81FACE3B71FF@oracle.com> On Nov 6, 2013, at 5:32 PM, Boris Davidovich wrote: > Am I missing something? > The intrinsic would be looking at a constant string. ? John -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131106/8cda7168/attachment.html From chris.hegarty at oracle.com Thu Nov 7 01:06:07 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 07 Nov 2013 09:06:07 +0000 Subject: hg: jdk8/tl/jdk: 8027822: ProblemList.txt Updates (11/2013) Message-ID: <20131107090621.4C161623EC@hg.openjdk.java.net> Changeset: f37d62e295c0 Author: chegar Date: 2013-11-07 08:04 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f37d62e295c0 8027822: ProblemList.txt Updates (11/2013) Reviewed-by: chegar, alanb Contributed-by: Amy Lu ! test/ProblemList.txt From chris.hegarty at oracle.com Thu Nov 7 01:24:31 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 07 Nov 2013 09:24:31 +0000 Subject: hg: jdk8/tl/jdk: 8027961: Inet[4|6]Address native initializing code should check field/MethodID values Message-ID: <20131107092443.B985C623EF@hg.openjdk.java.net> Changeset: 82b276590b85 Author: chegar Date: 2013-11-07 08:23 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82b276590b85 8027961: Inet[4|6]Address native initializing code should check field/MethodID values Reviewed-by: michaelm, rriggs ! src/share/native/java/net/Inet4Address.c ! src/share/native/java/net/Inet6Address.c ! src/share/native/java/net/InetAddress.c ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/windows/native/java/net/Inet4AddressImpl.c ! src/windows/native/java/net/Inet6AddressImpl.c From michael.x.mcmahon at oracle.com Thu Nov 7 02:43:33 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 07 Nov 2013 10:43:33 +0000 Subject: hg: jdk8/tl/jdk: 8027881: test/java/net/URLPermission/nstest/LookupTest.java failing intermittently, output insufficient Message-ID: <20131107104346.E8CAB623F2@hg.openjdk.java.net> Changeset: 88d1ed05a246 Author: michaelm Date: 2013-11-07 10:22 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88d1ed05a246 8027881: test/java/net/URLPermission/nstest/LookupTest.java failing intermittently, output insufficient Reviewed-by: chegar ! test/java/net/URLPermission/URLPermissionTest.java ! test/java/net/URLPermission/nstest/LookupTest.java + test/java/net/URLPermission/nstest/lookup.sh - test/java/net/URLPermission/nstest/policy From joel.franck at oracle.com Thu Nov 7 04:35:37 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Thu, 07 Nov 2013 12:35:37 +0000 Subject: hg: jdk8/tl/jdk: 8027796: Refactor Core Reflection for Type Annotations Message-ID: <20131107123551.69603623FB@hg.openjdk.java.net> Changeset: 44fa6bf42846 Author: jfranck Date: 2013-11-07 13:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44fa6bf42846 8027796: Refactor Core Reflection for Type Annotations Reviewed-by: psandoz ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/annotation/TypeAnnotation.java ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java From sundararajan.athijegannathan at oracle.com Thu Nov 7 06:17:15 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 07 Nov 2013 14:17:15 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20131107141717.77C2F623FE@hg.openjdk.java.net> Changeset: 2f07b4234451 Author: sundar Date: 2013-11-07 17:26 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2f07b4234451 8027828: ClassCastException when converting return value of a Java method to boolean Reviewed-by: jlaskey, attila ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/api/scripting/ScriptUtils.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java + test/script/basic/JDK-8027828.js + test/script/basic/JDK-8027828.js.EXPECTED + test/script/basic/convert.js + test/script/basic/convert.js.EXPECTED ! test/src/jdk/nashorn/api/scripting/ScriptObjectMirrorTest.java Changeset: 3b794f364c77 Author: sundar Date: 2013-11-07 18:11 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3b794f364c77 Merge From sean.mullan at oracle.com Thu Nov 7 08:26:12 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 07 Nov 2013 11:26:12 -0500 Subject: Updated group web page Message-ID: <527BBF24.90404@oracle.com> Hi, I have updated the OpenJDK Security Group web page [1] with a few changes: - added more links to member blogs - updated links from JDK 6 to JDK 7 - fixed broken link to Java Security book - added macosx source packages - and other small misc. changes If you have any comments/feedback, please let us know. Thanks, Sean [1] http://openjdk.java.net/groups/security/ From naoto.sato at oracle.com Thu Nov 7 10:04:06 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Thu, 07 Nov 2013 18:04:06 +0000 Subject: hg: jdk8/tl/jdk: 8027930: ResourceBundle test failures in fr locale Message-ID: <20131107180439.48B1C6240F@hg.openjdk.java.net> Changeset: fb7abd509bd2 Author: naoto Date: 2013-11-07 10:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fb7abd509bd2 8027930: ResourceBundle test failures in fr locale Reviewed-by: smarks ! test/java/util/ResourceBundle/ResourceBundleTest.java ! test/java/util/ResourceBundle/getBaseBundleName/TestGetBaseBundleName.java From roger.riggs at oracle.com Thu Nov 7 17:58:40 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 08 Nov 2013 01:58:40 +0000 Subject: hg: jdk8/tl/jdk: 8024458: DataInput.readDouble refers to "readlong" instead of "readLong" Message-ID: <20131108015854.EDA3B62455@hg.openjdk.java.net> Changeset: 04f071a95c29 Author: rriggs Date: 2013-11-07 20:56 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04f071a95c29 8024458: DataInput.readDouble refers to "readlong" instead of "readLong" Summary: fix the typo Reviewed-by: lancea, chegar, dxu ! src/share/classes/java/io/DataInput.java From joe.darcy at oracle.com Thu Nov 7 20:12:08 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 08 Nov 2013 04:12:08 +0000 Subject: hg: jdk8/tl/langtools: 8027730: Fix release-8 type visitors to support intersection types Message-ID: <20131108041211.CF47C62459@hg.openjdk.java.net> Changeset: e39bd9401ea5 Author: darcy Date: 2013-11-07 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39bd9401ea5 8027730: Fix release-8 type visitors to support intersection types Reviewed-by: jjg, jlahoda, sogoel ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor8.java + test/tools/javac/processing/model/util/TestIntersectionTypeVisitors.java From mandy.chung at oracle.com Thu Nov 7 20:48:59 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 08 Nov 2013 04:48:59 +0000 Subject: hg: jdk8/tl/corba: 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45 Message-ID: <20131108044900.953AD6245A@hg.openjdk.java.net> Changeset: b99535e22efe Author: mchung Date: 2013-11-07 20:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/b99535e22efe 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45 Reviewed-by: msheppar, alanb, lancea ! src/share/classes/com/sun/corba/se/spi/orbutil/proxy/CompositeInvocationHandlerImpl.java From staffan.larsen at oracle.com Fri Nov 8 01:04:08 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 08 Nov 2013 09:04:08 +0000 Subject: hg: jdk8/tl/jdk: 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object Message-ID: <20131108090422.B49BD62469@hg.openjdk.java.net> Changeset: 8a4405fb40ba Author: ykantser Date: 2013-11-07 16:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a4405fb40ba 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object Reviewed-by: sla, jbachorik ! test/sun/tools/jstatd/JstatdTest.java From mandy.chung at oracle.com Fri Nov 8 07:55:05 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 08 Nov 2013 15:55:05 +0000 Subject: hg: jdk8/tl/jdk: 8027351: (ref) Private finalize method invoked in preference to protected superclass method Message-ID: <20131108155536.2E54962470@hg.openjdk.java.net> Changeset: 41d7ce111bd8 Author: mchung Date: 2013-11-08 07:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41d7ce111bd8 8027351: (ref) Private finalize method invoked in preference to protected superclass method Reviewed-by: alanb, dholmes, mr, plevart, psandoz ! makefiles/lib/CoreLibraries.gmk ! makefiles/mapfiles/libjava/mapfile-vers ! makefiles/mapfiles/libjava/reorder-sparc ! makefiles/mapfiles/libjava/reorder-sparcv9 ! makefiles/mapfiles/libjava/reorder-x86 ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/ref/Finalizer.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/misc/VM.java + test/java/lang/ref/FinalizeOverride.java From chris.hegarty at oracle.com Fri Nov 8 08:13:27 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 08 Nov 2013 16:13:27 +0000 Subject: hg: jdk8/tl/jdk: 8022963: java/net/NetworkInterface/Equals.java fails equality for Windows Teredo Interface Message-ID: <20131108161339.A426462472@hg.openjdk.java.net> Changeset: 3112729d6b74 Author: tyan Date: 2013-11-08 15:12 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3112729d6b74 8022963: java/net/NetworkInterface/Equals.java fails equality for Windows Teredo Interface Reviewed-by: chegar ! test/java/net/MulticastSocket/TestInterfaces.java ! test/java/net/NetworkInterface/Equals.java From chris.hegarty at oracle.com Fri Nov 8 08:17:23 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 08 Nov 2013 16:17:23 +0000 Subject: hg: jdk8/tl/jdk: 8019834: InetAddress.getByName hangs for bad IPv6 literals Message-ID: <20131108161736.E58A062473@hg.openjdk.java.net> Changeset: 771c77b49bb6 Author: chegar Date: 2013-11-08 15:15 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/771c77b49bb6 8019834: InetAddress.getByName hangs for bad IPv6 literals Reviewed-by: alanb ! src/share/classes/java/net/InetAddress.java ! test/java/net/ipv6tests/BadIPv6Addresses.java From mandy.chung at oracle.com Fri Nov 8 09:44:27 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 08 Nov 2013 17:44:27 +0000 Subject: hg: jdk8/tl/jdk: 8028069: (ref) Finalizer.c not deleted in the changeset for JDK-8027351 Message-ID: <20131108174442.42C5662476@hg.openjdk.java.net> Changeset: 1c9ba18198d5 Author: mchung Date: 2013-11-08 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c9ba18198d5 8028069: (ref) Finalizer.c not deleted in the changeset for JDK-8027351 Reviewed-by: alanb - src/share/native/java/lang/ref/Finalizer.c From chris.hegarty at oracle.com Fri Nov 8 10:56:10 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 08 Nov 2013 18:56:10 +0000 Subject: hg: jdk8/tl/jdk: 8023462: TEST_BUG: test/com/sun/net/httpserver/bugs/B6433018.java fails on slow/single core machine Message-ID: <20131108185622.442AF6247A@hg.openjdk.java.net> Changeset: 46982ca895b4 Author: tyan Date: 2013-11-08 18:54 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46982ca895b4 8023462: TEST_BUG: test/com/sun/net/httpserver/bugs/B6433018.java fails on slow/single core machine Reviewed-by: chegar ! test/com/sun/net/httpserver/bugs/B6433018.java From mandy.chung at oracle.com Fri Nov 8 12:14:00 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 08 Nov 2013 20:14:00 +0000 Subject: hg: jdk8/tl/jdk: 8025985: com.sun.management.OSMBeanFactory should not be public Message-ID: <20131108201413.E279E62480@hg.openjdk.java.net> Changeset: 40ca9e4866de Author: mchung Date: 2013-11-08 12:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40ca9e4866de 8025985: com.sun.management.OSMBeanFactory should not be public Reviewed-by: alanb, erikj, ihse, jbachorik ! makefiles/lib/ServiceabilityLibraries.gmk ! makefiles/mapfiles/libmanagement/mapfile-vers + src/share/classes/sun/management/BaseOperatingSystemImpl.java ! src/share/classes/sun/management/ManagementFactoryHelper.java - src/share/classes/sun/management/OperatingSystemImpl.java - src/solaris/classes/com/sun/management/OSMBeanFactory.java - src/solaris/classes/com/sun/management/UnixOperatingSystem.java + src/solaris/classes/sun/management/OperatingSystemImpl.java - src/solaris/native/com/sun/management/LinuxOperatingSystem.c - src/solaris/native/com/sun/management/MacosxOperatingSystem.c - src/solaris/native/com/sun/management/SolarisOperatingSystem.c - src/solaris/native/com/sun/management/UnixOperatingSystem_md.c + src/solaris/native/sun/management/LinuxOperatingSystem.c + src/solaris/native/sun/management/MacosxOperatingSystem.c + src/solaris/native/sun/management/OperatingSystemImpl.c + src/solaris/native/sun/management/SolarisOperatingSystem.c - src/windows/classes/com/sun/management/OSMBeanFactory.java - src/windows/classes/com/sun/management/OperatingSystem.java + src/windows/classes/sun/management/OperatingSystemImpl.java - src/windows/native/com/sun/management/OperatingSystem_md.c + src/windows/native/sun/management/OperatingSystemImpl.c From joe.darcy at oracle.com Fri Nov 8 12:19:39 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 08 Nov 2013 20:19:39 +0000 Subject: hg: jdk8/tl/jdk: 8028076: Correct raw type lint warnings in core reflection implementation classes Message-ID: <20131108201953.3E21B62483@hg.openjdk.java.net> Changeset: 11376ad23e21 Author: darcy Date: 2013-11-08 12:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11376ad23e21 8028076: Correct raw type lint warnings in core reflection implementation classes Reviewed-by: lancea, alanb ! src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java ! src/share/classes/sun/reflect/generics/repository/GenericDeclRepository.java From alan.bateman at oracle.com Fri Nov 8 13:14:47 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 08 Nov 2013 21:14:47 +0000 Subject: hg: jdk8/tl/jdk: 8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host name starts with a-f Message-ID: <20131108211501.630EE62488@hg.openjdk.java.net> Changeset: 50df04934e86 Author: alanb Date: 2013-11-08 21:07 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50df04934e86 8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host name starts with a-f Reviewed-by: chegar ! src/share/classes/java/net/InetAddress.java From bernd-2013 at eckenfels.net Fri Nov 8 13:34:41 2013 From: bernd-2013 at eckenfels.net (Bernd Eckenfels) Date: Fri, 08 Nov 2013 22:34:41 +0100 Subject: qualified host parameter for UnknownHostException? (was: hg: jdk8/tl/jdk: 8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host name starts with a-f) In-Reply-To: <20131108211501.630EE62488@hg.openjdk.java.net> References: <20131108211501.630EE62488@hg.openjdk.java.net> Message-ID: Hello, BTW: it would be good if UHE had a data member of the not-found host value. Actually the javadoc hints in that direction: # public UnknownHostException(String host) # # Parameters: # host - the detail message. which is quite confusing. Maybe a new constructor like UHE(String cause, String host, String osError) would be really usefull? Gruss Bernd -- http://bernd.eckenfels.net From yong.huang at oracle.com Thu Nov 7 22:34:08 2013 From: yong.huang at oracle.com (yong.huang at oracle.com) Date: Fri, 08 Nov 2013 06:34:08 +0000 Subject: hg: jdk8/tl/jdk: 8027695: There should be a space before % sign in Swedish locale Message-ID: <20131108063422.B41126245E@hg.openjdk.java.net> Changeset: e10a182c973a Author: yhuang Date: 2013-11-07 22:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e10a182c973a 8027695: There should be a space before % sign in Swedish locale Reviewed-by: naoto ! src/share/classes/sun/text/resources/sv/FormatData_sv_SE.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java From jaroslav.bachorik at oracle.com Thu Nov 7 23:48:40 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Fri, 08 Nov 2013 07:48:40 +0000 Subject: hg: jdk8/tl/jdk: 8007984: Null pointer dereference in jdk/linux-amd64/democlasses/demo/jvmti/heapTracker/src/java_crw_demo.c Message-ID: <20131108074852.ADE2362461@hg.openjdk.java.net> Changeset: b5748857ef42 Author: jbachorik Date: 2013-11-08 08:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b5748857ef42 8007984: Null pointer dereference in jdk/linux-amd64/democlasses/demo/jvmti/heapTracker/src/java_crw_demo.c Reviewed-by: dholmes ! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c From roger.riggs at oracle.com Fri Nov 8 15:52:52 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 08 Nov 2013 23:52:52 +0000 Subject: hg: jdk8/tl/jdk: 8028041: Serialized Form description of j.l.String is not consistent with the implementation Message-ID: <20131108235304.9453E6248E@hg.openjdk.java.net> Changeset: df2f7f288353 Author: rriggs Date: 2013-11-08 17:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df2f7f288353 8028041: Serialized Form description of j.l.String is not consistent with the implementation Summary: Replaced incorrect description with reference to the serialization specification Reviewed-by: alanb, smarks ! src/share/classes/java/lang/String.java From lana.steuck at oracle.com Fri Nov 8 20:49:32 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:32 +0000 Subject: hg: jdk8/tl/corba: 4 new changesets Message-ID: <20131109044935.16142624A0@hg.openjdk.java.net> Changeset: d425685e0b74 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d425685e0b74 Added tag jdk8-b114 for changeset 0bbccf77c23e ! .hgtags Changeset: 8d07115924b7 Author: lana Date: 2013-10-31 16:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/8d07115924b7 Merge Changeset: 5fdc44652089 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5fdc44652089 Added tag jdk8-b115 for changeset 8d07115924b7 ! .hgtags Changeset: 4796555c4dc8 Author: lana Date: 2013-11-08 17:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/4796555c4dc8 Merge From lana.steuck at oracle.com Fri Nov 8 20:49:45 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:45 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20131109044958.ECB0A624A4@hg.openjdk.java.net> Changeset: fea486d30d41 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fea486d30d41 Added tag jdk8-b114 for changeset 850d2602ae98 ! .hgtags Changeset: 6b4d6205366c Author: lana Date: 2013-10-31 16:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6b4d6205366c Merge - test/tools/javac/ExtDirs/ext1/pkg1.jar - test/tools/javac/ExtDirs/ext2/pkg2.jar - test/tools/javac/ExtDirs/ext3/pkg1.jar - test/tools/javac/ExtDirs/ext3/pkg2.jar - test/tools/javac/T8019486/WrongLVTForLambdaTest.java Changeset: 3c040b04af05 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3c040b04af05 Added tag jdk8-b115 for changeset 6b4d6205366c ! .hgtags Changeset: 21294feaf311 Author: lana Date: 2013-11-08 17:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/21294feaf311 Merge From lana.steuck at oracle.com Fri Nov 8 20:49:37 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:37 +0000 Subject: hg: jdk8/tl/jaxp: 3 new changesets Message-ID: <20131109044945.B4268624A3@hg.openjdk.java.net> Changeset: d3b6da1b3e25 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d3b6da1b3e25 Added tag jdk8-b114 for changeset 1b1e12117fe2 ! .hgtags Changeset: f610fd46463e Author: lana Date: 2013-10-31 16:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f610fd46463e Merge Changeset: e757eb9aee3d Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e757eb9aee3d Added tag jdk8-b115 for changeset f610fd46463e ! .hgtags From lana.steuck at oracle.com Fri Nov 8 20:49:32 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:32 +0000 Subject: hg: jdk8/tl: 3 new changesets Message-ID: <20131109044932.DBA866249F@hg.openjdk.java.net> Changeset: b65d48f6938a Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b65d48f6938a Added tag jdk8-b114 for changeset 4f2011496393 ! .hgtags Changeset: 763ada2a1d8c Author: lana Date: 2013-10-31 16:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/763ada2a1d8c Merge Changeset: 40e892e2a4f2 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/40e892e2a4f2 Added tag jdk8-b115 for changeset 763ada2a1d8c ! .hgtags From lana.steuck at oracle.com Fri Nov 8 20:49:37 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:37 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20131109044943.86205624A2@hg.openjdk.java.net> Changeset: e126d8eca69b Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/e126d8eca69b Added tag jdk8-b114 for changeset 9ad289610fc6 ! .hgtags Changeset: 587560c222a2 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/587560c222a2 Added tag jdk8-b115 for changeset e126d8eca69b ! .hgtags From lana.steuck at oracle.com Fri Nov 8 20:49:37 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:37 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20131109044942.71D6A624A1@hg.openjdk.java.net> Changeset: f109bb255b80 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f109bb255b80 Added tag jdk8-b114 for changeset 79f7b79bf97b ! .hgtags Changeset: f0d3ac2474ee Author: lana Date: 2013-10-31 16:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f0d3ac2474ee Merge - src/jdk/nashorn/internal/runtime/ScriptObjectListAdapter.java Changeset: 0fb1a427fbf6 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0fb1a427fbf6 Added tag jdk8-b115 for changeset f0d3ac2474ee ! .hgtags Changeset: d091499d67fc Author: lana Date: 2013-11-08 17:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d091499d67fc Merge From lana.steuck at oracle.com Fri Nov 8 20:49:52 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:49:52 +0000 Subject: hg: jdk8/tl/hotspot: 37 new changesets Message-ID: <20131109045108.186F9624A5@hg.openjdk.java.net> Changeset: ddc3758f68db Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ddc3758f68db Added tag jdk8-b114 for changeset 7fd913010dbb ! .hgtags Changeset: 205834867346 Author: lana Date: 2013-10-31 16:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/205834867346 Merge Changeset: f94a9f0746d8 Author: amurillo Date: 2013-10-25 13:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f94a9f0746d8 8027173: new hotspot build - hs25-b57 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e64f1fe9756b Author: farvidsson Date: 2013-10-24 10:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e64f1fe9756b 8024423: JVMTI: GetLoadedClasses doesn't enumerate anonymous classes Summary: Rewrite of the getLoadedClasses() method implementation to include anonymous classes. Reviewed-by: coleenp, sspitsyn ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/prims/jvmtiGetLoadedClasses.cpp Changeset: d70a665e25d7 Author: iklam Date: 2013-10-24 22:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d70a665e25d7 8020753: JNI_CreateJavaVM on Mac OSX 10.9 Mavericks corrupts the callers stack size Summary: Use hard-coded DEFAULT_MAIN_THREAD_STACK_PAGES = 2048 for 10.9 Reviewed-by: dcubed, iveresov Contributed-by: gerard.ziemski at oracle.com ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Changeset: e4f478e7781b Author: jbachorik Date: 2013-10-25 09:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e4f478e7781b 8027294: Prepare hotspot for non TOD based uptime counter Summary: Use HR timer when available for os::elapsed_counter() on linux/bsd. Add a new counter for the JVM uptime. Reviewed-by: dholmes, sla ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/share/vm/services/jmm.h ! src/share/vm/services/management.cpp Changeset: a6177f601c64 Author: hseigel Date: 2013-10-25 11:05 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a6177f601c64 8026822: metaspace/flags/maxMetaspaceSize throws OOM of unexpected type.java.lang.OutOfMemoryError: Compressed class space Summary: Incorporate chunk size when seeing if OutOfMemoryError was caused by Metaspace or Compressed class space. Reviewed-by: stefank, coleenp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp Changeset: 634715d59d9e Author: hseigel Date: 2013-10-25 11:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/634715d59d9e Merge Changeset: 209aa13ab8c0 Author: coleenp Date: 2013-10-25 15:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/209aa13ab8c0 8024927: Nashorn performance regression with CompressedOops Summary: Allocate compressed class space at end of Java heap. For small heap sizes, without CDS, save some space so compressed classes can have the same favorable compression as oops Reviewed-by: stefank, hseigel, goetz ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/utilities/globalDefinitions.hpp + test/runtime/CompressedOops/CompressedClassPointers.java Changeset: b4aa8fc5d0d5 Author: ccheung Date: 2013-10-25 22:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b4aa8fc5d0d5 Merge ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/share/vm/memory/metaspace.cpp - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java Changeset: 1a04de1aaedb Author: dsamersoff Date: 2013-10-28 21:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1a04de1aaedb 8026950: Nits in agent ps_proc.c file breaks compilation of open hotspot Summary: Fixed two compilation-breaking nits Reviewed-by: sla, dholmes ! agent/src/os/bsd/ps_proc.c Changeset: 85730a185147 Author: ccheung Date: 2013-10-30 14:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/85730a185147 Merge Changeset: 292050e5d5ea Author: dholmes Date: 2013-10-24 00:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/292050e5d5ea 8026877: Error in opening JAR file when invalid jar specified with -Xbootclasspath/a on OpenJDK build Reviewed-by: coleenp, twisti ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/runtime/thread.cpp Changeset: 066778844ed9 Author: jprovino Date: 2013-10-27 14:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/066778844ed9 Merge Changeset: f2f9139ccde9 Author: jprovino Date: 2013-10-30 16:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f2f9139ccde9 Merge Changeset: a007575ea726 Author: vladidan Date: 2013-10-30 16:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a007575ea726 Merge Changeset: 3b3133d93fb6 Author: brutisso Date: 2013-10-28 13:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3b3133d93fb6 8027132: Print deprecation warning message for the flags controlling the CMS foreground collector Reviewed-by: stefank, ehelin, ysr, tschatzl ! src/share/vm/runtime/arguments.cpp + test/gc/startup_warnings/TestCMSForegroundFlags.java Changeset: 6d965678f21e Author: ehelin Date: 2013-10-31 21:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6d965678f21e Merge Changeset: bd3237e0e18d Author: twisti Date: 2013-10-24 16:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bd3237e0e18d 8026328: Setting a breakpoint on invokedynamic crashes the JVM Reviewed-by: jrose, roland ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/cpu/zero/vm/globals_zero.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/cppInterpreter.hpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/interpreter/templateInterpreter.hpp ! src/share/vm/interpreter/templateInterpreterGenerator.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/runtime/handles.cpp Changeset: cbe8ba0fb8fc Author: twisti Date: 2013-10-24 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cbe8ba0fb8fc Merge - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java Changeset: f01788f13696 Author: adlertz Date: 2013-10-25 10:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f01788f13696 8026940: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc Summary: Remove input to junk phi if they also become dead during post_allocate_copy_removal Reviewed-by: roland ! src/share/vm/opto/postaloc.cpp Changeset: 7ae254fd0b3c Author: adlertz Date: 2013-10-25 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7ae254fd0b3c Merge Changeset: 6c2f07d1495f Author: roland Date: 2013-10-28 09:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6c2f07d1495f 8027140: Assertion in compiler when running bigapps/Kitchensink/stability Summary: filter() code for TypeKlassPtr not moved when permgen removal was introduced Reviewed-by: twisti, iveresov ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp Changeset: bfdb530cdffa Author: roland Date: 2013-10-28 12:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bfdb530cdffa Merge Changeset: a196f1aaec86 Author: anoll Date: 2013-10-25 22:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a196f1aaec86 8026949: -Xint flag prints wrong warning: Initialization of C1 thread failed (no space to run compilers) Summary: Exit compiler threads early during startup so that wrong error message is not printed Reviewed-by: iveresov, twisti ! src/share/vm/compiler/compileBroker.cpp + test/compiler/startup/StartupOutput.java Changeset: 8c16f426dbb2 Author: iveresov Date: 2013-10-28 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8c16f426dbb2 Merge Changeset: fc1632f5021a Author: iveresov Date: 2013-10-28 17:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fc1632f5021a Merge Changeset: a57a165b8296 Author: rbackman Date: 2013-10-28 08:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a57a165b8296 8027353: Exact intrinsics: assert(n != NULL) failed: must not be null Reviewed-by: kvn, roland ! src/share/vm/opto/library_call.cpp ! test/compiler/intrinsics/mathexact/SubExactLConstantTest.java ! test/compiler/intrinsics/mathexact/SubExactLNonConstantTest.java Changeset: 60a32bb8ff99 Author: rbackman Date: 2013-10-30 13:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/60a32bb8ff99 8027444: mathExact: assert(i < _max) failed: oob: i=1, _max=1 Reviewed-by: duke ! src/share/vm/opto/loopTransform.cpp + test/compiler/intrinsics/mathexact/NestedMathExactTest.java Changeset: 4d3575d37a07 Author: iveresov Date: 2013-10-30 22:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4d3575d37a07 8026735: Stream tests throw java.lang.IncompatibleClassChangeError Summary: Put a band-aid to disable CHA-based inlining for interfaces with default methods in C1 Reviewed-by: kvn, twisti ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp + test/compiler/inlining/InlineDefaultMethod.java Changeset: 946a8294ab15 Author: iveresov Date: 2013-10-31 04:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/946a8294ab15 8024919: G1: SPECjbb2013 crashes due to a broken object reference Summary: Pass correct new value to post_barrer() in Unsafe.getAndSetObject() C1 intrinsic Reviewed-by: kvn, roland ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp Changeset: 2dcd0bd2920d Author: iveresov Date: 2013-10-31 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2dcd0bd2920d Merge Changeset: 0836a3c28c6a Author: iveresov Date: 2013-10-31 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0836a3c28c6a Merge Changeset: 3b32d287da89 Author: amurillo Date: 2013-11-01 08:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3b32d287da89 Merge ! src/os/bsd/vm/os_bsd.cpp Changeset: afd012c940e4 Author: amurillo Date: 2013-11-01 08:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/afd012c940e4 Added tag hs25-b57 for changeset 3b32d287da89 ! .hgtags Changeset: 9ebaac78a8a0 Author: amurillo Date: 2013-11-05 14:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9ebaac78a8a0 Merge Changeset: 842b6ce4dfb4 Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/842b6ce4dfb4 Added tag jdk8-b115 for changeset 9ebaac78a8a0 ! .hgtags From lana.steuck at oracle.com Fri Nov 8 20:57:08 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 09 Nov 2013 04:57:08 +0000 Subject: hg: jdk8/tl/jdk: 70 new changesets Message-ID: <20131109051116.55949624A6@hg.openjdk.java.net> Changeset: 62982664dc72 Author: cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62982664dc72 Added tag jdk8-b114 for changeset f26a0c8071bd ! .hgtags Changeset: 180c05796c45 Author: bae Date: 2013-10-10 18:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/180c05796c45 7058618: PNG parser bugs found via zzuf fuzzing Reviewed-by: prr, vadim ! src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java Changeset: 0c2ba6a67b0d Author: morris Date: 2013-10-11 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c2ba6a67b0d 7195597: ThreadStateTest gets different results with -Xcomp Reviewed-by: kvn ! test/java/lang/Thread/ThreadStateTest.java Changeset: 124bffc749ea Author: lana Date: 2013-10-12 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/124bffc749ea Merge - src/macosx/classes/sun/lwawt/SelectionClearListener.java - src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/time/chrono/ChronoDateImpl.java - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java - test/java/util/regex/PatternTest.java Changeset: 7ed340e7d894 Author: bae Date: 2013-10-14 15:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ed340e7d894 7058602: BMP parser bugs found via zzuf fuzzing Reviewed-by: prr, vadim ! src/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java ! src/share/classes/com/sun/imageio/plugins/common/iio-plugin.properties ! src/share/classes/java/awt/image/ComponentSampleModel.java Changeset: cb9fa40f73f7 Author: bae Date: 2013-10-14 15:49 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb9fa40f73f7 7058607: GIF parser bugs found via zzuf fuzzing Reviewed-by: prr, vadim ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java Changeset: 478f7a9b3b12 Author: bae Date: 2013-10-14 16:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/478f7a9b3b12 7058611: JPG parser bugs found via zzuf fuzzing Reviewed-by: prr, vadim ! src/share/classes/com/sun/imageio/plugins/jpeg/MarkerSegment.java ! src/share/classes/com/sun/imageio/plugins/jpeg/SOFMarkerSegment.java Changeset: b164c8eb1295 Author: jgodinez Date: 2013-10-14 09:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b164c8eb1295 8022536: closed/javax/print/TextFlavorTest.java fails Reviewed-by: prr, jchen ! src/solaris/classes/sun/print/CUPSPrinter.java ! src/solaris/classes/sun/print/IPPPrintService.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! test/java/awt/print/PrinterJob/PrintLatinCJKTest.java + test/javax/print/TextFlavorTest.java Changeset: 8a59181b3c6d Author: vadim Date: 2013-10-15 08:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a59181b3c6d 8023590: REGRESSION: large count of graphics artifacts with Java 8 on Windows 8 on Intel HD card. Reviewed-by: prr, bae ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h Changeset: 0df5cda89a50 Author: jchen Date: 2013-10-15 14:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0df5cda89a50 8025429: [parfait] warnings from b107 for sun.java2d.cmm: JNI exception pending Reviewed-by: prr, bae ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: c9c945cea665 Author: jgodinez Date: 2013-10-15 14:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9c945cea665 8015586: [macosx] Test closed/java/awt/print/PrinterJob/PrintToDir.java fails on MacOSX Reviewed-by: prr, jchen ! src/macosx/classes/sun/lwawt/macosx/CPrinterJob.java ! src/share/classes/sun/print/RasterPrinterJob.java + test/java/awt/print/PrinterJob/PrintToDir.java Changeset: 070e8ec9d82c Author: bae Date: 2013-10-16 17:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/070e8ec9d82c 8026702: Fix for 8025429 breaks jdk build on windows Reviewed-by: serb ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: 73d212a3b2eb Author: jchen Date: 2013-10-16 14:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/73d212a3b2eb 8024461: [macosx] Java crashed on mac10.9 for swing and 2d function manual test Reviewed-by: prr, vadim, serb ! src/share/native/sun/java2d/opengl/OGLBlitLoops.c Changeset: bcf8e9a59968 Author: jgodinez Date: 2013-10-18 15:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcf8e9a59968 8025988: [macosx] Attribute settings don't work for JobAttributes range 8025990: [macosx] Attribute settings don't work for JobAttributes setOrientationRequested, setMedia Reviewed-by: prr, jchen ! src/macosx/native/sun/awt/CPrinterJob.m ! src/share/classes/sun/print/RasterPrinterJob.java ! src/windows/classes/sun/awt/windows/WPrinterJob.java ! test/java/awt/PrintJob/SaveDialogTitleTest.java Changeset: 2a3e21fe9d0d Author: jgodinez Date: 2013-10-21 13:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a3e21fe9d0d 8026951: Fix for 8025988 breaks jdk build on windows Reviewed-by: prr, jchen ! src/share/classes/sun/print/RasterPrinterJob.java Changeset: 923f39485651 Author: bae Date: 2013-10-22 13:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/923f39485651 8026780: Crash on PPC and PPC v2 for Java_awt test suit Reviewed-by: prr, jchen ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: 739ed3f0e796 Author: ceisserer Date: 2013-10-22 13:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/739ed3f0e796 8023483: sun/java2d/DirectX/TransformedPaintTest/TransformedPaintTest.java failed with jdk8 on linux platforms Reviewed-by: prr, bae ! src/solaris/classes/sun/java2d/xr/XRBackend.java ! src/solaris/classes/sun/java2d/xr/XRBackendNative.java ! src/solaris/classes/sun/java2d/xr/XRCompositeManager.java ! src/solaris/classes/sun/java2d/xr/XRPaints.java ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c + test/java/awt/GradientPaint/GradientTransformTest.java + test/java/awt/GradientPaint/LinearColorSpaceGradientTest.java ! test/sun/java2d/DirectX/TransformedPaintTest/TransformedPaintTest.java Changeset: c55a8480cc27 Author: ceisserer Date: 2013-10-22 15:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c55a8480cc27 8023098: XRender : AlphaComposite test results are incorrect. Reviewed-by: prr, bae ! src/solaris/classes/sun/java2d/xr/MaskTileManager.java ! src/solaris/classes/sun/java2d/xr/XRColor.java ! src/solaris/classes/sun/java2d/xr/XRCompositeManager.java ! src/solaris/classes/sun/java2d/xr/XRDrawImage.java ! src/solaris/classes/sun/java2d/xr/XRMaskBlit.java + src/solaris/classes/sun/java2d/xr/XRSolidSrcPict.java ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java ! src/solaris/classes/sun/java2d/xr/XRUtils.java Changeset: aca4a67e560d Author: vadim Date: 2013-10-23 08:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aca4a67e560d 8001173: [findbugs] Evaluate FindBug output for sun.font.CompositeFont, sun.font.CompositeFontDescriptor Reviewed-by: prr, bae ! src/share/classes/sun/font/StandardTextSource.java ! src/share/classes/sun/font/TextLabelFactory.java ! src/solaris/classes/sun/font/FontConfigManager.java Changeset: 92af0666c168 Author: prr Date: 2013-10-23 08:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92af0666c168 8027169: Xrender: Cleaner version of the fix for 7159455 Nimbus scrollbar glitch Reviewed-by: prr, bae ! src/solaris/classes/sun/java2d/xr/XRPMBlitLoops.java Changeset: d27525c346fa Author: lana Date: 2013-10-24 21:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d27525c346fa Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html - src/share/classes/java/net/HttpURLPermission.java - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: 3371047f56f3 Author: lana Date: 2013-10-31 15:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3371047f56f3 Merge Changeset: 2e59014ef38f Author: alexsch Date: 2013-10-09 13:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2e59014ef38f 8025649: need test to cover JDK-8000423 Reviewed-by: anthony, serb Contributed-by: Alexander Stepanov + test/java/awt/InputMethods/DiacriticsTest/DiacriticsTest.html + test/java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java Changeset: 84c766f6796b Author: bagiras Date: 2013-10-09 14:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84c766f6796b 8016356: Any swing frame resizes ugly. Reviewed-by: art, anthony ! src/windows/native/sun/windows/awt_Window.cpp Changeset: 929dc0915f8c Author: anthony Date: 2013-10-09 15:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/929dc0915f8c 7159266: [macosx] ApplicationDelegate should not be set in the headless mode Summary: Don't install ApplicationDelegate in headless mode Reviewed-by: art, serb ! src/macosx/native/sun/awt/awt.m Changeset: 976e5f580124 Author: leonidr Date: 2013-10-09 20:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/976e5f580124 8019623: Lack of synchronization in AppContext.getAppContext() Reviewed-by: anthony, art ! src/share/classes/sun/awt/AppContext.java + test/sun/awt/AppContext/MultiThread/MultiThreadTest.java Changeset: fba62451d705 Author: leonidr Date: 2013-10-09 21:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fba62451d705 8016551: JMenuItem in WindowsLookAndFeel can't paint default icons Reviewed-by: alexsch, serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java + test/com/sun/java/swing/plaf/windows/8016551/bug8016551.java Changeset: cea6ca16142e Author: cl Date: 2013-10-09 14:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cea6ca16142e 8026021: more fix of javadoc errors and warnings reported by doclint, see the description Reviewed-by: anthony, serb ! src/share/classes/java/awt/GraphicsDevice.java ! src/share/classes/java/awt/GridBagLayout.java ! src/share/classes/java/awt/LinearGradientPaint.java ! src/share/classes/java/awt/RadialGradientPaint.java ! src/share/classes/java/awt/font/LineBreakMeasurer.java ! src/share/classes/java/awt/font/MultipleMaster.java ! src/share/classes/java/awt/font/NumericShaper.java ! src/share/classes/java/awt/font/OpenType.java ! src/share/classes/java/awt/geom/AffineTransform.java ! src/share/classes/java/awt/im/InputContext.java ! src/share/classes/javax/swing/Action.java ! src/share/classes/javax/swing/GroupLayout.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/StyleConstants.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java Changeset: 81ea6299230a Author: serb Date: 2013-10-10 02:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81ea6299230a 7058662: AiffFileReader throws java.lang.ArithmeticException: division by zero when frame size is zero 7058666: Unexpected exception in AU parser code 7058672: Unexpected exceptions and freezes in WAV parser code Reviewed-by: prr ! src/share/classes/com/sun/media/sound/AiffFileReader.java ! src/share/classes/com/sun/media/sound/AuFileReader.java ! src/share/classes/com/sun/media/sound/WaveFileReader.java + test/javax/sound/sampled/FileReader/ReadersExceptions.java Changeset: 857d6f78f241 Author: pchelko Date: 2013-10-10 11:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/857d6f78f241 8025588: [macosx] Frozen AppKit thread in 7u40 Reviewed-by: anthony, art, serb ! src/macosx/classes/sun/lwawt/macosx/CInputMethod.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CViewEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/event/InvocationEvent.java ! src/share/classes/sun/awt/AWTAccessor.java Changeset: 31a156bae7cb Author: pchelko Date: 2013-10-10 19:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31a156bae7cb 8024864: [macosx] Problems with rendering of controls Reviewed-by: serb, leonidr ! src/macosx/classes/sun/lwawt/LWWindowPeer.java + test/java/awt/Paint/bug8024864.java Changeset: de36486eadd2 Author: pchelko Date: 2013-10-11 11:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de36486eadd2 8026143: [macosx] Maximized state could be inconsistent between peer and frame Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m + test/java/awt/Frame/MaximizedByPlatform/MaximizedByPlatform.java Changeset: d96f9a8cf89a Author: kshefov Date: 2013-10-11 15:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d96f9a8cf89a 7124338: [macosx] Selection lost if a selected item removed from a java.awt.List Reviewed-by: serb, anthony + test/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html + test/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.java Changeset: 2e04843f1c1d Author: art Date: 2013-10-11 16:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2e04843f1c1d 8022185: Fix Raw and unchecked warnings in classes belonging to java.awt.datatransfer Reviewed-by: art, pchelko Contributed-by: Srikalyan Chandrashekar ! src/share/classes/java/awt/datatransfer/DataFlavor.java ! src/share/classes/java/awt/datatransfer/MimeTypeParameterList.java Changeset: 2f7f6995fa64 Author: pchelko Date: 2013-10-11 17:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2f7f6995fa64 8026262: NPE in SystemFlavorMap.getAllNativesForType - regression in jdk8 b110 by fix of #JDK-8024987 Reviewed-by: art, serb ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java Changeset: af273c9b564a Author: pchelko Date: 2013-10-11 18:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af273c9b564a 8024329: [macosx] JRadioButtonMenuItem behaves like a checkbox when using the ScreenMenuBar Reviewed-by: anthony, serb ! src/macosx/classes/com/apple/laf/ScreenMenuItemCheckbox.java Changeset: f65895a2959e Author: lana Date: 2013-10-11 14:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f65895a2959e Merge - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/time/chrono/ChronoDateImpl.java - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java - test/java/util/regex/PatternTest.java Changeset: d874963706dc Author: yan Date: 2013-10-14 11:47 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d874963706dc 8025824: [cleanup] Fix tidy errors and warnings in preformatted HTML files related to 2d/awt/swing Reviewed-by: anthony, alexsch ! src/macosx/classes/com/apple/eawt/event/package.html ! src/macosx/classes/com/apple/eawt/package.html ! src/share/classes/java/awt/color/package.html ! src/share/classes/java/awt/datatransfer/package.html ! src/share/classes/java/awt/dnd/package.html ! src/share/classes/java/awt/doc-files/AWTThreadIssues.html ! src/share/classes/java/awt/doc-files/DesktopProperties.html ! src/share/classes/java/awt/doc-files/FocusSpec.html ! src/share/classes/java/awt/doc-files/Modality.html ! src/share/classes/java/awt/event/package.html ! src/share/classes/java/awt/font/package.html ! src/share/classes/java/awt/geom/package.html ! src/share/classes/java/awt/image/package.html ! src/share/classes/java/awt/image/renderable/package.html ! src/share/classes/java/awt/package.html ! src/share/classes/java/awt/print/package.html ! src/share/classes/javax/print/attribute/package.html ! src/share/classes/javax/print/attribute/standard/package.html ! src/share/classes/javax/print/event/package.html ! src/share/classes/javax/print/package.html ! src/share/classes/javax/swing/border/package.html ! src/share/classes/javax/swing/colorchooser/package.html ! src/share/classes/javax/swing/event/package.html ! src/share/classes/javax/swing/filechooser/package.html ! src/share/classes/javax/swing/plaf/basic/package.html ! src/share/classes/javax/swing/plaf/metal/package.html ! src/share/classes/javax/swing/plaf/multi/doc-files/multi_tsc.html ! src/share/classes/javax/swing/plaf/multi/package.html ! src/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html ! src/share/classes/javax/swing/plaf/nimbus/package.html ! src/share/classes/javax/swing/plaf/package.html ! src/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html ! src/share/classes/javax/swing/plaf/synth/package.html ! src/share/classes/javax/swing/table/package.html ! src/share/classes/javax/swing/text/html/package.html ! src/share/classes/javax/swing/text/html/parser/package.html ! src/share/classes/javax/swing/text/package.html ! src/share/classes/javax/swing/text/rtf/package.html ! src/share/classes/javax/swing/tree/package.html ! src/share/classes/javax/swing/undo/package.html Changeset: 69a17384fe22 Author: malenkov Date: 2013-10-14 13:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69a17384fe22 7165112: Incomprehensible garbage in doc for RootPaneContainer Reviewed-by: alexsch ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/RootPaneContainer.java Changeset: 9f49b055e983 Author: malenkov Date: 2013-10-14 13:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f49b055e983 7016396: (spec) JCK test mentioned in 6735293 is still failing Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/share/classes/javax/swing/text/AsyncBoxView.java ! src/share/classes/javax/swing/text/CompositeView.java ! src/share/classes/javax/swing/text/GlyphView.java ! src/share/classes/javax/swing/text/View.java Changeset: 54a6e22b749c Author: malenkov Date: 2013-10-14 14:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/54a6e22b749c 7035495: javax.swing.ImageIcon spec should be clarified Reviewed-by: alexsch ! src/share/classes/javax/swing/ImageIcon.java Changeset: 5e0ed469c36a Author: alexsch Date: 2013-10-14 18:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e0ed469c36a 8005391: Floating behavior of HTMLEditorKit parser Reviewed-by: malenkov, leonidr Contributed-by: Alexander Shusherov ! src/share/classes/javax/swing/text/SimpleAttributeSet.java + test/javax/swing/text/html/8005391/bug8005391.java Changeset: 24fd0716d8d6 Author: alexsch Date: 2013-10-14 18:52 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/24fd0716d8d6 8020708: NLS mnemonics missing in SwingSet2/JInternalFrame demo Reviewed-by: malenkov, leonidr ! src/share/classes/com/sun/java/swing/plaf/motif/MotifInternalFrameTitlePane.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsInternalFrameTitlePane.java ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameTitlePane.java + test/javax/swing/JInternalFrame/8020708/bug8020708.java Changeset: 9546631f14ca Author: serb Date: 2013-10-14 20:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9546631f14ca 8019591: JCK: testICSEthrowing_fullScreen fails: no ICSE thrown Reviewed-by: art, anthony ! src/share/classes/java/awt/GraphicsDevice.java + test/java/awt/Window/WindowGCInFullScreen/WindowGCInFullScreen.java Changeset: f9548641d699 Author: serb Date: 2013-10-15 20:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9548641d699 7059886: 6 JCK manual awt/Desktop tests fail with GTKLookAndFeel - GTK intialization issue Reviewed-by: anthony, art Contributed-by: alexander.zvegintsev at oracle.com + src/solaris/classes/sun/misc/GThreadHelper.java ! src/solaris/native/sun/awt/awt_UNIXToolkit.c ! src/solaris/native/sun/awt/gtk2_interface.c ! src/solaris/native/sun/awt/gtk2_interface.h ! src/solaris/native/sun/xawt/awt_Desktop.c Changeset: 89546b9be510 Author: serb Date: 2013-10-15 20:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89546b9be510 8025225: Window.setAlwaysOnTop documentation should be updated Reviewed-by: anthony, art Contributed-by: alexander.zvegintsev at oracle.com ! src/share/classes/java/awt/Window.java Changeset: 229b10e97bd2 Author: bagiras Date: 2013-10-16 19:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/229b10e97bd2 2228674: Fix failed for CR 7162144 Reviewed-by: art, anthony ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/awt/EventQueue.java Changeset: 70242d821c66 Author: serb Date: 2013-10-17 20:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70242d821c66 8022657: Add FunctionalInterface annotation to awt interfaces Reviewed-by: anthony, art ! src/share/classes/java/awt/KeyEventDispatcher.java ! src/share/classes/java/awt/KeyEventPostProcessor.java Changeset: 3c2d4569a6a3 Author: serb Date: 2013-10-17 21:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c2d4569a6a3 8026356: [macosx] Found one Java-level deadlock:"AWT-EventQueue-0" && main Reviewed-by: anthony, art ! src/share/classes/java/awt/Component.java Changeset: 5334c651c7ba Author: yan Date: 2013-10-18 15:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5334c651c7ba 7002846: Fix for 6989505 may be incomplete Reviewed-by: anthony, art Contributed-by: Andrei Eremeev ! src/windows/classes/sun/awt/windows/WRobotPeer.java ! src/windows/native/sun/windows/awt_Robot.cpp ! src/windows/native/sun/windows/awt_Robot.h Changeset: 84ae644933b6 Author: serb Date: 2013-10-18 20:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84ae644933b6 8026476: Choice does not get mouse events if it does not have enough place for popup menu Reviewed-by: anthony, serb Contributed-by: alexander.zvegintsev at oracle.com ! src/solaris/classes/sun/awt/X11/XChoicePeer.java Changeset: d72ca6dac444 Author: leonidr Date: 2013-10-22 16:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d72ca6dac444 8020209: [macosx] Mac OS X key event confusion for "COMMAND PLUS" Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/osxapp/NSApplicationAWT.m + test/java/awt/event/KeyEvent/8020209/bug8020209.java ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java Changeset: 4ad826a08e6f Author: serb Date: 2013-10-23 16:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad826a08e6f 8020851: java.awt.event.WindowEvent spec should state that WINDOW_CLOSED event may not be delivered under certain circumstances Reviewed-by: anthony, art ! src/share/classes/java/awt/event/WindowEvent.java Changeset: cd2e3c63ee42 Author: serb Date: 2013-10-24 14:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd2e3c63ee42 7090424: TestGlyphVectorLayout failed automately with java.lang.StackOverflowError Reviewed-by: anthony, art ! src/solaris/classes/sun/awt/X11/XButtonPeer.java ! src/solaris/classes/sun/awt/X11/XCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XCheckboxPeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XContentWindow.java ! src/solaris/classes/sun/awt/X11/XLabelPeer.java ! src/solaris/classes/sun/awt/X11/XListPeer.java ! src/solaris/classes/sun/awt/X11/XWindow.java + test/java/awt/Paint/ButtonRepaint.java + test/java/awt/Paint/CheckboxRepaint.java + test/java/awt/Paint/ExposeOnEDT.java + test/java/awt/Paint/LabelRepaint.java + test/java/awt/Paint/ListRepaint.java Changeset: 7c84aff91033 Author: pchelko Date: 2013-10-24 19:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c84aff91033 8027030: AWT Multiple JVM DnD Test Failing on Linux (OEL and Ubuntu) and Solaris (Sparc and x64) Reviewed-by: anthony, serb ! src/share/classes/sun/awt/datatransfer/DataTransferer.java Changeset: c561db53a24c Author: pchelko Date: 2013-10-24 19:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c561db53a24c 8027025: [macosx] getLocationOnScreen returns 0 if parent invisible Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java + test/java/awt/Window/8027025/Test8027025.java Changeset: 6fe5443c3dde Author: alitvinov Date: 2013-10-25 13:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6fe5443c3dde 8027066: XMLDecoder in java 7 cannot properly deserialize object arrays Reviewed-by: alexsch, malenkov Contributed-by: anton.nashatyrev at oracle.com ! src/share/classes/com/sun/beans/decoder/ArrayElementHandler.java + test/java/beans/XMLEncoder/Test8027066.java Changeset: 75ae2a980db5 Author: malenkov Date: 2013-10-25 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75ae2a980db5 8026705: [TEST_BUG] java/beans/Introspector/TestTypeResolver.java failed Reviewed-by: art, jfranck ! test/java/beans/Introspector/TestTypeResolver.java Changeset: dab1d3798016 Author: serb Date: 2013-10-25 19:51 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dab1d3798016 7172770: Default Toolkit implementation return null value for property "awt.dynamicLayoutSupported" Reviewed-by: anthony, art ! src/share/classes/java/awt/Toolkit.java Changeset: 162c57b874d4 Author: lana Date: 2013-10-25 10:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/162c57b874d4 Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html ! src/share/classes/java/awt/datatransfer/DataFlavor.java - src/share/classes/java/net/HttpURLPermission.java ! src/share/classes/sun/awt/AppContext.java - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: 55cab2211ae9 Author: ant Date: 2013-10-29 16:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55cab2211ae9 8027157: [SwingNode] needs explicit expose for JWindow Reviewed-by: art, anthony ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WLightweightFramePeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: bedc29a6d074 Author: malenkov Date: 2013-10-29 17:01 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bedc29a6d074 8022746: List of spelling errors in API doc Reviewed-by: alexsch, smarks ! src/macosx/bundle/JavaAppLauncher/src/JVMArgs.m ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/com/apple/laf/AquaMenuPainter.java ! src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java ! src/macosx/classes/com/apple/laf/AquaTreeUI.java ! src/macosx/classes/java/net/DefaultInterface.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java ! src/macosx/classes/sun/font/CFontManager.java ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/CTextPipe.m ! src/share/back/commonRef.c ! src/share/back/eventFilter.c ! src/share/back/util.c ! src/share/classes/com/sun/beans/decoder/AccessorElementHandler.java ! src/share/classes/com/sun/beans/decoder/ArrayElementHandler.java ! src/share/classes/com/sun/beans/decoder/BooleanElementHandler.java ! src/share/classes/com/sun/beans/decoder/ByteElementHandler.java ! src/share/classes/com/sun/beans/decoder/CharElementHandler.java ! src/share/classes/com/sun/beans/decoder/ClassElementHandler.java ! src/share/classes/com/sun/beans/decoder/DoubleElementHandler.java ! src/share/classes/com/sun/beans/decoder/ElementHandler.java ! src/share/classes/com/sun/beans/decoder/FalseElementHandler.java ! src/share/classes/com/sun/beans/decoder/FieldElementHandler.java ! src/share/classes/com/sun/beans/decoder/FloatElementHandler.java ! src/share/classes/com/sun/beans/decoder/IntElementHandler.java ! src/share/classes/com/sun/beans/decoder/JavaElementHandler.java ! src/share/classes/com/sun/beans/decoder/LongElementHandler.java ! src/share/classes/com/sun/beans/decoder/MethodElementHandler.java ! src/share/classes/com/sun/beans/decoder/NewElementHandler.java ! src/share/classes/com/sun/beans/decoder/NullElementHandler.java ! src/share/classes/com/sun/beans/decoder/ObjectElementHandler.java ! src/share/classes/com/sun/beans/decoder/PropertyElementHandler.java ! src/share/classes/com/sun/beans/decoder/ShortElementHandler.java ! src/share/classes/com/sun/beans/decoder/StringElementHandler.java ! src/share/classes/com/sun/beans/decoder/TrueElementHandler.java ! src/share/classes/com/sun/beans/decoder/VarElementHandler.java ! src/share/classes/com/sun/beans/decoder/VoidElementHandler.java ! src/share/classes/com/sun/crypto/provider/PBECipherCore.java ! src/share/classes/com/sun/crypto/provider/PBES1Core.java ! src/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java ! src/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java ! src/share/classes/com/sun/imageio/plugins/common/StandardMetadataFormat.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JFIFMarkerSegment.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKColorChooserPanel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsGraphicsUtils.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTextFieldUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTextUI.java ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/jdi/connect/ListeningConnector.java ! src/share/classes/com/sun/jdi/connect/spi/TransportService.java ! src/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/TokenMgrError.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpErrorHandlerAgent.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibAgent.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibAgentMBean.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibGroup.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibTable.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpRequestTree.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpTableSupport.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpAdaptorServerMBean.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubBulkRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubNextRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubRequestHandler.java ! src/share/classes/com/sun/jndi/ldap/Connection.java ! src/share/classes/com/sun/jndi/ldap/Filter.java ! src/share/classes/com/sun/jndi/ldap/LdapCtx.java ! src/share/classes/com/sun/jndi/ldap/LdapName.java ! src/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java ! src/share/classes/com/sun/jndi/toolkit/dir/ContextEnumerator.java ! src/share/classes/com/sun/media/sound/AbstractMidiDevice.java ! src/share/classes/com/sun/media/sound/AudioSynthesizerPropertyInfo.java ! src/share/classes/com/sun/media/sound/DirectAudioDevice.java ! src/share/classes/com/sun/media/sound/SoftMixingSourceDataLine.java ! src/share/classes/com/sun/net/httpserver/Headers.java ! src/share/classes/com/sun/net/httpserver/HttpExchange.java ! src/share/classes/com/sun/net/ssl/internal/ssl/Provider.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionMethod.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/Reference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignature.java ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/WebRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/com/sun/rowset/package.html ! src/share/classes/com/sun/security/auth/module/LdapLoginModule.java ! src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java ! src/share/classes/com/sun/tools/example/debug/expr/TokenMgrError.java ! src/share/classes/com/sun/tools/hat/resources/hat.js ! src/share/classes/com/sun/tools/jdi/SocketAttachingConnector.java ! src/share/classes/com/sun/tools/jdi/SocketListeningConnector.java ! src/share/classes/com/sun/tools/jdi/ThreadListener.java ! src/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/share/classes/java/awt/AWTEventMulticaster.java ! src/share/classes/java/awt/AlphaComposite.java ! src/share/classes/java/awt/BasicStroke.java ! src/share/classes/java/awt/BorderLayout.java ! src/share/classes/java/awt/CheckboxMenuItem.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Event.java ! src/share/classes/java/awt/Font.java ! src/share/classes/java/awt/Graphics.java ! src/share/classes/java/awt/Graphics2D.java ! src/share/classes/java/awt/GraphicsEnvironment.java ! src/share/classes/java/awt/GridBagLayout.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/List.java ! src/share/classes/java/awt/MediaTracker.java ! src/share/classes/java/awt/MenuComponent.java ! src/share/classes/java/awt/MultipleGradientPaintContext.java ! src/share/classes/java/awt/Polygon.java ! src/share/classes/java/awt/PopupMenu.java ! src/share/classes/java/awt/RenderingHints.java ! src/share/classes/java/awt/ScrollPane.java ! src/share/classes/java/awt/ScrollPaneAdjustable.java ! src/share/classes/java/awt/Shape.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/TextField.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/datatransfer/FlavorMap.java ! src/share/classes/java/awt/datatransfer/MimeTypeParameterList.java ! src/share/classes/java/awt/dnd/DragGestureListener.java ! src/share/classes/java/awt/dnd/DragGestureRecognizer.java ! src/share/classes/java/awt/dnd/DragSourceContext.java ! src/share/classes/java/awt/dnd/DragSourceEvent.java ! src/share/classes/java/awt/dnd/DropTarget.java ! src/share/classes/java/awt/dnd/InvalidDnDOperationException.java ! src/share/classes/java/awt/event/ActionEvent.java ! src/share/classes/java/awt/event/KeyEvent.java ! src/share/classes/java/awt/font/FontRenderContext.java ! src/share/classes/java/awt/font/GlyphMetrics.java ! src/share/classes/java/awt/font/GlyphVector.java ! src/share/classes/java/awt/font/OpenType.java ! src/share/classes/java/awt/font/TextLayout.java ! src/share/classes/java/awt/font/TransformAttribute.java ! src/share/classes/java/awt/geom/AffineTransform.java ! src/share/classes/java/awt/geom/Line2D.java ! src/share/classes/java/awt/geom/Path2D.java ! src/share/classes/java/awt/geom/QuadCurve2D.java ! src/share/classes/java/awt/im/InputMethodRequests.java ! src/share/classes/java/awt/image/BandedSampleModel.java ! src/share/classes/java/awt/image/BufferStrategy.java ! src/share/classes/java/awt/image/BufferedImage.java ! src/share/classes/java/awt/image/ComponentColorModel.java ! src/share/classes/java/awt/image/ComponentSampleModel.java ! src/share/classes/java/awt/image/ImageConsumer.java ! src/share/classes/java/awt/image/IndexColorModel.java ! src/share/classes/java/awt/image/PixelInterleavedSampleModel.java ! src/share/classes/java/awt/image/renderable/RenderableImage.java ! src/share/classes/java/awt/image/renderable/RenderableImageOp.java ! src/share/classes/java/beans/AppletInitializer.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/EventHandler.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/PropertyDescriptor.java ! src/share/classes/java/beans/PropertyEditorSupport.java ! src/share/classes/java/beans/beancontext/BeanContextChildSupport.java ! src/share/classes/java/beans/beancontext/BeanContextServiceRevokedListener.java ! src/share/classes/java/beans/beancontext/BeanContextServicesSupport.java ! src/share/classes/java/beans/beancontext/BeanContextSupport.java ! src/share/classes/java/io/File.java ! src/share/classes/java/io/ObjectStreamConstants.java ! src/share/classes/java/io/PrintStream.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/management/CompilationMXBean.java ! src/share/classes/java/lang/management/MemoryPoolMXBean.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/lang/management/ThreadMXBean.java ! src/share/classes/java/net/Authenticator.java ! src/share/classes/java/net/CookieManager.java ! src/share/classes/java/net/CookieStore.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/InetSocketAddress.java ! src/share/classes/java/net/InterfaceAddress.java ! src/share/classes/java/net/JarURLConnection.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/StandardSocketOptions.java ! src/share/classes/java/net/URL.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/net/URLDecoder.java ! src/share/classes/java/net/URLEncoder.java ! src/share/classes/java/nio/channels/AsynchronousChannelGroup.java ! src/share/classes/java/nio/channels/DatagramChannel.java ! src/share/classes/java/nio/channels/MembershipKey.java ! src/share/classes/java/nio/channels/package-info.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/nio/file/attribute/UserDefinedFileAttributeView.java ! src/share/classes/java/rmi/MarshalledObject.java ! src/share/classes/java/security/AccessControlException.java ! src/share/classes/java/security/DigestOutputStream.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/ProtectionDomain.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/UnresolvedPermission.java ! src/share/classes/java/security/cert/CertificateRevokedException.java ! src/share/classes/java/security/spec/ECFieldF2m.java ! src/share/classes/java/sql/Array.java ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/Blob.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Clob.java ! src/share/classes/java/sql/Connection.java ! src/share/classes/java/sql/DataTruncation.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/DriverPropertyInfo.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLException.java ! src/share/classes/java/sql/SQLFeatureNotSupportedException.java ! src/share/classes/java/sql/SQLIntegrityConstraintViolationException.java ! src/share/classes/java/sql/SQLInvalidAuthorizationSpecException.java ! src/share/classes/java/sql/SQLNonTransientConnectionException.java ! src/share/classes/java/sql/SQLNonTransientException.java ! src/share/classes/java/sql/SQLRecoverableException.java ! src/share/classes/java/sql/SQLSyntaxErrorException.java ! src/share/classes/java/sql/SQLTimeoutException.java ! src/share/classes/java/sql/SQLTransactionRollbackException.java ! src/share/classes/java/sql/SQLTransientConnectionException.java ! src/share/classes/java/sql/SQLTransientException.java ! src/share/classes/java/sql/SQLWarning.java ! src/share/classes/java/sql/SQLXML.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/sql/Struct.java ! src/share/classes/java/sql/package.html ! src/share/classes/java/text/BreakIterator.java ! src/share/classes/java/text/ChoiceFormat.java ! src/share/classes/java/text/DigitList.java ! src/share/classes/java/text/FieldPosition.java ! src/share/classes/java/text/Format.java ! src/share/classes/java/text/RuleBasedCollator.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/MissingFormatWidthException.java ! src/share/classes/java/util/PriorityQueue.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ExecutorCompletionService.java ! src/share/classes/java/util/jar/Manifest.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/javax/accessibility/AccessibleContext.java ! src/share/classes/javax/accessibility/AccessibleText.java ! src/share/classes/javax/crypto/NullCipher.java ! src/share/classes/javax/crypto/NullCipherSpi.java ! src/share/classes/javax/imageio/IIOParam.java ! src/share/classes/javax/imageio/ImageIO.java ! src/share/classes/javax/imageio/ImageReader.java ! src/share/classes/javax/imageio/ImageWriteParam.java ! src/share/classes/javax/imageio/ImageWriter.java ! src/share/classes/javax/imageio/event/IIOReadProgressListener.java ! src/share/classes/javax/imageio/event/IIOReadUpdateListener.java ! src/share/classes/javax/imageio/event/IIOReadWarningListener.java ! src/share/classes/javax/imageio/event/IIOWriteWarningListener.java ! src/share/classes/javax/imageio/metadata/IIOMetadata.java ! src/share/classes/javax/imageio/metadata/IIOMetadataFormat.java ! src/share/classes/javax/imageio/metadata/IIOMetadataFormatImpl.java ! src/share/classes/javax/imageio/metadata/doc-files/standard_metadata.html ! src/share/classes/javax/imageio/spi/ImageReaderSpi.java ! src/share/classes/javax/imageio/spi/ImageReaderWriterSpi.java ! src/share/classes/javax/imageio/stream/ImageInputStream.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/relation/RelationServiceMBean.java ! src/share/classes/javax/management/remote/rmi/package.html ! src/share/classes/javax/naming/Binding.java ! src/share/classes/javax/naming/InsufficientResourcesException.java ! src/share/classes/javax/naming/ldap/LdapName.java ! src/share/classes/javax/naming/ldap/Rdn.java ! src/share/classes/javax/net/ssl/SSLPeerUnverifiedException.java ! src/share/classes/javax/net/ssl/SSLSocket.java ! src/share/classes/javax/print/CancelablePrintJob.java ! src/share/classes/javax/print/DocFlavor.java ! src/share/classes/javax/print/DocPrintJob.java ! src/share/classes/javax/print/MultiDoc.java ! src/share/classes/javax/print/PrintService.java ! src/share/classes/javax/print/attribute/standard/MediaTray.java ! src/share/classes/javax/print/attribute/standard/PresentationDirection.java ! src/share/classes/javax/print/attribute/standard/PrinterIsAcceptingJobs.java ! src/share/classes/javax/print/attribute/standard/PrinterStateReason.java ! src/share/classes/javax/print/package.html ! src/share/classes/javax/script/AbstractScriptEngine.java ! src/share/classes/javax/script/CompiledScript.java ! src/share/classes/javax/script/Invocable.java ! src/share/classes/javax/script/ScriptEngine.java ! src/share/classes/javax/script/ScriptEngineFactory.java ! src/share/classes/javax/security/sasl/RealmChoiceCallback.java ! src/share/classes/javax/security/sasl/Sasl.java ! src/share/classes/javax/security/sasl/SaslClient.java ! src/share/classes/javax/security/sasl/SaslException.java ! src/share/classes/javax/smartcardio/CardChannel.java ! src/share/classes/javax/smartcardio/CardTerminal.java ! src/share/classes/javax/sound/midi/MidiDevice.java ! src/share/classes/javax/sound/midi/MidiMessage.java ! src/share/classes/javax/sound/midi/MidiSystem.java ! src/share/classes/javax/sound/midi/ShortMessage.java ! src/share/classes/javax/sound/midi/Soundbank.java ! src/share/classes/javax/sound/midi/Synthesizer.java ! src/share/classes/javax/sound/sampled/AudioFormat.java ! src/share/classes/javax/sound/sampled/AudioSystem.java ! src/share/classes/javax/sound/sampled/ReverbType.java ! src/share/classes/javax/sql/PooledConnection.java ! src/share/classes/javax/sql/RowSet.java ! src/share/classes/javax/sql/StatementEvent.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/JoinRowSet.java ! src/share/classes/javax/sql/rowset/Joinable.java ! src/share/classes/javax/sql/rowset/Predicate.java ! src/share/classes/javax/sql/rowset/package.html ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncResolver.java ! src/share/classes/javax/sql/rowset/spi/TransactionalWriter.java ! src/share/classes/javax/sql/rowset/spi/XmlReader.java ! src/share/classes/javax/sql/rowset/spi/XmlWriter.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/DefaultListSelectionModel.java ! src/share/classes/javax/swing/DefaultRowSorter.java ! src/share/classes/javax/swing/GroupLayout.java ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JComboBox.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JFileChooser.java ! src/share/classes/javax/swing/JFormattedTextField.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JPasswordField.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JRootPane.java ! src/share/classes/javax/swing/JSlider.java ! src/share/classes/javax/swing/JSpinner.java ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JViewport.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/LookAndFeel.java ! src/share/classes/javax/swing/ProgressMonitor.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/javax/swing/ScrollPaneConstants.java ! src/share/classes/javax/swing/SpinnerDateModel.java ! src/share/classes/javax/swing/SpinnerModel.java ! src/share/classes/javax/swing/SpinnerNumberModel.java ! src/share/classes/javax/swing/SpringLayout.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/ToolTipManager.java ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/javax/swing/UIManager.java ! src/share/classes/javax/swing/border/TitledBorder.java ! src/share/classes/javax/swing/event/DocumentEvent.java ! src/share/classes/javax/swing/event/HyperlinkEvent.java ! src/share/classes/javax/swing/event/TableModelEvent.java ! src/share/classes/javax/swing/event/TreeModelEvent.java ! src/share/classes/javax/swing/filechooser/FileSystemView.java ! src/share/classes/javax/swing/plaf/ComboBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicBorders.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuUI.java ! src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicScrollPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSplitPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTableUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolTipUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java ! src/share/classes/javax/swing/plaf/metal/DefaultMetalTheme.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalRootPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalSliderUI.java ! src/share/classes/javax/swing/plaf/metal/MetalToolBarUI.java ! src/share/classes/javax/swing/plaf/metal/MetalTreeUI.java ! src/share/classes/javax/swing/plaf/nimbus/AbstractRegionPainter.java ! src/share/classes/javax/swing/plaf/nimbus/LoweredBorder.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java ! src/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java ! src/share/classes/javax/swing/plaf/synth/doc-files/componentProperties.html ! src/share/classes/javax/swing/table/DefaultTableColumnModel.java ! src/share/classes/javax/swing/table/JTableHeader.java ! src/share/classes/javax/swing/table/TableColumn.java ! src/share/classes/javax/swing/table/TableColumnModel.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/AbstractWriter.java ! src/share/classes/javax/swing/text/AsyncBoxView.java ! src/share/classes/javax/swing/text/BoxView.java ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/DefaultHighlighter.java ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/Document.java ! src/share/classes/javax/swing/text/DocumentFilter.java ! src/share/classes/javax/swing/text/ElementIterator.java ! src/share/classes/javax/swing/text/FlowView.java ! src/share/classes/javax/swing/text/GapContent.java ! src/share/classes/javax/swing/text/GapVector.java ! src/share/classes/javax/swing/text/InternationalFormatter.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/NumberFormatter.java ! src/share/classes/javax/swing/text/ParagraphView.java ! src/share/classes/javax/swing/text/StyleConstants.java ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/javax/swing/text/TableView.java ! src/share/classes/javax/swing/text/View.java ! src/share/classes/javax/swing/text/WrappedPlainView.java ! src/share/classes/javax/swing/text/ZoneView.java ! src/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/share/classes/javax/swing/text/html/BlockView.java ! src/share/classes/javax/swing/text/html/CSS.java ! src/share/classes/javax/swing/text/html/CSSParser.java ! src/share/classes/javax/swing/text/html/FormSubmitEvent.java ! src/share/classes/javax/swing/text/html/FormView.java ! src/share/classes/javax/swing/text/html/FrameSetView.java ! src/share/classes/javax/swing/text/html/HTML.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/html/HTMLFrameHyperlinkEvent.java ! src/share/classes/javax/swing/text/html/HTMLWriter.java ! src/share/classes/javax/swing/text/html/OptionListModel.java ! src/share/classes/javax/swing/text/html/ParagraphView.java ! src/share/classes/javax/swing/text/html/StyleSheet.java ! src/share/classes/javax/swing/text/html/TableView.java ! src/share/classes/javax/swing/text/html/parser/ContentModel.java ! src/share/classes/javax/swing/text/html/parser/DocumentParser.java ! src/share/classes/javax/swing/text/html/parser/Element.java ! src/share/classes/javax/swing/text/html/parser/Parser.java ! src/share/classes/javax/swing/tree/AbstractLayoutCache.java ! src/share/classes/javax/swing/tree/DefaultTreeCellEditor.java ! src/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/share/classes/javax/swing/tree/FixedHeightLayoutCache.java ! src/share/classes/javax/swing/tree/TreeModel.java ! src/share/classes/javax/swing/tree/TreeSelectionModel.java ! src/share/classes/javax/swing/tree/VariableHeightLayoutCache.java ! src/share/classes/javax/xml/crypto/KeySelector.java ! src/share/classes/javax/xml/crypto/MarshalException.java ! src/share/classes/javax/xml/crypto/dsig/TransformException.java ! src/share/classes/javax/xml/crypto/dsig/XMLSignatureException.java ! src/share/classes/jdi-overview.html ! src/share/classes/jdk/internal/org/objectweb/asm/Frame.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Analyzer.java ! src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Interpreter.java ! src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java ! src/share/classes/jdk/internal/util/xml/XMLStreamException.java ! src/share/classes/jdk/internal/util/xml/impl/Parser.java ! src/share/classes/org/ietf/jgss/GSSContext.java ! src/share/classes/org/ietf/jgss/GSSCredential.java ! src/share/classes/org/ietf/jgss/GSSException.java ! src/share/classes/org/ietf/jgss/GSSManager.java ! src/share/classes/org/ietf/jgss/GSSName.java ! src/share/classes/org/ietf/jgss/package.html ! src/share/classes/sun/applet/AppletSecurity.java ! src/share/classes/sun/awt/FontConfiguration.java ! src/share/classes/sun/awt/GlobalCursorManager.java ! src/share/classes/sun/awt/shell/ShellFolderManager.java ! src/share/classes/sun/dc/DuctusRenderingEngine.java ! src/share/classes/sun/font/ExtendedTextSourceLabel.java ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/font/FontRunIterator.java ! src/share/classes/sun/font/LayoutPathImpl.java ! src/share/classes/sun/font/ScriptRun.java ! src/share/classes/sun/font/StrikeCache.java ! src/share/classes/sun/font/SunFontManager.java ! src/share/classes/sun/font/TrueTypeFont.java ! src/share/classes/sun/font/Type1Font.java ! src/share/classes/sun/java2d/SurfaceDataProxy.java ! src/share/classes/sun/java2d/loops/ProcessPath.java ! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java ! src/share/classes/sun/java2d/pipe/BufferedMaskFill.java ! src/share/classes/sun/java2d/pipe/BufferedRenderPipe.java ! src/share/classes/sun/java2d/pipe/BufferedTextPipe.java ! src/share/classes/sun/java2d/pipe/DrawImage.java ! src/share/classes/sun/java2d/pipe/RenderingEngine.java ! src/share/classes/sun/java2d/pipe/hw/AccelDeviceEventNotifier.java ! src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java ! src/share/classes/sun/jvmstat/perfdata/monitor/PerfDataBufferImpl.java ! src/share/classes/sun/jvmstat/perfdata/monitor/protocol/file/FileMonitoredVm.java ! src/share/classes/sun/management/counter/perf/InstrumentationException.java ! src/share/classes/sun/management/counter/perf/PerfDataType.java ! src/share/classes/sun/misc/CRC16.java ! src/share/classes/sun/misc/CharacterDecoder.java ! src/share/classes/sun/misc/PerformanceLogger.java ! src/share/classes/sun/net/NetworkClient.java ! src/share/classes/sun/net/TelnetOutputStream.java ! src/share/classes/sun/net/ftp/FtpClient.java ! src/share/classes/sun/net/ftp/impl/FtpClient.java ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/idn/StringPrep.java ! src/share/classes/sun/net/smtp/SmtpProtocolException.java ! src/share/classes/sun/net/www/http/ChunkedInputStream.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/http/PosterOutputStream.java ! src/share/classes/sun/net/www/protocol/http/AuthCacheValue.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java ! src/share/classes/sun/print/PSPathGraphics.java ! src/share/classes/sun/print/PSPrinterJob.java ! src/share/classes/sun/print/PathGraphics.java ! src/share/classes/sun/print/PrintJob2D.java ! src/share/classes/sun/print/RasterPrinterJob.java ! src/share/classes/sun/rmi/rmic/RemoteClass.java ! src/share/classes/sun/rmi/rmic/Util.java ! src/share/classes/sun/rmi/rmic/newrmic/jrmp/StubSkeletonWriter.java ! src/share/classes/sun/rmi/runtime/Log.java ! src/share/classes/sun/rmi/server/Activation.java ! src/share/classes/sun/rmi/transport/ObjectTable.java ! src/share/classes/sun/rmi/transport/tcp/ConnectionMultiplexer.java ! src/share/classes/sun/rmi/transport/tcp/MultiplexOutputStream.java ! src/share/classes/sun/rmi/transport/tcp/TCPChannel.java ! src/share/classes/sun/security/jca/GetInstance.java ! src/share/classes/sun/security/jgss/krb5/Krb5Context.java ! src/share/classes/sun/security/jgss/krb5/Krb5NameElement.java ! src/share/classes/sun/security/jgss/krb5/MessageToken.java ! src/share/classes/sun/security/jgss/spi/GSSContextSpi.java ! src/share/classes/sun/security/jgss/spnego/SpNegoContext.java ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/security/krb5/Realm.java ! src/share/classes/sun/security/krb5/internal/CredentialsUtil.java ! src/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java ! src/share/classes/sun/security/krb5/internal/crypto/DesCbcEType.java ! src/share/classes/sun/security/pkcs11/P11DHKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11DSAKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11RSAKeyFactory.java ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java ! src/share/classes/sun/security/provider/DSA.java ! src/share/classes/sun/security/provider/certpath/AdjacencyList.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ReverseBuilder.java ! src/share/classes/sun/security/rsa/RSAKeyPairGenerator.java ! src/share/classes/sun/security/ssl/HandshakeOutStream.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/RSASignature.java ! src/share/classes/sun/security/ssl/Record.java ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java ! src/share/classes/sun/security/ssl/SunJSSE.java ! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java ! src/share/classes/sun/security/ssl/X509KeyManagerImpl.java ! src/share/classes/sun/security/tools/jarsigner/Main.java ! src/share/classes/sun/security/util/HostnameChecker.java ! src/share/classes/sun/security/x509/AlgIdDSA.java ! src/share/classes/sun/swing/plaf/synth/DefaultSynthStyle.java ! src/share/classes/sun/swing/plaf/synth/Paint9Painter.java ! src/share/classes/sun/text/normalizer/ReplaceableUCharacterIterator.java ! src/share/classes/sun/text/resources/th/CollationData_th.java ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/jconsole/BorderedComponent.java ! src/share/classes/sun/tools/jconsole/inspector/XTextField.java ! src/share/classes/sun/tools/jinfo/JInfo.java ! src/share/classes/sun/tools/jmap/JMap.java ! src/share/classes/sun/tools/jstat/ColumnFormat.java ! src/share/classes/sun/tools/jstat/resources/jstat_options ! src/share/classes/sun/tools/tree/ExprExpression.java ! src/share/classes/sun/tools/tree/FieldExpression.java ! src/share/classes/sun/util/locale/provider/RuleBasedBreakIterator.java ! src/share/classes/sun/util/logging/PlatformLogger.java ! src/share/demo/jfc/Font2DTest/FontPanel.java ! src/share/demo/jfc/TableExample/TableExample4.java ! src/share/demo/jvmti/hprof/debug_malloc.c ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/javavm/export/jvm.h ! src/share/native/com/sun/java/util/jar/pack/zip.cpp ! src/share/native/com/sun/media/sound/PlatformMidi.h ! src/share/native/common/jni_util.h ! src/share/native/java/lang/fdlibm/src/k_rem_pio2.c ! src/share/native/java/util/zip/zip_util.c ! src/share/native/sun/awt/image/cvutils/img_dcm.h ! src/share/native/sun/awt/image/cvutils/img_replscale.h ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/awt/image/jpeg/jpegdecoder.c ! src/share/native/sun/awt/libpng/CHANGES ! src/share/native/sun/awt/libpng/png.h ! src/share/native/sun/awt/libpng/pngconf.h ! src/share/native/sun/awt/libpng/pngpriv.h ! src/share/native/sun/awt/libpng/pngrutil.c ! src/share/native/sun/font/layout/ArabicLayoutEngine.h ! src/share/native/sun/font/layout/IndicReordering.h ! src/share/native/sun/font/layout/KhmerReordering.cpp ! src/share/native/sun/font/layout/OpenTypeLayoutEngine.h ! src/share/native/sun/font/layout/TibetanReordering.cpp ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c ! src/share/native/sun/java2d/cmm/lcms/cmslut.c ! src/share/native/sun/java2d/loops/ProcessPath.c ! src/share/native/sun/java2d/opengl/OGLTextRenderer.c ! src/share/native/sun/security/pkcs11/wrapper/p11_sessmgmt.c ! src/share/sample/jmx/jmx-scandir/index.html ! src/share/sample/nio/chatserver/ClientReader.java ! src/share/sample/scripting/scriptpad/src/resources/gui.js ! src/solaris/classes/java/net/DefaultInterface.java ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDropTargetRegistry.java ! src/solaris/classes/sun/awt/X11/XMenuItemPeer.java ! src/solaris/classes/sun/awt/X11/XScrollbar.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11GraphicsConfig.java ! src/solaris/classes/sun/font/XMap.java ! src/solaris/classes/sun/java2d/jules/JulesAATileGenerator.java ! src/solaris/classes/sun/nio/fs/SolarisWatchService.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/solaris/classes/sun/nio/fs/UnixUriUtils.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! src/solaris/demo/jni/Poller/Poller.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_BsdOS_ALSA_Ports.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_Ports.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_SolarisOS_PCM.c ! src/solaris/native/com/sun/media/sound/PLATFORM_API_SolarisOS_Utils.h ! src/solaris/native/sun/awt/gtk2_interface.c ! src/solaris/native/sun/awt/multiVis.c ! src/solaris/native/sun/security/smartcardio/MUSCLE/pcsclite.h ! src/windows/classes/com/sun/tools/jdi/SharedMemoryAttachingConnector.java ! src/windows/classes/com/sun/tools/jdi/SharedMemoryListeningConnector.java ! src/windows/classes/java/net/DefaultInterface.java ! src/windows/classes/sun/awt/windows/WPathGraphics.java ! src/windows/classes/sun/java2d/d3d/D3DBlitLoops.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java ! src/windows/classes/sun/nio/fs/WindowsPath.java ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java ! src/windows/native/java/io/canonicalize_md.c ! src/windows/native/java/net/DualStackPlainSocketImpl.c ! src/windows/native/java/net/icmp.h ! src/windows/native/sun/font/fontpath.c ! src/windows/native/sun/java2d/d3d/D3DTextRenderer.cpp ! src/windows/native/sun/java2d/windows/GDIBlitLoops.cpp ! src/windows/native/sun/java2d/windows/GDIRenderer.cpp ! src/windows/native/sun/nio/ch/SocketChannelImpl.c ! src/windows/native/sun/security/krb5/NativeCreds.c ! src/windows/native/sun/windows/ThemeReader.cpp ! src/windows/native/sun/windows/awt_BitmapUtil.cpp ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Dialog.h ! src/windows/native/sun/windows/awt_DnDDS.cpp ! src/windows/native/sun/windows/awt_Font.h ! src/windows/native/sun/windows/awt_InputTextInfor.cpp ! src/windows/native/sun/windows/awt_PrintJob.cpp ! src/windows/native/sun/windows/awt_TextComponent.cpp Changeset: d4eb25382baf Author: malenkov Date: 2013-10-29 19:01 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4eb25382baf 8027442: JDK compilation fails on MacOS Reviewed-by: alexsch, pchelko ! src/share/classes/java/awt/Component.java Changeset: a2b42e558211 Author: bagiras Date: 2013-10-29 21:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a2b42e558211 8027151: AWT_DnD/Basic_DnD/Automated/DnDMerlinQL/MultipleJVM failing on windows machine Reviewed-by: anthony, pchelko ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java Changeset: db2838f25a85 Author: pchelko Date: 2013-10-30 12:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db2838f25a85 8027152: Regression: test closed/java/awt/Serialize/NullSerializationTest/NullSerializationTest.html fails since JDK 8 b112 Reviewed-by: art, serb ! src/share/classes/java/awt/Window.java + test/java/awt/Window/OwnedWindowsSerialization/OwnedWindowsSerialization.java Changeset: 05f04b1c5bd0 Author: leonidr Date: 2013-10-30 20:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/05f04b1c5bd0 8013581: [macosx] Key Bindings break with awt GraphicsEnvironment setFullScreenWindow Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformLWView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/CWrapper.m + test/java/awt/FullScreen/8013581/bug8013581.java Changeset: 6f436140049d Author: lana Date: 2013-10-31 16:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f436140049d Merge ! src/share/classes/java/awt/image/ComponentSampleModel.java ! src/share/classes/sun/print/RasterPrinterJob.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: f82b730c798b Author: lana Date: 2013-10-31 16:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f82b730c798b Merge - src/share/classes/java/lang/invoke/MagicLambdaImpl.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/net/URLDecoder.java ! src/share/classes/java/net/URLEncoder.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/javax/naming/ldap/Rdn.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/tools/jar/Main.java - src/share/demo/jfc/Notepad/resources/Notepad_fr.properties - src/share/demo/jfc/Notepad/resources/Notepad_sv.properties ! src/share/javavm/export/jvm.h ! src/share/native/com/sun/java/util/jar/pack/zip.cpp ! src/solaris/classes/sun/nio/fs/UnixPath.java - test/java/net/NetworkInterface/MemLeakTest.java - test/jdk/lambda/vm/DefaultMethodsTest.java - test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh - test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh - test/sun/tools/jstatd/jpsOutput1.awk - test/sun/tools/jstatd/jstatGcutilOutput1.awk - test/sun/tools/jstatd/jstatdDefaults.sh - test/sun/tools/jstatd/jstatdExternalRegistry.sh - test/sun/tools/jstatd/jstatdPort.sh - test/sun/tools/jstatd/jstatdServerName.sh - test/sun/tools/jstatd/jstatdUsage1.sh - test/sun/tools/jstatd/usage.out Changeset: a389b4f5723f Author: cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a389b4f5723f Added tag jdk8-b115 for changeset f82b730c798b ! .hgtags Changeset: a579e2f73bca Author: lana Date: 2013-11-08 17:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a579e2f73bca Merge ! src/share/classes/java/lang/invoke/MethodType.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! test/java/lang/Thread/ThreadStateTest.java From jan.lahoda at oracle.com Sat Nov 9 06:30:13 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Sat, 09 Nov 2013 14:30:13 +0000 Subject: hg: jdk8/tl/langtools: 8027142: Invokedynamic instructions don't get line number table entries Message-ID: <20131109143017.187C7624B8@hg.openjdk.java.net> Changeset: 6e0f31d61e56 Author: jlahoda Date: 2013-11-09 15:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6e0f31d61e56 8027142: Invokedynamic instructions don't get line number table entries Summary: When emitting invokedynamic instruction, write pendingStatPos, if set, into the LineNumberTable. Invokedynamic itself does not set the pendingStatPos. Reviewed-by: jjg, jrose, ksrini, vromero ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! test/tools/javac/T8019486/WrongLNTForLambdaTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java From alan.bateman at oracle.com Sat Nov 9 08:48:10 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 09 Nov 2013 16:48:10 +0000 Subject: hg: jdk8/tl/jdk: 8028044: [TEST_BUG] Calendar shell tests do not pass TESTVMOPTS Message-ID: <20131109164823.E49F0624BB@hg.openjdk.java.net> Changeset: 9130770fb6e3 Author: alanb Date: 2013-11-09 16:46 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9130770fb6e3 8028044: [TEST_BUG] Calendar shell tests do not pass TESTVMOPTS Reviewed-by: dholmes, alanb Contributed-by: patrick.zhang at oracle.com ! test/java/util/Calendar/GenericTimeZoneNamesTest.sh ! test/java/util/Calendar/NarrowNamesTest.sh From roger.riggs at oracle.com Sat Nov 9 11:32:24 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Sat, 09 Nov 2013 19:32:24 +0000 Subject: hg: jdk8/tl/jdk: 8028092: Lint cleanup of java.time.format Message-ID: <20131109193236.7865F624BE@hg.openjdk.java.net> Changeset: 3add16c86970 Author: rriggs Date: 2013-11-09 14:30 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3add16c86970 8028092: Lint cleanup of java.time.format Summary: correct declarations and add @SuppressWarnings Reviewed-by: darcy, lancea ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/Parsed.java From Alan.Bateman at oracle.com Sun Nov 10 12:19:52 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sun, 10 Nov 2013 20:19:52 +0000 Subject: qualified host parameter for UnknownHostException? In-Reply-To: References: <20131108211501.630EE62488@hg.openjdk.java.net> Message-ID: <527FEA68.9030903@oracle.com> On 08/11/2013 21:34, Bernd Eckenfels wrote: > Hello, > > BTW: it would be good if UHE had a data member of the not-found host > value. Actually the javadoc hints in that direction: > > # public UnknownHostException(String host) > # > # Parameters: > # host - the detail message. > > which is quite confusing. Maybe a new constructor like UHE(String > cause, String host, String osError) would be really usefull? The name of the parameter is confusing because the detail message can include both the hostname and the error details (if known). This came recently during the lengthy discussion about JDK-8010371 [1]. -Alan. [1] http://mail.openjdk.java.net/pipermail/net-dev/2013-October/007390.html From weijun.wang at oracle.com Sun Nov 10 23:22:12 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 11 Nov 2013 15:22:12 +0800 Subject: RFR: 8027991: InputStream should be closed in sun.security.tools.jarsigner.Main Message-ID: <528085A4.6010808@oracle.com> Hi All Please take a review at this small fix at http://cr.openjdk.java.net/~weijun/8027991/webrev.00/ The bug is https://bugs.openjdk.java.net/browse/JDK-8027991. Thanks Max From xuelei.fan at oracle.com Mon Nov 11 00:11:47 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 11 Nov 2013 16:11:47 +0800 Subject: RFR: 8027991: InputStream should be closed in sun.security.tools.jarsigner.Main In-Reply-To: <528085A4.6010808@oracle.com> References: <528085A4.6010808@oracle.com> Message-ID: <52809143.9050703@oracle.com> Looks fine. Xuelei On 11/11/2013 3:22 PM, Weijun Wang wrote: > Hi All > > Please take a review at this small fix at > > http://cr.openjdk.java.net/~weijun/8027991/webrev.00/ > > The bug is https://bugs.openjdk.java.net/browse/JDK-8027991. > > Thanks > Max From alan.bateman at oracle.com Mon Nov 11 00:39:34 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 11 Nov 2013 08:39:34 +0000 Subject: hg: jdk8/tl/jdk: 8028099: Many com/sun/management/OperatingSystemMXBean tests failing with CCE (win) Message-ID: <20131111083948.C6350624E3@hg.openjdk.java.net> Changeset: 2525b91ca5a6 Author: alanb Date: 2013-11-11 08:36 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2525b91ca5a6 8028099: Many com/sun/management/OperatingSystemMXBean tests failing with CCE (win) Reviewed-by: mchung ! src/windows/classes/sun/management/OperatingSystemImpl.java From weijun.wang at oracle.com Mon Nov 11 00:56:02 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 11 Nov 2013 08:56:02 +0000 Subject: hg: jdk8/tl/jdk: 8027991: InputStream should be closed in sun.security.tools.jarsigner.Main Message-ID: <20131111085614.8B424624E4@hg.openjdk.java.net> Changeset: 7304b3195212 Author: weijun Date: 2013-11-11 16:54 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7304b3195212 8027991: InputStream should be closed in sun.security.tools.jarsigner.Main Reviewed-by: xuelei ! src/share/classes/sun/security/tools/jarsigner/Main.java + test/sun/security/tools/jarsigner/CertChainUnclosed.java From chris.hegarty at oracle.com Mon Nov 11 02:34:18 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 11 Nov 2013 10:34:18 +0000 Subject: hg: jdk8/tl/jdk: 8028102: All test targets, jdk/test/Makefile, fail on Windows Message-ID: <20131111103441.A2965624F0@hg.openjdk.java.net> Changeset: b48eded97dff Author: chegar Date: 2013-11-11 10:33 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b48eded97dff 8028102: All test targets, jdk/test/Makefile, fail on Windows Reviewed-by: mduigou ! test/Makefile From xuelei.fan at oracle.com Mon Nov 11 05:44:56 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 11 Nov 2013 21:44:56 +0800 Subject: Code review request, 802314, Test DisabledShortRSAKeys.java intermittent failed Message-ID: <5280DF58.8080705@oracle.com> Please review a test stabilization fix. webrev: http://cr.openjdk.java.net/~xuelei/8023147/webrev.00/ Thanks, Xuelei From eric.mccorkle at oracle.com Mon Nov 11 06:48:13 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Mon, 11 Nov 2013 14:48:13 +0000 Subject: hg: jdk8/tl/langtools: 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass(); ... Message-ID: <20131111144816.61A23624F7@hg.openjdk.java.net> Changeset: 4788eb38cac5 Author: emc Date: 2013-11-11 09:47 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4788eb38cac5 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass() 8027253: javac illegally accepts array as bound Summary: backing out change allowing arrays in intersection types Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties - test/tools/javac/ArraysInIntersections.java - test/tools/javac/InferArraysInIntersections.java - test/tools/javac/diags/examples/InterfaceOrArrayExpected.java ! test/tools/javac/generics/typevars/6680106/T6680106.out From joel.franck at oracle.com Mon Nov 11 08:29:23 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Mon, 11 Nov 2013 16:29:23 +0000 Subject: hg: jdk8/tl/langtools: 8027375: javac asserts on nested erroneous annotations Message-ID: <20131111162926.A5F28624FD@hg.openjdk.java.net> Changeset: f3ca12d680f3 Author: jfranck Date: 2013-11-11 17:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3ca12d680f3 8027375: javac asserts on nested erroneous annotations Summary: make sure JCAnnotation trees have type != null before annotation processing Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Annotate.java + test/tools/javac/annotations/testCrashNestedAnnos/TestCrashNestedAnnos.java + test/tools/javac/annotations/testCrashNestedAnnos/TestCrashNestedAnnos.out From michael.x.mcmahon at oracle.com Mon Nov 11 08:06:42 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Mon, 11 Nov 2013 16:06:42 +0000 Subject: hg: jdk8/tl/jdk: 8028060: test/java/net/URLPermission/nstest/lookup.sh failing (win) Message-ID: <20131111160655.11C41624FB@hg.openjdk.java.net> Changeset: 0e47462f03a0 Author: michaelm Date: 2013-11-11 16:06 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e47462f03a0 8028060: test/java/net/URLPermission/nstest/lookup.sh failing (win) Reviewed-by: alanb ! test/java/net/URLPermission/nstest/LookupTest.java ! test/java/net/URLPermission/nstest/lookup.sh From lance.andersen at oracle.com Mon Nov 11 11:22:50 2013 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Mon, 11 Nov 2013 19:22:50 +0000 Subject: hg: jdk8/tl/jdk: 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal Message-ID: <20131111192304.9BEBB62502@hg.openjdk.java.net> Changeset: 59ff7957c26f Author: lancea Date: 2013-11-11 14:22 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59ff7957c26f 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal Reviewed-by: darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/BaseRow.java From staffan.larsen at oracle.com Mon Nov 11 12:17:23 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Mon, 11 Nov 2013 20:17:23 +0000 Subject: hg: jdk8/tl/jdk: 8014506: Test of Jdp feature Message-ID: <20131111201735.59C2462503@hg.openjdk.java.net> Changeset: 0cacac7f5c37 Author: sla Date: 2013-11-08 18:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cacac7f5c37 8014506: Test of Jdp feature Reviewed-by: sla Contributed-by: Alex Schenkman + test/sun/management/jdp/ClientConnection.java + test/sun/management/jdp/DynamicLauncher.java ! test/sun/management/jdp/JdpClient.java + test/sun/management/jdp/JdpDefaultsTest.java ! test/sun/management/jdp/JdpDoSomething.java + test/sun/management/jdp/JdpOffTest.java + test/sun/management/jdp/JdpOffTestCase.java + test/sun/management/jdp/JdpOnTestCase.java + test/sun/management/jdp/JdpSpecificAddressTest.java ! test/sun/management/jdp/JdpTest.sh + test/sun/management/jdp/JdpTestCase.java + test/sun/management/jdp/JdpTestUtil.java + test/sun/management/jdp/JdpTestUtilTest.java ! test/sun/management/jdp/JdpUnitTest.java + test/sun/management/jdp/PacketTest.java + test/sun/management/jdp/PortAlreadyInUseTest.java + test/sun/management/jdp/README From xueming.shen at oracle.com Mon Nov 11 14:41:14 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 11 Nov 2013 22:41:14 +0000 Subject: hg: jdk8/tl/jdk: 8026330: java.util.Base64 urlEncoder should omit padding Message-ID: <20131111224131.E205562510@hg.openjdk.java.net> Changeset: 8e8e423fa3dc Author: sherman Date: 2013-11-11 14:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e8e423fa3dc 8026330: java.util.Base64 urlEncoder should omit padding Summary: to add Encoder.withoutPadding() Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java From robert.field at oracle.com Mon Nov 11 16:14:35 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Tue, 12 Nov 2013 00:14:35 +0000 Subject: hg: jdk8/tl/jdk: 8027803: test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java fails Message-ID: <20131112001448.1A5AD62519@hg.openjdk.java.net> Changeset: c04e46dbfea8 Author: rfield Date: 2013-11-11 16:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c04e46dbfea8 8027803: test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java fails Summary: fix NPE in test infrastructure Reviewed-by: ksrini, jfranck, alanb, rfield Contributed-by: alan.bateman at oracle.com ! test/lib/testlibrary/ClassFileInstaller.java From john.r.rose at oracle.com Mon Nov 11 20:34:34 2013 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Tue, 12 Nov 2013 04:34:34 +0000 Subject: hg: jdk8/tl/jdk: 8027823: catchException combinator fails with 9 argument target Message-ID: <20131112043449.1415862520@hg.openjdk.java.net> Changeset: 9fcb07df1c92 Author: vlivanov Date: 2013-11-09 04:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fcb07df1c92 8027823: catchException combinator fails with 9 argument target Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MethodHandleImpl.java + test/java/lang/invoke/MethodHandles/TestCatchException.java From sundararajan.athijegannathan at oracle.com Tue Nov 12 00:47:45 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 12 Nov 2013 08:47:45 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20131112084747.6305262530@hg.openjdk.java.net> Changeset: e65a98146b94 Author: attila Date: 2013-11-11 14:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e65a98146b94 8028020: Function parameter as last expression in comma in return value causes bad type calculation Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8028020.js + test/script/basic/JDK-8028020.js.EXPECTED Changeset: 2f0f8d1d0753 Author: sundar Date: 2013-11-12 10:23 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2f0f8d1d0753 Merge From erik.gahlin at oracle.com Tue Nov 12 05:51:03 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Tue, 12 Nov 2013 13:51:03 +0000 Subject: hg: jdk8/tl/jdk: 8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently Message-ID: <20131112135120.AA67362538@hg.openjdk.java.net> Changeset: 41dcb0c2e194 Author: egahlin Date: 2013-11-12 14:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41dcb0c2e194 8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently Reviewed-by: sla, jbachorik ! test/javax/management/monitor/ThreadPoolAccTest.java From sean.mullan at oracle.com Tue Nov 12 05:57:13 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 12 Nov 2013 08:57:13 -0500 Subject: Code review request, 802314, Test DisabledShortRSAKeys.java intermittent failed In-Reply-To: <5280DF58.8080705@oracle.com> References: <5280DF58.8080705@oracle.com> Message-ID: <528233B9.3000907@oracle.com> Looks ok to me. --Sean On 11/11/2013 08:44 AM, Xuelei Fan wrote: > Please review a test stabilization fix. > > webrev: http://cr.openjdk.java.net/~xuelei/8023147/webrev.00/ > > Thanks, > Xuelei > From stuart.marks at oracle.com Tue Nov 12 07:59:42 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 12 Nov 2013 15:59:42 +0000 Subject: hg: jdk8/tl/jdk: 8028027: serialver should emit declaration with the 'private' modifier Message-ID: <20131112155956.6B77A62540@hg.openjdk.java.net> Changeset: f6012ca3bdd3 Author: smarks Date: 2013-11-12 16:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6012ca3bdd3 8028027: serialver should emit declaration with the 'private' modifier Reviewed-by: darcy, mchung, alanb, chegar ! src/share/classes/sun/tools/serialver/SerialVer.java From erik.gahlin at oracle.com Tue Nov 12 08:43:21 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Tue, 12 Nov 2013 16:43:21 +0000 Subject: hg: jdk8/tl/jdk: 6543856: MonitorVmStartTerminate.sh fails intermittently Message-ID: <20131112164335.7ADD962548@hg.openjdk.java.net> Changeset: 4cff9f59644f Author: egahlin Date: 2013-11-12 17:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4cff9f59644f 6543856: MonitorVmStartTerminate.sh fails intermittently Reviewed-by: sla, dholmes ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh ! test/sun/jvmstat/testlibrary/JavaProcess.java From erik.gahlin at oracle.com Tue Nov 12 09:14:54 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Tue, 12 Nov 2013 17:14:54 +0000 Subject: hg: jdk8/tl/jdk: 6849945: VM Periodic Task Thread CPU time = -1ns in HotspotThreadMBean.getInternalThreadCpuTimes() Message-ID: <20131112171507.B29336254A@hg.openjdk.java.net> Changeset: d9f827e4d20c Author: egahlin Date: 2013-11-12 18:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9f827e4d20c 6849945: VM Periodic Task Thread CPU time = -1ns in HotspotThreadMBean.getInternalThreadCpuTimes() Reviewed-by: sla ! test/sun/management/HotspotThreadMBean/GetInternalThreads.java From joe.darcy at oracle.com Tue Nov 12 09:44:54 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 12 Nov 2013 17:44:54 +0000 Subject: hg: jdk8/tl/jdk: 8028229: Fix more raw types lint warning in core libraries Message-ID: <20131112174506.65E876254F@hg.openjdk.java.net> Changeset: 69432cb5bca2 Author: darcy Date: 2013-11-12 09:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69432cb5bca2 8028229: Fix more raw types lint warning in core libraries Reviewed-by: chegar, forax, lancea, alanb, jfranck ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/java/nio/file/TempFileHelper.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/sun/misc/Cleaner.java ! src/share/classes/sun/misc/ProxyGenerator.java ! src/share/classes/sun/rmi/rmic/Main.java ! src/share/classes/sun/rmi/server/LoaderHandler.java ! src/share/classes/sun/rmi/server/UnicastServerRef.java ! src/share/classes/sun/rmi/server/Util.java From alan.bateman at oracle.com Tue Nov 12 09:39:38 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 12 Nov 2013 17:39:38 +0000 Subject: hg: jdk8/tl/jdk: 8028208: (aio) Assertion in clearPendingIoMap when closing at around time file lock is acquired immediately (win) Message-ID: <20131112173950.14FC86254D@hg.openjdk.java.net> Changeset: 0c414ac10700 Author: alanb Date: 2013-11-12 17:37 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c414ac10700 8028208: (aio) Assertion in clearPendingIoMap when closing at around time file lock is acquired immediately (win) Reviewed-by: chegar ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! test/ProblemList.txt From roger.riggs at oracle.com Tue Nov 12 11:04:28 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 12 Nov 2013 19:04:28 +0000 Subject: hg: jdk8/tl/jdk: 8028014: Doclint warning/error cleanup in javax.management Message-ID: <20131112190440.BADB762550@hg.openjdk.java.net> Changeset: ebe27e1a2e2d Author: rriggs Date: 2013-11-12 14:03 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ebe27e1a2e2d 8028014: Doclint warning/error cleanup in javax.management Summary: Improve generated html by fixing doclint warnings Reviewed-by: sla, jbachorik ! src/share/classes/javax/management/AttributeList.java ! src/share/classes/javax/management/BooleanValueExp.java ! src/share/classes/javax/management/Descriptor.java ! src/share/classes/javax/management/DescriptorKey.java ! src/share/classes/javax/management/ImmutableDescriptor.java ! src/share/classes/javax/management/JMX.java ! src/share/classes/javax/management/MBeanFeatureInfo.java ! src/share/classes/javax/management/MBeanInfo.java ! src/share/classes/javax/management/MBeanServer.java ! src/share/classes/javax/management/MBeanServerConnection.java ! src/share/classes/javax/management/MBeanServerNotification.java ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/NumericValueExp.java ! src/share/classes/javax/management/ObjectName.java ! src/share/classes/javax/management/PersistentMBean.java ! src/share/classes/javax/management/Query.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/loading/MLetParser.java ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanConstructorInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationBroadcaster.java ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanOperationInfo.java ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/management/monitor/Monitor.java ! src/share/classes/javax/management/openmbean/ArrayType.java ! src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java ! src/share/classes/javax/management/openmbean/CompositeType.java ! src/share/classes/javax/management/openmbean/OpenMBeanAttributeInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenMBeanParameterInfoSupport.java ! src/share/classes/javax/management/openmbean/SimpleType.java ! src/share/classes/javax/management/openmbean/TabularType.java ! src/share/classes/javax/management/relation/Relation.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/relation/RelationServiceMBean.java ! src/share/classes/javax/management/relation/RelationSupport.java ! src/share/classes/javax/management/remote/JMXConnectionNotification.java ! src/share/classes/javax/management/remote/JMXConnector.java ! src/share/classes/javax/management/remote/JMXConnectorProvider.java ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/remote/rmi/RMIServerImpl.java From alan.bateman at oracle.com Tue Nov 12 23:44:59 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 13 Nov 2013 07:44:59 +0000 Subject: hg: jdk8/tl/jdk: 8028239: test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh with NoClassDefFoundError Message-ID: <20131113074515.A6FB762564@hg.openjdk.java.net> Changeset: c4c84b5a3dfa Author: alanb Date: 2013-11-13 07:43 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4c84b5a3dfa 8028239: test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh with NoClassDefFoundError Reviewed-by: mchung, egahlin ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh From xuelei.fan at oracle.com Wed Nov 13 01:16:44 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 13 Nov 2013 09:16:44 +0000 Subject: hg: jdk8/tl/jdk: 8023147: Test DisabledShortRSAKeys.java intermittent failed Message-ID: <20131113091702.709E062568@hg.openjdk.java.net> Changeset: 1158d504e39e Author: xuelei Date: 2013-11-13 01:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1158d504e39e 8023147: Test DisabledShortRSAKeys.java intermittent failed Reviewed-by: mullan ! test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java From daniel.fuchs at oracle.com Wed Nov 13 01:51:29 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Wed, 13 Nov 2013 09:51:29 +0000 Subject: hg: jdk8/tl/jdk: 8026952: Test java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java has wrong @bug id Message-ID: <20131113095143.6488E6256C@hg.openjdk.java.net> Changeset: 30a3aefc4084 Author: dfuchs Date: 2013-11-13 10:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30a3aefc4084 8026952: Test java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java has wrong @bug id Summary: Trivial: change @bug 8023163 into @bug 8026499 Reviewed-by: mchung, alanb ! test/java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java From erik.gahlin at oracle.com Wed Nov 13 06:27:41 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Wed, 13 Nov 2013 14:27:41 +0000 Subject: hg: jdk8/tl/jdk: 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java Message-ID: <20131113142753.A0AA96256F@hg.openjdk.java.net> Changeset: ddaa9a8acaed Author: egahlin Date: 2013-11-13 15:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddaa9a8acaed 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java Reviewed-by: sla, jbachorik ! test/ProblemList.txt ! test/javax/management/loading/LibraryLoader/LibraryLoaderTest.java From staffan.larsen at oracle.com Wed Nov 13 06:34:56 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 13 Nov 2013 14:34:56 +0000 Subject: hg: jdk8/tl/jdk: 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary Message-ID: <20131113143508.BBA8062570@hg.openjdk.java.net> Changeset: a42a416351b8 Author: ykantser Date: 2013-11-13 11:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a42a416351b8 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary Reviewed-by: sla + test/lib/testlibrary/AssertsTest.java + test/lib/testlibrary/OutputAnalyzerReportingTest.java + test/lib/testlibrary/jdk/testlibrary/InputArguments.java ! test/lib/testlibrary/jdk/testlibrary/JcmdBase.java - test/lib/testlibrary/jdk/testlibrary/JdkFinder.java ! test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java ! test/lib/testlibrary/jdk/testlibrary/ProcessTools.java ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java From mandy.chung at oracle.com Wed Nov 13 07:55:40 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 13 Nov 2013 15:55:40 +0000 Subject: hg: jdk8/tl/jdk: 8028234: Remove unused methods in sun.misc.JavaAWTAccess Message-ID: <20131113155557.74F7162577@hg.openjdk.java.net> Changeset: 7c55fecfae65 Author: mchung Date: 2013-11-13 07:49 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c55fecfae65 8028234: Remove unused methods in sun.misc.JavaAWTAccess Reviewed-by: art, dfuchs, lancea ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/misc/JavaAWTAccess.java ! test/java/util/logging/TestAppletLoggerContext.java From chris.hegarty at oracle.com Wed Nov 13 08:50:22 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 13 Nov 2013 16:50:22 +0000 Subject: hg: jdk8/tl/jdk: 8022213: Intermittent test failures in java/net/URLClassLoader Message-ID: <20131113165036.69A376257A@hg.openjdk.java.net> Changeset: 70f1bed5e7fd Author: chegar Date: 2013-11-13 16:44 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70f1bed5e7fd 8022213: Intermittent test failures in java/net/URLClassLoader Reviewed-by: dxu, alanb ! test/java/net/URLClassLoader/closetest/CloseTest.java ! test/java/net/URLClassLoader/closetest/Common.java ! test/java/net/URLClassLoader/closetest/GetResourceAsStream.java + test/lib/testlibrary/jdk/testlibrary/FileUtils.java From alan.bateman at oracle.com Wed Nov 13 09:08:02 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 13 Nov 2013 17:08:02 +0000 Subject: hg: jdk8/tl/jdk: 8028270: Files.readSymbolicLink calls AccessController directly so security manager can't grant the permission Message-ID: <20131113170815.347746257C@hg.openjdk.java.net> Changeset: a493871959c2 Author: alanb Date: 2013-11-13 16:52 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a493871959c2 8028270: Files.readSymbolicLink calls AccessController directly so security manager can't grant the permission Reviewed-by: mchung, martin, chegar ! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java ! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java ! test/java/nio/file/Files/CheckPermissions.java From erik.gahlin at oracle.com Wed Nov 13 09:39:05 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Wed, 13 Nov 2013 17:39:05 +0000 Subject: hg: jdk8/tl/jdk: 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh Message-ID: <20131113173917.E60F76257F@hg.openjdk.java.net> Changeset: 256b3395346b Author: egahlin Date: 2013-11-13 18:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/256b3395346b 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh Reviewed-by: sla, sspitsyn ! test/com/sun/jdi/BreakpointWithFullGC.sh From jaroslav.bachorik at oracle.com Sun Nov 10 11:07:18 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Sun, 10 Nov 2013 19:07:18 +0000 Subject: hg: jdk8/tl/jdk: 6523160: RuntimeMXBean.getUptime() returns negative values Message-ID: <20131110190730.17488624D7@hg.openjdk.java.net> Changeset: 0c75cc07d264 Author: jbachorik Date: 2013-11-10 20:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c75cc07d264 6523160: RuntimeMXBean.getUptime() returns negative values Summary: RuntimeMXBean.getUptime() should be based on HR timers rather than on the OS time Reviewed-by: dholmes, sla ! make/java/management/mapfile-vers ! makefiles/mapfiles/libmanagement/mapfile-vers ! src/share/classes/sun/management/RuntimeImpl.java ! src/share/classes/sun/management/VMManagement.java ! src/share/classes/sun/management/VMManagementImpl.java ! src/share/javavm/export/jmm.h ! src/share/native/sun/management/VMManagementImpl.c ! test/java/lang/management/RuntimeMXBean/UpTime.java From jaroslav.bachorik at oracle.com Wed Nov 13 04:13:53 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Wed, 13 Nov 2013 12:13:53 +0000 Subject: hg: jdk8/tl/jdk: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently Message-ID: <20131113121406.976CA6256E@hg.openjdk.java.net> Changeset: 680ef14a2cc0 Author: jbachorik Date: 2013-11-13 13:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/680ef14a2cc0 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently Reviewed-by: dholmes, ykantser ! test/com/sun/jdi/BadHandshakeTest.java From joe.darcy at oracle.com Wed Nov 13 11:07:25 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 13 Nov 2013 19:07:25 +0000 Subject: hg: jdk8/tl/jdk: 8028300: Fix raw type lint warnings in java.util.concurrent Message-ID: <20131113190739.7517462583@hg.openjdk.java.net> Changeset: e6333788b117 Author: darcy Date: 2013-11-13 11:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6333788b117 8028300: Fix raw type lint warnings in java.util.concurrent Reviewed-by: chegar, martin ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java From xueming.shen at oracle.com Wed Nov 13 11:32:02 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 13 Nov 2013 19:32:02 +0000 Subject: hg: jdk8/tl/jdk: 8027645: Pattern.split() with positive lookahead; ... Message-ID: <20131113193214.D483262584@hg.openjdk.java.net> Changeset: 9e37caf07ce0 Author: sherman Date: 2013-11-13 11:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e37caf07ce0 8027645: Pattern.split() with positive lookahead 6559590: Pattern.compile(".*").split("") returns incorrect result Summary: updated spec/impl for these two corner cases Reviewed-by: alanb, psandoz ! src/share/classes/java/lang/String.java ! src/share/classes/java/util/regex/Pattern.java ! test/java/lang/String/Split.java ! test/java/util/regex/RegExTest.java From lana.steuck at oracle.com Wed Nov 13 11:49:57 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 13 Nov 2013 19:49:57 +0000 Subject: hg: jdk8/tl/hotspot: 18 new changesets Message-ID: <20131113195035.6D74A62586@hg.openjdk.java.net> Changeset: 5b84039ca739 Author: amurillo Date: 2013-11-01 08:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5b84039ca739 8027580: new hotspot build - hs25-b58 Reviewed-by: jcoomes ! make/hotspot_version Changeset: ea79ab313e98 Author: mgerdin Date: 2013-10-30 15:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ea79ab313e98 8027252: Crash in interpreter because get_unsigned_2_byte_index_at_bcp reads 4 bytes Summary: Use 2-byte loads to load indexes from the byte code stream to avoid out of bounds reads. Reviewed-by: coleenp, sspitsyn ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp Changeset: fdd464c8d62e Author: acorn Date: 2013-10-30 09:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fdd464c8d62e 8027304: Lambda: inheriting abstract + 1 default -> default, not ICCE Reviewed-by: hseigel, zgu ! src/share/vm/classfile/defaultMethods.cpp Changeset: 4fe7815b04f5 Author: acorn Date: 2013-10-30 09:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4fe7815b04f5 Merge Changeset: c8fc12209830 Author: coleenp Date: 2013-10-31 14:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c8fc12209830 8027616: Off by one error in putback for compressed oops nashorn performance improvement Summary: Should compare bounds greater than or equal 4G when deciding if shift is needed or CDS area + compressed class space are within 4G of each other. Reviewed-by: stefank, hseigel, zgu ! src/share/vm/memory/metaspace.cpp Changeset: 910026b800b8 Author: coleenp Date: 2013-11-01 10:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/910026b800b8 8026946: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint should use MethodHandle 8026948: JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint might not work with anonymous classes Summary: Walk methods in breakpoints for marking on stack so they aren't deallocated by redefine classes. Use class_holder rather than class_loader to keep GC from reclaiming class owning the method. Reviewed-by: sspitsyn, ehelin, sla ! src/share/vm/classfile/metadataOnStackMark.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiImpl.hpp Changeset: 42790b7e4d48 Author: mgronlun Date: 2013-11-01 15:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/42790b7e4d48 Merge ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp Changeset: f8b56489e455 Author: mgronlun Date: 2013-11-01 17:10 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f8b56489e455 Merge Changeset: 04df110c8655 Author: mgronlun Date: 2013-11-02 20:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/04df110c8655 Merge Changeset: 208ebea980f8 Author: roland Date: 2013-11-04 21:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/208ebea980f8 8027445: SIGSEGV at TestFloatingDecimal.testAppendToDouble()I Summary: String.equals() intrinsic shouldn't use integer length input in pointer arithmetic without an i2l. Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/sparc.ad + test/compiler/intrinsics/stringequals/TestStringEqualsBadLength.java Changeset: e428d5e768e3 Author: rbackman Date: 2013-11-04 10:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e428d5e768e3 8027622: java.time.Instant.create failing since hs25-b56 Reviewed-by: kvn, iveresov ! src/share/vm/opto/compile.cpp + test/compiler/intrinsics/mathexact/CompareTest.java Changeset: a905d33ce13a Author: iveresov Date: 2013-11-05 00:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a905d33ce13a 8027751: C1 crashes in Weblogic with G1 enabled Summary: Keep T_OBJECT operands in registers for logical operations on x64 Reviewed-by: kvn, roland ! src/share/vm/c1/c1_LinearScan.cpp + test/compiler/regalloc/C1ObjectSpillInLogicOp.java Changeset: 94a83e0f9ce1 Author: iveresov Date: 2013-11-05 01:57 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/94a83e0f9ce1 8017065: C2 allows safepoint checks to leak into G1 pre-barriers Summary: Make all raw loads strictly respect control dependencies, make sure RCE doesn't move raw loads, add verification of G1 pre-barriers. Reviewed-by: kvn, roland ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/memnode.hpp Changeset: 613e6a6fc328 Author: iveresov Date: 2013-11-05 02:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/613e6a6fc328 Merge ! src/share/vm/opto/compile.cpp Changeset: be525e91f65b Author: mikael Date: 2013-11-06 06:51 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/be525e91f65b 8026775: nsk/jvmti/RedefineClasses/StressRedefine crashes due to EXCEPTION_ACCESS_VIOLATION Summary: Uncommon trap blob did not bang all the stack shadow pages Reviewed-by: kvn, twisti, iveresov, jrose ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/share/vm/asm/assembler.cpp + test/compiler/uncommontrap/UncommonTrapStackBang.java Changeset: 53662b2f1d68 Author: drchase Date: 2013-11-07 10:02 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/53662b2f1d68 Merge Changeset: e510dfdec6dd Author: amurillo Date: 2013-11-08 07:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e510dfdec6dd Merge Changeset: 52b076e6ffae Author: amurillo Date: 2013-11-08 07:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/52b076e6ffae Added tag hs25-b58 for changeset e510dfdec6dd ! .hgtags From eric.mccorkle at oracle.com Wed Nov 13 12:50:23 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Wed, 13 Nov 2013 20:50:23 +0000 Subject: hg: jdk8/tl/jdk: 8026884: test for fix of JDK-8021398 does not have @bug tag; ... Message-ID: <20131113205036.438CA6258F@hg.openjdk.java.net> Changeset: ea91826bc2e9 Author: emc Date: 2013-11-13 15:48 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea91826bc2e9 8026884: test for fix of JDK-8021398 does not have @bug tag 8028021: @since 1.8 missing for certain methods in java.lang.reflect.Method in generated api docs Summary: two documentation fixes Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Executable.java ! test/java/lang/reflect/Parameter/GetAnnotatedTypeTest.java From valerie.peng at oracle.com Wed Nov 13 13:43:31 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Wed, 13 Nov 2013 13:43:31 -0800 Subject: Code Review Request for 8026943: SQE test jce/Global/Cipher/SameBuffer failed Message-ID: <5283F283.6010706@oracle.com> Can someone help review my fixes for 8026943 "SQE test jce/Global/Cipher/SameBuffer failed"? According to Cipher javadoc, both its update(...) and doFinal(...) methods should be copy-safe, meaning the |input| and |output| buffers can reference the same byte array and no unprocessed input data is overwritten when the result is copied into the output buffer. In CipherCore class, this condition is not checked and thus leads to the scenarios of unprocessed input data being accidentally overwritten. I added checks to CipherCore class to detect this for both update(...)/doFinal(...) operations. DESedeWrapCipher class is also updated to not pass the same byte array for input and output when using FeedbackCipher objects. Also, removed similar handling inside CipherBlockChaining class as it's now handled at its caller level (CipherCore and DESedeWrapCipher classes). Webrev: http://cr.openjdk.java.net/~valeriep/8026943/webrev.00/ Thanks, Valerie -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131113/c47d95c1/attachment.html From sonali.goel at oracle.com Wed Nov 13 16:36:45 2013 From: sonali.goel at oracle.com (sonali.goel at oracle.com) Date: Thu, 14 Nov 2013 00:36:45 +0000 Subject: hg: jdk8/tl/langtools: 8025113: Convert 7 tools TryWithResources tests to jtreg format Message-ID: <20131114003648.C95BA62593@hg.openjdk.java.net> Changeset: f90d88913c5f Author: sogoel Date: 2013-11-13 16:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f90d88913c5f 8025113: Convert 7 tools TryWithResources tests to jtreg format Reviewed-by: darcy, jjg + test/tools/javac/TryWithResources/ResDeclOutsideTry.java + test/tools/javac/TryWithResources/ResDeclOutsideTry.out + test/tools/javac/TryWithResources/ResInNestedExpr.java + test/tools/javac/TryWithResources/ResourceNameConflict.java + test/tools/javac/TryWithResources/ResourceNameConflict.out + test/tools/javac/TryWithResources/ResourceRedecl.java + test/tools/javac/TryWithResources/ResourceRedecl.out + test/tools/javac/TryWithResources/ResourceShadow.java + test/tools/javac/TryWithResources/TestTwr09.java From xueming.shen at oracle.com Wed Nov 13 22:29:09 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 14 Nov 2013 06:29:09 +0000 Subject: hg: jdk8/tl/jdk: 8028321: Fix for String.split() empty input sequence/JDK-6559590 triggers regression Message-ID: <20131114062922.B87BA6259B@hg.openjdk.java.net> Changeset: 1d790a56de4e Author: sherman Date: 2013-11-13 22:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d790a56de4e 8028321: Fix for String.split() empty input sequence/JDK-6559590 triggers regression Summary: to undo the change for 6559590 Reviewed-by: darcy ! src/share/classes/java/lang/String.java ! src/share/classes/java/util/regex/Pattern.java ! test/java/lang/String/Split.java ! test/java/util/regex/RegExTest.java From rajan.halade at oracle.com Wed Nov 13 23:28:16 2013 From: rajan.halade at oracle.com (Rajan Halade) Date: Wed, 13 Nov 2013 23:28:16 -0800 Subject: Code Review Request: 8014266 Message-ID: <52847B90.90009@oracle.com> May I request you to review this simple change. http://cr.openjdk.java.net/~xuelei/8014266/webrev/ This is to update the test comment to assist in timeout analysis. The test may timeout on heavy loaded system as it involves multiple tls transactions. -- Rajan Halade, CISSP | Senior Member of Technical Staff Phone: +1 4082763359 Oracle JAVA Platform Group 4220 Network Circle, Bldg 22, #2155 | Santa Clara, CA 94538 Oracle is committed to developing practices and products that help protect the environment -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131113/4b304596/attachment.html From xuelei.fan at oracle.com Wed Nov 13 23:39:32 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 14 Nov 2013 15:39:32 +0800 Subject: Code Review Request: 8014266 In-Reply-To: <52847B90.90009@oracle.com> References: <52847B90.90009@oracle.com> Message-ID: <52847E34.1000404@oracle.com> Looks fine to me. Xuelei On 11/14/2013 3:28 PM, Rajan Halade wrote: > May I request you to review this simple change. > http://cr.openjdk.java.net/~xuelei/8014266/webrev/ > > This is to update the test comment to assist in timeout analysis. The > test may timeout on heavy loaded system as it involves multiple tls > transactions. > > -- > Rajan Halade, CISSP | Senior Member of Technical > Staff > Phone: +1 4082763359 > Oracle JAVA Platform Group > 4220 Network Circle, Bldg 22, #2155 | Santa Clara, CA 94538 > Oracle is committed to developing > practices and products that help protect the environment From alan.bateman at oracle.com Thu Nov 14 02:43:36 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 14 Nov 2013 10:43:36 +0000 Subject: hg: jdk8/tl/jdk: 8028343: More ProblemList.txt updates (11/2013) Message-ID: <20131114104348.19AE1625A2@hg.openjdk.java.net> Changeset: ecf85f4aecf0 Author: alanb Date: 2013-11-14 10:40 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecf85f4aecf0 8028343: More ProblemList.txt updates (11/2013) Reviewed-by: chegar ! test/ProblemList.txt From joel.franck at oracle.com Thu Nov 14 03:42:36 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Thu, 14 Nov 2013 11:42:36 +0000 Subject: hg: jdk8/tl/jdk: 8028055: (reflect) invoking Method/Constructor in anonymous classes breaks with -Dsun.reflect.noInflation=true Message-ID: <20131114114248.958AD625A8@hg.openjdk.java.net> Changeset: 83c768d6cb93 Author: jfranck Date: 2013-11-14 12:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83c768d6cb93 8028055: (reflect) invoking Method/Constructor in anonymous classes breaks with -Dsun.reflect.noInflation=true Reviewed-by: briangoetz ! src/share/classes/sun/reflect/ReflectionFactory.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java ! test/java/lang/invoke/lambda/RepetitiveLambdaSerialization.java ! test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java From sergey.lugovoy at oracle.com Thu Nov 14 00:44:48 2013 From: sergey.lugovoy at oracle.com (Sergey Lugovoy) Date: Thu, 14 Nov 2013 12:44:48 +0400 Subject: [security dev] [8] Review request for JDK-8028266 : Tidy warnings cleanup for packages java.security/javax.security Message-ID: <2405806.GIg7MIdCZp@workland> Hi all, please review the fix http://cr.openjdk.java.net/~yan/8028266/webrev.00/[1] for https://bugs.openjdk.java.net/browse/JDK-8028266 This patch cleanup tidy warnings for generated html documentation, and do not affect the appearance of the documentation. Best regards, Serge V. Lugovoy -------- [1] http://cr.openjdk.java.net/~yan/8028266/webrev.00/ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131114/741eb293/attachment.html From sean.mullan at oracle.com Thu Nov 14 07:01:08 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 14 Nov 2013 10:01:08 -0500 Subject: [security dev] [8] Review request for JDK-8028266 : Tidy warnings cleanup for packages java.security/javax.security In-Reply-To: <2405806.GIg7MIdCZp@workland> References: <2405806.GIg7MIdCZp@workland> Message-ID: <5284E5B4.3090809@oracle.com> Just one comment. I would prefer if you changed the following pattern: * *

* to: * instead of: * * There is no need for the extra line. Thanks, Sean On 11/14/2013 03:44 AM, Sergey Lugovoy wrote: > Hi all, > > please review the fix > > http://cr.openjdk.java.net/~yan/8028266/webrev.00/ > > for > > https://bugs.openjdk.java.net/browse/JDK-8028266 > > This patch cleanup tidy warnings for generated html documentation, and > do not > > affect the appearance of the documentation. > > Best regards, > > Serge V. Lugovoy > From sean.mullan at oracle.com Thu Nov 14 08:20:38 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 14 Nov 2013 11:20:38 -0500 Subject: Code Review Request for 8026943: SQE test jce/Global/Cipher/SameBuffer failed In-Reply-To: <5283F283.6010706@oracle.com> References: <5283F283.6010706@oracle.com> Message-ID: <5284F856.9010608@oracle.com> This looks good to me. --Sean On 11/13/2013 04:43 PM, Valerie (Yu-Ching) Peng wrote: > > Can someone help review my fixes for 8026943 "SQE test > jce/Global/Cipher/SameBuffer failed"? > > According to Cipher javadoc, both its update(...) and doFinal(...) > methods should be copy-safe, meaning the |input| and |output| buffers > can reference the same byte array and no unprocessed input data is > overwritten when the result is copied into the output buffer. In > CipherCore class, this condition is not checked and thus leads to the > scenarios of unprocessed input data being accidentally overwritten. > > I added checks to CipherCore class to detect this for both > update(...)/doFinal(...) operations. > DESedeWrapCipher class is also updated to not pass the same byte array > for input and output when using FeedbackCipher objects. > Also, removed similar handling inside CipherBlockChaining class as it's > now handled at its caller level (CipherCore and DESedeWrapCipher classes). > > Webrev: http://cr.openjdk.java.net/~valeriep/8026943/webrev.00/ > > Thanks, > Valerie From eric.mccorkle at oracle.com Thu Nov 14 09:33:25 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Thu, 14 Nov 2013 17:33:25 +0000 Subject: hg: jdk8/tl/langtools: 8028282: Remove @ignore from test langtools/test/tools/javac/T7042623.java Message-ID: <20131114173330.0D859625BF@hg.openjdk.java.net> Changeset: 24eaf41a3974 Author: emc Date: 2013-11-14 12:32 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/24eaf41a3974 8028282: Remove @ignore from test langtools/test/tools/javac/T7042623.java Summary: Remove @ignore from test Reviewed-by: jjg ! test/tools/javac/T7042623.java From staffan.larsen at oracle.com Thu Nov 14 10:34:23 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Thu, 14 Nov 2013 18:34:23 +0000 Subject: hg: jdk8/tl/jdk: 8027765: Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent Message-ID: <20131114183436.E0B7A625CE@hg.openjdk.java.net> Changeset: 65f7b83ab477 Author: sla Date: 2013-11-14 19:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/65f7b83ab477 8027765: Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent Reviewed-by: alanb, allwin, sspitsyn, mgronlun ! src/share/classes/sun/tools/jinfo/JInfo.java ! src/share/classes/sun/tools/jmap/JMap.java ! src/share/classes/sun/tools/jps/Jps.java ! src/share/classes/sun/tools/jstack/JStack.java From joe.darcy at oracle.com Thu Nov 14 11:12:29 2013 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 14 Nov 2013 11:12:29 -0800 Subject: [security dev] [8] Review request for JDK-8028266 : Tidy warnings cleanup for packages java.security/javax.security In-Reply-To: <5284E5B4.3090809@oracle.com> References: <2405806.GIg7MIdCZp@workland> <5284E5B4.3090809@oracle.com> Message-ID: <5285209D.4070304@oracle.com> Might just be my limited knowledge of HTML, but I don't understand the replacement of

with
in several places like: --- old/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java 2013-11-14 07:44:04.878682607 +0000 +++ new/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java 2013-11-14 07:44:04.718682612 +0000 @@ -48,14 +48,14 @@ *

* For example, to specify the "host" service use of a forwardable TGT the * target permission is specified as follows: - *

+ *
*

   *  DelegationPermission("\"host/foo.example.com at EXAMPLE.COM\" 
\"krbtgt/EXAMPLE.COM at EXAMPLE.COM\"");
   * 
*

* To give the "backup" service a proxiable nfs service ticket the target permission * might be specified: - *

+ *
*

   *  DelegationPermission("\"backup/bar.example.com at EXAMPLE.COM\" 
\"nfs/home.EXAMPLE.COM at EXAMPLE.COM\"");
   * 
Otherwise, the patch looks fine. -Joe On 11/14/2013 07:01 AM, Sean Mullan wrote: > Just one comment. I would prefer if you changed the following pattern: > > * > *

> * > > to: > > * > > instead of: > > * > * > > There is no need for the extra line. > > Thanks, > Sean > > On 11/14/2013 03:44 AM, Sergey Lugovoy wrote: >> Hi all, >> >> please review the fix >> >> http://cr.openjdk.java.net/~yan/8028266/webrev.00/ >> >> for >> >> https://bugs.openjdk.java.net/browse/JDK-8028266 >> >> This patch cleanup tidy warnings for generated html documentation, and >> do not >> >> affect the appearance of the documentation. >> >> Best regards, >> >> Serge V. Lugovoy >> > From vicente.romero at oracle.com Thu Nov 14 11:28:57 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 14 Nov 2013 19:28:57 +0000 Subject: hg: jdk8/tl/langtools: 8026963: type annotations code crashes for code with erroneous trees Message-ID: <20131114192901.60365625F2@hg.openjdk.java.net> Changeset: e79d6425f1c4 Author: vromero Date: 2013-11-14 19:28 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e79d6425f1c4 8026963: type annotations code crashes for code with erroneous trees Reviewed-by: jjg, jlahoda ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/T8026963/TypeAnnotationsCrashWithErroneousTreeTest.java + test/tools/javac/T8026963/TypeAnnotationsCrashWithErroneousTreeTest.out From coleen.phillimore at oracle.com Thu Nov 14 11:18:26 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Thu, 14 Nov 2013 19:18:26 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131114191851.C3BDD625F0@hg.openjdk.java.net> Changeset: 59f46f135584 Author: hseigel Date: 2013-11-14 10:44 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59f46f135584 8023041: The CDS classlist needs to be updated for JDK 8 Summary: Generate new classlists from JDK 8 classes Reviewed-by: alanb, coleenp, hseigel Contributed-by: ekaterina.pavlova at oracle.com ! make/tools/sharing/classlist.linux ! make/tools/sharing/classlist.macosx ! make/tools/sharing/classlist.solaris ! make/tools/sharing/classlist.windows Changeset: f893901ba29c Author: coleenp Date: 2013-11-14 14:01 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f893901ba29c Merge From bhavesh.x.patel at oracle.com Thu Nov 14 13:48:47 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Thu, 14 Nov 2013 21:48:47 +0000 Subject: hg: jdk8/tl/langtools: 8025524: javadoc does not correctly locate constructors for nested classes Message-ID: <20131114214851.77B44625FA@hg.openjdk.java.net> Changeset: 5ae66d372d57 Author: bpatel Date: 2013-11-14 13:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5ae66d372d57 8025524: javadoc does not correctly locate constructors for nested classes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javadoc/ConstructorDocImpl.java ! test/com/sun/javadoc/testAnchorNames/TestAnchorNames.java + test/com/sun/javadoc/testConstructors/TestConstructors.java + test/com/sun/javadoc/testConstructors/pkg1/Outer.java ! test/tools/javadoc/generics/genericInnerAndOuter/expected.out From xuelei.fan at oracle.com Thu Nov 14 16:09:50 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 15 Nov 2013 00:09:50 +0000 Subject: hg: jdk8/tl/jdk: 8014266: regression test AsyncSSLSocketClose.java time out. Message-ID: <20131115001002.D76A3625FF@hg.openjdk.java.net> Changeset: 40d0ccd00f87 Author: xuelei Date: 2013-11-14 16:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40d0ccd00f87 8014266: regression test AsyncSSLSocketClose.java time out. Reviewed-by: xuelei Contributed-by: Rajan Halade ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/AsyncSSLSocketClose.java From psj.rajarajan at gmail.com Thu Nov 14 11:57:12 2013 From: psj.rajarajan at gmail.com (Rajarajan Pudupatti Sundari Jeyakodi) Date: Thu, 14 Nov 2013 23:57:12 +0400 Subject: SSL handshake issue while java client talking to SSLv3 ONLY server Message-ID: Hi, We are facing a problem and I am sure this is the right place. We have a load balancer (cisco's) and for various reasons the SSL configuration on the load balancer (the server) side is set to use "SSLv3" protocol version. Now after setting the same, when I access the load balancer in CHROME browser, I am able to access the pages but I do see the below message when I click on their security icon. "*connection had to be retried using ssl 3.0*" - I looked at the packet capture using wireshark and I see that browser tries *TLSv1* and receives a "fatal alert" from the server saying "protocol_version" and *then immediately browser tries SSLv3 version* and finishes the handshake. So browser is able to negotiate this as a client. However when I set up a stand alone java (tried using 1.6 as well as 1.7) client from eclipse and try connecting to the server I am getting the below exception. : Received fatal alert: protocol_version javax.net.ssl.SSLException: Received fatal alert: protocol_version As per various documentations, I saw two options I have 1. to set https.protocol system property to SSLv3. [this works for us, but the problem is it is affects the outbound SSL calls globally. I have another outbound SSL call to another server which does not work with SSLv3] 2. setEnabledprotocols() - this works as well but sometimes, we dont have access to the socket directly (sometime we generates stubs using third party and the stub takes care of the low level connection stuff, so no access to that socket). *But my actual question is*, If by default TLSv1/SSLv3 and SSLv2Hello(just the format I believe) are enabled in java, why is JSSE implementation not able to negotiate like how chrome browser is able to negotiate. Is this expected? If browser is doing it, I believe it should be part of some SSL RFC and if that is the case, same functionality of this "negotiation" should be provided by java itself right? I did go through this *http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/sun/security/ssl/SSLSocketImpl.java *and was not able to find any part for this negotiation during handshake. Is there a possibility of issue from the server side (load balancer) that i. I see that server sends fatal alert but that being cisco I believe the ssl implementation should be perfect and that is expected. Am I wrong? Issue happens both in java 1.6 and 1.7. Do let me know if more information would be required to answer, will be happy to help. Thanks Rajarajan PSJ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131114/59bfba51/attachment.html From xuelei.fan at oracle.com Thu Nov 14 23:33:41 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 15 Nov 2013 15:33:41 +0800 Subject: SSL handshake issue while java client talking to SSLv3 ONLY server In-Reply-To: References: Message-ID: <5285CE55.30202@oracle.com> Please google "TLS version tolerance". Wish you luck. Xuelei On 11/15/2013 3:57 AM, Rajarajan Pudupatti Sundari Jeyakodi wrote: > Hi, > > We are facing a problem and I am sure this is the right place. We have a > load balancer (cisco's) and for various reasons the SSL configuration on > the load balancer (the server) side is set to use "SSLv3" protocol > version. Now after setting the same, when I access the load balancer in > CHROME browser, I am able to access the pages but I do see the below > message when I click on their security icon. > > > > "*connection had to be retried using ssl 3.0*" - I looked at the packet > capture using wireshark and I see that browser tries *TLSv1* and > receives a "fatal alert" from the server saying "protocol_version" and > *then immediately browser tries SSLv3 version* and finishes the > handshake. So browser is able to negotiate this as a client. > > > > However when I set up a stand alone java (tried using 1.6 as well as > 1.7) client from eclipse and try connecting to the server I am getting > the below exception. > > > > : Received fatal alert: protocol_versionjavax.net.ssl.SSLException: > Received fatal alert: protocol_version > > > As per various documentations, I saw two options I have > > > 1. to set https.protocol system property to SSLv3. [this works for us, > but the problem is it is affects the outbound SSL calls globally. I have > another outbound SSL call to another server which does not work with SSLv3] > > > > 2. setEnabledprotocols() - this works as well but sometimes, we dont > have access to the socket directly (sometime we generates stubs using > third party and the stub takes care of the low level connection stuff, > so no access to that socket). > > > > *But my actual question is*, If by default TLSv1/SSLv3 and > SSLv2Hello(just the format I believe) are enabled in java, why is JSSE > implementation not able to negotiate like how chrome browser is able to > negotiate. Is this expected? If browser is doing it, I believe it should > be part of some SSL RFC and if that is the case, same functionality of > this "negotiation" should be provided by java itself right? > > > > I did go through this > *http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/sun/security/ssl/SSLSocketImpl.java* > and was not able to find any part for this negotiation during handshake. > > > > Is there a possibility of issue from the server side (load balancer) > that i. I see that server sends fatal alert but that being cisco I > believe the ssl implementation should be perfect and that is expected. > Am I wrong? > > > > Issue happens both in java 1.6 and 1.7. Do let me know if more > information would be required to answer, will be happy to help. > > > Thanks > > Rajarajan PSJ > > > From vicente.romero at oracle.com Fri Nov 15 03:09:04 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Fri, 15 Nov 2013 11:09:04 +0000 Subject: hg: jdk8/tl/langtools: 8026231: Look at 'static' flag when checking method references Message-ID: <20131115110918.2F41062617@hg.openjdk.java.net> Changeset: d4cbb671de1c Author: vromero Date: 2013-11-15 11:08 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d4cbb671de1c 8026231: Look at 'static' flag when checking method references Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/lambda/MethodReference22.java ! test/tools/javac/lambda/MethodReference22.out ! test/tools/javac/lambda/MethodReference51.java ! test/tools/javac/lambda/MethodReference68.out + test/tools/javac/lambda/MethodReference73.java + test/tools/javac/lambda/MethodReference73.out ! test/tools/javac/lambda/TargetType60.java ! test/tools/javac/lambda/TargetType60.out From sergey.lugovoy at oracle.com Thu Nov 14 23:40:06 2013 From: sergey.lugovoy at oracle.com (Sergey Lugovoy) Date: Fri, 15 Nov 2013 11:40:06 +0400 Subject: [security dev] [8] Review request for JDK-8028266 : Tidy warnings cleanup for packages java.security/javax.security In-Reply-To: <5285209D.4070304@oracle.com> References: <2405806.GIg7MIdCZp@workland> <5284E5B4.3090809@oracle.com> <5285209D.4070304@oracle.com> Message-ID: <1550047.PlASO1GmOX@workland> Hi all, Please, see to second patch http://cr.openjdk.java.net/~yan/8028266/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8028266 I removed some extra lines left after

removal, as Sean suggested. As to the fact why I replaced "

" by "
" - that's because "p"
element represents a paragraph and cannot contain another block elements
("
" or "
") ( see more http://www.w3.org/TR/html401/struct/text.html#h-9.3.1) On Thursday, November 14, 2013 11:12:29 AM Joe Darcy wrote: > Might just be my limited knowledge of HTML, but I don't understand the > replacement of

with
in several places like: > > --- > old/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java > 2013-11-14 07:44:04.878682607 +0000 > +++ > new/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java > 2013-11-14 07:44:04.718682612 +0000 > @@ -48,14 +48,14 @@ > *

> * For example, to specify the "host" service use of a forwardable TGT the > * target permission is specified as follows: > - *

> + *
> *

>    *  DelegationPermission("\"host/foo.example.com at EXAMPLE.COM\"
> \"krbtgt/EXAMPLE.COM at EXAMPLE.COM\"");
>    * 
> *

> * To give the "backup" service a proxiable nfs service ticket the > target permission > * might be specified: > - *

> + *
> *

>    *  DelegationPermission("\"backup/bar.example.com at EXAMPLE.COM\"
> \"nfs/home.EXAMPLE.COM at EXAMPLE.COM\"");
>    * 
> > Otherwise, the patch looks fine. > > -Joe > > On 11/14/2013 07:01 AM, Sean Mullan wrote: > > Just one comment. I would prefer if you changed the following pattern: > > > > * > > *

> > * > > > > to: > > > > * > > > > instead of: > > > > * > > * > > > > There is no need for the extra line. > > > > Thanks, > > Sean > > > > On 11/14/2013 03:44 AM, Sergey Lugovoy wrote: > >> Hi all, > >> > >> please review the fix > >> > >> http://cr.openjdk.java.net/~yan/8028266/webrev.00/ > >> > >> for > >> > >> https://bugs.openjdk.java.net/browse/JDK-8028266 > >> > >> This patch cleanup tidy warnings for generated html documentation, and > >> do not > >> > >> affect the appearance of the documentation. > >> > >> Best regards, > >> > >> Serge V. Lugovoy From vincent.x.ryan at oracle.com Fri Nov 15 08:25:45 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 15 Nov 2013 16:25:45 +0000 Subject: [8] RFR 8015571: OCSP validation fails if ocsp.responderCertSubjectName is set Message-ID: <997286A8-ED6F-48EC-99A8-34A7AB1001EF@oracle.com> Please review this fix to OCSP which corrects the validation of OCSP responses when a trusted responder has been configured. Bug: https://bugs.openjdk.java.net/browse/JDK-8015571 Webrev: http://cr.openjdk.java.net/~vinnie/8015571/webrev.00/ The OCSP client can now handle OCSP responses from several trusted responders without re-configuration. In addition, out-of-order or absent signer certs in an OCSP Response are also handled correctly. Thanks. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131115/9a32ae0b/attachment-0001.html From sean.mullan at oracle.com Fri Nov 15 12:39:49 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 15 Nov 2013 15:39:49 -0500 Subject: [8] RFR 8015571: OCSP validation fails if ocsp.responderCertSubjectName is set In-Reply-To: <997286A8-ED6F-48EC-99A8-34A7AB1001EF@oracle.com> References: <997286A8-ED6F-48EC-99A8-34A7AB1001EF@oracle.com> Message-ID: <52868695.6090600@oracle.com> Looks good. --Sean On 11/15/2013 11:25 AM, Vincent Ryan wrote: > Please review this fix to OCSP which corrects the validation of OCSP > responses when a trusted > responder has been configured. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8015571 > Webrev: http://cr.openjdk.java.net/~vinnie/8015571/webrev.00/ > > The OCSP client can now handle OCSP responses from several trusted > responders without > re-configuration. In addition, out-of-order or absent signer certs in an > OCSP Response are also > handled correctly. > > Thanks. From bernd-2013 at eckenfels.net Fri Nov 15 15:40:39 2013 From: bernd-2013 at eckenfels.net (Bernd Eckenfels) Date: Sat, 16 Nov 2013 00:40:39 +0100 Subject: SHA-1 correctness and speed Message-ID: Hello, you might have seen it, on the pgp-devel mailing list there was a thread about a counter overflow in some message digest implementations of libcrypt (affecting GnuPG MIC+Sign). With hashed data > 256GB there are wrong hashes calculated. http://lists.gnupg.org/pipermail/gnupg-devel/2013-November/028041.html This motivated me to test Java implementation for the mentioned 257GB test vectors. SunJCE and BC are not affected. I want to share with you the code and results anyway. https://github.com/ecki/JavaCryptoTest/blob/master/src/main/java/net/eckenfels/test/jce/HashOverflowTest.java NB: BC implementation is slower than JCE implementation: This is testing mit 257*1024 times a 1MB nul buffer: == HashOverflowTest on Java HotSpot(TM) 64-Bit Server VM 1.7.0_09-b05/23.5-b02 (Oracle Corporation) @ Windows 7 6.1 amd64 Service Pack 1 == Testing algorithm SUN: MessageDigest.SHA -> sun.security.provider.SHA aliases: [SHA-1, SHA1] attributes: {ImplementedIn=Software} Digest:SHA-1 Message Digest from SUN 275951648768bytes x nul hash=6938f23e29e7d3dcd100d0ed2df9d6593113718f in 1310,562s Testing algorithm BC: MessageDigest.SHA-1 -> org.bouncycastle.jce.provider.JDKMessageDigest$SHA1 aliases: [SHA1, SHA, 1.3.14.3.2.26] Digest:SHA-1 Message Digest from BC 275951648768bytes x nul hash=6938f23e29e7d3dcd100d0ed2df9d6593113718f in 1529,284s That is Sun 200MiB/s vs BC 172 Mib/s vs. openssl* 308MiB/s (i7-2600 @3,40GHz ) On a slower system: Testing algorithm SUN: MessageDigest.SHA -> sun.security.provider.SHA aliases: [SHA-1, SHA1] attributes: {ImplementedIn=Software} Digest:SHA-1 Message Digest from SUN 275951648768bytes x nul hash=6938f23e29e7d3dcd100d0ed2df9d6593113718f in 7499,101s Testing algorithm BC: MessageDigest.SHA-1 -> org.bouncycastle.jce.provider.JDKMessageDigest$SHA1 aliases: [SHA1, SHA, 1.3.14.3.2.26] Digest:SHA-1 Message Digest from BC 275951648768bytes x nul hash=6938f23e29e7d3dcd100d0ed2df9d6593113718f in 9275,935s That is 35MiB/s vs. 28MiB/s vs. openssl 57MiB/s Bernd * cygwin dd if=/dev/zero bs=1M count=$[257*1024] | openssl SHA1 From staffan.larsen at oracle.com Mon Nov 18 01:23:38 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Mon, 18 Nov 2013 09:23:38 +0000 Subject: hg: jdk8/tl/jdk: 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently Message-ID: <20131118092351.C8CA76265B@hg.openjdk.java.net> Changeset: 64a492bc0ba7 Author: sla Date: 2013-11-14 12:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64a492bc0ba7 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently Summary: Port tests for java/lang/instrument/PremainClass from script to java Reviewed-by: sla Contributed-by: mattias.tobiasson at oracle.com - test/java/lang/instrument/PremainClass/NoPremainAgent.sh + test/java/lang/instrument/PremainClass/NoPremainAgentTest.java + test/java/lang/instrument/PremainClass/PremainClassTest.java - test/java/lang/instrument/PremainClass/PremainClassTest.sh - test/java/lang/instrument/PremainClass/ZeroArgPremainAgent.sh + test/java/lang/instrument/PremainClass/ZeroArgPremainAgentTest.java ! test/lib/testlibrary/jdk/testlibrary/Utils.java From alexander.zuev at oracle.com Mon Nov 18 08:23:09 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Mon, 18 Nov 2013 16:23:09 +0000 Subject: hg: jdk8/tl/jdk: 8028197: tools/launcher/DiacriticTest.java failed on MacOSX: Input length = 1 Message-ID: <20131118162324.0DF626266A@hg.openjdk.java.net> Changeset: c2b56fe61626 Author: kizune Date: 2013-11-18 20:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2b56fe61626 8028197: tools/launcher/DiacriticTest.java failed on MacOSX: Input length = 1 Reviewed-by: ksrini ! test/tools/launcher/DiacriticTest.java From jaroslav.bachorik at oracle.com Mon Nov 18 06:27:18 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Mon, 18 Nov 2013 14:27:18 +0000 Subject: hg: jdk8/tl/jdk: 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support Message-ID: <20131118142734.7C3B362664@hg.openjdk.java.net> Changeset: d842131d12d8 Author: jbachorik Date: 2013-11-18 15:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d842131d12d8 8027163: sun/management/jmxremote/bootstrap/CustomLauncherTest.java should be updated for jdk8 removal of solaris-32bit support Reviewed-by: sla ! test/lib/testlibrary/jdk/testlibrary/ProcessTools.java ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java ! test/sun/management/jmxremote/bootstrap/LocalManagementTest.java + test/sun/management/jmxremote/bootstrap/solaris-amd64/launcher - test/sun/management/jmxremote/bootstrap/solaris-i586/launcher - test/sun/management/jmxremote/bootstrap/solaris-sparc/launcher + test/sun/management/jmxremote/bootstrap/solaris-sparcv9/launcher From jaroslav.bachorik at oracle.com Mon Nov 18 07:22:31 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Mon, 18 Nov 2013 15:22:31 +0000 Subject: hg: jdk8/tl/jdk: 8028433: [TESTBUG] add -XX:+UsePerfData to some sun.management tests Message-ID: <20131118152246.47D0762666@hg.openjdk.java.net> Changeset: 0298ebbaf3b8 Author: jbachorik Date: 2013-11-18 16:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0298ebbaf3b8 8028433: [TESTBUG] add -XX:+UsePerfData to some sun.management tests Reviewed-by: sla, egahlin ! test/sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java ! test/sun/management/HotspotClassLoadingMBean/GetInitializedClassCount.java ! test/sun/management/HotspotClassLoadingMBean/GetLoadedClassSize.java ! test/sun/management/HotspotClassLoadingMBean/GetMethodDataSize.java ! test/sun/management/HotspotClassLoadingMBean/GetUnloadedClassSize.java ! test/sun/management/HotspotRuntimeMBean/GetSafepointCount.java From magnus.ihse.bursie at oracle.com Mon Nov 18 09:53:58 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:53:58 +0000 Subject: hg: jdk8/tl: 8027566: Remove the old build system Message-ID: <20131118175359.385806266D@hg.openjdk.java.net> Changeset: a667caba1e84 Author: ihse Date: 2013-11-14 10:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a667caba1e84 8027566: Remove the old build system Reviewed-by: erikj, tbell ! Makefile - NewMakefile.gmk ! common/autoconf/Makefile.in ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/source-dirs.m4 ! common/autoconf/spec.gmk.in ! common/bin/compare.sh - common/makefiles/HotspotWrapper.gmk - common/makefiles/IdlCompilation.gmk - common/makefiles/JavaCompilation.gmk - common/makefiles/Jprt.gmk - common/makefiles/Main.gmk - common/makefiles/MakeBase.gmk - common/makefiles/MakeHelpers.gmk - common/makefiles/Makefile - common/makefiles/NativeCompilation.gmk - common/makefiles/RMICompilation.gmk - common/makefiles/devkit/Makefile - common/makefiles/devkit/Tools.gmk - common/makefiles/javadoc/CORE_PKGS.gmk - common/makefiles/javadoc/Javadoc.gmk - common/makefiles/javadoc/NON_CORE_PKGS.gmk - common/makefiles/javadoc/Notes.html - common/makefiles/support/ListPathsSafely-post-compress.incl - common/makefiles/support/ListPathsSafely-pre-compress.incl - common/makefiles/support/ListPathsSafely-uncompress.sed - common/makefiles/support/unicode2x.sed ! common/nb_native/nbproject/configurations.xml - make/Defs-internal.gmk + make/HotspotWrapper.gmk + make/Javadoc.gmk + make/Jprt.gmk + make/Main.gmk + make/MakeHelpers.gmk - make/README.pre-components + make/common/CORE_PKGS.gmk + make/common/IdlCompilation.gmk + make/common/JavaCompilation.gmk + make/common/MakeBase.gmk + make/common/NON_CORE_PKGS.gmk + make/common/NativeCompilation.gmk + make/common/RMICompilation.gmk + make/common/support/ListPathsSafely-post-compress.incl + make/common/support/ListPathsSafely-pre-compress.incl + make/common/support/ListPathsSafely-uncompress.sed + make/common/support/unicode2x.sed - make/corba-rules.gmk - make/deploy-rules.gmk + make/devkit/Makefile + make/devkit/Tools.gmk - make/hotspot-rules.gmk - make/install-rules.gmk - make/jaxp-rules.gmk - make/jaxws-rules.gmk - make/jdk-rules.gmk - make/jprt.gmk - make/langtools-rules.gmk - make/nashorn-rules.gmk - make/sanity-rules.gmk - make/scripts/fixpath.pl - make/scripts/vsvars.sh - make/sponsors-rules.gmk From magnus.ihse.bursie at oracle.com Mon Nov 18 09:54:40 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:54:40 +0000 Subject: hg: jdk8/tl/jaxp: 8027566: Remove the old build system Message-ID: <20131118175447.806826266F@hg.openjdk.java.net> Changeset: 80acb8151797 Author: ihse Date: 2013-11-04 11:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/80acb8151797 8027566: Remove the old build system Reviewed-by: erikj, tbell + make/BuildJaxp.gmk ! make/Makefile - make/jprt.properties - make/scripts/update_src.sh - makefiles/BuildJaxp.gmk - makefiles/Makefile From magnus.ihse.bursie at oracle.com Mon Nov 18 09:54:07 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:54:07 +0000 Subject: hg: jdk8/tl/corba: 8027566: Remove the old build system Message-ID: <20131118175409.7B3D76266E@hg.openjdk.java.net> Changeset: 9729f9862eb4 Author: ihse Date: 2013-11-04 11:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/9729f9862eb4 8027566: Remove the old build system Reviewed-by: erikj, tbell + make/BuildCorba.gmk ! make/Makefile - make/com/Makefile - make/com/sun/Makefile - make/com/sun/corba/Makefile - make/com/sun/corba/minclude/com_sun_corba_se_PortableActivationIDL.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_activation.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_corba.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_core.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_dynamicany.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_encoding.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_interceptors.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_io.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_ior.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_legacy.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_logging.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_monitoring.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_naming_cosnaming.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_naming_namingutil.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_naming_pcosnaming.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_oa_poa.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_oa_toa.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_orb.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_orbutil.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_presentation_rmi.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_protocol.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_resolver.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_transport.jmk - make/com/sun/corba/minclude/com_sun_corba_se_impl_util.jmk - make/com/sun/corba/minclude/com_sun_corba_se_internal_LegacyFiles.jmk - make/com/sun/corba/minclude/com_sun_corba_se_pept.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_activation.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_copyobject.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_encoding.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_extension.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_ior.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_legacy_connection.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_legacy_interceptor.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_logging.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_monitoring.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_oa.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_orb.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_orbutil.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_presentation_rmi.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_protocol.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_resolver.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_servicecontext.jmk - make/com/sun/corba/minclude/com_sun_corba_se_spi_transport.jmk - make/com/sun/corba/minclude/com_sun_tools_corba_se_idl_toJavaPortable.jmk - make/com/sun/corba/minclude/javax_activity.jmk - make/com/sun/corba/minclude/javax_rmi.jmk - make/com/sun/corba/minclude/javax_rmi_CORBA.jmk - make/com/sun/corba/minclude/javax_transaction.jmk - make/com/sun/corba/minclude/org_omg_CORBA.jmk - make/com/sun/corba/minclude/org_omg_CORBAX.jmk - make/com/sun/corba/minclude/org_omg_CORBA_2_3.jmk - make/com/sun/corba/minclude/org_omg_CosNaming.jmk - make/com/sun/corba/minclude/org_omg_DynamicAny.jmk - make/com/sun/corba/minclude/org_omg_IOP.jmk - make/com/sun/corba/minclude/org_omg_Messaging.jmk - make/com/sun/corba/minclude/org_omg_PortableInterceptor.jmk - make/com/sun/corba/minclude/org_omg_PortableServer.jmk - make/com/sun/corba/minclude/org_omg_SendingContext.jmk - make/com/sun/corba/minclude/sun_corba.jmk - make/com/sun/corba/se/Makefile - make/com/sun/corba/se/PortableActivationIDL/Makefile - make/com/sun/corba/se/connection/FILES_java.gmk - make/com/sun/corba/se/connection/Makefile - make/com/sun/corba/se/core/Makefile - make/com/sun/corba/se/corespi/Makefile - make/com/sun/corba/se/impl/Makefile - make/com/sun/corba/se/impl/activation/Makefile - make/com/sun/corba/se/impl/activation/orbd/Makefile - make/com/sun/corba/se/impl/activation/servertool/Makefile - make/com/sun/corba/se/impl/interceptors/Makefile - make/com/sun/corba/se/impl/logging/Makefile - make/com/sun/corba/se/impl/monitoring/Makefile - make/com/sun/corba/se/impl/naming/Makefile - make/com/sun/corba/se/impl/naming/cosnaming/Makefile - make/com/sun/corba/se/impl/naming/namingutil/Makefile - make/com/sun/corba/se/impl/naming/pcosnaming/Makefile - make/com/sun/corba/se/impl/oa/Makefile - make/com/sun/corba/se/impl/oa/poa/Makefile - make/com/sun/corba/se/impl/oa/toa/Makefile - make/com/sun/corba/se/interceptor/FILES_java.gmk - make/com/sun/corba/se/interceptor/Makefile - make/com/sun/corba/se/pept/Makefile - make/com/sun/corba/se/rmi/Makefile - make/com/sun/corba/se/rmi/rmic/Makefile - make/com/sun/corba/se/rmi/rmic/SUN_RMI_RMIC_IIOP_java.gmk - make/com/sun/corba/se/sources/Makefile - make/com/sun/corba/se/spi/Makefile - make/com/sun/corba/se/spi/activation/Makefile - make/com/sun/corba/se/spi/copyobject/Makefile - make/com/sun/corba/se/spi/encoding/Makefile - make/com/sun/corba/se/spi/extension/Makefile - make/com/sun/corba/se/spi/legacy/Makefile - make/com/sun/corba/se/spi/legacy/connection/Makefile - make/com/sun/corba/se/spi/legacy/interceptor/Makefile - make/com/sun/corba/se/spi/logging/Makefile - make/com/sun/corba/se/spi/monitoring/Makefile - make/common/BuildToolJar.gmk - make/common/CancelImplicits.gmk - make/common/Classes.gmk - make/common/Defs-bsd.gmk - make/common/Defs-linux.gmk - make/common/Defs-solaris.gmk - make/common/Defs-windows.gmk - make/common/Defs.gmk - make/common/Rules.gmk - make/common/internal/Resources.gmk - make/common/shared/Defs-bsd.gmk - make/common/shared/Defs-java.gmk - make/common/shared/Defs-linux.gmk - make/common/shared/Defs-solaris.gmk - make/common/shared/Defs-utils.gmk - make/common/shared/Defs-windows.gmk - make/common/shared/Defs.gmk - make/common/shared/Platform.gmk - make/javax/Makefile - make/javax/xa/Makefile - make/jprt.properties - make/org/Makefile - make/org/omg/CORBA/Makefile - make/org/omg/CORBAX_java.gmk - make/org/omg/CosNaming/Makefile - make/org/omg/DynamicAny/Makefile - make/org/omg/Makefile - make/org/omg/PortableInterceptor/Makefile - make/org/omg/PortableServer/Makefile - make/org/omg/idl/FILES_java.gmk - make/org/omg/idl/Makefile - make/org/omg/sources/Makefile - make/sun/Makefile - make/sun/corba/Makefile - make/sun/corba/core/Makefile - make/sun/corba/org/Makefile - make/sun/corba/org/omg/FILES_java.gmk - make/sun/corba/org/omg/Makefile - make/sun/rmi/Makefile - make/sun/rmi/corbalogcompile/Makefile - make/sun/rmi/corbalogsources/Makefile - make/sun/rmi/rmic/FILES.gmk - make/sun/rmi/rmic/Makefile - make/tools/Makefile - make/tools/idlj/Makefile - make/tools/logutil/Makefile - make/tools/strip_properties/Makefile - makefiles/BuildCorba.gmk - makefiles/Makefile From magnus.ihse.bursie at oracle.com Mon Nov 18 09:55:06 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:55:06 +0000 Subject: hg: jdk8/tl/jdk: 8027566: Remove the old build system Message-ID: <20131118175522.0FECE62671@hg.openjdk.java.net> Changeset: 4be14673b9bf Author: ihse Date: 2013-11-14 11:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4be14673b9bf 8027566: Remove the old build system Reviewed-by: erikj, tbell + make/BuildJdk.gmk + make/Bundles.gmk + make/CompileDemos.gmk + make/CompileJavaClasses.gmk + make/CompileLaunchers.gmk + make/CompileNativeLibraries.gmk + make/CopyFiles.gmk + make/CopyIntoClasses.gmk + make/CopySamples.gmk + make/CreateJars.gmk + make/CreateSecurityJars.gmk + make/GenerateClasses.gmk + make/GenerateData.gmk + make/GenerateSources.gmk + make/Images.gmk + make/Import.gmk ! make/Makefile - make/PatchList.solaris + make/ProfileNames.gmk + make/Profiles.gmk + make/Setup.gmk + make/SignJars.gmk + make/Tools.gmk - make/altclasses/Makefile - make/apple/Makefile - make/apple/applescript/Makefile - make/bridge/AccessBridgeJava/Makefile - make/bridge/JAWTAccessBridge/Files_cpp.gmk - make/bridge/JAWTAccessBridge/Makefile - make/bridge/Jabswitch/Makefile - make/bridge/Jaccess/Makefile - make/bridge/JavaAccessBridge/Files_cpp.gmk - make/bridge/JavaAccessBridge/Makefile - make/bridge/Makefile - make/bridge/WindowsAccessBridge/Files_cpp.gmk - make/bridge/WindowsAccessBridge/Makefile - make/com/Makefile - make/com/apple/Makefile - make/com/apple/osx/Makefile - make/com/apple/osxui/Makefile - make/com/oracle/Makefile - make/com/oracle/jfr/Makefile - make/com/oracle/net/Makefile - make/com/oracle/nio/Makefile - make/com/oracle/security/ucrypto/FILES_c.gmk - make/com/oracle/security/ucrypto/Makefile - make/com/oracle/security/ucrypto/mapfile-vers - make/com/oracle/util/Makefile - make/com/sun/Makefile - make/com/sun/crypto/provider/Makefile - make/com/sun/demo/Makefile - make/com/sun/demo/jvmti/Makefile - make/com/sun/demo/jvmti/hprof/Makefile - make/com/sun/image/Makefile - make/com/sun/jarsigner/Makefile - make/com/sun/java/Makefile - make/com/sun/java/browser/Makefile - make/com/sun/java/browser/dom/Makefile - make/com/sun/java/browser/net/Makefile - make/com/sun/java/pack/FILES_cpp.gmk - make/com/sun/java/pack/Makefile - make/com/sun/java/pack/mapfile-vers - make/com/sun/java/pack/mapfile-vers-unpack200 - make/com/sun/java/pack/prop/Makefile - make/com/sun/jmx/Makefile - make/com/sun/jmx/snmp/Makefile - make/com/sun/jndi/Makefile - make/com/sun/jndi/cosnaming/Makefile - make/com/sun/jndi/dns/Makefile - make/com/sun/jndi/ldap/Makefile - make/com/sun/jndi/rmi/Makefile - make/com/sun/jndi/rmi/registry/Makefile - make/com/sun/jndi/toolkit/Makefile - make/com/sun/net/httpserver/Makefile - make/com/sun/net/ssl/Makefile - make/com/sun/nio/Makefile - make/com/sun/nio/sctp/Exportedfiles.gmk - make/com/sun/nio/sctp/FILES_c.gmk - make/com/sun/nio/sctp/FILES_java.gmk - make/com/sun/nio/sctp/Makefile - make/com/sun/nio/sctp/mapfile-vers - make/com/sun/org/Makefile - make/com/sun/org/apache/Makefile - make/com/sun/org/apache/xml/Makefile - make/com/sun/rowset/Makefile - make/com/sun/security/Makefile - make/com/sun/security/auth/FILES_java.gmk - make/com/sun/security/auth/Makefile - make/com/sun/security/auth/module/FILES_c_solaris.gmk - make/com/sun/security/auth/module/FILES_c_unix.gmk - make/com/sun/security/auth/module/FILES_c_windows.gmk - make/com/sun/security/auth/module/FILES_export_solaris.gmk - make/com/sun/security/auth/module/FILES_export_unix.gmk - make/com/sun/security/auth/module/FILES_export_windows.gmk - make/com/sun/security/auth/module/FILES_java.gmk - make/com/sun/security/auth/module/Makefile - make/com/sun/security/auth/module/mapfile-vers - make/com/sun/security/jgss/Makefile - make/com/sun/security/ntlm/Makefile - make/com/sun/security/sasl/Makefile - make/com/sun/sql/FILES_java.gmk - make/com/sun/sql/Makefile - make/com/sun/tools/Makefile - make/com/sun/tools/attach/Exportedfiles.gmk - make/com/sun/tools/attach/FILES_c.gmk - make/com/sun/tools/attach/FILES_java.gmk - make/com/sun/tools/attach/Makefile - make/com/sun/tools/attach/mapfile-bsd - make/com/sun/tools/attach/mapfile-linux - make/com/sun/tools/attach/mapfile-solaris - make/com/sun/tracing/Makefile - make/com/sun/tracing/dtrace/Makefile - make/common/BuildToolJar.gmk - make/common/CancelImplicits.gmk - make/common/Classes.gmk - make/common/Cscope.gmk - make/common/Defs-linux.gmk - make/common/Defs-macosx.gmk - make/common/Defs-solaris.gmk - make/common/Defs-windows.gmk - make/common/Defs.gmk - make/common/Demo.gmk - make/common/Library.gmk - make/common/Mapfile-vers.gmk - make/common/Program.gmk - make/common/Release-macosx.gmk - make/common/Release.gmk - make/common/Rules.gmk - make/common/Sanity.gmk - make/common/Subdirs.gmk - make/common/internal/Defs-corba.gmk - make/common/internal/Defs-jaxp.gmk - make/common/internal/Defs-jaxws.gmk - make/common/internal/Defs-langtools.gmk - make/common/internal/ImportComponents.gmk - make/common/internal/NativeCompileRules.gmk - make/common/internal/Resources.gmk - make/common/shared/Compiler-gcc.gmk - make/common/shared/Compiler-llvm.gmk - make/common/shared/Compiler-msvc.gmk - make/common/shared/Compiler-sun.gmk - make/common/shared/Defs-control.gmk - make/common/shared/Defs-java.gmk - make/common/shared/Defs-javadoc.gmk - make/common/shared/Defs-linux.gmk - make/common/shared/Defs-macosx.gmk - make/common/shared/Defs-solaris.gmk - make/common/shared/Defs-utils.gmk - make/common/shared/Defs-versions.gmk - make/common/shared/Defs-windows.gmk - make/common/shared/Defs.gmk - make/common/shared/Platform.gmk - make/common/shared/PrivateDefs.gmk-example - make/common/shared/Sanity-Settings.gmk - make/common/shared/Sanity.gmk + make/data/characterdata/CharacterData00.java.template + make/data/characterdata/CharacterData01.java.template + make/data/characterdata/CharacterData02.java.template + make/data/characterdata/CharacterData0E.java.template + make/data/characterdata/CharacterDataLatin1.java.template + make/data/characterdata/CharacterDataPrivateUse.java.template + make/data/characterdata/CharacterDataUndefined.java.template + make/data/charsetmapping/Big5.map + make/data/charsetmapping/Big5.nr + make/data/charsetmapping/DoubleByte-X.java.template + make/data/charsetmapping/EUC_CN.map + make/data/charsetmapping/EUC_KR.map + make/data/charsetmapping/GBK.map + make/data/charsetmapping/HKSCS2001.c2b + make/data/charsetmapping/HKSCS2001.map + make/data/charsetmapping/HKSCS2008.c2b + make/data/charsetmapping/HKSCS2008.map + make/data/charsetmapping/HKSCS_XP.c2b + make/data/charsetmapping/HKSCS_XP.map + make/data/charsetmapping/IBM037.c2b + make/data/charsetmapping/IBM037.map + make/data/charsetmapping/IBM037.nr + make/data/charsetmapping/IBM1006.map + make/data/charsetmapping/IBM1025.c2b + make/data/charsetmapping/IBM1025.map + make/data/charsetmapping/IBM1025.nr + make/data/charsetmapping/IBM1026.c2b + make/data/charsetmapping/IBM1026.map + make/data/charsetmapping/IBM1026.nr + make/data/charsetmapping/IBM1046.map + make/data/charsetmapping/IBM1047.map + make/data/charsetmapping/IBM1097.map + make/data/charsetmapping/IBM1098.map + make/data/charsetmapping/IBM1112.c2b + make/data/charsetmapping/IBM1112.map + make/data/charsetmapping/IBM1112.nr + make/data/charsetmapping/IBM1122.c2b + make/data/charsetmapping/IBM1122.map + make/data/charsetmapping/IBM1122.nr + make/data/charsetmapping/IBM1123.c2b + make/data/charsetmapping/IBM1123.map + make/data/charsetmapping/IBM1123.nr + make/data/charsetmapping/IBM1124.map + make/data/charsetmapping/IBM1140.c2b + make/data/charsetmapping/IBM1140.map + make/data/charsetmapping/IBM1141.c2b + make/data/charsetmapping/IBM1141.map + make/data/charsetmapping/IBM1142.c2b + make/data/charsetmapping/IBM1142.map + make/data/charsetmapping/IBM1143.c2b + make/data/charsetmapping/IBM1143.map + make/data/charsetmapping/IBM1144.c2b + make/data/charsetmapping/IBM1144.map + make/data/charsetmapping/IBM1145.c2b + make/data/charsetmapping/IBM1145.map + make/data/charsetmapping/IBM1146.c2b + make/data/charsetmapping/IBM1146.map + make/data/charsetmapping/IBM1147.c2b + make/data/charsetmapping/IBM1147.map + make/data/charsetmapping/IBM1148.c2b + make/data/charsetmapping/IBM1148.map + make/data/charsetmapping/IBM1149.c2b + make/data/charsetmapping/IBM1149.map + make/data/charsetmapping/IBM1364.c2b + make/data/charsetmapping/IBM1364.map + make/data/charsetmapping/IBM1381.c2b + make/data/charsetmapping/IBM1381.map + make/data/charsetmapping/IBM1383.c2b + make/data/charsetmapping/IBM1383.map + make/data/charsetmapping/IBM1383.nr + make/data/charsetmapping/IBM273.c2b + make/data/charsetmapping/IBM273.map + make/data/charsetmapping/IBM273.nr + make/data/charsetmapping/IBM277.c2b + make/data/charsetmapping/IBM277.map + make/data/charsetmapping/IBM277.nr + make/data/charsetmapping/IBM278.c2b + make/data/charsetmapping/IBM278.map + make/data/charsetmapping/IBM278.nr + make/data/charsetmapping/IBM280.c2b + make/data/charsetmapping/IBM280.map + make/data/charsetmapping/IBM280.nr + make/data/charsetmapping/IBM284.c2b + make/data/charsetmapping/IBM284.map + make/data/charsetmapping/IBM284.nr + make/data/charsetmapping/IBM285.c2b + make/data/charsetmapping/IBM285.map + make/data/charsetmapping/IBM285.nr + make/data/charsetmapping/IBM290.c2b + make/data/charsetmapping/IBM290.map + make/data/charsetmapping/IBM297.c2b + make/data/charsetmapping/IBM297.map + make/data/charsetmapping/IBM297.nr + make/data/charsetmapping/IBM300.c2b + make/data/charsetmapping/IBM300.map + make/data/charsetmapping/IBM420.c2b + make/data/charsetmapping/IBM420.map + make/data/charsetmapping/IBM420.nr + make/data/charsetmapping/IBM424.c2b + make/data/charsetmapping/IBM424.map + make/data/charsetmapping/IBM424.nr + make/data/charsetmapping/IBM437.map + make/data/charsetmapping/IBM500.c2b + make/data/charsetmapping/IBM500.map + make/data/charsetmapping/IBM500.nr + make/data/charsetmapping/IBM737.map + make/data/charsetmapping/IBM775.map + make/data/charsetmapping/IBM833.c2b + make/data/charsetmapping/IBM833.map + make/data/charsetmapping/IBM838.c2b + make/data/charsetmapping/IBM838.map + make/data/charsetmapping/IBM838.nr + make/data/charsetmapping/IBM850.map + make/data/charsetmapping/IBM852.map + make/data/charsetmapping/IBM855.map + make/data/charsetmapping/IBM856.map + make/data/charsetmapping/IBM857.map + make/data/charsetmapping/IBM858.map + make/data/charsetmapping/IBM860.map + make/data/charsetmapping/IBM861.map + make/data/charsetmapping/IBM862.map + make/data/charsetmapping/IBM863.map + make/data/charsetmapping/IBM864.map + make/data/charsetmapping/IBM865.map + make/data/charsetmapping/IBM866.map + make/data/charsetmapping/IBM868.map + make/data/charsetmapping/IBM869.map + make/data/charsetmapping/IBM870.c2b + make/data/charsetmapping/IBM870.map + make/data/charsetmapping/IBM870.nr + make/data/charsetmapping/IBM871.c2b + make/data/charsetmapping/IBM871.map + make/data/charsetmapping/IBM871.nr + make/data/charsetmapping/IBM874.map + make/data/charsetmapping/IBM874.nr + make/data/charsetmapping/IBM875.c2b + make/data/charsetmapping/IBM875.map + make/data/charsetmapping/IBM875.nr + make/data/charsetmapping/IBM918.c2b + make/data/charsetmapping/IBM918.map + make/data/charsetmapping/IBM918.nr + make/data/charsetmapping/IBM921.map + make/data/charsetmapping/IBM922.map + make/data/charsetmapping/IBM930.c2b + make/data/charsetmapping/IBM930.map + make/data/charsetmapping/IBM930.nr + make/data/charsetmapping/IBM933.c2b + make/data/charsetmapping/IBM933.map + make/data/charsetmapping/IBM935.c2b + make/data/charsetmapping/IBM935.map + make/data/charsetmapping/IBM935.nr + make/data/charsetmapping/IBM937.c2b + make/data/charsetmapping/IBM937.map + make/data/charsetmapping/IBM937.nr + make/data/charsetmapping/IBM939.c2b + make/data/charsetmapping/IBM939.map + make/data/charsetmapping/IBM939.nr + make/data/charsetmapping/IBM942.c2b + make/data/charsetmapping/IBM942.map + make/data/charsetmapping/IBM943.map + make/data/charsetmapping/IBM943.nr + make/data/charsetmapping/IBM948.c2b + make/data/charsetmapping/IBM948.map + make/data/charsetmapping/IBM949.map + make/data/charsetmapping/IBM950.c2b + make/data/charsetmapping/IBM950.map + make/data/charsetmapping/IBM970.c2b + make/data/charsetmapping/IBM970.map + make/data/charsetmapping/ISO_8859_11.map + make/data/charsetmapping/ISO_8859_13.map + make/data/charsetmapping/ISO_8859_15.map + make/data/charsetmapping/ISO_8859_2.map + make/data/charsetmapping/ISO_8859_3.map + make/data/charsetmapping/ISO_8859_4.map + make/data/charsetmapping/ISO_8859_5.map + make/data/charsetmapping/ISO_8859_6.map + make/data/charsetmapping/ISO_8859_7.map + make/data/charsetmapping/ISO_8859_8.map + make/data/charsetmapping/ISO_8859_9.map + make/data/charsetmapping/JIS_X_0201.c2b + make/data/charsetmapping/JIS_X_0201.map + make/data/charsetmapping/JIS_X_0208.map + make/data/charsetmapping/JIS_X_0208_MS5022X.c2b + make/data/charsetmapping/JIS_X_0208_MS5022X.map + make/data/charsetmapping/JIS_X_0208_MS932.map + make/data/charsetmapping/JIS_X_0208_MS932.nr + make/data/charsetmapping/JIS_X_0208_Solaris.map + make/data/charsetmapping/JIS_X_0208_Solaris.nr + make/data/charsetmapping/JIS_X_0212.map + make/data/charsetmapping/JIS_X_0212_MS5022X.map + make/data/charsetmapping/JIS_X_0212_Solaris.map + make/data/charsetmapping/JIS_X_0212_Solaris.nr + make/data/charsetmapping/Johab.map + make/data/charsetmapping/KOI8_R.map + make/data/charsetmapping/KOI8_U.map + make/data/charsetmapping/MS1250.map + make/data/charsetmapping/MS1251.map + make/data/charsetmapping/MS1252.map + make/data/charsetmapping/MS1253.map + make/data/charsetmapping/MS1254.map + make/data/charsetmapping/MS1255.map + make/data/charsetmapping/MS1256.map + make/data/charsetmapping/MS1257.map + make/data/charsetmapping/MS1258.map + make/data/charsetmapping/MS874.map + make/data/charsetmapping/MS932.c2b + make/data/charsetmapping/MS932.map + make/data/charsetmapping/MS932.nr + make/data/charsetmapping/MS936.map + make/data/charsetmapping/MS949.map + make/data/charsetmapping/MS950.map + make/data/charsetmapping/MS950.nr + make/data/charsetmapping/MacArabic.map + make/data/charsetmapping/MacCentralEurope.map + make/data/charsetmapping/MacCroatian.map + make/data/charsetmapping/MacCyrillic.map + make/data/charsetmapping/MacDingbat.map + make/data/charsetmapping/MacGreek.map + make/data/charsetmapping/MacHebrew.map + make/data/charsetmapping/MacIceland.map + make/data/charsetmapping/MacRoman.map + make/data/charsetmapping/MacRomania.map + make/data/charsetmapping/MacSymbol.map + make/data/charsetmapping/MacThai.map + make/data/charsetmapping/MacTurkish.map + make/data/charsetmapping/MacUkraine.map + make/data/charsetmapping/PCK.c2b + make/data/charsetmapping/PCK.map + make/data/charsetmapping/PCK.nr + make/data/charsetmapping/SJIS.c2b + make/data/charsetmapping/SJIS.map + make/data/charsetmapping/SingleByte-X.java.template + make/data/charsetmapping/TIS_620.map + make/data/charsetmapping/dbcs + make/data/charsetmapping/euc_tw.map + make/data/charsetmapping/extsbcs + make/data/charsetmapping/sbcs + make/data/charsetmapping/sjis0213.map + make/data/checkdeps/refs.allowed + make/data/classlist/classlist.linux + make/data/classlist/classlist.macosx + make/data/classlist/classlist.solaris + make/data/classlist/classlist.windows + make/data/cryptopolicy/limited/LIMITED + make/data/cryptopolicy/limited/default_local.policy + make/data/cryptopolicy/limited/exempt_local.policy + make/data/cryptopolicy/unlimited/UNLIMITED + make/data/cryptopolicy/unlimited/default_US_export.policy + make/data/cryptopolicy/unlimited/default_local.policy + make/data/dtdbuilder/HTMLlat1.sgml + make/data/dtdbuilder/HTMLspecial.sgml + make/data/dtdbuilder/HTMLsymbol.sgml + make/data/dtdbuilder/html32.dtd + make/data/dtdbuilder/public.map + make/data/jdwp/jdwp.spec + make/data/mainmanifest/manifest.mf + make/data/swingbeaninfo/SwingBeanInfo.template + make/data/swingbeaninfo/images/AbstractButtonColor16.gif + make/data/swingbeaninfo/images/BorderColor16.gif + make/data/swingbeaninfo/images/BoxColor16.gif + make/data/swingbeaninfo/images/BoxColor32.gif + make/data/swingbeaninfo/images/BoxMono16.gif + make/data/swingbeaninfo/images/BoxMono32.gif + make/data/swingbeaninfo/images/JAppletColor16.gif + make/data/swingbeaninfo/images/JAppletColor32.gif + make/data/swingbeaninfo/images/JAppletMono16.gif + make/data/swingbeaninfo/images/JAppletMono32.gif + make/data/swingbeaninfo/images/JButtonColor16.gif + make/data/swingbeaninfo/images/JButtonColor32.gif + make/data/swingbeaninfo/images/JButtonMono16.gif + make/data/swingbeaninfo/images/JButtonMono32.gif + make/data/swingbeaninfo/images/JCheckBoxColor16.gif + make/data/swingbeaninfo/images/JCheckBoxColor32.gif + make/data/swingbeaninfo/images/JCheckBoxMenuItemColor16.gif + make/data/swingbeaninfo/images/JCheckBoxMenuItemColor32.gif + make/data/swingbeaninfo/images/JCheckBoxMenuItemMono16.gif + make/data/swingbeaninfo/images/JCheckBoxMenuItemMono32.gif + make/data/swingbeaninfo/images/JCheckBoxMono16.gif + make/data/swingbeaninfo/images/JCheckBoxMono32.gif + make/data/swingbeaninfo/images/JColorChooserColor16.gif + make/data/swingbeaninfo/images/JColorChooserColor32.gif + make/data/swingbeaninfo/images/JColorChooserMono16.gif + make/data/swingbeaninfo/images/JColorChooserMono32.gif + make/data/swingbeaninfo/images/JComboBoxColor16.gif + make/data/swingbeaninfo/images/JComboBoxColor32.gif + make/data/swingbeaninfo/images/JComboBoxMono16.gif + make/data/swingbeaninfo/images/JComboBoxMono32.gif + make/data/swingbeaninfo/images/JComponentColor16.gif + make/data/swingbeaninfo/images/JDesktopPaneColor16.gif + make/data/swingbeaninfo/images/JDesktopPaneColor32.gif + make/data/swingbeaninfo/images/JDesktopPaneMono16.gif + make/data/swingbeaninfo/images/JDesktopPaneMono32.gif + make/data/swingbeaninfo/images/JDialogColor16.gif + make/data/swingbeaninfo/images/JDialogColor32.gif + make/data/swingbeaninfo/images/JDialogMono16.gif + make/data/swingbeaninfo/images/JDialogMono32.gif + make/data/swingbeaninfo/images/JEditorPaneColor16.gif + make/data/swingbeaninfo/images/JEditorPaneColor32.gif + make/data/swingbeaninfo/images/JEditorPaneMono16.gif + make/data/swingbeaninfo/images/JEditorPaneMono32.gif + make/data/swingbeaninfo/images/JFileChooserColor16.gif + make/data/swingbeaninfo/images/JFileChooserColor32.gif + make/data/swingbeaninfo/images/JFileChooserMono16.gif + make/data/swingbeaninfo/images/JFileChooserMono32.gif + make/data/swingbeaninfo/images/JFormattedTextFieldColor16.gif + make/data/swingbeaninfo/images/JFormattedTextFieldColor32.gif + make/data/swingbeaninfo/images/JFormattedTextFieldMono16.gif + make/data/swingbeaninfo/images/JFormattedTextFieldMono32.gif + make/data/swingbeaninfo/images/JFrameColor16.gif + make/data/swingbeaninfo/images/JFrameColor32.gif + make/data/swingbeaninfo/images/JFrameMono16.gif + make/data/swingbeaninfo/images/JFrameMono32.gif + make/data/swingbeaninfo/images/JInternalFrameColor16.gif + make/data/swingbeaninfo/images/JInternalFrameColor32.gif + make/data/swingbeaninfo/images/JInternalFrameMono16.gif + make/data/swingbeaninfo/images/JInternalFrameMono32.gif + make/data/swingbeaninfo/images/JLabelColor16.gif + make/data/swingbeaninfo/images/JLabelColor32.gif + make/data/swingbeaninfo/images/JLabelMono16.gif + make/data/swingbeaninfo/images/JLabelMono32.gif + make/data/swingbeaninfo/images/JLayeredPaneColor16.gif + make/data/swingbeaninfo/images/JLayeredPaneColor32.gif + make/data/swingbeaninfo/images/JLayeredPaneMono16.gif + make/data/swingbeaninfo/images/JLayeredPaneMono32.gif + make/data/swingbeaninfo/images/JListColor16.gif + make/data/swingbeaninfo/images/JListColor32.gif + make/data/swingbeaninfo/images/JListMono16.gif + make/data/swingbeaninfo/images/JListMono32.gif + make/data/swingbeaninfo/images/JMenuBarColor16.gif + make/data/swingbeaninfo/images/JMenuBarColor32.gif + make/data/swingbeaninfo/images/JMenuBarMono16.gif + make/data/swingbeaninfo/images/JMenuBarMono32.gif + make/data/swingbeaninfo/images/JMenuColor16.gif + make/data/swingbeaninfo/images/JMenuColor32.gif + make/data/swingbeaninfo/images/JMenuItemColor16.gif + make/data/swingbeaninfo/images/JMenuItemColor32.gif + make/data/swingbeaninfo/images/JMenuItemMono16.gif + make/data/swingbeaninfo/images/JMenuItemMono32.gif + make/data/swingbeaninfo/images/JMenuMono16.gif + make/data/swingbeaninfo/images/JMenuMono32.gif + make/data/swingbeaninfo/images/JOptionPaneColor16.gif + make/data/swingbeaninfo/images/JOptionPaneColor32.gif + make/data/swingbeaninfo/images/JOptionPaneMono16.gif + make/data/swingbeaninfo/images/JOptionPaneMono32.gif + make/data/swingbeaninfo/images/JPanelColor16.gif + make/data/swingbeaninfo/images/JPanelColor32.gif + make/data/swingbeaninfo/images/JPanelMono16.gif + make/data/swingbeaninfo/images/JPanelMono32.gif + make/data/swingbeaninfo/images/JPasswordFieldColor16.gif + make/data/swingbeaninfo/images/JPasswordFieldColor32.gif + make/data/swingbeaninfo/images/JPasswordFieldMono16.gif + make/data/swingbeaninfo/images/JPasswordFieldMono32.gif + make/data/swingbeaninfo/images/JPopupMenuColor16.gif + make/data/swingbeaninfo/images/JPopupMenuColor32.gif + make/data/swingbeaninfo/images/JPopupMenuMono16.gif + make/data/swingbeaninfo/images/JPopupMenuMono32.gif + make/data/swingbeaninfo/images/JProgressBarColor16.gif + make/data/swingbeaninfo/images/JProgressBarColor32.gif + make/data/swingbeaninfo/images/JProgressBarMono16.gif + make/data/swingbeaninfo/images/JProgressBarMono32.gif + make/data/swingbeaninfo/images/JRadioButtonColor16.gif + make/data/swingbeaninfo/images/JRadioButtonColor32.gif + make/data/swingbeaninfo/images/JRadioButtonMenuItemColor16.gif + make/data/swingbeaninfo/images/JRadioButtonMenuItemColor32.gif + make/data/swingbeaninfo/images/JRadioButtonMenuItemMono16.gif + make/data/swingbeaninfo/images/JRadioButtonMenuItemMono32.gif + make/data/swingbeaninfo/images/JRadioButtonMono16.gif + make/data/swingbeaninfo/images/JRadioButtonMono32.gif + make/data/swingbeaninfo/images/JRootPaneColor16.gif + make/data/swingbeaninfo/images/JRootPaneColor32.gif + make/data/swingbeaninfo/images/JRootPaneMono16.gif + make/data/swingbeaninfo/images/JRootPaneMono32.gif + make/data/swingbeaninfo/images/JScrollBarColor16.gif + make/data/swingbeaninfo/images/JScrollBarColor32.gif + make/data/swingbeaninfo/images/JScrollBarMono16.gif + make/data/swingbeaninfo/images/JScrollBarMono32.gif + make/data/swingbeaninfo/images/JScrollPaneColor16.gif + make/data/swingbeaninfo/images/JScrollPaneColor32.gif + make/data/swingbeaninfo/images/JScrollPaneMono16.gif + make/data/swingbeaninfo/images/JScrollPaneMono32.gif + make/data/swingbeaninfo/images/JSeparatorColor16.gif + make/data/swingbeaninfo/images/JSeparatorColor32.gif + make/data/swingbeaninfo/images/JSeparatorMono16.gif + make/data/swingbeaninfo/images/JSeparatorMono32.gif + make/data/swingbeaninfo/images/JSliderColor16.gif + make/data/swingbeaninfo/images/JSliderColor32.gif + make/data/swingbeaninfo/images/JSliderMono16.gif + make/data/swingbeaninfo/images/JSliderMono32.gif + make/data/swingbeaninfo/images/JSpinnerColor16.gif + make/data/swingbeaninfo/images/JSpinnerColor32.gif + make/data/swingbeaninfo/images/JSpinnerMono16.gif + make/data/swingbeaninfo/images/JSpinnerMono32.gif + make/data/swingbeaninfo/images/JSplitPaneColor16.gif + make/data/swingbeaninfo/images/JSplitPaneColor32.gif + make/data/swingbeaninfo/images/JSplitPaneMono16.gif + make/data/swingbeaninfo/images/JSplitPaneMono32.gif + make/data/swingbeaninfo/images/JTabbedPaneColor16.gif + make/data/swingbeaninfo/images/JTabbedPaneColor32.gif + make/data/swingbeaninfo/images/JTabbedPaneMono16.gif + make/data/swingbeaninfo/images/JTabbedPaneMono32.gif + make/data/swingbeaninfo/images/JTableColor16.gif + make/data/swingbeaninfo/images/JTableColor32.gif + make/data/swingbeaninfo/images/JTableMono16.gif + make/data/swingbeaninfo/images/JTableMono32.gif + make/data/swingbeaninfo/images/JTextAreaColor16.gif + make/data/swingbeaninfo/images/JTextAreaColor32.gif + make/data/swingbeaninfo/images/JTextAreaMono16.gif + make/data/swingbeaninfo/images/JTextAreaMono32.gif + make/data/swingbeaninfo/images/JTextFieldColor16.gif + make/data/swingbeaninfo/images/JTextFieldColor32.gif + make/data/swingbeaninfo/images/JTextFieldMono16.gif + make/data/swingbeaninfo/images/JTextFieldMono32.gif + make/data/swingbeaninfo/images/JTextPaneColor16.gif + make/data/swingbeaninfo/images/JTextPaneColor32.gif + make/data/swingbeaninfo/images/JTextPaneMono16.gif + make/data/swingbeaninfo/images/JTextPaneMono32.gif + make/data/swingbeaninfo/images/JToggleButtonColor16.gif + make/data/swingbeaninfo/images/JToggleButtonColor32.gif + make/data/swingbeaninfo/images/JToggleButtonMono16.gif + make/data/swingbeaninfo/images/JToggleButtonMono32.gif + make/data/swingbeaninfo/images/JToolBarColor16.gif + make/data/swingbeaninfo/images/JToolBarColor32.gif + make/data/swingbeaninfo/images/JToolBarMono16.gif + make/data/swingbeaninfo/images/JToolBarMono32.gif + make/data/swingbeaninfo/images/JTreeColor16.gif + make/data/swingbeaninfo/images/JTreeColor32.gif + make/data/swingbeaninfo/images/JTreeMono16.gif + make/data/swingbeaninfo/images/JTreeMono32.gif + make/data/swingbeaninfo/images/JViewportColor16.gif + make/data/swingbeaninfo/images/JViewportColor32.gif + make/data/swingbeaninfo/images/JViewportMono16.gif + make/data/swingbeaninfo/images/JViewportMono32.gif + make/data/swingbeaninfo/images/JWindowColor16.gif + make/data/swingbeaninfo/images/JWindowColor32.gif + make/data/swingbeaninfo/images/JWindowMono16.gif + make/data/swingbeaninfo/images/JWindowMono32.gif + make/data/swingbeaninfo/javax/swing/SwingBeanInfoBase.java + make/data/swingbeaninfo/manifest.mf + make/data/swingbeaninfo/sun/swing/BeanInfoUtils.java + make/data/tzdata/VERSION + make/data/tzdata/africa + make/data/tzdata/antarctica + make/data/tzdata/asia + make/data/tzdata/australasia + make/data/tzdata/backward + make/data/tzdata/etcetera + make/data/tzdata/europe + make/data/tzdata/factory + make/data/tzdata/gmt + make/data/tzdata/iso3166.tab + make/data/tzdata/jdk11_backward + make/data/tzdata/leapseconds + make/data/tzdata/northamerica + make/data/tzdata/pacificnew + make/data/tzdata/solar87 + make/data/tzdata/solar88 + make/data/tzdata/solar89 + make/data/tzdata/southamerica + make/data/tzdata/systemv + make/data/tzdata/zone.tab + make/data/unicodedata/PropList.txt + make/data/unicodedata/Scripts.txt + make/data/unicodedata/SpecialCasing.txt + make/data/unicodedata/UnicodeData.txt + make/data/unicodedata/VERSION - make/docs/CORE_PKGS.gmk - make/docs/Makefile - make/docs/NON_CORE_PKGS.gmk - make/docs/Notes.html + make/gendata/GendataBreakIterator.gmk + make/gendata/GendataFontConfig.gmk + make/gendata/GendataHtml32dtd.gmk + make/gendata/GendataTZDB.gmk + make/gensrc/GensrcBuffer.gmk + make/gensrc/GensrcCLDR.gmk + make/gensrc/GensrcCharacterData.gmk + make/gensrc/GensrcCharsetCoder.gmk + make/gensrc/GensrcCharsetMapping.gmk + make/gensrc/GensrcExceptions.gmk + make/gensrc/GensrcIcons.gmk + make/gensrc/GensrcJDWP.gmk + make/gensrc/GensrcJObjC.gmk + make/gensrc/GensrcLocaleDataMetaInfo.gmk + make/gensrc/GensrcMisc.gmk + make/gensrc/GensrcProperties.gmk + make/gensrc/GensrcSwing.gmk + make/gensrc/GensrcX11Wrappers.gmk - make/java/Makefile - make/java/applet/Makefile - make/java/awt/Makefile - make/java/beans/Makefile - make/java/fdlibm/FILES_c.gmk - make/java/fdlibm/Makefile - make/java/instrument/Makefile - make/java/instrument/mapfile-vers - make/java/invoke/Makefile - make/java/jar/Makefile - make/java/java/Exportedfiles.gmk - make/java/java/FILES_c.gmk - make/java/java/FILES_java.gmk - make/java/java/Makefile - make/java/java/genlocales.gmk - make/java/java/localegen.sh - make/java/java/localelist.sh - make/java/java/mapfile-vers - make/java/java/reflect/Makefile - make/java/java/reorder-i586 - make/java/java/reorder-sparc - make/java/java/reorder-sparcv9 - make/java/java_crw_demo/Makefile - make/java/java_crw_demo/mapfile-vers - make/java/java_hprof_demo/Makefile - make/java/java_hprof_demo/mapfile-vers - make/java/jexec/Makefile - make/java/jli/Makefile - make/java/jli/mapfile-vers - make/java/jobjc/Makefile - make/java/jvm/Makefile - make/java/logging/Makefile - make/java/main/Makefile - make/java/main/java/Makefile - make/java/main/java/mapfile-amd64 - make/java/main/java/mapfile-i586 - make/java/main/java/mapfile-sparc - make/java/main/java/mapfile-sparcv9 - make/java/main/javaw/Makefile - make/java/management/Exportedfiles.gmk - make/java/management/FILES_c.gmk - make/java/management/Makefile - make/java/management/mapfile-vers - make/java/math/Makefile - make/java/net/FILES_c.gmk - make/java/net/Makefile - make/java/net/mapfile-vers - make/java/nio/Exportedfiles.gmk - make/java/nio/FILES_c.gmk - make/java/nio/FILES_java.gmk - make/java/nio/Makefile - make/java/nio/addNotices.sh - make/java/nio/genBuffer.sh - make/java/nio/genCharsetProvider.sh - make/java/nio/genCoder.sh - make/java/nio/genExceptions.sh - make/java/nio/mapfile-bsd - make/java/nio/mapfile-linux - make/java/nio/mapfile-solaris - make/java/nio/reorder-i586 - make/java/nio/reorder-sparc - make/java/nio/reorder-sparcv9 - make/java/npt/Makefile - make/java/npt/mapfile-vers - make/java/redist/Makefile - make/java/redist/fonts/Makefile - make/java/redist/sajdi/Makefile - make/java/rmi/Makefile - make/java/security/Makefile - make/java/sql/Makefile - make/java/sun_nio/FILES_java.gmk - make/java/sun_nio/Makefile - make/java/text/Makefile - make/java/text/base/FILES_java.gmk - make/java/text/base/Makefile - make/java/text/bidi/Makefile - make/java/time/Makefile - make/java/util/FILES_java.gmk - make/java/util/FILES_properties.gmk - make/java/util/Makefile - make/java/verify/Makefile - make/java/verify/mapfile-vers - make/java/verify/reorder-i586 - make/java/verify/reorder-sparc - make/java/verify/reorder-sparcv9 - make/java/version/Makefile - make/java/zip/FILES_c.gmk - make/java/zip/FILES_java.gmk - make/java/zip/Makefile - make/java/zip/mapfile-vers - make/java/zip/reorder-i586 - make/java/zip/reorder-sparc - make/java/zip/reorder-sparcv9 - make/javax/Makefile - make/javax/accessibility/Makefile - make/javax/crypto/Defs-jce.gmk - make/javax/crypto/Makefile - make/javax/crypto/policy/limited/LIMITED - make/javax/crypto/policy/limited/default_local.policy - make/javax/crypto/policy/limited/exempt_local.policy - make/javax/crypto/policy/unlimited/UNLIMITED - make/javax/crypto/policy/unlimited/default_US_export.policy - make/javax/crypto/policy/unlimited/default_local.policy - make/javax/imageio/Makefile - make/javax/management/Makefile - make/javax/others/Makefile - make/javax/print/Makefile - make/javax/rmi/Makefile - make/javax/rmi/ssl/Makefile - make/javax/security/Makefile - make/javax/sound/FILES_c.gmk - make/javax/sound/Makefile - make/javax/sound/SoundDefs.gmk - make/javax/sound/jsoundalsa/Makefile - make/javax/sound/jsoundalsa/mapfile-vers - make/javax/sound/jsoundds/Makefile - make/javax/sound/mapfile-vers - make/javax/sql/Makefile - make/javax/swing/FILES.gmk - make/javax/swing/Makefile - make/javax/swing/beaninfo/FILES.gmk - make/javax/swing/beaninfo/Makefile - make/javax/swing/beaninfo/SwingBeans.gmk - make/javax/swing/beaninfo/manifest - make/javax/swing/html32dtd/Makefile - make/javax/swing/plaf/FILES.gmk - make/javax/swing/plaf/Makefile - make/jdk/Makefile - make/jdk_generic_profile.sh - make/jpda/Makefile - make/jpda/back/Makefile - make/jpda/back/mapfile-vers - make/jpda/bdi/Makefile - make/jpda/expr/Makefile - make/jpda/front/Makefile - make/jpda/gui/Makefile - make/jpda/jdwp/Makefile - make/jpda/jdwp/jdwp.spec - make/jpda/transport/Makefile - make/jpda/transport/shmem/Makefile - make/jpda/transport/shmem/mapfile-vers - make/jpda/transport/socket/Makefile - make/jpda/transport/socket/mapfile-vers - make/jpda/tty/Makefile - make/jprt.gmk - make/jprt.properties - make/launchers/Makefile - make/launchers/Makefile.launcher + make/lib/Awt2dLibraries.gmk + make/lib/CoreLibraries.gmk + make/lib/NetworkingLibraries.gmk + make/lib/NioLibraries.gmk + make/lib/PlatformLibraries.gmk + make/lib/SecurityLibraries.gmk + make/lib/ServiceabilityLibraries.gmk + make/lib/SoundLibraries.gmk + make/mapfiles/launchers/mapfile-sparc + make/mapfiles/launchers/mapfile-sparcv9 + make/mapfiles/launchers/mapfile-x86 + make/mapfiles/launchers/mapfile-x86_64 + make/mapfiles/libattach/mapfile-linux + make/mapfiles/libattach/mapfile-solaris + make/mapfiles/libattach/reorder-windows-x86 + make/mapfiles/libattach/reorder-windows-x86_64 + make/mapfiles/libawt/mapfile-mawt-vers + make/mapfiles/libawt/mapfile-vers + make/mapfiles/libawt/mapfile-vers-linux + make/mapfiles/libawt_headless/mapfile-vers + make/mapfiles/libawt_headless/reorder-sparc + make/mapfiles/libawt_headless/reorder-sparcv9 + make/mapfiles/libawt_headless/reorder-x86 + make/mapfiles/libawt_xawt/mapfile-vers + make/mapfiles/libdcpr/mapfile-vers + make/mapfiles/libdt_socket/mapfile-vers + make/mapfiles/libfontmanager/mapfile-vers + make/mapfiles/libfontmanager/mapfile-vers.openjdk + make/mapfiles/libhprof/mapfile-vers + make/mapfiles/libinstrument/mapfile-vers + make/mapfiles/libj2gss/mapfile-vers + make/mapfiles/libj2pcsc/mapfile-vers + make/mapfiles/libj2pkcs11/mapfile-vers + make/mapfiles/libj2ucrypto/mapfile-vers + make/mapfiles/libjaas/mapfile-vers + make/mapfiles/libjava/mapfile-vers + make/mapfiles/libjava/reorder-sparc + make/mapfiles/libjava/reorder-sparcv9 + make/mapfiles/libjava/reorder-x86 + make/mapfiles/libjava_crw_demo/mapfile-vers + make/mapfiles/libjawt/mapfile-vers + make/mapfiles/libjdga/mapfile-vers + make/mapfiles/libjdwp/mapfile-vers + make/mapfiles/libjfr/mapfile-vers + make/mapfiles/libjli/mapfile-vers + make/mapfiles/libjpeg/mapfile-vers + make/mapfiles/libjpeg/mapfile-vers-closed + make/mapfiles/libjpeg/reorder-sparc + make/mapfiles/libjpeg/reorder-sparcv9 + make/mapfiles/libjpeg/reorder-x86 + make/mapfiles/libjsdt/mapfile-vers + make/mapfiles/libjsound/mapfile-vers + make/mapfiles/libjsoundalsa/mapfile-vers + make/mapfiles/libkcms/mapfile-vers + make/mapfiles/liblcms/mapfile-vers + make/mapfiles/libmanagement/mapfile-vers + make/mapfiles/libmlib_image/mapfile-vers + make/mapfiles/libnet/mapfile-vers + make/mapfiles/libnio/mapfile-linux + make/mapfiles/libnio/mapfile-macosx + make/mapfiles/libnio/mapfile-solaris + make/mapfiles/libnio/reorder-sparc + make/mapfiles/libnio/reorder-sparcv9 + make/mapfiles/libnio/reorder-x86 + make/mapfiles/libnpt/mapfile-vers + make/mapfiles/libsctp/mapfile-vers + make/mapfiles/libsplashscreen/mapfile-vers + make/mapfiles/libsunec/mapfile-vers + make/mapfiles/libt2k/mapfile-vers + make/mapfiles/libunpack/mapfile-vers + make/mapfiles/libunpack/mapfile-vers-unpack200 + make/mapfiles/libverify/mapfile-vers + make/mapfiles/libverify/reorder-sparc + make/mapfiles/libverify/reorder-sparcv9 + make/mapfiles/libverify/reorder-x86 + make/mapfiles/libzip/mapfile-vers + make/mapfiles/libzip/reorder-sparc + make/mapfiles/libzip/reorder-sparcv9 + make/mapfiles/libzip/reorder-x86 - make/mkdemo/Makefile - make/mkdemo/applets/Animator/Makefile - make/mkdemo/applets/ArcTest/Makefile - make/mkdemo/applets/BarChart/Makefile - make/mkdemo/applets/Blink/Makefile - make/mkdemo/applets/CardTest/Makefile - make/mkdemo/applets/Clock/Makefile - make/mkdemo/applets/DitherTest/Makefile - make/mkdemo/applets/DrawTest/Makefile - make/mkdemo/applets/Fractal/Makefile - make/mkdemo/applets/GraphLayout/Makefile - make/mkdemo/applets/GraphicsTest/Makefile - make/mkdemo/applets/JumpingBox/Makefile - make/mkdemo/applets/Makefile - make/mkdemo/applets/MoleculeViewer/Makefile - make/mkdemo/applets/NervousText/Makefile - make/mkdemo/applets/SimpleGraph/Makefile - make/mkdemo/applets/SortDemo/Makefile - make/mkdemo/applets/SpreadSheet/Makefile - make/mkdemo/applets/TicTacToe/Makefile - make/mkdemo/applets/WireFrame/Makefile - make/mkdemo/jfc/CodePointIM/Makefile - make/mkdemo/jfc/FileChooserDemo/Makefile - make/mkdemo/jfc/Font2DTest/Makefile - make/mkdemo/jfc/Java2D/Makefile - make/mkdemo/jfc/Laffy/Makefile - make/mkdemo/jfc/Makefile - make/mkdemo/jfc/Metalworks/Makefile - make/mkdemo/jfc/Notepad/Makefile - make/mkdemo/jfc/SampleTree/Makefile - make/mkdemo/jfc/Stylepad/Makefile - make/mkdemo/jfc/SwingApplet/Makefile - make/mkdemo/jfc/SwingSet2/Makefile - make/mkdemo/jfc/SwingSet3/Makefile - make/mkdemo/jfc/TableExample/Makefile - make/mkdemo/jfc/TransparentRuler/Makefile - make/mkdemo/jni/Makefile - make/mkdemo/jni/Poller/Makefile - make/mkdemo/jpda/Makefile - make/mkdemo/jvmti/Makefile - make/mkdemo/jvmti/README.txt - make/mkdemo/jvmti/compiledMethodLoad/Makefile - make/mkdemo/jvmti/gctest/Makefile - make/mkdemo/jvmti/heapTracker/Makefile - make/mkdemo/jvmti/heapViewer/Makefile - make/mkdemo/jvmti/hprof/Makefile - make/mkdemo/jvmti/mapfile-vers - make/mkdemo/jvmti/minst/Makefile - make/mkdemo/jvmti/mtrace/Makefile - make/mkdemo/jvmti/versionCheck/Makefile - make/mkdemo/jvmti/waiters/Makefile - make/mkdemo/management/FullThreadDump/Makefile - make/mkdemo/management/JTop/Makefile - make/mkdemo/management/Makefile - make/mkdemo/management/MemoryMonitor/Makefile - make/mkdemo/management/README.txt - make/mkdemo/management/VerboseGC/Makefile - make/mkdemo/nio/Makefile - make/mkdemo/nio/zipfs/Makefile - make/mkdemo/scripting/Makefile - make/mkdemo/scripting/jconsole-plugin/Makefile - make/mksample/Makefile - make/mksample/dtrace/Makefile - make/mksample/forkjoin/Makefile - make/mksample/forkjoin/mergesort/Makefile - make/mksample/jmx/Makefile - make/mksample/jmx/jmx-scandir/Makefile - make/mksample/nbproject/Makefile - make/mksample/nio/Makefile - make/mksample/nio/chatserver/Makefile - make/mksample/nio/file/Makefile - make/mksample/nio/multicast/Makefile - make/mksample/nio/server/Makefile - make/mksample/scripting/Makefile - make/mksample/scripting/scriptpad/Makefile - make/mksample/webservices/EbayClient/Makefile - make/mksample/webservices/EbayServer/Makefile - make/mksample/webservices/Makefile ! make/netbeans/jdwpgen/nbproject/project.properties + make/non-build-utils/reorder/Makefile + make/non-build-utils/reorder/tests/Exit.java + make/non-build-utils/reorder/tests/Hello.java + make/non-build-utils/reorder/tests/IntToString.java + make/non-build-utils/reorder/tests/JHello.java + make/non-build-utils/reorder/tests/LoadFrame.java + make/non-build-utils/reorder/tests/LoadJFrame.java + make/non-build-utils/reorder/tests/LoadToolkit.java + make/non-build-utils/reorder/tests/Null.java + make/non-build-utils/reorder/tests/Sleep.java + make/non-build-utils/reorder/tools/Combine.java + make/non-build-utils/reorder/tools/MaxTime.java + make/non-build-utils/reorder/tools/mcount.c + make/non-build-utils/reorder/tools/remove_mcount.c + make/non-build-utils/reorder/tools/util-i586.il + make/non-build-utils/reorder/tools/util-sparc.il + make/non-build-utils/reorder/tools/util-sparcv9.il + make/non-build-utils/sharing/README.txt + make/non-build-utils/sharing/tests/GHello.java + make/non-build-utils/sharing/tests/Hello.java + make/non-build-utils/sharing/tests/JHello.java + make/non-build-utils/src/build/tools/commentchecker/CommentChecker.java + make/non-build-utils/src/build/tools/dirdiff/DirDiff.java + make/non-build-utils/src/build/tools/makeclasslist/MakeClasslist.java - make/org/Makefile - make/org/ietf/Makefile - make/org/ietf/jgss/FILES_java.gmk - make/org/ietf/jgss/Makefile - make/org/jcp/Makefile + make/profile-includes.txt + make/profile-rtjar-includes.txt + make/scripts/addNotices.sh + make/scripts/genCharsetProvider.sh + make/scripts/genExceptions.sh + make/scripts/localelist.sh + make/src/classes/build/tools/addjsum/AddJsum.java + make/src/classes/build/tools/addtorestrictedpkgs/AddToRestrictedPkgs.java + make/src/classes/build/tools/buildmetaindex/BuildMetaIndex.java + make/src/classes/build/tools/charsetmapping/DBCS.java + make/src/classes/build/tools/charsetmapping/EUC_TW.java + make/src/classes/build/tools/charsetmapping/HKSCS.java + make/src/classes/build/tools/charsetmapping/JIS0213.java + make/src/classes/build/tools/charsetmapping/Main.java + make/src/classes/build/tools/charsetmapping/SBCS.java + make/src/classes/build/tools/charsetmapping/Utils.java + make/src/classes/build/tools/classfile/RemoveMethods.java + make/src/classes/build/tools/cldrconverter/AbstractLDMLHandler.java + make/src/classes/build/tools/cldrconverter/Bundle.java + make/src/classes/build/tools/cldrconverter/BundleGenerator.java + make/src/classes/build/tools/cldrconverter/CLDRConverter.java + make/src/classes/build/tools/cldrconverter/CalendarType.java + make/src/classes/build/tools/cldrconverter/Container.java + make/src/classes/build/tools/cldrconverter/CopyrightHeaders.java + make/src/classes/build/tools/cldrconverter/Entry.java + make/src/classes/build/tools/cldrconverter/IgnoredContainer.java + make/src/classes/build/tools/cldrconverter/KeyContainer.java + make/src/classes/build/tools/cldrconverter/LDMLParseHandler.java + make/src/classes/build/tools/cldrconverter/MetaZonesParseHandler.java + make/src/classes/build/tools/cldrconverter/NumberingSystemsParseHandler.java + make/src/classes/build/tools/cldrconverter/ResourceBundleGenerator.java + make/src/classes/build/tools/cldrconverter/StringArrayElement.java + make/src/classes/build/tools/cldrconverter/StringArrayEntry.java + make/src/classes/build/tools/cldrconverter/StringEntry.java + make/src/classes/build/tools/cldrconverter/SupplementDataParseHandler.java + make/src/classes/build/tools/compilefontconfig/CompileFontConfig.java + make/src/classes/build/tools/compileproperties/CompileProperties.java + make/src/classes/build/tools/deps/CheckDeps.java + make/src/classes/build/tools/dtdbuilder/DTDBuilder.java + make/src/classes/build/tools/dtdbuilder/DTDInputStream.java + make/src/classes/build/tools/dtdbuilder/DTDParser.java + make/src/classes/build/tools/dtdbuilder/PublicMapping.java + make/src/classes/build/tools/dtdbuilder/README.txt + make/src/classes/build/tools/generatebreakiteratordata/BreakIteratorRBControl.java + make/src/classes/build/tools/generatebreakiteratordata/CharSet.java + make/src/classes/build/tools/generatebreakiteratordata/CharacterCategory.java + make/src/classes/build/tools/generatebreakiteratordata/DictionaryBasedBreakIteratorBuilder.java + make/src/classes/build/tools/generatebreakiteratordata/GenerateBreakIteratorData.java + make/src/classes/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java + make/src/classes/build/tools/generatebreakiteratordata/SupplementaryCharacterData.java + make/src/classes/build/tools/generatecharacter/CharacterName.java + make/src/classes/build/tools/generatecharacter/CharacterScript.java + make/src/classes/build/tools/generatecharacter/GenerateCharacter.java + make/src/classes/build/tools/generatecharacter/PrintCharacterRanges.java + make/src/classes/build/tools/generatecharacter/PropList.java + make/src/classes/build/tools/generatecharacter/SpecialCaseMap.java + make/src/classes/build/tools/generatecharacter/UnicodeSpec.java + make/src/classes/build/tools/generatecharacter/Utility.java + make/src/classes/build/tools/generatecurrencydata/GenerateCurrencyData.java + make/src/classes/build/tools/generatenimbus/AbstractGradient.java + make/src/classes/build/tools/generatenimbus/Border.java + make/src/classes/build/tools/generatenimbus/Canvas.java + make/src/classes/build/tools/generatenimbus/ComponentColor.java + make/src/classes/build/tools/generatenimbus/Dimension.java + make/src/classes/build/tools/generatenimbus/Ellipse.java + make/src/classes/build/tools/generatenimbus/Generator.java + make/src/classes/build/tools/generatenimbus/Gradient.java + make/src/classes/build/tools/generatenimbus/GradientStop.java + make/src/classes/build/tools/generatenimbus/Insets.java + make/src/classes/build/tools/generatenimbus/Layer.java + make/src/classes/build/tools/generatenimbus/Matte.java + make/src/classes/build/tools/generatenimbus/ObjectFactory.java + make/src/classes/build/tools/generatenimbus/Paint.java + make/src/classes/build/tools/generatenimbus/PainterGenerator.java + make/src/classes/build/tools/generatenimbus/Path.java + make/src/classes/build/tools/generatenimbus/Point.java + make/src/classes/build/tools/generatenimbus/RadialGradient.java + make/src/classes/build/tools/generatenimbus/Rectangle.java + make/src/classes/build/tools/generatenimbus/Shape.java + make/src/classes/build/tools/generatenimbus/SynthModel.java + make/src/classes/build/tools/generatenimbus/Typeface.java + make/src/classes/build/tools/generatenimbus/UIColor.java + make/src/classes/build/tools/generatenimbus/UIComponent.java + make/src/classes/build/tools/generatenimbus/UIDefault.java + make/src/classes/build/tools/generatenimbus/UIFont.java + make/src/classes/build/tools/generatenimbus/UIIconRegion.java + make/src/classes/build/tools/generatenimbus/UIProperty.java + make/src/classes/build/tools/generatenimbus/UIRegion.java + make/src/classes/build/tools/generatenimbus/UIState.java + make/src/classes/build/tools/generatenimbus/UIStateType.java + make/src/classes/build/tools/generatenimbus/UIStyle.java + make/src/classes/build/tools/generatenimbus/Utils.java + make/src/classes/build/tools/hasher/Hasher.java + make/src/classes/build/tools/icondata/awt/ToBin.java + make/src/classes/build/tools/icondata/osxapp/ToBin.java + make/src/classes/build/tools/jarreorder/JarReorder.java + make/src/classes/build/tools/jdwpgen/AbstractCommandNode.java + make/src/classes/build/tools/jdwpgen/AbstractGroupNode.java + make/src/classes/build/tools/jdwpgen/AbstractNamedNode.java + make/src/classes/build/tools/jdwpgen/AbstractSimpleNode.java + make/src/classes/build/tools/jdwpgen/AbstractSimpleTypeNode.java + make/src/classes/build/tools/jdwpgen/AbstractTypeListNode.java + make/src/classes/build/tools/jdwpgen/AbstractTypeNode.java + make/src/classes/build/tools/jdwpgen/AltNode.java + make/src/classes/build/tools/jdwpgen/ArrayObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/ArrayRegionTypeNode.java + make/src/classes/build/tools/jdwpgen/ArrayTypeNode.java + make/src/classes/build/tools/jdwpgen/BooleanTypeNode.java + make/src/classes/build/tools/jdwpgen/ByteTypeNode.java + make/src/classes/build/tools/jdwpgen/ClassLoaderObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/ClassObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/ClassTypeNode.java + make/src/classes/build/tools/jdwpgen/CommandNode.java + make/src/classes/build/tools/jdwpgen/CommandSetNode.java + make/src/classes/build/tools/jdwpgen/CommentNode.java + make/src/classes/build/tools/jdwpgen/ConstantNode.java + make/src/classes/build/tools/jdwpgen/ConstantSetNode.java + make/src/classes/build/tools/jdwpgen/Context.java + make/src/classes/build/tools/jdwpgen/ErrorNode.java + make/src/classes/build/tools/jdwpgen/ErrorSetNode.java + make/src/classes/build/tools/jdwpgen/EventNode.java + make/src/classes/build/tools/jdwpgen/FieldTypeNode.java + make/src/classes/build/tools/jdwpgen/FrameTypeNode.java + make/src/classes/build/tools/jdwpgen/GroupNode.java + make/src/classes/build/tools/jdwpgen/IntTypeNode.java + make/src/classes/build/tools/jdwpgen/InterfaceTypeNode.java + make/src/classes/build/tools/jdwpgen/LocationTypeNode.java + make/src/classes/build/tools/jdwpgen/LongTypeNode.java + make/src/classes/build/tools/jdwpgen/Main.java + make/src/classes/build/tools/jdwpgen/MethodTypeNode.java + make/src/classes/build/tools/jdwpgen/NameNode.java + make/src/classes/build/tools/jdwpgen/NameValueNode.java + make/src/classes/build/tools/jdwpgen/Node.java + make/src/classes/build/tools/jdwpgen/ObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/OutNode.java + make/src/classes/build/tools/jdwpgen/Parse.java + make/src/classes/build/tools/jdwpgen/ReferenceIDTypeNode.java + make/src/classes/build/tools/jdwpgen/ReferenceTypeNode.java + make/src/classes/build/tools/jdwpgen/RepeatNode.java + make/src/classes/build/tools/jdwpgen/ReplyNode.java + make/src/classes/build/tools/jdwpgen/RootNode.java + make/src/classes/build/tools/jdwpgen/SelectNode.java + make/src/classes/build/tools/jdwpgen/StringObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/StringTypeNode.java + make/src/classes/build/tools/jdwpgen/TaggedObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/ThreadGroupObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/ThreadObjectTypeNode.java + make/src/classes/build/tools/jdwpgen/TypeNode.java + make/src/classes/build/tools/jdwpgen/UntaggedValueTypeNode.java + make/src/classes/build/tools/jdwpgen/ValueTypeNode.java + make/src/classes/build/tools/spp/Spp.java + make/src/classes/build/tools/stripproperties/StripProperties.java + make/src/classes/build/tools/swingbeaninfo/DocBeanInfo.java + make/src/classes/build/tools/swingbeaninfo/GenDocletBeanInfo.java + make/src/classes/build/tools/swingbeaninfo/GenSwingBeanInfo.java + make/src/classes/build/tools/tzdb/ChronoField.java + make/src/classes/build/tools/tzdb/DateTimeException.java + make/src/classes/build/tools/tzdb/LocalDate.java + make/src/classes/build/tools/tzdb/LocalDateTime.java + make/src/classes/build/tools/tzdb/LocalTime.java + make/src/classes/build/tools/tzdb/TimeDefinition.java + make/src/classes/build/tools/tzdb/TzdbZoneRulesCompiler.java + make/src/classes/build/tools/tzdb/Utils.java + make/src/classes/build/tools/tzdb/ZoneOffset.java + make/src/classes/build/tools/tzdb/ZoneOffsetTransition.java + make/src/classes/build/tools/tzdb/ZoneOffsetTransitionRule.java + make/src/classes/build/tools/tzdb/ZoneRules.java + make/src/classes/build/tools/tzdb/ZoneRulesBuilder.java + make/src/native/add_gnu_debuglink/add_gnu_debuglink.c + make/src/native/fix_empty_sec_hdr_flags/fix_empty_sec_hdr_flags.c - make/sun/Makefile - make/sun/applet/Makefile - make/sun/audio/Makefile - make/sun/awt/CondenseRules.awk - make/sun/awt/Depend.mak - make/sun/awt/Depend.sed - make/sun/awt/FILES_c_unix.gmk - make/sun/awt/FILES_c_windows.gmk - make/sun/awt/FILES_export_unix.gmk - make/sun/awt/FILES_export_windows.gmk - make/sun/awt/Makefile - make/sun/awt/README - make/sun/awt/ToBin.java - make/sun/awt/make.depend - make/sun/awt/mapfile-mawt-vers - make/sun/awt/mapfile-vers - make/sun/awt/mapfile-vers-bsd - make/sun/awt/mapfile-vers-linux - make/sun/awt/mawt.gmk - make/sun/cldr/Makefile - make/sun/cmm/Makefile - make/sun/cmm/kcms/FILES_c_unix.gmk - make/sun/cmm/kcms/FILES_c_windows.gmk - make/sun/cmm/kcms/Makefile - make/sun/cmm/kcms/mapfile-vers - make/sun/cmm/lcms/FILES_c_unix.gmk - make/sun/cmm/lcms/FILES_c_windows.gmk - make/sun/cmm/lcms/Makefile - make/sun/cmm/lcms/mapfile-vers - make/sun/dcpr/FILES_c.gmk - make/sun/dcpr/Makefile - make/sun/dcpr/mapfile-vers - make/sun/font/FILES_c.gmk - make/sun/font/Makefile - make/sun/font/mapfile-vers - make/sun/font/mapfile-vers.openjdk - make/sun/font/reorder-i586 - make/sun/font/reorder-sparc - make/sun/font/reorder-sparcv9 - make/sun/font/t2k/FILES_c.gmk - make/sun/font/t2k/Makefile - make/sun/font/t2k/mapfile-vers - make/sun/headless/Makefile - make/sun/headless/mapfile-vers - make/sun/headless/reorder-i586 - make/sun/headless/reorder-sparc - make/sun/headless/reorder-sparcv9 - make/sun/image/Makefile - make/sun/image/generic/FILES_c.gmk - make/sun/image/generic/Makefile - make/sun/image/generic/mapfile-vers - make/sun/image/vis/FILES_c.gmk - make/sun/image/vis/Makefile - make/sun/jar/Makefile - make/sun/javazic/Makefile - make/sun/javazic/javatz/fullset.txt - make/sun/javazic/javatz/java_11_ids.txt - make/sun/javazic/javatz/java_us_ids.txt - make/sun/javazic/javatz/java_win_ids.txt - make/sun/javazic/javatz/java_zone_ids.txt - make/sun/javazic/javatz/jdk1.1.x_zone_ids.txt - make/sun/javazic/tzdata/VERSION - make/sun/javazic/tzdata/africa - make/sun/javazic/tzdata/antarctica - make/sun/javazic/tzdata/asia - make/sun/javazic/tzdata/australasia - make/sun/javazic/tzdata/backward - make/sun/javazic/tzdata/etcetera - make/sun/javazic/tzdata/europe - make/sun/javazic/tzdata/factory - make/sun/javazic/tzdata/gmt - make/sun/javazic/tzdata/iso3166.tab - make/sun/javazic/tzdata/jdk11_backward - make/sun/javazic/tzdata/leapseconds - make/sun/javazic/tzdata/northamerica - make/sun/javazic/tzdata/pacificnew - make/sun/javazic/tzdata/solar87 - make/sun/javazic/tzdata/solar88 - make/sun/javazic/tzdata/solar89 - make/sun/javazic/tzdata/southamerica - make/sun/javazic/tzdata/systemv - make/sun/javazic/tzdata/zone.tab - make/sun/javazic/tzdata_jdk/gmt - make/sun/javazic/tzdata_jdk/jdk11_backward - make/sun/javazic/tzdata_jdk/jdk11_full_backward - make/sun/jawt/Depend.mak - make/sun/jawt/Depend.sed - make/sun/jawt/Makefile - make/sun/jawt/make.depend - make/sun/jawt/mapfile-vers - make/sun/jconsole/FILES.gmk - make/sun/jconsole/Makefile - make/sun/jdga/Makefile - make/sun/jdga/mapfile-vers - make/sun/jpeg/FILES_c.gmk - make/sun/jpeg/Makefile - make/sun/jpeg/mapfile-vers - make/sun/jpeg/mapfile-vers-closed - make/sun/jpeg/reorder-i586 - make/sun/jpeg/reorder-sparc - make/sun/jpeg/reorder-sparcv9 - make/sun/launcher/Makefile - make/sun/lwawt/FILES_c_macosx.gmk - make/sun/lwawt/FILES_export_macosx.gmk - make/sun/lwawt/Makefile - make/sun/management/Makefile - make/sun/management/jmxremote/Makefile - make/sun/management/snmp/Makefile - make/sun/misc/Makefile - make/sun/native2ascii/Makefile - make/sun/net/FILES_java.gmk - make/sun/net/Makefile - make/sun/net/others/Makefile - make/sun/net/spi/Makefile - make/sun/net/spi/nameservice/Makefile - make/sun/net/spi/nameservice/dns/Makefile - make/sun/nio/Makefile - make/sun/nio/cs/FILES_java.gmk - make/sun/nio/cs/Makefile - make/sun/osxapp/Makefile - make/sun/osxapp/ToBin.java - make/sun/pisces/Makefile - make/sun/rmi/Makefile - make/sun/rmi/cgi/Makefile - make/sun/rmi/oldtools/FILES_java.gmk - make/sun/rmi/oldtools/Makefile - make/sun/rmi/registry/Makefile - make/sun/rmi/rmi/Makefile - make/sun/rmi/rmi/mapfile-vers - make/sun/rmi/rmic/FILES.gmk - make/sun/rmi/rmic/Makefile - make/sun/rmi/rmid/Makefile - make/sun/security/Makefile - make/sun/security/action/Makefile - make/sun/security/ec/FILES_c.gmk - make/sun/security/ec/Makefile - make/sun/security/ec/mapfile-vers - make/sun/security/jgss/Makefile - make/sun/security/jgss/wrapper/FILES_c.gmk - make/sun/security/jgss/wrapper/Makefile - make/sun/security/jgss/wrapper/mapfile-vers - make/sun/security/krb5/FILES_c_windows.gmk - make/sun/security/krb5/Makefile - make/sun/security/mscapi/FILES_cpp.gmk - make/sun/security/mscapi/Makefile - make/sun/security/other/Makefile - make/sun/security/pkcs11/FILES_c.gmk - make/sun/security/pkcs11/Makefile - make/sun/security/pkcs11/mapfile-vers - make/sun/security/smartcardio/FILES_c.gmk - make/sun/security/smartcardio/Makefile - make/sun/security/smartcardio/mapfile-vers - make/sun/security/tools/Makefile - make/sun/security/util/Makefile - make/sun/serialver/Makefile - make/sun/splashscreen/FILES_c.gmk - make/sun/splashscreen/Makefile - make/sun/splashscreen/mapfile-vers - make/sun/text/FILES_java.gmk - make/sun/text/FILES_properties.gmk - make/sun/text/Makefile - make/sun/tools/Makefile - make/sun/tracing/Makefile - make/sun/tracing/dtrace/Makefile - make/sun/tracing/dtrace/mapfile-vers - make/sun/tzdb/Makefile - make/sun/usagetracker/Makefile - make/sun/util/Makefile - make/sun/xawt/FILES_c_unix.gmk - make/sun/xawt/FILES_export_unix.gmk - make/sun/xawt/Makefile - make/sun/xawt/mapfile-vers - make/templates/bsd-header - make/templates/gpl-cp-header - make/templates/gpl-header - make/tools/CharsetMapping/Big5.map - make/tools/CharsetMapping/Big5.nr - make/tools/CharsetMapping/DoubleByte-X.java.template - make/tools/CharsetMapping/EUC_CN.map - make/tools/CharsetMapping/EUC_KR.map - make/tools/CharsetMapping/GBK.map - make/tools/CharsetMapping/HKSCS2001.c2b - make/tools/CharsetMapping/HKSCS2001.map - make/tools/CharsetMapping/HKSCS2008.c2b - make/tools/CharsetMapping/HKSCS2008.map - make/tools/CharsetMapping/HKSCS_XP.c2b - make/tools/CharsetMapping/HKSCS_XP.map - make/tools/CharsetMapping/IBM037.c2b - make/tools/CharsetMapping/IBM037.map - make/tools/CharsetMapping/IBM037.nr - make/tools/CharsetMapping/IBM1006.map - make/tools/CharsetMapping/IBM1025.c2b - make/tools/CharsetMapping/IBM1025.map - make/tools/CharsetMapping/IBM1025.nr - make/tools/CharsetMapping/IBM1026.c2b - make/tools/CharsetMapping/IBM1026.map - make/tools/CharsetMapping/IBM1026.nr - make/tools/CharsetMapping/IBM1046.map - make/tools/CharsetMapping/IBM1047.map - make/tools/CharsetMapping/IBM1097.map - make/tools/CharsetMapping/IBM1098.map - make/tools/CharsetMapping/IBM1112.c2b - make/tools/CharsetMapping/IBM1112.map - make/tools/CharsetMapping/IBM1112.nr - make/tools/CharsetMapping/IBM1122.c2b - make/tools/CharsetMapping/IBM1122.map - make/tools/CharsetMapping/IBM1122.nr - make/tools/CharsetMapping/IBM1123.c2b - make/tools/CharsetMapping/IBM1123.map - make/tools/CharsetMapping/IBM1123.nr - make/tools/CharsetMapping/IBM1124.map - make/tools/CharsetMapping/IBM1140.c2b - make/tools/CharsetMapping/IBM1140.map - make/tools/CharsetMapping/IBM1141.c2b - make/tools/CharsetMapping/IBM1141.map - make/tools/CharsetMapping/IBM1142.c2b - make/tools/CharsetMapping/IBM1142.map - make/tools/CharsetMapping/IBM1143.c2b - make/tools/CharsetMapping/IBM1143.map - make/tools/CharsetMapping/IBM1144.c2b - make/tools/CharsetMapping/IBM1144.map - make/tools/CharsetMapping/IBM1145.c2b - make/tools/CharsetMapping/IBM1145.map - make/tools/CharsetMapping/IBM1146.c2b - make/tools/CharsetMapping/IBM1146.map - make/tools/CharsetMapping/IBM1147.c2b - make/tools/CharsetMapping/IBM1147.map - make/tools/CharsetMapping/IBM1148.c2b - make/tools/CharsetMapping/IBM1148.map - make/tools/CharsetMapping/IBM1149.c2b - make/tools/CharsetMapping/IBM1149.map - make/tools/CharsetMapping/IBM1364.c2b - make/tools/CharsetMapping/IBM1364.map - make/tools/CharsetMapping/IBM1381.c2b - make/tools/CharsetMapping/IBM1381.map - make/tools/CharsetMapping/IBM1383.c2b - make/tools/CharsetMapping/IBM1383.map - make/tools/CharsetMapping/IBM1383.nr - make/tools/CharsetMapping/IBM273.c2b - make/tools/CharsetMapping/IBM273.map - make/tools/CharsetMapping/IBM273.nr - make/tools/CharsetMapping/IBM277.c2b - make/tools/CharsetMapping/IBM277.map - make/tools/CharsetMapping/IBM277.nr - make/tools/CharsetMapping/IBM278.c2b - make/tools/CharsetMapping/IBM278.map - make/tools/CharsetMapping/IBM278.nr - make/tools/CharsetMapping/IBM280.c2b - make/tools/CharsetMapping/IBM280.map - make/tools/CharsetMapping/IBM280.nr - make/tools/CharsetMapping/IBM284.c2b - make/tools/CharsetMapping/IBM284.map - make/tools/CharsetMapping/IBM284.nr - make/tools/CharsetMapping/IBM285.c2b - make/tools/CharsetMapping/IBM285.map - make/tools/CharsetMapping/IBM285.nr - make/tools/CharsetMapping/IBM290.c2b - make/tools/CharsetMapping/IBM290.map - make/tools/CharsetMapping/IBM297.c2b - make/tools/CharsetMapping/IBM297.map - make/tools/CharsetMapping/IBM297.nr - make/tools/CharsetMapping/IBM300.c2b - make/tools/CharsetMapping/IBM300.map - make/tools/CharsetMapping/IBM420.c2b - make/tools/CharsetMapping/IBM420.map - make/tools/CharsetMapping/IBM420.nr - make/tools/CharsetMapping/IBM424.c2b - make/tools/CharsetMapping/IBM424.map - make/tools/CharsetMapping/IBM424.nr - make/tools/CharsetMapping/IBM437.map - make/tools/CharsetMapping/IBM500.c2b - make/tools/CharsetMapping/IBM500.map - make/tools/CharsetMapping/IBM500.nr - make/tools/CharsetMapping/IBM737.map - make/tools/CharsetMapping/IBM775.map - make/tools/CharsetMapping/IBM833.c2b - make/tools/CharsetMapping/IBM833.map - make/tools/CharsetMapping/IBM838.c2b - make/tools/CharsetMapping/IBM838.map - make/tools/CharsetMapping/IBM838.nr - make/tools/CharsetMapping/IBM850.map - make/tools/CharsetMapping/IBM852.map - make/tools/CharsetMapping/IBM855.map - make/tools/CharsetMapping/IBM856.map - make/tools/CharsetMapping/IBM857.map - make/tools/CharsetMapping/IBM858.map - make/tools/CharsetMapping/IBM860.map - make/tools/CharsetMapping/IBM861.map - make/tools/CharsetMapping/IBM862.map - make/tools/CharsetMapping/IBM863.map - make/tools/CharsetMapping/IBM864.map - make/tools/CharsetMapping/IBM865.map - make/tools/CharsetMapping/IBM866.map - make/tools/CharsetMapping/IBM868.map - make/tools/CharsetMapping/IBM869.map - make/tools/CharsetMapping/IBM870.c2b - make/tools/CharsetMapping/IBM870.map - make/tools/CharsetMapping/IBM870.nr - make/tools/CharsetMapping/IBM871.c2b - make/tools/CharsetMapping/IBM871.map - make/tools/CharsetMapping/IBM871.nr - make/tools/CharsetMapping/IBM874.map - make/tools/CharsetMapping/IBM874.nr - make/tools/CharsetMapping/IBM875.c2b - make/tools/CharsetMapping/IBM875.map - make/tools/CharsetMapping/IBM875.nr - make/tools/CharsetMapping/IBM918.c2b - make/tools/CharsetMapping/IBM918.map - make/tools/CharsetMapping/IBM918.nr - make/tools/CharsetMapping/IBM921.map - make/tools/CharsetMapping/IBM922.map - make/tools/CharsetMapping/IBM930.c2b - make/tools/CharsetMapping/IBM930.map - make/tools/CharsetMapping/IBM930.nr - make/tools/CharsetMapping/IBM933.c2b - make/tools/CharsetMapping/IBM933.map - make/tools/CharsetMapping/IBM935.c2b - make/tools/CharsetMapping/IBM935.map - make/tools/CharsetMapping/IBM935.nr - make/tools/CharsetMapping/IBM937.c2b - make/tools/CharsetMapping/IBM937.map - make/tools/CharsetMapping/IBM937.nr - make/tools/CharsetMapping/IBM939.c2b - make/tools/CharsetMapping/IBM939.map - make/tools/CharsetMapping/IBM939.nr - make/tools/CharsetMapping/IBM942.c2b - make/tools/CharsetMapping/IBM942.map - make/tools/CharsetMapping/IBM943.map - make/tools/CharsetMapping/IBM943.nr - make/tools/CharsetMapping/IBM948.c2b - make/tools/CharsetMapping/IBM948.map - make/tools/CharsetMapping/IBM949.map - make/tools/CharsetMapping/IBM950.c2b - make/tools/CharsetMapping/IBM950.map - make/tools/CharsetMapping/IBM970.c2b - make/tools/CharsetMapping/IBM970.map - make/tools/CharsetMapping/ISO_8859_11.map - make/tools/CharsetMapping/ISO_8859_13.map - make/tools/CharsetMapping/ISO_8859_15.map - make/tools/CharsetMapping/ISO_8859_2.map - make/tools/CharsetMapping/ISO_8859_3.map - make/tools/CharsetMapping/ISO_8859_4.map - make/tools/CharsetMapping/ISO_8859_5.map - make/tools/CharsetMapping/ISO_8859_6.map - make/tools/CharsetMapping/ISO_8859_7.map - make/tools/CharsetMapping/ISO_8859_8.map - make/tools/CharsetMapping/ISO_8859_9.map - make/tools/CharsetMapping/JIS_X_0201.c2b - make/tools/CharsetMapping/JIS_X_0201.map - make/tools/CharsetMapping/JIS_X_0208.map - make/tools/CharsetMapping/JIS_X_0208_MS5022X.c2b - make/tools/CharsetMapping/JIS_X_0208_MS5022X.map - make/tools/CharsetMapping/JIS_X_0208_MS932.map - make/tools/CharsetMapping/JIS_X_0208_MS932.nr - make/tools/CharsetMapping/JIS_X_0208_Solaris.map - make/tools/CharsetMapping/JIS_X_0208_Solaris.nr - make/tools/CharsetMapping/JIS_X_0212.map - make/tools/CharsetMapping/JIS_X_0212_MS5022X.map - make/tools/CharsetMapping/JIS_X_0212_Solaris.map - make/tools/CharsetMapping/JIS_X_0212_Solaris.nr - make/tools/CharsetMapping/Johab.map - make/tools/CharsetMapping/KOI8_R.map - make/tools/CharsetMapping/KOI8_U.map - make/tools/CharsetMapping/MS1250.map - make/tools/CharsetMapping/MS1251.map - make/tools/CharsetMapping/MS1252.map - make/tools/CharsetMapping/MS1253.map - make/tools/CharsetMapping/MS1254.map - make/tools/CharsetMapping/MS1255.map - make/tools/CharsetMapping/MS1256.map - make/tools/CharsetMapping/MS1257.map - make/tools/CharsetMapping/MS1258.map - make/tools/CharsetMapping/MS874.map - make/tools/CharsetMapping/MS932.c2b - make/tools/CharsetMapping/MS932.map - make/tools/CharsetMapping/MS932.nr - make/tools/CharsetMapping/MS936.map - make/tools/CharsetMapping/MS949.map - make/tools/CharsetMapping/MS950.map - make/tools/CharsetMapping/MS950.nr - make/tools/CharsetMapping/MacArabic.map - make/tools/CharsetMapping/MacCentralEurope.map - make/tools/CharsetMapping/MacCroatian.map - make/tools/CharsetMapping/MacCyrillic.map - make/tools/CharsetMapping/MacDingbat.map - make/tools/CharsetMapping/MacGreek.map - make/tools/CharsetMapping/MacHebrew.map - make/tools/CharsetMapping/MacIceland.map - make/tools/CharsetMapping/MacRoman.map - make/tools/CharsetMapping/MacRomania.map - make/tools/CharsetMapping/MacSymbol.map - make/tools/CharsetMapping/MacThai.map - make/tools/CharsetMapping/MacTurkish.map - make/tools/CharsetMapping/MacUkraine.map - make/tools/CharsetMapping/Makefile - make/tools/CharsetMapping/PCK.c2b - make/tools/CharsetMapping/PCK.map - make/tools/CharsetMapping/PCK.nr - make/tools/CharsetMapping/SJIS.c2b - make/tools/CharsetMapping/SJIS.map - make/tools/CharsetMapping/SingleByte-X.java.template - make/tools/CharsetMapping/TIS_620.map - make/tools/CharsetMapping/dbcs - make/tools/CharsetMapping/euc_tw.map - make/tools/CharsetMapping/extsbcs - make/tools/CharsetMapping/sbcs - make/tools/CharsetMapping/sjis0213.map - make/tools/GenerateCharacter/Character.c.template - make/tools/GenerateCharacter/CharacterData00.java.template - make/tools/GenerateCharacter/CharacterData01.java.template - make/tools/GenerateCharacter/CharacterData02.java.template - make/tools/GenerateCharacter/CharacterData0E.java.template - make/tools/GenerateCharacter/CharacterDataLatin1.java.template - make/tools/GenerateCharacter/CharacterDataPrivateUse.java.template - make/tools/GenerateCharacter/CharacterDataUndefined.java.template - make/tools/GenerateCharacter/Makefile - make/tools/GenerateCharacter/check_class.c.template - make/tools/Makefile - make/tools/README.txt - make/tools/UnicodeData/PropList.txt - make/tools/UnicodeData/Scripts.txt - make/tools/UnicodeData/SpecialCasing.txt - make/tools/UnicodeData/UnicodeData.txt - make/tools/UnicodeData/VERSION - make/tools/add_gnu_debuglink/Makefile - make/tools/add_gnu_debuglink/add_gnu_debuglink.c - make/tools/addjsum/Makefile - make/tools/addtorestrictedpkgs/Makefile - make/tools/buildmetaindex/Makefile - make/tools/cldrconverter/Makefile - make/tools/commentchecker/Makefile - make/tools/compile_font_config/Makefile - make/tools/compile_properties/Makefile - make/tools/dir_diff/Makefile - make/tools/dtdbuilder/Makefile - make/tools/dtdbuilder/dtds/HTMLlat1.sgml - make/tools/dtdbuilder/dtds/HTMLspecial.sgml - make/tools/dtdbuilder/dtds/HTMLsymbol.sgml - make/tools/dtdbuilder/dtds/html32.dtd - make/tools/dtdbuilder/dtds/public.map - make/tools/fix_empty_sec_hdr_flags/Makefile - make/tools/fix_empty_sec_hdr_flags/fix_empty_sec_hdr_flags.c - make/tools/freetypecheck/Makefile - make/tools/freetypecheck/freetypecheck.c - make/tools/generate_break_iterator/Makefile - make/tools/generate_nimbus/Makefile - make/tools/generatecurrencydata/Makefile - make/tools/hasher_classes/Makefile - make/tools/jarreorder/Makefile - make/tools/jarsplit/Makefile - make/tools/jdwpgen/Makefile - make/tools/makeclasslist/Makefile - make/tools/manifest.mf - make/tools/msys_build_scripts/dospath.sh - make/tools/msys_build_scripts/dospath.vbs - make/tools/reorder/Makefile - make/tools/reorder/tests/Exit.java - make/tools/reorder/tests/Hello.java - make/tools/reorder/tests/IntToString.java - make/tools/reorder/tests/JHello.java - make/tools/reorder/tests/LoadFrame.java - make/tools/reorder/tests/LoadJFrame.java - make/tools/reorder/tests/LoadToolkit.java - make/tools/reorder/tests/Null.java - make/tools/reorder/tests/Sleep.java - make/tools/reorder/tools/Combine.java - make/tools/reorder/tools/MaxTime.java - make/tools/reorder/tools/mcount.c - make/tools/reorder/tools/remove_mcount.c - make/tools/reorder/tools/util-i586.il - make/tools/reorder/tools/util-sparc.il - make/tools/reorder/tools/util-sparcv9.il - make/tools/sharing/README.txt - make/tools/sharing/classlist.linux - make/tools/sharing/classlist.macosx - make/tools/sharing/classlist.solaris - make/tools/sharing/classlist.windows - make/tools/sharing/tests/GHello.java - make/tools/sharing/tests/Hello.java - make/tools/sharing/tests/JHello.java - make/tools/spp/Makefile - make/tools/src/build/tools/addjsum/AddJsum.java - make/tools/src/build/tools/addtorestrictedpkgs/AddToRestrictedPkgs.java - make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java - make/tools/src/build/tools/charsetmapping/DBCS.java - make/tools/src/build/tools/charsetmapping/EUC_TW.java - make/tools/src/build/tools/charsetmapping/HKSCS.java - make/tools/src/build/tools/charsetmapping/JIS0213.java - make/tools/src/build/tools/charsetmapping/Main.java - make/tools/src/build/tools/charsetmapping/SBCS.java - make/tools/src/build/tools/charsetmapping/Utils.java - make/tools/src/build/tools/classfile/RemoveMethods.java - make/tools/src/build/tools/cldrconverter/AbstractLDMLHandler.java - make/tools/src/build/tools/cldrconverter/Bundle.java - make/tools/src/build/tools/cldrconverter/BundleGenerator.java - make/tools/src/build/tools/cldrconverter/CLDRConverter.java - make/tools/src/build/tools/cldrconverter/CalendarType.java - make/tools/src/build/tools/cldrconverter/Container.java - make/tools/src/build/tools/cldrconverter/CopyrightHeaders.java - make/tools/src/build/tools/cldrconverter/Entry.java - make/tools/src/build/tools/cldrconverter/IgnoredContainer.java - make/tools/src/build/tools/cldrconverter/KeyContainer.java - make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java - make/tools/src/build/tools/cldrconverter/MetaZonesParseHandler.java - make/tools/src/build/tools/cldrconverter/NumberingSystemsParseHandler.java - make/tools/src/build/tools/cldrconverter/ResourceBundleGenerator.java - make/tools/src/build/tools/cldrconverter/StringArrayElement.java - make/tools/src/build/tools/cldrconverter/StringArrayEntry.java - make/tools/src/build/tools/cldrconverter/StringEntry.java - make/tools/src/build/tools/cldrconverter/SupplementDataParseHandler.java - make/tools/src/build/tools/commentchecker/CommentChecker.java - make/tools/src/build/tools/compilefontconfig/CompileFontConfig.java - make/tools/src/build/tools/compileproperties/CompileProperties.java - make/tools/src/build/tools/deps/CheckDeps.java - make/tools/src/build/tools/deps/refs.allowed - make/tools/src/build/tools/dirdiff/DirDiff.java - make/tools/src/build/tools/dtdbuilder/DTDBuilder.java - make/tools/src/build/tools/dtdbuilder/DTDInputStream.java - make/tools/src/build/tools/dtdbuilder/DTDParser.java - make/tools/src/build/tools/dtdbuilder/PublicMapping.java - make/tools/src/build/tools/dtdbuilder/README.txt - make/tools/src/build/tools/generatebreakiteratordata/BreakIteratorRBControl.java - make/tools/src/build/tools/generatebreakiteratordata/CharSet.java - make/tools/src/build/tools/generatebreakiteratordata/CharacterCategory.java - make/tools/src/build/tools/generatebreakiteratordata/DictionaryBasedBreakIteratorBuilder.java - make/tools/src/build/tools/generatebreakiteratordata/GenerateBreakIteratorData.java - make/tools/src/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java - make/tools/src/build/tools/generatebreakiteratordata/SupplementaryCharacterData.java - make/tools/src/build/tools/generatecharacter/CharacterName.java - make/tools/src/build/tools/generatecharacter/CharacterScript.java - make/tools/src/build/tools/generatecharacter/GenerateCharacter.java - make/tools/src/build/tools/generatecharacter/PrintCharacterRanges.java - make/tools/src/build/tools/generatecharacter/PropList.java - make/tools/src/build/tools/generatecharacter/SpecialCaseMap.java - make/tools/src/build/tools/generatecharacter/UnicodeSpec.java - make/tools/src/build/tools/generatecharacter/Utility.java - make/tools/src/build/tools/generatecurrencydata/GenerateCurrencyData.java - make/tools/src/build/tools/generatenimbus/AbstractGradient.java - make/tools/src/build/tools/generatenimbus/Border.java - make/tools/src/build/tools/generatenimbus/Canvas.java - make/tools/src/build/tools/generatenimbus/ComponentColor.java - make/tools/src/build/tools/generatenimbus/Dimension.java - make/tools/src/build/tools/generatenimbus/Ellipse.java - make/tools/src/build/tools/generatenimbus/Generator.java - make/tools/src/build/tools/generatenimbus/Gradient.java - make/tools/src/build/tools/generatenimbus/GradientStop.java - make/tools/src/build/tools/generatenimbus/Insets.java - make/tools/src/build/tools/generatenimbus/Layer.java - make/tools/src/build/tools/generatenimbus/Matte.java - make/tools/src/build/tools/generatenimbus/ObjectFactory.java - make/tools/src/build/tools/generatenimbus/Paint.java - make/tools/src/build/tools/generatenimbus/PainterGenerator.java - make/tools/src/build/tools/generatenimbus/Path.java - make/tools/src/build/tools/generatenimbus/Point.java - make/tools/src/build/tools/generatenimbus/RadialGradient.java - make/tools/src/build/tools/generatenimbus/Rectangle.java - make/tools/src/build/tools/generatenimbus/Shape.java - make/tools/src/build/tools/generatenimbus/SynthModel.java - make/tools/src/build/tools/generatenimbus/Typeface.java - make/tools/src/build/tools/generatenimbus/UIColor.java - make/tools/src/build/tools/generatenimbus/UIComponent.java - make/tools/src/build/tools/generatenimbus/UIDefault.java - make/tools/src/build/tools/generatenimbus/UIFont.java - make/tools/src/build/tools/generatenimbus/UIIconRegion.java - make/tools/src/build/tools/generatenimbus/UIProperty.java - make/tools/src/build/tools/generatenimbus/UIRegion.java - make/tools/src/build/tools/generatenimbus/UIState.java - make/tools/src/build/tools/generatenimbus/UIStateType.java - make/tools/src/build/tools/generatenimbus/UIStyle.java - make/tools/src/build/tools/generatenimbus/Utils.java - make/tools/src/build/tools/hasher/Hasher.java - make/tools/src/build/tools/jarreorder/JarReorder.java - make/tools/src/build/tools/jarsplit/JarSplit.java - make/tools/src/build/tools/jdwpgen/AbstractCommandNode.java - make/tools/src/build/tools/jdwpgen/AbstractGroupNode.java - make/tools/src/build/tools/jdwpgen/AbstractNamedNode.java - make/tools/src/build/tools/jdwpgen/AbstractSimpleNode.java - make/tools/src/build/tools/jdwpgen/AbstractSimpleTypeNode.java - make/tools/src/build/tools/jdwpgen/AbstractTypeListNode.java - make/tools/src/build/tools/jdwpgen/AbstractTypeNode.java - make/tools/src/build/tools/jdwpgen/AltNode.java - make/tools/src/build/tools/jdwpgen/ArrayObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/ArrayRegionTypeNode.java - make/tools/src/build/tools/jdwpgen/ArrayTypeNode.java - make/tools/src/build/tools/jdwpgen/BooleanTypeNode.java - make/tools/src/build/tools/jdwpgen/ByteTypeNode.java - make/tools/src/build/tools/jdwpgen/ClassLoaderObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/ClassObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/ClassTypeNode.java - make/tools/src/build/tools/jdwpgen/CommandNode.java - make/tools/src/build/tools/jdwpgen/CommandSetNode.java - make/tools/src/build/tools/jdwpgen/CommentNode.java - make/tools/src/build/tools/jdwpgen/ConstantNode.java - make/tools/src/build/tools/jdwpgen/ConstantSetNode.java - make/tools/src/build/tools/jdwpgen/Context.java - make/tools/src/build/tools/jdwpgen/ErrorNode.java - make/tools/src/build/tools/jdwpgen/ErrorSetNode.java - make/tools/src/build/tools/jdwpgen/EventNode.java - make/tools/src/build/tools/jdwpgen/FieldTypeNode.java - make/tools/src/build/tools/jdwpgen/FrameTypeNode.java - make/tools/src/build/tools/jdwpgen/GroupNode.java - make/tools/src/build/tools/jdwpgen/IntTypeNode.java - make/tools/src/build/tools/jdwpgen/InterfaceTypeNode.java - make/tools/src/build/tools/jdwpgen/LocationTypeNode.java - make/tools/src/build/tools/jdwpgen/LongTypeNode.java - make/tools/src/build/tools/jdwpgen/Main.java - make/tools/src/build/tools/jdwpgen/MethodTypeNode.java - make/tools/src/build/tools/jdwpgen/NameNode.java - make/tools/src/build/tools/jdwpgen/NameValueNode.java - make/tools/src/build/tools/jdwpgen/Node.java - make/tools/src/build/tools/jdwpgen/ObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/OutNode.java - make/tools/src/build/tools/jdwpgen/Parse.java - make/tools/src/build/tools/jdwpgen/ReferenceIDTypeNode.java - make/tools/src/build/tools/jdwpgen/ReferenceTypeNode.java - make/tools/src/build/tools/jdwpgen/RepeatNode.java - make/tools/src/build/tools/jdwpgen/ReplyNode.java - make/tools/src/build/tools/jdwpgen/RootNode.java - make/tools/src/build/tools/jdwpgen/SelectNode.java - make/tools/src/build/tools/jdwpgen/StringObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/StringTypeNode.java - make/tools/src/build/tools/jdwpgen/TaggedObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/ThreadGroupObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/ThreadObjectTypeNode.java - make/tools/src/build/tools/jdwpgen/TypeNode.java - make/tools/src/build/tools/jdwpgen/UntaggedValueTypeNode.java - make/tools/src/build/tools/jdwpgen/ValueTypeNode.java - make/tools/src/build/tools/makeclasslist/MakeClasslist.java - make/tools/src/build/tools/spp/Spp.java - make/tools/src/build/tools/stripproperties/StripProperties.java - make/tools/src/build/tools/tzdb/ChronoField.java - make/tools/src/build/tools/tzdb/DateTimeException.java - make/tools/src/build/tools/tzdb/LocalDate.java - make/tools/src/build/tools/tzdb/LocalDateTime.java - make/tools/src/build/tools/tzdb/LocalTime.java - make/tools/src/build/tools/tzdb/TimeDefinition.java - make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java - make/tools/src/build/tools/tzdb/Utils.java - make/tools/src/build/tools/tzdb/ZoneOffset.java - make/tools/src/build/tools/tzdb/ZoneOffsetTransition.java - make/tools/src/build/tools/tzdb/ZoneOffsetTransitionRule.java - make/tools/src/build/tools/tzdb/ZoneRules.java - make/tools/src/build/tools/tzdb/ZoneRulesBuilder.java - make/tools/strip_properties/Makefile - make/tools/swing-beans/DocBeanInfo.java - make/tools/swing-beans/GenDocletBeanInfo.java - make/tools/swing-beans/GenSwingBeanInfo.java - make/tools/swing-beans/SwingBeanInfo.template - make/tools/swing-beans/beaninfo/images/AbstractButtonColor16.gif - make/tools/swing-beans/beaninfo/images/BorderColor16.gif - make/tools/swing-beans/beaninfo/images/BoxColor16.gif - make/tools/swing-beans/beaninfo/images/BoxColor32.gif - make/tools/swing-beans/beaninfo/images/BoxMono16.gif - make/tools/swing-beans/beaninfo/images/BoxMono32.gif - make/tools/swing-beans/beaninfo/images/JAppletColor16.gif - make/tools/swing-beans/beaninfo/images/JAppletColor32.gif - make/tools/swing-beans/beaninfo/images/JAppletMono16.gif - make/tools/swing-beans/beaninfo/images/JAppletMono32.gif - make/tools/swing-beans/beaninfo/images/JButtonColor16.gif - make/tools/swing-beans/beaninfo/images/JButtonColor32.gif - make/tools/swing-beans/beaninfo/images/JButtonMono16.gif - make/tools/swing-beans/beaninfo/images/JButtonMono32.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxColor16.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxColor32.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxMenuItemColor16.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxMenuItemColor32.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxMenuItemMono16.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxMenuItemMono32.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxMono16.gif - make/tools/swing-beans/beaninfo/images/JCheckBoxMono32.gif - make/tools/swing-beans/beaninfo/images/JColorChooserColor16.gif - make/tools/swing-beans/beaninfo/images/JColorChooserColor32.gif - make/tools/swing-beans/beaninfo/images/JColorChooserMono16.gif - make/tools/swing-beans/beaninfo/images/JColorChooserMono32.gif - make/tools/swing-beans/beaninfo/images/JComboBoxColor16.gif - make/tools/swing-beans/beaninfo/images/JComboBoxColor32.gif - make/tools/swing-beans/beaninfo/images/JComboBoxMono16.gif - make/tools/swing-beans/beaninfo/images/JComboBoxMono32.gif - make/tools/swing-beans/beaninfo/images/JComponentColor16.gif - make/tools/swing-beans/beaninfo/images/JDesktopPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JDesktopPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JDesktopPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JDesktopPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JDialogColor16.gif - make/tools/swing-beans/beaninfo/images/JDialogColor32.gif - make/tools/swing-beans/beaninfo/images/JDialogMono16.gif - make/tools/swing-beans/beaninfo/images/JDialogMono32.gif - make/tools/swing-beans/beaninfo/images/JEditorPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JEditorPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JEditorPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JEditorPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JFileChooserColor16.gif - make/tools/swing-beans/beaninfo/images/JFileChooserColor32.gif - make/tools/swing-beans/beaninfo/images/JFileChooserMono16.gif - make/tools/swing-beans/beaninfo/images/JFileChooserMono32.gif - make/tools/swing-beans/beaninfo/images/JFormattedTextFieldColor16.gif - make/tools/swing-beans/beaninfo/images/JFormattedTextFieldColor32.gif - make/tools/swing-beans/beaninfo/images/JFormattedTextFieldMono16.gif - make/tools/swing-beans/beaninfo/images/JFormattedTextFieldMono32.gif - make/tools/swing-beans/beaninfo/images/JFrameColor16.gif - make/tools/swing-beans/beaninfo/images/JFrameColor32.gif - make/tools/swing-beans/beaninfo/images/JFrameMono16.gif - make/tools/swing-beans/beaninfo/images/JFrameMono32.gif - make/tools/swing-beans/beaninfo/images/JInternalFrameColor16.gif - make/tools/swing-beans/beaninfo/images/JInternalFrameColor32.gif - make/tools/swing-beans/beaninfo/images/JInternalFrameMono16.gif - make/tools/swing-beans/beaninfo/images/JInternalFrameMono32.gif - make/tools/swing-beans/beaninfo/images/JLabelColor16.gif - make/tools/swing-beans/beaninfo/images/JLabelColor32.gif - make/tools/swing-beans/beaninfo/images/JLabelMono16.gif - make/tools/swing-beans/beaninfo/images/JLabelMono32.gif - make/tools/swing-beans/beaninfo/images/JLayeredPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JLayeredPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JLayeredPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JLayeredPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JListColor16.gif - make/tools/swing-beans/beaninfo/images/JListColor32.gif - make/tools/swing-beans/beaninfo/images/JListMono16.gif - make/tools/swing-beans/beaninfo/images/JListMono32.gif - make/tools/swing-beans/beaninfo/images/JMenuBarColor16.gif - make/tools/swing-beans/beaninfo/images/JMenuBarColor32.gif - make/tools/swing-beans/beaninfo/images/JMenuBarMono16.gif - make/tools/swing-beans/beaninfo/images/JMenuBarMono32.gif - make/tools/swing-beans/beaninfo/images/JMenuColor16.gif - make/tools/swing-beans/beaninfo/images/JMenuColor32.gif - make/tools/swing-beans/beaninfo/images/JMenuItemColor16.gif - make/tools/swing-beans/beaninfo/images/JMenuItemColor32.gif - make/tools/swing-beans/beaninfo/images/JMenuItemMono16.gif - make/tools/swing-beans/beaninfo/images/JMenuItemMono32.gif - make/tools/swing-beans/beaninfo/images/JMenuMono16.gif - make/tools/swing-beans/beaninfo/images/JMenuMono32.gif - make/tools/swing-beans/beaninfo/images/JOptionPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JOptionPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JOptionPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JOptionPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JPanelColor16.gif - make/tools/swing-beans/beaninfo/images/JPanelColor32.gif - make/tools/swing-beans/beaninfo/images/JPanelMono16.gif - make/tools/swing-beans/beaninfo/images/JPanelMono32.gif - make/tools/swing-beans/beaninfo/images/JPasswordFieldColor16.gif - make/tools/swing-beans/beaninfo/images/JPasswordFieldColor32.gif - make/tools/swing-beans/beaninfo/images/JPasswordFieldMono16.gif - make/tools/swing-beans/beaninfo/images/JPasswordFieldMono32.gif - make/tools/swing-beans/beaninfo/images/JPopupMenuColor16.gif - make/tools/swing-beans/beaninfo/images/JPopupMenuColor32.gif - make/tools/swing-beans/beaninfo/images/JPopupMenuMono16.gif - make/tools/swing-beans/beaninfo/images/JPopupMenuMono32.gif - make/tools/swing-beans/beaninfo/images/JProgressBarColor16.gif - make/tools/swing-beans/beaninfo/images/JProgressBarColor32.gif - make/tools/swing-beans/beaninfo/images/JProgressBarMono16.gif - make/tools/swing-beans/beaninfo/images/JProgressBarMono32.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonColor16.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonColor32.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonMenuItemColor16.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonMenuItemColor32.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonMenuItemMono16.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonMenuItemMono32.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonMono16.gif - make/tools/swing-beans/beaninfo/images/JRadioButtonMono32.gif - make/tools/swing-beans/beaninfo/images/JRootPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JRootPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JRootPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JRootPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JScrollBarColor16.gif - make/tools/swing-beans/beaninfo/images/JScrollBarColor32.gif - make/tools/swing-beans/beaninfo/images/JScrollBarMono16.gif - make/tools/swing-beans/beaninfo/images/JScrollBarMono32.gif - make/tools/swing-beans/beaninfo/images/JScrollPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JScrollPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JScrollPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JScrollPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JSeparatorColor16.gif - make/tools/swing-beans/beaninfo/images/JSeparatorColor32.gif - make/tools/swing-beans/beaninfo/images/JSeparatorMono16.gif - make/tools/swing-beans/beaninfo/images/JSeparatorMono32.gif - make/tools/swing-beans/beaninfo/images/JSliderColor16.gif - make/tools/swing-beans/beaninfo/images/JSliderColor32.gif - make/tools/swing-beans/beaninfo/images/JSliderMono16.gif - make/tools/swing-beans/beaninfo/images/JSliderMono32.gif - make/tools/swing-beans/beaninfo/images/JSpinnerColor16.gif - make/tools/swing-beans/beaninfo/images/JSpinnerColor32.gif - make/tools/swing-beans/beaninfo/images/JSpinnerMono16.gif - make/tools/swing-beans/beaninfo/images/JSpinnerMono32.gif - make/tools/swing-beans/beaninfo/images/JSplitPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JSplitPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JSplitPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JSplitPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JTabbedPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JTabbedPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JTabbedPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JTabbedPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JTableColor16.gif - make/tools/swing-beans/beaninfo/images/JTableColor32.gif - make/tools/swing-beans/beaninfo/images/JTableMono16.gif - make/tools/swing-beans/beaninfo/images/JTableMono32.gif - make/tools/swing-beans/beaninfo/images/JTextAreaColor16.gif - make/tools/swing-beans/beaninfo/images/JTextAreaColor32.gif - make/tools/swing-beans/beaninfo/images/JTextAreaMono16.gif - make/tools/swing-beans/beaninfo/images/JTextAreaMono32.gif - make/tools/swing-beans/beaninfo/images/JTextFieldColor16.gif - make/tools/swing-beans/beaninfo/images/JTextFieldColor32.gif - make/tools/swing-beans/beaninfo/images/JTextFieldMono16.gif - make/tools/swing-beans/beaninfo/images/JTextFieldMono32.gif - make/tools/swing-beans/beaninfo/images/JTextPaneColor16.gif - make/tools/swing-beans/beaninfo/images/JTextPaneColor32.gif - make/tools/swing-beans/beaninfo/images/JTextPaneMono16.gif - make/tools/swing-beans/beaninfo/images/JTextPaneMono32.gif - make/tools/swing-beans/beaninfo/images/JToggleButtonColor16.gif - make/tools/swing-beans/beaninfo/images/JToggleButtonColor32.gif - make/tools/swing-beans/beaninfo/images/JToggleButtonMono16.gif - make/tools/swing-beans/beaninfo/images/JToggleButtonMono32.gif - make/tools/swing-beans/beaninfo/images/JToolBarColor16.gif - make/tools/swing-beans/beaninfo/images/JToolBarColor32.gif - make/tools/swing-beans/beaninfo/images/JToolBarMono16.gif - make/tools/swing-beans/beaninfo/images/JToolBarMono32.gif - make/tools/swing-beans/beaninfo/images/JTreeColor16.gif - make/tools/swing-beans/beaninfo/images/JTreeColor32.gif - make/tools/swing-beans/beaninfo/images/JTreeMono16.gif - make/tools/swing-beans/beaninfo/images/JTreeMono32.gif - make/tools/swing-beans/beaninfo/images/JViewportColor16.gif - make/tools/swing-beans/beaninfo/images/JViewportColor32.gif - make/tools/swing-beans/beaninfo/images/JViewportMono16.gif - make/tools/swing-beans/beaninfo/images/JViewportMono32.gif - make/tools/swing-beans/beaninfo/images/JWindowColor16.gif - make/tools/swing-beans/beaninfo/images/JWindowColor32.gif - make/tools/swing-beans/beaninfo/images/JWindowMono16.gif - make/tools/swing-beans/beaninfo/images/JWindowMono32.gif - make/tools/swing-beans/javax/swing/SwingBeanInfoBase.java - make/tools/swing-beans/sun/swing/BeanInfoUtils.java - make/tools/tzdb/Makefile - makefiles/BuildJdk.gmk - makefiles/Bundles.gmk - makefiles/CompileDemos.gmk - makefiles/CompileJavaClasses.gmk - makefiles/CompileLaunchers.gmk - makefiles/CompileNativeLibraries.gmk - makefiles/CopyFiles.gmk - makefiles/CopyIntoClasses.gmk - makefiles/CopySamples.gmk - makefiles/CreateJars.gmk - makefiles/CreateSecurityJars.gmk - makefiles/GenerateClasses.gmk - makefiles/GenerateData.gmk - makefiles/GenerateSources.gmk - makefiles/Images.gmk - makefiles/Import.gmk - makefiles/Makefile - makefiles/PatchList.solaris - makefiles/ProfileNames.gmk - makefiles/Profiles.gmk - makefiles/Setup.gmk - makefiles/SignJars.gmk - makefiles/Tools.gmk - makefiles/gendata/GendataBreakIterator.gmk - makefiles/gendata/GendataFontConfig.gmk - makefiles/gendata/GendataHtml32dtd.gmk - makefiles/gendata/GendataTZDB.gmk - makefiles/gendata/GendataTimeZone.gmk - makefiles/gensrc/GensrcBuffer.gmk - makefiles/gensrc/GensrcCLDR.gmk - makefiles/gensrc/GensrcCharacterData.gmk - makefiles/gensrc/GensrcCharsetCoder.gmk - makefiles/gensrc/GensrcCharsetMapping.gmk - makefiles/gensrc/GensrcExceptions.gmk - makefiles/gensrc/GensrcIcons.gmk - makefiles/gensrc/GensrcJDWP.gmk - makefiles/gensrc/GensrcJObjC.gmk - makefiles/gensrc/GensrcLocaleDataMetaInfo.gmk - makefiles/gensrc/GensrcMisc.gmk - makefiles/gensrc/GensrcProperties.gmk - makefiles/gensrc/GensrcSwing.gmk - makefiles/gensrc/GensrcX11Wrappers.gmk - makefiles/jpda/jdwp/jdwp.spec - makefiles/jprt.gmk - makefiles/jprt.properties - makefiles/lib/Awt2dLibraries.gmk - makefiles/lib/CoreLibraries.gmk - makefiles/lib/NetworkingLibraries.gmk - makefiles/lib/NioLibraries.gmk - makefiles/lib/PlatformLibraries.gmk - makefiles/lib/SecurityLibraries.gmk - makefiles/lib/ServiceabilityLibraries.gmk - makefiles/lib/SoundLibraries.gmk - makefiles/mapfiles/launchers/mapfile-sparc - makefiles/mapfiles/launchers/mapfile-sparcv9 - makefiles/mapfiles/launchers/mapfile-x86 - makefiles/mapfiles/launchers/mapfile-x86_64 - makefiles/mapfiles/libattach/mapfile-linux - makefiles/mapfiles/libattach/mapfile-solaris - makefiles/mapfiles/libattach/reorder-windows-x86 - makefiles/mapfiles/libattach/reorder-windows-x86_64 - makefiles/mapfiles/libawt/mapfile-mawt-vers - makefiles/mapfiles/libawt/mapfile-vers - makefiles/mapfiles/libawt/mapfile-vers-linux - makefiles/mapfiles/libawt_headless/mapfile-vers - makefiles/mapfiles/libawt_headless/reorder-sparc - makefiles/mapfiles/libawt_headless/reorder-sparcv9 - makefiles/mapfiles/libawt_headless/reorder-x86 - makefiles/mapfiles/libawt_xawt/mapfile-vers - makefiles/mapfiles/libdcpr/mapfile-vers - makefiles/mapfiles/libdt_socket/mapfile-vers - makefiles/mapfiles/libfontmanager/mapfile-vers - makefiles/mapfiles/libfontmanager/mapfile-vers.openjdk - makefiles/mapfiles/libhprof/mapfile-vers - makefiles/mapfiles/libinstrument/mapfile-vers - makefiles/mapfiles/libj2gss/mapfile-vers - makefiles/mapfiles/libj2pcsc/mapfile-vers - makefiles/mapfiles/libj2pkcs11/mapfile-vers - makefiles/mapfiles/libj2ucrypto/mapfile-vers - makefiles/mapfiles/libjaas/mapfile-vers - makefiles/mapfiles/libjava/mapfile-vers - makefiles/mapfiles/libjava/reorder-sparc - makefiles/mapfiles/libjava/reorder-sparcv9 - makefiles/mapfiles/libjava/reorder-x86 - makefiles/mapfiles/libjava_crw_demo/mapfile-vers - makefiles/mapfiles/libjawt/mapfile-vers - makefiles/mapfiles/libjdga/mapfile-vers - makefiles/mapfiles/libjdwp/mapfile-vers - makefiles/mapfiles/libjfr/mapfile-vers - makefiles/mapfiles/libjli/mapfile-vers - makefiles/mapfiles/libjpeg/mapfile-vers - makefiles/mapfiles/libjpeg/mapfile-vers-closed - makefiles/mapfiles/libjpeg/reorder-sparc - makefiles/mapfiles/libjpeg/reorder-sparcv9 - makefiles/mapfiles/libjpeg/reorder-x86 - makefiles/mapfiles/libjsdt/mapfile-vers - makefiles/mapfiles/libjsound/mapfile-vers - makefiles/mapfiles/libjsoundalsa/mapfile-vers - makefiles/mapfiles/libkcms/mapfile-vers - makefiles/mapfiles/liblcms/mapfile-vers - makefiles/mapfiles/libmanagement/mapfile-vers - makefiles/mapfiles/libmlib_image/mapfile-vers - makefiles/mapfiles/libnet/mapfile-vers - makefiles/mapfiles/libnio/mapfile-linux - makefiles/mapfiles/libnio/mapfile-macosx - makefiles/mapfiles/libnio/mapfile-solaris - makefiles/mapfiles/libnio/reorder-sparc - makefiles/mapfiles/libnio/reorder-sparcv9 - makefiles/mapfiles/libnio/reorder-x86 - makefiles/mapfiles/libnpt/mapfile-vers - makefiles/mapfiles/libsctp/mapfile-vers - makefiles/mapfiles/libsplashscreen/mapfile-vers - makefiles/mapfiles/libsunec/mapfile-vers - makefiles/mapfiles/libt2k/mapfile-vers - makefiles/mapfiles/libunpack/mapfile-vers - makefiles/mapfiles/libunpack/mapfile-vers-unpack200 - makefiles/mapfiles/libverify/mapfile-vers - makefiles/mapfiles/libverify/reorder-sparc - makefiles/mapfiles/libverify/reorder-sparcv9 - makefiles/mapfiles/libverify/reorder-x86 - makefiles/mapfiles/libzip/mapfile-vers - makefiles/mapfiles/libzip/reorder-sparc - makefiles/mapfiles/libzip/reorder-sparcv9 - makefiles/mapfiles/libzip/reorder-x86 - makefiles/profile-includes.txt - makefiles/profile-rtjar-includes.txt - makefiles/scripts/addNotices.sh - makefiles/scripts/genCharsetProvider.sh - makefiles/scripts/genExceptions.sh - makefiles/scripts/localelist.sh - makefiles/sun/awt/ToBin.java - makefiles/sun/osxapp/ToBin.java From magnus.ihse.bursie at oracle.com Mon Nov 18 09:54:44 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:54:44 +0000 Subject: hg: jdk8/tl/jaxws: 8027566: Remove the old build system Message-ID: <20131118175449.7656262670@hg.openjdk.java.net> Changeset: 1d1af4ce8eeb Author: ihse Date: 2013-11-04 11:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/1d1af4ce8eeb 8027566: Remove the old build system Reviewed-by: erikj, tbell + make/BuildJaxws.gmk ! make/Makefile - make/jprt.properties - make/scripts/update_src.sh - makefiles/BuildJaxws.gmk - makefiles/Makefile From magnus.ihse.bursie at oracle.com Mon Nov 18 09:55:28 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:55:28 +0000 Subject: hg: jdk8/tl/nashorn: 8027566: Remove the old build system Message-ID: <20131118175530.C4FAE62672@hg.openjdk.java.net> Changeset: 779e155419b8 Author: ihse Date: 2013-11-04 11:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/779e155419b8 8027566: Remove the old build system Reviewed-by: erikj, tbell + make/BuildNashorn.gmk ! make/Makefile - makefiles/BuildNashorn.gmk - makefiles/Makefile From magnus.ihse.bursie at oracle.com Mon Nov 18 09:55:19 2013 From: magnus.ihse.bursie at oracle.com (magnus.ihse.bursie at oracle.com) Date: Mon, 18 Nov 2013 17:55:19 +0000 Subject: hg: jdk8/tl/langtools: 8027566: Remove the old build system Message-ID: <20131118175531.0687062673@hg.openjdk.java.net> Changeset: 8043b9cf31ab Author: ihse Date: 2013-11-04 11:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8043b9cf31ab 8027566: Remove the old build system Reviewed-by: erikj, tbell + make/BuildLangtools.gmk ! make/Makefile - make/jprt.properties - makefiles/BuildLangtools.gmk - makefiles/Makefile From yuri.nesterenko at oracle.com Mon Nov 18 01:50:37 2013 From: yuri.nesterenko at oracle.com (Yuri Nesterenko) Date: Mon, 18 Nov 2013 13:50:37 +0400 Subject: [security dev] [8] Review request for JDK-8028266 : Tidy warnings cleanup for packages java.security/javax.security In-Reply-To: <1550047.PlASO1GmOX@workland> References: <2405806.GIg7MIdCZp@workland> <5284E5B4.3090809@oracle.com> <5285209D.4070304@oracle.com> <1550047.PlASO1GmOX@workland> Message-ID: <5289E2ED.7090405@oracle.com> Let's not create a backlog of stale documentation changes! If I may, I do approve this fix. Thanks, -yan On 11/15/2013 11:40 AM, Sergey Lugovoy wrote: > Hi all, > Please, see to second patch > http://cr.openjdk.java.net/~yan/8028266/webrev.01/ > for > https://bugs.openjdk.java.net/browse/JDK-8028266 > > I removed some extra lines left after

removal, as Sean suggested. > As to the fact why I replaced "

" by "
" - that's because "p"
> element represents a paragraph and cannot contain another block elements
> ("
" or "
") > ( see more http://www.w3.org/TR/html401/struct/text.html#h-9.3.1) > > On Thursday, November 14, 2013 11:12:29 AM Joe Darcy wrote: >> Might just be my limited knowledge of HTML, but I don't understand the >> replacement of

with
in several places like: >> >> --- >> old/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java >> 2013-11-14 07:44:04.878682607 +0000 >> +++ >> new/src/share/classes/javax/security/auth/kerberos/DelegationPermission.java >> 2013-11-14 07:44:04.718682612 +0000 >> @@ -48,14 +48,14 @@ >> *

>> * For example, to specify the "host" service use of a forwardable TGT the >> * target permission is specified as follows: >> - *

>> + *
>> *

>>     *  DelegationPermission("\"host/foo.example.com at EXAMPLE.COM\"
>> \"krbtgt/EXAMPLE.COM at EXAMPLE.COM\"");
>>     * 
>> *

>> * To give the "backup" service a proxiable nfs service ticket the >> target permission >> * might be specified: >> - *

>> + *
>> *

>>     *  DelegationPermission("\"backup/bar.example.com at EXAMPLE.COM\"
>> \"nfs/home.EXAMPLE.COM at EXAMPLE.COM\"");
>>     * 
>> >> Otherwise, the patch looks fine. >> >> -Joe >> >> On 11/14/2013 07:01 AM, Sean Mullan wrote: >>> Just one comment. I would prefer if you changed the following pattern: >>> >>> * >>> *

>>> * >>> >>> to: >>> >>> * >>> >>> instead of: >>> >>> * >>> * >>> >>> There is no need for the extra line. >>> >>> Thanks, >>> Sean >>> >>> On 11/14/2013 03:44 AM, Sergey Lugovoy wrote: >>>> Hi all, >>>> >>>> please review the fix >>>> >>>> http://cr.openjdk.java.net/~yan/8028266/webrev.00/ >>>> >>>> for >>>> >>>> https://bugs.openjdk.java.net/browse/JDK-8028266 >>>> >>>> This patch cleanup tidy warnings for generated html documentation, and >>>> do not >>>> >>>> affect the appearance of the documentation. >>>> >>>> Best regards, >>>> >>>> Serge V. Lugovoy From yuri.nesterenko at oracle.com Mon Nov 18 05:01:09 2013 From: yuri.nesterenko at oracle.com (yuri.nesterenko at oracle.com) Date: Mon, 18 Nov 2013 13:01:09 +0000 Subject: hg: jdk8/tl/jdk: 8028049: Tidy warnings cleanup for packages java.nio/java.io Message-ID: <20131118130121.9329A62663@hg.openjdk.java.net> Changeset: 19ff80da8283 Author: yan Date: 2013-11-18 17:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19ff80da8283 8028049: Tidy warnings cleanup for packages java.nio/java.io Reviewed-by: alanb, darcy Contributed-by: Sergey Lugovoy ! src/share/classes/java/io/EOFException.java ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/nio/channels/AsynchronousChannelGroup.java ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/package.html From weijun.wang at oracle.com Mon Nov 18 20:28:50 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 19 Nov 2013 12:28:50 +0800 Subject: RFR: 8028479: runNameEquals still cannot precisely detect if a usable native krb5 is available Message-ID: <528AE902.3050701@oracle.com> Please take a look at http://cr.openjdk.java.net/~weijun/8028479/webrev.00/ The fix includes 2 parts: 1. krb5-config not checking gssapi. This does not work on Solaris. Only krb5 is available there. With an argument, a default will be used (usually krb5). 2. A 64-bit Linux might only have 64-bit native lib installed but 32-bit JRE cannot use it. krb5-config cannot tell the bitness. Thanks Max From Xuelei.Fan at Oracle.COM Mon Nov 18 22:05:07 2013 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Tue, 19 Nov 2013 14:05:07 +0800 Subject: RFR: 8028479: runNameEquals still cannot precisely detect if a usable native krb5 is available In-Reply-To: <528AE902.3050701@oracle.com> References: <528AE902.3050701@oracle.com> Message-ID: <528AFF93.5040706@Oracle.COM> Looks fine to me. Xuelei On 11/19/2013 12:28 PM, Weijun Wang wrote: > Please take a look at > > http://cr.openjdk.java.net/~weijun/8028479/webrev.00/ > > The fix includes 2 parts: > > 1. krb5-config not checking gssapi. This does not work on Solaris. Only > krb5 is available there. With an argument, a default will be used > (usually krb5). > > 2. A 64-bit Linux might only have 64-bit native lib installed but 32-bit > JRE cannot use it. krb5-config cannot tell the bitness. > > Thanks > Max From weijun.wang at oracle.com Mon Nov 18 22:15:41 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 19 Nov 2013 06:15:41 +0000 Subject: hg: jdk8/tl/jdk: 8028479: runNameEquals still cannot precisely detect if a usable native krb5 is available Message-ID: <20131119061604.35CBD62692@hg.openjdk.java.net> Changeset: 7b71e53c6a2b Author: weijun Date: 2013-11-19 14:14 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b71e53c6a2b 8028479: runNameEquals still cannot precisely detect if a usable native krb5 is available Reviewed-by: xuelei ! test/sun/security/krb5/runNameEquals.sh From erik.gahlin at oracle.com Tue Nov 19 02:48:43 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Tue, 19 Nov 2013 10:48:43 +0000 Subject: hg: jdk8/tl/jdk: 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt Message-ID: <20131119104913.3A8DB62699@hg.openjdk.java.net> Changeset: d6195774dd1f Author: egahlin Date: 2013-11-19 11:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6195774dd1f 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt Reviewed-by: alanb ! test/ProblemList.txt From chris.hegarty at oracle.com Tue Nov 19 05:48:42 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 19 Nov 2013 13:48:42 +0000 Subject: hg: jdk8/tl/jdk: 7086879: java/net/InetAddress/CheckJNI.java hangs on Linux when IPv6 enabled Message-ID: <20131119134856.8CE416269D@hg.openjdk.java.net> Changeset: d5ddde25d107 Author: tyan Date: 2013-11-19 13:46 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5ddde25d107 7086879: java/net/InetAddress/CheckJNI.java hangs on Linux when IPv6 enabled Reviewed-by: chegar ! test/ProblemList.txt From alan.bateman at oracle.com Tue Nov 19 06:11:27 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 19 Nov 2013 14:11:27 +0000 Subject: hg: jdk8/tl/jdk: 8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests Message-ID: <20131119141142.E7A146269E@hg.openjdk.java.net> Changeset: 2e574350a2b6 Author: alanb Date: 2013-11-19 14:08 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2e574350a2b6 8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests Reviewed-by: dholmes, sla, tbell ! test/Makefile From alan.bateman at oracle.com Tue Nov 19 06:14:04 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 19 Nov 2013 14:14:04 +0000 Subject: hg: jdk8/tl: 8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests Message-ID: <20131119141404.EAF086269F@hg.openjdk.java.net> Changeset: 9937f406e27e Author: alanb Date: 2013-11-19 14:11 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9937f406e27e 8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests Reviewed-by: dholmes, sla, tbell ! make/jprt.properties ! test/Makefile From vincent.x.ryan at oracle.com Tue Nov 19 06:16:34 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 19 Nov 2013 14:16:34 +0000 Subject: [8] RFR 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src} Message-ID: <528B72C2.8030807@oracle.com> Please review the following test fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8028377 Webrev: http://cr.openjdk.java.net/~vinnie/8028377/webrev.00/ It now writes temporary keystores in the test scratch area (not the test source area). Thanks. From Alan.Bateman at oracle.com Tue Nov 19 06:23:32 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 19 Nov 2013 14:23:32 +0000 Subject: [8] RFR 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src} In-Reply-To: <528B72C2.8030807@oracle.com> References: <528B72C2.8030807@oracle.com> Message-ID: <528B7464.1080708@oracle.com> On 19/11/2013 14:16, Vincent Ryan wrote: > Please review the following test fix: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8028377 > Webrev: http://cr.openjdk.java.net/~vinnie/8028377/webrev.00/ > > It now writes temporary keystores in the test scratch area > (not the test source area). This looks okay to me. One suggestion is to use the two-arg File constructor rather than String concatenation. -Alan. From weijun.wang at oracle.com Tue Nov 19 06:30:49 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 19 Nov 2013 22:30:49 +0800 Subject: [8] RFR 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src} In-Reply-To: <528B72C2.8030807@oracle.com> References: <528B72C2.8030807@oracle.com> Message-ID: <528B7619.8080304@oracle.com> Why not just put the file in the current directory? That's the real scratch dir. Or the cfg file needs an absolute path? Also, is it necessary to remove the files in finally? If the test fails, the files will be retained by jtreg so we can look into the reason. Or, these lines are added to make sure the files are removable? But then I think File::delete will not fail if a file is not removable. Files::delete is better. Thanks Max On 11/19/13, 22:16, Vincent Ryan wrote: > Please review the following test fix: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8028377 > Webrev: http://cr.openjdk.java.net/~vinnie/8028377/webrev.00/ > > It now writes temporary keystores in the test scratch area > (not the test source area). > > Thanks. From vincent.x.ryan at oracle.com Tue Nov 19 06:34:52 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 19 Nov 2013 14:34:52 +0000 Subject: [8] RFR 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src} In-Reply-To: <528B7464.1080708@oracle.com> References: <528B72C2.8030807@oracle.com> <528B7464.1080708@oracle.com> Message-ID: <528B770C.2020507@oracle.com> Thanks Alan. I've changed to using the two-arg constructor for File and I've updated the webrev in place. On 19/11/2013 14:23, Alan Bateman wrote: > On 19/11/2013 14:16, Vincent Ryan wrote: >> Please review the following test fix: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8028377 >> Webrev: http://cr.openjdk.java.net/~vinnie/8028377/webrev.00/ >> >> It now writes temporary keystores in the test scratch area >> (not the test source area). > This looks okay to me. One suggestion is to use the two-arg File > constructor rather than String concatenation. > > -Alan. From sean.coffey at oracle.com Tue Nov 19 06:49:32 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 19 Nov 2013 14:49:32 +0000 Subject: hg: jdk8/tl/jdk: 8028583: Add helper methods to test libraries Message-ID: <20131119144948.38D95626A2@hg.openjdk.java.net> Changeset: d1bb85f0a45a Author: coffeys Date: 2013-11-19 14:47 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1bb85f0a45a 8028583: Add helper methods to test libraries Reviewed-by: chegar ! test/java/rmi/testlibrary/TestLibrary.java ! test/lib/testlibrary/jdk/testlibrary/FileUtils.java From kumar.x.srinivasan at oracle.com Tue Nov 19 07:18:48 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Tue, 19 Nov 2013 15:18:48 +0000 Subject: hg: jdk8/tl/jdk: 8023978: [TEST_BUG] launcher tests must exclude platforms without server vm Message-ID: <20131119151900.74DC2626A6@hg.openjdk.java.net> Changeset: 40462a41b41b Author: ksrini Date: 2013-11-19 07:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40462a41b41b 8023978: [TEST_BUG] launcher tests must exclude platforms without server vm Reviewed-by: dholmes, mchung ! test/tools/launcher/ExecutionEnvironment.java ! test/tools/launcher/Test7029048.java ! test/tools/launcher/TestHelper.java From vincent.x.ryan at oracle.com Tue Nov 19 07:29:37 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 19 Nov 2013 15:29:37 +0000 Subject: [8] RFR 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src} In-Reply-To: <528B7619.8080304@oracle.com> References: <528B72C2.8030807@oracle.com> <528B7619.8080304@oracle.com> Message-ID: <528B83E1.9090100@oracle.com> On 19/11/2013 14:30, Weijun Wang wrote: > Why not just put the file in the current directory? That's the real > scratch dir. Or the cfg file needs an absolute path? Good point Max. The cfg file does require an absolute path so I've changed the test to now write to {user.dir}. And I've updated the webrev (in place). > > Also, is it necessary to remove the files in finally? If the test fails, > the files will be retained by jtreg so we can look into the reason. Or, > these lines are added to make sure the files are removable? But then I > think File::delete will not fail if a file is not removable. > Files::delete is better. I previously encountered a problem when tests were running concurrently but now that I write to {user.dir} I can remove that finally block. > > Thanks > Max > > > On 11/19/13, 22:16, Vincent Ryan wrote: >> Please review the following test fix: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8028377 >> Webrev: http://cr.openjdk.java.net/~vinnie/8028377/webrev.00/ >> >> It now writes temporary keystores in the test scratch area >> (not the test source area). >> >> Thanks. From Alan.Bateman at oracle.com Tue Nov 19 07:31:51 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 19 Nov 2013 15:31:51 +0000 Subject: [8] RFR 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src} In-Reply-To: <528B83E1.9090100@oracle.com> References: <528B72C2.8030807@oracle.com> <528B7619.8080304@oracle.com> <528B83E1.9090100@oracle.com> Message-ID: <528B8467.8040209@oracle.com> On 19/11/2013 15:29, Vincent Ryan wrote: > > On 19/11/2013 14:30, Weijun Wang wrote: >> Why not just put the file in the current directory? That's the real >> scratch dir. Or the cfg file needs an absolute path? > > Good point Max. The cfg file does require an absolute path so I've > changed the test to now write to {user.dir}. > > And I've updated the webrev (in place). Yes, Max's suggestion to user the working directory is good. The updated webrev looks good to me. -Alan. From chris.hegarty at oracle.com Tue Nov 19 07:32:22 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 19 Nov 2013 15:32:22 +0000 Subject: hg: jdk8/tl/jdk: 8028094: TEST_BUG: java/lang/ProcessBuilder/Basic.java leaves "sleep 6666" processes behind Message-ID: <20131119153235.07A90626A8@hg.openjdk.java.net> Changeset: cfbee8ee71bf Author: bvaidya Date: 2013-11-19 15:31 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cfbee8ee71bf 8028094: TEST_BUG: java/lang/ProcessBuilder/Basic.java leaves "sleep 6666" processes behind Reviewed-by: chegar ! test/java/lang/ProcessBuilder/Basic.java From vincent.x.ryan at oracle.com Tue Nov 19 07:43:44 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Tue, 19 Nov 2013 15:43:44 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131119154408.4933E626A9@hg.openjdk.java.net> Changeset: e8daf5a83e42 Author: vinnie Date: 2013-11-19 15:39 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8daf5a83e42 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src} Reviewed-by: alanb, weijun ! test/sun/security/provider/KeyStore/DKSTest.java ! test/sun/security/provider/KeyStore/domains.cfg Changeset: bfd4e632eeda Author: vinnie Date: 2013-11-19 15:42 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bfd4e632eeda Merge From rob.mckenna at oracle.com Tue Nov 19 08:06:07 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Tue, 19 Nov 2013 16:06:07 +0000 Subject: hg: jdk8/tl/jdk: 8022206: Intermittent test failures in java/lang/ProcessBuilder/Basic.java Message-ID: <20131119160620.363B5626AB@hg.openjdk.java.net> Changeset: 63b696dafc8a Author: robm Date: 2013-11-19 15:36 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/63b696dafc8a 8022206: Intermittent test failures in java/lang/ProcessBuilder/Basic.java Reviewed-by: chegar, alanb ! test/java/lang/ProcessBuilder/Basic.java From sean.coffey at oracle.com Tue Nov 19 08:30:26 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 19 Nov 2013 16:30:26 +0000 Subject: hg: jdk8/tl/jdk: 8016728: TEST_BUG: test/java/rmi/transport/closeServerSocket/CloseServerSocket.java failing intermittently Message-ID: <20131119163041.0246A626AD@hg.openjdk.java.net> Changeset: f2ccd3530476 Author: coffeys Date: 2013-11-19 16:22 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2ccd3530476 8016728: TEST_BUG: test/java/rmi/transport/closeServerSocket/CloseServerSocket.java failing intermittently Reviewed-by: chegar ! test/java/rmi/transport/closeServerSocket/CloseServerSocket.java From alan.bateman at oracle.com Tue Nov 19 07:12:37 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 19 Nov 2013 15:12:37 +0000 Subject: hg: jdk8/tl/jdk: 8028589: Instrument tools/jar/JarEntryTime.java to make it easier to diagnose failures Message-ID: <20131119151253.8563A626A4@hg.openjdk.java.net> Changeset: 36821ee241a2 Author: alanb Date: 2013-11-19 15:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/36821ee241a2 8028589: Instrument tools/jar/JarEntryTime.java to make it easier to diagnose failures Reviewed-by: chegar ! test/tools/jar/JarEntryTime.java From michael.x.mcmahon at oracle.com Tue Nov 19 09:51:03 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Tue, 19 Nov 2013 17:51:03 +0000 Subject: hg: jdk8/tl/jdk: 8028581: [TESTBUG] java/net/Socket/LingerTest.java failing Message-ID: <20131119175115.950A1626B3@hg.openjdk.java.net> Changeset: 79e975dfeb8a Author: michaelm Date: 2013-11-19 17:49 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79e975dfeb8a 8028581: [TESTBUG] java/net/Socket/LingerTest.java failing Reviewed-by: alanb ! test/java/net/Socket/LingerTest.java From alexander.zuev at oracle.com Tue Nov 19 10:06:03 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 19 Nov 2013 18:06:03 +0000 Subject: hg: jdk8/tl/jdk: 8027900: pack200 option is broken due to the incorrect makefile definition for its driver Message-ID: <20131119180616.795F1626B9@hg.openjdk.java.net> Changeset: 5aa853ca08a8 Author: kizune Date: 2013-11-19 22:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5aa853ca08a8 8027900: pack200 option is broken due to the incorrect makefile definition for its driver Reviewed-by: ksrini, ihse ! make/CompileLaunchers.gmk From vincent.x.ryan at oracle.com Tue Nov 19 09:56:25 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Tue, 19 Nov 2013 17:56:25 +0000 Subject: hg: jdk8/tl/jdk: 8015571: OCSP validation fails if ocsp.responderCertSubjectName is set Message-ID: <20131119175637.7FF9F626B4@hg.openjdk.java.net> Changeset: f8b24e1a609e Author: vinnie Date: 2013-11-19 17:55 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8b24e1a609e 8015571: OCSP validation fails if ocsp.responderCertSubjectName is set Reviewed-by: mullan, xuelei ! src/share/classes/sun/security/provider/certpath/OCSP.java ! src/share/classes/sun/security/provider/certpath/OCSPRequest.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! src/share/classes/sun/security/x509/X509CertImpl.java From mandy.chung at oracle.com Tue Nov 19 10:21:34 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 19 Nov 2013 18:21:34 +0000 Subject: hg: jdk8/tl/jdk: 8028565: Remove java/lang/management/ThreadMXBean/ThreadStateTest.java from ProblemList.txt Message-ID: <20131119182147.C2F65626BC@hg.openjdk.java.net> Changeset: 48c61808374f Author: mchung Date: 2013-11-19 10:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48c61808374f 8028565: Remove java/lang/management/ThreadMXBean/ThreadStateTest.java from ProblemList.txt Reviewed-by: sla ! test/ProblemList.txt From roger.riggs at oracle.com Tue Nov 19 10:29:28 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 19 Nov 2013 18:29:28 +0000 Subject: hg: jdk8/tl/jdk: 8028141: test/sun/management/jmxremote/bootstrap/LocalManagementTest|CustomLauncherTest.java failing again Message-ID: <20131119182942.7F43E626BE@hg.openjdk.java.net> Changeset: 3f47e393e1dd Author: rriggs Date: 2013-11-19 13:20 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f47e393e1dd 8028141: test/sun/management/jmxremote/bootstrap/LocalManagementTest|CustomLauncherTest.java failing again Summary: Correct to use the test.class.path instead of test.classes Reviewed-by: alanb, chegar ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java ! test/sun/management/jmxremote/bootstrap/LocalManagementTest.java From alexander.zuev at oracle.com Tue Nov 19 10:15:02 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 19 Nov 2013 18:15:02 +0000 Subject: hg: jdk8/tl/langtools: 6726154: javadoc generated with incorrect version in comment Message-ID: <20131119181507.11E2C626BA@hg.openjdk.java.net> Changeset: f42a22e2b2cd Author: kizune Date: 2013-11-19 22:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f42a22e2b2cd 6726154: javadoc generated with incorrect version in comment Reviewed-by: jjg, bpatel, erikj, tbell ! make/BuildLangtools.gmk ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java From daniel.fuchs at oracle.com Tue Nov 19 11:11:47 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Tue, 19 Nov 2013 19:11:47 +0000 Subject: hg: jdk8/tl/jdk: 8028185: XMLFormatter.format emits incorrect year Message-ID: <20131119191201.11AAF626C0@hg.openjdk.java.net> Changeset: 67d742c75971 Author: dfuchs Date: 2013-11-19 20:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/67d742c75971 8028185: XMLFormatter.format emits incorrect year Summary: Fixes a regression where the year in the date was increased by 1900. Reviewed-by: alanb, mchung ! src/share/classes/java/util/logging/XMLFormatter.java + test/java/util/logging/XMLFormatterDate.java From daniel.fuchs at oracle.com Tue Nov 19 13:29:06 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Tue, 19 Nov 2013 21:29:06 +0000 Subject: hg: jdk8/tl/jdk: 8005202: java/util/logging/CheckLockLocationTest.java fail on solars_10 Message-ID: <20131119212918.8D7EB626C9@hg.openjdk.java.net> Changeset: 059530c5ae9a Author: dfuchs Date: 2013-11-19 22:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/059530c5ae9a 8005202: java/util/logging/CheckLockLocationTest.java fail on solars_10 Summary: this test has been seen failing on Solaris 10, presumably because it was run as root. The fix will skip the non-writable case if it can't make a non-writable dir. Reviewed-by: mchung ! test/java/util/logging/CheckLockLocationTest.java From dan.xu at oracle.com Tue Nov 19 13:23:22 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Tue, 19 Nov 2013 21:23:22 +0000 Subject: hg: jdk8/tl/jdk: 8028631: Improve the test coverage to the pathname handling on unix-like platforms Message-ID: <20131119212335.5AA70626C7@hg.openjdk.java.net> Changeset: f496565c4eec Author: dxu Date: 2013-11-19 13:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f496565c4eec 8028631: Improve the test coverage to the pathname handling on unix-like platforms Summary: Add GeneralSolaris.java testcase and fix the concurrency issue Reviewed-by: lancea, chegar, alanb ! test/java/io/pathNames/General.java + test/java/io/pathNames/GeneralSolaris.java ! test/java/io/pathNames/GeneralWin32.java From valerie.peng at oracle.com Tue Nov 19 13:58:58 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 19 Nov 2013 13:58:58 -0800 Subject: [8] RFR 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src} In-Reply-To: <528B83E1.9090100@oracle.com> References: <528B72C2.8030807@oracle.com> <528B7619.8080304@oracle.com> <528B83E1.9090100@oracle.com> Message-ID: <528BDF22.9090309@oracle.com> If the test passed, these temporary files should be removed, shouldn't they? Thanks, Valerie On 11/19/13 07:29, Vincent Ryan wrote: > > On 19/11/2013 14:30, Weijun Wang wrote: >> Why not just put the file in the current directory? That's the real >> scratch dir. Or the cfg file needs an absolute path? > > Good point Max. The cfg file does require an absolute path so I've > changed the test to now write to {user.dir}. > > And I've updated the webrev (in place). > > >> >> Also, is it necessary to remove the files in finally? If the test fails, >> the files will be retained by jtreg so we can look into the reason. Or, >> these lines are added to make sure the files are removable? But then I >> think File::delete will not fail if a file is not removable. >> Files::delete is better. > > I previously encountered a problem when tests were running concurrently > but now that I write to {user.dir} I can remove that finally block. > > >> >> Thanks >> Max >> >> >> On 11/19/13, 22:16, Vincent Ryan wrote: >>> Please review the following test fix: >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8028377 >>> Webrev: http://cr.openjdk.java.net/~vinnie/8028377/webrev.00/ >>> >>> It now writes temporary keystores in the test scratch area >>> (not the test source area). >>> >>> Thanks. From vincent.x.ryan at oracle.com Tue Nov 19 14:34:20 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 19 Nov 2013 22:34:20 +0000 Subject: [8] RFR 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src} In-Reply-To: <528BDF22.9090309@oracle.com> References: <528B72C2.8030807@oracle.com> <528B7619.8080304@oracle.com> <528B83E1.9090100@oracle.com> <528BDF22.9090309@oracle.com> Message-ID: <528BE76C.5040200@oracle.com> Hello Valerie, They get written to the scratch directory for the testrun so I don't think it is necessary to delete them explicitly. I'll confirm that. Thanks. On 19/11/2013 21:58, Valerie (Yu-Ching) Peng wrote: > > If the test passed, these temporary files should be removed, shouldn't > they? > Thanks, > Valerie > > On 11/19/13 07:29, Vincent Ryan wrote: >> >> On 19/11/2013 14:30, Weijun Wang wrote: >>> Why not just put the file in the current directory? That's the real >>> scratch dir. Or the cfg file needs an absolute path? >> >> Good point Max. The cfg file does require an absolute path so I've >> changed the test to now write to {user.dir}. >> >> And I've updated the webrev (in place). >> >> >>> >>> Also, is it necessary to remove the files in finally? If the test fails, >>> the files will be retained by jtreg so we can look into the reason. Or, >>> these lines are added to make sure the files are removable? But then I >>> think File::delete will not fail if a file is not removable. >>> Files::delete is better. >> >> I previously encountered a problem when tests were running concurrently >> but now that I write to {user.dir} I can remove that finally block. >> >> >>> >>> Thanks >>> Max >>> >>> >>> On 11/19/13, 22:16, Vincent Ryan wrote: >>>> Please review the following test fix: >>>> >>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8028377 >>>> Webrev: http://cr.openjdk.java.net/~vinnie/8028377/webrev.00/ >>>> >>>> It now writes temporary keystores in the test scratch area >>>> (not the test source area). >>>> >>>> Thanks. > From stuart.marks at oracle.com Tue Nov 19 15:23:40 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 19 Nov 2013 23:23:40 +0000 Subject: hg: jdk8/tl/jdk: 8028638: java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails Message-ID: <20131119232352.AC246626D8@hg.openjdk.java.net> Changeset: 19d2e9649138 Author: smarks Date: 2013-11-19 15:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19d2e9649138 8028638: java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails Reviewed-by: lancea ! test/java/rmi/testlibrary/RMID.java From vicente.romero at oracle.com Tue Nov 19 15:36:44 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 19 Nov 2013 23:36:44 +0000 Subject: hg: jdk8/tl/langtools: 8028504: javac generates LocalVariableTable even with -g:none Message-ID: <20131119233647.AF78F626D9@hg.openjdk.java.net> Changeset: 66bcd5d4b3d1 Author: vromero Date: 2013-11-19 23:35 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/66bcd5d4b3d1 8028504: javac generates LocalVariableTable even with -g:none Reviewed-by: jjg, jlahoda ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java + test/tools/javac/T8028504/DontGenerateLVTForGNoneOpTest.java From rajan.halade at oracle.com Tue Nov 19 16:19:47 2013 From: rajan.halade at oracle.com (Rajan Halade) Date: Tue, 19 Nov 2013 16:19:47 -0800 Subject: Thoughts on possible options to JDK-8027598 Message-ID: <528C0023.8060302@oracle.com> I am working towards fixing JDK-8027598 , there are multiple options available here and would appreciate your thoughts on this. It was filed to address the issue at large reported inJDK-8027526 . Problem - When a regression test is run in agentvm mode and alters security providers, it can cause adverse effects on next tests executed in the batch. We have been batteling with few intermittent failures which are caused by scenario like this so I think it is important to have this fix. Possible approaches - 1. Enhance JTREG - This option would require change in jtreg to store/restore security providers when run in agentvm mode. 2. Update impacting tests to run in othervm - simple change but may slow down batch execution slightly. 3. Update each test to use library java/security/KeyPairGenerator/Failover.java like done in java/security/Provider tests - another easy change and tests would continue to run agentvm but would have added overhead of restoring providers. We will continue to pursue option 1 but many not be possible. Option 2 & 3 above are equally good and are debatable so would like your thoughts on it. Thanks, Rajan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131119/615c1e32/attachment.html From xuelei.fan at oracle.com Tue Nov 19 17:07:20 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 20 Nov 2013 09:07:20 +0800 Subject: Thoughts on possible options to JDK-8027598 In-Reply-To: <528C0023.8060302@oracle.com> References: <528C0023.8060302@oracle.com> Message-ID: <528C0B48.70606@oracle.com> On 11/20/2013 8:19 AM, Rajan Halade wrote: > I am working towards fixing JDK-8027598 > , there are multiple > options available here and would appreciate your thoughts on this. It > was filed to address the issue at large reported inJDK-8027526 > . > > Problem - When a regression test is run in agentvm mode and alters > security providers, it can cause adverse effects on next tests executed > in the batch. We have been batteling with few intermittent failures > which are caused by scenario like this so I think it is important to > have this fix. > > Possible approaches - > 1. Enhance JTREG - This option would require change in jtreg to > store/restore security providers when run in agentvm mode. If I am correct, JTREG has support provider cleanup already. But the question is even JTREG reset the providers, it still cannot ensure next test won't be impacted because in some circumstances JDK may need to cache something which depends on previous providers. Still need to analysis the test case by case. Xuelei > 2. Update impacting tests to run in othervm - simple change but may slow > down batch execution slightly. > 3. Update each test to use library > java/security/KeyPairGenerator/Failover.java like done in > java/security/Provider tests - another easy change and tests would > continue to run agentvm but would have added overhead of restoring > providers. > > We will continue to pursue option 1 but many not be possible. Option 2 & > 3 above are equally good and are debatable so would like your thoughts > on it. > > Thanks, > Rajan > > From valerie.peng at oracle.com Tue Nov 19 17:37:29 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Tue, 19 Nov 2013 17:37:29 -0800 Subject: Code Review Request for 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init() Message-ID: <528C1259.8050909@oracle.com> Can someone please help review my fixes for 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init()? Native PKCS11 libraries don't seem to check the key during the initialization calls (triggered by initSign()/initVerify()). Rather, it errors out during the subsequent update() calls. So, I added necessary key length checks. Webrev: http://cr.openjdk.java.net/~valeriep/7200306/webrev.00/ Thanks, Valerie From bradford.wetmore at oracle.com Tue Nov 19 17:44:02 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Tue, 19 Nov 2013 17:44:02 -0800 Subject: Thoughts on possible options to JDK-8027598 In-Reply-To: <528C0023.8060302@oracle.com> References: <528C0023.8060302@oracle.com> Message-ID: <528C13E2.9000204@oracle.com> On 11/19/2013 4:19 PM, Rajan Halade wrote: > I am working towards fixing JDK-8027598 > , there are multiple > options available here and would appreciate your thoughts on this. It > was filed to address the issue at large reported inJDK-8027526 > . > > Problem - When a regression test is run in agentvm mode and alters > security providers, it can cause adverse effects on next tests executed > in the batch. We have been batteling with few intermittent failures > which are caused by scenario like this so I think it is important to > have this fix. > > Possible approaches - > 1. Enhance JTREG - This option would require change in jtreg to > store/restore security providers when run in agentvm mode. That is my preference. I'm also cc'ing Jonathan Gibbons who should also be involved. I believe you can just look to see if the provider list has been updated, then restore only if that is the case. > 2. Update impacting tests to run in othervm - simple change but may slow > down batch execution slightly. Correct. I am not suggesting the following, but one other thing that was proposed was to update the Makefiles to run the java_security* targets in othervm, but that doesn't work when calling jtreg directly, and impacts all tests in that target. > 3. Update each test to use library > java/security/KeyPairGenerator/Failover.java like done in > java/security/Provider tests - another easy change and tests would > continue to run agentvm but would have added overhead of restoring > providers. > > We will continue to pursue option 1 but many not be possible. Option 2 & > 3 above are equally good and are debatable so would like your thoughts > on it. I would suggest pursing in order 1, 3, 2. Brad > > Thanks, > Rajan > > From bradford.wetmore at oracle.com Tue Nov 19 17:44:50 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Tue, 19 Nov 2013 17:44:50 -0800 Subject: Thoughts on possible options to JDK-8027598 In-Reply-To: <528C0B48.70606@oracle.com> References: <528C0023.8060302@oracle.com> <528C0B48.70606@oracle.com> Message-ID: <528C1412.8070004@oracle.com> On 11/19/2013 5:07 PM, Xuelei Fan wrote: > On 11/20/2013 8:19 AM, Rajan Halade wrote: >> I am working towards fixing JDK-8027598 >> , there are multiple >> options available here and would appreciate your thoughts on this. It >> was filed to address the issue at large reported inJDK-8027526 >> . >> >> Problem - When a regression test is run in agentvm mode and alters >> security providers, it can cause adverse effects on next tests executed >> in the batch. We have been batteling with few intermittent failures >> which are caused by scenario like this so I think it is important to >> have this fix. >> >> Possible approaches - >> 1. Enhance JTREG - This option would require change in jtreg to >> store/restore security providers when run in agentvm mode. > If I am correct, JTREG has support provider cleanup already. No, it does not currently. Brad > But the > question is even JTREG reset the providers, it still cannot ensure next > test won't be impacted because in some circumstances JDK may need to > cache something which depends on previous providers. Still need to > analysis the test case by case. > > Xuelei > >> 2. Update impacting tests to run in othervm - simple change but may slow >> down batch execution slightly. >> 3. Update each test to use library >> java/security/KeyPairGenerator/Failover.java like done in >> java/security/Provider tests - another easy change and tests would >> continue to run agentvm but would have added overhead of restoring >> providers. >> >> We will continue to pursue option 1 but many not be possible. Option 2 & >> 3 above are equally good and are debatable so would like your thoughts >> on it. >> >> Thanks, >> Rajan >> >> > From chris.hegarty at oracle.com Wed Nov 20 03:54:17 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 20 Nov 2013 11:54:17 +0000 Subject: Thoughts on possible options to JDK-8027598 In-Reply-To: <528C0B48.70606@oracle.com> References: <528C0023.8060302@oracle.com> <528C0B48.70606@oracle.com> Message-ID: <528CA2E9.6060002@oracle.com> On 20/11/13 01:07, Xuelei Fan wrote: > On 11/20/2013 8:19 AM, Rajan Halade wrote: >> I am working towards fixing JDK-8027598 >> , there are multiple >> options available here and would appreciate your thoughts on this. It >> was filed to address the issue at large reported inJDK-8027526 >> . >> >> Problem - When a regression test is run in agentvm mode and alters >> security providers, it can cause adverse effects on next tests executed >> in the batch. We have been batteling with few intermittent failures >> which are caused by scenario like this so I think it is important to >> have this fix. >> >> Possible approaches - >> 1. Enhance JTREG - This option would require change in jtreg to >> store/restore security providers when run in agentvm mode. > If I am correct, JTREG has support provider cleanup already. But the > question is even JTREG reset the providers, it still cannot ensure next > test won't be impacted because in some circumstances JDK may need to > cache something which depends on previous providers. Still need to > analysis the test case by case. Right, any static or cached data may be invalid, and this will require careful changes to the JRE itself. If there are not too many of these tests, I don't think that explicitly marking them othervm will hurt too much. And making them reliable will reduce greatly the amount of time spent head scratching chasing intermittent failures. -Chris. > > Xuelei > >> 2. Update impacting tests to run in othervm - simple change but may slow >> down batch execution slightly. >> 3. Update each test to use library >> java/security/KeyPairGenerator/Failover.java like done in >> java/security/Provider tests - another easy change and tests would >> continue to run agentvm but would have added overhead of restoring >> providers. >> >> We will continue to pursue option 1 but many not be possible. Option 2 & >> 3 above are equally good and are debatable so would like your thoughts >> on it. >> >> Thanks, >> Rajan >> >> > From chris.hegarty at oracle.com Wed Nov 20 04:03:59 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 20 Nov 2013 12:03:59 +0000 Subject: [8] RFR 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src} In-Reply-To: <528BE76C.5040200@oracle.com> References: <528B72C2.8030807@oracle.com> <528B7619.8080304@oracle.com> <528B83E1.9090100@oracle.com> <528BDF22.9090309@oracle.com> <528BE76C.5040200@oracle.com> Message-ID: <528CA52F.6020008@oracle.com> On 19/11/13 22:34, Vincent Ryan wrote: > Hello Valerie, > > They get written to the scratch directory for the testrun so I > don't think it is necessary to delete them explicitly. > I'll confirm that. You are correct Vinnie. Jtreg will attempt to delete the scratch working directory after the test completes. You can leave things as are. If you do want to explicitly remove these files, then you should use something like FileUtils.deleteFileIfExistsWithRetry() [1]. If left to jtreg, it has its own retry logic on Windows. -Chris. [1] http://hg.openjdk.java.net/jdk8/tl/jdk/file/19d2e9649138/test/lib/testlibrary/jdk/testlibrary/FileUtils.java > > Thanks. > > On 19/11/2013 21:58, Valerie (Yu-Ching) Peng wrote: >> >> If the test passed, these temporary files should be removed, shouldn't >> they? >> Thanks, >> Valerie >> >> On 11/19/13 07:29, Vincent Ryan wrote: >>> >>> On 19/11/2013 14:30, Weijun Wang wrote: >>>> Why not just put the file in the current directory? That's the real >>>> scratch dir. Or the cfg file needs an absolute path? >>> >>> Good point Max. The cfg file does require an absolute path so I've >>> changed the test to now write to {user.dir}. >>> >>> And I've updated the webrev (in place). >>> >>> >>>> >>>> Also, is it necessary to remove the files in finally? If the test >>>> fails, >>>> the files will be retained by jtreg so we can look into the reason. Or, >>>> these lines are added to make sure the files are removable? But then I >>>> think File::delete will not fail if a file is not removable. >>>> Files::delete is better. >>> >>> I previously encountered a problem when tests were running concurrently >>> but now that I write to {user.dir} I can remove that finally block. >>> >>> >>>> >>>> Thanks >>>> Max >>>> >>>> >>>> On 11/19/13, 22:16, Vincent Ryan wrote: >>>>> Please review the following test fix: >>>>> >>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8028377 >>>>> Webrev: http://cr.openjdk.java.net/~vinnie/8028377/webrev.00/ >>>>> >>>>> It now writes temporary keystores in the test scratch area >>>>> (not the test source area). >>>>> >>>>> Thanks. >> From erik.gahlin at oracle.com Wed Nov 20 03:31:41 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Wed, 20 Nov 2013 11:31:41 +0000 Subject: hg: jdk8/tl/jdk: 7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails Message-ID: <20131120113219.D2F4A626F7@hg.openjdk.java.net> Changeset: 894a4bae9e33 Author: egahlin Date: 2013-11-20 12:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/894a4bae9e33 7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails Reviewed-by: sla ! test/com/sun/jdi/BreakpointWithFullGC.sh From jan.lahoda at oracle.com Wed Nov 20 05:01:24 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Wed, 20 Nov 2013 13:01:24 +0000 Subject: hg: jdk8/tl/langtools: 6557966: Multiple upper bounds of the TypeVariable Message-ID: <20131120130134.99358626FC@hg.openjdk.java.net> Changeset: 7c89d200781b Author: jlahoda Date: 2013-11-20 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7c89d200781b 6557966: Multiple upper bounds of the TypeVariable Summary: Adjusting javax.lang.model javadoc regarding IntersectionType, IntersectionType.accept now calls visitIntersection for all kinds of IntersectionTypes. Reviewed-by: darcy, vromero Contributed-by: joe.darcy at oracle.com, jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/javax/lang/model/type/DeclaredType.java ! src/share/classes/javax/lang/model/type/IntersectionType.java ! src/share/classes/javax/lang/model/type/TypeVariable.java ! test/tools/javac/processing/model/type/IntersectionPropertiesTest.java From joel.franck at oracle.com Wed Nov 20 04:24:58 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Wed, 20 Nov 2013 12:24:58 +0000 Subject: hg: jdk8/tl/jdk: 8027413: Clarify javadoc for j.l.a.Target and j.l.a.ElementType Message-ID: <20131120122511.7F611626F9@hg.openjdk.java.net> Changeset: f39be11835ff Author: jfranck Date: 2013-11-20 13:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f39be11835ff 8027413: Clarify javadoc for j.l.a.Target and j.l.a.ElementType Reviewed-by: darcy ! src/share/classes/java/lang/annotation/ElementType.java ! src/share/classes/java/lang/annotation/Target.java From mandy.chung at oracle.com Wed Nov 20 10:02:35 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 20 Nov 2013 18:02:35 +0000 Subject: hg: jdk8/tl/jdk: 8028647: Add instrumentation in GetSafepointSyncTime.java and remove it from ProblemList.txt Message-ID: <20131120180250.5B94562711@hg.openjdk.java.net> Changeset: 90e27a47ff28 Author: mchung Date: 2013-11-20 10:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90e27a47ff28 8028647: Add instrumentation in GetSafepointSyncTime.java and remove it from ProblemList.txt Reviewed-by: sla, chegar ! test/ProblemList.txt ! test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java From volker.simonis at gmail.com Wed Nov 20 10:26:35 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 20 Nov 2013 19:26:35 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX Message-ID: Hi, this is the second review round for "8024854: Basic changes and files to build the class library on AIX". The previous reviews can be found at the end of this mail in the references section. I've tried to address all the comments and suggestions from the first round and to further streamline the patch (it perfectly builds on Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The biggest change compared to the first review round is the new "aix/" subdirectory which I've now created under "jdk/src" and which contains AIX-only code. The webrev is against our http://hg.openjdk.java.net/ppc-aix-port/stagerepository which has been recently synchronised with the jdk8 master: http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ Below (and in the webrev) you can find some comments which explain the changes to each file. In order to be able to push this big change, I need the approval of reviewers from the lib, net, svc, 2d, awt and sec groups. So please don't hesitate to jump at it - there are enough changes for everybody:) Thank you and best regards, Volker *References:* The following reviews have been posted so far (thanks Iris for collecting them :) - Alan Bateman (lib): Initial comments (16 Sep [2]) - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) - Michael McMahon (net): Initial comments (20 Sept [4]) - Steffan Larsen (svc): APPROVED (20 Sept [5]) - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments (15 Oct [7]) - Sean Mullan (sec): Initial comments (26 Sept [8]) [2]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html [3]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html [4]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html [5]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html [6]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html [7]: http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html [8]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html *Detailed change description:* The new "jdk/src/aix" subdirectory contains the following new and AIX-specific files for now: src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java src/aix/classes/sun/nio/ch/AixPollPort.java src/aix/classes/sun/nio/fs/AixFileStore.java src/aix/classes/sun/nio/fs/AixFileSystem.java src/aix/classes/sun/nio/fs/AixFileSystemProvider.java src/aix/classes/sun/nio/fs/AixNativeDispatcher.java src/aix/classes/sun/tools/attach/AixAttachProvider.java src/aix/classes/sun/tools/attach/AixVirtualMachine.java src/aix/native/java/net/aix_close.c src/aix/native/sun/nio/ch/AixPollPort.c src/aix/native/sun/nio/fs/AixNativeDispatcher.c src/aix/native/sun/tools/attach/AixVirtualMachine.c src/aix/porting/porting_aix.c src/aix/porting/porting_aix.h src/aix/porting/porting_aix.c src/aix/porting/porting_aix.h - Added these two files for AIX relevant utility code. - Currently these files only contain an implementation of dladdr which is not available on AIX. - In the first review round the existing dladdr users in the code either called the version from the HotSpot on AIX ( src/solaris/native/sun/awt/awt_LoadLibrary.c) or had a private copy of the whole implementation (src/solaris/demo/jvmti/hprof/hprof_md.c). This is now not necessary any more. The new file layout required some small changes to the makefiles to make them aware of the new directory locations: makefiles/CompileDemos.gmk - Add an extra argument to SetupJVMTIDemo which can be used to pass additional source locations. - Currently this is only used on AIX for the AIX porting utilities which are required by hprof. makefiles/lib/Awt2dLibraries.gmk makefiles/lib/ServiceabilityLibraries.gmk - On AIX add the sources of the AIX porting utilities to the build. They are required by src/solaris/native/sun/awt/awt_LoadLibrary.c and src/solaris/demo/jvmti/hprof/hprof_md.c because dladdr is not available on AIX. makefiles/lib/NioLibraries.gmk - Make the AIX-build aware of the new NIO source locations under src/aix/native/sun/nio/. makefiles/lib/NetworkingLibraries.gmk - Make the AIX-build aware of the new aix_close.c source location under src/aix/native/java/net/. src/share/bin/jli_util.h - Define JLI_Lseek on AIX. src/share/lib/security/java.security-aix - Provide default java.security-aix for AIX based on the latest Linux version as suggested by Sean Mullan. src/share/native/common/check_code.c - On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is legal, but the code in check_code.c does not handles this properly. So we wrap the two methods on AIX and return a non-NULL pointer even if we allocate 0 bytes. src/share/native/sun/awt/medialib/mlib_sys.c - malloc always returns 8-byte aligned pointers on AIX as well. src/share/native/sun/awt/medialib/mlib_types.h - Add AIX to the list of known platforms. src/share/native/sun/font/layout/KernTable.cpp - Rename the macro DEBUG to DEBUG_KERN_TABLE because DEBUG is too common and may be defined in other headers as well as on the command line and xlc bails out on macro redefinitions with a different value. src/share/native/sun/security/ec/impl/ecc_impl.h - Define required types and macros on AIX. src/solaris/back/exec_md.c - AIX behaves like Linux in this case so check for it in the Linux branch. src/solaris/bin/java_md_solinux.c, src/solaris/bin/java_md_solinux.h - On AIX LD_LIBRARY_PATH is called LIBPATH - Always use LD_LIBRARY_PATH macro instead of using the string " LD_LIBRARY_PATH" directly to cope with different library path names. - Add jre/lib//jli to the standard library search path on AIX because the AIX linker doesn't support the -rpath option. - Replace #ifdef __linux__ by #ifndef __solaris__ because in this case, AIX behaves like Linux. - Removed the definition of JVM_DLL, JAVA_DLL and LD_LIBRARY_PATH from java_md_solinux.h because the macros are redefined in the corresponding .c files anyway. src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties - Provide basic fontconfig.propertiesfor AIX. src/solaris/classes/java/lang/UNIXProcess.java.aix, src/aix/classes/sun/tools/attach/AixAttachProvider.java, src/aix/classes/sun/tools/attach/AixVirtualMachine.java, src/aix/native/sun/tools/attach/AixVirtualMachine.c - Provide AIX specific Java versions, mostly based on the corresponding Linux versions. src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java - Detect AIX operating system and return the corresponding channel and file system providers. src/solaris/classes/sun/nio/ch/Port.java - Add a callback function unregisterImpl(int fd) for implementations that need special handling when fd is removed and call it from unregister(int fd). By default the implementation of unregisterImpl(int fd) is empty except for the derived AixPollPort class on AIX. src/solaris/demo/jvmti/hprof/hprof_md.c - Add AIX support. AIX mostly behaves like Linux, with the one exception that it has no dladdr functionality. - Use the dladdr implementation from porting_aix.{c,h} on AIX. src/solaris/native/com/sun/management/UnixOperatingSystem_md.c - Adapt for AIX (i.e. use libperfstat on AIX to query OS memory). src/solaris/native/common/jdk_util_md.h - Add AIX definitions of the ISNANF and ISNAND macros. src/solaris/native/java/io/io_util_md.c - AIX behaves like Linux in this case so check for it in the Linux branch. src/solaris/native/java/lang/UNIXProcess_md.c - AIX behaves mostly like Solraris in this case so adjust the ifdefs accordingly. src/solaris/native/java/lang/childproc.c - AIX does not understand '/proc/self' - it requires the real process ID to query the proc file system for the current process. src/solaris/native/java/net/NetworkInterface.c - Add AIX support into the Linux branch because AIX mostly behaves like AIX for IPv4. - AIX needs a special function to enumerate IPv6 interfaces and to query the MAC address. - Moved the declaration of siocgifconfRequest to the beginning a the function (as recommend by Michael McMahon) to remain C89 compatible. src/solaris/native/java/net/PlainSocketImpl.c - On AIX (like on Solaris) setsockopt will set errno to EINVAL if the socket is closed. The default error message is then confusing. src/aix/native/java/net/aix_close.c, src/share/native/java/net/net_util.c - As recommended by Michael McMahon and Alan Bateman I've move an adapted version of linux_close.c to src/aix/native/java/net/aix_close.cbecause we also need the file and socket wrappers on AIX. - Compared to the Linux version, we've added the initialization of some previously uninitialized data structures. - Also, on AIX we don't have __attribute((constructor)) so we need to initialize manually (from JNI_OnLoad() in src/share/native/java/net/net_util.c. src/solaris/native/java/net/net_util_md.h - AIX needs the same workaround for I/O cancellation like Linux and MacOSX. src/solaris/native/java/net/net_util_md.c - SO_REUSEADDR is called SO_REUSEPORT on AIX. - On AIX we have to ignore failures due to ENOBUFS when setting the SO_SNDBUF/SO_RCVBUF socket options. src/solaris/native/java/util/TimeZone_md.c - Currently on AIX the only way to get the platform time zone is to read it from the TZ environment variable. src/solaris/native/sun/awt/awt_LoadLibrary.c - Use the dladdr from porting_aix.{c,h} on AIX. src/solaris/native/sun/awt/fontpath.c - Changed some macros from if !defined(__linux__) to if defined(__solaris__) because that's their real meaning. - Add AIX specific fontpath settings and library search paths for libfontconfig.so. src/solaris/native/sun/java2d/x11/X11SurfaceData.c - Rename the MIN and MAX macros to XSD_MIN and XSD_MAX to avoid name clashes (MIN and MAX are much too common and thexy are already defined in some AIX system headers). src/solaris/native/sun/java2d/x11/XRBackendNative.c - Handle AIX like Solaris. src/solaris/native/sun/nio/ch/Net.c - Add AIX-specific includes and constant definitions. - On AIX "socket extensions for multicast source filters" support depends on the OS version. Check for this and throw appropriate exceptions if it is requested but not supported. This is needed to pass JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c - On AIX strerror() is not thread-safe so we have to use strerror_r()instead. - On AIX readdir_r() returns EBADF (i.e. '9') and sets 'result' to NULL for the directory stream end. Otherwise, 'errno' will contain the error code. - Handle some AIX corner cases for the results of the statvfs64() call. - On AIX getgrgid_r() returns ESRCH if group does not exist. src/solaris/native/sun/security/pkcs11/j2secmod_md.c - Use RTLD_LAZY instead of RTLD_NOLOAD on AIX. test/java/lang/ProcessBuilder/Basic.java test/java/lang/ProcessBuilder/DestroyTest.java - Port this test to AIX and make it more robust (i.e. recognize the "C" locale as isEnglish(), ignore VM-warnings in the output, make sure the "grandchild" processes created by the test don't run too long (60s vs. 6666s) because in the case of test problems these processes will pollute the process space, make sure the test fails with an error and doesn't hang indefinitley in the case of a problem). *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this intended? Well, _AIX is defined in some system headers while AIX is defined by the build system. This is already used inconsistently (i.e. __linux__ vs. LINUX) and in general I try to be consistent with the style of the file where I the changes are. That said, I changes most of the occurences of AIX to _AIX. *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are they supposed to be there? We currently don't support OS/400 (later renamed into i5/OS and currently called IBM i) in our OpenJDK port but we do support it in our internel, SAP JVM build. We stripped out all the extra OS/400 functionality from the port but in some places where there is common functionality needd by both, AIX and OS/400 the OS/400 support may still be visible in the OpenJDK port. I don't think this is a real problem and it helps us to keep our internel sources in sync with the OpenJDK port. That said, I think I've removed all the references to OS/400 now. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131120/95330cdb/attachment-0001.html From bhavesh.x.patel at oracle.com Wed Nov 20 10:54:26 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Wed, 20 Nov 2013 18:54:26 +0000 Subject: hg: jdk8/tl/langtools: 8027977: javadoc dies on NumberFormat/DateFormat subclass Message-ID: <20131120185429.D7D4462717@hg.openjdk.java.net> Changeset: ef44a2971cb1 Author: bpatel Date: 2013-11-20 10:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ef44a2971cb1 8027977: javadoc dies on NumberFormat/DateFormat subclass Reviewed-by: jjg ! src/share/classes/com/sun/tools/javadoc/DocEnv.java + test/com/sun/javadoc/testCompletionFailure/TestCompletionFailure.java + test/com/sun/javadoc/testCompletionFailure/pkg1/NumberFormatTest.java From sean.mullan at oracle.com Wed Nov 20 13:43:50 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 20 Nov 2013 16:43:50 -0500 Subject: SHA-1 correctness and speed In-Reply-To: References: Message-ID: <528D2D16.6060903@oracle.com> Hi Bernd, Thanks for sharing the analysis and results. And good to know it isn't an issue in SunJCE. --Sean On 11/15/2013 06:40 PM, Bernd Eckenfels wrote: > Hello, > > you might have seen it, on the pgp-devel mailing list there was a thread > about a counter overflow in some message digest implementations of > libcrypt (affecting GnuPG MIC+Sign). With hashed data > 256GB there are > wrong hashes calculated. > > http://lists.gnupg.org/pipermail/gnupg-devel/2013-November/028041.html > > This motivated me to test Java implementation for the mentioned 257GB > test vectors. SunJCE and BC are not affected. I want to share with you > the code and results anyway. > > https://github.com/ecki/JavaCryptoTest/blob/master/src/main/java/net/eckenfels/test/jce/HashOverflowTest.java > > > NB: BC implementation is slower than JCE implementation: > > This is testing mit 257*1024 times a 1MB nul buffer: > > == HashOverflowTest on Java HotSpot(TM) 64-Bit Server VM > 1.7.0_09-b05/23.5-b02 (Oracle Corporation) > @ Windows 7 6.1 amd64 Service Pack 1 == > Testing algorithm SUN: MessageDigest.SHA -> sun.security.provider.SHA > aliases: [SHA-1, SHA1] attributes: {ImplementedIn=Software} > Digest:SHA-1 Message Digest from SUN 275951648768bytes x nul > hash=6938f23e29e7d3dcd100d0ed2df9d6593113718f in 1310,562s > > Testing algorithm BC: MessageDigest.SHA-1 -> > org.bouncycastle.jce.provider.JDKMessageDigest$SHA1 > aliases: [SHA1, SHA, 1.3.14.3.2.26] > Digest:SHA-1 Message Digest from BC 275951648768bytes x nul > hash=6938f23e29e7d3dcd100d0ed2df9d6593113718f in 1529,284s > > That is Sun 200MiB/s vs BC 172 Mib/s vs. openssl* 308MiB/s (i7-2600 > @3,40GHz ) > > On a slower system: > > Testing algorithm SUN: MessageDigest.SHA -> sun.security.provider.SHA > aliases: [SHA-1, SHA1] attributes: {ImplementedIn=Software} > Digest:SHA-1 Message Digest from SUN 275951648768bytes x nul > hash=6938f23e29e7d3dcd100d0ed2df9d6593113718f in 7499,101s > > Testing algorithm BC: MessageDigest.SHA-1 -> > org.bouncycastle.jce.provider.JDKMessageDigest$SHA1 > aliases: [SHA1, SHA, 1.3.14.3.2.26] > Digest:SHA-1 Message Digest from BC 275951648768bytes x nul > hash=6938f23e29e7d3dcd100d0ed2df9d6593113718f in 9275,935s > > That is 35MiB/s vs. 28MiB/s vs. openssl 57MiB/s > > Bernd > > * cygwin dd if=/dev/zero bs=1M count=$[257*1024] | openssl SHA1 From alan.bateman at oracle.com Wed Nov 20 13:36:54 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 20 Nov 2013 21:36:54 +0000 Subject: hg: jdk8/tl/jdk: 8028734: test/java/util/Locale/InternationalBAT.java changes does not restore the default TimeZone Message-ID: <20131120213710.E21EF6271F@hg.openjdk.java.net> Changeset: ecd6c25b54ce Author: alanb Date: 2013-11-20 21:34 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecd6c25b54ce 8028734: test/java/util/Locale/InternationalBAT.java changes does not restore the default TimeZone Reviewed-by: naoto ! test/java/util/Locale/InternationalBAT.java From rajan.halade at oracle.com Wed Nov 20 15:35:38 2013 From: rajan.halade at oracle.com (Rajan Halade) Date: Wed, 20 Nov 2013 15:35:38 -0800 Subject: Thoughts on possible options to JDK-8027598 In-Reply-To: <528CA2E9.6060002@oracle.com> References: <528C0023.8060302@oracle.com> <528C0B48.70606@oracle.com> <528CA2E9.6060002@oracle.com> Message-ID: <528D474A.2020400@oracle.com> Thanks for your comments. See inline - - Rajan On 11/20/2013 03:54, Chris Hegarty wrote: > On 20/11/13 01:07, Xuelei Fan wrote: >> On 11/20/2013 8:19 AM, Rajan Halade wrote: >>> I am working towards fixing JDK-8027598 >>> , there are multiple >>> options available here and would appreciate your thoughts on this. It >>> was filed to address the issue at large reported inJDK-8027526 >>> . >>> >>> Problem - When a regression test is run in agentvm mode and alters >>> security providers, it can cause adverse effects on next tests executed >>> in the batch. We have been batteling with few intermittent failures >>> which are caused by scenario like this so I think it is important to >>> have this fix. >>> >>> Possible approaches - >>> 1. Enhance JTREG - This option would require change in jtreg to >>> store/restore security providers when run in agentvm mode. >> If I am correct, JTREG has support provider cleanup already. But the >> question is even JTREG reset the providers, it still cannot ensure next >> test won't be impacted because in some circumstances JDK may need to >> cache something which depends on previous providers. Still need to >> analysis the test case by case. > > Right, any static or cached data may be invalid, and this will require > careful changes to the JRE itself. Pardon my ignorance - if I gather correctly then ProvidersSnapshot library also doesn't sandbox effects completely. > > If there are not too many of these tests, I don't think that > explicitly marking them othervm will hurt too much. And making them > reliable will reduce greatly the amount of time spent head scratching > chasing intermittent failures. I agree with you, we need to consider using othervm mode. There are ~66 (1% of all reg tests) such tests which are run in agentvm, don't use ProvidersSnapshot library, and are modifying providers. I think its safe to go with othervm option, let me know. - Rajan > > -Chris. > >> >> Xuelei >> >>> 2. Update impacting tests to run in othervm - simple change but may >>> slow >>> down batch execution slightly. >>> 3. Update each test to use library >>> java/security/KeyPairGenerator/Failover.java like done in >>> java/security/Provider tests - another easy change and tests would >>> continue to run agentvm but would have added overhead of restoring >>> providers. >>> >>> We will continue to pursue option 1 but many not be possible. Option >>> 2 & >>> 3 above are equally good and are debatable so would like your thoughts >>> on it. >>> >>> Thanks, >>> Rajan >>> >>> >> From chris.hegarty at oracle.com Thu Nov 21 01:53:14 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 21 Nov 2013 09:53:14 +0000 Subject: Thoughts on possible options to JDK-8027598 In-Reply-To: <528D474A.2020400@oracle.com> References: <528C0023.8060302@oracle.com> <528C0B48.70606@oracle.com> <528CA2E9.6060002@oracle.com> <528D474A.2020400@oracle.com> Message-ID: <528DD80A.7020600@oracle.com> On 11/20/2013 11:35 PM, Rajan Halade wrote: > .... >>>> >>>> Possible approaches - >>>> 1. Enhance JTREG - This option would require change in jtreg to >>>> store/restore security providers when run in agentvm mode. >>> If I am correct, JTREG has support provider cleanup already. But the >>> question is even JTREG reset the providers, it still cannot ensure next >>> test won't be impacted because in some circumstances JDK may need to >>> cache something which depends on previous providers. Still need to >>> analysis the test case by case. >> >> Right, any static or cached data may be invalid, and this will require >> careful changes to the JRE itself. > Pardon my ignorance - if I gather correctly then ProvidersSnapshot > library also doesn't sandbox effects completely. FYI. I am not part of the security team, and someone from the security group should ultimately have to agree/disagree, but we have similar issues in other parts of the platform. I don't know the specifics of the code here so it may, or may not, be an issue. If any part of the security framework stores values in static fields, that is dependent on the security providers, then when the providers change this static value may be incorrect. We encounter this from time to time with system properties. E.g. JDK HTTP Client code reads system property and stores in static field, JDK HTTP Client will never never re-read the property as it believes it will not change. Having jtreg reset/clean certain system properties will not help in this case. >> If there are not too many of these tests, I don't think that >> explicitly marking them othervm will hurt too much. And making them >> reliable will reduce greatly the amount of time spent head scratching >> chasing intermittent failures. > I agree with you, we need to consider using othervm mode. There are ~66 > (1% of all reg tests) such tests which are run in agentvm, don't use > ProvidersSnapshot library, and are modifying providers. I think its safe > to go with othervm option, let me know. IMHO, this is the right way to go here. -Chris. > > - Rajan >> >> -Chris. >> >>> >>> Xuelei >>> >>>> 2. Update impacting tests to run in othervm - simple change but may >>>> slow >>>> down batch execution slightly. >>>> 3. Update each test to use library >>>> java/security/KeyPairGenerator/Failover.java like done in >>>> java/security/Provider tests - another easy change and tests would >>>> continue to run agentvm but would have added overhead of restoring >>>> providers. >>>> >>>> We will continue to pursue option 1 but many not be possible. Option >>>> 2 & >>>> 3 above are equally good and are debatable so would like your thoughts >>>> on it. >>>> >>>> Thanks, >>>> Rajan >>>> >>>> >>> > From mark.sheppard at oracle.com Thu Nov 21 03:35:13 2013 From: mark.sheppard at oracle.com (mark.sheppard at oracle.com) Date: Thu, 21 Nov 2013 11:35:13 +0000 Subject: hg: jdk8/tl/corba: 8028215: ORB.init fails with SecurityException if properties select the JDK default ORB Message-ID: <20131121113515.1971C62731@hg.openjdk.java.net> Changeset: fe781b3badd6 Author: msheppar Date: 2013-11-21 11:30 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/fe781b3badd6 8028215: ORB.init fails with SecurityException if properties select the JDK default ORB Summary: check for default ORBImpl and ORBSingleton set via properties or System properties Reviewed-by: alanb, coffeys, mchung ! src/share/classes/org/omg/CORBA/ORB.java From Alan.Bateman at oracle.com Thu Nov 21 04:01:31 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 21 Nov 2013 12:01:31 +0000 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: <528DF61B.6060403@oracle.com> On 20/11/2013 18:26, Volker Simonis wrote: > Hi, > > this is the second review round for "8024854: Basic changes and files > to build the class library on AIX > ". The previous > reviews can be found at the end of this mail in the references section. > > I've tried to address all the comments and suggestions from the first > round and to further streamline the patch (it perfectly builds on > Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). > The biggest change compared to the first review round is the new > "aix/" subdirectory which I've now created under "jdk/src" and which > contains AIX-only code. Thanks for the update and addressing all the original comments and suggestions. In particular, moving most of the AIX specific files to src/aix and including an implementation of dladdr, make a big difference and makes this much easier to review. I've skimmed through all the non-client files in the webrev and just have a few comments: NetworkLibraries.gmk - is the exclude of bsd_close.c right? It looks like it will add this to LIBNET_EXCLUDE_FILES even when building on Mac. In the old verifier code (check_code.c) then it's not clear to me that the caller wrapper is needed but in any case the change suggests to me that we should look at the malloc usages so that they better handle the size==0 case. I realize the wrappers are to avoid changing too much and it should be okay to handle this via a separate bug. In net_util.c then it's a bit ugly to be calling aix_close_init. Michael/Chris - what you would think about the JNI_OnLoad calling into a platform specific function to do platform specific initialization? The changes to java_md_solinux.c look okay to me but it makes me wonder if this should be renamed as it no longer exclusively Solaris + Linux. Port.java - one suggestion for unregisterImpl is to rename it to preUnregister and change it to protected so that it's more obvious that it supposed to be overridden. UnixNativeDispatcher.c - this looks okay (must reduced since the first round), I just wonder if the changes to *_getpwuid and *_getgrgid are really needed as this just impacts the error message. Also might be good to indent the #ifdef to be consistent with the other usages in these functions. That's mostly it. I notice that only a small number of tests have been updated. Are there more test updates to come? I'm pretty sure we have a lot more tests that may require update (searching for SunOS might give some hints). -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131121/62f03fbc/attachment.html From mark.sheppard at oracle.com Thu Nov 21 03:37:57 2013 From: mark.sheppard at oracle.com (mark.sheppard at oracle.com) Date: Thu, 21 Nov 2013 11:37:57 +0000 Subject: hg: jdk8/tl/jdk: 8028215: ORB.init fails with SecurityException if properties select the JDK default ORB Message-ID: <20131121113853.3C1B762732@hg.openjdk.java.net> Changeset: d5d4b9a63174 Author: msheppar Date: 2013-11-21 11:36 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5d4b9a63174 8028215: ORB.init fails with SecurityException if properties select the JDK default ORB Summary: check for default ORBImpl and ORBSingleton set via properties or System properties Reviewed-by: alanb, coffeys, mchung + test/com/sun/corba/se/impl/orb/SetDefaultORBTest.java From erik.gahlin at oracle.com Thu Nov 21 04:46:40 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Thu, 21 Nov 2013 12:46:40 +0000 Subject: hg: jdk8/tl/jdk: 6402201: ProcessAttachTest.sh needs better synchronization Message-ID: <20131121124655.9331D62737@hg.openjdk.java.net> Changeset: 91ec3bc92793 Author: egahlin Date: 2013-11-21 13:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91ec3bc92793 6402201: ProcessAttachTest.sh needs better synchronization Reviewed-by: alanb ! test/ProblemList.txt ! test/com/sun/jdi/ProcessAttachDebuggee.java ! test/com/sun/jdi/ProcessAttachTest.sh From staffan.larsen at oracle.com Thu Nov 21 05:26:06 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Thu, 21 Nov 2013 13:26:06 +0000 Subject: hg: jdk8/tl/jdk: 8028632: Update jdk/test/ProblemList.txt to reflect fix JDK-8024423 Message-ID: <20131121132618.AEF2B6273A@hg.openjdk.java.net> Changeset: fc9f24b9408e Author: sla Date: 2013-11-21 12:57 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc9f24b9408e 8028632: Update jdk/test/ProblemList.txt to reflect fix JDK-8024423 Summary: Removed 5 testcases from the ProblemList Reviewed-by: sla Contributed-by: balchandra.vaidya at oracle.com ! test/ProblemList.txt From chris.hegarty at oracle.com Thu Nov 21 05:44:33 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 21 Nov 2013 13:44:33 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131121134510.833B16273B@hg.openjdk.java.net> Changeset: 2972241cf7eb Author: tyan Date: 2013-11-21 13:37 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2972241cf7eb 7036666: test/com/sun/net/httpserver/Test9a.java fails intermittently Summary: Additional stacktrace information is printed on failure Reviewed-by: alanb, dfuchs, chegar ! test/ProblemList.txt ! test/com/sun/net/httpserver/Test9a.java Changeset: ed979f9b40cd Author: tyan Date: 2013-11-21 13:42 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ed979f9b40cd 8022212: Intermittent test failures in java/net Reviewed-by: chegar ! test/java/net/NetworkInterface/IndexTest.java From rob.mckenna at oracle.com Thu Nov 21 08:08:17 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Thu, 21 Nov 2013 16:08:17 +0000 Subject: hg: jdk8/tl/jdk: 6703075: (process) java/lang/ProcessBuilder/Basic.java fails with fastdebug Message-ID: <20131121160829.C978862741@hg.openjdk.java.net> Changeset: 89fccc5a7469 Author: martin Date: 2013-11-21 16:06 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89fccc5a7469 6703075: (process) java/lang/ProcessBuilder/Basic.java fails with fastdebug Reviewed-by: alanb ! test/java/lang/ProcessBuilder/Basic.java From valerie.peng at oracle.com Thu Nov 21 12:03:27 2013 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Thu, 21 Nov 2013 20:03:27 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131121200356.B232D6276B@hg.openjdk.java.net> Changeset: 93826827e8b4 Author: valeriep Date: 2013-11-19 15:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93826827e8b4 8026943: SQE test jce/Global/Cipher/SameBuffer failed Summary: Always use different input/output buffers when calling FeedbackCipher objects Reviewed-by: mullan ! src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/DESedeWrapCipher.java + test/com/sun/crypto/provider/Cipher/AES/TestCopySafe.java Changeset: 06d155a7c9b0 Author: valeriep Date: 2013-11-21 11:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/06d155a7c9b0 Merge From volker.simonis at gmail.com Thu Nov 21 07:54:07 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 21 Nov 2013 16:54:07 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <528DF61B.6060403@oracle.com> References: <528DF61B.6060403@oracle.com> Message-ID: Hi Alan, thanks a lot for the fast review and your valuable comments. Please find my answers inline: On Thu, Nov 21, 2013 at 1:01 PM, Alan Bateman wrote: > On 20/11/2013 18:26, Volker Simonis wrote: > > Hi, > > this is the second review round for "8024854: Basic changes and files to > build the class library on AIX". > The previous reviews can be found at the end of this mail in the references > section. > > I've tried to address all the comments and suggestions from the first > round and to further streamline the patch (it perfectly builds on > Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The > biggest change compared to the first review round is the new "aix/" > subdirectory which I've now created under "jdk/src" and which contains > AIX-only code. > > Thanks for the update and addressing all the original comments and > suggestions. In particular, moving most of the AIX specific files to > src/aix and including an implementation of dladdr, make a big difference > and makes this much easier to review. > > I've skimmed through all the non-client files in the webrev and just have > a few comments: > > NetworkLibraries.gmk - is the exclude of bsd_close.c right? It looks like > it will add this to LIBNET_EXCLUDE_FILES even when building on Mac. > > You're right, that's a typo. That should have read: 48 ifneq ($(OPENJDK_TARGET_OS), aix) 49 LIBNET_EXCLUDE_FILES += aix_close.c 50 else 51 LIBNET_SRC_DIRS += $(JDK_TOPDIR)/src/aix/native/java/net/ 52 endif But actually I've just realized that it is not need at all, because 'aix_close.c' isn't in the PATH for any other OS than AIX (that could be probably called a feature of the new file layout:) So I'll simply change it to: 48 ifeq ($(OPENJDK_TARGET_OS), aix) 49 LIBNET_SRC_DIRS += $(JDK_TOPDIR)/src/aix/native/java/net/ 50 endif In the old verifier code (check_code.c) then it's not clear to me that the > caller wrapper is needed but in any case the change suggests to me that we > should look at the malloc usages so that they better handle the size==0 > case. I realize the wrappers are to avoid changing too much and it should > be okay to handle this via a separate bug. > > Yes, exactly. I didn't wanted to change too much code. But as the C-Standard states ( http://pubs.opengroup.org/onlinepubs/000095399/functions/malloc.html) "...If size is 0, either a null pointer or a unique pointer that can be successfully passed to free() shall be returned..." it is perfectly legal that malloc/calloc return a NULL pointer if called with a zero argument. This case is currently not handled (i.e. it's handled as an 'out of memory' error) in check_code.c and I agree that this should be fixed via a separate bug. > In net_util.c then it's a bit ugly to be calling aix_close_init. > Michael/Chris - what you would think about the JNI_OnLoad calling into a > platform specific function to do platform specific initialization? > > What about renaming 'initLocalAddrTable()' into something like 'platformInit()' and moving the call to 'aix_close_init' to a AIX-specific version of 'platformInit()' in net_util_md.c? > The changes to java_md_solinux.c look okay to me but it makes me wonder if > this should be renamed as it no longer exclusively Solaris + Linux. > > You're right - we could rename it to something like 'java_md_unix.c'. But no matter how fancy the name would be, the file would still be in the 'src/solaris/bin' subdirectory:( So I think we'd better leave this for a later change when we completely factor out the Linux/Mac code from the 'solaris/' directory. > Port.java - one suggestion for unregisterImpl is to rename it to > preUnregister and change it to protected so that it's more obvious that it > supposed to be overridden. > > Done. Also changed the comment to JavaDoc style to be more consistent with the other comments in that file. > UnixNativeDispatcher.c - this looks okay (must reduced since the first > round), I just wonder if the changes to *_getpwuid and *_getgrgid are > really needed as this just impacts the error message. Also might be good to > indent the #ifdef to be consistent with the other usages in these functions. > > You're right. This change was done before you fixed "7043788: (fs) PosixFileAttributes.owner() or group() throws NPE if owner/group not in passwd/group database" ( http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f91c799f7bfb). After you're fix it was "automatically" adapted. I've removed the special AIX handling as suggested because I think as well that another error message in the exception won't have any impact. > That's mostly it. I notice that only a small number of tests have been > updated. Are there more test updates to come? I'm pretty sure we have a lot > more tests that may require update (searching for SunOS might give some > hints). > > I'm currently working on it and created "8028537: PPC64: Updated jdk/test scripts to understand the AIX os and environment" for it because I didn't wanted to blow up this change unnecessarily. -Alan. > > > > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131121/c32891cb/attachment.html From dan.xu at oracle.com Thu Nov 21 14:24:03 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Thu, 21 Nov 2013 22:24:03 +0000 Subject: hg: jdk8/tl/jdk: 8028628: java/nio/channels/FileChannel/Size.java failed once in the same binary run Message-ID: <20131121222415.EA98D62787@hg.openjdk.java.net> Changeset: 81708985c0a2 Author: dxu Date: 2013-11-21 14:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81708985c0a2 8028628: java/nio/channels/FileChannel/Size.java failed once in the same binary run Reviewed-by: alanb, chegar, mchung, lancea ! test/java/nio/channels/FileChannel/Size.java From dan.xu at oracle.com Thu Nov 21 14:17:15 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Thu, 21 Nov 2013 22:17:15 +0000 Subject: hg: jdk8/tl/jdk: 7065902: (file) test/java/nio/file/Files/Misc.java fails on Solaris 11 when run as root Message-ID: <20131121221729.3D0E962785@hg.openjdk.java.net> Changeset: a74d6aa51654 Author: dxu Date: 2013-11-21 14:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a74d6aa51654 7065902: (file) test/java/nio/file/Files/Misc.java fails on Solaris 11 when run as root Reviewed-by: alanb ! test/java/nio/file/Files/Misc.java From stuart.marks at oracle.com Thu Nov 21 16:01:51 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 22 Nov 2013 00:01:51 +0000 Subject: hg: jdk8/tl/jdk: 7174936: several String methods claim to always create new String Message-ID: <20131122000217.394126278A@hg.openjdk.java.net> Changeset: 4bc37b6c4133 Author: smarks Date: 2013-11-21 16:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bc37b6c4133 7174936: several String methods claim to always create new String Reviewed-by: dholmes, bchristi, alanb, lancea ! src/share/classes/java/lang/String.java From weijun.wang at oracle.com Thu Nov 21 16:47:44 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 22 Nov 2013 08:47:44 +0800 Subject: RFR: 8028351: JWS doesn't get authenticated when using kerberos auth proxy Message-ID: <528EA9B0.9000906@oracle.com> Please take a look at http://cr.openjdk.java.net/~weijun/8028351/webrev.00/ The bug is https://bugs.openjdk.java.net/browse/JDK-8028351 Basically, we now treat no password provided as empty password, this leads to a useless (and failed) login and has some other serious issues, say, too many unsuccessful login blocks a user account. Thanks Max From xuelei.fan at oracle.com Thu Nov 21 17:39:16 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 22 Nov 2013 09:39:16 +0800 Subject: RFR: 8028351: JWS doesn't get authenticated when using kerberos auth proxy In-Reply-To: <528EA9B0.9000906@oracle.com> References: <528EA9B0.9000906@oracle.com> Message-ID: <528EB5C4.4030609@oracle.com> Looks like a reasonable fix to me. Xuelei On 11/22/2013 8:47 AM, Weijun Wang wrote: > Please take a look at > > http://cr.openjdk.java.net/~weijun/8028351/webrev.00/ > > The bug is > > https://bugs.openjdk.java.net/browse/JDK-8028351 > > Basically, we now treat no password provided as empty password, this > leads to a useless (and failed) login and has some other serious issues, > say, too many unsuccessful login blocks a user account. > > Thanks > Max From sundararajan.athijegannathan at oracle.com Thu Nov 21 20:32:44 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 22 Nov 2013 04:32:44 +0000 Subject: hg: jdk8/tl/nashorn: 5 new changesets Message-ID: <20131122043249.EB1926279A@hg.openjdk.java.net> Changeset: fea9f0f9bbde Author: sundar Date: 2013-11-14 15:53 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fea9f0f9bbde 8028161: nashorn: src/jdk/nashorn/api/scripting/ScriptEngineTest.java Reviewed-by: lagergren, hannesw ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: a165c0fb5be6 Author: hannesw Date: 2013-11-16 00:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a165c0fb5be6 8028210: Missing conversions on array index expression Reviewed-by: attila, jlaskey, lagergren ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java + test/script/basic/JDK-8028210.js + test/script/basic/JDK-8028210.js.EXPECTED Changeset: bce2bbfb35ae Author: lagergren Date: 2013-11-18 16:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bce2bbfb35ae 8028434: Line number nodes were off for while nodes and do while nodes - the line number of a loop node should be treated as the location of the test expression Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8028434.js + test/script/basic/JDK-8028434.js.EXPECTED Changeset: b375d261e56c Author: lagergren Date: 2013-11-19 10:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b375d261e56c 8028573: Line number nodes were off for while nodes and do while nodes - the line number of a loop node should be treated as the location of the test expression Reviewed-by: attila, hannesw ! test/script/basic/JDK-8028434.js Changeset: 73d741231651 Author: sundar Date: 2013-11-22 08:52 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/73d741231651 Merge From sean.coffey at oracle.com Fri Nov 22 01:58:40 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Fri, 22 Nov 2013 09:58:40 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20131122095935.EEE41627A8@hg.openjdk.java.net> Changeset: cd56de5896b4 Author: aefimov Date: 2013-11-15 15:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd56de5896b4 8027848: The ZoneInfoFile doesn't honor future GMT offset changes Reviewed-by: sherman, coffeys ! src/share/classes/sun/util/calendar/ZoneInfoFile.java Changeset: ebd47f6ab172 Author: aefimov Date: 2013-11-21 20:48 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ebd47f6ab172 8027370: Support tzdata2013h Reviewed-by: sherman, coffeys ! make/data/tzdata/VERSION ! make/data/tzdata/africa ! make/data/tzdata/southamerica ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/southamerica Changeset: 3b50d682e7c1 Author: coffeys Date: 2013-11-22 09:56 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b50d682e7c1 Merge From joel.franck at oracle.com Fri Nov 22 02:38:19 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Fri, 22 Nov 2013 10:38:19 +0000 Subject: hg: jdk8/tl/jdk: 8023278: Reflection API methods do not throw AnnotationFormatError in case of malformed Runtime[In]VisibleTypeAnnotations attribute Message-ID: <20131122103836.EEC29627AA@hg.openjdk.java.net> Changeset: 0775f4f6532a Author: jfranck Date: 2013-11-22 11:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0775f4f6532a 8023278: Reflection API methods do not throw AnnotationFormatError in case of malformed Runtime[In]VisibleTypeAnnotations attribute Reviewed-by: darcy ! src/share/classes/sun/reflect/annotation/TypeAnnotation.java ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java + test/java/lang/annotation/typeAnnotations/BadCPIndex.java From Alan.Bateman at oracle.com Fri Nov 22 05:24:56 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 22 Nov 2013 13:24:56 +0000 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: <528DF61B.6060403@oracle.com> Message-ID: <528F5B28.7000404@oracle.com> On 21/11/2013 15:54, Volker Simonis wrote: > : > But actually I've just realized that it is not need at all, because > 'aix_close.c' isn't in the PATH for any other OS than AIX (that could > be probably called a feature of the new file layout:) So I'll simply > change it to: > 48 ifeq ($(OPENJDK_TARGET_OS), aix) > 49 LIBNET_SRC_DIRS += $(JDK_TOPDIR)/src/aix/native/java/net/ > 50 endif This make sense. > > Yes, exactly. I didn't wanted to change too much code. But as the > C-Standard states > (http://pubs.opengroup.org/onlinepubs/000095399/functions/malloc.html) > "...If size is 0, either a null pointer or a unique pointer that can > be successfully passed to free() shall be returned..." it is perfectly > legal that malloc/calloc return a NULL pointer if called with a zero > argument. This case is currently not handled (i.e. it's handled as an > 'out of memory' error) in check_code.c and I agree that this should be > fixed via a separate bug. Yes, let's use a separate bug for this. > In net_util.c then it's a bit ugly to be calling aix_close_init. > Michael/Chris - what you would think about the JNI_OnLoad calling > into a platform specific function to do platform specific > initialization? > > > What about renaming 'initLocalAddrTable()' into something like > 'platformInit()' and moving the call to 'aix_close_init' to a > AIX-specific version of 'platformInit()' in net_util_md.c? I don't have a strong opinion on the name of the function, platformInit is fine for now. > : > > > You're right - we could rename it to something like 'java_md_unix.c'. > But no matter how fancy the name would be, the file would still be in > the 'src/solaris/bin' subdirectory:( So I think we'd better leave this > for a later change when we completely factor out the Linux/Mac code > from the 'solaris/' directory. I think JDK 9 is a good time to finally tackle this issue (as you probably know, this is something that I've brought up on porters-dev or build-dev a few times). > Port.java - one suggestion for unregisterImpl is to rename it to > preUnregister and change it to protected so that it's more obvious > that it supposed to be overridden. > > > Done. Also changed the comment to JavaDoc style to be more consistent > with the other comments in that file. Thanks. > UnixNativeDispatcher.c - this looks okay (must reduced since the > first round), I just wonder if the changes to *_getpwuid and > *_getgrgid are really needed as this just impacts the error > message. Also might be good to indent the #ifdef to be consistent > with the other usages in these functions. > > > You're right. This change was done before you fixed "7043788: (fs) > PosixFileAttributes.owner() or group() throws NPE if owner/group not > in passwd/group database" > (http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f91c799f7bfb). After > you're fix it was "automatically" adapted. I've removed the special > AIX handling as suggested because I think as well that another error > message in the exception won't have any impact. Thanks. > : > > > I'm currently working on it and created "8028537: PPC64: Updated > jdk/test scripts to understand the AIX os and environment" for it > because I didn't wanted to blow up this change unnecessarily. Okay. So overall I think this patch is in good shape (I have not reviewed the AWT/2D/client changes in any detail) and I don't see any blocking issues to this going in. -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131122/30623543/attachment.html From sean.mullan at oracle.com Fri Nov 22 07:40:43 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 22 Nov 2013 10:40:43 -0500 Subject: Code Review Request for 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init() In-Reply-To: <528C1259.8050909@oracle.com> References: <528C1259.8050909@oracle.com> Message-ID: <528F7AFB.20108@oracle.com> The fix looks good. One comment on the test - it looks like the test would start failing if Solaris PKCS11 started to support 2048 bit DSA keys. Is there a way to workaround that by checking the max key length supported by the library? --Sean On 11/19/2013 08:37 PM, Valerie (Yu-Ching) Peng wrote: > > Can someone please help review my fixes for 7200306: SunPKCS11 provider > delays the check of DSA key size for SHA1withDSA to sign() instead of > init()? > > Native PKCS11 libraries don't seem to check the key during the > initialization calls (triggered by initSign()/initVerify()). > Rather, it errors out during the subsequent update() calls. So, I added > necessary key length checks. > > Webrev: > http://cr.openjdk.java.net/~valeriep/7200306/webrev.00/ > > Thanks, > Valerie From sean.mullan at oracle.com Fri Nov 22 11:42:16 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 22 Nov 2013 14:42:16 -0500 Subject: Thoughts on possible options to JDK-8027598 In-Reply-To: <528DD80A.7020600@oracle.com> References: <528C0023.8060302@oracle.com> <528C0B48.70606@oracle.com> <528CA2E9.6060002@oracle.com> <528D474A.2020400@oracle.com> <528DD80A.7020600@oracle.com> Message-ID: <528FB398.4050305@oracle.com> On 11/21/2013 04:53 AM, Chris Hegarty wrote: >>>> If I am correct, JTREG has support provider cleanup already. But the >>>> question is even JTREG reset the providers, it still cannot ensure next >>>> test won't be impacted because in some circumstances JDK may need to >>>> cache something which depends on previous providers. Still need to >>>> analysis the test case by case. >>> >>> Right, any static or cached data may be invalid, and this will require >>> careful changes to the JRE itself. >> Pardon my ignorance - if I gather correctly then ProvidersSnapshot >> library also doesn't sandbox effects completely. > > FYI. I am not part of the security team, and someone from the security > group should ultimately have to agree/disagree, but we have similar > issues in other parts of the platform. I don't know the specifics of the > code here so it may, or may not, be an issue. > > If any part of the security framework stores values in static fields, > that is dependent on the security providers, then when the providers > change this static value may be incorrect. > > We encounter this from time to time with system properties. E.g. JDK > HTTP Client code reads system property and stores in static field, JDK > HTTP Client will never never re-read the property as it believes it will > not change. Having jtreg reset/clean certain system properties will not > help in this case. Yes, the example with system properties is a good one. However, providers are designed to be added and removed dynamically (see the java.security.Security API), so if there is some static information not being cleared when providers are reset, I would tend to think it may be a bug in the JDK. My preference would be change jtreg to clear/restore providers, and more thoroughly analyze any subsequent test failures as it may be a bug in the JDK. --Sean From valerie.peng at oracle.com Fri Nov 22 11:54:03 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 22 Nov 2013 11:54:03 -0800 Subject: Code Review Request for 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init() In-Reply-To: <528F7AFB.20108@oracle.com> References: <528C1259.8050909@oracle.com> <528F7AFB.20108@oracle.com> Message-ID: <528FB65B.5080404@oracle.com> Even if Solaris PKCS11 provider starts to support 2048-bit DSA keys, its SHA1withDSA signature impl should still only accept up-to-1024-bit DSA keys. The longer DSA keys need newer signature impls using SHA2-family digests. So, the regression test should still be valid. Thanks, Valerie On 11/22/13 07:40, Sean Mullan wrote: > The fix looks good. One comment on the test - it looks like the test > would start failing if Solaris PKCS11 started to support 2048 bit DSA > keys. Is there a way to workaround that by checking the max key length > supported by the library? > > --Sean > > On 11/19/2013 08:37 PM, Valerie (Yu-Ching) Peng wrote: >> >> Can someone please help review my fixes for 7200306: SunPKCS11 provider >> delays the check of DSA key size for SHA1withDSA to sign() instead of >> init()? >> >> Native PKCS11 libraries don't seem to check the key during the >> initialization calls (triggered by initSign()/initVerify()). >> Rather, it errors out during the subsequent update() calls. So, I added >> necessary key length checks. >> >> Webrev: >> http://cr.openjdk.java.net/~valeriep/7200306/webrev.00/ >> >> Thanks, >> Valerie > From sean.mullan at oracle.com Fri Nov 22 12:20:07 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 22 Nov 2013 15:20:07 -0500 Subject: Code Review Request for 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init() In-Reply-To: <528FB65B.5080404@oracle.com> References: <528C1259.8050909@oracle.com> <528F7AFB.20108@oracle.com> <528FB65B.5080404@oracle.com> Message-ID: <528FBC77.1090309@oracle.com> On 11/22/2013 02:54 PM, Valerie (Yu-Ching) Peng wrote: > > Even if Solaris PKCS11 provider starts to support 2048-bit DSA keys, its > SHA1withDSA signature impl should still only accept up-to-1024-bit DSA > keys. The longer DSA keys need newer signature impls using SHA2-family > digests. > So, the regression test should still be valid. Ok, sounds good. --Sean > Thanks, > Valerie > > On 11/22/13 07:40, Sean Mullan wrote: >> The fix looks good. One comment on the test - it looks like the test >> would start failing if Solaris PKCS11 started to support 2048 bit DSA >> keys. Is there a way to workaround that by checking the max key length >> supported by the library? >> >> --Sean >> >> On 11/19/2013 08:37 PM, Valerie (Yu-Ching) Peng wrote: >>> >>> Can someone please help review my fixes for 7200306: SunPKCS11 provider >>> delays the check of DSA key size for SHA1withDSA to sign() instead of >>> init()? >>> >>> Native PKCS11 libraries don't seem to check the key during the >>> initialization calls (triggered by initSign()/initVerify()). >>> Rather, it errors out during the subsequent update() calls. So, I added >>> necessary key length checks. >>> >>> Webrev: >>> http://cr.openjdk.java.net/~valeriep/7200306/webrev.00/ >>> >>> Thanks, >>> Valerie >> > From valerie.peng at oracle.com Fri Nov 22 12:36:30 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 22 Nov 2013 12:36:30 -0800 Subject: Code Review Request for 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init() In-Reply-To: <528FBC77.1090309@oracle.com> References: <528C1259.8050909@oracle.com> <528F7AFB.20108@oracle.com> <528FB65B.5080404@oracle.com> <528FBC77.1090309@oracle.com> Message-ID: <528FC04E.3090003@oracle.com> Thanks for the prompt review~ Valerie On 11/22/13 12:20, Sean Mullan wrote: > On 11/22/2013 02:54 PM, Valerie (Yu-Ching) Peng wrote: >> >> Even if Solaris PKCS11 provider starts to support 2048-bit DSA keys, its >> SHA1withDSA signature impl should still only accept up-to-1024-bit DSA >> keys. The longer DSA keys need newer signature impls using SHA2-family >> digests. >> So, the regression test should still be valid. > > Ok, sounds good. > > --Sean > >> Thanks, >> Valerie >> >> On 11/22/13 07:40, Sean Mullan wrote: >>> The fix looks good. One comment on the test - it looks like the test >>> would start failing if Solaris PKCS11 started to support 2048 bit DSA >>> keys. Is there a way to workaround that by checking the max key length >>> supported by the library? >>> >>> --Sean >>> >>> On 11/19/2013 08:37 PM, Valerie (Yu-Ching) Peng wrote: >>>> >>>> Can someone please help review my fixes for 7200306: SunPKCS11 >>>> provider >>>> delays the check of DSA key size for SHA1withDSA to sign() instead of >>>> init()? >>>> >>>> Native PKCS11 libraries don't seem to check the key during the >>>> initialization calls (triggered by initSign()/initVerify()). >>>> Rather, it errors out during the subsequent update() calls. So, I >>>> added >>>> necessary key length checks. >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~valeriep/7200306/webrev.00/ >>>> >>>> Thanks, >>>> Valerie >>> >> > From rajan.halade at oracle.com Fri Nov 22 13:11:55 2013 From: rajan.halade at oracle.com (Rajan Halade) Date: Fri, 22 Nov 2013 13:11:55 -0800 Subject: Thoughts on possible options to JDK-8027598 In-Reply-To: <528FB398.4050305@oracle.com> References: <528C0023.8060302@oracle.com> <528C0B48.70606@oracle.com> <528CA2E9.6060002@oracle.com> <528D474A.2020400@oracle.com> <528DD80A.7020600@oracle.com> <528FB398.4050305@oracle.com> Message-ID: <528FC89B.309@oracle.com> On 11/22/2013 11:42, Sean Mullan wrote: > On 11/21/2013 04:53 AM, Chris Hegarty wrote: >>>>> If I am correct, JTREG has support provider cleanup already. But the >>>>> question is even JTREG reset the providers, it still cannot ensure >>>>> next >>>>> test won't be impacted because in some circumstances JDK may need to >>>>> cache something which depends on previous providers. Still need to >>>>> analysis the test case by case. >>>> >>>> Right, any static or cached data may be invalid, and this will require >>>> careful changes to the JRE itself. >>> Pardon my ignorance - if I gather correctly then ProvidersSnapshot >>> library also doesn't sandbox effects completely. >> >> FYI. I am not part of the security team, and someone from the security >> group should ultimately have to agree/disagree, but we have similar >> issues in other parts of the platform. I don't know the specifics of the >> code here so it may, or may not, be an issue. >> >> If any part of the security framework stores values in static fields, >> that is dependent on the security providers, then when the providers >> change this static value may be incorrect. >> >> We encounter this from time to time with system properties. E.g. JDK >> HTTP Client code reads system property and stores in static field, JDK >> HTTP Client will never never re-read the property as it believes it will >> not change. Having jtreg reset/clean certain system properties will not >> help in this case. > > Yes, the example with system properties is a good one. > > However, providers are designed to be added and removed dynamically > (see the java.security.Security API), so if there is some static > information not being cleared when providers are reset, I would tend > to think it may be a bug in the JDK. yes. thanks! > > My preference would be change jtreg to clear/restore providers, and > more thoroughly analyze any subsequent test failures as it may be a > bug in the JDK. Ok, I will follow up with jtreg team to find out when they can commit to timeline. - Rajan > > --Sean > From robert.field at oracle.com Fri Nov 22 17:08:04 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Sat, 23 Nov 2013 01:08:04 +0000 Subject: hg: jdk8/tl/langtools: 8028739: javac generates incorrect descriptor for MethodHandle::invoke Message-ID: <20131123010808.22666627CB@hg.openjdk.java.net> Changeset: 4fa835472e3c Author: rfield Date: 2013-11-22 17:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4fa835472e3c 8028739: javac generates incorrect descriptor for MethodHandle::invoke Summary: introduce special handling for signature polymorphic methods Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestMethodHandle.java From paul.sandoz at oracle.com Mon Nov 25 01:18:15 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Mon, 25 Nov 2013 09:18:15 +0000 Subject: hg: jdk8/tl/jdk: 8028516: Java doc error in Int/Long/Double/Stream.peek Message-ID: <20131125091828.3B135627FF@hg.openjdk.java.net> Changeset: 1f45b24ffe4b Author: psandoz Date: 2013-11-25 09:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f45b24ffe4b 8028516: Java doc error in Int/Long/Double/Stream.peek Reviewed-by: chegar ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Stream.java From chris.hegarty at oracle.com Mon Nov 25 02:29:41 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 25 Nov 2013 10:29:41 +0000 Subject: Thoughts on possible options to JDK-8027598 In-Reply-To: <528FC89B.309@oracle.com> References: <528C0023.8060302@oracle.com> <528C0B48.70606@oracle.com> <528CA2E9.6060002@oracle.com> <528D474A.2020400@oracle.com> <528DD80A.7020600@oracle.com> <528FB398.4050305@oracle.com> <528FC89B.309@oracle.com> Message-ID: <52932695.7040407@oracle.com> On 22/11/13 21:11, Rajan Halade wrote: > > On 11/22/2013 11:42, Sean Mullan wrote: >> On 11/21/2013 04:53 AM, Chris Hegarty wrote: >>>>>> If I am correct, JTREG has support provider cleanup already. But the >>>>>> question is even JTREG reset the providers, it still cannot ensure >>>>>> next >>>>>> test won't be impacted because in some circumstances JDK may need to >>>>>> cache something which depends on previous providers. Still need to >>>>>> analysis the test case by case. >>>>> >>>>> Right, any static or cached data may be invalid, and this will require >>>>> careful changes to the JRE itself. >>>> Pardon my ignorance - if I gather correctly then ProvidersSnapshot >>>> library also doesn't sandbox effects completely. >>> >>> FYI. I am not part of the security team, and someone from the security >>> group should ultimately have to agree/disagree, but we have similar >>> issues in other parts of the platform. I don't know the specifics of the >>> code here so it may, or may not, be an issue. >>> >>> If any part of the security framework stores values in static fields, >>> that is dependent on the security providers, then when the providers >>> change this static value may be incorrect. >>> >>> We encounter this from time to time with system properties. E.g. JDK >>> HTTP Client code reads system property and stores in static field, JDK >>> HTTP Client will never never re-read the property as it believes it will >>> not change. Having jtreg reset/clean certain system properties will not >>> help in this case. >> >> Yes, the example with system properties is a good one. >> >> However, providers are designed to be added and removed dynamically >> (see the java.security.Security API), so if there is some static >> information not being cleared when providers are reset, I would tend >> to think it may be a bug in the JDK. OK, if this is the case then that is fine. > yes. thanks! >> >> My preference would be change jtreg to clear/restore providers, and >> more thoroughly analyze any subsequent test failures as it may be a >> bug in the JDK. > Ok, I will follow up with jtreg team to find out when they can commit to > timeline. jtreg team? I am not aware of one. Jon Gibbons works on this in his spare time. You may want to take a look at jtreg [1] in the code tools project. -Chris. [1] http://openjdk.java.net/projects/code-tools/jtreg/ > > - Rajan >> >> --Sean >> > From lana.steuck at oracle.com Mon Nov 25 11:08:46 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:08:46 +0000 Subject: hg: jdk8/tl/corba: 4 new changesets Message-ID: <20131125190851.92AAF62825@hg.openjdk.java.net> Changeset: 7299367c8aa4 Author: cl Date: 2013-11-14 09:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7299367c8aa4 Added tag jdk8-b116 for changeset 5fdc44652089 ! .hgtags Changeset: e53d1ee4d2ae Author: lana Date: 2013-11-14 23:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e53d1ee4d2ae Merge Changeset: d6820a414f18 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d6820a414f18 Added tag jdk8-b117 for changeset e53d1ee4d2ae ! .hgtags Changeset: e648df60c8a2 Author: lana Date: 2013-11-25 09:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e648df60c8a2 Merge From lana.steuck at oracle.com Mon Nov 25 11:08:56 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:08:56 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20131125190907.26CBC62827@hg.openjdk.java.net> Changeset: 774c63629870 Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/774c63629870 Added tag jdk8-b116 for changeset 0fb1a427fbf6 ! .hgtags Changeset: 1db3d4e4d189 Author: lana Date: 2013-11-15 07:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1db3d4e4d189 Merge Changeset: 8d014b039b44 Author: cl Date: 2013-11-21 09:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8d014b039b44 Added tag jdk8-b117 for changeset 1db3d4e4d189 ! .hgtags Changeset: 44ea3815e414 Author: lana Date: 2013-11-25 09:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/44ea3815e414 Merge From lana.steuck at oracle.com Mon Nov 25 11:08:51 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:08:51 +0000 Subject: hg: jdk8/tl/jaxws: 3 new changesets Message-ID: <20131125190908.5C8FC62828@hg.openjdk.java.net> Changeset: fe56ba456fd3 Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/fe56ba456fd3 Added tag jdk8-b116 for changeset 587560c222a2 ! .hgtags Changeset: 76a598cf50c4 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/76a598cf50c4 Added tag jdk8-b117 for changeset fe56ba456fd3 ! .hgtags Changeset: 4900fcaae498 Author: lana Date: 2013-11-25 09:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/4900fcaae498 Merge From lana.steuck at oracle.com Mon Nov 25 11:08:56 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:08:56 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20131125190919.64DCC62829@hg.openjdk.java.net> Changeset: 64d119680f0a Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64d119680f0a Added tag jdk8-b116 for changeset 3c040b04af05 ! .hgtags Changeset: 19de039a03a6 Author: lana Date: 2013-11-15 07:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/19de039a03a6 Merge - test/tools/javac/ArraysInIntersections.java - test/tools/javac/InferArraysInIntersections.java - test/tools/javac/diags/examples/InterfaceOrArrayExpected.java Changeset: 4fd6a7ff8c06 Author: cl Date: 2013-11-21 09:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4fd6a7ff8c06 Added tag jdk8-b117 for changeset 19de039a03a6 ! .hgtags Changeset: 7ef88faaa16c Author: lana Date: 2013-11-25 09:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7ef88faaa16c Merge From lana.steuck at oracle.com Mon Nov 25 11:08:46 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:08:46 +0000 Subject: hg: jdk8/tl: 5 new changesets Message-ID: <20131125190847.985AE62824@hg.openjdk.java.net> Changeset: c1029b02ca87 Author: ihse Date: 2013-11-08 09:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c1029b02ca87 8027836: Webrev should handle files that has been moved from a directory which now is removed. Reviewed-by: mduigou, tbell ! make/scripts/webrev.ksh Changeset: cbfe5da942c6 Author: katleman Date: 2013-11-11 15:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/cbfe5da942c6 Merge Changeset: a4afb0a8d55e Author: cl Date: 2013-11-14 09:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a4afb0a8d55e Added tag jdk8-b116 for changeset cbfe5da942c6 ! .hgtags Changeset: 0a6db1aac998 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0a6db1aac998 Added tag jdk8-b117 for changeset a4afb0a8d55e ! .hgtags Changeset: 24847bd96465 Author: lana Date: 2013-11-25 09:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/24847bd96465 Merge From lana.steuck at oracle.com Mon Nov 25 11:09:14 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:09:14 +0000 Subject: hg: jdk8/tl/hotspot: 36 new changesets Message-ID: <20131125191035.64E3D6282A@hg.openjdk.java.net> Changeset: aec3226be72d Author: cl Date: 2013-11-14 09:04 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aec3226be72d Added tag jdk8-b116 for changeset 52b076e6ffae ! .hgtags Changeset: 20c72bec2707 Author: amurillo Date: 2013-11-08 07:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/20c72bec2707 8028061: new hotspot build - hs25-b59 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 9d8b29a0548c Author: mgerdin Date: 2013-11-08 16:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9d8b29a0548c 8027237: New tests on ReservedSpace/VirtualSpace classes Summary: Three tests added: 1) test stressing VirtualSpace by resizing it constantly 2) test running unit tests in several threads 3) test checking protected area in ReservedHeapSpace class Reviewed-by: stefank, zgu Contributed-by: aleksey.timofeev at oracle.com ! src/share/vm/prims/whitebox.cpp + test/runtime/memory/ReadFromNoaccessArea.java + test/runtime/memory/RunUnitTestsConcurrently.java + test/runtime/memory/StressVirtualSpaceResize.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: 19f8a5d7600b Author: mgerdin Date: 2013-11-08 23:49 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/19f8a5d7600b Merge Changeset: fce21ac5968d Author: acorn Date: 2013-11-13 07:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fce21ac5968d 8027229: ICCE expected for >=2 maximally specific default methods. Summary: Need to process defaults for interfaces for invokespecial Reviewed-by: lfoltan, hseigel, coleenp, jrose ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp ! src/share/vm/oops/klassVtable.cpp Changeset: 41cb10cbfb3c Author: coleenp Date: 2013-11-13 16:42 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/41cb10cbfb3c 8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field change Summary: Create extra constant pool cache entries for invokespecial/InterfaceMethodref to hold the alternate resolution. Reviewed-by: jrose, lfoltan, hseigel ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp Changeset: 4288e54fd145 Author: jwilhelm Date: 2013-10-21 18:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4288e54fd145 8026851: Remove unnecessary code in GenRemSet Summary: Removed the GenRemSet::rem_set_name() since we only have one remset. Reviewed-by: stefank, mgerdin, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp Changeset: 3aee6bc29547 Author: jwilhelm Date: 2013-10-21 18:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3aee6bc29547 8026852: Use restricted_align_down in collector policy code Summary: Moved restricted_align_down to globalDefinitions and renamed it align_size_down_bounded Reviewed-by: stefank, mgerdin, tschatzl ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 46d7652b223c Author: jwilhelm Date: 2013-10-21 18:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/46d7652b223c 8026853: Prepare GC code for collector policy regression fix Summary: Cleanup related to the NewSize and MaxNewSize bugs Reviewed-by: tschatzl, jcoomes, ehelin ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 8f07aa079343 Author: jwilhelm Date: 2013-11-01 17:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8f07aa079343 8016309: assert(eden_size > 0 && survivor_size > 0) failed: just checking 7057939: jmap shows MaxNewSize=4GB when Java is using parallel collector Summary: Major cleanup of the collectorpolicy classes Reviewed-by: tschatzl, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/parallelScavenge/adjoiningGenerations.cpp ! src/share/vm/gc_implementation/parallelScavenge/adjoiningGenerations.hpp ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp + src/share/vm/gc_implementation/parallelScavenge/generationSizer.cpp ! src/share/vm/gc_implementation/parallelScavenge/generationSizer.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! test/gc/arguments/TestMaxHeapSizeTools.java + test/gc/arguments/TestMaxNewSize.java Changeset: 610be0309a79 Author: amurillo Date: 2013-11-02 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/610be0309a79 Merge ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 28674af341ac Author: tschatzl Date: 2013-11-07 15:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region? Summary: Change checks for isHumongous() to continuesHumongous() as installing a code root for a humongous object is valid, but not for continuations of humongous objects. Cleaned up asserts. Reviewed-by: jmasa, tamao ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp + test/gc/g1/TestHumongousCodeCacheRoots.java Changeset: 40b8c6bad703 Author: jmasa Date: 2013-10-16 15:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/40b8c6bad703 8024954: CMS: CMSClassUnloadingMaxInterval is not implemented correctly. This change is also part of the fix for 8024483. Reviewed-by: mgerdin, brutisso, tschatzl Contributed-by: jwha at google.com ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: 592d8b01fedd Author: jmasa Date: 2013-11-08 06:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/592d8b01fedd 8024483: assertion failure: (!mirror_alive || loader_alive) failed: Reviewed-by: brutisso, tschatzl, mgerdin ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: 3ad2b68d107e Author: jwilhelm Date: 2013-11-10 00:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3ad2b68d107e 8027911: Assertion in the collector policy when running gc/arguments/TestMaxNewSize.java Summary: Update NewSize when _initial_gen0_size is changed Reviewed-by: tschatzl, brutisso ! src/share/vm/memory/collectorPolicy.cpp Changeset: 236cecd9ec97 Author: jwilhelm Date: 2013-11-11 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/236cecd9ec97 8028093: Initial young size is smaller than minimum young size Summary: Remove min_gen1_size argument from adjust_gen0_sizes() Reviewed-by: tschatzl, brutisso ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp Changeset: bde526e3667e Author: jwilhelm Date: 2013-11-11 05:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bde526e3667e Merge Changeset: 11b116661830 Author: mgerdin Date: 2013-11-11 16:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/11b116661830 Merge ! src/share/vm/memory/metaspace.cpp Changeset: ee527493b36d Author: sjohanss Date: 2013-11-08 17:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ee527493b36d 8027960: Assertion assert(end >= start) failed during nightly testing on solaris Summary: Needed to update _space_alignment in generation sizer to ensure correct sizing of spaces. Reviewed-by: jmasa, tschatzl ! src/share/vm/gc_implementation/parallelScavenge/generationSizer.cpp Changeset: 755c423791ab Author: ehelin Date: 2013-11-14 21:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/755c423791ab Merge ! src/share/vm/prims/whitebox.cpp Changeset: e2509677809c Author: vlivanov Date: 2013-11-08 01:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e2509677809c 8023037: Race between ciEnv::register_method and nmethod::make_not_entrant_or_zombie Reviewed-by: kvn, iveresov ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/runtime/globals.hpp Changeset: 83c8f6f4ab09 Author: drchase Date: 2013-11-08 14:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/83c8f6f4ab09 Merge Changeset: 1dcea64e9f00 Author: kvn Date: 2013-11-11 11:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1dcea64e9f00 8024830: SEGV in org.apache.lucene.codecs.compressing.CompressingTermVectorsReader.get Summary: Exclude last input argument's stack slots from vector's spilling masks. Reviewed-by: iveresov ! src/share/vm/opto/matcher.cpp Changeset: 78da3894b86f Author: anoll Date: 2013-11-12 09:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/78da3894b86f 8027593: performance drop with constrained codecache starting with hs25 b111 Summary: Fixed proper sweeping of small code cache sizes Reviewed-by: kvn, iveresov ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp Changeset: 144b23411b51 Author: roland Date: 2013-11-12 13:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/144b23411b51 8027632: assert(xtype->klass_is_exact()) failed: Should be exact at graphKit.cpp Summary: receiver type collected by profiling for default method may be interface Reviewed-by: kvn, iveresov ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: f675976a61e7 Author: rbackman Date: 2013-11-12 13:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f675976a61e7 8028198: SIGSEGV in PhaseIdealLoop::build_loop_late_post Reviewed-by: iveresov, kvn ! src/share/vm/opto/loopopts.cpp + test/compiler/intrinsics/mathexact/SplitThruPhiTest.java Changeset: b957c650babb Author: rbackman Date: 2013-11-12 14:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b957c650babb 8028207: assert(_outcnt==1) failed: not unique in compile.cpp Reviewed-by: iveresov, kvn ! src/share/vm/opto/mathexactnode.hpp + test/compiler/intrinsics/mathexact/GVNTest.java Changeset: e6ba215af802 Author: roland Date: 2013-11-13 09:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e6ba215af802 8027631: "unexpected profiling mismatch" error with new type profiling Summary: inlined method handle calls can call methods with different signatures Reviewed-by: kvn, iveresov ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp + test/compiler/profiling/TestUnexpectedProfilingMismatch.java Changeset: 924c32982a12 Author: roland Date: 2013-11-13 01:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/924c32982a12 Merge Changeset: 6e1826d5c23e Author: roland Date: 2013-11-13 13:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6e1826d5c23e 8027572: assert(r != 0) failed: invalid Summary: null classes should be expected in profiles with conflicts Reviewed-by: kvn, iveresov ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/methodData.hpp + test/compiler/profiling/unloadingconflict/B.java + test/compiler/profiling/unloadingconflict/TestProfileConflictClassUnloading.java Changeset: e74074c34312 Author: vlivanov Date: 2013-11-14 09:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e74074c34312 8028159: C2: compiler stack overflow during inlining of @ForceInline methods Reviewed-by: roland, kvn ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/runtime/globals.hpp Changeset: df0df745224c Author: drchase Date: 2013-11-14 15:58 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/df0df745224c Merge Changeset: 6f206b5d258f Author: drchase Date: 2013-11-14 13:38 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6f206b5d258f Merge ! src/share/vm/runtime/arguments.cpp Changeset: c78d517c7ea4 Author: amurillo Date: 2013-11-15 07:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c78d517c7ea4 Merge Changeset: f573d00213b7 Author: amurillo Date: 2013-11-15 07:50 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f573d00213b7 Added tag hs25-b59 for changeset c78d517c7ea4 ! .hgtags Changeset: 55be5aac78e2 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/55be5aac78e2 Added tag jdk8-b117 for changeset f573d00213b7 ! .hgtags From lana.steuck at oracle.com Mon Nov 25 11:08:49 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:08:49 +0000 Subject: hg: jdk8/tl/jaxp: 3 new changesets Message-ID: <20131125190906.CEE8762826@hg.openjdk.java.net> Changeset: c1d234d4f164 Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c1d234d4f164 Added tag jdk8-b116 for changeset e757eb9aee3d ! .hgtags Changeset: e4e5069250e7 Author: cl Date: 2013-11-21 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e4e5069250e7 Added tag jdk8-b117 for changeset c1d234d4f164 ! .hgtags Changeset: 7ce7e38868d3 Author: lana Date: 2013-11-25 09:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/7ce7e38868d3 Merge From lana.steuck at oracle.com Mon Nov 25 11:11:22 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 25 Nov 2013 19:11:22 +0000 Subject: hg: jdk8/tl/jdk: 20 new changesets Message-ID: <20131125191534.9FACF6282B@hg.openjdk.java.net> Changeset: bdcba4854576 Author: erikj Date: 2013-11-07 10:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bdcba4854576 8027698: Platform specific jars are not being signed by the sign-jars target Reviewed-by: ihse, tbell, wetmore ! makefiles/SignJars.gmk Changeset: 295a641fc86b Author: erikj Date: 2013-11-07 14:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/295a641fc86b 8027406: JDK demos are missing source files Reviewed-by: alexsch, ihse ! makefiles/CompileDemos.gmk Changeset: 43168d403243 Author: anthony Date: 2013-11-08 20:07 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43168d403243 8027912: [macosx] Provide means to force the headful mode on OS X when running via ssh Summary: Bypass AquaSession check if AWT_FORCE_HEADFUL env. variable is set to TRUE Reviewed-by: anthony, art Contributed-by: David Dehaven ! src/solaris/native/java/lang/java_props_macosx.c Changeset: 0dc0067f3b8e Author: katleman Date: 2013-11-11 15:06 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0dc0067f3b8e Merge Changeset: 483148bf625e Author: cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/483148bf625e Added tag jdk8-b116 for changeset 0dc0067f3b8e ! .hgtags Changeset: f2ae86dba4bc Author: prr Date: 2013-11-13 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2ae86dba4bc 8028206: sun/java2d/cmm/ProfileOp/SetDataTest.java fails Reviewed-by: bae, jchen ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c ! test/sun/java2d/cmm/ProfileOp/SetDataTest.java Changeset: b691a6abf9e0 Author: lana Date: 2013-11-14 23:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b691a6abf9e0 Merge Changeset: 30766f910509 Author: malenkov Date: 2013-11-01 21:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30766f910509 8026491: Typos in string literals Reviewed-by: alexsch, anthony ! src/macosx/classes/com/apple/laf/AquaFileChooserUI.java ! src/macosx/classes/com/apple/laf/resources/aqua.properties ! src/share/classes/com/sun/imageio/plugins/common/StandardMetadataFormatResources.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubBulkRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubNextRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubRequestHandler.java ! src/share/classes/com/sun/tools/example/debug/gui/CommandInterpreter.java ! src/share/classes/com/sun/tools/script/shell/init.js ! src/share/classes/com/sun/tools/script/shell/messages.properties ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/swing/KeyboardManager.java ! src/share/classes/javax/swing/SortingFocusTraversalPolicy.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/management/snmp/jvminstr/JVM_MANAGEMENT_MIB_IMPL.java ! src/share/classes/sun/misc/ExtensionDependency.java ! src/share/classes/sun/rmi/rmic/RMIGenerator.java ! src/share/classes/sun/security/jgss/krb5/InitialToken.java ! src/share/classes/sun/security/jgss/spnego/SpNegoContext.java ! src/share/demo/jfc/FileChooserDemo/FileChooserDemo.java ! src/share/native/sun/security/pkcs11/wrapper/p11_util.c ! src/share/sample/nio/chatserver/ClientReader.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java ! src/windows/classes/sun/security/krb5/internal/tools/Ktab.java Changeset: b8eb21e93fa7 Author: yan Date: 2013-11-07 18:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b8eb21e93fa7 8025234: [javadoc] fix some errors in javax.swing.** Reviewed-by: alexsch, malenkov Contributed-by: Dmitry Ginzburg ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/Action.java ! src/share/classes/javax/swing/Box.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/CellRendererPane.java ! src/share/classes/javax/swing/DefaultListSelectionModel.java ! src/share/classes/javax/swing/DesktopManager.java ! src/share/classes/javax/swing/GroupLayout.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JFileChooser.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JList.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JMenuBar.java ! src/share/classes/javax/swing/JTextField.java Changeset: 29f979efbabf Author: malenkov Date: 2013-11-08 14:09 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/29f979efbabf 8027648: Type of overridden property is resolved incorrectly Reviewed-by: alexsch ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/javax/swing/tree/DefaultMutableTreeNode.java + test/java/beans/Introspector/Test8027648.java + test/java/beans/Introspector/Test8027905.java Changeset: 184f13eeed41 Author: lana Date: 2013-11-08 15:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/184f13eeed41 Merge - src/share/classes/java/lang/invoke/MagicLambdaImpl.java - src/share/demo/jfc/Notepad/resources/Notepad_fr.properties - src/share/demo/jfc/Notepad/resources/Notepad_sv.properties - test/java/net/NetworkInterface/MemLeakTest.java - test/jdk/lambda/vm/DefaultMethodsTest.java - test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh - test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh - test/sun/tools/jstatd/jpsOutput1.awk - test/sun/tools/jstatd/jstatGcutilOutput1.awk - test/sun/tools/jstatd/jstatdDefaults.sh - test/sun/tools/jstatd/jstatdExternalRegistry.sh - test/sun/tools/jstatd/jstatdPort.sh - test/sun/tools/jstatd/jstatdServerName.sh - test/sun/tools/jstatd/jstatdUsage1.sh - test/sun/tools/jstatd/usage.out Changeset: 4bc2414624e2 Author: leonidr Date: 2013-11-12 20:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bc2414624e2 8027972: [macosx] Provide a regression test for JDK-8007006 Reviewed-by: anthony + test/java/awt/MenuBar/8007006/bug8007006.java Changeset: 0242fce0f717 Author: serb Date: 2013-11-12 20:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0242fce0f717 8027696: Incorrect copyright header in the tests Reviewed-by: alanb, malenkov, mullan ! test/ProblemList.txt ! test/com/sun/jmx/remote/NotificationMarshalVersions/Client/Client.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Client/ConfigKey.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Client/TestNotification.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/ConfigKey.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Server.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Ste.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/SteMBean.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/Server/TestNotification.java ! test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java ! test/com/sun/jndi/cosnaming/CNNameParser.java ! test/com/sun/jndi/cosnaming/IiopUrlIPv6.java ! test/demo/zipfs/ZipFSTester.java ! test/java/awt/AlphaComposite/TestAlphaCompositeForNaN.java ! test/java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html ! test/java/awt/Choice/NonFocusablePopupMenuTest/NonFocusablePopupMenuTest.html ! test/java/awt/Component/F10TopToplevel/F10TopToplevel.html ! test/java/awt/Component/UpdatingBootTime/UpdatingBootTime.html ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/NextFramePositionCalculator.java ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/SourcePanel.java ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/TargetPanel.java ! test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html ! test/java/awt/EventQueue/MainAppContext/MainAppContext.java ! test/java/awt/EventQueue/PostEventOrderingTest/PostEventOrderingTest.java ! test/java/awt/FileDialog/FileDialogReturnTest/FileDialogReturnTest.html ! test/java/awt/FileDialog/FileNameOverrideTest/FileNameOverrideTest.html ! test/java/awt/FileDialog/FileNameOverrideTest/FileNameOverrideTest.java ! test/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html ! test/java/awt/FileDialog/MultipleMode/MultipleMode.html ! test/java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest.html ! test/java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.html ! test/java/awt/FileDialog/SaveFileNameOverrideTest/SaveFileNameOverrideTest.java ! test/java/awt/Focus/6981400/Test1.java ! test/java/awt/Focus/6981400/Test2.java ! test/java/awt/Focus/6981400/Test3.java ! test/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html ! test/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html ! test/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java ! test/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html ! test/java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java ! test/java/awt/Focus/FocusTraversalPolicy/InitialFTP.java ! test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_AWT.java ! test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_Swing.java ! test/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html ! test/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html ! test/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html ! test/java/awt/Frame/FrameSetSizeStressTest/FrameSetSizeStressTest.java ! test/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html ! test/java/awt/Frame/ShownOnPack/ShownOnPack.html ! test/java/awt/Graphics/DrawImageBG/SystemBgColorTest.java ! test/java/awt/Graphics2D/FillTexturePaint/FillTexturePaint.java ! test/java/awt/InputMethods/InputMethodsTest/InputMethodsTest.html ! test/java/awt/JAWT/JAWT.sh ! test/java/awt/JAWT/Makefile.cygwin ! test/java/awt/JAWT/Makefile.unix ! test/java/awt/JAWT/Makefile.win ! test/java/awt/JAWT/MyCanvas.java ! test/java/awt/JAWT/myfile.c ! test/java/awt/JAWT/myfile.cpp ! test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_AWT.java ! test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java ! test/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html ! test/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html ! test/java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html ! test/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html ! test/java/awt/List/SetFontTest/SetFontTest.html ! test/java/awt/Menu/NullMenuLabelTest/NullMenuLabelTest.java ! test/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html ! test/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java ! test/java/awt/Mouse/MouseModifiersUnitTest/ModifierPermutation.java ! test/java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Extra.java ! test/java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java ! test/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html ! test/java/awt/Multiscreen/TranslucencyThrowsExceptionWhenFullScreen/TranslucencyThrowsExceptionWhenFullScreen.java ! test/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html ! test/java/awt/PrintJob/Text/stringwidth.sh ! test/java/awt/Robot/AcceptExtraMouseButtons/AcceptExtraMouseButtons.java ! test/java/awt/Robot/ManualInstructions/ManualInstructions.java ! test/java/awt/Robot/RobotExtraButton/RobotExtraButton.java ! test/java/awt/ScrollPane/ScrollPanePreferredSize/ScrollPanePreferredSize.java ! test/java/awt/TextArea/MouseOverScrollbarWhenTyping/Test.java ! test/java/awt/TextArea/MouseOverScrollbarWhenTyping/Test1.java ! test/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.html ! test/java/awt/TextArea/TextAreaTwicePack/TextAreaTwicePack.java ! test/java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest.html ! test/java/awt/TextField/ScrollSelectionTest/ScrollSelectionTest.html ! test/java/awt/Toolkit/Headless/AWTEventListener/AWTListener.java ! test/java/awt/Toolkit/Headless/ExceptionContract/ExceptionContract.java ! test/java/awt/Toolkit/Headless/GetPrintJob/GetPrintJob.java ! test/java/awt/Toolkit/Headless/GetPrintJob/GetPrintJobHeadless.java ! test/java/awt/Toolkit/SecurityTest/SecurityTest2.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_1.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_2.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_3.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_4.java ! test/java/awt/Toolkit/ToolkitPropertyTest/SystemPropTest_5.java ! test/java/awt/Toolkit/ToolkitPropertyTest/ToolkitPropertyTest_Disable.java ! test/java/awt/Toolkit/ToolkitPropertyTest/ToolkitPropertyTest_Enable.java ! test/java/awt/Window/Grab/GrabTest.java ! test/java/awt/Window/TranslucentShapedFrameTest/TSFrame.java ! test/java/awt/Window/TranslucentShapedFrameTest/TranslucentShapedFrameTest.java ! test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh ! test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/test.html ! test/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html ! test/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.html ! test/java/awt/dnd/Button2DragTest/Button2DragTest.html ! test/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html ! test/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java ! test/java/awt/dnd/DnDFileGroupDescriptor/DnDTarget.java ! test/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html ! test/java/awt/dnd/ImageDecoratedDnD/DnDSource.java ! test/java/awt/dnd/ImageDecoratedDnD/DnDTarget.java ! test/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.html ! test/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java ! test/java/awt/dnd/ImageDecoratedDnD/ImageGenerator.java ! test/java/awt/dnd/ImageDecoratedDnD/MyCursor.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/DnDSource.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/DnDTarget.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html ! test/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/ImageGenerator.java ! test/java/awt/dnd/ImageDecoratedDnDInOut/MyCursor.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/DnDSource.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/DnDTarget.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html ! test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/ImageGenerator.java ! test/java/awt/dnd/ImageDecoratedDnDNegative/MyCursor.java ! test/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html ! test/java/awt/event/InputEvent/ButtonArraysEquality/ButtonArraysEquality.java ! test/java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.html ! test/java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.java ! test/java/awt/event/KeyEvent/KeyReleasedInAppletTest/KeyReleasedInAppletTest.html ! test/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html ! test/java/awt/event/MouseEvent/AWTPanelSmoothWheel/AWTPanelSmoothWheel.html ! test/java/awt/event/MouseEvent/AcceptExtraButton/AcceptExtraButton.java ! test/java/awt/event/MouseEvent/CTORRestrictions/CTORRestrictions.java ! test/java/awt/event/MouseEvent/CTORRestrictions/CTORRestrictions_Disable.java ! test/java/awt/event/MouseEvent/CheckGetMaskForButton/CheckGetMaskForButton.java ! test/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html ! test/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html ! test/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html ! test/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html ! test/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html ! test/java/awt/event/OtherEvents/UngrabID/UngrabID.java ! test/java/awt/im/4490692/bug4490692.html ! test/java/awt/im/4959409/bug4959409.html ! test/java/awt/im/JTextFieldTest.html ! test/java/awt/image/BufferedImage/TinyScale.java ! test/java/awt/image/DrawImage/EABlitTest.java ! test/java/awt/print/PrinterJob/CustomPrintService/PrintServiceStub.java ! test/java/awt/print/PrinterJob/CustomPrintService/SetPrintServiceTest.java ! test/java/awt/print/bug8023392/bug8023392.html ! test/java/awt/print/bug8023392/bug8023392.java ! test/java/beans/Introspector/6380849/beans/FirstBean.java ! test/java/beans/Introspector/6380849/beans/FirstBeanBeanInfo.java ! test/java/beans/Introspector/6380849/beans/SecondBean.java ! test/java/beans/Introspector/6380849/beans/ThirdBean.java ! test/java/beans/Introspector/6380849/infos/SecondBeanBeanInfo.java ! test/java/beans/Introspector/6380849/infos/ThirdBeanBeanInfo.java ! test/java/beans/Introspector/6976577/test/Accessor.java ! test/java/beans/Introspector/7122138/pack/Sub.java ! test/java/beans/Introspector/7122138/pack/Super.java ! test/java/beans/XMLEncoder/6380849/Bean.java ! test/java/beans/XMLEncoder/6380849/BeanPersistenceDelegate.java ! test/java/io/FileInputStream/OpsAfterClose.java ! test/java/io/FileOutputStream/OpsAfterClose.java ! test/java/io/RandomAccessFile/OpsAfterClose.java ! test/java/lang/StringBuffer/BufferForwarding.java ! test/java/lang/StringBuilder/BuilderForwarding.java ! test/java/lang/instrument/RedefineBigClassApp.java ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/RetransformBigClassApp.java ! test/java/lang/invoke/AccessControlTest.java ! test/java/lang/invoke/BigArityTest.java ! test/java/lang/invoke/ClassValueTest.java ! test/java/lang/invoke/InvokeGenericTest.java ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java ! test/java/lang/invoke/PermuteArgsTest.java ! test/java/lang/invoke/PrivateInvokeTest.java ! test/java/lang/invoke/RevealDirectTest.java ! test/java/lang/invoke/RicochetTest.java ! test/java/lang/invoke/TestCatchExceptionWithVarargs.java ! test/java/lang/invoke/ThrowExceptionsTest.java ! test/java/lang/invoke/remote/RemoteExample.java ! test/java/lang/ref/ReferenceEnqueuePending.java ! test/java/net/URLClassLoader/closetest/build.sh ! test/java/security/cert/CertPathBuilder/selfIssued/generate.sh ! test/java/security/cert/CertPathValidator/indirectCRL/generate.sh ! test/java/security/cert/CertPathValidator/nameConstraints/generate.sh ! test/java/security/cert/CertificateRevokedException/Basic.java ! test/java/util/Calendar/CldrFormatNamesTest.java ! test/java/util/Locale/LocaleEnhanceTest.java ! test/java/util/Locale/LocaleTestFmwk.java ! test/java/util/Locale/tools/EquivMapsGenerator.java ! test/java/util/TimeZone/Bug6912560.java ! test/java/util/TimeZone/CLDRDisplayNamesTest.java ! test/java/util/TimeZone/ListTimeZones.java ! test/java/util/TimeZone/OldIDMappingTest.java ! test/java/util/TimeZone/OldIDMappingTest.sh ! test/java/util/TimeZone/SetDefaultSecurityTest.java ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.java ! test/java/util/TimeZone/TzIDOldMapping.java ! test/java/util/prefs/AddNodeChangeListener.java ! test/java/util/prefs/CheckUserPrefFirst.java ! test/java/util/prefs/CheckUserPrefLater.java ! test/java/util/regex/RegExTest.java ! test/java/util/spi/ResourceBundleControlProvider/providersrc/UserControlProvider.java ! test/java/util/zip/LargeZip.java ! test/java/util/zip/TotalInOut.java ! test/javax/imageio/plugins/gif/GifTransparencyTest.java ! test/javax/management/modelmbean/LoggingExceptionTest.java ! test/javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java ! test/javax/print/DialogMargins.java ! test/javax/print/StreamPrintingOrientation.java ! test/javax/print/applet/AppletPrintLookup.html ! test/javax/sound/midi/File/SMPTESequence.java ! test/javax/sound/midi/Gervill/AudioFloatConverter/GetFormat.java ! test/javax/sound/midi/Gervill/AudioFloatConverter/ToFloatArray.java ! test/javax/sound/midi/Gervill/AudioFloatFormatConverter/SkipTest.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Available.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Close.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/GetFormat.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/GetFrameLength.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/MarkSupported.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Read.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/ReadFloatArray.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/ReadFloatArrayIntInt.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Reset.java ! test/javax/sound/midi/Gervill/AudioFloatInputStream/Skip.java ! test/javax/sound/midi/Gervill/DLSSoundbankReader/TestGetSoundbankFile.java ! test/javax/sound/midi/Gervill/DLSSoundbankReader/TestGetSoundbankInputStream.java ! test/javax/sound/midi/Gervill/DLSSoundbankReader/TestGetSoundbankInputStream2.java ! test/javax/sound/midi/Gervill/DLSSoundbankReader/TestGetSoundbankUrl.java ! test/javax/sound/midi/Gervill/EmergencySoundbank/TestCreateSoundbank.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/GetInputStream.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/GetRoot.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/Load.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/LoadAll.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/NewModelByteBufferByteArray.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/NewModelByteBufferByteArrayIntInt.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/NewModelByteBufferFile.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/NewModelByteBufferFileLongLong.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/Available.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/Close.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/MarkReset.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/MarkSupported.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/Read.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/ReadByte.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/ReadByteIntInt.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/RandomFileInputStream/Skip.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/SubbufferLong.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/SubbufferLongLong.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/SubbufferLongLongBoolean.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/Unload.java ! test/javax/sound/midi/Gervill/ModelByteBuffer/WriteTo.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetAttenuation.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetChannels.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetLoopLength.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetLoopStart.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/GetPitchCorrection.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/NewModelByteBufferWavetableModelByteBuffer.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/NewModelByteBufferWavetableModelByteBufferAudioFormat.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/NewModelByteBufferWavetableModelByteBufferAudioFormatFloat.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/NewModelByteBufferWavetableModelByteBufferFloat.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/Open.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/OpenStream.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/Set8BitExtensionBuffer.java ! test/javax/sound/midi/Gervill/ModelByteBufferWavetable/SetLoopType.java ! test/javax/sound/midi/Gervill/ModelDestination/NewModelDestination.java ! test/javax/sound/midi/Gervill/ModelDestination/NewModelDestinationModelIdentifier.java ! test/javax/sound/midi/Gervill/ModelDestination/SetIdentifier.java ! test/javax/sound/midi/Gervill/ModelDestination/SetTransform.java ! test/javax/sound/midi/Gervill/ModelIdentifier/EqualsObject.java ! test/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierString.java ! test/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierStringInt.java ! test/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierStringString.java ! test/javax/sound/midi/Gervill/ModelIdentifier/NewModelIdentifierStringStringInt.java ! test/javax/sound/midi/Gervill/ModelIdentifier/SetInstance.java ! test/javax/sound/midi/Gervill/ModelIdentifier/SetObject.java ! test/javax/sound/midi/Gervill/ModelIdentifier/SetVariable.java ! test/javax/sound/midi/Gervill/ModelPerformer/GetOscillators.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetConnectionBlocks.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetDefaultConnectionsEnabled.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetExclusiveClass.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetKeyFrom.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetKeyTo.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetName.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetSelfNonExclusive.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetVelFrom.java ! test/javax/sound/midi/Gervill/ModelPerformer/SetVelTo.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSource.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifier.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifierBoolean.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifierBooleanBoolean.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifierBooleanBooleanInt.java ! test/javax/sound/midi/Gervill/ModelSource/NewModelSourceModelIdentifierModelTransform.java ! test/javax/sound/midi/Gervill/ModelSource/SetIdentifier.java ! test/javax/sound/midi/Gervill/ModelSource/SetTransform.java ! test/javax/sound/midi/Gervill/ModelStandardIndexedDirector/ModelStandardIndexedDirectorTest.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/NewModelStandardTransform.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/NewModelStandardTransformBoolean.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/NewModelStandardTransformBooleanBoolean.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/NewModelStandardTransformBooleanBooleanInt.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/SetDirection.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/SetPolarity.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/SetTransform.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformAbsolute.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformConcave.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformConvex.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformLinear.java ! test/javax/sound/midi/Gervill/ModelStandardTransform/TransformSwitch.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/Available.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/Close.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/GetFilePointer.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/GetSize.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/HasNextChunk.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/Read.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadByte.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadByteArrayIntInt.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadInt.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadLong.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadShort.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadString.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadUnsignedByte.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadUnsignedInt.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/ReadUnsignedShort.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/Skip.java ! test/javax/sound/midi/Gervill/RiffReaderWriter/WriteOutputStream.java ! test/javax/sound/midi/Gervill/SF2SoundbankReader/TestGetSoundbankFile.java ! test/javax/sound/midi/Gervill/SF2SoundbankReader/TestGetSoundbankInputStream.java ! test/javax/sound/midi/Gervill/SF2SoundbankReader/TestGetSoundbankInputStream2.java ! test/javax/sound/midi/Gervill/SF2SoundbankReader/TestGetSoundbankUrl.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelInstrument.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelInstrumentIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelInstrumentIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelInstrumentIntIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformer.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerArray.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerArrayIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerArrayIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerArrayIntIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/AddModelPerformerIntIntIntIntInt.java ! test/javax/sound/midi/Gervill/SimpleInstrument/Clear.java ! test/javax/sound/midi/Gervill/SimpleInstrument/SetName.java ! test/javax/sound/midi/Gervill/SimpleInstrument/SetPatch.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/AddInstrument.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/AddResource.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/GetInstrument.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/RemoveInstrument.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/SetDescription.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/SetName.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/SetVendor.java ! test/javax/sound/midi/Gervill/SimpleSoundbank/SetVersion.java ! test/javax/sound/midi/Gervill/SoftAudioBuffer/Array.java ! test/javax/sound/midi/Gervill/SoftAudioBuffer/Clear.java ! test/javax/sound/midi/Gervill/SoftAudioBuffer/Get.java ! test/javax/sound/midi/Gervill/SoftAudioBuffer/NewSoftAudioBuffer.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/DummySourceDataLine.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/GetFormat.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/GetPropertyInfo.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/Open.java ! test/javax/sound/midi/Gervill/SoftAudioSynthesizer/OpenStream.java ! test/javax/sound/midi/Gervill/SoftChannel/AllNotesOff.java ! test/javax/sound/midi/Gervill/SoftChannel/AllSoundOff.java ! test/javax/sound/midi/Gervill/SoftChannel/ChannelPressure.java ! test/javax/sound/midi/Gervill/SoftChannel/Controller.java ! test/javax/sound/midi/Gervill/SoftChannel/LocalControl.java ! test/javax/sound/midi/Gervill/SoftChannel/Mono.java ! test/javax/sound/midi/Gervill/SoftChannel/Mute.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOff.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOff2.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOn.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOverFlowTest.java ! test/javax/sound/midi/Gervill/SoftChannel/NoteOverFlowTest2.java ! test/javax/sound/midi/Gervill/SoftChannel/Omni.java ! test/javax/sound/midi/Gervill/SoftChannel/PitchBend.java ! test/javax/sound/midi/Gervill/SoftChannel/PolyPressure.java ! test/javax/sound/midi/Gervill/SoftChannel/ProgramAndBankChange.java ! test/javax/sound/midi/Gervill/SoftChannel/ProgramChange.java ! test/javax/sound/midi/Gervill/SoftChannel/ResetAllControllers.java ! test/javax/sound/midi/Gervill/SoftChannel/SoftTestUtils.java ! test/javax/sound/midi/Gervill/SoftChannel/Solo.java ! test/javax/sound/midi/Gervill/SoftCubicResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftFilter/TestProcessAudio.java ! test/javax/sound/midi/Gervill/SoftLanczosResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_mix.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_mix_mono.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_mix_mono_overdrive.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_mix_overdrive.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_normal.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_normal_mono.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_overdrive.java ! test/javax/sound/midi/Gervill/SoftLimiter/ProcessAudio_replace_overdrive_mono.java ! test/javax/sound/midi/Gervill/SoftLinearResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftLinearResampler2/Interpolate.java ! test/javax/sound/midi/Gervill/SoftLowFrequencyOscillator/TestProcessControlLogic.java ! test/javax/sound/midi/Gervill/SoftPointResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftProvider/GetDevice.java ! test/javax/sound/midi/Gervill/SoftReceiver/Close.java ! test/javax/sound/midi/Gervill/SoftReceiver/GetMidiDevice.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_ActiveSense.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_AllNotesOff.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_AllSoundOff.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_ChannelPressure.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_Controller.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_Mono.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOff.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOn.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOn_AllChannels.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOn_Delayed.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_NoteOn_Multiple.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_Omni.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_PitchBend.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_PolyPressure.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_ProgramChange.java ! test/javax/sound/midi/Gervill/SoftReceiver/Send_ResetAllControllers.java ! test/javax/sound/midi/Gervill/SoftReceiver/SoftTestUtils.java ! test/javax/sound/midi/Gervill/SoftSincResampler/Interpolate.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/Close.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/DummySourceDataLine.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetAvailableInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetAvailableInstruments2.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetChannels.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetDefaultSoundbank.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetDeviceInfo.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetLatency.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetLoadedInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetLoadedInstruments2.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetMaxPolyphony.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetMaxReceivers.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetMaxTransmitters.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetMicrosecondPosition.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetPropertyInfo.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetReceiver.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetReceiver2.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetReceivers.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetTransmitter.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetTransmitters.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/GetVoiceStatus.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/ImplicitOpenClose.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/IsOpen.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/IsSoundbankSupported.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/LoadAllInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/LoadInstrument.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/LoadInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/Open.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/OpenStream.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/RemapInstrument.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/TestDisableLoadDefaultSoundbank.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/TestPreciseTimestampRendering.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/TestRender1.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/UnloadAllInstruments.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/UnloadInstrument.java ! test/javax/sound/midi/Gervill/SoftSynthesizer/UnloadInstruments.java ! test/javax/sound/midi/Gervill/SoftTuning/GetName.java ! test/javax/sound/midi/Gervill/SoftTuning/GetTuning.java ! test/javax/sound/midi/Gervill/SoftTuning/GetTuningInt.java ! test/javax/sound/midi/Gervill/SoftTuning/Load1.java ! test/javax/sound/midi/Gervill/SoftTuning/Load2.java ! test/javax/sound/midi/Gervill/SoftTuning/Load4.java ! test/javax/sound/midi/Gervill/SoftTuning/Load5.java ! test/javax/sound/midi/Gervill/SoftTuning/Load6.java ! test/javax/sound/midi/Gervill/SoftTuning/Load7.java ! test/javax/sound/midi/Gervill/SoftTuning/Load8.java ! test/javax/sound/midi/Gervill/SoftTuning/Load9.java ! test/javax/sound/midi/Gervill/SoftTuning/NewSoftTuning.java ! test/javax/sound/midi/Gervill/SoftTuning/NewSoftTuningByteArray.java ! test/javax/sound/midi/Gervill/SoftTuning/NewSoftTuningPatch.java ! test/javax/sound/midi/Gervill/SoftTuning/NewSoftTuningPatchByteArray.java ! test/javax/sound/midi/Gervill/SoftTuning/RealTimeTuning.java ! test/javax/sound/midi/MidiDeviceConnectors/TestAllDevices.java ! test/javax/sound/midi/Sequencer/SequencerImplicitSynthOpen.java ! test/javax/sound/sampled/AudioFormat/Matches_NOT_SPECIFIED.java ! test/javax/sound/sampled/AudioFormat/PCM_FLOAT_support.java ! test/javax/sound/sampled/Clip/ClipSetPos.java ! test/javax/sound/sampled/DataLine/DataLine_ArrayIndexOutOfBounds.java ! test/javax/sound/sampled/DirectAudio/bug6400879.java ! test/javax/sound/sampled/FileWriter/AlawEncoderSync.java ! test/javax/sound/sampled/FileWriter/WriterCloseInput.java ! test/javax/swing/JCheckBox/4449413/bug4449413.html ! test/javax/swing/JColorChooser/Test4222508.html ! test/javax/swing/JColorChooser/Test4759306.html ! test/javax/swing/JColorChooser/Test4759934.html ! test/javax/swing/JColorChooser/Test4887836.html ! test/javax/swing/JColorChooser/Test6348456.html ! test/javax/swing/JColorChooser/Test6977726.html ! test/javax/swing/JComponent/4337267/bug4337267.java ! test/javax/swing/JComponent/6683775/bug6683775.java ! test/javax/swing/JEditorPane/4492274/test.html ! test/javax/swing/JEditorPane/6917744/test.html ! test/javax/swing/JEditorPane/bug4714674.java ! test/javax/swing/JFileChooser/6570445/bug6570445.java ! test/javax/swing/JFileChooser/6698013/bug6698013.html ! test/javax/swing/JFileChooser/6698013/bug6698013.java ! test/javax/swing/JFileChooser/6798062/bug6798062.html ! test/javax/swing/JInternalFrame/6726866/bug6726866.html ! test/javax/swing/JInternalFrame/6726866/bug6726866.java ! test/javax/swing/JSlider/4987336/bug4987336.html ! test/javax/swing/JSlider/6524424/bug6524424.html ! test/javax/swing/JSlider/6587742/bug6587742.html ! test/javax/swing/JSlider/6742358/bug6742358.html ! test/javax/swing/JTabbedPane/4310381/bug4310381.html ! test/javax/swing/JTree/4314199/bug4314199.html ! test/javax/swing/SwingUtilities/7170657/bug7170657.java ! test/javax/swing/border/Test4129681.html ! test/javax/swing/border/Test4243289.html ! test/javax/swing/border/Test4247606.html ! test/javax/swing/border/Test4252164.html ! test/javax/swing/border/Test4760089.html ! test/javax/swing/border/Test6910490.html ! test/javax/swing/border/Test7022041.java ! test/javax/swing/text/html/TableView/7030332/bug7030332.html ! test/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html ! test/sun/nio/cs/EUC_TW_OLD.java ! test/sun/nio/cs/TestStringCoding.java ! test/sun/nio/cs/X11CNS11643.java ! test/sun/nio/cs/X11CNS11643P1.java ! test/sun/nio/cs/X11CNS11643P2.java ! test/sun/nio/cs/X11CNS11643P3.java ! test/sun/security/pkcs11/KeyStore/SecretKeysBasic.java ! test/sun/security/pkcs11/ec/TestECGenSpec.java ! test/sun/security/pkcs11/ec/TestKeyFactory.java ! test/sun/util/resources/Locale/Bug6275682.java ! test/tools/launcher/DiacriticTest.java ! test/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java ! test/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java Changeset: d6fe4e451dfb Author: bagiras Date: 2013-11-13 20:16 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6fe4e451dfb 8028283: Revert JavaDoc changes pushed for JDK-7068423 Reviewed-by: art, serb ! src/share/classes/java/awt/GraphicsDevice.java Changeset: 535f19dd3960 Author: pchelko Date: 2013-11-14 10:52 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/535f19dd3960 8028230: Behavior of SystemFlavorMap.getNativesForFlavor differ from that in Java 7 Reviewed-by: anthony, serb ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java + test/java/awt/datatransfer/DuplicatedNativesTest/DuplicatedNativesTest.java Changeset: 8d17ebcef958 Author: pchelko Date: 2013-11-14 11:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d17ebcef958 8025440: [TEST_BUG] com/sun/awt/SecurityWarning/GetSizeShouldNotReturnZero.java failed since jdk8b108 Reviewed-by: anthony + test/com/sun/awt/SecurityWarning/CustomSecurityManager.java ! test/com/sun/awt/SecurityWarning/GetSizeShouldNotReturnZero.java + test/java/awt/regtesthelpers/CopyClassFile.java Changeset: ca0db77f6d6b Author: lana Date: 2013-11-14 23:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca0db77f6d6b Merge Changeset: fc4ac66aa657 Author: lana Date: 2013-11-15 07:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc4ac66aa657 Merge ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/sun/awt/AppContext.java - src/share/classes/sun/management/OperatingSystemImpl.java - src/share/native/java/lang/ref/Finalizer.c - src/solaris/classes/com/sun/management/OSMBeanFactory.java - src/solaris/classes/com/sun/management/UnixOperatingSystem.java - src/solaris/native/com/sun/management/LinuxOperatingSystem.c - src/solaris/native/com/sun/management/MacosxOperatingSystem.c - src/solaris/native/com/sun/management/SolarisOperatingSystem.c - src/solaris/native/com/sun/management/UnixOperatingSystem_md.c - src/windows/classes/com/sun/management/OSMBeanFactory.java - src/windows/classes/com/sun/management/OperatingSystem.java - src/windows/native/com/sun/management/OperatingSystem_md.c ! test/ProblemList.txt - test/java/lang/management/ThreadMXBean/ThreadStateTest.java - test/java/lang/reflect/Method/DefaultMethodModeling.java - test/java/net/URLPermission/nstest/policy ! test/java/util/regex/RegExTest.java - test/lib/testlibrary/jdk/testlibrary/JdkFinder.java Changeset: 8bc258c021a3 Author: cl Date: 2013-11-21 09:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8bc258c021a3 Added tag jdk8-b117 for changeset fc4ac66aa657 ! .hgtags Changeset: ee3c7ab60373 Author: lana Date: 2013-11-25 09:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee3c7ab60373 Merge ! make/CompileDemos.gmk ! make/SignJars.gmk ! test/ProblemList.txt ! test/tools/launcher/DiacriticTest.java From sean.mullan at oracle.com Mon Nov 25 13:06:43 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 25 Nov 2013 16:06:43 -0500 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: <5293BBE3.7040709@oracle.com> Hi Volker, The security changes look fine. I'm not crazy that we now have to maintain one additional java.security file which is the exact same as java.security-linux, but this is really an existing issue with duplicated content across the java.security files which I will try to fix early in JDK 9: https://bugs.openjdk.java.net/browse/JDK-6997010 Thanks, Sean On 11/20/2013 01:26 PM, Volker Simonis wrote: > Hi, > > this is the second review round for "8024854: Basic changes and files to > build the class library on > AIX". > The previous reviews can be found at the end of this mail in the references > section. > > I've tried to address all the comments and suggestions from the first round > and to further streamline the patch (it perfectly builds on Linux/x86_64, > Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The biggest change > compared to the first review round is the new "aix/" subdirectory which > I've now created under "jdk/src" and which contains AIX-only code. > > The webrev is against our > http://hg.openjdk.java.net/ppc-aix-port/stagerepository which has been > recently synchronised with the jdk8 master: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > > Below (and in the webrev) you can find some comments which explain the > changes to each file. In order to be able to push this big change, I need > the approval of reviewers from the lib, net, svc, 2d, awt and sec groups. > So please don't hesitate to jump at it - there are enough changes for > everybody:) > > Thank you and best regards, > Volker > > *References:* > > The following reviews have been posted so far (thanks Iris for collecting > them :) > > - Alan Bateman (lib): Initial comments (16 Sep [2]) > - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) > - Michael McMahon (net): Initial comments (20 Sept [4]) > - Steffan Larsen (svc): APPROVED (20 Sept [5]) > - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments (15 > Oct [7]) > - Sean Mullan (sec): Initial comments (26 Sept [8]) > > [2]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html > [3]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html > [4]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html > [5]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html > [6]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html > [7]: http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html > [8]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html > > > *Detailed change description:* > > The new "jdk/src/aix" subdirectory contains the following new and > AIX-specific files for now: > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileStore.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/classes/sun/nio/fs/AixFileSystemProvider.java > src/aix/classes/sun/nio/fs/AixNativeDispatcher.java > src/aix/classes/sun/tools/attach/AixAttachProvider.java > src/aix/classes/sun/tools/attach/AixVirtualMachine.java > src/aix/native/java/net/aix_close.c > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/sun/nio/fs/AixNativeDispatcher.c > src/aix/native/sun/tools/attach/AixVirtualMachine.c > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > - Added these two files for AIX relevant utility code. > - Currently these files only contain an implementation of dladdr which > is not available on AIX. > - In the first review round the existing dladdr users in the code either > called the version from the HotSpot on AIX ( > src/solaris/native/sun/awt/awt_LoadLibrary.c) or had a private copy of > the whole implementation (src/solaris/demo/jvmti/hprof/hprof_md.c). This > is now not necessary any more. > > The new file layout required some small changes to the makefiles to make > them aware of the new directory locations: > > makefiles/CompileDemos.gmk > > - Add an extra argument to SetupJVMTIDemo which can be used to pass > additional source locations. > - Currently this is only used on AIX for the AIX porting utilities which > are required by hprof. > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/ServiceabilityLibraries.gmk > > - On AIX add the sources of the AIX porting utilities to the build. They > are required by src/solaris/native/sun/awt/awt_LoadLibrary.c and > src/solaris/demo/jvmti/hprof/hprof_md.c because dladdr is not available > on AIX. > > makefiles/lib/NioLibraries.gmk > > - Make the AIX-build aware of the new NIO source locations under > src/aix/native/sun/nio/. > > makefiles/lib/NetworkingLibraries.gmk > > - Make the AIX-build aware of the new aix_close.c source location under > src/aix/native/java/net/. > > src/share/bin/jli_util.h > > - Define JLI_Lseek on AIX. > > src/share/lib/security/java.security-aix > > - Provide default java.security-aix for AIX based on the latest Linux > version as suggested by Sean Mullan. > > src/share/native/common/check_code.c > > - On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is > legal, but the code in check_code.c does not handles this properly. So > we wrap the two methods on AIX and return a non-NULL pointer even if we > allocate 0 bytes. > > src/share/native/sun/awt/medialib/mlib_sys.c > > - malloc always returns 8-byte aligned pointers on AIX as well. > > src/share/native/sun/awt/medialib/mlib_types.h > > - Add AIX to the list of known platforms. > > src/share/native/sun/font/layout/KernTable.cpp > > - Rename the macro DEBUG to DEBUG_KERN_TABLE because DEBUG is too common > and may be defined in other headers as well as on the command line and > xlc bails out on macro redefinitions with a different value. > > src/share/native/sun/security/ec/impl/ecc_impl.h > > - Define required types and macros on AIX. > > src/solaris/back/exec_md.c > > - AIX behaves like Linux in this case so check for it in the Linux > branch. > > src/solaris/bin/java_md_solinux.c, > src/solaris/bin/java_md_solinux.h > > - On AIX LD_LIBRARY_PATH is called LIBPATH > - Always use LD_LIBRARY_PATH macro instead of using the string " > LD_LIBRARY_PATH" directly to cope with different library path names. > - Add jre/lib//jli to the standard library search path on AIX > because the AIX linker doesn't support the -rpath option. > - Replace #ifdef __linux__ by #ifndef __solaris__ because in this case, > AIX behaves like Linux. > - Removed the definition of JVM_DLL, JAVA_DLL and LD_LIBRARY_PATH from > java_md_solinux.h because the macros are redefined in the corresponding > .c files anyway. > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > - Provide basic fontconfig.propertiesfor AIX. > > src/solaris/classes/java/lang/UNIXProcess.java.aix, > src/aix/classes/sun/tools/attach/AixAttachProvider.java, > src/aix/classes/sun/tools/attach/AixVirtualMachine.java, > src/aix/native/sun/tools/attach/AixVirtualMachine.c > > - Provide AIX specific Java versions, mostly based on the corresponding > Linux versions. > > src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java > src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java > > - Detect AIX operating system and return the corresponding channel and > file system providers. > > src/solaris/classes/sun/nio/ch/Port.java > > - Add a callback function unregisterImpl(int fd) for implementations > that need special handling when fd is removed and call it from > unregister(int > fd). By default the implementation of unregisterImpl(int fd) is empty > except for the derived AixPollPort class on AIX. > > src/solaris/demo/jvmti/hprof/hprof_md.c > > - Add AIX support. AIX mostly behaves like Linux, with the one exception > that it has no dladdr functionality. > - Use the dladdr implementation from porting_aix.{c,h} on AIX. > > src/solaris/native/com/sun/management/UnixOperatingSystem_md.c > > - Adapt for AIX (i.e. use libperfstat on AIX to query OS memory). > > src/solaris/native/common/jdk_util_md.h > > - Add AIX definitions of the ISNANF and ISNAND macros. > > src/solaris/native/java/io/io_util_md.c > > - AIX behaves like Linux in this case so check for it in the Linux > branch. > > src/solaris/native/java/lang/UNIXProcess_md.c > > - AIX behaves mostly like Solraris in this case so adjust the ifdefs > accordingly. > > src/solaris/native/java/lang/childproc.c > > - AIX does not understand '/proc/self' - it requires the real process ID > to query the proc file system for the current process. > > src/solaris/native/java/net/NetworkInterface.c > > - Add AIX support into the Linux branch because AIX mostly behaves like > AIX for IPv4. > - AIX needs a special function to enumerate IPv6 interfaces and to query > the MAC address. > - Moved the declaration of siocgifconfRequest to the beginning a the > function (as recommend by Michael McMahon) to remain C89 compatible. > > src/solaris/native/java/net/PlainSocketImpl.c > > - On AIX (like on Solaris) setsockopt will set errno to EINVAL if the > socket is closed. The default error message is then confusing. > > src/aix/native/java/net/aix_close.c, > src/share/native/java/net/net_util.c > > - As recommended by Michael McMahon and Alan Bateman I've move an > adapted version of linux_close.c to > src/aix/native/java/net/aix_close.cbecause we also need the file and > socket wrappers on AIX. > - Compared to the Linux version, we've added the initialization of some > previously uninitialized data structures. > - Also, on AIX we don't have __attribute((constructor)) so we need to > initialize manually (from JNI_OnLoad() in > src/share/native/java/net/net_util.c. > > src/solaris/native/java/net/net_util_md.h > > - AIX needs the same workaround for I/O cancellation like Linux and > MacOSX. > > src/solaris/native/java/net/net_util_md.c > > - SO_REUSEADDR is called SO_REUSEPORT on AIX. > - On AIX we have to ignore failures due to ENOBUFS when setting the > SO_SNDBUF/SO_RCVBUF socket options. > > src/solaris/native/java/util/TimeZone_md.c > > - Currently on AIX the only way to get the platform time zone is to read > it from the TZ environment variable. > > src/solaris/native/sun/awt/awt_LoadLibrary.c > > - Use the dladdr from porting_aix.{c,h} on AIX. > > src/solaris/native/sun/awt/fontpath.c > > - Changed some macros from if !defined(__linux__) to if > defined(__solaris__) because that's their real meaning. > - Add AIX specific fontpath settings and library search paths for > libfontconfig.so. > > src/solaris/native/sun/java2d/x11/X11SurfaceData.c > > - Rename the MIN and MAX macros to XSD_MIN and XSD_MAX to avoid name > clashes (MIN and MAX are much too common and thexy are already defined > in some AIX system headers). > > src/solaris/native/sun/java2d/x11/XRBackendNative.c > > - Handle AIX like Solaris. > > src/solaris/native/sun/nio/ch/Net.c > > - Add AIX-specific includes and constant definitions. > - On AIX "socket extensions for multicast source filters" support > depends on the OS version. Check for this and throw appropriate exceptions > if it is requested but not supported. This is needed to pass > JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast > > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > > - On AIX strerror() is not thread-safe so we have to use strerror_r()instead. > - On AIX readdir_r() returns EBADF (i.e. '9') and sets 'result' to NULL > for the directory stream end. Otherwise, 'errno' will contain the error > code. > - Handle some AIX corner cases for the results of the statvfs64() call. > - On AIX getgrgid_r() returns ESRCH if group does not exist. > > src/solaris/native/sun/security/pkcs11/j2secmod_md.c > > - Use RTLD_LAZY instead of RTLD_NOLOAD on AIX. > > test/java/lang/ProcessBuilder/Basic.java > test/java/lang/ProcessBuilder/DestroyTest.java > > - Port this test to AIX and make it more robust (i.e. recognize the "C" > locale as isEnglish(), ignore VM-warnings in the output, make sure the > "grandchild" processes created by the test don't run too long (60s vs. > 6666s) because in the case of test problems these processes will pollute > the process space, make sure the test fails with an error and doesn't hang > indefinitley in the case of a problem). > > *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this > intended? > > Well, _AIX is defined in some system headers while AIX is defined by the > build system. This is already used inconsistently (i.e. __linux__ vs. LINUX) > and in general I try to be consistent with the style of the file where I > the changes are. That said, I changes most of the occurences of AIX to _AIX. > > > *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are > they supposed to be there? > > We currently don't support OS/400 (later renamed into i5/OS and currently > called IBM i) in our OpenJDK port but we do support it in our internel, SAP > JVM build. We stripped out all the extra OS/400 functionality from the port > but in some places where there is common functionality needd by both, AIX > and OS/400 the OS/400 support may still be visible in the OpenJDK port. I > don't think this is a real problem and it helps us to keep our internel > sources in sync with the OpenJDK port. That said, I think I've removed all > the references to OS/400 now. > From valerie.peng at oracle.com Mon Nov 25 14:49:50 2013 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Mon, 25 Nov 2013 22:49:50 +0000 Subject: hg: jdk8/tl/jdk: 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init() Message-ID: <20131125225013.32D1362839@hg.openjdk.java.net> Changeset: 8d5a9245b9ca Author: valeriep Date: 2013-11-25 11:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d5a9245b9ca 7200306: SunPKCS11 provider delays the check of DSA key size for SHA1withDSA to sign() instead of init() Summary: Add key length checks to P11Signature class Reviewed-by: mullan ! src/share/classes/sun/security/pkcs11/P11Signature.java ! src/share/classes/sun/security/pkcs11/Token.java + test/sun/security/pkcs11/Signature/TestDSAKeyLength.java From huizhe.wang at oracle.com Mon Nov 25 16:58:34 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 26 Nov 2013 00:58:34 +0000 Subject: hg: jdk8/tl/jdk: 8027973: javax/xml/jaxp/transform/jdk8004476/XSLTExFuncTest.java hangs (win) Message-ID: <20131126005849.E0B5E62846@hg.openjdk.java.net> Changeset: 0bf3a58a1783 Author: joehw Date: 2013-11-25 16:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0bf3a58a1783 8027973: javax/xml/jaxp/transform/jdk8004476/XSLTExFuncTest.java hangs (win) Reviewed-by: alanb, dfuchs, joehw Contributed-by: patrick.zhang at oracle.com + test/javax/xml/jaxp/transform/8004476/SecureProcessingTest.xml + test/javax/xml/jaxp/transform/8004476/TestBase.java + test/javax/xml/jaxp/transform/8004476/XPathExFuncTest.java + test/javax/xml/jaxp/transform/8004476/XSLTExFuncTest.java + test/javax/xml/jaxp/transform/8004476/tokenize.xml + test/javax/xml/jaxp/transform/8004476/tokenize.xsl - test/javax/xml/jaxp/transform/jdk8004476/SecureProcessingTest.xml - test/javax/xml/jaxp/transform/jdk8004476/TestBase.java - test/javax/xml/jaxp/transform/jdk8004476/XPathExFuncTest.java - test/javax/xml/jaxp/transform/jdk8004476/XSLTExFuncTest.java - test/javax/xml/jaxp/transform/jdk8004476/tokenize.xml - test/javax/xml/jaxp/transform/jdk8004476/tokenize.xsl From jonathan.gibbons at oracle.com Mon Nov 25 17:45:23 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 26 Nov 2013 01:45:23 +0000 Subject: hg: jdk8/tl/langtools: 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules Message-ID: <20131126014526.64AEE62847@hg.openjdk.java.net> Changeset: a78f51d6bd5e Author: jjg Date: 2013-11-25 17:42 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a78f51d6bd5e 8028318: [doclint] doclint will reject existing user-written doc comments using custom tags that follow the recommended rules Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! test/tools/doclint/CustomTagTest.java ! test/tools/doclint/CustomTagTest.out ! test/tools/doclint/CustomTagTestWithOption.out From yuka.kamiya at oracle.com Mon Nov 25 21:51:08 2013 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Tue, 26 Nov 2013 05:51:08 +0000 Subject: hg: jdk8/tl/jdk: 8029057: test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError Message-ID: <20131126055121.962F06284F@hg.openjdk.java.net> Changeset: 4d9078b1f25b Author: peytoia Date: 2013-11-26 14:49 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d9078b1f25b 8029057: test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError Reviewed-by: okutsu - test/java/text/Bidi/Bug6665028.java From joel.franck at oracle.com Tue Nov 26 04:41:42 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 26 Nov 2013 12:41:42 +0000 Subject: hg: jdk8/tl/langtools: 8028428: strictfp allowed as annotation element modifier Message-ID: <20131126124146.5D77562860@hg.openjdk.java.net> Changeset: 3ea55d523981 Author: jfranck Date: 2013-11-26 13:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ea55d523981 8028428: strictfp allowed as annotation element modifier Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java + test/tools/javac/annotations/AnnotationTypeElementModifiers.java + test/tools/javac/annotations/AnnotationTypeElementModifiers.out From jan.lahoda at oracle.com Tue Nov 26 06:40:55 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Tue, 26 Nov 2013 14:40:55 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20131126144102.1944F62864@hg.openjdk.java.net> Changeset: 8acb838c9b79 Author: jlahoda Date: 2013-11-26 15:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8acb838c9b79 8026374: javac accepts void as a method parameter Summary: Changing Check.validate to reject void types. Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/declaration/method/MethodVoidParameter.java + test/tools/javac/declaration/method/MethodVoidParameter.out Changeset: 756ae3791c45 Author: jlahoda Date: 2013-11-26 15:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/756ae3791c45 8027789: Access method for Outer.super.m() references indirect superclass Summary: Internally convert the qualified super access to an equivalent of an unqualified super access inside the access method. Reviewed-by: vromero, jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/expression/_super/NonDirectSuper/Base.java + test/tools/javac/expression/_super/NonDirectSuper/NonDirectSuper.java + test/tools/javac/expression/_super/NonDirectSuper/Target11.java From weijun.wang at oracle.com Tue Nov 26 07:06:29 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 26 Nov 2013 23:06:29 +0800 Subject: RFR: 8029181: ts.sh generates invalid file after JDK-8027026 Message-ID: <5294B8F5.5000606@oracle.com> Please take a look at http://cr.openjdk.java.net/~weijun/8029181/webrev.00/ Not really harmful, but still an error. Thanks Max From vincent.x.ryan at oracle.com Tue Nov 26 07:35:58 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 26 Nov 2013 15:35:58 +0000 Subject: RFR: 8029181: ts.sh generates invalid file after JDK-8027026 In-Reply-To: <5294B8F5.5000606@oracle.com> References: <5294B8F5.5000606@oracle.com> Message-ID: <9B01640A-5A83-49CF-B268-DBBD562BDE64@oracle.com> Hello Max, Your fix looks good. Thanks. On 26 Nov 2013, at 15:06, Weijun Wang wrote: > Please take a look at > > http://cr.openjdk.java.net/~weijun/8029181/webrev.00/ > > Not really harmful, but still an error. > > Thanks > Max From sean.mullan at oracle.com Tue Nov 26 07:58:59 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 26 Nov 2013 10:58:59 -0500 Subject: RFR: 8029181: ts.sh generates invalid file after JDK-8027026 In-Reply-To: <5294B8F5.5000606@oracle.com> References: <5294B8F5.5000606@oracle.com> Message-ID: <5294C543.6010006@oracle.com> Looks good, but please make sure to add the "teststabilization" label to the bug before you push. --Sean On 11/26/2013 10:06 AM, Weijun Wang wrote: > Please take a look at > > http://cr.openjdk.java.net/~weijun/8029181/webrev.00/ > > Not really harmful, but still an error. > > Thanks > Max From Alan.Bateman at oracle.com Tue Nov 26 09:03:15 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 26 Nov 2013 17:03:15 +0000 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: <5294D453.5050402@oracle.com> On 26/11/2013 16:23, Volker Simonis wrote: > Hi, > > thanks to everybody for the prompt and helpful reviews. Here comes the > final webrev which incorporates all the corrections and suggestions from > the second review round: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ > > I've successfully build (and run some smoke tests) with these changes on > Linux (x86_32, x86_64, ppc64), Solaris/sparcv9, Windows/x86_64, MacOSX and > AIX (5.3, 7.1). > I've skimmed over the last webrev with focus on: NetworkingLibraries.gmk where I see this is now fixed for all platforms. net_util.* and the platform specific net_util_md.* where I see you've added platformInit so it's much cleaner. UnixNativeDispatcher.c where the error translation is now removed (and looks fine). So overall it looks good to me and should be pushed to the staging forest once you hear from others that commented previously. -Alan From weijun.wang at oracle.com Tue Nov 26 15:13:02 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 27 Nov 2013 07:13:02 +0800 Subject: RFR: 8029181: ts.sh generates invalid file after JDK-8027026 In-Reply-To: <5294C543.6010006@oracle.com> References: <5294B8F5.5000606@oracle.com> <5294C543.6010006@oracle.com> Message-ID: <52952AFE.2030305@oracle.com> I can do that. Is "teststabilization" equivalent to "noreg-self" now? I thought it is used by a test that intermittently fails, at least that fails. --Max On 11/26/13, 23:58, Sean Mullan wrote: > Looks good, but please make sure to add the "teststabilization" label to > the bug before you push. > > --Sean > > On 11/26/2013 10:06 AM, Weijun Wang wrote: >> Please take a look at >> >> http://cr.openjdk.java.net/~weijun/8029181/webrev.00/ >> >> Not really harmful, but still an error. >> >> Thanks >> Max > From lana.steuck at oracle.com Tue Nov 26 16:12:00 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 27 Nov 2013 00:12:00 +0000 Subject: hg: jdk8/tl/hotspot: 15 new changesets Message-ID: <20131127001231.9F49462895@hg.openjdk.java.net> Changeset: 854a42db7069 Author: amurillo Date: 2013-11-15 07:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/854a42db7069 8028444: new hotspot build - hs25-b60 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 570aaefce624 Author: morris Date: 2013-11-18 12:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/570aaefce624 8028319: ConflictingDefaultsTest.testReabstract spins when running with -mode invoke and -Xcomp Summary: Change _abstract_method_handler to return AbstractMethodError i2c, c2i and c2iv entries. Reviewed-by: kvn, vlivanov ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 938e1e64e28f Author: anoll Date: 2013-11-14 19:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/938e1e64e28f 8028306: nsk stress tests, CodeCache fills, then safepoint asserts Summary: Move handle_full_code_cache() out of block that forbids safepoints Reviewed-by: kvn, iveresov ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/runtime/sweeper.cpp Changeset: fca8f4799229 Author: roland Date: 2013-11-20 12:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fca8f4799229 8028308: nsk regression, assert(obj->is_oop()) failed: not an oop Summary: rbp not restored when stack overflow is thrown from deopt/uncommon trap blobs Reviewed-by: kvn, iveresov ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp + test/compiler/uncommontrap/TestStackBangRbp.java Changeset: cdf20166ec45 Author: minqi Date: 2013-11-13 16:24 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cdf20166ec45 8025632: Remove all references to MagicLambdaImpl from Hotspot Summary: MagicLambdaImpl was removed from jdk side, this should be done in vm side too Reviewed-by: coleenp, hseigel, rdurbin ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/reflection.cpp ! test/compiler/jsr292/ConcurrentClassLoadingTest.java Changeset: 3edddbff4865 Author: minqi Date: 2013-11-13 16:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3edddbff4865 Merge Changeset: b03f33670080 Author: sla Date: 2013-11-14 19:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b03f33670080 6606002: jinfo doesn't detect dynamic vm flags changing Reviewed-by: coleenp, jbachorik, sspitsyn ! agent/src/share/classes/sun/jvm/hotspot/tools/JInfo.java Changeset: 5280822ddfcd Author: sla Date: 2013-11-14 20:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5280822ddfcd 6626412: jstack using SA prints some info messages into err stream Reviewed-by: coleenp, farvidsson, jbachorik, dsamersoff, sspitsyn ! agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java Changeset: 438fe38c63c8 Author: mgronlun Date: 2013-11-15 21:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/438fe38c63c8 Merge ! src/share/vm/runtime/globals.hpp Changeset: d61a1a166f44 Author: coleenp Date: 2013-11-15 17:20 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d61a1a166f44 8028347: Rewriter::scan_method asserts with array oob in RT_Baseline Summary: Fix reversing rewriting for invokespecial Reviewed-by: jrose, hseigel ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp Changeset: 0b9ea9a72436 Author: sla Date: 2013-11-18 10:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0b9ea9a72436 8027630: SIGSEGV in const char*Klass::external_name() Reviewed-by: coleenp, sspitsyn, mgronlun ! src/share/vm/classfile/metadataOnStackMark.cpp ! src/share/vm/services/threadService.cpp ! src/share/vm/services/threadService.hpp Changeset: 396564992823 Author: sgabdura Date: 2013-11-18 08:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/396564992823 8028341: PSR:FUNC: SCOPE PARAMETER MISSING FROM THE -XX:+PRINTFLAGSFINAL Reviewed-by: dcubed, sla ! src/share/vm/runtime/globals.cpp Changeset: aa933e6b061d Author: mgronlun Date: 2013-11-22 20:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aa933e6b061d Merge Changeset: abad3b2d905d Author: amurillo Date: 2013-11-22 13:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/abad3b2d905d Merge Changeset: c9f439732b18 Author: amurillo Date: 2013-11-22 13:34 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c9f439732b18 Added tag hs25-b60 for changeset abad3b2d905d ! .hgtags From rajan.halade at oracle.com Tue Nov 26 17:13:32 2013 From: rajan.halade at oracle.com (Rajan Halade) Date: Tue, 26 Nov 2013 17:13:32 -0800 Subject: Code Review Request: 8021418 Message-ID: <5295473C.9090508@oracle.com> May I request you to review this simple change - http://cr.openjdk.java.net/~juh/rajan/8021418/ The test is modified to set SO_REUSEADDR on ServerSocket to false for stabilization. Thanks, Rajan From bradford.wetmore at oracle.com Tue Nov 26 17:20:10 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Tue, 26 Nov 2013 17:20:10 -0800 Subject: Code Review Request: 8025763 In-Reply-To: <5265A119.1060606@oracle.com> References: <52606140.1060204@oracle.com> <52618F88.5000803@oracle.com> <5261F3E5.9060409@oracle.com> <5265A119.1060606@oracle.com> Message-ID: <529548CA.8030008@oracle.com> Tony, I note the @since's are missing for the new methods, both in the generated output in the overridden methods (i.e. no javadoc), and the methods in which you've changed the behavior (i.e. new javadoc). I'm not sure what you can do about the previous behavior (cc'ing Mike/Sowmya, maybe they know), but what about the new ones? Brad On 10/21/2013 2:48 PM, Sean Mullan wrote: > On 10/18/2013 10:52 PM, Anthony Scarpino wrote: >> I've updated the webrev >> >> http://cr.openjdk.java.net/~ascarpino/8025763/webrev.01/ > > Update looks good. > > --Sean From weijun.wang at oracle.com Tue Nov 26 17:57:12 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 27 Nov 2013 01:57:12 +0000 Subject: hg: jdk8/tl/jdk: 8029181: ts.sh generates invalid file after JDK-8027026 Message-ID: <20131127015726.CB73162897@hg.openjdk.java.net> Changeset: 1738dfb0c52a Author: weijun Date: 2013-11-27 09:56 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1738dfb0c52a 8029181: ts.sh generates invalid file after JDK-8027026 Reviewed-by: vinnie, mullan ! test/sun/security/tools/jarsigner/TimestampCheck.java From xuelei.fan at oracle.com Tue Nov 26 18:09:38 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 27 Nov 2013 10:09:38 +0800 Subject: Code Review Request: 8021418 In-Reply-To: <5295473C.9090508@oracle.com> References: <5295473C.9090508@oracle.com> Message-ID: <52955462.6050406@oracle.com> This change looks fine. JSSE regression tests use a lot of code as "new ServerSocket(0)", we may want a cleanup for test stabilization. Xuelei On 11/27/2013 9:13 AM, Rajan Halade wrote: > May I request you to review this simple change - > > http://cr.openjdk.java.net/~juh/rajan/8021418/ > > > The test is modified to set SO_REUSEADDR on ServerSocket to false for > stabilization. > > Thanks, > Rajan From rajan.halade at oracle.com Tue Nov 26 18:42:33 2013 From: rajan.halade at oracle.com (Rajan Halade) Date: Tue, 26 Nov 2013 18:42:33 -0800 Subject: Code Review Request: 8021418 In-Reply-To: <52955462.6050406@oracle.com> References: <5295473C.9090508@oracle.com> <52955462.6050406@oracle.com> Message-ID: <52955C19.4040908@oracle.com> On 11/26/2013 18:09, Xuelei Fan wrote: > This change looks fine. thanks! > > JSSE regression tests use a lot of code as "new ServerSocket(0)", we may > want a cleanup for test stabilization. I will look at regression tests and file separate bug for it. - Rajan > > Xuelei > > On 11/27/2013 9:13 AM, Rajan Halade wrote: >> May I request you to review this simple change - >> >> http://cr.openjdk.java.net/~juh/rajan/8021418/ >> >> >> The test is modified to set SO_REUSEADDR on ServerSocket to false for >> stabilization. >> >> Thanks, >> Rajan From volker.simonis at gmail.com Fri Nov 22 02:45:25 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 22 Nov 2013 11:45:25 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: We've synced our staging repository yesterday with the latest jdk8-b117 and I noticed that change "8025985: com.sun.management.OSMBeanFactory should not be public" moved the file src/solaris/native/com/sun/ management/UnixOperatingSystem_md.c to src/solaris/native/sun/management/OperatingSystemImpl.c. Fortunately, my changes to UnixOperatingSystem_md.c described in the webrev apply cleanly to the new file (I've tested this locally). I'll update the webrev accordingly once I've collected some more feedback. Thank you and best regards, Volker On Wed, Nov 20, 2013 at 7:26 PM, Volker Simonis wrote: > Hi, > > this is the second review round for "8024854: Basic changes and files to > build the class library on AIX". > The previous reviews can be found at the end of this mail in the references > section. > > I've tried to address all the comments and suggestions from the first > round and to further streamline the patch (it perfectly builds on > Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The > biggest change compared to the first review round is the new "aix/" > subdirectory which I've now created under "jdk/src" and which contains > AIX-only code. > > The webrev is against our http://hg.openjdk.java.net/ppc-aix-port/stagerepository which has been recently synchronised with the jdk8 master: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > > Below (and in the webrev) you can find some comments which explain the > changes to each file. In order to be able to push this big change, I need > the approval of reviewers from the lib, net, svc, 2d, awt and sec groups. > So please don't hesitate to jump at it - there are enough changes for > everybody:) > > Thank you and best regards, > Volker > > *References:* > > The following reviews have been posted so far (thanks Iris for collecting > them :) > > - Alan Bateman (lib): Initial comments (16 Sep [2]) > - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) > - Michael McMahon (net): Initial comments (20 Sept [4]) > - Steffan Larsen (svc): APPROVED (20 Sept [5]) > - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments > (15 Oct [7]) > - Sean Mullan (sec): Initial comments (26 Sept [8]) > > [2]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html > [3]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html > [4]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html > [5]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html > [6]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html > [7]: > http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html > [8]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html > > > *Detailed change description:* > > The new "jdk/src/aix" subdirectory contains the following new and > AIX-specific files for now: > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileStore.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/classes/sun/nio/fs/AixFileSystemProvider.java > src/aix/classes/sun/nio/fs/AixNativeDispatcher.java > src/aix/classes/sun/tools/attach/AixAttachProvider.java > src/aix/classes/sun/tools/attach/AixVirtualMachine.java > src/aix/native/java/net/aix_close.c > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/sun/nio/fs/AixNativeDispatcher.c > src/aix/native/sun/tools/attach/AixVirtualMachine.c > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > - Added these two files for AIX relevant utility code. > - Currently these files only contain an implementation of dladdr which > is not available on AIX. > - In the first review round the existing dladdr users in the code > either called the version from the HotSpot on AIX ( > src/solaris/native/sun/awt/awt_LoadLibrary.c) or had a private copy of > the whole implementation (src/solaris/demo/jvmti/hprof/hprof_md.c). > This is now not necessary any more. > > The new file layout required some small changes to the makefiles to make > them aware of the new directory locations: > > makefiles/CompileDemos.gmk > > - Add an extra argument to SetupJVMTIDemo which can be used to pass > additional source locations. > - Currently this is only used on AIX for the AIX porting utilities > which are required by hprof. > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/ServiceabilityLibraries.gmk > > - On AIX add the sources of the AIX porting utilities to the build. > They are required by src/solaris/native/sun/awt/awt_LoadLibrary.c and > src/solaris/demo/jvmti/hprof/hprof_md.c because dladdr is not > available on AIX. > > makefiles/lib/NioLibraries.gmk > > - Make the AIX-build aware of the new NIO source locations under > src/aix/native/sun/nio/. > > makefiles/lib/NetworkingLibraries.gmk > > - Make the AIX-build aware of the new aix_close.c source location > under src/aix/native/java/net/. > > src/share/bin/jli_util.h > > - Define JLI_Lseek on AIX. > > src/share/lib/security/java.security-aix > > - Provide default java.security-aix for AIX based on the latest Linux > version as suggested by Sean Mullan. > > src/share/native/common/check_code.c > > - On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is > legal, but the code in check_code.c does not handles this properly. So > we wrap the two methods on AIX and return a non-NULL pointer even if we > allocate 0 bytes. > > src/share/native/sun/awt/medialib/mlib_sys.c > > - malloc always returns 8-byte aligned pointers on AIX as well. > > src/share/native/sun/awt/medialib/mlib_types.h > > - Add AIX to the list of known platforms. > > src/share/native/sun/font/layout/KernTable.cpp > > - Rename the macro DEBUG to DEBUG_KERN_TABLE because DEBUG is too > common and may be defined in other headers as well as on the command line > and xlc bails out on macro redefinitions with a different value. > > src/share/native/sun/security/ec/impl/ecc_impl.h > > - Define required types and macros on AIX. > > src/solaris/back/exec_md.c > > - AIX behaves like Linux in this case so check for it in the Linux > branch. > > src/solaris/bin/java_md_solinux.c, > src/solaris/bin/java_md_solinux.h > > - On AIX LD_LIBRARY_PATH is called LIBPATH > - Always use LD_LIBRARY_PATH macro instead of using the string " > LD_LIBRARY_PATH" directly to cope with different library path names. > - Add jre/lib//jli to the standard library search path on AIX > because the AIX linker doesn't support the -rpath option. > - Replace #ifdef __linux__ by #ifndef __solaris__ because in this > case, AIX behaves like Linux. > - Removed the definition of JVM_DLL, JAVA_DLL and LD_LIBRARY_PATH from > java_md_solinux.h because the macros are redefined in the > corresponding .c files anyway. > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > - Provide basic fontconfig.propertiesfor AIX. > > src/solaris/classes/java/lang/UNIXProcess.java.aix, > src/aix/classes/sun/tools/attach/AixAttachProvider.java, > src/aix/classes/sun/tools/attach/AixVirtualMachine.java, > src/aix/native/sun/tools/attach/AixVirtualMachine.c > > - Provide AIX specific Java versions, mostly based on the > corresponding Linux versions. > > src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java > src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java > > - Detect AIX operating system and return the corresponding channel and > file system providers. > > src/solaris/classes/sun/nio/ch/Port.java > > - Add a callback function unregisterImpl(int fd) for implementations > that need special handling when fd is removed and call it from unregister(int > fd). By default the implementation of unregisterImpl(int fd) is empty > except for the derived AixPollPort class on AIX. > > src/solaris/demo/jvmti/hprof/hprof_md.c > > - Add AIX support. AIX mostly behaves like Linux, with the one > exception that it has no dladdr functionality. > - Use the dladdr implementation from porting_aix.{c,h} on AIX. > > src/solaris/native/com/sun/management/UnixOperatingSystem_md.c > > - Adapt for AIX (i.e. use libperfstat on AIX to query OS memory). > > src/solaris/native/common/jdk_util_md.h > > - Add AIX definitions of the ISNANF and ISNAND macros. > > src/solaris/native/java/io/io_util_md.c > > - AIX behaves like Linux in this case so check for it in the Linux > branch. > > src/solaris/native/java/lang/UNIXProcess_md.c > > - AIX behaves mostly like Solraris in this case so adjust the ifdefs > accordingly. > > src/solaris/native/java/lang/childproc.c > > - AIX does not understand '/proc/self' - it requires the real process > ID to query the proc file system for the current process. > > src/solaris/native/java/net/NetworkInterface.c > > - Add AIX support into the Linux branch because AIX mostly behaves > like AIX for IPv4. > - AIX needs a special function to enumerate IPv6 interfaces and to > query the MAC address. > - Moved the declaration of siocgifconfRequest to the beginning a the > function (as recommend by Michael McMahon) to remain C89 compatible. > > src/solaris/native/java/net/PlainSocketImpl.c > > - On AIX (like on Solaris) setsockopt will set errno to EINVAL if the > socket is closed. The default error message is then confusing. > > src/aix/native/java/net/aix_close.c, > src/share/native/java/net/net_util.c > > - As recommended by Michael McMahon and Alan Bateman I've move an > adapted version of linux_close.c to src/aix/native/java/net/aix_close.cbecause we also need the file and socket wrappers on AIX. > - Compared to the Linux version, we've added the initialization of > some previously uninitialized data structures. > - Also, on AIX we don't have __attribute((constructor)) so we need to > initialize manually (from JNI_OnLoad() in > src/share/native/java/net/net_util.c. > > src/solaris/native/java/net/net_util_md.h > > - AIX needs the same workaround for I/O cancellation like Linux and > MacOSX. > > src/solaris/native/java/net/net_util_md.c > > - SO_REUSEADDR is called SO_REUSEPORT on AIX. > - On AIX we have to ignore failures due to ENOBUFS when setting the > SO_SNDBUF/SO_RCVBUF socket options. > > src/solaris/native/java/util/TimeZone_md.c > > - Currently on AIX the only way to get the platform time zone is to > read it from the TZ environment variable. > > src/solaris/native/sun/awt/awt_LoadLibrary.c > > - Use the dladdr from porting_aix.{c,h} on AIX. > > src/solaris/native/sun/awt/fontpath.c > > - Changed some macros from if !defined(__linux__) to if > defined(__solaris__) because that's their real meaning. > - Add AIX specific fontpath settings and library search paths for > libfontconfig.so. > > src/solaris/native/sun/java2d/x11/X11SurfaceData.c > > - Rename the MIN and MAX macros to XSD_MIN and XSD_MAX to avoid name > clashes (MIN and MAX are much too common and thexy are already defined > in some AIX system headers). > > src/solaris/native/sun/java2d/x11/XRBackendNative.c > > - Handle AIX like Solaris. > > src/solaris/native/sun/nio/ch/Net.c > > - Add AIX-specific includes and constant definitions. > - On AIX "socket extensions for multicast source filters" support > depends on the OS version. Check for this and throw appropriate exceptions > if it is requested but not supported. This is needed to pass > JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast > > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > > - On AIX strerror() is not thread-safe so we have to use strerror_r()instead. > - On AIX readdir_r() returns EBADF (i.e. '9') and sets 'result' to > NULL for the directory stream end. Otherwise, 'errno' will contain the > error code. > - Handle some AIX corner cases for the results of the statvfs64() call. > - On AIX getgrgid_r() returns ESRCH if group does not exist. > > src/solaris/native/sun/security/pkcs11/j2secmod_md.c > > - Use RTLD_LAZY instead of RTLD_NOLOAD on AIX. > > test/java/lang/ProcessBuilder/Basic.java > test/java/lang/ProcessBuilder/DestroyTest.java > > - Port this test to AIX and make it more robust (i.e. recognize the > "C" locale as isEnglish(), ignore VM-warnings in the output, make sure > the "grandchild" processes created by the test don't run too long (60s vs. > 6666s) because in the case of test problems these processes will pollute > the process space, make sure the test fails with an error and doesn't hang > indefinitley in the case of a problem). > > *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this > intended? > > Well, _AIX is defined in some system headers while AIX is defined by the > build system. This is already used inconsistently (i.e. __linux__ vs. > LINUX) and in general I try to be consistent with the style of the file > where I the changes are. That said, I changes most of the occurences of > AIX to _AIX. > > *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are > they supposed to be there? > > We currently don't support OS/400 (later renamed into i5/OS and currently > called IBM i) in our OpenJDK port but we do support it in our internel, SAP > JVM build. We stripped out all the extra OS/400 functionality from the port > but in some places where there is common functionality needd by both, AIX > and OS/400 the OS/400 support may still be visible in the OpenJDK port. I > don't think this is a real problem and it helps us to keep our internel > sources in sync with the OpenJDK port. That said, I think I've removed all > the references to OS/400 now. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131122/c71b0541/attachment-0001.html From volker.simonis at gmail.com Fri Nov 22 08:37:55 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 22 Nov 2013 17:37:55 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <528F5B28.7000404@oracle.com> References: <528DF61B.6060403@oracle.com> <528F5B28.7000404@oracle.com> Message-ID: Hi Alan, so I'll rename 'initLocalAddrTable()' into 'platformInit()' and move the call to 'aix_close_init' to a AIX-specific version of 'platformInit()' in net_util_md.c as discussed. I'll post a final webrev once I got the comments from the AWT/2D guys. As far as I understood, you've now reviewed the 'core-lib'/'net' parts right? That would mean that I'll still need a review from the AWT/2D and the Security group - any volunteers:). Once again thanks a lot for your help, Volker On Fri, Nov 22, 2013 at 2:24 PM, Alan Bateman wrote: > On 21/11/2013 15:54, Volker Simonis wrote: > > : > But actually I've just realized that it is not need at all, because > 'aix_close.c' isn't in the PATH for any other OS than AIX (that could be > probably called a feature of the new file layout:) So I'll simply change it > to: > > 48 ifeq ($(OPENJDK_TARGET_OS), aix) > 49 LIBNET_SRC_DIRS += $(JDK_TOPDIR)/src/aix/native/java/net/ > 50 endif > > This make sense. > > > > > Yes, exactly. I didn't wanted to change too much code. But as the C-Standard > states > (http://pubs.opengroup.org/onlinepubs/000095399/functions/malloc.html) > "...If size is 0, either a null pointer or a unique pointer that can be > successfully passed to free() shall be returned..." it is perfectly legal > that malloc/calloc return a NULL pointer if called with a zero argument. > This case is currently not handled (i.e. it's handled as an 'out of memory' > error) in check_code.c and I agree that this should be fixed via a separate > bug. > > Yes, let's use a separate bug for this. > > > > > >> >> In net_util.c then it's a bit ugly to be calling aix_close_init. >> Michael/Chris - what you would think about the JNI_OnLoad calling into a >> platform specific function to do platform specific initialization? >> > > What about renaming 'initLocalAddrTable()' into something like > 'platformInit()' and moving the call to 'aix_close_init' to a AIX-specific > version of 'platformInit()' in net_util_md.c? > > I don't have a strong opinion on the name of the function, platformInit is > fine for now. > > > > : > > > You're right - we could rename it to something like 'java_md_unix.c'. But no > matter how fancy the name would be, the file would still be in the > 'src/solaris/bin' subdirectory:( So I think we'd better leave this for a > later change when we completely factor out the Linux/Mac code from the > 'solaris/' directory. > > I think JDK 9 is a good time to finally tackle this issue (as you probably > know, this is something that I've brought up on porters-dev or build-dev a > few times). > > > > >> >> Port.java - one suggestion for unregisterImpl is to rename it to >> preUnregister and change it to protected so that it's more obvious that it >> supposed to be overridden. >> > > Done. Also changed the comment to JavaDoc style to be more consistent with > the other comments in that file. > > Thanks. > > > >> >> UnixNativeDispatcher.c - this looks okay (must reduced since the first >> round), I just wonder if the changes to *_getpwuid and *_getgrgid are really >> needed as this just impacts the error message. Also might be good to indent >> the #ifdef to be consistent with the other usages in these functions. >> > > You're right. This change was done before you fixed "7043788: (fs) > PosixFileAttributes.owner() or group() throws NPE if owner/group not in > passwd/group database" > (http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f91c799f7bfb). After you're > fix it was "automatically" adapted. I've removed the special AIX handling > as suggested because I think as well that another error message in the > exception won't have any impact. > > Thanks. > > > > : > > > I'm currently working on it and created "8028537: PPC64: Updated jdk/test > scripts to understand the AIX os and environment" for it because I didn't > wanted to blow up this change unnecessarily. > > Okay. > > So overall I think this patch is in good shape (I have not reviewed the > AWT/2D/client changes in any detail) and I don't see any blocking issues to > this going in. > > -Alan > > > From artem.ananiev at oracle.com Mon Nov 25 07:52:03 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 25 Nov 2013 19:52:03 +0400 Subject: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: <52937223.408@oracle.com> Hi, Volker, just a few very minor comments about the client changes: 1. mlib_sys.c: the change is fine, but it makes the following comment obsolete. 2. XRBackendNative.c: the same comment here. 3. Awt2dLibraries.gmk: $(JDK_TOPDIR)/src/aix/porting/porting_aix.c would be better than just porting_aix.c Thanks, Artem On 11/20/2013 10:26 PM, Volker Simonis wrote: > Hi, > > this is the second review round for "8024854: Basic changes and files to > build the class library on AIX > ". The previous > reviews can be found at the end of this mail in the references section. > > I've tried to address all the comments and suggestions from the first > round and to further streamline the patch (it perfectly builds on > Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The > biggest change compared to the first review round is the new "aix/" > subdirectory which I've now created under "jdk/src" and which contains > AIX-only code. > > The webrev is against our http://hg.openjdk.java.net/ppc-aix-port/stage > repository which has been recently synchronised with the jdk8 master: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > > Below (and in the webrev) you can find some comments which explain the > changes to each file. In order to be able to push this big change, I > need the approval of reviewers from the lib, net, svc, 2d, awt and sec > groups. So please don't hesitate to jump at it - there are enough > changes for everybody:) > > Thank you and best regards, > Volker > > *References:* > > The following reviews have been posted so far (thanks Iris for > collecting them :) > > - Alan Bateman (lib): Initial comments (16 Sep [2]) > - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) > - Michael McMahon (net): Initial comments (20 Sept [4]) > - Steffan Larsen (svc): APPROVED (20 Sept [5]) > - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments > (15 Oct [7]) > - Sean Mullan (sec): Initial comments (26 Sept [8]) > > [2]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html > [3]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html > [4]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html > [5]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html > [6]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html > [7]: http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html > [8]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html > > > *Detailed change description:* > > The new "jdk/src/aix" subdirectory contains the following new and > AIX-specific files for now: > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileStore.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/classes/sun/nio/fs/AixFileSystemProvider.java > src/aix/classes/sun/nio/fs/AixNativeDispatcher.java > src/aix/classes/sun/tools/attach/AixAttachProvider.java > src/aix/classes/sun/tools/attach/AixVirtualMachine.java > src/aix/native/java/net/aix_close.c > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/sun/nio/fs/AixNativeDispatcher.c > src/aix/native/sun/tools/attach/AixVirtualMachine.c > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > * Added these two files for AIX relevant utility code. > * Currently these files only contain an implementation of |dladdr| > which is not available on AIX. > * In the first review round the existing |dladdr| users in the code > either called the version from the HotSpot on AIX > (|src/solaris/native/sun/awt/awt_LoadLibrary.c|) or had a private > copy of the whole implementation > (|src/solaris/demo/jvmti/hprof/hprof_md.c|). This is now not > necessary any more. > > The new file layout required some small changes to the makefiles to make > them aware of the new directory locations: > > > makefiles/CompileDemos.gmk > > * Add an extra argument to |SetupJVMTIDemo| which can be used to pass > additional source locations. > * Currently this is only used on AIX for the AIX porting utilities > which are required by hprof. > > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/ServiceabilityLibraries.gmk > > * On AIX add the sources of the AIX porting utilities to the build. > They are required by |src/solaris/native/sun/awt/awt_LoadLibrary.c| > and |src/solaris/demo/jvmti/hprof/hprof_md.c| because |dladdr| is > not available on AIX. > > > makefiles/lib/NioLibraries.gmk > > * Make the AIX-build aware of the new NIO source locations under > |src/aix/native/sun/nio/|. > > > makefiles/lib/NetworkingLibraries.gmk > > * Make the AIX-build aware of the new |aix_close.c| source location > under |src/aix/native/java/net/|. > > > src/share/bin/jli_util.h > > * Define |JLI_Lseek| on AIX. > > > src/share/lib/security/java.security-aix > > * Provide default |java.security-aix| for AIX based on the latest > Linux version as suggested by Sean Mullan. > > > src/share/native/common/check_code.c > > * On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is > legal, but the code in |check_code.c| does not handles this > properly. So we wrap the two methods on AIX and return a non-NULL > pointer even if we allocate 0 bytes. > > > src/share/native/sun/awt/medialib/mlib_sys.c > > * |malloc| always returns 8-byte aligned pointers on AIX as well. > > > src/share/native/sun/awt/medialib/mlib_types.h > > * Add AIX to the list of known platforms. > > > src/share/native/sun/font/layout/KernTable.cpp > > * Rename the macro |DEBUG| to |DEBUG_KERN_TABLE| because |DEBUG| is > too common and may be defined in other headers as well as on the > command line and |xlc| bails out on macro redefinitions with a > different value. > > > src/share/native/sun/security/ec/impl/ecc_impl.h > > * Define required types and macros on AIX. > > > src/solaris/back/exec_md.c > > * AIX behaves like Linux in this case so check for it in the Linux branch. > > > src/solaris/bin/java_md_solinux.c, > src/solaris/bin/java_md_solinux.h > > * On AIX |LD_LIBRARY_PATH| is called |LIBPATH| > * Always use |LD_LIBRARY_PATH| macro instead of using the string > "|LD_LIBRARY_PATH|" directly to cope with different library path names. > * Add |jre/lib//jli| to the standard library search path on AIX > because the AIX linker doesn't support the |-rpath| option. > * Replace |#ifdef __linux__| by |#ifndef __solaris__| because in this > case, AIX behaves like Linux. > * Removed the definition of |JVM_DLL|, |JAVA_DLL| and > |LD_LIBRARY_PATH| from |java_md_solinux.h| because the macros are > redefined in the corresponding |.c| files anyway. > > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > * Provide basic |fontconfig.properties|for AIX. > > > src/solaris/classes/java/lang/UNIXProcess.java.aix, > src/aix/classes/sun/tools/attach/AixAttachProvider.java, > src/aix/classes/sun/tools/attach/AixVirtualMachine.java, > src/aix/native/sun/tools/attach/AixVirtualMachine.c > > * Provide AIX specific Java versions, mostly based on the > corresponding Linux versions. > > > src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java > src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java > > * Detect AIX operating system and return the corresponding channel and > file system providers. > > > src/solaris/classes/sun/nio/ch/Port.java > > * Add a callback function |unregisterImpl(int fd)| for implementations > that need special handling when |fd| is removed and call it from > |unregister(int fd)|. By default the implementation of > |unregisterImpl(int fd)| is empty except for the derived > |AixPollPort| class on AIX. > > > src/solaris/demo/jvmti/hprof/hprof_md.c > > * Add AIX support. AIX mostly behaves like Linux, with the one > exception that it has no |dladdr| functionality. > * Use the |dladdr| implementation from |porting_aix.{c,h}| on AIX. > > > src/solaris/native/com/sun/management/UnixOperatingSystem_md.c > > * Adapt for AIX (i.e. use |libperfstat| on AIX to query OS memory). > > > src/solaris/native/common/jdk_util_md.h > > * Add AIX definitions of the |ISNANF| and |ISNAND| macros. > > > src/solaris/native/java/io/io_util_md.c > > * AIX behaves like Linux in this case so check for it in the Linux branch. > > > src/solaris/native/java/lang/UNIXProcess_md.c > > * AIX behaves mostly like Solraris in this case so adjust the ifdefs > accordingly. > > > src/solaris/native/java/lang/childproc.c > > * AIX does not understand '/proc/self' - it requires the real process > ID to query the proc file system for the current process. > > > src/solaris/native/java/net/NetworkInterface.c > > * Add AIX support into the Linux branch because AIX mostly behaves > like AIX for IPv4. > * AIX needs a special function to enumerate IPv6 interfaces and to > query the MAC address. > * Moved the declaration of |siocgifconfRequest| to the beginning a the > function (as recommend by Michael McMahon) to remain C89 compatible. > > > src/solaris/native/java/net/PlainSocketImpl.c > > * On AIX (like on Solaris) |setsockopt| will set errno to |EINVAL| if > the socket is closed. The default error message is then confusing. > > > src/aix/native/java/net/aix_close.c, > src/share/native/java/net/net_util.c > > * As recommended by Michael McMahon and Alan Bateman I've move an > adapted version of |linux_close.c| to > |src/aix/native/java/net/aix_close.c| because we also need the file > and socket wrappers on AIX. > * Compared to the Linux version, we've added the initialization of > some previously uninitialized data structures. > * Also, on AIX we don't have |__attribute((constructor))| so we need > to initialize manually (from |JNI_OnLoad()| in > |src/share/native/java/net/net_util.c|. > > > src/solaris/native/java/net/net_util_md.h > > * AIX needs the same workaround for I/O cancellation like Linux and > MacOSX. > > > src/solaris/native/java/net/net_util_md.c > > * |SO_REUSEADDR| is called |SO_REUSEPORT| on AIX. > * On AIX we have to ignore failures due to |ENOBUFS| when setting the > |SO_SNDBUF|/|SO_RCVBUF| socket options. > > > src/solaris/native/java/util/TimeZone_md.c > > * Currently on AIX the only way to get the platform time zone is to > read it from the |TZ| environment variable. > > > src/solaris/native/sun/awt/awt_LoadLibrary.c > > * Use the |dladdr| from |porting_aix.{c,h}| on AIX. > > > src/solaris/native/sun/awt/fontpath.c > > * Changed some macros from |if !defined(__linux__)| to |if > defined(__solaris__)| because that's their real meaning. > * Add AIX specific fontpath settings and library search paths for > |libfontconfig.so|. > > > src/solaris/native/sun/java2d/x11/X11SurfaceData.c > > * Rename the |MIN| and |MAX| macros to |XSD_MIN| and |XSD_MAX| to > avoid name clashes (|MIN| and |MAX| are much too common and thexy > are already defined in some AIX system headers). > > > src/solaris/native/sun/java2d/x11/XRBackendNative.c > > * Handle AIX like Solaris. > > > src/solaris/native/sun/nio/ch/Net.c > > * Add AIX-specific includes and constant definitions. > * On AIX "socket extensions for multicast source filters" support > depends on the OS version. Check for this and throw appropriate > exceptions if it is requested but not supported. This is needed to > pass > JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast > > > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > > * On AIX |strerror()| is not thread-safe so we have to use > |strerror_r()| instead. > * On AIX |readdir_r()| returns EBADF (i.e. '9') and sets 'result' to > NULL for the directory stream end. Otherwise, 'errno' will contain > the error code. > * Handle some AIX corner cases for the results of the |statvfs64()| call. > * On AIX |getgrgid_r()| returns ESRCH if group does not exist. > > > src/solaris/native/sun/security/pkcs11/j2secmod_md.c > > * Use |RTLD_LAZY| instead of |RTLD_NOLOAD| on AIX. > > > test/java/lang/ProcessBuilder/Basic.java > test/java/lang/ProcessBuilder/DestroyTest.java > > * Port this test to AIX and make it more robust (i.e. recognize the > "C" locale as |isEnglish()|, ignore VM-warnings in the output, make > sure the "grandchild" processes created by the test don't run too > long (60s vs. 6666s) because in the case of test problems these > processes will pollute the process space, make sure the test fails > with an error and doesn't hang indefinitley in the case of a problem). > > *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this > intended? > > Well, |_AIX| is defined in some system headers while |AIX| is defined by > the build system. This is already used inconsistently (i.e. |__linux__| > vs. |LINUX|) and in general I try to be consistent with the style of the > file where I the changes are. That said, I changes most of the > occurences of |AIX| to |_AIX|. > > *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are > they supposed to be there? > > We currently don't support OS/400 (later renamed into i5/OS and > currently called IBM i) in our OpenJDK port but we do support it in our > internel, SAP JVM build. We stripped out all the extra OS/400 > functionality from the port but in some places where there is common > functionality needd by both, AIX and OS/400 the OS/400 support may still > be visible in the OpenJDK port. I don't think this is a real problem and > it helps us to keep our internel sources in sync with the OpenJDK port. > That said, I think I've removed all the references to OS/400 now. > > From michael.fang at oracle.com Mon Nov 25 14:15:35 2013 From: michael.fang at oracle.com (michael.fang at oracle.com) Date: Mon, 25 Nov 2013 22:15:35 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20131125221542.D8A6C62830@hg.openjdk.java.net> Changeset: abd44ea60dbe Author: mfang Date: 2013-11-21 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/abd44ea60dbe 8028803: jdk8 l10n resource file translation update 5 - jaxp repo Reviewed-by: joehw, yhuang ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_CN.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_zh_CN.java ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_CN.java ! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_zh_CN.java Changeset: e65463c785ed Author: mfang Date: 2013-11-25 14:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e65463c785ed Merge From volker.simonis at gmail.com Mon Nov 25 14:30:26 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 25 Nov 2013 23:30:26 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <52937223.408@oracle.com> References: <52937223.408@oracle.com> Message-ID: Hi Artem, thanks a lot for your review. Please find my comments inline: On Monday, November 25, 2013, Artem Ananiev wrote: > Hi, Volker, > > just a few very minor comments about the client changes: > > 1. mlib_sys.c: the change is fine, but it makes the following comment > obsolete. You're right. I'll update the comment and try to find a corresponding reference for the AIX compiler. > 2. XRBackendNative.c: the same comment here. Again, I'll update the comment accordingly. > 3. Awt2dLibraries.gmk: $(JDK_TOPDIR)/src/aix/porting/porting_aix.c would > be better than just porting_aix.c Good catch! I think the right solution would be to add $(JDK_TOPDIR)/src/aix/porting to LIBAWT_DIRS. This will also add the directory automatically to LIBAWT_CFLAGS. I'll prepare a final webrev with all the proposed changes tomorrow. Thanks once again, Volker > > Thanks, > > Artem > > On 11/20/2013 10:26 PM, Volker Simonis wrote: > >> Hi, >> >> this is the second review round for "8024854: Basic changes and files to >> build the class library on AIX >> ". The previous >> reviews can be found at the end of this mail in the references section. >> >> I've tried to address all the comments and suggestions from the first >> round and to further streamline the patch (it perfectly builds on >> Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The >> biggest change compared to the first review round is the new "aix/" >> subdirectory which I've now created under "jdk/src" and which contains >> AIX-only code. >> >> The webrev is against our http://hg.openjdk.java.net/ppc-aix-port/stage >> repository which has been recently synchronised with the jdk8 master: >> >> http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ >> >> Below (and in the webrev) you can find some comments which explain the >> changes to each file. In order to be able to push this big change, I >> need the approval of reviewers from the lib, net, svc, 2d, awt and sec >> groups. So please don't hesitate to jump at it - there are enough >> changes for everybody:) >> >> Thank you and best regards, >> Volker >> >> *References:* >> >> The following reviews have been posted so far (thanks Iris for >> collecting them :) >> >> - Alan Bateman (lib): Initial comments (16 Sep [2]) >> - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) >> - Michael McMahon (net): Initial comments (20 Sept [4]) >> - Steffan Larsen (svc): APPROVED (20 Sept [5]) >> - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments >> (15 Oct [7]) >> - Sean Mullan (sec): Initial comments (26 Sept [8]) >> >> [2]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001045.html >> [3]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001078.html >> [4]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001079.html >> [5]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001077.html >> [6]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001069.html >> [7]: http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/ >> 003826.html >> [8]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001081.html >> >> >> *Detailed change description:* >> >> The new "jdk/src/aix" subdirectory contains the following new and >> AIX-specific files for now: >> >> src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties >> src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java >> src/aix/classes/sun/nio/ch/AixPollPort.java >> src/aix/classes/sun/nio/fs/AixFileStore.java >> src/aix/classes/sun/nio/fs/AixFileSystem.java >> src/aix/classes/sun/nio/fs/AixFileSystemProvider.java >> src/aix/classes/sun/nio/fs/AixNativeDispatcher.java >> src/aix/classes/sun/tools/attach/AixAttachProvider.java >> src/aix/classes/sun/tools/attach/AixVirtualMachine.java >> src/aix/native/java/net/aix_close.c >> src/aix/native/sun/nio/ch/AixPollPort.c >> src/aix/native/sun/nio/fs/AixNativeDispatcher.c >> src/aix/native/sun/tools/attach/AixVirtualMachine.c >> src/aix/porting/porting_aix.c >> src/aix/porting/porting_aix.h >> >> >> src/aix/porting/porting_aix.c >> src/aix/porting/porting_aix.h >> >> * Added these two files for AIX relevant utility code. >> * Currently these files only contain an implementation of |dladdr| >> which is not available on AIX. >> * In the first review round the existing |dladdr| users in the code >> either called the version from the HotSpot on AIX >> (|src/solaris/native/sun/awt/awt_LoadLibrary.c|) or had a private >> copy of the whole implementation >> (|src/solaris/demo/jvmti/hprof/hprof_md.c|). This is now not >> necessary any more. >> >> The new file layout required some small changes to the makefiles to make >> them aware of the new directory locations: >> >> >> makefiles/CompileDemos.gmk >> >> * Add an extra argument to |SetupJVMTIDemo| which can be used to pass >> additional source locations. >> * Currently this is only used on AIX for the AIX porting utilities >> which are required by hprof. >> >> >> makefiles/lib/Awt2dLibraries.gmk >> makefiles/lib/ServiceabilityLibraries.gmk >> >> * On AIX add the sources of the AIX porting utilities to the build. >> They are required by |src/solaris/native/sun/awt/awt_LoadLibrary.c| >> and |src/solaris/demo/jvmti/hprof/hprof_md.c| because |dladdr| is >> not available on AIX. >> >> >> makefiles/lib/NioLibraries.gmk >> >> * Make the AIX-build aware of the new NIO source locations under >> |src/aix/native/sun/nio/|. >> >> >> makefiles/lib/NetworkingLibraries.gmk >> >> * Make the AIX-build aware of the new |aix_close.c| source location >> under |src/aix/native/java/net/|. >> >> >> src/share/bin/jli_util.h >> >> * Define |JLI_Lseek| on AIX. >> >> >> src/share/lib/security/java.security-aix >> >> * Provide default |java.security-aix| for AIX based on the latest >> Linux version as suggested by Sean Mullan. >> >> >> src/share/native/common/check_code.c >> >> * On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is >> legal, but the code in |check_code.c| does not handles this >> properly. So we wrap the two methods on AIX and return a non-NULL >> pointer even if we allocate 0 bytes. >> >> >> src/share/native/sun/awt/medialib/mlib_sys.c >> >> * |malloc| always returns 8-byte aligned pointers on AIX as well. >> >> >> src/share/native/sun/awt/medialib/mlib_types.h >> >> * Add AIX to the list of known platforms. >> >> >> src/share/native/sun/font/layout/KernTable.cpp >> >> * Rename the macro |DEBUG| to |DEBUG_KERN_TABLE| because |DEBUG| is >> too common and may be defined in other headers as well as on the >> command line and |xlc| bails out on macro redefinitions with a >> different value. >> >> >> src/share/native/sun/security/ec/impl/ecc_impl.h >> >> * Define required types and macros on AIX. >> >> >> src/solaris/back/exec_md.c >> >> * AIX behaves like Linux in this case so check for it in the Linux >> branch. >> >> >> src/solaris/bin/java_md_solinux.c, >> src/solaris/bin/java_md_solinux.h >> >> * On AIX |LD_LIBRARY_PATH| is called |LIBPATH| >> * Always use |LD_LIBRARY_PATH| macro instead of using the string >> "|LD_LIBRARY_PATH|" directly to cope with different library path >> names. >> * Add |jre/lib//jli| to the standard library search path on AIX >> because the AIX linker doesn't support the |-rpath| option. >> * Replace |#ifdef __linux__| by |#ifndef __solaris__| because in this >> case, AIX behaves like Linux. >> * Removed the definition of |JVM_DLL|, |JAVA_DLL| and >> |LD_LIBRARY_PATH| from |java_md_solinux.h| because the macros are >> redefined in the corresponding |.c| files anyway. >> >> >> src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties >> >> * Provide basic |fontconfig.properties|for AIX. >> >> >> src/solaris/classes/java/lang/UNIXProcess.java.aix, >> src/aix/classes/sun/tools/attach/AixAttachProvider.java, >> src/aix/classes/sun/tools/attach/AixVirtualMachine.java, >> src/aix/native/sun/tools/attach/AixVirtualMachine.c >> >> * Provide AIX specific Java versions, mostly based on the >> corresponding Linux versions. >> >> >> src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProv >> ider.java >> src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java >> >> * Detect AIX operating system and return the corresponding channel and >> file system providers. >> >> >> src/solaris/classes/sun/nio/ch/Port.java >> >> * Add a callback function |unregisterImpl(int fd)| for implementations >> that need special handling when |fd| is removed and call it from >> |unregister(int fd)|. By default the implementation of >> |unregisterImpl(int fd)| is empty except for the derived >> |AixPollPort| class on AIX. >> >> >> src/solaris/demo/jvmti/hprof/hprof_md.c >> >> * Add AIX support. AIX mostly behaves like Linux, with the one >> exception that it has no |dladdr| functionality. >> * Use the |dladdr| implementation from |porting_aix.{c,h}| on AIX. >> >> >> src/solaris/native/com/sun/management/UnixOperatingSystem_md.c >> >> * Adapt for AIX (i.e. use |libperfstat| on AIX to query OS memory). >> >> >> src/solaris/native/common/jdk_util_md.h >> >> * Add AIX definitions of the |ISNANF| and |ISNAND| macros. >> >> >> src/solaris/native/java/io/io_util_md.c >> >> * AIX behaves like Linux in this case so check for it in the Linux >> branch. >> >> >> src/solaris/native/java/lang/UNIXProcess_md.c >> >> * AIX behaves mostly like Solraris in this case so adjust the ifdefs >> accordingly. >> >> >> src/solaris/native/java/lang/childproc.c >> >> * AIX does not understand '/proc/self' - it requires the real process >> ID to query the proc file system for the current process. >> >> >> src/solaris/native/java/net/NetworkInterface.c >> >> * Add AIX support into the Linux branch because AIX mostly behaves >> like AIX for IPv4. >> * AIX needs a special function to enumerate IPv6 interfaces and to >> query the MAC address. >> * Moved the declaration of |siocgifconfRequest| to the beginning a the >> function (as recommend by Michael McMahon) to remain C89 compatible. >> >> >> src/solaris/native/java/net/PlainSocketImpl.c >> >> * On AIX (like on Solaris) |setsockopt| will set errno to |EINVAL| if >> the socket is closed. The default error message is then confusing. >> >> >> src/aix/native/java/net/aix_close.c, >> src/share/native/java/net/net_util.c >> >> * As recommended by Michael McMahon and Alan Bateman I've move an >> adapted version of |linux_close.c| to >> |src/aix/native/java/net/aix_close.c| because we also need the file >> and socket wrappers on AIX. >> * Compared to the Linux version, we've added the initialization of >> some previously uninitialized data structures. >> * Also, on AIX we don't have |__attribute((constructor))| so we need >> to initialize manually (from |JNI_OnLoad()| in >> |src/share/native/java/net/net_util.c|. >> >> >> src/solaris/native/java/net/net_util_md.h >> >> * AIX needs the same workaround for I/O cancellation like Linux and >> MacOSX. >> >> >> src/solaris/native/java/net/net_util_md.c >> >> * |SO_REUSEADDR| is called |SO_REUSEPORT| on AIX. >> * On AIX we have to ignore failures due to |ENOBUFS| when setting the >> |SO_SNDBUF|/|SO_RCVBUF| socket options. >> >> >> src/solaris/native/java/util/TimeZone_md.c >> >> * Currently on AIX the only way to get the platform time zone is to >> read it from the |TZ| environment variable. >> >> >> src/solaris/native/sun/awt/awt_LoadLibrary.c >> >> * Use the |dladdr| from |porting_aix.{c,h}| on AIX. >> >> >> src/solaris/native/sun/awt/fontpath.c >> >> * Changed some macros from |if !defined(__linux__)| to |if >> defined(__solaris__)| because that's their real meaning. >> * Add AIX specific fontpath settings and library search paths for >> |libfontconfig.so|. >> >> >> src/solaris/native/sun/java2d/x11/X11SurfaceData.c >> >> * Rename the |MIN| and |MAX| macros to |XSD_MIN| and |XSD_MAX| to >> avoid name clashes (|MIN| and |MAX| are much too common and thexy >> are already defined in some AIX system headers). >> >> >> src/solaris/native/sun/java2d/x11/XRBackendNative.c >> >> * Handle AIX like Solaris. >> >> >> src/solaris/native/sun/nio/ch/Net.c >> >> * Add AIX-specific includes and constant definitions. >> * On AIX "socket extensions for multicast source filters" support >> depends on the OS version. Check for this and throw appropriate >> exceptions if it is requested but not supported. This is needed to >> pass >> JCK-api/java_nio/channels/DatagramChannel/ >> DatagramChannel.html#Multicast >> >> >> src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c >> >> * On AIX |strerror()| is not thread-safe so we have to use >> |strerror_r()| instead. >> * On AIX |readdir_r()| returns EBADF (i.e. '9') and sets 'result' to >> NULL for the directory stream end. Otherwise, 'errno' will contain >> the error code. >> * Handle some AIX corner cases for the results of the |statvfs64()| >> call. >> * On AIX |getgrgid_r()| returns ESRCH if group does not exist. >> >> >> src/solaris/native/sun/security/pkcs11/j2secmod_md.c >> >> * Use |RTLD_LAZY| instead of |RTLD_NOLOAD| on AIX. >> >> >> test/java/lang/ProcessBuilder/Basic.java >> test/java/lang/ProcessBuilder/DestroyTest.java >> >> * Port this test to AIX and make it more robust (i.e. recognize the >> "C" locale as |isEnglish()|, ignore VM-warnings in the output, make >> sure the "grandchild" processes created by the test don't run too >> long (60s vs. 6666s) because in the case of test problems these >> processes will pollute the process space, make sure the test fails >> with an error and doesn't hang indefinitley in the case of a problem). >> >> *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this >> intended? >> >> Well, |_AIX| is defined in some system headers while |AIX| is defined by >> the build system. This is already used inconsistently (i.e. |__linux__| >> vs. |LINUX|) and in general I try to be consistent with the style of the >> file where I the changes are. That said, I changes most of the >> occurences of |AIX| to |_AIX|. >> >> *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are >> they supposed to be there? >> >> We currently don't support OS/400 (later renamed into i5/OS and >> currently called IBM i) in our OpenJDK port but we do support it in our >> internel, SAP JVM build. We stripped out all the extra OS/400 >> functionality from the port but in some places where there is common >> functionality needd by both, AIX and OS/400 the OS/400 support may still >> be visible in the OpenJDK port. I don't think this is a real problem and >> it helps us to keep our internel sources in sync with the OpenJDK port. >> That said, I think I've removed all the references to OS/400 now. >> >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131125/dfce4466/attachment-0001.html From volker.simonis at gmail.com Mon Nov 25 14:35:33 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 25 Nov 2013 23:35:33 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <5293BBE3.7040709@oracle.com> References: <5293BBE3.7040709@oracle.com> Message-ID: Hi Sean, thanks a lot for you review. Please let me know once you start working on 6997010 so I can update the corresponding AIX file accordingly. Regards, Volker On Monday, November 25, 2013, Sean Mullan wrote: > Hi Volker, > > The security changes look fine. I'm not crazy that we now have to maintain > one additional java.security file which is the exact same as > java.security-linux, but this is really an existing issue with duplicated > content across the java.security files which I will try to fix early in JDK > 9: https://bugs.openjdk.java.net/browse/JDK-6997010 > > Thanks, > Sean > > On 11/20/2013 01:26 PM, Volker Simonis wrote: > >> Hi, >> >> this is the second review round for "8024854: Basic changes and files to >> build the class library on >> AIX". >> The previous reviews can be found at the end of this mail in the >> references >> section. >> >> I've tried to address all the comments and suggestions from the first >> round >> and to further streamline the patch (it perfectly builds on Linux/x86_64, >> Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The biggest change >> compared to the first review round is the new "aix/" subdirectory which >> I've now created under "jdk/src" and which contains AIX-only code. >> >> The webrev is against our >> http://hg.openjdk.java.net/ppc-aix-port/stagerepository which has been >> recently synchronised with the jdk8 master: >> >> http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ >> >> Below (and in the webrev) you can find some comments which explain the >> changes to each file. In order to be able to push this big change, I need >> the approval of reviewers from the lib, net, svc, 2d, awt and sec groups. >> So please don't hesitate to jump at it - there are enough changes for >> everybody:) >> >> Thank you and best regards, >> Volker >> >> *References:* >> >> The following reviews have been posted so far (thanks Iris for collecting >> them :) >> >> - Alan Bateman (lib): Initial comments (16 Sep [2]) >> - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) >> - Michael McMahon (net): Initial comments (20 Sept [4]) >> - Steffan Larsen (svc): APPROVED (20 Sept [5]) >> - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments (15 >> Oct [7]) >> - Sean Mullan (sec): Initial comments (26 Sept [8]) >> >> [2]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001045.html >> [3]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001078.html >> [4]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001079.html >> [5]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001077.html >> [6]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001069.html >> [7]: http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/ >> 003826.html >> [8]: >> http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001081.html >> >> >> *Detailed change description:* >> >> The new "jdk/src/aix" subdirectory contains the following new and >> AIX-specific files for now: >> >> src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties >> src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java >> src/aix/classes/sun/nio/ch/AixPollPort.java >> src/aix/classes/sun/nio/fs/AixFileStore.java >> src/aix/classes/sun/nio/fs/AixFileSystem.java >> src/aix/classes/sun/nio/fs/AixFileSystemProvider.java >> src/aix/classes/sun/nio/fs/AixNativeDispatcher.java >> src/aix/classes/sun/tools/attach/AixAttachProvider.java >> src/aix/classes/sun/tools/attach/AixVirtualMachine.java >> src/aix/native/java/net/aix_close.c >> src/aix/native/sun/nio/ch/AixPollPort.c >> src/aix/native/sun/nio/fs/AixNativeDispatcher.c >> src/aix/native/sun/tools/attach/AixVirtualMachine.c >> src/aix/porting/porting_aix.c >> src/aix/porting/porting_aix.h >> >> src/aix/porting/porting_aix.c >> src/aix/porting/porting_aix.h >> >> - Added these two files for AIX relevant utility code. >> - Currently these files only contain an implementation of dladdr which >> is not available on AIX. >> - In the first review round the existing dladdr users in the code >> either >> called the version from the HotSpot on AIX ( >> src/solaris/native/sun/awt/awt_LoadLibrary.c) or had a private copy >> of >> the whole implementation (src/solaris/demo/jvmti/hprof/hprof_md.c). >> This >> is now not necessary any more. >> >> The new file layout required some small changes to the makefiles to make >> them aware of the new directory locations: >> >> makefiles/CompileDemos.gmk >> >> - Add an extra argument to SetupJVMTIDemo which can be used to pass >> additional source locations. >> - Currently this is only used on AIX for the AIX porting utilities >> which >> are required by hprof. >> >> makefiles/lib/Awt2dLibraries.gmk >> makefiles/lib/ServiceabilityLibraries.gmk >> >> - On AIX add the sources of the AIX porting utilities to the build. >> They >> are required by src/solaris/native/sun/awt/awt_LoadLibrary.c and >> src/solaris/demo/jvmti/hprof/hprof_md.c because dladdr is not >> available >> on AIX. >> >> makefiles/lib/NioLibraries.gmk >> >> - Make the AIX-build aware of the new NIO source locations under >> src/aix/native/sun/nio/. >> >> makefiles/lib/NetworkingLibraries.gmk >> >> - Make the AIX-build aware of the new aix_close.c source location >> under >> src/aix/native/java/net/. >> >> src/share/bin/jli_util.h >> >> - Define JLI_Lseek on AIX. >> >> src/share/lib/security/java.security-aix >> >> - Provide default java.security-aix for AIX based on the latest Linux >> version as suggested by Sean Mullan. >> >> src/share/native/common/check_code.c >> >> - On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is >> legal, but the code in check_code.c does not handles this properly. So >> we wrap the two methods on AIX and return a non-NULL pointer even if >> we >> allocate 0 bytes. >> >> src/share/native/sun/awt/medialib/mlib_sys.c >> >> - malloc always returns 8-byte aligned pointers on AIX as well. >> >> src/share/native/sun/awt/medialib/mlib_types.h >> >> - Add AIX to the list of known platforms. >> >> src/share/native/sun/font/layout/KernTable.cpp >> >> - Rename the macro DEBUG to DEBUG_KERN_TABLE because DEBUG is too >> common >> and may be defined in other headers as well as on the command line and >> xlc bails out on macro redefinitions with a different value. >> >> src/share/native/sun/security/ec/impl/ecc_impl.h >> >> - Define required types and macros on AIX. >> >> src/solaris/back/exec_md.c >> >> - AIX behaves like Linux in this case so check for it in the Linux >> branch. >> >> src/solaris/bin/java_md_solinux.c, >> src/solaris/bin/java_md_solinux.h >> >> - On AIX LD_LIBRARY_PATH is called LIBPATH >> - Always use LD_LIBRARY_PATH macro instead of using the string " >> LD_LIBRARY_PATH" directly to cope with different library path names. >> - Add jre/lib//jli to the standard library search path on AIX >> because the AIX linker doesn't support the -rpath option. >> - Replace #ifdef __linux__ by #ifndef __solaris__ because in this >> case, >> AIX behaves like Linux. >> - Removed the definition of JVM_DLL, JAVA_DLL and LD_LIBRARY_PATH from >> java_md_solinux.h because the macros are redefined in the >> corresponding >> .c files anyway. >> >> src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties >> >> - Provide basic fontconfig.propertiesfor AIX. >> >> src/solaris/classes/java/lang/UNIXProcess.java.aix, >> src/aix/classes/sun/tools/attach/AixAttachProvider.java, >> src/aix/classes/sun/tools/attach/AixVirtualMachine.java, >> src/aix/native/sun/tools/attach/AixVirtualMachine.c >> >> - Provide AIX specific Java versions, mostly based on the >> corresponding >> Linux versions. >> >> src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java >> src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java >> >> - Detect AIX operating system and return the corresponding channel and >> file system providers. >> >> src/solaris/classes/sun/nio/ch/Port.java >> >> - Add a callback function unregisterImpl(int fd) for implementations >> that need special handling when fd is removed and call it from >> unregister(int >> fd). By default the implementation of unregisterImpl(int fd) is empty >> except for the derived AixPollPort class on AIX. >> >> src/solaris/demo/jvmti/hprof/hprof_md.c >> >> - Add AIX support. AIX mostly behaves like Linux, with the one >> exception >> that it has no dladdr functionality. >> - Use the dladdr implementation from porting_aix.{c,h} on AIX. >> >> src/solaris/native/com/sun/management/UnixOperatingSystem_md.c >> >> - Adapt for AIX (i.e. use libperfstat on AIX to query OS memory). >> >> src/solaris/native/common/jdk_util_md.h >> >> - Add AIX definitions of the ISNANF and ISNAND macros. >> >> src/solaris/native/java/io/io_util_md.c >> >> - AIX behaves like Linux in this case so check for it in the Linux >> branch. >> >> src/solaris/native/java/lang/UNIXProcess_md.c >> >> - AIX behaves mostly like Solraris in this case so adjust the ifdefs >> accordingly. >> >> src/solaris/native/java/lang/childproc.c >> >> - AIX does not understand '/proc/self' - it requires the real process >> ID >> to query the proc file system for the current process. >> >> src/solaris/native/java/net/NetworkInterface.c >> >> - Add AIX support into the Linux branch because AIX mostly behaves >> like >> AIX for IPv4. >> - AIX needs a special function to enumerate IPv6 interfaces and to >> query >> the MAC address. >> - Moved the declaration of siocgifconfRequest to the beginning a the >> function (as recommend by Michael McMahon) to remain C89 compatible. >> >> src/solaris/native/java/net/PlainSocketImpl.c >> >> - On AIX (like on Solaris) setsockopt will set errno to EINVAL if the >> socket is closed. The default error message is then confusing. >> >> src/aix/native/java/net/aix_close.c, >> src/share/native/java/net/net_util.c >> >> - As recommended by Michael McMahon and Alan Bateman I've move an >> adapted version of linux_close.c to >> src/aix/native/java/net/aix_close.cbecause we also need the file and >> socket wrappers on AIX. >> - Compared to the Linux version, we've added the initialization of >> some >> previously uninitialized data structures. >> - Also, on AIX we don't have __attribute((constructor)) so we need to >> initialize manually (from JNI_OnLoad() in >> src/share/native/java/net/net_util.c. >> >> src/solaris/native/java/net/net_util_md.h >> >> - AIX needs the same workaround for I/O cancellation like Linux and >> MacOSX. >> >> src/solaris/native/java/net/net_util_md.c >> >> - SO_REUSEADDR is called SO_REUSEPORT on AIX. >> - On AIX we have to ignore failures due to ENOBUFS when setting the >> SO_SNDBUF/SO_RCVBUF socket options. >> >> src/solaris/native/java/util/TimeZone_md.c >> >> - Currently on AIX the only way to get the platform time zone is to >> read >> it from the TZ environment variable. >> >> src/solaris/native/sun/awt/awt_LoadLibrary.c >> >> - Use the dladdr from porting_aix.{c,h} on AIX. >> >> src/solaris/native/sun/awt/fontpath.c >> >> - Changed some macros from if !defined(__linux__) to if >> defined(__solaris__) because that's their real meaning. >> - Add AIX specific fontpath settings and library search paths for >> libfontconfig.so. >> >> src/solaris/native/sun/java2d/x11/X11SurfaceData.c >> >> - Rename the MIN and MAX macros to XSD_MIN and XSD_MAX to avoid name >> clashes (MIN and MAX are much too common and thexy are already defined >> in some AIX system headers). >> >> src/solaris/native/sun/java2d/x11/XRBackendNative.c >> >> - Handle AIX like Solaris. >> >> src/solaris/native/sun/nio/ch/Net.c >> >> - Add AIX-specific includes and constant definitions. >> - On AIX "socket extensions for multicast source filters" support >> depends on the OS version. Check for this and throw appropriate >> exceptions >> if it is requested but not supported. This is needed to pass >> JCK-api/java_nio/channels/DatagramChannel/ >> DatagramChannel.html#Multicast >> >> src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c >> >> - On AIX strerror() is not thread-safe so we have to use >> strerror_r()instead. >> - On AIX readdir_r() returns EBADF (i.e. '9') and sets 'result' to >> NULL >> for the directory stream end. Otherwise, 'errno' will contain the >> error >> code. >> - Handle some AIX corner cases for the results of the statvfs64() >> call. >> - On AIX getgrgid_r() returns ESRCH if group does not exist. >> >> src/solaris/native/sun/security/pkcs11/j2secmod_md.c >> >> - Use RTLD_LAZY instead of RTLD_NOLOAD on AIX. >> >> test/java/lang/ProcessBuilder/Basic.java >> test/java/lang/ProcessBuilder/DestroyTest.java >> >> - Port this test to AIX and make it more robust (i.e. recognize the >> "C" >> locale as isEnglish(), ignore VM-warnings in the output, make sure the >> "grandchild" processes created by the test don't run too long (60s vs. >> 6666s) because in the case of test problems these processes will >> pollute >> the process space, make sure the test fails with an error and doesn't >> hang >> indefinitley in the case of a problem). >> >> *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this >> intended? >> >> Well, _AIX is defined in some system headers while AIX is defined by the >> build system. This is already used inconsistently (i.e. __linux__ vs. >> LINUX) >> and in general I try to be consistent with the style of the file where I >> the changes are. That said, I changes most of the occurences of AIX to >> _AIX. >> >> >> *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are >> they supposed to be there? >> >> We currently don't support OS/400 (later renamed into i5/OS and currently >> called IBM i) in our OpenJDK port but we do support it in our internel, >> SAP >> JVM build. We stripped out all the extra OS/400 functionality from the >> port >> but in some places where there is common functionality needd by both, AIX >> and OS/400 the OS/400 support may still be visible in the OpenJDK port. I >> don't think this is a real problem and it helps us to keep our internel >> sources in sync with the OpenJDK port. That said, I think I've removed all >> the references to OS/400 now. >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131125/bd221e42/attachment-0001.html From philip.race at oracle.com Mon Nov 25 15:24:15 2013 From: philip.race at oracle.com (Phil Race) Date: Mon, 25 Nov 2013 15:24:15 -0800 Subject: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: <5293DC1F.4060205@oracle.com> Hi, I see you've already received a ton of good feedback on this v2. I have just a few things to add. I don't know what symlinks might exist on AIX but it seems odd to me that you have :- 138 static char *fullAixFontPath[] = { 139 "/usr/lpp/X11/lib/X11/fonts/Type1", .. but the paths in the new file aix.fontconfig.properties look like this :- /usr/lib/X11/fonts/Type1/cour.pfa Also for the build to pick up a file called *src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties *it seems like you should have added a section to handle this path to jdk/makefiles/gendata/GenDataFontConfig.gmk That seems to be where the new build handles such files. Are you seeing the .bfc and .src files created ? At runtime it'll get picked up so so long as System.getProperty("os.name") returns "aix" (all lower-case) so I think that's OK. Its the build time part I'd expect to see but don't. -phil. On 11/20/2013 10:26 AM, Volker Simonis wrote: > Hi, > > this is the second review round for "8024854: Basic changes and files > to build the class library on AIX > ". The previous > reviews can be found at the end of this mail in the references section. > > I've tried to address all the comments and suggestions from the first > round and to further streamline the patch (it perfectly builds on > Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). > The biggest change compared to the first review round is the new > "aix/" subdirectory which I've now created under "jdk/src" and which > contains AIX-only code. > > The webrev is against our > http://hg.openjdk.java.net/ppc-aix-port/stage repository which has > been recently synchronised with the jdk8 master: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > > > Below (and in the webrev) you can find some comments which explain the > changes to each file. In order to be able to push this big change, I > need the approval of reviewers from the lib, net, svc, 2d, awt and sec > groups. So please don't hesitate to jump at it - there are enough > changes for everybody:) > > Thank you and best regards, > Volker > > *References:* > > The following reviews have been posted so far (thanks Iris for > collecting them :) > > - Alan Bateman (lib): Initial comments (16 Sep [2]) > - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) > - Michael McMahon (net): Initial comments (20 Sept [4]) > - Steffan Larsen (svc): APPROVED (20 Sept [5]) > - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments > (15 Oct [7]) > - Sean Mullan (sec): Initial comments (26 Sept [8]) > > [2]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html > [3]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html > [4]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html > [5]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html > [6]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html > [7]: > http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html > [8]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html > > > *Detailed change description:* > > The new "jdk/src/aix" subdirectory contains the following new and > AIX-specific files for now: > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileStore.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/classes/sun/nio/fs/AixFileSystemProvider.java > src/aix/classes/sun/nio/fs/AixNativeDispatcher.java > src/aix/classes/sun/tools/attach/AixAttachProvider.java > src/aix/classes/sun/tools/attach/AixVirtualMachine.java > src/aix/native/java/net/aix_close.c > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/sun/nio/fs/AixNativeDispatcher.c > src/aix/native/sun/tools/attach/AixVirtualMachine.c > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > * Added these two files for AIX relevant utility code. > * Currently these files only contain an implementation of |dladdr| > which is not available on AIX. > * In the first review round the existing |dladdr| users in the code > either called the version from the HotSpot on AIX > (|src/solaris/native/sun/awt/awt_LoadLibrary.c|) or had a private > copy of the whole implementation > (|src/solaris/demo/jvmti/hprof/hprof_md.c|). This is now not > necessary any more. > > The new file layout required some small changes to the makefiles to > make them aware of the new directory locations: > > > makefiles/CompileDemos.gmk > > * Add an extra argument to |SetupJVMTIDemo| which can be used to > pass additional source locations. > * Currently this is only used on AIX for the AIX porting utilities > which are required by hprof. > > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/ServiceabilityLibraries.gmk > > * On AIX add the sources of the AIX porting utilities to the build. > They are required by > |src/solaris/native/sun/awt/awt_LoadLibrary.c| and > |src/solaris/demo/jvmti/hprof/hprof_md.c| because |dladdr| is not > available on AIX. > > > makefiles/lib/NioLibraries.gmk > > * Make the AIX-build aware of the new NIO source locations under > |src/aix/native/sun/nio/|. > > > makefiles/lib/NetworkingLibraries.gmk > > * Make the AIX-build aware of the new |aix_close.c| source location > under |src/aix/native/java/net/|. > > > src/share/bin/jli_util.h > > * Define |JLI_Lseek| on AIX. > > > src/share/lib/security/java.security-aix > > * Provide default |java.security-aix| for AIX based on the latest > Linux version as suggested by Sean Mullan. > > > src/share/native/common/check_code.c > > * On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which > is legal, but the code in |check_code.c| does not handles this > properly. So we wrap the two methods on AIX and return a non-NULL > pointer even if we allocate 0 bytes. > > > src/share/native/sun/awt/medialib/mlib_sys.c > > * |malloc| always returns 8-byte aligned pointers on AIX as well. > > > src/share/native/sun/awt/medialib/mlib_types.h > > * Add AIX to the list of known platforms. > > > src/share/native/sun/font/layout/KernTable.cpp > > * Rename the macro |DEBUG| to |DEBUG_KERN_TABLE| because |DEBUG| is > too common and may be defined in other headers as well as on the > command line and |xlc| bails out on macro redefinitions with a > different value. > > > src/share/native/sun/security/ec/impl/ecc_impl.h > > * Define required types and macros on AIX. > > > src/solaris/back/exec_md.c > > * AIX behaves like Linux in this case so check for it in the Linux > branch. > > > src/solaris/bin/java_md_solinux.c, > src/solaris/bin/java_md_solinux.h > > * On AIX |LD_LIBRARY_PATH| is called |LIBPATH| > * Always use |LD_LIBRARY_PATH| macro instead of using the string > "|LD_LIBRARY_PATH|" directly to cope with different library path > names. > * Add |jre/lib//jli| to the standard library search path on > AIX because the AIX linker doesn't support the |-rpath| option. > * Replace |#ifdef __linux__| by |#ifndef __solaris__| because in > this case, AIX behaves like Linux. > * Removed the definition of |JVM_DLL|, |JAVA_DLL| and > |LD_LIBRARY_PATH| from |java_md_solinux.h| because the macros are > redefined in the corresponding |.c| files anyway. > > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > * Provide basic |fontconfig.properties|for AIX. > > > src/solaris/classes/java/lang/UNIXProcess.java.aix, > src/aix/classes/sun/tools/attach/AixAttachProvider.java, > src/aix/classes/sun/tools/attach/AixVirtualMachine.java, > src/aix/native/sun/tools/attach/AixVirtualMachine.c > > * Provide AIX specific Java versions, mostly based on the > corresponding Linux versions. > > > src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java > src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java > > * Detect AIX operating system and return the corresponding channel > and file system providers. > > > src/solaris/classes/sun/nio/ch/Port.java > > * Add a callback function |unregisterImpl(int fd)| for > implementations that need special handling when |fd| is removed > and call it from |unregister(int fd)|. By default the > implementation of |unregisterImpl(int fd)| is empty except for the > derived |AixPollPort| class on AIX. > > > src/solaris/demo/jvmti/hprof/hprof_md.c > > * Add AIX support. AIX mostly behaves like Linux, with the one > exception that it has no |dladdr| functionality. > * Use the |dladdr| implementation from |porting_aix.{c,h}| on AIX. > > > src/solaris/native/com/sun/management/UnixOperatingSystem_md.c > > * Adapt for AIX (i.e. use |libperfstat| on AIX to query OS memory). > > > src/solaris/native/common/jdk_util_md.h > > * Add AIX definitions of the |ISNANF| and |ISNAND| macros. > > > src/solaris/native/java/io/io_util_md.c > > * AIX behaves like Linux in this case so check for it in the Linux > branch. > > > src/solaris/native/java/lang/UNIXProcess_md.c > > * AIX behaves mostly like Solraris in this case so adjust the ifdefs > accordingly. > > > src/solaris/native/java/lang/childproc.c > > * AIX does not understand '/proc/self' - it requires the real > process ID to query the proc file system for the current process. > > > src/solaris/native/java/net/NetworkInterface.c > > * Add AIX support into the Linux branch because AIX mostly behaves > like AIX for IPv4. > * AIX needs a special function to enumerate IPv6 interfaces and to > query the MAC address. > * Moved the declaration of |siocgifconfRequest| to the beginning a > the function (as recommend by Michael McMahon) to remain C89 > compatible. > > > src/solaris/native/java/net/PlainSocketImpl.c > > * On AIX (like on Solaris) |setsockopt| will set errno to |EINVAL| > if the socket is closed. The default error message is then confusing. > > > src/aix/native/java/net/aix_close.c, > src/share/native/java/net/net_util.c > > * As recommended by Michael McMahon and Alan Bateman I've move an > adapted version of |linux_close.c| to > |src/aix/native/java/net/aix_close.c| because we also need the > file and socket wrappers on AIX. > * Compared to the Linux version, we've added the initialization of > some previously uninitialized data structures. > * Also, on AIX we don't have |__attribute((constructor))| so we need > to initialize manually (from |JNI_OnLoad()| in > |src/share/native/java/net/net_util.c|. > > > src/solaris/native/java/net/net_util_md.h > > * AIX needs the same workaround for I/O cancellation like Linux and > MacOSX. > > > src/solaris/native/java/net/net_util_md.c > > * |SO_REUSEADDR| is called |SO_REUSEPORT| on AIX. > * On AIX we have to ignore failures due to |ENOBUFS| when setting > the |SO_SNDBUF|/|SO_RCVBUF| socket options. > > > src/solaris/native/java/util/TimeZone_md.c > > * Currently on AIX the only way to get the platform time zone is to > read it from the |TZ| environment variable. > > > src/solaris/native/sun/awt/awt_LoadLibrary.c > > * Use the |dladdr| from |porting_aix.{c,h}| on AIX. > > > src/solaris/native/sun/awt/fontpath.c > > * Changed some macros from |if !defined(__linux__)| to |if > defined(__solaris__)| because that's their real meaning. > * Add AIX specific fontpath settings and library search paths for > |libfontconfig.so|. > > > src/solaris/native/sun/java2d/x11/X11SurfaceData.c > > * Rename the |MIN| and |MAX| macros to |XSD_MIN| and |XSD_MAX| to > avoid name clashes (|MIN| and |MAX| are much too common and thexy > are already defined in some AIX system headers). > > > src/solaris/native/sun/java2d/x11/XRBackendNative.c > > * Handle AIX like Solaris. > > > src/solaris/native/sun/nio/ch/Net.c > > * Add AIX-specific includes and constant definitions. > * On AIX "socket extensions for multicast source filters" support > depends on the OS version. Check for this and throw appropriate > exceptions if it is requested but not supported. This is needed to > pass > JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast > > > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > > * On AIX |strerror()| is not thread-safe so we have to use > |strerror_r()| instead. > * On AIX |readdir_r()| returns EBADF (i.e. '9') and sets 'result' to > NULL for the directory stream end. Otherwise, 'errno' will contain > the error code. > * Handle some AIX corner cases for the results of the |statvfs64()| > call. > * On AIX |getgrgid_r()| returns ESRCH if group does not exist. > > > src/solaris/native/sun/security/pkcs11/j2secmod_md.c > > * Use |RTLD_LAZY| instead of |RTLD_NOLOAD| on AIX. > > > test/java/lang/ProcessBuilder/Basic.java > test/java/lang/ProcessBuilder/DestroyTest.java > > * Port this test to AIX and make it more robust (i.e. recognize the > "C" locale as |isEnglish()|, ignore VM-warnings in the output, > make sure the "grandchild" processes created by the test don't run > too long (60s vs. 6666s) because in the case of test problems > these processes will pollute the process space, make sure the test > fails with an error and doesn't hang indefinitley in the case of a > problem). > > *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this > intended? > > Well, |_AIX| is defined in some system headers while |AIX| is defined > by the build system. This is already used inconsistently (i.e. > |__linux__| vs. |LINUX|) and in general I try to be consistent with > the style of the file where I the changes are. That said, I changes > most of the occurences of |AIX| to |_AIX|. > > *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, > are they supposed to be there? > > We currently don't support OS/400 (later renamed into i5/OS and > currently called IBM i) in our OpenJDK port but we do support it in > our internel, SAP JVM build. We stripped out all the extra OS/400 > functionality from the port but in some places where there is common > functionality needd by both, AIX and OS/400 the OS/400 support may > still be visible in the OpenJDK port. I don't think this is a real > problem and it helps us to keep our internel sources in sync with the > OpenJDK port. That said, I think I've removed all the references to > OS/400 now. > > From volker.simonis at gmail.com Tue Nov 26 01:57:17 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 26 Nov 2013 10:57:17 +0100 Subject: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <5293DC1F.4060205@oracle.com> References: <5293DC1F.4060205@oracle.com> Message-ID: Hi Phil, thanks a lot for the review. Please find my comments inline: On Tue, Nov 26, 2013 at 12:24 AM, Phil Race wrote: > Hi, > I see you've already received a ton of good feedback on this v2. > > I have just a few things to add. > I don't know what symlinks might exist on AIX but it seems odd to > me that you have :- > > 138 static char *fullAixFontPath[] = { > 139 "/usr/lpp/X11/lib/X11/fonts/Type1", > .. > > but the paths in the new file aix.fontconfig.properties look like this :- > > /usr/lib/X11/fonts/Type1/cour.pfa > > You're absolutely right. I've updated 'aix.fontconfig.properties' to contain the same absolute path like 'fontpath.c'. I've also added a comment which describes to which AIX-package the fonts belong to and to which locations they are sym-linked to. Also for the build to pick up a file called > *src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > *it seems like you should have added a section to handle this path to > jdk/makefiles/gendata/GenDataFontConfig.gmk > > That seems to be where the new build handles such files. > > Are you seeing the .bfc and .src files created ? > > You're right. But that was already added by the general AIX-build change "8024900: PPC64: Enable new build on AIX (jdk part)" ( http://hg.openjdk.java.net/ppc-aix-port/stage/jdk/diff/3ac08cd5e2e8/makefiles/GendataFontConfig.gmk ). And yes, the .bfc and .src files are created and copied to the right places. > At runtime it'll get picked up so so long as System.getProperty("os.name") > returns "aix" (all lower-case) so I think that's OK. Its the build time > part > I'd expect to see but don't. > > I did split the AIX change into several changes and the build changes have been reviewed separately: 8024265: PPC64: Enable new build on AIX ( https://bugs.openjdk.java.net/browse/JDK-8024265) 8024900: PPC64: Enable new build on AIX (jdk part) ( https://bugs.openjdk.java.net/browse/JDK-8024900) This change only contains the additional make changes which became necessary after I started to move AIX-specific files into their own jdk/src/aix/ directory. Everything else is already in place. I'll prepare and test a finaly webrev with all the changes from this review round today. Thanks a lot, Volker > -phil. > > > On 11/20/2013 10:26 AM, Volker Simonis wrote: > >> Hi, >> >> this is the second review round for "8024854: Basic changes and files to >> build the class library on AIX > net/browse/JDK-8024854>". The previous reviews can be found at the end >> of this mail in the references section. >> >> >> I've tried to address all the comments and suggestions from the first >> round and to further streamline the patch (it perfectly builds on >> Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The >> biggest change compared to the first review round is the new "aix/" >> subdirectory which I've now created under "jdk/src" and which contains >> AIX-only code. >> >> The webrev is against our http://hg.openjdk.java.net/ppc-aix-port/stagerepository which has been recently synchronised with the jdk8 master: >> >> http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ < >> http://cr.openjdk.java.net/%7Esimonis/webrevs/8024854.v2/> >> >> >> Below (and in the webrev) you can find some comments which explain the >> changes to each file. In order to be able to push this big change, I need >> the approval of reviewers from the lib, net, svc, 2d, awt and sec groups. >> So please don't hesitate to jump at it - there are enough changes for >> everybody:) >> >> Thank you and best regards, >> Volker >> >> *References:* >> >> >> The following reviews have been posted so far (thanks Iris for collecting >> them :) >> >> - Alan Bateman (lib): Initial comments (16 Sep [2]) >> - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) >> - Michael McMahon (net): Initial comments (20 Sept [4]) >> - Steffan Larsen (svc): APPROVED (20 Sept [5]) >> - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments >> (15 Oct [7]) >> - Sean Mullan (sec): Initial comments (26 Sept [8]) >> >> [2]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001045.html >> [3]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001078.html >> [4]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001079.html >> [5]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001077.html >> [6]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001069.html >> [7]: http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/ >> 003826.html >> [8]: http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/ >> 2013-September/001081.html >> >> >> *Detailed change description:* >> >> >> The new "jdk/src/aix" subdirectory contains the following new and >> AIX-specific files for now: >> src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties >> src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java >> src/aix/classes/sun/nio/ch/AixPollPort.java >> src/aix/classes/sun/nio/fs/AixFileStore.java >> src/aix/classes/sun/nio/fs/AixFileSystem.java >> src/aix/classes/sun/nio/fs/AixFileSystemProvider.java >> src/aix/classes/sun/nio/fs/AixNativeDispatcher.java >> src/aix/classes/sun/tools/attach/AixAttachProvider.java >> src/aix/classes/sun/tools/attach/AixVirtualMachine.java >> src/aix/native/java/net/aix_close.c >> src/aix/native/sun/nio/ch/AixPollPort.c >> src/aix/native/sun/nio/fs/AixNativeDispatcher.c >> src/aix/native/sun/tools/attach/AixVirtualMachine.c >> src/aix/porting/porting_aix.c >> src/aix/porting/porting_aix.h >> >> >> src/aix/porting/porting_aix.c >> src/aix/porting/porting_aix.h >> >> * Added these two files for AIX relevant utility code. >> * Currently these files only contain an implementation of |dladdr| >> >> which is not available on AIX. >> * In the first review round the existing |dladdr| users in the code >> >> either called the version from the HotSpot on AIX >> (|src/solaris/native/sun/awt/awt_LoadLibrary.c|) or had a private >> >> copy of the whole implementation >> (|src/solaris/demo/jvmti/hprof/hprof_md.c|). This is now not >> >> necessary any more. >> >> The new file layout required some small changes to the makefiles to make >> them aware of the new directory locations: >> >> >> makefiles/CompileDemos.gmk >> >> * Add an extra argument to |SetupJVMTIDemo| which can be used to >> pass additional source locations. >> * Currently this is only used on AIX for the AIX porting utilities >> >> which are required by hprof. >> >> >> makefiles/lib/Awt2dLibraries.gmk >> makefiles/lib/ServiceabilityLibraries.gmk >> >> * On AIX add the sources of the AIX porting utilities to the build. >> >> They are required by >> |src/solaris/native/sun/awt/awt_LoadLibrary.c| and >> |src/solaris/demo/jvmti/hprof/hprof_md.c| because |dladdr| is not >> available on AIX. >> >> >> makefiles/lib/NioLibraries.gmk >> >> * Make the AIX-build aware of the new NIO source locations under >> |src/aix/native/sun/nio/|. >> >> >> makefiles/lib/NetworkingLibraries.gmk >> >> * Make the AIX-build aware of the new |aix_close.c| source location >> under |src/aix/native/java/net/|. >> >> >> src/share/bin/jli_util.h >> >> * Define |JLI_Lseek| on AIX. >> >> >> src/share/lib/security/java.security-aix >> >> * Provide default |java.security-aix| for AIX based on the latest >> >> Linux version as suggested by Sean Mullan. >> >> >> src/share/native/common/check_code.c >> >> * On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which >> >> is legal, but the code in |check_code.c| does not handles this >> properly. So we wrap the two methods on AIX and return a non-NULL >> pointer even if we allocate 0 bytes. >> >> >> src/share/native/sun/awt/medialib/mlib_sys.c >> >> * |malloc| always returns 8-byte aligned pointers on AIX as well. >> >> >> src/share/native/sun/awt/medialib/mlib_types.h >> >> * Add AIX to the list of known platforms. >> >> >> src/share/native/sun/font/layout/KernTable.cpp >> >> * Rename the macro |DEBUG| to |DEBUG_KERN_TABLE| because |DEBUG| is >> >> too common and may be defined in other headers as well as on the >> command line and |xlc| bails out on macro redefinitions with a >> different value. >> >> >> src/share/native/sun/security/ec/impl/ecc_impl.h >> >> * Define required types and macros on AIX. >> >> >> src/solaris/back/exec_md.c >> >> * AIX behaves like Linux in this case so check for it in the Linux >> branch. >> >> >> src/solaris/bin/java_md_solinux.c, >> src/solaris/bin/java_md_solinux.h >> >> * On AIX |LD_LIBRARY_PATH| is called |LIBPATH| >> * Always use |LD_LIBRARY_PATH| macro instead of using the string >> >> "|LD_LIBRARY_PATH|" directly to cope with different library path >> names. >> * Add |jre/lib//jli| to the standard library search path on >> >> AIX because the AIX linker doesn't support the |-rpath| option. >> * Replace |#ifdef __linux__| by |#ifndef __solaris__| because in >> >> this case, AIX behaves like Linux. >> * Removed the definition of |JVM_DLL|, |JAVA_DLL| and >> >> |LD_LIBRARY_PATH| from |java_md_solinux.h| because the macros are >> redefined in the corresponding |.c| files anyway. >> >> >> src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties >> >> * Provide basic |fontconfig.properties|for AIX. >> >> >> src/solaris/classes/java/lang/UNIXProcess.java.aix, >> src/aix/classes/sun/tools/attach/AixAttachProvider.java, >> src/aix/classes/sun/tools/attach/AixVirtualMachine.java, >> src/aix/native/sun/tools/attach/AixVirtualMachine.c >> >> * Provide AIX specific Java versions, mostly based on the >> >> corresponding Linux versions. >> >> >> src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProv >> ider.java >> src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java >> >> * Detect AIX operating system and return the corresponding channel >> >> and file system providers. >> >> >> src/solaris/classes/sun/nio/ch/Port.java >> >> * Add a callback function |unregisterImpl(int fd)| for >> >> implementations that need special handling when |fd| is removed >> and call it from |unregister(int fd)|. By default the >> >> implementation of |unregisterImpl(int fd)| is empty except for the >> derived |AixPollPort| class on AIX. >> >> >> src/solaris/demo/jvmti/hprof/hprof_md.c >> >> * Add AIX support. AIX mostly behaves like Linux, with the one >> >> exception that it has no |dladdr| functionality. >> * Use the |dladdr| implementation from |porting_aix.{c,h}| on AIX. >> >> >> src/solaris/native/com/sun/management/UnixOperatingSystem_md.c >> >> * Adapt for AIX (i.e. use |libperfstat| on AIX to query OS memory). >> >> >> src/solaris/native/common/jdk_util_md.h >> >> * Add AIX definitions of the |ISNANF| and |ISNAND| macros. >> >> >> src/solaris/native/java/io/io_util_md.c >> >> * AIX behaves like Linux in this case so check for it in the Linux >> branch. >> >> >> src/solaris/native/java/lang/UNIXProcess_md.c >> >> * AIX behaves mostly like Solraris in this case so adjust the ifdefs >> accordingly. >> >> >> src/solaris/native/java/lang/childproc.c >> >> * AIX does not understand '/proc/self' - it requires the real >> >> process ID to query the proc file system for the current process. >> >> >> src/solaris/native/java/net/NetworkInterface.c >> >> * Add AIX support into the Linux branch because AIX mostly behaves >> like AIX for IPv4. >> * AIX needs a special function to enumerate IPv6 interfaces and to >> query the MAC address. >> * Moved the declaration of |siocgifconfRequest| to the beginning a >> >> the function (as recommend by Michael McMahon) to remain C89 >> compatible. >> >> >> src/solaris/native/java/net/PlainSocketImpl.c >> >> * On AIX (like on Solaris) |setsockopt| will set errno to |EINVAL| >> >> if the socket is closed. The default error message is then confusing. >> >> >> src/aix/native/java/net/aix_close.c, >> src/share/native/java/net/net_util.c >> >> * As recommended by Michael McMahon and Alan Bateman I've move an >> >> adapted version of |linux_close.c| to >> |src/aix/native/java/net/aix_close.c| because we also need the >> file and socket wrappers on AIX. >> * Compared to the Linux version, we've added the initialization of >> >> some previously uninitialized data structures. >> * Also, on AIX we don't have |__attribute((constructor))| so we need >> >> to initialize manually (from |JNI_OnLoad()| in >> |src/share/native/java/net/net_util.c|. >> >> >> src/solaris/native/java/net/net_util_md.h >> >> * AIX needs the same workaround for I/O cancellation like Linux and >> MacOSX. >> >> >> src/solaris/native/java/net/net_util_md.c >> >> * |SO_REUSEADDR| is called |SO_REUSEPORT| on AIX. >> * On AIX we have to ignore failures due to |ENOBUFS| when setting >> the |SO_SNDBUF|/|SO_RCVBUF| socket options. >> >> >> src/solaris/native/java/util/TimeZone_md.c >> >> * Currently on AIX the only way to get the platform time zone is to >> >> read it from the |TZ| environment variable. >> >> >> src/solaris/native/sun/awt/awt_LoadLibrary.c >> >> * Use the |dladdr| from |porting_aix.{c,h}| on AIX. >> >> >> src/solaris/native/sun/awt/fontpath.c >> >> * Changed some macros from |if !defined(__linux__)| to |if >> >> defined(__solaris__)| because that's their real meaning. >> * Add AIX specific fontpath settings and library search paths for >> |libfontconfig.so|. >> >> >> src/solaris/native/sun/java2d/x11/X11SurfaceData.c >> >> * Rename the |MIN| and |MAX| macros to |XSD_MIN| and |XSD_MAX| to >> avoid name clashes (|MIN| and |MAX| are much too common and thexy >> >> are already defined in some AIX system headers). >> >> >> src/solaris/native/sun/java2d/x11/XRBackendNative.c >> >> * Handle AIX like Solaris. >> >> >> src/solaris/native/sun/nio/ch/Net.c >> >> * Add AIX-specific includes and constant definitions. >> * On AIX "socket extensions for multicast source filters" support >> >> depends on the OS version. Check for this and throw appropriate >> exceptions if it is requested but not supported. This is needed to >> pass >> JCK-api/java_nio/channels/DatagramChannel/ >> DatagramChannel.html#Multicast >> >> >> src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c >> >> * On AIX |strerror()| is not thread-safe so we have to use >> |strerror_r()| instead. >> * On AIX |readdir_r()| returns EBADF (i.e. '9') and sets 'result' to >> >> NULL for the directory stream end. Otherwise, 'errno' will contain >> the error code. >> * Handle some AIX corner cases for the results of the |statvfs64()| >> call. >> * On AIX |getgrgid_r()| returns ESRCH if group does not exist. >> >> >> src/solaris/native/sun/security/pkcs11/j2secmod_md.c >> >> * Use |RTLD_LAZY| instead of |RTLD_NOLOAD| on AIX. >> >> >> test/java/lang/ProcessBuilder/Basic.java >> test/java/lang/ProcessBuilder/DestroyTest.java >> >> * Port this test to AIX and make it more robust (i.e. recognize the >> "C" locale as |isEnglish()|, ignore VM-warnings in the output, >> >> make sure the "grandchild" processes created by the test don't run >> too long (60s vs. 6666s) because in the case of test problems >> these processes will pollute the process space, make sure the test >> fails with an error and doesn't hang indefinitley in the case of a >> problem). >> >> *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this >> intended? >> >> Well, |_AIX| is defined in some system headers while |AIX| is defined by >> the build system. This is already used inconsistently (i.e. |__linux__| vs. >> |LINUX|) and in general I try to be consistent with the style of the file >> where I the changes are. That said, I changes most of the occurences of >> |AIX| to |_AIX|. >> >> *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are >> they supposed to be there? >> >> >> We currently don't support OS/400 (later renamed into i5/OS and currently >> called IBM i) in our OpenJDK port but we do support it in our internel, SAP >> JVM build. We stripped out all the extra OS/400 functionality from the port >> but in some places where there is common functionality needd by both, AIX >> and OS/400 the OS/400 support may still be visible in the OpenJDK port. I >> don't think this is a real problem and it helps us to keep our internel >> sources in sync with the OpenJDK port. That said, I think I've removed all >> the references to OS/400 now. >> >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131126/3276cd8c/attachment-0001.html From volker.simonis at gmail.com Tue Nov 26 08:23:37 2013 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 26 Nov 2013 17:23:37 +0100 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: Hi, thanks to everybody for the prompt and helpful reviews. Here comes the final webrev which incorporates all the corrections and suggestions from the second review round: http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ I've successfully build (and run some smoke tests) with these changes on Linux (x86_32, x86_64, ppc64), Solaris/sparcv9, Windows/x86_64, MacOSX and AIX (5.3, 7.1). So if nobody vetoes these changes are ready for push into our staging repository. @Vladimir: can I push them or do you want to run them trough JPRT? Thank you and best regards, Volker PS: compared to the last webrev ( http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/), I've slightly changed the following files: makefiles/lib/Awt2dLibraries.gmk makefiles/lib/NetworkingLibraries.gmk makefiles/Setup.gmk src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties src/aix/classes/sun/nio/ch/AixPollPort.java src/aix/classes/sun/nio/fs/AixFileSystem.java src/aix/native/java/net/aix_close.c src/aix/porting/porting_aix.c src/share/native/java/net/net_util.c src/share/native/java/net/net_util.h src/share/native/sun/awt/medialib/mlib_sys.c src/solaris/bin/java_md_solinux.c src/solaris/classes/sun/nio/ch/Port.java src/solaris/native/java/net/net_util_md.c src/solaris/native/sun/java2d/x11/XRBackendNative.c src/solaris/native/sun/management/OperatingSystemImpl.c src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c src/windows/native/java/net/net_util_md.c Most of the changes are cosmetic, except the ones in: src/share/native/java/net/net_util.c src/share/native/java/net/net_util.h src/solaris/native/java/net/net_util_md.c src/windows/native/java/net/net_util_md.c where I renamed 'initLocalAddrTable()' to 'platformInit()'. For AIX, this method will now call 'aix_close_init()' as suggested by Alan. The changes to src/solaris/native/com/sun/ management/UnixOperatingSystem_md.c are now in src/solaris/native/sun/management/OperatingSystemImpl.c because that file was moved by an upstream change. On Wed, Nov 20, 2013 at 7:26 PM, Volker Simonis wrote: > Hi, > > this is the second review round for "8024854: Basic changes and files to > build the class library on AIX". > The previous reviews can be found at the end of this mail in the references > section. > > I've tried to address all the comments and suggestions from the first > round and to further streamline the patch (it perfectly builds on > Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and Windows/x86_64). The > biggest change compared to the first review round is the new "aix/" > subdirectory which I've now created under "jdk/src" and which contains > AIX-only code. > > The webrev is against our http://hg.openjdk.java.net/ppc-aix-port/stagerepository which has been recently synchronised with the jdk8 master: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > > Below (and in the webrev) you can find some comments which explain the > changes to each file. In order to be able to push this big change, I need > the approval of reviewers from the lib, net, svc, 2d, awt and sec groups. > So please don't hesitate to jump at it - there are enough changes for > everybody:) > > Thank you and best regards, > Volker > > *References:* > > The following reviews have been posted so far (thanks Iris for collecting > them :) > > - Alan Bateman (lib): Initial comments (16 Sep [2]) > - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) > - Michael McMahon (net): Initial comments (20 Sept [4]) > - Steffan Larsen (svc): APPROVED (20 Sept [5]) > - Phil Race (2d): Initial comments (18 Sept [6]); Additional comments > (15 Oct [7]) > - Sean Mullan (sec): Initial comments (26 Sept [8]) > > [2]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html > [3]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html > [4]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html > [5]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html > [6]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html > [7]: > http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html > [8]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html > > > *Detailed change description:* > > The new "jdk/src/aix" subdirectory contains the following new and > AIX-specific files for now: > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileStore.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/classes/sun/nio/fs/AixFileSystemProvider.java > src/aix/classes/sun/nio/fs/AixNativeDispatcher.java > src/aix/classes/sun/tools/attach/AixAttachProvider.java > src/aix/classes/sun/tools/attach/AixVirtualMachine.java > src/aix/native/java/net/aix_close.c > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/sun/nio/fs/AixNativeDispatcher.c > src/aix/native/sun/tools/attach/AixVirtualMachine.c > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > - Added these two files for AIX relevant utility code. > - Currently these files only contain an implementation of dladdr which > is not available on AIX. > - In the first review round the existing dladdr users in the code > either called the version from the HotSpot on AIX ( > src/solaris/native/sun/awt/awt_LoadLibrary.c) or had a private copy of > the whole implementation (src/solaris/demo/jvmti/hprof/hprof_md.c). > This is now not necessary any more. > > The new file layout required some small changes to the makefiles to make > them aware of the new directory locations: > > makefiles/CompileDemos.gmk > > - Add an extra argument to SetupJVMTIDemo which can be used to pass > additional source locations. > - Currently this is only used on AIX for the AIX porting utilities > which are required by hprof. > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/ServiceabilityLibraries.gmk > > - On AIX add the sources of the AIX porting utilities to the build. > They are required by src/solaris/native/sun/awt/awt_LoadLibrary.c and > src/solaris/demo/jvmti/hprof/hprof_md.c because dladdr is not > available on AIX. > > makefiles/lib/NioLibraries.gmk > > - Make the AIX-build aware of the new NIO source locations under > src/aix/native/sun/nio/. > > makefiles/lib/NetworkingLibraries.gmk > > - Make the AIX-build aware of the new aix_close.c source location > under src/aix/native/java/net/. > > src/share/bin/jli_util.h > > - Define JLI_Lseek on AIX. > > src/share/lib/security/java.security-aix > > - Provide default java.security-aix for AIX based on the latest Linux > version as suggested by Sean Mullan. > > src/share/native/common/check_code.c > > - On AIX malloc(0) and calloc(0, ...) return a NULL pointer, which is > legal, but the code in check_code.c does not handles this properly. So > we wrap the two methods on AIX and return a non-NULL pointer even if we > allocate 0 bytes. > > src/share/native/sun/awt/medialib/mlib_sys.c > > - malloc always returns 8-byte aligned pointers on AIX as well. > > src/share/native/sun/awt/medialib/mlib_types.h > > - Add AIX to the list of known platforms. > > src/share/native/sun/font/layout/KernTable.cpp > > - Rename the macro DEBUG to DEBUG_KERN_TABLE because DEBUG is too > common and may be defined in other headers as well as on the command line > and xlc bails out on macro redefinitions with a different value. > > src/share/native/sun/security/ec/impl/ecc_impl.h > > - Define required types and macros on AIX. > > src/solaris/back/exec_md.c > > - AIX behaves like Linux in this case so check for it in the Linux > branch. > > src/solaris/bin/java_md_solinux.c, > src/solaris/bin/java_md_solinux.h > > - On AIX LD_LIBRARY_PATH is called LIBPATH > - Always use LD_LIBRARY_PATH macro instead of using the string " > LD_LIBRARY_PATH" directly to cope with different library path names. > - Add jre/lib//jli to the standard library search path on AIX > because the AIX linker doesn't support the -rpath option. > - Replace #ifdef __linux__ by #ifndef __solaris__ because in this > case, AIX behaves like Linux. > - Removed the definition of JVM_DLL, JAVA_DLL and LD_LIBRARY_PATH from > java_md_solinux.h because the macros are redefined in the > corresponding .c files anyway. > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > - Provide basic fontconfig.propertiesfor AIX. > > src/solaris/classes/java/lang/UNIXProcess.java.aix, > src/aix/classes/sun/tools/attach/AixAttachProvider.java, > src/aix/classes/sun/tools/attach/AixVirtualMachine.java, > src/aix/native/sun/tools/attach/AixVirtualMachine.c > > - Provide AIX specific Java versions, mostly based on the > corresponding Linux versions. > > src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java > src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java > > - Detect AIX operating system and return the corresponding channel and > file system providers. > > src/solaris/classes/sun/nio/ch/Port.java > > - Add a callback function unregisterImpl(int fd) for implementations > that need special handling when fd is removed and call it from unregister(int > fd). By default the implementation of unregisterImpl(int fd) is empty > except for the derived AixPollPort class on AIX. > > src/solaris/demo/jvmti/hprof/hprof_md.c > > - Add AIX support. AIX mostly behaves like Linux, with the one > exception that it has no dladdr functionality. > - Use the dladdr implementation from porting_aix.{c,h} on AIX. > > src/solaris/native/com/sun/management/UnixOperatingSystem_md.c > > - Adapt for AIX (i.e. use libperfstat on AIX to query OS memory). > > src/solaris/native/common/jdk_util_md.h > > - Add AIX definitions of the ISNANF and ISNAND macros. > > src/solaris/native/java/io/io_util_md.c > > - AIX behaves like Linux in this case so check for it in the Linux > branch. > > src/solaris/native/java/lang/UNIXProcess_md.c > > - AIX behaves mostly like Solraris in this case so adjust the ifdefs > accordingly. > > src/solaris/native/java/lang/childproc.c > > - AIX does not understand '/proc/self' - it requires the real process > ID to query the proc file system for the current process. > > src/solaris/native/java/net/NetworkInterface.c > > - Add AIX support into the Linux branch because AIX mostly behaves > like AIX for IPv4. > - AIX needs a special function to enumerate IPv6 interfaces and to > query the MAC address. > - Moved the declaration of siocgifconfRequest to the beginning a the > function (as recommend by Michael McMahon) to remain C89 compatible. > > src/solaris/native/java/net/PlainSocketImpl.c > > - On AIX (like on Solaris) setsockopt will set errno to EINVAL if the > socket is closed. The default error message is then confusing. > > src/aix/native/java/net/aix_close.c, > src/share/native/java/net/net_util.c > > - As recommended by Michael McMahon and Alan Bateman I've move an > adapted version of linux_close.c to src/aix/native/java/net/aix_close.cbecause we also need the file and socket wrappers on AIX. > - Compared to the Linux version, we've added the initialization of > some previously uninitialized data structures. > - Also, on AIX we don't have __attribute((constructor)) so we need to > initialize manually (from JNI_OnLoad() in > src/share/native/java/net/net_util.c. > > src/solaris/native/java/net/net_util_md.h > > - AIX needs the same workaround for I/O cancellation like Linux and > MacOSX. > > src/solaris/native/java/net/net_util_md.c > > - SO_REUSEADDR is called SO_REUSEPORT on AIX. > - On AIX we have to ignore failures due to ENOBUFS when setting the > SO_SNDBUF/SO_RCVBUF socket options. > > src/solaris/native/java/util/TimeZone_md.c > > - Currently on AIX the only way to get the platform time zone is to > read it from the TZ environment variable. > > src/solaris/native/sun/awt/awt_LoadLibrary.c > > - Use the dladdr from porting_aix.{c,h} on AIX. > > src/solaris/native/sun/awt/fontpath.c > > - Changed some macros from if !defined(__linux__) to if > defined(__solaris__) because that's their real meaning. > - Add AIX specific fontpath settings and library search paths for > libfontconfig.so. > > src/solaris/native/sun/java2d/x11/X11SurfaceData.c > > - Rename the MIN and MAX macros to XSD_MIN and XSD_MAX to avoid name > clashes (MIN and MAX are much too common and thexy are already defined > in some AIX system headers). > > src/solaris/native/sun/java2d/x11/XRBackendNative.c > > - Handle AIX like Solaris. > > src/solaris/native/sun/nio/ch/Net.c > > - Add AIX-specific includes and constant definitions. > - On AIX "socket extensions for multicast source filters" support > depends on the OS version. Check for this and throw appropriate exceptions > if it is requested but not supported. This is needed to pass > JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast > > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > > - On AIX strerror() is not thread-safe so we have to use strerror_r()instead. > - On AIX readdir_r() returns EBADF (i.e. '9') and sets 'result' to > NULL for the directory stream end. Otherwise, 'errno' will contain the > error code. > - Handle some AIX corner cases for the results of the statvfs64() call. > - On AIX getgrgid_r() returns ESRCH if group does not exist. > > src/solaris/native/sun/security/pkcs11/j2secmod_md.c > > - Use RTLD_LAZY instead of RTLD_NOLOAD on AIX. > > test/java/lang/ProcessBuilder/Basic.java > test/java/lang/ProcessBuilder/DestroyTest.java > > - Port this test to AIX and make it more robust (i.e. recognize the > "C" locale as isEnglish(), ignore VM-warnings in the output, make sure > the "grandchild" processes created by the test don't run too long (60s vs. > 6666s) because in the case of test problems these processes will pollute > the process space, make sure the test fails with an error and doesn't hang > indefinitley in the case of a problem). > > *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is this > intended? > > Well, _AIX is defined in some system headers while AIX is defined by the > build system. This is already used inconsistently (i.e. __linux__ vs. > LINUX) and in general I try to be consistent with the style of the file > where I the changes are. That said, I changes most of the occurences of > AIX to _AIX. > > *Q (Alan Bateman):* There are a few changes for OS/400 in the patch, are > they supposed to be there? > > We currently don't support OS/400 (later renamed into i5/OS and currently > called IBM i) in our OpenJDK port but we do support it in our internel, SAP > JVM build. We stripped out all the extra OS/400 functionality from the port > but in some places where there is common functionality needd by both, AIX > and OS/400 the OS/400 support may still be visible in the OpenJDK port. I > don't think this is a real problem and it helps us to keep our internel > sources in sync with the OpenJDK port. That said, I think I've removed all > the references to OS/400 now. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131126/07f59421/attachment-0001.html From iris.clark at oracle.com Tue Nov 26 10:08:51 2013 From: iris.clark at oracle.com (Iris Clark) Date: Tue, 26 Nov 2013 10:08:51 -0800 (PST) Subject: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: <5294D453.5050402@oracle.com> References: <5294D453.5050402@oracle.com> Message-ID: > So overall it looks good to me and should be pushed to the staging > forest once you hear from others that commented previously. I think that means Chris Hegarty, Michael McMahon, and Sergey Bylokhov. Alan, please correct me if I'm wrong. Thanks, iris -----Original Message----- From: Alan Bateman Sent: Tuesday, November 26, 2013 9:03 AM To: Volker Simonis Cc: Vladimir Kozlov; 2d-dev at openjdk.java.net; serviceability-dev at openjdk.java.net; security-dev; ppc-aix-port-dev at openjdk.java.net; awt-dev at openjdk.java.net; Java Core Libs; net-dev Subject: Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX On 26/11/2013 16:23, Volker Simonis wrote: > Hi, > > thanks to everybody for the prompt and helpful reviews. Here comes the > final webrev which incorporates all the corrections and suggestions > from the second review round: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ > > I've successfully build (and run some smoke tests) with these changes > on Linux (x86_32, x86_64, ppc64), Solaris/sparcv9, Windows/x86_64, > MacOSX and AIX (5.3, 7.1). > I've skimmed over the last webrev with focus on: NetworkingLibraries.gmk where I see this is now fixed for all platforms. net_util.* and the platform specific net_util_md.* where I see you've added platformInit so it's much cleaner. UnixNativeDispatcher.c where the error translation is now removed (and looks fine). So overall it looks good to me and should be pushed to the staging forest once you hear from others that commented previously. -Alan From philip.race at oracle.com Tue Nov 26 12:01:11 2013 From: philip.race at oracle.com (Phil Race) Date: Tue, 26 Nov 2013 12:01:11 -0800 Subject: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX In-Reply-To: References: Message-ID: <5294FE07.3060309@oracle.com> Looking only at what you needed to change this time round, all seems fine now. -phil. On 11/26/13 8:23 AM, Volker Simonis wrote: > Hi, > > thanks to everybody for the prompt and helpful reviews. Here comes the > final webrev which incorporates all the corrections and suggestions > from the second review round: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ > > > I've successfully build (and run some smoke tests) with these changes > on Linux (x86_32, x86_64, ppc64), Solaris/sparcv9, Windows/x86_64, > MacOSX and AIX (5.3, 7.1). > > So if nobody vetoes these changes are ready for push into our staging > repository. > > @Vladimir: can I push them or do you want to run them trough JPRT? > > Thank you and best regards, > Volker > > PS: compared to the last webrev > (http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > ), I've > slightly changed the following files: > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/NetworkingLibraries.gmk > makefiles/Setup.gmk > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/native/java/net/aix_close.c > src/aix/porting/porting_aix.c > src/share/native/java/net/net_util.c > src/share/native/java/net/net_util.h > src/share/native/sun/awt/medialib/mlib_sys.c > src/solaris/bin/java_md_solinux.c > src/solaris/classes/sun/nio/ch/Port.java > src/solaris/native/java/net/net_util_md.c > src/solaris/native/sun/java2d/x11/XRBackendNative.c > src/solaris/native/sun/management/OperatingSystemImpl.c > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > src/windows/native/java/net/net_util_md.c > > Most of the changes are cosmetic, except the ones in: > > src/share/native/java/net/net_util.c > src/share/native/java/net/net_util.h > src/solaris/native/java/net/net_util_md.c > src/windows/native/java/net/net_util_md.c > > where I renamed 'initLocalAddrTable()' to 'platformInit()'. For AIX, > this method will now call 'aix_close_init()' as suggested by Alan. > > The changes to src/solaris/native/com/sun/ > management/UnixOperatingSystem_md.c are now in > src/solaris/native/sun/management/OperatingSystemImpl.c because that > file was moved by an upstream change. > > > > On Wed, Nov 20, 2013 at 7:26 PM, Volker Simonis > > wrote: > > Hi, > > this is the second review round for "8024854: Basic changes and > files to build the class library on AIX > ". The previous > reviews can be found at the end of this mail in the references > section. > > I've tried to address all the comments and suggestions from the > first round and to further streamline the patch (it perfectly > builds on Linux/x86_64, Linux/PPC664, AIX, Solaris/SPARC and > Windows/x86_64). The biggest change compared to the first review > round is the new "aix/" subdirectory which I've now created under > "jdk/src" and which contains AIX-only code. > > The webrev is against our > http://hg.openjdk.java.net/ppc-aix-port/stage repository which has > been recently synchronised with the jdk8 master: > > http://cr.openjdk.java.net/~simonis/webrevs/8024854.v2/ > > > Below (and in the webrev) you can find some comments which explain > the changes to each file. In order to be able to push this big > change, I need the approval of reviewers from the lib, net, svc, > 2d, awt and sec groups. So please don't hesitate to jump at it - > there are enough changes for everybody:) > > Thank you and best regards, > Volker > > *References:* > > The following reviews have been posted so far (thanks Iris for > collecting them :) > > - Alan Bateman (lib): Initial comments (16 Sep [2]) > - Chris Hegarty (lib/net): Initial comments (20 Sep [3]) > - Michael McMahon (net): Initial comments (20 Sept [4]) > - Steffan Larsen (svc): APPROVED (20 Sept [5]) > - Phil Race (2d): Initial comments (18 Sept [6]); Additional > comments (15 Oct [7]) > - Sean Mullan (sec): Initial comments (26 Sept [8]) > > [2]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001045.html > [3]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001078.html > [4]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001079.html > [5]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001077.html > [6]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001069.html > [7]: > http://mail.openjdk.java.net/pipermail/2d-dev/2013-October/003826.html > [8]: > http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2013-September/001081.html > > > *Detailed change description:* > > The new "jdk/src/aix" subdirectory contains the following new and > AIX-specific files for now: > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > src/aix/classes/sun/nio/ch/AixAsynchronousChannelProvider.java > src/aix/classes/sun/nio/ch/AixPollPort.java > src/aix/classes/sun/nio/fs/AixFileStore.java > src/aix/classes/sun/nio/fs/AixFileSystem.java > src/aix/classes/sun/nio/fs/AixFileSystemProvider.java > src/aix/classes/sun/nio/fs/AixNativeDispatcher.java > src/aix/classes/sun/tools/attach/AixAttachProvider.java > src/aix/classes/sun/tools/attach/AixVirtualMachine.java > src/aix/native/java/net/aix_close.c > src/aix/native/sun/nio/ch/AixPollPort.c > src/aix/native/sun/nio/fs/AixNativeDispatcher.c > src/aix/native/sun/tools/attach/AixVirtualMachine.c > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > > src/aix/porting/porting_aix.c > src/aix/porting/porting_aix.h > > * Added these two files for AIX relevant utility code. > * Currently these files only contain an implementation of > |dladdr| which is not available on AIX. > * In the first review round the existing |dladdr| users in the > code either called the version from the HotSpot on AIX > (|src/solaris/native/sun/awt/awt_LoadLibrary.c|) or had a > private copy of the whole implementation > (|src/solaris/demo/jvmti/hprof/hprof_md.c|). This is now not > necessary any more. > > The new file layout required some small changes to the makefiles > to make them aware of the new directory locations: > > > makefiles/CompileDemos.gmk > > * Add an extra argument to |SetupJVMTIDemo| which can be used to > pass additional source locations. > * Currently this is only used on AIX for the AIX porting > utilities which are required by hprof. > > > makefiles/lib/Awt2dLibraries.gmk > makefiles/lib/ServiceabilityLibraries.gmk > > * On AIX add the sources of the AIX porting utilities to the > build. They are required by > |src/solaris/native/sun/awt/awt_LoadLibrary.c| and > |src/solaris/demo/jvmti/hprof/hprof_md.c| because |dladdr| is > not available on AIX. > > > makefiles/lib/NioLibraries.gmk > > * Make the AIX-build aware of the new NIO source locations under > |src/aix/native/sun/nio/|. > > > makefiles/lib/NetworkingLibraries.gmk > > * Make the AIX-build aware of the new |aix_close.c| source > location under |src/aix/native/java/net/|. > > > src/share/bin/jli_util.h > > * Define |JLI_Lseek| on AIX. > > > src/share/lib/security/java.security-aix > > * Provide default |java.security-aix| for AIX based on the > latest Linux version as suggested by Sean Mullan. > > > src/share/native/common/check_code.c > > * On AIX malloc(0) and calloc(0, ...) return a NULL pointer, > which is legal, but the code in |check_code.c| does not > handles this properly. So we wrap the two methods on AIX and > return a non-NULL pointer even if we allocate 0 bytes. > > > src/share/native/sun/awt/medialib/mlib_sys.c > > * |malloc| always returns 8-byte aligned pointers on AIX as well. > > > src/share/native/sun/awt/medialib/mlib_types.h > > * Add AIX to the list of known platforms. > > > src/share/native/sun/font/layout/KernTable.cpp > > * Rename the macro |DEBUG| to |DEBUG_KERN_TABLE| because |DEBUG| > is too common and may be defined in other headers as well as > on the command line and |xlc| bails out on macro redefinitions > with a different value. > > > src/share/native/sun/security/ec/impl/ecc_impl.h > > * Define required types and macros on AIX. > > > src/solaris/back/exec_md.c > > * AIX behaves like Linux in this case so check for it in the > Linux branch. > > > src/solaris/bin/java_md_solinux.c, > src/solaris/bin/java_md_solinux.h > > * On AIX |LD_LIBRARY_PATH| is called |LIBPATH| > * Always use |LD_LIBRARY_PATH| macro instead of using the string > "|LD_LIBRARY_PATH|" directly to cope with different library > path names. > * Add |jre/lib//jli| to the standard library search path > on AIX because the AIX linker doesn't support the |-rpath| option. > * Replace |#ifdef __linux__| by |#ifndef __solaris__| because in > this case, AIX behaves like Linux. > * Removed the definition of |JVM_DLL|, |JAVA_DLL| and > |LD_LIBRARY_PATH| from |java_md_solinux.h| because the macros > are redefined in the corresponding |.c| files anyway. > > > src/aix/classes/sun/awt/fontconfigs/aix.fontconfig.properties > > * Provide basic |fontconfig.properties|for AIX. > > > src/solaris/classes/java/lang/UNIXProcess.java.aix, > src/aix/classes/sun/tools/attach/AixAttachProvider.java, > src/aix/classes/sun/tools/attach/AixVirtualMachine.java, > src/aix/native/sun/tools/attach/AixVirtualMachine.c > > * Provide AIX specific Java versions, mostly based on the > corresponding Linux versions. > > > src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java > src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java > > * Detect AIX operating system and return the corresponding > channel and file system providers. > > > src/solaris/classes/sun/nio/ch/Port.java > > * Add a callback function |unregisterImpl(int fd)| for > implementations that need special handling when |fd| is > removed and call it from |unregister(int fd)|. By default the > implementation of |unregisterImpl(int fd)| is empty except for > the derived |AixPollPort| class on AIX. > > > src/solaris/demo/jvmti/hprof/hprof_md.c > > * Add AIX support. AIX mostly behaves like Linux, with the one > exception that it has no |dladdr| functionality. > * Use the |dladdr| implementation from |porting_aix.{c,h}| on AIX. > > > src/solaris/native/com/sun/management/UnixOperatingSystem_md.c > > * Adapt for AIX (i.e. use |libperfstat| on AIX to query OS memory). > > > src/solaris/native/common/jdk_util_md.h > > * Add AIX definitions of the |ISNANF| and |ISNAND| macros. > > > src/solaris/native/java/io/io_util_md.c > > * AIX behaves like Linux in this case so check for it in the > Linux branch. > > > src/solaris/native/java/lang/UNIXProcess_md.c > > * AIX behaves mostly like Solraris in this case so adjust the > ifdefs accordingly. > > > src/solaris/native/java/lang/childproc.c > > * AIX does not understand '/proc/self' - it requires the real > process ID to query the proc file system for the current process. > > > src/solaris/native/java/net/NetworkInterface.c > > * Add AIX support into the Linux branch because AIX mostly > behaves like AIX for IPv4. > * AIX needs a special function to enumerate IPv6 interfaces and > to query the MAC address. > * Moved the declaration of |siocgifconfRequest| to the beginning > a the function (as recommend by Michael McMahon) to remain C89 > compatible. > > > src/solaris/native/java/net/PlainSocketImpl.c > > * On AIX (like on Solaris) |setsockopt| will set errno to > |EINVAL| if the socket is closed. The default error message is > then confusing. > > > src/aix/native/java/net/aix_close.c, > src/share/native/java/net/net_util.c > > * As recommended by Michael McMahon and Alan Bateman I've move > an adapted version of |linux_close.c| to > |src/aix/native/java/net/aix_close.c| because we also need the > file and socket wrappers on AIX. > * Compared to the Linux version, we've added the initialization > of some previously uninitialized data structures. > * Also, on AIX we don't have |__attribute((constructor))| so we > need to initialize manually (from |JNI_OnLoad()| in > |src/share/native/java/net/net_util.c|. > > > src/solaris/native/java/net/net_util_md.h > > * AIX needs the same workaround for I/O cancellation like Linux > and MacOSX. > > > src/solaris/native/java/net/net_util_md.c > > * |SO_REUSEADDR| is called |SO_REUSEPORT| on AIX. > * On AIX we have to ignore failures due to |ENOBUFS| when > setting the |SO_SNDBUF|/|SO_RCVBUF| socket options. > > > src/solaris/native/java/util/TimeZone_md.c > > * Currently on AIX the only way to get the platform time zone is > to read it from the |TZ| environment variable. > > > src/solaris/native/sun/awt/awt_LoadLibrary.c > > * Use the |dladdr| from |porting_aix.{c,h}| on AIX. > > > src/solaris/native/sun/awt/fontpath.c > > * Changed some macros from |if !defined(__linux__)| to |if > defined(__solaris__)| because that's their real meaning. > * Add AIX specific fontpath settings and library search paths > for |libfontconfig.so|. > > > src/solaris/native/sun/java2d/x11/X11SurfaceData.c > > * Rename the |MIN| and |MAX| macros to |XSD_MIN| and |XSD_MAX| > to avoid name clashes (|MIN| and |MAX| are much too common and > thexy are already defined in some AIX system headers). > > > src/solaris/native/sun/java2d/x11/XRBackendNative.c > > * Handle AIX like Solaris. > > > src/solaris/native/sun/nio/ch/Net.c > > * Add AIX-specific includes and constant definitions. > * On AIX "socket extensions for multicast source filters" > support depends on the OS version. Check for this and throw > appropriate exceptions if it is requested but not supported. > This is needed to pass > JCK-api/java_nio/channels/DatagramChannel/DatagramChannel.html#Multicast > > > src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c > > * On AIX |strerror()| is not thread-safe so we have to use > |strerror_r()| instead. > * On AIX |readdir_r()| returns EBADF (i.e. '9') and sets > 'result' to NULL for the directory stream end. Otherwise, > 'errno' will contain the error code. > * Handle some AIX corner cases for the results of the > |statvfs64()| call. > * On AIX |getgrgid_r()| returns ESRCH if group does not exist. > > > src/solaris/native/sun/security/pkcs11/j2secmod_md.c > > * Use |RTLD_LAZY| instead of |RTLD_NOLOAD| on AIX. > > > test/java/lang/ProcessBuilder/Basic.java > test/java/lang/ProcessBuilder/DestroyTest.java > > * Port this test to AIX and make it more robust (i.e. recognize > the "C" locale as |isEnglish()|, ignore VM-warnings in the > output, make sure the "grandchild" processes created by the > test don't run too long (60s vs. 6666s) because in the case of > test problems these processes will pollute the process space, > make sure the test fails with an error and doesn't hang > indefinitley in the case of a problem). > > *Q (Michael McMahon):* Seems to be two macros _AIX and AIX. Is > this intended? > > Well, |_AIX| is defined in some system headers while |AIX| is > defined by the build system. This is already used inconsistently > (i.e. |__linux__| vs. |LINUX|) and in general I try to be > consistent with the style of the file where I the changes are. > That said, I changes most of the occurences of |AIX| to |_AIX|. > > *Q (Alan Bateman):* There are a few changes for OS/400 in the > patch, are they supposed to be there? > > We currently don't support OS/400 (later renamed into i5/OS and > currently called IBM i) in our OpenJDK port but we do support it > in our internel, SAP JVM build. We stripped out all the extra > OS/400 functionality from the port but in some places where there > is common functionality needd by both, AIX and OS/400 the OS/400 > support may still be visible in the OpenJDK port. I don't think > this is a real problem and it helps us to keep our internel > sources in sync with the OpenJDK port. That said, I think I've > removed all the references to OS/400 now. > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131126/51b1b229/attachment-0001.html From vladimir.kozlov at oracle.com Tue Nov 26 15:13:38 2013 From: vladimir.kozlov at oracle.com (vladimir.kozlov at oracle.com) Date: Tue, 26 Nov 2013 23:13:38 +0000 Subject: hg: jdk8/tl/jdk: 8016839: JSR292: AME instead of IAE when calling a method Message-ID: <20131126231350.CD08F6288D@hg.openjdk.java.net> Changeset: e822676cd3cd Author: jrose Date: 2013-11-26 17:16 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e822676cd3cd 8016839: JSR292: AME instead of IAE when calling a method Summary: Catch missing-because-illegal case for itable entries and use an exception-throwing method instead of null. Reviewed-by: acorn, jrose, coleenp Contributed-by: david.r.chase at oracle.com ! src/share/classes/sun/misc/Unsafe.java From naoto.sato at oracle.com Wed Nov 27 10:01:47 2013 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 27 Nov 2013 18:01:47 +0000 Subject: hg: jdk8/tl/jdk: 8028771: regression test java/util/Locale/LocaleProviders.sh failed Message-ID: <20131127180205.D38E9628AC@hg.openjdk.java.net> Changeset: 2370d285d08b Author: naoto Date: 2013-11-27 10:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2370d285d08b 8028771: regression test java/util/Locale/LocaleProviders.sh failed Reviewed-by: alanb ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh From sean.mullan at oracle.com Wed Nov 27 10:12:59 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 27 Nov 2013 13:12:59 -0500 Subject: Code Review Request: 8025763 In-Reply-To: <529548CA.8030008@oracle.com> References: <52606140.1060204@oracle.com> <52618F88.5000803@oracle.com> <5261F3E5.9060409@oracle.com> <5265A119.1060606@oracle.com> <529548CA.8030008@oracle.com> Message-ID: <5296362B.7080905@oracle.com> On 11/26/2013 08:20 PM, Bradford Wetmore wrote: > Tony, > > I note the @since's are missing for the new methods, both in the > generated output in the overridden methods (i.e. no javadoc), and the > methods in which you've changed the behavior (i.e. new javadoc). > > I'm not sure what you can do about the previous behavior (cc'ing > Mike/Sowmya, maybe they know), but what about the new ones? That kind of seems like a javadoc bug to me. Shouldn't it add the @since tag as part of inheriting the javadoc? Anyway, adding @since tags would be considered a docs only change, so Tony you could still fix this for JDK 8 - can you file a bug? Thanks, Sean > > Brad > > > > On 10/21/2013 2:48 PM, Sean Mullan wrote: >> On 10/18/2013 10:52 PM, Anthony Scarpino wrote: >>> I've updated the webrev >>> >>> http://cr.openjdk.java.net/~ascarpino/8025763/webrev.01/ >> >> Update looks good. >> >> --Sean From anthony.scarpino at oracle.com Wed Nov 27 12:46:06 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Wed, 27 Nov 2013 12:46:06 -0800 Subject: Code Review Request: 8025763 In-Reply-To: <5296362B.7080905@oracle.com> References: <52606140.1060204@oracle.com> <52618F88.5000803@oracle.com> <5261F3E5.9060409@oracle.com> <5265A119.1060606@oracle.com> <529548CA.8030008@oracle.com> <5296362B.7080905@oracle.com> Message-ID: <839A2BFF-5EB8-4BC0-BE6F-0D4C2EAADC4E@oracle.com> > On Nov 27, 2013, at 10:12 AM, Sean Mullan wrote: > >> On 11/26/2013 08:20 PM, Bradford Wetmore wrote: >> Tony, >> >> I note the @since's are missing for the new methods, both in the >> generated output in the overridden methods (i.e. no javadoc), and the >> methods in which you've changed the behavior (i.e. new javadoc). >> >> I'm not sure what you can do about the previous behavior (cc'ing >> Mike/Sowmya, maybe they know), but what about the new ones? > > That kind of seems like a javadoc bug to me. Shouldn't it add the @since tag as part of inheriting the javadoc? > > Anyway, adding @since tags would be considered a docs only change, so Tony you could still fix this for JDK 8 - can you file a bug? > > Thanks, > Sean My first thought was it would be a javadoc issue too. Let me see if setting @since doesn't cause the inheritance of the other tag to stop. If it doesn't I'll fix it for 8. Tony > >> >> Brad >> >> >> >>> On 10/21/2013 2:48 PM, Sean Mullan wrote: >>>> On 10/18/2013 10:52 PM, Anthony Scarpino wrote: >>>> I've updated the webrev >>>> >>>> http://cr.openjdk.java.net/~ascarpino/8025763/webrev.01/ >>> >>> Update looks good. >>> >>> --Sean > From bradford.wetmore at oracle.com Wed Nov 27 12:47:46 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Wed, 27 Nov 2013 12:47:46 -0800 Subject: Thoughts on possible options to JDK-8027598 In-Reply-To: <52932695.7040407@oracle.com> References: <528C0023.8060302@oracle.com> <528C0B48.70606@oracle.com> <528CA2E9.6060002@oracle.com> <528D474A.2020400@oracle.com> <528DD80A.7020600@oracle.com> <528FB398.4050305@oracle.com> <528FC89B.309@oracle.com> <52932695.7040407@oracle.com> Message-ID: <52965A72.5050608@oracle.com> > jtreg team? I am not aware of one. Jon Gibbons works on this in his > spare time. I would call him "the JTREG team." Was there an ETA for this? Balancing recent test stabilization efforts with this, you may consider consider adding othervm and then back it out when the JTREG fix is made. Brad On 11/25/2013 2:29 AM, Chris Hegarty wrote: > On 22/11/13 21:11, Rajan Halade wrote: >> >> On 11/22/2013 11:42, Sean Mullan wrote: >>> On 11/21/2013 04:53 AM, Chris Hegarty wrote: >>>>>>> If I am correct, JTREG has support provider cleanup already. But the >>>>>>> question is even JTREG reset the providers, it still cannot ensure >>>>>>> next >>>>>>> test won't be impacted because in some circumstances JDK may need to >>>>>>> cache something which depends on previous providers. Still need to >>>>>>> analysis the test case by case. >>>>>> >>>>>> Right, any static or cached data may be invalid, and this will >>>>>> require >>>>>> careful changes to the JRE itself. >>>>> Pardon my ignorance - if I gather correctly then ProvidersSnapshot >>>>> library also doesn't sandbox effects completely. >>>> >>>> FYI. I am not part of the security team, and someone from the security >>>> group should ultimately have to agree/disagree, but we have similar >>>> issues in other parts of the platform. I don't know the specifics of >>>> the >>>> code here so it may, or may not, be an issue. >>>> >>>> If any part of the security framework stores values in static fields, >>>> that is dependent on the security providers, then when the providers >>>> change this static value may be incorrect. >>>> >>>> We encounter this from time to time with system properties. E.g. JDK >>>> HTTP Client code reads system property and stores in static field, JDK >>>> HTTP Client will never never re-read the property as it believes it >>>> will >>>> not change. Having jtreg reset/clean certain system properties will not >>>> help in this case. >>> >>> Yes, the example with system properties is a good one. >>> >>> However, providers are designed to be added and removed dynamically >>> (see the java.security.Security API), so if there is some static >>> information not being cleared when providers are reset, I would tend >>> to think it may be a bug in the JDK. > > OK, if this is the case then that is fine. > >> yes. thanks! >>> >>> My preference would be change jtreg to clear/restore providers, and >>> more thoroughly analyze any subsequent test failures as it may be a >>> bug in the JDK. >> Ok, I will follow up with jtreg team to find out when they can commit to >> timeline. > > jtreg team? I am not aware of one. Jon Gibbons works on this in his > spare time. You may want to take a look at jtreg [1] in the code tools > project. > > -Chris. > > [1] http://openjdk.java.net/projects/code-tools/jtreg/ > >> >> - Rajan >>> >>> --Sean >>> >> From bradford.wetmore at oracle.com Wed Nov 27 12:55:58 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Wed, 27 Nov 2013 12:55:58 -0800 Subject: Code Review Request: 8025763 In-Reply-To: <839A2BFF-5EB8-4BC0-BE6F-0D4C2EAADC4E@oracle.com> References: <52606140.1060204@oracle.com> <52618F88.5000803@oracle.com> <5261F3E5.9060409@oracle.com> <5265A119.1060606@oracle.com> <529548CA.8030008@oracle.com> <5296362B.7080905@oracle.com> <839A2BFF-5EB8-4BC0-BE6F-0D4C2EAADC4E@oracle.com> Message-ID: <52965C5E.9050200@oracle.com> Sean wrote: > That kind of seems like a javadoc bug to me. Shouldn't it add the > @since tag as part of inheriting the javadoc? On the chance that this is a real bug, I filed this yesterday: https://bugs.openjdk.java.net/browse/JDK-8029241 @throws/@since are both missing (others?), it seems more efficient from a developer perspective to simply copy this info to the overridden classes, instead of making the developer drill down to get the rest of the information. Tony wrote: > Let me see if setting @since doesn't cause the inheritance of the > other tag to stop. If it doesn't I'll fix it for 8. I'm guessing that if you add anything, it's going to suppress the inherited javadoc, so you'll have to wait for JDK-8029241 to be fixed. But for the case of new stuff where you've provided new text, I feel it should have an @since added. And feel free to clean up the > 80 char lines! ;) Brad On 11/27/2013 12:46 PM, Anthony Scarpino wrote: > >> On Nov 27, 2013, at 10:12 AM, Sean Mullan wrote: >> >>> On 11/26/2013 08:20 PM, Bradford Wetmore wrote: >>> Tony, >>> >>> I note the @since's are missing for the new methods, both in the >>> generated output in the overridden methods (i.e. no javadoc), and the >>> methods in which you've changed the behavior (i.e. new javadoc). >>> >>> I'm not sure what you can do about the previous behavior (cc'ing >>> Mike/Sowmya, maybe they know), but what about the new ones? >> >> That kind of seems like a javadoc bug to me. Shouldn't it add the @since tag as part of inheriting the javadoc? >> >> Anyway, adding @since tags would be considered a docs only change, so Tony you could still fix this for JDK 8 - can you file a bug? >> >> Thanks, >> Sean > > My first thought was it would be a javadoc issue too. > > Let me see if setting @since doesn't cause the inheritance of the other tag to stop. If it doesn't I'll fix it for 8. > > Tony > >> >>> >>> Brad >>> >>> >>> >>>> On 10/21/2013 2:48 PM, Sean Mullan wrote: >>>>> On 10/18/2013 10:52 PM, Anthony Scarpino wrote: >>>>> I've updated the webrev >>>>> >>>>> http://cr.openjdk.java.net/~ascarpino/8025763/webrev.01/ >>>> >>>> Update looks good. >>>> >>>> --Sean >> From bradford.wetmore at oracle.com Wed Nov 27 13:07:13 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Wed, 27 Nov 2013 13:07:13 -0800 Subject: Code Review Request: 8021418 In-Reply-To: <52955462.6050406@oracle.com> References: <5295473C.9090508@oracle.com> <52955462.6050406@oracle.com> Message-ID: <52965F01.7080601@oracle.com> Where did this workaround suggestion come from? Please link these two issues (JDK-6978415) together. Have you talked to the network team about this? brad On 11/26/2013 6:09 PM, Xuelei Fan wrote: > This change looks fine. > > JSSE regression tests use a lot of code as "new ServerSocket(0)", we may > want a cleanup for test stabilization. > > Xuelei > > On 11/27/2013 9:13 AM, Rajan Halade wrote: >> May I request you to review this simple change - >> >> http://cr.openjdk.java.net/~juh/rajan/8021418/ >> >> >> The test is modified to set SO_REUSEADDR on ServerSocket to false for >> stabilization. >> >> Thanks, >> Rajan > From rajan.halade at oracle.com Wed Nov 27 13:38:42 2013 From: rajan.halade at oracle.com (Rajan Halade) Date: Wed, 27 Nov 2013 13:38:42 -0800 Subject: Code Review Request: 8021418 In-Reply-To: <52965F01.7080601@oracle.com> References: <5295473C.9090508@oracle.com> <52955462.6050406@oracle.com> <52965F01.7080601@oracle.com> Message-ID: <52966662.9090700@oracle.com> On 11/27/2013 13:07, Bradford Wetmore wrote: > Where did this workaround suggestion come from? Refer to JDK-6978415, it has possible workaround listed. > > Please link these two issues (JDK-6978415) together. the two bugs are linked now. > > Have you talked to the network team about this? No, since workaround suggested solved the issue. Thanks, Rajan > > brad > > > > > On 11/26/2013 6:09 PM, Xuelei Fan wrote: >> This change looks fine. >> >> JSSE regression tests use a lot of code as "new ServerSocket(0)", we may >> want a cleanup for test stabilization. >> >> Xuelei >> >> On 11/27/2013 9:13 AM, Rajan Halade wrote: >>> May I request you to review this simple change - >>> >>> http://cr.openjdk.java.net/~juh/rajan/8021418/ >>> >>> >>> The test is modified to set SO_REUSEADDR on ServerSocket to false for >>> stabilization. >>> >>> Thanks, >>> Rajan >> From rajan.halade at oracle.com Wed Nov 27 13:43:28 2013 From: rajan.halade at oracle.com (Rajan Halade) Date: Wed, 27 Nov 2013 13:43:28 -0800 Subject: Thoughts on possible options to JDK-8027598 In-Reply-To: <52965A72.5050608@oracle.com> References: <528C0023.8060302@oracle.com> <528C0B48.70606@oracle.com> <528CA2E9.6060002@oracle.com> <528D474A.2020400@oracle.com> <528DD80A.7020600@oracle.com> <528FB398.4050305@oracle.com> <528FC89B.309@oracle.com> <52932695.7040407@oracle.com> <52965A72.5050608@oracle.com> Message-ID: <52966780.8040907@oracle.com> On 11/27/2013 12:47, Bradford Wetmore wrote: > > jtreg team? I am not aware of one. Jon Gibbons works on this in his > > spare time. > > I would call him "the JTREG team." > > Was there an ETA for this? Balancing recent test stabilization > efforts with this, you may consider consider adding othervm and then > back it out when the JTREG fix is made. I am discussing this with Jon and will soon update with summary of it. I am also working on adding /othervm to affected tests. - Rajan > > Brad > > > > On 11/25/2013 2:29 AM, Chris Hegarty wrote: >> On 22/11/13 21:11, Rajan Halade wrote: >>> >>> On 11/22/2013 11:42, Sean Mullan wrote: >>>> On 11/21/2013 04:53 AM, Chris Hegarty wrote: >>>>>>>> If I am correct, JTREG has support provider cleanup already. >>>>>>>> But the >>>>>>>> question is even JTREG reset the providers, it still cannot ensure >>>>>>>> next >>>>>>>> test won't be impacted because in some circumstances JDK may >>>>>>>> need to >>>>>>>> cache something which depends on previous providers. Still need to >>>>>>>> analysis the test case by case. >>>>>>> >>>>>>> Right, any static or cached data may be invalid, and this will >>>>>>> require >>>>>>> careful changes to the JRE itself. >>>>>> Pardon my ignorance - if I gather correctly then ProvidersSnapshot >>>>>> library also doesn't sandbox effects completely. >>>>> >>>>> FYI. I am not part of the security team, and someone from the >>>>> security >>>>> group should ultimately have to agree/disagree, but we have similar >>>>> issues in other parts of the platform. I don't know the specifics of >>>>> the >>>>> code here so it may, or may not, be an issue. >>>>> >>>>> If any part of the security framework stores values in static fields, >>>>> that is dependent on the security providers, then when the providers >>>>> change this static value may be incorrect. >>>>> >>>>> We encounter this from time to time with system properties. E.g. JDK >>>>> HTTP Client code reads system property and stores in static field, >>>>> JDK >>>>> HTTP Client will never never re-read the property as it believes it >>>>> will >>>>> not change. Having jtreg reset/clean certain system properties >>>>> will not >>>>> help in this case. >>>> >>>> Yes, the example with system properties is a good one. >>>> >>>> However, providers are designed to be added and removed dynamically >>>> (see the java.security.Security API), so if there is some static >>>> information not being cleared when providers are reset, I would tend >>>> to think it may be a bug in the JDK. >> >> OK, if this is the case then that is fine. >> >>> yes. thanks! >>>> >>>> My preference would be change jtreg to clear/restore providers, and >>>> more thoroughly analyze any subsequent test failures as it may be a >>>> bug in the JDK. >>> Ok, I will follow up with jtreg team to find out when they can >>> commit to >>> timeline. >> >> jtreg team? I am not aware of one. Jon Gibbons works on this in his >> spare time. You may want to take a look at jtreg [1] in the code tools >> project. >> >> -Chris. >> >> [1] http://openjdk.java.net/projects/code-tools/jtreg/ >> >>> >>> - Rajan >>>> >>>> --Sean >>>> >>> From jason.uh at oracle.com Wed Nov 27 15:27:00 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Wed, 27 Nov 2013 23:27:00 +0000 Subject: hg: jdk8/tl/jdk: 8021418: Intermittent: SSLSocketSSLEngineTemplate.java test fails with timeout Message-ID: <20131127232713.D3EFD628C0@hg.openjdk.java.net> Changeset: 5ac7cd164300 Author: juh Date: 2013-11-27 15:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ac7cd164300 8021418: Intermittent: SSLSocketSSLEngineTemplate.java test fails with timeout Reviewed-by: xuelei, wetmore Contributed-by: rajan.halade at oracle.com ! test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.java From xuelei.fan at oracle.com Wed Nov 27 17:27:35 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Thu, 28 Nov 2013 09:27:35 +0800 Subject: Code Review Request: 8021418 In-Reply-To: <52966662.9090700@oracle.com> References: <5295473C.9090508@oracle.com> <52955462.6050406@oracle.com> <52965F01.7080601@oracle.com> <52966662.9090700@oracle.com> Message-ID: <52969C07.9080104@oracle.com> On 11/28/2013 5:38 AM, Rajan Halade wrote: > On 11/27/2013 13:07, Bradford Wetmore wrote: >> Where did this workaround suggestion come from? > Refer to JDK-6978415, it has possible workaround listed. The spec of ServerSocket.setReuseAddress() says, "When a ServerSocket is created the initial setting of SO_REUSEADDR is not defined." I think it's nice to explicitly set the value in case of address reuse when using automatically allocated server port. Xuelei From jaroslav.bachorik at oracle.com Thu Nov 28 00:16:50 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Thu, 28 Nov 2013 08:16:50 +0000 Subject: hg: jdk8/tl/jdk: 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS Message-ID: <20131128081759.A7522628D2@hg.openjdk.java.net> Changeset: 4afe1281c837 Author: jbachorik Date: 2013-11-28 09:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4afe1281c837 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS Reviewed-by: mchung ! test/com/sun/management/GarbageCollectorMXBean/LastGCInfo.java ! test/java/lang/management/GarbageCollectorMXBean/GcInfoCompositeType.java From chris.hegarty at oracle.com Fri Nov 29 01:26:20 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 29 Nov 2013 09:26:20 +0000 Subject: hg: jdk8/tl/jdk: 8029348: ProblemList.txt updates (11/2013) Message-ID: <20131129092634.5775662930@hg.openjdk.java.net> Changeset: 5bcaf730ceb8 Author: tyan Date: 2013-11-29 09:29 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bcaf730ceb8 8029348: ProblemList.txt updates (11/2013) Reviewed-by: chegar ! test/ProblemList.txt From alexyursha at gmail.com Fri Nov 29 07:46:27 2013 From: alexyursha at gmail.com (Alex Yursha) Date: Fri, 29 Nov 2013 18:46:27 +0300 Subject: Redundant check in java.security.BasicPermission.implies() Message-ID: Hi everyone, the summary of this issue is that it seems like java.security.BasicPermission.implies() executes a useless check that duplicates the functionality provided by java.lang.String.startsWith(). Below is a jdk7 code for java.security.BasicPermission.implies() method with the lines of interest highlighted in bold: public boolean implies(Permission p) { if ((p == null) || (p.getClass() != getClass())) return false; BasicPermission that = (BasicPermission) p; if (this.wildcard) { if (that.wildcard) { // one wildcard can imply another return that.path.startsWith(path); } else { *// make sure ap.path is longer so a.b.* doesn't imply a.b* * return (that.path.length() > this.path.length()) &&* * that.path.startsWith(this.path);* } } else { if (that.wildcard) { // a non-wildcard can't imply a wildcard return false; } else { return this.path.equals(that.path); } } } As the highlighted comment states, the length comparison check is performed in order to prevent such cases where "a.b.*" would imply "a.b". But the contract for java.lang.String.startsWith() is such that if the prefix length is greater than the string length than that test will fail. So it seems like java.security.BasicPermission.implies() tries to duplicate the check that is performed by java.lang.String.startswith() out of the box. Regards, Alex Yursha -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131129/362c13ab/attachment.html From tom.hawtin at oracle.com Fri Nov 29 09:16:13 2013 From: tom.hawtin at oracle.com (Tom Hawtin) Date: Fri, 29 Nov 2013 17:16:13 +0000 Subject: Redundant check in java.security.BasicPermission.implies() In-Reply-To: References: Message-ID: <5298CBDD.8000303@oracle.com> On 29/11/2013 15:46, Alex Yursha wrote: > // make sure ap.path is longer so a.b.* doesn't imply a.b ^. Somebody has removed the full stop from the sentence fragment. I'll give you that this class API docs should be better. > return (that.path.length() > this.path.length()) && > that.path.startsWith(this.path); > As the highlighted comment states, the length comparison check is > performed in order to prevent such cases where "a.b.*" would imply > "a.b". But the contract for java.lang.String.startsWith() is such that > if the prefix length is greater than the string length than that test > will fail. So it seems like java.security.BasicPermission.implies() > tries to duplicate the check that is performed by > java.lang.String.startswith() out of the box. So, suppose we had permissions with names "a.b.*" and "a.b.". These have paths "a.b." and "a.b." (respectively, or not). startsWith will return true, but the length comparison false. So - the check is not redundant - a.b. is not implied by a.b.* - BasicPermission does not correctly specify behaviour of wildcards (should probably have a CR) Tom From alexyursha at gmail.com Fri Nov 29 12:29:28 2013 From: alexyursha at gmail.com (Alex Yursha) Date: Fri, 29 Nov 2013 23:29:28 +0300 Subject: Redundant check in java.security.BasicPermission.implies() In-Reply-To: <5298CBDD.8000303@oracle.com> References: <5298CBDD.8000303@oracle.com> Message-ID: The javadocs for the class java.security.BasicPermission says, that the naming convention for BasicPermission names follows the hierarchical property naming convention with possible wildcards. AFAIU, *hierarchical property naming convention* assumes that you specify either a simple identifier like *user*, or a sequence of dot-separated identifiers like *user.group.id - *so what is the purpose for names like *user. *with a dot at the end? It seems like it contradicts the documentation and has no purpose. On Fri, Nov 29, 2013 at 8:16 PM, Tom Hawtin wrote: > On 29/11/2013 15:46, Alex Yursha wrote: > > // make sure ap.path is longer so a.b.* doesn't imply a.b >> > ^. > Somebody has removed the full stop from the sentence fragment. I'll give > you that this class API docs should be better. > > > return (that.path.length() > this.path.length()) && >> that.path.startsWith(this.path); >> > > As the highlighted comment states, the length comparison check is >> performed in order to prevent such cases where "a.b.*" would imply >> "a.b". But the contract for java.lang.String.startsWith() is such that >> if the prefix length is greater than the string length than that test >> will fail. So it seems like java.security.BasicPermission.implies() >> tries to duplicate the check that is performed by >> java.lang.String.startswith() out of the box. >> > > So, suppose we had permissions with names "a.b.*" and "a.b.". These have > paths "a.b." and "a.b." (respectively, or not). startsWith will return > true, but the length comparison false. > > So > > - the check is not redundant > - a.b. is not implied by a.b.* > - BasicPermission does not correctly specify behaviour of wildcards > (should probably have a CR) > > Tom > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/security-dev/attachments/20131129/c144c89f/attachment.html