From artem.smotrakov at oracle.com Tue Oct 1 09:45:08 2013 From: artem.smotrakov at oracle.com (Artem) Date: Tue, 01 Oct 2013 13:45:08 +0400 Subject: Code review request: 8025123: SNI support in Kerberos cipher suites In-Reply-To: <5249908B.9090804@oracle.com> References: <52497C36.4020604@oracle.com> <524984D4.1000403@oracle.com> <52498B85.9090603@oracle.com> <5249908B.9090804@oracle.com> Message-ID: <524A99A4.7020506@oracle.com> Hi Max, I updated the fix according to your comments: http://cr.openjdk.java.net/~kshefov/8025123/webrev.02/ Artem On 09/30/2013 06:54 PM, Weijun Wang wrote: > Now that we only check "localhost" and "localhost.localdomain", the > following hack in the SSL.java test is not necessary any more: > > 92 // Run this after KDC, so our own DNS service can be started > 93 try { > 94 server = > InetAddress.getLocalHost().getHostName().toLowerCase(); > 95 } catch (java.net.UnknownHostException e) { > 96 server = "localhost"; > 97 } > > Just write > > server = "host." + OneKDC.REALM.toLowerCase(Locale.US); > > There is another coding style thing in > KerberosClientKeyExchangeImpl.java: > > + if ("localhost".equals(serverName) || > + "localhost.localdomain".equals(serverName)) { > > When a long time is broken to two, the second line should be indented > twice the normal width, i.e. > > + if ("localhost".equals(serverName) || > + "localhost.localdomain".equals(serverName)) { > > Everything nice is fine. > > Thanks > Max > > On 9/30/13 10:32 PM, Artem wrote: >> Updated webrev: http://cr.openjdk.java.net/~kshefov/8025123/webrev.01/ >> >> >> - broke lines exceed 80 characters >> - the code updated accrding to >> http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-142311.html#449 >> >> - updated copy right dates >> >> Artem >> >> On 09/30/2013 06:04 PM, Xuelei Fan wrote: >>> It's a good catch and wonderful fix. Thanks, Artem! >>> >>> The fix looks fine to me, except three very minor coding style >>> comments. >>> 1. we used to have only 80 characters in each line. >>> I think there might some lines exceed 80 characters, would you mind >>> break these lines to keep the style consistent? It is especially >>> friendly to users like me that use vi terminal. >>> >>> 2. KerberosClientKeyExchangeImpl.java >>> >>> + if(localHost != null) serverName = localHost; >>> >>> Personally, I prefer to use (with white space after "if", and "{}" over >>> the statement) (see section 7.4 of [1]). >>> >>> + if (localHost != null) { >>> + serverName = localHost; >>> + } >>> >>> 3. Not necessary, but I normally update the copy right date if it is >>> not >>> up-to-date. Still a very personal preference. >>> >>> Thanks, >>> Xuelei >>> >>> [1]: >>> http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-142311.html#449 >>> >>> >>> On 9/30/2013 9:27 PM, Artem wrote: >>>> Hello, >>>> >>>> please review this fix for 8: >>>> >>>> http://cr.openjdk.java.net/~kshefov/8025123/webrev.00/ >>>> >>>> https://bugs.openjdk.java.net/browse/JDK-8025123 >>>> >>>> SNI APIs were introduced in JDK 8, but TLS Kerberos client >>>> implementation does not take into account SNI host name when it >>>> requests >>>> TGS. >>>> >>>> For example, there are two HTTPS sites at the same machine: >>>> >>>> https_service_1.test.machine >>>> https_service_2.test.machine >>>> >>>> KDC contains records for both HTTPS services: >>>> >>>> host/https_service_1.test.machine at TEST.REALM >>>> host/https_service_2.test.machine at TEST.REALM >>>> >>>> Client wants to request 'https_service_1.test.machine' service, and it >>>> sets SNI host name 'https_service_1.test.machine' during handshaking. >>>> Currently TLS Kerberos client implementation requests TGS for >>>> 'host/test.machine at TEST.REALM' instead of >>>> 'host/https_service_1.test.machine at TEST.REALM' >>>> >>>> Changes: >>>> - ClientHandshaker uses SNI host name if it is specified. >>>> - If client gets server name extension in server hello then it is >>>> considered as SNI confirmation, so SNI hostname must be used to build >>>> Kerberos service principal name. If there is no SNI confirmation, >>>> client >>>> uses SNI first and then fallback to getHostSE(). >>>> - KerberosClientKeyExchangeImpl.getServiceTicket() method used to >>>> change >>>> a hostname for service principal if loopback address was used. But >>>> since >>>> we introduced SNI, using IP address to make the decision does not work >>>> any more. For compatibility reasons, the method checks that >>>> "localhost" >>>> or "localhost.localdomain" are passed (they are two known loopback >>>> hostname). If so, it still tries to get the local hostname. >>>> - Added a test case for test/sun/security/krb5/auto/SSL.java >>>> >>>> I have tested this with available reg/jck/sqe tests, no issues found. >>>> >>>> Artem >> -------------- next part -------------- An HTML attachment was scrubbed... URL: From paul.sandoz at oracle.com Tue Oct 1 10:36:47 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Tue, 01 Oct 2013 10:36:47 +0000 Subject: hg: jdk8/tl/jdk: 8024408: Specifications for Collection/List/Set/SortedSet.spliterator() need to document if all the (subclass) instances are required to return SIZED spliterators Message-ID: <20131001103710.3BE6762C36@hg.openjdk.java.net> Changeset: f8b3ab514564 Author: psandoz Date: 2013-10-01 12:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8b3ab514564 8024408: Specifications for Collection/List/Set/SortedSet.spliterator() need to document if all the (subclass) instances are required to return SIZED spliterators Reviewed-by: alanb ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Set.java ! src/share/classes/java/util/SortedSet.java ! test/java/util/Spliterator/SpliteratorCharacteristics.java From sundararajan.athijegannathan at oracle.com Tue Oct 1 12:14:30 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 01 Oct 2013 12:14:30 +0000 Subject: hg: jdk8/tl/nashorn: 8 new changesets Message-ID: <20131001121439.29E8762C3A@hg.openjdk.java.net> Changeset: 2016a6b9e1f3 Author: hannesw Date: 2013-09-27 16:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2016a6b9e1f3 8025515: Performance issues with Source.getLine() Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/ir/LexicalContext.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/Source.java + test/script/basic/JDK-8025515.js Changeset: 1809c9e97c71 Author: hannesw Date: 2013-09-27 17:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1809c9e97c71 8025520: Array.prototype.slice should only copy defined elements Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8025520.js Changeset: efc40aacaee4 Author: hannesw Date: 2013-09-30 15:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/efc40aacaee4 8025589: Array.prototype.shift should only copy defined elements in generic mode Reviewed-by: sundar, attila ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8025589.js Changeset: ad5f9ce2a95b Author: jlaskey Date: 2013-09-30 10:24 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ad5f9ce2a95b Merge Changeset: 787e36fdf69a Author: jlaskey Date: 2013-09-30 12:06 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/787e36fdf69a Merge Changeset: 7272ec90f2c6 Author: sundar Date: 2013-09-30 21:33 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7272ec90f2c6 8025629: load function should support a way to load scripts from classpath Reviewed-by: lagergren, hannesw, attila ! make/build.xml ! src/jdk/nashorn/internal/runtime/Context.java + test/script/trusted/JDK-8025629.js + test/src/jdk/nashorn/internal/runtime/resources/load_test.js Changeset: f5aefbe76cec Author: jlaskey Date: 2013-09-30 18:09 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f5aefbe76cec 8025689: fx:base.js classes not loading Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/resources/fx/base.js Changeset: cd7fb58043cb Author: sundar Date: 2013-10-01 14:38 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/cd7fb58043cb 8025488: Error.captureStackTrace should not format error stack Reviewed-by: hannesw, attila ! src/jdk/nashorn/internal/objects/NativeError.java + test/script/basic/JDK-8025488.js + test/script/basic/JDK-8025488.js.EXPECTED From alexander.zuev at oracle.com Tue Oct 1 13:04:14 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 01 Oct 2013 13:04:14 +0000 Subject: hg: jdk8/tl/langtools: 7118749: NPE in CreateSymbols caused by bad diagnostic Message-ID: <20131001130418.B759762C3C@hg.openjdk.java.net> Changeset: 1a3e8347f3dd Author: kizune Date: 2013-10-01 17:03 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1a3e8347f3dd 7118749: NPE in CreateSymbols caused by bad diagnostic Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java From dmitry.degrave at oracle.com Tue Oct 1 13:46:40 2013 From: dmitry.degrave at oracle.com (dmitry.degrave at oracle.com) Date: Tue, 01 Oct 2013 13:46:40 +0000 Subject: hg: jdk8/tl/jaxp: 8024707: TransformerException : item() return null with node list of length != 1 Message-ID: <20131001134642.F253262C3E@hg.openjdk.java.net> Changeset: 84a2b2ee6fc6 Author: aefimov Date: 2013-10-01 17:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/84a2b2ee6fc6 8024707: TransformerException : item() return null with node list of length != 1 Reviewed-by: joehw, lancea ! src/com/sun/org/apache/xml/internal/dtm/ref/DTMAxisIterNodeList.java From dmitry.degrave at oracle.com Tue Oct 1 13:47:11 2013 From: dmitry.degrave at oracle.com (dmitry.degrave at oracle.com) Date: Tue, 01 Oct 2013 13:47:11 +0000 Subject: hg: jdk8/tl/jdk: 8024707: TransformerException : item() return null with node list of length != 1 Message-ID: <20131001134724.E31CE62C3F@hg.openjdk.java.net> Changeset: bf52ea6bd9eb Author: aefimov Date: 2013-10-01 17:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf52ea6bd9eb 8024707: TransformerException : item() return null with node list of length != 1 Reviewed-by: joehw, lancea + test/javax/xml/jaxp/parsers/8024707/TestFunc.java + test/javax/xml/jaxp/parsers/8024707/XSLT.java + test/javax/xml/jaxp/parsers/8024707/in.xml + test/javax/xml/jaxp/parsers/8024707/test.xsl From xuelei.fan at oracle.com Tue Oct 1 15:02:56 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 01 Oct 2013 23:02:56 +0800 Subject: Code review request: 8025123: SNI support in Kerberos cipher suites In-Reply-To: <524A99A4.7020506@oracle.com> References: <52497C36.4020604@oracle.com> <524984D4.1000403@oracle.com> <52498B85.9090603@oracle.com> <5249908B.9090804@oracle.com> <524A99A4.7020506@oracle.com> Message-ID: <524AE420.9040400@oracle.com> Looks fine to me. Xuelei On 10/1/2013 5:45 PM, Artem wrote: > Hi Max, > > I updated the fix according to your comments: > > http://cr.openjdk.java.net/~kshefov/8025123/webrev.02/ > > > Artem > > On 09/30/2013 06:54 PM, Weijun Wang wrote: >> Now that we only check "localhost" and "localhost.localdomain", the >> following hack in the SSL.java test is not necessary any more: >> >> 92 // Run this after KDC, so our own DNS service can be started >> 93 try { >> 94 server = >> InetAddress.getLocalHost().getHostName().toLowerCase(); >> 95 } catch (java.net.UnknownHostException e) { >> 96 server = "localhost"; >> 97 } >> >> Just write >> >> server = "host." + OneKDC.REALM.toLowerCase(Locale.US); >> >> There is another coding style thing in >> KerberosClientKeyExchangeImpl.java: >> >> + if ("localhost".equals(serverName) || >> + "localhost.localdomain".equals(serverName)) { >> >> When a long time is broken to two, the second line should be indented >> twice the normal width, i.e. >> >> + if ("localhost".equals(serverName) || >> + "localhost.localdomain".equals(serverName)) { >> >> Everything nice is fine. >> >> Thanks >> Max >> >> On 9/30/13 10:32 PM, Artem wrote: >>> Updated webrev: http://cr.openjdk.java.net/~kshefov/8025123/webrev.01/ >>> >>> >>> - broke lines exceed 80 characters >>> - the code updated accrding to >>> http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-142311.html#449 >>> >>> - updated copy right dates >>> >>> Artem >>> >>> On 09/30/2013 06:04 PM, Xuelei Fan wrote: >>>> It's a good catch and wonderful fix. Thanks, Artem! >>>> >>>> The fix looks fine to me, except three very minor coding style >>>> comments. >>>> 1. we used to have only 80 characters in each line. >>>> I think there might some lines exceed 80 characters, would you mind >>>> break these lines to keep the style consistent? It is especially >>>> friendly to users like me that use vi terminal. >>>> >>>> 2. KerberosClientKeyExchangeImpl.java >>>> >>>> + if(localHost != null) serverName = localHost; >>>> >>>> Personally, I prefer to use (with white space after "if", and "{}" over >>>> the statement) (see section 7.4 of [1]). >>>> >>>> + if (localHost != null) { >>>> + serverName = localHost; >>>> + } >>>> >>>> 3. Not necessary, but I normally update the copy right date if it is >>>> not >>>> up-to-date. Still a very personal preference. >>>> >>>> Thanks, >>>> Xuelei >>>> >>>> [1]: >>>> http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-142311.html#449 >>>> >>>> >>>> On 9/30/2013 9:27 PM, Artem wrote: >>>>> Hello, >>>>> >>>>> please review this fix for 8: >>>>> >>>>> http://cr.openjdk.java.net/~kshefov/8025123/webrev.00/ >>>>> >>>>> https://bugs.openjdk.java.net/browse/JDK-8025123 >>>>> >>>>> SNI APIs were introduced in JDK 8, but TLS Kerberos client >>>>> implementation does not take into account SNI host name when it >>>>> requests >>>>> TGS. >>>>> >>>>> For example, there are two HTTPS sites at the same machine: >>>>> >>>>> https_service_1.test.machine >>>>> https_service_2.test.machine >>>>> >>>>> KDC contains records for both HTTPS services: >>>>> >>>>> host/https_service_1.test.machine at TEST.REALM >>>>> host/https_service_2.test.machine at TEST.REALM >>>>> >>>>> Client wants to request 'https_service_1.test.machine' service, and it >>>>> sets SNI host name 'https_service_1.test.machine' during handshaking. >>>>> Currently TLS Kerberos client implementation requests TGS for >>>>> 'host/test.machine at TEST.REALM' instead of >>>>> 'host/https_service_1.test.machine at TEST.REALM' >>>>> >>>>> Changes: >>>>> - ClientHandshaker uses SNI host name if it is specified. >>>>> - If client gets server name extension in server hello then it is >>>>> considered as SNI confirmation, so SNI hostname must be used to build >>>>> Kerberos service principal name. If there is no SNI confirmation, >>>>> client >>>>> uses SNI first and then fallback to getHostSE(). >>>>> - KerberosClientKeyExchangeImpl.getServiceTicket() method used to >>>>> change >>>>> a hostname for service principal if loopback address was used. But >>>>> since >>>>> we introduced SNI, using IP address to make the decision does not work >>>>> any more. For compatibility reasons, the method checks that >>>>> "localhost" >>>>> or "localhost.localdomain" are passed (they are two known loopback >>>>> hostname). If so, it still tries to get the local hostname. >>>>> - Added a test case for test/sun/security/krb5/auto/SSL.java >>>>> >>>>> I have tested this with available reg/jck/sqe tests, no issues found. >>>>> >>>>> Artem >>> > From mike.duigou at oracle.com Tue Oct 1 17:29:25 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 01 Oct 2013 17:29:25 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131001173020.8476462C5E@hg.openjdk.java.net> Changeset: 8cfb2bddd95e Author: mduigou Date: 2013-09-30 15:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8cfb2bddd95e 7057785: Add note about optional support of recursive methods for self-referential Collection/Map Reviewed-by: scolebourne, darcy, mduigou Contributed-by: Stephen Colebourne ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Map.java Changeset: f2e2326f787b Author: mduigou Date: 2013-10-01 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2e2326f787b 8025067: Unconditionally throw NPE if null op provided to Arrays.parallelPrefix Reviewed-by: henryjen, chegar, psandoz ! src/share/classes/java/util/Arrays.java ! test/java/util/Arrays/ParallelPrefix.java From mike.duigou at oracle.com Tue Oct 1 17:37:55 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Tue, 01 Oct 2013 17:37:55 +0000 Subject: hg: jdk8/tl/jdk: 8025686: Update jdk repo netbeans projects to support NetBeans 7.4 for Java 8 support Message-ID: <20131001173807.4DC8762C60@hg.openjdk.java.net> Changeset: c32ab940a183 Author: mduigou Date: 2013-10-01 10:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c32ab940a183 8025686: Update jdk repo netbeans projects to support NetBeans 7.4 for Java 8 support Reviewed-by: lancea, chegar ! make/netbeans/common/java-data-native.ent ! make/netbeans/common/java-data-no-native.ent From eric.mccorkle at oracle.com Tue Oct 1 21:27:00 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Tue, 01 Oct 2013 21:27:00 +0000 Subject: hg: jdk8/tl/jdk: 8024616: JSR292: lazily initialize core NamedFunctions used for bootstrapping Message-ID: <20131001212712.1AB2F62C75@hg.openjdk.java.net> Changeset: 1ed675532589 Author: vlivanov Date: 2013-09-18 20:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ed675532589 8024616: JSR292: lazily initialize core NamedFunctions used for bootstrapping Reviewed-by: jrose ! src/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java From eric.mccorkle at oracle.com Tue Oct 1 21:36:18 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Tue, 01 Oct 2013 21:36:18 +0000 Subject: hg: jdk8/tl/jdk: 8021398: j.l.r.Parameter.getAnnotatedType().getType() for not annotated use of type returns null Message-ID: <20131001213630.DA85162C78@hg.openjdk.java.net> Changeset: bf1118ab775b Author: emc Date: 2013-10-01 17:35 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf1118ab775b 8021398: j.l.r.Parameter.getAnnotatedType().getType() for not annotated use of type returns null Summary: Fixed issue with type annotation reflection framework that would cause getType of AnnotatedTypes to be null if no annotations were present. Reviewed-by: darcy, jfranck ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java + test/java/lang/reflect/Parameter/GetAnnotatedTypeTest.java From eric.mccorkle at oracle.com Tue Oct 1 21:43:01 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Tue, 01 Oct 2013 21:43:01 +0000 Subject: hg: jdk8/tl/langtools: 8021339: Compile-time error during casting array to intersection Message-ID: <20131001214305.099F362C79@hg.openjdk.java.net> Changeset: de1c5dbe6c28 Author: emc Date: 2013-10-01 17:41 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/de1c5dbe6c28 8021339: Compile-time error during casting array to intersection Summary: Add ability to have arrays in intersection types. Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/ArraysInIntersections.java + test/tools/javac/InferArraysInIntersections.java ! test/tools/javac/generics/typevars/6680106/T6680106.out From eric.mccorkle at oracle.com Tue Oct 1 21:24:14 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Tue, 01 Oct 2013 21:24:14 +0000 Subject: hg: jdk8/tl/jdk: 8001107: @Stable annotation for constant folding of lazily evaluated variables Message-ID: <20131001212426.B496562C73@hg.openjdk.java.net> Changeset: 5a7bd9825c01 Author: vlivanov Date: 2013-09-23 19:51 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5a7bd9825c01 8001107: @Stable annotation for constant folding of lazily evaluated variables Reviewed-by: twisti, kvn, rbackman Contributed-by: john.r.rose at oracle.com, vladimir.x.ivanov at oracle.com ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/invoke/MethodTypeForm.java + src/share/classes/java/lang/invoke/Stable.java From kumar.x.srinivasan at oracle.com Tue Oct 1 22:42:31 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Tue, 01 Oct 2013 22:42:31 +0000 Subject: hg: jdk8/tl/jdk: 8025342: NLS: unsupported translation format in jar/pack/DriverResource.java Message-ID: <20131001224245.5328862C7B@hg.openjdk.java.net> Changeset: 84e7f6685319 Author: ksrini Date: 2013-10-01 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84e7f6685319 8025342: NLS: unsupported translation format in jar/pack/DriverResource.java Reviewed-by: naoto, mfang ! src/share/classes/com/sun/java/util/jar/pack/Driver.java ! src/share/classes/com/sun/java/util/jar/pack/DriverResource.java From john.r.rose at oracle.com Wed Oct 2 02:23:45 2013 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Wed, 02 Oct 2013 02:23:45 +0000 Subject: hg: jdk8/tl/jdk: 8022701: Accessibility checking: InvocationTargetException is thrown instead of IllegalAccessError Message-ID: <20131002022421.327E062C86@hg.openjdk.java.net> Changeset: d90928a89af5 Author: drchase Date: 2013-09-27 13:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d90928a89af5 8022701: Accessibility checking: InvocationTargetException is thrown instead of IllegalAccessError Summary: Inserted code to convert specific exceptions, case-by-case, plus a test. Reviewed-by: jrose, twisti ! src/share/classes/java/lang/invoke/MethodHandleNatives.java + test/java/lang/invoke/8022701/BogoLoader.java + test/java/lang/invoke/8022701/InvokeSeveralWays.java + test/java/lang/invoke/8022701/Invoker.java + test/java/lang/invoke/8022701/MHIllegalAccess.java + test/java/lang/invoke/8022701/MethodSupplier.java From alan.bateman at oracle.com Wed Oct 2 03:27:06 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 02 Oct 2013 03:27:06 +0000 Subject: hg: jdk8/tl: 8006843: org.w3c.dom.events.UIEvent.getView is specified to return type that is not in the Java SE specification Message-ID: <20131002032706.AFBCC62C89@hg.openjdk.java.net> Changeset: 187a759c08ba Author: alanb Date: 2013-10-02 04:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/187a759c08ba 8006843: org.w3c.dom.events.UIEvent.getView is specified to return type that is not in the Java SE specification Reviewed-by: mduigou, tbell ! common/makefiles/javadoc/CORE_PKGS.gmk From xuelei.fan at oracle.com Wed Oct 2 03:26:43 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 02 Oct 2013 03:26:43 +0000 Subject: hg: jdk8/tl/jdk: 8025123: SNI support in Kerberos cipher suites Message-ID: <20131002032658.A714B62C88@hg.openjdk.java.net> Changeset: 3fca37c636be Author: xuelei Date: 2013-10-01 20:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fca37c636be 8025123: SNI support in Kerberos cipher suites Reviewed-by: weijun, xuelei Contributed-by: Artem Smotrakov ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java ! src/share/classes/sun/security/ssl/krb5/KerberosClientKeyExchangeImpl.java ! test/sun/security/krb5/auto/SSL.java From bradford.wetmore at oracle.com Wed Oct 2 04:28:31 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Tue, 01 Oct 2013 21:28:31 -0700 Subject: RFR: JDK-8014838: getStrongSecureRandom() should require at least one implementation In-Reply-To: <5244BD68.8040107@oracle.com> References: <5244BD68.8040107@oracle.com> Message-ID: <524BA0EF.5010204@oracle.com> During the internal CCC review, the CCC lead suggested a change to the method name to more closely follow the existing getInstance() methods, so I've changed the name from: java.security.SecureRandom.getStrongSecureRandom() to java.security.SecureRandom.getInstanceStrong() This particular change will be tracked via: 8025694: Rename getStrongSecureRandom based on feedback This will collate better (i.e. javadoc/NetBeans) than getStrongInstance(). It was also pointed out that the current strong Window MSCAPI-based implementation may not be available under the various profiles, so I've added a SHA1PRNG:SUN fallback in case the MSCAPI is not available. https://bugs.openjdk.java.net/browse/JDK-8014838 https://bugs.openjdk.java.net/browse/JDK-8025694 http://cr.openjdk.java.net/~wetmore/8025694/webrev.00 (contains both 8025694/8014838) Even though we are not currently building profiles on Windows currently, we could in the future, so the profiles team agrees this is a good compromise. Brad On 9/26/2013 4:04 PM, Bradford Wetmore wrote: > This minor suggestion came up in May from our JCK team: > > https://bugs.openjdk.java.net/browse/JDK-8014838 > > http://cr.openjdk.java.net/~wetmore/8014838/webrev.00/ > > JCK suggested all implementations should have at least one strong random > implementation. > > I've also changed the error case to throw NoSuchAlgorithmException > instead of returning null. > > CCC review is also underway concurrently, but I'm not expecting any issues. > > Brad From masayoshi.okutsu at oracle.com Wed Oct 2 06:32:25 2013 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Wed, 02 Oct 2013 06:32:25 +0000 Subject: hg: jdk8/tl/jdk: 6902861: (cal) GregorianCalendar roll WEEK_OF_YEAR is broken for January 1 2010 Message-ID: <20131002063239.AC93662C8C@hg.openjdk.java.net> Changeset: 914c29c10bce Author: okutsu Date: 2013-10-02 15:31 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/914c29c10bce 6902861: (cal) GregorianCalendar roll WEEK_OF_YEAR is broken for January 1 2010 Reviewed-by: peytoia ! src/share/classes/java/util/GregorianCalendar.java + test/java/util/Calendar/Bug6902861.java From sean.coffey at oracle.com Wed Oct 2 08:22:34 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Wed, 02 Oct 2013 08:22:34 +0000 Subject: hg: jdk8/tl/jdk: 8024952: ClassCastException in PlainSocketImpl.accept() when using custom socketImpl Message-ID: <20131002082305.2A14B62C96@hg.openjdk.java.net> Changeset: 368172cb6dc5 Author: coffeys Date: 2013-10-02 09:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/368172cb6dc5 8024952: ClassCastException in PlainSocketImpl.accept() when using custom socketImpl Reviewed-by: chegar ! src/windows/classes/java/net/PlainSocketImpl.java + test/java/net/PlainSocketImpl/CustomSocketImplFactory.java From masayoshi.okutsu at oracle.com Wed Oct 2 08:58:02 2013 From: masayoshi.okutsu at oracle.com (masayoshi.okutsu at oracle.com) Date: Wed, 02 Oct 2013 08:58:02 +0000 Subject: hg: jdk8/tl/jdk: 8022666: java.util.Calendar.set(int, int, int, int, int, int) documentation typo Message-ID: <20131002085900.D4ADF62C97@hg.openjdk.java.net> Changeset: 82e3150778e0 Author: okutsu Date: 2013-10-02 17:57 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82e3150778e0 8022666: java.util.Calendar.set(int,int,int,int,int,int) documentation typo Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java From paul.sandoz at oracle.com Wed Oct 2 12:25:58 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Wed, 02 Oct 2013 12:25:58 +0000 Subject: hg: jdk8/tl/jdk: 8025535: Unsafe typecast in java.util.stream.SortedOps Message-ID: <20131002122644.6D9B862C9D@hg.openjdk.java.net> Changeset: e1b04fd49204 Author: psandoz Date: 2013-10-01 18:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e1b04fd49204 8025535: Unsafe typecast in java.util.stream.SortedOps Reviewed-by: mduigou, chegar ! src/share/classes/java/util/stream/SortedOps.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java From sean.mullan at oracle.com Wed Oct 2 12:55:03 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 02 Oct 2013 08:55:03 -0400 Subject: RFR: JDK-8014838: getStrongSecureRandom() should require at least one implementation In-Reply-To: <524BA0EF.5010204@oracle.com> References: <5244BD68.8040107@oracle.com> <524BA0EF.5010204@oracle.com> Message-ID: <524C17A7.5020900@oracle.com> Looks good to me. --Sean On 10/02/2013 12:28 AM, Bradford Wetmore wrote: > During the internal CCC review, the CCC lead suggested a change to the > method name to more closely follow the existing getInstance() methods, > so I've changed the name from: > > java.security.SecureRandom.getStrongSecureRandom() > > to > > java.security.SecureRandom.getInstanceStrong() > > This particular change will be tracked via: > > 8025694: Rename getStrongSecureRandom based on feedback > > This will collate better (i.e. javadoc/NetBeans) than getStrongInstance(). > > It was also pointed out that the current strong Window MSCAPI-based > implementation may not be available under the various profiles, so I've > added a SHA1PRNG:SUN fallback in case the MSCAPI is not available. > > https://bugs.openjdk.java.net/browse/JDK-8014838 > https://bugs.openjdk.java.net/browse/JDK-8025694 > http://cr.openjdk.java.net/~wetmore/8025694/webrev.00 > (contains both 8025694/8014838) > > Even though we are not currently building profiles on Windows currently, > we could in the future, so the profiles team agrees this is a good > compromise. > > Brad > > > > > On 9/26/2013 4:04 PM, Bradford Wetmore wrote: >> This minor suggestion came up in May from our JCK team: >> >> https://bugs.openjdk.java.net/browse/JDK-8014838 >> >> http://cr.openjdk.java.net/~wetmore/8014838/webrev.00/ >> >> JCK suggested all implementations should have at least one strong random >> implementation. >> >> I've also changed the error case to throw NoSuchAlgorithmException >> instead of returning null. >> >> CCC review is also underway concurrently, but I'm not expecting any >> issues. >> >> Brad From staffan.larsen at oracle.com Wed Oct 2 12:37:32 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 02 Oct 2013 12:37:32 +0000 Subject: hg: jdk8/tl/jdk: 6696975: JTop plugin fails if connected readonly to target JVM Message-ID: <20131002123745.087CF62C9E@hg.openjdk.java.net> Changeset: 3bb89c509d59 Author: egahlin Date: 2013-10-01 17:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3bb89c509d59 6696975: JTop plugin fails if connected readonly to target JVM Reviewed-by: mchung, jbachorik, sla, sjiang ! src/share/demo/management/JTop/JTop.java From vicente.romero at oracle.com Wed Oct 2 16:06:03 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 02 Oct 2013 16:06:03 +0000 Subject: hg: jdk8/tl/langtools: 8023679: Improve error message for '_' used as a lambda parameter name Message-ID: <20131002160614.8D2F162CA7@hg.openjdk.java.net> Changeset: 1e6088da1740 Author: vromero Date: 2013-10-02 17:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e6088da1740 8023679: Improve error message for '_' used as a lambda parameter name Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/UnderscoreInLambdaExpression.java From martinrb at google.com Wed Oct 2 16:29:32 2013 From: martinrb at google.com (Martin Buchholz) Date: Wed, 2 Oct 2013 09:29:32 -0700 Subject: FutureTask.cancel(true) should run thread.interrupt within doPrivileged Message-ID: FutureTask.cancel(true) invokes thread.interrupt on the thread (if any) currently running the task. This should succeed even if modifyThread permission is denied by the security manager. Here's a proposed fix for jdk8+: --- src/main/java/util/concurrent/FutureTask.java 15 May 2013 02:39:59 -0000 1.103 +++ src/main/java/util/concurrent/FutureTask.java 2 Oct 2013 16:25:23 -0000 @@ -132,6 +132,12 @@ return state != NEW; } + private static void privilegedInterrupt(Thread t) { + java.security.PrivilegedAction doInterrupt = + () -> { t.interrupt(); return null; }; + java.security.AccessController.doPrivileged(doInterrupt); + } + public boolean cancel(boolean mayInterruptIfRunning) { if (!(state == NEW && UNSAFE.compareAndSwapInt(this, stateOffset, NEW, @@ -142,7 +148,11 @@ try { Thread t = runner; if (t != null) - t.interrupt(); + try { + t.interrupt(); + } catch (SecurityException e) { + privilegedInterrupt(t); + } } finally { // final state UNSAFE.putOrderedInt(this, stateOffset, INTERRUPTED); } -------------- next part -------------- An HTML attachment was scrubbed... URL: From bradford.wetmore at oracle.com Wed Oct 2 16:41:47 2013 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Wed, 02 Oct 2013 16:41:47 +0000 Subject: hg: jdk8/tl/jdk: 8025694: Rename getStrongSecureRandom based on feedback; ... Message-ID: <20131002164200.1A7E462CAB@hg.openjdk.java.net> Changeset: a6ac824b463d Author: wetmore Date: 2013-10-02 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a6ac824b463d 8025694: Rename getStrongSecureRandom based on feedback 8014838: getStrongSecureRandom() should require at least one implementation Reviewed-by: mullan, darcy ! src/share/classes/java/security/SecureRandom.java ! src/share/lib/security/java.security-windows ! test/sun/security/provider/SecureRandom/StrongSecureRandom.java From martinrb at google.com Wed Oct 2 16:54:30 2013 From: martinrb at google.com (Martin Buchholz) Date: Wed, 2 Oct 2013 09:54:30 -0700 Subject: FutureTask.cancel(true) should run thread.interrupt within doPrivileged In-Reply-To: <524C4E9B.5080602@gmail.com> References: <524C4E9B.5080602@gmail.com> Message-ID: On Wed, Oct 2, 2013 at 9:49 AM, Peter Levart wrote: > Hi Martin, > > If you want to optimize for without-security-manager case I want to optimize for the case that Thread.interrupt does not throw SecurityException -------------- next part -------------- An HTML attachment was scrubbed... URL: From peter.levart at gmail.com Wed Oct 2 16:49:31 2013 From: peter.levart at gmail.com (Peter Levart) Date: Wed, 02 Oct 2013 18:49:31 +0200 Subject: FutureTask.cancel(true) should run thread.interrupt within doPrivileged In-Reply-To: References: Message-ID: <524C4E9B.5080602@gmail.com> Hi Martin, If you want to optimize for without-security-manager case, then it would be better this way: private static void privilegedInterrupt(Thread t) { if (System.getSecurityManager() == null) { t.interrupt(); } else { PrivilegedAction doInterrupt = () -> { t.interrupt(); return null; }; AccessController.doPrivileged(doInterrupt); } } ...and no security exception catching. This way you don't trigger double security checks for case with-security-manager and not enough permission... Regards, Peter On 10/02/2013 06:29 PM, Martin Buchholz wrote: > FutureTask.cancel(true) invokes thread.interrupt on the thread (if any) > currently running the task. > This should succeed even if modifyThread permission is denied by the > security manager. > > Here's a proposed fix for jdk8+: > > --- src/main/java/util/concurrent/FutureTask.java 15 May 2013 02:39:59 -0000 > 1.103 > +++ src/main/java/util/concurrent/FutureTask.java 2 Oct 2013 16:25:23 -0000 > @@ -132,6 +132,12 @@ > return state != NEW; > } > > + private static void privilegedInterrupt(Thread t) { > + java.security.PrivilegedAction doInterrupt = > + () -> { t.interrupt(); return null; }; > + java.security.AccessController.doPrivileged(doInterrupt); > + } > + > public boolean cancel(boolean mayInterruptIfRunning) { > if (!(state == NEW && > UNSAFE.compareAndSwapInt(this, stateOffset, NEW, > @@ -142,7 +148,11 @@ > try { > Thread t = runner; > if (t != null) > - t.interrupt(); > + try { > + t.interrupt(); > + } catch (SecurityException e) { > + privilegedInterrupt(t); > + } > } finally { // final state > UNSAFE.putOrderedInt(this, stateOffset, INTERRUPTED); > } From dl at cs.oswego.edu Wed Oct 2 17:02:45 2013 From: dl at cs.oswego.edu (Doug Lea) Date: Wed, 02 Oct 2013 13:02:45 -0400 Subject: [concurrency-interest] FutureTask.cancel(true) should run thread.interrupt within doPrivileged In-Reply-To: References: Message-ID: <524C51B5.3040905@cs.oswego.edu> On 10/02/2013 12:29 PM, Martin Buchholz wrote: > FutureTask.cancel(true) invokes thread.interrupt on the thread (if any) > currently running the task. > This should succeed even if modifyThread permission is denied by the security > manager. > We haven't interpreted "should" in this way in the past here or in related contexts, but I don't see are reason not to, pending any objections by security folks. -Doug > Here's a proposed fix for jdk8+: > > --- src/main/java/util/concurrent/FutureTask.java15 May 2013 02:39:59 -00001.103 > +++ src/main/java/util/concurrent/FutureTask.java2 Oct 2013 16:25:23 -0000 > @@ -132,6 +132,12 @@ > return state != NEW; > } > + private static void privilegedInterrupt(Thread t) { > + java.security.PrivilegedAction doInterrupt = > + () -> { t.interrupt(); return null; }; > + java.security.AccessController.doPrivileged(doInterrupt); > + } > + > public boolean cancel(boolean mayInterruptIfRunning) { > if (!(state == NEW && > UNSAFE.compareAndSwapInt(this, stateOffset, NEW, > @@ -142,7 +148,11 @@ > try { > Thread t = runner; > if (t != null) > - t.interrupt(); > + try { > + t.interrupt(); > + } catch (SecurityException e) { > + privilegedInterrupt(t); > + } > } finally { // final state > UNSAFE.putOrderedInt(this, stateOffset, INTERRUPTED); > } > > > > _______________________________________________ > Concurrency-interest mailing list > Concurrency-interest at cs.oswego.edu > http://cs.oswego.edu/mailman/listinfo/concurrency-interest > From eric.mccorkle at oracle.com Wed Oct 2 23:14:18 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Wed, 02 Oct 2013 23:14:18 +0000 Subject: hg: jdk8/tl/jdk: 8020981: Update methods of java.lang.reflect.Parameter to throw correct exceptions Message-ID: <20131002231431.6950C62CC5@hg.openjdk.java.net> Changeset: cb8946eda85b Author: emc Date: 2013-10-02 19:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb8946eda85b 8020981: Update methods of java.lang.reflect.Parameter to throw correct exceptions Summary: Fix behavior of parameter reflection API for malformed class files. Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Executable.java + src/share/classes/java/lang/reflect/MalformedParametersException.java ! src/share/classes/java/lang/reflect/Parameter.java + test/java/lang/reflect/Parameter/BadClassFiles.java From david.holmes at oracle.com Thu Oct 3 02:06:23 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 03 Oct 2013 12:06:23 +1000 Subject: [concurrency-interest] FutureTask.cancel(true) should run thread.interrupt within doPrivileged In-Reply-To: <524C51B5.3040905@cs.oswego.edu> References: <524C51B5.3040905@cs.oswego.edu> Message-ID: <524CD11F.7070200@oracle.com> On 3/10/2013 3:02 AM, Doug Lea wrote: > On 10/02/2013 12:29 PM, Martin Buchholz wrote: >> FutureTask.cancel(true) invokes thread.interrupt on the thread (if any) >> currently running the task. >> This should succeed even if modifyThread permission is denied by the >> security >> manager. >> > > We haven't interpreted "should" in this way in the past here or in > related contexts, but I don't see are reason not to, pending any > objections by security folks. We have been tightening the conditions under which interrupts can be issued, so relaxing them in this way is simply not acceptable. David ----- > -Doug > > >> Here's a proposed fix for jdk8+: >> >> --- src/main/java/util/concurrent/FutureTask.java15 May 2013 02:39:59 >> -00001.103 >> +++ src/main/java/util/concurrent/FutureTask.java2 Oct 2013 16:25:23 >> -0000 >> @@ -132,6 +132,12 @@ >> return state != NEW; >> } >> + private static void privilegedInterrupt(Thread t) { >> + java.security.PrivilegedAction doInterrupt = >> + () -> { t.interrupt(); return null; }; >> + java.security.AccessController.doPrivileged(doInterrupt); >> + } >> + >> public boolean cancel(boolean mayInterruptIfRunning) { >> if (!(state == NEW && >> UNSAFE.compareAndSwapInt(this, stateOffset, NEW, >> @@ -142,7 +148,11 @@ >> try { >> Thread t = runner; >> if (t != null) >> - t.interrupt(); >> + try { >> + t.interrupt(); >> + } catch (SecurityException e) { >> + privilegedInterrupt(t); >> + } >> } finally { // final state >> UNSAFE.putOrderedInt(this, stateOffset, >> INTERRUPTED); >> } >> >> >> >> _______________________________________________ >> Concurrency-interest mailing list >> Concurrency-interest at cs.oswego.edu >> http://cs.oswego.edu/mailman/listinfo/concurrency-interest >> > From david.holmes at oracle.com Thu Oct 3 02:13:30 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 03 Oct 2013 12:13:30 +1000 Subject: FutureTask.cancel(true) should run thread.interrupt within doPrivileged In-Reply-To: References: <524C4E9B.5080602@gmail.com> Message-ID: <524CD2CA.2070901@oracle.com> On 3/10/2013 2:54 AM, Martin Buchholz wrote: > On Wed, Oct 2, 2013 at 9:49 AM, Peter Levart wrote: > >> Hi Martin, >> >> If you want to optimize for without-security-manager case > > > I want to optimize for the case that Thread.interrupt does not throw > SecurityException How is your proposal optimizing that case ??? David From martinrb at google.com Thu Oct 3 03:55:00 2013 From: martinrb at google.com (Martin Buchholz) Date: Wed, 2 Oct 2013 20:55:00 -0700 Subject: FutureTask.cancel(true) should run thread.interrupt within doPrivileged In-Reply-To: <524CD2CA.2070901@oracle.com> References: <524C4E9B.5080602@gmail.com> <524CD2CA.2070901@oracle.com> Message-ID: On Wed, Oct 2, 2013 at 7:13 PM, David Holmes wrote: > On 3/10/2013 2:54 AM, Martin Buchholz wrote: > >> On Wed, Oct 2, 2013 at 9:49 AM, Peter Levart >> wrote: >> >> Hi Martin, >>> >>> If you want to optimize for without-security-manager case >>> >> >> >> I want to optimize for the case that Thread.interrupt does not throw >> SecurityException >> > > How is your proposal optimizing that case ??? Instead of doing extra work to avoid a SecurityException, I am assuming a SecurityException is rare, and risk having to throw it twice. -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.holmes at oracle.com Thu Oct 3 04:03:31 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 03 Oct 2013 14:03:31 +1000 Subject: FutureTask.cancel(true) should run thread.interrupt within doPrivileged In-Reply-To: References: <524C4E9B.5080602@gmail.com> <524CD2CA.2070901@oracle.com> Message-ID: <524CEC93.20106@oracle.com> On 3/10/2013 1:55 PM, Martin Buchholz wrote: > On Wed, Oct 2, 2013 at 7:13 PM, David Holmes wrote: > >> On 3/10/2013 2:54 AM, Martin Buchholz wrote: >> >>> On Wed, Oct 2, 2013 at 9:49 AM, Peter Levart >>> wrote: >>> >>> Hi Martin, >>>> >>>> If you want to optimize for without-security-manager case >>>> >>> >>> >>> I want to optimize for the case that Thread.interrupt does not throw >>> SecurityException >>> >> >> How is your proposal optimizing that case ??? > > > Instead of doing extra work to avoid a SecurityException, I am assuming a > SecurityException is rare, and risk having to throw it twice. Sorry I'm missing something - what extra work are you avoiding and where? The original code just did t.interrupt() now you've added try/catch with a second privileged interrupt attempt. I don't see anything being avoided. Are you referring to caller code that catches the SecurityException itself and somehow retries? David From martinrb at google.com Thu Oct 3 04:11:01 2013 From: martinrb at google.com (Martin Buchholz) Date: Wed, 2 Oct 2013 21:11:01 -0700 Subject: FutureTask.cancel(true) should run thread.interrupt within doPrivileged In-Reply-To: <524CEC93.20106@oracle.com> References: <524C4E9B.5080602@gmail.com> <524CD2CA.2070901@oracle.com> <524CEC93.20106@oracle.com> Message-ID: I was responding to Peter Levart's suggestion of checking for the presence of a security manager before calling doPrivileged. Which is not an important question now, given that the primary question is whether we should allow future.cancel() to interrupt within a doPrivileged. Alternatively, is there a reasonable way for a security manager to enable such usages without enabling arbitrary modifyThread? On Wed, Oct 2, 2013 at 9:03 PM, David Holmes wrote: > On 3/10/2013 1:55 PM, Martin Buchholz wrote: > >> On Wed, Oct 2, 2013 at 7:13 PM, David Holmes ** >> wrote: >> >> On 3/10/2013 2:54 AM, Martin Buchholz wrote: >>> >>> On Wed, Oct 2, 2013 at 9:49 AM, Peter Levart >>>> wrote: >>>> >>>> Hi Martin, >>>> >>>>> >>>>> If you want to optimize for without-security-manager case >>>>> >>>>> >>>> >>>> I want to optimize for the case that Thread.interrupt does not throw >>>> SecurityException >>>> >>>> >>> How is your proposal optimizing that case ??? >>> >> >> >> Instead of doing extra work to avoid a SecurityException, I am assuming a >> SecurityException is rare, and risk having to throw it twice. >> > > Sorry I'm missing something - what extra work are you avoiding and where? > The original code just did t.interrupt() now you've added try/catch with a > second privileged interrupt attempt. I don't see anything being avoided. > Are you referring to caller code that catches the SecurityException itself > and somehow retries? > > David > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.holmes at oracle.com Thu Oct 3 05:12:43 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 03 Oct 2013 15:12:43 +1000 Subject: FutureTask.cancel(true) should run thread.interrupt within doPrivileged In-Reply-To: References: <524C4E9B.5080602@gmail.com> <524CD2CA.2070901@oracle.com> <524CEC93.20106@oracle.com> Message-ID: <524CFCCB.2060000@oracle.com> On 3/10/2013 2:11 PM, Martin Buchholz wrote: > I was responding to Peter Levart's suggestion of checking for the presence > of a security manager before calling doPrivileged. Which is not an > important question now, given that the primary question is whether we > should allow future.cancel() to interrupt within a doPrivileged. Ah I see. > Alternatively, is there a reasonable way for a security manager to enable > such usages without enabling arbitrary modifyThread? I'm not quite sure what you are asking. Thread permissions are notoriously coarse-grained. I thought that was a big mistake when the security architecture was updated in 1.2 (?) but here we are a decade (or more) later and it seems noone really complained. So be it. Hypothetically we could define finer-grained permissions to differ interrupt from nasty things like stop/suspend. But in practice unless we change how we assign that permission then you would still require it and wouldn't have it unless using a custom security policy - which would allow you to deal with the modifyThread permission too. David ----- > > On Wed, Oct 2, 2013 at 9:03 PM, David Holmes wrote: > >> On 3/10/2013 1:55 PM, Martin Buchholz wrote: >> >>> On Wed, Oct 2, 2013 at 7:13 PM, David Holmes ** >>> wrote: >>> >>> On 3/10/2013 2:54 AM, Martin Buchholz wrote: >>>> >>>> On Wed, Oct 2, 2013 at 9:49 AM, Peter Levart >>>>> wrote: >>>>> >>>>> Hi Martin, >>>>> >>>>>> >>>>>> If you want to optimize for without-security-manager case >>>>>> >>>>>> >>>>> >>>>> I want to optimize for the case that Thread.interrupt does not throw >>>>> SecurityException >>>>> >>>>> >>>> How is your proposal optimizing that case ??? >>>> >>> >>> >>> Instead of doing extra work to avoid a SecurityException, I am assuming a >>> SecurityException is rare, and risk having to throw it twice. >>> >> >> Sorry I'm missing something - what extra work are you avoiding and where? >> The original code just did t.interrupt() now you've added try/catch with a >> second privileged interrupt attempt. I don't see anything being avoided. >> Are you referring to caller code that catches the SecurityException itself >> and somehow retries? >> >> David >> >> From paul.sandoz at oracle.com Thu Oct 3 10:12:22 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Thu, 03 Oct 2013 10:12:22 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131003101314.93FAA62CE2@hg.openjdk.java.net> Changeset: 811c35a6a58f Author: psandoz Date: 2013-10-02 16:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/811c35a6a58f 8025534: Unsafe typecast in java.util.stream.Streams.Nodes 8025538: Unsafe typecast in java.util.stream.SpinedBuffer 8025533: Unsafe typecast in java.util.stream.Streams.RangeIntSpliterator.splitPoint() 8025525: Unsafe typecast in java.util.stream.Node.OfPrimitive.asArray() Reviewed-by: chegar ! src/share/classes/java/util/stream/Node.java ! src/share/classes/java/util/stream/Nodes.java ! src/share/classes/java/util/stream/SortedOps.java ! src/share/classes/java/util/stream/SpinedBuffer.java ! src/share/classes/java/util/stream/Streams.java Changeset: c55a7941050c Author: psandoz Date: 2013-10-03 10:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c55a7941050c 8025567: Mark relevant public stream tests as serialization hostile Reviewed-by: alanb ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ForEachOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamBuilderTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ToArrayOpTest.java From dmitry.samersoff at oracle.com Thu Oct 3 12:55:27 2013 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Thu, 03 Oct 2013 12:55:27 +0000 Subject: hg: jdk8/tl/jdk: 8009213: sun/management/jdp/JdpTest.sh fails with exit code 1 Message-ID: <20131003125539.805AB62CEC@hg.openjdk.java.net> Changeset: 5d6dc0cba08f Author: dsamersoff Date: 2013-10-03 16:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d6dc0cba08f 8009213: sun/management/jdp/JdpTest.sh fails with exit code 1 Summary: There's no guarantee that the java process has executed far enough to be found by jps when we try to obtain it's pid. Reviewed-by: sla ! test/sun/management/jdp/JdpTest.sh From alexander.zuev at oracle.com Thu Oct 3 13:41:00 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Thu, 03 Oct 2013 13:41:00 +0000 Subject: hg: jdk8/tl/jdk: 8025738: locale related test fails on langtools mac 10.7 test host Message-ID: <20131003134121.D9BFE62CEE@hg.openjdk.java.net> Changeset: 9c32a9490eac Author: kizune Date: 2013-10-03 17:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c32a9490eac 8025738: locale related test fails on langtools mac 10.7 test host Reviewed-by: ksrini ! test/tools/launcher/DiacriticTest.java From vincent.x.ryan at oracle.com Thu Oct 3 13:57:22 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 3 Oct 2013 14:57:22 +0100 Subject: [8] Request for review: 8008296: keytool utility doesn't support '-importpassword' command In-Reply-To: <523A3C77.9020209@oracle.com> References: <6A8C2502-42E0-4A35-80E1-A07AE7E66425@oracle.com> <523A3C77.9020209@oracle.com> Message-ID: <77720D87-6F20-4F8B-A414-3EFAED4972DC@oracle.com> Thanks for the comments - I'm just returning to this following JavaOne. I've updated the Help messages to add a separate section for '-importpass' and I've reverted the prompt to its previous value: 'Enter the password to be stored'. Let me know if there are any other issues. Otherwise I'd like to push this today. On 19 Sep 2013, at 00:51, Weijun Wang wrote: > Hi Vinnie > > Mostly good, but do you need to add a help line for it? You reuse the GENSECKEY command so "keytool -importpass -help" looks strange. > > Also, the command name is -importpassword but the prompt is "Enter the passphrase to be stored". Feel a little uncomfortable. > > Thanks > Max > > > On 9/14/13 2:25 AM, Vincent Ryan wrote: >> >> Please review the following fix that adds support to the keytool utility for storing arbitrary user passwords >> in a keystore. For keystores such as PKCS#12 that support a variety of key protection algorithms, >> the PBE algorithm may also be specified by overloading the existing -keyalg flag. For example, >> >> % keytool -importpassword -storetype PKCS12 -keyalg PBEWithHmacSHA1AndAES_128 ... >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008296 >> Webrev: http://cr.openjdk.java.net/~vinnie/8008296/webrev.00/ >> >> Thanks. >> >> From weijun.wang at oracle.com Thu Oct 3 14:08:16 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 03 Oct 2013 22:08:16 +0800 Subject: [8] Request for review: 8008296: keytool utility doesn't support '-importpassword' command In-Reply-To: <77720D87-6F20-4F8B-A414-3EFAED4972DC@oracle.com> References: <6A8C2502-42E0-4A35-80E1-A07AE7E66425@oracle.com> <523A3C77.9020209@oracle.com> <77720D87-6F20-4F8B-A414-3EFAED4972DC@oracle.com> Message-ID: <524D7A50.1060202@oracle.com> I don't have other issues. Have you updated the webrev? I see no change. --Max On 10/3/13 9:57 PM, Vincent Ryan wrote: > Thanks for the comments - I'm just returning to this following JavaOne. > > I've updated the Help messages to add a separate section for '-importpass' and > I've reverted the prompt to its previous value: 'Enter the password to be stored'. > > Let me know if there are any other issues. Otherwise I'd like to push this today. > > > On 19 Sep 2013, at 00:51, Weijun Wang wrote: > >> Hi Vinnie >> >> Mostly good, but do you need to add a help line for it? You reuse the GENSECKEY command so "keytool -importpass -help" looks strange. >> >> Also, the command name is -importpassword but the prompt is "Enter the passphrase to be stored". Feel a little uncomfortable. >> >> Thanks >> Max >> >> >> On 9/14/13 2:25 AM, Vincent Ryan wrote: >>> >>> Please review the following fix that adds support to the keytool utility for storing arbitrary user passwords >>> in a keystore. For keystores such as PKCS#12 that support a variety of key protection algorithms, >>> the PBE algorithm may also be specified by overloading the existing -keyalg flag. For example, >>> >>> % keytool -importpassword -storetype PKCS12 -keyalg PBEWithHmacSHA1AndAES_128 ... >>> >>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008296 >>> Webrev: http://cr.openjdk.java.net/~vinnie/8008296/webrev.00/ >>> >>> Thanks. >>> >>> > From vincent.x.ryan at oracle.com Thu Oct 3 15:26:48 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 3 Oct 2013 16:26:48 +0100 Subject: [8] Request for review: 8008296: keytool utility doesn't support '-importpassword' command In-Reply-To: <524D7A50.1060202@oracle.com> References: <6A8C2502-42E0-4A35-80E1-A07AE7E66425@oracle.com> <523A3C77.9020209@oracle.com> <77720D87-6F20-4F8B-A414-3EFAED4972DC@oracle.com> <524D7A50.1060202@oracle.com> Message-ID: <5631006A-E3F1-487E-BCA6-AC214ACB29B7@oracle.com> Sorry. I've just refreshed it now: http://cr.openjdk.java.net/~vinnie/8008296/webrev.00 On 3 Oct 2013, at 15:08, Weijun Wang wrote: > I don't have other issues. Have you updated the webrev? I see no change. > > --Max > > On 10/3/13 9:57 PM, Vincent Ryan wrote: >> Thanks for the comments - I'm just returning to this following JavaOne. >> >> I've updated the Help messages to add a separate section for '-importpass' and >> I've reverted the prompt to its previous value: 'Enter the password to be stored'. >> >> Let me know if there are any other issues. Otherwise I'd like to push this today. >> >> >> On 19 Sep 2013, at 00:51, Weijun Wang wrote: >> >>> Hi Vinnie >>> >>> Mostly good, but do you need to add a help line for it? You reuse the GENSECKEY command so "keytool -importpass -help" looks strange. >>> >>> Also, the command name is -importpassword but the prompt is "Enter the passphrase to be stored". Feel a little uncomfortable. >>> >>> Thanks >>> Max >>> >>> >>> On 9/14/13 2:25 AM, Vincent Ryan wrote: >>>> >>>> Please review the following fix that adds support to the keytool utility for storing arbitrary user passwords >>>> in a keystore. For keystores such as PKCS#12 that support a variety of key protection algorithms, >>>> the PBE algorithm may also be specified by overloading the existing -keyalg flag. For example, >>>> >>>> % keytool -importpassword -storetype PKCS12 -keyalg PBEWithHmacSHA1AndAES_128 ... >>>> >>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008296 >>>> Webrev: http://cr.openjdk.java.net/~vinnie/8008296/webrev.00/ >>>> >>>> Thanks. >>>> >>>> >> From robert.field at oracle.com Thu Oct 3 17:24:42 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Thu, 03 Oct 2013 17:24:42 +0000 Subject: hg: jdk8/tl/jdk: 8010433: Remove lambda metafactory work-around to JDK-8005119 Message-ID: <20131003172512.E48F462D0B@hg.openjdk.java.net> Changeset: 8d8b809dd294 Author: rfield Date: 2013-10-03 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d8b809dd294 8010433: Remove lambda metafactory work-around to JDK-8005119 Summary: Restore invokespecial to lambda metafactory Reviewed-by: ksrini ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java From robert.field at oracle.com Thu Oct 3 18:27:36 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Thu, 03 Oct 2013 18:27:36 +0000 Subject: hg: jdk8/tl/jdk: 8020849: jdk/lambda/vm/DefaultMethodsTest.java Message-ID: <20131003182839.8556662D1C@hg.openjdk.java.net> Changeset: 1b3616c4a836 Author: rfield Date: 2013-10-03 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b3616c4a836 8020849: jdk/lambda/vm/DefaultMethodsTest.java Summary: Bridge generation has been removed from the VM. Fix is to remove tests that no longer make sense. Reviewed-by: ksrini ! test/jdk/lambda/vm/DefaultMethodsTest.java From roger.riggs at oracle.com Thu Oct 3 20:20:21 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Thu, 03 Oct 2013 20:20:21 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131003202235.747C262D32@hg.openjdk.java.net> Changeset: 01b8604e8268 Author: rriggs Date: 2013-08-22 10:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01b8604e8268 8024896: Refactor java.time serialization tests into separate subpackage Summary: Move serialization tests to .serial subpackage Reviewed-by: sherman Contributed-by: paul.rank at oracle.com ! test/java/time/tck/java/time/TCKDuration.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKPeriod.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneId.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/chrono/TCKChronoLocalDate.java ! test/java/time/tck/java/time/chrono/TCKChronoLocalDateTime.java - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java + test/java/time/tck/java/time/chrono/serial/TCKChronoLocalDate.java + test/java/time/tck/java/time/chrono/serial/TCKChronoLocalDateTime.java + test/java/time/tck/java/time/chrono/serial/TCKChronologySerialization.java + test/java/time/tck/java/time/serial/TCKDuration.java + test/java/time/tck/java/time/serial/TCKInstant.java + test/java/time/tck/java/time/serial/TCKLocalDate.java + test/java/time/tck/java/time/serial/TCKLocalDateTime.java + test/java/time/tck/java/time/serial/TCKLocalTime.java + test/java/time/tck/java/time/serial/TCKMonthDay.java + test/java/time/tck/java/time/serial/TCKOffsetDateTime.java + test/java/time/tck/java/time/serial/TCKOffsetTime.java + test/java/time/tck/java/time/serial/TCKPeriod.java + test/java/time/tck/java/time/serial/TCKYear.java + test/java/time/tck/java/time/serial/TCKYearMonth.java + test/java/time/tck/java/time/serial/TCKZoneId.java + test/java/time/tck/java/time/serial/TCKZoneOffset.java + test/java/time/tck/java/time/serial/TCKZonedDateTime.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java + test/java/time/tck/java/time/temporal/serial/TCKWeekFields.java ! test/java/time/tck/java/time/zone/TCKFixedZoneRules.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java ! test/java/time/tck/java/time/zone/TCKZoneRules.java + test/java/time/tck/java/time/zone/serial/TCKFixedZoneRules.java + test/java/time/tck/java/time/zone/serial/TCKZoneOffsetTransition.java + test/java/time/tck/java/time/zone/serial/TCKZoneOffsetTransitionRule.java + test/java/time/tck/java/time/zone/serial/TCKZoneRules.java Changeset: e813b58bd6db Author: rriggs Date: 2013-10-03 15:16 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e813b58bd6db 8024427: Missing java.time.chrono serialization tests Summary: Add tests and cleanup existing serialization tests Reviewed-by: sherman ! src/share/classes/java/time/temporal/ValueRange.java ! test/java/time/tck/java/time/AbstractTCKTest.java ! test/java/time/tck/java/time/TCKClock_Fixed.java ! test/java/time/tck/java/time/TCKClock_Offset.java ! test/java/time/tck/java/time/TCKClock_System.java ! test/java/time/tck/java/time/TCKClock_Tick.java ! test/java/time/tck/java/time/chrono/CopticDate.java ! test/java/time/tck/java/time/chrono/TCKChronoZonedDateTime.java ! test/java/time/tck/java/time/chrono/TCKChronology.java ! test/java/time/tck/java/time/chrono/TCKTestServiceLoader.java ! test/java/time/tck/java/time/chrono/serial/TCKChronoLocalDateSerialization.java < test/java/time/tck/java/time/chrono/serial/TCKChronoLocalDate.java ! test/java/time/tck/java/time/chrono/serial/TCKChronoLocalDateTimeSerialization.java < test/java/time/tck/java/time/chrono/serial/TCKChronoLocalDateTime.java + test/java/time/tck/java/time/chrono/serial/TCKChronoZonedDateTimeSerialization.java ! test/java/time/tck/java/time/chrono/serial/TCKChronologySerialization.java + test/java/time/tck/java/time/chrono/serial/TCKCopticSerialization.java + test/java/time/tck/java/time/chrono/serial/TCKEraSerialization.java + test/java/time/tck/java/time/serial/TCKClockSerialization.java ! test/java/time/tck/java/time/serial/TCKDurationSerialization.java < test/java/time/tck/java/time/serial/TCKDuration.java ! test/java/time/tck/java/time/serial/TCKInstantSerialization.java < test/java/time/tck/java/time/serial/TCKInstant.java ! test/java/time/tck/java/time/serial/TCKLocalDateSerialization.java < test/java/time/tck/java/time/serial/TCKLocalDate.java ! test/java/time/tck/java/time/serial/TCKLocalDateTimeSerialization.java < test/java/time/tck/java/time/serial/TCKLocalDateTime.java ! test/java/time/tck/java/time/serial/TCKLocalTimeSerialization.java < test/java/time/tck/java/time/serial/TCKLocalTime.java ! test/java/time/tck/java/time/serial/TCKMonthDaySerialization.java < test/java/time/tck/java/time/serial/TCKMonthDay.java ! test/java/time/tck/java/time/serial/TCKOffsetDateTimeSerialization.java < test/java/time/tck/java/time/serial/TCKOffsetDateTime.java ! test/java/time/tck/java/time/serial/TCKOffsetTimeSerialization.java < test/java/time/tck/java/time/serial/TCKOffsetTime.java ! test/java/time/tck/java/time/serial/TCKPeriodSerialization.java < test/java/time/tck/java/time/serial/TCKPeriod.java ! test/java/time/tck/java/time/serial/TCKYearMonthSerialization.java < test/java/time/tck/java/time/serial/TCKYearMonth.java ! test/java/time/tck/java/time/serial/TCKYearSerialization.java < test/java/time/tck/java/time/serial/TCKYear.java ! test/java/time/tck/java/time/serial/TCKZoneIdSerialization.java < test/java/time/tck/java/time/serial/TCKZoneId.java ! test/java/time/tck/java/time/serial/TCKZoneOffsetSerialization.java < test/java/time/tck/java/time/serial/TCKZoneOffset.java ! test/java/time/tck/java/time/serial/TCKZonedDateTimeSerialization.java < test/java/time/tck/java/time/serial/TCKZonedDateTime.java ! test/java/time/tck/java/time/temporal/TCKJulianFields.java + test/java/time/tck/java/time/temporal/serial/TCKChronoFieldSerialization.java + test/java/time/tck/java/time/temporal/serial/TCKChronoUnitSerialization.java + test/java/time/tck/java/time/temporal/serial/TCKJulianFieldsSerialization.java + test/java/time/tck/java/time/temporal/serial/TCKValueRangeSerialization.java ! test/java/time/tck/java/time/temporal/serial/TCKWeekFieldsSerialization.java < test/java/time/tck/java/time/temporal/serial/TCKWeekFields.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java ! test/java/time/tck/java/time/zone/serial/TCKFixedZoneRulesSerialization.java < test/java/time/tck/java/time/zone/serial/TCKFixedZoneRules.java ! test/java/time/tck/java/time/zone/serial/TCKZoneOffsetTransitionRuleSerialization.java < test/java/time/tck/java/time/zone/serial/TCKZoneOffsetTransitionRule.java ! test/java/time/tck/java/time/zone/serial/TCKZoneOffsetTransitionSerialization.java < test/java/time/tck/java/time/zone/serial/TCKZoneOffsetTransition.java ! test/java/time/tck/java/time/zone/serial/TCKZoneRulesSerialization.java < test/java/time/tck/java/time/zone/serial/TCKZoneRules.java ! test/java/time/test/java/time/AbstractTest.java ! test/java/time/test/java/time/TestDuration.java ! test/java/time/test/java/time/temporal/TestDateTimeValueRange.java From viktor.klang at gmail.com Wed Oct 2 20:40:56 2013 From: viktor.klang at gmail.com (=?UTF-8?B?4oiaaWt0b3Ig0qBsYW5n?=) Date: Wed, 2 Oct 2013 22:40:56 +0200 Subject: [concurrency-interest] FutureTask.cancel(true) should run thread.interrupt within doPrivileged In-Reply-To: <524C51B5.3040905@cs.oswego.edu> References: <524C51B5.3040905@cs.oswego.edu> Message-ID: My ignorance made me surprised that this wasn't the default of the Thread.interrupt method. Cheers, ? On Wed, Oct 2, 2013 at 7:02 PM, Doug Lea
wrote: > On 10/02/2013 12:29 PM, Martin Buchholz wrote: > >> FutureTask.cancel(true) invokes thread.interrupt on the thread (if any) >> currently running the task. >> This should succeed even if modifyThread permission is denied by the >> security >> manager. >> >> > We haven't interpreted "should" in this way in the past here or in > related contexts, but I don't see are reason not to, pending any > objections by security folks. > > -Doug > > > Here's a proposed fix for jdk8+: >> >> --- src/main/java/util/concurrent/**FutureTask.java15 May 2013 02:39:59 >> -00001.103 >> +++ src/main/java/util/concurrent/**FutureTask.java2 Oct 2013 16:25:23 >> -0000 >> >> @@ -132,6 +132,12 @@ >> return state != NEW; >> } >> + private static void privilegedInterrupt(Thread t) { >> + java.security.**PrivilegedAction doInterrupt = >> + () -> { t.interrupt(); return null; }; >> + java.security.**AccessController.doPrivileged(**doInterrupt); >> + } >> + >> public boolean cancel(boolean mayInterruptIfRunning) { >> if (!(state == NEW && >> UNSAFE.compareAndSwapInt(this, stateOffset, NEW, >> @@ -142,7 +148,11 @@ >> try { >> Thread t = runner; >> if (t != null) >> - t.interrupt(); >> + try { >> + t.interrupt(); >> + } catch (SecurityException e) { >> + privilegedInterrupt(t); >> + } >> } finally { // final state >> UNSAFE.putOrderedInt(this, stateOffset, >> INTERRUPTED); >> } >> >> >> >> ______________________________**_________________ >> Concurrency-interest mailing list >> Concurrency-interest at cs.**oswego.edu >> http://cs.oswego.edu/mailman/**listinfo/concurrency-interest >> >> > ______________________________**_________________ > Concurrency-interest mailing list > Concurrency-interest at cs.**oswego.edu > http://cs.oswego.edu/mailman/**listinfo/concurrency-interest > -- *Viktor Klang* *Director of Engineering* Typesafe Twitter: @viktorklang -------------- next part -------------- An HTML attachment was scrubbed... URL: From weijun.wang at oracle.com Fri Oct 4 03:05:16 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 04 Oct 2013 11:05:16 +0800 Subject: [8] Request for review: 8008296: keytool utility doesn't support '-importpassword' command In-Reply-To: <5631006A-E3F1-487E-BCA6-AC214ACB29B7@oracle.com> References: <6A8C2502-42E0-4A35-80E1-A07AE7E66425@oracle.com> <523A3C77.9020209@oracle.com> <77720D87-6F20-4F8B-A414-3EFAED4972DC@oracle.com> <524D7A50.1060202@oracle.com> <5631006A-E3F1-487E-BCA6-AC214ACB29B7@oracle.com> Message-ID: <524E306C.5010101@oracle.com> This looks fine. Thanks Max On 10/3/13 11:26 PM, Vincent Ryan wrote: > Sorry. I've just refreshed it now: > http://cr.openjdk.java.net/~vinnie/8008296/webrev.00 > > > > On 3 Oct 2013, at 15:08, Weijun Wang wrote: > >> I don't have other issues. Have you updated the webrev? I see no change. >> >> --Max >> >> On 10/3/13 9:57 PM, Vincent Ryan wrote: >>> Thanks for the comments - I'm just returning to this following JavaOne. >>> >>> I've updated the Help messages to add a separate section for '-importpass' and >>> I've reverted the prompt to its previous value: 'Enter the password to be stored'. >>> >>> Let me know if there are any other issues. Otherwise I'd like to push this today. >>> >>> >>> On 19 Sep 2013, at 00:51, Weijun Wang wrote: >>> >>>> Hi Vinnie >>>> >>>> Mostly good, but do you need to add a help line for it? You reuse the GENSECKEY command so "keytool -importpass -help" looks strange. >>>> >>>> Also, the command name is -importpassword but the prompt is "Enter the passphrase to be stored". Feel a little uncomfortable. >>>> >>>> Thanks >>>> Max >>>> >>>> >>>> On 9/14/13 2:25 AM, Vincent Ryan wrote: >>>>> >>>>> Please review the following fix that adds support to the keytool utility for storing arbitrary user passwords >>>>> in a keystore. For keystores such as PKCS#12 that support a variety of key protection algorithms, >>>>> the PBE algorithm may also be specified by overloading the existing -keyalg flag. For example, >>>>> >>>>> % keytool -importpassword -storetype PKCS12 -keyalg PBEWithHmacSHA1AndAES_128 ... >>>>> >>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008296 >>>>> Webrev: http://cr.openjdk.java.net/~vinnie/8008296/webrev.00/ >>>>> >>>>> Thanks. >>>>> >>>>> >>> > From jan.lahoda at oracle.com Fri Oct 4 06:32:03 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Fri, 04 Oct 2013 06:32:03 +0000 Subject: hg: jdk8/tl/langtools: 8025118: Annotation processing api returns default modifier for interface without default methods Message-ID: <20131004063211.3E5F362D4D@hg.openjdk.java.net> Changeset: c13305cf8528 Author: jlahoda Date: 2013-10-04 08:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c13305cf8528 8025118: Annotation processing api returns default modifier for interface without default methods Summary: TypeElement.getModifiers() should not contain Modifier.DEFAULT Reviewed-by: darcy, jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java + test/tools/javac/processing/model/element/TestTypeElement.java From sundararajan.athijegannathan at oracle.com Fri Oct 4 13:05:39 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 04 Oct 2013 13:05:39 +0000 Subject: hg: jdk8/tl/nashorn: 8025771: Enhance Nashorn Contexts Message-ID: <20131004130547.E8AB662D72@hg.openjdk.java.net> Changeset: 3470bc26128f Author: sundar Date: 2013-10-04 16:21 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3470bc26128f 8025771: Enhance Nashorn Contexts Reviewed-by: jlaskey, hannesw - make/java.security.override ! make/project.properties ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java ! test/script/basic/JDK-8023026.js + test/script/sandbox/arrayclass.js + test/script/sandbox/arrayclass.js.EXPECTED From staffan.larsen at oracle.com Fri Oct 4 13:19:00 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 04 Oct 2013 13:19:00 +0000 Subject: hg: jdk8/tl/jdk: 8025829: Add java/lang/instrument/RetransformBigClass.sh to problemlist Message-ID: <20131004131913.076C062D74@hg.openjdk.java.net> Changeset: 77ba1e67707c Author: allwin Date: 2013-10-04 15:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77ba1e67707c 8025829: Add java/lang/instrument/RetransformBigClass.sh to problemlist Reviewed-by: sla, jbachorik ! test/ProblemList.txt From vincent.x.ryan at oracle.com Fri Oct 4 15:00:47 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 4 Oct 2013 16:00:47 +0100 Subject: [8] Request for review: 8008296: keytool utility doesn't support '-importpassword' command In-Reply-To: <524E306C.5010101@oracle.com> References: <6A8C2502-42E0-4A35-80E1-A07AE7E66425@oracle.com> <523A3C77.9020209@oracle.com> <77720D87-6F20-4F8B-A414-3EFAED4972DC@oracle.com> <524D7A50.1060202@oracle.com> <5631006A-E3F1-487E-BCA6-AC214ACB29B7@oracle.com> <524E306C.5010101@oracle.com> Message-ID: <93F97D1A-9D40-4E1A-83C3-AA74E2831BB0@oracle.com> Thanks Max. On 4 Oct 2013, at 04:05, Weijun Wang wrote: > This looks fine. > > Thanks > Max > > On 10/3/13 11:26 PM, Vincent Ryan wrote: >> Sorry. I've just refreshed it now: >> http://cr.openjdk.java.net/~vinnie/8008296/webrev.00 >> >> >> >> On 3 Oct 2013, at 15:08, Weijun Wang wrote: >> >>> I don't have other issues. Have you updated the webrev? I see no change. >>> >>> --Max >>> >>> On 10/3/13 9:57 PM, Vincent Ryan wrote: >>>> Thanks for the comments - I'm just returning to this following JavaOne. >>>> >>>> I've updated the Help messages to add a separate section for '-importpass' and >>>> I've reverted the prompt to its previous value: 'Enter the password to be stored'. >>>> >>>> Let me know if there are any other issues. Otherwise I'd like to push this today. >>>> >>>> >>>> On 19 Sep 2013, at 00:51, Weijun Wang wrote: >>>> >>>>> Hi Vinnie >>>>> >>>>> Mostly good, but do you need to add a help line for it? You reuse the GENSECKEY command so "keytool -importpass -help" looks strange. >>>>> >>>>> Also, the command name is -importpassword but the prompt is "Enter the passphrase to be stored". Feel a little uncomfortable. >>>>> >>>>> Thanks >>>>> Max >>>>> >>>>> >>>>> On 9/14/13 2:25 AM, Vincent Ryan wrote: >>>>>> >>>>>> Please review the following fix that adds support to the keytool utility for storing arbitrary user passwords >>>>>> in a keystore. For keystores such as PKCS#12 that support a variety of key protection algorithms, >>>>>> the PBE algorithm may also be specified by overloading the existing -keyalg flag. For example, >>>>>> >>>>>> % keytool -importpassword -storetype PKCS12 -keyalg PBEWithHmacSHA1AndAES_128 ... >>>>>> >>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008296 >>>>>> Webrev: http://cr.openjdk.java.net/~vinnie/8008296/webrev.00/ >>>>>> >>>>>> Thanks. >>>>>> >>>>>> >>>> >> From vincent.x.ryan at oracle.com Fri Oct 4 15:06:58 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Fri, 04 Oct 2013 15:06:58 +0000 Subject: hg: jdk8/tl/jdk: 8008296: keytool utility doesn't support '-importpassword' command Message-ID: <20131004150846.CCBE862D79@hg.openjdk.java.net> Changeset: b5aad88cbf12 Author: vinnie Date: 2013-10-04 16:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b5aad88cbf12 8008296: keytool utility doesn't support '-importpassword' command Reviewed-by: weijun ! src/share/classes/sun/security/tools/keytool/Main.java ! src/share/classes/sun/security/tools/keytool/Resources.java + test/sun/security/tools/keytool/StorePasswords.java + test/sun/security/tools/keytool/StorePasswordsByShell.sh From alexander.zuev at oracle.com Fri Oct 4 15:39:23 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Fri, 04 Oct 2013 15:39:23 +0000 Subject: hg: jdk8/tl/langtools: 7096170: should remove unused support for enabling javac logging Message-ID: <20131004153931.CB4C862D7A@hg.openjdk.java.net> Changeset: c0d44b1e6b6a Author: kizune Date: 2013-10-04 19:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c0d44b1e6b6a 7096170: should remove unused support for enabling javac logging Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java From roger.riggs at oracle.com Fri Oct 4 16:53:10 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 04 Oct 2013 16:53:10 +0000 Subject: hg: jdk8/tl/jdk: 7 new changesets Message-ID: <20131004165456.3C0CA62D87@hg.openjdk.java.net> Changeset: 1de0fac9b962 Author: rriggs Date: 2013-08-29 20:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1de0fac9b962 8023764: Optimize Period addition Summary: Optimise plus/minus for common cases Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/ZonedDateTime.java Changeset: 356df1b99976 Author: rriggs Date: 2013-08-30 11:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/356df1b99976 8023763: Rename ChronoDateImpl Summary: Rename ChronoDateImpl to ChronoLocalDateImpl Reviewed-by: sherman Contributed-by: scolebourne at joda.org - src/share/classes/java/time/chrono/ChronoDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java + src/share/classes/java/time/chrono/ChronoLocalDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/HijrahDate.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/chrono/MinguoDate.java ! src/share/classes/java/time/chrono/ThaiBuddhistDate.java Changeset: 5d73f7a2db51 Author: rriggs Date: 2013-09-04 15:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d73f7a2db51 8023762: Add ChronoPeriod interface and bind period to Chronology Summary: Make Period ISO-only, adding a Chronology-specific period concept Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java + src/share/classes/java/time/chrono/ChronoPeriod.java + src/share/classes/java/time/chrono/ChronoPeriodImpl.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/HijrahDate.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/chrono/MinguoDate.java ! src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/chrono/ThaiBuddhistDate.java ! src/share/classes/java/time/temporal/Temporal.java ! test/java/time/tck/java/time/TCKPeriod.java + test/java/time/tck/java/time/chrono/TCKChronoPeriod.java ! test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java ! test/java/time/tck/java/time/chrono/TCKMinguoChronology.java ! test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java ! test/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java Changeset: 79077f1641cc Author: rriggs Date: 2013-09-14 22:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79077f1641cc 8024835: Change until() to accept any compatible temporal Summary: Method until(Temporal,TemporalUnit) now uses from() to convert; Enhance from() methods where necessary Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! test/java/time/tck/java/time/TCKDuration.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/chrono/CopticDate.java ! test/java/time/tck/java/time/temporal/TCKIsoFields.java Changeset: 14a187dc4ffe Author: rriggs Date: 2013-10-04 12:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/14a187dc4ffe 8024999: Instant.Parse typo in example Summary: javadoc only fix to correct example to use "." and "Z" Reviewed-by: sherman ! src/share/classes/java/time/Instant.java Changeset: f9c701ba04e7 Author: rriggs Date: 2013-09-14 22:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9c701ba04e7 8024807: Add getChronlogy() to CLDT/CZDT Summary: Alternative to method is clunky and hard to find Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! test/java/time/tck/java/time/chrono/TCKChronoLocalDateTime.java ! test/java/time/tck/java/time/chrono/TCKChronoZonedDateTime.java Changeset: e12b912ab98e Author: rriggs Date: 2013-09-14 22:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e12b912ab98e 8024834: Better return type for TemporalField resolve Summary: Allow resolve method to return more than just ChronoLocalDate Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/format/Parsed.java ! src/share/classes/java/time/temporal/TemporalField.java ! test/java/time/tck/java/time/format/TCKDateTimeParseResolver.java From robert.field at oracle.com Fri Oct 4 16:55:18 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Fri, 04 Oct 2013 16:55:18 +0000 Subject: hg: jdk8/tl/jdk: 8021186: jdk/lambda/vm/DefaultMethodsTest.java fails Message-ID: <20131004165529.DFDB862D88@hg.openjdk.java.net> Changeset: 7736abdf0805 Author: rfield Date: 2013-10-04 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7736abdf0805 8021186: jdk/lambda/vm/DefaultMethodsTest.java fails Summary: remove DefaultMethodsTest from jdk/test/problemList.txt Reviewed-by: mduigou ! test/ProblemList.txt From joe.darcy at oracle.com Fri Oct 4 17:00:53 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 04 Oct 2013 17:00:53 +0000 Subject: hg: jdk8/tl/langtools: 8025913: Rename jdk.Supported to jdk.Exported Message-ID: <20131004170100.617D762D89@hg.openjdk.java.net> Changeset: 379c04c090cf Author: darcy Date: 2013-10-04 10:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/379c04c090cf 8025913: Rename jdk.Supported to jdk.Exported Reviewed-by: psandoz, forax, lancea, alanb, mchung, jjg ! src/share/classes/com/sun/source/doctree/AttributeTree.java ! src/share/classes/com/sun/source/doctree/AuthorTree.java ! src/share/classes/com/sun/source/doctree/BlockTagTree.java ! src/share/classes/com/sun/source/doctree/CommentTree.java ! src/share/classes/com/sun/source/doctree/DeprecatedTree.java ! src/share/classes/com/sun/source/doctree/DocCommentTree.java ! src/share/classes/com/sun/source/doctree/DocRootTree.java ! src/share/classes/com/sun/source/doctree/DocTree.java ! src/share/classes/com/sun/source/doctree/DocTreeVisitor.java ! src/share/classes/com/sun/source/doctree/EndElementTree.java ! src/share/classes/com/sun/source/doctree/EntityTree.java ! src/share/classes/com/sun/source/doctree/ErroneousTree.java ! src/share/classes/com/sun/source/doctree/IdentifierTree.java ! src/share/classes/com/sun/source/doctree/InheritDocTree.java ! src/share/classes/com/sun/source/doctree/InlineTagTree.java ! src/share/classes/com/sun/source/doctree/LinkTree.java ! src/share/classes/com/sun/source/doctree/LiteralTree.java ! src/share/classes/com/sun/source/doctree/ParamTree.java ! src/share/classes/com/sun/source/doctree/ReferenceTree.java ! src/share/classes/com/sun/source/doctree/ReturnTree.java ! src/share/classes/com/sun/source/doctree/SeeTree.java ! src/share/classes/com/sun/source/doctree/SerialDataTree.java ! src/share/classes/com/sun/source/doctree/SerialFieldTree.java ! src/share/classes/com/sun/source/doctree/SerialTree.java ! src/share/classes/com/sun/source/doctree/SinceTree.java ! src/share/classes/com/sun/source/doctree/StartElementTree.java ! src/share/classes/com/sun/source/doctree/TextTree.java ! src/share/classes/com/sun/source/doctree/ThrowsTree.java ! src/share/classes/com/sun/source/doctree/UnknownBlockTagTree.java ! src/share/classes/com/sun/source/doctree/UnknownInlineTagTree.java ! src/share/classes/com/sun/source/doctree/ValueTree.java ! src/share/classes/com/sun/source/doctree/VersionTree.java ! src/share/classes/com/sun/source/doctree/package-info.java ! src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java ! src/share/classes/com/sun/source/tree/AnnotationTree.java ! src/share/classes/com/sun/source/tree/ArrayAccessTree.java ! src/share/classes/com/sun/source/tree/ArrayTypeTree.java ! src/share/classes/com/sun/source/tree/AssertTree.java ! src/share/classes/com/sun/source/tree/AssignmentTree.java ! src/share/classes/com/sun/source/tree/BinaryTree.java ! src/share/classes/com/sun/source/tree/BlockTree.java ! src/share/classes/com/sun/source/tree/BreakTree.java ! src/share/classes/com/sun/source/tree/CaseTree.java ! src/share/classes/com/sun/source/tree/CatchTree.java ! src/share/classes/com/sun/source/tree/ClassTree.java ! src/share/classes/com/sun/source/tree/CompilationUnitTree.java ! src/share/classes/com/sun/source/tree/CompoundAssignmentTree.java ! src/share/classes/com/sun/source/tree/ConditionalExpressionTree.java ! src/share/classes/com/sun/source/tree/ContinueTree.java ! src/share/classes/com/sun/source/tree/DoWhileLoopTree.java ! src/share/classes/com/sun/source/tree/EmptyStatementTree.java ! src/share/classes/com/sun/source/tree/EnhancedForLoopTree.java ! src/share/classes/com/sun/source/tree/ErroneousTree.java ! src/share/classes/com/sun/source/tree/ExpressionStatementTree.java ! src/share/classes/com/sun/source/tree/ExpressionTree.java ! src/share/classes/com/sun/source/tree/ForLoopTree.java ! src/share/classes/com/sun/source/tree/IdentifierTree.java ! src/share/classes/com/sun/source/tree/IfTree.java ! src/share/classes/com/sun/source/tree/ImportTree.java ! src/share/classes/com/sun/source/tree/InstanceOfTree.java ! src/share/classes/com/sun/source/tree/IntersectionTypeTree.java ! src/share/classes/com/sun/source/tree/LabeledStatementTree.java ! src/share/classes/com/sun/source/tree/LambdaExpressionTree.java ! src/share/classes/com/sun/source/tree/LineMap.java ! src/share/classes/com/sun/source/tree/LiteralTree.java ! src/share/classes/com/sun/source/tree/MemberReferenceTree.java ! src/share/classes/com/sun/source/tree/MemberSelectTree.java ! src/share/classes/com/sun/source/tree/MethodInvocationTree.java ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/ModifiersTree.java ! src/share/classes/com/sun/source/tree/NewArrayTree.java ! src/share/classes/com/sun/source/tree/NewClassTree.java ! src/share/classes/com/sun/source/tree/ParameterizedTypeTree.java ! src/share/classes/com/sun/source/tree/ParenthesizedTree.java ! src/share/classes/com/sun/source/tree/PrimitiveTypeTree.java ! src/share/classes/com/sun/source/tree/ReturnTree.java ! src/share/classes/com/sun/source/tree/Scope.java ! src/share/classes/com/sun/source/tree/StatementTree.java ! src/share/classes/com/sun/source/tree/SwitchTree.java ! src/share/classes/com/sun/source/tree/SynchronizedTree.java ! src/share/classes/com/sun/source/tree/ThrowTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TryTree.java ! src/share/classes/com/sun/source/tree/TypeCastTree.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/tree/UnaryTree.java ! src/share/classes/com/sun/source/tree/UnionTypeTree.java ! src/share/classes/com/sun/source/tree/VariableTree.java ! src/share/classes/com/sun/source/tree/WhileLoopTree.java ! src/share/classes/com/sun/source/tree/WildcardTree.java ! src/share/classes/com/sun/source/tree/package-info.java ! src/share/classes/com/sun/source/util/DocSourcePositions.java ! src/share/classes/com/sun/source/util/DocTreePath.java ! src/share/classes/com/sun/source/util/DocTreePathScanner.java ! src/share/classes/com/sun/source/util/DocTreeScanner.java ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/source/util/JavacTask.java ! src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/com/sun/source/util/SimpleDocTreeVisitor.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/SourcePositions.java ! src/share/classes/com/sun/source/util/TaskEvent.java ! src/share/classes/com/sun/source/util/TaskListener.java ! src/share/classes/com/sun/source/util/TreePath.java ! src/share/classes/com/sun/source/util/TreePathScanner.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/source/util/package-info.java ! src/share/classes/com/sun/tools/javac/Main.java + src/share/classes/jdk/Exported.java - src/share/classes/jdk/Supported.java From daniel.fuchs at oracle.com Fri Oct 4 18:41:28 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Fri, 04 Oct 2013 18:41:28 +0000 Subject: hg: jdk8/tl/jaxp: 8025745: Clarify API documentation of JAXP factories. Message-ID: <20131004184134.9F52C62D8E@hg.openjdk.java.net> Changeset: f031b2fe21cd Author: dfuchs Date: 2013-10-04 19:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f031b2fe21cd 8025745: Clarify API documentation of JAXP factories. Summary: Clarifies usage of ServiceLoader in JAXP factories. Reviewed-by: alanb, joehw, psandoz ! src/javax/xml/datatype/DatatypeFactory.java ! src/javax/xml/parsers/DocumentBuilderFactory.java ! src/javax/xml/parsers/SAXParserFactory.java ! src/javax/xml/stream/XMLEventFactory.java ! src/javax/xml/stream/XMLInputFactory.java ! src/javax/xml/stream/XMLOutputFactory.java ! src/javax/xml/transform/TransformerFactory.java ! src/javax/xml/validation/SchemaFactory.java ! src/javax/xml/xpath/XPathFactory.java From bhavesh.x.patel at oracle.com Fri Oct 4 20:32:59 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Fri, 04 Oct 2013 20:32:59 +0000 Subject: hg: jdk8/tl/langtools: 8008164: Invisible table captions in javadoc-generated html Message-ID: <20131004203309.BA4EA62D95@hg.openjdk.java.net> Changeset: 6e186ca11ec0 Author: bpatel Date: 2013-10-04 13:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6e186ca11ec0 8008164: Invisible table captions in javadoc-generated html Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css + test/com/sun/javadoc/testHtmlTableStyles/TestHtmlTableStyles.java + test/com/sun/javadoc/testHtmlTableStyles/pkg1/TestTable.java + test/com/sun/javadoc/testHtmlTableStyles/pkg2/TestUse.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java From bhavesh.x.patel at oracle.com Fri Oct 4 20:41:46 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Fri, 04 Oct 2013 20:41:46 +0000 Subject: hg: jdk8/tl/langtools: 8024756: method grouping tabs are not selectable Message-ID: <20131004204149.F270A62D96@hg.openjdk.java.net> Changeset: 3344ea7404b1 Author: bpatel Date: 2013-10-04 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3344ea7404b1 8024756: method grouping tabs are not selectable Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! test/com/sun/javadoc/JavascriptWinTitle/JavascriptWinTitle.java ! test/com/sun/javadoc/testJavascript/TestJavascript.java From jonathan.gibbons at oracle.com Fri Oct 4 21:00:16 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 04 Oct 2013 21:00:16 +0000 Subject: hg: jdk8/tl/langtools: 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor Message-ID: <20131004210020.038FF62D97@hg.openjdk.java.net> Changeset: 2fa6ced325cc Author: jjg Date: 2013-10-04 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fa6ced325cc 8022163: javac exits with 0 status and no messages on error to construct an ann-procesor Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/errors/TestBadProcessor.java From jonathan.gibbons at oracle.com Fri Oct 4 21:47:36 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 04 Oct 2013 21:47:36 +0000 Subject: hg: jdk8/tl/langtools: 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode Message-ID: <20131004214739.29BA162D99@hg.openjdk.java.net> Changeset: 515d54c1b063 Author: jjg Date: 2013-10-04 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/515d54c1b063 6525408: DiagnosticListener should receive MANDATORY_WARNING in standard compiler mode Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/javax/tools/Diagnostic.java From valerie.peng at oracle.com Fri Oct 4 22:24:48 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 04 Oct 2013 15:24:48 -0700 Subject: Code Review Request for 8025967 "addition of -Werror broke the old build" Message-ID: <524F4030.8000906@oracle.com> Well, can someone please review the following trivial fix today or early Monday? 8025967: addition of -Werror broke the old build JCE is still using the legacy build and as a result, I have to fix build warnings in other components in order for the whole build to succeed. The changes are all about addressing the javac raw type warnings. I want to keep changes to a minimum, thus I only changed the private/implementation related ones and used annotation to disable the warnings in all public APIs and some private ones where there are dependencies, e.g. JNI. Webrev can be found at: http://cr.openjdk.java.net/~valeriep/8025967/ Thanks! Valerie From jonathan.gibbons at oracle.com Fri Oct 4 22:25:52 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 04 Oct 2013 22:25:52 +0000 Subject: hg: jdk8/tl/langtools: 8025970: Spurious characters in JavaCompiler Message-ID: <20131004222556.7299862D9B@hg.openjdk.java.net> Changeset: 3e3c321710be Author: jjg Date: 2013-10-04 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3e3c321710be 8025970: Spurious characters in JavaCompiler Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java From bhavesh.x.patel at oracle.com Fri Oct 4 22:37:32 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Fri, 04 Oct 2013 22:37:32 +0000 Subject: hg: jdk8/tl: 8025741: Fix jdk/make/docs/Makefile to point to correct docs URL for JDK 8. Message-ID: <20131004223732.E1E0562D9C@hg.openjdk.java.net> Changeset: 6b8f5030e5ad Author: bpatel Date: 2013-10-04 15:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6b8f5030e5ad 8025741: Fix jdk/make/docs/Makefile to point to correct docs URL for JDK 8. Reviewed-by: tbell ! common/makefiles/javadoc/Javadoc.gmk From bhavesh.x.patel at oracle.com Fri Oct 4 22:38:54 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Fri, 04 Oct 2013 22:38:54 +0000 Subject: hg: jdk8/tl/jdk: 8025741: Fix jdk/make/docs/Makefile to point to correct docs URL for JDK 8. Message-ID: <20131004223906.38C9362D9D@hg.openjdk.java.net> Changeset: 66181f7991bd Author: bpatel Date: 2013-10-04 15:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/66181f7991bd 8025741: Fix jdk/make/docs/Makefile to point to correct docs URL for JDK 8. Reviewed-by: tbell ! make/docs/Makefile From kumar.x.srinivasan at oracle.com Fri Oct 4 23:16:11 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 04 Oct 2013 23:16:11 +0000 Subject: hg: jdk8/tl/langtools: 8003537: javap use internal class name when printing bound of type variable Message-ID: <20131004231614.DD5DE62D9E@hg.openjdk.java.net> Changeset: bb87db832b31 Author: ksrini Date: 2013-10-04 16:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bb87db832b31 8003537: javap use internal class name when printing bound of type variable Reviewed-by: jjg ! src/share/classes/com/sun/tools/javap/ClassWriter.java + test/tools/javap/BoundsTypeVariableTest.java From kumar.x.srinivasan at oracle.com Fri Oct 4 23:45:49 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 04 Oct 2013 23:45:49 +0000 Subject: hg: jdk8/tl/langtools: 8005542: jtreg test OverrideBridge.java contains @ignore Message-ID: <20131004234552.5B5A562DA0@hg.openjdk.java.net> Changeset: 15651a673358 Author: ksrini Date: 2013-10-04 16:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/15651a673358 8005542: jtreg test OverrideBridge.java contains @ignore Reviewed-by: jjg Contributed-by: steve.sides at oracle.com - test/tools/javac/generics/OverrideBridge.java From chris.hegarty at oracle.com Sat Oct 5 08:05:56 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Sat, 05 Oct 2013 08:05:56 +0000 Subject: hg: jdk8/tl/jdk: 8016271: wsimport -clientjar does not create portable jars on Windows due to hardcoded backslash Message-ID: <20131005080617.2118262DBA@hg.openjdk.java.net> Changeset: 7d2112abbb1d Author: coffeys Date: 2013-10-04 16:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d2112abbb1d 8016271: wsimport -clientjar does not create portable jars on Windows due to hardcoded backslash Reviewed-by: mkos, chegar + test/javax/xml/ws/clientjar/TestService.java + test/javax/xml/ws/clientjar/TestWsImport.java From chris.hegarty at oracle.com Sat Oct 5 07:57:24 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Sat, 05 Oct 2013 07:57:24 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20131005075733.5131162DB7@hg.openjdk.java.net> Changeset: b0610cd08440 Author: mkos Date: 2013-10-04 16:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b0610cd08440 8025054: Update JAX-WS RI integration to 2.2.9-b130926.1035 Reviewed-by: chegar ! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/ExternalMetadataFeature.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_de.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_es.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_fr.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_it.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_ja.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_ko.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_pt_BR.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_zh_CN.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_zh_TW.properties ! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/WscompileMessages.java ! src/share/jaxws_classes/com/sun/tools/internal/ws/resources/wscompile.properties ! src/share/jaxws_classes/com/sun/tools/internal/ws/version.properties ! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/Options.java ! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsgenTool.java ! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsimportOptions.java ! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsimportTool.java ! src/share/jaxws_classes/com/sun/tools/internal/ws/wsdl/parser/DOMForest.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_de.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_es.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_fr.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_it.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_ja.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_ko.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_pt_BR.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_zh_CN.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_zh_TW.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/SchemaCache.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/internalizer/DOMForest.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/ct/AbstractExtendedComplexTypeBuilder.java ! src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/parser/SchemaConstraintChecker.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/Messages.properties ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/property/SingleMapNodeProperty.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/AccessorInjector.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/Injector.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/reflect/opt/OptimizedAccessorFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/util/XmlFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/Base64Data.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/Base64Encoder.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/Base64EncoderStream.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/ByteArrayOutputStreamEx.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/NamespaceContextEx.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/StreamingDataHandler.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/XMLStreamWriterEx.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/binary/SchemaBuilderImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/digested/DDataPattern.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/digested/DPattern.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/digested/DXMLPrinter.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/digested/DataPatternBuilderImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/digested/GrammarBuilderImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/nc/AnyNameClass.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/nc/NameClassBuilderImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/nc/SimpleNameClass.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/parse/compact/UCode_UCodeESC_CharStream.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/parse/xml/SchemaParser.java ! src/share/jaxws_classes/com/sun/xml/internal/rngom/xml/sax/JAXPXMLReaderCreator.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/addressing/WsaTubeHelper.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLBoundOperation.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLBoundPortType.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLExtensible.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLFault.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLModel.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLOperation.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLOutput.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLPort.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLPortType.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/WSDLService.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLBoundFault.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLBoundOperation.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLBoundPortType.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLFault.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLInput.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLMessage.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLModel.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLOperation.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLOutput.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLPart.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLPort.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLPortType.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/model/wsdl/editable/EditableWSDLService.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/parser/WSDLParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/wsdl/parser/WSDLParserExtensionContext.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/binding/WebServiceFeatureList.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/MonitorRootClient.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/PortInfo.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/Stub.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/WSServiceDelegate.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/ExternalMetadataReader.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/JavaMethodImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/AbstractExtensibleImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLBoundFaultImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLBoundOperationImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLBoundPortTypeImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLFaultImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLInputImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLMessageImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLModelImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLOperationImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLOutputImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLPartImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLPortImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLPortTypeImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLProperties.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLServiceImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/jaxws/PolicyWSDLParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/WsservletMessages.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/wsservlet.properties ! src/share/jaxws_classes/com/sun/xml/internal/ws/server/EndpointFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/server/WSEndpointImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/ProviderImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/HttpAdapter.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/client/HttpTransportPipe.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/util/pipe/AbstractSchemaValidationTube.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/util/version.properties ! src/share/jaxws_classes/com/sun/xml/internal/ws/util/xml/XmlUtil.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/ActionBasedOperationFinder.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/PayloadQNameBasedOperationFinder.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/DelegatingParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/FoolProofParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/MemberSubmissionAddressingWSDLParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/RuntimeWSDLParser.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/W3CAddressingMetadataWSDLParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/W3CAddressingWSDLParserExtension.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/WSDLParserExtensionContextImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/parser/WSDLParserExtensionFacade.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/wsdl/writer/WSDLGenerator.java ! src/share/jaxws_classes/javax/annotation/PostConstruct.java ! src/share/jaxws_classes/javax/annotation/PreDestroy.java ! src/share/jaxws_classes/javax/xml/bind/JAXBException.java ! src/share/jaxws_classes/javax/xml/bind/Marshaller.java ! src/share/jaxws_classes/javax/xml/bind/TypeConstraintException.java ! src/share/jaxws_classes/javax/xml/bind/annotation/adapters/package.html ! src/share/jaxws_classes/javax/xml/soap/MessageFactory.java Changeset: e56be3a2287a Author: coffeys Date: 2013-10-05 08:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/e56be3a2287a 8016271: wsimport -clientjar does not create portable jars on Windows due to hardcoded backslash Reviewed-by: mkos, chegar ! src/share/jaxws_classes/com/sun/tools/internal/ws/wscompile/WsimportTool.java From john.r.rose at oracle.com Sat Oct 5 12:31:44 2013 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Sat, 05 Oct 2013 12:31:44 +0000 Subject: hg: jdk8/tl/jdk: 9 new changesets Message-ID: <20131005123417.A921962DBB@hg.openjdk.java.net> Changeset: 44da760eed4b Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44da760eed4b 8024761: JSR 292 improve performance of generic invocation Summary: use a per-MH one element cache for MH.asType to speed up MH.invoke; also cache enough MH constants to cache LMF.metafactory Reviewed-by: twisti ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/CallSite.java - src/share/classes/java/lang/invoke/InvokeGeneric.java ! src/share/classes/java/lang/invoke/Invokers.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MemberName.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodTypeForm.java Changeset: 97d5cc1e7586 Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/97d5cc1e7586 8001105: findVirtual of Object[].clone produces internal error Summary: Replicate JVM logic for access control that makes Object.clone appear public when applied to an array type. Reviewed-by: twisti ! src/share/classes/java/lang/invoke/MethodHandles.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: 91535ade7349 Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91535ade7349 8019417: JSR 292 javadoc should clarify method handle arity limits Summary: clarification of erroneous reading of spec. that led to 7194534 Reviewed-by: twisti, darcy ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! test/java/lang/invoke/BigArityTest.java Changeset: d391e062b983 Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d391e062b983 8001109: arity mismatch on a call to spreader method handle should elicit IllegalArgumentException Summary: Document error conditions that may occur when calling a "spreader" method handle. Use IAE in all cases. Reviewed-by: twisti, vlivanov ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! test/java/lang/invoke/JavaDocExamplesTest.java Changeset: acdf5bf1a918 Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/acdf5bf1a918 8001108: an attempt to use "" as a method name should elicit NoSuchMethodException Summary: add an explicit check for leading "<", upgrade the unit tests Reviewed-by: twisti, darcy ! src/share/classes/java/lang/invoke/MethodHandles.java ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: df6236da299d Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df6236da299d 8024599: JSR 292 direct method handles need to respect initialization rules for static members Summary: Align MH semantic with bytecode behavior of constructor and static member accesses, regarding invocation. Reviewed-by: twisti, darcy, abuckley, vlivanov ! src/share/classes/java/lang/invoke/MethodHandles.java + test/java/lang/invoke/CallStaticInitOrder.java Changeset: eb3cfc69c16e Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb3cfc69c16e 8001110: method handles should have a collectArguments transform, generalizing asCollector Summary: promote an existing private method; make unit tests on all argument positions to arity 10 with mixed types Reviewed-by: twisti, vlivanov ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: b670477bff8f Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b670477bff8f 8025112: JSR 292 spec updates for security manager and caller sensitivity Summary: align CONSTANT_MethodHandle and Lookup.find* API calls, clarify security manager & @CallerSensitive interactions Reviewed-by: mchung, twisti ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleInfo.java ! src/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! test/java/lang/invoke/TestPrivateMember.java Changeset: 6623c675e734 Author: jrose Date: 2013-10-05 05:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6623c675e734 8024438: JSR 292 API specification maintenance for JDK 8 Summary: add wildcard to unreflectConstructor, various clarifications and minor edits Reviewed-by: mchung, darcy, twisti ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleInfo.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/invoke/MutableCallSite.java ! src/share/classes/java/lang/invoke/SwitchPoint.java ! src/share/classes/sun/invoke/WrapperInstance.java ! src/share/classes/sun/invoke/util/VerifyAccess.java ! src/share/classes/sun/invoke/util/VerifyType.java ! test/java/lang/invoke/AccessControlTest.java ! test/java/lang/invoke/MethodHandlesTest.java ! test/java/lang/invoke/RevealDirectTest.java From vincent.x.ryan at oracle.com Sat Oct 5 16:28:45 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Sat, 05 Oct 2013 17:28:45 +0100 Subject: Code Review Request for 8025967 "addition of -Werror broke the old build" In-Reply-To: <524F4030.8000906@oracle.com> References: <524F4030.8000906@oracle.com> Message-ID: <52503E3D.2060601@oracle.com> Your changes look fine. On 04/10/2013 23:24, Valerie (Yu-Ching) Peng wrote: > > Well, can someone please review the following trivial fix today or early > Monday? > 8025967: addition of -Werror broke the old build > > JCE is still using the legacy build and as a result, I have to fix build > warnings in other components in order for the whole build to succeed. > The changes are all about addressing the javac raw type warnings. > I want to keep changes to a minimum, thus I only changed the > private/implementation related ones and used annotation to disable the > warnings in all public APIs and some private ones where there are > dependencies, e.g. JNI. > > Webrev can be found at: http://cr.openjdk.java.net/~valeriep/8025967/ > > Thanks! > Valerie > From Alan.Bateman at oracle.com Sun Oct 6 20:03:34 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sun, 06 Oct 2013 21:03:34 +0100 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs Message-ID: <5251C216.105@oracle.com> As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, I'd like to have another attempt at adding the annotation to a number of JDK specific APIs that are long standing exported, documented and supported APIs. Specifically, the following APIs: - Java Debug Interface (com.sun.jdi) - Attach API (com.sun.tools.attach) - SCTP API (com.sun.nio.sctp) - HTTP server API (com.sun.net.httpserver) - Management extensions (com.sun.management) - JConsole Plugin API (com.sun.tools.jconsole) - JDK-specific API to JAAS (com.sun.security.auth) - JDK-specific JGSS API (com.sun.security.jgss) (The javadoc for each of these APIs is currently generated in the build) The webrev with the proposed update is here: http://cr.openjdk.java.net/~alanb/8008662/webrev.02/ As per the original webrev, I've added package-info.java to a number of packages that didn't have any description. In a few cases, I've had to rename the legacy package.html to package-info.java. For the review then the intention is that @jdk.Exported be added to the package-info and all public/protected types in these APIs. The only exceptions are two cases where I've added @jdk.Exported(false), specifically: - com.sun.management.OSMBeanFactory as it clearly documents to stay away - com.sun.security.auth.callback.DialogCallbackHandler as it for the chop (see JEP 162) Thanks, Alan. From chris.hegarty at oracle.com Mon Oct 7 08:23:08 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 07 Oct 2013 09:23:08 +0100 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <5251C216.105@oracle.com> References: <5251C216.105@oracle.com> Message-ID: <52526F6C.8020202@oracle.com> Alan, I checked the httpsever and sctp changes. All look good to me. -Chris. On 10/06/2013 09:03 PM, Alan Bateman wrote: > > As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, > I'd like to have another attempt at adding the annotation to a number of > JDK specific APIs that are long standing exported, documented and > supported APIs. Specifically, the following APIs: > > - Java Debug Interface (com.sun.jdi) > - Attach API (com.sun.tools.attach) > - SCTP API (com.sun.nio.sctp) > - HTTP server API (com.sun.net.httpserver) > - Management extensions (com.sun.management) > - JConsole Plugin API (com.sun.tools.jconsole) > - JDK-specific API to JAAS (com.sun.security.auth) > - JDK-specific JGSS API (com.sun.security.jgss) > > (The javadoc for each of these APIs is currently generated in the build) > > The webrev with the proposed update is here: > http://cr.openjdk.java.net/~alanb/8008662/webrev.02/ > > As per the original webrev, I've added package-info.java to a number of > packages that didn't have any description. In a few cases, I've had to > rename the legacy package.html to package-info.java. > > For the review then the intention is that @jdk.Exported be added to the > package-info and all public/protected types in these APIs. The only > exceptions are two cases where I've added @jdk.Exported(false), > specifically: > > - com.sun.management.OSMBeanFactory as it clearly documents to stay away > - com.sun.security.auth.callback.DialogCallbackHandler as it for the > chop (see JEP 162) > > Thanks, > > Alan. From vincent.x.ryan at oracle.com Mon Oct 7 08:33:06 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Mon, 7 Oct 2013 09:33:06 +0100 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <52526F6C.8020202@oracle.com> References: <5251C216.105@oracle.com> <52526F6C.8020202@oracle.com> Message-ID: The JAAS and JGSS changes look fine too. On 7 Oct 2013, at 09:23, Chris Hegarty wrote: > Alan, > > I checked the httpsever and sctp changes. All look good to me. > > -Chris. > > On 10/06/2013 09:03 PM, Alan Bateman wrote: >> >> As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, >> I'd like to have another attempt at adding the annotation to a number of >> JDK specific APIs that are long standing exported, documented and >> supported APIs. Specifically, the following APIs: >> >> - Java Debug Interface (com.sun.jdi) >> - Attach API (com.sun.tools.attach) >> - SCTP API (com.sun.nio.sctp) >> - HTTP server API (com.sun.net.httpserver) >> - Management extensions (com.sun.management) >> - JConsole Plugin API (com.sun.tools.jconsole) >> - JDK-specific API to JAAS (com.sun.security.auth) >> - JDK-specific JGSS API (com.sun.security.jgss) >> >> (The javadoc for each of these APIs is currently generated in the build) >> >> The webrev with the proposed update is here: >> http://cr.openjdk.java.net/~alanb/8008662/webrev.02/ >> >> As per the original webrev, I've added package-info.java to a number of >> packages that didn't have any description. In a few cases, I've had to >> rename the legacy package.html to package-info.java. >> >> For the review then the intention is that @jdk.Exported be added to the >> package-info and all public/protected types in these APIs. The only >> exceptions are two cases where I've added @jdk.Exported(false), >> specifically: >> >> - com.sun.management.OSMBeanFactory as it clearly documents to stay away >> - com.sun.security.auth.callback.DialogCallbackHandler as it for the >> chop (see JEP 162) >> >> Thanks, >> >> Alan. From daniel.fuchs at oracle.com Mon Oct 7 09:44:04 2013 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Mon, 07 Oct 2013 11:44:04 +0200 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <5251C216.105@oracle.com> References: <5251C216.105@oracle.com> Message-ID: <52528264.4040205@oracle.com> Hi Alan, The com.sun.management changes look good. -- daniel On 10/6/13 10:03 PM, Alan Bateman wrote: > > As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, > I'd like to have another attempt at adding the annotation to a number of > JDK specific APIs that are long standing exported, documented and > supported APIs. Specifically, the following APIs: > > - Java Debug Interface (com.sun.jdi) > - Attach API (com.sun.tools.attach) > - SCTP API (com.sun.nio.sctp) > - HTTP server API (com.sun.net.httpserver) > - Management extensions (com.sun.management) > - JConsole Plugin API (com.sun.tools.jconsole) > - JDK-specific API to JAAS (com.sun.security.auth) > - JDK-specific JGSS API (com.sun.security.jgss) > > (The javadoc for each of these APIs is currently generated in the build) > > The webrev with the proposed update is here: > http://cr.openjdk.java.net/~alanb/8008662/webrev.02/ > > As per the original webrev, I've added package-info.java to a number of > packages that didn't have any description. In a few cases, I've had to > rename the legacy package.html to package-info.java. > > For the review then the intention is that @jdk.Exported be added to the > package-info and all public/protected types in these APIs. The only > exceptions are two cases where I've added @jdk.Exported(false), > specifically: > > - com.sun.management.OSMBeanFactory as it clearly documents to stay away > - com.sun.security.auth.callback.DialogCallbackHandler as it for the > chop (see JEP 162) > > Thanks, > > Alan. From mandy.chung at oracle.com Mon Oct 7 10:31:08 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 07 Oct 2013 03:31:08 -0700 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <5251C216.105@oracle.com> References: <5251C216.105@oracle.com> Message-ID: <52528D6C.5000705@oracle.com> On 10/6/2013 1:03 PM, Alan Bateman wrote: > > The webrev with the proposed update is here: > http://cr.openjdk.java.net/~alanb/8008662/webrev.02/ > I went through the entire webrev and the change looks good. > > For the review then the intention is that @jdk.Exported be added to > the package-info and all public/protected types in these APIs. The > only exceptions are two cases where I've added @jdk.Exported(false), > specifically: > > - com.sun.management.OSMBeanFactory as it clearly documents to stay away It's a bug. We should fix it and remove this public class (I have filed JDK-8025985 for it). > - com.sun.security.auth.callback.DialogCallbackHandler as it for the > chop (see JEP 162) Good and this will be gone in jdk9. Mandy From alan.bateman at oracle.com Mon Oct 7 10:51:55 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 07 Oct 2013 10:51:55 +0000 Subject: hg: jdk8/tl/jdk: 8025983: Typo in Javadoc of Files.isRegularFile() Message-ID: <20131007105234.A1F8362DF3@hg.openjdk.java.net> Changeset: 0ac9dc315071 Author: alanb Date: 2013-10-07 11:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ac9dc315071 8025983: Typo in Javadoc of Files.isRegularFile() Reviewed-by: mchung, chegar ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/Path.java From Alan.Bateman at oracle.com Mon Oct 7 10:56:26 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 07 Oct 2013 11:56:26 +0100 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <52528D6C.5000705@oracle.com> References: <5251C216.105@oracle.com> <52528D6C.5000705@oracle.com> Message-ID: <5252935A.8070005@oracle.com> On 07/10/2013 11:31, Mandy Chung wrote: > : > >> >> For the review then the intention is that @jdk.Exported be added to >> the package-info and all public/protected types in these APIs. The >> only exceptions are two cases where I've added @jdk.Exported(false), >> specifically: >> >> - com.sun.management.OSMBeanFactory as it clearly documents to stay away > > It's a bug. We should fix it and remove this public class (I have > filed JDK-8025985 for it). Thanks for creating the bug, I agree it should be removed. For now, I'll leave @jdk.Exported(false), unless that issue is resolved before we push this (I hope that is okay with you). -Alan. From sean.mullan at oracle.com Mon Oct 7 12:26:08 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 07 Oct 2013 08:26:08 -0400 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <5251C216.105@oracle.com> References: <5251C216.105@oracle.com> Message-ID: <5252A860.4050609@oracle.com> 7 classes in com.sun.security.auth have been deprecated for several major releases now. Should they still have this annotation? --Sean On 10/06/2013 04:03 PM, Alan Bateman wrote: > > As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, > I'd like to have another attempt at adding the annotation to a number of > JDK specific APIs that are long standing exported, documented and > supported APIs. Specifically, the following APIs: > > - Java Debug Interface (com.sun.jdi) > - Attach API (com.sun.tools.attach) > - SCTP API (com.sun.nio.sctp) > - HTTP server API (com.sun.net.httpserver) > - Management extensions (com.sun.management) > - JConsole Plugin API (com.sun.tools.jconsole) > - JDK-specific API to JAAS (com.sun.security.auth) > - JDK-specific JGSS API (com.sun.security.jgss) > > (The javadoc for each of these APIs is currently generated in the build) > > The webrev with the proposed update is here: > http://cr.openjdk.java.net/~alanb/8008662/webrev.02/ > > As per the original webrev, I've added package-info.java to a number of > packages that didn't have any description. In a few cases, I've had to > rename the legacy package.html to package-info.java. > > For the review then the intention is that @jdk.Exported be added to the > package-info and all public/protected types in these APIs. The only > exceptions are two cases where I've added @jdk.Exported(false), > specifically: > > - com.sun.management.OSMBeanFactory as it clearly documents to stay away > - com.sun.security.auth.callback.DialogCallbackHandler as it for the > chop (see JEP 162) > > Thanks, > > Alan. From Alan.Bateman at oracle.com Mon Oct 7 12:28:52 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 07 Oct 2013 13:28:52 +0100 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <5252A860.4050609@oracle.com> References: <5251C216.105@oracle.com> <5252A860.4050609@oracle.com> Message-ID: <5252A904.1070808@oracle.com> On 07/10/2013 13:26, Sean Mullan wrote: > 7 classes in com.sun.security.auth have been deprecated for several > major releases now. Should they still have this annotation? > > --Sean I know but aren't they still exported and supported? DialogCallbackHandler is the only one with its name on a bullet. -Alan. From sean.mullan at oracle.com Mon Oct 7 12:36:53 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 07 Oct 2013 08:36:53 -0400 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <5252A904.1070808@oracle.com> References: <5251C216.105@oracle.com> <5252A860.4050609@oracle.com> <5252A904.1070808@oracle.com> Message-ID: <5252AAE5.4020806@oracle.com> On 10/07/2013 08:28 AM, Alan Bateman wrote: > On 07/10/2013 13:26, Sean Mullan wrote: >> 7 classes in com.sun.security.auth have been deprecated for several >> major releases now. Should they still have this annotation? >> >> --Sean > I know but aren't they still exported and supported? They have all had API replacements since JDK 1.4 or 1.5. There has been plenty of time to transition. > DialogCallbackHandler is the only one with its name on a bullet. We have only started removing some deprecated things in JDK, so it just was never thought about until now. Marking these as supported going forward strikes me as a bit strange, since we don't really want anyone using these anymore. --Sean From Alan.Bateman at oracle.com Mon Oct 7 12:58:17 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 07 Oct 2013 13:58:17 +0100 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <5252AAE5.4020806@oracle.com> References: <5251C216.105@oracle.com> <5252A860.4050609@oracle.com> <5252A904.1070808@oracle.com> <5252AAE5.4020806@oracle.com> Message-ID: <5252AFE9.2040205@oracle.com> On 07/10/2013 13:36, Sean Mullan wrote: > > We have only started removing some deprecated things in JDK, so it > just was never thought about until now. Marking these as supported > going forward strikes me as a bit strange, since we don't really want > anyone using these anymore. As a guide, I think we should plan to address these anomalies for 9 so that we can export APIs on a per API package basis. I'm okay to change these to @jdk.Exported(false) if we can flag them for removal (like we did for DialogCallbackHandler). -Alan. From sean.mullan at oracle.com Mon Oct 7 13:02:35 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 07 Oct 2013 09:02:35 -0400 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <5252AFE9.2040205@oracle.com> References: <5251C216.105@oracle.com> <5252A860.4050609@oracle.com> <5252A904.1070808@oracle.com> <5252AAE5.4020806@oracle.com> <5252AFE9.2040205@oracle.com> Message-ID: <5252B0EB.2040803@oracle.com> On 10/07/2013 08:58 AM, Alan Bateman wrote: > On 07/10/2013 13:36, Sean Mullan wrote: >> >> We have only started removing some deprecated things in JDK, so it >> just was never thought about until now. Marking these as supported >> going forward strikes me as a bit strange, since we don't really want >> anyone using these anymore. > As a guide, I think we should plan to address these anomalies for 9 so > that we can export APIs on a per API package basis. I'm okay to change > these to @jdk.Exported(false) if we can flag them for removal (like we > did for DialogCallbackHandler). Sure. I'll file a bug to have these deprecated classes removed in 9. --Sean From sean.mullan at oracle.com Mon Oct 7 15:41:23 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 07 Oct 2013 11:41:23 -0400 Subject: Code Review Request for 8025967 "addition of -Werror broke the old build" In-Reply-To: <524F4030.8000906@oracle.com> References: <524F4030.8000906@oracle.com> Message-ID: <5252D623.4040302@oracle.com> I would also send this to core-libs-dev for someone to look over the non-security component changes. --Sean On 10/04/2013 06:24 PM, Valerie (Yu-Ching) Peng wrote: > > Well, can someone please review the following trivial fix today or early > Monday? > 8025967: addition of -Werror broke the old build > > JCE is still using the legacy build and as a result, I have to fix build > warnings in other components in order for the whole build to succeed. > The changes are all about addressing the javac raw type warnings. > I want to keep changes to a minimum, thus I only changed the > private/implementation related ones and used annotation to disable the > warnings in all public APIs and some private ones where there are > dependencies, e.g. JNI. > > Webrev can be found at: http://cr.openjdk.java.net/~valeriep/8025967/ > > Thanks! > Valerie > From valerie.peng at oracle.com Mon Oct 7 18:14:00 2013 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Mon, 07 Oct 2013 11:14:00 -0700 Subject: Code Review Request for 8025967 "addition of -Werror broke the old build" In-Reply-To: <5252D623.4040302@oracle.com> References: <524F4030.8000906@oracle.com> <5252D623.4040302@oracle.com> Message-ID: <5252F9E8.30905@oracle.com> Thanks Vinnie for the review~ Forwarding this request to core-libs-dev per Sean's suggestion. Changes are for getting rid of compiler warnings in order for JCE provider build (still using the old build process) to complete successfully - either add the annotation to suppress rawtype warnings or change local declarations from Class[] to Class[]. If there are concerns, please let me know by EOB today as I have to get JCE changes integrated before leaving for vacation. Thanks, Valerie On 10/07/13 08:41, Sean Mullan wrote: > I would also send this to core-libs-dev for someone to look over the > non-security component changes. > > --Sean > > On 10/04/2013 06:24 PM, Valerie (Yu-Ching) Peng wrote: >> >> Well, can someone please review the following trivial fix today or early >> Monday? >> 8025967: addition of -Werror broke the old build >> >> JCE is still using the legacy build and as a result, I have to fix build >> warnings in other components in order for the whole build to succeed. >> The changes are all about addressing the javac raw type warnings. >> I want to keep changes to a minimum, thus I only changed the >> private/implementation related ones and used annotation to disable the >> warnings in all public APIs and some private ones where there are >> dependencies, e.g. JNI. >> >> Webrev can be found at: http://cr.openjdk.java.net/~valeriep/8025967/ >> >> Thanks! >> Valerie >> > From henry.jen at oracle.com Mon Oct 7 18:32:58 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Mon, 07 Oct 2013 18:32:58 +0000 Subject: hg: jdk8/tl/jdk: 8025968: Integrate test improvements made in lambda repo Message-ID: <20131007183325.BD04D62E0B@hg.openjdk.java.net> Changeset: f0ad3e2918b4 Author: henryjen Date: 2013-10-07 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0ad3e2918b4 8025968: Integrate test improvements made in lambda repo Reviewed-by: psandoz ! test/java/util/stream/bootlib/java/util/stream/OpTestCase.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ExplodeOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java From joe.darcy at oracle.com Mon Oct 7 22:02:15 2013 From: joe.darcy at oracle.com (Joseph Darcy) Date: Mon, 07 Oct 2013 15:02:15 -0700 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <5251C216.105@oracle.com> References: <5251C216.105@oracle.com> Message-ID: <52532F67.4070408@oracle.com> Hello, I skimmed the patch and it looked fine. More generally, we want every package and top-level class in the com.sun.* namespace to be either explicitly exported or not. Cheers, -Joe On 10/6/2013 1:03 PM, Alan Bateman wrote: > > As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, > I'd like to have another attempt at adding the annotation to a number > of JDK specific APIs that are long standing exported, documented and > supported APIs. Specifically, the following APIs: > > - Java Debug Interface (com.sun.jdi) > - Attach API (com.sun.tools.attach) > - SCTP API (com.sun.nio.sctp) > - HTTP server API (com.sun.net.httpserver) > - Management extensions (com.sun.management) > - JConsole Plugin API (com.sun.tools.jconsole) > - JDK-specific API to JAAS (com.sun.security.auth) > - JDK-specific JGSS API (com.sun.security.jgss) > > (The javadoc for each of these APIs is currently generated in the build) > > The webrev with the proposed update is here: > http://cr.openjdk.java.net/~alanb/8008662/webrev.02/ > > As per the original webrev, I've added package-info.java to a number > of packages that didn't have any description. In a few cases, I've had > to rename the legacy package.html to package-info.java. > > For the review then the intention is that @jdk.Exported be added to > the package-info and all public/protected types in these APIs. The > only exceptions are two cases where I've added @jdk.Exported(false), > specifically: > > - com.sun.management.OSMBeanFactory as it clearly documents to stay away > - com.sun.security.auth.callback.DialogCallbackHandler as it for the > chop (see JEP 162) > > Thanks, > > Alan. From henry.jen at oracle.com Mon Oct 7 23:50:27 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Mon, 07 Oct 2013 23:50:27 +0000 Subject: hg: jdk8/tl/jdk: 8026009: Changes for 8025968 break all stream tests Message-ID: <20131007235048.ABE8762E19@hg.openjdk.java.net> Changeset: 0cffe1dab0bf Author: henryjen Date: 2013-10-07 15:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cffe1dab0bf 8026009: Changes for 8025968 break all stream tests Reviewed-by: mduigou ! test/java/util/stream/bootlib/java/util/stream/OpTestCase.java From joe.darcy at oracle.com Mon Oct 7 23:52:13 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 07 Oct 2013 23:52:13 +0000 Subject: hg: jdk8/tl/langtools: 8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer Message-ID: <20131007235219.1698962E1A@hg.openjdk.java.net> Changeset: 4dd7ffbf01fb Author: darcy Date: 2013-10-07 16:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4dd7ffbf01fb 8026017: Make history of AnnotatedConstruct methods in jx.l.m.e.Element clearer Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/Element.java From xuelei.fan at oracle.com Tue Oct 8 01:47:30 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Tue, 08 Oct 2013 01:47:30 +0000 Subject: hg: jdk8/tl/jdk: 6956398: make ephemeral DH key match the length of the certificate key Message-ID: <20131008014817.94FEF62E1D@hg.openjdk.java.net> Changeset: 0d5f4f1782e8 Author: xuelei Date: 2013-10-07 18:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0d5f4f1782e8 6956398: make ephemeral DH key match the length of the certificate key Reviewed-by: weijun ! src/share/classes/sun/security/ssl/ServerHandshaker.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/DHKeyExchange/DHEKeySizing.java From paul.sandoz at oracle.com Tue Oct 8 09:49:05 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Tue, 08 Oct 2013 09:49:05 +0000 Subject: hg: jdk8/tl/jdk: 8025136: SplittableRandom enchancements Message-ID: <20131008095033.9061F62E23@hg.openjdk.java.net> Changeset: b90dcd1a71bf Author: psandoz Date: 2013-10-08 11:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b90dcd1a71bf 8025136: SplittableRandom enchancements Reviewed-by: psandoz, martin Contributed-by: Doug Lea
, Guy Steele ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/SplittableRandom.java ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java From alan.bateman at oracle.com Tue Oct 8 11:13:29 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 08 Oct 2013 11:13:29 +0000 Subject: hg: jdk8/tl/jdk: 8024788: (fs) Files.readAllBytes uses FileChannel which may not be supported by all providers Message-ID: <20131008111357.0B8C962E2C@hg.openjdk.java.net> Changeset: 95bb56c61276 Author: alanb Date: 2013-10-08 10:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/95bb56c61276 8024788: (fs) Files.readAllBytes uses FileChannel which may not be supported by all providers Reviewed-by: chegar ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/Files/BytesAndLines.java From anders.rundgren.net at gmail.com Tue Oct 8 12:53:24 2013 From: anders.rundgren.net at gmail.com (Anders Rundgren) Date: Tue, 08 Oct 2013 14:53:24 +0200 Subject: Creating an EC Public Key using Named Curves Message-ID: <52540044.5080704@gmail.com> If you have the X and Y points and the name of a public key you can create a ECPublicKey using BouncyCastle. I cannot find any counterpart in JDK 7. What am I missing? BC: return KeyFactory.getInstance ("EC").generatePublic (new ECPublicKeySpec (new ECPoint (x, y), new ECNamedCurveSpec (name,...))); Cheers Anders From sundararajan.athijegannathan at oracle.com Tue Oct 8 15:26:34 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 08 Oct 2013 15:26:34 +0000 Subject: hg: jdk8/tl/nashorn: 6 new changesets Message-ID: <20131008152640.B367362E44@hg.openjdk.java.net> Changeset: 6345d08fd5de Author: hannesw Date: 2013-10-08 11:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6345d08fd5de 8025213: Assignment marks variable as defined too early Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/codegen/Attr.java + test/script/basic/JDK-8025213.js + test/script/basic/JDK-8025213.js.EXPECTED Changeset: 8c326f8c6799 Author: sundar Date: 2013-10-08 13:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8c326f8c6799 8026033: Switch should load expression even when there are no cases in it Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8026033.js + test/script/basic/JDK-8026033.js.EXPECTED Changeset: 025e2ff9e91b Author: hannesw Date: 2013-10-08 13:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/025e2ff9e91b 8025965: Specialized functions with same weight replace each other in TreeSet Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/CompiledFunction.java Changeset: 19dba6637f20 Author: sundar Date: 2013-10-08 14:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/19dba6637f20 8026039: future strict names are allowed as function name and argument name of a strict function Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/error/JDK-8026039.js + test/script/error/JDK-8026039.js.EXPECTED Changeset: c9921761903b Author: hannesw Date: 2013-10-08 15:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c9921761903b 8026042: FoldConstants need to guard against ArrayLiteralNode Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/ir/LiteralNode.java + test/script/basic/JDK-8026042.js + test/script/basic/JDK-8026042.js.EXPECTED Changeset: 346ba5b8a488 Author: sundar Date: 2013-10-08 16:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/346ba5b8a488 8026048: Function constructor should convert arguments to String before performing any syntax checks Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/objects/NativeFunction.java + test/script/basic/JDK-8026048.js From vincent.x.ryan at oracle.com Tue Oct 8 15:41:23 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 8 Oct 2013 16:41:23 +0100 Subject: Creating an EC Public Key using Named Curves In-Reply-To: <52540044.5080704@gmail.com> References: <52540044.5080704@gmail.com> Message-ID: Currently, there is no public API for named curves. However you can generate named curves using the SunEC provider and the ECParameterSpec class. For example, AlgorithmParameters parameters = AlgorithmParameters.getInstance("EC", "SunEC"); parameters.init(new ECGenParameterSpec("secp256r1")); ECParameterSpec ecParameters = parameters.getParameterSpec(ECParameterSpec.class); return KeyFactory.getInstance("EC", "SunEC").generatePublic(new ECPublicKeySpec(new ECPoint(x, y), ecParameters)); It's not elegant but the list of supported named curves can be extracted from the AlgorithmParameters.EC SupportedCurves property. For example, String[] curves = Security.getProvider("SunEC") .getProperty("AlgorithmParameters.EC SupportedCurves") .split("\\|"); for (String curve : curves) { System.out.println(curve.substring(1, curve.indexOf(","))); } On 8 Oct 2013, at 13:53, Anders Rundgren wrote: > If you have the X and Y points and the name of a public key you can create a ECPublicKey using BouncyCastle. > I cannot find any counterpart in JDK 7. What am I missing? > > BC: > > return KeyFactory.getInstance ("EC").generatePublic (new ECPublicKeySpec (new ECPoint (x, y), new ECNamedCurveSpec (name,...))); > > Cheers > Anders From mstjohns at comcast.net Tue Oct 8 16:56:39 2013 From: mstjohns at comcast.net (Michael StJohns) Date: Tue, 08 Oct 2013 12:56:39 -0400 Subject: Creating an EC Public Key using Named Curves In-Reply-To: References: <52540044.5080704@gmail.com> Message-ID: <20131008165636.497326A37@mail.openjdk.java.net> I use this construct a lot, but there are a number of cases (e.g. where I'm trying to take an EC key and turn it into a structure to send to a smart card) where what I really need is to be able to produce an EllipticCurve (actually ECParamaterSpec) from a name. I started looking at why ECGenParameterSpec isn't currently a subclass of ECParameterSpec. I *think* this is because the curve table is currently part of the individual EC providers rather than part of the JDK side implementation. I'm wondering if perhaps its time to change the above and move the curve database over to the JDK side? Mike At 11:41 AM 10/8/2013, Vincent Ryan wrote: >Currently, there is no public API for named curves. > >However you can generate named curves using the SunEC provider and the ECParameterSpec class. >For example, > > AlgorithmParameters parameters = AlgorithmParameters.getInstance("EC", "SunEC"); > parameters.init(new ECGenParameterSpec("secp256r1")); > ECParameterSpec ecParameters = parameters.getParameterSpec(ECParameterSpec.class); > > return KeyFactory.getInstance("EC", "SunEC").generatePublic(new ECPublicKeySpec(new ECPoint(x, y), ecParameters)); > > >It's not elegant but the list of supported named curves can be extracted from the AlgorithmParameters.EC SupportedCurves >property. For example, > > String[] curves = Security.getProvider("SunEC") > .getProperty("AlgorithmParameters.EC SupportedCurves") > .split("\\|"); > for (String curve : curves) { > System.out.println(curve.substring(1, curve.indexOf(","))); > } > > > > >On 8 Oct 2013, at 13:53, Anders Rundgren wrote: > >> If you have the X and Y points and the name of a public key you can create a ECPublicKey using BouncyCastle. >> I cannot find any counterpart in JDK 7. What am I missing? >> >> BC: >> >> return KeyFactory.getInstance ("EC").generatePublic (new ECPublicKeySpec (new ECPoint (x, y), new ECNamedCurveSpec (name,...))); >> >> Cheers >> Anders From vincent.x.ryan at oracle.com Tue Oct 8 17:38:50 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 8 Oct 2013 18:38:50 +0100 Subject: Creating an EC Public Key using Named Curves In-Reply-To: <201310081656.r98GubCF028983@aserp1060.oracle.com> References: <52540044.5080704@gmail.com> <201310081656.r98GubCF028983@aserp1060.oracle.com> Message-ID: On 8 Oct 2013, at 17:56, Michael StJohns wrote: > I use this construct a lot, but there are a number of cases (e.g. where I'm trying to take an EC key and turn it into a structure to send to a smart card) where what I really need is to be able to produce an EllipticCurve (actually ECParamaterSpec) from a name. Are you seeking to extend the collection of supported named curve parameters? Because most of the well-known named curve parameters are already supported via the mechanism below. Adding more (to the SunEC and SunPKCS11 providers) is quite straight forward. Adding new classes to the JDK is more difficult and already too late for JDK 8. > > I started looking at why ECGenParameterSpec isn't currently a subclass of ECParameterSpec. I *think* this is because the curve table is currently part of the individual EC providers rather than part of the JDK side implementation. True. The database of curve parameters is part of the SunEC provider. > > I'm wondering if perhaps its time to change the above and move the curve database over to the JDK side? > > Mike > > > > > > At 11:41 AM 10/8/2013, Vincent Ryan wrote: >> Currently, there is no public API for named curves. >> >> However you can generate named curves using the SunEC provider and the ECParameterSpec class. >> For example, >> >> AlgorithmParameters parameters = AlgorithmParameters.getInstance("EC", "SunEC"); >> parameters.init(new ECGenParameterSpec("secp256r1")); >> ECParameterSpec ecParameters = parameters.getParameterSpec(ECParameterSpec.class); >> >> return KeyFactory.getInstance("EC", "SunEC").generatePublic(new ECPublicKeySpec(new ECPoint(x, y), ecParameters)); >> >> >> It's not elegant but the list of supported named curves can be extracted from the AlgorithmParameters.EC SupportedCurves >> property. For example, >> >> String[] curves = Security.getProvider("SunEC") >> .getProperty("AlgorithmParameters.EC SupportedCurves") >> .split("\\|"); >> for (String curve : curves) { >> System.out.println(curve.substring(1, curve.indexOf(","))); >> } >> >> >> >> >> On 8 Oct 2013, at 13:53, Anders Rundgren wrote: >> >>> If you have the X and Y points and the name of a public key you can create a ECPublicKey using BouncyCastle. >>> I cannot find any counterpart in JDK 7. What am I missing? >>> >>> BC: >>> >>> return KeyFactory.getInstance ("EC").generatePublic (new ECPublicKeySpec (new ECPoint (x, y), new ECNamedCurveSpec (name,...))); >>> >>> Cheers >>> Anders > > From michael.fang at oracle.com Tue Oct 8 16:44:00 2013 From: michael.fang at oracle.com (michael.fang at oracle.com) Date: Tue, 08 Oct 2013 16:44:00 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20131008164405.D673462E49@hg.openjdk.java.net> Changeset: dbecbb685503 Author: mfang Date: 2013-10-08 09:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/dbecbb685503 8025215: jdk8 l10n resource file translation update 4 Reviewed-by: joehw, yhuang ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_de.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_es.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_fr.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_it.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ja.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ko.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_pt_BR.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_sv.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_CN.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_TW.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_de.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_es.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_fr.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_it.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ja.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ko.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_pt_BR.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sv.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_CN.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_TW.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_pt_BR.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_sv.java ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_TW.properties ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_de.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_es.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_fr.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_it.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_ja.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_ko.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_pt_BR.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_sv.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_CN.java ! src/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_TW.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_de.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_es.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_fr.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_it.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_ja.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_ko.java + src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_pt_BR.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_sv.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_zh_CN.java ! src/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_zh_TW.java ! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_es.java ! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_ja.java ! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_pt_BR.java ! src/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_sv.java Changeset: 1c074a0c2b97 Author: mfang Date: 2013-10-08 09:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1c074a0c2b97 Merge From vincent.x.ryan at oracle.com Tue Oct 8 18:14:28 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 8 Oct 2013 19:14:28 +0100 Subject: [8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class Message-ID: Please review the following change - it's a simple re-factoring to promote a nested class to a stand-alone class: Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008171 Webrev: http://cr.openjdk.java.net/~vinnie/8008171/webrev.00/ Thanks. From sean.mullan at oracle.com Tue Oct 8 18:33:24 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 08 Oct 2013 14:33:24 -0400 Subject: [8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class In-Reply-To: References: Message-ID: <52544FF4.7090609@oracle.com> Looks good to me. --Sean On 10/08/2013 02:14 PM, Vincent Ryan wrote: > Please review the following change - it's a simple re-factoring to promote a nested class to a stand-alone class: > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008171 > Webrev: http://cr.openjdk.java.net/~vinnie/8008171/webrev.00/ > > Thanks. > From mstjohns at comcast.net Tue Oct 8 19:14:41 2013 From: mstjohns at comcast.net (Michael StJohns) Date: Tue, 08 Oct 2013 15:14:41 -0400 Subject: Creating an EC Public Key using Named Curves In-Reply-To: References: <52540044.5080704@gmail.com> <201310081656.r98GubCF028983@aserp1060.oracle.com> Message-ID: <20131008191437.B3E2D6AE9@mail.openjdk.java.net> At 01:38 PM 10/8/2013, Vincent Ryan wrote: >On 8 Oct 2013, at 17:56, Michael StJohns wrote: > >> I use this construct a lot, but there are a number of cases (e.g. where I'm trying to take an EC key and turn it into a structure to send to a smart card) where what I really need is to be able to produce an EllipticCurve (actually ECParamaterSpec) from a name. > >Are you seeking to extend the collection of supported named curve parameters? >Because most of the well-known named curve parameters are already supported via the mechanism below. > >Adding more (to the SunEC and SunPKCS11 providers) is quite straight forward. >Adding new classes to the JDK is more difficult and already too late for JDK 8. Hi Vincent - No - this is about doing something like: int keyType; ECParameterSpec p256spec = .... ECParameterSpec p384spec = ... if (eckey.getParams().equals(p256spec)) keyType = p256Key; else if (eckey.getParams().equals(p384spec)) keyType = p384Key; else keyType = unknownKey; When creating a key (public or private) on a smart card, I don't want to have to pass over the whole curve data, just an indicator as to which curve to use to set the card parameters. The way I get around this now is to generate a key pair for each of those two curves (using the ECGenParameters construct), and then extract the params from one of the generated keys to set "p256spec" or "p384spec". This is a bit round about, but it works. The only other way to do this is to .encode() the original key and then parse the ASN1 to find the OID that identifies the curve. Again, round about but it works. >> >> I started looking at why ECGenParameterSpec isn't currently a subclass of ECParameterSpec. I *think* this is because the curve table is currently part of the individual EC providers rather than part of the JDK side implementation. > >True. The database of curve parameters is part of the SunEC provider. I'm not sure the curve database should or needs to be part of individual providers. Given that there is one and only one curve definition for any given OID, it might be useful to create a single common database of curves. It would mean that providers wouldn't have to repeat the same curve data (and possibly get it wrong). E.g. maybe promote most of sun.security.ec.NamedCurve to java.security.ECNamedCurve? Mike >> >> I'm wondering if perhaps its time to change the above and move the curve database over to the JDK side? >> >> Mike >> >> >> >> >> >> At 11:41 AM 10/8/2013, Vincent Ryan wrote: >>> Currently, there is no public API for named curves. >>> >>> However you can generate named curves using the SunEC provider and the ECParameterSpec class. >>> For example, >>> >>> AlgorithmParameters parameters = AlgorithmParameters.getInstance("EC", "SunEC"); >>> parameters.init(new ECGenParameterSpec("secp256r1")); >>> ECParameterSpec ecParameters = parameters.getParameterSpec(ECParameterSpec.class); >>> >>> return KeyFactory.getInstance("EC", "SunEC").generatePublic(new ECPublicKeySpec(new ECPoint(x, y), ecParameters)); >>> >>> >>> It's not elegant but the list of supported named curves can be extracted from the AlgorithmParameters.EC SupportedCurves >>> property. For example, >>> >>> String[] curves = Security.getProvider("SunEC") >>> .getProperty("AlgorithmParameters.EC SupportedCurves") >>> .split("\\|"); >>> for (String curve : curves) { >>> System.out.println(curve.substring(1, curve.indexOf(","))); >>> } >>> >>> >>> >>> >>> On 8 Oct 2013, at 13:53, Anders Rundgren wrote: >>> >>>> If you have the X and Y points and the name of a public key you can create a ECPublicKey using BouncyCastle. >>>> I cannot find any counterpart in JDK 7. What am I missing? >>>> >>>> BC: >>>> >>>> return KeyFactory.getInstance ("EC").generatePublic (new ECPublicKeySpec (new ECPoint (x, y), new ECNamedCurveSpec (name,...))); >>>> >>>> Cheers >>>> Anders >> >> From mstjohns at comcast.net Tue Oct 8 19:44:00 2013 From: mstjohns at comcast.net (Michael StJohns) Date: Tue, 08 Oct 2013 15:44:00 -0400 Subject: Creating an EC Public Key using Named Curves In-Reply-To: <7.1.0.9.2.20131008144016.088a5798@comcast.net> References: <52540044.5080704@gmail.com> <201310081656.r98GubCF028983@aserp1060.oracle.com> <7.1.0.9.2.20131008144016.088a5798@comcast.net> Message-ID: <20131008194356.918376B15@mail.openjdk.java.net> *sigh* I need to read emails a lot more closely. Ignore this - for some reason I was reading this as the key pair generation stuff rather than the parameter generation stuff. I'm going to try out this construct on BouncyCastle and see if it works for their curve tables. Mike At 03:14 PM 10/8/2013, Michael StJohns wrote: >At 01:38 PM 10/8/2013, Vincent Ryan wrote: > >>On 8 Oct 2013, at 17:56, Michael StJohns wrote: >> >>> I use this construct a lot, but there are a number of cases (e.g. where I'm trying to take an EC key and turn it into a structure to send to a smart card) where what I really need is to be able to produce an EllipticCurve (actually ECParamaterSpec) from a name. >> >>Are you seeking to extend the collection of supported named curve parameters? >>Because most of the well-known named curve parameters are already supported via the mechanism below. >> >>Adding more (to the SunEC and SunPKCS11 providers) is quite straight forward. >>Adding new classes to the JDK is more difficult and already too late for JDK 8. > >Hi Vincent - > >No - this is about doing something like: > >int keyType; > >ECParameterSpec p256spec = .... >ECParameterSpec p384spec = ... > >if (eckey.getParams().equals(p256spec)) > keyType = p256Key; >else if (eckey.getParams().equals(p384spec)) > keyType = p384Key; >else > keyType = unknownKey; > > >When creating a key (public or private) on a smart card, I don't want to have to pass over the whole curve data, just an indicator as to which curve to use to set the card parameters. > >The way I get around this now is to generate a key pair for each of those two curves (using the ECGenParameters construct), and then extract the params from one of the generated keys to set "p256spec" or "p384spec". This is a bit round about, but it works. > >The only other way to do this is to .encode() the original key and then parse the ASN1 to find the OID that identifies the curve. Again, round about but it works. > > > > > > >>> >>> I started looking at why ECGenParameterSpec isn't currently a subclass of ECParameterSpec. I *think* this is because the curve table is currently part of the individual EC providers rather than part of the JDK side implementation. >> >>True. The database of curve parameters is part of the SunEC provider. > >I'm not sure the curve database should or needs to be part of individual providers. Given that there is one and only one curve definition for any given OID, it might be useful to create a single common database of curves. It would mean that providers wouldn't have to repeat the same curve data (and possibly get it wrong). > >E.g. maybe promote most of sun.security.ec.NamedCurve to java.security.ECNamedCurve? > >Mike > > > >>> >>> I'm wondering if perhaps its time to change the above and move the curve database over to the JDK side? >>> >>> Mike >>> >>> >>> >>> >>> >>> At 11:41 AM 10/8/2013, Vincent Ryan wrote: >>>> Currently, there is no public API for named curves. >>>> >>>> However you can generate named curves using the SunEC provider and the ECParameterSpec class. >>>> For example, >>>> >>>> AlgorithmParameters parameters = AlgorithmParameters.getInstance("EC", "SunEC"); >>>> parameters.init(new ECGenParameterSpec("secp256r1")); >>>> ECParameterSpec ecParameters = parameters.getParameterSpec(ECParameterSpec.class); >>>> >>>> return KeyFactory.getInstance("EC", "SunEC").generatePublic(new ECPublicKeySpec(new ECPoint(x, y), ecParameters)); >>>> >>>> >>>> It's not elegant but the list of supported named curves can be extracted from the AlgorithmParameters.EC SupportedCurves >>>> property. For example, >>>> >>>> String[] curves = Security.getProvider("SunEC") >>>> .getProperty("AlgorithmParameters.EC SupportedCurves") >>>> .split("\\|"); >>>> for (String curve : curves) { >>>> System.out.println(curve.substring(1, curve.indexOf(","))); >>>> } >>>> >>>> >>>> >>>> >>>> On 8 Oct 2013, at 13:53, Anders Rundgren wrote: >>>> >>>>> If you have the X and Y points and the name of a public key you can create a ECPublicKey using BouncyCastle. >>>>> I cannot find any counterpart in JDK 7. What am I missing? >>>>> >>>>> BC: >>>>> >>>>> return KeyFactory.getInstance ("EC").generatePublic (new ECPublicKeySpec (new ECPoint (x, y), new ECNamedCurveSpec (name,...))); >>>>> >>>>> Cheers >>>>> Anders >>> >>> From anders.rundgren.net at gmail.com Tue Oct 8 19:49:26 2013 From: anders.rundgren.net at gmail.com (Anders Rundgren) Date: Tue, 08 Oct 2013 21:49:26 +0200 Subject: Creating an EC Public Key using Named Curves In-Reply-To: References: <52540044.5080704@gmail.com> Message-ID: <525461C6.8000308@gmail.com> On 2013-10-08 17:41, Vincent Ryan wrote: > Currently, there is no public API for named curves. > > However you can generate named curves using the SunEC provider and the ECParameterSpec class. > For example, > > AlgorithmParameters parameters = AlgorithmParameters.getInstance("EC", "SunEC"); > parameters.init(new ECGenParameterSpec("secp256r1")); > ECParameterSpec ecParameters = parameters.getParameterSpec(ECParameterSpec.class); > > return KeyFactory.getInstance("EC", "SunEC").generatePublic(new ECPublicKeySpec(new ECPoint(x, y), ecParameters)); > > > It's not elegant but the list of supported named curves can be extracted from the AlgorithmParameters.EC SupportedCurves > property. For example, > > String[] curves = Security.getProvider("SunEC") > .getProperty("AlgorithmParameters.EC SupportedCurves") > .split("\\|"); > for (String curve : curves) { > System.out.println(curve.substring(1, curve.indexOf(","))); > } Thanx Vicent, I guess this is new for JDK 7. Unfortunately I seem to be stuck with BC because a serialized named ECPublicKey in JDK 7 uses a different (and IMHO incorrect) format which makes it impossible to sign a public key in an interoperable way. Note: I used Oracle's JDK 7 on Windows but I assume it is the same for OpenJDK. thanx Anders Rundgren > > > > > On 8 Oct 2013, at 13:53, Anders Rundgren wrote: > >> If you have the X and Y points and the name of a public key you can create a ECPublicKey using BouncyCastle. >> I cannot find any counterpart in JDK 7. What am I missing? >> >> BC: >> >> return KeyFactory.getInstance ("EC").generatePublic (new ECPublicKeySpec (new ECPoint (x, y), new ECNamedCurveSpec (name,...))); >> >> Cheers >> Anders > From sean.mullan at oracle.com Tue Oct 8 19:52:34 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 08 Oct 2013 15:52:34 -0400 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access Message-ID: <52546282.50101@oracle.com> Please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8007292 This bug requires build changes and a new build tool to add additional restricted packages to the java.security file which are not part of OpenJDK. These packages are only added when doing a build including the open and closed sources. The restricted packages and new test are in the closed sources and will be reviewed separately. webrev: http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.00/ Thanks, Sean From mstjohns at comcast.net Tue Oct 8 20:14:45 2013 From: mstjohns at comcast.net (Michael StJohns) Date: Tue, 08 Oct 2013 16:14:45 -0400 Subject: Creating an EC Public Key using Named Curves In-Reply-To: <20131008194356.918376B15@mail.openjdk.java.net> References: <52540044.5080704@gmail.com> <201310081656.r98GubCF028983@aserp1060.oracle.com> <7.1.0.9.2.20131008144016.088a5798@comcast.net> <20131008194356.918376B15@mail.openjdk.java.net> Message-ID: <20131008201441.C809D6B46@mail.openjdk.java.net> At 03:44 PM 10/8/2013, Michael StJohns wrote: This fails using bouncy castle. There is no "EC" factory for AlgorithmParameters for BC 1.49. Mike >I'm going to try out this construct on BouncyCastle and see if it works for their curve tables. > >>>>> >>>>> However you can generate named curves using the SunEC provider and the ECParameterSpec class. >>>>> For example, >>>>> >>>>> AlgorithmParameters parameters = AlgorithmParameters.getInstance("EC", "SunEC"); >>>>> parameters.init(new ECGenParameterSpec("secp256r1")); >>>>> ECParameterSpec ecParameters = parameters.getParameterSpec(ECParameterSpec.class); From anders.rundgren.net at gmail.com Tue Oct 8 20:35:27 2013 From: anders.rundgren.net at gmail.com (Anders Rundgren) Date: Tue, 08 Oct 2013 22:35:27 +0200 Subject: Correction. Re: Creating an EC Public Key using Named Curves In-Reply-To: References: <52540044.5080704@gmail.com> Message-ID: <52546C8F.4040203@gmail.com> Pardon me. It was actually BC 1.45 which screw-up, not JDK 7. Anyway, the bottom line (for me as developer...) is that BC and JDK 7 are incompatible at the src level. thanx Anders On 2013-10-08 17:41, Vincent Ryan wrote: > Currently, there is no public API for named curves. > > However you can generate named curves using the SunEC provider and the ECParameterSpec class. > For example, > > AlgorithmParameters parameters = AlgorithmParameters.getInstance("EC", "SunEC"); > parameters.init(new ECGenParameterSpec("secp256r1")); > ECParameterSpec ecParameters = parameters.getParameterSpec(ECParameterSpec.class); > > return KeyFactory.getInstance("EC", "SunEC").generatePublic(new ECPublicKeySpec(new ECPoint(x, y), ecParameters)); > > > It's not elegant but the list of supported named curves can be extracted from the AlgorithmParameters.EC SupportedCurves > property. For example, > > String[] curves = Security.getProvider("SunEC") > .getProperty("AlgorithmParameters.EC SupportedCurves") > .split("\\|"); > for (String curve : curves) { > System.out.println(curve.substring(1, curve.indexOf(","))); > } Thanx Vicent, I guess this is new for JDK 7. Unfortunately I seem to be stuck with BC because a serialized named ECPublicKey in JDK 7 uses a different (and IMHO incorrect) format which makes it impossible to sign a public key in an interoperable way. Note: I used Oracle's JDK 7 on Windows but I assume it is the same for OpenJDK. thanx Anders Rundgren > > > > > On 8 Oct 2013, at 13:53, Anders Rundgren wrote: > >> If you have the X and Y points and the name of a public key you can create a ECPublicKey using BouncyCastle. >> I cannot find any counterpart in JDK 7. What am I missing? >> >> BC: >> >> return KeyFactory.getInstance ("EC").generatePublic (new ECPublicKeySpec (new ECPoint (x, y), new ECNamedCurveSpec (name,...))); >> >> Cheers >> Anders > From rob.mckenna at oracle.com Tue Oct 8 23:12:59 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Tue, 08 Oct 2013 23:12:59 +0000 Subject: hg: jdk8/tl/jdk: 7180557: InetAddress.getLocalHost throws UnknownHostException on java7u5 on OSX webbugs Message-ID: <20131008231322.E3E2662E6A@hg.openjdk.java.net> Changeset: f1e31376f419 Author: robm Date: 2013-10-09 00:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1e31376f419 7180557: InetAddress.getLocalHost throws UnknownHostException on java7u5 on OSX webbugs Reviewed-by: chegar, dsamersoff ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c From weijun.wang at oracle.com Wed Oct 9 00:51:02 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 09 Oct 2013 08:51:02 +0800 Subject: [8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class In-Reply-To: References: Message-ID: <5254A876.2040905@oracle.com> The code change looks fine. Do we need a CCC for it? Thanks Max p.s. I would use the bugs.openjdk.java.net URL. On 10/9/13 2:14 AM, Vincent Ryan wrote: > Please review the following change - it's a simple re-factoring to promote a nested class to a stand-alone class: > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008171 > Webrev: http://cr.openjdk.java.net/~vinnie/8008171/webrev.00/ > > Thanks. > From david.holmes at oracle.com Wed Oct 9 04:33:04 2013 From: david.holmes at oracle.com (David Holmes) Date: Wed, 09 Oct 2013 14:33:04 +1000 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access In-Reply-To: <52546282.50101@oracle.com> References: <52546282.50101@oracle.com> Message-ID: <5254DC80.3080305@oracle.com> Hi Sean, Not a full review. On 9/10/2013 5:52 AM, Sean Mullan wrote: > Please review the fix for the following bug: > > https://bugs.openjdk.java.net/browse/JDK-8007292 > > This bug requires build changes and a new build tool to add additional > restricted packages to the java.security file which are not part of > OpenJDK. These packages are only added when doing a build including the > open and closed sources. > > The restricted packages and new test are in the closed sources and will > be reviewed separately. > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.00/ Based on your description and the ifndef OPENJDK it sounds to me that this doesn't belong in the OpenJDK makefiles. That aside I would think the CP+RM could be changed to a MV. In the tool this code doesn't show correct use of try-with-resources: 51 try (BufferedReader br = new BufferedReader(new FileReader(args[0])); 52 BufferedWriter bw = new BufferedWriter(new FileWriter(args[1]))) { The FileReader and FileWriter should also be covered by TWR: try (FileReader fr = new FileReader(args[0]); BufferedReader br = new BufferedReader(fr); FileWriter fw = new FileWriter(args[1]); BufferedWriter bw = new BufferedWriter(fw)) { Finally do we still use make/tools/Makefile in the new build? David ----- > Thanks, > Sean From joel.franck at oracle.com Wed Oct 9 07:08:53 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Wed, 09 Oct 2013 07:08:53 +0000 Subject: hg: jdk8/tl/langtools: 8024415: Bug in javac Pretty: Wrong precedence in JCConditional trees Message-ID: <20131009070900.731AD62E73@hg.openjdk.java.net> Changeset: ea000904db62 Author: alundblad Date: 2013-10-08 15:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ea000904db62 8024415: Bug in javac Pretty: Wrong precedence in JCConditional trees Summary: Fixed precedence and associativity issues with pretty printing of JCConditional expressions. Reviewed-by: jfranck Contributed-by: Andreas Lundblad , Matthew Dempsky ! src/share/classes/com/sun/tools/javac/tree/Pretty.java + test/tools/javac/tree/T8024415.java From vincent.x.ryan at oracle.com Wed Oct 9 08:03:40 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 9 Oct 2013 09:03:40 +0100 Subject: [8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class In-Reply-To: <52544FF4.7090609@oracle.com> References: <52544FF4.7090609@oracle.com> Message-ID: <515D5A84-70F4-4681-9869-7E3F70F7AD8E@oracle.com> Thanks. On 8 Oct 2013, at 19:33, Sean Mullan wrote: > Looks good to me. > > --Sean > > On 10/08/2013 02:14 PM, Vincent Ryan wrote: >> Please review the following change - it's a simple re-factoring to promote a nested class to a stand-alone class: >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008171 >> Webrev: http://cr.openjdk.java.net/~vinnie/8008171/webrev.00/ >> >> Thanks. >> > From alan.bateman at oracle.com Wed Oct 9 08:23:36 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 09 Oct 2013 08:23:36 +0000 Subject: hg: jdk8/tl/jdk: 8008662: Add @jdk.Exported to JDK-specific/exported APIs Message-ID: <20131009082348.AE9D462E76@hg.openjdk.java.net> Changeset: 2ea162b2ff55 Author: alanb Date: 2013-10-09 09:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ea162b2ff55 8008662: Add @jdk.Exported to JDK-specific/exported APIs Reviewed-by: chegar, vinnie, dfuchs, mchung, mullan, darcy ! src/share/classes/com/sun/jdi/AbsentInformationException.java ! src/share/classes/com/sun/jdi/Accessible.java ! src/share/classes/com/sun/jdi/ArrayReference.java ! src/share/classes/com/sun/jdi/ArrayType.java ! src/share/classes/com/sun/jdi/BooleanType.java ! src/share/classes/com/sun/jdi/BooleanValue.java ! src/share/classes/com/sun/jdi/Bootstrap.java ! src/share/classes/com/sun/jdi/ByteType.java ! src/share/classes/com/sun/jdi/ByteValue.java ! src/share/classes/com/sun/jdi/CharType.java ! src/share/classes/com/sun/jdi/CharValue.java ! src/share/classes/com/sun/jdi/ClassLoaderReference.java ! src/share/classes/com/sun/jdi/ClassNotLoadedException.java ! src/share/classes/com/sun/jdi/ClassNotPreparedException.java ! src/share/classes/com/sun/jdi/ClassObjectReference.java ! src/share/classes/com/sun/jdi/ClassType.java ! src/share/classes/com/sun/jdi/DoubleType.java ! src/share/classes/com/sun/jdi/DoubleValue.java ! src/share/classes/com/sun/jdi/Field.java ! src/share/classes/com/sun/jdi/FloatType.java ! src/share/classes/com/sun/jdi/FloatValue.java ! src/share/classes/com/sun/jdi/IncompatibleThreadStateException.java ! src/share/classes/com/sun/jdi/InconsistentDebugInfoException.java ! src/share/classes/com/sun/jdi/IntegerType.java ! src/share/classes/com/sun/jdi/IntegerValue.java ! src/share/classes/com/sun/jdi/InterfaceType.java ! src/share/classes/com/sun/jdi/InternalException.java ! src/share/classes/com/sun/jdi/InvalidCodeIndexException.java ! src/share/classes/com/sun/jdi/InvalidLineNumberException.java ! src/share/classes/com/sun/jdi/InvalidStackFrameException.java ! src/share/classes/com/sun/jdi/InvalidTypeException.java ! src/share/classes/com/sun/jdi/InvocationException.java ! src/share/classes/com/sun/jdi/JDIPermission.java ! src/share/classes/com/sun/jdi/LocalVariable.java ! src/share/classes/com/sun/jdi/Locatable.java ! src/share/classes/com/sun/jdi/Location.java ! src/share/classes/com/sun/jdi/LongType.java ! src/share/classes/com/sun/jdi/LongValue.java ! src/share/classes/com/sun/jdi/Method.java ! src/share/classes/com/sun/jdi/Mirror.java ! src/share/classes/com/sun/jdi/MonitorInfo.java ! src/share/classes/com/sun/jdi/NativeMethodException.java ! src/share/classes/com/sun/jdi/ObjectCollectedException.java ! src/share/classes/com/sun/jdi/ObjectReference.java ! src/share/classes/com/sun/jdi/PathSearchingVirtualMachine.java ! src/share/classes/com/sun/jdi/PrimitiveType.java ! src/share/classes/com/sun/jdi/PrimitiveValue.java ! src/share/classes/com/sun/jdi/ReferenceType.java ! src/share/classes/com/sun/jdi/ShortType.java ! src/share/classes/com/sun/jdi/ShortValue.java ! src/share/classes/com/sun/jdi/StackFrame.java ! src/share/classes/com/sun/jdi/StringReference.java ! src/share/classes/com/sun/jdi/ThreadGroupReference.java ! src/share/classes/com/sun/jdi/ThreadReference.java ! src/share/classes/com/sun/jdi/Type.java ! src/share/classes/com/sun/jdi/TypeComponent.java ! src/share/classes/com/sun/jdi/VMCannotBeModifiedException.java ! src/share/classes/com/sun/jdi/VMDisconnectedException.java ! src/share/classes/com/sun/jdi/VMMismatchException.java ! src/share/classes/com/sun/jdi/VMOutOfMemoryException.java ! src/share/classes/com/sun/jdi/Value.java ! src/share/classes/com/sun/jdi/VirtualMachine.java ! src/share/classes/com/sun/jdi/VirtualMachineManager.java ! src/share/classes/com/sun/jdi/VoidType.java ! src/share/classes/com/sun/jdi/VoidValue.java ! src/share/classes/com/sun/jdi/connect/AttachingConnector.java ! src/share/classes/com/sun/jdi/connect/Connector.java ! src/share/classes/com/sun/jdi/connect/IllegalConnectorArgumentsException.java ! src/share/classes/com/sun/jdi/connect/LaunchingConnector.java ! src/share/classes/com/sun/jdi/connect/ListeningConnector.java ! src/share/classes/com/sun/jdi/connect/Transport.java ! src/share/classes/com/sun/jdi/connect/TransportTimeoutException.java ! src/share/classes/com/sun/jdi/connect/VMStartException.java + src/share/classes/com/sun/jdi/connect/package-info.java - src/share/classes/com/sun/jdi/connect/package.html ! src/share/classes/com/sun/jdi/connect/spi/ClosedConnectionException.java ! src/share/classes/com/sun/jdi/connect/spi/Connection.java ! src/share/classes/com/sun/jdi/connect/spi/TransportService.java + src/share/classes/com/sun/jdi/connect/spi/package-info.java - src/share/classes/com/sun/jdi/connect/spi/package.html ! src/share/classes/com/sun/jdi/event/AccessWatchpointEvent.java ! src/share/classes/com/sun/jdi/event/BreakpointEvent.java ! src/share/classes/com/sun/jdi/event/ClassPrepareEvent.java ! src/share/classes/com/sun/jdi/event/ClassUnloadEvent.java ! src/share/classes/com/sun/jdi/event/Event.java ! src/share/classes/com/sun/jdi/event/EventIterator.java ! src/share/classes/com/sun/jdi/event/EventQueue.java ! src/share/classes/com/sun/jdi/event/EventSet.java ! src/share/classes/com/sun/jdi/event/ExceptionEvent.java ! src/share/classes/com/sun/jdi/event/LocatableEvent.java ! src/share/classes/com/sun/jdi/event/MethodEntryEvent.java ! src/share/classes/com/sun/jdi/event/MethodExitEvent.java ! src/share/classes/com/sun/jdi/event/ModificationWatchpointEvent.java ! src/share/classes/com/sun/jdi/event/MonitorContendedEnterEvent.java ! src/share/classes/com/sun/jdi/event/MonitorContendedEnteredEvent.java ! src/share/classes/com/sun/jdi/event/MonitorWaitEvent.java ! src/share/classes/com/sun/jdi/event/MonitorWaitedEvent.java ! src/share/classes/com/sun/jdi/event/StepEvent.java ! src/share/classes/com/sun/jdi/event/ThreadDeathEvent.java ! src/share/classes/com/sun/jdi/event/ThreadStartEvent.java ! src/share/classes/com/sun/jdi/event/VMDeathEvent.java ! src/share/classes/com/sun/jdi/event/VMDisconnectEvent.java ! src/share/classes/com/sun/jdi/event/VMStartEvent.java ! src/share/classes/com/sun/jdi/event/WatchpointEvent.java + src/share/classes/com/sun/jdi/event/package-info.java - src/share/classes/com/sun/jdi/event/package.html + src/share/classes/com/sun/jdi/package-info.java - src/share/classes/com/sun/jdi/package.html ! src/share/classes/com/sun/jdi/request/AccessWatchpointRequest.java ! src/share/classes/com/sun/jdi/request/BreakpointRequest.java ! src/share/classes/com/sun/jdi/request/ClassPrepareRequest.java ! src/share/classes/com/sun/jdi/request/ClassUnloadRequest.java ! src/share/classes/com/sun/jdi/request/DuplicateRequestException.java ! src/share/classes/com/sun/jdi/request/EventRequest.java ! src/share/classes/com/sun/jdi/request/EventRequestManager.java ! src/share/classes/com/sun/jdi/request/ExceptionRequest.java ! src/share/classes/com/sun/jdi/request/InvalidRequestStateException.java ! src/share/classes/com/sun/jdi/request/MethodEntryRequest.java ! src/share/classes/com/sun/jdi/request/MethodExitRequest.java ! src/share/classes/com/sun/jdi/request/ModificationWatchpointRequest.java ! src/share/classes/com/sun/jdi/request/MonitorContendedEnterRequest.java ! src/share/classes/com/sun/jdi/request/MonitorContendedEnteredRequest.java ! src/share/classes/com/sun/jdi/request/MonitorWaitRequest.java ! src/share/classes/com/sun/jdi/request/MonitorWaitedRequest.java ! src/share/classes/com/sun/jdi/request/StepRequest.java ! src/share/classes/com/sun/jdi/request/ThreadDeathRequest.java ! src/share/classes/com/sun/jdi/request/ThreadStartRequest.java ! src/share/classes/com/sun/jdi/request/VMDeathRequest.java ! src/share/classes/com/sun/jdi/request/WatchpointRequest.java + src/share/classes/com/sun/jdi/request/package-info.java - src/share/classes/com/sun/jdi/request/package.html ! src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java ! src/share/classes/com/sun/management/GarbageCollectorMXBean.java ! src/share/classes/com/sun/management/GcInfo.java ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/com/sun/management/OperatingSystemMXBean.java ! src/share/classes/com/sun/management/ThreadMXBean.java ! src/share/classes/com/sun/management/UnixOperatingSystemMXBean.java ! src/share/classes/com/sun/management/VMOption.java + src/share/classes/com/sun/management/package-info.java - src/share/classes/com/sun/management/package.html ! src/share/classes/com/sun/net/httpserver/Authenticator.java ! src/share/classes/com/sun/net/httpserver/BasicAuthenticator.java ! src/share/classes/com/sun/net/httpserver/Filter.java ! src/share/classes/com/sun/net/httpserver/Headers.java ! src/share/classes/com/sun/net/httpserver/HttpContext.java ! src/share/classes/com/sun/net/httpserver/HttpExchange.java ! src/share/classes/com/sun/net/httpserver/HttpHandler.java ! src/share/classes/com/sun/net/httpserver/HttpPrincipal.java ! src/share/classes/com/sun/net/httpserver/HttpServer.java ! src/share/classes/com/sun/net/httpserver/HttpsConfigurator.java ! src/share/classes/com/sun/net/httpserver/HttpsExchange.java ! src/share/classes/com/sun/net/httpserver/HttpsParameters.java ! src/share/classes/com/sun/net/httpserver/HttpsServer.java ! src/share/classes/com/sun/net/httpserver/package-info.java ! src/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java ! src/share/classes/com/sun/net/httpserver/spi/package-info.java ! src/share/classes/com/sun/nio/sctp/AbstractNotificationHandler.java ! src/share/classes/com/sun/nio/sctp/Association.java ! src/share/classes/com/sun/nio/sctp/AssociationChangeNotification.java ! src/share/classes/com/sun/nio/sctp/HandlerResult.java ! src/share/classes/com/sun/nio/sctp/IllegalReceiveException.java ! src/share/classes/com/sun/nio/sctp/IllegalUnbindException.java ! src/share/classes/com/sun/nio/sctp/InvalidStreamException.java ! src/share/classes/com/sun/nio/sctp/MessageInfo.java ! src/share/classes/com/sun/nio/sctp/Notification.java ! src/share/classes/com/sun/nio/sctp/NotificationHandler.java ! src/share/classes/com/sun/nio/sctp/PeerAddressChangeNotification.java ! src/share/classes/com/sun/nio/sctp/SctpChannel.java ! src/share/classes/com/sun/nio/sctp/SctpMultiChannel.java ! src/share/classes/com/sun/nio/sctp/SctpServerChannel.java ! src/share/classes/com/sun/nio/sctp/SctpSocketOption.java ! src/share/classes/com/sun/nio/sctp/SctpStandardSocketOptions.java ! src/share/classes/com/sun/nio/sctp/SendFailedNotification.java ! src/share/classes/com/sun/nio/sctp/ShutdownNotification.java ! src/share/classes/com/sun/nio/sctp/package-info.java ! src/share/classes/com/sun/security/auth/LdapPrincipal.java ! src/share/classes/com/sun/security/auth/NTDomainPrincipal.java ! src/share/classes/com/sun/security/auth/NTNumericCredential.java ! src/share/classes/com/sun/security/auth/NTSid.java ! src/share/classes/com/sun/security/auth/NTSidDomainPrincipal.java ! src/share/classes/com/sun/security/auth/NTSidGroupPrincipal.java ! src/share/classes/com/sun/security/auth/NTSidPrimaryGroupPrincipal.java ! src/share/classes/com/sun/security/auth/NTSidUserPrincipal.java ! src/share/classes/com/sun/security/auth/NTUserPrincipal.java ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/PrincipalComparator.java ! src/share/classes/com/sun/security/auth/SolarisNumericGroupPrincipal.java ! src/share/classes/com/sun/security/auth/SolarisNumericUserPrincipal.java ! src/share/classes/com/sun/security/auth/SolarisPrincipal.java ! src/share/classes/com/sun/security/auth/UnixNumericGroupPrincipal.java ! src/share/classes/com/sun/security/auth/UnixNumericUserPrincipal.java ! src/share/classes/com/sun/security/auth/UnixPrincipal.java ! src/share/classes/com/sun/security/auth/UserPrincipal.java ! src/share/classes/com/sun/security/auth/X500Principal.java ! src/share/classes/com/sun/security/auth/callback/DialogCallbackHandler.java ! src/share/classes/com/sun/security/auth/callback/TextCallbackHandler.java + src/share/classes/com/sun/security/auth/callback/package-info.java ! src/share/classes/com/sun/security/auth/login/ConfigFile.java + src/share/classes/com/sun/security/auth/login/package-info.java ! src/share/classes/com/sun/security/auth/module/JndiLoginModule.java ! src/share/classes/com/sun/security/auth/module/KeyStoreLoginModule.java ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java ! src/share/classes/com/sun/security/auth/module/LdapLoginModule.java ! src/share/classes/com/sun/security/auth/module/NTLoginModule.java ! src/share/classes/com/sun/security/auth/module/NTSystem.java ! src/share/classes/com/sun/security/auth/module/SolarisLoginModule.java ! src/share/classes/com/sun/security/auth/module/SolarisSystem.java ! src/share/classes/com/sun/security/auth/module/UnixLoginModule.java ! src/share/classes/com/sun/security/auth/module/UnixSystem.java + src/share/classes/com/sun/security/auth/module/package-info.java + src/share/classes/com/sun/security/auth/package-info.java ! src/share/classes/com/sun/security/jgss/AuthorizationDataEntry.java ! src/share/classes/com/sun/security/jgss/ExtendedGSSContext.java ! src/share/classes/com/sun/security/jgss/ExtendedGSSCredential.java ! src/share/classes/com/sun/security/jgss/GSSUtil.java ! src/share/classes/com/sun/security/jgss/InquireSecContextPermission.java ! src/share/classes/com/sun/security/jgss/InquireType.java + src/share/classes/com/sun/security/jgss/package-info.java ! src/share/classes/com/sun/tools/attach/AgentInitializationException.java ! src/share/classes/com/sun/tools/attach/AgentLoadException.java ! src/share/classes/com/sun/tools/attach/AttachNotSupportedException.java ! src/share/classes/com/sun/tools/attach/AttachPermission.java ! src/share/classes/com/sun/tools/attach/VirtualMachine.java ! src/share/classes/com/sun/tools/attach/VirtualMachineDescriptor.java + src/share/classes/com/sun/tools/attach/package-info.java - src/share/classes/com/sun/tools/attach/package.html ! src/share/classes/com/sun/tools/attach/spi/AttachProvider.java + src/share/classes/com/sun/tools/attach/spi/package-info.java - src/share/classes/com/sun/tools/attach/spi/package.html ! src/share/classes/com/sun/tools/jconsole/JConsoleContext.java ! src/share/classes/com/sun/tools/jconsole/JConsolePlugin.java + src/share/classes/com/sun/tools/jconsole/package-info.java - src/share/classes/com/sun/tools/jconsole/package.html ! src/solaris/classes/com/sun/management/OSMBeanFactory.java From vincent.x.ryan at oracle.com Wed Oct 9 09:02:24 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 9 Oct 2013 10:02:24 +0100 Subject: [8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class In-Reply-To: <5254A876.2040905@oracle.com> References: <5254A876.2040905@oracle.com> Message-ID: Thanks Max. On 9 Oct 2013, at 01:51, Weijun Wang wrote: > The code change looks fine. Do we need a CCC for it? Yes. CCC has been approved. > > Thanks > Max > > p.s. I would use the bugs.openjdk.java.net URL. Right. My webrev generates the old URL by default. I've changed it to use OpenJDK in future. > > On 10/9/13 2:14 AM, Vincent Ryan wrote: >> Please review the following change - it's a simple re-factoring to promote a nested class to a stand-alone class: >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008171 >> Webrev: http://cr.openjdk.java.net/~vinnie/8008171/webrev.00/ >> >> Thanks. >> From erik.joelsson at oracle.com Wed Oct 9 09:14:26 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 09 Oct 2013 11:14:26 +0200 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access In-Reply-To: <5254DC80.3080305@oracle.com> References: <52546282.50101@oracle.com> <5254DC80.3080305@oracle.com> Message-ID: <52551E72.9030605@oracle.com> Hello Sean, On 2013-10-09 06:33, David Holmes wrote: > Hi Sean, > > Not a full review. > > On 9/10/2013 5:52 AM, Sean Mullan wrote: >> Please review the fix for the following bug: >> >> https://bugs.openjdk.java.net/browse/JDK-8007292 >> >> This bug requires build changes and a new build tool to add additional >> restricted packages to the java.security file which are not part of >> OpenJDK. These packages are only added when doing a build including the >> open and closed sources. >> >> The restricted packages and new test are in the closed sources and will >> be reviewed separately. >> >> webrev: http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.00/ > > Based on your description and the ifndef OPENJDK it sounds to me that > this doesn't belong in the OpenJDK makefiles. > I agree in principle, but the pattern on how to handle this isn't well established yet and something we need to improve on. In this case we would need to make changes on the open side anyway to provide hooks for overrides of the behavior. I'm willing to accept this for now. > That aside I would think the CP+RM could be changed to a MV. Agreed. I would prefer the TOOL_ADDTO... line to be moved to jdk/makefiles/Tools.gmk with the other similar definitions, even if it is only used here atm. > > In the tool this code doesn't show correct use of try-with-resources: > > 51 try (BufferedReader br = new BufferedReader(new > FileReader(args[0])); > 52 BufferedWriter bw = new BufferedWriter(new > FileWriter(args[1]))) { > > The FileReader and FileWriter should also be covered by TWR: > > try (FileReader fr = new FileReader(args[0]); > BufferedReader br = new BufferedReader(fr); > FileWriter fw = new FileWriter(args[1]); > BufferedWriter bw = new BufferedWriter(fw)) { > I'm not familiar with the try-with-resources, but calling close on a BufferedReader/writer will close the underlying reader/writer so nothing will be left open, will it not? > > Finally do we still use make/tools/Makefile in the new build? > No, we don't. If you want to add old build support for this, you would also need to add usage of the tool to the correct old makefile. /Erik From vincent.x.ryan at oracle.com Wed Oct 9 10:50:46 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Wed, 09 Oct 2013 10:50:46 +0000 Subject: hg: jdk8/tl/jdk: 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class Message-ID: <20131009105101.6D73A62E7F@hg.openjdk.java.net> Changeset: 91a752e3d50b Author: vinnie Date: 2013-10-09 10:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91a752e3d50b 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class Reviewed-by: mullan, weijun + src/share/classes/java/security/DomainLoadStoreParameter.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/sun/security/provider/DomainKeyStore.java ! test/sun/security/provider/KeyStore/DKSTest.java From jan.lahoda at oracle.com Wed Oct 9 11:13:15 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Wed, 09 Oct 2013 11:13:15 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20131009111321.C1A1D62E81@hg.openjdk.java.net> Changeset: 0be3f1820e8b Author: jlahoda Date: 2013-10-09 13:06 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0be3f1820e8b 8025141: java.lang.ClassFormatError: Illegal field modifiers in class (...) Summary: Should not generate non-public $assertionsDisabled field into interfaces Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/defaultMethods/Assertions.java + test/tools/javac/defaultMethods/CannotChangeAssertionsStateAfterInitialized.java Changeset: 1b469fd31e35 Author: jlahoda Date: 2013-10-09 13:09 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1b469fd31e35 8025087: Annotation processing api returns default modifier for interface static method Summary: ClassReader must not set Flags.DEFAULT for interface static methods Reviewed-by: vromero, jjg ! make/build.xml ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/defaultMethods/BadClassfile.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/InvalidDefaultInterface/InvalidDefaultInterface.java + test/tools/javac/diags/examples/InvalidDefaultInterface/processors/CreateBadClassFile.java + test/tools/javac/diags/examples/InvalidStaticInterface/InvalidStaticInterface.java + test/tools/javac/diags/examples/InvalidStaticInterface/processors/CreateBadClassFile.java ! test/tools/javac/processing/model/element/TestExecutableElement.java From sundararajan.athijegannathan at oracle.com Wed Oct 9 13:08:35 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 09 Oct 2013 13:08:35 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20131009130838.EBB9962E8A@hg.openjdk.java.net> Changeset: 8d29733ad609 Author: sundar Date: 2013-10-09 10:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8d29733ad609 8026112: Function("with(x ? 1e81 : (x2.constructor = 0.1)){}") throws AssertionError: double is not compatible with object Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8026112.js Changeset: 1e03d7caa68b Author: sundar Date: 2013-10-09 13:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1e03d7caa68b 8026125: Array.prototype.slice.call(Java.type("java.util.HashMap")) throws ClassCastException: jdk.internal.dynalink.beans.StaticClass cannot be cast to jdk.nashorn.internal.runtime.ScriptObject Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8026125.js Changeset: ec3094d9d5d5 Author: hannesw Date: 2013-10-09 14:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ec3094d9d5d5 8026008: Constant folding removes var statement Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/codegen/FoldConstants.java + test/script/basic/JDK-8026008.js + test/script/basic/JDK-8026008.js.EXPECTED From sean.mullan at oracle.com Wed Oct 9 13:20:50 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 09 Oct 2013 09:20:50 -0400 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access In-Reply-To: <52551E72.9030605@oracle.com> References: <52546282.50101@oracle.com> <5254DC80.3080305@oracle.com> <52551E72.9030605@oracle.com> Message-ID: <52555832.1080907@oracle.com> On 10/09/2013 05:14 AM, Erik Joelsson wrote: > Hello Sean, > > On 2013-10-09 06:33, David Holmes wrote: >> Hi Sean, >> >> Not a full review. >> >> On 9/10/2013 5:52 AM, Sean Mullan wrote: >>> Please review the fix for the following bug: >>> >>> https://bugs.openjdk.java.net/browse/JDK-8007292 >>> >>> This bug requires build changes and a new build tool to add additional >>> restricted packages to the java.security file which are not part of >>> OpenJDK. These packages are only added when doing a build including the >>> open and closed sources. >>> >>> The restricted packages and new test are in the closed sources and will >>> be reviewed separately. >>> >>> webrev: http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.00/ >> >> Based on your description and the ifndef OPENJDK it sounds to me that >> this doesn't belong in the OpenJDK makefiles. >> > I agree in principle, but the pattern on how to handle this isn't well > established yet and something we need to improve on. In this case we > would need to make changes on the open side anyway to provide hooks for > overrides of the behavior. I'm willing to accept this for now. Thanks. Also, keep in mind that this hook allows each vendor,etc to add additional proprietary or internal packages to the restricted packages properties for their own build. So I think it is useful in general in that respect. >> That aside I would think the CP+RM could be changed to a MV. > Agreed. Right. Will do. > I would prefer the TOOL_ADDTO... line to be moved to > jdk/makefiles/Tools.gmk with the other similar definitions, even if it > is only used here atm. Ok. >> In the tool this code doesn't show correct use of try-with-resources: >> >> 51 try (BufferedReader br = new BufferedReader(new >> FileReader(args[0])); >> 52 BufferedWriter bw = new BufferedWriter(new >> FileWriter(args[1]))) { >> >> The FileReader and FileWriter should also be covered by TWR: >> >> try (FileReader fr = new FileReader(args[0]); >> BufferedReader br = new BufferedReader(fr); >> FileWriter fw = new FileWriter(args[1]); >> BufferedWriter bw = new BufferedWriter(fw)) { >> > I'm not familiar with the try-with-resources, but calling close on a > BufferedReader/writer will close the underlying reader/writer so nothing > will be left open, will it not? That's what I thought as well. David? >> Finally do we still use make/tools/Makefile in the new build? >> > No, we don't. If you want to add old build support for this, you would > also need to add usage of the tool to the correct old makefile. I don't think it's necessary to add this to the old build at this point. I'll post another webrev later in the day with these updates. Thanks, Sean From paul.sandoz at oracle.com Wed Oct 9 13:20:46 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Wed, 09 Oct 2013 13:20:46 +0000 Subject: hg: jdk8/tl/jdk: 8020061: Clarify reporting characteristics between splits Message-ID: <20131009132111.4767F62E8D@hg.openjdk.java.net> Changeset: 1cd20806fd5c Author: psandoz Date: 2013-10-09 15:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1cd20806fd5c 8020061: Clarify reporting characteristics between splits Reviewed-by: alanb, chegar ! src/share/classes/java/util/Spliterator.java From mandy.chung at oracle.com Wed Oct 9 13:27:21 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 09 Oct 2013 13:27:21 +0000 Subject: hg: jdk8/tl/jdk: 8026027: Level.parse should return the custom Level instance instead of the mirrored Level Message-ID: <20131009132733.D27DC62E8E@hg.openjdk.java.net> Changeset: cf6e39cfdf50 Author: mchung Date: 2013-10-09 06:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf6e39cfdf50 8026027: Level.parse should return the custom Level instance instead of the mirrored Level Reviewed-by: dfuchs, chegar ! src/share/classes/java/util/logging/Level.java + test/java/util/logging/Level/CustomLevel.java + test/java/util/logging/Level/myresource.properties From roger.riggs at oracle.com Wed Oct 9 15:07:08 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Wed, 09 Oct 2013 15:07:08 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131009150735.2783B62E95@hg.openjdk.java.net> Changeset: e3b70e601c1c Author: rriggs Date: 2013-10-09 11:02 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3b70e601c1c 8024612: java/time/tck/java/time/format/TCKDateTimeFormatters.java failed Summary: The test should be using the Locale.Category.FORMAT to verify the test data Reviewed-by: lancea ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java Changeset: 09e2a73aa1dc Author: rriggs Date: 2013-09-26 15:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09e2a73aa1dc 8025718: Enhance error messages for parsing Summary: Add values and types to exception messages Reviewed-by: lancea Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/format/Parsed.java ! test/java/time/test/java/time/format/TestDateTimeFormatter.java From anders.rundgren.net at gmail.com Wed Oct 9 15:18:49 2013 From: anders.rundgren.net at gmail.com (Anders Rundgren) Date: Wed, 09 Oct 2013 17:18:49 +0200 Subject: Creating an EC Public Key using Named Curves In-Reply-To: References: <52540044.5080704@gmail.com> Message-ID: <525573D9.9090306@gmail.com> On 2013-10-08 17:41, Vincent Ryan wrote: > Currently, there is no public API for named curves. Since I wanted a source-compatible BC, JDK 6-7, and Android solution, I ended-up using public key samples instead: ECParameterSpec spec = ((ECPublicKey) KeyFactory.getInstance ("EC").generatePublic (new X509EncodedKeySpec (sample_public_key))).getParams (); https://code.google.com/p/openkeystore/source/browse/library/trunk/src/org/webpki/crypto/KeyAlgorithms.java It is not pretty but since it is one-time op I can (probably) live with it. Anders > > However you can generate named curves using the SunEC provider and the ECParameterSpec class. > For example, > > AlgorithmParameters parameters = AlgorithmParameters.getInstance("EC", "SunEC"); > parameters.init(new ECGenParameterSpec("secp256r1")); > ECParameterSpec ecParameters = parameters.getParameterSpec(ECParameterSpec.class); > > return KeyFactory.getInstance("EC", "SunEC").generatePublic(new ECPublicKeySpec(new ECPoint(x, y), ecParameters)); > > > It's not elegant but the list of supported named curves can be extracted from the AlgorithmParameters.EC SupportedCurves > property. For example, > > String[] curves = Security.getProvider("SunEC") > .getProperty("AlgorithmParameters.EC SupportedCurves") > .split("\\|"); > for (String curve : curves) { > System.out.println(curve.substring(1, curve.indexOf(","))); > } > > > > > On 8 Oct 2013, at 13:53, Anders Rundgren wrote: > >> If you have the X and Y points and the name of a public key you can create a ECPublicKey using BouncyCastle. >> I cannot find any counterpart in JDK 7. What am I missing? >> >> BC: >> >> return KeyFactory.getInstance ("EC").generatePublic (new ECPublicKeySpec (new ECPoint (x, y), new ECNamedCurveSpec (name,...))); >> >> Cheers >> Anders > From henry.jen at oracle.com Wed Oct 9 17:00:42 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Wed, 09 Oct 2013 17:00:42 +0000 Subject: hg: jdk8/tl/jdk: 8023524: Mechanism to dump generated lambda classes / log lambda code generation Message-ID: <20131009170105.2E54462E9D@hg.openjdk.java.net> Changeset: c070001c4f60 Author: henryjen Date: 2013-10-09 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c070001c4f60 8023524: Mechanism to dump generated lambda classes / log lambda code generation Reviewed-by: plevart, mchung, forax, jjb Contributed-by: brian.goetz at oracle.com, henry.jen at oracle.com ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + src/share/classes/java/lang/invoke/ProxyClassesDumper.java + test/java/lang/invoke/lambda/LogGeneratedClassesTest.java From sean.mullan at oracle.com Wed Oct 9 17:19:26 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 09 Oct 2013 13:19:26 -0400 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access In-Reply-To: <52555832.1080907@oracle.com> References: <52546282.50101@oracle.com> <5254DC80.3080305@oracle.com> <52551E72.9030605@oracle.com> <52555832.1080907@oracle.com> Message-ID: <5255901E.1020104@oracle.com> Updated webrev: http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.01/ Let me know if there are any more comments, otherwise I will plan to push tomorrow. Thanks, Sean On 10/09/2013 09:20 AM, Sean Mullan wrote: > On 10/09/2013 05:14 AM, Erik Joelsson wrote: >> Hello Sean, >> >> On 2013-10-09 06:33, David Holmes wrote: >>> Hi Sean, >>> >>> Not a full review. >>> >>> On 9/10/2013 5:52 AM, Sean Mullan wrote: >>>> Please review the fix for the following bug: >>>> >>>> https://bugs.openjdk.java.net/browse/JDK-8007292 >>>> >>>> This bug requires build changes and a new build tool to add additional >>>> restricted packages to the java.security file which are not part of >>>> OpenJDK. These packages are only added when doing a build including the >>>> open and closed sources. >>>> >>>> The restricted packages and new test are in the closed sources and will >>>> be reviewed separately. >>>> >>>> webrev: http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.00/ >>> >>> Based on your description and the ifndef OPENJDK it sounds to me that >>> this doesn't belong in the OpenJDK makefiles. >>> >> I agree in principle, but the pattern on how to handle this isn't well >> established yet and something we need to improve on. In this case we >> would need to make changes on the open side anyway to provide hooks for >> overrides of the behavior. I'm willing to accept this for now. > > Thanks. Also, keep in mind that this hook allows each vendor,etc to add > additional proprietary or internal packages to the restricted packages > properties for their own build. So I think it is useful in general in > that respect. > >>> That aside I would think the CP+RM could be changed to a MV. >> Agreed. > > Right. Will do. > >> I would prefer the TOOL_ADDTO... line to be moved to >> jdk/makefiles/Tools.gmk with the other similar definitions, even if it >> is only used here atm. > > Ok. > >>> In the tool this code doesn't show correct use of try-with-resources: >>> >>> 51 try (BufferedReader br = new BufferedReader(new >>> FileReader(args[0])); >>> 52 BufferedWriter bw = new BufferedWriter(new >>> FileWriter(args[1]))) { >>> >>> The FileReader and FileWriter should also be covered by TWR: >>> >>> try (FileReader fr = new FileReader(args[0]); >>> BufferedReader br = new BufferedReader(fr); >>> FileWriter fw = new FileWriter(args[1]); >>> BufferedWriter bw = new BufferedWriter(fw)) { >>> >> I'm not familiar with the try-with-resources, but calling close on a >> BufferedReader/writer will close the underlying reader/writer so nothing >> will be left open, will it not? > > That's what I thought as well. David? > >>> Finally do we still use make/tools/Makefile in the new build? >>> >> No, we don't. If you want to add old build support for this, you would >> also need to add usage of the tool to the correct old makefile. > > I don't think it's necessary to add this to the old build at this point. > > I'll post another webrev later in the day with these updates. > > Thanks, > Sean > From roger.riggs at oracle.com Wed Oct 9 18:42:06 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Wed, 09 Oct 2013 18:42:06 +0000 Subject: hg: jdk8/tl/jdk: 8024076: Incorrect 2 -> 4 year parsing and resolution in DateTimeFormatter Message-ID: <20131009184222.ABF3E62EA7@hg.openjdk.java.net> Changeset: d42fe440bda8 Author: rriggs Date: 2013-10-09 13:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d42fe440bda8 8024076: Incorrect 2 -> 4 year parsing and resolution in DateTimeFormatter Summary: Add appendValueReduced method based on a ChronoLocalDate to provide context for the value Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java ! test/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java ! test/java/time/test/java/time/format/TestReducedParser.java ! test/java/time/test/java/time/format/TestReducedPrinter.java From brian.burkhalter at oracle.com Wed Oct 9 18:50:05 2013 From: brian.burkhalter at oracle.com (brian.burkhalter at oracle.com) Date: Wed, 09 Oct 2013 18:50:05 +0000 Subject: hg: jdk8/tl/jdk: 8016252: More defensive HashSet.readObject Message-ID: <20131009185018.E91C762EA8@hg.openjdk.java.net> Changeset: b86e6700266e Author: bpb Date: 2013-10-09 11:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b86e6700266e 8016252: More defensive HashSet.readObject Summary: Add data validation checks in readObject(). Reviewed-by: alanb, mduigou, chegar Contributed-by: Brian Burkhalter ! src/share/classes/java/util/HashSet.java + test/java/util/HashSet/Serialization.java From valerie.peng at oracle.com Wed Oct 9 20:26:29 2013 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Wed, 09 Oct 2013 20:26:29 +0000 Subject: hg: jdk8/tl/jdk: 5 new changesets Message-ID: <20131009202801.65D1362EB0@hg.openjdk.java.net> Changeset: 1597066b58ee Author: valeriep Date: 2013-10-08 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1597066b58ee 7196382: PKCS11 provider should support 2048-bit DH Summary: Query and enforce range checking using the values from native PKCS11 library. Reviewed-by: xuelei ! src/share/classes/com/sun/crypto/provider/DHParameterGenerator.java ! src/share/classes/sun/security/pkcs11/P11KeyPairGenerator.java + test/sun/security/pkcs11/KeyPairGenerator/TestDH2048.java Changeset: 3da8be8d13bf Author: valeriep Date: 2013-10-08 11:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3da8be8d13bf 8012900: CICO ignores AAD in GCM mode Summary: Change GCM decryption to not return result until tag verification passed Reviewed-by: xuelei ! src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/CipherFeedback.java ! src/share/classes/com/sun/crypto/provider/CounterMode.java ! src/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java ! src/share/classes/com/sun/crypto/provider/FeedbackCipher.java ! src/share/classes/com/sun/crypto/provider/GCTR.java ! src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java ! src/share/classes/com/sun/crypto/provider/OutputFeedback.java ! src/share/classes/com/sun/crypto/provider/PCBC.java ! src/share/classes/javax/crypto/CipherSpi.java + test/com/sun/crypto/provider/Cipher/AES/TestCICOWithGCMAndAAD.java Changeset: f4305254f92f Author: valeriep Date: 2013-10-08 11:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4305254f92f 8014374: Cannot initialize "AES/GCM/NoPadding" on wrap/unseal on solaris with OracleUcrypto Summary: Removed OracleUcrypto provider regression tests from OpenJDK Reviewed-by: xuelei - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java Changeset: e044b0151858 Author: valeriep Date: 2013-10-08 14:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e044b0151858 8025967: addition of -Werror broke the old build Summary: Fixed and suppressed compiler warnings on rawtypes Reviewed-by: vinnie ! src/share/classes/com/sun/jndi/ldap/LdapCtxFactory.java ! src/share/classes/com/sun/jndi/ldap/LdapPoolManager.java ! src/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java ! src/share/classes/java/lang/instrument/Instrumentation.java ! src/share/classes/java/net/ContentHandler.java ! src/share/classes/javax/crypto/JceSecurityManager.java ! src/share/classes/sun/instrument/InstrumentationImpl.java ! src/share/classes/sun/net/www/content/image/gif.java ! src/share/classes/sun/net/www/content/image/jpeg.java ! src/share/classes/sun/net/www/content/image/png.java ! src/share/classes/sun/net/www/content/image/x_xbitmap.java ! src/share/classes/sun/net/www/content/image/x_xpixmap.java ! src/share/classes/sun/net/www/protocol/https/HttpsURLConnectionImpl.java ! src/share/classes/sun/reflect/misc/MethodUtil.java ! src/share/classes/sun/security/provider/AuthPolicyFile.java ! src/share/classes/sun/security/provider/SubjectCodeSource.java ! src/share/classes/sun/security/tools/jarsigner/Main.java ! src/share/classes/sun/security/tools/keytool/Main.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java Changeset: 7a7b73a40bb1 Author: valeriep Date: 2013-10-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a7b73a40bb1 Merge - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html From brian.burkhalter at oracle.com Thu Oct 10 00:29:26 2013 From: brian.burkhalter at oracle.com (brian.burkhalter at oracle.com) Date: Thu, 10 Oct 2013 00:29:26 +0000 Subject: hg: jdk8/tl/jdk: 7189139: BigInteger's staticRandom field can be a source of bottlenecks. Message-ID: <20131010002949.8ACA162EB7@hg.openjdk.java.net> Changeset: 673f8045311e Author: bpb Date: 2013-10-09 17:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/673f8045311e 7189139: BigInteger's staticRandom field can be a source of bottlenecks. Summary: Use ThreadLocalRandom instead of SecureRandom. Reviewed-by: shade, psandoz Contributed-by: Brian Burkhalter ! src/share/classes/java/math/BigInteger.java From weijun.wang at oracle.com Thu Oct 10 00:56:06 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 10 Oct 2013 08:56:06 +0800 Subject: Code review request: 8026235: keytool NSS test should use 64 bit lib on Solaris Message-ID: <5255FB26.3050101@oracle.com> Hi Vinnie Please take a review at http://cr.openjdk.java.net/~weijun/8026235/webrev.00/ Thanks Max From jason.uh at oracle.com Thu Oct 10 00:56:53 2013 From: jason.uh at oracle.com (Jason Uh) Date: Wed, 09 Oct 2013 17:56:53 -0700 Subject: [8] Request for Review: 8026052: cannot find symbol Proc Message-ID: <5255FB55.10307@oracle.com> Please review this fix. This changeset removes trailing slashes at the end of the test library paths in the jtreg @library tag, which can cause the tests to fail on Windows. webrev: http://cr.openjdk.java.net/~juh/8026052/webrev.00/ Thanks, Jason From jason.uh at oracle.com Thu Oct 10 00:57:03 2013 From: jason.uh at oracle.com (Jason Uh) Date: Wed, 09 Oct 2013 17:57:03 -0700 Subject: [8] Request for Review: 8026233: test/sun/security/tools/keytool/StorePasswords.java needs to clean up files Message-ID: <5255FB5F.5070705@oracle.com> Hi Vinnie, Could you please review this fix? The test sun/security/tools/keytool/StorePasswords.java can terminate with an error on Windows because of files not getting cleaned up, so this fix deletes the keystore file at the end of the test. webrev: http://cr.openjdk.java.net/~juh/8026233/webrev.00/ Thanks, Jason From david.holmes at oracle.com Thu Oct 10 01:18:21 2013 From: david.holmes at oracle.com (David Holmes) Date: Thu, 10 Oct 2013 11:18:21 +1000 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access In-Reply-To: <52555832.1080907@oracle.com> References: <52546282.50101@oracle.com> <5254DC80.3080305@oracle.com> <52551E72.9030605@oracle.com> <52555832.1080907@oracle.com> Message-ID: <5256005D.6070201@oracle.com> cc'ing Joe Darcy. :) Joe: there is a try-with-resources question for you below ... On 9/10/2013 11:20 PM, Sean Mullan wrote: > On 10/09/2013 05:14 AM, Erik Joelsson wrote: >> On 2013-10-09 06:33, David Holmes wrote: >>> In the tool this code doesn't show correct use of try-with-resources: >>> >>> 51 try (BufferedReader br = new BufferedReader(new >>> FileReader(args[0])); >>> 52 BufferedWriter bw = new BufferedWriter(new >>> FileWriter(args[1]))) { >>> >>> The FileReader and FileWriter should also be covered by TWR: >>> >>> try (FileReader fr = new FileReader(args[0]); >>> BufferedReader br = new BufferedReader(fr); >>> FileWriter fw = new FileWriter(args[1]); >>> BufferedWriter bw = new BufferedWriter(fw)) { >>> >> I'm not familiar with the try-with-resources, but calling close on a >> BufferedReader/writer will close the underlying reader/writer so nothing >> will be left open, will it not? > > That's what I thought as well. David? It maybe that I am overly pedantic with this but the issue is that with the original code if the BufferedReader/Writer constructors throw an exception then the FileReader/Writer that was already created would not be closed. The revised code accounts for this. Joe: what is best-practice here? I see a lot of examples of t-w-r where there is a set of chained I/O streams and only the outermost one is a t-w-r resource. And that seems wrong to me. Thanks, David >>> Finally do we still use make/tools/Makefile in the new build? >>> >> No, we don't. If you want to add old build support for this, you would >> also need to add usage of the tool to the correct old makefile. > > I don't think it's necessary to add this to the old build at this point. > > I'll post another webrev later in the day with these updates. > > Thanks, > Sean > From mike.duigou at oracle.com Thu Oct 10 01:25:58 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 10 Oct 2013 01:25:58 +0000 Subject: hg: jdk8/tl/jdk: 8024709: TreeMap.DescendingKeyIterator 'remove' confuses iterator position Message-ID: <20131010012639.85AE162EB8@hg.openjdk.java.net> Changeset: eab3c09745b6 Author: bchristi Date: 2013-10-09 12:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eab3c09745b6 8024709: TreeMap.DescendingKeyIterator 'remove' confuses iterator position Summary: Override remove() method in DescendingKeyIterator Reviewed-by: alanb, mduigou, psandoz ! src/share/classes/java/util/TreeMap.java ! test/java/util/Collection/MOAT.java From joe.darcy at oracle.com Thu Oct 10 01:32:23 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 10 Oct 2013 01:32:23 +0000 Subject: hg: jdk8/tl/jdk: 8024354: Explicitly permit DoubleStream.sum()/average() implementations to use higher precision summation Message-ID: <20131010013235.BE03562EBB@hg.openjdk.java.net> Changeset: c13309f658e1 Author: darcy Date: 2013-10-09 18:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c13309f658e1 8024354: Explicitly permit DoubleStream.sum()/average() implementations to use higher precision summation Reviewed-by: mduigou, briangoetz ! src/share/classes/java/util/DoubleSummaryStatistics.java ! src/share/classes/java/util/stream/DoubleStream.java From weijun.wang at oracle.com Thu Oct 10 01:37:43 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 10 Oct 2013 09:37:43 +0800 Subject: [8] Request for Review: 8026052: cannot find symbol Proc In-Reply-To: <5255FB55.10307@oracle.com> References: <5255FB55.10307@oracle.com> Message-ID: <525604E7.9040601@oracle.com> This looks harmless. But it looks more like a jtreg issue if it cannot deal with that slash. I haven't noticed it failing on Windows before. Can you point me to a jtr file. Thanks Max On 10/10/13 8:56 AM, Jason Uh wrote: > Please review this fix. This changeset removes trailing slashes at the > end of the test library paths in the jtreg @library tag, which can cause > the tests to fail on Windows. > > webrev: http://cr.openjdk.java.net/~juh/8026052/webrev.00/ > > Thanks, > Jason From joe.darcy at oracle.com Thu Oct 10 02:36:44 2013 From: joe.darcy at oracle.com (Joseph Darcy) Date: Wed, 09 Oct 2013 19:36:44 -0700 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access In-Reply-To: <5256005D.6070201@oracle.com> References: <52546282.50101@oracle.com> <5254DC80.3080305@oracle.com> <52551E72.9030605@oracle.com> <52555832.1080907@oracle.com> <5256005D.6070201@oracle.com> Message-ID: <525612BC.9040507@oracle.com> On 10/9/2013 6:18 PM, David Holmes wrote: > cc'ing Joe Darcy. :) > > Joe: there is a try-with-resources question for you below ... > > On 9/10/2013 11:20 PM, Sean Mullan wrote: >> On 10/09/2013 05:14 AM, Erik Joelsson wrote: >>> On 2013-10-09 06:33, David Holmes wrote: >>>> In the tool this code doesn't show correct use of try-with-resources: >>>> >>>> 51 try (BufferedReader br = new BufferedReader(new >>>> FileReader(args[0])); >>>> 52 BufferedWriter bw = new BufferedWriter(new >>>> FileWriter(args[1]))) { >>>> >>>> The FileReader and FileWriter should also be covered by TWR: >>>> >>>> try (FileReader fr = new FileReader(args[0]); >>>> BufferedReader br = new BufferedReader(fr); >>>> FileWriter fw = new FileWriter(args[1]); >>>> BufferedWriter bw = new BufferedWriter(fw)) { >>>> >>> I'm not familiar with the try-with-resources, but calling close on a >>> BufferedReader/writer will close the underlying reader/writer so >>> nothing >>> will be left open, will it not? >> >> That's what I thought as well. David? > > It maybe that I am overly pedantic with this but the issue is that > with the original code if the BufferedReader/Writer constructors throw > an exception then the FileReader/Writer that was already created would > not be closed. The revised code accounts for this. > > Joe: what is best-practice here? I see a lot of examples of t-w-r > where there is a set of chained I/O streams and only the outermost one > is a t-w-r resource. And that seems wrong to me. It is a hazard (I thought I had published a blog entry on this very tropic, but apparently not). The most robust pattern is try(OriginalResource r1 = new OriginalResource; WrappingResource r2 = new WrappingResource(r1); AnnotherWrappingResource r3 = new WrappingResource(r2)) { ...} One thing to watch out for in this pattern is a non-idempotent close. Calling close on r3 will presumably propagate a close call to r2, and then r2 to r1. So give the desguaring the try-with-resource and the expected behavior of the wrapping in a normal termination situation, close on r3 gets called once, close on r2 gets called twice (first from the close on r3, second close from try-with-resources), and close on r1 gets called three times. HTH, -Joe From vincent.x.ryan at oracle.com Thu Oct 10 06:36:13 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 10 Oct 2013 07:36:13 +0100 Subject: Code review request: 8026235: keytool NSS test should use 64 bit lib on Solaris In-Reply-To: <5255FB26.3050101@oracle.com> References: <5255FB26.3050101@oracle.com> Message-ID: <52564ADD.5020006@oracle.com> Your changes look fine. Thanks. On 10/10/2013 01:56, Weijun Wang wrote: > Hi Vinnie > > Please take a review at > > http://cr.openjdk.java.net/~weijun/8026235/webrev.00/ > > Thanks > Max From bernd-pirat at eckenfels.net Thu Oct 10 03:49:41 2013 From: bernd-pirat at eckenfels.net (Bernd Eckenfels) Date: Thu, 10 Oct 2013 05:49:41 +0200 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access Message-ID: Hello, While you discuss TWR hazards, be aware that closing a sink (OutputStream) as part of a "finally" branch which hides exceptions is dangerous in some I/O scenarios because hardware write errors could be delayed until the close. NFS for example has this tendency, but also some virtual filesystems do a lot of commit work on close. So typically you add a close inside the try as well. Greetings Bernd Am 10.10.2013, 04:36 Uhr, schrieb Joseph Darcy : > It is a hazard (I thought I had published a blog entry on this very > tropic, but apparently not). The most robust pattern is > > try(OriginalResource r1 = new OriginalResource; > WrappingResource r2 = new WrappingResource(r1); > AnnotherWrappingResource r3 = new WrappingResource(r2)) { ...} > > One thing to watch out for in this pattern is a non-idempotent close. > Calling close on r3 will presumably propagate a close call to r2, and > then r2 to r1. So give the desguaring the try-with-resource and the > expected behavior of the wrapping in a normal termination situation, > close on r3 gets called once, close on r2 gets called twice (first from > the close on r3, second close from try-with-resources), and close on r1 > gets called three times. > > HTH, > > -Joe -- http://bernd.eckenfels.net From shanliang.jiang at oracle.com Thu Oct 10 06:49:33 2013 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Thu, 10 Oct 2013 06:49:33 +0000 Subject: hg: jdk8/tl/jdk: 8025206: Intermittent test failure: javax/management/monitor/NullAttributeValueTest.java Message-ID: <20131010064945.52B3A62EC3@hg.openjdk.java.net> Changeset: e8097e1e18a7 Author: sjiang Date: 2013-10-10 08:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8097e1e18a7 8025206: Intermittent test failure: javax/management/monitor/NullAttributeValueTest.java Reviewed-by: dholmes, dfuchs, jbachorik ! test/javax/management/monitor/NullAttributeValueTest.java From shanliang.jiang at oracle.com Thu Oct 10 06:38:38 2013 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Thu, 10 Oct 2013 06:38:38 +0000 Subject: hg: jdk8/tl/jdk: 8025207: Intermittent test failure: javax/management/monitor/CounterMonitorThresholdTest.java Message-ID: <20131010063900.29E1C62EC1@hg.openjdk.java.net> Changeset: e901a618dcff Author: sjiang Date: 2013-10-10 08:37 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e901a618dcff 8025207: Intermittent test failure: javax/management/monitor/CounterMonitorThresholdTest.java Reviewed-by: dfuchs, dholmes ! test/javax/management/monitor/CounterMonitorThresholdTest.java From shanliang.jiang at oracle.com Thu Oct 10 07:04:02 2013 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Thu, 10 Oct 2013 07:04:02 +0000 Subject: hg: jdk8/tl/jdk: 8025205: Intermittent test failure: javax/management/remote/mandatory/connection/BrokenConnectionTest.java Message-ID: <20131010070414.34A2A62EC4@hg.openjdk.java.net> Changeset: a30f6fd581b3 Author: sjiang Date: 2013-10-10 09:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a30f6fd581b3 8025205: Intermittent test failure: javax/management/remote/mandatory/connection/BrokenConnectionTest.java Reviewed-by: dholmes, dfuchs, jbachorik ! test/javax/management/remote/mandatory/connection/BrokenConnectionTest.java From staffan.larsen at oracle.com Thu Oct 10 07:38:46 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Thu, 10 Oct 2013 07:38:46 +0000 Subject: hg: jdk8/tl/jdk: 8025427: jstat tests fails on 32-bit platforms Message-ID: <20131010073859.3EABA62EC9@hg.openjdk.java.net> Changeset: 6aa637dde16e Author: sla Date: 2013-10-10 09:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6aa637dde16e 8025427: jstat tests fails on 32-bit platforms Reviewed-by: ehelin, dsamersoff, dholmes, sspitsyn ! src/share/classes/sun/tools/jstat/RowClosure.java ! test/ProblemList.txt ! test/sun/tools/jstat/gcCauseOutput1.awk ! test/sun/tools/jstat/lineCounts1.awk ! test/sun/tools/jstat/lineCounts2.awk ! test/sun/tools/jstat/lineCounts3.awk ! test/sun/tools/jstat/lineCounts4.awk ! test/sun/tools/jstat/timeStamp1.awk ! test/sun/tools/jstatd/jstatGcutilOutput1.awk From weijun.wang at oracle.com Thu Oct 10 07:26:37 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 10 Oct 2013 07:26:37 +0000 Subject: hg: jdk8/tl/jdk: 8026235: keytool NSS test should use 64 bit lib on Solaris Message-ID: <20131010072652.AE4E062EC5@hg.openjdk.java.net> Changeset: 74b4d20769fd Author: weijun Date: 2013-10-10 15:24 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74b4d20769fd 8026235: keytool NSS test should use 64 bit lib on Solaris Reviewed-by: vinnie ! test/sun/security/tools/keytool/autotest.sh From staffan.larsen at oracle.com Thu Oct 10 08:43:56 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Thu, 10 Oct 2013 08:43:56 +0000 Subject: hg: jdk8/tl/jdk: 8014446: JT_JDK: Wrong detection of test result for test com/sun/jdi/NoLaunchOptionTest.java Message-ID: <20131010084446.2952162ED0@hg.openjdk.java.net> Changeset: 998560cccefc Author: allwin Date: 2013-10-10 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/998560cccefc 8014446: JT_JDK: Wrong detection of test result for test com/sun/jdi/NoLaunchOptionTest.java Reviewed-by: sla, mgronlun, dholmes, jbachorik, chegar ! test/com/sun/jdi/NoLaunchOptionTest.java From alan.bateman at oracle.com Thu Oct 10 09:01:24 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 10 Oct 2013 09:01:24 +0000 Subject: hg: jdk8/tl/jdk: 7011859: java/util/concurrent/Semaphore/RacingReleases.java failing Message-ID: <20131010090153.05EAF62ED4@hg.openjdk.java.net> Changeset: 99b7bbe0474f Author: dl Date: 2013-10-10 09:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/99b7bbe0474f 7011859: java/util/concurrent/Semaphore/RacingReleases.java failing Reviewed-by: alanb, dholmes ! src/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java ! src/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java From david.holmes at oracle.com Thu Oct 10 08:59:24 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Thu, 10 Oct 2013 08:59:24 +0000 Subject: hg: jdk8/tl/jdk: 8026232: Move libnpt from profile compact1 to compact3 Message-ID: <20131010085955.5711062ED3@hg.openjdk.java.net> Changeset: 254173b48dcb Author: dholmes Date: 2013-10-10 04:57 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/254173b48dcb 8026232: Move libnpt from profile compact1 to compact3 Reviewed-by: mchung, alanb ! makefiles/profile-includes.txt From erik.joelsson at oracle.com Thu Oct 10 09:57:53 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 10 Oct 2013 11:57:53 +0200 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access In-Reply-To: <5255901E.1020104@oracle.com> References: <52546282.50101@oracle.com> <5254DC80.3080305@oracle.com> <52551E72.9030605@oracle.com> <52555832.1080907@oracle.com> <5255901E.1020104@oracle.com> Message-ID: <52567A21.3050503@oracle.com> Adding makefiles to make/tools is not needed for the new build. Either remove those changes or make a complete port to the old build. I'm not pushing for porting this to the old build at this point since missing this will not cause the old build to stop working, it will just diverge the resulting bits a bit more. /Erik On 2013-10-09 19:19, Sean Mullan wrote: > Updated webrev: > http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.01/ > > Let me know if there are any more comments, otherwise I will plan to > push tomorrow. > > Thanks, > Sean > > On 10/09/2013 09:20 AM, Sean Mullan wrote: >> On 10/09/2013 05:14 AM, Erik Joelsson wrote: >>> Hello Sean, >>> >>> On 2013-10-09 06:33, David Holmes wrote: >>>> Hi Sean, >>>> >>>> Not a full review. >>>> >>>> On 9/10/2013 5:52 AM, Sean Mullan wrote: >>>>> Please review the fix for the following bug: >>>>> >>>>> https://bugs.openjdk.java.net/browse/JDK-8007292 >>>>> >>>>> This bug requires build changes and a new build tool to add >>>>> additional >>>>> restricted packages to the java.security file which are not part of >>>>> OpenJDK. These packages are only added when doing a build >>>>> including the >>>>> open and closed sources. >>>>> >>>>> The restricted packages and new test are in the closed sources and >>>>> will >>>>> be reviewed separately. >>>>> >>>>> webrev: http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.00/ >>>> >>>> Based on your description and the ifndef OPENJDK it sounds to me that >>>> this doesn't belong in the OpenJDK makefiles. >>>> >>> I agree in principle, but the pattern on how to handle this isn't well >>> established yet and something we need to improve on. In this case we >>> would need to make changes on the open side anyway to provide hooks for >>> overrides of the behavior. I'm willing to accept this for now. >> >> Thanks. Also, keep in mind that this hook allows each vendor,etc to add >> additional proprietary or internal packages to the restricted packages >> properties for their own build. So I think it is useful in general in >> that respect. >> >>>> That aside I would think the CP+RM could be changed to a MV. >>> Agreed. >> >> Right. Will do. >> >>> I would prefer the TOOL_ADDTO... line to be moved to >>> jdk/makefiles/Tools.gmk with the other similar definitions, even if it >>> is only used here atm. >> >> Ok. >> >>>> In the tool this code doesn't show correct use of try-with-resources: >>>> >>>> 51 try (BufferedReader br = new BufferedReader(new >>>> FileReader(args[0])); >>>> 52 BufferedWriter bw = new BufferedWriter(new >>>> FileWriter(args[1]))) { >>>> >>>> The FileReader and FileWriter should also be covered by TWR: >>>> >>>> try (FileReader fr = new FileReader(args[0]); >>>> BufferedReader br = new BufferedReader(fr); >>>> FileWriter fw = new FileWriter(args[1]); >>>> BufferedWriter bw = new BufferedWriter(fw)) { >>>> >>> I'm not familiar with the try-with-resources, but calling close on a >>> BufferedReader/writer will close the underlying reader/writer so >>> nothing >>> will be left open, will it not? >> >> That's what I thought as well. David? >> >>>> Finally do we still use make/tools/Makefile in the new build? >>>> >>> No, we don't. If you want to add old build support for this, you would >>> also need to add usage of the tool to the correct old makefile. >> >> I don't think it's necessary to add this to the old build at this point. >> >> I'll post another webrev later in the day with these updates. >> >> Thanks, >> Sean >> > From michael.x.mcmahon at oracle.com Thu Oct 10 11:38:41 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Thu, 10 Oct 2013 11:38:41 +0000 Subject: hg: jdk8/tl/jdk: 7076487: (sctp) SCTP API classes does not exist in JDK for Mac Message-ID: <20131010113908.54B3C62EEB@hg.openjdk.java.net> Changeset: 8294c49d23b3 Author: michaelm Date: 2013-10-10 12:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8294c49d23b3 7076487: (sctp) SCTP API classes does not exist in JDK for Mac Reviewed-by: alanb, chegar ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk + src/macosx/classes/sun/nio/ch/sctp/SctpChannelImpl.java + src/macosx/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java + src/macosx/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java From sundararajan.athijegannathan at oracle.com Thu Oct 10 12:07:16 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 10 Oct 2013 12:07:16 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20131010120727.9160A62EEC@hg.openjdk.java.net> Changeset: 03a68e7ca1d5 Author: lagergren Date: 2013-10-09 17:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/03a68e7ca1d5 8026137: Fix Issues with Binary Evaluation Order Reviewed-by: hannesw, jlaskey Contributed-by: marcus.lagergren at oracle.com, attila.szegedi at oracle.com ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/BranchOptimizer.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/CompileUnit.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/codegen/types/BooleanType.java ! src/jdk/nashorn/internal/codegen/types/ObjectType.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BaseNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java - src/jdk/nashorn/internal/ir/TypeOverride.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/parser/TokenType.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/arrays/JavaArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/ReverseJavaArrayIterator.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java + test/script/basic/JDK-8026137.js + test/script/basic/JDK-8026137.js.EXPECTED Changeset: 7cc5ff16380f Author: sundar Date: 2013-10-10 11:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7cc5ff16380f 8026167: Class cache/reuse of 'eval' scripts results in ClassCastException in some cases. Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/runtime/CodeInstaller.java ! src/jdk/nashorn/internal/runtime/Context.java ! test/script/assert.js ! test/script/basic/JDK-8019508.js ! test/script/basic/JDK-8019508.js.EXPECTED ! test/script/basic/JDK-8019553.js ! test/script/basic/JDK-8019553.js.EXPECTED ! test/script/basic/JDK-8019791.js ! test/script/basic/JDK-8019791.js.EXPECTED ! test/script/basic/JDK-8019805.js ! test/script/basic/JDK-8019805.js.EXPECTED + test/script/basic/JDK-8026167.js ! test/script/basic/NASHORN-100.js ! test/script/basic/NASHORN-100.js.EXPECTED ! test/script/basic/NASHORN-293.js ! test/script/basic/NASHORN-293.js.EXPECTED ! test/script/basic/NASHORN-40.js ! test/script/basic/NASHORN-40.js.EXPECTED ! test/script/basic/NASHORN-51.js ! test/script/basic/NASHORN-51.js.EXPECTED ! test/script/basic/NASHORN-98.js ! test/script/basic/NASHORN-98.js.EXPECTED ! test/script/basic/eval.js ! test/script/basic/eval.js.EXPECTED Changeset: e60bbcf2f6b6 Author: sundar Date: 2013-10-10 13:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e60bbcf2f6b6 8026248: importClass has to be a varargs function Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js + test/script/basic/JDK-8026248.js + test/script/basic/JDK-8026248.js.EXPECTED From joel.franck at oracle.com Thu Oct 10 08:56:35 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Thu, 10 Oct 2013 08:56:35 +0000 Subject: hg: jdk8/tl/langtools: 8021237: clean up JavacAnnotatedConstruct Message-ID: <20131010085713.4CF4062ED1@hg.openjdk.java.net> Changeset: 1e7ad879f15e Author: alundblad Date: 2013-10-10 08:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e7ad879f15e 8021237: clean up JavacAnnotatedConstruct Summary: Refactored the static helper methods in JavacAnnoConstructs into ordinary methods and put them in a common superclass (AnnoConstruct) of Symbol and Type. Reviewed-by: jjg, vromero, jfranck + src/share/classes/com/sun/tools/javac/code/AnnoConstruct.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java - src/share/classes/com/sun/tools/javac/model/JavacAnnoConstructs.java From joel.franck at oracle.com Thu Oct 10 16:19:01 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Thu, 10 Oct 2013 16:19:01 +0000 Subject: hg: jdk8/tl/jdk: 7044282: (reflect) Class.forName and Array.newInstance are inconsistent regarding multidimensional arrays Message-ID: <20131010161931.9663E62F04@hg.openjdk.java.net> Changeset: f25d9d8811ca Author: jfranck Date: 2013-10-10 18:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f25d9d8811ca 7044282: (reflect) Class.forName and Array.newInstance are inconsistent regarding multidimensional arrays Reviewed-by: darcy, psandoz ! src/share/classes/java/lang/reflect/Array.java + test/java/lang/Class/forName/arrayClass/Class1.java + test/java/lang/Class/forName/arrayClass/Class2.java + test/java/lang/Class/forName/arrayClass/Class3.java + test/java/lang/Class/forName/arrayClass/Class4.java + test/java/lang/Class/forName/arrayClass/ExceedMaxDim.java ! test/java/lang/reflect/Array/ExceedMaxDim.java From magnus.ihse.bursie at oracle.com Thu Oct 10 07:36:32 2013 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Thu, 10 Oct 2013 09:36:32 +0200 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access In-Reply-To: <52555832.1080907@oracle.com> References: <52546282.50101@oracle.com> <5254DC80.3080305@oracle.com> <52551E72.9030605@oracle.com> <52555832.1080907@oracle.com> Message-ID: <52565900.3070308@oracle.com> On 2013-10-09 15:20, Sean Mullan wrote: > >>> Finally do we still use make/tools/Makefile in the new build? >>> >> No, we don't. If you want to add old build support for this, you would >> also need to add usage of the tool to the correct old makefile. > > I don't think it's necessary to add this to the old build at this point. I don't really get this. You have made some changes to the old build system (changes in make/tools/Makefile and the addition of make/tools/addtorestrictedpkgs/Makefile), but you are not actually using this. I think you should either drop these changes as well, or fix it so that the old build is usable too. Doing it half-way seems just confusing. Also, are we -- in general -- okay with making changes only to the new build system? As long as both systems are still there, I thought the idea was to keep them in sync. Even though we want to remove the old build, we don't know when that happens, and we *don't* want the systems do diverge. Or are there precedence for this kind of changes? /Magnus From shanliang.jiang at oracle.com Thu Oct 10 15:48:09 2013 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Thu, 10 Oct 2013 15:48:09 +0000 Subject: hg: jdk8/tl/jdk: 8025204: Intermittent test failure: javax/management/remote/mandatory/connection/IdleTimeoutTest.java Message-ID: <20131010154859.B08D062F01@hg.openjdk.java.net> Changeset: cab80088c671 Author: sjiang Date: 2013-10-10 17:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cab80088c671 8025204: Intermittent test failure: javax/management/remote/mandatory/connection/IdleTimeoutTest.java Reviewed-by: dholmes, jbachorik ! test/javax/management/remote/mandatory/connection/IdleTimeoutTest.java From sean.mullan at oracle.com Thu Oct 10 17:45:17 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 10 Oct 2013 13:45:17 -0400 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access In-Reply-To: <52567A21.3050503@oracle.com> References: <52546282.50101@oracle.com> <5254DC80.3080305@oracle.com> <52551E72.9030605@oracle.com> <52555832.1080907@oracle.com> <5255901E.1020104@oracle.com> <52567A21.3050503@oracle.com> Message-ID: <5256E7AD.2080301@oracle.com> On 10/10/2013 05:57 AM, Erik Joelsson wrote: > Adding makefiles to make/tools is not needed for the new build. Either > remove those changes or make a complete port to the old build. I'm not > pushing for porting this to the old build at this point since missing > this will not cause the old build to stop working, it will just diverge > the resulting bits a bit more. I have ported the changes to the old build, please review. New webrev: http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.02/ The only modified file is make/java/security/Makefile Thanks, Sean From bhavesh.x.patel at oracle.com Thu Oct 10 17:52:29 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Thu, 10 Oct 2013 17:52:29 +0000 Subject: hg: jdk8/tl/langtools: 8025633: Fix javadoc to generate valid anchor names Message-ID: <20131010175322.BB19962F20@hg.openjdk.java.net> Changeset: 933ba3f81a87 Author: bpatel Date: 2013-10-10 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/933ba3f81a87 8025633: Fix javadoc to generate valid anchor names Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeFieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java + src/share/classes/com/sun/tools/doclets/formats/html/SectionName.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletConstants.java ! test/com/sun/javadoc/AccessSkipNav/AccessSkipNav.java + test/com/sun/javadoc/testAnchorNames/TestAnchorNames.java + test/com/sun/javadoc/testAnchorNames/pkg1/DeprMemClass.java + test/com/sun/javadoc/testAnchorNames/pkg1/RegClass.java ! test/com/sun/javadoc/testAnnotationOptional/TestAnnotationOptional.java ! test/com/sun/javadoc/testAnnotationTypes/TestAnnotationTypes.java ! test/com/sun/javadoc/testClassCrossReferences/TestClassCrossReferences.java ! test/com/sun/javadoc/testExternalOverridenMethod/TestExternalOverridenMethod.java ! test/com/sun/javadoc/testHref/TestHref.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java ! test/com/sun/javadoc/testMemberInheritence/TestMemberInheritence.java ! test/com/sun/javadoc/testMemberSummary/TestMemberSummary.java ! test/com/sun/javadoc/testNavigation/TestNavigation.java ! test/com/sun/javadoc/testNestedGenerics/TestNestedGenerics.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenMethodDocCopy.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPackageFlag.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testTaglets/TestTaglets.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/testTypeParams/TestTypeParameters.java ! test/com/sun/javadoc/testWarnings/TestWarnings.java From eric.mccorkle at oracle.com Thu Oct 10 17:56:29 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Thu, 10 Oct 2013 17:56:29 +0000 Subject: hg: jdk8/tl/langtools: 8019461: Clean up javac diagnostics; ... Message-ID: <20131010175642.9149F62F23@hg.openjdk.java.net> Changeset: 6dcf94e32a3a Author: emc Date: 2013-10-10 13:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6dcf94e32a3a 8019461: Clean up javac diagnostics 7196553: Review error messages for repeating annotations Summary: Changes to the diagnostic messages to improve clarity and JLS coherence Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties - test/tools/javac/diags/examples/DuplicateAnnotation.java + test/tools/javac/diags/examples/InterfaceOrArrayExpected.java + test/tools/javac/diags/examples/RepeatableAnnotationsNotSupported.java From vincent.x.ryan at oracle.com Thu Oct 10 19:15:08 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 10 Oct 2013 20:15:08 +0100 Subject: [8] Request for Review: 8026233: test/sun/security/tools/keytool/StorePasswords.java needs to clean up files In-Reply-To: <5255FB5F.5070705@oracle.com> References: <5255FB5F.5070705@oracle.com> Message-ID: <3C6F39DA-04D8-4E96-B052-42B84313FFCA@oracle.com> That fix looks fine Jason. Thanks. On 10 Oct 2013, at 01:57, Jason Uh wrote: > Hi Vinnie, > > Could you please review this fix? The test sun/security/tools/keytool/StorePasswords.java can terminate with an error on Windows because of files not getting cleaned up, so this fix deletes the keystore file at the end of the test. > > webrev: http://cr.openjdk.java.net/~juh/8026233/webrev.00/ > > Thanks, > Jason From tim.bell at oracle.com Thu Oct 10 19:26:06 2013 From: tim.bell at oracle.com (Tim Bell) Date: Thu, 10 Oct 2013 12:26:06 -0700 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access In-Reply-To: <5256E7AD.2080301@oracle.com> References: <52546282.50101@oracle.com> <5254DC80.3080305@oracle.com> <52551E72.9030605@oracle.com> <52555832.1080907@oracle.com> <5255901E.1020104@oracle.com> <52567A21.3050503@oracle.com> <5256E7AD.2080301@oracle.com> Message-ID: <5256FF4E.7080303@oracle.com> On 10/10/13 10:45 AM, Sean Mullan wrote: > On 10/10/2013 05:57 AM, Erik Joelsson wrote: >> Adding makefiles to make/tools is not needed for the new build. Either >> remove those changes or make a complete port to the old build. I'm not >> pushing for porting this to the old build at this point since missing >> this will not cause the old build to stop working, it will just diverge >> the resulting bits a bit more. > > I have ported the changes to the old build, please review. > > New webrev: http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.02/ > > The only modified file is make/java/security/Makefile Makefile looks good to me. As for when the old makefiles are removed, we don't know for sure yet, but the time is getting closer as there are fewer stopper issues with the removal. Tim From eric.mccorkle at oracle.com Thu Oct 10 22:56:46 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Thu, 10 Oct 2013 22:56:46 +0000 Subject: hg: jdk8/tl/jdk: 8026011: java.lang.reflect.MalformedParametersException introduces doclint warnings Message-ID: <20131010225701.3187A62F46@hg.openjdk.java.net> Changeset: 4abfcbac1cb6 Author: emc Date: 2013-10-10 18:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4abfcbac1cb6 8026011: java.lang.reflect.MalformedParametersException introduces doclint warnings Summary: Add javadoc comments to members of MalformedParametersException Reviewed-by: darcy ! src/share/classes/java/lang/reflect/MalformedParametersException.java From eric.mccorkle at oracle.com Fri Oct 11 00:12:41 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Fri, 11 Oct 2013 00:12:41 +0000 Subject: hg: jdk8/tl/langtools: 8008762: Type annotation on inner class in anonymous class show up as regular type annotations; ... Message-ID: <20131011001244.DCEAB62F49@hg.openjdk.java.net> Changeset: b1b4a6dcc282 Author: emc Date: 2013-10-10 20:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b1b4a6dcc282 8008762: Type annotation on inner class in anonymous class show up as regular type annotations 8015257: type annotation with TYPE_USE and FIELD attributed differently if repeated. 8013409: test failures for type annotations Summary: Fixes to address some problems in type annotations Reviewed-by: jfranck, jjg ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/annotations/typeAnnotations/classfile/TestAnonInnerClasses.java + test/tools/javac/annotations/typeAnnotations/classfile/testanoninner.template ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.out ! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java From jonathan.gibbons at oracle.com Fri Oct 11 00:14:53 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 11 Oct 2013 00:14:53 +0000 Subject: hg: jdk8/tl/langtools: 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java Message-ID: <20131011001456.7B35062F4A@hg.openjdk.java.net> Changeset: f068d235c4f7 Author: jjg Date: 2013-10-10 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f068d235c4f7 8026294: 8025633 breaks langtools/test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java Reviewed-by: darcy ! test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java From huizhe.wang at oracle.com Fri Oct 11 00:01:50 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Fri, 11 Oct 2013 00:01:50 +0000 Subject: hg: jdk8/tl/jaxp: 8003262: reverse translation required changes in xalan resource bundles Message-ID: <20131011000152.91BCF62F47@hg.openjdk.java.net> Changeset: b76629725522 Author: joehw Date: 2013-10-10 17:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b76629725522 8003262: reverse translation required changes in xalan resource bundles Reviewed-by: lancea, dfuchs ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_de.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_es.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_fr.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_it.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ja.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ko.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_pt_BR.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_sv.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_CN.java ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_TW.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ca.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_cs.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_de.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_es.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_fr.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_it.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ja.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ko.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_pt_BR.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sk.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sv.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_CN.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_TW.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_ca.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_cs.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_de.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_es.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_fr.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_it.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_ja.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_ko.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_pt_BR.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_sk.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_sv.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_zh_CN.java ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_zh_TW.java From lana.steuck at oracle.com Fri Oct 11 04:33:10 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 Oct 2013 04:33:10 +0000 Subject: hg: jdk8/tl/jaxp: 5 new changesets Message-ID: <20131011043340.3400362F56@hg.openjdk.java.net> Changeset: 17ee0d3e97fd Author: katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/17ee0d3e97fd Added tag jdk8-b110 for changeset 4c84c5b447b0 ! .hgtags Changeset: 2107c9baa457 Author: lana Date: 2013-10-10 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/2107c9baa457 Merge Changeset: cff4e3bf530a Author: lana Date: 2013-10-10 20:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/cff4e3bf530a Merge Changeset: a4622ff1462b Author: cl Date: 2013-10-10 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a4622ff1462b Added tag jdk8-b111 for changeset 17ee0d3e97fd ! .hgtags Changeset: 46ccc5fbc523 Author: lana Date: 2013-10-10 21:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/46ccc5fbc523 Merge From lana.steuck at oracle.com Fri Oct 11 04:33:03 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 Oct 2013 04:33:03 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20131011043309.5879962F53@hg.openjdk.java.net> Changeset: 85c1c94e7235 Author: katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/85c1c94e7235 Added tag jdk8-b110 for changeset 3d2b7ce93c5c ! .hgtags Changeset: d7e478820c56 Author: cl Date: 2013-10-10 10:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d7e478820c56 Added tag jdk8-b111 for changeset 85c1c94e7235 ! .hgtags From lana.steuck at oracle.com Fri Oct 11 04:33:12 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 Oct 2013 04:33:12 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20131011043325.F1F5C62F54@hg.openjdk.java.net> Changeset: d49a8c2173f5 Author: lana Date: 2013-09-26 17:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d49a8c2173f5 Merge Changeset: 75fd3486e584 Author: katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/75fd3486e584 Added tag jdk8-b110 for changeset d49a8c2173f5 ! .hgtags Changeset: fc2b6885e60e Author: cl Date: 2013-10-10 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fc2b6885e60e Added tag jdk8-b111 for changeset 75fd3486e584 ! .hgtags Changeset: f6263ae511c2 Author: lana Date: 2013-10-10 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f6263ae511c2 Merge From lana.steuck at oracle.com Fri Oct 11 04:33:00 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 Oct 2013 04:33:00 +0000 Subject: hg: jdk8/tl: 12 new changesets Message-ID: <20131011043303.7C9E462F52@hg.openjdk.java.net> Changeset: 5ec3c4948863 Author: ksrini Date: 2013-09-27 16:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5ec3c4948863 8023495: [infra] create 64-bit solaris bits with symlinks Reviewed-by: ihse, tbell, erikj ! common/makefiles/Jprt.gmk ! common/makefiles/Main.gmk Changeset: 72c2495c86c9 Author: katleman Date: 2013-10-01 12:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/72c2495c86c9 Merge Changeset: 0f704e36bc5d Author: ihse Date: 2013-10-01 10:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/0f704e36bc5d 8006661: Use LC_ALL=C instead of LANG=C compare.sh Reviewed-by: tbell ! common/bin/compare.sh Changeset: 4faa09c7fe55 Author: erikj Date: 2013-10-02 15:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4faa09c7fe55 Merge Changeset: 669e3e3d4459 Author: katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/669e3e3d4459 Added tag jdk8-b110 for changeset 4faa09c7fe55 ! .hgtags Changeset: feb4f2d97042 Author: ihse Date: 2013-10-03 11:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/feb4f2d97042 8008944: Correct typos Reviewed-by: tbell, erikj ! NewMakefile.gmk ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/makefiles/JavaCompilation.gmk Changeset: d23177734b28 Author: thurka Date: 2013-10-07 13:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d23177734b28 8025920: webrev.ksh does not provide any details about changes in zip files Summary: Add support for diffs for zip files Reviewed-by: ksrini, chegar ! make/scripts/webrev.ksh Changeset: 9b102ab97693 Author: erikj Date: 2013-10-07 18:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9b102ab97693 8005924: Make it possible to set both --with-user-release-suffix and --with-build-number Reviewed-by: ihse, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in Changeset: d086227bfc45 Author: katleman Date: 2013-10-08 13:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d086227bfc45 Merge Changeset: 4d23143c676a Author: lana Date: 2013-10-10 08:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4d23143c676a Merge Changeset: 82a36c5c4eaf Author: cl Date: 2013-10-10 10:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/82a36c5c4eaf Added tag jdk8-b111 for changeset d086227bfc45 ! .hgtags Changeset: fd3b32cc4b6e Author: lana Date: 2013-10-10 21:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/fd3b32cc4b6e Merge From lana.steuck at oracle.com Fri Oct 11 04:33:07 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 Oct 2013 04:33:07 +0000 Subject: hg: jdk8/tl/jaxws: 4 new changesets Message-ID: <20131011043336.B9FD962F55@hg.openjdk.java.net> Changeset: 32edc7a2c866 Author: katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/32edc7a2c866 Added tag jdk8-b110 for changeset cc682329886b ! .hgtags Changeset: da77e343f458 Author: lana Date: 2013-10-10 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/da77e343f458 Merge Changeset: fc94ce4b899e Author: cl Date: 2013-10-10 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/fc94ce4b899e Added tag jdk8-b111 for changeset 32edc7a2c866 ! .hgtags Changeset: 66a12ce67d3a Author: lana Date: 2013-10-10 21:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/66a12ce67d3a Merge From lana.steuck at oracle.com Fri Oct 11 04:33:32 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 Oct 2013 04:33:32 +0000 Subject: hg: jdk8/tl/langtools: 5 new changesets Message-ID: <20131011043353.0A54662F57@hg.openjdk.java.net> Changeset: 41541097533a Author: lana Date: 2013-09-26 17:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/41541097533a Merge Changeset: af6244ba81b6 Author: katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/af6244ba81b6 Added tag jdk8-b110 for changeset 41541097533a ! .hgtags Changeset: a0e8fd2464d6 Author: cl Date: 2013-10-10 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a0e8fd2464d6 Added tag jdk8-b111 for changeset af6244ba81b6 ! .hgtags Changeset: 8f293c710369 Author: lana Date: 2013-10-10 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8f293c710369 Merge Changeset: bf33f4f81b40 Author: lana Date: 2013-10-10 20:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bf33f4f81b40 Merge - test/tools/javac/diags/examples/DuplicateAnnotation.java From lana.steuck at oracle.com Fri Oct 11 04:34:22 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 Oct 2013 04:34:22 +0000 Subject: hg: jdk8/tl/hotspot: 82 new changesets Message-ID: <20131011043729.093EC62F58@hg.openjdk.java.net> Changeset: 8a6a85321d3a Author: amurillo Date: 2013-09-20 11:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8a6a85321d3a 8025127: new hotspot build - hs25-b52 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 63147986a428 Author: dcubed Date: 2013-09-18 07:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/63147986a428 8019835: Strings interned in different threads equal but does not == Summary: Add -XX:+VerifyStringTableAtExit option and code to verify StringTable invariants. Reviewed-by: rdurbin, sspitsyn, coleenp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/classfile/symbolTable.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp Changeset: dfae98867ee8 Author: dholmes Date: 2013-09-18 20:08 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dfae98867ee8 8024826: (s) : Remove alt-rt.jar, used by +AggressiveOps Reviewed-by: alanb, chegar, dholmes, ksrini Contributed-by: Mike Duigou ! src/share/vm/runtime/arguments.cpp Changeset: c1d7040a1183 Author: sgabdura Date: 2013-09-18 16:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c1d7040a1183 8022836: JVM crashes in JVMTIENVBASE::GET_CURRENT_CONTENDED_MONITOR and GET_OWNED_MONITOR Summary: Check that the _java_thread parameter is valid when it is possible that the JavaThread has exited after the initial checks were made in generated/jvmtifiles/jvmtiEnter.cpp: jvmti_GetCurrentContendedMonitor() Reviewed-by: dcubed, dsamersoff ! src/share/vm/prims/jvmtiEnvBase.hpp Changeset: 8c84f04ff977 Author: kevinw Date: 2013-09-18 19:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8c84f04ff977 Merge Changeset: 6eb908998b32 Author: kevinw Date: 2013-09-19 08:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6eb908998b32 Merge Changeset: 9ed97b511b26 Author: hseigel Date: 2013-09-19 11:04 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9ed97b511b26 8024517: runtime/CDSCompressedKPtrs/XShareAuto.java failed with RuntimeException Summary: Make sure CDS is off by default when running server compiler. Reviewed-by: dholmes, coleenp ! src/share/vm/runtime/arguments.cpp ! test/runtime/CDSCompressedKPtrs/XShareAuto.java Changeset: 4f9a42c33738 Author: coleenp Date: 2013-09-20 09:30 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4f9a42c33738 8022887: Assertion hit while using class and redefining it with RedefineClasses simultaneously Summary: Need to refetch each method from InstanceKlass after all safepoints. Removed leaky PreviousVersionInfo code. Reviewed-by: dcubed, sspitsyn ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/handles.inline.hpp Changeset: f201713502e0 Author: coleenp Date: 2013-09-20 09:44 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f201713502e0 Merge Changeset: 1b03bed31241 Author: allwin Date: 2013-09-17 17:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1b03bed31241 7196151: ParserTest SEGv on solaris Reviewed-by: sla, coleenp, ctornqvi, dsamersoff ! src/share/vm/services/diagnosticArgument.cpp Changeset: e5a25e4ae509 Author: mgerdin Date: 2013-09-20 10:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e5a25e4ae509 Merge Changeset: 7c29904fdfa2 Author: coleenp Date: 2013-09-20 18:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7c29904fdfa2 8014956: nashorn/api/javaaccess/MethodAccessTest.java test fails on sparc-solaris 64 Summary: reference_map[] array had uninitialized junk that was causing a bogus bootstrap method to be found. Reviewed-by: hseigel, dcubed, sspitsyn ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp Changeset: df03413ad1a9 Author: coleenp Date: 2013-09-21 01:45 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/df03413ad1a9 Merge Changeset: 0f37d1badced Author: dcubed Date: 2013-09-20 12:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0f37d1badced Merge ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: a7609ec351d6 Author: dcubed Date: 2013-09-20 18:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a7609ec351d6 Merge ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp - test/gc/metaspace/ClassMetaspaceSizeInJmapHeap.java Changeset: 8ddc26f62476 Author: sla Date: 2013-09-22 06:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8ddc26f62476 6989981: jstack causes "fatal error: ExceptionMark destructor expects no pending exceptions" Reviewed-by: sla, dsamersoff Contributed-by: Yasumasa Suenaga ! src/share/vm/services/attachListener.cpp Changeset: 1f42d3ec1759 Author: dsamersoff Date: 2013-09-22 18:49 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1f42d3ec1759 7133122: SA throws sun.jvm.hotspot.debugger.UnmappedAddressException when it should not Summary: replace PT_LOAD segment with library segment when necessary Reviewed-by: dholmes, sla ! agent/src/os/linux/ps_core.c Changeset: ae2edb3df7fb Author: dsamersoff Date: 2013-09-22 18:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ae2edb3df7fb Merge Changeset: 084b21cd0228 Author: iklam Date: 2013-09-23 08:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/084b21cd0228 8025088: Missing cases for JVM_CONSTANT_MethodHandleInError cause crash if debugger steps into error-tagged method handle Summary: Need to refetch each method from InstanceKlass after all safepoints. Removed leaky PreviousVersionInfo code. Reviewed-by: coleenp, sspitsyn ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp Changeset: e8a0010ba69e Author: zgu Date: 2013-09-25 13:03 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e8a0010ba69e Merge Changeset: 891687731b59 Author: anoll Date: 2013-09-24 15:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/891687731b59 7009641: Don't fail VM when CodeCache is full Summary: Allocation in the code cache returns NULL instead of failing the entire VM Reviewed-by: kvn, iveresov ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/vtableStubs_x86_32.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/compiledIC.hpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 1b64d46620a3 Author: kvn Date: 2013-09-24 16:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1b64d46620a3 8022585: VM crashes when ran with -XX:+PrintInlining Summary: use adr_at() to access inline info structures in growableArray. Add ability to specify print inlining per method. Reviewed-by: twisti ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/library_call.cpp + test/compiler/print/PrintInlining.java Changeset: f637d4dc21bb Author: adlertz Date: 2013-09-26 08:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f637d4dc21bb Merge Changeset: 586fa1919a89 Author: bpittore Date: 2013-09-20 15:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/586fa1919a89 8014911: Should use SUPPORTS_NATIVE_CX8 define to help C/C++ compiler elide blocks of code Summary: If SUPPORTS_NATIVE_CX8 true then supports_cx8() function hard coded to return 'true' Reviewed-by: kvn, twisti, dholmes ! src/share/vm/runtime/vm_version.hpp Changeset: 504d8f519adf Author: jiangli Date: 2013-09-20 20:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/504d8f519adf Merge Changeset: d682c6e24fe3 Author: bdelsart Date: 2013-09-26 01:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d682c6e24fe3 Merge Changeset: 60a2d625db36 Author: bdelsart Date: 2013-09-26 04:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/60a2d625db36 Merge Changeset: 2c022e432e10 Author: stefank Date: 2013-09-20 10:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2c022e432e10 8024974: Incorrect use of GC_locker::is_active() Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint. Reviewed-by: brutisso, dcubed Contributed-by: per.liden at oracle.com ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp Changeset: 9361de86a50f Author: stefank Date: 2013-09-20 11:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9361de86a50f 8025059: Metspace::should_expand mixes bytes and words in check against MaxMetaspaceSize Reviewed-by: coleenp, brutisso, mgerdin, jmasa ! src/share/vm/memory/metaspace.cpp Changeset: b960c9df4f11 Author: stefank Date: 2013-09-21 10:09 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b960c9df4f11 8025096: Move the ChunkManager instances out of the VirtualSpaceLists Reviewed-by: coleenp, mgerdin, jmasa ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp Changeset: 10cc3b624f8f Author: tschatzl Date: 2013-09-24 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/10cc3b624f8f Merge - test/runtime/6878713/Test6878713.sh - test/runtime/6878713/testcase.jar - test/runtime/7020373/Test7020373.sh - test/runtime/7020373/testcase.jar Changeset: a19bea467577 Author: tschatzl Date: 2013-09-25 13:25 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a19bea467577 7163191: G1: introduce a "heap spanning table" abstraction Summary: Add G1BiasedArray that is an array where each element represents a fixed-sized subdivision of the heap. Use this abstraction to refactor the HeapRegionSeq class. Reviewed-by: brutisso ! make/excludeSrc.make + src/share/vm/gc_implementation/g1/g1BiasedArray.cpp + src/share/vm/gc_implementation/g1/g1BiasedArray.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.inline.hpp ! src/share/vm/gc_implementation/g1/vmStructs_g1.hpp ! src/share/vm/prims/jni.cpp Changeset: 03f493ce3a71 Author: brutisso Date: 2013-09-25 17:23 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/03f493ce3a71 8025228: assert(new_entry->reserved_words() == vs_word_size) fails in nightly Reviewed-by: mgerdin, tschatzl, jmasa ! src/share/vm/memory/metaspace.cpp ! src/share/vm/prims/jni.cpp Changeset: 461159cd7a91 Author: tschatzl Date: 2013-09-26 12:18 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/461159cd7a91 Merge ! src/share/vm/classfile/symbolTable.cpp Changeset: 3da9fad1391e Author: tschatzl Date: 2013-09-26 06:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3da9fad1391e Merge Changeset: 58043478c26d Author: amurillo Date: 2013-09-26 13:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/58043478c26d Merge Changeset: 6209b0ed51c0 Author: amurillo Date: 2013-09-26 13:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6209b0ed51c0 Added tag hs25-b52 for changeset 58043478c26d ! .hgtags Changeset: ebfa5793d349 Author: katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ebfa5793d349 Added tag jdk8-b110 for changeset 6209b0ed51c0 ! .hgtags Changeset: 24250c363d7f Author: amurillo Date: 2013-09-26 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/24250c363d7f 8025536: new hotspot build - hs25-b53 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 899ecf76b570 Author: dsimms Date: 2013-09-25 13:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/899ecf76b570 8023956: Provide a work-around to broken Linux 32 bit "Exec Shield" using CS for NX emulation (crashing with SI_KERNEL) Summary: Execute some code at a high virtual address value, and keep mapped Reviewed-by: coleenp, zgu ! src/os/linux/vm/os_linux.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.hpp Changeset: 5b1191bf0b4b Author: ctornqvi Date: 2013-09-25 17:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5b1191bf0b4b 8024677: [TESTBUG] Move tests for classes in /testlibrary Summary: Moved the tests to /testlibrary_tests and updated TEST.groups Reviewed-by: dholmes, sla ! test/TEST.groups - test/testlibrary/AssertsTest.java - test/testlibrary/OutputAnalyzerReportingTest.java - test/testlibrary/OutputAnalyzerTest.java + test/testlibrary_tests/AssertsTest.java + test/testlibrary_tests/OutputAnalyzerReportingTest.java + test/testlibrary_tests/OutputAnalyzerTest.java Changeset: c1fbf21c7397 Author: ctornqvi Date: 2013-09-25 17:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c1fbf21c7397 8024492: [TESTBUG] Test library class Platform.java needs to include methods for missing OS's and architectures Summary: Added methods for 32bit, arm, ppc, x64 and x86 Reviewed-by: zgu, hseigel, mseledtsov ! test/testlibrary/com/oracle/java/testlibrary/Platform.java Changeset: 190899198332 Author: hseigel Date: 2013-09-26 10:25 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/190899198332 7195622: CheckUnhandledOops has limited usefulness now Summary: Enable CHECK_UNHANDLED_OOPS in fastdebug builds across all supported platforms. Reviewed-by: coleenp, hseigel, dholmes, stefank, twisti, ihse, rdurbin Contributed-by: lois.foltan at oracle.com ! make/bsd/makefiles/fastdebug.make ! make/linux/makefiles/fastdebug.make ! make/windows/makefiles/fastdebug.make ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/dictionary.hpp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parOopClosures.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.inline.hpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceMirrorKlass.hpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/oops/oopsHierarchy.hpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vframeArray.cpp ! src/share/vm/services/classLoadingService.cpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/memoryManager.cpp ! src/share/vm/services/memoryPool.cpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp ! src/share/vm/utilities/hashtable.cpp ! src/share/vm/utilities/taskqueue.hpp Changeset: a5ac0873476c Author: zgu Date: 2013-09-27 10:08 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a5ac0873476c Merge ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 36b97be47bde Author: acorn Date: 2013-10-01 08:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/36b97be47bde 8011311: Private interface methods. Default conflicts:ICCE. no erased_super_default. Reviewed-by: coleenp, bharadwaj, minqi ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/classfile/defaultMethods.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/klassVtable.cpp Changeset: de059a14e159 Author: zgu Date: 2013-10-01 08:54 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/de059a14e159 8022187: Missing ResourceMark crash when assertion using FormatBufferResource fails Summary: Uses stack for the format buffer instead of resource memory Reviewed-by: kvn, coleenp ! src/share/vm/utilities/array.hpp Changeset: 90b27e931639 Author: zgu Date: 2013-10-01 09:21 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/90b27e931639 Merge Changeset: 31f0118ea584 Author: zgu Date: 2013-10-01 11:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/31f0118ea584 Merge Changeset: 72b7e96c1922 Author: twisti Date: 2013-09-26 12:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/72b7e96c1922 8024545: make develop and notproduct flag values available in product builds Reviewed-by: dholmes, kvn ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/globals_extension.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/classLoadingService.cpp ! src/share/vm/services/dtraceAttacher.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/memoryService.cpp Changeset: c9ccd7b85f20 Author: rbackman Date: 2013-09-27 08:39 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c9ccd7b85f20 8024924: Intrinsify java.lang.Math.addExact Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/classes.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp + src/share/vm/opto/mathexactnode.cpp + src/share/vm/opto/mathexactnode.hpp ! src/share/vm/opto/multnode.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/subnode.hpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/vmStructs.cpp + test/compiler/intrinsics/mathexact/CondTest.java + test/compiler/intrinsics/mathexact/ConstantTest.java + test/compiler/intrinsics/mathexact/LoadTest.java + test/compiler/intrinsics/mathexact/LoopDependentTest.java + test/compiler/intrinsics/mathexact/NonConstantTest.java + test/compiler/intrinsics/mathexact/Verify.java Changeset: 510fbd28919c Author: anoll Date: 2013-09-27 10:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/510fbd28919c 8020151: PSR:PERF Large performance regressions when code cache is filled Summary: Code cache sweeping based on method hotness; removed speculatively disconnect Reviewed-by: kvn, iveresov ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/runtime/vm_operations.hpp ! src/share/vm/trace/trace.xml Changeset: a07c25e4f67e Author: adlertz Date: 2013-09-27 12:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a07c25e4f67e Merge ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/services/attachListener.cpp Changeset: 1c3486050433 Author: adlertz Date: 2013-09-27 15:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1c3486050433 Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: e8e077292da3 Author: iignatyev Date: 2013-09-28 12:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e8e077292da3 8024678: Java source files in hotspot/test/testlibrary should not use @author tag in JavaDoc Reviewed-by: twisti ! test/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassPathDirEntry.java ! test/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassPathJarEntry.java ! test/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassPathJarInDirEntry.java ! test/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassesListInFile.java ! test/testlibrary/ctw/src/sun/hotspot/tools/ctw/CompileTheWorld.java ! test/testlibrary/ctw/src/sun/hotspot/tools/ctw/Compiler.java ! test/testlibrary/ctw/src/sun/hotspot/tools/ctw/PathHandler.java ! test/testlibrary/ctw/src/sun/hotspot/tools/ctw/Utils.java Changeset: 303826f477c6 Author: iignatyev Date: 2013-09-28 12:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/303826f477c6 8023452: TestCase$Helper(java.lang.Object) must be osr_compiled Reviewed-by: kvn ! test/compiler/whitebox/CompilerWhiteBoxTest.java ! test/compiler/whitebox/DeoptimizeAllTest.java ! test/compiler/whitebox/DeoptimizeMethodTest.java ! test/compiler/whitebox/EnqueueMethodForCompilationTest.java ! test/compiler/whitebox/IsMethodCompilableTest.java ! test/compiler/whitebox/MakeMethodNotCompilableTest.java Changeset: f2512d89ad0c Author: twisti Date: 2013-09-28 12:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f2512d89ad0c 8025613: clang: remove -Wno-unused-value Reviewed-by: iveresov ! agent/src/os/linux/LinuxDebuggerLocal.c ! agent/src/os/linux/ps_proc.c ! agent/src/os/linux/salibelf.c ! agent/src/os/linux/symtab.c ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/gcc.make ! src/cpu/x86/vm/assembler_x86.cpp ! src/share/vm/classfile/defaultMethods.cpp Changeset: 29bdcf12457c Author: shade Date: 2013-09-27 11:52 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/29bdcf12457c 8014447: Object.hashCode intrinsic breaks inline caches Summary: Try to inline as normal method first, then fall back to intrinsic. Reviewed-by: kvn, twisti ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/library_call.cpp Changeset: d8d059e90ec1 Author: twisti Date: 2013-09-30 15:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d8d059e90ec1 8025599: Missing store barrier with OptimizeStringConcat Reviewed-by: kvn, twisti Contributed-by: Axel Siebenborn ! src/share/vm/opto/graphKit.cpp Changeset: dc261f466b6d Author: drchase Date: 2013-09-27 13:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dc261f466b6d 8025260: Methodhandles/JSR292: NullPointerException (NPE) thrown instead of AbstractMethodError (AME) Summary: Copied null-checks from templateInterpreter_CPU into methodHandles_CPU Reviewed-by: jrose, twisti ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp + test/compiler/jsr292/methodHandleExceptions/ByteClassLoader.java + test/compiler/jsr292/methodHandleExceptions/C.java + test/compiler/jsr292/methodHandleExceptions/I.java + test/compiler/jsr292/methodHandleExceptions/TestAMEnotNPE.java Changeset: cacc4c6bfc80 Author: vlivanov Date: 2013-10-02 06:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cacc4c6bfc80 8025233: Move sun.invoke.Stable into java.lang.invoke package Reviewed-by: twisti, iveresov ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/vmSymbols.hpp Changeset: 268e7a2178d7 Author: iveresov Date: 2013-10-03 16:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/268e7a2178d7 Merge ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/services/classLoadingService.cpp Changeset: d68894a09c7c Author: jiangli Date: 2013-09-27 13:49 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d68894a09c7c 8024990: JT_JDK: 11 failures with SIGSEGV on arm-sflt platforms in nightly fastdebug build. Summary: Enable patching for load_appendix_id. Reviewed-by: kvn, dlong, bdelsart ! src/share/vm/c1/c1_Runtime1.cpp Changeset: 5186dcaca431 Author: jiangli Date: 2013-09-27 13:53 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5186dcaca431 Merge ! src/share/vm/c1/c1_Runtime1.cpp - test/gc/metaspace/ClassMetaspaceSizeInJmapHeap.java - test/runtime/6878713/Test6878713.sh - test/runtime/6878713/testcase.jar - test/runtime/7020373/Test7020373.sh - test/runtime/7020373/testcase.jar Changeset: d0cfa6502dfe Author: jprovino Date: 2013-10-03 10:25 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d0cfa6502dfe Merge ! src/share/vm/c1/c1_Runtime1.cpp Changeset: 100614790c1e Author: vladidan Date: 2013-10-03 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/100614790c1e Merge Changeset: c319b188c7b2 Author: tschatzl Date: 2013-09-26 12:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c319b188c7b2 8014078: G1: improve remembered set summary information by providing per region type information Summary: Add memory consumption breakdown on a per region type in the G1 remembered set summary statistics. This simplifies remembered set memory consumption analysis. Reviewed-by: brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1RemSetSummary.cpp ! test/gc/g1/TestSummarizeRSetStats.java + test/gc/g1/TestSummarizeRSetStatsPerRegion.java + test/gc/g1/TestSummarizeRSetStatsTools.java Changeset: bc918fd1e584 Author: mgerdin Date: 2013-09-27 10:23 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bc918fd1e584 8025279: metaspace/flags/maxMetaspaceSize throws OOM: out of Compressed Klass space Summary: Only put "Compressed class space" as OOM cause if actually using Compressed class space Reviewed-by: jwilhelm, stefank, ehelin, coleenp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp Changeset: 4fa18058548e Author: tschatzl Date: 2013-09-27 11:18 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4fa18058548e Merge Changeset: ccef6e165e8b Author: tschatzl Date: 2013-09-27 13:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ccef6e165e8b Merge Changeset: d55c004e1d4d Author: mgerdin Date: 2013-09-24 14:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d55c004e1d4d 8025305: Cleanup CardTableModRefBS usage in G1 Summary: Move some G1 specific code from CardTableModRefBS to G1SATBCardTableModRefBS. Reviewed-by: brutisso, tschatzl, ehelin ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/g1CardCounts.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/g1EvacFailure.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp Changeset: 7ec10139bf37 Author: tschatzl Date: 2013-09-30 12:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7ec10139bf37 8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads Summary: The initialization for the remembered set summary data structures used the wrong thread count, i.e. number of worker threads instead of number of refinement threads. Reviewed-by: brutisso ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSetSummary.cpp ! src/share/vm/gc_implementation/g1/g1RemSetSummary.hpp + test/gc/g1/TestSummarizeRSetStatsThreads.java Changeset: 9de9169ddde6 Author: brutisso Date: 2013-10-01 07:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9de9169ddde6 8025605: G1: Heap expansion logging misleading for fully expanded heap Reviewed-by: tschatzl, jwilhelm, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: 9ecd6d3782b1 Author: ehelin Date: 2013-10-01 15:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9ecd6d3782b1 8025313: MetaspaceMemoryPool incorrectly reports undefined size for max Reviewed-by: stefank, tschatzl ! src/share/vm/memory/collectorPolicy.cpp Changeset: 77a774ab3cf0 Author: mgerdin Date: 2013-10-02 14:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/77a774ab3cf0 8012525: gc/metaspace/G1AddMetaspaceDependency.java Test fails a safepoint timeout assertion or hangs. Reviewed-by: brutisso, tschatzl ! test/gc/metaspace/G1AddMetaspaceDependency.java Changeset: 6e22e7042433 Author: ehelin Date: 2013-09-30 11:39 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6e22e7042433 8025226: TestPerfCountersAndMemoryPools.java fails with -Xmixed or -Xcomp Reviewed-by: brutisso, mgerdin ! test/gc/metaspace/TestPerfCountersAndMemoryPools.java Changeset: 379ef2cc19c0 Author: ehelin Date: 2013-10-02 18:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/379ef2cc19c0 Merge Changeset: ab68fc0101ce Author: jwilhelm Date: 2013-10-03 13:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ab68fc0101ce 8025855: Simplify GenRemSet code slightly Summary: Remove a few redundant switch-statements Reviewed-by: jcoomes, tschatzl ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/genRemSet.cpp Changeset: c49c7f835e8d Author: jwilhelm Date: 2013-10-03 17:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c49c7f835e8d 8025853: Remove unnecessary uses of GenerationSizer Summary: Removed stray includes and some minor cleanup of GenerationSizer Reviewed-by: tschatzl, jcoomes ! src/share/vm/gc_implementation/parallelScavenge/generationSizer.hpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp Changeset: 798522662fcd Author: jcoomes Date: 2013-10-04 13:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/798522662fcd Merge ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp Changeset: 562a3d356de6 Author: amurillo Date: 2013-10-04 14:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/562a3d356de6 Merge - test/testlibrary/AssertsTest.java - test/testlibrary/OutputAnalyzerReportingTest.java - test/testlibrary/OutputAnalyzerTest.java Changeset: f6962730bbde Author: amurillo Date: 2013-10-04 14:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f6962730bbde Added tag hs25-b53 for changeset 562a3d356de6 ! .hgtags Changeset: 02d171a3b5d1 Author: cl Date: 2013-10-10 10:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/02d171a3b5d1 Added tag jdk8-b111 for changeset f6962730bbde ! .hgtags From robert.field at oracle.com Fri Oct 11 06:27:37 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Fri, 11 Oct 2013 06:27:37 +0000 Subject: hg: jdk8/tl/langtools: 8012557: Implement lambda methods on interfaces as private; ... Message-ID: <20131011062740.CD92362F5F@hg.openjdk.java.net> Changeset: 1ce8405af5fe Author: rfield Date: 2013-10-10 23:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ce8405af5fe 8012557: Implement lambda methods on interfaces as private 8016320: Method reference in subinterface of type I.super::foo produces exception at runtime Summary: Now that the VM supports interface instance private methods, lambda methods and lambda bridges are always private. Access is now through invokespecial. Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java + test/tools/javac/lambda/8012557/A.java + test/tools/javac/lambda/8012557/B.java + test/tools/javac/lambda/8012557/C.java + test/tools/javac/lambda/8012557/PrivateLambdas.java + test/tools/javac/lambda/8012557/SAM.java + test/tools/javac/lambda/8016320/IllegalBridgeModifier.java From lana.steuck at oracle.com Fri Oct 11 04:36:19 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 Oct 2013 04:36:19 +0000 Subject: hg: jdk8/tl/jdk: 96 new changesets Message-ID: <20131011045629.B3ECD62F5A@hg.openjdk.java.net> Changeset: 529cd4de1823 Author: prr Date: 2013-09-26 15:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/529cd4de1823 7092764: java.awt.font.TransformAttribute.equals(null) throws NPE Reviewed-by: jgodinez, jchen ! src/share/classes/java/awt/font/TransformAttribute.java + test/java/awt/font/TransformAttribute/TransformEqualityTest.java Changeset: 1bcd48cfb7be Author: ceisserer Date: 2013-09-26 16:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1bcd48cfb7be 8024895: xrender MaskImage cache isn't accounting for change in alpha Reviewed-by: prr, jchen ! src/solaris/classes/sun/java2d/xr/XRMaskImage.java + test/java/awt/image/DrawImage/EABlitTest.java Changeset: dae020405903 Author: lana Date: 2013-09-26 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dae020405903 Merge Changeset: 0151f12bd392 Author: malenkov Date: 2013-08-22 17:17 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0151f12bd392 8023536: Some regression tests have a wrong header Reviewed-by: alexsch ! test/java/beans/Performance/Test7122740.java ! test/java/beans/Performance/Test7184799.java ! test/javax/swing/JTree/8013571/Test8013571.java Changeset: b71f112dab2a Author: malenkov Date: 2013-08-22 21:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b71f112dab2a 7057769: JScrollBar spec should specify that unit increment & decrement functionality may not be present Reviewed-by: alexsch ! src/share/classes/javax/swing/JScrollBar.java Changeset: f983fd18dd81 Author: malenkov Date: 2013-08-23 19:29 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f983fd18dd81 7080613: java.beans.DefaultPersistenceDelegate.instantiate(..) doesn't throw NPE Reviewed-by: alexsch ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/PersistenceDelegate.java Changeset: 22ef5187a3e6 Author: dmarkov Date: 2013-08-26 17:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/22ef5187a3e6 8023474: First mousepress doesn't start editing in JTree Reviewed-by: alexp, anthony ! src/share/classes/java/awt/Component.java ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java ! src/share/classes/sun/awt/AWTAccessor.java + test/javax/swing/plaf/basic/BasicTreeUI/8023474/bug8023474.java Changeset: abd068530590 Author: malenkov Date: 2013-08-27 12:53 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abd068530590 7195179: ClassCastException for null values in JComboBox Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java + test/javax/swing/JComboBox/7195179/Test7195179.java Changeset: 92adff44c841 Author: malenkov Date: 2013-08-27 13:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92adff44c841 8021379: JFileChooser Create New Folder button enabled in write proteced directory Reviewed-by: alexsch ! src/share/classes/sun/swing/FilePane.java Changeset: 4bfcf9c5ced3 Author: malenkov Date: 2013-08-27 13:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bfcf9c5ced3 8022398: javax/swing/JFileChooser/8013442/Test8013442.java fails Reviewed-by: alexsch ! src/macosx/classes/com/apple/laf/AquaFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java ! src/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java + src/share/classes/sun/swing/AbstractFilterComboBoxModel.java ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java Changeset: e11ed7187b0c Author: lana Date: 2013-08-27 21:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e11ed7187b0c Merge - src/share/classes/com/sun/security/auth/PolicyParser.java - src/share/classes/com/sun/security/auth/SubjectCodeSource.java - src/share/classes/java/util/jar/UnsupportedProfileException.java - src/share/classes/sun/security/provider/ConfigSpiFile.java - test/java/net/URLClassLoader/profiles/Basic.java - test/java/net/URLClassLoader/profiles/Lib.java - test/java/net/URLClassLoader/profiles/basic.sh - test/tools/jar/AddAndUpdateProfile.java - test/tools/launcher/profiles/Basic.java - test/tools/launcher/profiles/Logging.java - test/tools/launcher/profiles/Main.java - test/tools/launcher/profiles/VersionCheck.java Changeset: 43de418f1345 Author: ptbrunet Date: 2013-08-28 17:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43de418f1345 8011955: Lunar screen reader crashes intermittently in WindowsAccessBridge-32.DLL 6995891: JAWS will occasionally stop speaking focused objects as user TABs -> problem with message queue 8014738: Combobox menu items are not announced with JAWS 8011938: Java Ferret example corrupts JCombobox of the running application 8012011: JAB 2.0.2 incompletely shows kbd accelerator in menus 8022966: Java Access Bridge no longer usable with screen magnifiers Reviewed-by: raginip, tbell, erikj, art ! make/bridge/AccessBridgeJava/Makefile ! makefiles/CompileJavaClasses.gmk ! makefiles/GensrcMisc.gmk Changeset: 35644adc3269 Author: malenkov Date: 2013-08-28 17:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35644adc3269 6968363: ClassCastException while entering HINDI characters with CustomDocument Reviewed-by: alexsch ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/share/classes/javax/swing/text/GlyphPainter2.java ! src/share/classes/javax/swing/text/ParagraphView.java + test/javax/swing/text/AbstractDocument/6968363/Test6968363.java Changeset: 6432f8749e1d Author: pchelko Date: 2013-08-30 11:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6432f8749e1d 8023966: JViewPort.BLIT_SCROLL_MODE does not work in JLightweightFrame Reviewed-by: anthony, ant ! src/share/classes/javax/swing/JViewport.java Changeset: 7151f08eeadf Author: alexsch Date: 2013-08-30 13:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7151f08eeadf 8022401: [macosx] javax/swing/text/JTextComponent/5074573/bug5074573.java fails Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTEvent.m + test/java/awt/event/KeyEvent/KeyChar/KeyCharTest.java Changeset: f2f614e31522 Author: malenkov Date: 2013-09-02 14:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2f614e31522 7156658: JTextComponent.setFocusAccelerator() spec does not state that focus accelerator is L&F dependent Reviewed-by: alexsch ! src/share/classes/javax/swing/text/JTextComponent.java Changeset: 6ffa2680e139 Author: art Date: 2013-09-02 16:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ffa2680e139 8022184: Fix static , Raw warnings in classes belonging to java.awt Reviewed-by: art, anthony Contributed-by: Srikalyan Chandrashekar ! src/share/classes/java/awt/AWTKeyStroke.java ! src/share/classes/java/awt/CardLayout.java ! src/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/GradientPaintContext.java ! src/share/classes/java/awt/GraphicsEnvironment.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/SequencedEvent.java ! src/share/classes/java/awt/TexturePaintContext.java ! src/share/classes/java/awt/WaitDispatchSupport.java Changeset: b5ed8686cc01 Author: malenkov Date: 2013-09-03 11:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b5ed8686cc01 6943780: JTabbedPane throws ArrayIndexOutOfBoundsException sometimes Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java + test/javax/swing/plaf/basic/BasicTabbedPaneUI/Test6943780.java Changeset: 80a8c4ff3b51 Author: alexsch Date: 2013-09-03 17:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/80a8c4ff3b51 8007156: [macosx] Wrong events in processKeyBinding of JTable Submit Date Reviewed-by: leonidr ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java + test/java/awt/event/KeyEvent/ExtendedKeyCode/ExtendedKeyCodeTest.java Changeset: 2ad01ecbaf90 Author: malenkov Date: 2013-09-03 21:53 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ad01ecbaf90 7172865: PropertyDescriptor fails to work with setter method name if setter is non-void Reviewed-by: art, alexsch ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/MethodDescriptor.java + src/share/classes/java/beans/MethodRef.java ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/Introspector/Test7172865.java Changeset: ba711056009f Author: pchelko Date: 2013-09-04 14:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba711056009f 8021943: FileDialog getFile returns corrupted string after previous setFile Reviewed-by: anthony, serb Contributed-by: alexander.zvegintsev at oracle.com ! src/windows/native/sun/windows/awt_FileDialog.cpp Changeset: ba041df8a554 Author: mcherkas Date: 2013-09-04 18:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba041df8a554 8023565: JPG causes javax.imageio.IIOException: ICC APP2 encoutered without prior JFIF Reviewed-by: bae, vadim ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGMetadata.java Changeset: e4ba3d9ea041 Author: mcherkas Date: 2013-09-05 15:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4ba3d9ea041 8023392: Swing text components printed with spaces between chars Reviewed-by: alexsch, alexp Contributed-by: anton.nashatyrev at oracle.com ! src/share/classes/sun/swing/SwingUtilities2.java + test/java/awt/print/bug8023392/bug8023392.html + test/java/awt/print/bug8023392/bug8023392.java Changeset: d267c066b006 Author: lana Date: 2013-09-06 15:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d267c066b006 Merge - src/share/classes/sun/misc/Compare.java - src/share/classes/sun/misc/Sort.java Changeset: fbb6f976d780 Author: alexsch Date: 2013-09-09 17:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fbb6f976d780 8024413: Add tests for issues JDK-8002077 and JDK-7199708 Reviewed-by: malenkov, leonidr + test/javax/swing/JFileChooser/7199708/bug7199708.java + test/javax/swing/JFileChooser/8002077/bug8002077.java Changeset: 3ea08767fc0d Author: alexsch Date: 2013-09-09 18:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3ea08767fc0d 8020060: MoleculeViewerTest demo doesn't work due to SecurityPermissions Reviewed-by: malenkov, erikj ! makefiles/CompileDemos.gmk ! src/share/demo/applets/MoleculeViewer/XYZApp.java ! src/share/demo/applets/MoleculeViewer/example1.html ! src/share/demo/applets/MoleculeViewer/example2.html ! src/share/demo/applets/MoleculeViewer/example3.html ! src/share/demo/applets/WireFrame/ThreeD.java ! src/share/demo/applets/WireFrame/example1.html ! src/share/demo/applets/WireFrame/example2.html ! src/share/demo/applets/WireFrame/example3.html ! src/share/demo/applets/WireFrame/example4.html Changeset: fc5d16fec25f Author: serb Date: 2013-09-09 21:03 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc5d16fec25f 8023042: Inaccuracy in documentation in a sound area Reviewed-by: prr ! src/share/classes/javax/sound/sampled/AudioFileFormat.java ! src/share/classes/javax/sound/sampled/AudioFormat.java Changeset: 9d0d961fb1cd Author: pchelko Date: 2013-09-10 11:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d0d961fb1cd 8024381: The test for 8020210 does not have @bug tag Reviewed-by: anthony, serb ! test/java/awt/Window/MaximizeOffscreen/MaximizeOffscreenTest.java Changeset: 8b6dace81d6c Author: alexsch Date: 2013-09-10 14:33 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8b6dace81d6c 8021253: JFileChooser does not react on pressing enter since java 7 Reviewed-by: malenkov ! src/share/classes/javax/swing/JFileChooser.java + test/javax/swing/JFileChooser/8021253/bug8021253.java Changeset: 1daffcf035c4 Author: malenkov Date: 2013-09-10 17:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1daffcf035c4 7057770: (spec)Scrollbar spec should specify that unit increment & decrement functionality may not be present Reviewed-by: alexsch ! src/share/classes/java/awt/Scrollbar.java Changeset: eedb2b6d93ec Author: malenkov Date: 2013-09-10 17:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eedb2b6d93ec 8024407: [macosx] javax/swing/JScrollBar/7163696/Test7163696.java failed intermittently on macos Reviewed-by: alexsch ! test/javax/swing/JScrollBar/7163696/Test7163696.java Changeset: 0cc00c11e17e Author: leonidr Date: 2013-09-10 20:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cc00c11e17e 8003901: [macosx] Need test for JDK-8002114 Reviewed-by: anthony, serb ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java Changeset: 04fbd34fda7b Author: bagiras Date: 2013-09-12 14:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04fbd34fda7b 8003965: Toolkit.beep() documentation is ambiguous Reviewed-by: anthony ! src/share/classes/java/awt/Toolkit.java Changeset: def1fa9854f7 Author: bagiras Date: 2013-09-12 15:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/def1fa9854f7 7064312: Cleanup: avoid using unsafe string function Reviewed-by: serb, pchelko ! src/windows/native/sun/windows/awt_FileDialog.cpp ! src/windows/native/sun/windows/awt_Font.cpp ! src/windows/native/sun/windows/awt_PrintControl.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_TrayIcon.cpp ! src/windows/native/sun/windows/awt_ole.cpp Changeset: 6321e4429a38 Author: serb Date: 2013-09-12 18:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6321e4429a38 7124537: [macosx] Menu shortcuts for all menu items should be disabled if a menu itself is disabled Reviewed-by: anthony, leonidr ! src/macosx/classes/sun/lwawt/macosx/CMenu.java ! src/macosx/classes/sun/lwawt/macosx/CMenuItem.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java Changeset: 3213c388740a Author: dmarkov Date: 2013-09-12 18:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3213c388740a 8024395: Improve fix for line break calculations Reviewed-by: alexp, alexsch ! src/share/classes/javax/swing/text/FlowView.java ! src/share/classes/javax/swing/text/View.java ! test/javax/swing/text/View/8014863/bug8014863.java Changeset: ef2f0c15b332 Author: pchelko Date: 2013-09-13 11:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef2f0c15b332 8024170: [SwingNode] Implement cursor change Reviewed-by: anthony, ant ! src/macosx/classes/sun/lwawt/LWLightweightFramePeer.java ! src/share/classes/sun/swing/JLightweightFrame.java ! src/share/classes/sun/swing/LightweightContent.java ! src/share/classes/sun/swing/SwingAccessor.java ! src/solaris/classes/sun/awt/X11/XLightweightFramePeer.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WLightweightFramePeer.java Changeset: 12788c245d67 Author: pchelko Date: 2013-09-13 17:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12788c245d67 8015453: java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java failed on windows with jdk8 since b86 Reviewed-by: art, serb ! src/share/classes/sun/awt/datatransfer/DataTransferer.java Changeset: df107b1f2f2e Author: pchelko Date: 2013-09-13 17:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df107b1f2f2e 8015371: The HTML text without tags does not appear inside the WordPad application, and we try to click the button, but the case exits. Reviewed-by: anthony, serb ! src/windows/classes/sun/awt/windows/WDataTransferer.java Changeset: 40fdf56c09a9 Author: pchelko Date: 2013-09-13 17:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40fdf56c09a9 8015455: java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows Reviewed-by: serb, anthony ! src/share/classes/java/awt/dnd/DropTarget.java ! src/share/classes/javax/swing/TransferHandler.java Changeset: 915d13946f18 Author: mcherkas Date: 2013-09-13 17:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/915d13946f18 8015601: [macosx] Test javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java fails on MacOS X Reviewed-by: alexp, alexsch ! test/javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java Changeset: ad52e924c55a Author: kshefov Date: 2013-09-13 17:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ad52e924c55a 8006087: [TEST_BUG] The BACKSPACE key doesn't work and after pressing 'cancel' and 'DONE' button, the case pass automatically. Reviewed-by: alexsch, serb ! test/javax/swing/JFileChooser/4150029/bug4150029.html ! test/javax/swing/JFileChooser/4150029/bug4150029.java Changeset: c8a85165b725 Author: kshefov Date: 2013-09-13 17:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8a85165b725 8015597: [TEST_BUG] [macosx] Test closed/javax/swing/JMenuBar/4750590/bug4750590.java fails since JDK 8 b75 on MacOSX Reviewed-by: alexsch, serb + test/javax/swing/JMenuBar/4750590/bug4750590.java Changeset: 17cc8f13e4e7 Author: pchelko Date: 2013-09-13 18:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17cc8f13e4e7 8012026: [macosx] Component.getMousePosition() does not work in an applet on MacOS Reviewed-by: anthony, serb ! make/sun/lwawt/FILES_export_macosx.gmk - src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/AWTView.m + test/java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java + test/java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java Changeset: a46d22ee4d4b Author: alexsch Date: 2013-09-16 17:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a46d22ee4d4b 8008728: [macosx] Swing. JDialog. Modal dialog goes to background Reviewed-by: serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m + test/java/awt/Modal/ModalDialogOrderingTest/ModalDialogOrderingTest.java Changeset: 8f5b4e7623cf Author: ant Date: 2013-09-16 18:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f5b4e7623cf 8022512: JLightweightFrame: the content pane should be transparent Reviewed-by: anthony ! src/share/classes/sun/swing/JLightweightFrame.java Changeset: 49c7d299a504 Author: kshefov Date: 2013-09-16 19:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49c7d299a504 7020060: [TEST_BUG] java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java failed Reviewed-by: anthony, serb ! test/java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java Changeset: 98080e9367be Author: kshefov Date: 2013-09-16 19:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98080e9367be 8015588: [TEST_BUG] [macosx] Test java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java fails on MacOSX Reviewed-by: anthony, serb ! test/java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java Changeset: 04612a52e7bd Author: pchelko Date: 2013-09-16 19:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04612a52e7bd 8024779: [macosx] SwingNode crashes on exit Reviewed-by: anthony, ant ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 4e88bf592830 Author: pchelko Date: 2013-09-16 19:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4e88bf592830 8024485: For 5-1 step: if input something into the 'File:' and 'Dir:', the dir output isn't empty in the output window after showing and canceling the file dialog Reviewed-by: serb, anthony ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java Changeset: 8530456e0091 Author: omajid Date: 2013-09-16 15:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8530456e0091 8024863: X11: Support GNOME Shell as mutter Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XWM.java Changeset: 4899f6734a14 Author: ant Date: 2013-09-18 12:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4899f6734a14 8024839: [Unified Swing/Fx threading] don't schedule an event dispatching from the event dispatch thread Reviewed-by: anthony, pchelko ! src/share/classes/java/awt/EventQueue.java Changeset: cc7a15f4c735 Author: mcherkas Date: 2013-09-18 15:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc7a15f4c735 8016746: Test javax/swing/JTable/7068740/bug7068740.java fails Reviewed-by: serb, alexsch ! test/javax/swing/JTable/7068740/bug7068740.java Changeset: 2c240454c192 Author: leonidr Date: 2013-09-18 18:36 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c240454c192 7188071: closed/java/awt/TrayIcon/TrayIconSecurity/GrantedTrayIconTest fails Reviewed-by: anthony, serb ! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java Changeset: 20b1135647fa Author: lana Date: 2013-09-18 16:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/20b1135647fa Merge ! src/share/classes/java/awt/Toolkit.java - src/share/classes/java/util/stream/CloseableStream.java - src/share/classes/java/util/stream/DelegatingStream.java ! src/share/classes/sun/swing/SwingUtilities2.java ! src/windows/native/sun/windows/awt_PrintControl.cpp - test/java/util/Collection/ListDefaults.java - test/java/util/Map/CheckRandomHashSeed.java - test/java/util/Map/TreeBinSplitBackToEntries.java - test/java/util/concurrent/ConcurrentHashMap/toArray.java - test/sun/tools/jconsole/ImmutableResourceTest.java - test/sun/tools/jconsole/ImmutableResourceTest.sh Changeset: e292d504ad68 Author: leonidr Date: 2013-09-19 22:33 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e292d504ad68 7144065: [macosx] Orphaned Choice popup window Reviewed-by: anthony, serb Contributed-by: alexander.potochkin at oracle.com ! src/macosx/classes/sun/lwawt/LWChoicePeer.java Changeset: 602e5d0141d3 Author: leonidr Date: 2013-09-19 23:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/602e5d0141d3 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol Reviewed-by: anthony, serb ! makefiles/GensrcProperties.gmk + src/macosx/classes/sun/awt/resources/awtosx.properties ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/sun/awt/AWTAccessor.java + test/java/awt/Toolkit/ToolkitPropertyTest/bug7129133.java Changeset: c04e55e17066 Author: kshefov Date: 2013-09-20 17:07 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c04e55e17066 7124314: [TEST_BUG] [macosx] Aqua LAF: JTree doesn't select element by keyboards left and right keys Reviewed-by: alexsch, serb Contributed-by: vera.akulova at oracle.com + test/javax/swing/JTree/4927934/bug4927934.java Changeset: 6c1f9468f3de Author: kshefov Date: 2013-09-20 17:16 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6c1f9468f3de 8017180: [macosx] [TEST_BUG] alt-key doesn't work on macos for menu Reviewed-by: alexsch, serb Contributed-by: vera.akulova at oracle.com + test/java/awt/Focus/KeyEventForBadFocusOwnerTest/KeyEventForBadFocusOwnerTest.java + test/javax/swing/JMenuItem/4171437/bug4171437.java + test/javax/swing/JPopupMenu/4458079/bug4458079.java Changeset: f139aef966fd Author: kshefov Date: 2013-09-20 17:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f139aef966fd 7124232: [TEST_BUG] [macosx] JSplitPane has wrong divider location Reviewed-by: alexsch, serb Contributed-by: vera.akulova at oracle.com + test/javax/swing/JSplitPane/4816114/bug4816114.java Changeset: abebe03818f6 Author: malenkov Date: 2013-09-20 18:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abebe03818f6 7024235: Nimbus L&F: wrong "packing" of a frame containing tabbed pane Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java + test/javax/swing/JTabbedPane/7024235/Test7024235.java Changeset: 2ac59698de38 Author: kshefov Date: 2013-09-23 16:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ac59698de38 8015600: [TEST_BUG] [macosx] Test closed/javax/swing/plaf/basic/BasicMenuUI/4983388/bug4983388.java fails since JDK 8 b75 on MacOSX Reviewed-by: alexsch, serb + test/javax/swing/plaf/basic/BasicMenuUI/4983388/bug4983388.java Changeset: eac52fe3990c Author: serb Date: 2013-09-23 16:17 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eac52fe3990c 8005255: [macosx] Cleanup warnings in sun.lwawt Reviewed-by: alexsch, anthony ! make/sun/lwawt/FILES_export_macosx.gmk ! src/macosx/classes/sun/lwawt/LWButtonPeer.java ! src/macosx/classes/sun/lwawt/LWCanvasPeer.java ! src/macosx/classes/sun/lwawt/LWCheckboxPeer.java ! src/macosx/classes/sun/lwawt/LWChoicePeer.java ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWContainerPeer.java ! src/macosx/classes/sun/lwawt/LWCursorManager.java ! src/macosx/classes/sun/lwawt/LWLabelPeer.java ! src/macosx/classes/sun/lwawt/LWListPeer.java ! src/macosx/classes/sun/lwawt/LWMouseInfoPeer.java ! src/macosx/classes/sun/lwawt/LWPanelPeer.java ! src/macosx/classes/sun/lwawt/LWRepaintArea.java ! src/macosx/classes/sun/lwawt/LWScrollBarPeer.java ! src/macosx/classes/sun/lwawt/LWScrollPanePeer.java ! src/macosx/classes/sun/lwawt/LWTextAreaPeer.java ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java - src/macosx/classes/sun/lwawt/SelectionClearListener.java Changeset: 2684fd4e9f3b Author: serb Date: 2013-09-23 17:55 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2684fd4e9f3b 7172833: For default java.awt.Toolkit impl methods java.awt.Toolkit.is/setDynamicLayout() are not consistent Reviewed-by: alexsch, anthony ! src/share/classes/java/awt/Toolkit.java + test/java/awt/Toolkit/DynamicLayout/bug7172833.java Changeset: d73d3a29065c Author: serb Date: 2013-09-23 21:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d73d3a29065c 8019282: keyRelesed is reached even though key was NOT released Reviewed-by: serb, anthony Contributed-by: alexander.zvegintsev at oracle.com ! make/sun/xawt/mapfile-vers ! makefiles/mapfiles/libawt_xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XlibWrapper.java ! src/solaris/native/sun/xawt/XlibWrapper.c Changeset: 8c0b943a0090 Author: yan Date: 2013-09-24 12:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c0b943a0090 8025114: Eliminate doclint errors in java.awt.dnd package javadoc Reviewed-by: serb, alexsch ! src/share/classes/java/awt/dnd/DragGestureRecognizer.java ! src/share/classes/java/awt/dnd/DragSource.java ! src/share/classes/java/awt/dnd/DragSourceContext.java ! src/share/classes/java/awt/dnd/DragSourceDragEvent.java ! src/share/classes/java/awt/dnd/DragSourceDropEvent.java ! src/share/classes/java/awt/dnd/DragSourceEvent.java ! src/share/classes/java/awt/dnd/DropTarget.java ! src/share/classes/java/awt/dnd/DropTargetDragEvent.java ! src/share/classes/java/awt/dnd/DropTargetDropEvent.java Changeset: 1303823e89da Author: yan Date: 2013-09-24 16:36 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1303823e89da 8025230: [cleanup] some more javadoc formatting fixes for swing Reviewed-by: alexsch ! src/share/classes/javax/swing/JPanel.java ! src/share/classes/javax/swing/JPasswordField.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JRadioButton.java ! src/share/classes/javax/swing/JRadioButtonMenuItem.java ! src/share/classes/javax/swing/JRootPane.java ! src/share/classes/javax/swing/JScrollPane.java ! src/share/classes/javax/swing/JSeparator.java ! src/share/classes/javax/swing/JSlider.java ! src/share/classes/javax/swing/JSpinner.java ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JTextArea.java ! src/share/classes/javax/swing/JTextField.java ! src/share/classes/javax/swing/JToolBar.java ! src/share/classes/javax/swing/JToolTip.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/JViewport.java ! src/share/classes/javax/swing/KeyStroke.java ! src/share/classes/javax/swing/OverlayLayout.java ! src/share/classes/javax/swing/ProgressMonitor.java ! src/share/classes/javax/swing/SizeRequirements.java ! src/share/classes/javax/swing/SizeSequence.java Changeset: d580e0bc85d9 Author: yan Date: 2013-09-24 17:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d580e0bc85d9 8025117: [cleanup] Eliminate doclint errors in javax/swing/text classes Reviewed-by: alexsch ! src/share/classes/javax/swing/JLayer.java ! src/share/classes/javax/swing/RowFilter.java ! src/share/classes/javax/swing/plaf/TextUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/share/classes/javax/swing/text/AttributeSet.java ! src/share/classes/javax/swing/text/BadLocationException.java ! src/share/classes/javax/swing/text/BoxView.java ! src/share/classes/javax/swing/text/Caret.java ! src/share/classes/javax/swing/text/ComponentView.java ! src/share/classes/javax/swing/text/CompositeView.java ! src/share/classes/javax/swing/text/DefaultEditorKit.java ! src/share/classes/javax/swing/text/DefaultHighlighter.java ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/Document.java ! src/share/classes/javax/swing/text/DocumentFilter.java ! src/share/classes/javax/swing/text/EditorKit.java ! src/share/classes/javax/swing/text/FieldView.java ! src/share/classes/javax/swing/text/FlowView.java ! src/share/classes/javax/swing/text/GapContent.java ! src/share/classes/javax/swing/text/GlyphView.java ! src/share/classes/javax/swing/text/Highlighter.java ! src/share/classes/javax/swing/text/IconView.java ! src/share/classes/javax/swing/text/NavigationFilter.java ! src/share/classes/javax/swing/text/ParagraphView.java ! src/share/classes/javax/swing/text/PasswordView.java ! src/share/classes/javax/swing/text/PlainDocument.java ! src/share/classes/javax/swing/text/PlainView.java ! src/share/classes/javax/swing/text/Position.java ! src/share/classes/javax/swing/text/StringContent.java ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/javax/swing/text/StyledDocument.java ! src/share/classes/javax/swing/text/StyledEditorKit.java ! src/share/classes/javax/swing/text/TabExpander.java ! src/share/classes/javax/swing/text/TabableView.java ! src/share/classes/javax/swing/text/TableView.java ! src/share/classes/javax/swing/text/Utilities.java ! src/share/classes/javax/swing/text/View.java ! src/share/classes/javax/swing/text/WrappedPlainView.java ! src/share/classes/javax/swing/text/ZoneView.java ! src/share/classes/javax/swing/text/html/BlockView.java ! src/share/classes/javax/swing/text/html/CSS.java ! src/share/classes/javax/swing/text/html/FormView.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java Changeset: 58178aec7e81 Author: kshefov Date: 2013-09-24 17:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/58178aec7e81 7124320: [TEST_BUG] [macosx] JComboBox doesn't change selection on mouse over Reviewed-by: alexsch, serb Contributed-by: vera.akulova at oracle.com + test/javax/swing/JComboBox/6236162/bug6236162.java Changeset: f500844c2253 Author: kshefov Date: 2013-09-24 17:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f500844c2253 7133154: [TEST_BUG] [macosx] closed/javax/swing/JInternalFrame/4251301/bug4251301.java fails on MacOS Reviewed-by: alexsch, serb Contributed-by: vera.akulova at oracle.com + test/javax/swing/JInternalFrame/4251301/bug4251301.java Changeset: 967557d5b90a Author: kshefov Date: 2013-09-24 18:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/967557d5b90a 7133146: [macosx] closed/javax/swing/JInternalFrame/4193219/IconCoord fails on MacOS Reviewed-by: alexsch, serb Contributed-by: vera.akulova at oracle.com + test/javax/swing/JInternalFrame/4193219/IconCoord.java Changeset: 3982dd1210ba Author: kshefov Date: 2013-09-24 18:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3982dd1210ba 8015599: [TEST_BUG] [macosx] Test closed/javax/swing/Popup/TaskbarPositionTest.java fails since JDK 8 b75 on MacOSX Reviewed-by: alexsch, serb + test/javax/swing/Popup/TaskbarPositionTest.java Changeset: 2ed1584d62c5 Author: leonidr Date: 2013-09-24 18:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ed1584d62c5 8022555: [macosx] AppleScriptEngine.jar MUST call java.awt.Toolkit.getDefaultToolkit() lazily Reviewed-by: anthony, serb ! src/macosx/classes/apple/applescript/AppleScriptEngineFactory.java Changeset: a284da808700 Author: malenkov Date: 2013-09-25 14:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a284da808700 8023310: Thread contention in the method Beans.IsDesignTime() Reviewed-by: art, sfriberg ! src/share/classes/java/beans/ThreadGroupContext.java ! src/share/classes/java/beans/WeakIdentityMap.java Changeset: 10e66428ddb0 Author: alexsch Date: 2013-09-25 16:17 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/10e66428ddb0 8007155: [macosx] Disabled panel takes mouse input in JLayeredPane Reviewed-by: serb, anthony ! src/macosx/classes/sun/lwawt/LWCursorManager.java ! src/share/classes/java/awt/Container.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/awt/GlobalCursorManager.java ! src/solaris/classes/sun/awt/X11/XGlobalCursorManager.java ! src/windows/classes/sun/awt/windows/WGlobalCursorManager.java ! src/windows/native/sun/windows/awt_Container.cpp ! src/windows/native/sun/windows/awt_Container.h ! src/windows/native/sun/windows/awt_Cursor.cpp + test/java/awt/Cursor/CursorOverlappedPanelsTest/CursorOverlappedPanelsTest.html + test/java/awt/Cursor/CursorOverlappedPanelsTest/CursorOverlappedPanelsTest.java Changeset: 7cad8ef127a9 Author: pchelko Date: 2013-09-25 16:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cad8ef127a9 8024987: Copy/paste regression since JDK8 b86 Reviewed-by: serb, anthony ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java Changeset: cff4f079fa3f Author: kshefov Date: 2013-09-25 16:52 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cff4f079fa3f 8004032: [TEST_BUG] [macosx] There is no effect when double clicking on the Icon, after right clicking on the Icon and the Icon disappear Reviewed-by: anthony, serb + test/java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html + test/java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.java Changeset: 681ac9f9c452 Author: alexsch Date: 2013-09-25 17:08 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/681ac9f9c452 8025070: [javadoc] fix some javadoc errors in javax/swing/plaf/synth Reviewed-by: serb, alexsch Contributed-by: Alexander Stepanov ! src/share/classes/javax/swing/plaf/synth/SynthButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthCheckBoxMenuItemUI.java ! src/share/classes/javax/swing/plaf/synth/SynthCheckBoxUI.java ! src/share/classes/javax/swing/plaf/synth/SynthColorChooserUI.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopIconUI.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthEditorPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthFormattedTextFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameUI.java ! src/share/classes/javax/swing/plaf/synth/SynthLabelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthListUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuItemUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuLayout.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthOptionPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPainter.java ! src/share/classes/javax/swing/plaf/synth/SynthPanelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPasswordFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPopupMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthProgressBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthRadioButtonMenuItemUI.java ! src/share/classes/javax/swing/plaf/synth/SynthRadioButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthRootPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthScrollBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthScrollPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSeparatorUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSpinnerUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTableHeaderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTableUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextAreaUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToggleButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToolBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToolTipUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java ! src/share/classes/javax/swing/plaf/synth/SynthViewportUI.java Changeset: 2f8803ebd98c Author: yan Date: 2013-09-25 17:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2f8803ebd98c 8025085: [javadoc] some errors in javax/swing Reviewed-by: alexsch Contributed-by: Dmitry Zinkevich ! src/share/classes/javax/swing/JButton.java ! src/share/classes/javax/swing/JCheckBox.java ! src/share/classes/javax/swing/JCheckBoxMenuItem.java ! src/share/classes/javax/swing/JColorChooser.java ! src/share/classes/javax/swing/JComboBox.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JDesktopPane.java ! src/share/classes/javax/swing/JMenuItem.java ! src/share/classes/javax/swing/JToggleButton.java ! src/share/classes/javax/swing/SpinnerDateModel.java ! src/share/classes/javax/swing/SpinnerListModel.java ! src/share/classes/javax/swing/SpinnerNumberModel.java ! src/share/classes/javax/swing/SpringLayout.java ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/javax/swing/UIDefaults.java ! src/share/classes/javax/swing/UnsupportedLookAndFeelException.java ! src/share/classes/javax/swing/ViewportLayout.java ! src/share/classes/javax/swing/plaf/LayerUI.java ! src/share/classes/javax/swing/plaf/basic/BasicBorders.java ! src/share/classes/javax/swing/plaf/basic/BasicDesktopIconUI.java ! src/share/classes/javax/swing/plaf/basic/BasicDesktopPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicGraphicsUtils.java ! src/share/classes/javax/swing/plaf/basic/BasicIconFactory.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLabelUI.java ! src/share/classes/javax/swing/plaf/basic/BasicListUI.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuUI.java ! src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicPopupMenuSeparatorUI.java ! src/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java ! src/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicScrollPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSeparatorUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSplitPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolBarSeparatorUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolTipUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java ! src/share/classes/javax/swing/plaf/basic/DefaultMenuLayout.java ! src/share/classes/javax/swing/plaf/metal/MetalBorders.java ! src/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java ! src/share/classes/javax/swing/plaf/metal/MetalLabelUI.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalPopupMenuSeparatorUI.java ! src/share/classes/javax/swing/plaf/metal/MetalScrollPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalSeparatorUI.java ! src/share/classes/javax/swing/plaf/metal/MetalSliderUI.java ! src/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalToolTipUI.java ! src/share/classes/javax/swing/plaf/nimbus/AbstractRegionPainter.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java ! src/share/classes/javax/swing/plaf/synth/Region.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/html/ImageView.java ! src/share/classes/javax/swing/text/html/InlineView.java ! src/share/classes/javax/swing/text/html/StyleSheet.java ! src/share/classes/javax/swing/text/html/parser/ContentModel.java ! src/share/classes/javax/swing/text/html/parser/DocumentParser.java ! src/share/classes/javax/swing/text/html/parser/Parser.java ! src/share/classes/javax/swing/tree/AbstractLayoutCache.java ! src/share/classes/javax/swing/tree/DefaultTreeCellEditor.java ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java ! src/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/share/classes/javax/swing/tree/TreeCellRenderer.java ! src/share/classes/javax/swing/tree/TreeModel.java ! src/share/classes/javax/swing/undo/UndoManager.java Changeset: c40ed21f2939 Author: alexsch Date: 2013-09-25 17:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c40ed21f2939 7083457: Incomplete specification for javax/swing/text/DefaultCaret.html#setVisible(boolean) Reviewed-by: malenkov, serb ! src/share/classes/javax/swing/text/DefaultCaret.java + test/javax/swing/text/DefaultCaret/7083457/bug7083457.java Changeset: 09fb25645717 Author: ptbrunet Date: 2013-09-26 10:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09fb25645717 8025160: Recent Java Accessibility Bridge push has make failures Reviewed-by: tbell, erikj ! make/bridge/AccessBridgeJava/Makefile ! makefiles/CreateJars.gmk ! makefiles/GensrcMisc.gmk Changeset: 0270e9b0891b Author: yan Date: 2013-09-26 16:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0270e9b0891b 8025218: [javadoc] some errors in java/awt classes Reviewed-by: yan Contributed-by: Dmitry Zinkevich ! src/share/classes/java/awt/AWTKeyStroke.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Event.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/GridBagConstraints.java ! src/share/classes/java/awt/GridBagLayout.java ! src/share/classes/java/awt/GridLayout.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/MenuBar.java ! src/share/classes/java/awt/ScrollPane.java ! src/share/classes/java/awt/ScrollPaneAdjustable.java ! src/share/classes/java/awt/SystemTray.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/TextField.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/datatransfer/DataFlavor.java ! src/share/classes/java/awt/event/MouseMotionListener.java Changeset: 3b22833f2695 Author: lana Date: 2013-09-26 17:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b22833f2695 Merge - src/macosx/classes/sun/lwawt/SelectionClearListener.java - src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java Changeset: 8edd604bf960 Author: lana Date: 2013-09-26 17:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8edd604bf960 Merge - test/java/util/regex/PatternTest.java Changeset: 9684ed81cd21 Author: ksrini Date: 2013-09-27 16:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9684ed81cd21 8020552: [launcher] changes to support removal of Solaris 32-bit distribution 8023495: [infra] create 64-bit solaris bits with symlinks Reviewed-by: ihse, tbell, dholmes, darcy, alanb, erikj, sla, martin ! makefiles/Images.gmk ! src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java ! src/solaris/bin/java_md_solinux.c ! test/com/sun/jdi/BadHandshakeTest.java ! test/com/sun/jdi/DoubleAgentTest.java ! test/com/sun/jdi/ExclusiveBind.java ! test/com/sun/jdi/PrivateTransportTest.sh ! test/com/sun/jdi/RunToExit.java - test/com/sun/jdi/Solaris32AndSolaris64Test.sh ! test/com/sun/jdi/connect/spi/SimpleLaunchingConnector.java ! test/demo/jvmti/DemoRun.java ! test/java/nio/channels/spi/SelectorProvider/inheritedChannel/Makefile + test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-amd64/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so ! test/java/nio/channels/spi/SelectorProvider/inheritedChannel/run_tests.sh ! test/sun/security/tools/keytool/autotest.sh ! test/sun/tools/jhat/HatRun.java ! test/tools/launcher/6842838/Test6842838.sh ! test/tools/launcher/ChangeDataModel.java ! test/tools/launcher/ExecutionEnvironment.java ! test/tools/launcher/FXLauncherTest.java ! test/tools/launcher/RunpathTest.java ! test/tools/launcher/Test7029048.java ! test/tools/launcher/TestHelper.java Changeset: 2c7c7b813eb3 Author: katleman Date: 2013-10-01 12:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c7c7b813eb3 Merge - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so Changeset: dd43ccb3bac9 Author: ihse Date: 2013-10-01 11:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd43ccb3bac9 8019219: Fix typo in jdk/makefiles "default" targets Reviewed-by: erikj ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk Changeset: 54e099776f08 Author: erikj Date: 2013-10-02 15:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/54e099776f08 Merge Changeset: 9f57d2774603 Author: katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f57d2774603 Added tag jdk8-b110 for changeset 54e099776f08 ! .hgtags Changeset: 88597d465e48 Author: ihse Date: 2013-10-01 15:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88597d465e48 8016024: Remove solaris path from FillCacheFind Reviewed-by: erikj ! makefiles/Tools.gmk Changeset: 760af86b3f3f Author: erikj Date: 2013-10-03 11:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/760af86b3f3f 8024522: java.time packages missing from src.zip Reviewed-by: tbell ! makefiles/CreateJars.gmk Changeset: 719befd87c7b Author: katleman Date: 2013-10-08 13:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/719befd87c7b Merge Changeset: a1d91e198ddf Author: lana Date: 2013-10-10 13:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a1d91e198ddf Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk - src/macosx/classes/sun/lwawt/SelectionClearListener.java - src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so ! test/sun/security/tools/keytool/autotest.sh Changeset: 1863a7e3a1c9 Author: lana Date: 2013-10-10 20:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1863a7e3a1c9 Merge Changeset: 7af04d2d2139 Author: cl Date: 2013-10-10 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7af04d2d2139 Added tag jdk8-b111 for changeset 719befd87c7b ! .hgtags Changeset: 1a067bc31098 Author: lana Date: 2013-10-10 21:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1a067bc31098 Merge From erik.joelsson at oracle.com Fri Oct 11 07:36:44 2013 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 11 Oct 2013 09:36:44 +0200 Subject: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access In-Reply-To: <5256E7AD.2080301@oracle.com> References: <52546282.50101@oracle.com> <5254DC80.3080305@oracle.com> <52551E72.9030605@oracle.com> <52555832.1080907@oracle.com> <5255901E.1020104@oracle.com> <52567A21.3050503@oracle.com> <5256E7AD.2080301@oracle.com> Message-ID: <5257AA8C.6020000@oracle.com> On 2013-10-10 19:45, Sean Mullan wrote: > On 10/10/2013 05:57 AM, Erik Joelsson wrote: >> Adding makefiles to make/tools is not needed for the new build. Either >> remove those changes or make a complete port to the old build. I'm not >> pushing for porting this to the old build at this point since missing >> this will not cause the old build to stop working, it will just diverge >> the resulting bits a bit more. > > I have ported the changes to the old build, please review. > > New webrev: http://cr.openjdk.java.net/~mullan/webrevs/8007292/webrev.02/ > > The only modified file is make/java/security/Makefile > Thanks, looks good now! /Erik From sundararajan.athijegannathan at oracle.com Fri Oct 11 08:20:24 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 11 Oct 2013 08:20:24 +0000 Subject: hg: jdk8/tl/nashorn: 5 new changesets Message-ID: <20131011082034.ECA2662F63@hg.openjdk.java.net> Changeset: 34f7a699cdef Author: sundar Date: 2013-10-10 14:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/34f7a699cdef 8026162: "this" in SAM adapter functions is wrong Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterServices.java + test/script/basic/JDK-8026162.js Changeset: ed3da7a574a0 Author: lagergren Date: 2013-10-10 16:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ed3da7a574a0 8026250: Logging nullpointer bugfix and javadoc warnings Reviewed-by: hannesw, jlaskey, sundar ! src/jdk/nashorn/api/scripting/JSObject.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/GlobalObject.java ! src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/ScriptLoader.java ! src/jdk/nashorn/internal/runtime/WithObject.java Changeset: a781ea074521 Author: sundar Date: 2013-10-10 21:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a781ea074521 8026264: Getter, setter function name mangling issues Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java + test/script/basic/JDK-8026264.js Changeset: 375c2f2d41c8 Author: sundar Date: 2013-10-11 06:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/375c2f2d41c8 8026263: [NASHORN] Test test/script/basic/JDK-8025488.js fails in nightly builds Reviewed-by: jlaskey ! test/script/basic/JDK-8025488.js Changeset: 56be5161f0d2 Author: sundar Date: 2013-10-11 09:09 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/56be5161f0d2 Merge From sundararajan.athijegannathan at oracle.com Fri Oct 11 12:28:37 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 11 Oct 2013 12:28:37 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20131011122842.3823862F6C@hg.openjdk.java.net> Changeset: 1c154cee43d9 Author: hannesw Date: 2013-10-11 10:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1c154cee43d9 8026292: Megamorphic setter fails with boolean value Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/MethodEmitter.java + test/script/basic/JDK-8026292.js Changeset: fb091f9052a6 Author: sundar Date: 2013-10-11 11:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fb091f9052a6 8026302: source representation of getter and setter methods is wrong Reviewed-by: lagergren, hannesw, jlaskey ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8026302.js + test/script/basic/JDK-8026302.js.EXPECTED ! test/script/basic/objects.js.EXPECTED Changeset: 062579f50371 Author: sundar Date: 2013-10-11 14:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/062579f50371 8026317: $ in the function name results in wrong function being invoked Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/codegen/Namespace.java + test/script/basic/JDK-8026317.js + test/script/basic/JDK-8026317.js.EXPECTED Changeset: b35d175207f6 Author: sundar Date: 2013-10-11 14:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b35d175207f6 Merge From sean.mullan at oracle.com Fri Oct 11 13:45:57 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Fri, 11 Oct 2013 13:45:57 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131011134659.CE0C062F6F@hg.openjdk.java.net> Changeset: 4ad76262bac8 Author: mullan Date: 2013-10-11 08:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad76262bac8 8007292: Add JavaFX internal packages to package.access Summary: build hooks to allow closed restricted packages to be added to java.security file Reviewed-by: erikj, dholmes, tbell ! make/java/security/Makefile ! make/tools/Makefile + make/tools/addtorestrictedpkgs/Makefile + make/tools/src/build/tools/addtorestrictedpkgs/AddToRestrictedPkgs.java ! makefiles/CopyFiles.gmk ! makefiles/Tools.gmk ! test/java/lang/SecurityManager/CheckPackageAccess.java Changeset: 76df579c0b93 Author: mullan Date: 2013-10-11 09:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/76df579c0b93 Merge ! makefiles/Tools.gmk - src/macosx/classes/sun/lwawt/SelectionClearListener.java - src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/time/chrono/ChronoDateImpl.java - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java From jan.lahoda at oracle.com Fri Oct 11 13:59:32 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Fri, 11 Oct 2013 13:59:32 +0000 Subject: hg: jdk8/tl/langtools: 6278240: Exception from AnnotationValue.getValue() should list the found type not the required type Message-ID: <20131011135935.3C31862F73@hg.openjdk.java.net> Changeset: 872c4a898b38 Author: jlahoda Date: 2013-10-11 15:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/872c4a898b38 6278240: Exception from AnnotationValue.getValue() should list the found type not the required type Reviewed-by: darcy, jfranck, jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/processing/errors/EnsureAnnotationTypeMismatchException/Processor.java + test/tools/javac/processing/errors/EnsureAnnotationTypeMismatchException/Source.java + test/tools/javac/processing/errors/EnsureAnnotationTypeMismatchException/Source.out From dan.xu at oracle.com Fri Oct 11 16:48:01 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Fri, 11 Oct 2013 16:48:01 +0000 Subject: hg: jdk8/tl/jdk: 8025712: (props) Possible memory leak in java_props_md.c / ParseLocale Message-ID: <20131011164853.6499F62F86@hg.openjdk.java.net> Changeset: cb373cf43294 Author: dxu Date: 2013-10-11 09:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb373cf43294 8025712: (props) Possible memory leak in java_props_md.c / ParseLocale Reviewed-by: naoto, chegar ! src/solaris/native/java/lang/java_props_md.c From vincent.x.ryan at oracle.com Fri Oct 11 18:41:05 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 11 Oct 2013 19:41:05 +0100 Subject: [8] 8026301: DomainKeyStore doesn't cleanup correctly when storing to keystore Message-ID: Please review this fix to close output stream in DomainKeyStore: Bug: https://bugs.openjdk.java.net/browse/JDK-8026301 Webrev: http://cr.openjdk.java.net/~vinnie/8026301/webrev.00/ Thanks. From sean.mullan at oracle.com Fri Oct 11 19:10:12 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 11 Oct 2013 15:10:12 -0400 Subject: [8] 8026301: DomainKeyStore doesn't cleanup correctly when storing to keystore In-Reply-To: References: Message-ID: <52584D14.9050604@oracle.com> Looks good, just add a noreg-trivial tag to the bug. --Sean On 10/11/2013 02:41 PM, Vincent Ryan wrote: > > Please review this fix to close output stream in DomainKeyStore: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8026301 > Webrev: http://cr.openjdk.java.net/~vinnie/8026301/webrev.00/ > > Thanks. > From bradford.wetmore at oracle.com Fri Oct 11 19:49:11 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Fri, 11 Oct 2013 12:49:11 -0700 Subject: [8] 8026301: DomainKeyStore doesn't cleanup correctly when storing to keystore In-Reply-To: <52584D14.9050604@oracle.com> References: <52584D14.9050604@oracle.com> Message-ID: <52585637.7020308@oracle.com> Looks ok to me. Brad On 10/11/2013 12:10 PM, Sean Mullan wrote: > Looks good, just add a noreg-trivial tag to the bug. > > --Sean > > On 10/11/2013 02:41 PM, Vincent Ryan wrote: >> >> Please review this fix to close output stream in DomainKeyStore: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8026301 >> Webrev: http://cr.openjdk.java.net/~vinnie/8026301/webrev.00/ >> >> Thanks. >> > From vincent.x.ryan at oracle.com Fri Oct 11 19:55:23 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 11 Oct 2013 20:55:23 +0100 Subject: [8] 8026301: DomainKeyStore doesn't cleanup correctly when storing to keystore In-Reply-To: <52584D14.9050604@oracle.com> References: <52584D14.9050604@oracle.com> Message-ID: <768852DC-D5C6-4CCB-AE47-A35CF4B48EAA@oracle.com> Thanks. On 11 Oct 2013, at 20:10, Sean Mullan wrote: > Looks good, just add a noreg-trivial tag to the bug. > > --Sean > > On 10/11/2013 02:41 PM, Vincent Ryan wrote: >> >> Please review this fix to close output stream in DomainKeyStore: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8026301 >> Webrev: http://cr.openjdk.java.net/~vinnie/8026301/webrev.00/ >> >> Thanks. >> > From alan.bateman at oracle.com Fri Oct 11 19:59:42 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 11 Oct 2013 19:59:42 +0000 Subject: hg: jdk8/tl/jdk: 8019526: (fs) Files.lines, etc without Charset parameter Message-ID: <20131011195954.DFDAC62FA3@hg.openjdk.java.net> Changeset: 9632de07d963 Author: alanb Date: 2013-10-11 20:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9632de07d963 8019526: (fs) Files.lines, etc without Charset parameter Reviewed-by: psandoz, henryjen ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/Files/BytesAndLines.java ! test/java/nio/file/Files/StreamTest.java From vincent.x.ryan at oracle.com Fri Oct 11 19:47:42 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Fri, 11 Oct 2013 19:47:42 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131011194840.ADE9462FA1@hg.openjdk.java.net> Changeset: d23247aa7462 Author: vinnie Date: 2013-10-11 20:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d23247aa7462 8026301: DomainKeyStore doesn't cleanup correctly when storing to keystore Reviewed-by: mullan ! src/share/classes/sun/security/provider/DomainKeyStore.java Changeset: 94493b5800bb Author: vinnie Date: 2013-10-11 20:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94493b5800bb Merge From robert.field at oracle.com Fri Oct 11 22:22:03 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Fri, 11 Oct 2013 22:22:03 +0000 Subject: hg: jdk8/tl/jdk: 8026213: Reflection support for private interface methods Message-ID: <20131011222240.638D362FAB@hg.openjdk.java.net> Changeset: 4561460bf570 Author: rfield Date: 2013-10-11 15:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4561460bf570 8026213: Reflection support for private interface methods Reviewed-by: forax, psandoz, dholmes, jfranck Contributed-by: karen.kinnear at oracle.com ! src/share/classes/sun/reflect/AccessorGenerator.java ! src/share/classes/sun/reflect/MethodAccessorGenerator.java + test/java/lang/reflect/Method/invoke/TestPrivateInterfaceMethodReflect.java From mike.duigou at oracle.com Fri Oct 11 22:31:33 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 11 Oct 2013 22:31:33 +0000 Subject: hg: jdk8/tl: 8025796: hgforest.sh could trigger unbuffered output from hg without complicated machinations Message-ID: <20131011223133.8194662FAC@hg.openjdk.java.net> Changeset: 3f9873789d44 Author: mduigou Date: 2013-10-11 15:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/3f9873789d44 8025796: hgforest.sh could trigger unbuffered output from hg without complicated machinations Reviewed-by: mduigou Contributed-by: Dmitry Samersoff ! common/bin/hgforest.sh From weijun.wang at oracle.com Sat Oct 12 00:49:37 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Sat, 12 Oct 2013 08:49:37 +0800 Subject: Code review request: 7025699: Policy Tool is not accessible by keyboard Message-ID: <52589CA1.4080503@oracle.com> Hi All Please review the fix at http://cr.openjdk.java.net/~weijun/7025699/webrev.00/ The fix includes porting PolicyTool from AWT to Swing, defining mnemonics for menu items and buttons, and adding keyboard shortcuts for the File -> New/Open/Save items. Several tests are updated also. Thanks Max From weijun.wang at oracle.com Sat Oct 12 09:28:52 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Sat, 12 Oct 2013 17:28:52 +0800 Subject: Request for review: 8025124: InitialToken.useNullKey incorrectly applies NULL_KEY in some cases Message-ID: <52591654.8040209@oracle.com> Please review the fix at http://cr.openjdk.java.net/~weijun/8025124/webrev.00/ This is an interop fix. We used to determine if a NULL key should be used based on etype being new or old, now we just look at the etype inside the EncryptedData. If it's 0 then there is no need to decrypt it. Note that this is not a security issue because the whole KRB-CRED is encrypted anyway. A new regression test added. Thanks Max From xuelei.fan at oracle.com Mon Oct 14 03:19:00 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 14 Oct 2013 11:19:00 +0800 Subject: Code review request 8026119 Regression test DHEKeySizing.java failing intermittently In-Reply-To: <525B5F56.8040006@oracle.com> References: <525B5A21.2050200@oracle.com> <525B5D7F.5080406@oracle.com> <525B5F56.8040006@oracle.com> Message-ID: <525B62A4.4040005@oracle.com> CC security-dev. On 10/14/2013 11:04 AM, Xuelei Fan wrote: > Normally, there are only leading zero of DH keys. Oops, typo here: ... there are only one leading zero of DH keys. Xuelei > By the fix, I suppose > it should rally happen for 3 bytes leading zeros. The worst cases, > dh_p, dh_g and dh_Ys each has 3 leading zeros (9 bytes in total) in a > handshaking message. > > It's both OK to me to use 2 (6 in totla) and 3 (9 in total) leading zeros. > > Xuelei > > On 10/14/2013 10:57 AM, Weijun Wang wrote: >> Isn't 9 too big here? If I understand correctly, the probability of the >> bias being up to 9 is (1/256)^9. If this happens, you should really >> suspect the quality of your RNG. >> >> Thanks >> Max >> >> On 10/14/13 10:42 AM, Xuelei Fan wrote: >>> Hi Max, >>> >>> Please review this simple fix of a regression test intermittent failure. >>> >>> webrev: http://cr.openjdk.java.net/~xuelei/8026119/webrev.00/ >>> >>> The cause of the issue is that during TLS handshaking, if the negotiated >>> DH key starts with zero bytes, the leading zero bytes are stripped in >>> the communication. As result in that we cannot estimate the DH key size >>> in handshaking messages exactly. This fix is an effort to minimum the >>> impact the leading zeros by a length bias. If the message size is >>> between [dh_key_size - bias, dh_key_size], the message is OK in this >>> test. >>> >>> Thanks, >>> Xuelei >>> > From weijun.wang at oracle.com Mon Oct 14 03:45:19 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Mon, 14 Oct 2013 11:45:19 +0800 Subject: Code review request 8026119 Regression test DHEKeySizing.java failing intermittently In-Reply-To: <525B62A4.4040005@oracle.com> References: <525B5A21.2050200@oracle.com> <525B5D7F.5080406@oracle.com> <525B5F56.8040006@oracle.com> <525B62A4.4040005@oracle.com> Message-ID: <525B68CF.6080903@oracle.com> On 10/14/13 11:19 AM, Xuelei Fan wrote: > CC security-dev. > > On 10/14/2013 11:04 AM, Xuelei Fan wrote: >> Normally, there are only leading zero of DH keys. > Oops, typo here: > ... there are only one leading zero of DH keys. > > Xuelei > >> By the fix, I suppose >> it should rally happen for 3 bytes leading zeros. The worst cases, >> dh_p, dh_g and dh_Ys each has 3 leading zeros (9 bytes in total) in a >> handshaking message. I guess they are independent? So the probably of all 3 having 3 leading zeroes is still (256^3)^3. >> >> It's both OK to me to use 2 (6 in totla) and 3 (9 in total) leading zeros. >> Any is OK, since the expected differences are big enough. Your code change is fine. Thanks Max >> Xuelei >> >> On 10/14/2013 10:57 AM, Weijun Wang wrote: >>> Isn't 9 too big here? If I understand correctly, the probability of the >>> bias being up to 9 is (1/256)^9. If this happens, you should really >>> suspect the quality of your RNG. >>> >>> Thanks >>> Max >>> >>> On 10/14/13 10:42 AM, Xuelei Fan wrote: >>>> Hi Max, >>>> >>>> Please review this simple fix of a regression test intermittent failure. >>>> >>>> webrev: http://cr.openjdk.java.net/~xuelei/8026119/webrev.00/ >>>> >>>> The cause of the issue is that during TLS handshaking, if the negotiated >>>> DH key starts with zero bytes, the leading zero bytes are stripped in >>>> the communication. As result in that we cannot estimate the DH key size >>>> in handshaking messages exactly. This fix is an effort to minimum the >>>> impact the leading zeros by a length bias. If the message size is >>>> between [dh_key_size - bias, dh_key_size], the message is OK in this >>>> test. >>>> >>>> Thanks, >>>> Xuelei >>>> >> > From xuelei.fan at oracle.com Mon Oct 14 04:00:16 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 14 Oct 2013 12:00:16 +0800 Subject: Code review request 8026119 Regression test DHEKeySizing.java failing intermittently In-Reply-To: <525B68CF.6080903@oracle.com> References: <525B5A21.2050200@oracle.com> <525B5D7F.5080406@oracle.com> <525B5F56.8040006@oracle.com> <525B62A4.4040005@oracle.com> <525B68CF.6080903@oracle.com> Message-ID: <525B6C50.2080401@oracle.com> 9 is really huge. I will use 6 instead. Thanks for the code review. Xuelei On 10/14/2013 11:45 AM, Weijun Wang wrote: > On 10/14/13 11:19 AM, Xuelei Fan wrote: >> CC security-dev. >> >> On 10/14/2013 11:04 AM, Xuelei Fan wrote: >>> Normally, there are only leading zero of DH keys. >> Oops, typo here: >> ... there are only one leading zero of DH keys. >> >> Xuelei >> >>> By the fix, I suppose >>> it should rally happen for 3 bytes leading zeros. The worst cases, >>> dh_p, dh_g and dh_Ys each has 3 leading zeros (9 bytes in total) in a >>> handshaking message. > > I guess they are independent? So the probably of all 3 having 3 leading > zeroes is still (256^3)^3. > >>> >>> It's both OK to me to use 2 (6 in totla) and 3 (9 in total) leading >>> zeros. >>> > > Any is OK, since the expected differences are big enough. Your code > change is fine. > > Thanks > Max > >>> Xuelei >>> >>> On 10/14/2013 10:57 AM, Weijun Wang wrote: >>>> Isn't 9 too big here? If I understand correctly, the probability of the >>>> bias being up to 9 is (1/256)^9. If this happens, you should really >>>> suspect the quality of your RNG. >>>> >>>> Thanks >>>> Max >>>> >>>> On 10/14/13 10:42 AM, Xuelei Fan wrote: >>>>> Hi Max, >>>>> >>>>> Please review this simple fix of a regression test intermittent >>>>> failure. >>>>> >>>>> webrev: http://cr.openjdk.java.net/~xuelei/8026119/webrev.00/ >>>>> >>>>> The cause of the issue is that during TLS handshaking, if the >>>>> negotiated >>>>> DH key starts with zero bytes, the leading zero bytes are stripped in >>>>> the communication. As result in that we cannot estimate the DH key >>>>> size >>>>> in handshaking messages exactly. This fix is an effort to minimum the >>>>> impact the leading zeros by a length bias. If the message size is >>>>> between [dh_key_size - bias, dh_key_size], the message is OK in this >>>>> test. >>>>> >>>>> Thanks, >>>>> Xuelei >>>>> >>> >> From xuelei.fan at oracle.com Mon Oct 14 04:12:08 2013 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 14 Oct 2013 04:12:08 +0000 Subject: hg: jdk8/tl/jdk: 8026119: Regression test DHEKeySizing.java failing intermittently Message-ID: <20131014041308.02D8E62FFD@hg.openjdk.java.net> Changeset: fb202a8e83c9 Author: xuelei Date: 2013-10-13 21:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fb202a8e83c9 8026119: Regression test DHEKeySizing.java failing intermittently Reviewed-by: weijun ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/DHKeyExchange/DHEKeySizing.java From daniel.fuchs at oracle.com Mon Oct 14 08:45:52 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Mon, 14 Oct 2013 08:45:52 +0000 Subject: hg: jdk8/tl/jdk: 8024704: Improve API documentation of ClassLoader and ServiceLoader with respect to enumeration of resources. Message-ID: <20131014084627.8B1D662361@hg.openjdk.java.net> Changeset: 9f8bfdd99129 Author: dfuchs Date: 2013-10-14 10:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f8bfdd99129 8024704: Improve API documentation of ClassLoader and ServiceLoader with respect to enumeration of resources. Reviewed-by: alanb, psandoz, mchung ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/util/ServiceLoader.java From alan.bateman at oracle.com Mon Oct 14 10:22:51 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 14 Oct 2013 10:22:51 +0000 Subject: hg: jdk8/tl/jaxp: 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc Message-ID: <20131014102257.8AE596236F@hg.openjdk.java.net> Changeset: de8c803d4958 Author: aefimov Date: 2013-10-13 13:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/de8c803d4958 8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc Reviewed-by: alanb, shade ! src/com/sun/org/apache/xpath/internal/XPathContext.java From chris.hegarty at oracle.com Mon Oct 14 10:49:03 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 14 Oct 2013 10:49:03 +0000 Subject: hg: jdk8/tl/jdk: 8023555: test/java/net/Socks/SocksProxyVersion.java fails when machine name is localhost Message-ID: <20131014104948.C8DD262372@hg.openjdk.java.net> Changeset: 077237e4613f Author: tyan Date: 2013-10-14 11:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/077237e4613f 8023555: test/java/net/Socks/SocksProxyVersion.java fails when machine name is localhost Reviewed-by: chegar, alanb ! test/java/net/Socks/SocksProxyVersion.java From xuelei.fan at oracle.com Mon Oct 14 13:06:00 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 14 Oct 2013 21:06:00 +0800 Subject: Request for review: 8025124: InitialToken.useNullKey incorrectly applies NULL_KEY in some cases In-Reply-To: <52591654.8040209@oracle.com> References: <52591654.8040209@oracle.com> Message-ID: <525BEC38.40407@oracle.com> Looks fine to me. Xuelei On 10/12/2013 5:28 PM, Weijun Wang wrote: > Please review the fix at > > http://cr.openjdk.java.net/~weijun/8025124/webrev.00/ > > This is an interop fix. We used to determine if a NULL key should be > used based on etype being new or old, now we just look at the etype > inside the EncryptedData. If it's 0 then there is no need to decrypt it. > Note that this is not a security issue because the whole KRB-CRED is > encrypted anyway. > > A new regression test added. > > Thanks > Max From lana.steuck at oracle.com Mon Oct 14 18:47:32 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 14 Oct 2013 18:47:32 +0000 Subject: hg: jdk8/tl/jaxp: 4 new changesets Message-ID: <20131014184751.C582862391@hg.openjdk.java.net> Changeset: d69f4ac43d64 Author: lana Date: 2013-10-08 14:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d69f4ac43d64 Merge Changeset: cdc3577cba0b Author: lana Date: 2013-10-11 00:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/cdc3577cba0b Merge Changeset: 4712979714d1 Author: lana Date: 2013-10-11 21:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/4712979714d1 Merge Changeset: 91ae0f2045bc Author: lana Date: 2013-10-14 09:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/91ae0f2045bc Merge From lana.steuck at oracle.com Mon Oct 14 18:47:44 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 14 Oct 2013 18:47:44 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20131014184753.2CCFC62393@hg.openjdk.java.net> Changeset: 3551855c4f40 Author: lana Date: 2013-10-08 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3551855c4f40 Merge - make/java.security.override Changeset: b48b719c5efc Author: lana Date: 2013-10-11 03:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b48b719c5efc Merge - make/java.security.override Changeset: 1b0a71a9920a Author: lana Date: 2013-10-11 23:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1b0a71a9920a Merge From lana.steuck at oracle.com Mon Oct 14 18:47:57 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 14 Oct 2013 18:47:57 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20131014184806.311CC62394@hg.openjdk.java.net> Changeset: 4dfcf3a6902f Author: lana Date: 2013-10-08 14:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4dfcf3a6902f Merge - src/share/classes/jdk/Supported.java - test/tools/javac/generics/OverrideBridge.java Changeset: 2f43529df42f Author: lana Date: 2013-10-11 03:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2f43529df42f Merge - src/share/classes/jdk/Supported.java - test/tools/javac/generics/OverrideBridge.java Changeset: f329c374da4b Author: lana Date: 2013-10-11 23:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f329c374da4b Merge From lana.steuck at oracle.com Mon Oct 14 18:47:36 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 14 Oct 2013 18:47:36 +0000 Subject: hg: jdk8/tl/jaxws: 3 new changesets Message-ID: <20131014184752.2548F62392@hg.openjdk.java.net> Changeset: 1d6c13d3b8de Author: lana Date: 2013-10-08 14:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/1d6c13d3b8de Merge Changeset: 7c0a7937f6ef Author: lana Date: 2013-10-11 00:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/7c0a7937f6ef Merge Changeset: 328b8b96773b Author: lana Date: 2013-10-11 21:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/328b8b96773b Merge From lana.steuck at oracle.com Mon Oct 14 18:47:22 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 14 Oct 2013 18:47:22 +0000 Subject: hg: jdk8/tl: 3 new changesets Message-ID: <20131014184724.A016E6238F@hg.openjdk.java.net> Changeset: 7c0e2fd8be4d Author: lana Date: 2013-10-08 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7c0e2fd8be4d Merge Changeset: 3ece65f23ed2 Author: lana Date: 2013-10-11 00:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/3ece65f23ed2 Merge Changeset: d35943431696 Author: lana Date: 2013-10-11 21:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d35943431696 Merge From jonathan.gibbons at oracle.com Mon Oct 14 19:38:46 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 14 Oct 2013 19:38:46 +0000 Subject: hg: jdk8/tl/langtools: 8026368: doclint does not report empty tags when tag closed implicitly Message-ID: <20131014193849.5D63A6239B@hg.openjdk.java.net> Changeset: b024fe427d24 Author: jjg Date: 2013-10-14 12:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b024fe427d24 8026368: doclint does not report empty tags when tag closed implicitly Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! test/tools/doclint/HtmlAttrsTest.java ! test/tools/doclint/HtmlAttrsTest.out ! test/tools/doclint/tidy/BadEnd.out ! test/tools/doclint/tidy/TrimmingEmptyTag.java ! test/tools/doclint/tidy/TrimmingEmptyTag.out From lana.steuck at oracle.com Mon Oct 14 18:50:33 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 14 Oct 2013 18:50:33 +0000 Subject: hg: jdk8/tl/jdk: 63 new changesets Message-ID: <20131014190553.ABDF662395@hg.openjdk.java.net> Changeset: 8a041011b6e6 Author: jgodinez Date: 2013-09-27 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a041011b6e6 6870661: Setting a custom PrintService on a PrinterJob leads to a PrinterException Reviewed-by: prr, jgodinez Contributed-by: patrick at reini.net ! src/windows/classes/sun/awt/windows/WPrinterJob.java + test/java/awt/print/PrinterJob/CustomPrintService/PrintDialog.java + test/java/awt/print/PrinterJob/CustomPrintService/PrintServiceStub.java + test/java/awt/print/PrinterJob/CustomPrintService/SetPrintServiceTest.java Changeset: 31b8d4931a09 Author: prr Date: 2013-09-27 13:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31b8d4931a09 8020190: Fatal: Bug in native code: jfieldID must match object Reviewed-by: jgodinez, vadim ! src/share/classes/sun/font/FreetypeFontScaler.java ! src/share/native/sun/font/freetypeScaler.c Changeset: 6ef33b4553a4 Author: vadim Date: 2013-09-30 12:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ef33b4553a4 8001119: [fingbugs] Evaluate necessity to make some arrays package protected Reviewed-by: prr, bae + src/share/classes/com/sun/imageio/plugins/bmp/BMPCompressionTypes.java ! src/share/classes/com/sun/imageio/plugins/bmp/BMPConstants.java ! src/share/classes/com/sun/imageio/plugins/bmp/BMPImageWriter.java ! src/share/classes/com/sun/imageio/plugins/bmp/BMPMetadata.java ! src/share/classes/com/sun/imageio/plugins/gif/GIFStreamMetadata.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEG.java ! src/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java ! src/share/classes/javax/imageio/plugins/bmp/BMPImageWriteParam.java Changeset: e2604b873b36 Author: prr Date: 2013-10-01 15:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2604b873b36 8007386: On physical machine (video card is Intel Q45) the text is blank. Reviewed-by: prr, jchen ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 96ff585555f4 Author: vadim Date: 2013-10-02 10:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/96ff585555f4 8024343: Change different color with the "The XOR alternation color" combobox, the color of the image can not shown immediately. Reviewed-by: ceisserer, prr, bae ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java + test/sun/java2d/AcceleratedXORModeTest.java Changeset: 5f3d984d8207 Author: prr Date: 2013-10-02 11:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f3d984d8207 8025837: Extraneous changes in the fix for 8007386 Reviewed-by: jgodinez, jchen ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: f53aeb3c7eed Author: prr Date: 2013-10-02 11:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f53aeb3c7eed 7179526: xrender : closed/sun/java2d/volatileImage/LineClipTest.java failed since jdk8b36 Reviewed-by: prr, jchen ! src/solaris/classes/sun/java2d/xr/GrowableRectArray.java ! src/solaris/classes/sun/java2d/xr/MaskTile.java ! src/solaris/classes/sun/java2d/xr/MaskTileManager.java + src/solaris/classes/sun/java2d/xr/XRDrawLine.java ! src/solaris/classes/sun/java2d/xr/XRRenderer.java + test/java/awt/Graphics/LineClipTest.java Changeset: a15cad0e12d3 Author: bae Date: 2013-10-03 11:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a15cad0e12d3 8022632: Reading a PNG file fails because of WBMPImageReaderSpi.canDecodeInput() Reviewed-by: prr, jgodinez ! src/share/classes/com/sun/imageio/plugins/wbmp/WBMPImageReaderSpi.java + test/javax/imageio/plugins/wbmp/StreamResetTest.java Changeset: 2f11a00279ec Author: jchen Date: 2013-10-03 13:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2f11a00279ec 8025280: [parfait] warnings from b107 for jdk.src.share.native.sun.java2d.loops: JNI exception pending, JNI critical region violation Reviewed-by: prr, jgodinez ! src/share/native/sun/java2d/loops/Blit.c ! src/share/native/sun/java2d/loops/BlitBg.c ! src/share/native/sun/java2d/loops/DrawPath.c ! src/share/native/sun/java2d/loops/DrawPolygons.c ! src/share/native/sun/java2d/loops/FillPath.c ! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.c ! src/share/native/sun/java2d/loops/MaskBlit.c ! src/share/native/sun/java2d/loops/MaskFill.c ! src/share/native/sun/java2d/loops/ScaledBlit.c ! src/share/native/sun/java2d/loops/TransformHelper.c Changeset: e88d39b110dd Author: jchen Date: 2013-10-03 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e88d39b110dd 8025480: [parfait] "JNI exception pending" warnings from b107 for jdk.src.share.native.sun.java2d Reviewed-by: prr, jgodinez ! src/share/native/sun/java2d/Disposer.c ! src/share/native/sun/java2d/SurfaceData.c Changeset: 3c1b13ad0677 Author: jchen Date: 2013-10-03 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c1b13ad0677 8025309: [parfait] JNI-related warnings from b107 for jdk.src.share.native.sun.java2d.pipe Reviewed-by: prr, jgodinez ! src/share/native/sun/java2d/pipe/BufferedRenderPipe.c ! src/share/native/sun/java2d/pipe/Region.c ! src/share/native/sun/java2d/pipe/ShapeSpanIterator.c ! src/share/native/sun/java2d/pipe/SpanClipRenderer.c Changeset: d37594b689ce Author: jchen Date: 2013-10-03 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d37594b689ce 8025664: [parfait] warnings from b62 for jdk.src.share.native.sun.font Reviewed-by: prr, jgodinez ! src/share/native/sun/font/freetypeScaler.c Changeset: 0ed939dc4230 Author: jchen Date: 2013-10-03 13:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ed939dc4230 8025294: [parfait] JNI-related warnings from b107 for jdk.src.solaris.native.sun.java2d.x11 Reviewed-by: prr, jgodinez ! src/solaris/native/sun/java2d/x11/X11Renderer.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/java2d/x11/XRBackendNative.c ! src/solaris/native/sun/java2d/x11/XRSurfaceData.c Changeset: 8fd757f31470 Author: jchen Date: 2013-10-04 16:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8fd757f31470 8025940: Windows build fails after the fix for 8025280 Reviewed-by: prr, jgodinez ! src/share/native/sun/java2d/loops/MaskBlit.c Changeset: 727b60f9c09c Author: lana Date: 2013-10-08 14:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/727b60f9c09c Merge Changeset: e4e151f6ae50 Author: yan Date: 2013-09-27 12:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4e151f6ae50 8025249: [javadoc] fix some javadoc errors in javax/swing/ Reviewed-by: alexsch, yan Contributed-by: Taras Ledkov ! src/share/classes/javax/swing/border/CompoundBorder.java ! src/share/classes/javax/swing/colorchooser/AbstractColorChooserPanel.java ! src/share/classes/javax/swing/event/CaretEvent.java ! src/share/classes/javax/swing/event/DocumentEvent.java ! src/share/classes/javax/swing/event/EventListenerList.java ! src/share/classes/javax/swing/event/ListDataEvent.java ! src/share/classes/javax/swing/event/TreeModelEvent.java ! src/share/classes/javax/swing/filechooser/FileView.java ! src/share/classes/javax/swing/table/DefaultTableCellRenderer.java ! src/share/classes/javax/swing/table/DefaultTableModel.java ! src/share/classes/javax/swing/table/JTableHeader.java ! src/share/classes/javax/swing/table/TableCellRenderer.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/AbstractWriter.java ! src/share/classes/javax/swing/text/AsyncBoxView.java ! src/share/classes/javax/swing/text/AttributeSet.java ! src/share/classes/javax/swing/text/Document.java ! src/share/classes/javax/swing/text/Element.java ! src/share/classes/javax/swing/text/View.java Changeset: ca45169cb4eb Author: pchelko Date: 2013-09-27 14:29 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca45169cb4eb 8024122: [TEST] need test to cover JDK-7146572 Reviewed-by: anthony, yan Contributed-by: Alexander Stepanov + test/java/awt/InputMethods/InputMethodsTest/InputMethodsTest.html + test/java/awt/InputMethods/InputMethodsTest/InputMethodsTest.java Changeset: ad7db846c951 Author: pchelko Date: 2013-09-27 17:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ad7db846c951 8025503: [macosx] FileDialog allows file selection with apple.awt.fileDialogForDirectories = true Reviewed-by: serb, anthony ! src/macosx/native/sun/awt/CFileDialog.m Changeset: 260bc59ca253 Author: pchelko Date: 2013-09-27 18:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/260bc59ca253 8016563: Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails Reviewed-by: anthony, serb ! src/share/classes/sun/awt/datatransfer/DataTransferer.java Changeset: bfff9e9120ec Author: malenkov Date: 2013-09-27 22:17 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bfff9e9120ec 8012716: java.beans.EventHandler.create method should check if the given listenerInterface is a public interface Reviewed-by: art, mchung ! src/share/classes/java/beans/EventHandler.java Changeset: 0042f54f65d0 Author: malenkov Date: 2013-09-27 22:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0042f54f65d0 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed Reviewed-by: anthony, serb ! src/macosx/classes/sun/awt/CGraphicsEnvironment.java ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java Changeset: 603cd3cefbb0 Author: malenkov Date: 2013-09-30 22:08 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/603cd3cefbb0 8025652: [macos] build failed Reviewed-by: serb ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java Changeset: cdfa2301a291 Author: serb Date: 2013-10-01 04:29 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdfa2301a291 7150100: [macosx] "0123456789" is selected in the TextField Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java + test/java/awt/TextArea/SelectionVisible/SelectionVisible.html + test/java/awt/TextArea/SelectionVisible/SelectionVisible.java + test/java/awt/TextField/SelectionVisible/SelectionVisible.html + test/java/awt/TextField/SelectionVisible/SelectionVisible.java Changeset: 2d8418d68a3c Author: kshefov Date: 2013-10-01 13:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2d8418d68a3c 7125471: [macosx] NofocusListDblClickTest should wait between doublr clicks Reviewed-by: anthony, serb Contributed-by: vera.akulova at oracle.com + test/java/awt/List/NofocusListDblClickTest/NofocusListDblClickTest.java Changeset: 329011aad090 Author: kshefov Date: 2013-10-01 13:30 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/329011aad090 8012468: [TEST_BUG] javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java doesn't release mouse button Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com ! test/javax/swing/PopupFactory/6276087/NonOpaquePopupMenuTest.java Changeset: 0887aad989fb Author: kshefov Date: 2013-10-01 13:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0887aad989fb 8012466: [TEST_BUG] javax/swing/JInternalFrame/Test6505027.java doesn't release mouse button Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com ! test/javax/swing/JInternalFrame/Test6505027.java Changeset: 1043bd1f7fca Author: kshefov Date: 2013-10-01 13:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1043bd1f7fca 8004294: [TEST_BUG] javax/swing/JSpinner/4973721/bug4973721.java failed on win2003 Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com + test/javax/swing/JSpinner/4973721/bug4973721.java Changeset: 68157255f3eb Author: kshefov Date: 2013-10-01 13:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68157255f3eb 8012461: [TEST_BUG] closed/javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java doesn't release mouse button Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com + test/javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java + test/javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.xml Changeset: 172405287fde Author: kshefov Date: 2013-10-01 13:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/172405287fde 7133545: [macosx] closed/javax/swing/JSplitPane/4514858/bug4514858.java fails on MacOS Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com + test/javax/swing/JSplitPane/4514858/bug4514858.java Changeset: 291e66f4cb83 Author: kshefov Date: 2013-10-01 13:47 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/291e66f4cb83 7133532: [macosx] closed/javax/swing/JScrollBar/bug4202954/bug4202954.java fails on MacOS Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com + test/javax/swing/JScrollBar/bug4202954/bug4202954.java Changeset: 560ede42bd2e Author: kshefov Date: 2013-10-01 14:38 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/560ede42bd2e 8025707: Frogot to add a file to fix for JDK-8012461 Reviewed-by: serb, alexsch Contributed-by: vera.akulova at oracle.com + test/javax/swing/plaf/synth/SynthButtonUI/6276188/red.gif Changeset: a0c28e64c049 Author: alitvinov Date: 2013-10-01 18:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a0c28e64c049 8025145: [macosx]: java 7 does not recognize tiff image on clipboard Reviewed-by: anthony, serb Contributed-by: anton.nashatyrev at oracle.com ! src/macosx/lib/flavormap.properties Changeset: 5e205645d990 Author: pchelko Date: 2013-10-02 11:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e205645d990 7124363: [macosx] ClassCastException: CFileDialog cannot be cast to LWWindowPeer Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/LWWindowPeer.java Changeset: 1189f954d52f Author: pchelko Date: 2013-10-02 11:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1189f954d52f 8024163: [macosx] NullPointerException at javax.swing.TransferHandler$DropHandler.handleDrag since jdk8b93, 7u40b28 Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CDropTargetContextPeer.java ! src/macosx/native/sun/awt/CDropTarget.m + test/java/awt/dnd/DropTargetEnterExitTest/ExtraDragEnterTest.java + test/java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java Changeset: 01198c681710 Author: pchelko Date: 2013-10-02 11:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01198c681710 8024600: [macosx] code prevents use of -Xlint:auxiliaryclass,empty in jdk build Reviewed-by: anthony, serb ! src/macosx/classes/com/apple/eawt/_AppEventLegacyHandler.java + src/macosx/classes/com/apple/eawt/_OpenAppHandler.java ! src/macosx/classes/com/apple/laf/AquaComboBoxRenderer.java + src/macosx/classes/com/apple/laf/AquaComboBoxRendererInternal.java ! src/macosx/classes/com/apple/laf/AquaMenuBarUI.java Changeset: 287e0a7731ff Author: pchelko Date: 2013-10-02 16:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/287e0a7731ff 8024158: [macosx] java/awt/EventDispatchThread/LoopRobustness/LoopRobustness still failed after fix JDK-8022247; since jdk8b96 Reviewed-by: art, leonidr ! src/macosx/classes/sun/lwawt/LWWindowPeer.java Changeset: 244f2ee51f31 Author: leonidr Date: 2013-10-02 17:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/244f2ee51f31 8023994: Right click on the icon added to the system tray for the first time, java.lang.IllegalArgumentException thrown. Reviewed-by: anthony, serb ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java Changeset: f40f2421c60f Author: serb Date: 2013-10-02 21:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f40f2421c60f 8013563: Memory leak in JFrame on Linux Reviewed-by: anthony, art ! src/share/classes/java/awt/Window.java + test/java/awt/Window/WindowsLeak/WindowsLeak.java Changeset: 1da5d306e84b Author: cl Date: 2013-10-02 11:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1da5d306e84b 8025409: Fix javadoc comments errors and warning reported by doclint report Reviewed-by: anthony, yan ! src/share/classes/java/awt/BorderLayout.java ! src/share/classes/java/awt/Button.java ! src/share/classes/java/awt/Checkbox.java ! src/share/classes/java/awt/CheckboxGroup.java ! src/share/classes/java/awt/CheckboxMenuItem.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/Color.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/FlowLayout.java ! src/share/classes/java/awt/FontMetrics.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/GridBagLayout.java ! src/share/classes/java/awt/GridLayout.java ! src/share/classes/java/awt/Label.java ! src/share/classes/java/awt/LinearGradientPaint.java ! src/share/classes/java/awt/List.java ! src/share/classes/java/awt/MenuBar.java ! src/share/classes/java/awt/MenuItem.java ! src/share/classes/java/awt/RadialGradientPaint.java ! src/share/classes/java/awt/Scrollbar.java ! src/share/classes/java/awt/SystemTray.java ! src/share/classes/java/awt/TextArea.java ! src/share/classes/java/awt/TextField.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/font/TextAttribute.java ! src/share/classes/java/awt/geom/AffineTransform.java ! src/share/classes/java/awt/geom/Line2D.java ! src/share/classes/java/awt/print/PrinterJob.java ! src/share/classes/javax/print/Doc.java ! src/share/classes/javax/print/DocFlavor.java ! src/share/classes/javax/print/MultiDoc.java ! src/share/classes/javax/print/attribute/standard/Finishings.java ! src/share/classes/javax/print/attribute/standard/JobStateReasons.java ! src/share/classes/javax/print/attribute/standard/MediaPrintableArea.java ! src/share/classes/javax/print/attribute/standard/MultipleDocumentHandling.java ! src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java ! src/share/classes/javax/print/attribute/standard/Sides.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/JScrollPane.java ! src/share/classes/javax/swing/JTabbedPane.java ! src/share/classes/javax/swing/LookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalTreeUI.java ! src/share/classes/javax/swing/text/Document.java ! src/share/classes/javax/swing/text/MaskFormatter.java ! src/share/classes/javax/swing/text/View.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java Changeset: 998578a87c0e Author: bagiras Date: 2013-10-03 16:51 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/998578a87c0e 8013553: [macosx] java.awt.FileDialog removes file extensions Reviewed-by: leonidr, serb ! src/macosx/native/sun/awt/CFileDialog.m Changeset: 1533a379deb0 Author: anthony Date: 2013-10-03 18:01 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1533a379deb0 7174704: [macosx] New issue in 7u6 b12: HeadlessPrintingTest failure Summary: Load the lwawt native library on Mac regardless of the headless/headful mode. Also, some minor cleanup. Reviewed-by: art, serb ! src/macosx/native/sun/awt/awt.m ! src/solaris/native/sun/awt/awt_LoadLibrary.c Changeset: 39b674405270 Author: alexsch Date: 2013-10-03 19:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39b674405270 7092283: Property Window.locationByPlatform is not cleared by calling setVisible(false) Reviewed-by: anthony, serb ! src/share/classes/java/awt/Window.java + test/java/awt/Window/LocationByPlatform/LocationByPlatformTest.java Changeset: 6ffe50fe06bd Author: mcherkas Date: 2013-10-04 20:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ffe50fe06bd 8020688: Broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index. Reviewed-by: anthony, alexsch ! src/macosx/classes/apple/applescript/AppleScriptEngine.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/XMLX509SKI.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverDirectHTTP.java ! src/share/classes/java/applet/Applet.java ! src/share/classes/java/applet/AppletStub.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/DefaultFocusTraversalPolicy.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/DisplayMode.java ! src/share/classes/java/awt/FocusTraversalPolicy.java ! src/share/classes/java/awt/Font.java ! src/share/classes/java/awt/GraphicsDevice.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/datatransfer/DataFlavor.java ! src/share/classes/java/awt/datatransfer/Transferable.java ! src/share/classes/java/awt/event/ActionEvent.java ! src/share/classes/java/awt/event/ActionListener.java ! src/share/classes/java/awt/event/ComponentAdapter.java ! src/share/classes/java/awt/event/ComponentEvent.java ! src/share/classes/java/awt/event/ComponentListener.java ! src/share/classes/java/awt/event/ContainerAdapter.java ! src/share/classes/java/awt/event/ContainerEvent.java ! src/share/classes/java/awt/event/ContainerListener.java ! src/share/classes/java/awt/event/FocusAdapter.java ! src/share/classes/java/awt/event/FocusEvent.java ! src/share/classes/java/awt/event/FocusListener.java ! src/share/classes/java/awt/event/ItemEvent.java ! src/share/classes/java/awt/event/ItemListener.java ! src/share/classes/java/awt/event/KeyAdapter.java ! src/share/classes/java/awt/event/KeyEvent.java ! src/share/classes/java/awt/event/MouseAdapter.java ! src/share/classes/java/awt/event/MouseEvent.java ! src/share/classes/java/awt/event/MouseListener.java ! src/share/classes/java/awt/event/MouseMotionAdapter.java ! src/share/classes/java/awt/event/MouseMotionListener.java ! src/share/classes/java/awt/event/WindowAdapter.java ! src/share/classes/java/awt/event/WindowEvent.java ! src/share/classes/java/awt/event/WindowFocusListener.java ! src/share/classes/java/awt/event/WindowListener.java ! src/share/classes/java/awt/geom/Line2D.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/net/URI.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/javax/management/Descriptor.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/BorderFactory.java ! src/share/classes/javax/swing/BoundedRangeModel.java ! src/share/classes/javax/swing/Box.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/ButtonGroup.java ! src/share/classes/javax/swing/DefaultFocusManager.java ! src/share/classes/javax/swing/FocusManager.java ! src/share/classes/javax/swing/ImageIcon.java ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JButton.java ! src/share/classes/javax/swing/JCheckBox.java ! src/share/classes/javax/swing/JCheckBoxMenuItem.java ! src/share/classes/javax/swing/JColorChooser.java ! src/share/classes/javax/swing/JComboBox.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JDesktopPane.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JFileChooser.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JList.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JMenuBar.java ! src/share/classes/javax/swing/JMenuItem.java ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/JPanel.java ! src/share/classes/javax/swing/JPasswordField.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JProgressBar.java ! src/share/classes/javax/swing/JRadioButton.java ! src/share/classes/javax/swing/JRadioButtonMenuItem.java ! src/share/classes/javax/swing/JRootPane.java ! src/share/classes/javax/swing/JScrollPane.java ! src/share/classes/javax/swing/JSeparator.java ! src/share/classes/javax/swing/JSlider.java ! src/share/classes/javax/swing/JSpinner.java ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTabbedPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JTextArea.java ! src/share/classes/javax/swing/JTextField.java ! src/share/classes/javax/swing/JTextPane.java ! src/share/classes/javax/swing/JToggleButton.java ! src/share/classes/javax/swing/JToolBar.java ! src/share/classes/javax/swing/JToolTip.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/ProgressMonitor.java ! src/share/classes/javax/swing/ProgressMonitorInputStream.java ! src/share/classes/javax/swing/Spring.java ! src/share/classes/javax/swing/SpringLayout.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/SwingWorker.java ! src/share/classes/javax/swing/Timer.java ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/javax/swing/WindowConstants.java ! src/share/classes/javax/swing/border/Border.java ! src/share/classes/javax/swing/event/InternalFrameAdapter.java ! src/share/classes/javax/swing/event/InternalFrameEvent.java ! src/share/classes/javax/swing/event/InternalFrameListener.java ! src/share/classes/javax/swing/event/TreeExpansionEvent.java ! src/share/classes/javax/swing/event/TreeExpansionListener.java ! src/share/classes/javax/swing/event/TreeModelEvent.java ! src/share/classes/javax/swing/event/TreeModelListener.java ! src/share/classes/javax/swing/event/TreeSelectionListener.java ! src/share/classes/javax/swing/event/TreeWillExpandListener.java ! src/share/classes/javax/swing/filechooser/FileFilter.java ! src/share/classes/javax/swing/filechooser/FileView.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/table/TableModel.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/PlainDocument.java ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/tree/DefaultMutableTreeNode.java ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java ! src/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/share/classes/javax/swing/tree/ExpandVetoException.java ! src/share/classes/javax/swing/tree/TreeCellRenderer.java ! src/share/classes/javax/swing/tree/TreeModel.java ! src/share/classes/javax/swing/tree/TreeNode.java ! src/share/classes/javax/swing/tree/TreePath.java ! src/share/classes/javax/swing/tree/TreeSelectionModel.java ! src/share/classes/sun/swing/PrintingStatus.java ! src/share/classes/sun/text/normalizer/UCharacter.java ! src/share/demo/jfc/FileChooserDemo/FileChooserDemo.java Changeset: 01b40315f872 Author: alexsch Date: 2013-10-07 16:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01b40315f872 8025438: [macosx] right JNFCall* method should be used in JDK-8008728 fix Reviewed-by: serb, anthony ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 72afa269fa3b Author: alexsch Date: 2013-10-07 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72afa269fa3b 8007219: [macosx] Frame size reverts meaning of maximized attribute if frame size close to display Reviewed-by: serb, anthony ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/native/sun/awt/CWrapper.m + test/java/awt/Frame/MaximizedToMaximized/MaximizedToMaximized.java Changeset: 546c0ebfbf56 Author: cl Date: 2013-10-07 11:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/546c0ebfbf56 8025840: Fix all the doclint warnings about trademark Reviewed-by: art ! src/share/classes/javax/swing/AbstractAction.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/AbstractCellEditor.java ! src/share/classes/javax/swing/AbstractListModel.java ! src/share/classes/javax/swing/Box.java ! src/share/classes/javax/swing/BoxLayout.java ! src/share/classes/javax/swing/ButtonGroup.java ! src/share/classes/javax/swing/CellRendererPane.java ! src/share/classes/javax/swing/DefaultBoundedRangeModel.java ! src/share/classes/javax/swing/DefaultButtonModel.java ! src/share/classes/javax/swing/DefaultCellEditor.java ! src/share/classes/javax/swing/DefaultListCellRenderer.java ! src/share/classes/javax/swing/DefaultListModel.java ! src/share/classes/javax/swing/DefaultListSelectionModel.java ! src/share/classes/javax/swing/DefaultSingleSelectionModel.java ! src/share/classes/javax/swing/ImageIcon.java ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JButton.java ! src/share/classes/javax/swing/JCheckBox.java ! src/share/classes/javax/swing/JCheckBoxMenuItem.java ! src/share/classes/javax/swing/JColorChooser.java ! src/share/classes/javax/swing/JComboBox.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JDesktopPane.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JEditorPane.java ! src/share/classes/javax/swing/JFormattedTextField.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JLayeredPane.java ! src/share/classes/javax/swing/JList.java ! src/share/classes/javax/swing/JMenu.java ! src/share/classes/javax/swing/JMenuBar.java ! src/share/classes/javax/swing/JMenuItem.java ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/JPanel.java ! src/share/classes/javax/swing/JPasswordField.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/javax/swing/JProgressBar.java ! src/share/classes/javax/swing/JRadioButton.java ! src/share/classes/javax/swing/JRadioButtonMenuItem.java ! src/share/classes/javax/swing/JRootPane.java ! src/share/classes/javax/swing/JScrollBar.java ! src/share/classes/javax/swing/JScrollPane.java ! src/share/classes/javax/swing/JSeparator.java ! src/share/classes/javax/swing/JSlider.java ! src/share/classes/javax/swing/JSpinner.java ! src/share/classes/javax/swing/JSplitPane.java ! src/share/classes/javax/swing/JTabbedPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JTextArea.java ! src/share/classes/javax/swing/JTextField.java ! src/share/classes/javax/swing/JTextPane.java ! src/share/classes/javax/swing/JToggleButton.java ! src/share/classes/javax/swing/JToolBar.java ! src/share/classes/javax/swing/JToolTip.java ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/JViewport.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/KeyStroke.java ! src/share/classes/javax/swing/OverlayLayout.java ! src/share/classes/javax/swing/ScrollPaneLayout.java ! src/share/classes/javax/swing/SizeRequirements.java ! src/share/classes/javax/swing/Spring.java ! src/share/classes/javax/swing/SpringLayout.java ! src/share/classes/javax/swing/Timer.java ! src/share/classes/javax/swing/UIDefaults.java ! src/share/classes/javax/swing/UIManager.java ! src/share/classes/javax/swing/UnsupportedLookAndFeelException.java ! src/share/classes/javax/swing/ViewportLayout.java ! src/share/classes/javax/swing/border/AbstractBorder.java ! src/share/classes/javax/swing/border/BevelBorder.java ! src/share/classes/javax/swing/border/CompoundBorder.java ! src/share/classes/javax/swing/border/EmptyBorder.java ! src/share/classes/javax/swing/border/EtchedBorder.java ! src/share/classes/javax/swing/border/LineBorder.java ! src/share/classes/javax/swing/border/MatteBorder.java ! src/share/classes/javax/swing/border/SoftBevelBorder.java ! src/share/classes/javax/swing/border/TitledBorder.java ! src/share/classes/javax/swing/colorchooser/AbstractColorChooserPanel.java ! src/share/classes/javax/swing/colorchooser/ColorChooserComponentFactory.java ! src/share/classes/javax/swing/colorchooser/DefaultPreviewPanel.java ! src/share/classes/javax/swing/colorchooser/DefaultSwatchChooserPanel.java ! src/share/classes/javax/swing/event/AncestorEvent.java ! src/share/classes/javax/swing/event/CaretEvent.java ! src/share/classes/javax/swing/event/ChangeEvent.java ! src/share/classes/javax/swing/event/EventListenerList.java ! src/share/classes/javax/swing/event/HyperlinkEvent.java ! src/share/classes/javax/swing/event/InternalFrameEvent.java ! src/share/classes/javax/swing/event/ListDataEvent.java ! src/share/classes/javax/swing/event/ListSelectionEvent.java ! src/share/classes/javax/swing/event/MenuDragMouseEvent.java ! src/share/classes/javax/swing/event/MenuEvent.java ! src/share/classes/javax/swing/event/MenuKeyEvent.java ! src/share/classes/javax/swing/event/PopupMenuEvent.java ! src/share/classes/javax/swing/event/TableColumnModelEvent.java ! src/share/classes/javax/swing/event/TableModelEvent.java ! src/share/classes/javax/swing/event/TreeExpansionEvent.java ! src/share/classes/javax/swing/event/TreeModelEvent.java ! src/share/classes/javax/swing/event/TreeSelectionEvent.java ! src/share/classes/javax/swing/event/UndoableEditEvent.java ! src/share/classes/javax/swing/plaf/BorderUIResource.java ! src/share/classes/javax/swing/plaf/ColorUIResource.java ! src/share/classes/javax/swing/plaf/DimensionUIResource.java ! src/share/classes/javax/swing/plaf/FontUIResource.java ! src/share/classes/javax/swing/plaf/IconUIResource.java ! src/share/classes/javax/swing/plaf/InsetsUIResource.java ! src/share/classes/javax/swing/plaf/basic/BasicArrowButton.java ! src/share/classes/javax/swing/plaf/basic/BasicCheckBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxEditor.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxRenderer.java ! src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java ! src/share/classes/javax/swing/plaf/basic/BasicEditorPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicIconFactory.java ! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/basic/BasicListUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java ! src/share/classes/javax/swing/plaf/basic/BasicTextAreaUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTextFieldUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTextPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/share/classes/javax/swing/plaf/basic/ComboPopup.java ! src/share/classes/javax/swing/plaf/metal/DefaultMetalTheme.java ! src/share/classes/javax/swing/plaf/metal/MetalButtonUI.java ! src/share/classes/javax/swing/plaf/metal/MetalCheckBoxIcon.java ! src/share/classes/javax/swing/plaf/metal/MetalCheckBoxUI.java ! src/share/classes/javax/swing/plaf/metal/MetalComboBoxButton.java ! src/share/classes/javax/swing/plaf/metal/MetalComboBoxEditor.java ! src/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java ! src/share/classes/javax/swing/plaf/metal/MetalIconFactory.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/plaf/metal/MetalProgressBarUI.java ! src/share/classes/javax/swing/plaf/metal/MetalRadioButtonUI.java ! src/share/classes/javax/swing/plaf/metal/MetalRootPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalScrollButton.java ! src/share/classes/javax/swing/plaf/metal/MetalScrollPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalSeparatorUI.java ! src/share/classes/javax/swing/plaf/metal/MetalSliderUI.java ! src/share/classes/javax/swing/plaf/metal/MetalSplitPaneDivider.java ! src/share/classes/javax/swing/plaf/metal/MetalSplitPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/metal/MetalTextFieldUI.java ! src/share/classes/javax/swing/plaf/metal/MetalToggleButtonUI.java ! src/share/classes/javax/swing/plaf/metal/MetalToolTipUI.java ! src/share/classes/javax/swing/plaf/multi/MultiLookAndFeel.java ! src/share/classes/javax/swing/plaf/synth/SynthTextAreaUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextPaneUI.java ! src/share/classes/javax/swing/table/AbstractTableModel.java ! src/share/classes/javax/swing/table/DefaultTableCellRenderer.java ! src/share/classes/javax/swing/table/DefaultTableColumnModel.java ! src/share/classes/javax/swing/table/DefaultTableModel.java ! src/share/classes/javax/swing/table/JTableHeader.java ! src/share/classes/javax/swing/table/TableColumn.java ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/BadLocationException.java ! src/share/classes/javax/swing/text/DateFormatter.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/share/classes/javax/swing/text/DefaultEditorKit.java ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/DefaultFormatterFactory.java ! src/share/classes/javax/swing/text/DefaultStyledDocument.java ! src/share/classes/javax/swing/text/InternationalFormatter.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/MaskFormatter.java ! src/share/classes/javax/swing/text/NumberFormatter.java ! src/share/classes/javax/swing/text/PlainDocument.java ! src/share/classes/javax/swing/text/SimpleAttributeSet.java ! src/share/classes/javax/swing/text/StringContent.java ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/javax/swing/text/StyledEditorKit.java ! src/share/classes/javax/swing/text/TabSet.java ! src/share/classes/javax/swing/text/TabStop.java ! src/share/classes/javax/swing/text/TextAction.java ! src/share/classes/javax/swing/text/html/Option.java ! src/share/classes/javax/swing/tree/AbstractLayoutCache.java ! src/share/classes/javax/swing/tree/DefaultMutableTreeNode.java ! src/share/classes/javax/swing/tree/DefaultTreeCellEditor.java ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java ! src/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/share/classes/javax/swing/tree/FixedHeightLayoutCache.java ! src/share/classes/javax/swing/tree/TreePath.java ! src/share/classes/javax/swing/tree/VariableHeightLayoutCache.java ! src/share/classes/javax/swing/undo/CannotRedoException.java ! src/share/classes/javax/swing/undo/CannotUndoException.java ! src/share/classes/javax/swing/undo/UndoManager.java Changeset: bdc8abbce9c1 Author: yan Date: 2013-10-08 13:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bdc8abbce9c1 8025236: [javadoc] fix some errors in AWT Reviewed-by: yan, anthony Contributed-by: Dmitry Ginzburg ! src/share/classes/java/awt/event/InputEvent.java ! src/share/classes/java/awt/event/MouseEvent.java ! src/share/classes/java/awt/im/InputContext.java ! src/share/classes/java/awt/im/InputMethodHighlight.java Changeset: 01022f461570 Author: pchelko Date: 2013-10-08 15:17 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01022f461570 7158311: GraphicsDevice.setDisplayMode(...) leads to hang when DISPLAY variable points to Oracle Linux 8001463: Regression : Deadlock between AWT-XAWT thread and AWT-EventQueue-0 Thread when screen resolution changes Reviewed-by: art, serb Contributed-by: alexander.zvegintsev at oracle.com ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: a5d0730342a5 Author: pchelko Date: 2013-10-08 15:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5d0730342a5 8025585: Win: Popups in JFXPanel do not receive MouseWheel events Reviewed-by: anthony, art ! src/windows/native/sun/windows/awt_Toolkit.cpp Changeset: 85a72bb00d74 Author: bagiras Date: 2013-10-08 16:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85a72bb00d74 8000425: FileDialog documentation should be enhanced Reviewed-by: serb, anthony ! src/share/classes/java/awt/FileDialog.java Changeset: 01607de6265d Author: bagiras Date: 2013-10-08 16:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01607de6265d 7068423: Spec for java.awt.GraphicsDevice.getFullScreenWindow() needs clarification Reviewed-by: art, anthony ! src/share/classes/java/awt/GraphicsDevice.java Changeset: 184b16f4e61f Author: bagiras Date: 2013-10-08 17:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/184b16f4e61f 7199196: Incremental transfer is broken because of a typo Reviewed-by: anthony, serb ! src/solaris/classes/sun/awt/X11/XSelection.java Changeset: 42d3ea1c35b4 Author: malenkov Date: 2013-10-08 18:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/42d3ea1c35b4 7081584: Specification for Window.isAlwaysOnTopSupported needs to be clarified Reviewed-by: art, serb ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/macosx/CFileDialog.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/peer/ComponentPeer.java ! src/share/classes/sun/awt/NullComponentPeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java Changeset: 6914b883c3bb Author: malenkov Date: 2013-10-08 18:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6914b883c3bb 7172597: java.awt.KeyboardFocusManager.clearFocusOwner() missed javadoc tag @since 1.8 Reviewed-by: art, anthony ! src/share/classes/java/awt/KeyboardFocusManager.java Changeset: a2dd2b411723 Author: alexsch Date: 2013-10-08 18:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a2dd2b411723 7081594: Windows owned by an always-on-top window DO NOT automatically become always-on-top Reviewed-by: art, anthony, serb ! src/share/classes/java/awt/Window.java + test/java/awt/Window/AlwaysOnTop/AlwaysOnTopFieldTest.java Changeset: 0c06c38dfc3e Author: serb Date: 2013-10-08 21:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c06c38dfc3e 8022119: test api/javax_sound/sampled/spi/MixerProvider/indexTGF_MixerProviderTests fails Reviewed-by: art, anthony ! src/share/classes/com/sun/media/sound/JSSecurityManager.java Changeset: b218a14bdc8a Author: serb Date: 2013-10-08 23:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b218a14bdc8a 8025603: Unused methods in the awt text peers should be removed Reviewed-by: art, anthony ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/peer/TextComponentPeer.java ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java ! src/windows/classes/sun/awt/windows/WButtonPeer.java ! src/windows/classes/sun/awt/windows/WCheckboxPeer.java ! src/windows/classes/sun/awt/windows/WChoicePeer.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WLabelPeer.java ! src/windows/classes/sun/awt/windows/WListPeer.java ! src/windows/classes/sun/awt/windows/WScrollbarPeer.java ! src/windows/classes/sun/awt/windows/WTextAreaPeer.java ! src/windows/classes/sun/awt/windows/WTextComponentPeer.java ! src/windows/classes/sun/awt/windows/WTextFieldPeer.java ! src/windows/native/sun/windows/awt_TextArea.cpp ! src/windows/native/sun/windows/awt_TextComponent.cpp ! src/windows/native/sun/windows/awt_TextField.cpp Changeset: e591ac19174f Author: leonidr Date: 2013-10-09 01:03 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e591ac19174f 8004050: [macosx] The 'ESC' key does not work with jdk8 Reviewed-by: alexsch, serb ! src/macosx/classes/com/apple/laf/AquaComboBoxUI.java ! src/macosx/classes/com/apple/laf/AquaKeyBindings.java Changeset: c1ef9ebac26a Author: lana Date: 2013-10-08 14:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1ef9ebac26a Merge ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java Changeset: 748207aa9620 Author: lana Date: 2013-10-08 14:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/748207aa9620 Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/time/chrono/ChronoDateImpl.java - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java Changeset: 575d4bc3bcae Author: lana Date: 2013-10-11 03:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/575d4bc3bcae Merge ! makefiles/CreateJars.gmk - src/share/classes/java/lang/invoke/InvokeGeneric.java - src/share/classes/java/time/chrono/ChronoDateImpl.java - test/java/time/tck/java/time/chrono/TCKChronologySerialization.java Changeset: 96644227daed Author: lana Date: 2013-10-11 23:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/96644227daed Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk Changeset: 3a5c987ff3a0 Author: lana Date: 2013-10-14 09:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a5c987ff3a0 Merge From jan.lahoda at oracle.com Mon Oct 14 20:14:03 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Mon, 14 Oct 2013 20:14:03 +0000 Subject: hg: jdk8/tl/langtools: 8014016: javac is too late detecting invalid annotation usage Message-ID: <20131014201425.D6D7E6239E@hg.openjdk.java.net> Changeset: 87b5bfef7edb Author: jlahoda Date: 2013-10-14 22:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/87b5bfef7edb 8014016: javac is too late detecting invalid annotation usage Summary: Adding new queue to Annotate for validation tasks, performing annotation validation during enter Reviewed-by: jjg, emc, jfranck ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.out + test/tools/javac/processing/errors/StopOnInapplicableAnnotations/GenerateFunctionalInterface.java + test/tools/javac/processing/errors/StopOnInapplicableAnnotations/GenerateSuperInterfaceProcessor.java + test/tools/javac/processing/errors/StopOnInapplicableAnnotations/Processor.java + test/tools/javac/processing/errors/StopOnInapplicableAnnotations/Source.java From fengzm at sg.ibm.com Mon Oct 14 20:18:25 2013 From: fengzm at sg.ibm.com (Zhemin Feng) Date: Tue, 15 Oct 2013 04:18:25 +0800 Subject: AUTO: Zhemin Feng is out of the office (returning 10/23/2013) Message-ID: I am out of the office until 10/23/2013. I will take leave from Tuesday for about one week, and will be back on 23th Oct. Please contact Tianyu Tang/Singapore/IBM for Java Security L3 work. Best regards, Feng Zhemin Note: This is an automated response to your message "security-dev Digest, Vol 76, Issue 27" sent on 10/15/2013 2:49:58. This is the only notification you will receive while this person is away. -------------- next part -------------- An HTML attachment was scrubbed... URL: From michael.x.mcmahon at oracle.com Mon Oct 14 21:10:22 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Mon, 14 Oct 2013 21:10:22 +0000 Subject: hg: jdk8/tl/jdk: 8014719: HttpClient/ProxyTest.java failing with IAE HttpURLPermission.parseURI Message-ID: <20131014211103.07C21623A0@hg.openjdk.java.net> Changeset: dd0deeb04933 Author: michaelm Date: 2013-10-14 22:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd0deeb04933 8014719: HttpClient/ProxyTest.java failing with IAE HttpURLPermission.parseURI Reviewed-by: alanb, chegar + src/share/classes/java/net/HostPortrange.java ! src/share/classes/java/net/HttpURLConnection.java - src/share/classes/java/net/HttpURLPermission.java + src/share/classes/java/net/URLPermission.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 + test/java/net/URLPermission/URLPermissionTest.java + test/java/net/URLPermission/URLTest.java + test/java/net/URLPermission/policy.1 + test/java/net/URLPermission/policy.2 + test/java/net/URLPermission/policy.3 From henry.jen at oracle.com Tue Oct 15 00:28:00 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Tue, 15 Oct 2013 00:28:00 +0000 Subject: hg: jdk8/tl/jdk: 8026362: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed on windows, jtreg report Fail to org.testng.SkipException Message-ID: <20131015002828.C515B623B2@hg.openjdk.java.net> Changeset: 94d4aa2fb414 Author: henryjen Date: 2013-10-14 17:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94d4aa2fb414 8026362: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed on windows, jtreg report Fail to org.testng.SkipException Reviewed-by: chegar ! test/java/lang/invoke/lambda/LogGeneratedClassesTest.java From stefan.karlsson at oracle.com Mon Oct 14 12:40:22 2013 From: stefan.karlsson at oracle.com (stefan.karlsson at oracle.com) Date: Mon, 14 Oct 2013 12:40:22 +0000 Subject: hg: jdk8/tl/jdk: 7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2 Message-ID: <20131014124112.178C06237C@hg.openjdk.java.net> Changeset: f15a0087181e Author: stefank Date: 2013-10-14 14:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f15a0087181e 7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2 Reviewed-by: coleenp, sla Contributed-by: stefan.karlsson at oracle.com, coleen.phillimore at oracle.com ! test/java/lang/management/MemoryMXBean/LowMemoryTest2.java ! test/java/lang/management/MemoryMXBean/LowMemoryTest2.sh From jonathan.gibbons at oracle.com Tue Oct 15 04:52:03 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 15 Oct 2013 04:52:03 +0000 Subject: hg: jdk8/tl/langtools: 8026371: "tidy" issues in langtools/src/**/*.html files Message-ID: <20131015045206.996DF623C5@hg.openjdk.java.net> Changeset: b9e3b55a908c Author: jjg Date: 2013-10-14 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b9e3b55a908c 8026371: "tidy" issues in langtools/src/**/*.html files Reviewed-by: darcy + src/share/classes/com/sun/javadoc/package-info.java - src/share/classes/com/sun/javadoc/package.html + src/share/classes/com/sun/tools/classfile/package-info.java - src/share/classes/com/sun/tools/classfile/package.html + src/share/classes/com/sun/tools/doclets/formats/html/markup/package-info.java - src/share/classes/com/sun/tools/doclets/formats/html/markup/package.html + src/share/classes/com/sun/tools/doclets/formats/html/package-info.java - src/share/classes/com/sun/tools/doclets/formats/html/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/package.html + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/package-info.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/package.html + src/share/classes/com/sun/tools/doclets/package-info.java - src/share/classes/com/sun/tools/doclets/package.html + src/share/classes/com/sun/tools/javap/package-info.java - src/share/classes/com/sun/tools/javap/package.html ! src/share/classes/javax/lang/model/overview.html ! src/share/classes/javax/tools/overview.html From huizhe.wang at oracle.com Tue Oct 15 05:08:13 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 15 Oct 2013 05:08:13 +0000 Subject: hg: jdk8/tl/jaxp: 8015092: SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression Message-ID: <20131015050818.7D767623C8@hg.openjdk.java.net> Changeset: eb169222d3f2 Author: joehw Date: 2013-10-14 22:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/eb169222d3f2 8015092: SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression Reviewed-by: lancea, alanb ! src/com/sun/org/apache/xerces/internal/impl/xpath/XPath.java From huizhe.wang at oracle.com Tue Oct 15 05:28:24 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 15 Oct 2013 05:28:24 +0000 Subject: hg: jdk8/tl/jdk: 8015092: SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression Message-ID: <20131015052905.CC8A9623CA@hg.openjdk.java.net> Changeset: 50e88f25255f Author: joehw Date: 2013-10-14 22:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50e88f25255f 8015092: SchemaFactory cannot parse schema if whitespace added within patterns in Selector XPath expression Reviewed-by: lancea, alanb + test/javax/xml/jaxp/validation/8015092/XPathWhiteSpaceTest.java + test/javax/xml/jaxp/validation/8015092/idIxpns.xsd + test/javax/xml/jaxp/validation/8015092/idIxpns1.xsd + test/javax/xml/jaxp/validation/8015092/idJ029.xsd + test/javax/xml/jaxp/validation/8015092/idJimp.xsd From jonathan.gibbons at oracle.com Tue Oct 15 05:36:29 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 15 Oct 2013 05:36:29 +0000 Subject: hg: jdk8/tl/langtools: 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail Message-ID: <20131015053632.19853623CB@hg.openjdk.java.net> Changeset: 7d266a2b31b2 Author: jjg Date: 2013-10-14 22:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7d266a2b31b2 8025693: recent javadoc changes cause com/sun/javadoc/testLinkOption/TestLinkOption.java to fail Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java + test/tools/javadoc/8025693/Test.java From jonathan.gibbons at oracle.com Tue Oct 15 06:09:05 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 15 Oct 2013 06:09:05 +0000 Subject: hg: jdk8/tl/langtools: 8025998: Missing LV table in lambda bodies Message-ID: <20131015060908.D2808623CC@hg.openjdk.java.net> Changeset: 09a414673570 Author: jjg Date: 2013-10-14 23:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09a414673570 8025998: Missing LV table in lambda bodies Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/lambda/LocalVariableTable.java From alan.bateman at oracle.com Tue Oct 15 09:57:40 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 15 Oct 2013 09:57:40 +0000 Subject: hg: jdk8/tl/jdk: 8026398: Can't load jdk.Exported, ClassNotFoundException Message-ID: <20131015095854.93053623D7@hg.openjdk.java.net> Changeset: 0b6632e570b0 Author: alanb Date: 2013-10-15 10:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0b6632e570b0 8026398: Can't load jdk.Exported, ClassNotFoundException Reviewed-by: chegar, mchung ! make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java From daniel.fuchs at oracle.com Tue Oct 15 11:02:03 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Tue, 15 Oct 2013 11:02:03 +0000 Subject: hg: jdk8/tl/jdk: 8026404: Logging in Applet can trigger ACE: access denied ("java.lang.RuntimePermission" "modifyThreadGroup") Message-ID: <20131015110224.D7D07623E3@hg.openjdk.java.net> Changeset: 2c16140fb515 Author: dfuchs Date: 2013-10-15 13:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c16140fb515 8026404: Logging in Applet can trigger ACE: access denied ("java.lang.RuntimePermission" "modifyThreadGroup") Summary: The test 'threadGroup.getParent() == null' can sometimes throw ACE and needs to be wrapped in doPrivileged. Reviewed-by: alanb, mchung, dholmes ! src/share/classes/sun/awt/AppContext.java ! test/TEST.groups + test/java/util/logging/TestMainAppContext.java From weijun.wang at oracle.com Tue Oct 15 14:13:09 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 15 Oct 2013 22:13:09 +0800 Subject: Code review request: 7025699: Policy Tool is not accessible by keyboard In-Reply-To: <525D304C.9090304@oracle.com> References: <52589CA1.4080503@oracle.com> <525D304C.9090304@oracle.com> Message-ID: <525D4D75.3090200@oracle.com> Policy Tool is a GUI editor for the plain text policy file. The only I/O is loading the policy file from disk and it should be quite small, so I think there won't be a problem here. Thanks Max On 10/15/13 8:08 PM, Anthony Petrov wrote: > Hi Max, > > I don't have expertise in this code so I haven't reviewed the fix > thoroughly. I'd like to point out one thing though: unlike AWT, Swing is > a single-threaded GUI toolkit. While in AWT you can create > components/windows and call APIs on any thread, in Swing everything > GUI-related must be performed on the Event Dispatch Thread (EDT) only. > Any long, non-GUI-related operations (like I/O, computations, etc.) > should be dispatched on other threads (with a SwingWorker, for example). > > I don't see a single SwingUtilities.invokeLater/invokeAndWait() call in > PolicyTool.java, so I thought I'd ask whether you're aware of the > threading limitations imposed by Swing and how those are going to be > addressed? > > -- > best regards, > Anthony > > On 10/12/2013 04:49 AM, Weijun Wang wrote: >> Hi All >> >> Please review the fix at >> >> http://cr.openjdk.java.net/~weijun/7025699/webrev.00/ >> >> The fix includes porting PolicyTool from AWT to Swing, defining >> mnemonics for menu items and buttons, and adding keyboard shortcuts for >> the File -> New/Open/Save items. Several tests are updated also. >> >> Thanks >> Max From jan.lahoda at oracle.com Tue Oct 15 14:24:33 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Tue, 15 Oct 2013 14:24:33 +0000 Subject: hg: jdk8/tl/langtools: 8026180: com.sun.source.tree.NewArrayTree refers to com.sun.tools.javac.util.List Message-ID: <20131015142436.CBB89623EA@hg.openjdk.java.net> Changeset: 79649bf21a92 Author: jlahoda Date: 2013-10-15 16:23 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79649bf21a92 8026180: com.sun.source.tree.NewArrayTree refers to com.sun.tools.javac.util.List Summary: Correcting import in NewArrayTree, adding test protecting againts improper types in API signatures Reviewed-by: jjg ! src/share/classes/com/sun/source/tree/NewArrayTree.java + test/tools/javac/tree/NoPrivateTypesExported.java From leif.samuelsson at oracle.com Tue Oct 15 17:00:45 2013 From: leif.samuelsson at oracle.com (Leif Samuelsson) Date: Tue, 15 Oct 2013 10:00:45 -0700 Subject: Code review request: 7025699: Policy Tool is not accessible by keyboard In-Reply-To: <525D73C9.2090702@oracle.com> References: <52589CA1.4080503@oracle.com> <525D304C.9090304@oracle.com> <525D4D75.3090200@oracle.com> <525D70B1.4020603@oracle.com> <525D73C9.2090702@oracle.com> Message-ID: <525D74BD.6070707@oracle.com> Thanks for the good feedback. We will make sure to move to move the GUI instantiation to the EDT and the file I/O to a worker thread. All other operations are event driven and therefore occur directly on the EDT. Leif On 2013-10-15 09:56, alexander potochkin wrote: > Hello > >> Well, performing I/O or other blocking operations on EDT can only freeze the app's GUI for the period of blocking. If developers/users are OK with that, this is fine with me too. >> > > I don't think an I/O blocking operation on EDT is acceptable. It can freeze the whole application and give a bad experience to the users. > Please consider using the SwingWorker API > http://docs.oracle.com/javase/tutorial/uiswing/concurrency/worker.html > > >> However, you should still call all Swing APIs (including creating your components/windows) on the EDT. And I don't see this is being done in your current code. As a minimum, the displayToolWindow() method should be dispatched on the event thread. I haven't examined the code closely, but if there are any other GUI updates from separate threads, those should also be moved to the EDT. See the following tutorial for details: >> >> http://docs.oracle.com/javase/tutorial/uiswing/concurrency/dispatch.html >> > > Indeed, rewriting an AWT app as a Swing app is not only about changing Labels to JLabels > Please make sure that all Swing code are used on the event dispatching thread only. > > Thanks > alexp > >> -- >> best regards, >> Anthony >> >> On 10/15/2013 06:13 PM, Weijun Wang wrote: >>> Policy Tool is a GUI editor for the plain text policy file. The only I/O >>> is loading the policy file from disk and it should be quite small, so I >>> think there won't be a problem here. >>> >>> Thanks >>> Max >>> >>> On 10/15/13 8:08 PM, Anthony Petrov wrote: >>>> Hi Max, >>>> >>>> I don't have expertise in this code so I haven't reviewed the fix >>>> thoroughly. I'd like to point out one thing though: unlike AWT, Swing is >>>> a single-threaded GUI toolkit. While in AWT you can create >>>> components/windows and call APIs on any thread, in Swing everything >>>> GUI-related must be performed on the Event Dispatch Thread (EDT) only. >>>> Any long, non-GUI-related operations (like I/O, computations, etc.) >>>> should be dispatched on other threads (with a SwingWorker, for example). >>>> >>>> I don't see a single SwingUtilities.invokeLater/invokeAndWait() call in >>>> PolicyTool.java, so I thought I'd ask whether you're aware of the >>>> threading limitations imposed by Swing and how those are going to be >>>> addressed? >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 10/12/2013 04:49 AM, Weijun Wang wrote: >>>>> Hi All >>>>> >>>>> Please review the fix at >>>>> >>>>> http://cr.openjdk.java.net/~weijun/7025699/webrev.00/ >>>>> >>>>> The fix includes porting PolicyTool from AWT to Swing, defining >>>>> mnemonics for menu items and buttons, and adding keyboard shortcuts for >>>>> the File -> New/Open/Save items. Several tests are updated also. >>>>> >>>>> Thanks >>>>> Max > From jaroslav.bachorik at oracle.com Tue Oct 15 08:37:15 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Tue, 15 Oct 2013 08:37:15 +0000 Subject: hg: jdk8/tl/jdk: 6804470: JvmstatCountersTest.java test times out on slower machines Message-ID: <20131015083748.D959C623D0@hg.openjdk.java.net> Changeset: abe8d432f714 Author: jbachorik Date: 2013-10-15 10:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abe8d432f714 6804470: JvmstatCountersTest.java test times out on slower machines Summary: Increasing the default timeout to cater for the slower machines Reviewed-by: alanb ! test/sun/management/jmxremote/bootstrap/JvmstatCountersTest.java From anthony.petrov at oracle.com Tue Oct 15 12:08:44 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 15 Oct 2013 16:08:44 +0400 Subject: Code review request: 7025699: Policy Tool is not accessible by keyboard In-Reply-To: <52589CA1.4080503@oracle.com> References: <52589CA1.4080503@oracle.com> Message-ID: <525D304C.9090304@oracle.com> Hi Max, I don't have expertise in this code so I haven't reviewed the fix thoroughly. I'd like to point out one thing though: unlike AWT, Swing is a single-threaded GUI toolkit. While in AWT you can create components/windows and call APIs on any thread, in Swing everything GUI-related must be performed on the Event Dispatch Thread (EDT) only. Any long, non-GUI-related operations (like I/O, computations, etc.) should be dispatched on other threads (with a SwingWorker, for example). I don't see a single SwingUtilities.invokeLater/invokeAndWait() call in PolicyTool.java, so I thought I'd ask whether you're aware of the threading limitations imposed by Swing and how those are going to be addressed? -- best regards, Anthony On 10/12/2013 04:49 AM, Weijun Wang wrote: > Hi All > > Please review the fix at > > http://cr.openjdk.java.net/~weijun/7025699/webrev.00/ > > The fix includes porting PolicyTool from AWT to Swing, defining > mnemonics for menu items and buttons, and adding keyboard shortcuts for > the File -> New/Open/Save items. Several tests are updated also. > > Thanks > Max From anthony.petrov at oracle.com Tue Oct 15 16:43:29 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 15 Oct 2013 20:43:29 +0400 Subject: Code review request: 7025699: Policy Tool is not accessible by keyboard In-Reply-To: <525D4D75.3090200@oracle.com> References: <52589CA1.4080503@oracle.com> <525D304C.9090304@oracle.com> <525D4D75.3090200@oracle.com> Message-ID: <525D70B1.4020603@oracle.com> Well, performing I/O or other blocking operations on EDT can only freeze the app's GUI for the period of blocking. If developers/users are OK with that, this is fine with me too. However, you should still call all Swing APIs (including creating your components/windows) on the EDT. And I don't see this is being done in your current code. As a minimum, the displayToolWindow() method should be dispatched on the event thread. I haven't examined the code closely, but if there are any other GUI updates from separate threads, those should also be moved to the EDT. See the following tutorial for details: http://docs.oracle.com/javase/tutorial/uiswing/concurrency/dispatch.html -- best regards, Anthony On 10/15/2013 06:13 PM, Weijun Wang wrote: > Policy Tool is a GUI editor for the plain text policy file. The only I/O > is loading the policy file from disk and it should be quite small, so I > think there won't be a problem here. > > Thanks > Max > > On 10/15/13 8:08 PM, Anthony Petrov wrote: >> Hi Max, >> >> I don't have expertise in this code so I haven't reviewed the fix >> thoroughly. I'd like to point out one thing though: unlike AWT, Swing is >> a single-threaded GUI toolkit. While in AWT you can create >> components/windows and call APIs on any thread, in Swing everything >> GUI-related must be performed on the Event Dispatch Thread (EDT) only. >> Any long, non-GUI-related operations (like I/O, computations, etc.) >> should be dispatched on other threads (with a SwingWorker, for example). >> >> I don't see a single SwingUtilities.invokeLater/invokeAndWait() call in >> PolicyTool.java, so I thought I'd ask whether you're aware of the >> threading limitations imposed by Swing and how those are going to be >> addressed? >> >> -- >> best regards, >> Anthony >> >> On 10/12/2013 04:49 AM, Weijun Wang wrote: >>> Hi All >>> >>> Please review the fix at >>> >>> http://cr.openjdk.java.net/~weijun/7025699/webrev.00/ >>> >>> The fix includes porting PolicyTool from AWT to Swing, defining >>> mnemonics for menu items and buttons, and adding keyboard shortcuts for >>> the File -> New/Open/Save items. Several tests are updated also. >>> >>> Thanks >>> Max From alexander.potochkin at oracle.com Tue Oct 15 16:56:41 2013 From: alexander.potochkin at oracle.com (alexander potochkin) Date: Tue, 15 Oct 2013 09:56:41 -0700 Subject: Code review request: 7025699: Policy Tool is not accessible by keyboard In-Reply-To: <525D70B1.4020603@oracle.com> References: <52589CA1.4080503@oracle.com> <525D304C.9090304@oracle.com> <525D4D75.3090200@oracle.com> <525D70B1.4020603@oracle.com> Message-ID: <525D73C9.2090702@oracle.com> Hello > Well, performing I/O or other blocking operations on EDT can only > freeze the app's GUI for the period of blocking. If developers/users > are OK with that, this is fine with me too. > I don't think an I/O blocking operation on EDT is acceptable. It can freeze the whole application and give a bad experience to the users. Please consider using the SwingWorker API http://docs.oracle.com/javase/tutorial/uiswing/concurrency/worker.html > However, you should still call all Swing APIs (including creating your > components/windows) on the EDT. And I don't see this is being done in > your current code. As a minimum, the displayToolWindow() method should > be dispatched on the event thread. I haven't examined the code > closely, but if there are any other GUI updates from separate threads, > those should also be moved to the EDT. See the following tutorial for > details: > > http://docs.oracle.com/javase/tutorial/uiswing/concurrency/dispatch.html > Indeed, rewriting an AWT app as a Swing app is not only about changing Labels to JLabels Please make sure that all Swing code are used on the event dispatching thread only. Thanks alexp > -- > best regards, > Anthony > > On 10/15/2013 06:13 PM, Weijun Wang wrote: >> Policy Tool is a GUI editor for the plain text policy file. The only I/O >> is loading the policy file from disk and it should be quite small, so I >> think there won't be a problem here. >> >> Thanks >> Max >> >> On 10/15/13 8:08 PM, Anthony Petrov wrote: >>> Hi Max, >>> >>> I don't have expertise in this code so I haven't reviewed the fix >>> thoroughly. I'd like to point out one thing though: unlike AWT, >>> Swing is >>> a single-threaded GUI toolkit. While in AWT you can create >>> components/windows and call APIs on any thread, in Swing everything >>> GUI-related must be performed on the Event Dispatch Thread (EDT) only. >>> Any long, non-GUI-related operations (like I/O, computations, etc.) >>> should be dispatched on other threads (with a SwingWorker, for >>> example). >>> >>> I don't see a single SwingUtilities.invokeLater/invokeAndWait() call in >>> PolicyTool.java, so I thought I'd ask whether you're aware of the >>> threading limitations imposed by Swing and how those are going to be >>> addressed? >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 10/12/2013 04:49 AM, Weijun Wang wrote: >>>> Hi All >>>> >>>> Please review the fix at >>>> >>>> http://cr.openjdk.java.net/~weijun/7025699/webrev.00/ >>>> >>>> The fix includes porting PolicyTool from AWT to Swing, defining >>>> mnemonics for menu items and buttons, and adding keyboard shortcuts >>>> for >>>> the File -> New/Open/Save items. Several tests are updated also. >>>> >>>> Thanks >>>> Max From roger.riggs at oracle.com Tue Oct 15 17:41:17 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 15 Oct 2013 17:41:17 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20131015174243.6B6E7623FB@hg.openjdk.java.net> Changeset: ea422834f880 Author: rriggs Date: 2013-09-26 23:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea422834f880 8025720: Separate temporal interface layer Summary: Remove ZoneId and Chronology from TemporalField interface Reviewed-by: sherman Contributed-by: scolebourne at joda.org ! src/share/classes/java/time/format/Parsed.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/WeekFields.java ! test/java/time/tck/java/time/format/TCKDateTimeParseResolver.java Changeset: 110107410393 Author: scolebourne Date: 2013-07-09 21:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/110107410393 8025719: Change Chronology to an interface Summary: Split Chronology and add AbstractChronology Reviewed-by: darcy Contributed-by: scolebourne at joda.org + src/share/classes/java/time/chrono/AbstractChronology.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/HijrahChronology.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/JapaneseChronology.java ! src/share/classes/java/time/chrono/MinguoChronology.java ! src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java ! test/java/time/tck/java/time/chrono/CopticChronology.java Changeset: 087c8c1d2631 Author: rriggs Date: 2013-10-15 13:14 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/087c8c1d2631 8025722: TemporalAdjusters and TemporalQueries Summary: Move static from interfaces methods to supporting classes Reviewed-by: sherman ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/chrono/AbstractChronology.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoPeriodImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/JapaneseChronology.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/Parsed.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java ! src/share/classes/java/time/temporal/TemporalAdjusters.java ! src/share/classes/java/time/temporal/TemporalAmount.java ! src/share/classes/java/time/temporal/TemporalQueries.java ! src/share/classes/java/time/temporal/TemporalQuery.java ! src/share/classes/java/time/temporal/package-info.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/util/Formatter.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneId.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/TestIsoChronology.java ! test/java/time/tck/java/time/chrono/CopticDate.java ! test/java/time/tck/java/time/chrono/TCKChronoLocalDateTime.java ! test/java/time/tck/java/time/chrono/TCKChronoZonedDateTime.java ! test/java/time/tck/java/time/chrono/TCKIsoChronology.java ! test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java ! test/java/time/tck/java/time/chrono/TCKMinguoChronology.java ! test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java ! test/java/time/tck/java/time/format/TCKChronoPrinterParser.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java ! test/java/time/tck/java/time/format/TCKDateTimeParseResolver.java ! test/java/time/tck/java/time/format/TCKLocalizedPrinterParser.java ! test/java/time/tck/java/time/format/TCKZoneIdPrinterParser.java ! test/java/time/tck/java/time/temporal/TCKTemporalAdjusters.java ! test/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java ! test/java/time/test/java/time/format/TestCharLiteralParser.java ! test/java/time/test/java/time/format/TestNonIsoFormatter.java ! test/java/time/test/java/time/format/TestNumberParser.java ! test/java/time/test/java/time/format/TestStringLiteralParser.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java ! test/java/time/test/java/util/TestFormatter.java From bhavesh.x.patel at oracle.com Tue Oct 15 18:21:01 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Tue, 15 Oct 2013 18:21:01 +0000 Subject: hg: jdk8/tl/langtools: 8026370: javadoc creates empty Message-ID: <20131015182106.98FF0623FE@hg.openjdk.java.net> Changeset: bf6b11347b1a Author: bpatel Date: 2013-10-15 11:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bf6b11347b1a 8026370: javadoc creates empty Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java + test/com/sun/javadoc/testTagOutput/TestTagOutput.java + test/com/sun/javadoc/testTagOutput/pkg1/DeprecatedTag.java From vicente.romero at oracle.com Tue Oct 15 18:38:09 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 15 Oct 2013 18:38:09 +0000 Subject: hg: jdk8/tl/langtools: 8025816: javac crash with method reference with a type variable as the site Message-ID: <20131015183812.DACE9623FF@hg.openjdk.java.net> Changeset: 70a301b35e71 Author: vromero Date: 2013-10-15 19:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/70a301b35e71 8025816: javac crash with method reference with a type variable as the site Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/T8025816/CrashMethodReferenceWithSiteTypeVarTest.java From chris.hegarty at oracle.com Tue Oct 15 20:00:51 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 15 Oct 2013 20:00:51 +0000 Subject: hg: jdk8/tl: 3 new changesets Message-ID: <20131015200051.825F66240B@hg.openjdk.java.net> Changeset: af87dabb4263 Author: msheppar Date: 2013-06-14 15:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/af87dabb4263 8011157: Improve CORBA portablility Summary: fix also reviewed by Alexander Fomin Reviewed-by: alanb, coffeys, skoivu ! common/makefiles/RMICompilation.gmk Changeset: ce8c63017f11 Author: chegar Date: 2013-10-13 21:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ce8c63017f11 Merge Changeset: 28be3d174c92 Author: chegar Date: 2013-10-15 13:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/28be3d174c92 Merge From vicente.romero at oracle.com Tue Oct 15 20:04:14 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 15 Oct 2013 20:04:14 +0000 Subject: hg: jdk8/tl/langtools: 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears Message-ID: <20131015200431.BC4DF6240C@hg.openjdk.java.net> Changeset: d8d6b58f1ebf Author: vromero Date: 2013-10-15 21:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d8d6b58f1ebf 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/lambda/T8024947/PotentiallyAmbiguousWarningTest.java + test/tools/javac/lambda/T8024947/PotentiallyAmbiguousWarningTest.out From chris.hegarty at oracle.com Tue Oct 15 20:04:38 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 15 Oct 2013 20:04:38 +0000 Subject: hg: jdk8/tl/jaxp: 14 new changesets Message-ID: <20131015200522.8F7FD6240D@hg.openjdk.java.net> Changeset: ecb66dc473c1 Author: joehw Date: 2013-07-16 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ecb66dc473c1 8012425: Transform TransformerFactory Reviewed-by: alanb, dfuchs, mullan ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xerces/internal/parsers/AbstractSAXParser.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java Changeset: 7a2014318343 Author: joehw Date: 2013-07-17 09:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/7a2014318343 8017298: Better XML support Reviewed-by: alanb, dfuchs, mullan, lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/XMLScanner.java ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/xs/models/CMNodeFactory.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java ! src/com/sun/org/apache/xerces/internal/parsers/AbstractSAXParser.java ! src/com/sun/org/apache/xerces/internal/parsers/SecurityConfiguration.java - src/com/sun/org/apache/xerces/internal/util/SecurityManager.java ! src/com/sun/org/apache/xerces/internal/util/SymbolTable.java + src/com/sun/org/apache/xerces/internal/utils/XMLSecurityManager.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/xml/internal/stream/Entity.java Changeset: a59549c3ad60 Author: dfuchs Date: 2013-07-17 18:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a59549c3ad60 8013502: Improve stream factories Reviewed-by: joehw, mullan, lancea ! src/javax/xml/stream/FactoryFinder.java Changeset: 4b0b2b5c4cc8 Author: chegar Date: 2013-07-22 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/4b0b2b5c4cc8 Merge Changeset: 40b8abe19642 Author: chegar Date: 2013-07-29 14:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/40b8abe19642 Merge ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java Changeset: 720db2e27962 Author: joehw Date: 2013-07-31 00:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/720db2e27962 8014530: Better digital signature processing Reviewed-by: alanb, dfuchs, mullan, lancea ! src/com/sun/org/apache/xalan/internal/XalanConstants.java + src/com/sun/org/apache/xalan/internal/utils/XMLSecurityManager.java ! src/com/sun/org/apache/xalan/internal/utils/XMLSecurityPropertyManager.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Import.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Include.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java ! src/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java ! src/com/sun/org/apache/xerces/internal/impl/Constants.java ! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java ! src/com/sun/org/apache/xerces/internal/impl/XML11NSDocumentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDTDScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/com/sun/org/apache/xerces/internal/impl/XMLNSDocumentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLScanner.java ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/xs/models/CMNodeFactory.java ! src/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StAXValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java ! src/com/sun/org/apache/xerces/internal/parsers/SAXParser.java ! src/com/sun/org/apache/xerces/internal/parsers/SecurityConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java + src/com/sun/org/apache/xerces/internal/utils/XMLLimitAnalyzer.java ! src/com/sun/org/apache/xerces/internal/utils/XMLSecurityManager.java ! src/com/sun/org/apache/xerces/internal/utils/XMLSecurityPropertyManager.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java Changeset: cd9347628c7c Author: joehw Date: 2013-07-31 10:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/cd9347628c7c 8021366: java_util/Properties/PropertiesWithOtherEncodings fails during 7u45 nightly testing Reviewed-by: lancea, alanb, dfuchs, mullan ! src/com/sun/xml/internal/stream/Entity.java Changeset: ecbddaa85462 Author: chegar Date: 2013-08-02 11:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ecbddaa85462 Merge Changeset: c5e80c1fa32f Author: chegar Date: 2013-08-09 14:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c5e80c1fa32f Merge ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java Changeset: f952c33ebfdb Author: chegar Date: 2013-08-15 21:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f952c33ebfdb Merge Changeset: ce16a5aa1507 Author: joehw Date: 2013-08-20 09:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ce16a5aa1507 8022682: Supporting XOM Reviewed-by: alanb, chegar, lancea ! src/com/sun/org/apache/xerces/internal/impl/PropertyManager.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java ! src/com/sun/org/apache/xerces/internal/parsers/DOMParser.java ! src/com/sun/org/apache/xerces/internal/parsers/DTDConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/NonValidatingConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/SAXParser.java ! src/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java ! src/com/sun/org/apache/xerces/internal/parsers/XMLParser.java + src/com/sun/org/apache/xerces/internal/util/SecurityManager.java ! src/com/sun/org/apache/xerces/internal/utils/XMLLimitAnalyzer.java ! src/com/sun/org/apache/xerces/internal/utils/XMLSecurityManager.java Changeset: cc3b64366048 Author: chegar Date: 2013-08-23 22:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/cc3b64366048 Merge Changeset: 2b77e12ff69d Author: chegar Date: 2013-10-11 19:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/2b77e12ff69d Merge ! src/com/sun/org/apache/xerces/internal/parsers/DTDConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/NonValidatingConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/SAXParser.java ! src/com/sun/org/apache/xerces/internal/util/SecurityManager.java Changeset: 6f220761f643 Author: chegar Date: 2013-10-15 14:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6f220761f643 Merge From chris.hegarty at oracle.com Tue Oct 15 20:06:26 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 15 Oct 2013 20:06:26 +0000 Subject: hg: jdk8/tl/jaxws: 11 new changesets Message-ID: <20131015200656.D6AA46240E@hg.openjdk.java.net> Changeset: 43240b8b995b Author: mkos Date: 2013-08-01 16:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/43240b8b995b 8017505: Better Client Service Reviewed-by: mullan, ahgross, mgrebac ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/AbstractInstanceResolver.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/InstanceResolver.java + src/share/jaxws_classes/com/sun/xml/internal/ws/api/server/MethodUtil.java + src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/MethodUtil.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/SEIStub.java + src/share/jaxws_classes/com/sun/xml/internal/ws/policy/privateutil/MethodUtil.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/policy/privateutil/PolicyUtils.java Changeset: 358f32260d1f Author: chegar Date: 2013-08-02 11:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/358f32260d1f Merge Changeset: 5212665bea32 Author: chegar Date: 2013-08-09 14:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/5212665bea32 Merge Changeset: d9704ab517d5 Author: chegar Date: 2013-08-15 21:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d9704ab517d5 Merge Changeset: fca8869ccfd0 Author: chegar Date: 2013-08-23 22:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/fca8869ccfd0 Merge Changeset: a6e2adde013e Author: chegar Date: 2013-08-30 10:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/a6e2adde013e Merge Changeset: f6376ba97cea Author: chegar Date: 2013-09-06 09:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/f6376ba97cea Merge Changeset: d3a65e8912c9 Author: chegar Date: 2013-09-14 20:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d3a65e8912c9 Merge Changeset: da8141b6e344 Author: chegar Date: 2013-10-03 19:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/da8141b6e344 Merge Changeset: 2dc8ae7eb53b Author: chegar Date: 2013-10-11 19:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/2dc8ae7eb53b Merge Changeset: 01facfebe17b Author: chegar Date: 2013-10-15 13:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/01facfebe17b Merge From chris.hegarty at oracle.com Tue Oct 15 20:21:42 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 15 Oct 2013 20:21:42 +0000 Subject: hg: jdk8/tl/corba: 15 new changesets Message-ID: <20131015202154.91C4562411@hg.openjdk.java.net> Changeset: 81d694b1ab2f Author: msheppar Date: 2013-06-14 16:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/81d694b1ab2f 8011157: Improve CORBA portablility Summary: fix also reviewed by Alexander Fomin Reviewed-by: alanb, coffeys, skoivu ! src/share/classes/com/sun/corba/se/impl/transport/SelectorImpl.java ! src/share/classes/sun/rmi/rmic/iiop/StubGenerator.java Changeset: ab6eae733bce Author: chegar Date: 2013-07-15 11:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/ab6eae733bce Merge Changeset: e5ea72df9806 Author: chegar Date: 2013-07-22 13:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e5ea72df9806 Merge Changeset: be4fdc568d73 Author: mchung Date: 2013-07-22 19:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/be4fdc568d73 8017196: Ensure Proxies are handled appropriately Reviewed-by: dfuchs, jrose, jdn, ahgross, chegar ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/InvocationHandlerFactoryImpl.java ! src/share/classes/com/sun/corba/se/spi/orbutil/proxy/CompositeInvocationHandlerImpl.java Changeset: b0aeb77f0292 Author: chegar Date: 2013-07-25 17:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/b0aeb77f0292 Merge Changeset: a72f506e3058 Author: chegar Date: 2013-08-02 09:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a72f506e3058 Merge Changeset: 0717fc6f2960 Author: chegar Date: 2013-08-09 14:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0717fc6f2960 Merge Changeset: 6b5db99e194c Author: chegar Date: 2013-08-15 21:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/6b5db99e194c Merge - src/share/classes/com/sun/corba/se/impl/copyobject/JavaInputStream.sjava - src/share/classes/com/sun/corba/se/impl/copyobject/JavaOutputStream.sjava - src/share/classes/com/sun/corba/se/impl/interceptors/ThreadCurrentStack.sjava - src/share/classes/com/sun/corba/se/impl/orbutil/DefineWrapper.sjava - src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLNameTranslatorImpl_save.sjava - src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLTypesUtil_save.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalClientRequestImpl.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalClientResponseImpl.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalServerRequestImpl.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalServerResponseImpl.sjava - src/share/classes/com/sun/corba/se/impl/transport/BufferConnectionImpl.sjava Changeset: 9c75c61d97f8 Author: msheppar Date: 2013-08-19 15:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/9c75c61d97f8 8022940: Enhance CORBA translations Reviewed-by: coffeys, alanb, skoivu ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLNameTranslatorImpl.java Changeset: 2caa37dfd7cd Author: chegar Date: 2013-08-23 22:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/2caa37dfd7cd Merge Changeset: a5788ab042dc Author: chegar Date: 2013-08-30 09:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a5788ab042dc Merge Changeset: 118a211bb3ba Author: chegar Date: 2013-09-06 09:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/118a211bb3ba Merge Changeset: cc52d582df09 Author: chegar Date: 2013-09-14 19:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/cc52d582df09 Merge Changeset: 396854c032bb Author: chegar Date: 2013-10-03 19:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/396854c032bb Merge Changeset: 47513cdce4ed Author: chegar Date: 2013-10-13 22:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/47513cdce4ed Merge From jan.lahoda at oracle.com Tue Oct 15 20:22:53 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Tue, 15 Oct 2013 20:22:53 +0000 Subject: hg: jdk8/tl/langtools: 8026510: The name of com.sun.tools.javac.comp.Annotate.Annotator is confusing Message-ID: <20131015202256.D890D62412@hg.openjdk.java.net> Changeset: 19e8eebfbe52 Author: jlahoda Date: 2013-10-15 22:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/19e8eebfbe52 8026510: The name of com.sun.tools.javac.comp.Annotate.Annotator is confusing Summary: A mostly automated rename Annotate.Annotator->Annotate.Worker and enterAnnotation->run. Reviewed-by: emc, jjg ! src/share/classes/com/sun/tools/javac/code/SymbolMetadata.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java From chris.hegarty at oracle.com Tue Oct 15 20:23:36 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 15 Oct 2013 20:23:36 +0000 Subject: hg: jdk8/tl/hotspot: 13 new changesets Message-ID: <20131015202413.3BED862413@hg.openjdk.java.net> Changeset: 5c599c419c1d Author: hseigel Date: 2013-07-11 12:59 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5c599c419c1d 8016256: Make finalization final Summary: Add private methods to final methods check Reviewed-by: coleenp, acorn, ahgross Contributed-by: harold.seigel at oracle.com ! src/share/vm/classfile/classFileParser.cpp Changeset: d840f02d03b4 Author: chegar Date: 2013-07-15 11:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d840f02d03b4 Merge - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp Changeset: 7ec210434b3c Author: chegar Date: 2013-07-22 14:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7ec210434b3c Merge - src/share/vm/memory/klassInfoClosure.hpp - src/share/vm/runtime/aprofiler.cpp - src/share/vm/runtime/aprofiler.hpp Changeset: ca9029490fce Author: chegar Date: 2013-07-25 17:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ca9029490fce Merge Changeset: 8f66130f7b5c Author: chegar Date: 2013-08-02 11:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8f66130f7b5c Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: 38f9393d1847 Author: sgabdura Date: 2013-08-09 11:03 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/38f9393d1847 8020789: Disable exporting of gc.heap_dump diagnostic command Reviewed-by: fparain, ahgross ! src/share/vm/services/diagnosticCommand.cpp Changeset: ee7a7aa7c6bb Author: chegar Date: 2013-08-09 14:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ee7a7aa7c6bb Merge Changeset: 8f3c59225a5c Author: chegar Date: 2013-08-15 21:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8f3c59225a5c Merge - test/runtime/7196045/Test7196045.java - test/runtime/8000968/Test8000968.sh Changeset: 7638e35cabc6 Author: erikj Date: 2013-08-19 17:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7638e35cabc6 8015614: Update build settings Reviewed-by: tbell, dholmes, ahgross ! make/windows/makefiles/compile.make ! make/windows/makefiles/sa.make Changeset: d4fa23d6c35b Author: chegar Date: 2013-08-23 22:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d4fa23d6c35b Merge - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 07b5f47d7a18 Author: chegar Date: 2013-08-30 09:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/07b5f47d7a18 Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: 98a2169ed7ac Author: iklam Date: 2013-08-24 00:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/98a2169ed7ac 8023683: Enhance class file parsing Summary: Use the value returned by REALLOC_RESOURCE_ARRAY() Reviewed-by: coleenp, ahgross ! src/share/vm/classfile/classFileParser.cpp Changeset: 8321dcc18438 Author: chegar Date: 2013-10-13 21:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8321dcc18438 Merge ! src/share/vm/classfile/classFileParser.cpp From chris.hegarty at oracle.com Tue Oct 15 20:08:27 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 15 Oct 2013 20:08:27 +0000 Subject: hg: jdk8/tl/jdk: 61 new changesets Message-ID: <20131015202435.B8C2D62414@hg.openjdk.java.net> Changeset: b3baca585b7f Author: jbachorik Date: 2013-04-23 09:37 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3baca585b7f 8011081: Improve jhat Summary: Properly escape HTML output Reviewed-by: alanb, mschoene, sundar ! src/share/classes/com/sun/tools/hat/internal/server/AllClassesQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/ClassQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/HttpReader.java ! src/share/classes/com/sun/tools/hat/internal/server/InstancesCountQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/OQLHelp.java ! src/share/classes/com/sun/tools/hat/internal/server/OQLQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/QueryHandler.java ! src/share/classes/com/sun/tools/hat/internal/server/RefsByTypeQuery.java Changeset: 37f6f4dbfc6d Author: ksrini Date: 2013-05-07 13:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37f6f4dbfc6d 8013506: Better Pack200 data handling Reviewed-by: jrose, kizune, mschoene ! src/share/native/com/sun/java/util/jar/pack/zip.cpp Changeset: 139a01719eec Author: jchen Date: 2013-05-09 09:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/139a01719eec 8013510: Augment image writing code Reviewed-by: bae, prr ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageWriter.java ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c Changeset: f2068f4244a5 Author: bae Date: 2013-05-14 12:51 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2068f4244a5 8014093: Improve parsing of images Reviewed-by: prr, jgodinez ! src/share/native/sun/awt/image/awt_parseImage.c ! src/share/native/sun/awt/image/awt_parseImage.h ! src/share/native/sun/awt/medialib/awt_ImagingLib.c Changeset: 65d5a6e53d12 Author: alexsch Date: 2013-05-20 14:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/65d5a6e53d12 8013744: Better tabling for AWT Reviewed-by: art, malenkov, skoivu ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/UIDefaults.java ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/NumberFormatter.java ! src/share/classes/sun/swing/SwingLazyValue.java ! src/share/classes/sun/swing/SwingUtilities2.java Changeset: 52be85d5149b Author: bae Date: 2013-05-20 15:26 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/52be85d5149b 8014102: Improve image conversion Reviewed-by: mschoene, prr, jgodinez ! src/share/native/sun/awt/medialib/awt_ImagingLib.c Changeset: 08b88f831dd1 Author: malenkov Date: 2013-05-20 19:49 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/08b88f831dd1 8012071: Better Building of Beans Reviewed-by: art, skoivu ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/MetaData.java Changeset: 140c474ab8b9 Author: malenkov Date: 2013-05-31 21:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/140c474ab8b9 8012277: Improve AWT DataFlavor Reviewed-by: art, skoivu ! src/share/classes/java/awt/datatransfer/DataFlavor.java Changeset: 23fe888b698d Author: weijun Date: 2013-05-08 09:21 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23fe888b698d 8014341: Better service from Kerberos servers Summary: read incoming data safely and take care of null return value Reviewed-by: valeriep, ahgross ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/security/krb5/internal/NetClient.java Changeset: 532343ec60b7 Author: weijun Date: 2013-06-13 10:21 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/532343ec60b7 8013739: Better LDAP resource management Reviewed-by: ahgross, mchung, xuelei ! src/share/classes/com/sun/jndi/ldap/VersionHelper12.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/sun/misc/JavaLangAccess.java Changeset: 6d9ec6877a7f Author: weijun Date: 2013-06-13 10:31 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d9ec6877a7f 8015731: Subject java.security.auth.subject to improvements Reviewed-by: skoivu, mullan ! src/share/classes/javax/security/auth/Subject.java Changeset: ccca37ca416a Author: jchen Date: 2013-06-13 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ccca37ca416a 8014098: Better profile validation Reviewed-by: bae, mschoene, prr ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c Changeset: 5a14ecd30b4e Author: msheppar Date: 2013-06-14 15:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5a14ecd30b4e 8011157: Improve CORBA portablility Summary: fix also reviewed by Alexander Fomin Reviewed-by: alanb, coffeys, skoivu ! make/com/sun/jmx/Makefile ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java Changeset: 7addece3f21e Author: jbachorik Date: 2013-06-20 08:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7addece3f21e 8014085: Better serialization support in JMX classes Reviewed-by: alanb, dfuchs, skoivu ! src/share/classes/javax/management/MBeanNotificationInfo.java ! src/share/classes/javax/management/remote/JMXPrincipal.java ! src/share/classes/javax/management/remote/JMXServiceURL.java ! src/share/classes/javax/management/remote/NotificationResult.java ! src/share/classes/javax/management/remote/TargetedNotification.java Changeset: eb29deb3c1db Author: chegar Date: 2013-06-27 10:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb29deb3c1db Merge Changeset: 0a06ec55aacd Author: bae Date: 2013-07-01 15:17 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a06ec55aacd 8017287: Better resource disposal Reviewed-by: prr, vadim, skoivu ! src/share/classes/sun/java2d/Disposer.java Changeset: 51204df822d3 Author: erikj Date: 2013-07-03 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51204df822d3 8012146: Improve tool support Reviewed-by: ksrini, dholmes, alanb, anthony ! makefiles/CompileLaunchers.gmk ! makefiles/Images.gmk ! test/Makefile Changeset: 888fd0ad7e1e Author: ascarpino Date: 2013-07-03 15:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/888fd0ad7e1e 8011071: Better crypto provider handling Reviewed-by: hawtin, valeriep ! src/share/classes/com/sun/crypto/provider/DHPrivateKey.java ! src/share/classes/sun/security/ec/ECPrivateKeyImpl.java ! src/share/classes/sun/security/jgss/GSSCredentialImpl.java ! src/share/classes/sun/security/pkcs/PKCS8Key.java ! src/share/classes/sun/security/pkcs11/P11Key.java ! src/share/classes/sun/security/provider/DSAPrivateKey.java ! src/share/classes/sun/security/rsa/RSAPrivateCrtKeyImpl.java ! src/share/classes/sun/security/rsa/RSAPrivateKeyImpl.java Changeset: a06b764cc2d0 Author: dsamersoff Date: 2013-07-08 16:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a06b764cc2d0 8008589: Better MBean permission validation Summary: Better MBean permission validation Reviewed-by: skoivu, dfuchs, mchung, sjiang ! src/share/classes/javax/management/MBeanTrustPermission.java Changeset: 9c6de162771c Author: smarks Date: 2013-07-11 13:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c6de162771c 8014987: Augment serialization handling Reviewed-by: alanb, coffeys, skoivu ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/ObjectOutputStream.java Changeset: c40752886882 Author: jfranck Date: 2013-07-15 14:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c40752886882 8014349: (cl) Class.getDeclaredClass problematic in some class loader configurations Reviewed-by: mchung, ahgross, darcy ! src/share/classes/java/lang/Class.java ! src/share/native/java/lang/Class.c Changeset: 48548e40187a Author: mchung Date: 2013-07-15 20:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48548e40187a 8017291: Cast Proxies Aside Reviewed-by: alanb, ahgross ! src/share/classes/java/lang/ClassLoader.java Changeset: 047c99b53994 Author: chegar Date: 2013-07-15 18:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/047c99b53994 Merge ! src/share/classes/java/lang/Thread.java - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/swing/SwingUtilities2.java - test/java/util/Comparators/BasicTest.java Changeset: 3062c96e79e0 Author: chegar Date: 2013-07-16 12:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3062c96e79e0 Merge Changeset: e1497f102a8a Author: malenkov Date: 2013-07-16 21:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e1497f102a8a 8019617: Better view of objects Reviewed-by: art, skoivu ! src/share/classes/javax/swing/text/html/ObjectView.java Changeset: 69a2dc92fefe Author: michaelm Date: 2013-07-18 18:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69a2dc92fefe 8015743: Address internet addresses Reviewed-by: alanb, khazra, skoivu ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/InetAddress.java ! src/share/native/java/net/Inet6Address.c ! src/share/native/java/net/net_util.c ! src/share/native/java/net/net_util.h ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/net_util_md.c ! src/windows/native/java/net/Inet6AddressImpl.c ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface_winXP.c ! src/windows/native/java/net/TwoStacksPlainSocketImpl.c ! src/windows/native/java/net/net_util_md.c ! test/java/net/Inet6Address/serialize/Serialize.java Changeset: 5d8f1e697cd8 Author: okutsu Date: 2013-07-19 12:14 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d8f1e697cd8 8001029: Add new date/time capability Reviewed-by: mchung, hawtin ! src/share/classes/java/util/TimeZone.java + test/java/util/TimeZone/SetDefaultSecurityTest.java Changeset: fe90bd20865b Author: sjiang Date: 2013-07-19 13:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe90bd20865b 8014534: Better profiling support Summary: Validation of parameters Reviewed-by: sspitsyn, skoivu, mchung ! src/share/classes/com/sun/demo/jvmti/hprof/Tracker.java ! src/share/demo/jvmti/hprof/hprof_class.c ! src/share/demo/jvmti/hprof/hprof_event.c Changeset: 0a51ccf778b3 Author: chegar Date: 2013-07-22 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a51ccf778b3 Merge Changeset: 3725e8a70ae9 Author: mchung Date: 2013-07-22 19:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3725e8a70ae9 8017196: Ensure Proxies are handled appropriately Reviewed-by: dfuchs, jrose, jdn, ahgross, chegar ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java Changeset: 5bde952bf23c Author: sgabdura Date: 2013-07-23 09:30 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bde952bf23c 8016357: Update hotspot diagnostic class Summary: Add security check to HotSpotDiagnostic.dumpHeap Reviewed-by: fparain, sla, ahgross ! make/java/management/mapfile-vers ! makefiles/mapfiles/libmanagement/mapfile-vers ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/sun/management/HotSpotDiagnostic.java ! src/share/native/sun/management/HotSpotDiagnostic.c Changeset: 5bdc55e87cae Author: weijun Date: 2013-07-17 18:46 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bdc55e87cae 8020696: Merge problem for KdcComm.java Reviewed-by: chegar ! src/share/classes/sun/security/krb5/KdcComm.java Changeset: 490c67c5d9a2 Author: jchen Date: 2013-07-24 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/490c67c5d9a2 8020293: JVM crash Reviewed-by: prr, jgodinez ! src/share/classes/sun/font/GlyphLayout.java ! src/share/native/sun/font/layout/SunLayoutEngine.cpp Changeset: bcce47d9d8da Author: jbachorik Date: 2013-07-19 16:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcce47d9d8da 8019584: javax/management/remote/mandatory/loading/MissingClassTest.java failed in nightly against jdk7u45: java.io.InvalidObjectException: Invalid notification: null Reviewed-by: mchung, sjiang, dfuchs, ahgross ! src/share/classes/javax/management/remote/NotificationResult.java ! src/share/classes/javax/management/remote/TargetedNotification.java ! test/javax/management/remote/mandatory/loading/MissingClassTest.java Changeset: d7a0bbf526f8 Author: jbachorik Date: 2013-07-29 04:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d7a0bbf526f8 8021577: JCK test api/javax_management/jmx_serial/modelmbean/ModelMBeanNotificationInfo/serial/index.html#Input has failed since jdk 7u45 b01 Reviewed-by: alanb, dfuchs, ahgross ! src/share/classes/javax/management/MBeanNotificationInfo.java Changeset: 1a1e42c8e988 Author: chegar Date: 2013-07-25 19:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1a1e42c8e988 Merge ! src/share/classes/com/sun/crypto/provider/DHPrivateKey.java - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/InetAddress.java - src/share/classes/java/util/stream/StreamBuilder.java ! src/share/classes/javax/security/auth/Subject.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/security/pkcs11/P11Key.java - test/java/util/Collections/EmptySortedSet.java Changeset: 446bc20447a1 Author: chegar Date: 2013-07-29 14:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/446bc20447a1 Merge Changeset: e537b7f5f39b Author: naoto Date: 2013-08-01 14:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e537b7f5f39b 8021286: Improve MacOS resourcing Reviewed-by: okutsu - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk ! make/sun/awt/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m Changeset: 44a063555ccd Author: chegar Date: 2013-08-02 11:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44a063555ccd Merge Changeset: 17e1675e3d1e Author: serb Date: 2013-08-04 02:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17e1675e3d1e 8021282: Better recycling of object instances Reviewed-by: art ! src/macosx/classes/com/apple/laf/AquaUtils.java Changeset: ba7566de89c6 Author: sjiang Date: 2013-08-06 10:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ba7566de89c6 8019292: Better Attribute Value Exceptions Reviewed-by: dfuchs, dholmes, ahgross ! src/share/classes/javax/management/BadAttributeValueExpException.java Changeset: 23476862c55b Author: malenkov Date: 2013-08-07 14:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23476862c55b 8021969: The index_AccessAllowed jnlp can not load successfully with exception thrown in the log. Reviewed-by: art, skoivu ! src/share/classes/java/awt/datatransfer/DataFlavor.java Changeset: db9539b0061d Author: jbachorik Date: 2013-08-08 19:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db9539b0061d 8021360: object not exported" on start of JMXConnectorServer for RMI-IIOP protocol with security manager Reviewed-by: alanb, ahgross, smarks, coffeys ! src/share/classes/com/sun/jmx/remote/protocol/iiop/IIOPProxyImpl.java Changeset: 077d8c2cc5f6 Author: chegar Date: 2013-08-09 14:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/077d8c2cc5f6 Merge ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/InetAddress.java - src/share/classes/java/net/package.html ! src/share/classes/java/util/TimeZone.java ! src/share/native/java/net/net_util.c ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/awt/medialib/awt_ImagingLib.c ! test/Makefile Changeset: e82ddcc1b2fb Author: serb Date: 2013-08-12 19:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e82ddcc1b2fb 8021275: Better screening for ScreenMenu Reviewed-by: art ! src/macosx/classes/com/apple/laf/ScreenMenu.java Changeset: 3e3cbd93f4f1 Author: twisti Date: 2013-08-12 13:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e3cbd93f4f1 8022066: Evaluation of method reference to signature polymorphic method crashes VM Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MethodHandles.java + test/java/lang/invoke/MethodHandleConstants.java Changeset: e173b8786362 Author: ksrini Date: 2013-08-14 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e173b8786362 8021355: REGRESSION: Five closed/java/awt/SplashScreen tests fail since 7u45 b01 on Linux, Solaris Reviewed-by: dholmes, anthony, ahgross, erikj ! src/solaris/bin/java_md_solinux.c Changeset: 31010ca3da3e Author: chegar Date: 2013-08-15 21:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31010ca3da3e Merge ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java - test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java - test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh Changeset: 3f85c96eafcc Author: weijun Date: 2013-08-14 15:25 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f85c96eafcc 8022931: Enhance Kerberos exceptions Reviewed-by: xuelei, ahgross ! src/share/classes/javax/security/auth/kerberos/KeyTab.java Changeset: 50bdb9577b27 Author: erikj Date: 2013-08-19 12:30 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50bdb9577b27 8022719: tools/launcher/RunpathTest.java fails after 8012146 Reviewed-by: chegar ! test/tools/launcher/RunpathTest.java Changeset: 0f279113c95a Author: erikj Date: 2013-08-19 14:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f279113c95a 8023231: Remove comma from jtreg bug line Reviewed-by: alanb, chegar ! test/tools/launcher/RunpathTest.java Changeset: ad35b4b6ce8e Author: chegar Date: 2013-08-23 12:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ad35b4b6ce8e Merge Changeset: 29f73bc50bd4 Author: chegar Date: 2013-08-30 09:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/29f73bc50bd4 Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk - src/share/classes/com/sun/security/auth/PolicyParser.java - src/share/classes/com/sun/security/auth/SubjectCodeSource.java ! src/share/classes/java/net/InetAddress.java - src/share/classes/java/util/jar/UnsupportedProfileException.java - src/share/classes/sun/security/provider/ConfigSpiFile.java ! src/solaris/native/java/net/NetworkInterface.c - test/java/net/URLClassLoader/profiles/Basic.java - test/java/net/URLClassLoader/profiles/Lib.java - test/java/net/URLClassLoader/profiles/basic.sh - test/tools/jar/AddAndUpdateProfile.java - test/tools/launcher/profiles/Basic.java - test/tools/launcher/profiles/Logging.java - test/tools/launcher/profiles/Main.java - test/tools/launcher/profiles/VersionCheck.java Changeset: a8593bc7c29d Author: chegar Date: 2013-09-06 09:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8593bc7c29d Merge ! src/share/classes/java/lang/Class.java - src/share/classes/sun/misc/Compare.java - src/share/classes/sun/misc/Sort.java Changeset: 22ea25e71b4c Author: chegar Date: 2013-09-14 19:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/22ea25e71b4c Merge Changeset: 240072825ada Author: chegar Date: 2013-10-03 19:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/240072825ada Merge ! make/sun/awt/Makefile ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/Images.gmk - src/macosx/classes/sun/lwawt/SelectionClearListener.java - src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java ! src/share/classes/java/awt/datatransfer/DataFlavor.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/invoke/MethodHandles.java - src/share/classes/java/util/stream/CloseableStream.java - src/share/classes/java/util/stream/DelegatingStream.java ! src/share/classes/javax/management/MBeanNotificationInfo.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/security/auth/Subject.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/UIDefaults.java ! src/share/classes/sun/swing/SwingUtilities2.java ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/font/layout/SunLayoutEngine.cpp ! src/solaris/bin/java_md_solinux.c ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface_winXP.c - test/com/sun/jdi/Solaris32AndSolaris64Test.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-i586/libLauncher.so - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-sparc/libLauncher.so - test/java/util/Collection/ListDefaults.java - test/java/util/Map/CheckRandomHashSeed.java - test/java/util/Map/TreeBinSplitBackToEntries.java - test/java/util/concurrent/ConcurrentHashMap/toArray.java - test/java/util/regex/PatternTest.java - test/sun/tools/jconsole/ImmutableResourceTest.java - test/sun/tools/jconsole/ImmutableResourceTest.sh ! test/tools/launcher/RunpathTest.java Changeset: adbf6d61c820 Author: chegar Date: 2013-10-07 11:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/adbf6d61c820 8025991: tools/launcher/RunpathTest.java fails Reviewed-by: erikj ! test/tools/launcher/RunpathTest.java Changeset: 99832c718cb8 Author: chegar Date: 2013-10-15 09:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/99832c718cb8 Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/solaris/native/java/net/Inet6AddressImpl.c Changeset: 3dbfab65c17e Author: chegar Date: 2013-10-15 13:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3dbfab65c17e Merge ! src/share/classes/java/awt/datatransfer/DataFlavor.java ! src/share/classes/java/lang/ClassLoader.java - src/share/classes/java/net/HttpURLPermission.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/UIDefaults.java ! src/share/classes/javax/swing/text/DefaultFormatter.java ! src/share/classes/javax/swing/text/NumberFormatter.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: 27ac58b9a62a Author: chegar Date: 2013-10-15 20:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27ac58b9a62a 8026513: ProblemList.txt Updates (10/2013) Reviewed-by: alanb ! test/ProblemList.txt Changeset: 78ffa90c77b2 Author: chegar Date: 2013-10-15 20:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78ffa90c77b2 Merge From chris.hegarty at oracle.com Tue Oct 15 20:15:40 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 15 Oct 2013 20:15:40 +0000 Subject: hg: jdk8/tl/langtools: 14 new changesets Message-ID: <20131015201701.A023D6240F@hg.openjdk.java.net> Changeset: 84df20dc604a Author: bpatel Date: 2013-07-24 15:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84df20dc604a 8016675: Make Javadoc pages more robust Reviewed-by: jlaskey, ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java + test/com/sun/javadoc/testWindowTitle/TestWindowTitle.java + test/com/sun/javadoc/testWindowTitle/p1/C1.java + test/com/sun/javadoc/testWindowTitle/p2/C2.java Changeset: 8b3e2cc5f1de Author: chegar Date: 2013-07-25 19:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8b3e2cc5f1de Merge - test/tools/javac/generics/6723444/T6723444.out - test/tools/javac/generics/7015430/T7015430.out Changeset: 0d75d3b96477 Author: chegar Date: 2013-08-02 11:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0d75d3b96477 Merge Changeset: 2d1a54d213c2 Author: chegar Date: 2013-08-09 14:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2d1a54d213c2 Merge Changeset: 84b6d75ff2c9 Author: chegar Date: 2013-08-15 21:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84b6d75ff2c9 Merge Changeset: a540e2a926cf Author: chegar Date: 2013-08-23 22:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a540e2a926cf Merge Changeset: a8f0c3583a86 Author: chegar Date: 2013-08-30 10:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a8f0c3583a86 Merge - test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java Changeset: 6250a7f0aba6 Author: chegar Date: 2013-09-06 10:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6250a7f0aba6 Merge - test/com/sun/javadoc/testNavagation/TestNavagation.java - test/com/sun/javadoc/testNavagation/pkg/A.java - test/com/sun/javadoc/testNavagation/pkg/C.java - test/com/sun/javadoc/testNavagation/pkg/E.java - test/com/sun/javadoc/testNavagation/pkg/I.java - test/tools/javac/8015701/AnonymousParameters.java Changeset: a6901af8a2e4 Author: chegar Date: 2013-09-14 20:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a6901af8a2e4 Merge Changeset: 2c13a5da6854 Author: chegar Date: 2013-10-03 19:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2c13a5da6854 Merge ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java - src/share/classes/com/sun/tools/javac/code/Annotations.java - test/tools/javac/diags/examples/CyclicInference.java - test/tools/javac/diags/examples/MrefStat.java.rej - test/tools/javac/diags/examples/MrefStat1.java.rej - test/tools/javac/lambda/TargetType10.out - test/tools/javac/lambda/typeInference/InferenceTest5.java - test/tools/javac/lambda/typeInference/InferenceTest_neg5.java - test/tools/javac/lambda/typeInference/InferenceTest_neg5.out Changeset: 86e57f576e65 Author: chegar Date: 2013-10-11 19:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/86e57f576e65 Merge ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java Changeset: 46feacb99698 Author: chegar Date: 2013-10-15 14:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/46feacb99698 Merge - src/share/classes/com/sun/javadoc/package.html - src/share/classes/com/sun/tools/classfile/package.html - src/share/classes/com/sun/tools/doclets/formats/html/markup/package.html - src/share/classes/com/sun/tools/doclets/formats/html/package.html - src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/package.html - src/share/classes/com/sun/tools/doclets/internal/toolkit/package.html - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/package.html - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/package.html - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/package.html - src/share/classes/com/sun/tools/doclets/package.html - src/share/classes/com/sun/tools/javap/package.html Changeset: 90c9ae4bc756 Author: chegar Date: 2013-10-15 20:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/90c9ae4bc756 Merge Changeset: dd073728085d Author: chegar Date: 2013-10-15 21:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dd073728085d Merge From jonathan.gibbons at oracle.com Tue Oct 15 22:58:43 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 15 Oct 2013 22:58:43 +0000 Subject: hg: jdk8/tl/langtools: 8026564: import changes from type-annotations forest Message-ID: <20131015225846.A7F786242A@hg.openjdk.java.net> Changeset: b0c086cd4520 Author: jjg Date: 2013-10-15 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0c086cd4520 8026564: import changes from type-annotations forest Reviewed-by: jjg Contributed-by: wdietl at gmail.com, steve.sides at oracle.com ! make/build.properties ! make/build.xml ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/SymbolMetadata.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/javax/lang/model/AnnotatedConstruct.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java ! test/tools/javac/T7042623.java ! test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java + test/tools/javac/annotations/typeAnnotations/classfile/Scopes.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.out ! test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage2.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.java ! test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.out ! test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion7.out ! test/tools/javac/annotations/typeAnnotations/failures/BadCast.java ! test/tools/javac/annotations/typeAnnotations/failures/BadCast.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotatePackages.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotatePackages.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateScoping.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateScoping.out ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java - test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass2.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass2.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass3.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass3.out ! test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.java ! test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.out - test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.java - test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.out ! test/tools/javac/annotations/typeAnnotations/failures/IndexArray.java ! test/tools/javac/annotations/typeAnnotations/failures/IndexArray.out ! test/tools/javac/annotations/typeAnnotations/failures/LintCast.out ! test/tools/javac/annotations/typeAnnotations/failures/OldArray.java + test/tools/javac/annotations/typeAnnotations/failures/OldArray.out ! test/tools/javac/annotations/typeAnnotations/failures/Scopes.java ! test/tools/javac/annotations/typeAnnotations/failures/Scopes.out ! test/tools/javac/annotations/typeAnnotations/failures/StaticFields.java ! test/tools/javac/annotations/typeAnnotations/failures/StaticFields.out - test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.java - test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.out ! test/tools/javac/annotations/typeAnnotations/failures/TypeVariableCycleTest.java + test/tools/javac/annotations/typeAnnotations/failures/TypeVariableMissingTA.java + test/tools/javac/annotations/typeAnnotations/failures/TypeVariableMissingTA.out - test/tools/javac/diags/examples/CantAnnotateNestedType.java + test/tools/javac/diags/examples/CantAnnotateScoping.java + test/tools/javac/diags/examples/CantAnnotateScoping1.java - test/tools/javac/diags/examples/CantAnnotateStaticClass.java ! test/tools/javac/lib/DPrinter.java ! test/tools/javac/processing/model/type/BasicAnnoTests.java From brian.burkhalter at oracle.com Tue Oct 15 23:47:39 2013 From: brian.burkhalter at oracle.com (brian.burkhalter at oracle.com) Date: Tue, 15 Oct 2013 23:47:39 +0000 Subject: hg: jdk8/tl/jdk: 8010371: getaddrinfo can fail with EAI_SYSTEM/EAGAIN, causes UnknownHostException to be thrown Message-ID: <20131015234802.A3DAB6242E@hg.openjdk.java.net> Changeset: 3676f04e6553 Author: bpb Date: 2013-10-15 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3676f04e6553 8010371: getaddrinfo can fail with EAI_SYSTEM/EAGAIN, causes UnknownHostException to be thrown Summary: Modify UHE exception message for EAI_AGAIN failures. Reviewed-by: alanb, chegar, michaelm, dsamersoff Contributed-by: Brian Burkhalter ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/windows/native/java/net/Inet4AddressImpl.c ! src/windows/native/java/net/Inet6AddressImpl.c From david.holmes at oracle.com Wed Oct 16 00:54:53 2013 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 16 Oct 2013 00:54:53 +0000 Subject: hg: jdk8/tl/jdk: 8026378: TEST_BUG: Clean up TEST.groups Message-ID: <20131016005509.13F4162431@hg.openjdk.java.net> Changeset: e33aea66caa3 Author: dholmes Date: 2013-10-15 20:54 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e33aea66caa3 8026378: TEST_BUG: Clean up TEST.groups Reviewed-by: mduigou, mchung, alanb ! test/TEST.groups From jason.uh at oracle.com Wed Oct 16 02:19:16 2013 From: jason.uh at oracle.com (Jason Uh) Date: Tue, 15 Oct 2013 19:19:16 -0700 Subject: [8] Request for Review: 8026052: cannot find symbol Proc In-Reply-To: <525604E7.9040601@oracle.com> References: <5255FB55.10307@oracle.com> <525604E7.9040601@oracle.com> Message-ID: <525DF7A4.8030604@oracle.com> Confirmed that the trailing slash actually shouldn't make a difference. The problem ended up being the result of the reporter having an incomplete test environment, so I'll withdraw this request. Thanks, Jason On 10/9/13 6:37 PM, Weijun Wang wrote: > This looks harmless. But it looks more like a jtreg issue if it cannot > deal with that slash. > > I haven't noticed it failing on Windows before. Can you point me to a > jtr file. > > Thanks > Max > > On 10/10/13 8:56 AM, Jason Uh wrote: >> Please review this fix. This changeset removes trailing slashes at the >> end of the test library paths in the jtreg @library tag, which can cause >> the tests to fail on Windows. >> >> webrev: http://cr.openjdk.java.net/~juh/8026052/webrev.00/ >> >> Thanks, >> Jason From bernd-2013 at eckenfels.net Wed Oct 16 03:01:05 2013 From: bernd-2013 at eckenfels.net (Bernd Eckenfels) Date: Wed, 16 Oct 2013 05:01:05 +0200 Subject: JNLP with unsigend resources is no longer loaded with SunJDK 7U45 Message-ID: Hello, sadly I noticed another regression with the Oracle JDK 7U45: it will refuse to load an JNLP Application if the JAR files contain unsigned resources. I must admit I dont know what we have those in the JAR files and I will remove them (META-INF/maven/* stuff mostly) but I wonder why this was not announced. Even when I reduce the security slider as far as possible I am never asked if it is ok and I want to proceed. I know it is not the best list to discuss this here, but since I wanted to write something about the new code base properties anyway, I thought I might begin with complain :) Gruss Bernd java.lang.SecurityException: com.sun.deploy.net.JARSigningException: Unsignierter Eintrag gefunden in Ressource: http://localhost:10000/s....jar at com.sun.deploy.cache.CacheEntry.getJarFile(Unknown Source) at com.sun.javaws.security.SigningInfo.check(Unknown Source) at com.sun.javaws.security.JNLPSignedResourcesHelper.checkSignedResourcesHelper(Unknown Source) at com.sun.javaws.security.JNLPSignedResourcesHelper.checkSignedResources(Unknown Source) at com.sun.javaws.Launcher.prepareResources(Unknown Source) at com.sun.javaws.Launcher.prepareAllResources(Unknown Source) at com.sun.javaws.Launcher.prepareToLaunch(Unknown Source) at com.sun.javaws.Launcher.prepareToLaunch(Unknown Source) at com.sun.javaws.Launcher.launch(Unknown Source) at com.sun.javaws.Main.launchApp(Unknown Source) at com.sun.javaws.Main.continueInSecureThread(Unknown Source) at com.sun.javaws.Main.access$000(Unknown Source) at com.sun.javaws.Main$1.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: com.sun.deploy.net.JARSigningException: Unsignierter Eintrag gefunden in Ressource: http://localhost:10000/seeburger/app/com.seeburger.gui-framework.gui-framework.jar ... 14 more .. ... jnlp file truncated after 10K From weijun.wang at oracle.com Wed Oct 16 06:40:36 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 16 Oct 2013 06:40:36 +0000 Subject: hg: jdk8/tl/jdk: 8025124: InitialToken.useNullKey incorrectly applies NULL_KEY in some cases Message-ID: <20131016064144.9D15162446@hg.openjdk.java.net> Changeset: a70aab9b373e Author: weijun Date: 2013-10-16 14:39 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a70aab9b373e 8025124: InitialToken.useNullKey incorrectly applies NULL_KEY in some cases Reviewed-by: xuelei ! src/share/classes/sun/security/jgss/krb5/InitialToken.java ! src/share/classes/sun/security/krb5/KrbCred.java From weijun.wang at oracle.com Wed Oct 16 06:50:21 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 16 Oct 2013 14:50:21 +0800 Subject: Request for review: 8025124: InitialToken.useNullKey incorrectly applies NULL_KEY in some cases In-Reply-To: <525BEC38.40407@oracle.com> References: <52591654.8040209@oracle.com> <525BEC38.40407@oracle.com> Message-ID: <525E372D.1040707@oracle.com> Thanks. FYI: I pushed the changeset which only contains the src part. The test does not work universally now. On Mac, the krb5 impl is Heimdal and has a very different configuration. On Solaris, there is a problem calling gss_inquire_cred on GSS_C_NULL_OID. Noreg-hard added. We are allowed to add test after ZBB. Of course, only if I can get the regression test running fine. Thanks Max On 10/14/13 9:06 PM, Xuelei Fan wrote: > Looks fine to me. > > Xuelei > > On 10/12/2013 5:28 PM, Weijun Wang wrote: >> Please review the fix at >> >> http://cr.openjdk.java.net/~weijun/8025124/webrev.00/ >> >> This is an interop fix. We used to determine if a NULL key should be >> used based on etype being new or old, now we just look at the etype >> inside the EncryptedData. If it's 0 then there is no need to decrypt it. >> Note that this is not a security issue because the whole KRB-CRED is >> encrypted anyway. >> >> A new regression test added. >> >> Thanks >> Max > From sundararajan.athijegannathan at oracle.com Wed Oct 16 06:54:54 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 16 Oct 2013 06:54:54 +0000 Subject: hg: jdk8/tl/nashorn: 7 new changesets Message-ID: <20131016065502.808F862447@hg.openjdk.java.net> Changeset: 6cb4f20d971f Author: jlaskey Date: 2013-10-11 14:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6cb4f20d971f 8026309: latest runsunspider.js tests contains several bugs Reviewed-by: sundar, lagergren Contributed-by: james.laskey at oracle.com ! test/script/basic/runsunspider.js Changeset: 8c617a092d68 Author: hannesw Date: 2013-10-14 11:45 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8c617a092d68 8026016: too many relinks dominate avatar.js http benchmark Reviewed-by: sundar, jlaskey, attila ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8026016.js + test/script/basic/JDK-8026016.js.EXPECTED Changeset: d155c4a7703c Author: attila Date: 2013-10-14 12:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d155c4a7703c 8026113: Nashorn arrays should automatically convert to Java arrays Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java + test/src/jdk/nashorn/api/javaaccess/ArrayConversionTest.java Changeset: 64e841576c68 Author: attila Date: 2013-10-15 15:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/64e841576c68 8026397: Fix ambiguity with array conversion, including passing JS NativeArrays in Java variable arity methods' vararg array position Reviewed-by: jlaskey, sundar ! src/jdk/internal/dynalink/beans/SingleDynamicMethod.java ! src/jdk/internal/dynalink/support/Guards.java ! src/jdk/internal/dynalink/support/messages.properties ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java ! test/src/jdk/nashorn/api/javaaccess/ArrayConversionTest.java Changeset: aa452eb4a5d0 Author: hannesw Date: 2013-10-15 17:37 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/aa452eb4a5d0 8026367: Add a sync keyword to mozilla_compat Reviewed-by: sundar, attila, lagergren ! src/jdk/nashorn/api/scripting/ScriptUtils.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js + test/script/basic/JDK-8026367.js ! test/script/sandbox/loadcompat.js Changeset: b3ee112a328e Author: jlaskey Date: 2013-10-15 13:14 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b3ee112a328e 8026498: Revert: latest runsunspider.js tests contains several bugs Reviewed-by: sundar, hannesw Contributed-by: james.laskey at oracle.com ! test/script/basic/runsunspider.js Changeset: 9a13e95cc40f Author: sundar Date: 2013-10-15 22:13 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9a13e95cc40f Merge From dmitry.degrave at oracle.com Wed Oct 16 11:17:36 2013 From: dmitry.degrave at oracle.com (dmitry.degrave at oracle.com) Date: Wed, 16 Oct 2013 11:17:36 +0000 Subject: hg: jdk8/tl/jdk: 8023431: Test java/util/zip/GZIP/GZIPInZip.java failed Message-ID: <20131016111755.CC42F62456@hg.openjdk.java.net> Changeset: 9ea6a464c147 Author: igerasim Date: 2013-10-15 21:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9ea6a464c147 8023431: Test java/util/zip/GZIP/GZIPInZip.java failed Summary: Properly close PipedStreams. Additional testing for malformed input Reviewed-by: darcy, sherman ! test/java/util/zip/GZIP/GZIPInZip.java From erik.joelsson at oracle.com Wed Oct 16 12:25:42 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Wed, 16 Oct 2013 12:25:42 +0000 Subject: hg: jdk8/tl: 6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar Message-ID: <20131016122542.E4D5B62459@hg.openjdk.java.net> Changeset: af81988013b5 Author: erikj Date: 2013-10-16 13:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/af81988013b5 6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar Reviewed-by: dholmes, chegar ! common/makefiles/JavaCompilation.gmk ! common/makefiles/RMICompilation.gmk From erik.joelsson at oracle.com Wed Oct 16 12:26:00 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Wed, 16 Oct 2013 12:26:00 +0000 Subject: hg: jdk8/tl/corba: 6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar Message-ID: <20131016122602.1BA126245A@hg.openjdk.java.net> Changeset: 438c54c148a6 Author: erikj Date: 2013-10-16 13:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/438c54c148a6 6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar Reviewed-by: dholmes, chegar ! makefiles/BuildCorba.gmk From erik.joelsson at oracle.com Wed Oct 16 13:53:54 2013 From: erik.joelsson at oracle.com (erik.joelsson at oracle.com) Date: Wed, 16 Oct 2013 13:53:54 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131016135529.AE6586245F@hg.openjdk.java.net> Changeset: 76a7c0bc74fd Author: erikj Date: 2013-10-16 13:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/76a7c0bc74fd 6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar Reviewed-by: dholmes, chegar ! makefiles/GendataBreakIterator.gmk ! makefiles/GenerateClasses.gmk ! makefiles/Setup.gmk ! src/share/classes/sun/tools/tree/Node.java Changeset: e078fd8a78f6 Author: erikj Date: 2013-10-16 15:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e078fd8a78f6 Merge From rob.mckenna at oracle.com Wed Oct 16 14:08:57 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Wed, 16 Oct 2013 14:08:57 +0000 Subject: hg: jdk8/tl/jdk: 8026245: InetAddress.getLocalHost crash if IPv6 disabled (macosx) Message-ID: <20131016140923.AF19E62460@hg.openjdk.java.net> Changeset: d8eec0e3a023 Author: robm Date: 2013-10-16 15:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8eec0e3a023 8026245: InetAddress.getLocalHost crash if IPv6 disabled (macosx) Reviewed-by: chegar, alanb ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! test/java/net/InetAddress/GetLocalHostWithSM.java ! test/java/net/Socket/GetLocalAddress.java From sean.mullan at oracle.com Wed Oct 16 15:12:43 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 16 Oct 2013 11:12:43 -0400 Subject: [8] Review Request for 8026346: test/java/lang/SecurityManager/CheckPackageAccess.java failing Message-ID: <525EACEB.2020900@oracle.com> This test was failing due to an invalid assumption that the JDK source tree would be available when testing. The test has been changed to not assume that. Also, a minor fix was made to the order of the restricted packages in the java.security-macosx file to be consistent with the other java.security files. webrev: http://cr.openjdk.java.net/~mullan/webrevs/8026346/webrev.01/ bug: https://bugs.openjdk.java.net/browse/JDK-8026346 Thanks, Sean From daniel.fuchs at oracle.com Wed Oct 16 15:22:37 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Wed, 16 Oct 2013 15:22:37 +0000 Subject: hg: jdk8/tl/jdk: 8011638: Remove deprecated methods in sun.util.logging.PlatformLogger Message-ID: <20131016152401.B019A62465@hg.openjdk.java.net> Changeset: 445667b19e32 Author: dfuchs Date: 2013-10-16 17:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/445667b19e32 8011638: Remove deprecated methods in sun.util.logging.PlatformLogger Reviewed-by: psandoz, mchung, alanb, chegar ! src/share/classes/sun/font/FontUtilities.java ! src/share/classes/sun/util/logging/PlatformLogger.java ! test/sun/util/logging/PlatformLoggerTest.java From jonathan.gibbons at oracle.com Wed Oct 16 17:49:47 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 16 Oct 2013 17:49:47 +0000 Subject: hg: jdk8/tl/langtools: 8026704: Build failure with --enable-debug Message-ID: <20131016174953.24F266246F@hg.openjdk.java.net> Changeset: d7e155f874a7 Author: jjg Date: 2013-10-16 10:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7e155f874a7 8026704: Build failure with --enable-debug Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java - test/tools/javac/lambda/LocalVariableTable.java From bernd-2013 at eckenfels.net Wed Oct 16 18:14:49 2013 From: bernd-2013 at eckenfels.net (Bernd Eckenfels) Date: Wed, 16 Oct 2013 20:14:49 +0200 Subject: JNLP with unsigend resources is no longer loaded with SunJDK 7U45 Message-ID: Am 16.10.2013, 05:01 Uhr, schrieb Bernd Eckenfels : > java.lang.SecurityException: com.sun.deploy.net.JARSigningException: > Unsignierter Eintrag gefunden in Ressource: > http://localhost:10000/s....jar I was checking if deployment rules would help me here. But if I create a run-rule for this location it does not help, because it seems like the verification of the JAR is executed before the deployment rules. So I cannot force an older JRE version which can deal with those files. Gruss Bernd From daniel.fuchs at oracle.com Wed Oct 16 18:50:18 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Wed, 16 Oct 2013 18:50:18 +0000 Subject: hg: jdk8/tl/jdk: 8013839: Enhance Logger API for handling of resource bundles; ... Message-ID: <20131016185101.EFBBA62472@hg.openjdk.java.net> Changeset: 2ef43f3a901c Author: dfuchs Date: 2013-10-16 20:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ef43f3a901c 8013839: Enhance Logger API for handling of resource bundles 4814565: (rb) add method to get basename from a ResourceBundle Summary: adds Logger.setResourceBundle(ResourceBundle) and ResourceBundle.getBaseBundleName() Reviewed-by: mchung, naoto ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/java/util/logging/Logger.java + test/java/util/ResourceBundle/getBaseBundleName/TestGetBaseBundleName.java + test/java/util/ResourceBundle/getBaseBundleName/resources/ListBundle.java + test/java/util/ResourceBundle/getBaseBundleName/resources/ListBundle_fr.java + test/java/util/ResourceBundle/getBaseBundleName/resources/PropertyBundle.properties + test/java/util/ResourceBundle/getBaseBundleName/resources/PropertyBundle_fr.properties + test/java/util/logging/Logger/logrb/TestLogrbResourceBundle.java + test/java/util/logging/Logger/logrb/resources/ListBundle.java + test/java/util/logging/Logger/logrb/resources/ListBundle_fr.java + test/java/util/logging/Logger/logrb/resources/PropertyBundle.properties + test/java/util/logging/Logger/logrb/resources/PropertyBundle_fr.properties + test/java/util/logging/Logger/setResourceBundle/TestSetResourceBundle.java + test/java/util/logging/Logger/setResourceBundle/resources/ListBundle.java + test/java/util/logging/Logger/setResourceBundle/resources/ListBundle_fr.java + test/java/util/logging/Logger/setResourceBundle/resources/PropertyBundle.properties + test/java/util/logging/Logger/setResourceBundle/resources/PropertyBundle_fr.properties From mike.duigou at oracle.com Wed Oct 16 20:12:51 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 16 Oct 2013 20:12:51 +0000 Subject: hg: jdk8/tl/jdk: 8025910: rename substream(long) -> skip and remove substream(long, long) Message-ID: <20131016201329.3606C6247F@hg.openjdk.java.net> Changeset: cf9cb3d241a3 Author: mduigou Date: 2013-10-16 13:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf9cb3d241a3 8025910: rename substream(long) -> skip and remove substream(long,long) Reviewed-by: psandoz, henryjen ! src/share/classes/java/util/stream/DoublePipeline.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntPipeline.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongPipeline.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/Stream.java ! test/java/util/stream/boottest/java/util/stream/SpinedBufferTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntSliceOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java From eric.mccorkle at oracle.com Wed Oct 16 20:33:46 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Wed, 16 Oct 2013 20:33:46 +0000 Subject: hg: jdk8/tl/langtools: 8026286: Improper locking of annotation queues causes assertion failures.; ... Message-ID: <20131016203408.AFEED62487@hg.openjdk.java.net> Changeset: 7f6481e5fe3a Author: emc Date: 2013-10-16 16:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7f6481e5fe3a 8026286: Improper locking of annotation queues causes assertion failures. 8026063: Calls to annotate.flush() cause incorrect type annotations to be generated. Summary: Fix locking in ClassReader.java Reviewed-by: jfranck ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java + test/tools/javac/annotations/typeAnnotations/TestAnonInnerInstance1.java ! test/tools/javac/annotations/typeAnnotations/classfile/T8008762.java From sean.coffey at oracle.com Wed Oct 16 20:21:42 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Wed, 16 Oct 2013 20:21:42 +0000 Subject: hg: jdk8/tl/jdk: 8025255: (tz) Support tzdata2013g Message-ID: <20131016202214.A84AF62480@hg.openjdk.java.net> Changeset: 60e3cdbe8cdf Author: aefimov Date: 2013-10-13 14:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60e3cdbe8cdf 8025255: (tz) Support tzdata2013g Reviewed-by: okutsu, mfang ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/backward ! make/sun/javazic/tzdata/etcetera ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/iso3166.tab ! make/sun/javazic/tzdata/leapseconds ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/antarctica ! test/sun/util/calendar/zi/tzdata/asia ! test/sun/util/calendar/zi/tzdata/australasia ! test/sun/util/calendar/zi/tzdata/backward ! test/sun/util/calendar/zi/tzdata/etcetera ! test/sun/util/calendar/zi/tzdata/europe ! test/sun/util/calendar/zi/tzdata/iso3166.tab ! test/sun/util/calendar/zi/tzdata/leapseconds ! test/sun/util/calendar/zi/tzdata/northamerica ! test/sun/util/calendar/zi/tzdata/southamerica ! test/sun/util/calendar/zi/tzdata/zone.tab From henry.jen at oracle.com Thu Oct 17 04:36:57 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Thu, 17 Oct 2013 04:36:57 +0000 Subject: hg: jdk8/tl/jdk: 8026768: java.util.Map.Entry comparingBy methods missing @since 1.8 Message-ID: <20131017043716.577F96249C@hg.openjdk.java.net> Changeset: e2e3c2c249e2 Author: henryjen Date: 2013-10-16 21:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2e3c2c249e2 8026768: java.util.Map.Entry comparingBy methods missing @since 1.8 Reviewed-by: dholmes ! src/share/classes/java/util/Map.java From yuka.kamiya at oracle.com Thu Oct 17 04:59:32 2013 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Thu, 17 Oct 2013 04:59:32 +0000 Subject: hg: jdk8/tl/jdk: 8025703: Update LSR datafile for BCP 47 Message-ID: <20131017045944.38A556249E@hg.openjdk.java.net> Changeset: ce266885222d Author: peytoia Date: 2013-10-17 13:57 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce266885222d 8025703: Update LSR datafile for BCP 47 Reviewed-by: okutsu ! src/share/classes/sun/util/locale/LocaleEquivalentMaps.java + test/java/util/Locale/Bug8025703.java ! test/java/util/Locale/tools/language-subtag-registry.txt From bradford.wetmore at oracle.com Thu Oct 17 06:39:29 2013 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Thu, 17 Oct 2013 06:39:29 +0000 Subject: hg: jdk8/tl/jdk: 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files Message-ID: <20131017064008.E091E624A3@hg.openjdk.java.net> Changeset: a45acc8de0f3 Author: wetmore Date: 2013-10-16 23:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a45acc8de0f3 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files Reviewed-by: katleman, dholmes ! makefiles/GenerateClasses.gmk From bradford.wetmore at oracle.com Thu Oct 17 06:38:53 2013 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Thu, 17 Oct 2013 06:38:53 +0000 Subject: hg: jdk8/tl/corba: 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files Message-ID: <20131017063854.64EAC624A1@hg.openjdk.java.net> Changeset: 1a71d800b032 Author: wetmore Date: 2013-10-16 23:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/1a71d800b032 8026762: jdk8-tl builds windows builds failing in corba - javac: no source files Reviewed-by: katleman, dholmes ! makefiles/BuildCorba.gmk From sundararajan.athijegannathan at oracle.com Thu Oct 17 09:21:13 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 17 Oct 2013 09:21:13 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20131017092119.09F41624A6@hg.openjdk.java.net> Changeset: 1899da5c71d3 Author: hannesw Date: 2013-10-16 10:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1899da5c71d3 8026692: eval() throws NullPointerException with --compile-only Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/Lower.java + test/script/basic/JDK-8026692.js Changeset: 2d5f9f77c199 Author: hannesw Date: 2013-10-16 10:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2d5f9f77c199 8026693: getType() called on DISCARD node Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/codegen/BranchOptimizer.java + test/script/basic/JDK-8026693.js Changeset: adc5639fc4b9 Author: sundar Date: 2013-10-17 13:02 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/adc5639fc4b9 Merge From weijun.wang at oracle.com Thu Oct 17 11:03:47 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 17 Oct 2013 19:03:47 +0800 Subject: RFR 8026712,TEST_BUG: update sun/security/tools/keytool/autotest.sh with a new location to find of libsoftokn3.so Message-ID: <525FC413.9090505@oracle.com> Hi Vinnie Please take a review at this fix http://cr.openjdk.java.net/~weijun/8026712/webrev.00 It seems the PKCS11Test.java file also hardcoded the paths. But I don't know what other archs to add. Thanks Max From joel.franck at oracle.com Thu Oct 17 11:41:09 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Thu, 17 Oct 2013 11:41:09 +0000 Subject: hg: jdk8/tl/langtools: 8015372: Update tests for Method Parameter Reflection API to check whether a parameter is final Message-ID: <20131017114115.E9E15624AB@hg.openjdk.java.net> Changeset: a48d3b981083 Author: mnunez Date: 2013-10-17 13:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a48d3b981083 8015372: Update tests for Method Parameter Reflection API to check whether a parameter is final Reviewed-by: jjg, jfranck ! test/tools/javac/MethodParameters/AnnotationTest.java + test/tools/javac/MethodParameters/AnnotationTest.out ! test/tools/javac/MethodParameters/AnonymousClass.java + test/tools/javac/MethodParameters/AnonymousClass.out ! test/tools/javac/MethodParameters/ClassFileVisitor.java ! test/tools/javac/MethodParameters/Constructors.java + test/tools/javac/MethodParameters/Constructors.out ! test/tools/javac/MethodParameters/EnumTest.java + test/tools/javac/MethodParameters/EnumTest.out ! test/tools/javac/MethodParameters/InstanceMethods.java + test/tools/javac/MethodParameters/InstanceMethods.out ! test/tools/javac/MethodParameters/LambdaTest.java + test/tools/javac/MethodParameters/LambdaTest.out ! test/tools/javac/MethodParameters/LocalClassTest.java + test/tools/javac/MethodParameters/LocalClassTest.out ! test/tools/javac/MethodParameters/MemberClassTest.java + test/tools/javac/MethodParameters/MemberClassTest.out ! test/tools/javac/MethodParameters/ReflectionVisitor.java ! test/tools/javac/MethodParameters/StaticMethods.java + test/tools/javac/MethodParameters/StaticMethods.out ! test/tools/javac/MethodParameters/Tester.java ! test/tools/javac/MethodParameters/UncommonParamNames.java + test/tools/javac/MethodParameters/UncommonParamNames.out From Vincent.X.Ryan at Oracle.Com Thu Oct 17 12:26:37 2013 From: Vincent.X.Ryan at Oracle.Com (Vincent Ryan) Date: Thu, 17 Oct 2013 13:26:37 +0100 Subject: RFR 8026712, TEST_BUG: update sun/security/tools/keytool/autotest.sh with a new location to find of libsoftokn3.so In-Reply-To: <525FC413.9090505@oracle.com> References: <525FC413.9090505@oracle.com> Message-ID: <4FE8F5F9-DDAE-42B6-A264-14A55E40601E@Oracle.Com> That looks fine (except that l.82 got dropped from the original). Since Embedded Linux versions install the NSS libs in different directories we may have to add new paths in future. On 17 Oct 2013, at 12:03, Weijun Wang wrote: > Hi Vinnie > > Please take a review at this fix > > http://cr.openjdk.java.net/~weijun/8026712/webrev.00 > > It seems the PKCS11Test.java file also hardcoded the paths. But I don't know what other archs to add. > > Thanks > Max From joel.franck at oracle.com Thu Oct 17 12:25:14 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Thu, 17 Oct 2013 12:25:14 +0000 Subject: hg: jdk8/tl/langtools: 8008192: Better ordering checks needed in repeatingAnnotations/combo/ReflectionTest Message-ID: <20131017122518.F1F19624AC@hg.openjdk.java.net> Changeset: 4d8af6fda907 Author: mnunez Date: 2013-10-17 13:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4d8af6fda907 8008192: Better ordering checks needed in repeatingAnnotations/combo/ReflectionTest Reviewed-by: jjg, jfranck ! test/tools/javac/annotations/repeatingAnnotations/combo/Helper.java ! test/tools/javac/annotations/repeatingAnnotations/combo/ReflectionTest.java From weijun.wang at oracle.com Thu Oct 17 12:52:18 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 17 Oct 2013 20:52:18 +0800 Subject: RFR 8026712, TEST_BUG: update sun/security/tools/keytool/autotest.sh with a new location to find of libsoftokn3.so In-Reply-To: <4FE8F5F9-DDAE-42B6-A264-14A55E40601E@Oracle.Com> References: <525FC413.9090505@oracle.com> <4FE8F5F9-DDAE-42B6-A264-14A55E40601E@Oracle.Com> Message-ID: <525FDD82.1010809@oracle.com> On 10/17/13 8:26 PM, Vincent Ryan wrote: > That looks fine (except that l.82 got dropped from the original). Ah, good catch, > > Since Embedded Linux versions install the NSS libs in different directories we may have to > add new paths in future. Seems these are old-style Debian (before the multi-arch thing), so still in /usr/lib/nss. --Max > > > On 17 Oct 2013, at 12:03, Weijun Wang wrote: > >> Hi Vinnie >> >> Please take a review at this fix >> >> http://cr.openjdk.java.net/~weijun/8026712/webrev.00 >> >> It seems the PKCS11Test.java file also hardcoded the paths. But I don't know what other archs to add. >> >> Thanks >> Max > From weijun.wang at oracle.com Thu Oct 17 12:57:11 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 17 Oct 2013 12:57:11 +0000 Subject: hg: jdk8/tl/jdk: 8026712: TEST_BUG: update sun/security/tools/keytool/autotest.sh with a new location to find of libsoftokn3.so Message-ID: <20131017125803.9530A624AD@hg.openjdk.java.net> Changeset: 37e3dcb798c3 Author: weijun Date: 2013-10-17 20:56 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37e3dcb798c3 8026712: TEST_BUG: update sun/security/tools/keytool/autotest.sh with a new location to find of libsoftokn3.so Reviewed-by: vinnie ! test/sun/security/tools/keytool/autotest.sh From eric.mccorkle at oracle.com Thu Oct 17 13:34:44 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Thu, 17 Oct 2013 13:34:44 +0000 Subject: hg: jdk8/tl/jdk: 8022718: Runtime accessibility checking: protected class, if extended, should be accessible from another package Message-ID: <20131017133532.AC669624B1@hg.openjdk.java.net> Changeset: 0a6730b5e192 Author: drchase Date: 2013-10-16 17:55 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a6730b5e192 8022718: Runtime accessibility checking: protected class, if extended, should be accessible from another package Summary: Modify accessibility check; it was muddled about Java vs JVM protection terminology. Reviewed-by: jrose ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/sun/invoke/util/VerifyAccess.java ! src/share/classes/sun/reflect/Reflection.java + test/java/lang/invoke/accessProtectedSuper/BogoLoader.java + test/java/lang/invoke/accessProtectedSuper/MethodInvoker.java + test/java/lang/invoke/accessProtectedSuper/Test.java + test/java/lang/invoke/accessProtectedSuper/anotherpkg/MethodSupplierOuter.java From vincent.x.ryan at oracle.com Thu Oct 17 14:17:50 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 17 Oct 2013 15:17:50 +0100 Subject: [8] Review Request for 8026346: test/java/lang/SecurityManager/CheckPackageAccess.java failing In-Reply-To: <525EACEB.2020900@oracle.com> References: <525EACEB.2020900@oracle.com> Message-ID: <5CC826FC-5910-460F-AED8-D782E2BD0CAA@oracle.com> Those changes look fine. Thanks. On 16 Oct 2013, at 16:12, Sean Mullan wrote: > This test was failing due to an invalid assumption that the JDK source tree would be available when testing. The test has been changed to not assume that. Also, a minor fix was made to the order of the restricted packages in the java.security-macosx file to be consistent with the other java.security files. > > webrev: http://cr.openjdk.java.net/~mullan/webrevs/8026346/webrev.01/ > bug: https://bugs.openjdk.java.net/browse/JDK-8026346 > > Thanks, > Sean From roger.riggs at oracle.com Thu Oct 17 14:46:09 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Thu, 17 Oct 2013 14:46:09 +0000 Subject: hg: jdk8/tl/jdk: 8026516: javadoc errors in java.time Message-ID: <20131017144656.B3B64624B4@hg.openjdk.java.net> Changeset: 36fe6a9bd43e Author: rriggs Date: 2013-10-17 10:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/36fe6a9bd43e 8026516: javadoc errors in java.time Summary: Corrected links to TemporalQuery and TemporalField.resolve Reviewed-by: mduigou, darcy, lancea ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/IsoEra.java ! src/share/classes/java/time/chrono/MinguoChronology.java ! src/share/classes/java/time/chrono/MinguoEra.java ! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java ! src/share/classes/java/time/chrono/ThaiBuddhistEra.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java From sean.mullan at oracle.com Thu Oct 17 15:36:38 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Thu, 17 Oct 2013 15:36:38 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20131017153852.56D75624B7@hg.openjdk.java.net> Changeset: 5d866df64ae3 Author: mullan Date: 2013-10-17 10:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d866df64ae3 8026346: test/java/lang/SecurityManager/CheckPackageAccess.java failing Reviewed-by: vinnie ! src/share/lib/security/java.security-macosx ! test/java/lang/SecurityManager/CheckPackageAccess.java Changeset: 04e8b8fc6906 Author: mullan Date: 2013-10-17 10:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04e8b8fc6906 Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/java/net/HttpURLPermission.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: 85a73ad28c53 Author: mullan Date: 2013-10-17 11:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85a73ad28c53 Merge From leif.samuelsson at oracle.com Thu Oct 17 16:57:55 2013 From: leif.samuelsson at oracle.com (Leif Samuelsson) Date: Thu, 17 Oct 2013 09:57:55 -0700 Subject: Code review request: 7025699: Policy Tool is not accessible by keyboard In-Reply-To: <525D74BD.6070707@oracle.com> References: <52589CA1.4080503@oracle.com> <525D304C.9090304@oracle.com> <525D4D75.3090200@oracle.com> <525D70B1.4020603@oracle.com> <525D73C9.2090702@oracle.com> <525D74BD.6070707@oracle.com> Message-ID: <52601713.5020202@oracle.com> Hi All, A new webrev is available at: http://cr.openjdk.java.net/~weijun/7025699/webrev.01/ The following new changes were made: 1. Added call to SwingUtilities.invokeLater() in main() to run the GUI initialization on the Event Dispatch Thread. 2. Minor corrections to initial size and placement of the main window. 3. More mnemonics defined for buttons and labeled fields on the Policy Entry and KeyStore dialogs. Note that we have decided to not implement the use of SwingWorker for File I/O in this release. The main reasons are that it is not covered in the scope of the bug report, the blocking can not actually be considered a regression compared to the AWT version, and it would require enough refactoring of the code to risk affecting the general logic and cause new bugs. I am the Contributor for this bug fix, and Max (Weijun) will be the Committer. Thanks, Leif On 2013-10-15 10:00, Leif Samuelsson wrote: > Thanks for the good feedback. We will make sure to move to move the > GUI instantiation to the EDT and the file I/O to a worker thread. > > All other operations are event driven and therefore occur directly > on the EDT. > > Leif > > > On 2013-10-15 09:56, alexander potochkin wrote: >> Hello >> >>> Well, performing I/O or other blocking operations on EDT can only freeze the app's GUI for the period of blocking. If developers/users are OK with that, this is fine with me too. >>> >> >> I don't think an I/O blocking operation on EDT is acceptable. It can freeze the whole application and give a bad experience to the users. >> Please consider using the SwingWorker API >> http://docs.oracle.com/javase/tutorial/uiswing/concurrency/worker.html >> >> >>> However, you should still call all Swing APIs (including creating your components/windows) on the EDT. And I don't see this is being done in your current code. As a minimum, the displayToolWindow() method should be dispatched on the event thread. I haven't examined the code closely, but if there are any other GUI updates from separate threads, those should also be moved to the EDT. See the following tutorial for details: >>> >>> http://docs.oracle.com/javase/tutorial/uiswing/concurrency/dispatch.html >>> >> >> Indeed, rewriting an AWT app as a Swing app is not only about changing Labels to JLabels >> Please make sure that all Swing code are used on the event dispatching thread only. >> >> Thanks >> alexp >> >>> -- >>> best regards, >>> Anthony >>> >>> On 10/15/2013 06:13 PM, Weijun Wang wrote: >>>> Policy Tool is a GUI editor for the plain text policy file. The only I/O >>>> is loading the policy file from disk and it should be quite small, so I >>>> think there won't be a problem here. >>>> >>>> Thanks >>>> Max >>>> >>>> On 10/15/13 8:08 PM, Anthony Petrov wrote: >>>>> Hi Max, >>>>> >>>>> I don't have expertise in this code so I haven't reviewed the fix >>>>> thoroughly. I'd like to point out one thing though: unlike AWT, Swing is >>>>> a single-threaded GUI toolkit. While in AWT you can create >>>>> components/windows and call APIs on any thread, in Swing everything >>>>> GUI-related must be performed on the Event Dispatch Thread (EDT) only. >>>>> Any long, non-GUI-related operations (like I/O, computations, etc.) >>>>> should be dispatched on other threads (with a SwingWorker, for example). >>>>> >>>>> I don't see a single SwingUtilities.invokeLater/invokeAndWait() call in >>>>> PolicyTool.java, so I thought I'd ask whether you're aware of the >>>>> threading limitations imposed by Swing and how those are going to be >>>>> addressed? >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 10/12/2013 04:49 AM, Weijun Wang wrote: >>>>>> Hi All >>>>>> >>>>>> Please review the fix at >>>>>> >>>>>> http://cr.openjdk.java.net/~weijun/7025699/webrev.00/ >>>>>> >>>>>> The fix includes porting PolicyTool from AWT to Swing, defining >>>>>> mnemonics for menu items and buttons, and adding keyboard shortcuts for >>>>>> the File -> New/Open/Save items. Several tests are updated also. >>>>>> >>>>>> Thanks >>>>>> Max >> From roger.riggs at oracle.com Thu Oct 17 17:50:14 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Thu, 17 Oct 2013 17:50:14 +0000 Subject: hg: jdk8/tl/jdk: 8026183: minor documentation problems in java.lang.invoke; ... Message-ID: <20131017175026.571B6624C9@hg.openjdk.java.net> Changeset: 456a9b199208 Author: rriggs Date: 2013-10-17 13:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/456a9b199208 8026183: minor documentation problems in java.lang.invoke 8015808: Typo in MethodHandle javadoc Summary: Fix typos and javadoc markup and extraneous paragraph tags Reviewed-by: lancea ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/ConstantCallSite.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodType.java From jason.uh at oracle.com Thu Oct 17 18:04:46 2013 From: jason.uh at oracle.com (Jason Uh) Date: Thu, 17 Oct 2013 11:04:46 -0700 Subject: [8] Request for Review: 8026233: test/sun/security/tools/keytool/StorePasswords.java needs to clean up files In-Reply-To: <3C6F39DA-04D8-4E96-B052-42B84313FFCA@oracle.com> References: <5255FB5F.5070705@oracle.com> <3C6F39DA-04D8-4E96-B052-42B84313FFCA@oracle.com> Message-ID: <526026BE.9070905@oracle.com> Hi Vinnie, I'd like to add to this changeset to ensure that resources are closed. Could you please review the revision? http://cr.openjdk.java.net/~juh/8026233/webrev.01/ Thanks, Jason On 10/10/2013 12:15 PM, Vincent Ryan wrote: > That fix looks fine Jason. > Thanks. > > On 10 Oct 2013, at 01:57, Jason Uh wrote: > >> Hi Vinnie, >> >> Could you please review this fix? The test sun/security/tools/keytool/StorePasswords.java can terminate with an error on Windows because of files not getting cleaned up, so this fix deletes the keystore file at the end of the test. >> >> webrev: http://cr.openjdk.java.net/~juh/8026233/webrev.00/ >> >> Thanks, >> Jason > From huizhe.wang at oracle.com Thu Oct 17 18:24:19 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Thu, 17 Oct 2013 18:24:19 +0000 Subject: hg: jdk8/tl/jaxp: 8015243: SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI Message-ID: <20131017182425.949BC624CB@hg.openjdk.java.net> Changeset: 0c3f951630fe Author: joehw Date: 2013-10-17 11:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0c3f951630fe 8015243: SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/util/URI.java From vincent.x.ryan at oracle.com Thu Oct 17 18:35:38 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Thu, 17 Oct 2013 19:35:38 +0100 Subject: [8] Request for Review: 8026233: test/sun/security/tools/keytool/StorePasswords.java needs to clean up files In-Reply-To: <526026BE.9070905@oracle.com> References: <5255FB5F.5070705@oracle.com> <3C6F39DA-04D8-4E96-B052-42B84313FFCA@oracle.com> <526026BE.9070905@oracle.com> Message-ID: <46C86998-F7BF-45F7-863E-F3F9B3A6436C@oracle.com> Looks fine. Thanks. On 17 Oct 2013, at 19:04, Jason Uh wrote: > Hi Vinnie, I'd like to add to this changeset to ensure that resources are closed. Could you please review the revision? > > http://cr.openjdk.java.net/~juh/8026233/webrev.01/ > > Thanks, > Jason > > On 10/10/2013 12:15 PM, Vincent Ryan wrote: >> That fix looks fine Jason. >> Thanks. >> >> On 10 Oct 2013, at 01:57, Jason Uh wrote: >> >>> Hi Vinnie, >>> >>> Could you please review this fix? The test sun/security/tools/keytool/StorePasswords.java can terminate with an error on Windows because of files not getting cleaned up, so this fix deletes the keystore file at the end of the test. >>> >>> webrev: http://cr.openjdk.java.net/~juh/8026233/webrev.00/ >>> >>> Thanks, >>> Jason >> From java3 at segal.org Thu Oct 17 18:47:19 2013 From: java3 at segal.org (Mickey Segal) Date: Thu, 17 Oct 2013 14:47:19 -0400 Subject: InvocationTargetException when running applet locally Message-ID: <000001cecb69$4fa3c2e0$eeeb48a0$@segal.org> For years, we've used the ability to run our signed Java applet locally when we are in a location without internet access. That seems no longer to work as of Java 7 update 45. When the applet is launched, a java.lang.reflect.InvocationTargetException is thrown. I assume this is a result of something done to block some security hole, but does that mean there is no way anymore to run a Java applet locally, even if it is signed? No message shows up in the Java Console, and even a println put right at the beginning of the program gives no console output. In Java 7 update 25, there was also a problem running applets locally, but it was getCodeBase returning null, something that could be solved by hard-coding the codebase. Is there any workaround to this issue in 7u45? Can one stay at 7u40 indefinitely? Does switching to a Java 8 build get around the issue? From huizhe.wang at oracle.com Thu Oct 17 18:56:34 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Thu, 17 Oct 2013 18:56:34 +0000 Subject: hg: jdk8/tl/jdk: 8015243: SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI Message-ID: <20131017185713.BB0FF624CC@hg.openjdk.java.net> Changeset: bc04f561bb78 Author: joehw Date: 2013-10-17 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc04f561bb78 8015243: SchemaFactory does not catch enum. value that is not in the value space of the base type, anyURI Reviewed-by: lancea + test/javax/xml/jaxp/validation/8015243/AnyURITest.java + test/javax/xml/jaxp/validation/8015243/anyURI_b006.xsd From jason.uh at oracle.com Thu Oct 17 19:01:16 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Thu, 17 Oct 2013 19:01:16 +0000 Subject: hg: jdk8/tl/jdk: 8026233: test/sun/security/tools/keytool/StorePasswords.java needs to clean up files Message-ID: <20131017190128.182E5624CE@hg.openjdk.java.net> Changeset: fa38f8e0accd Author: juh Date: 2013-10-17 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fa38f8e0accd 8026233: test/sun/security/tools/keytool/StorePasswords.java needs to clean up files Reviewed-by: vinnie ! test/sun/security/tools/keytool/StorePasswords.java From java3 at segal.org Thu Oct 17 19:01:42 2013 From: java3 at segal.org (Mickey Segal) Date: Thu, 17 Oct 2013 15:01:42 -0400 Subject: How to download Java 7 update 40? Message-ID: <000001cecb6b$51fb83a0$f5f28ae0$@segal.org> It is not yet at the download page at http://www.oracle.com/technetwork/java/javase/downloads/java-archive-downloads-javase7-521261.html -------------- next part -------------- An HTML attachment was scrubbed... URL: From java3 at segal.org Thu Oct 17 19:07:55 2013 From: java3 at segal.org (Mickey Segal) Date: Thu, 17 Oct 2013 15:07:55 -0400 Subject: InvocationTargetException when running applet locally Message-ID: <000201cecb6c$30570980$91051c80$@segal.org> I've tested Java 8 build 111 (jre-8-ea-bin-b111-windows-i586-10_oct_2013) and the InvocationTargetException problem doesn't occur. Does that mean that the InvocationTargetException problem is a bug in Java 7 or a feature not yet propagated to Java 8? From alexander.potochkin at oracle.com Thu Oct 17 17:11:12 2013 From: alexander.potochkin at oracle.com (alexander potochkin) Date: Thu, 17 Oct 2013 10:11:12 -0700 Subject: Code review request: 7025699: Policy Tool is not accessible by keyboard In-Reply-To: <52601713.5020202@oracle.com> References: <52589CA1.4080503@oracle.com> <525D304C.9090304@oracle.com> <525D4D75.3090200@oracle.com> <525D70B1.4020603@oracle.com> <525D73C9.2090702@oracle.com> <525D74BD.6070707@oracle.com> <52601713.5020202@oracle.com> Message-ID: <52601A30.8030401@oracle.com> Hello Leif Looks good to me I had a look at the PolicyTool code and indeed it is better to leave the IO processing as is at this moment. Thanks alexp > Hi All, > > A new webrev is available at: > > http://cr.openjdk.java.net/~weijun/7025699/webrev.01/ > > The following new changes were made: > > 1. Added call to SwingUtilities.invokeLater() in main() to run the GUI > initialization on the Event Dispatch Thread. > > 2. Minor corrections to initial size and placement of the main window. > > 3. More mnemonics defined for buttons and labeled fields on the Policy > Entry and KeyStore dialogs. > > Note that we have decided to not implement the use of SwingWorker for > File I/O in this release. The main reasons are that it is not covered > in the scope of the bug report, the blocking can not actually be > considered a regression compared to the AWT version, and it would > require enough refactoring of the code to risk affecting the general > logic and cause new bugs. > > I am the Contributor for this bug fix, and Max (Weijun) will be the > Committer. > > Thanks, > Leif > > > > On 2013-10-15 10:00, Leif Samuelsson wrote: >> Thanks for the good feedback. We will make sure to move to move the >> GUI instantiation to the EDT and the file I/O to a worker thread. >> >> All other operations are event driven and therefore occur directly >> on the EDT. >> >> Leif >> >> >> On 2013-10-15 09:56, alexander potochkin wrote: >>> Hello >>> >>>> Well, performing I/O or other blocking operations on EDT can only >>>> freeze the app's GUI for the period of blocking. If >>>> developers/users are OK with that, this is fine with me too. >>>> >>> >>> I don't think an I/O blocking operation on EDT is acceptable. It can >>> freeze the whole application and give a bad experience to the users. >>> Please consider using the SwingWorker API >>> http://docs.oracle.com/javase/tutorial/uiswing/concurrency/worker.html >>> >>> >>>> However, you should still call all Swing APIs (including creating >>>> your components/windows) on the EDT. And I don't see this is being >>>> done in your current code. As a minimum, the displayToolWindow() >>>> method should be dispatched on the event thread. I haven't examined >>>> the code closely, but if there are any other GUI updates from >>>> separate threads, those should also be moved to the EDT. See the >>>> following tutorial for details: >>>> >>>> http://docs.oracle.com/javase/tutorial/uiswing/concurrency/dispatch.html >>>> >>>> >>> >>> Indeed, rewriting an AWT app as a Swing app is not only about >>> changing Labels to JLabels >>> Please make sure that all Swing code are used on the event >>> dispatching thread only. >>> >>> Thanks >>> alexp >>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 10/15/2013 06:13 PM, Weijun Wang wrote: >>>>> Policy Tool is a GUI editor for the plain text policy file. The >>>>> only I/O >>>>> is loading the policy file from disk and it should be quite small, >>>>> so I >>>>> think there won't be a problem here. >>>>> >>>>> Thanks >>>>> Max >>>>> >>>>> On 10/15/13 8:08 PM, Anthony Petrov wrote: >>>>>> Hi Max, >>>>>> >>>>>> I don't have expertise in this code so I haven't reviewed the fix >>>>>> thoroughly. I'd like to point out one thing though: unlike AWT, >>>>>> Swing is >>>>>> a single-threaded GUI toolkit. While in AWT you can create >>>>>> components/windows and call APIs on any thread, in Swing everything >>>>>> GUI-related must be performed on the Event Dispatch Thread (EDT) >>>>>> only. >>>>>> Any long, non-GUI-related operations (like I/O, computations, etc.) >>>>>> should be dispatched on other threads (with a SwingWorker, for >>>>>> example). >>>>>> >>>>>> I don't see a single SwingUtilities.invokeLater/invokeAndWait() >>>>>> call in >>>>>> PolicyTool.java, so I thought I'd ask whether you're aware of the >>>>>> threading limitations imposed by Swing and how those are going to be >>>>>> addressed? >>>>>> >>>>>> -- >>>>>> best regards, >>>>>> Anthony >>>>>> >>>>>> On 10/12/2013 04:49 AM, Weijun Wang wrote: >>>>>>> Hi All >>>>>>> >>>>>>> Please review the fix at >>>>>>> >>>>>>> http://cr.openjdk.java.net/~weijun/7025699/webrev.00/ >>>>>>> >>>>>>> The fix includes porting PolicyTool from AWT to Swing, defining >>>>>>> mnemonics for menu items and buttons, and adding keyboard >>>>>>> shortcuts for >>>>>>> the File -> New/Open/Save items. Several tests are updated also. >>>>>>> >>>>>>> Thanks >>>>>>> Max >>> From lance.andersen at oracle.com Thu Oct 17 19:16:48 2013 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Thu, 17 Oct 2013 19:16:48 +0000 Subject: hg: jdk8/tl/jdk: 8026812: doclint clean up for java.sql and javax.sql Message-ID: <20131017191711.EAAEA624CF@hg.openjdk.java.net> Changeset: 64c0ac7cd936 Author: lancea Date: 2013-10-17 15:14 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64c0ac7cd936 8026812: doclint clean up for java.sql and javax.sql Reviewed-by: mduigou ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Connection.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLException.java ! src/share/classes/java/sql/SQLFeatureNotSupportedException.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/sql/SQLWarning.java ! src/share/classes/java/sql/SQLXML.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/javax/sql/CommonDataSource.java ! src/share/classes/javax/sql/RowSet.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/FilteredRowSet.java ! src/share/classes/javax/sql/rowset/JdbcRowSet.java ! src/share/classes/javax/sql/rowset/JoinRowSet.java ! src/share/classes/javax/sql/rowset/Joinable.java ! src/share/classes/javax/sql/rowset/Predicate.java ! src/share/classes/javax/sql/rowset/WebRowSet.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java ! src/share/classes/javax/sql/rowset/spi/SyncResolver.java From gnu.andrew at redhat.com Thu Oct 17 19:25:30 2013 From: gnu.andrew at redhat.com (Andrew) Date: Thu, 17 Oct 2013 15:25:30 -0400 (EDT) Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <5251C216.105@oracle.com> References: <5251C216.105@oracle.com> Message-ID: <1898888421.8989993.1382037930696.JavaMail.root@redhat.com> ----- Original Message ----- > > As a follow-up to Joe Darcy's rename of jdk.Supported to jdk.Exported, > I'd like to have another attempt at adding the annotation to a number of > JDK specific APIs that are long standing exported, documented and > supported APIs. Specifically, the following APIs: > > - Java Debug Interface (com.sun.jdi) > - Attach API (com.sun.tools.attach) > - SCTP API (com.sun.nio.sctp) > - HTTP server API (com.sun.net.httpserver) > - Management extensions (com.sun.management) > - JConsole Plugin API (com.sun.tools.jconsole) > - JDK-specific API to JAAS (com.sun.security.auth) > - JDK-specific JGSS API (com.sun.security.jgss) > > (The javadoc for each of these APIs is currently generated in the build) > > The webrev with the proposed update is here: > http://cr.openjdk.java.net/~alanb/8008662/webrev.02/ > > As per the original webrev, I've added package-info.java to a number of > packages that didn't have any description. In a few cases, I've had to > rename the legacy package.html to package-info.java. > > For the review then the intention is that @jdk.Exported be added to the > package-info and all public/protected types in these APIs. The only > exceptions are two cases where I've added @jdk.Exported(false), > specifically: > > - com.sun.management.OSMBeanFactory as it clearly documents to stay away > - com.sun.security.auth.callback.DialogCallbackHandler as it for the > chop (see JEP 162) > > Thanks, > > Alan. > I just came across this trying to understand what the new annotation means. Is the intention for these 'exported' APIs to be eventually replaced by proper parts of the specification (i.e. java.* or javax.*). I'm not keen on the idea of encouraging the use of APIs that are only in this implementation of the JDK. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From mandy.chung at oracle.com Thu Oct 17 20:24:00 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 17 Oct 2013 20:24:00 +0000 Subject: hg: jdk8/tl/langtools: 8015912: jdeps support to output in dot file format; ... Message-ID: <20131017202405.ABBB9624D4@hg.openjdk.java.net> Changeset: defadd528513 Author: mchung Date: 2013-10-17 13:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/defadd528513 8015912: jdeps support to output in dot file format 8026255: Switch jdeps to follow traditional Java option style Reviewed-by: alanb ! src/share/classes/com/sun/tools/jdeps/Analyzer.java ! src/share/classes/com/sun/tools/jdeps/Archive.java ! src/share/classes/com/sun/tools/jdeps/ClassFileReader.java ! src/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java + src/share/classes/com/sun/tools/jdeps/Profile.java - src/share/classes/com/sun/tools/jdeps/Profiles.java ! src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties + test/tools/jdeps/APIDeps.java ! test/tools/jdeps/Basic.java ! test/tools/jdeps/Test.java + test/tools/jdeps/b/B.java + test/tools/jdeps/c/C.java + test/tools/jdeps/c/I.java + test/tools/jdeps/d/D.java + test/tools/jdeps/e/E.java + test/tools/jdeps/f/F.java + test/tools/jdeps/g/G.java + test/tools/jdeps/m/Bar.java + test/tools/jdeps/m/Foo.java + test/tools/jdeps/m/Gee.java From mandy.chung at oracle.com Thu Oct 17 20:25:21 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 17 Oct 2013 20:25:21 +0000 Subject: hg: jdk8/tl/jdk: 8015912: jdeps support to output in dot file format; ... Message-ID: <20131017202546.776B1624D5@hg.openjdk.java.net> Changeset: 3735d81552a7 Author: mchung Date: 2013-10-17 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3735d81552a7 8015912: jdeps support to output in dot file format 8026255: Switch jdeps to follow traditional Java option style Reviewed-by: alanb ! test/sun/reflect/CallerSensitive/CallerSensitiveFinder.java From mike.duigou at oracle.com Thu Oct 17 20:54:19 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 17 Oct 2013 20:54:19 +0000 Subject: hg: jdk8/tl/jdk: 8004138: ForkJoinTask leaks exceptions Message-ID: <20131017205508.2266B624D9@hg.openjdk.java.net> Changeset: c1af85c48819 Author: mduigou Date: 2013-10-17 12:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1af85c48819 8004138: ForkJoinTask leaks exceptions Reviewed-by: chegar, mduigou, psandoz, martin Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/ForkJoinTask.java + test/java/util/concurrent/forkjoin/FJExceptionTableLeak.java From mandy.chung at oracle.com Thu Oct 17 21:04:50 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 17 Oct 2013 14:04:50 -0700 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <1898888421.8989993.1382037930696.JavaMail.root@redhat.com> References: <5251C216.105@oracle.com> <1898888421.8989993.1382037930696.JavaMail.root@redhat.com> Message-ID: <526050F2.1050204@oracle.com> On 10/17/13 12:25 PM, Andrew wrote: > > I just came across this trying to understand what the new annotation means. > > Is the intention for these 'exported' APIs to be eventually replaced by proper > parts of the specification (i.e. java.* or javax.*). I'm not keen on the idea > of encouraging the use of APIs that are only in this implementation of the JDK. @Exported APIs are supported for use outside JDK implementation. You can refer to JEP 179 [1] for details. Most of the APIs annotated with @Exported are not new and have been supported by Oracle JDK(links to jdk7 docs) http://docs.oracle.com/javase/7/docs/technotes/guides/management/ http://docs.oracle.com/javase/7/docs/technotes/guides/security/index.html The JDK internal APIs remain to be unsupported. Mandy [1] http://openjdk.java.net/jeps/179 From mike.duigou at oracle.com Thu Oct 17 21:09:29 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 17 Oct 2013 21:09:29 +0000 Subject: hg: jdk8/tl: 8026062: webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug", -l and wxfile support Message-ID: <20131017210929.D5FED624DA@hg.openjdk.java.net> Changeset: 9ec6626d43bb Author: mduigou Date: 2013-10-17 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9ec6626d43bb 8026062: webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug", -l and wxfile support Reviewed-by: weijun, dsamersoff, darcy, jrose, tbell ! make/scripts/webrev.ksh From bernd-2013 at eckenfels.net Thu Oct 17 21:14:35 2013 From: bernd-2013 at eckenfels.net (Bernd Eckenfels) Date: Thu, 17 Oct 2013 23:14:35 +0200 Subject: InvocationTargetException when running applet locally Message-ID: Am 17.10.2013, 20:47 Uhr, schrieb Mickey Segal : > For years, we've used the ability to run our signed Java applet locally > when we are in a location without internet access. That seems no longer > to work as of Java 7 update 45. When the applet is launched, a > java.lang.reflect.InvocationTargetException is thrown. I assume this is > a result of something done to block some security hole, but does that > mean there is no way anymore to run a Java applet locally, even if it is > signed? It might be obvious, but maybe not: InvocationTargetException is an Exception produced by Reflection. It is used to wrap Exceptions thrown in the reflected code (since it is not possible to declare them dynamically). In your case I guess Reflection is used by the launcher to start the applet methods. It would be good citizenship to remove the ITE from printing/displaying but as it is not done, you have to do it. You need to look at the stacked cause, the next Exception is the one your code throws. Without seeing this chain it is hard to guess what your problem is. But I think most likely you run into a NPE because of the changed behavior of getCodeBase() (as explained here for example: http://www.duckware.com/tech/java-security-clusterfuck.html) Greetings Bernd From brian.burkhalter at oracle.com Thu Oct 17 22:06:40 2013 From: brian.burkhalter at oracle.com (brian.burkhalter at oracle.com) Date: Thu, 17 Oct 2013 22:06:40 +0000 Subject: hg: jdk8/tl/jdk: 8026832: Clean up straggling doclint warnings in java.math Message-ID: <20131017220653.11AC7624DB@hg.openjdk.java.net> Changeset: e76bb2436b04 Author: bpb Date: 2013-10-17 15:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e76bb2436b04 8026832: Clean up straggling doclint warnings in java.math Summary: Fix empty paragraph tag warnings. Reviewed-by: lancea ! src/share/classes/java/math/BigDecimal.java ! src/share/classes/java/math/RoundingMode.java From anthony.scarpino at oracle.com Thu Oct 17 22:14:24 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Thu, 17 Oct 2013 15:14:24 -0700 Subject: Code Review Request: 8025763 Message-ID: <52606140.1060204@oracle.com> Hi, I need a code review for changes regarding 8025763 Provider does not override new Hashtable methods http://cr.openjdk.java.net/~ascarpino/8025763/ thanks Tony From bradford.wetmore at oracle.com Thu Oct 17 22:50:53 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Thu, 17 Oct 2013 15:50:53 -0700 Subject: [8] Request for Review: 8026233: test/sun/security/tools/keytool/StorePasswords.java needs to clean up files In-Reply-To: <46C86998-F7BF-45F7-863E-F3F9B3A6436C@oracle.com> References: <5255FB5F.5070705@oracle.com> <3C6F39DA-04D8-4E96-B052-42B84313FFCA@oracle.com> <526026BE.9070905@oracle.com> <46C86998-F7BF-45F7-863E-F3F9B3A6436C@oracle.com> Message-ID: <526069CD.1070005@oracle.com> Looks good. brad On 10/17/2013 11:35 AM, Vincent Ryan wrote: > Looks fine. > Thanks. > > > On 17 Oct 2013, at 19:04, Jason Uh wrote: > >> Hi Vinnie, I'd like to add to this changeset to ensure that resources are closed. Could you please review the revision? >> >> http://cr.openjdk.java.net/~juh/8026233/webrev.01/ >> >> Thanks, >> Jason >> >> On 10/10/2013 12:15 PM, Vincent Ryan wrote: >>> That fix looks fine Jason. >>> Thanks. >>> >>> On 10 Oct 2013, at 01:57, Jason Uh wrote: >>> >>>> Hi Vinnie, >>>> >>>> Could you please review this fix? The test sun/security/tools/keytool/StorePasswords.java can terminate with an error on Windows because of files not getting cleaned up, so this fix deletes the keystore file at the end of the test. >>>> >>>> webrev: http://cr.openjdk.java.net/~juh/8026233/webrev.00/ >>>> >>>> Thanks, >>>> Jason >>> > From huizhe.wang at oracle.com Thu Oct 17 23:36:09 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Thu, 17 Oct 2013 23:36:09 +0000 Subject: hg: jdk8/tl/jaxp: 8016500: Unlocalized warnigs. Message-ID: <20131017233615.5F800624DF@hg.openjdk.java.net> Changeset: 951c1f7fdb10 Author: joehw Date: 2013-10-17 16:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/951c1f7fdb10 8016500: Unlocalized warnigs. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/jaxp/DefaultValidationErrorHandler.java ! src/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java From lana.steuck at oracle.com Fri Oct 18 00:50:44 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Oct 2013 00:50:44 +0000 Subject: hg: jdk8/tl/jaxp: 5 new changesets Message-ID: <20131018005108.4E110624ED@hg.openjdk.java.net> Changeset: acae2e8a46df Author: ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/acae2e8a46df 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildJaxp.gmk ! makefiles/Makefile Changeset: c1f9158fbb9c Author: katleman Date: 2013-10-16 11:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c1f9158fbb9c Merge Changeset: e85dd07c0eea Author: cl Date: 2013-10-17 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/e85dd07c0eea Added tag jdk8-b112 for changeset c1f9158fbb9c ! .hgtags Changeset: 31c82bc71ae3 Author: lana Date: 2013-10-17 15:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/31c82bc71ae3 Merge Changeset: 2f1e1e2c2242 Author: lana Date: 2013-10-17 17:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/2f1e1e2c2242 Merge From lana.steuck at oracle.com Fri Oct 18 00:50:44 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Oct 2013 00:50:44 +0000 Subject: hg: jdk8/tl: 25 new changesets Message-ID: <20131018005048.530AB624EA@hg.openjdk.java.net> Changeset: 7dea0ce25bdc Author: pbhat Date: 2013-05-30 16:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7dea0ce25bdc Merge ! common/autoconf/generated-configure.sh Changeset: d081bdbf904d Author: jqzuo Date: 2013-06-10 16:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d081bdbf904d Merge ! common/autoconf/generated-configure.sh Changeset: b59990653fb9 Author: pbhat Date: 2013-06-21 18:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b59990653fb9 Merge ! common/autoconf/generated-configure.sh Changeset: dd345e4b51fb Author: pbhat Date: 2013-07-05 11:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/dd345e4b51fb Merge ! common/autoconf/generated-configure.sh Changeset: 24cc2d9b0af5 Author: pbhat Date: 2013-07-18 16:49 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/24cc2d9b0af5 Merge ! common/autoconf/generated-configure.sh Changeset: 4a4c9e7bc6c9 Author: pbhat Date: 2013-07-25 17:26 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4a4c9e7bc6c9 Merge Changeset: 63d794ade242 Author: pbhat Date: 2013-08-02 09:41 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/63d794ade242 Merge Changeset: a5485b9a2d14 Author: pbhat Date: 2013-08-09 14:54 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a5485b9a2d14 Merge Changeset: 028ac95111b9 Author: pbhat Date: 2013-08-16 14:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/028ac95111b9 Merge Changeset: 4b686cbc32c7 Author: pbhat Date: 2013-08-23 09:45 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4b686cbc32c7 Merge ! common/autoconf/generated-configure.sh Changeset: ec583e324aaf Author: pbhat Date: 2013-08-30 10:14 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ec583e324aaf Merge ! common/autoconf/generated-configure.sh Changeset: 96f00091b570 Author: pbhat Date: 2013-09-05 11:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/96f00091b570 Merge ! common/autoconf/generated-configure.sh Changeset: 69096d4b1da2 Author: pbhat Date: 2013-09-12 12:08 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/69096d4b1da2 Merge ! common/autoconf/generated-configure.sh Changeset: 5a306baf3bb7 Author: pbhat Date: 2013-09-19 14:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5a306baf3bb7 Merge ! common/autoconf/generated-configure.sh Changeset: 88ca3ff9ce2d Author: billyh Date: 2013-09-25 10:50 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/88ca3ff9ce2d 8025262: new64jre/new64jdk wrappers should be removed, build 32-bit AU during windows-amd64 builds instead Reviewed-by: amenkov, jqzuo ! make/install-rules.gmk Changeset: c8066e5d7a7b Author: pbhat Date: 2013-09-26 11:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c8066e5d7a7b Merge Changeset: 00ae95ca1755 Author: pbhat Date: 2013-10-03 09:52 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/00ae95ca1755 Merge Changeset: 7deff16cf438 Author: jqzuo Date: 2013-10-14 18:53 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/7deff16cf438 Merge ! common/autoconf/generated-configure.sh Changeset: ec48d637778a Author: tbell Date: 2013-10-09 18:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ec48d637778a 8023611: Win32 and win64: Remove all the WARNINGS in JDK 8 builds for Windows 2008 and MSVS 2010 SP1 Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: 174a54ce39c4 Author: ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/174a54ce39c4 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! NewMakefile.gmk ! common/autoconf/autogen.sh ! common/autoconf/basics.m4 ! common/autoconf/basics_windows.m4 ! common/autoconf/boot-jdk.m4 ! common/autoconf/bootcycle-spec.gmk.in ! common/autoconf/build-aux/config.guess ! common/autoconf/build-performance.m4 ! common/autoconf/builddeps.conf.example ! common/autoconf/builddeps.conf.nfs.example ! common/autoconf/builddeps.m4 ! common/autoconf/compare.sh.in ! common/autoconf/config.h.in ! common/autoconf/configure ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/help.m4 ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/autoconf/libraries.m4 ! common/autoconf/platform.m4 ! common/autoconf/source-dirs.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 ! common/autoconf/toolchain_windows.m4 ! common/makefiles/HotspotWrapper.gmk ! common/makefiles/IdlCompilation.gmk ! common/makefiles/JavaCompilation.gmk ! common/makefiles/Jprt.gmk ! common/makefiles/Main.gmk ! common/makefiles/MakeBase.gmk ! common/makefiles/MakeHelpers.gmk ! common/makefiles/NativeCompilation.gmk ! common/makefiles/RMICompilation.gmk ! common/makefiles/devkit/Makefile ! common/makefiles/devkit/Tools.gmk ! common/makefiles/javadoc/CORE_PKGS.gmk ! common/makefiles/javadoc/Javadoc.gmk ! common/makefiles/javadoc/NON_CORE_PKGS.gmk ! common/makefiles/javadoc/Notes.html Changeset: 6274d4cd22d3 Author: erikj Date: 2013-10-14 11:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6274d4cd22d3 8025921: Make LOG=debug output more readable Reviewed-by: tbell, ihse ! common/makefiles/JavaCompilation.gmk ! common/makefiles/MakeBase.gmk Changeset: 547316ea137d Author: katleman Date: 2013-10-16 11:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/547316ea137d Merge ! common/autoconf/generated-configure.sh ! common/makefiles/javadoc/CORE_PKGS.gmk ! common/makefiles/javadoc/Javadoc.gmk Changeset: ac748011cbbf Author: cl Date: 2013-10-17 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ac748011cbbf Added tag jdk8-b112 for changeset 547316ea137d ! .hgtags Changeset: 77473affb9c0 Author: lana Date: 2013-10-17 13:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/77473affb9c0 Merge ! common/makefiles/JavaCompilation.gmk ! common/makefiles/RMICompilation.gmk Changeset: 35c14ec3e12f Author: lana Date: 2013-10-17 15:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/35c14ec3e12f Merge From lana.steuck at oracle.com Fri Oct 18 00:50:23 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Oct 2013 00:50:23 +0000 Subject: hg: jdk8/tl/corba: 4 new changesets Message-ID: <20131018005033.E0ED4624E9@hg.openjdk.java.net> Changeset: 66fc1a749867 Author: ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/66fc1a749867 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildCorba.gmk ! makefiles/Makefile Changeset: 43cec76d1d62 Author: katleman Date: 2013-10-16 11:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/43cec76d1d62 Merge Changeset: 54aa9b7d743d Author: cl Date: 2013-10-17 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/54aa9b7d743d Added tag jdk8-b112 for changeset 43cec76d1d62 ! .hgtags Changeset: 1c01208087b5 Author: lana Date: 2013-10-17 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/1c01208087b5 Merge ! makefiles/BuildCorba.gmk From lana.steuck at oracle.com Fri Oct 18 00:50:53 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Oct 2013 00:50:53 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20131018005104.D2C70624EB@hg.openjdk.java.net> Changeset: 45399f3ef717 Author: ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/45399f3ef717 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildNashorn.gmk ! makefiles/Makefile Changeset: 6a4fdb3bb4e3 Author: katleman Date: 2013-10-16 12:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6a4fdb3bb4e3 Merge Changeset: 103590fc1e0a Author: cl Date: 2013-10-17 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/103590fc1e0a Added tag jdk8-b112 for changeset 6a4fdb3bb4e3 ! .hgtags Changeset: 676cd7bf5e09 Author: lana Date: 2013-10-17 16:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/676cd7bf5e09 Merge From lana.steuck at oracle.com Fri Oct 18 00:50:44 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Oct 2013 00:50:44 +0000 Subject: hg: jdk8/tl/jaxws: 4 new changesets Message-ID: <20131018005105.164FF624EC@hg.openjdk.java.net> Changeset: 602fdd7bb765 Author: ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/602fdd7bb765 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildJaxws.gmk ! makefiles/Makefile Changeset: dbdd5c762509 Author: katleman Date: 2013-10-16 11:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/dbdd5c762509 Merge Changeset: 9ca9735d9966 Author: cl Date: 2013-10-17 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/9ca9735d9966 Added tag jdk8-b112 for changeset dbdd5c762509 ! .hgtags Changeset: be7d1f874b96 Author: lana Date: 2013-10-17 16:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/be7d1f874b96 Merge From lana.steuck at oracle.com Fri Oct 18 00:50:53 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Oct 2013 00:50:53 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20131018005124.34CF9624EE@hg.openjdk.java.net> Changeset: 343aeb2033f0 Author: ihse Date: 2013-10-10 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/343aeb2033f0 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildLangtools.gmk ! makefiles/Makefile Changeset: 954dd199d6ff Author: katleman Date: 2013-10-16 12:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/954dd199d6ff Merge Changeset: 8f54b4231c28 Author: cl Date: 2013-10-17 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8f54b4231c28 Added tag jdk8-b112 for changeset 954dd199d6ff ! .hgtags Changeset: bca97b47f0a2 Author: lana Date: 2013-10-17 16:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bca97b47f0a2 Merge From lana.steuck at oracle.com Fri Oct 18 00:52:44 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Oct 2013 00:52:44 +0000 Subject: hg: jdk8/tl/jdk: 11 new changesets Message-ID: <20131018005525.F31C0624F0@hg.openjdk.java.net> Changeset: 28191d3ff921 Author: erikj Date: 2013-10-09 16:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28191d3ff921 8026144: Missing mkdir in Images.gmk Reviewed-by: tbell ! makefiles/Images.gmk Changeset: 86df2e879eca Author: tbell Date: 2013-10-09 18:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86df2e879eca 8023611: Win32 and win64: Remove all the WARNINGS in JDK 8 builds for Windows 2008 and MSVS 2010 SP1 Reviewed-by: erikj ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Defs-versions.gmk ! make/common/shared/Sanity.gmk Changeset: 98d98ec01f07 Author: tbell Date: 2013-10-09 23:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98d98ec01f07 Merge Changeset: 9c60860b1812 Author: ihse Date: 2013-10-10 15:06 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c60860b1812 8001931: The new build system whitespace cleanup Reviewed-by: tbell, simonis, erikj ! makefiles/BuildJdk.gmk ! makefiles/Bundles.gmk ! makefiles/CompileDemos.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/CopySamples.gmk ! makefiles/CreateJars.gmk ! makefiles/GendataBreakIterator.gmk ! makefiles/GendataFontConfig.gmk ! makefiles/GendataHtml32dtd.gmk ! makefiles/GendataTZDB.gmk ! makefiles/GendataTimeZone.gmk ! makefiles/GenerateClasses.gmk ! makefiles/GenerateData.gmk ! makefiles/GenerateJavaSources.gmk ! makefiles/GensrcBuffer.gmk ! makefiles/GensrcCLDR.gmk ! makefiles/GensrcCharacterData.gmk ! makefiles/GensrcCharsetCoder.gmk ! makefiles/GensrcCharsetMapping.gmk ! makefiles/GensrcExceptions.gmk ! makefiles/GensrcIcons.gmk ! makefiles/GensrcJDWP.gmk ! makefiles/GensrcJObjC.gmk ! makefiles/GensrcLocaleDataMetaInfo.gmk ! makefiles/GensrcMisc.gmk ! makefiles/GensrcProperties.gmk ! makefiles/GensrcSwing.gmk ! makefiles/GensrcX11Wrappers.gmk ! makefiles/Images.gmk ! makefiles/Import.gmk ! makefiles/Makefile ! makefiles/PatchList.solaris ! makefiles/ProfileNames.gmk ! makefiles/Profiles.gmk ! makefiles/Setup.gmk ! makefiles/SignJars.gmk ! makefiles/Tools.gmk ! makefiles/jpda/jdwp/jdwp.spec ! makefiles/jprt.gmk ! makefiles/jprt.properties ! makefiles/mapfiles/libawt/mapfile-mawt-vers ! makefiles/mapfiles/libawt/mapfile-vers ! makefiles/mapfiles/libawt/mapfile-vers-linux ! makefiles/mapfiles/libawt_headless/mapfile-vers ! makefiles/mapfiles/libawt_xawt/mapfile-vers ! makefiles/mapfiles/libfontmanager/mapfile-vers ! makefiles/mapfiles/libfontmanager/mapfile-vers.openjdk ! makefiles/mapfiles/libj2pcsc/mapfile-vers ! makefiles/mapfiles/libjdga/mapfile-vers ! makefiles/mapfiles/libjli/mapfile-vers ! makefiles/mapfiles/libverify/mapfile-vers ! makefiles/profile-includes.txt ! makefiles/profile-rtjar-includes.txt ! makefiles/scripts/addNotices.sh ! makefiles/scripts/genCharsetProvider.sh ! makefiles/scripts/genExceptions.sh ! makefiles/scripts/localelist.sh ! makefiles/sun/awt/ToBin.java Changeset: cf3ee0e2c1a5 Author: erikj Date: 2013-10-14 11:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf3ee0e2c1a5 8025612: rt.jar still has old specification value in the manifest Reviewed-by: alanb, dholmes, tbell, wetmore ! make/tools/manifest.mf Changeset: 986acae7efe9 Author: ihse Date: 2013-10-15 13:06 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/986acae7efe9 8001933: Move Gensrc*.gmk and Gendata*.gmk into separate directories. Reviewed-by: erikj, tbell ! makefiles/BuildJdk.gmk ! makefiles/CreateJars.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk ! makefiles/GenerateData.gmk - makefiles/GenerateJavaSources.gmk + makefiles/GenerateSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk + makefiles/gendata/GendataBreakIterator.gmk + makefiles/gendata/GendataFontConfig.gmk + makefiles/gendata/GendataHtml32dtd.gmk + makefiles/gendata/GendataTZDB.gmk + makefiles/gendata/GendataTimeZone.gmk + makefiles/gensrc/GensrcBuffer.gmk + makefiles/gensrc/GensrcCLDR.gmk + makefiles/gensrc/GensrcCharacterData.gmk + makefiles/gensrc/GensrcCharsetCoder.gmk + makefiles/gensrc/GensrcCharsetMapping.gmk + makefiles/gensrc/GensrcExceptions.gmk + makefiles/gensrc/GensrcIcons.gmk + makefiles/gensrc/GensrcJDWP.gmk + makefiles/gensrc/GensrcJObjC.gmk + makefiles/gensrc/GensrcLocaleDataMetaInfo.gmk + makefiles/gensrc/GensrcMisc.gmk + makefiles/gensrc/GensrcProperties.gmk + makefiles/gensrc/GensrcSwing.gmk + makefiles/gensrc/GensrcX11Wrappers.gmk Changeset: eef656e1bdeb Author: ksrini Date: 2013-10-16 07:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eef656e1bdeb 8026500: [infra] remove extraneous docs in solaris images Reviewed-by: erikj, mchung, tbell ! makefiles/Images.gmk - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 Changeset: f002f5f3a16c Author: katleman Date: 2013-10-16 12:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f002f5f3a16c Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk ! makefiles/Profiles.gmk ! makefiles/profile-includes.txt - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 Changeset: bef8f6d429de Author: cl Date: 2013-10-17 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bef8f6d429de Added tag jdk8-b112 for changeset f002f5f3a16c ! .hgtags Changeset: 187d5ccb5b18 Author: lana Date: 2013-10-17 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/187d5ccb5b18 Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CreateJars.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk ! makefiles/GenerateClasses.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk ! makefiles/Images.gmk ! makefiles/Setup.gmk ! makefiles/Tools.gmk + makefiles/gendata/GendataBreakIterator.gmk ! makefiles/profile-includes.txt - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 Changeset: b73fb7920645 Author: lana Date: 2013-10-17 15:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b73fb7920645 Merge - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 From lana.steuck at oracle.com Fri Oct 18 00:52:44 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 18 Oct 2013 00:52:44 +0000 Subject: hg: jdk8/tl/hotspot: 46 new changesets Message-ID: <20131018005433.C131B624EF@hg.openjdk.java.net> Changeset: deec468baebd Author: amurillo Date: 2013-10-04 14:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/deec468baebd 8025859: new hotspot build - hs25-b54 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 5b3b75d9eb2f Author: coleenp Date: 2013-10-01 14:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5b3b75d9eb2f 8025570: Naked oop in test/serviceability/ParserTest Summary: Fix for two naked objArrayOop(s) oops causing test failure Reviewed-by: coleenp, ctornqvi Contributed-by: lois.foltan at oracle.com ! src/share/vm/prims/wbtestmethods/parserTests.cpp Changeset: f21415c32ca1 Author: coleenp Date: 2013-10-01 15:41 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f21415c32ca1 Merge Changeset: d574419c5372 Author: mseledtsov Date: 2013-10-02 15:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d574419c5372 8025671: Test name changed, test list not updated. Test6878713.sh Summary: Removed the obsolete test from the test group file Reviewed-by: sla, ctornqvi, dholmes ! test/TEST.groups Changeset: 931f105563c5 Author: coleenp Date: 2013-10-02 13:02 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/931f105563c5 8025569: -XX:+CheckUnhandledOops crashes on Windows Summary: Disable CHECK_UNHANDLED_OOPS in fastdebug builds for JDK 8 on WIndows 32 & 64 bit machines Reviewed-by: coleenp, ctornqvi, zgu Contributed-by: lois.foltan at oracle.com ! make/windows/makefiles/fastdebug.make Changeset: 6f73bc5df986 Author: coleenp Date: 2013-10-02 15:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6f73bc5df986 Merge Changeset: 2bd38d594b9a Author: dsamersoff Date: 2013-10-02 20:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2bd38d594b9a 8025283: Nits in os_bsd file breaks compilation of open hotspot Summary: Couple of nits in os_bsd.cpp brake compilation of open hotspot on non-apple platforms Reviewed-by: sla, sspitsyn ! src/os/bsd/vm/os_bsd.cpp Changeset: 9855f17334d8 Author: dsamersoff Date: 2013-10-03 01:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9855f17334d8 Merge Changeset: 5705c7ee6dd7 Author: dsamersoff Date: 2013-10-02 22:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5705c7ee6dd7 8025250: SA: Sync linux and bsd versions of ps_core file Summary: linux/ps_core.c and bsd/ps_core.c share most of code, but it has different formatting, comments etc. Reviewed-by: sla, minqi ! agent/src/os/bsd/ps_core.c ! agent/src/os/linux/ps_core.c Changeset: 7ae82c3a781a Author: dsamersoff Date: 2013-10-03 04:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7ae82c3a781a Merge Changeset: faff125a1ead Author: dsamersoff Date: 2013-10-03 12:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/faff125a1ead 8022616: u4 should not be used as a type for thread_id Summary: Usage of u4 as a type for thread_id cause a compilation error on platform, where thread_id is a pointer Reviewed-by: sla, sspitsyn, minqi ! src/os/bsd/vm/osThread_bsd.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/os_bsd.hpp Changeset: 07f8c2a453f8 Author: coleenp Date: 2013-10-03 18:53 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/07f8c2a453f8 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV Summary: Redefined class in stack trace may not be found by method_idnum so handle null. Reviewed-by: sla, dcubed, sspitsyn ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 3374b92de2d9 Author: coleenp Date: 2013-10-03 18:50 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3374b92de2d9 8025004: -XX:+CheckUnhandledOops asserts for JDK 8 Solaris fastdebug binaries Summary: Remove unnecessary volatile keyword on stack locals within instanceKlass.cpp to work around Solaris Studio C++ compiler issue Reviewed-by: coleenp, dcubed Contributed-by: lois.foltan at oracle.com ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: 3bf767171ea4 Author: coleenp Date: 2013-10-05 00:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3bf767171ea4 Merge Changeset: 675ffabf3798 Author: mikael Date: 2013-10-02 09:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/675ffabf3798 8024087: Remove dead JVM_{Get,Set}PrimitiveFieldValues functions Summary: The two functions were used to support JDK 1.3 but are no longer in use Reviewed-by: coleenp, ctornqvi, twisti, dsamersoff ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm_misc.hpp ! src/share/vm/prims/nativeLookup.cpp Changeset: a1fd44b003c7 Author: coleenp Date: 2013-10-05 00:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a1fd44b003c7 Merge Changeset: 4212bfb33d76 Author: coleenp Date: 2013-10-05 03:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4212bfb33d76 Merge Changeset: 2720ab7a0d70 Author: ccheung Date: 2013-10-04 21:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2720ab7a0d70 Merge ! src/share/vm/prims/jvm.cpp Changeset: febab3a8f203 Author: erikj Date: 2013-10-04 12:45 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/febab3a8f203 8007446: Add /MP to cl.exe speeds up windows builds of OpenJDK. Reviewed-by: sla, ctornqvi ! make/windows/makefiles/compile.make ! make/windows/makefiles/sa.make Changeset: 763705f0fec3 Author: sla Date: 2013-10-04 13:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/763705f0fec3 8016845: SA is unable to use hsdis on windows Summary: Added sadis.c to the build to provide missing symbols in sawindbg.dll. Added code to use the correct hsdisXXX.dll filename on different windows platforms. Reviewed-by: sla, mgerdin Contributed-by: fredrik.arvidsson at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/asm/Disassembler.java ! make/windows/makefiles/sa.make Changeset: f9be370a7d54 Author: sla Date: 2013-10-05 15:18 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f9be370a7d54 8025922: JNI access to Strings need to check if the value field is non-null Reviewed-by: dholmes, dcubed ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jniCheck.cpp Changeset: 8ef918538e22 Author: sla Date: 2013-10-04 13:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8ef918538e22 6313383: SA: Update jmap to support HPROF binary format "JAVA PROFILE 1.0.2" Summary: Adds support for large(>4G) heap dumps in hprof format. Adds tests and updates testlibrary. Reviewed-by: sla, allwin Contributed-by: fredrik.arvidsson at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/utilities/AbstractHeapGraphWriter.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java ! test/TEST.groups + test/serviceability/sa/jmap-hprof/JMapHProfLargeHeapProc.java + test/serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ! test/testlibrary/com/oracle/java/testlibrary/JDKToolLauncher.java Changeset: 9c63ad02c0a4 Author: sla Date: 2013-10-05 10:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9c63ad02c0a4 Merge Changeset: cc4f5f8d885e Author: mseledtsov Date: 2013-10-06 16:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cc4f5f8d885e 8023796: [TESTBUG] Add -XX:-TransmitErrorReport to runtime/6888954/vmerrors.sh Summary: added -XX:-TransmitErrorReport to the test Reviewed-by: stefank, ctornqvi ! test/runtime/6888954/vmerrors.sh ! test/runtime/memory/ReserveMemory.java Changeset: ac9cb1d5a202 Author: acorn Date: 2013-10-07 12:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ac9cb1d5a202 8009130: Lambda: Fix access controls, loader constraints. Summary: New default methods list with inherited superinterface methods Reviewed-by: minqi, sspitsyn, coleenp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/reflectionUtils.cpp ! src/share/vm/runtime/reflectionUtils.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 615d83933195 Author: dholmes Date: 2013-10-08 02:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/615d83933195 8026025: JVM_GetCallerClass allows Reflection.getCallerClass(int depth) to use Reviewed-by: alanb, dholmes, twisti Contributed-by: mandy.chung at oracle.com ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h Changeset: c90e76575b03 Author: kevinw Date: 2013-10-08 09:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c90e76575b03 8019375: Internal symbol table size should be tunable. Reviewed-by: coleenp, kamg ! agent/src/share/classes/sun/jvm/hotspot/memory/SymbolTable.java ! src/share/vm/classfile/symbolTable.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: ced68a57cdbd Author: kevinw Date: 2013-10-08 11:37 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ced68a57cdbd Merge Changeset: c72075c2883e Author: acorn Date: 2013-10-08 16:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c72075c2883e 8026022: Verifier: allow anon classes to invokespecial host class/intf methods. Reviewed-by: coleenp, bharadwaj ! src/share/vm/classfile/verifier.cpp Changeset: d25557d03ec0 Author: acorn Date: 2013-10-09 17:57 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d25557d03ec0 8026185: nsk/jvmit/GetMethodDeclaringClass/declcls001 failed Summary: Missed initialization. Thanks Coleen. Reviewed-by: coleenp, minqi ! src/share/vm/oops/instanceKlass.cpp Changeset: c01f4910f5f5 Author: ccheung Date: 2013-10-10 13:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c01f4910f5f5 Merge Changeset: 9b4d0569f2f4 Author: jwilhelm Date: 2013-10-03 21:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9b4d0569f2f4 8025852: Remove unnecessary setters in collector policy classes Summary: Use instance variables directly within the collector policy classes and remove unused setters. Reviewed-by: tschatzl, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp Changeset: 087f02e22fc2 Author: jwilhelm Date: 2013-10-04 22:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/087f02e22fc2 8025854: Use "young gen" instead of "eden" Summary: Changed a few descriptions and variable names to young gen. Reviewed-by: tschatzl, jcoomes ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 263f2c796d6c Author: stefank Date: 2013-10-05 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/263f2c796d6c 8024838: Significant slowdown due to transparent huge pages Summary: Don't turn on transparent huge pages (-XX:+UseTransparentHugePages) unless explicitly specified on the command line. This has the effect that large pages are never turned on Linux unless the user has explicitly enabled any of the large pages flags: -XX:+UseLargePages, -XX:+UseTransparentHugePages, -XX:+UseHugeTLBFS, and -XX:+UseSHM. Reviewed-by: jwilhelm, tschatzl, brutisso ! src/os/linux/vm/globals_linux.hpp ! src/os/linux/vm/os_linux.cpp + test/runtime/memory/LargePages/TestLargePagesFlags.java Changeset: 8618e0d7735b Author: stefank Date: 2013-10-05 08:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8618e0d7735b Merge Changeset: 04b18a42c2f3 Author: mgerdin Date: 2013-10-04 13:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/04b18a42c2f3 8025526: VirtualSpace should support per-instance disabling of large pages Summary: Add a new initialization function to VirtualSpace which allows the caller to override the max commit granularity. Reviewed-by: stefank, ehelin, tschatzl ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp Changeset: 69944b868a32 Author: mgerdin Date: 2013-10-08 17:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/69944b868a32 8014555: G1: Memory ordering problem with Conc refinement and card marking Summary: Add a StoreLoad barrier in the G1 post-barrier to fix a race with concurrent refinement. Also-reviewed-by: martin.doerr at sap.com Reviewed-by: iveresov, tschatzl, brutisso, roland, kvn ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp ! src/share/vm/gc_implementation/g1/ptrQueue.hpp ! src/share/vm/opto/graphKit.cpp Changeset: b4d8a3d4db73 Author: tamao Date: 2013-10-09 11:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b4d8a3d4db73 8010506: Typos and errors in descriptions of vm options in globals.hpp Summary: Fix typos and errors in descriptions of vm options in globals.hpp Reviewed-by: jmasa, jwilhelm ! src/share/vm/runtime/globals.hpp Changeset: 82af7d7a0128 Author: tschatzl Date: 2013-10-09 10:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/82af7d7a0128 8003420: NPG: make new GC root for pd_set Summary: Move protection domain oops from system dictionary entries into a seperate set; the system dictionary references entries in that set now. This allows fast iteration during non-classunloading garbage collection. Implementation based on initial prototype from Ioi Lam (iklam). Reviewed-by: coleenp, iklam + agent/src/share/classes/sun/jvm/hotspot/memory/ProtectionDomainCacheEntry.java ! agent/src/share/classes/sun/jvm/hotspot/memory/ProtectionDomainEntry.java ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/dictionary.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 85c1ca43713f Author: stefank Date: 2013-10-07 15:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/85c1ca43713f 8024547: MaxMetaspaceSize should limit the committed memory used by the metaspaces Reviewed-by: brutisso, jmasa, coleenp ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/filemap.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: a6414751d537 Author: stefank Date: 2013-10-07 15:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a6414751d537 8025996: Track metaspace usage when metaspace is expanded Reviewed-by: coleenp, ehelin ! src/share/vm/memory/metaspace.cpp ! src/share/vm/services/memoryService.hpp Changeset: aa6f2ea19d8f Author: jcoomes Date: 2013-10-11 08:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aa6f2ea19d8f Merge ! src/os/linux/vm/os_linux.cpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/dictionary.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 4a845c7a4638 Author: amurillo Date: 2013-10-11 13:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4a845c7a4638 Merge Changeset: 0ed9a90f45e1 Author: amurillo Date: 2013-10-11 13:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0ed9a90f45e1 Added tag hs25-b54 for changeset 4a845c7a4638 ! .hgtags Changeset: aeae561a6d0b Author: cl Date: 2013-10-17 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aeae561a6d0b Added tag jdk8-b112 for changeset 0ed9a90f45e1 ! .hgtags Changeset: 1a93f2c5945a Author: lana Date: 2013-10-17 14:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1a93f2c5945a Merge ! make/windows/makefiles/compile.make ! make/windows/makefiles/sa.make ! src/share/vm/classfile/classFileParser.cpp From weijun.wang at oracle.com Fri Oct 18 01:00:02 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 18 Oct 2013 01:00:02 +0000 Subject: hg: jdk8/tl/jdk: 7025699: Policy Tool is not accessible by keyboard Message-ID: <20131018010020.7680F624F1@hg.openjdk.java.net> Changeset: c1616a944d1c Author: weijun Date: 2013-10-18 08:57 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1616a944d1c 7025699: Policy Tool is not accessible by keyboard Reviewed-by: alexp, weijun Contributed-by: Leif Samuelsson ! src/share/classes/sun/security/tools/policytool/PolicyTool.java ! src/share/classes/sun/security/tools/policytool/Resources.java ! test/sun/security/tools/policytool/Alias.html ! test/sun/security/tools/policytool/OpenPolicy.html ! test/sun/security/tools/policytool/UpdatePermissions.html From joe.darcy at oracle.com Fri Oct 18 02:11:05 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 18 Oct 2013 02:11:05 +0000 Subject: hg: jdk8/tl/langtools: 8026838: Fix new doclint issues in javax.annotation.processing Message-ID: <20131018021117.C1794624F4@hg.openjdk.java.net> Changeset: 7af634b1fc5b Author: darcy Date: 2013-10-17 19:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7af634b1fc5b 8026838: Fix new doclint issues in javax.annotation.processing Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/Processor.java From mandy.chung at oracle.com Fri Oct 18 02:51:03 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 18 Oct 2013 02:51:03 +0000 Subject: hg: jdk8/tl/jdk: 8025799: Restore sun.reflect.Reflection.getCallerClass(int) until a replacement API is provided Message-ID: <20131018025201.EFA98624F6@hg.openjdk.java.net> Changeset: 042a473535aa Author: mchung Date: 2013-10-17 19:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/042a473535aa 8025799: Restore sun.reflect.Reflection.getCallerClass(int) until a replacement API is provided Reviewed-by: alanb, forax, dholmes, twisti ! makefiles/mapfiles/libjava/mapfile-vers ! makefiles/mapfiles/libjava/reorder-sparc ! makefiles/mapfiles/libjava/reorder-sparcv9 ! makefiles/mapfiles/libjava/reorder-x86 ! src/share/classes/sun/reflect/Reflection.java ! src/share/javavm/export/jvm.h ! src/share/native/sun/reflect/Reflection.c + test/sun/reflect/Reflection/GetCallerClassWithDepth.java From joe.darcy at oracle.com Fri Oct 18 05:22:49 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 18 Oct 2013 05:22:49 +0000 Subject: hg: jdk8/tl/jdk: 8026840: Fix new doclint issues in javax.naming Message-ID: <20131018052321.D251D624FC@hg.openjdk.java.net> Changeset: 8a7b1b615100 Author: darcy Date: 2013-10-17 22:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a7b1b615100 8026840: Fix new doclint issues in javax.naming Reviewed-by: mchung ! src/share/classes/javax/naming/CompositeName.java ! src/share/classes/javax/naming/CompoundName.java ! src/share/classes/javax/naming/Context.java ! src/share/classes/javax/naming/InitialContext.java ! src/share/classes/javax/naming/ReferralException.java ! src/share/classes/javax/naming/directory/DirContext.java ! src/share/classes/javax/naming/event/EventContext.java ! src/share/classes/javax/naming/ldap/LdapContext.java ! src/share/classes/javax/naming/ldap/Rdn.java From xueming.shen at oracle.com Fri Oct 18 06:42:03 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 18 Oct 2013 06:42:03 +0000 Subject: hg: jdk8/tl/jdk: 8025971: Remove ZoneId.OLD_SHORT_IDS; ... Message-ID: <20131018064229.C8DCE624FD@hg.openjdk.java.net> Changeset: 658e121bda42 Author: sherman Date: 2013-10-17 23:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/658e121bda42 8025971: Remove ZoneId.OLD_SHORT_IDS 8026197: Slow reading tzdb.dat if the JRE is on a high-latency, remote file system Summary: removed the compatiblity old short-ids mapping Reviewed-by: okutsu ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! test/java/time/tck/java/time/TCKZoneId.java ! test/java/util/Calendar/JavatimeTest.java From Alan.Bateman at oracle.com Fri Oct 18 10:01:48 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 18 Oct 2013 11:01:48 +0100 Subject: 8008662: Add @jdk.Exported to JDK-specific/exported APIs In-Reply-To: <1898888421.8989993.1382037930696.JavaMail.root@redhat.com> References: <5251C216.105@oracle.com> <1898888421.8989993.1382037930696.JavaMail.root@redhat.com> Message-ID: <5261070C.60408@oracle.com> On 17/10/2013 20:25, Andrew wrote: > : > > Is the intention for these 'exported' APIs to be eventually replaced by proper > parts of the specification (i.e. java.* or javax.*). I'm not keen on the idea > of encouraging the use of APIs that are only in this implementation of the JDK. Just to add to Mandy's comments, the boat debated a long time ago on some of these. For example the Java Debug Interface (JDI) was in Sun's JDK 1.2 (1998). Since then almost every IDE has been using it (I think Eclipse might have their own implementation). Looking back then maybe it should have been standardized a long time ago but it's not clear that it's worth doing now. The HTTP server API has its own story. As I recall (and my memory is a bit hazy) then there wasn't agreement to include it as part of Java SE 6 and it had to be moved to a com.sun.net package so that it could be used for the web services APIs. The history on SCTP is that it was still an IEFT draft at the time and that it would have been too premature to attempt to standardize an API. So the decision was to start out with a com.sun API and get experience with it before re-visiting in the future to see if there is strong need to define a standard API. -Alan. From java3 at segal.org Fri Oct 18 10:37:27 2013 From: java3 at segal.org (Mickey Segal) Date: Fri, 18 Oct 2013 06:37:27 -0400 Subject: InvocationTargetException when running applet locally In-Reply-To: References: Message-ID: <001e01cecbee$0a9ab890$1fd029b0$@segal.org> We were able to get past the problem of getCodeBase() returning null by hard-coding the URL. This worked in 7 update 25 and 7 update 40. We were able to debug that problem because the applet would launch and we could use println statements find that the problem was getCodeBase() returning null. But the problem with 7 update 45 is that we don't even get to the stage of anything appearing in the Java Console; even from a println at the beginning of the code. So we don't have a set of stacked Exceptions because the only clue that InvocationTargetException is involved is an error dialog that come up, but when one clicks the option for details, the Java Console is displayed, but no messages appear. -----Original Message----- From: Bernd Eckenfels [mailto:bernd-2013 at eckenfels.net] Sent: Thursday, October 17, 2013 5:15 PM It might be obvious, but maybe not: InvocationTargetException is an Exception produced by Reflection. It is used to wrap Exceptions thrown in the reflected code (since it is not possible to declare them dynamically). In your case I guess Reflection is used by the launcher to start the applet methods. It would be good citizenship to remove the ITE from printing/displaying but as it is not done, you have to do it. You need to look at the stacked cause, the next Exception is the one your code throws. Without seeing this chain it is hard to guess what your problem is. But I think most likely you run into a NPE because of the changed behavior of getCodeBase() (as explained here for example: http://www.duckware.com/tech/java-security-clusterfuck.html) Greetings Bernd From java3 at segal.org Fri Oct 18 11:04:33 2013 From: java3 at segal.org (Mickey Segal) Date: Fri, 18 Oct 2013 07:04:33 -0400 Subject: InvocationTargetException when running applet locally References: Message-ID: <000001cecbf1$d435b710$7ca12530$@segal.org> There are also some JAR Manifest changes in 7u45, as detailed at http://www.oracle.com/technetwork/java/javase/7u45-relnotes-2016950.html#newft I don't know if that can explain the complete failure to load and the InvocationTargetException, or is just an additional issue. -----Original Message----- From: Mickey Segal [mailto:java3 at segal.org] Sent: Friday, October 18, 2013 6:37 AM We were able to get past the problem of getCodeBase() returning null by hard-coding the URL. This worked in 7 update 25 and 7 update 40. We were able to debug that problem because the applet would launch and we could use println statements find that the problem was getCodeBase() returning null. But the problem with 7 update 45 is that we don't even get to the stage of anything appearing in the Java Console; even from a println at the beginning of the code. So we don't have a set of stacked Exceptions because the only clue that InvocationTargetException is involved is an error dialog that come up, but when one clicks the option for details, the Java Console is displayed, but no messages appear. From staffan.larsen at oracle.com Fri Oct 18 10:35:44 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Fri, 18 Oct 2013 10:35:44 +0000 Subject: hg: jdk8/tl/jdk: 8021897: EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals() Message-ID: <20131018103634.618EC6250D@hg.openjdk.java.net> Changeset: 8479a48d9fd4 Author: sla Date: 2013-10-18 11:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8479a48d9fd4 8021897: EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals() Reviewed-by: alanb, sspitsyn ! src/share/back/outStream.c + test/com/sun/jdi/GetUninitializedStringValue.java From alan.bateman at oracle.com Fri Oct 18 13:37:22 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 18 Oct 2013 13:37:22 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20131018133958.A96F96251E@hg.openjdk.java.net> Changeset: da695008417f Author: alanb Date: 2013-10-18 13:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da695008417f 8026859: (fs) test/java/nio/file/Files/StreamTest.java fails to compile intermittently Reviewed-by: psandoz ! test/java/nio/file/Files/StreamTest.java Changeset: 4e065f5b4a16 Author: igerasim Date: 2013-10-18 16:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4e065f5b4a16 8026756: Test java/util/zip/GZIP/GZIPInZip.java failed Reviewed-by: alanb ! test/java/util/zip/GZIP/GZIPInZip.java Changeset: 329cf77821e8 Author: alanb Date: 2013-10-18 13:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/329cf77821e8 7050570: (fs) FileSysteProvider fails to initializes if run with file.encoding set to Cp037 Reviewed-by: sherman, ulfzibis ! src/share/classes/sun/nio/fs/Util.java ! src/solaris/classes/sun/nio/fs/GnomeFileTypeDetector.java ! src/solaris/classes/sun/nio/fs/LinuxDosFileAttributeView.java ! src/solaris/classes/sun/nio/fs/LinuxFileStore.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystem.java ! src/solaris/classes/sun/nio/fs/LinuxUserDefinedFileAttributeView.java ! src/solaris/classes/sun/nio/fs/SolarisUserDefinedFileAttributeView.java ! src/solaris/classes/sun/nio/fs/UnixException.java ! src/solaris/classes/sun/nio/fs/UnixFileStore.java ! src/solaris/classes/sun/nio/fs/UnixFileSystem.java ! src/solaris/classes/sun/nio/fs/UnixMountEntry.java ! src/solaris/classes/sun/nio/fs/UnixNativeDispatcher.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/solaris/classes/sun/nio/fs/UnixUserPrincipals.java From sean.mullan at oracle.com Fri Oct 18 13:53:42 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 18 Oct 2013 09:53:42 -0400 Subject: InvocationTargetException when running applet locally In-Reply-To: <001e01cecbee$0a9ab890$1fd029b0$@segal.org> References: <001e01cecbee$0a9ab890$1fd029b0$@segal.org> Message-ID: <52613D66.9010201@oracle.com> On 10/18/2013 06:37 AM, Mickey Segal wrote: > We were able to get past the problem of getCodeBase() returning null > by hard-coding the URL. This worked in 7 update 25 and 7 update 40. > We were able to debug that problem because the applet would launch > and we could use println statements find that the problem was > getCodeBase() returning null. But the problem with 7 update 45 is > that we don't even get to the stage of anything appearing in the Java > Console; even from a println at the beginning of the code. So we > don't have a set of stacked Exceptions because the only clue that > InvocationTargetException is involved is an error dialog that come > up, but when one clicks the option for details, the Java Console is > displayed, but no messages appear. Check the log files in $HOME/.java/deployment/log directory. Perhaps some messages aren't appearing in the console for some reason. Otherwise, I would suggest to please file a bug so we can look into it further: http://bugs.sun.com/ Thanks, Sean From java3 at segal.org Fri Oct 18 13:59:21 2013 From: java3 at segal.org (Mickey Segal) Date: Fri, 18 Oct 2013 09:59:21 -0400 Subject: InvocationTargetException when running applet locally References: Message-ID: <001201cecc0a$3f9ebcf0$bedc36d0$@segal.org> I implemented for our Java applet that runs locally the following Manifest lines: Permissions: all-permissions Codebase: * We'd added these in a Manifest.txt file for our Web version after the changes in a previous version that flagged errors unless these were present. But after installing 7u45 on another computer, this doesn't get rid of the "Error, Click for details" message instead of the applet appearing. Clicking gets an Application Error dialog box titled RuntimeException that lists java.lang.reflect.InvocationTargetException and none of the buttons such as Details do anything useful. All is fine with the Web version. All was fine with 7u40, which still hasn't appeared on the old version download page. All is fine on Java 8 build 111. Is there something else needed to add to the Manifest file? Anyone have other ideas? -----Original Message----- From: Mickey Segal Sent: Friday, October 18, 2013 7:05 AM There are also some JAR Manifest changes in 7u45, as detailed at http://www.oracle.com/technetwork/java/javase/7u45-relnotes-2016950.html#newft I don't know if that can explain the complete failure to load and the InvocationTargetException, or is just an additional issue. From java3 at segal.org Fri Oct 18 14:53:48 2013 From: java3 at segal.org (Mickey Segal) Date: Fri, 18 Oct 2013 10:53:48 -0400 Subject: InvocationTargetException when running applet locally Message-ID: <000e01cecc11$da7e8c80$8f7ba580$@segal.org> I'm having trouble resolving what you mean by $HOME. I'm used to it meaning on Windows the same thing as the user.home property, which is: c:\Users\MyUserName\ but I don't see anything there, even looking with "Hide protected operating system files" disabled. Can you help point me in the right direction? If the log doesn't solve this problem I'd be glad to file a bug report, but unfortunately this came right before we begin 2 weeks of conferences at which we'll be exhibiting all day and not doing any programming. Hopefully we won't be dead in the water in terms of Java working locally. The 7u25 problem also happened right before another major presentation, so this is the second short-deadline crisis we've had with Java updates and such crises are the sort of thing that will get Java a bad reputation with developers. If we are using Java 8 build 111 are we safe from forced updates, and can resolve this in a less time pressured environment? -----Original Message----- From: security-dev-bounces at openjdk.java.net [mailto:security-dev-bounces at openjdk.java.net] On Behalf Of Sean Mullan Sent: Friday, October 18, 2013 9:54 AM Check the log files in $HOME/.java/deployment/log directory. Perhaps some messages aren't appearing in the console for some reason. Otherwise, I would suggest to please file a bug so we can look into it further: http://bugs.sun.com/ Thanks, Sean From sundararajan.athijegannathan at oracle.com Fri Oct 18 14:03:09 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 18 Oct 2013 14:03:09 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20131018140316.E28096251F@hg.openjdk.java.net> Changeset: b01a10c7c7c2 Author: attila Date: 2013-10-17 12:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b01a10c7c7c2 8026161: Don't narrow floating-point literals in the lexer Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/runtime/JSType.java + test/script/basic/JDK-8026161.js + test/script/basic/JDK-8026161.js.EXPECTED ! test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java Changeset: a2065f67857c Author: hannesw Date: 2013-10-17 17:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a2065f67857c 8026701: Array.prototype.splice is slow on dense arrays Reviewed-by: lagergren, sundar, jlaskey ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java ! test/examples/array-micro.js + test/script/basic/JDK-8026701.js + test/script/basic/JDK-8026701.js.EXPECTED Changeset: 66d27c77b455 Author: hannesw Date: 2013-10-18 12:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/66d27c77b455 8026805: Array.prototype.length doesn't work as expected Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java + test/script/basic/JDK-8026805.js Changeset: b5b4c98b072b Author: sundar Date: 2013-10-18 18:26 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b5b4c98b072b Merge From alan.bateman at oracle.com Fri Oct 18 15:14:29 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 18 Oct 2013 15:14:29 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131018151520.E42916252E@hg.openjdk.java.net> Changeset: 602aa6fa46c6 Author: alanb Date: 2013-10-18 15:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/602aa6fa46c6 8026876: (fs) Build issue with src/solaris/classes/sun/nio/fs/SolarisUserDefinedFileAttributeView.java Reviewed-by: psandoz ! src/solaris/classes/sun/nio/fs/SolarisUserDefinedFileAttributeView.java Changeset: 93f4f012deaf Author: alanb Date: 2013-10-18 16:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93f4f012deaf Merge From rob.mckenna at oracle.com Fri Oct 18 15:30:13 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Fri, 18 Oct 2013 15:30:13 +0000 Subject: hg: jdk8/tl/jdk: 8024660: TEST_BUG: java/lang/ProcessBuilder/*IOHandle.java leaving hotspot.log open in fastdebug builds Message-ID: <20131018153027.4058E6252F@hg.openjdk.java.net> Changeset: 8d1d5a5aeb41 Author: robm Date: 2013-10-18 16:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d1d5a5aeb41 8024660: TEST_BUG: java/lang/ProcessBuilder/*IOHandle.java leaving hotspot.log open in fastdebug builds Reviewed-by: alanb Contributed-by: pavel.punegov at oracle.com ! test/java/lang/ProcessBuilder/InheritIOEHandle.java ! test/java/lang/ProcessBuilder/SiblingIOEHandle.java From sean.mullan at oracle.com Fri Oct 18 16:36:07 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 18 Oct 2013 12:36:07 -0400 Subject: InvocationTargetException when running applet locally In-Reply-To: <000e01cecc11$da7e8c80$8f7ba580$@segal.org> References: <000e01cecc11$da7e8c80$8f7ba580$@segal.org> Message-ID: <52616377.3070500@oracle.com> On 10/18/2013 10:53 AM, Mickey Segal wrote: > I'm having trouble resolving what you mean by $HOME. I'm used to it meaning on Windows the same thing as the user.home property, which is: > c:\Users\MyUserName\ > but I don't see anything there, even looking with "Hide protected operating system files" disabled. > > Can you help point me in the right direction? On Windows this would typically be \Sun\Java\Deployment\log > > If the log doesn't solve this problem I'd be glad to file a bug report, but unfortunately this came right before we begin 2 weeks of conferences at which we'll be exhibiting all day and not doing any programming. Hopefully we won't be dead in the water in terms of Java working locally. The 7u25 problem also happened right before another major presentation, so this is the second short-deadline crisis we've had with Java updates and such crises are the sort of thing that will get Java a bad reputation with developers. > > If we are using Java 8 build 111 are we safe from forced updates, and can resolve this in a less time pressured environment? I think so, but I'm not positive. Note that this list is used to discuss security topics in the OpenJDK: cryptography, TLS, PKI, Kerberos, etc. It isn't typically used to discuss deployment security topics, although I will try to help as I can. I recommend that you also try the OTN forums, as there are experts on deployment monitoring them and are more likely to be able to help. https://forums.oracle.com/community/developer/english/java/java_desktop/java_plug-in https://forums.oracle.com/community/developer/english/java/java_desktop/java_web_start_%26_jnlp --Sean > > -----Original Message----- > From: security-dev-bounces at openjdk.java.net [mailto:security-dev-bounces at openjdk.java.net] On Behalf Of Sean Mullan > Sent: Friday, October 18, 2013 9:54 AM > > Check the log files in $HOME/.java/deployment/log directory. Perhaps > some messages aren't appearing in the console for some reason. > > Otherwise, I would suggest to please file a bug so we can look into it > further: http://bugs.sun.com/ > > Thanks, > Sean > From java3 at segal.org Fri Oct 18 17:55:33 2013 From: java3 at segal.org (Mickey Segal) Date: Fri, 18 Oct 2013 13:55:33 -0400 Subject: InvocationTargetException when running applet locally In-Reply-To: <52616377.3070500@oracle.com> References: <000e01cecc11$da7e8c80$8f7ba580$@segal.org> <52616377.3070500@oracle.com> Message-ID: <001201cecc2b$3ef61de0$bce259a0$@segal.org> On Windows there is a folder: C:\Users\MyUserName\AppData\LocalLow\Sun\Java\Deployment\log but it is empty. I'm working this up as a bug report. I have a description, a Web version and a zip file to download and try locally at: http://www.segal.org/java/SignedAppletTest/ If anyone has any insights before I file this as a bug report I'd appreciate that. -----Original Message----- From: Sean Mullan Sent: Friday, October 18, 2013 12:36 PM On Windows this would typically be \Sun\Java\Deployment\log From anthony.petrov at oracle.com Fri Oct 18 10:05:50 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 18 Oct 2013 14:05:50 +0400 Subject: Code review request: 7025699: Policy Tool is not accessible by keyboard In-Reply-To: <52601A30.8030401@oracle.com> References: <52589CA1.4080503@oracle.com> <525D304C.9090304@oracle.com> <525D4D75.3090200@oracle.com> <525D70B1.4020603@oracle.com> <525D73C9.2090702@oracle.com> <525D74BD.6070707@oracle.com> <52601713.5020202@oracle.com> <52601A30.8030401@oracle.com> Message-ID: <526107FE.8050301@oracle.com> +1 -- best regards, Anthony On 10/17/2013 09:11 PM, alexander potochkin wrote: > Hello Leif > > Looks good to me > > I had a look at the PolicyTool code > and indeed it is better to leave the IO processing as is at this moment. > > Thanks > alexp > >> Hi All, >> >> A new webrev is available at: >> >> http://cr.openjdk.java.net/~weijun/7025699/webrev.01/ >> >> The following new changes were made: >> >> 1. Added call to SwingUtilities.invokeLater() in main() to run the GUI >> initialization on the Event Dispatch Thread. >> >> 2. Minor corrections to initial size and placement of the main window. >> >> 3. More mnemonics defined for buttons and labeled fields on the Policy >> Entry and KeyStore dialogs. >> >> Note that we have decided to not implement the use of SwingWorker for >> File I/O in this release. The main reasons are that it is not covered >> in the scope of the bug report, the blocking can not actually be >> considered a regression compared to the AWT version, and it would >> require enough refactoring of the code to risk affecting the general >> logic and cause new bugs. >> >> I am the Contributor for this bug fix, and Max (Weijun) will be the >> Committer. >> >> Thanks, >> Leif >> >> >> >> On 2013-10-15 10:00, Leif Samuelsson wrote: >>> Thanks for the good feedback. We will make sure to move to move the >>> GUI instantiation to the EDT and the file I/O to a worker thread. >>> >>> All other operations are event driven and therefore occur directly >>> on the EDT. >>> >>> Leif >>> >>> >>> On 2013-10-15 09:56, alexander potochkin wrote: >>>> Hello >>>> >>>>> Well, performing I/O or other blocking operations on EDT can only >>>>> freeze the app's GUI for the period of blocking. If >>>>> developers/users are OK with that, this is fine with me too. >>>>> >>>> >>>> I don't think an I/O blocking operation on EDT is acceptable. It can >>>> freeze the whole application and give a bad experience to the users. >>>> Please consider using the SwingWorker API >>>> http://docs.oracle.com/javase/tutorial/uiswing/concurrency/worker.html >>>> >>>> >>>>> However, you should still call all Swing APIs (including creating >>>>> your components/windows) on the EDT. And I don't see this is being >>>>> done in your current code. As a minimum, the displayToolWindow() >>>>> method should be dispatched on the event thread. I haven't examined >>>>> the code closely, but if there are any other GUI updates from >>>>> separate threads, those should also be moved to the EDT. See the >>>>> following tutorial for details: >>>>> >>>>> http://docs.oracle.com/javase/tutorial/uiswing/concurrency/dispatch.html >>>>> >>>>> >>>> >>>> Indeed, rewriting an AWT app as a Swing app is not only about >>>> changing Labels to JLabels >>>> Please make sure that all Swing code are used on the event >>>> dispatching thread only. >>>> >>>> Thanks >>>> alexp >>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 10/15/2013 06:13 PM, Weijun Wang wrote: >>>>>> Policy Tool is a GUI editor for the plain text policy file. The >>>>>> only I/O >>>>>> is loading the policy file from disk and it should be quite small, >>>>>> so I >>>>>> think there won't be a problem here. >>>>>> >>>>>> Thanks >>>>>> Max >>>>>> >>>>>> On 10/15/13 8:08 PM, Anthony Petrov wrote: >>>>>>> Hi Max, >>>>>>> >>>>>>> I don't have expertise in this code so I haven't reviewed the fix >>>>>>> thoroughly. I'd like to point out one thing though: unlike AWT, >>>>>>> Swing is >>>>>>> a single-threaded GUI toolkit. While in AWT you can create >>>>>>> components/windows and call APIs on any thread, in Swing everything >>>>>>> GUI-related must be performed on the Event Dispatch Thread (EDT) >>>>>>> only. >>>>>>> Any long, non-GUI-related operations (like I/O, computations, etc.) >>>>>>> should be dispatched on other threads (with a SwingWorker, for >>>>>>> example). >>>>>>> >>>>>>> I don't see a single SwingUtilities.invokeLater/invokeAndWait() >>>>>>> call in >>>>>>> PolicyTool.java, so I thought I'd ask whether you're aware of the >>>>>>> threading limitations imposed by Swing and how those are going to be >>>>>>> addressed? >>>>>>> >>>>>>> -- >>>>>>> best regards, >>>>>>> Anthony >>>>>>> >>>>>>> On 10/12/2013 04:49 AM, Weijun Wang wrote: >>>>>>>> Hi All >>>>>>>> >>>>>>>> Please review the fix at >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~weijun/7025699/webrev.00/ >>>>>>>> >>>>>>>> The fix includes porting PolicyTool from AWT to Swing, defining >>>>>>>> mnemonics for menu items and buttons, and adding keyboard >>>>>>>> shortcuts for >>>>>>>> the File -> New/Open/Save items. Several tests are updated also. >>>>>>>> >>>>>>>> Thanks >>>>>>>> Max >>>> > From shanliang.jiang at oracle.com Fri Oct 18 14:16:51 2013 From: shanliang.jiang at oracle.com (shanliang.jiang at oracle.com) Date: Fri, 18 Oct 2013 14:16:51 +0000 Subject: hg: jdk8/tl/jdk: 8026028: [findbugs] findbugs report some issue in com.sun.jmx.snmp package Message-ID: <20131018141711.BB89162528@hg.openjdk.java.net> Changeset: 4161f17dfe2b Author: sjiang Date: 2013-10-18 16:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4161f17dfe2b 8026028: [findbugs] findbugs report some issue in com.sun.jmx.snmp package Reviewed-by: psandoz, dfuchs ! src/share/classes/com/sun/jmx/snmp/SnmpString.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMib.java ! src/share/classes/com/sun/jmx/snmp/daemon/CommunicatorServer.java + test/com/sun/jmx/snmp/NoInfoLeakTest.java From sean.mullan at oracle.com Fri Oct 18 19:44:08 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 18 Oct 2013 15:44:08 -0400 Subject: Code Review Request: 8025763 In-Reply-To: <52606140.1060204@oracle.com> References: <52606140.1060204@oracle.com> Message-ID: <52618F88.5000803@oracle.com> Mostly looks good, just a few comments: - for completeness, please add @Override tags to all existing methods that are overridden - you need to also override the new forEach and getOrDefault methods to first check if the provider is initialized. See, for example, the get method. - nit, say either "security manager" or "Security Manager" but not both. I would probably use the former since it was used already throughout. - line 429, replace should be synchronized - For the methods that require both put and remove permissions, can you tweak the wording to say: "... to see if it's ok to set this provider's property values and remove this provider's properties." and "... denies access to set property values or remove properties." - lines 681-684. I think this should call checkLegacy() like the other impl methods otherwise legacyStrings might be null and throw an NPE. - line 733,787 remove indentation and align - line 749-750, shouldn't that be legacyStrings.compute and BiFunction? --Sean On 10/17/2013 06:14 PM, Anthony Scarpino wrote: > Hi, > > I need a code review for changes regarding > 8025763 Provider does not override new Hashtable methods > > http://cr.openjdk.java.net/~ascarpino/8025763/ > > thanks > > Tony From bernd-2013 at eckenfels.net Fri Oct 18 20:10:41 2013 From: bernd-2013 at eckenfels.net (Bernd Eckenfels) Date: Fri, 18 Oct 2013 22:10:41 +0200 Subject: InvocationTargetException when running applet locally Message-ID: Am 18.10.2013, 19:55 Uhr, schrieb Mickey Segal : > I'm working this up as a bug report. I have a description, a Web > version and a zip file to download and try locally at: > http://www.segal.org/java/SignedAppletTest/ I get this in the detail view: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException at sun.plugin2.applet.Plugin2ClassLoader.defineClassHelper(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader.access$100(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader$2.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at sun.plugin2.applet.Plugin2ClassLoader.findClassHelper(Unknown Source) at sun.plugin2.applet.Applet2ClassLoader.findClass(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader.loadClass0(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader.loadClass(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader.loadCode(Unknown Source) at sun.plugin2.applet.Plugin2Manager.initAppletAdapter(Unknown Source) at sun.plugin2.applet.Plugin2Manager$AppletExecutionRunnable.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) ... 14 more Caused by: java.lang.NullPointerException at sun.plugin2.applet.Plugin2ClassLoader.loadAllowedCodebases(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader.getPermissions(Unknown Source) at sun.plugin2.applet.Applet2ClassLoader.getPermissions(Unknown Source) at java.security.SecureClassLoader.getProtectionDomain(Unknown Source) at java.security.SecureClassLoader.defineClass(Unknown Source) at java.net.URLClassLoader.defineClass(Unknown Source) ... 18 more I got a warning (before the crash) that the permissions settings is missing and this might not work in future versions. But it is in the JAR (and I added to the applet tag) and it did not help. This version is really bad :-/ Bernd -- http://bernd.eckenfels.net From dmitry.samersoff at oracle.com Fri Oct 18 20:08:15 2013 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Fri, 18 Oct 2013 20:08:15 +0000 Subject: hg: jdk8/tl/jdk: 8004213: JDP packet needs pid, broadcast interval and rmi server hostname fields Message-ID: <20131018200958.8668062548@hg.openjdk.java.net> Changeset: 88436832cfd0 Author: dsamersoff Date: 2013-10-19 00:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88436832cfd0 8004213: JDP packet needs pid, broadcast interval and rmi server hostname fields Summary: Add some extra fileds to jdp packet Reviewed-by: allwin, sla, hirt ! src/share/classes/sun/management/jdp/JdpController.java ! src/share/classes/sun/management/jdp/JdpJmxPacket.java ! test/sun/management/jdp/JdpClient.java ! test/sun/management/jdp/JdpDoSomething.java ! test/sun/management/jdp/JdpTest.sh From java3 at segal.org Fri Oct 18 20:44:24 2013 From: java3 at segal.org (Mickey Segal) Date: Fri, 18 Oct 2013 16:44:24 -0400 Subject: InvocationTargetException when running applet locally In-Reply-To: References: Message-ID: <000901cecc42$d5225d30$7f671790$@segal.org> Thanks. I didn't know that some Exceptions were not visible until the trace level was set higher. There is nothing here that jumps out to me as something that I can fix, so I will go ahead and file the bug report. I'll probably wait a day in case anyone else has something important to add. Workarounds are welcome at any time, though. It would be nice to have the ability to add comments to a bug report as we did in the Sun era, since then one could add useful information later. But at least I can post updates to my version at http://www.segal.org/java/SignedAppletTest/ and reference that in the bug report, allowing both the Oracle people and those doing Web searches to find the problem. -----Original Message----- From: Bernd Eckenfels [mailto:bernd-2013 at eckenfels.net] Sent: Friday, October 18, 2013 4:11 PM I get this in the detail view: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException at sun.plugin2.applet.Plugin2ClassLoader.defineClassHelper(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader.access$100(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader$2.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at sun.plugin2.applet.Plugin2ClassLoader.findClassHelper(Unknown Source) at sun.plugin2.applet.Applet2ClassLoader.findClass(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader.loadClass0(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader.loadClass(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader.loadClass(Unknown Source) at java.lang.ClassLoader.loadClass(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader.loadCode(Unknown Source) at sun.plugin2.applet.Plugin2Manager.initAppletAdapter(Unknown Source) at sun.plugin2.applet.Plugin2Manager$AppletExecutionRunnable.run(Unknown Source) at java.lang.Thread.run(Unknown Source) Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) ... 14 more Caused by: java.lang.NullPointerException at sun.plugin2.applet.Plugin2ClassLoader.loadAllowedCodebases(Unknown Source) at sun.plugin2.applet.Plugin2ClassLoader.getPermissions(Unknown Source) at sun.plugin2.applet.Applet2ClassLoader.getPermissions(Unknown Source) at java.security.SecureClassLoader.getProtectionDomain(Unknown Source) at java.security.SecureClassLoader.defineClass(Unknown Source) at java.net.URLClassLoader.defineClass(Unknown Source) ... 18 more I got a warning (before the crash) that the permissions settings is missing and this might not work in future versions. But it is in the JAR (and I added to the applet tag) and it did not help. This version is really bad :-/ From bernd-2013 at eckenfels.net Fri Oct 18 21:13:11 2013 From: bernd-2013 at eckenfels.net (Bernd Eckenfels) Date: Fri, 18 Oct 2013 23:13:11 +0200 Subject: InvocationTargetException when running applet locally Message-ID: Am 18.10.2013, 22:44 Uhr, schrieb Mickey Segal : > There is nothing here that jumps out to me as something that I can fix, > so I will go ahead and file the bug report. I'll probably wait a day in > case anyone else has something important to add. Yes, looks like a Java bug. One thing you could try is to read the property in the init() method instead of the AWT callback. Or you try it inside a periveledged context. (Sorry for not trying it myself but you have the signing infrastructure set up, so... :) > It would be nice to have the ability to add comments to a bug report as > we did in the Sun era, since then one could add useful information > later. But at least I can post updates to my version at > http://www.segal.org/java/SignedAppletTest/ and reference that in the > bug report, allowing both the Oracle people and those doing Web searches > to find the problem. Even in the Sun area it was hard to discuss on those bugs. I think it was never really intended to. BTW: I tollay agree. Java "security" "updates" broke appications for us multiple times as well. We will never ever consider to use JNLP (Appler/WebStart) again. Luckily HTML has become much more powerfull lately. This "situation" (and I dont blame Oracle it started in sun times) really kills Java on the Desktop. Gruss Bernd -- http://bernd.eckenfels.net From sean.mullan at oracle.com Fri Oct 18 21:24:10 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 18 Oct 2013 17:24:10 -0400 Subject: [8] Review Request for 8021191: Add isAuthorized check to limited doPrivileged methods Message-ID: <5261A6FA.8000405@oracle.com> Please review this change to the limited doPrivileged methods to check that the passed-in access control context is authorized before using. http://cr.openjdk.java.net/~mullan/webrevs/8021191/webrev.00/ Thanks, Sean From roger.riggs at oracle.com Fri Oct 18 21:34:27 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Fri, 18 Oct 2013 21:34:27 +0000 Subject: hg: jdk8/tl/jdk: 8025828: Late binding of Chronology to appendValueReduced Message-ID: <20131018213445.AC1EB6254C@hg.openjdk.java.net> Changeset: 7a947daa8f51 Author: rriggs Date: 2013-10-18 16:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a947daa8f51 8025828: Late binding of Chronology to appendValueReduced Summary: Add a listener to the parseContext called when the Chronology changes Reviewed-by: sherman ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! test/java/time/test/java/time/format/TestReducedParser.java From jonathan.gibbons at oracle.com Fri Oct 18 22:05:43 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 18 Oct 2013 22:05:43 +0000 Subject: hg: jdk8/tl/langtools: 8026749: Missing LV table in lambda bodies Message-ID: <20131018220557.096896254E@hg.openjdk.java.net> Changeset: 7de97abc4a5c Author: jjg Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de97abc4a5c 8026749: Missing LV table in lambda bodies Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/lambda/LocalVariableTable.java From bhavesh.x.patel at oracle.com Fri Oct 18 23:35:50 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Fri, 18 Oct 2013 23:35:50 +0000 Subject: hg: jdk8/tl/langtools: 8026567: Use meaningful style names for strong and italic styles. Message-ID: <20131018233556.27B2E6255C@hg.openjdk.java.net> Changeset: 130b8c0e570e Author: bpatel Date: 2013-10-18 16:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/130b8c0e570e 8026567: Use meaningful style names for strong and italic styles. Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeFieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfileWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/testAnnotationTypes/TestAnnotationTypes.java ! test/com/sun/javadoc/testClassCrossReferences/TestClassCrossReferences.java ! test/com/sun/javadoc/testClassTree/TestClassTree.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testDeprecatedDocs/TestDeprecatedDocs.java ! test/com/sun/javadoc/testExternalOverridenMethod/TestExternalOverridenMethod.java ! test/com/sun/javadoc/testHref/TestHref.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testHtmlStrongTag/TestHtmlStrongTag.java ! test/com/sun/javadoc/testIndex/TestIndex.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testLegacyTaglet/Check.java ! test/com/sun/javadoc/testLinkOption/TestLinkOption.java ! test/com/sun/javadoc/testMemberInheritence/TestMemberInheritence.java ! test/com/sun/javadoc/testMemberSummary/TestMemberSummary.java ! test/com/sun/javadoc/testNavigation/TestNavigation.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenMethodDocCopy.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethods.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPackageFlag.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPrivateFlag.java ! test/com/sun/javadoc/testPackageDeprecation/TestPackageDeprecation.java ! test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java ! test/com/sun/javadoc/testProfiles/TestProfilesConfiguration.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSimpleTag/TestSimpleTag.java ! test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java ! test/com/sun/javadoc/testSinceTag/TestSinceTag.java ! test/com/sun/javadoc/testTagOutput/TestTagOutput.java ! test/com/sun/javadoc/testTaglets/TestTaglets.java ! test/com/sun/javadoc/testTaglets/taglets/Foo.java ! test/com/sun/javadoc/testThrowsHead/TestThrowsHead.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java From anthony.scarpino at oracle.com Sat Oct 19 02:52:21 2013 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Fri, 18 Oct 2013 19:52:21 -0700 Subject: Code Review Request: 8025763 In-Reply-To: <52618F88.5000803@oracle.com> References: <52606140.1060204@oracle.com> <52618F88.5000803@oracle.com> Message-ID: <5261F3E5.9060409@oracle.com> On 10/18/2013 12:44 PM, Sean Mullan wrote: > Mostly looks good, just a few comments: > > - for completeness, please add @Override tags to all existing methods > that are overridden > > - you need to also override the new forEach and getOrDefault methods to > first check if the provider is initialized. See, for example, the get > method. > > - nit, say either "security manager" or "Security Manager" but not both. > I would probably use the former since it was used already throughout. > > - line 429, replace should be synchronized > > - For the methods that require both put and remove permissions, can you > tweak the wording to say: > > "... to see if it's ok to set this provider's property values and > remove this provider's properties." > > and > > "... denies access to set property values or remove properties." no problem with all the above > > - lines 681-684. I think this should call checkLegacy() like the other > impl methods otherwise legacyStrings might be null and throw an NPE. That was a mistake where I should have had checkLegacy() > > - line 733,787 remove indentation and align Not sure how they got indented, that strange > > - line 749-750, shouldn't that be legacyStrings.compute and BiFunction? Whoops.. That's got cut-n-paste written all over it I've updated the webrev http://cr.openjdk.java.net/~ascarpino/8025763/webrev.01/ > > --Sean > > On 10/17/2013 06:14 PM, Anthony Scarpino wrote: >> Hi, >> >> I need a code review for changes regarding >> 8025763 Provider does not override new Hashtable methods >> >> http://cr.openjdk.java.net/~ascarpino/8025763/ >> >> thanks >> >> Tony > From vicente.romero at oracle.com Sat Oct 19 16:55:15 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sat, 19 Oct 2013 16:55:15 +0000 Subject: hg: jdk8/tl/jdk: 8026854: java.time.temporal.TemporalQueries doesn't compile after javac modification to lambda flow analysis Message-ID: <20131019165527.959BC6256F@hg.openjdk.java.net> Changeset: fbb7510f788d Author: vromero Date: 2013-10-19 17:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fbb7510f788d 8026854: java.time.temporal.TemporalQueries doesn't compile after javac modification to lambda flow analysis Reviewed-by: psandoz ! src/share/classes/java/time/temporal/TemporalQueries.java From vicente.romero at oracle.com Sat Oct 19 16:58:11 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sat, 19 Oct 2013 16:58:11 +0000 Subject: hg: jdk8/tl/langtools: 8024809: javac, some lambda programs are rejected by flow analysis Message-ID: <20131019165814.CA79E62570@hg.openjdk.java.net> Changeset: c4292590fc70 Author: vromero Date: 2013-10-19 17:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c4292590fc70 8024809: javac, some lambda programs are rejected by flow analysis Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! test/tools/javac/lambda/8016081/T8016081.java ! test/tools/javac/lambda/LambdaExpr13.java + test/tools/javac/lambda/T8024809/SelfInitializerInLambdaTesta.java + test/tools/javac/lambda/T8024809/SelfInitializerInLambdaTesta.out + test/tools/javac/lambda/T8024809/SelfInitializerInLambdaTestb.java + test/tools/javac/lambda/T8024809/SelfInitializerInLambdaTestb.out ! test/tools/javac/lambda/TestSelfRef.java From dmitry.samersoff at oracle.com Sat Oct 19 17:03:18 2013 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Sat, 19 Oct 2013 17:03:18 +0000 Subject: hg: jdk8/tl/jdk: 8024071: In ManagementAgent.start it should be possible to set the jdp.name parameter. Message-ID: <20131019170333.8A13962571@hg.openjdk.java.net> Changeset: 392acefef659 Author: dsamersoff Date: 2013-10-19 20:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/392acefef659 8024071: In ManagementAgent.start it should be possible to set the jdp.name parameter. Summary: Pass one more property from Agent to JdpController Reviewed-by: jbachorik, sla ! src/share/classes/sun/management/Agent.java ! test/sun/management/jdp/JdpTest.sh ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh From kumar.x.srinivasan at oracle.com Sat Oct 19 22:22:37 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Sat, 19 Oct 2013 22:22:37 +0000 Subject: hg: jdk8/tl/jdk: 8026794: Test tools/pack200/TimeStamp.java fails while opening golden.jar.native.IST on linux-ppc(v2) Message-ID: <20131019222421.9D33C62574@hg.openjdk.java.net> Changeset: ede89a97e80a Author: ksrini Date: 2013-10-19 15:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ede89a97e80a 8026794: Test tools/pack200/TimeStamp.java fails while opening golden.jar.native.IST on linux-ppc(v2) Reviewed-by: dholmes ! src/share/native/com/sun/java/util/jar/pack/zip.cpp From java3 at segal.org Sun Oct 20 01:55:04 2013 From: java3 at segal.org (Mickey Segal) Date: Sat, 19 Oct 2013 21:55:04 -0400 Subject: Can't even file a bug report for: InvocationTargetException when running applet locally Message-ID: <000e01cecd37$66221c90$326655b0$@segal.org> I just tried twice to submit the bug documented at http://www.segal.org/java/SignedAppletTest/. I got a Submission Error page. I was told: We recommend opening a new report in a new window, and copying the contents of the original report to the new report. (Use the browser "Back" button to see the contents of the original report.) However, the second submission failed too and clicking the back button gives a ?Page expired? message, and trying to save the page in the browser fails, and it is annoying because I need to collect information from two different computers to document the previous working version. I?m trying to be as constructive as possible here, but there are 3 levels of error here: 1. The original bug 2. The failure of the bug report system. 3. The directions on the Submission Error page are incorrect. Is there some workaround to getting the Java bug report system to work? -------------- next part -------------- An HTML attachment was scrubbed... URL: From java3 at segal.org Sun Oct 20 02:01:06 2013 From: java3 at segal.org (Mickey Segal) Date: Sat, 19 Oct 2013 22:01:06 -0400 Subject: Can't even file a bug report for: InvocationTargetException when running applet locally Message-ID: <001901cecd38$3d5ef8e0$b81ceaa0$@segal.org> It is even worse than I thought. There is a 4th level of error. The email address given for reporting the bug reporting system not working bounces as ?User unknown?. From: Mickey Segal [mailto:java3 at segal.org] Sent: Saturday, October 19, 2013 9:55 PM To: 'Sean Mullan' Cc: 'security-dev at openjdk.java.net' Subject: Can't even file a bug report for: InvocationTargetException when running applet locally I just tried twice to submit the bug documented at http://www.segal.org/java/SignedAppletTest/. I got a Submission Error page. I was told: We recommend opening a new report in a new window, and copying the contents of the original report to the new report. (Use the browser "Back" button to see the contents of the original report.) However, the second submission failed too and clicking the back button gives a ?Page expired? message, and trying to save the page in the browser fails, and it is annoying because I need to collect information from two different computers to document the previous working version. I?m trying to be as constructive as possible here, but there are 3 levels of error here: 1. The original bug 2. The failure of the bug report system. 3. The directions on the Submission Error page are incorrect. Is there some workaround to getting the Java bug report system to work? -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.gibbons at oracle.com Sun Oct 20 19:05:49 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sun, 20 Oct 2013 19:05:49 +0000 Subject: hg: jdk8/tl/langtools: 8025109: Better encapsulation for AnnotatedType Message-ID: <20131020190557.63EAE6258F@hg.openjdk.java.net> Changeset: e5d3cd43c85e Author: jjg Date: 2013-10-20 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e5d3cd43c85e 8025109: Better encapsulation for AnnotatedType Reviewed-by: jjg Contributed-by: wdietl at gmail.com ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java From jonathan.gibbons at oracle.com Sun Oct 20 19:47:52 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sun, 20 Oct 2013 19:47:52 +0000 Subject: hg: jdk8/tl/langtools: 8026791: wrong type_path encoded for method_return on an inner class constructor Message-ID: <20131020194755.500B662595@hg.openjdk.java.net> Changeset: ae4f5cb78ebd Author: jjg Date: 2013-10-20 12:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ae4f5cb78ebd 8026791: wrong type_path encoded for method_return on an inner class constructor Reviewed-by: jjg Contributed-by: wdietl at gmail.com ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java From kumar.x.srinivasan at oracle.com Sun Oct 20 19:56:05 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Sun, 20 Oct 2013 19:56:05 +0000 Subject: hg: jdk8/tl/langtools: 8026931: MethodParameters tests failing on Windows Message-ID: <20131020195608.29A9E62597@hg.openjdk.java.net> Changeset: 399c738e5103 Author: ksrini Date: 2013-10-20 12:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/399c738e5103 8026931: MethodParameters tests failing on Windows Reviewed-by: jjg, vromero ! test/tools/javac/MethodParameters/Tester.java From robert.field at oracle.com Mon Oct 21 01:09:08 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Mon, 21 Oct 2013 01:09:08 +0000 Subject: hg: jdk8/tl/jdk: 8025631: Enhance Lambda construction Message-ID: <20131021010923.9665062599@hg.openjdk.java.net> Changeset: 71ecbde5e5e4 Author: rfield Date: 2013-10-20 18:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71ecbde5e5e4 8025631: Enhance Lambda construction Reviewed-by: ksrini, ahgross ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java - src/share/classes/java/lang/invoke/MagicLambdaImpl.java From sundararajan.athijegannathan at oracle.com Mon Oct 21 07:42:36 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Mon, 21 Oct 2013 07:42:36 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20131021074241.09385625A1@hg.openjdk.java.net> Changeset: d8aa87d292eb Author: hannesw Date: 2013-10-18 22:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d8aa87d292eb 8026858: Array length does not handle defined properties correctly Reviewed-by: jlaskey ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8026858.js Changeset: 612886fe324d Author: sundar Date: 2013-10-21 10:09 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/612886fe324d Merge From daniel.fuchs at oracle.com Mon Oct 21 09:18:54 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Mon, 21 Oct 2013 09:18:54 +0000 Subject: hg: jdk8/tl/jdk: 8016344: (props) Properties.storeToXML behaviour has changed from JDK 6 to 7 Message-ID: <20131021091921.77D07625A7@hg.openjdk.java.net> Changeset: 567d47fd3fe2 Author: dfuchs Date: 2013-10-21 11:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/567d47fd3fe2 8016344: (props) Properties.storeToXML behaviour has changed from JDK 6 to 7 Summary: When storing Properties to XML only locally defined properties must be saved. Reviewed-by: psandoz, mchung, alanb ! src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java ! src/share/classes/sun/util/xml/PlatformXmlPropertiesProvider.java + test/java/util/Properties/LoadAndStoreXMLWithDefaults.java From daniel.fuchs at oracle.com Mon Oct 21 10:07:31 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Mon, 21 Oct 2013 10:07:31 +0000 Subject: hg: jdk8/tl/jdk: 8026499: Root Logger level can be reset unexpectedly Message-ID: <20131021100830.7177E625B0@hg.openjdk.java.net> Changeset: c81125493ca6 Author: dfuchs Date: 2013-10-21 12:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c81125493ca6 8026499: Root Logger level can be reset unexpectedly Summary: This fix prevents the logger's level to be re-initialized if it has already been initialized. Reviewed-by: mchung ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java From vicente.romero at oracle.com Mon Oct 21 14:58:20 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Mon, 21 Oct 2013 14:58:20 +0000 Subject: hg: jdk8/tl/langtools: 8026956: test tools/javac/lambda/TargetType58.java is failing after a libs change Message-ID: <20131021145825.D37E9625BF@hg.openjdk.java.net> Changeset: 9f876bd43f55 Author: vromero Date: 2013-10-21 15:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f876bd43f55 8026956: test tools/javac/lambda/TargetType58.java is failing after a libs change Reviewed-by: jfranck ! test/tools/javac/lambda/TargetType58.java From sean.mullan at oracle.com Mon Oct 21 18:38:43 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 21 Oct 2013 14:38:43 -0400 Subject: InvocationTargetException when running applet locally In-Reply-To: <000901cecc42$d5225d30$7f671790$@segal.org> References: <000901cecc42$d5225d30$7f671790$@segal.org> Message-ID: <526574B3.2010201@oracle.com> I think this is a known issue. There is a workaround documented in the JDK 7u45 release notes, can you try it out? See "JNLP applet fails to load if using JNLP versioning.": http://www.oracle.com/technetwork/java/javase/7u45-relnotes-2016950.html --Sean On 10/18/2013 04:44 PM, Mickey Segal wrote: > Thanks. I didn't know that some Exceptions were not visible until the trace level was set higher. > > There is nothing here that jumps out to me as something that I can fix, so I will go ahead and file the bug report. I'll probably wait a day in case anyone else has something important to add. > > Workarounds are welcome at any time, though. > > It would be nice to have the ability to add comments to a bug report as we did in the Sun era, since then one could add useful information later. But at least I can post updates to my version at http://www.segal.org/java/SignedAppletTest/ and reference that in the bug report, allowing both the Oracle people and those doing Web searches to find the problem. > > -----Original Message----- > From: Bernd Eckenfels [mailto:bernd-2013 at eckenfels.net] > Sent: Friday, October 18, 2013 4:11 PM > > I get this in the detail view: > > java.lang.RuntimeException: java.lang.reflect.InvocationTargetException > at sun.plugin2.applet.Plugin2ClassLoader.defineClassHelper(Unknown Source) > at sun.plugin2.applet.Plugin2ClassLoader.access$100(Unknown Source) > at sun.plugin2.applet.Plugin2ClassLoader$2.run(Unknown Source) > at java.security.AccessController.doPrivileged(Native Method) > at sun.plugin2.applet.Plugin2ClassLoader.findClassHelper(Unknown Source) > at sun.plugin2.applet.Applet2ClassLoader.findClass(Unknown Source) > at sun.plugin2.applet.Plugin2ClassLoader.loadClass0(Unknown Source) > at sun.plugin2.applet.Plugin2ClassLoader.loadClass(Unknown Source) > at sun.plugin2.applet.Plugin2ClassLoader.loadClass(Unknown Source) > at java.lang.ClassLoader.loadClass(Unknown Source) > at sun.plugin2.applet.Plugin2ClassLoader.loadCode(Unknown Source) > at sun.plugin2.applet.Plugin2Manager.initAppletAdapter(Unknown Source) > at sun.plugin2.applet.Plugin2Manager$AppletExecutionRunnable.run(Unknown > Source) > at java.lang.Thread.run(Unknown Source) > Caused by: java.lang.reflect.InvocationTargetException > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) > at java.lang.reflect.Method.invoke(Unknown Source) > ... 14 more > Caused by: java.lang.NullPointerException > at sun.plugin2.applet.Plugin2ClassLoader.loadAllowedCodebases(Unknown > Source) > at sun.plugin2.applet.Plugin2ClassLoader.getPermissions(Unknown Source) > at sun.plugin2.applet.Applet2ClassLoader.getPermissions(Unknown Source) > at java.security.SecureClassLoader.getProtectionDomain(Unknown Source) > at java.security.SecureClassLoader.defineClass(Unknown Source) > at java.net.URLClassLoader.defineClass(Unknown Source) > ... 18 more > > > I got a warning (before the crash) that the permissions settings is > missing and this might not work in future versions. But it is in the JAR > (and I added to the applet tag) and it did not help. This version is > really bad :-/ > From xueming.shen at oracle.com Mon Oct 21 18:18:35 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Mon, 21 Oct 2013 18:18:35 +0000 Subject: hg: jdk8/tl/jdk: 8026842: Remove Time-Zone IDs HST/EST/MST Message-ID: <20131021181901.2D1B9625C7@hg.openjdk.java.net> Changeset: f0c18a5e3ae5 Author: sherman Date: 2013-10-21 11:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0c18a5e3ae5 8026842: Remove Time-Zone IDs HST/EST/MST Summary: removed these ids from ZoneId's zid list, supported via short_ids list Reviewed-by: okutsu ! make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java From joe.darcy at oracle.com Mon Oct 21 19:55:04 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 21 Oct 2013 19:55:04 +0000 Subject: hg: jdk8/tl/jdk: 8022658: Revisit FunctionalInterface on some core libs types Message-ID: <20131021195523.7A5B7625CB@hg.openjdk.java.net> Changeset: c1700125d041 Author: darcy Date: 2013-10-21 12:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1700125d041 8022658: Revisit FunctionalInterface on some core libs types Reviewed-by: briangoetz, mduigou, mr ! src/share/classes/java/io/Closeable.java ! src/share/classes/java/io/Flushable.java ! src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/java/lang/Comparable.java ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/lang/Readable.java From yuka.kamiya at oracle.com Mon Oct 21 21:15:42 2013 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Mon, 21 Oct 2013 21:15:42 +0000 Subject: hg: jdk8/tl/jdk: 8020037: String.toLowerCase incorrectly increases length, if string contains \u0130 char Message-ID: <20131021211555.660D0625CD@hg.openjdk.java.net> Changeset: e8683d5b2b0a Author: peytoia Date: 2013-10-22 06:13 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8683d5b2b0a 8020037: String.toLowerCase incorrectly increases length, if string contains \u0130 char Reviewed-by: naoto ! src/share/classes/java/lang/ConditionalSpecialCasing.java ! src/share/classes/java/lang/String.java ! test/java/lang/String/ToLowerCase.java From vincent.x.ryan at oracle.com Mon Oct 21 21:36:47 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Mon, 21 Oct 2013 22:36:47 +0100 Subject: [8] 8012636: OCSP validation fails even when public key is trusted Message-ID: <52659E6F.7020806@oracle.com> Please review this fix to support key-rollover certs (same name, different keys): Bug: https://bugs.openjdk.java.net/browse/JDK-8012636 Webrev: http://cr.openjdk.java.net/~vinnie/8012636/webrev.00/ This issue arises when an OCSP responder replaces its public key but retains its subject name. The OCSP client must be able to validate responses signed by both keys. Thanks. From karen.kinnear at oracle.com Sun Oct 20 03:57:06 2013 From: karen.kinnear at oracle.com (karen.kinnear at oracle.com) Date: Sun, 20 Oct 2013 03:57:06 +0000 Subject: hg: jdk8/tl/hotspot: 8026893: Push 8026365 to TL early and add test Message-ID: <20131020035724.7665D62581@hg.openjdk.java.net> Changeset: e39b138b2518 Author: acorn Date: 2013-10-19 18:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e39b138b2518 8026893: Push 8026365 to TL early and add test Reviewed-by: dcubed, kamg ! src/share/vm/classfile/verifier.cpp ! test/TEST.groups + test/runtime/8026365/InvokeSpecialAnonTest.java From jaroslav.bachorik at oracle.com Mon Oct 21 08:51:42 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Mon, 21 Oct 2013 08:51:42 +0000 Subject: hg: jdk8/tl/jdk: 7197919: java/lang/management/ThreadMXBean/ThreadBlockedCount.java has concurency issues Message-ID: <20131021085242.BFA25625A4@hg.openjdk.java.net> Changeset: 30c46debdf0f Author: jbachorik Date: 2013-10-21 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30c46debdf0f 7197919: java/lang/management/ThreadMXBean/ThreadBlockedCount.java has concurency issues Reviewed-by: sla, mchung ! test/java/lang/management/ThreadMXBean/ThreadBlockedCount.java From jaroslav.bachorik at oracle.com Mon Oct 21 08:56:56 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Mon, 21 Oct 2013 08:56:56 +0000 Subject: hg: jdk8/tl/jdk: 8024613: javax/management/remote/mandatory/connection/RMIConnector_NPETest.java failing intermittently Message-ID: <20131021085715.40CD9625A5@hg.openjdk.java.net> Changeset: d8694ad1ed2d Author: jbachorik Date: 2013-10-21 10:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8694ad1ed2d 8024613: javax/management/remote/mandatory/connection/RMIConnector_NPETest.java failing intermittently Summary: RMID needs a varying amount of time to start its socket server. We need to cater for it. Reviewed-by: sjiang, dfuchs, sla ! test/javax/management/remote/mandatory/connection/RMIConnector_NPETest.java From jaroslav.bachorik at oracle.com Mon Oct 21 11:59:53 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Mon, 21 Oct 2013 11:59:53 +0000 Subject: hg: jdk8/tl/jdk: 7140929: NotSerializableNotifTest.java fails intermittently Message-ID: <20131021120131.16C9B625B2@hg.openjdk.java.net> Changeset: 698baf22e081 Author: jbachorik Date: 2013-10-21 13:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/698baf22e081 7140929: NotSerializableNotifTest.java fails intermittently Reviewed-by: sjiang, alanb ! test/javax/management/remote/mandatory/notif/NotSerializableNotifTest.java From konstantin.shefov at oracle.com Mon Oct 21 09:39:45 2013 From: konstantin.shefov at oracle.com (konstantin.shefov at oracle.com) Date: Mon, 21 Oct 2013 09:39:45 +0000 Subject: hg: jdk8/tl/nashorn: 8026871: NASHORN TEST: Enable possibility to test Nashorn use of JavaFX canvas. Message-ID: <20131021094010.A0FC4625A9@hg.openjdk.java.net> Changeset: f22742d5daa3 Author: kshefov Date: 2013-10-21 13:31 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f22742d5daa3 8026871: NASHORN TEST: Enable possibility to test Nashorn use of JavaFX canvas. Reviewed-by: jlaskey, sundar ! make/build.xml ! make/project.properties + test/script/jfx.js + test/script/jfx/flyingimage.js + test/script/jfx/flyingimage/flyingimage.png + test/script/jfx/flyingimage/golden/linux.png + test/script/jfx/flyingimage/golden/macosx.png + test/script/jfx/flyingimage/golden/windows.png + test/script/jfx/kaleidoscope.js + test/script/jfx/kaleidoscope/golden/linux.png + test/script/jfx/kaleidoscope/golden/macosx.png + test/script/jfx/kaleidoscope/golden/windows.png From sean.mullan at oracle.com Mon Oct 21 21:48:09 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 21 Oct 2013 17:48:09 -0400 Subject: Code Review Request: 8025763 In-Reply-To: <5261F3E5.9060409@oracle.com> References: <52606140.1060204@oracle.com> <52618F88.5000803@oracle.com> <5261F3E5.9060409@oracle.com> Message-ID: <5265A119.1060606@oracle.com> On 10/18/2013 10:52 PM, Anthony Scarpino wrote: > I've updated the webrev > > http://cr.openjdk.java.net/~ascarpino/8025763/webrev.01/ Update looks good. --Sean From joe.darcy at oracle.com Mon Oct 21 22:37:42 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 21 Oct 2013 22:37:42 +0000 Subject: hg: jdk8/tl/langtools: 8026984: Clarity intended use of jdk.Exported Message-ID: <20131021223750.0B666625CF@hg.openjdk.java.net> Changeset: b82982ac3ca2 Author: darcy Date: 2013-10-21 15:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b82982ac3ca2 8026984: Clarity intended use of jdk.Exported Reviewed-by: psandoz, mr, alanb ! src/share/classes/jdk/Exported.java From jason.uh at oracle.com Tue Oct 22 00:12:53 2013 From: jason.uh at oracle.com (Jason Uh) Date: Mon, 21 Oct 2013 17:12:53 -0700 Subject: [8] Request for Review: 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests Message-ID: <5265C305.4050804@oracle.com> Hi Sean, Could I please get a review of this changeset? The change checks for null params when RevocationChecker.init is called. Bug: https://bugs.openjdk.java.net/browse/JDK-8025287 Webrev: http://cr.openjdk.java.net/~juh/8025287/webrev.00/ Thanks, Jason From xueming.shen at oracle.com Tue Oct 22 01:22:38 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 22 Oct 2013 01:22:38 +0000 Subject: hg: jdk8/tl/jdk: 8008386: (cs) Unmappable leading should be decoded to replacement. Message-ID: <20131022012324.5038F625D4@hg.openjdk.java.net> Changeset: 3b00bf85a6f5 Author: sherman Date: 2013-10-21 18:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b00bf85a6f5 8008386: (cs) Unmappable leading should be decoded to replacement. Summary: updated the unmappable/malformed detecting handling for db charsets Reviewed-by: naoto ! src/share/classes/sun/nio/cs/ext/DoubleByte.java ! test/sun/nio/cs/TestIBMBugs.java + test/sun/nio/cs/TestUnmappable.java From xuelei.fan at oracle.com Tue Oct 22 01:27:27 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 22 Oct 2013 09:27:27 +0800 Subject: [8] Review Request for 8021191: Add isAuthorized check to limited doPrivileged methods In-Reply-To: <5261A6FA.8000405@oracle.com> References: <5261A6FA.8000405@oracle.com> Message-ID: <5265D47F.1080107@oracle.com> It's a behavior update. Looks fine to me. Xuelei On 10/19/2013 5:24 AM, Sean Mullan wrote: > Please review this change to the limited doPrivileged methods to check > that the passed-in access control context is authorized before using. > > http://cr.openjdk.java.net/~mullan/webrevs/8021191/webrev.00/ > > Thanks, > Sean From weijun.wang at oracle.com Tue Oct 22 02:00:26 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 22 Oct 2013 10:00:26 +0800 Subject: [8] Review Request for 8021191: Add isAuthorized check to limited doPrivileged methods In-Reply-To: <5265D47F.1080107@oracle.com> References: <5261A6FA.8000405@oracle.com> <5265D47F.1080107@oracle.com> Message-ID: <5265DC3A.9010406@oracle.com> In AccessController.java, existing doc always has a "specified" between "the" and "{@code AccessControlContext}". BTW, maybe a little off-topic, I am not sure about the exact meaning of "with no permissions". jre/lib/security/java.policy has granted some permissions (e.g. reading "java.version") to everyone. Do the doPrivWithPerm methods honor them? No other comment. Thanks Max On 10/22/13 9:27 AM, Xuelei Fan wrote: > It's a behavior update. Looks fine to me. > > Xuelei > > On 10/19/2013 5:24 AM, Sean Mullan wrote: >> Please review this change to the limited doPrivileged methods to check >> that the passed-in access control context is authorized before using. >> >> http://cr.openjdk.java.net/~mullan/webrevs/8021191/webrev.00/ >> >> Thanks, >> Sean > From joel.franck at oracle.com Tue Oct 22 02:13:26 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 22 Oct 2013 02:13:26 +0000 Subject: hg: jdk8/tl/langtools: 8026855: AnnoConstruct.getAnnotationsByType includes inherited indirectly present annotations even when containee type is not inheritable Message-ID: <20131022021332.E33E4625D8@hg.openjdk.java.net> Changeset: ac839d6f4953 Author: jfranck Date: 2013-10-22 03:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ac839d6f4953 8026855: AnnoConstruct.getAnnotationsByType includes inherited indirectly present annotations even when containee type is not inheritable Summary: In AnnoConstruct.getAnnotationByType() check that the annotation sought after is inherited before looking on supertypes. Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/AnnoConstruct.java + test/tools/javac/processing/model/element/TestNonInherited.java From coleen.phillimore at oracle.com Tue Oct 22 03:40:30 2013 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Tue, 22 Oct 2013 03:40:30 +0000 Subject: hg: jdk8/tl/jdk: 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV Message-ID: <20131022034109.39927625E4@hg.openjdk.java.net> Changeset: f581b72e3715 Author: sla Date: 2013-10-21 23:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f581b72e3715 8025238: nsk/jvmti/scenarios/bcinstr/BI04/bi04t002 crashed with SIGSEGV Summary: Redefined class in stack trace may not be found by method_idnum so handle null. Reviewed-by: coleenp, dcubed, sspitsyn ! test/java/lang/instrument/RedefineMethodInBacktrace.sh ! test/java/lang/instrument/RedefineMethodInBacktraceApp.java + test/java/lang/instrument/RedefineMethodInBacktraceTargetB.java + test/java/lang/instrument/RedefineMethodInBacktraceTargetB_2.java From jason.uh at oracle.com Tue Oct 22 03:55:14 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Tue, 22 Oct 2013 03:55:14 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20131022035619.396A7625E6@hg.openjdk.java.net> Changeset: 975e3a89814e Author: darcy Date: 2013-10-21 13:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/975e3a89814e 8024603: Turn on javac lint checking for auxiliaryclass, empty, and try in jdk build Reviewed-by: erikj, ihse, chegar ! makefiles/Setup.gmk Changeset: f443d9b863cf Author: juh Date: 2013-10-21 22:05 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f443d9b863cf Merge Changeset: d0882a1deeb5 Author: juh Date: 2013-10-22 03:49 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d0882a1deeb5 Merge From xuelei.fan at oracle.com Tue Oct 22 04:41:30 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Tue, 22 Oct 2013 12:41:30 +0800 Subject: [8] 8012636: OCSP validation fails even when public key is trusted In-Reply-To: <52659E6F.7020806@oracle.com> References: <52659E6F.7020806@oracle.com> Message-ID: <526601FA.1030808@oracle.com> OCSPRequest.java ================ line 79-80, Note that Debug.getInstance("certpath") may return null. Looks like don't need dump variable any more. OCSPResponse.java ================ line 134-135. ------------- Debug.getInstance("certpath") may return null. May not need dump variable. line 299: --------- byte[] responderKey = seq.getData().getOctetString(); I was wondering the variable may be responderKeyId: responderKeyId = seq.getData().getOctetString(); line 380-381: ------------- Per RFC 2560, responderKeyId is a SHA-1 hash of responder's public key. The value may be not the SubjectKeyIdentifier in a certificate per RFC 5280. line 373-384: ------------- Why only include certs that match the responderID? I was wondering that these certs is used to build a full certification path. The cert does not match the responderID may be used as intermediate cert of a path. line 442-445: ------------- Need more time to parse the following update. Xuelei On 10/22/2013 5:36 AM, Vincent Ryan wrote: > Please review this fix to support key-rollover certs > (same name, different keys): > > Bug: https://bugs.openjdk.java.net/browse/JDK-8012636 > Webrev: http://cr.openjdk.java.net/~vinnie/8012636/webrev.00/ > > This issue arises when an OCSP responder replaces its public key > but retains its subject name. The OCSP client must be able to > validate responses signed by both keys. > > Thanks. From kumar.x.srinivasan at oracle.com Tue Oct 22 04:34:12 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Tue, 22 Oct 2013 04:34:12 +0000 Subject: hg: jdk8/tl/langtools: 8026758: Inefficient code in LambdaToMethod Message-ID: <20131022043417.6CA25625EC@hg.openjdk.java.net> Changeset: 87c950ea88be Author: ksrini Date: 2013-10-21 20:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/87c950ea88be 8026758: Inefficient code in LambdaToMethod Reviewed-by: jjg, jlahoda, rfield ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java From joel.franck at oracle.com Tue Oct 22 08:32:15 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 22 Oct 2013 08:32:15 +0000 Subject: hg: jdk8/tl/langtools: 8026857: AnnoConstruct.getAnnotationsByType does not search supertype for inherited annotations if @SomeContainer({}) is present Message-ID: <20131022083233.2FDB3625F6@hg.openjdk.java.net> Changeset: f003f09144ff Author: jfranck Date: 2013-10-22 10:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f003f09144ff 8026857: AnnoConstruct.getAnnotationsByType does not search supertype for inherited annotations if @SomeContainer({}) is present Summary: An empty container should not stop javac from looking at supertypes for inherited repeating annotations Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/AnnoConstruct.java + test/tools/javac/processing/model/element/TestEmptyContainer.java From joel.franck at oracle.com Tue Oct 22 08:50:53 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 22 Oct 2013 08:50:53 +0000 Subject: hg: jdk8/tl/jdk: 8009411: (reflect) Class.getMethods should not include static methods from interfaces Message-ID: <20131022085246.E9B7F625F7@hg.openjdk.java.net> Changeset: 04ba97b7c2f9 Author: jfranck Date: 2013-10-22 10:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04ba97b7c2f9 8009411: (reflect) Class.getMethods should not include static methods from interfaces Summary: Update getMethods() and getMethod() to filter out interface statics Reviewed-by: darcy Contributed-by: joel.franck at oracle.com, andreas.lundblad at oracle.com, amy.lu at oracle.com, peter.levart at gmail.com ! src/share/classes/java/lang/Class.java ! test/java/lang/reflect/DefaultStaticTest/DefaultStaticInvokeTest.java ! test/java/lang/reflect/DefaultStaticTest/DefaultStaticTestData.java + test/java/lang/reflect/Method/InterfaceStatic/StaticInterfaceMethodInWayOfDefault.java From staffan.larsen at oracle.com Tue Oct 22 09:46:23 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 22 Oct 2013 09:46:23 +0000 Subject: hg: jdk8/tl/jdk: 8026962: Put java/lang/management/ClassLoadingMXBean/LoadCounts.java into ProblemList.txt Message-ID: <20131022095104.B1C45625FE@hg.openjdk.java.net> Changeset: bb2fb6be8b2a Author: ykantser Date: 2013-10-22 10:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb2fb6be8b2a 8026962: Put java/lang/management/ClassLoadingMXBean/LoadCounts.java into ProblemList.txt Reviewed-by: sla, jbachorik ! test/ProblemList.txt From joel.franck at oracle.com Tue Oct 22 10:40:00 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Tue, 22 Oct 2013 10:40:00 +0000 Subject: hg: jdk8/tl/jdk: 8004912: Repeating annotations - getAnnotationsByType(Class) is not working as expected for few inheritance scenarios; ... Message-ID: <20131022104043.279CA62603@hg.openjdk.java.net> Changeset: b07856d0de34 Author: alundblad Date: 2013-10-22 12:35 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b07856d0de34 8004912: Repeating annotations - getAnnotationsByType(Class) is not working as expected for few inheritance scenarios 8019420: Repeatable non-inheritable annotation types are mishandled by Core Reflection Reviewed-by: jfranck ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/annotation/AnnotationSupport.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java + test/java/lang/annotation/repeatingAnnotations/NonInheritableContainee.java + test/java/lang/annotation/repeatingAnnotations/OrderUnitTest.java ! test/java/lang/annotation/repeatingAnnotations/RepeatedUnitTest.java From alan.bateman at oracle.com Tue Oct 22 10:45:01 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 22 Oct 2013 10:45:01 +0000 Subject: hg: jdk8/tl/corba: 8021257: com.sun.corba.se.** should be on restricted package list Message-ID: <20131022104503.E67AB62604@hg.openjdk.java.net> Changeset: 52ad44f9a3ec Author: alanb Date: 2013-10-22 11:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/52ad44f9a3ec 8021257: com.sun.corba.se.** should be on restricted package list Reviewed-by: chegar, coffeys, smarks Contributed-by: alan.bateman at oralce.com, mark.sheppard at oracle.com ! src/share/classes/javax/rmi/CORBA/Stub.java ! src/share/classes/javax/rmi/CORBA/Util.java ! src/share/classes/javax/rmi/PortableRemoteObject.java ! src/share/classes/org/omg/CORBA/ORB.java From alan.bateman at oracle.com Tue Oct 22 11:10:17 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 22 Oct 2013 11:10:17 +0000 Subject: hg: jdk8/tl/jdk: 8024833: (fc) FileChannel.map does not handle async close/interrupt correctly Message-ID: <20131022111029.DAFE562607@hg.openjdk.java.net> Changeset: f15ad52cffed Author: alanb Date: 2013-10-22 12:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f15ad52cffed 8024833: (fc) FileChannel.map does not handle async close/interrupt correctly Reviewed-by: alanb Contributed-by: chris.w.dennis at gmail.com ! src/share/classes/sun/nio/ch/FileChannelImpl.java + test/java/nio/channels/FileChannel/InterruptMapDeadlock.java From alan.bateman at oracle.com Tue Oct 22 10:48:37 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 22 Oct 2013 10:48:37 +0000 Subject: hg: jdk8/tl/jdk: 8021257: com.sun.corba.se.** should be on restricted package list Message-ID: <20131022104859.02ADC62605@hg.openjdk.java.net> Changeset: 6f9515a9519f Author: alanb Date: 2013-10-22 11:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f9515a9519f 8021257: com.sun.corba.se.** should be on restricted package list Reviewed-by: chegar, coffeys, smarks, mullan Contributed-by: alan.bateman at oralce.com, mark.sheppard at oracle.com ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/lang/SecurityManager/CheckPackageAccess.java From sean.mullan at oracle.com Tue Oct 22 11:35:20 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 22 Oct 2013 07:35:20 -0400 Subject: [8] Review Request for 8021191: Add isAuthorized check to limited doPrivileged methods In-Reply-To: <5265DC3A.9010406@oracle.com> References: <5261A6FA.8000405@oracle.com> <5265D47F.1080107@oracle.com> <5265DC3A.9010406@oracle.com> Message-ID: <526662F8.2030008@oracle.com> On 10/21/2013 10:00 PM, Weijun Wang wrote: > In AccessController.java, existing doc always has a "specified" between > "the" and "{@code AccessControlContext}". Fixed. > BTW, maybe a little off-topic, I am not sure about the exact meaning of > "with no permissions". jre/lib/security/java.policy has granted some > permissions (e.g. reading "java.version") to everyone. Do the > doPrivWithPerm methods honor them? No, it is really executed with no permissions. Thanks, Sean > > No other comment. > > Thanks > Max > > On 10/22/13 9:27 AM, Xuelei Fan wrote: >> It's a behavior update. Looks fine to me. >> >> Xuelei >> >> On 10/19/2013 5:24 AM, Sean Mullan wrote: >>> Please review this change to the limited doPrivileged methods to check >>> that the passed-in access control context is authorized before using. >>> >>> http://cr.openjdk.java.net/~mullan/webrevs/8021191/webrev.00/ >>> >>> Thanks, >>> Sean >> From weijun.wang at oracle.com Tue Oct 22 12:55:27 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 22 Oct 2013 20:55:27 +0800 Subject: RFR 8027026: Change keytool -genkeypair to use -keyalg RSA Message-ID: <526675BF.2060705@oracle.com> There is a bug on Solaris on DSA keypair generation, and DSA related test has a 1/256 probability to fail at signature verification. This fix updates all non algorithm related "keytool -genkeypair" calls to using RSA. Please take a review: http://cr.openjdk.java.net/~weijun/8027026/webrev.00 Thanks Max From Alan.Bateman at oracle.com Tue Oct 22 13:00:10 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 22 Oct 2013 14:00:10 +0100 Subject: RFR 8027026: Change keytool -genkeypair to use -keyalg RSA In-Reply-To: <526675BF.2060705@oracle.com> References: <526675BF.2060705@oracle.com> Message-ID: <526676DA.1040208@oracle.com> On 22/10/2013 13:55, Weijun Wang wrote: > There is a bug on Solaris on DSA keypair generation, and DSA related > test has a 1/256 probability to fail at signature verification. This > fix updates all non algorithm related "keytool -genkeypair" calls to > using RSA. > > Please take a review: > > http://cr.openjdk.java.net/~weijun/8027026/webrev.00 This looks okay to me (and good to see a number of tests liberated from the ProblemList as a result). -Alan. From vicente.romero at oracle.com Tue Oct 22 12:59:17 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 22 Oct 2013 12:59:17 +0000 Subject: hg: jdk8/tl/langtools: 8025290: javac implicit versus explicit lambda compilation error Message-ID: <20131022125922.C6C4F62610@hg.openjdk.java.net> Changeset: 963c57175e40 Author: vromero Date: 2013-10-22 13:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/963c57175e40 8025290: javac implicit versus explicit lambda compilation error Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/util/JavacMessages.java + test/tools/javac/lambda/T8025290/ExplicitVSImplicitLambdaTest.java From chris.hegarty at oracle.com Tue Oct 22 13:06:42 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 22 Oct 2013 14:06:42 +0100 Subject: RFR 8027026: Change keytool -genkeypair to use -keyalg RSA In-Reply-To: <526676DA.1040208@oracle.com> References: <526675BF.2060705@oracle.com> <526676DA.1040208@oracle.com> Message-ID: <52667862.5060402@oracle.com> On 22/10/2013 14:00, Alan Bateman wrote: > On 22/10/2013 13:55, Weijun Wang wrote: >> There is a bug on Solaris on DSA keypair generation, and DSA related >> test has a 1/256 probability to fail at signature verification. This >> fix updates all non algorithm related "keytool -genkeypair" calls to >> using RSA. >> >> Please take a review: >> >> http://cr.openjdk.java.net/~weijun/8027026/webrev.00 > This looks okay to me (and good to see a number of tests liberated from > the ProblemList as a result). +1 -Chris. > > -Alan. From chris.hegarty at oracle.com Tue Oct 22 13:05:59 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 22 Oct 2013 13:05:59 +0000 Subject: hg: jdk8/tl/jdk: 8017779: java/net/Authenticator/B4769350.java fails Message-ID: <20131022130621.8F56862611@hg.openjdk.java.net> Changeset: 7cafbb397683 Author: chegar Date: 2013-10-22 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cafbb397683 8017779: java/net/Authenticator/B4769350.java fails Reviewed-by: chegar Contributed-by: Tristan Yan , Kurchi Subhra Hazra ! test/java/net/Authenticator/B4769350.java From sean.mullan at oracle.com Tue Oct 22 13:14:04 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 22 Oct 2013 13:14:04 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20131022131513.B657F62612@hg.openjdk.java.net> Changeset: 5f4aecd73caa Author: mullan Date: 2013-10-22 08:03 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f4aecd73caa 8021191: Add isAuthorized check to limited doPrivileged methods Reviewed-by: weijun, xuelei ! src/share/classes/java/security/AccessControlContext.java ! src/share/classes/java/security/AccessController.java Changeset: 948b390b6952 Author: mullan Date: 2013-10-22 08:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/948b390b6952 Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/java/lang/invoke/MagicLambdaImpl.java - src/share/classes/java/net/HttpURLPermission.java - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: 3ea9af449b36 Author: mullan Date: 2013-10-22 09:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3ea9af449b36 Merge - test/java/net/NetworkInterface/MemLeakTest.java From alan.bateman at oracle.com Tue Oct 22 13:20:53 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 22 Oct 2013 13:20:53 +0000 Subject: hg: jdk8/tl/jdk: 7074436: (sc) SocketChannel can do short gathering writes when channel configured blocking (win) Message-ID: <20131022132115.916A762613@hg.openjdk.java.net> Changeset: 54869853c06c Author: alanb Date: 2013-10-22 14:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/54869853c06c 7074436: (sc) SocketChannel can do short gathering writes when channel configured blocking (win) Reviewed-by: chegar ! src/windows/native/sun/nio/ch/SocketDispatcher.c ! test/java/nio/channels/SocketChannel/ShortWrite.java From sean.mullan at oracle.com Tue Oct 22 13:32:02 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 22 Oct 2013 09:32:02 -0400 Subject: RFR 8027026: Change keytool -genkeypair to use -keyalg RSA In-Reply-To: <526675BF.2060705@oracle.com> References: <526675BF.2060705@oracle.com> Message-ID: <52667E52.7090307@oracle.com> Looks good. --Sean On 10/22/2013 08:55 AM, Weijun Wang wrote: > There is a bug on Solaris on DSA keypair generation, and DSA related > test has a 1/256 probability to fail at signature verification. This fix > updates all non algorithm related "keytool -genkeypair" calls to using RSA. > > Please take a review: > > http://cr.openjdk.java.net/~weijun/8027026/webrev.00 > > Thanks > Max From sean.mullan at oracle.com Tue Oct 22 13:49:49 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 22 Oct 2013 09:49:49 -0400 Subject: [8] Request for Review: 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests In-Reply-To: <5265C305.4050804@oracle.com> References: <5265C305.4050804@oracle.com> Message-ID: <5266827D.1000405@oracle.com> Hi Jason, The fix looks good. Even though there is a TCK test for this, I think you should add a regression test, and it should be very easy to add. You can add it to jdk/test/java/security/cert/PKIXRevocationChecker/UnitTest.java, ex: $ hg diff UnitTest.java diff -r 54869853c06c test/java/security/cert/PKIXRevocationChecker/UnitTest.java --- a/test/java/security/cert/PKIXRevocationChecker/UnitTest.java +++ b/test/java/security/cert/PKIXRevocationChecker/UnitTest.java @@ -44,6 +44,8 @@ CertPathChecker cpc = cpv.getRevocationChecker(); PKIXRevocationChecker prc = (PKIXRevocationChecker)cpc; + prc.init(false); + System.out.println("Testing that get methods return null or " + "empty lists/sets/maps"); requireNull(prc.getOcspResponder(), "getOcspResponder()"); --Sean On 10/21/2013 08:12 PM, Jason Uh wrote: > Hi Sean, > > Could I please get a review of this changeset? > > The change checks for null params when RevocationChecker.init is called. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8025287 > Webrev: http://cr.openjdk.java.net/~juh/8025287/webrev.00/ > > Thanks, > Jason From sundararajan.athijegannathan at oracle.com Tue Oct 22 14:27:40 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 22 Oct 2013 14:27:40 +0000 Subject: hg: jdk8/tl/nashorn: 5 new changesets Message-ID: <20131022142752.D0F3A6261A@hg.openjdk.java.net> Changeset: d8d5b7919c57 Author: sundar Date: 2013-10-22 14:27 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d8d5b7919c57 8027016: Array.prototype.indexOf should return -1 when array is of length zero Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/objects/NativeArray.java + test/script/basic/JDK-8027016.js Changeset: 6d339d98074e Author: hannesw Date: 2013-10-22 11:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6d339d98074e 8027015: AutoCloseable no longer implements @FunctionalInterface Reviewed-by: lagergren, sundar ! test/script/basic/NASHORN-397.js Changeset: d24a4fabdce1 Author: hannesw Date: 2013-10-22 11:31 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d24a4fabdce1 8026955: for-in should convert primitive values to object Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8026955.js + test/script/basic/JDK-8026955.js.EXPECTED Changeset: 360761288b38 Author: sundar Date: 2013-10-22 17:38 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/360761288b38 8027024: String.prototype.charAt and charCodeAt do not evaluate 'self' and 'pos' arguments in right order Reviewed-by: jlaskey, attila, lagergren ! src/jdk/nashorn/internal/objects/NativeString.java ! src/overview.html + test/script/basic/JDK-8027024.js + test/script/basic/JDK-8027024.js.EXPECTED Changeset: d04028e6b624 Author: sundar Date: 2013-10-22 17:47 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d04028e6b624 Merge From chris.hegarty at oracle.com Tue Oct 22 12:36:20 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 22 Oct 2013 12:36:20 +0000 Subject: hg: jdk8/tl/jdk: 8023390: Test java/net/NetworkInterface/MemLeakTest.java failed with the latest jdk8 build Message-ID: <20131022123706.7CC186260C@hg.openjdk.java.net> Changeset: 6a1989dc302d Author: igerasim Date: 2013-10-15 18:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a1989dc302d 8023390: Test java/net/NetworkInterface/MemLeakTest.java failed with the latest jdk8 build Summary: Removing the test as it is unreliable and fails intermittently Reviewed-by: chegar - test/java/net/NetworkInterface/MemLeakTest.java From sean.mullan at oracle.com Tue Oct 22 16:06:05 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 22 Oct 2013 12:06:05 -0400 Subject: [8] 8012636: OCSP validation fails even when public key is trusted In-Reply-To: <52659E6F.7020806@oracle.com> References: <52659E6F.7020806@oracle.com> Message-ID: <5266A26D.20906@oracle.com> I am still reviewing, but here are some comments so far: * X509CertImpl I would prefer if getSubjectKeyIdentifier returned a KeyIdentifier so that it is consistent with the getAuthKeyId method. Also, in OCSPResponse, you can then just call KeyIdentifier.equals instead of comparing the bytes yourself with Arrays.equals. * RevocationChecker RevocationChecker can be re-used for subsequent revocation checks by calling the init method. So, you need to clear the contents of the responderCerts list each time init is called. You can add this after line 323 in the init method responderCerts.clear(); --Sean On 10/21/2013 05:36 PM, Vincent Ryan wrote: > Please review this fix to support key-rollover certs > (same name, different keys): > > Bug: https://bugs.openjdk.java.net/browse/JDK-8012636 > Webrev: http://cr.openjdk.java.net/~vinnie/8012636/webrev.00/ > > This issue arises when an OCSP responder replaces its public key > but retains its subject name. The OCSP client must be able to > validate responses signed by both keys. > > Thanks. From sundararajan.athijegannathan at oracle.com Tue Oct 22 17:07:41 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Tue, 22 Oct 2013 17:07:41 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20131022170746.7ACAB6262F@hg.openjdk.java.net> Changeset: 0ecbc0188b64 Author: attila Date: 2013-10-22 16:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0ecbc0188b64 8027031: complete merging of loads and converts Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/codegen/BranchOptimizer.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/SpillObjectCreator.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java Changeset: 6f19eb443a47 Author: attila Date: 2013-10-22 17:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6f19eb443a47 8027037: Make ScriptObjectMirror conversions work for any JSObject Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/nashorn/api/scripting/JSObject.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java Changeset: eae4e4c1f613 Author: sundar Date: 2013-10-22 22:04 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/eae4e4c1f613 8027020: [regression] java.lang.VerifyError: Bad type on operand stack Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/runtime/ScriptLoader.java Changeset: 734f71f8a2c3 Author: sundar Date: 2013-10-22 22:12 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/734f71f8a2c3 Merge From brian.burkhalter at oracle.com Tue Oct 22 17:45:40 2013 From: brian.burkhalter at oracle.com (brian.burkhalter at oracle.com) Date: Tue, 22 Oct 2013 17:45:40 +0000 Subject: hg: jdk8/tl/jdk: 8026806: Incomplete test of getaddrinfo() return value could lead to incorrect exception for Windows Inet 6 Message-ID: <20131022174611.289E562631@hg.openjdk.java.net> Changeset: 9758edb6976f Author: bpb Date: 2013-10-22 10:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9758edb6976f 8026806: Incomplete test of getaddrinfo() return value could lead to incorrect exception for Windows Inet 6 Summary: Check getaddrinfo return value before calling WSAGetLastError. Reviewed-by: alanb, dsamersoff ! src/windows/native/java/net/Inet6AddressImpl.c From eric.mccorkle at oracle.com Tue Oct 22 17:56:14 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Tue, 22 Oct 2013 17:56:14 +0000 Subject: hg: jdk8/tl/jdk: 8026818: Defmeth failures with -mode invoke Message-ID: <20131022175633.3094562632@hg.openjdk.java.net> Changeset: 23b124cbf242 Author: drchase Date: 2013-10-22 12:57 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23b124cbf242 8026818: Defmeth failures with -mode invoke Summary: Added test for IllegalAccessException -> IllegalAccessError path to check if root cause was AbstractMethodError Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MethodHandleNatives.java From sean.mullan at oracle.com Tue Oct 22 18:08:34 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 22 Oct 2013 14:08:34 -0400 Subject: [8] 8012636: OCSP validation fails even when public key is trusted In-Reply-To: <5266A26D.20906@oracle.com> References: <52659E6F.7020806@oracle.com> <5266A26D.20906@oracle.com> Message-ID: <5266BF22.8050009@oracle.com> I still need to review RevocationChecker but a few more comments ... * OCSPResponse - the responderKeyId field is never set. I believe line 299 should be: responderKeyId = seq.getData().getOctetString(); - lines 372-385. I think it would be better to not do any matching yet, and store all of the certs in a list. The matching should be done later in verify if we still need to find a trusted responder cert. - lines 443-4, it seems expensive to iterate over all the possible responders, verifying the signature each time to determine who has signed the response if it is signed by the issuing CA. What about the following logic instead: 1. check the responderName or responderId against the list of trusted responder certs that are passed in. I think it would be better to store the responderCerts in a map instead of a list, using the keyId or name as key (you could create a new ResponderKey class that compares either the name or the keyId, whichever is set). 2. If step 1 is successful (finds a matching cert), this cert is already trusted so you can proceed to verifying the signature. There is no need to look at the certs in the OCSPResponse. 3. If step 1 fails, then you can look at the certs in the OCSPResponse, find the cert that matches the keyId or name, verify the signature, then check if it is authorized. - line 611, it seems the caller could set this if verify returns true. Then you could make this method static. --Sean On 10/22/2013 12:06 PM, Sean Mullan wrote: > I am still reviewing, but here are some comments so far: > > * X509CertImpl > > I would prefer if getSubjectKeyIdentifier returned a KeyIdentifier so > that it is consistent with the getAuthKeyId method. Also, in > OCSPResponse, you can then just call KeyIdentifier.equals instead of > comparing the bytes yourself with Arrays.equals. > > * RevocationChecker > > RevocationChecker can be re-used for subsequent revocation checks by > calling the init method. So, you need to clear the contents of the > responderCerts list each time init is called. You can add this after > line 323 in the init method > > responderCerts.clear(); > > --Sean > > On 10/21/2013 05:36 PM, Vincent Ryan wrote: >> Please review this fix to support key-rollover certs >> (same name, different keys): >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8012636 >> Webrev: http://cr.openjdk.java.net/~vinnie/8012636/webrev.00/ >> >> This issue arises when an OCSP responder replaces its public key >> but retains its subject name. The OCSP client must be able to >> validate responses signed by both keys. >> >> Thanks. > From alexander.zuev at oracle.com Tue Oct 22 18:21:33 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Tue, 22 Oct 2013 18:21:33 +0000 Subject: hg: jdk8/tl/jdk: 8026873: tools/launcher/VersionCheck.java fails in jprt because of jmc.ini Message-ID: <20131022182200.2511A62633@hg.openjdk.java.net> Changeset: 72c0f289a8cb Author: kizune Date: 2013-10-22 22:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72c0f289a8cb 8026873: tools/launcher/VersionCheck.java fails in jprt because of jmc.ini Reviewed-by: ksrini ! test/tools/launcher/VersionCheck.java From brian.burkhalter at oracle.com Tue Oct 22 18:29:39 2013 From: brian.burkhalter at oracle.com (brian.burkhalter at oracle.com) Date: Tue, 22 Oct 2013 18:29:39 +0000 Subject: hg: jdk8/tl/jdk: 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE; ... Message-ID: <20131022183012.BF5E962634@hg.openjdk.java.net> Changeset: 2be08cdd1ced Author: bpb Date: 2013-10-22 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2be08cdd1ced 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE 6445180: URLClassLoader does not describe the behavior of several methods with respect to null arguments Summary: Document when a NPE will be thrown by URLClassLoader constructors, newInstance(), findClass(), and getPermissions(). Reviewed-by: alanb, mduigou, chegar, dholmes, jrose ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/javax/management/remote/rmi/NoCallStackClassLoader.java ! src/share/classes/sun/applet/AppletClassLoader.java + test/java/net/URLClassLoader/NullURLTest.java From jason.uh at oracle.com Tue Oct 22 18:41:31 2013 From: jason.uh at oracle.com (Jason Uh) Date: Tue, 22 Oct 2013 11:41:31 -0700 Subject: [8] Request for Review: 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests In-Reply-To: <5266827D.1000405@oracle.com> References: <5265C305.4050804@oracle.com> <5266827D.1000405@oracle.com> Message-ID: <5266C6DB.4070108@oracle.com> Hi Sean, Thanks. I've added a test and have removed "noreg-jck." I'll push if you're okay with the change. http://cr.openjdk.java.net/~juh/8025287/webrev.01/ Jason On 10/22/2013 06:49 AM, Sean Mullan wrote: > Hi Jason, > > The fix looks good. Even though there is a TCK test for this, I think > you should add a regression test, and it should be very easy to add. You > can add it to > jdk/test/java/security/cert/PKIXRevocationChecker/UnitTest.java, ex: > > $ hg diff UnitTest.java > diff -r 54869853c06c > test/java/security/cert/PKIXRevocationChecker/UnitTest.java > --- a/test/java/security/cert/PKIXRevocationChecker/UnitTest.java > +++ b/test/java/security/cert/PKIXRevocationChecker/UnitTest.java > @@ -44,6 +44,8 @@ > CertPathChecker cpc = cpv.getRevocationChecker(); > PKIXRevocationChecker prc = (PKIXRevocationChecker)cpc; > > + prc.init(false); > + > System.out.println("Testing that get methods return null or " + > "empty lists/sets/maps"); > requireNull(prc.getOcspResponder(), "getOcspResponder()"); > > > --Sean > > On 10/21/2013 08:12 PM, Jason Uh wrote: >> Hi Sean, >> >> Could I please get a review of this changeset? >> >> The change checks for null params when RevocationChecker.init is called. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8025287 >> Webrev: http://cr.openjdk.java.net/~juh/8025287/webrev.00/ >> >> Thanks, >> Jason > From sean.mullan at oracle.com Tue Oct 22 18:52:19 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 22 Oct 2013 14:52:19 -0400 Subject: [8] Request for Review: 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests In-Reply-To: <5266C6DB.4070108@oracle.com> References: <5265C305.4050804@oracle.com> <5266827D.1000405@oracle.com> <5266C6DB.4070108@oracle.com> Message-ID: <5266C963.8010001@oracle.com> Just add the bugid to the @bug tag in the test and it looks good to push. --Sean On 10/22/2013 02:41 PM, Jason Uh wrote: > Hi Sean, > > Thanks. I've added a test and have removed "noreg-jck." I'll push if > you're okay with the change. > > http://cr.openjdk.java.net/~juh/8025287/webrev.01/ > > Jason > > On 10/22/2013 06:49 AM, Sean Mullan wrote: >> Hi Jason, >> >> The fix looks good. Even though there is a TCK test for this, I think >> you should add a regression test, and it should be very easy to add. You >> can add it to >> jdk/test/java/security/cert/PKIXRevocationChecker/UnitTest.java, ex: >> >> $ hg diff UnitTest.java >> diff -r 54869853c06c >> test/java/security/cert/PKIXRevocationChecker/UnitTest.java >> --- a/test/java/security/cert/PKIXRevocationChecker/UnitTest.java >> +++ b/test/java/security/cert/PKIXRevocationChecker/UnitTest.java >> @@ -44,6 +44,8 @@ >> CertPathChecker cpc = cpv.getRevocationChecker(); >> PKIXRevocationChecker prc = (PKIXRevocationChecker)cpc; >> >> + prc.init(false); >> + >> System.out.println("Testing that get methods return null or " + >> "empty lists/sets/maps"); >> requireNull(prc.getOcspResponder(), "getOcspResponder()"); >> >> >> --Sean >> >> On 10/21/2013 08:12 PM, Jason Uh wrote: >>> Hi Sean, >>> >>> Could I please get a review of this changeset? >>> >>> The change checks for null params when RevocationChecker.init is called. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8025287 >>> Webrev: http://cr.openjdk.java.net/~juh/8025287/webrev.00/ >>> >>> Thanks, >>> Jason >> From joe.darcy at oracle.com Tue Oct 22 19:07:55 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 22 Oct 2013 19:07:55 +0000 Subject: hg: jdk8/tl/jdk: 8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue, SecurityManager} Message-ID: <20131022190815.58A6962637@hg.openjdk.java.net> Changeset: 9a32af82bd1e Author: darcy Date: 2013-10-22 12:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a32af82bd1e 8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue, SecurityManager} Reviewed-by: chegar, forax, alanb, mduigou ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/ClassValue.java ! src/share/classes/java/lang/SecurityManager.java From jason.uh at oracle.com Tue Oct 22 18:58:28 2013 From: jason.uh at oracle.com (jason.uh at oracle.com) Date: Tue, 22 Oct 2013 18:58:28 +0000 Subject: hg: jdk8/tl/jdk: 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests Message-ID: <20131022185847.9573E62635@hg.openjdk.java.net> Changeset: c956a5d0618f Author: juh Date: 2013-10-22 11:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c956a5d0618f 8025287: NPE in api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! test/java/security/cert/PKIXRevocationChecker/UnitTest.java From roger.riggs at oracle.com Tue Oct 22 19:14:52 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 22 Oct 2013 19:14:52 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20131022191556.1E56E62638@hg.openjdk.java.net> Changeset: e2b814e68956 Author: rriggs Date: 2013-10-22 15:03 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2b814e68956 8024686: Cleanup of java.time serialization source Summary: optimize serialized form of OffsetTime, OffsetDateTime; correct order of modifiers Reviewed-by: sherman ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/chrono/ChronoPeriodImpl.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! test/java/time/tck/java/time/serial/TCKOffsetDateTimeSerialization.java ! test/java/time/tck/java/time/serial/TCKOffsetTimeSerialization.java Changeset: d5c2b125ed0f Author: rriggs Date: 2013-10-22 15:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5c2b125ed0f Merge Changeset: cd60848c87b2 Author: rriggs Date: 2013-10-22 15:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd60848c87b2 Merge From sean.mullan at oracle.com Tue Oct 22 19:45:34 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Tue, 22 Oct 2013 15:45:34 -0400 Subject: [8] 8012636: OCSP validation fails even when public key is trusted In-Reply-To: <5266BF22.8050009@oracle.com> References: <52659E6F.7020806@oracle.com> <5266A26D.20906@oracle.com> <5266BF22.8050009@oracle.com> Message-ID: <5266D5DE.8000508@oracle.com> Just one more comment on RevocationChecker: - I'd prefer if the getResponderCert methods remained static. You can do that by creating a local variable in getResponderCerts(X509CertSelector,Set,List) to hold the certs and then returning that. --Sean On 10/22/2013 02:08 PM, Sean Mullan wrote: > I still need to review RevocationChecker but a few more comments ... > > * OCSPResponse > > - the responderKeyId field is never set. I believe line 299 should be: > > responderKeyId = seq.getData().getOctetString(); > > - lines 372-385. I think it would be better to not do any matching yet, > and store all of the certs in a list. The matching should be done later > in verify if we still need to find a trusted responder cert. > > - lines 443-4, it seems expensive to iterate over all the possible > responders, verifying the signature each time to determine who has > signed the response if it is signed by the issuing CA. What about the > following logic instead: > > 1. check the responderName or responderId against the list of trusted > responder certs that are passed in. I think it would be better to store > the responderCerts in a map instead of a list, using the keyId or name > as key (you could create a new ResponderKey class that compares either > the name or the keyId, whichever is set). > > 2. If step 1 is successful (finds a matching cert), this cert is > already trusted so you can proceed to verifying the signature. There is > no need to look at the certs in the OCSPResponse. > > 3. If step 1 fails, then you can look at the certs in the > OCSPResponse, find the cert that matches the keyId or name, verify the > signature, then check if it is authorized. > > - line 611, it seems the caller could set this if verify returns true. > Then you could make this method static. > > --Sean > > On 10/22/2013 12:06 PM, Sean Mullan wrote: >> I am still reviewing, but here are some comments so far: >> >> * X509CertImpl >> >> I would prefer if getSubjectKeyIdentifier returned a KeyIdentifier so >> that it is consistent with the getAuthKeyId method. Also, in >> OCSPResponse, you can then just call KeyIdentifier.equals instead of >> comparing the bytes yourself with Arrays.equals. >> >> * RevocationChecker >> >> RevocationChecker can be re-used for subsequent revocation checks by >> calling the init method. So, you need to clear the contents of the >> responderCerts list each time init is called. You can add this after >> line 323 in the init method >> >> responderCerts.clear(); >> >> --Sean >> >> On 10/21/2013 05:36 PM, Vincent Ryan wrote: >>> Please review this fix to support key-rollover certs >>> (same name, different keys): >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8012636 >>> Webrev: http://cr.openjdk.java.net/~vinnie/8012636/webrev.00/ >>> >>> This issue arises when an OCSP responder replaces its public key >>> but retains its subject name. The OCSP client must be able to >>> validate responses signed by both keys. >>> >>> Thanks. >> > From roger.riggs at oracle.com Tue Oct 22 21:16:59 2013 From: roger.riggs at oracle.com (roger.riggs at oracle.com) Date: Tue, 22 Oct 2013 21:16:59 +0000 Subject: hg: jdk8/tl/jdk: 8026982: javadoc errors in core libs Message-ID: <20131022211712.B127862640@hg.openjdk.java.net> Changeset: 4bb758a77fd7 Author: rriggs Date: 2013-10-22 17:02 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bb758a77fd7 8026982: javadoc errors in core libs Summary: Cleanup of javadoc -Xlint errors Reviewed-by: lancea, mduigou, darcy, mullan, mchung ! src/share/classes/java/io/ByteArrayInputStream.java ! src/share/classes/java/io/ByteArrayOutputStream.java ! src/share/classes/java/io/DataInput.java ! src/share/classes/java/io/DataOutput.java ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/io/InputStream.java ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/PipedInputStream.java ! src/share/classes/java/io/PipedReader.java ! src/share/classes/java/io/RandomAccessFile.java ! src/share/classes/java/io/Serializable.java ! src/share/classes/java/io/SerializablePermission.java ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/ArrayStoreException.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/ClassCastException.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/RuntimePermission.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/lang/management/ManagementFactory.java ! src/share/classes/java/lang/management/ManagementPermission.java ! src/share/classes/java/lang/management/MemoryUsage.java ! src/share/classes/java/lang/management/package.html ! src/share/classes/java/lang/reflect/ReflectPermission.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/MulticastSocket.java ! src/share/classes/java/net/NetPermission.java ! src/share/classes/java/net/Proxy.java ! src/share/classes/java/net/Socket.java ! src/share/classes/java/net/SocketOptions.java ! src/share/classes/java/net/SocketPermission.java ! src/share/classes/java/net/URI.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/net/URLDecoder.java ! src/share/classes/java/net/URLEncoder.java ! src/share/classes/java/net/URLPermission.java ! src/share/classes/java/net/package-info.java ! src/share/classes/java/nio/X-Buffer.java.template ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/rmi/activation/ActivationGroup.java ! src/share/classes/java/rmi/dgc/VMID.java ! src/share/classes/java/rmi/server/UnicastRemoteObject.java ! src/share/classes/java/security/AccessController.java ! src/share/classes/java/security/AlgorithmParameterGenerator.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/CodeSource.java ! src/share/classes/java/security/Key.java ! src/share/classes/java/security/KeyPairGenerator.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/MessageDigest.java ! src/share/classes/java/security/Permission.java ! src/share/classes/java/security/PermissionCollection.java ! src/share/classes/java/security/SecurityPermission.java ! src/share/classes/java/security/Signature.java ! src/share/classes/java/security/SignedObject.java ! src/share/classes/java/security/acl/Acl.java ! src/share/classes/java/security/cert/CertificateFactory.java ! src/share/classes/java/security/cert/PKIXRevocationChecker.java ! src/share/classes/java/security/cert/PolicyQualifierInfo.java ! src/share/classes/java/security/cert/TrustAnchor.java ! src/share/classes/java/security/cert/X509CertSelector.java ! src/share/classes/java/security/interfaces/DSAKeyPairGenerator.java ! src/share/classes/java/text/MessageFormat.java ! src/share/classes/java/text/Normalizer.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/util/Base64.java ! src/share/classes/java/util/BitSet.java ! src/share/classes/java/util/Deque.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/Properties.java ! src/share/classes/java/util/PropertyPermission.java ! src/share/classes/java/util/Queue.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/UUID.java ! src/share/classes/java/util/concurrent/BlockingDeque.java ! src/share/classes/java/util/concurrent/BlockingQueue.java ! src/share/classes/java/util/concurrent/Future.java ! src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java ! src/share/classes/java/util/jar/Pack200.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/java/util/spi/LocaleServiceProvider.java From michael.fang at oracle.com Tue Oct 22 21:39:52 2013 From: michael.fang at oracle.com (michael.fang at oracle.com) Date: Tue, 22 Oct 2013 21:39:52 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20131022214106.4FDE562644@hg.openjdk.java.net> Changeset: e84413f066e0 Author: mfang Date: 2013-10-22 14:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e84413f066e0 8026109: [ja] overtranslation of jarsigner in command line output Reviewed-by: naoto ! src/share/classes/sun/security/tools/jarsigner/Resources_ja.java Changeset: 25ebb8b61371 Author: mfang Date: 2013-10-22 14:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/25ebb8b61371 6607048: clear extra l10n resource files in demo Reviewed-by: naoto, yhuang - src/share/demo/jfc/Notepad/resources/Notepad_fr.properties - src/share/demo/jfc/Notepad/resources/Notepad_sv.properties Changeset: f2ddffb4b165 Author: mfang Date: 2013-10-22 14:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2ddffb4b165 Merge From stuart.marks at oracle.com Tue Oct 22 21:58:33 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Tue, 22 Oct 2013 21:58:33 +0000 Subject: hg: jdk8/tl/jdk: 8026427: deprecate obsolete APIs from java.rmi Message-ID: <20131022215848.A9B0B62645@hg.openjdk.java.net> Changeset: 9fbf35589211 Author: smarks Date: 2013-10-22 14:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fbf35589211 8026427: deprecate obsolete APIs from java.rmi Reviewed-by: alanb, dfuchs ! src/share/classes/java/rmi/RMISecurityManager.java ! src/share/classes/java/rmi/activation/ActivationGroup.java ! src/share/classes/java/rmi/server/ServerRef.java ! src/share/classes/java/rmi/server/SocketSecurityException.java From henry.jen at oracle.com Tue Oct 22 22:24:43 2013 From: henry.jen at oracle.com (henry.jen at oracle.com) Date: Tue, 22 Oct 2013 22:24:43 +0000 Subject: hg: jdk8/tl/jdk: 8025909: Lambda Library Spec Updates; ... Message-ID: <20131022222514.047256264E@hg.openjdk.java.net> Changeset: 0913c3bab168 Author: henryjen Date: 2013-10-22 15:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0913c3bab168 8025909: Lambda Library Spec Updates 8024179: Document limitations and performance characteristics of stream sources and operations 8024138: (Spec clarification) Lambda Metafacory spec should state DMH constraint on implMethod Reviewed-by: mduigou Contributed-by: brian.goetz at oracle.com, paul.sandoz at oracle.com ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/lang/invoke/LambdaMetafactory.java ! src/share/classes/java/lang/invoke/SerializedLambda.java ! src/share/classes/java/util/DoubleSummaryStatistics.java ! src/share/classes/java/util/Iterator.java ! src/share/classes/java/util/List.java ! src/share/classes/java/util/Map.java ! src/share/classes/java/util/PrimitiveIterator.java ! src/share/classes/java/util/Spliterator.java ! src/share/classes/java/util/function/package-info.java ! src/share/classes/java/util/stream/BaseStream.java ! src/share/classes/java/util/stream/Collectors.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Node.java ! src/share/classes/java/util/stream/SpinedBuffer.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/StreamSupport.java ! src/share/classes/java/util/stream/package-info.java From sean.mullan at oracle.com Tue Oct 22 23:45:36 2013 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Tue, 22 Oct 2013 23:45:36 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131022234642.4FFA762659@hg.openjdk.java.net> Changeset: fc7a6fa3589a Author: ascarpino Date: 2013-10-22 19:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc7a6fa3589a 8025763: Provider does not override new Hashtable methods Reviewed-by: mullan ! src/share/classes/java/security/Provider.java Changeset: b065de1700d3 Author: mullan Date: 2013-10-22 19:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b065de1700d3 Merge - src/share/demo/jfc/Notepad/resources/Notepad_fr.properties - src/share/demo/jfc/Notepad/resources/Notepad_sv.properties From robert.field at oracle.com Tue Oct 22 23:55:56 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Tue, 22 Oct 2013 23:55:56 +0000 Subject: hg: jdk8/tl/langtools: 8023668: Desugar serializable lambda bodies using more robust naming scheme Message-ID: <20131022235607.226DE6265E@hg.openjdk.java.net> Changeset: 6cd16d8ed2b9 Author: rfield Date: 2013-10-22 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6cd16d8ed2b9 8023668: Desugar serializable lambda bodies using more robust naming scheme Summary: lambda / bridged method-reference naming overhaul Reviewed-by: ksrini, briangoetz ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! test/tools/javac/MethodParameters/LambdaTest.out ! test/tools/javac/T8019486/WrongLVTForLambdaTest.java + test/tools/javac/lambda/lambdaNaming/TestSerializedLambdaNameStability.java + test/tools/javac/lambda/lambdaNaming/after/TESTNameOfCapturedArgs.java + test/tools/javac/lambda/lambdaNaming/after/TESTOrderOfCapturedArgs.java + test/tools/javac/lambda/lambdaNaming/after/TESTTargetName.java + test/tools/javac/lambda/lambdaNaming/after/TESTTargetType.java + test/tools/javac/lambda/lambdaNaming/after/TESTTypesOfCapturedArgs.java + test/tools/javac/lambda/lambdaNaming/after/TESTVariableAssignmentTarget.java + test/tools/javac/lambda/lambdaNaming/before/TESTNameOfCapturedArgs.java + test/tools/javac/lambda/lambdaNaming/before/TESTOrderOfCapturedArgs.java + test/tools/javac/lambda/lambdaNaming/before/TESTTargetName.java + test/tools/javac/lambda/lambdaNaming/before/TESTTargetType.java + test/tools/javac/lambda/lambdaNaming/before/TESTTypesOfCapturedArgs.java + test/tools/javac/lambda/lambdaNaming/before/TESTVariableAssignmentTarget.java From weijun.wang at oracle.com Wed Oct 23 00:33:12 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 23 Oct 2013 00:33:12 +0000 Subject: hg: jdk8/tl/jdk: 8027026: Change keytool -genkeypair to use -keyalg RSA Message-ID: <20131023003331.C4AF262664@hg.openjdk.java.net> Changeset: d545d67e2f68 Author: weijun Date: 2013-10-23 08:32 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d545d67e2f68 8027026: Change keytool -genkeypair to use -keyalg RSA Reviewed-by: alanb, chegar, mullan ! test/ProblemList.txt ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh ! test/java/util/jar/JarInputStream/ExtraFileInMetaInf.java ! test/sun/security/pkcs12/PKCS12SameKeyId.java ! test/sun/security/tools/jarsigner/TimestampCheck.java ! test/sun/security/tools/jarsigner/checkusage.sh ! test/sun/security/tools/jarsigner/collator.sh ! test/sun/security/tools/jarsigner/crl.sh ! test/sun/security/tools/jarsigner/jvindex.sh ! test/sun/security/tools/jarsigner/newsize7.sh ! test/sun/security/tools/jarsigner/onlymanifest.sh ! test/sun/security/tools/jarsigner/passtype.sh ! test/sun/security/tools/jarsigner/samename.sh ! test/sun/security/tools/jarsigner/ts.sh ! test/sun/security/tools/keytool/CloseFile.java ! test/sun/security/tools/keytool/ListKeychainStore.sh ! test/sun/security/tools/keytool/StartDateTest.java ! test/sun/security/tools/keytool/UnknownAndUnparseable.java ! test/sun/security/tools/keytool/emptysubject.sh ! test/sun/security/tools/keytool/importreadall.sh ! test/sun/security/tools/keytool/p12importks.sh ! test/sun/security/tools/keytool/readjar.sh ! test/sun/security/tools/keytool/selfissued.sh ! test/sun/security/tools/keytool/trystore.sh ! test/sun/security/validator/certreplace.sh ! test/sun/security/validator/samedn.sh From jonathan.gibbons at oracle.com Wed Oct 23 00:46:26 2013 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 23 Oct 2013 00:46:26 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20131023004635.B39DA62666@hg.openjdk.java.net> Changeset: 351d6808c1a5 Author: jjg Date: 2013-10-22 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/351d6808c1a5 8027119: Cleanup javadoc comments for taglet API Reviewed-by: mduigou ! src/share/classes/com/sun/javadoc/Tag.java Changeset: 41d3ffca22ff Author: jjg Date: 2013-10-22 17:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/41d3ffca22ff Merge From xuelei.fan at oracle.com Wed Oct 23 02:16:17 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 23 Oct 2013 10:16:17 +0800 Subject: [8] 8012636: OCSP validation fails even when public key is trusted In-Reply-To: <526601FA.1030808@oracle.com> References: <52659E6F.7020806@oracle.com> <526601FA.1030808@oracle.com> Message-ID: <52673171.1060506@oracle.com> OCSPResponse.java ================ line 442-445: ------------- I like the old style that once the certs in response is not empty, we should check that the cert are trusted. This update may ignore the certs in response. Xuelei On 10/22/2013 12:41 PM, Xuelei Fan wrote: > OCSPRequest.java > ================ > line 79-80, Note that Debug.getInstance("certpath") may return null. > Looks like don't need dump variable any more. > > OCSPResponse.java > ================ > line 134-135. > ------------- > Debug.getInstance("certpath") may return null. May not need dump variable. > > line 299: > --------- > byte[] responderKey = seq.getData().getOctetString(); > > I was wondering the variable may be responderKeyId: > responderKeyId = seq.getData().getOctetString(); > > line 380-381: > ------------- > Per RFC 2560, responderKeyId is a SHA-1 hash of responder's public key. > The value may be not the SubjectKeyIdentifier in a certificate per RFC > 5280. > > line 373-384: > ------------- > Why only include certs that match the responderID? I was wondering that > these certs is used to build a full certification path. The cert does > not match the responderID may be used as intermediate cert of a path. > > line 442-445: > ------------- > Need more time to parse the following update. > > Xuelei > > On 10/22/2013 5:36 AM, Vincent Ryan wrote: >> Please review this fix to support key-rollover certs >> (same name, different keys): >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8012636 >> Webrev: http://cr.openjdk.java.net/~vinnie/8012636/webrev.00/ >> >> This issue arises when an OCSP responder replaces its public key >> but retains its subject name. The OCSP client must be able to >> validate responses signed by both keys. >> >> Thanks. > From michael.x.mcmahon at oracle.com Wed Oct 23 10:04:28 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Wed, 23 Oct 2013 10:04:28 +0000 Subject: hg: jdk8/tl/jdk: 8025734: Use literal IP address where possible in SocketPermission generated by HttpURLPermission Message-ID: <20131023100553.8290C62675@hg.openjdk.java.net> Changeset: 1b0dfa631b6f Author: michaelm Date: 2013-10-23 11:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b0dfa631b6f 8025734: Use literal IP address where possible in SocketPermission generated by HttpURLPermission Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/java/net/URLPermission/nstest/LookupTest.java + test/java/net/URLPermission/nstest/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor + test/java/net/URLPermission/nstest/SimpleNameService.java + test/java/net/URLPermission/nstest/SimpleNameServiceDescriptor.java + test/java/net/URLPermission/nstest/policy From vincent.x.ryan at oracle.com Wed Oct 23 10:44:31 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 23 Oct 2013 11:44:31 +0100 Subject: [8] 8012636: OCSP validation fails even when public key is trusted In-Reply-To: <526601FA.1030808@oracle.com> References: <52659E6F.7020806@oracle.com> <526601FA.1030808@oracle.com> Message-ID: <5267A88F.70905@oracle.com> Thanks for your review. Some comments below. On 22/10/2013 05:41, Xuelei Fan wrote: > OCSPRequest.java > ================ > line 79-80, Note that Debug.getInstance("certpath") may return null. > Looks like don't need dump variable any more. Although null is returned it is not a problem since the isOn method is a static. > > OCSPResponse.java > ================ > line 134-135. > ------------- > Debug.getInstance("certpath") may return null. May not need dump variable. As above. > > line 299: > --------- > byte[] responderKey = seq.getData().getOctetString(); > > I was wondering the variable may be responderKeyId: > responderKeyId = seq.getData().getOctetString(); That's an error. I've corrected that. > > line 380-381: > ------------- > Per RFC 2560, responderKeyId is a SHA-1 hash of responder's public key. > The value may be not the SubjectKeyIdentifier in a certificate per RFC > 5280. True. But if the formats don't match then that's a configuration problem that will affect other OCSP clients too. I could generate a new hash for the comparison but that seemed expensive. > > line 373-384: > ------------- > Why only include certs that match the responderID? I was wondering that > these certs is used to build a full certification path. The cert does > not match the responderID may be used as intermediate cert of a path. Currently, certpath validation is not performed for the responder cert. > > line 442-445: > ------------- > Need more time to parse the following update. > > Xuelei > > On 10/22/2013 5:36 AM, Vincent Ryan wrote: >> Please review this fix to support key-rollover certs >> (same name, different keys): >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8012636 >> Webrev: http://cr.openjdk.java.net/~vinnie/8012636/webrev.00/ >> >> This issue arises when an OCSP responder replaces its public key >> but retains its subject name. The OCSP client must be able to >> validate responses signed by both keys. >> >> Thanks. > From jan.lahoda at oracle.com Wed Oct 23 10:50:12 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Wed, 23 Oct 2013 10:50:12 +0000 Subject: hg: jdk8/tl/langtools: 8026508: Invokedynamic instructions don't get line number table entries Message-ID: <20131023105049.42B6362678@hg.openjdk.java.net> Changeset: b05db8c815e8 Author: jlahoda Date: 2013-10-23 07:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b05db8c815e8 8026508: Invokedynamic instructions don't get line number table entries Summary: Setting or correcting positions for many trees produced by LambdaToMethod. Reviewed-by: vromero, rfield ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/T8019486/WrongLNTForLambdaTest.java - test/tools/javac/T8019486/WrongLVTForLambdaTest.java From xuelei.fan at oracle.com Wed Oct 23 11:20:53 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Wed, 23 Oct 2013 19:20:53 +0800 Subject: [8] 8012636: OCSP validation fails even when public key is trusted In-Reply-To: <5267A88F.70905@oracle.com> References: <52659E6F.7020806@oracle.com> <526601FA.1030808@oracle.com> <5267A88F.70905@oracle.com> Message-ID: <5267B115.5020500@oracle.com> On 10/23/2013 6:44 PM, Vincent Ryan wrote: > On 22/10/2013 05:41, Xuelei Fan wrote: >> OCSPRequest.java >> ================ >> line 79-80, Note that Debug.getInstance("certpath") may return null. >> Looks like don't need dump variable any more. > > Although null is returned it is not a problem since the isOn method > is a static. > You also call debug.println(). I think what you want to do is to dump debug log when "certpath" is on. If you won't check "debug != null", Debug.getInstance("certpath") does not make sense, I think. >> >> OCSPResponse.java >> ================ >> line 134-135. >> ------------- >> Debug.getInstance("certpath") may return null. May not need dump >> variable. > As above. Xuelei From vincent.x.ryan at oracle.com Wed Oct 23 11:42:25 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 23 Oct 2013 12:42:25 +0100 Subject: [8] 8012636: OCSP validation fails even when public key is trusted In-Reply-To: <5267B115.5020500@oracle.com> References: <52659E6F.7020806@oracle.com> <526601FA.1030808@oracle.com> <5267A88F.70905@oracle.com> <5267B115.5020500@oracle.com> Message-ID: <5267B621.5090007@oracle.com> On 23/10/2013 12:20, Xuelei Fan wrote: > On 10/23/2013 6:44 PM, Vincent Ryan wrote: >> On 22/10/2013 05:41, Xuelei Fan wrote: >>> OCSPRequest.java >>> ================ >>> line 79-80, Note that Debug.getInstance("certpath") may return null. >>> Looks like don't need dump variable any more. >> >> Although null is returned it is not a problem since the isOn method >> is a static. >> > You also call debug.println(). I think what you want to do is to dump > debug log when "certpath" is on. If you won't check "debug != null", > Debug.getInstance("certpath") does not make sense, I think. Ah. Now I understand. I'll make that correction. > >>> >>> OCSPResponse.java >>> ================ >>> line 134-135. >>> ------------- >>> Debug.getInstance("certpath") may return null. May not need dump >>> variable. >> > As above. > > Xuelei > From staffan.larsen at oracle.com Wed Oct 23 14:05:43 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 23 Oct 2013 14:05:43 +0000 Subject: hg: jdk8/tl/jdk: 8026789: Update test/java/lang/instrument/Re(transform|define)BigClass.sh test to use NMT for memory leak detection Message-ID: <20131023140613.0642362689@hg.openjdk.java.net> Changeset: 8c20e9ef8709 Author: sla Date: 2013-10-23 15:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c20e9ef8709 8026789: Update test/java/lang/instrument/Re(transform|define)BigClass.sh test to use NMT for memory leak detection Reviewed-by: dcubed ! test/ProblemList.txt + test/java/lang/instrument/NMTHelper.java ! test/java/lang/instrument/RedefineBigClass.sh ! test/java/lang/instrument/RedefineBigClassApp.java ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/RetransformBigClassApp.java From chris.hegarty at oracle.com Wed Oct 23 13:39:16 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 23 Oct 2013 13:39:16 +0000 Subject: hg: jdk8/tl/jdk: 8020758: HttpCookie constructor does not throw IAE when name contains a space Message-ID: <20131023133946.0C7DA62687@hg.openjdk.java.net> Changeset: f120672b91ef Author: chegar Date: 2013-10-23 14:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f120672b91ef 8020758: HttpCookie constructor does not throw IAE when name contains a space Reviewed-by: michaelm, msheppar ! src/share/classes/java/net/HttpCookie.java ! test/java/net/CookieHandler/TestHttpCookie.java From vincent.x.ryan at oracle.com Wed Oct 23 15:24:10 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 23 Oct 2013 16:24:10 +0100 Subject: [8] 8012636: OCSP validation fails even when public key is trusted In-Reply-To: <5266A26D.20906@oracle.com> References: <52659E6F.7020806@oracle.com> <5266A26D.20906@oracle.com> Message-ID: <754C0F12-3149-4270-B01F-18D297281A8B@oracle.com> Thanks. I've made those recommended changes. On 22 Oct 2013, at 17:06, Sean Mullan wrote: > I am still reviewing, but here are some comments so far: > > * X509CertImpl > > I would prefer if getSubjectKeyIdentifier returned a KeyIdentifier so that it is consistent with the getAuthKeyId method. Also, in OCSPResponse, you can then just call KeyIdentifier.equals instead of comparing the bytes yourself with Arrays.equals. > > * RevocationChecker > > RevocationChecker can be re-used for subsequent revocation checks by calling the init method. So, you need to clear the contents of the responderCerts list each time init is called. You can add this after line 323 in the init method > > responderCerts.clear(); > > --Sean > > On 10/21/2013 05:36 PM, Vincent Ryan wrote: >> Please review this fix to support key-rollover certs >> (same name, different keys): >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8012636 >> Webrev: http://cr.openjdk.java.net/~vinnie/8012636/webrev.00/ >> >> This issue arises when an OCSP responder replaces its public key >> but retains its subject name. The OCSP client must be able to >> validate responses signed by both keys. >> >> Thanks. > From alexander.zuev at oracle.com Wed Oct 23 14:40:51 2013 From: alexander.zuev at oracle.com (alexander.zuev at oracle.com) Date: Wed, 23 Oct 2013 14:40:51 +0000 Subject: hg: jdk8/tl/jdk: 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking Message-ID: <20131023144119.06BEB6268B@hg.openjdk.java.net> Changeset: 3cdf6ca3ef47 Author: kizune Date: 2013-10-23 18:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3cdf6ca3ef47 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking Reviewed-by: alanb, ksrini ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/jar/resources/jar.properties + test/tools/jar/normalize/TestNormal.java From sean.coffey at oracle.com Wed Oct 23 16:00:59 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Wed, 23 Oct 2013 16:00:59 +0000 Subject: hg: jdk8/tl/jdk: 5036554: unmarshal error on CORBA alias type in CORBA any Message-ID: <20131023160209.B5AA062696@hg.openjdk.java.net> Changeset: 2af3f5a61322 Author: coffeys Date: 2013-10-23 16:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2af3f5a61322 5036554: unmarshal error on CORBA alias type in CORBA any Reviewed-by: chegar, smarks + test/com/sun/corba/5036554/JavaBug.java + test/com/sun/corba/5036554/README + test/com/sun/corba/5036554/TestCorbaBug.sh + test/com/sun/corba/5036554/bug.idl From sean.coffey at oracle.com Wed Oct 23 15:56:52 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Wed, 23 Oct 2013 15:56:52 +0000 Subject: hg: jdk8/tl/corba: 5036554: unmarshal error on CORBA alias type in CORBA any Message-ID: <20131023155701.2BAAE62693@hg.openjdk.java.net> Changeset: a90e9efa4264 Author: coffeys Date: 2013-10-23 16:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a90e9efa4264 5036554: unmarshal error on CORBA alias type in CORBA any Reviewed-by: chegar, smarks ! src/share/classes/com/sun/corba/se/impl/corba/AnyImpl.java From sundararajan.athijegannathan at oracle.com Wed Oct 23 16:29:42 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Wed, 23 Oct 2013 16:29:42 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20131023162955.2458562698@hg.openjdk.java.net> Changeset: 5df55690fd5b Author: sundar Date: 2013-10-23 17:30 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5df55690fd5b 8027128: jdk.nashorn.api.scripting.JSObject should be an interface Reviewed-by: hannesw, attila, jlaskey + src/jdk/nashorn/api/scripting/AbstractJSObject.java ! src/jdk/nashorn/api/scripting/JSObject.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java ! test/script/basic/JDK-8024847.js ! test/script/basic/JDK-8024847.js.EXPECTED ! test/src/jdk/nashorn/api/scripting/PluggableJSObjectTest.java ! test/src/jdk/nashorn/api/scripting/ScriptObjectMirrorTest.java Changeset: f31ee3a2847d Author: sundar Date: 2013-10-23 20:15 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f31ee3a2847d 8027150: ScriptObjectListAdapter won't work as expected Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/runtime/ListAdapter.java - src/jdk/nashorn/internal/runtime/ScriptObjectListAdapter.java Changeset: 640c1854f742 Author: sundar Date: 2013-10-23 20:21 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/640c1854f742 Merge - src/jdk/nashorn/internal/runtime/ScriptObjectListAdapter.java From robert.field at oracle.com Wed Oct 23 17:28:49 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Wed, 23 Oct 2013 17:28:49 +0000 Subject: hg: jdk8/tl/langtools: 8022720: Method refeerences - private method should be accessible (nested classes) Message-ID: <20131023172853.4DBC46269B@hg.openjdk.java.net> Changeset: 32ea6ccb7607 Author: rfield Date: 2013-10-23 10:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/32ea6ccb7607 8022720: Method refeerences - private method should be accessible (nested classes) Reviewed-by: jjg, ksrini ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/privateMethodReferences/MethodInvoker.java + test/tools/javac/lambda/privateMethodReferences/MethodSupplier.java + test/tools/javac/lambda/privateMethodReferences/ThirdClass.java From vincent.x.ryan at oracle.com Wed Oct 23 18:37:05 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Wed, 23 Oct 2013 19:37:05 +0100 Subject: [8] 8012636: OCSP validation fails even when public key is trusted In-Reply-To: <52673171.1060506@oracle.com> References: <52659E6F.7020806@oracle.com> <526601FA.1030808@oracle.com> <52673171.1060506@oracle.com> Message-ID: <6D11F801-79A2-4CF3-98DE-AA274A354FAE@oracle.com> That behaviour hasn't changed. The certs returned in the OCSP Response are still checked for trust: now they must satisfy the Authorized Responder tests. Previously, the cert returned in the OCSP Response was first matched against the trusted responder. That's no longer needed as all the trusted responders are examined (separately) in a previous step. On 23 Oct 2013, at 03:16, Xuelei Fan wrote: > OCSPResponse.java > ================ > line 442-445: > ------------- > I like the old style that once the certs in response is not empty, we > should check that the cert are trusted. This update may ignore the > certs in response. > > Xuelei > > > On 10/22/2013 12:41 PM, Xuelei Fan wrote: >> OCSPRequest.java >> ================ >> line 79-80, Note that Debug.getInstance("certpath") may return null. >> Looks like don't need dump variable any more. >> >> OCSPResponse.java >> ================ >> line 134-135. >> ------------- >> Debug.getInstance("certpath") may return null. May not need dump variable. >> >> line 299: >> --------- >> byte[] responderKey = seq.getData().getOctetString(); >> >> I was wondering the variable may be responderKeyId: >> responderKeyId = seq.getData().getOctetString(); >> >> line 380-381: >> ------------- >> Per RFC 2560, responderKeyId is a SHA-1 hash of responder's public key. >> The value may be not the SubjectKeyIdentifier in a certificate per RFC >> 5280. >> >> line 373-384: >> ------------- >> Why only include certs that match the responderID? I was wondering that >> these certs is used to build a full certification path. The cert does >> not match the responderID may be used as intermediate cert of a path. >> >> line 442-445: >> ------------- >> Need more time to parse the following update. >> >> Xuelei >> >> On 10/22/2013 5:36 AM, Vincent Ryan wrote: >>> Please review this fix to support key-rollover certs >>> (same name, different keys): >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8012636 >>> Webrev: http://cr.openjdk.java.net/~vinnie/8012636/webrev.00/ >>> >>> This issue arises when an OCSP responder replaces its public key >>> but retains its subject name. The OCSP client must be able to >>> validate responses signed by both keys. >>> >>> Thanks. >> > From robert.field at oracle.com Wed Oct 23 18:37:36 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Wed, 23 Oct 2013 18:37:36 +0000 Subject: hg: jdk8/tl/jdk: 8027176: Remove redundant jdk/lambda/vm/DefaultMethodsTest.java Message-ID: <20131023183806.10E2B6269D@hg.openjdk.java.net> Changeset: 88acc99132e2 Author: rfield Date: 2013-10-23 11:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88acc99132e2 8027176: Remove redundant jdk/lambda/vm/DefaultMethodsTest.java Reviewed-by: ksrini - test/jdk/lambda/vm/DefaultMethodsTest.java From sean.coffey at oracle.com Wed Oct 23 19:54:25 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Wed, 23 Oct 2013 19:54:25 +0000 Subject: hg: jdk8/tl/jdk: 8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly aurora test runs Message-ID: <20131023195510.255C4626A3@hg.openjdk.java.net> Changeset: ee7f1c78bec7 Author: coffeys Date: 2013-10-23 20:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee7f1c78bec7 8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly aurora test runs Reviewed-by: chegar ! test/javax/xml/ws/clientjar/TestWsImport.java From erik.gahlin at oracle.com Wed Oct 23 08:51:15 2013 From: erik.gahlin at oracle.com (erik.gahlin at oracle.com) Date: Wed, 23 Oct 2013 08:51:15 +0000 Subject: hg: jdk8/tl/jdk: 7105883: JDWP: agent crash if there exists a ThreadGroup with null name Message-ID: <20131023085207.791F162674@hg.openjdk.java.net> Changeset: c077a2810782 Author: egahlin Date: 2013-10-23 10:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c077a2810782 7105883: JDWP: agent crash if there exists a ThreadGroup with null name Reviewed-by: sla, jbachorik ! src/share/back/ThreadGroupReferenceImpl.c + test/com/sun/jdi/NullThreadGroupNameTest.java From jaroslav.bachorik at oracle.com Wed Oct 23 13:08:27 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Wed, 23 Oct 2013 13:08:27 +0000 Subject: hg: jdk8/tl/jdk: 7112404: 2 tests in java/lang/management/ManagementFactory fails with G1 because expect non-zero pools Message-ID: <20131023130859.9146862686@hg.openjdk.java.net> Changeset: f4970c7abe93 Author: jbachorik Date: 2013-10-23 15:03 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4970c7abe93 7112404: 2 tests in java/lang/management/ManagementFactory fails with G1 because expect non-zero pools Reviewed-by: mchung, sjiang ! test/java/lang/management/ManagementFactory/ProxyTypeMapping.java ! test/java/lang/management/ManagementFactory/ValidateOpenTypes.java From bhavesh.x.patel at oracle.com Wed Oct 23 20:57:54 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Wed, 23 Oct 2013 20:57:54 +0000 Subject: hg: jdk8/tl/langtools: 8026770: javadoc creates invalid HTML in profile summary pages Message-ID: <20131023205809.E7B2B626A6@hg.openjdk.java.net> Changeset: 8746caa5cf80 Author: bpatel Date: 2013-10-23 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8746caa5cf80 8026770: javadoc creates invalid HTML in profile summary pages Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageWriterImpl.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java From jan.lahoda at oracle.com Wed Oct 23 21:03:28 2013 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Wed, 23 Oct 2013 21:03:28 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20131023210339.D1CA0626A7@hg.openjdk.java.net> Changeset: abc3eaccba73 Author: jlahoda Date: 2013-10-23 23:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abc3eaccba73 8027191: Fix for JDK-8026861 refers to an incorrect bug number Summary: Reverting changeset b05db8c815e8, so that it can be applied again with a correct bug number Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java - test/tools/javac/T8019486/WrongLNTForLambdaTest.java + test/tools/javac/T8019486/WrongLVTForLambdaTest.java Changeset: 864dafc5ab7a Author: jlahoda Date: 2013-10-23 07:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/864dafc5ab7a 8026861: Wrong LineNumberTable for variable declarations in lambdas Summary: Setting or correcting positions for many trees produced by LambdaToMethod. Reviewed-by: vromero, rfield ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/T8019486/WrongLNTForLambdaTest.java - test/tools/javac/T8019486/WrongLVTForLambdaTest.java From mike.duigou at oracle.com Wed Oct 23 21:35:33 2013 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Wed, 23 Oct 2013 21:35:33 +0000 Subject: hg: jdk8/tl/jdk: 8024688: further split Map and ConcurrentMap defaults eliminating looping from Map defaults, Map.merge fixes and doc fixes. Message-ID: <20131023213600.7E86A626AD@hg.openjdk.java.net> Changeset: f4129fcfacdc Author: mduigou Date: 2013-10-23 14:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4129fcfacdc 8024688: further split Map and ConcurrentMap defaults eliminating looping from Map defaults, Map.merge fixes and doc fixes. Reviewed-by: psandoz, dholmes ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Map.java ! src/share/classes/java/util/concurrent/ConcurrentMap.java ! test/java/util/Map/Defaults.java From robert.field at oracle.com Wed Oct 23 22:17:34 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Wed, 23 Oct 2013 22:17:34 +0000 Subject: hg: jdk8/tl/jdk: 8025868: Several lang/LMBD JCK tests fail with java.lang.BootstrapMethodError Message-ID: <20131023221756.4D2C0626B2@hg.openjdk.java.net> Changeset: d9d3705a992f Author: rfield Date: 2013-10-23 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9d3705a992f 8025868: Several lang/LMBD JCK tests fail with java.lang.BootstrapMethodError Summary: Wildcard marker interfaces can cause duplicate implemented interfaces in generated lambda class Reviewed-by: briangoetz ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + test/java/lang/invoke/lambda/DupIntf.java From kumar.x.srinivasan at oracle.com Thu Oct 24 01:08:12 2013 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 24 Oct 2013 01:08:12 +0000 Subject: hg: jdk8/tl/langtools: 8026936: Initialize LamdbaToMethod lazily and as required Message-ID: <20131024010818.99367626BD@hg.openjdk.java.net> Changeset: 31fe30e2deac Author: ksrini Date: 2013-10-23 15:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/31fe30e2deac 8026936: Initialize LamdbaToMethod lazily and as required Reviewed-by: jjg, rfield Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java From java3 at segal.org Thu Oct 24 01:49:37 2013 From: java3 at segal.org (Mickey Segal) Date: Wed, 23 Oct 2013 21:49:37 -0400 Subject: InvocationTargetException when running applet locally In-Reply-To: <526574B3.2010201@oracle.com> References: <000901cecc42$d5225d30$7f671790$@segal.org> <526574B3.2010201@oracle.com> Message-ID: <00e101ced05b$4ca339d0$e5e9ad70$@segal.org> Thanks for the information. I apologize for the delay in responding; the reason will become clear below. I'll need to get up to speed on JNLP and will be able to do this until the conference I'm at ends and Saturday and I have a few days off before the next conference. However, reading through the release notes I would have guessed that the problem is the one labeled "Non-JNLP trusted applet fails to load using the file:\\ URL." I'll need to read up about JNLP to try these workarounds. I also found that the problem is even worse on Windows 8.1 on a Microsoft Surface 2. The applet at http://www.segal.org/java/SignedAppletTest/ doesn't run locally using either Internet Explorer (version 11) or Firefox, even using Java 8 build 111. Fortunately our main applet, which this test applet was made to mimic, does run using Firefox and 8 b111, so I'm able to demonstrate the software at the conference (but it doesn't run locally on IE 11 even using 8 build 111). But I discovered this at 2:30 AM (the Surface went on sale at midnight) and got virtually no sleep that night because it took a while to find the Firefox workaround and I needed to be back at the conference early in the morning. I usually answer email sooner, but it has been a rough few days, but all of those who are working on Java and occasionally hear claims that it Java slow will be gratified to know that we can run a clinical analysis of a genome in under a second on Microsoft's new tablet using Java. Once we can solve the problem with running locally we will feel better, and get more sleep. -----Original Message----- From: Sean Mullan [mailto:sean.mullan at oracle.com] Sent: Monday, October 21, 2013 2:39 PM I think this is a known issue. There is a workaround documented in the JDK 7u45 release notes, can you try it out? See "JNLP applet fails to load if using JNLP versioning.": http://www.oracle.com/technetwork/java/javase/7u45-relnotes-2016950.html From eric.mccorkle at oracle.com Thu Oct 24 03:21:23 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Thu, 24 Oct 2013 03:21:23 +0000 Subject: hg: jdk8/tl/langtools: 8006732: support correct bytecode storage of type annotations in multicatch Message-ID: <20131024032129.B1B0B626C2@hg.openjdk.java.net> Changeset: d2fa3f7e964e Author: emc Date: 2013-10-23 23:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d2fa3f7e964e 8006732: support correct bytecode storage of type annotations in multicatch Summary: Fix issue with annotations being added before attribution, which causes multicatch not to work right and several tests to fail. Reviewed-by: jfranck, jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass2.java ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass2.out ! test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java From eric.mccorkle at oracle.com Thu Oct 24 05:27:49 2013 From: eric.mccorkle at oracle.com (eric.mccorkle at oracle.com) Date: Thu, 24 Oct 2013 05:27:49 +0000 Subject: hg: jdk8/tl/langtools: 8023682: Incorrect attributes emitted for anonymous class declaration Message-ID: <20131024052756.77835626C5@hg.openjdk.java.net> Changeset: 119747cd9f25 Author: emc Date: 2013-10-24 01:27 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/119747cd9f25 8023682: Incorrect attributes emitted for anonymous class declaration Summary: Cause javac to emit type annotations on new instruction as well as anonymous class supertype for annotated anonymous classes. Reviewed-by: jjg, jfranck ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/annotations/typeAnnotations/failures/TypeOnAnonClass.java + test/tools/javac/annotations/typeAnnotations/failures/TypeOnAnonClass.out ! test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.out ! test/tools/javac/annotations/typeAnnotations/newlocations/AnonymousClass.java From dan.xu at oracle.com Thu Oct 24 05:31:31 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Thu, 24 Oct 2013 05:31:31 +0000 Subject: hg: jdk8/tl/jdk: 7122887: JDK ignores Gnome3 proxy settings Message-ID: <20131024053218.77ACD626C6@hg.openjdk.java.net> Changeset: c9562ac9b812 Author: dxu Date: 2013-10-23 22:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9562ac9b812 7122887: JDK ignores Gnome3 proxy settings Summary: Fix GConf and add to use GProxyResolver to handle network proxy resolution Reviewed-by: chegar ! src/solaris/native/sun/net/spi/DefaultProxySelector.c ! test/java/net/ProxySelector/SystemProxies.java From staffan.larsen at oracle.com Thu Oct 24 07:55:02 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Thu, 24 Oct 2013 07:55:02 +0000 Subject: hg: jdk8/tl/jdk: 8009681: TEST_BUG: MethodExitReturnValuesTest.java may fail when there are unexpected background threads Message-ID: <20131024075601.D6FB4626CC@hg.openjdk.java.net> Changeset: e6bc0dca294b Author: sla Date: 2013-10-15 12:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6bc0dca294b 8009681: TEST_BUG: MethodExitReturnValuesTest.java may fail when there are unexpected background threads Reviewed-by: sla, allwin Contributed-by: mikael.auno at oracle.com ! test/com/sun/jdi/MethodEntryExitEvents.java ! test/com/sun/jdi/MethodExitReturnValuesTest.java From alan.bateman at oracle.com Thu Oct 24 12:33:45 2013 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 24 Oct 2013 12:33:45 +0000 Subject: hg: jdk8/tl/jdk: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable Message-ID: <20131024123510.1759D626D3@hg.openjdk.java.net> Changeset: 700d62b8d9cc Author: alanb Date: 2013-10-24 13:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/700d62b8d9cc 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable Reviewed-by: rriggs, psandoz, chegar Contributed-by: dl at cs.oswego.edu, alan.bateman at oracle.com ! src/share/classes/java/util/concurrent/atomic/DoubleAccumulator.java ! src/share/classes/java/util/concurrent/atomic/DoubleAdder.java ! src/share/classes/java/util/concurrent/atomic/LongAccumulator.java ! src/share/classes/java/util/concurrent/atomic/LongAdder.java + test/java/util/concurrent/atomic/Serial.java From rob.mckenna at oracle.com Thu Oct 24 13:28:21 2013 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Thu, 24 Oct 2013 13:28:21 +0000 Subject: hg: jdk8/tl/jdk: 8024521: (process) Async close issues with Process InputStream Message-ID: <20131024132846.2F1B3626D6@hg.openjdk.java.net> Changeset: e2ec05b2ed94 Author: igerasim Date: 2013-10-23 15:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2ec05b2ed94 8024521: (process) Async close issues with Process InputStream Reviewed-by: psandoz, martin, alanb, robm ! src/solaris/classes/java/lang/UNIXProcess.java.bsd ! src/solaris/classes/java/lang/UNIXProcess.java.linux + test/java/lang/Runtime/exec/CloseRace.java From stuart.marks at oracle.com Thu Oct 24 17:14:00 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Thu, 24 Oct 2013 17:14:00 +0000 Subject: hg: jdk8/tl/jdk: 8023862: deprecate HTTP proxying from RMI Message-ID: <20131024171414.72C13626F3@hg.openjdk.java.net> Changeset: 808b9ef4f667 Author: smarks Date: 2013-10-24 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/808b9ef4f667 8023862: deprecate HTTP proxying from RMI Reviewed-by: mchung ! src/share/classes/java/rmi/server/RMISocketFactory.java ! src/share/classes/java/rmi/server/package.html ! src/share/classes/sun/rmi/transport/proxy/RMIMasterSocketFactory.java + test/sun/rmi/transport/proxy/DisableHttpDefaultValue.java From brian.goetz at oracle.com Thu Oct 24 17:15:29 2013 From: brian.goetz at oracle.com (brian.goetz at oracle.com) Date: Thu, 24 Oct 2013 17:15:29 +0000 Subject: hg: jdk8/tl/jdk: 8019646: Clarify javadoc contract of LambdaMetafactory Message-ID: <20131024171544.B121B626F4@hg.openjdk.java.net> Changeset: 5fa2fd782993 Author: briangoetz Date: 2013-10-24 13:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5fa2fd782993 8019646: Clarify javadoc contract of LambdaMetafactory Reviewed-by: briangoetz, rfield Contributed-by: dan.smith at oracle.com ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/share/classes/java/lang/invoke/LambdaMetafactory.java From joel.franck at oracle.com Thu Oct 24 17:21:27 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Thu, 24 Oct 2013 17:21:27 +0000 Subject: hg: jdk8/tl/jdk: 8023651: j.l.r.Constructor.getAnnotatedReceiverType() and j.l.r.Constructor.getAnnotatedReturnType() for inner classes return incorrect result Message-ID: <20131024172140.9227E626F5@hg.openjdk.java.net> Changeset: 93e696ba5923 Author: jfranck Date: 2013-10-24 19:04 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93e696ba5923 8023651: j.l.r.Constructor.getAnnotatedReceiverType() and j.l.r.Constructor.getAnnotatedReturnType() for inner classes return incorrect result Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java + test/java/lang/annotation/typeAnnotations/ConstructorReceiverTest.java From joel.franck at oracle.com Thu Oct 24 16:54:10 2013 From: joel.franck at oracle.com (joel.franck at oracle.com) Date: Thu, 24 Oct 2013 16:54:10 +0000 Subject: hg: jdk8/tl/jdk: 8027170: Annotations declared on super-super-class should be overridden by super-class. Message-ID: <20131024165457.41DF4626F0@hg.openjdk.java.net> Changeset: b8927cbfb893 Author: alundblad Date: 2013-10-24 18:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b8927cbfb893 8027170: Annotations declared on super-super-class should be overridden by super-class. Reviewed-by: jfranck Contributed-by: andreas.lundblad at oracle.com, peter.levart at gmail.com ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/System.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/reflect/annotation/AnnotationSupport.java + test/java/lang/annotation/repeatingAnnotations/InheritedAssociatedAnnotations.java From christian.thalinger at oracle.com Thu Oct 24 17:52:55 2013 From: christian.thalinger at oracle.com (christian.thalinger at oracle.com) Date: Thu, 24 Oct 2013 17:52:55 +0000 Subject: hg: jdk8/tl/jdk: 8026502: java/lang/invoke/MethodHandleConstants.java fails on all platforms Message-ID: <20131024175306.BA330626F6@hg.openjdk.java.net> Changeset: 66884b270b44 Author: twisti Date: 2013-10-24 10:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/66884b270b44 8026502: java/lang/invoke/MethodHandleConstants.java fails on all platforms Reviewed-by: iveresov, jrose ! src/share/classes/java/lang/invoke/MethodHandles.java From xueming.shen at oracle.com Thu Oct 24 18:15:13 2013 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 24 Oct 2013 18:15:13 +0000 Subject: hg: jdk8/tl/jdk: 8025003: Base64 should be less strict with padding Message-ID: <20131024181536.C272A626F7@hg.openjdk.java.net> Changeset: e7bdb2fcc7bc Author: sherman Date: 2013-10-24 11:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7bdb2fcc7bc 8025003: Base64 should be less strict with padding Summary: updated spec and implementation of mime decoder to be lenient for padding Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/Base64GetEncoderTest.java ! test/java/util/Base64/TestBase64.java ! test/java/util/Base64/TestBase64Golden.java From bhavesh.x.patel at oracle.com Thu Oct 24 18:24:17 2013 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Thu, 24 Oct 2013 18:24:17 +0000 Subject: hg: jdk8/tl/langtools: 8006248: Since addition of -Xdoclint, javadoc ignores unknown tags Message-ID: <20131024182422.A6CB9626F9@hg.openjdk.java.net> Changeset: 667843bd2193 Author: bpatel Date: 2013-10-24 11:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/667843bd2193 8006248: Since addition of -Xdoclint, javadoc ignores unknown tags Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/Env.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java + test/com/sun/javadoc/testCustomTag/TagTestClass.java + test/com/sun/javadoc/testCustomTag/TestCustomTag.java + test/com/sun/javadoc/testCustomTag/taglets/CustomTag.java + test/tools/doclint/CustomTagTest.java + test/tools/doclint/CustomTagTest.out + test/tools/doclint/CustomTagTestWithOption.out ! test/tools/doclint/DocLintTester.java From huizhe.wang at oracle.com Thu Oct 24 20:46:19 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Thu, 24 Oct 2013 20:46:19 +0000 Subject: hg: jdk8/tl/jaxp: 8004476: XSLT Extension Functions Don't Work in WebStart Message-ID: <20131024204635.A5A19626FF@hg.openjdk.java.net> Changeset: 390e94b9a852 Author: joehw Date: 2013-10-24 13:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/390e94b9a852 8004476: XSLT Extension Functions Don't Work in WebStart Reviewed-by: dfuchs, lancea, alanb ! src/com/sun/org/apache/xalan/internal/XalanConstants.java + src/com/sun/org/apache/xalan/internal/utils/FeatureManager.java + src/com/sun/org/apache/xalan/internal/utils/FeaturePropertyBase.java ! src/com/sun/org/apache/xalan/internal/utils/XMLSecurityManager.java ! src/com/sun/org/apache/xalan/internal/utils/XMLSecurityPropertyManager.java ! src/com/sun/org/apache/xalan/internal/xsltc/cmdline/Compile.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/utils/SecuritySupport.java ! src/com/sun/org/apache/xpath/internal/jaxp/JAXPExtensionsProvider.java ! src/com/sun/org/apache/xpath/internal/jaxp/XPathExpressionImpl.java ! src/com/sun/org/apache/xpath/internal/jaxp/XPathFactoryImpl.java ! src/com/sun/org/apache/xpath/internal/jaxp/XPathImpl.java From huizhe.wang at oracle.com Thu Oct 24 21:15:06 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Thu, 24 Oct 2013 21:15:06 +0000 Subject: hg: jdk8/tl/jdk: 8004476: XSLT Extension Functions Don't Work in WebStart Message-ID: <20131024211529.D722162701@hg.openjdk.java.net> Changeset: 05dbf105e70f Author: joehw Date: 2013-10-24 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/05dbf105e70f 8004476: XSLT Extension Functions Don't Work in WebStart Reviewed-by: dfuchs, lancea, alanb + test/javax/xml/jaxp/transform/jdk8004476/SecureProcessingTest.xml + test/javax/xml/jaxp/transform/jdk8004476/TestBase.java + test/javax/xml/jaxp/transform/jdk8004476/XPathExFuncTest.java + test/javax/xml/jaxp/transform/jdk8004476/XSLTExFuncTest.java + test/javax/xml/jaxp/transform/jdk8004476/tokenize.xml + test/javax/xml/jaxp/transform/jdk8004476/tokenize.xsl From robert.field at oracle.com Thu Oct 24 23:53:07 2013 From: robert.field at oracle.com (robert.field at oracle.com) Date: Thu, 24 Oct 2013 23:53:07 +0000 Subject: hg: jdk8/tl/langtools: 8027220: DefaultMethodsTest: Change test to match spec Message-ID: <20131024235318.723B06270F@hg.openjdk.java.net> Changeset: 860f1d21763a Author: rfield Date: 2013-10-24 16:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/860f1d21763a 8027220: DefaultMethodsTest: Change test to match spec Reviewed-by: ksrini ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/TestHarness.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java From weijun.wang at oracle.com Fri Oct 25 00:39:27 2013 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 25 Oct 2013 00:39:27 +0000 Subject: hg: jdk8/tl/jdk: 8026929: remove accelerators from policytool resources Message-ID: <20131025004104.D37F162710@hg.openjdk.java.net> Changeset: e9ec0ca5bab1 Author: weijun Date: 2013-10-25 08:38 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e9ec0ca5bab1 8026929: remove accelerators from policytool resources Reviewed-by: alexp, weijun Contributed-by: Leif Samuelsson ! src/share/classes/sun/security/tools/policytool/PolicyTool.java ! src/share/classes/sun/security/tools/policytool/Resources.java From vincent.x.ryan at oracle.com Fri Oct 25 01:04:07 2013 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 25 Oct 2013 02:04:07 +0100 Subject: [8] 8012636: OCSP validation fails even when public key is trusted In-Reply-To: <52659E6F.7020806@oracle.com> References: <52659E6F.7020806@oracle.com> Message-ID: <5269C387.8010409@oracle.com> Please review this updated webrev that addresses the comments received so far: http://cr.openjdk.java.net/~vinnie/8012636/webrev.01/ Thanks. On 21/10/2013 22:36, Vincent Ryan wrote: > Please review this fix to support key-rollover certs > (same name, different keys): > > Bug: https://bugs.openjdk.java.net/browse/JDK-8012636 > Webrev: http://cr.openjdk.java.net/~vinnie/8012636/webrev.00/ > > This issue arises when an OCSP responder replaces its public key > but retains its subject name. The OCSP client must be able to > validate responses signed by both keys. > > Thanks. From xuelei.fan at oracle.com Fri Oct 25 03:41:25 2013 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Fri, 25 Oct 2013 11:41:25 +0800 Subject: [8] 8012636: OCSP validation fails even when public key is trusted In-Reply-To: <5269C387.8010409@oracle.com> References: <52659E6F.7020806@oracle.com> <5269C387.8010409@oracle.com> Message-ID: <5269E865.1090800@oracle.com> Looks fine to me. Xuelei On 10/25/2013 9:04 AM, Vincent Ryan wrote: > Please review this updated webrev that addresses the comments received > so far: > > http://cr.openjdk.java.net/~vinnie/8012636/webrev.01/ > > Thanks. > > > On 21/10/2013 22:36, Vincent Ryan wrote: >> Please review this fix to support key-rollover certs >> (same name, different keys): >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8012636 >> Webrev: http://cr.openjdk.java.net/~vinnie/8012636/webrev.00/ >> >> This issue arises when an OCSP responder replaces its public key >> but retains its subject name. The OCSP client must be able to >> validate responses signed by both keys. >> >> Thanks. > From chris.hegarty at oracle.com Fri Oct 25 10:22:48 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 25 Oct 2013 10:22:48 +0000 Subject: hg: jdk8/tl/jdk: 7079145: Remove java/net/ipv6tests/UdpTest.java from the ProblemList.txt Message-ID: <20131025102504.6B5A462738@hg.openjdk.java.net> Changeset: d126301ad372 Author: ewang Date: 2013-10-25 11:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d126301ad372 7079145: Remove java/net/ipv6tests/UdpTest.java from the ProblemList.txt Reviewed-by: alanb, chegar ! test/ProblemList.txt From stuart.marks at oracle.com Fri Oct 25 21:53:31 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 25 Oct 2013 21:53:31 +0000 Subject: hg: jdk8/tl/jdk: 5063500: Formatter spec says "char" is not an integral type; ... Message-ID: <20131025215345.E77FD62770@hg.openjdk.java.net> Changeset: 8ea272253285 Author: smarks Date: 2013-10-25 14:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8ea272253285 5063500: Formatter spec says "char" is not an integral type 7126305: Wrong Unicode value specified for format conversion character 'd' 8027287: incorrect example in Formatter javadoc Reviewed-by: rriggs, darcy, lancea ! src/share/classes/java/util/Formatter.java From java3 at segal.org Sat Oct 26 21:03:44 2013 From: java3 at segal.org (Mickey Segal) Date: Sat, 26 Oct 2013 17:03:44 -0400 Subject: InvocationTargetException when running applet locally In-Reply-To: <526574B3.2010201@oracle.com> References: <000901cecc42$d5225d30$7f671790$@segal.org> <526574B3.2010201@oracle.com> Message-ID: <000501ced28e$dbf4de10$93de9a30$@segal.org> I wasn't using JNLP so I don't know if JNLP versioning was the relevant part of the release notes. The part about " Non-JNLP trusted applet fails to load using the file:\\ URL", however, seemed highly relevant. The recommended approach was " Use a JNLP file to launch the applet" and I tried that modeled after the information at http://www.oracle.com/technetwork/java/javase/index-142562.html but that didn't work. However, I've never used JNLP before so it is possible that I made some error in using JNLP. Someone suggested that the problem relates to compression, but using "jar cfm0" instead of "jar cfm" didn't help, though it did produce an uncompressed JAR file. I'll try again to file the bug report, but 7update45 fails in every environment I've tried except using Vista and turning off the next generation Java plugin, and even that works in Internet Explorer, not Firefox. And on Windows 8, even using 8build111 fails with Internet Explorer, but works with Firefox. Things this brittle make me nervous. It would be good if there were some effort at Oracle to get this fixed quickly or provide more details about workarounds. -----Original Message----- From: Sean Mullan [mailto:sean.mullan at oracle.com] Sent: Monday, October 21, 2013 2:39 PM I think this is a known issue. There is a workaround documented in the JDK 7u45 release notes, can you try it out? See "JNLP applet fails to load if using JNLP versioning.": http://www.oracle.com/technetwork/java/javase/7u45-relnotes-2016950.html From daniel.fuchs at oracle.com Mon Oct 28 13:32:28 2013 From: daniel.fuchs at oracle.com (daniel.fuchs at oracle.com) Date: Mon, 28 Oct 2013 13:32:28 +0000 Subject: hg: jdk8/tl/jdk: 8026863: regression in anonymous Logger.setParent method Message-ID: <20131028133301.E4F9C62795@hg.openjdk.java.net> Changeset: af4dd45bc7f7 Author: dfuchs Date: 2013-10-28 10:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af4dd45bc7f7 8026863: regression in anonymous Logger.setParent method Summary: restore behaviour of setParent in anonymous logger and clarifies the spec with respect to security permissions. Reviewed-by: mchung, prr ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/AnonymousLogger/TestAnonymousLogger.java From java3 at segal.org Mon Oct 28 18:44:23 2013 From: java3 at segal.org (Mickey Segal) Date: Mon, 28 Oct 2013 14:44:23 -0400 Subject: InvocationTargetException when running applet locally In-Reply-To: <000501ced28e$dbf4de10$93de9a30$@segal.org> References: <000901cecc42$d5225d30$7f671790$@segal.org> <526574B3.2010201@oracle.com> <000501ced28e$dbf4de10$93de9a30$@segal.org> Message-ID: <000901ced40d$b9213e30$2b63ba90$@segal.org> The bug described at http://www.segal.org/java/SignedAppletTest/ was successfully submitted to the bug database on 26 October 2013 and assigned a bug number within minutes, presumably by some automated system. As yet, however, nothing has appeared at http://bugs.sun.com/view_bug.do?bug_id=9007738. -----Original Message----- From: security-dev-bounces at openjdk.java.net [mailto:security-dev-bounces at openjdk.java.net] On Behalf Of Mickey Segal Sent: Saturday, October 26, 2013 5:04 PM To: 'Sean Mullan'; security-dev at openjdk.java.net Subject: RE: InvocationTargetException when running applet locally I wasn't using JNLP so I don't know if JNLP versioning was the relevant part of the release notes. The part about " Non-JNLP trusted applet fails to load using the file:\\ URL", however, seemed highly relevant. The recommended approach was " Use a JNLP file to launch the applet" and I tried that modeled after the information at http://www.oracle.com/technetwork/java/javase/index-142562.html but that didn't work. However, I've never used JNLP before so it is possible that I made some error in using JNLP. Someone suggested that the problem relates to compression, but using "jar cfm0" instead of "jar cfm" didn't help, though it did produce an uncompressed JAR file. I'll try again to file the bug report, but 7update45 fails in every environment I've tried except using Vista and turning off the next generation Java plugin, and even that works in Internet Explorer, not Firefox. And on Windows 8, even using 8build111 fails with Internet Explorer, but works with Firefox. Things this brittle make me nervous. It would be good if there were some effort at Oracle to get this fixed quickly or provide more details about workarounds. From lana.steuck at oracle.com Mon Oct 28 21:57:28 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 28 Oct 2013 21:57:28 +0000 Subject: hg: jdk8/tl/nashorn: 2 new changesets Message-ID: <20131028215748.D1815627A9@hg.openjdk.java.net> Changeset: 79f7b79bf97b Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/79f7b79bf97b Added tag jdk8-b113 for changeset 676cd7bf5e09 ! .hgtags Changeset: 767e85d2a1b3 Author: lana Date: 2013-10-28 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/767e85d2a1b3 Merge From lana.steuck at oracle.com Mon Oct 28 21:57:56 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 28 Oct 2013 21:57:56 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20131028215834.5B5E9627AC@hg.openjdk.java.net> Changeset: 127c2e74d2cf Author: tbell Date: 2013-10-22 16:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/127c2e74d2cf 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 54150586ba78 Author: katleman Date: 2013-10-23 08:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/54150586ba78 Merge Changeset: 850d2602ae98 Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/850d2602ae98 Added tag jdk8-b113 for changeset 54150586ba78 ! .hgtags Changeset: 44e3ba40e00c Author: lana Date: 2013-10-28 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/44e3ba40e00c Merge From lana.steuck at oracle.com Mon Oct 28 21:57:28 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 28 Oct 2013 21:57:28 +0000 Subject: hg: jdk8/tl/corba: 3 new changesets Message-ID: <20131028215747.A7C6D627A7@hg.openjdk.java.net> Changeset: a259ff3e42d9 Author: tbell Date: 2013-10-22 16:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a259ff3e42d9 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 0bbccf77c23e Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0bbccf77c23e Added tag jdk8-b113 for changeset a259ff3e42d9 ! .hgtags Changeset: 219e616a6a4f Author: lana Date: 2013-10-28 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/219e616a6a4f Merge From lana.steuck at oracle.com Mon Oct 28 21:58:05 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 28 Oct 2013 21:58:05 +0000 Subject: hg: jdk8/tl/jaxp: 3 new changesets Message-ID: <20131028215828.6FE5C627AB@hg.openjdk.java.net> Changeset: 0046d2278204 Author: tbell Date: 2013-10-22 16:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0046d2278204 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 1b1e12117fe2 Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1b1e12117fe2 Added tag jdk8-b113 for changeset 0046d2278204 ! .hgtags Changeset: 96562bf197f2 Author: lana Date: 2013-10-28 12:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/96562bf197f2 Merge From lana.steuck at oracle.com Mon Oct 28 21:57:34 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 28 Oct 2013 21:57:34 +0000 Subject: hg: jdk8/tl/jaxws: 4 new changesets Message-ID: <20131028215805.27031627AA@hg.openjdk.java.net> Changeset: 17f1b13cd401 Author: simonis Date: 2013-10-21 15:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/17f1b13cd401 8026874: During JAXWS build the newly built JAXP classes should be in the bootclasspath (not only in the classpath) Reviewed-by: erikj ! makefiles/BuildJaxws.gmk Changeset: f20820d1582f Author: katleman Date: 2013-10-22 16:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/f20820d1582f Merge Changeset: 9261f342aa73 Author: tbell Date: 2013-10-22 16:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/9261f342aa73 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 9ad289610fc6 Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/9ad289610fc6 Added tag jdk8-b113 for changeset 9261f342aa73 ! .hgtags From lana.steuck at oracle.com Mon Oct 28 22:00:19 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 28 Oct 2013 22:00:19 +0000 Subject: hg: jdk8/tl/hotspot: 70 new changesets Message-ID: <20131028220619.772AB627AD@hg.openjdk.java.net> Changeset: 7c26dced065e Author: amurillo Date: 2013-10-11 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7c26dced065e 8026265: new hotspot build - hs25-b55 Reviewed-by: jcoomes ! make/hotspot_version Changeset: b4a4fdc1f464 Author: coleenp Date: 2013-10-09 21:45 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b4a4fdc1f464 8025185: MethodHandleInError and MethodTypeInError not handled in ConstantPool::compare_entry_to and copy_entry_to Summary: Add missing cases. Reviewed-by: sspitsyn, dcubed ! src/share/vm/oops/constantPool.cpp Changeset: e831448418ac Author: coleenp Date: 2013-10-09 22:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e831448418ac Merge Changeset: cd7ea1d79dac Author: sla Date: 2013-10-11 13:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cd7ea1d79dac 8026199: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java Compilation failed Summary: Fixed a compilation failure due to changed method name Reviewed-by: sla, jbachorik Contributed-by: fredrik.arvidsson at oracle.com ! test/serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ! test/testlibrary/com/oracle/java/testlibrary/JDKToolLauncher.java Changeset: 539144972c1e Author: sla Date: 2013-10-11 14:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/539144972c1e 8024425: VM_HeapDumper doesn't put anonymous classes in the heap dump Summary: Switched from using SystemDictionary to using ClassLoaderDataGraph to get the anonymous classes included. Reviewed-by: sla, sspitsyn Contributed-by: fredrik.arvidsson at oracle.com ! src/share/vm/services/heapDumper.cpp Changeset: 301ece1880ad Author: sla Date: 2013-10-11 14:57 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/301ece1880ad Merge Changeset: 28ca974cc21a Author: coleenp Date: 2013-10-11 11:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/28ca974cc21a 8022592: assert at constantTag.cpp:57: ShouldNotReachHere() Summary: more missing cases for JVM_CONSTANT_Method{Handle,Type}InError Reviewed-by: hseigel, dcubed ! src/share/vm/oops/constantPool.cpp ! src/share/vm/utilities/constantTag.cpp ! src/share/vm/utilities/constantTag.hpp Changeset: 26ae62bc26c4 Author: coleenp Date: 2013-10-11 15:04 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/26ae62bc26c4 Merge Changeset: 0db3ba3f6870 Author: hseigel Date: 2013-10-11 15:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0db3ba3f6870 8026041: JVM crashes with assert "assert(is_updated()) failed: must not be clear" with -XX:+PrintGCApplicationConcurrentTime in -Xcomp mode Summary: Prior to printing the time interval in RuntimeService::record_safepoint_begin(), check first that VM initialization is complete. Reviewed-by: coleenp, dholmes, sla, ctornqvi Contributed-by: lois.foltan at oracle.com ! src/share/vm/services/runtimeService.cpp Changeset: df268195b0ea Author: hseigel Date: 2013-10-11 17:08 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/df268195b0ea Merge Changeset: 41459da469ae Author: ccheung Date: 2013-10-11 18:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/41459da469ae Merge Changeset: 83dbf427fedd Author: ccheung Date: 2013-10-11 22:22 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/83dbf427fedd Merge Changeset: 3e265ce4d2dd Author: hseigel Date: 2013-10-12 13:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3e265ce4d2dd 8025942: os::Bsd::available_memory() needs implementation Summary: Implement using the host_statistics64() api. Reviewed-by: dsamersoff, morris, dholmes, coleenp, hseigel, dcubed Contributed-by: gerard.ziemski at oracle.com ! src/os/bsd/vm/os_bsd.cpp Changeset: d37a0525c0fe Author: hseigel Date: 2013-10-12 15:39 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d37a0525c0fe 8024667: VM crashes with "assert(method() != NULL) failed: must have set method" Summary: Check if data is in shared spaces before deallocating it. Reviewed-by: coleenp, dcubed ! src/share/vm/memory/metadataFactory.hpp ! src/share/vm/oops/instanceKlass.cpp Changeset: 2f8728d92483 Author: acorn Date: 2013-10-14 21:52 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2f8728d92483 8026299: invokespecial gets ICCE when it should get AME. Reviewed-by: ccheung, coleenp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp Changeset: f509b8f4699b Author: dcubed Date: 2013-10-15 08:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f509b8f4699b 7165611: implement Full Debug Symbols on MacOS X hotspot Summary: Add MacOS X FDS support to hotspot; add minimal MacOS X FDS import support to jdk; add MacOS X FDS support to install; add MacOS X FDS support to root. Reviewed-by: erikj, sla, dholmes, rdurbin, tbell, ihse ! make/Makefile ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/jsig.make ! make/bsd/makefiles/product.make ! make/bsd/makefiles/saproc.make ! make/bsd/makefiles/universal.gmk ! make/bsd/makefiles/vm.make ! make/defs.make Changeset: e8703d708e6e Author: ccheung Date: 2013-10-16 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e8703d708e6e Merge Changeset: 1e814e391ee8 Author: anoll Date: 2013-10-04 09:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1e814e391ee8 8025656: compiler/8013496/Test8013496.sh fails on assert Summary: Ensure the thread is in correct state; rewrote test in Java Reviewed-by: kvn, twisti ! src/share/vm/compiler/compileBroker.cpp - test/compiler/8013496/Test8013496.sh + test/compiler/codecache/CheckReservedInitialCodeCacheSizeArgOrder.java Changeset: 0c4c40f5c399 Author: twisti Date: 2013-10-04 10:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0c4c40f5c399 8011138: C2: stack overflow in compiler thread because of recursive inlining of lambda form methods Reviewed-by: kvn, roland ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/parse.hpp Changeset: 5f1241525a01 Author: twisti Date: 2013-10-04 19:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5f1241525a01 Merge Changeset: bf8a21c3ab3b Author: vlivanov Date: 2013-10-07 14:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bf8a21c3ab3b 8025849: Redundant "pid" in VM log file name (e.g. hotspot_pidpid12345.log) Reviewed-by: twisti, azeemj ! src/share/vm/utilities/ostream.cpp Changeset: 5cc2d82aa82a Author: vlivanov Date: 2013-10-07 14:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5cc2d82aa82a 8024943: ciReplay: fails to dump replay data during safepointing Reviewed-by: kvn, twisti ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/utilities/vmError.cpp Changeset: f478c98e8114 Author: vlivanov Date: 2013-10-07 14:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f478c98e8114 8024774: assert(_con < t->is_tuple()->cnt()) failed: ProjNode::_con must be in range Reviewed-by: iveresov, roland, kvn, twisti ! src/share/vm/opto/parse2.cpp Changeset: 5741fc86a2ee Author: vlivanov Date: 2013-10-07 14:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5741fc86a2ee 8025845: Default methods are unnecessarily marked w/ force_inline directive in some situations Reviewed-by: acorn, kvn ! src/share/vm/classfile/defaultMethods.cpp Changeset: c775af091fe9 Author: twisti Date: 2013-10-07 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c775af091fe9 8025566: EXCEPTION_ACCESS_VIOLATION in compiled by C1 String.valueOf method Reviewed-by: kvn ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/opto/parseHelper.cpp Changeset: d9043b88eeb3 Author: roland Date: 2013-10-03 10:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d9043b88eeb3 8024067: Missing replace_in_map() calls following null checks Summary: add replace_in_map() calls following some null checks in type checks Reviewed-by: kvn ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp Changeset: 17cda06bcb7d Author: iveresov Date: 2013-10-08 07:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/17cda06bcb7d Merge ! src/share/vm/classfile/defaultMethods.cpp - test/compiler/8013496/Test8013496.sh Changeset: 6171eb9da4fd Author: twisti Date: 2013-10-08 19:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6171eb9da4fd 8007923: Tests on references fails Reviewed-by: kvn, iveresov ! src/share/vm/ci/ciKlass.cpp ! src/share/vm/opto/escape.cpp Changeset: 98692a2d36d7 Author: adlertz Date: 2013-10-09 13:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/98692a2d36d7 8013830: [parfait] Uninitialised pointer 'Reachblock' may be used as argument Summary: Replace uninitialised pointer with NULL at argument. Reviewed-by: kvn, roland, twisti ! src/share/vm/opto/reg_split.cpp Changeset: 4e7f99b70d9d Author: adlertz Date: 2013-10-09 05:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4e7f99b70d9d Merge - test/testlibrary/AssertsTest.java - test/testlibrary/OutputAnalyzerReportingTest.java - test/testlibrary/OutputAnalyzerTest.java Changeset: 46ef27bcacb3 Author: twisti Date: 2013-10-09 11:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/46ef27bcacb3 8020750: Node::get_int: guarantee(t != NULL) failed: must be con Reviewed-by: kvn, roland ! src/share/vm/opto/ifnode.cpp Changeset: d13d7aba8c12 Author: roland Date: 2013-10-09 16:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d13d7aba8c12 8023657: New type profiling points: arguments to call Summary: x86 interpreter and c1 type profiling for arguments at calls Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/globals_sparc.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Instruction.cpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_RangeCheckElimination.hpp ! src/share/vm/ci/ciClassList.hpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/ci/ciKlass.hpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/ci/ciObjArrayKlass.cpp ! src/share/vm/ci/ciObjArrayKlass.hpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/ci/ciTypeArrayKlass.hpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/signature.cpp ! src/share/vm/runtime/signature.hpp Changeset: 8b80b262e501 Author: twisti Date: 2013-10-11 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8b80b262e501 8005173: assert(false) failed: DEBUG MESSAGE: exception oop must be empty (macroAssembler_x86.cpp:625) Reviewed-by: kvn, iveresov ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/thread.hpp Changeset: d8a449d2f5b2 Author: adlertz Date: 2013-10-11 13:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d8a449d2f5b2 8011415: CTW on Sparc: assert(lrg.lo_degree()) failed: Summary: Increased the LRG AllStack mask size since the previous size was not big enough when compiling huge methods (60k+ nodes) Reviewed-by: kvn, roland, twisti ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/ifg.cpp Changeset: 2348b2726e1d Author: adlertz Date: 2013-10-11 19:16 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2348b2726e1d Merge Changeset: dd2cf1d1248b Author: adlertz Date: 2013-10-12 01:29 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dd2cf1d1248b Merge Changeset: 469216acdb28 Author: anoll Date: 2013-10-10 15:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/469216acdb28 8023014: CodeSweeperSweepNoFlushTest.java fails with HS crash Summary: Ensure ensure correct initialization of compiler runtime Reviewed-by: kvn, twisti ! src/share/vm/c1/c1_Compiler.cpp ! src/share/vm/c1/c1_Compiler.hpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeBlob.hpp ! src/share/vm/compiler/abstractCompiler.cpp ! src/share/vm/compiler/abstractCompiler.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/opto/c2compiler.cpp ! src/share/vm/opto/c2compiler.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/shark/sharkCompiler.cpp ! src/share/vm/shark/sharkCompiler.hpp + test/compiler/startup/SmallCodeCacheStartup.java Changeset: ed2c74787eb5 Author: twisti Date: 2013-10-11 19:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ed2c74787eb5 Merge Changeset: ce0cc25bc5e2 Author: roland Date: 2013-10-12 12:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ce0cc25bc5e2 8026054: New type profiling points: type of return values at calls Summary: x86 interpreter and c1 type profiling for return values at calls Reviewed-by: kvn, twisti ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_RangeCheckElimination.hpp ! src/share/vm/c1/c1_ValueMap.hpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/runtime/globals.hpp Changeset: f50418dfb1b7 Author: iveresov Date: 2013-10-13 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f50418dfb1b7 Merge ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp - test/compiler/8013496/Test8013496.sh Changeset: e504cd481ec0 Author: twisti Date: 2013-10-14 19:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e504cd481ec0 8026376: assert(false) failed: DEBUG MESSAGE: exception pc already set Reviewed-by: kvn ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp Changeset: 8df6f123d35e Author: drchase Date: 2013-10-12 17:26 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8df6f123d35e 8026124: JSR-292 bug: java.nio.file.Path.toString cores dump Summary: catch problem case, assert it matches valid input, new test Reviewed-by: jrose, twisti, kvn ! src/share/vm/interpreter/linkResolver.cpp + test/compiler/jsr292/CreatesInterfaceDotEqualsCallInfo.java + test/compiler/jsr292/createsInterfaceDotEqualsCallInfo.js Changeset: f91a9a696e5e Author: kvn Date: 2013-10-15 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f91a9a696e5e 8026293: Schedule part of G1 pre-barrier late Summary: move rare executed part of G1 write barrier from hot path. Reviewed-by: kvn, twisti, roland Contributed-by: staffan.friberg at oracle.com ! src/share/vm/opto/graphKit.cpp Changeset: 1263c7e17e1c Author: kvn Date: 2013-10-15 17:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1263c7e17e1c Merge Changeset: 4a2acfb16e97 Author: rbackman Date: 2013-10-11 12:06 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4a2acfb16e97 8025657: compiler/intrinsics/mathexact/ConstantTest.java fails on assert in lcm.cpp on solaris x64 Reviewed-by: kvn, twisti ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/mathexactnode.cpp ! src/share/vm/opto/mathexactnode.hpp + test/compiler/intrinsics/mathexact/RepeatTest.java Changeset: 90abdd727e64 Author: iveresov Date: 2013-10-16 11:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/90abdd727e64 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64 Summary: Do memory flow analysis in string concat optimizier to exclude cases when computation of arguments to StringBuffer::append has side effects Reviewed-by: kvn, twisti ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/stringopts.cpp Changeset: 8f4bb1773fd9 Author: iveresov Date: 2013-10-17 10:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8f4bb1773fd9 Merge ! src/share/vm/interpreter/linkResolver.cpp - test/compiler/8013496/Test8013496.sh Changeset: 7114c4597ae3 Author: acorn Date: 2013-10-17 23:30 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7114c4597ae3 8026365: NoClassDefinitionFound for anonymous class invokespecial. Reviewed-by: dcubed, kamg ! src/share/vm/classfile/verifier.cpp ! test/TEST.groups Changeset: 9c8289162268 Author: jwilhelm Date: 2013-10-11 16:18 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9c8289162268 8024776: Max/MinHeapFreeRatio descriptions should be more precise Summary: Descriptions for Max/MinHeapFreeRatio updated Reviewed-by: ehelin, jmasa ! src/share/vm/runtime/globals.hpp Changeset: 2382ff14d889 Author: jwilhelm Date: 2013-10-12 05:08 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2382ff14d889 Merge ! src/share/vm/runtime/globals.hpp Changeset: 24f32d09a0d7 Author: jwilhelm Date: 2013-10-12 00:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/24f32d09a0d7 8023643: G1 assert failed when NewSize was specified greater than MaxNewSize Summary: Exit with an error if incompatible NewSize and MaxNeSize are set Reviewed-by: brutisso, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: d6818f623792 Author: tschatzl Date: 2013-10-15 11:18 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d6818f623792 8026186: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java Compilation failed Summary: After a method rename in JDK-8014905 the mentioned test did not compile any more. Fix the uses of the affected method. Reviewed-by: jwilhelm, mgerdin, jmasa ! test/serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ! test/testlibrary/com/oracle/java/testlibrary/JDKToolLauncher.java Changeset: 027006a47a6d Author: sjohanss Date: 2013-10-14 14:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/027006a47a6d 8025661: Ill-formed -Xminf and -Xmaxf options values interpreted as 0 Summary: Using strtod() instead of atof() when parsing -Xminf and -Xmaxf. Reviewed-by: brutisso, pliden ! src/share/vm/runtime/arguments.cpp + test/gc/arguments/TestHeapFreeRatio.java Changeset: 82fcc0567fef Author: mgerdin Date: 2013-10-15 04:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/82fcc0567fef Merge Changeset: 6f1919cfd18c Author: pliden Date: 2013-10-15 11:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6f1919cfd18c 8023158: hotspot/test/gc/7168848/HumongousAlloc.java fails 14 full gcs, expect 0 full gcs Reviewed-by: brutisso, tschatzl ! test/TEST.groups - test/gc/7168848/HumongousAlloc.java + test/gc/g1/TestHumongousAllocInitialMark.java Changeset: bfd52054aeb8 Author: pliden Date: 2013-10-15 11:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bfd52054aeb8 8024632: Description of InitialSurvivorRatio flag in globals.hpp is incorrect Reviewed-by: brutisso, tschatzl, kmo, tamao ! src/share/vm/runtime/globals.hpp Changeset: 041c5da41ac4 Author: pliden Date: 2013-10-15 11:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/041c5da41ac4 8024634: gc/startup_warnings tests can fail due to unrelated warnings Reviewed-by: brutisso, jwilhelm, tamao ! test/gc/startup_warnings/TestCMS.java ! test/gc/startup_warnings/TestCMSNoIncrementalMode.java ! test/gc/startup_warnings/TestG1.java ! test/gc/startup_warnings/TestParNewCMS.java ! test/gc/startup_warnings/TestParallelGC.java ! test/gc/startup_warnings/TestParallelScavengeSerialOld.java ! test/gc/startup_warnings/TestSerialGC.java Changeset: f16726924734 Author: stefank Date: 2013-10-15 07:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f16726924734 Merge - test/gc/7168848/HumongousAlloc.java Changeset: bdfbb1fb19ca Author: stefank Date: 2013-10-15 14:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bdfbb1fb19ca 8026391: The Metachunk header wastes memory Reviewed-by: coleenp, jmasa ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeList.cpp - src/share/vm/memory/metablock.cpp - src/share/vm/memory/metablock.hpp ! src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ec2e26e26183 Author: stefank Date: 2013-10-15 14:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ec2e26e26183 8026392: Metachunks and Metablocks are using a too large alignment Reviewed-by: coleenp, jmasa ! src/share/vm/memory/metachunk.cpp Changeset: 9e5fadad7fdf Author: tschatzl Date: 2013-10-16 11:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9e5fadad7fdf 8025925: jmap fails with "field _length not found in type HeapRegionSeq" Summary: The change JDK-7163191 changed the data layout of a class that is referenced by the java code of the SA agent. This fix synchronizes the SA agent with that change. Reviewed-by: sla, mgerdin + agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/G1HeapRegionTable.java ! agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/HeapRegionSeq.java Changeset: 28df60a5badf Author: stefank Date: 2013-10-17 08:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/28df60a5badf 8026707: JDK-8026391 broke the optimized build target Reviewed-by: mgerdin, coleenp ! src/share/vm/memory/metachunk.hpp Changeset: 94c0343b1887 Author: stefank Date: 2013-10-17 08:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/94c0343b1887 8026715: Remove the MetaDataDeallocateALot develop flag Reviewed-by: coleenp, mgerdin ! src/share/vm/memory/metaspace.cpp ! src/share/vm/runtime/globals.hpp Changeset: bf9e50c573ad Author: jmasa Date: 2013-10-17 06:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bf9e50c573ad 8025635: SoftReferences are not cleared before metaspace OOME are thrown Reviewed-by: jcoomes, tamao, tschatzl, stefank ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp Changeset: c51cd6af7e61 Author: jcoomes Date: 2013-10-18 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c51cd6af7e61 Merge ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp ! test/TEST.groups - test/compiler/8013496/Test8013496.sh ! test/serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ! test/testlibrary/com/oracle/java/testlibrary/JDKToolLauncher.java Changeset: 23b8db5ea31d Author: amurillo Date: 2013-10-18 21:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/23b8db5ea31d Merge - src/share/vm/memory/metablock.cpp - src/share/vm/memory/metablock.hpp - test/compiler/8013496/Test8013496.sh - test/gc/7168848/HumongousAlloc.java Changeset: e8cbdc701bfb Author: amurillo Date: 2013-10-18 21:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e8cbdc701bfb Added tag hs25-b55 for changeset 23b8db5ea31d ! .hgtags Changeset: 4589b398ab03 Author: amurillo Date: 2013-10-22 13:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4589b398ab03 Merge - src/share/vm/memory/metablock.cpp - src/share/vm/memory/metablock.hpp - test/compiler/8013496/Test8013496.sh - test/gc/7168848/HumongousAlloc.java Changeset: 4a1128861221 Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4a1128861221 Added tag jdk8-b113 for changeset 4589b398ab03 ! .hgtags Changeset: 0e55a181cb08 Author: lana Date: 2013-10-28 12:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0e55a181cb08 Merge - src/share/vm/memory/metablock.cpp - src/share/vm/memory/metablock.hpp - test/compiler/8013496/Test8013496.sh - test/gc/7168848/HumongousAlloc.java From lana.steuck at oracle.com Mon Oct 28 22:00:46 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 28 Oct 2013 22:00:46 +0000 Subject: hg: jdk8/tl/jdk: 17 new changesets Message-ID: <20131028220823.22094627AF@hg.openjdk.java.net> Changeset: 01b81253f2d5 Author: dcubed Date: 2013-10-15 08:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01b81253f2d5 7165611: implement Full Debug Symbols on MacOS X hotspot Summary: Add MacOS X FDS support to hotspot; add minimal MacOS X FDS import support to jdk; add MacOS X FDS support to install; add MacOS X FDS support to root. Reviewed-by: erikj, sla, dholmes, rdurbin, tbell, ihse ! make/common/Defs-macosx.gmk ! make/common/Defs.gmk ! make/java/redist/Makefile ! makefiles/Import.gmk ! makefiles/Tools.gmk Changeset: 969e8c6c26cc Author: amurillo Date: 2013-10-19 08:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/969e8c6c26cc Merge ! makefiles/Import.gmk ! makefiles/Tools.gmk Changeset: c4ab67d1e0ce Author: amurillo Date: 2013-10-22 13:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4ab67d1e0ce Merge ! makefiles/Tools.gmk Changeset: a5b57fca66da Author: ihse Date: 2013-10-16 20:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5b57fca66da 8025715: Split CompileNativeLibraries.gmk Reviewed-by: erikj ! makefiles/CompileNativeLibraries.gmk + makefiles/lib/Awt2dLibraries.gmk + makefiles/lib/CoreLibraries.gmk + makefiles/lib/NetworkingLibraries.gmk + makefiles/lib/NioLibraries.gmk + makefiles/lib/PlatformLibraries.gmk + makefiles/lib/SecurityLibraries.gmk + makefiles/lib/ServiceabilityLibraries.gmk + makefiles/lib/SoundLibraries.gmk Changeset: 1e99d539088d Author: katleman Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e99d539088d Merge Changeset: 7ec4ddc36ad6 Author: erikj Date: 2013-10-17 16:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ec4ddc36ad6 8019540: licensee reports a JDK8 build failure after 8005849/8005008 fixes integrated. Reviewed-by: dholmes, sla ! makefiles/CopyIntoClasses.gmk Changeset: 11e90e4167d4 Author: erikj Date: 2013-10-21 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11e90e4167d4 Merge Changeset: 3a6ac3484b05 Author: cl Date: 2013-10-21 23:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a6ac3484b05 8026974: solaris build missing java-rmi.cgi Reviewed-by: ksrini ! makefiles/CompileLaunchers.gmk Changeset: b121e84392fa Author: erikj Date: 2013-10-22 11:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b121e84392fa 8026966: Most native libs broken on mac in jdk8/build Reviewed-by: ihse, anthony ! makefiles/lib/PlatformLibraries.gmk Changeset: 9850efaedc50 Author: katleman Date: 2013-10-22 16:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9850efaedc50 Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk + makefiles/lib/Awt2dLibraries.gmk + makefiles/lib/CoreLibraries.gmk + makefiles/lib/NetworkingLibraries.gmk + makefiles/lib/NioLibraries.gmk + makefiles/lib/PlatformLibraries.gmk + makefiles/lib/SecurityLibraries.gmk + makefiles/lib/ServiceabilityLibraries.gmk + makefiles/lib/SoundLibraries.gmk Changeset: 698937f18761 Author: tbell Date: 2013-10-22 16:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/698937f18761 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties ! makefiles/jprt.properties Changeset: 81431a7c17cf Author: tbell Date: 2013-10-22 16:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81431a7c17cf Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html - src/share/classes/java/net/HttpURLPermission.java - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: aabaae5de1ee Author: ihse Date: 2013-10-23 13:06 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aabaae5de1ee 8001922: Improve freetype handling. Reviewed-by: erikj ! makefiles/CopyFiles.gmk ! makefiles/lib/Awt2dLibraries.gmk Changeset: ab0e61a57df7 Author: chegar Date: 2013-10-23 13:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ab0e61a57df7 8027059: (sctp) fatal warnings overly restrictive with gcc 4.8.1 Reviewed-by: mduigou, dxu, erikj, ihse ! makefiles/lib/NioLibraries.gmk Changeset: 5b4261b4b72a Author: erikj Date: 2013-10-23 17:57 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5b4261b4b72a 8026888: Licensee build failure due to wrong libs being called Reviewed-by: tbell, ihse, simonis ! makefiles/lib/Awt2dLibraries.gmk Changeset: b88aa723a5fa Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b88aa723a5fa Added tag jdk8-b113 for changeset 5b4261b4b72a ! .hgtags Changeset: e7639b856256 Author: lana Date: 2013-10-28 12:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7639b856256 Merge From lana.steuck at oracle.com Mon Oct 28 21:57:39 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 28 Oct 2013 21:57:39 +0000 Subject: hg: jdk8/tl: 17 new changesets Message-ID: <20131028215745.39395627A6@hg.openjdk.java.net> Changeset: 22c6f0b7e2b5 Author: dcubed Date: 2013-10-15 08:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/22c6f0b7e2b5 7165611: implement Full Debug Symbols on MacOS X hotspot Summary: Add MacOS X FDS support to hotspot; add minimal MacOS X FDS import support to jdk; add MacOS X FDS support to install; add MacOS X FDS support to root. Reviewed-by: erikj, sla, dholmes, rdurbin, tbell, ihse ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/makefiles/NativeCompilation.gmk Changeset: ac09e62d5e6b Author: amurillo Date: 2013-10-19 08:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ac09e62d5e6b Merge ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/makefiles/NativeCompilation.gmk Changeset: 9d5284dfc00d Author: amurillo Date: 2013-10-22 13:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9d5284dfc00d Merge Changeset: 5b4f14990dd1 Author: ihse Date: 2013-10-18 10:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5b4f14990dd1 8001912: Improve detection of msvcr100.dll Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 ! common/autoconf/toolchain_windows.m4 Changeset: 65c1752b4c38 Author: katleman Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/65c1752b4c38 Merge Changeset: 17d195bd56fc Author: erikj Date: 2013-10-18 11:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/17d195bd56fc 8025869: make docs doesn't regenerate docs correctly after changing API doc comments in jaxp sources Reviewed-by: ihse, tbell ! common/makefiles/JavaCompilation.gmk Changeset: e27dda53d4f5 Author: erikj Date: 2013-10-21 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e27dda53d4f5 Merge Changeset: 1a853fac18ff Author: erikj Date: 2013-10-21 11:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1a853fac18ff 8026528: [build] configure does not recognize newer make in cygwin Reviewed-by: tbell, ksrini, ihse ! NewMakefile.gmk ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: dffe654ab24c Author: ihse Date: 2013-10-22 11:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/dffe654ab24c 8001925: Add useful help messages if freetype is not found on Windows Reviewed-by: erikj, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/help.m4 Changeset: 56db38956113 Author: ihse Date: 2013-10-22 12:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/56db38956113 8026864: Deprecate --disable-macosx-runtime-support. Reviewed-by: erikj ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: 9e177e7fc438 Author: katleman Date: 2013-10-22 14:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9e177e7fc438 Merge ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/makefiles/JavaCompilation.gmk Changeset: 4293401d683b Author: katleman Date: 2013-10-22 16:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4293401d683b 8027068: Update to NewMakefile.gmk check of MAKE_VERSION broke jdk8-build nightly builds on windows, saying 3.82.90 is too low Reviewed-by: ihse, tbell, wetmore ! NewMakefile.gmk Changeset: 269497597620 Author: tbell Date: 2013-10-22 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/269497597620 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 2cc1a52d37ef Author: tbell Date: 2013-10-22 16:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/2cc1a52d37ef Merge Changeset: 6f19b2440412 Author: ihse Date: 2013-10-23 13:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6f19b2440412 8001922: Improve freetype handling. Reviewed-by: erikj ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/help.m4 ! common/autoconf/libraries.m4 ! common/autoconf/spec.gmk.in Changeset: 6ba4c7cb623e Author: erikj Date: 2013-10-23 17:03 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6ba4c7cb623e 8026888: Licensee build failure due to wrong libs being called Reviewed-by: tbell, ihse, simonis ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: a36df87b3901 Author: cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a36df87b3901 Added tag jdk8-b113 for changeset 6ba4c7cb623e ! .hgtags From staffan.larsen at oracle.com Tue Oct 29 07:11:10 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 29 Oct 2013 07:11:10 +0000 Subject: hg: jdk8/tl/jdk: 8027371: Add JDI tests for breakpointing and stepping in lambda code Message-ID: <20131029071153.B9D09627D3@hg.openjdk.java.net> Changeset: ecba02f6be31 Author: sla Date: 2013-10-29 08:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecba02f6be31 8027371: Add JDI tests for breakpointing and stepping in lambda code Reviewed-by: mchung, sspitsyn + test/com/sun/jdi/LambdaBreakpointTest.java + test/com/sun/jdi/LambdaStepTest.java From sean.coffey at oracle.com Tue Oct 29 12:05:11 2013 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 29 Oct 2013 12:05:11 +0000 Subject: hg: jdk8/tl/jdk: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing Message-ID: <20131029120539.8C2F6627D9@hg.openjdk.java.net> Changeset: d34c5e860d5f Author: aefimov Date: 2013-10-24 17:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d34c5e860d5f 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing Reviewed-by: okutsu, mfang, alanb ! test/ProblemList.txt ! test/sun/util/resources/TimeZone/Bug6317929.java From james.laskey at oracle.com Tue Oct 29 14:40:02 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 29 Oct 2013 14:40:02 +0000 Subject: hg: jdk8/tl/nashorn: 3 new changesets Message-ID: <20131029144010.7ED48627E6@hg.openjdk.java.net> Changeset: 7985ec3782b5 Author: hannesw Date: 2013-10-25 10:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7985ec3782b5 8027042: Evaluation order for binary operators can be improved Reviewed-by: lagergren, jlaskey, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/types/Type.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Expression.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java + test/script/basic/JDK-8027042.js + test/script/basic/JDK-8027042.js.EXPECTED Changeset: 71cfb21c68dc Author: hannesw Date: 2013-10-25 15:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/71cfb21c68dc 8027301: Optimizations for Function.prototype.apply Reviewed-by: jlaskey ! src/jdk/nashorn/internal/runtime/CompiledFunctions.java ! src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java Changeset: 406f2b672937 Author: jlaskey Date: 2013-10-29 10:40 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/406f2b672937 Merge From james.laskey at oracle.com Tue Oct 29 14:48:40 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 29 Oct 2013 14:48:40 +0000 Subject: hg: jdk8/tl: 26 new changesets Message-ID: <20131029144841.CDF68627EA@hg.openjdk.java.net> Changeset: 3dc55f0c1b6f Author: jlaskey Date: 2013-01-28 16:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/3dc55f0c1b6f 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.laskey at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/source-dirs.m4 ! common/autoconf/spec.gmk.in ! common/bin/compare.sh ! common/makefiles/Main.gmk ! common/makefiles/MakeBase.gmk + make/nashorn-rules.gmk ! make/scripts/hgforest.sh Changeset: ecd447139a39 Author: jlaskey Date: 2013-02-04 17:30 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ecd447139a39 Merge ! common/autoconf/generated-configure.sh Changeset: 9ed388a04fa7 Author: jlaskey Date: 2013-02-06 13:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9ed388a04fa7 8007666: nashorn missing from hgforest.sh Reviewed-by: jlaskey Contributed-by: james.laskey at oracle.com ! common/bin/hgforest.sh Changeset: 8b19b55f695d Author: jlaskey Date: 2013-02-18 19:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8b19b55f695d 8008420: Fix Nashorn forest to build with NEWBUILD=false Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! Makefile ! make/nashorn-rules.gmk Changeset: f9a1cb245484 Author: jlaskey Date: 2013-02-19 10:02 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/f9a1cb245484 8008446: Tweaks to make all NEWBUILD=false round 2 Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! make/Defs-internal.gmk Changeset: 887fde71977e Author: jlaskey Date: 2013-02-21 15:25 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/887fde71977e 8008447: Tweaks to make all NEWBUILD=false round 3 Reviewed-by: jjh, sundar Contributed-by: james.laskey at oracle.com ! make/jdk-rules.gmk ! make/sanity-rules.gmk Changeset: e877cb3eb4d6 Author: jlaskey Date: 2013-02-22 13:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e877cb3eb4d6 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/hgforest.sh ! common/makefiles/Main.gmk Changeset: 528a9984198f Author: jlaskey Date: 2013-02-22 22:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/528a9984198f 8008774: nashorn missing from dependencies after merge with tl Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! common/makefiles/Main.gmk Changeset: 13ddc5c3ebfc Author: jlaskey Date: 2013-03-02 10:28 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/13ddc5c3ebfc Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/hgforest.sh ! common/makefiles/Main.gmk ! make/nashorn-rules.gmk Changeset: 1d38d30196be Author: jlaskey Date: 2013-03-08 14:44 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1d38d30196be Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: b938d5ee29c3 Author: jlaskey Date: 2013-03-15 11:50 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b938d5ee29c3 Merge Changeset: fe5a388bf8fe Author: jlaskey Date: 2013-03-26 09:13 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/fe5a388bf8fe Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: 1378ccca1c79 Author: jlaskey Date: 2013-04-09 08:35 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1378ccca1c79 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/hgforest.sh ! common/makefiles/Main.gmk Changeset: 8a7e97848471 Author: jlaskey Date: 2013-04-15 08:06 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8a7e97848471 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: 6316aefcf716 Author: jlaskey Date: 2013-04-17 08:47 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6316aefcf716 Merge Changeset: dd81e9b5fb38 Author: jlaskey Date: 2013-04-22 13:59 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/dd81e9b5fb38 Merge Changeset: 431d16ddfcd9 Author: jlaskey Date: 2013-04-29 21:37 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/431d16ddfcd9 Merge Changeset: 1fca390200c1 Author: jlaskey Date: 2013-05-14 09:04 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1fca390200c1 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: 67b5cbe55744 Author: jlaskey Date: 2013-05-23 09:48 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/67b5cbe55744 Merge Changeset: de886178f8e6 Author: jlaskey Date: 2013-06-05 13:08 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/de886178f8e6 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in Changeset: 520fd54a7c43 Author: jlaskey Date: 2013-07-16 09:08 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/520fd54a7c43 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: 67dc3d7d5b5f Author: jlaskey Date: 2013-07-24 08:23 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/67dc3d7d5b5f Merge ! common/autoconf/generated-configure.sh Changeset: 96f207364e46 Author: jlaskey Date: 2013-08-27 16:05 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/96f207364e46 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: ddf76977d04a Author: jlaskey Date: 2013-09-13 10:14 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ddf76977d04a Merge ! common/autoconf/generated-configure.sh ! common/bin/hgforest.sh ! common/makefiles/Main.gmk Changeset: 8b92b08993a8 Author: jlaskey Date: 2013-09-30 10:23 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8b92b08993a8 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in Changeset: d832f6171acd Author: jlaskey Date: 2013-10-29 11:48 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d832f6171acd Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/hgforest.sh ! common/makefiles/Main.gmk From james.laskey at oracle.com Tue Oct 29 14:32:16 2013 From: james.laskey at oracle.com (james.laskey at oracle.com) Date: Tue, 29 Oct 2013 14:32:16 +0000 Subject: hg: jdk8/tl/jdk: 27 new changesets Message-ID: <20131029143925.61F19627E4@hg.openjdk.java.net> Changeset: a8bbd962f34a Author: jlaskey Date: 2013-01-28 16:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8bbd962f34a 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.laskey at oracle.com ! THIRD_PARTY_README ! make/launchers/Makefile ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! test/tools/launcher/VersionCheck.java Changeset: 41654275896d Author: jlaskey Date: 2013-02-04 17:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41654275896d Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java ! test/tools/launcher/VersionCheck.java Changeset: a174944b0c00 Author: jlaskey Date: 2013-02-21 15:25 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a174944b0c00 8008447: Tweaks to make all NEWBUILD=false round 3 Reviewed-by: jjh, sundar Contributed-by: james.laskey at oracle.com ! make/launchers/Makefile Changeset: 25db7658a063 Author: jlaskey Date: 2013-02-22 10:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/25db7658a063 8008721: Tweaks to make all NEWBUILD=false round 4 Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! make/launchers/Makefile Changeset: ea22045ce09b Author: jlaskey Date: 2013-02-22 14:05 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea22045ce09b Merge ! makefiles/CreateJars.gmk Changeset: ff68fafd6302 Author: jlaskey Date: 2013-02-22 17:45 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff68fafd6302 8008756: THIRD_PARTY_README contains Unicode Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! THIRD_PARTY_README Changeset: ce82a0ee7735 Author: jlaskey Date: 2013-02-22 18:03 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce82a0ee7735 8008757: NEWBUILD=true has separate launcher code for jjs Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! makefiles/CompileLaunchers.gmk Changeset: 20a827b22a2e Author: jlaskey Date: 2013-02-22 23:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/20a827b22a2e 8008775: Remove non-ascii from jdk/THIRD_PARTY_README Reviewed-by: jjh Contributed-by: james.laskey at oracle.com ! THIRD_PARTY_README Changeset: 364e0871f7a3 Author: jlaskey Date: 2013-03-02 11:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/364e0871f7a3 Merge ! make/launchers/Makefile ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk - src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java - test/javax/script/RhinoExceptionTest.java ! test/tools/launcher/VersionCheck.java Changeset: 3565c755c49f Author: jlaskey Date: 2013-03-15 11:51 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3565c755c49f Merge ! makefiles/CreateJars.gmk Changeset: 8c223a4f906a Author: jlaskey Date: 2013-03-26 09:12 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c223a4f906a Merge ! makefiles/CreateJars.gmk Changeset: efbbcd5848cf Author: jlaskey Date: 2013-04-01 10:09 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/efbbcd5848cf Merge Changeset: 39ce82dad57d Author: jlaskey Date: 2013-04-09 08:36 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39ce82dad57d Merge Changeset: ff9683b6854c Author: jlaskey Date: 2013-04-15 08:27 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff9683b6854c Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk Changeset: 1cdf20da340b Author: jlaskey Date: 2013-04-17 08:47 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1cdf20da340b Merge Changeset: 72fa581a83a4 Author: jlaskey Date: 2013-04-22 14:00 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72fa581a83a4 Merge Changeset: ead9944bbb3b Author: jlaskey Date: 2013-04-29 21:37 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ead9944bbb3b Merge Changeset: 5bde43b1e463 Author: jlaskey Date: 2013-05-14 09:04 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bde43b1e463 Merge Changeset: efd620f8963f Author: jlaskey Date: 2013-05-23 09:48 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/efd620f8963f Merge ! makefiles/CreateJars.gmk Changeset: 193652dff077 Author: jlaskey Date: 2013-05-29 13:22 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/193652dff077 Merge Changeset: 733713d7517c Author: jlaskey Date: 2013-06-05 13:10 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/733713d7517c Merge ! makefiles/CompileLaunchers.gmk Changeset: 3b464e13a776 Author: jlaskey Date: 2013-07-16 09:09 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b464e13a776 Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! test/tools/launcher/VersionCheck.java Changeset: c0a2094aaafd Author: jlaskey Date: 2013-07-24 08:22 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0a2094aaafd Merge - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html Changeset: 528fc8f4281b Author: jlaskey Date: 2013-08-27 16:06 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/528fc8f4281b Merge ! makefiles/CompileLaunchers.gmk Changeset: be6ca7197e0e Author: jlaskey Date: 2013-09-13 10:15 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be6ca7197e0e Merge ! makefiles/CreateJars.gmk - src/share/classes/java/util/stream/CloseableStream.java - src/share/classes/java/util/stream/DelegatingStream.java - test/java/util/Map/CheckRandomHashSeed.java - test/java/util/Map/TreeBinSplitBackToEntries.java - test/sun/tools/jconsole/ImmutableResourceTest.java - test/sun/tools/jconsole/ImmutableResourceTest.sh Changeset: 74b1eb493407 Author: jlaskey Date: 2013-09-30 10:24 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74b1eb493407 Merge ! makefiles/CreateJars.gmk Changeset: f5c9333b6129 Author: jlaskey Date: 2013-10-29 10:40 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5c9333b6129 Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! test/tools/launcher/VersionCheck.java From chris.hegarty at oracle.com Tue Oct 29 17:25:02 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 29 Oct 2013 17:25:02 +0000 Subject: hg: jdk8/tl/jdk: 8027466: Revert jdk/THIRD_PARTY_README to known good version Message-ID: <20131029172537.44C10627F7@hg.openjdk.java.net> Changeset: 121c34517841 Author: chegar Date: 2013-10-29 17:21 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/121c34517841 8027466: Revert jdk/THIRD_PARTY_README to known good version Reviewed-by: alanb ! THIRD_PARTY_README From jaroslav.bachorik at oracle.com Fri Oct 25 11:02:55 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Fri, 25 Oct 2013 11:02:55 +0000 Subject: hg: jdk8/tl/jdk: 8004926: sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out Message-ID: <20131025110336.0F16D6273A@hg.openjdk.java.net> Changeset: 1153022c0a45 Author: jbachorik Date: 2013-10-25 13:01 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1153022c0a45 8004926: sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out Summary: Improve reliability by converting the test to Java Reviewed-by: dsamersoff, dholmes ! test/TEST.groups ! test/lib/testlibrary/jdk/testlibrary/ProcessTools.java ! test/lib/testlibrary/jdk/testlibrary/StreamPumper.java + test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java - test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh + test/sun/management/jmxremote/bootstrap/LocalManagementTest.java - test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh ! test/sun/management/jmxremote/bootstrap/TestApplication.java ! test/sun/management/jmxremote/bootstrap/TestManager.java + test/sun/management/jmxremote/bootstrap/linux-amd64/launcher From bobbyphilip at gmail.com Mon Oct 28 13:41:48 2013 From: bobbyphilip at gmail.com (Bobby Philip) Date: Mon, 28 Oct 2013 19:11:48 +0530 Subject: Stack Overflow Question Message-ID: Why is the java crypto padding algorithm called PKCS#5? http://stackoverflow.com/q/19631412/571113?sem=2 -------------- next part -------------- An HTML attachment was scrubbed... URL: From michael.fang at oracle.com Tue Oct 29 18:36:22 2013 From: michael.fang at oracle.com (michael.fang at oracle.com) Date: Tue, 29 Oct 2013 18:36:22 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20131029183706.98C25627FC@hg.openjdk.java.net> Changeset: 6fc2889fe7d0 Author: mfang Date: 2013-10-29 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6fc2889fe7d0 8026108: [it, ja, zh_CN] wrong translation in jar example. Reviewed-by: okutsu, yhuang ! src/share/classes/sun/tools/jar/resources/jar_it.properties ! src/share/classes/sun/tools/jar/resources/jar_ja.properties ! src/share/classes/sun/tools/jar/resources/jar_zh_CN.properties Changeset: 0cc9bdb22911 Author: mfang Date: 2013-10-29 11:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cc9bdb22911 8008437: [sv] over-translation in java command line outputs Reviewed-by: okutsu, yhuang ! src/share/classes/sun/tools/jar/resources/jar_sv.properties Changeset: 331d8ced56dc Author: mfang Date: 2013-10-29 11:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/331d8ced56dc 8025646: [pt_BR] overtranslation of option in java command line output Reviewed-by: naoto, yhuang ! src/share/classes/sun/launcher/resources/launcher_pt_BR.properties From huizhe.wang at oracle.com Tue Oct 29 21:58:38 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 29 Oct 2013 21:58:38 +0000 Subject: hg: jdk8/tl/jaxp: 8027484: Implementation error in SAX2DOM.java Message-ID: <20131029215845.C5DA662808@hg.openjdk.java.net> Changeset: 1af33ab1bc58 Author: joehw Date: 2013-10-29 14:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1af33ab1bc58 8027484: Implementation error in SAX2DOM.java Reviewed-by: alanb, lancea ! src/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2DOM.java From chris.hegarty at oracle.com Wed Oct 30 14:44:31 2013 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 30 Oct 2013 14:44:31 +0000 Subject: hg: jdk8/tl/jdk: 8026880: NetworkInterface native initializing code should check fieldID values Message-ID: <20131030144518.931296282A@hg.openjdk.java.net> Changeset: 9a5048dc7c0d Author: chegar Date: 2013-10-30 14:41 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a5048dc7c0d 8026880: NetworkInterface native initializing code should check fieldID values Reviewed-by: alanb ! src/solaris/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface.c From staffan.larsen at oracle.com Wed Oct 30 15:02:35 2013 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 30 Oct 2013 15:02:35 +0000 Subject: hg: jdk8/tl/jdk: 8022229: Intermittent test failures in sun/tools/jstatd Message-ID: <20131030150308.90CDE6282B@hg.openjdk.java.net> Changeset: b04b124418d8 Author: ykantser Date: 2013-10-30 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b04b124418d8 8022229: Intermittent test failures in sun/tools/jstatd Reviewed-by: sla, egahlin, jbachorik, allwin + test/lib/testlibrary/jdk/testlibrary/Asserts.java + test/lib/testlibrary/jdk/testlibrary/JDKToolFinder.java + test/lib/testlibrary/jdk/testlibrary/JDKToolLauncher.java + test/lib/testlibrary/jdk/testlibrary/Platform.java + test/lib/testlibrary/jdk/testlibrary/ProcessThread.java + test/lib/testlibrary/jdk/testlibrary/TestThread.java + test/lib/testlibrary/jdk/testlibrary/Utils.java + test/lib/testlibrary/jdk/testlibrary/XRun.java + test/sun/tools/jstatd/JstatGCUtilParser.java + test/sun/tools/jstatd/JstatdTest.java + test/sun/tools/jstatd/TestJstatdDefaults.java + test/sun/tools/jstatd/TestJstatdExternalRegistry.java + test/sun/tools/jstatd/TestJstatdPort.java + test/sun/tools/jstatd/TestJstatdPortAndServer.java + test/sun/tools/jstatd/TestJstatdServer.java + test/sun/tools/jstatd/TestJstatdUsage.java - test/sun/tools/jstatd/jpsOutput1.awk - test/sun/tools/jstatd/jstatGcutilOutput1.awk - test/sun/tools/jstatd/jstatdDefaults.sh - test/sun/tools/jstatd/jstatdExternalRegistry.sh - test/sun/tools/jstatd/jstatdPort.sh - test/sun/tools/jstatd/jstatdServerName.sh - test/sun/tools/jstatd/jstatdUsage1.sh - test/sun/tools/jstatd/usage.out From mandy.chung at oracle.com Wed Oct 30 15:37:06 2013 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 30 Oct 2013 15:37:06 +0000 Subject: hg: jdk8/tl/langtools: 8027481: jdeps to handle classes with the same package name and correct profile for javax.crypto.* Message-ID: <20131030153721.0710C6282D@hg.openjdk.java.net> Changeset: aa91bc6e8480 Author: mchung Date: 2013-10-30 08:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aa91bc6e8480 8027481: jdeps to handle classes with the same package name and correct profile for javax.crypto.* Reviewed-by: alanb, dfuchs ! src/share/classes/com/sun/tools/jdeps/Analyzer.java ! src/share/classes/com/sun/tools/jdeps/Archive.java ! src/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/share/classes/com/sun/tools/jdeps/Profile.java ! test/tools/jdeps/Basic.java ! test/tools/jdeps/Test.java + test/tools/jdeps/javax/activity/NotCompactProfile.java + test/tools/jdeps/p/Bar.java From huizhe.wang at oracle.com Wed Oct 30 15:59:44 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Wed, 30 Oct 2013 15:59:44 +0000 Subject: hg: jdk8/tl/jaxp: 8024378: StAX parser shall support JAXP properties Message-ID: <20131030160009.AA6AD62830@hg.openjdk.java.net> Changeset: 04778b00286a Author: joehw Date: 2013-10-30 08:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/04778b00286a 8024378: StAX parser shall support JAXP properties Reviewed-by: dfuchs, lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLNSDocumentScannerImpl.java From vincent.x.ryan at oracle.com Wed Oct 30 17:56:14 2013 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Wed, 30 Oct 2013 17:56:14 +0000 Subject: hg: jdk8/tl: 8027567: JDK 8 build failure: the correct version of GNU make is being rejected Message-ID: <20131030175615.20F536283E@hg.openjdk.java.net> Changeset: 067355edfbf8 Author: vinnie Date: 2013-10-30 17:31 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/rev/067355edfbf8 8027567: JDK 8 build failure: the correct version of GNU make is being rejected Reviewed-by: chegar, erikj ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh From vicente.romero at oracle.com Wed Oct 30 18:11:40 2013 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 30 Oct 2013 18:11:40 +0000 Subject: hg: jdk8/tl/langtools: 8027327: jar files related to test test/tools/javac/ExtDirs/ExtDirTest.java should be removed from the repo Message-ID: <20131030181143.3E96662841@hg.openjdk.java.net> Changeset: 537fa895fd74 Author: vromero Date: 2013-10-30 18:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/537fa895fd74 8027327: jar files related to test test/tools/javac/ExtDirs/ExtDirTest.java should be removed from the repo Reviewed-by: ksrini ! test/tools/javac/ExtDirs/ExtDirTest.java - test/tools/javac/ExtDirs/ext1/pkg1.jar - test/tools/javac/ExtDirs/ext2/pkg2.jar - test/tools/javac/ExtDirs/ext3/pkg1.jar - test/tools/javac/ExtDirs/ext3/pkg2.jar From brian.goetz at oracle.com Wed Oct 30 18:21:21 2013 From: brian.goetz at oracle.com (brian.goetz at oracle.com) Date: Wed, 30 Oct 2013 18:21:21 +0000 Subject: hg: jdk8/tl/langtools: 8024930: Re-enable disabled bridging tests Message-ID: <20131030182131.EB59462842@hg.openjdk.java.net> Changeset: 62a67e0875ff Author: briangoetz Date: 2013-10-30 14:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/62a67e0875ff 8024930: Re-enable disabled bridging tests Reviewed-by: psandoz, rfield ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/Compiler.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/SourceModel.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/TestHarness.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java From michael.x.mcmahon at oracle.com Wed Oct 30 18:41:41 2013 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Wed, 30 Oct 2013 18:41:41 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131030184313.1141862843@hg.openjdk.java.net> Changeset: 7bc67bed3c14 Author: michaelm Date: 2013-10-30 18:37 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bc67bed3c14 8027570: NullPointerException in URLPermission.hashCode() Reviewed-by: chegar ! src/share/classes/java/net/URLPermission.java ! test/java/net/URLPermission/URLPermissionTest.java Changeset: 281e26d7f325 Author: michaelm Date: 2013-10-30 18:38 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/281e26d7f325 Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - makefiles/GendataBreakIterator.gmk - makefiles/GendataFontConfig.gmk - makefiles/GendataHtml32dtd.gmk - makefiles/GendataTZDB.gmk - makefiles/GendataTimeZone.gmk - makefiles/GenerateJavaSources.gmk - makefiles/GensrcBuffer.gmk - makefiles/GensrcCLDR.gmk - makefiles/GensrcCharacterData.gmk - makefiles/GensrcCharsetCoder.gmk - makefiles/GensrcCharsetMapping.gmk - makefiles/GensrcExceptions.gmk - makefiles/GensrcIcons.gmk - makefiles/GensrcJDWP.gmk - makefiles/GensrcJObjC.gmk - makefiles/GensrcLocaleDataMetaInfo.gmk - makefiles/GensrcMisc.gmk - makefiles/GensrcProperties.gmk - makefiles/GensrcSwing.gmk - makefiles/GensrcX11Wrappers.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/java/lang/invoke/MagicLambdaImpl.java ! src/share/classes/java/net/URLPermission.java - src/share/demo/jfc/Notepad/resources/Notepad_fr.properties - src/share/demo/jfc/Notepad/resources/Notepad_sv.properties - src/solaris/doc/sun/man/man1/ja/javaws.1 - src/solaris/doc/sun/man/man1/javaws.1 - test/java/net/NetworkInterface/MemLeakTest.java - test/jdk/lambda/vm/DefaultMethodsTest.java - test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh - test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh - test/sun/tools/jstatd/jpsOutput1.awk - test/sun/tools/jstatd/jstatGcutilOutput1.awk - test/sun/tools/jstatd/jstatdDefaults.sh - test/sun/tools/jstatd/jstatdExternalRegistry.sh - test/sun/tools/jstatd/jstatdPort.sh - test/sun/tools/jstatd/jstatdServerName.sh - test/sun/tools/jstatd/jstatdUsage1.sh - test/sun/tools/jstatd/usage.out From bradford.wetmore at oracle.com Wed Oct 30 21:25:12 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Wed, 30 Oct 2013 14:25:12 -0700 Subject: Very simple webrev. Message-ID: <52717938.8040804@oracle.com> https://bugs.openjdk.java.net/browse/JDK-8027526 http://cr.openjdk.java.net/~wetmore/8027526/webrev/ Alan was getting some test failures, I'm 95% sure it's due to a provider being inserted one of two tests and being run with agentvm. According to Jon Gibbons, agentvm does not reset the Security Providers. I'm putting this one open change back, and will be filing a bug for the remainder. Brad From sean.mullan at oracle.com Wed Oct 30 21:28:08 2013 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 30 Oct 2013 17:28:08 -0400 Subject: Very simple webrev. In-Reply-To: <52717938.8040804@oracle.com> References: <52717938.8040804@oracle.com> Message-ID: <527179E8.3050001@oracle.com> Looks good. --Sean On 10/30/2013 05:25 PM, Bradford Wetmore wrote: > > https://bugs.openjdk.java.net/browse/JDK-8027526 > http://cr.openjdk.java.net/~wetmore/8027526/webrev/ > > Alan was getting some test failures, I'm 95% sure it's due to a provider > being inserted one of two tests and being run with agentvm. > > According to Jon Gibbons, agentvm does not reset the Security Providers. > > I'm putting this one open change back, and will be filing a bug for the > remainder. > > Brad From mandy.chung at oracle.com Wed Oct 30 21:37:47 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 30 Oct 2013 14:37:47 -0700 Subject: Very simple webrev. In-Reply-To: <52717938.8040804@oracle.com> References: <52717938.8040804@oracle.com> Message-ID: <52717C2B.3080901@oracle.com> On 10/30/2013 2:25 PM, Bradford Wetmore wrote: > > https://bugs.openjdk.java.net/browse/JDK-8027526 > http://cr.openjdk.java.net/~wetmore/8027526/webrev/ > 32 * @run main/othervm SignatureGetAlgorithm 33 * @author youdwei 34 * @run main/othervm SignatureGetAlgorithm I think you intended to move line 32 rather than copy? Otherwise, looks okay. Mandy From bradford.wetmore at oracle.com Wed Oct 30 21:45:29 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Wed, 30 Oct 2013 14:45:29 -0700 Subject: Very simple webrev. In-Reply-To: <52717C2B.3080901@oracle.com> References: <52717938.8040804@oracle.com> <52717C2B.3080901@oracle.com> Message-ID: <52717DF9.9070708@oracle.com> *facepalm* CR withdrawn...it must be the one in the closed repo then. Thanks Mandy. Brad On 10/30/2013 2:37 PM, Mandy Chung wrote: > > On 10/30/2013 2:25 PM, Bradford Wetmore wrote: >> >> https://bugs.openjdk.java.net/browse/JDK-8027526 >> http://cr.openjdk.java.net/~wetmore/8027526/webrev/ >> > > 32 * @run main/othervm SignatureGetAlgorithm > 33 * @author youdwei > 34 * @run main/othervm SignatureGetAlgorithm > > I think you intended to move line 32 rather than copy? Otherwise, looks > okay. > > Mandy > From bradford.wetmore at oracle.com Wed Oct 30 22:26:55 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Wed, 30 Oct 2013 15:26:55 -0700 Subject: Very simple webrev. In-Reply-To: <52717DF9.9070708@oracle.com> References: <52717938.8040804@oracle.com> <52717C2B.3080901@oracle.com> <52717DF9.9070708@oracle.com> Message-ID: <527187AF.4020006@oracle.com> I'm still going to change the name of the provider, the name "test" was resulting in failure mode: test failed: some condition which of course wasn't obvious where test was coming from. Brad On 10/30/2013 2:45 PM, Bradford Wetmore wrote: > *facepalm* > > CR withdrawn...it must be the one in the closed repo then. Thanks Mandy. > > Brad > > > > On 10/30/2013 2:37 PM, Mandy Chung wrote: >> >> On 10/30/2013 2:25 PM, Bradford Wetmore wrote: >>> >>> https://bugs.openjdk.java.net/browse/JDK-8027526 >>> http://cr.openjdk.java.net/~wetmore/8027526/webrev/ >>> >> >> 32 * @run main/othervm SignatureGetAlgorithm >> 33 * @author youdwei >> 34 * @run main/othervm SignatureGetAlgorithm >> >> I think you intended to move line 32 rather than copy? Otherwise, looks >> okay. >> >> Mandy >> From lana.steuck at oracle.com Wed Oct 30 22:48:25 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 30 Oct 2013 22:48:25 +0000 Subject: hg: jdk8/tl: 6 new changesets Message-ID: <20131030224827.5C29D6284C@hg.openjdk.java.net> Changeset: b098ee22aa97 Author: erikj Date: 2013-10-24 10:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b098ee22aa97 8009280: JCE jurisdiction policy files not copied into jdk/lib/security Reviewed-by: tbell, ihse ! common/makefiles/JavaCompilation.gmk Changeset: 3c48e11c3901 Author: dholmes Date: 2013-10-24 20:45 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/3c48e11c3901 8016096: [macosx] jawt_md.h shipped with jdk is outdated Summary: Revised build system and added platform specific headers for Mac OS X Reviewed-by: ihse, erikj Contributed-by: david.dehaven at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 Changeset: 72ef61df77e5 Author: ihse Date: 2013-10-25 13:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/72ef61df77e5 8027300: configure should use LIBS instead of LDFLAGS when testing freetype Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: dfbc93f26f38 Author: dcubed Date: 2013-10-25 10:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/dfbc93f26f38 8027117: adapt JDK-7165611 to new build-infra whitespace/indent policy Summary: Fix whitespace/indent issues. Reviewed-by: hseigel, coleenp, erikj, ihse ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/makefiles/NativeCompilation.gmk Changeset: 4f2011496393 Author: katleman Date: 2013-10-28 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4f2011496393 Merge Changeset: 37d2736caf46 Author: lana Date: 2013-10-30 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/37d2736caf46 Merge ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in From lana.steuck at oracle.com Wed Oct 30 22:50:56 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 30 Oct 2013 22:50:56 +0000 Subject: hg: jdk8/tl/hotspot: 67 new changesets Message-ID: <20131030225901.85A9E62850@hg.openjdk.java.net> Changeset: d6d8aeb2c2d4 Author: amurillo Date: 2013-10-19 08:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d6d8aeb2c2d4 8026928: new hotspot build - hs25-b56 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 384c92148c68 Author: amurillo Date: 2013-10-21 14:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/384c92148c68 8023496: [jprt] build and test solaris 64-bits only Reviewed-by: tbell, jcoomes ! make/jprt.properties Changeset: f9d4ed6c88dd Author: dholmes Date: 2013-10-21 20:51 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f9d4ed6c88dd 8026872: [TESTBUG] Classes OOMCrashClass4000_1.class and OOMCrashClass1960_2.class from runtime/ClassFile/ tests won't run on compact profiles Reviewed-by: sla, sspitsyn ! test/TEST.groups Changeset: 8cd1abf3ecab Author: dholmes Date: 2013-10-21 21:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8cd1abf3ecab Merge - src/share/vm/memory/metablock.cpp - src/share/vm/memory/metablock.hpp ! test/TEST.groups - test/compiler/8013496/Test8013496.sh - test/gc/7168848/HumongousAlloc.java Changeset: 2036c97e3af0 Author: dholmes Date: 2013-10-21 22:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2036c97e3af0 Merge Changeset: 7fe6ef09d242 Author: farvidsson Date: 2013-10-16 09:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7fe6ef09d242 8025638: jmap returns 0 instead of 1 when it fails. Summary: Re-factored some code handling return values and fails/errors during tool execution. Reviewed-by: sla, kevinw Contributed-by: fredrik.arvidsson at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/tools/ClassLoaderStats.java ! agent/src/share/classes/sun/jvm/hotspot/tools/FinalizerInfo.java ! agent/src/share/classes/sun/jvm/hotspot/tools/FlagDumper.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapDumper.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JInfo.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JMap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JSnap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/JStack.java ! agent/src/share/classes/sun/jvm/hotspot/tools/ObjectHistogram.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PMap.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java ! agent/src/share/classes/sun/jvm/hotspot/tools/StackTrace.java ! agent/src/share/classes/sun/jvm/hotspot/tools/SysPropsDumper.java ! agent/src/share/classes/sun/jvm/hotspot/tools/Tool.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java ! agent/src/share/classes/sun/jvm/hotspot/tools/soql/JSDB.java ! agent/src/share/classes/sun/jvm/hotspot/tools/soql/SOQL.java Changeset: 042cf42c72bd Author: simonis Date: 2013-10-16 15:06 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/042cf42c72bd 8026703: Wrongly placed element in Event-Based JVM Tracing .xsl files Reviewed-by: sla, kamg ! src/share/vm/trace/traceEventClasses.xsl ! src/share/vm/trace/traceEventIds.xsl ! src/share/vm/trace/traceTypes.xsl Changeset: d248425bcfe8 Author: hseigel Date: 2013-10-16 14:32 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d248425bcfe8 8024804: Crash when InterfaceMethodref resolves to Object.registerNatives Summary: Added check for NULL prior to continuation of method look up to avoid runtime crash during look up of Object's superclass' methods. Reviewed-by: coleenp, hseigel Contributed-by: lois.foltan at oracle.com ! src/share/vm/interpreter/linkResolver.cpp + test/runtime/8024804/RegisterNatives.java Changeset: 9e0ef3f02648 Author: hseigel Date: 2013-10-16 15:26 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9e0ef3f02648 Merge Changeset: 1bee3014cf2a Author: dsamersoff Date: 2013-10-17 16:08 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1bee3014cf2a 8025812: tmtools/jmap/heap_config tests fail on Linux-ia32 because it Cant attach to the core file Summary: Coredump store memsz elf field rounded up to page Reviewed-by: dholmes, sla ! agent/src/os/linux/ps_core.c Changeset: ffb471203842 Author: erikj Date: 2013-10-17 16:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ffb471203842 8026792: HOTSPOT: licensee reports a JDK8 build failure after 8005849/8005008 fixes integrated. Reviewed-by: dholmes, sla ! make/windows/makefiles/trace.make Changeset: ad8e901ca2e1 Author: sla Date: 2013-10-17 12:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ad8e901ca2e1 Merge Changeset: d2db09f281ca Author: dsamersoff Date: 2013-10-17 16:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d2db09f281ca 8005810: Update Hotspot Serviceability Agent for Method Parameter Reflection and Generic Type Signature Data Summary: Hotspot was updated to store method parameter reflection and generic type signature data at runtime. Serviceability agent support was updated for this data Reviewed-by: coleenp, minqi, sla Contributed-by: eric.mccorkle at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! src/share/vm/runtime/vmStructs.cpp Changeset: b942ac65ac86 Author: dsamersoff Date: 2013-10-17 17:01 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b942ac65ac86 Merge Changeset: d0453d2fd045 Author: dsamersoff Date: 2013-10-18 10:37 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d0453d2fd045 Merge Changeset: ee99e1a7c5fb Author: ccheung Date: 2013-10-18 19:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ee99e1a7c5fb Merge ! src/share/vm/interpreter/linkResolver.cpp - src/share/vm/memory/metablock.cpp - src/share/vm/memory/metablock.hpp ! src/share/vm/runtime/vmStructs.cpp - test/compiler/8013496/Test8013496.sh - test/gc/7168848/HumongousAlloc.java Changeset: 996d1f2f056f Author: dsamersoff Date: 2013-10-19 21:29 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/996d1f2f056f 8026930: In ManagementAgent.start it should be possible to set the jdp.name parameter (hotspot part) Summary: Pass one more property from Agent to JdpController Reviewed-by: jbachorik, sla ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp Changeset: 1327b7f85503 Author: ccheung Date: 2013-10-21 17:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1327b7f85503 Merge Changeset: 662c154d2749 Author: hseigel Date: 2013-10-22 14:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/662c154d2749 8026394: Eclipse fails with JDK8 build 111 Summary: If the resolved interface does not itself contain "clone" or "finalize" methods, the method/interface method resolution looks to the interface's super class, java.lang.Object. With the JDK 8 interface method accessability check requirement, since these two methods are declared within Object as protected, they must be special cased in LinkResolver::check_method_accessability() in order to avoid an IAE. Reviewed-by: acorn, dholmes Contributed-by: lois.foltan at oracle.com ! src/share/vm/interpreter/linkResolver.cpp + test/runtime/8026394/InterfaceObjectTest.java Changeset: b8860472c377 Author: iklam Date: 2013-10-22 14:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b8860472c377 8014910: deadlock between JVM/TI ClassPrepare event handler and CompilerThread Summary: Revert changes in JDK-8008962 Reviewed-by: coleenp, sspitsyn ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiEnv.cpp Changeset: 28be4c586b70 Author: iklam Date: 2013-10-22 16:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/28be4c586b70 Merge Changeset: a997d762fa20 Author: hseigel Date: 2013-10-22 15:54 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a997d762fa20 8026809: [TESTBUG] Create regression test for JDK-8026041 Summary: Created simple regression test for the bug Reviewed-by: hseigel, lfoltan, zgu Contributed-by: mikhailo.seledtsov at oracle.com + test/runtime/CommandLine/PrintGCApplicationConcurrentTime.java Changeset: c183576a2dd1 Author: hseigel Date: 2013-10-22 22:14 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c183576a2dd1 Merge Changeset: b658cfe35857 Author: farvidsson Date: 2013-10-23 10:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b658cfe35857 8026808: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failed with unexpected exit value Summary: Fixes a bug with vmArgs when using JDKToolLauncher Reviewed-by: sla, dholmes ! test/testlibrary/com/oracle/java/testlibrary/JDKToolLauncher.java Changeset: b3a4d4279fa3 Author: ccheung Date: 2013-10-24 17:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b3a4d4279fa3 Merge Changeset: 74e00b98d5dd Author: anoll Date: 2013-10-17 19:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/74e00b98d5dd 8026708: guarantee(codelet_size > 0 && (size_t)codelet_size > 2*K) failed: not enough space for interpreter generation Summary: Increase size for the template interpreter accordingly Reviewed-by: kvn, twisti ! src/cpu/x86/vm/templateInterpreter_x86.hpp Changeset: 1856ea98184a Author: adlertz Date: 2013-10-18 10:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1856ea98184a 8022783: Nashorn test fails with: assert(!def_outside->member(r)) Summary: Enables private copies of inputs for recent spill copies as well Reviewed-by: kvn, twisti ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/reg_split.cpp Changeset: e3b736cf4fa3 Author: adlertz Date: 2013-10-18 09:36 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e3b736cf4fa3 Merge Changeset: 252d541466ea Author: morris Date: 2013-10-18 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/252d541466ea 8008242: VerifyOops is broken on SPARC Summary: Fixed displacement issues in SPARC macroassembler and ensure that getClass intrinsic temporary result is T_METADATA Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp Changeset: 3213ba4d3dff Author: roland Date: 2013-10-19 12:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3213ba4d3dff 8024069: replace_in_map() should operate on parent maps Summary: type information gets lost because replace_in_map() doesn't update parent maps Reviewed-by: kvn, twisti ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/multnode.cpp ! src/share/vm/opto/multnode.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp Changeset: 19c5a042b0b3 Author: iignatyev Date: 2013-10-19 21:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/19c5a042b0b3 8026414: [TESTBUG] Tests for Tiered/NonTiered levels Reviewed-by: twisti, iveresov + test/compiler/tiered/CompLevelsTest.java + test/compiler/tiered/NonTieredLevelsTest.java + test/compiler/tiered/TieredLevelsTest.java Changeset: 600c83f8e6a5 Author: iignatyev Date: 2013-10-19 21:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/600c83f8e6a5 8023318: compiler/whitebox tests timeout with enabled TieredCompilation Reviewed-by: kvn, twisti ! test/compiler/whitebox/CompilerWhiteBoxTest.java Changeset: e842cc2d2dfb Author: iveresov Date: 2013-10-19 22:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e842cc2d2dfb Merge Changeset: 52575a17a36c Author: iignatyev Date: 2013-10-21 09:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/52575a17a36c 8026865: [TESTBUG] 'compiler/print/PrintInlining.java' should specify -XX:+UnlockDiagnosticVMOptions Reviewed-by: twisti, iveresov ! test/compiler/print/PrintInlining.java Changeset: 4748b3308cda Author: iveresov Date: 2013-10-21 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4748b3308cda Merge Changeset: 5ccbab1c69f3 Author: roland Date: 2013-10-22 09:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5ccbab1c69f3 8026251: New type profiling points: parameters to methods Summary: x86 interpreter and c1 type profiling for parameters on method entries Reviewed-by: kvn, twisti ! src/cpu/x86/vm/bytecodeInterpreter_x86.cpp ! src/cpu/x86/vm/globals_x86.hpp + src/cpu/x86/vm/interp_masm_x86.cpp + src/cpu/x86/vm/interp_masm_x86.hpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/register_definitions_x86.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/vtableStubs_x86_32.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/templateTable.hpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp Changeset: 435c7b4577cd Author: rbackman Date: 2013-10-21 15:31 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/435c7b4577cd 8026959: assert(!n->pinned() || n->is_MachConstantBase()) failed: only pinned MachConstantBase node is expected here Reviewed-by: iveresov, roland ! src/share/vm/opto/compile.cpp Changeset: 36e17466dd39 Author: rbackman Date: 2013-10-22 14:02 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/36e17466dd39 Merge Changeset: 8b4bbba322d3 Author: anoll Date: 2013-10-23 10:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8b4bbba322d3 8026407: VM crashes on linux-ppc and linux-i586 when there is not enough ReservedCodeCacheSize specified Summary: Ensure currently required generation of AdapterHandlerLibrary::create_native_wrapper() Reviewed-by: roland, iveresov ! src/share/vm/compiler/compileBroker.cpp Changeset: b2ee5dc63353 Author: roland Date: 2013-10-23 12:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b2ee5dc63353 8024070: C2 needs some form of type speculation Summary: record unused type profile information with type system, propagate and use it. Reviewed-by: kvn, twisti ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/arguments.cpp + test/compiler/types/TypeSpeculation.java Changeset: 4c9115774c8e Author: adlertz Date: 2013-10-23 10:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4c9115774c8e 8026939: assert(Reachblock != NULL) failed: Reachblock must be non-NULL Summary: We can reach this state from phi input rematerialization, so pass in the Reaches of the predecessor Reviewed-by: roland, twisti ! src/share/vm/opto/reg_split.cpp Changeset: 97d400662426 Author: adlertz Date: 2013-10-23 19:22 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/97d400662426 Merge Changeset: 9acbfe04b5c3 Author: iveresov Date: 2013-10-23 11:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9acbfe04b5c3 8026495: JVM Crashes when started with -XX:+DTraceMethodProbes on Solaris x86_64 Summary: Fix wrong calling convention in LIR_Assembler::emit_unwind_handler(), T_METADATA support in calling convention generator, C1 register allocator Reviewed-by: twisti, jrose ! src/cpu/sparc/vm/c1_FrameMap_sparc.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LinearScan.cpp Changeset: 1c90f0072f0d Author: twisti Date: 2013-10-23 15:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1c90f0072f0d 8026502: java/lang/invoke/MethodHandleConstants.java fails on all platforms Reviewed-by: iveresov, jrose ! src/share/vm/classfile/systemDictionary.cpp Changeset: 3a04e444da6d Author: iveresov Date: 2013-10-23 16:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3a04e444da6d Merge Changeset: 59e8ad757e19 Author: rbackman Date: 2013-10-18 10:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/59e8ad757e19 8026844: Various Math functions needs intrinsification Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/mathexactnode.cpp ! src/share/vm/opto/mathexactnode.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/vmStructs.cpp + test/compiler/intrinsics/mathexact/AddExactICondTest.java + test/compiler/intrinsics/mathexact/AddExactIConstantTest.java + test/compiler/intrinsics/mathexact/AddExactILoadTest.java + test/compiler/intrinsics/mathexact/AddExactILoopDependentTest.java + test/compiler/intrinsics/mathexact/AddExactINonConstantTest.java + test/compiler/intrinsics/mathexact/AddExactIRepeatTest.java + test/compiler/intrinsics/mathexact/AddExactLConstantTest.java + test/compiler/intrinsics/mathexact/AddExactLNonConstantTest.java - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java + test/compiler/intrinsics/mathexact/DecExactITest.java + test/compiler/intrinsics/mathexact/DecExactLTest.java + test/compiler/intrinsics/mathexact/IncExactITest.java + test/compiler/intrinsics/mathexact/IncExactLTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java + test/compiler/intrinsics/mathexact/MulExactICondTest.java + test/compiler/intrinsics/mathexact/MulExactIConstantTest.java + test/compiler/intrinsics/mathexact/MulExactILoadTest.java + test/compiler/intrinsics/mathexact/MulExactILoopDependentTest.java + test/compiler/intrinsics/mathexact/MulExactINonConstantTest.java + test/compiler/intrinsics/mathexact/MulExactIRepeatTest.java + test/compiler/intrinsics/mathexact/MulExactLConstantTest.java + test/compiler/intrinsics/mathexact/MulExactLNonConstantTest.java + test/compiler/intrinsics/mathexact/NegExactIConstantTest.java + test/compiler/intrinsics/mathexact/NegExactILoadTest.java + test/compiler/intrinsics/mathexact/NegExactILoopDependentTest.java + test/compiler/intrinsics/mathexact/NegExactINonConstantTest.java + test/compiler/intrinsics/mathexact/NegExactLConstantTest.java + test/compiler/intrinsics/mathexact/NegExactLNonConstantTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java + test/compiler/intrinsics/mathexact/SubExactICondTest.java + test/compiler/intrinsics/mathexact/SubExactIConstantTest.java + test/compiler/intrinsics/mathexact/SubExactILoadTest.java + test/compiler/intrinsics/mathexact/SubExactILoopDependentTest.java + test/compiler/intrinsics/mathexact/SubExactINonConstantTest.java + test/compiler/intrinsics/mathexact/SubExactIRepeatTest.java + test/compiler/intrinsics/mathexact/SubExactLConstantTest.java + test/compiler/intrinsics/mathexact/SubExactLNonConstantTest.java ! test/compiler/intrinsics/mathexact/Verify.java Changeset: 68f07c29521b Author: anoll Date: 2013-10-15 08:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/68f07c29521b 8025740: Typo. Error line for wrong ReservedCodeCacheSize value is printed twice Summary: Remove duplicate print Reviewed-by: kvn, twisti ! src/share/vm/runtime/arguments.cpp Changeset: d95eca175eff Author: sspitsyn Date: 2013-10-23 20:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d95eca175eff 8023004: JSR 292: java.lang.RuntimeException: Original target method was called. Reviewed-by: jrose ! src/share/vm/prims/methodHandles.cpp Changeset: 0d1661d63d70 Author: vlivanov Date: 2013-10-23 20:20 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0d1661d63d70 8012941: JSR 292: too deep inlining might crash compiler because of stack overflow Reviewed-by: kvn, twisti ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_globals.hpp Changeset: f7d928a3181c Author: roland Date: 2013-10-24 19:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f7d928a3181c 8026978: JSR292: fatal error: Type profiling not implemented on this platform Summary: force TypeProfileLevel to 0 on non x86 Reviewed-by: twisti ! src/share/vm/runtime/arguments.cpp Changeset: 395499125cb0 Author: iveresov Date: 2013-10-24 16:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/395499125cb0 Merge - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java Changeset: 6b32b911d723 Author: iveresov Date: 2013-10-24 16:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6b32b911d723 Merge ! src/share/vm/runtime/vmStructs.cpp - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java Changeset: 1d1ea10fe09f Author: mgerdin Date: 2013-10-15 13:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1d1ea10fe09f 8015255: NPG: Don't waste fragment at the end of a VirtualSpaceNode before retiring it. Summary: Chunk up the last piece of committed memory in a VSN when getting a new one. Reviewed-by: stefank, jmasa ! src/share/vm/memory/metaspace.cpp ! src/share/vm/prims/jni.cpp Changeset: 91a88c8450f4 Author: mgerdin Date: 2013-10-18 09:31 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/91a88c8450f4 8026698: Incorrect error handling in Metaspace::allocate Reviewed-by: stefank, jwilhelm ! src/share/vm/memory/metaspace.cpp Changeset: a1b05d4a6fd0 Author: stefank Date: 2013-10-21 09:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a1b05d4a6fd0 8026781: Add missing test to exercise -XX:+UseLargePagesInMetaspace Reviewed-by: mgerdin, brutisso + test/gc/TestSystemGC.java Changeset: 3dd24766da44 Author: stefank Date: 2013-10-21 01:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3dd24766da44 Merge Changeset: 2fab5b7e6140 Author: ehelin Date: 2013-10-21 14:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2fab5b7e6140 8025834: NPE in Parallel Scavenge with -XX:+CheckUnhandledOops Reviewed-by: coleenp, mgerdin, sspitsyn ! src/share/vm/prims/jvmtiImpl.cpp Changeset: c7f403b05168 Author: sjohanss Date: 2013-10-22 11:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c7f403b05168 8026848: -XX:+G1SummarizeRSetStats can result in wrong exit code and crash Summary: Changed the use of %d to SIZE_FORMAT macro in format string when printing size_t values. Reviewed-by: stefank, ehelin ! src/share/vm/gc_implementation/g1/g1RemSetSummary.cpp Changeset: 0823c8bac468 Author: jcoomes Date: 2013-10-22 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0823c8bac468 Merge Changeset: 1b422ef5288a Author: tschatzl Date: 2013-10-23 10:23 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1b422ef5288a 8025728: Missing volatile specifier for field G1AllocRegion::_alloc_region Summary: The field G1AllocRegion::_alloc_region needs to be declared volatile as it is used with that intention. Otherwise the compiler may generate the code that reloads the value which might have changed in the meantime, leading to spurious crashes. Reviewed-by: iveresov, simonis, tschatzl Contributed-by: Axel Siebenborn ! src/share/vm/gc_implementation/g1/g1AllocRegion.hpp Changeset: 0dcdec729cda Author: jcoomes Date: 2013-10-25 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0dcdec729cda Merge Changeset: 82a9cdbf683e Author: amurillo Date: 2013-10-25 13:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/82a9cdbf683e Merge ! src/share/vm/services/diagnosticCommand.cpp - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java Changeset: bde83ddf920c Author: amurillo Date: 2013-10-25 13:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bde83ddf920c Added tag hs25-b56 for changeset 82a9cdbf683e ! .hgtags Changeset: e006d2e25bc7 Author: dholmes Date: 2013-10-24 20:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e006d2e25bc7 8025673: [macosx] Disable X11 AWT toolkit Summary: Disable but not completely remove the XAWT and headless toolkits on Mac OS X Reviewed-by: dholmes Contributed-by: david.dehaven at oracle.com ! src/os/bsd/vm/os_bsd.cpp Changeset: 913a35723a0a Author: katleman Date: 2013-10-28 16:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/913a35723a0a Merge Changeset: 7fd913010dbb Author: katleman Date: 2013-10-29 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7fd913010dbb Merge Changeset: ea1b8c643fc8 Author: lana Date: 2013-10-30 13:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ea1b8c643fc8 Merge - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java From lana.steuck at oracle.com Wed Oct 30 22:49:43 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 30 Oct 2013 22:49:43 +0000 Subject: hg: jdk8/tl/jdk: 7 new changesets Message-ID: <20131030225652.23DDB6284E@hg.openjdk.java.net> Changeset: 110c4fe4c354 Author: erikj Date: 2013-10-24 10:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/110c4fe4c354 8009280: JCE jurisdiction policy files not copied into jdk/lib/security Reviewed-by: tbell, ihse ! makefiles/BuildJdk.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk + makefiles/CreateSecurityJars.gmk ! makefiles/SignJars.gmk Changeset: f40f639e1f52 Author: dholmes Date: 2013-10-24 20:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f40f639e1f52 8016096: [macosx] jawt_md.h shipped with jdk is outdated Summary: Revised build system and added platform specific headers for Mac OS X Reviewed-by: anthony, art, ihse, erikj Contributed-by: david.dehaven at oracle.com ! makefiles/CopyFiles.gmk ! makefiles/gensrc/GensrcX11Wrappers.gmk + src/macosx/javavm/export/jawt_md.h + src/macosx/javavm/export/jni_md.h + src/macosx/javavm/export/jvm_md.h ! src/macosx/native/sun/awt/AWTSurfaceLayers.h ! src/macosx/native/sun/awt/CMenuComponent.h ! src/macosx/native/sun/awt/jawt.m ! src/macosx/native/sun/font/CoreTextSupport.h ! src/share/javavm/export/jawt.h Changeset: f3c95d961557 Author: dholmes Date: 2013-10-24 20:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3c95d961557 8025673: [macosx] Disable X11 AWT toolkit Summary: Disable but not completely remove the XAWT and headless toolkits on Mac OS X Reviewed-by: anthony, art, ihse, erikj Contributed-by: david.dehaven at oracle.com ! makefiles/CompileJavaClasses.gmk ! makefiles/GenerateSources.gmk ! makefiles/Tools.gmk ! makefiles/lib/Awt2dLibraries.gmk ! src/share/native/java/lang/System.c ! src/share/native/java/lang/java_props.h ! src/solaris/native/java/lang/java_props_macosx.c ! src/solaris/native/java/lang/java_props_macosx.h ! src/solaris/native/java/lang/java_props_md.c ! src/solaris/native/sun/awt/fontpath.c ! test/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh Changeset: 5813af4c02e4 Author: dcubed Date: 2013-10-25 10:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5813af4c02e4 8027117: adapt JDK-7165611 to new build-infra whitespace/indent policy Summary: Fix whitespace/indent issues. Reviewed-by: hseigel, coleenp, erikj, ihse ! makefiles/Import.gmk Changeset: 1628a137edca Author: katleman Date: 2013-10-28 16:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1628a137edca Merge Changeset: f26a0c8071bd Author: erikj Date: 2013-10-29 15:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f26a0c8071bd 8027298: broken link in jdk8b113 macosx binaries Reviewed-by: dcubed, ihse ! makefiles/Import.gmk Changeset: 348ffbd19feb Author: lana Date: 2013-10-30 13:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/348ffbd19feb Merge ! makefiles/CreateJars.gmk + makefiles/CreateSecurityJars.gmk From brian.goetz at oracle.com Wed Oct 30 23:37:05 2013 From: brian.goetz at oracle.com (brian.goetz at oracle.com) Date: Wed, 30 Oct 2013 23:37:05 +0000 Subject: hg: jdk8/tl/jdk: 8027318: Lambda Metafactory: generate serialization-hostile read/writeObject methods for non-serializable lambdas Message-ID: <20131030233742.12BDF62854@hg.openjdk.java.net> Changeset: ddb0b681654a Author: briangoetz Date: 2013-10-29 12:31 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddb0b681654a 8027318: Lambda Metafactory: generate serialization-hostile read/writeObject methods for non-serializable lambdas Reviewed-by: rfield, psandoz ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! test/java/util/stream/test/org/openjdk/tests/java/lang/invoke/SerializedLambdaTest.java From bradford.wetmore at oracle.com Wed Oct 30 23:53:42 2013 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Wed, 30 Oct 2013 23:53:42 +0000 Subject: hg: jdk8/tl/jdk: 8027526: CheckTipsAndVersions.java failing occasionally Message-ID: <20131030235426.0554C62855@hg.openjdk.java.net> Changeset: f731d096530f Author: wetmore Date: 2013-10-30 16:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f731d096530f 8027526: CheckTipsAndVersions.java failing occasionally Reviewed-by: mullan, mchung ! test/java/security/Signature/SignatureGetAlgorithm.java From jaroslav.bachorik at oracle.com Tue Oct 29 21:03:06 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Tue, 29 Oct 2013 21:03:06 +0000 Subject: hg: jdk8/tl/jdk: 8027358: sun/management/jmxremote/bootstrap/LocalManagementTest.java failing since JDK-8004926 Message-ID: <20131029210417.D498C62801@hg.openjdk.java.net> Changeset: a3ac9c0b19a9 Author: jbachorik Date: 2013-10-29 21:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3ac9c0b19a9 8027358: sun/management/jmxremote/bootstrap/LocalManagementTest.java failing since JDK-8004926 Reviewed-by: alanb, egahlin ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java ! test/sun/management/jmxremote/bootstrap/LocalManagementTest.java From michael.fang at oracle.com Tue Oct 29 22:33:39 2013 From: michael.fang at oracle.com (michael.fang at oracle.com) Date: Tue, 29 Oct 2013 22:33:39 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131029223451.443006280B@hg.openjdk.java.net> Changeset: 8cfc73ad9f31 Author: mfang Date: 2013-10-29 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8cfc73ad9f31 8008647: [es] minor cosmetic issues in translated java command line outputs Reviewed-by: naoto ! src/share/classes/sun/tools/jar/resources/jar_es.properties Changeset: 4071c853edff Author: mfang Date: 2013-10-29 15:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4071c853edff Merge From michael.fang at oracle.com Wed Oct 30 00:01:11 2013 From: michael.fang at oracle.com (michael.fang at oracle.com) Date: Wed, 30 Oct 2013 00:01:11 +0000 Subject: hg: jdk8/tl/jdk: 8025521: [de] mnemonic conflict in FileChooser for GTK Style feel&look Message-ID: <20131030000215.4EA766280F@hg.openjdk.java.net> Changeset: bede752d1e3c Author: mfang Date: 2013-10-29 16:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bede752d1e3c 8025521: [de] mnemonic conflict in FileChooser for GTK Style feel&look Reviewed-by: naoto ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_de.properties From jaroslav.bachorik at oracle.com Wed Oct 30 13:51:44 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Wed, 30 Oct 2013 13:51:44 +0000 Subject: hg: jdk8/tl/jdk: 8027058: sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh Failed to initialize connector Message-ID: <20131030135216.319FA62826@hg.openjdk.java.net> Changeset: 5d1bda6c1fe3 Author: jbachorik Date: 2013-10-30 14:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d1bda6c1fe3 8027058: sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh Failed to initialize connector Summary: Dynamically discover the first available port instead of hard-coding one Reviewed-by: sla, chegar, dfuchs ! test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.java From michael.fang at oracle.com Wed Oct 30 16:39:32 2013 From: michael.fang at oracle.com (michael.fang at oracle.com) Date: Wed, 30 Oct 2013 16:39:32 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20131030164115.C0F1062835@hg.openjdk.java.net> Changeset: 550244957351 Author: mfang Date: 2013-10-30 09:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/550244957351 6192407: s10_70, ko, s1/dvd, minor misspelling under "Select Software Localizations" Reviewed-by: yhuang ! src/share/classes/sun/util/resources/ko/LocaleNames_ko.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: e45b48874ba9 Author: mfang Date: 2013-10-30 09:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e45b48874ba9 6931564: Incorrect display name of Locale for south africa Reviewed-by: yhuang ! src/share/classes/sun/util/resources/sv/LocaleNames_sv.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java From jaroslav.bachorik at oracle.com Wed Oct 30 16:56:50 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Wed, 30 Oct 2013 16:56:50 +0000 Subject: hg: jdk8/tl/jdk: 8020467: Inconsistency between usage.getUsed() and isUsageThresholdExceeded() with CMS Old Gen pool Message-ID: <20131030165725.8FCDA62837@hg.openjdk.java.net> Changeset: 2a714dabb624 Author: jbachorik Date: 2013-10-30 17:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a714dabb624 8020467: Inconsistency between usage.getUsed() and isUsageThresholdExceeded() with CMS Old Gen pool Reviewed-by: mchung, brutisso ! test/java/lang/management/MemoryPoolMXBean/ThresholdTest.java From joe.darcy at oracle.com Thu Oct 31 00:33:16 2013 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 31 Oct 2013 00:33:16 +0000 Subject: hg: jdk8/tl/jdk: 8005294: Consider default methods for additions to AnnotatedElement Message-ID: <20131031003400.8C14062856@hg.openjdk.java.net> Changeset: e8894e3224d9 Author: darcy Date: 2013-10-30 17:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8894e3224d9 8005294: Consider default methods for additions to AnnotatedElement Reviewed-by: jfranck, plevart, mchung, abuckley, sogoel ! src/share/classes/java/lang/reflect/AnnotatedElement.java + test/java/lang/reflect/AnnotatedElement/TestAnnotatedElementDefaults.java From stuart.marks at oracle.com Thu Oct 31 01:41:36 2013 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Thu, 31 Oct 2013 01:41:36 +0000 Subject: hg: jdk8/tl/jdk: 8023863: deprecate support for statically-generated stubs from RMI (JRMP); ... Message-ID: <20131031014252.633DA6285E@hg.openjdk.java.net> Changeset: 1ea1b24c1a04 Author: smarks Date: 2013-10-30 18:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ea1b24c1a04 8023863: deprecate support for statically-generated stubs from RMI (JRMP) 4449028: exportObject() javadoc should specify behavior for null socket factories Reviewed-by: dfuchs, darcy ! src/share/classes/java/rmi/server/RemoteStub.java ! src/share/classes/java/rmi/server/UnicastRemoteObject.java ! src/share/classes/java/rmi/server/package.html From brian.burkhalter at oracle.com Thu Oct 31 00:47:15 2013 From: brian.burkhalter at oracle.com (brian.burkhalter at oracle.com) Date: Thu, 31 Oct 2013 00:47:15 +0000 Subject: hg: jdk8/tl/jdk: 6910473: java.math.BigInteger.bitLength() may return negative "int" on large numbers; ... Message-ID: <20131031004802.2EF9262857@hg.openjdk.java.net> Changeset: 0734e1584d9d Author: bpb Date: 2013-10-30 17:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0734e1584d9d 6910473: java.math.BigInteger.bitLength() may return negative "int" on large numbers 8021203: BigInteger.doubleValue/floatValue returns 0.0 instead of Infinity 8021204: Constructor BigInteger(String val, int radix) doesn't detect overflow 8022780: Incorrect BigInteger division because of MutableBigInteger.bitLength() overflow Summary: Prevent construction of overflowed BigIntegers. Reviewed-by: bpb, darcy, psandoz Contributed-by: Dmitry Nadezhin ! src/share/classes/java/math/BigInteger.java ! src/share/classes/java/math/MutableBigInteger.java + test/java/math/BigInteger/BitLengthOverflow.java + test/java/math/BigInteger/DivisionOverflow.java + test/java/math/BigInteger/DoubleValueOverflow.java ! test/java/math/BigInteger/ExtremeShiftingTests.java + test/java/math/BigInteger/StringConstructorOverflow.java + test/java/math/BigInteger/SymmetricRangeTests.java From sundararajan.athijegannathan at oracle.com Thu Oct 31 08:52:59 2013 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Thu, 31 Oct 2013 08:52:59 +0000 Subject: hg: jdk8/tl/nashorn: 4 new changesets Message-ID: <20131031085308.7E9D96286F@hg.openjdk.java.net> Changeset: adab2c628923 Author: jlaskey Date: 2013-10-29 14:22 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/adab2c628923 8027447: The wrong string buffer is specified for stderr in $EXEC Reviewed-by: lagergren, sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java Changeset: 645197151cc3 Author: jlaskey Date: 2013-10-30 11:28 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/645197151cc3 8027532: nashorn should only use jdk8 apis in the compact1 profile Reviewed-by: sundar, lagergren, hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/ir/debug/ObjectSizeCalculator.java Changeset: a002c1bb88f9 Author: sundar Date: 2013-10-30 20:09 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a002c1bb88f9 8027562: eval should load second and subsequent arguments for side effect Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8027562.js + test/script/basic/JDK-8027562.js.EXPECTED Changeset: 5ce78473d6c3 Author: sundar Date: 2013-10-31 12:50 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5ce78473d6c3 Merge From paul.sandoz at oracle.com Thu Oct 31 11:03:16 2013 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Thu, 31 Oct 2013 11:03:16 +0000 Subject: hg: jdk8/tl/jdk: 8027316: Distinct operation on an unordered stream should not be a barrier Message-ID: <20131031110754.2866B62875@hg.openjdk.java.net> Changeset: 18c111c17231 Author: psandoz Date: 2013-10-31 11:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18c111c17231 8027316: Distinct operation on an unordered stream should not be a barrier Reviewed-by: henryjen, mduigou, briangoetz ! src/share/classes/java/util/stream/DistinctOps.java ! src/share/classes/java/util/stream/StreamSpliterators.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java From brian.goetz at oracle.com Thu Oct 31 15:01:04 2013 From: brian.goetz at oracle.com (brian.goetz at oracle.com) Date: Thu, 31 Oct 2013 15:01:04 +0000 Subject: hg: jdk8/tl/jdk: 8024633: Lambda linkage performance - initialize generated class earlier Message-ID: <20131031150144.7E52862880@hg.openjdk.java.net> Changeset: 9732816c9d17 Author: briangoetz Date: 2013-10-29 12:45 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9732816c9d17 8024633: Lambda linkage performance - initialize generated class earlier Reviewed-by: briangoetz, rfield Contributed-by: sergey.kuksenko at oracle.com ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java From brian.goetz at oracle.com Thu Oct 31 14:49:05 2013 From: brian.goetz at oracle.com (brian.goetz at oracle.com) Date: Thu, 31 Oct 2013 14:49:05 +0000 Subject: hg: jdk8/tl/jdk: 8024637: Lambda linkage performance - use reflection instead of ASM to manipulate parameter types; ... Message-ID: <20131031145701.89E916287E@hg.openjdk.java.net> Changeset: 82ee370c3d7e Author: briangoetz Date: 2013-10-31 10:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82ee370c3d7e 8024637: Lambda linkage performance - use reflection instead of ASM to manipulate parameter types 8023984: Lambda linkage performance - use a method ref to a static factory instead of a ctor ref Reviewed-by: briangoetz, rfield Contributed-by: sergey.kuksenko at oracle.com ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/share/classes/java/lang/invoke/TypeConvertingMethodAdapter.java From dan.xu at oracle.com Thu Oct 31 18:57:40 2013 From: dan.xu at oracle.com (dan.xu at oracle.com) Date: Thu, 31 Oct 2013 18:57:40 +0000 Subject: hg: jdk8/tl/jdk: 8027155: test/java/io/File/NulFile.java failing when test run in othervm mode Message-ID: <20131031185812.6E5166288F@hg.openjdk.java.net> Changeset: e93de88661ab Author: dxu Date: 2013-10-31 11:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e93de88661ab 8027155: test/java/io/File/NulFile.java failing when test run in othervm mode Reviewed-by: mchung, alanb ! test/java/io/File/NulFile.java From huizhe.wang at oracle.com Thu Oct 31 20:53:14 2013 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Thu, 31 Oct 2013 20:53:14 +0000 Subject: hg: jdk8/tl/jdk: 8024876: [TEST_BUG] javax/xml/jaxp/parsers/8022548/XOMParserTest.java failed when testbase dir has read only permissions Message-ID: <20131031205326.E49F9628B5@hg.openjdk.java.net> Changeset: c4bbd5963f9c Author: joehw Date: 2013-10-31 13:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4bbd5963f9c 8024876: [TEST_BUG] javax/xml/jaxp/parsers/8022548/XOMParserTest.java failed when testbase dir has read only permissions Reviewed-by: chegar ! test/javax/xml/jaxp/parsers/8022548/XOMParserTest.java From dan.xu at oracle.com Thu Oct 31 22:05:17 2013 From: dan.xu at oracle.com (Dan Xu) Date: Thu, 31 Oct 2013 15:05:17 -0700 Subject: RFR: JDK-8027624 - com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again Message-ID: <5272D41D.8030207@oracle.com> Hi All, Please help review a simple change towards the testcase, TestProviderLeak.java. In the call of SecretKeyFactory.getInstance(), it will try to access files under temporary directory by calling File.list() method. And this list() method may consume a lot of memory if there are large amount of files inside. In such case, it will cause OutOfMemory error and fail the test. As the contents in the tmp directory vary at different time and on different machines, it leads to the fragility of this test. In the change, it moves eatupMemory() method close to the testing iteration to avoid the memory consumption in non-testing codes. Bug: https://bugs.openjdk.java.net/browse/JDK-8027624 Webrev: http://cr.openjdk.java.net/~dxu/8027624/webrev/ Thanks, -Dan -------------- next part -------------- An HTML attachment was scrubbed... URL: From bernd-2013 at eckenfels.net Thu Oct 31 22:15:47 2013 From: bernd-2013 at eckenfels.net (Bernd Eckenfels) Date: Thu, 31 Oct 2013 23:15:47 +0100 Subject: RFR: JDK-8027624 - com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again In-Reply-To: <5272D41D.8030207@oracle.com> References: <5272D41D.8030207@oracle.com> Message-ID: Am 31.10.2013, 23:05 Uhr, schrieb Dan Xu : > In the call of SecretKeyFactory.getInstance(), it will try to access > files under temporary directory by calling File.list() method. And this > list() method may consume a lot of memory if there are large amount of > files inside. You could also consider using File.newDirectoryStream of NIO.2 Gruss Bernd -- http://bernd.eckenfels.net From bradford.wetmore at oracle.com Thu Oct 31 22:24:07 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Thu, 31 Oct 2013 15:24:07 -0700 Subject: RFR: JDK-8027624 - com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again In-Reply-To: <5272D41D.8030207@oracle.com> References: <5272D41D.8030207@oracle.com> Message-ID: <5272D887.3030002@oracle.com> Looks good, thanks for looking at this, Dan! Brad On 10/31/2013 3:05 PM, Dan Xu wrote: > Hi All, > > Please help review a simple change towards the testcase, > TestProviderLeak.java. > > In the call of SecretKeyFactory.getInstance(), it will try to access > files under temporary directory by calling File.list() method. And this > list() method may consume a lot of memory if there are large amount of > files inside. In such case, it will cause OutOfMemory error and fail the > test. As the contents in the tmp directory vary at different time and on > different machines, it leads to the fragility of this test. In the > change, it moves eatupMemory() method close to the testing iteration to > avoid the memory consumption in non-testing codes. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8027624 > Webrev: http://cr.openjdk.java.net/~dxu/8027624/webrev/ > > > Thanks, > > -Dan From dan.xu at oracle.com Thu Oct 31 23:26:32 2013 From: dan.xu at oracle.com (Dan Xu) Date: Thu, 31 Oct 2013 16:26:32 -0700 Subject: RFR: JDK-8027624 - com/sun/crypto/provider/KeyFactory/TestProviderLeak.java unstable again In-Reply-To: References: <5272D41D.8030207@oracle.com> Message-ID: <5272E728.80507@oracle.com> Hi Bernd, You are right, Thanks for your suggestion. We already have an enhancement logged on this improvement, please see JDK-7176176. I have linked it to this bug and commented about it. -Dan On 10/31/2013 03:15 PM, Bernd Eckenfels wrote: > Am 31.10.2013, 23:05 Uhr, schrieb Dan Xu : >> In the call of SecretKeyFactory.getInstance(), it will try to access >> files under temporary directory by calling File.list() method. And this >> list() method may consume a lot of memory if there are large amount of >> files inside. > > You could also consider using File.newDirectoryStream of NIO.2 > > Gruss > Bernd From jaroslav.bachorik at oracle.com Thu Oct 31 11:14:55 2013 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Thu, 31 Oct 2013 11:14:55 +0000 Subject: hg: jdk8/tl/jdk: 7144200: java/lang/management/ClassLoadingMXBean/LoadCounts.java failed with JFR enabled Message-ID: <20131031111541.D248862876@hg.openjdk.java.net> Changeset: bb4b1e1e390d Author: jbachorik Date: 2013-10-31 11:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb4b1e1e390d 7144200: java/lang/management/ClassLoadingMXBean/LoadCounts.java failed with JFR enabled Summary: Make the test less stringent by not requiring the number of loaded classes to increase by a specific number Reviewed-by: sla ! test/ProblemList.txt ! test/java/lang/management/ClassLoadingMXBean/LoadCounts.java