RFR 8098854: Do cleanup in a proper order in mscapi

Vincent Ryan vincent.x.ryan at oracle.com
Wed Jul 1 17:08:43 UTC 2015


Your fix looks fine to me.
Thanks.


> On 1 Jul 2015, at 18:04, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
> 
> Hello!
> 
> Would someone please help review this small cleanup fix?
> I'll go on vacation in a week, and I would like to push it before then.
> 
> Sincerely yours,
> Ivan
> 
> On 19.06.2015 22:17, Ivan Gerasimov wrote:
>> Hello everyone!
>> 
>> The changeset consists of two parts:
>> - checking systematically for NULL result of FindClass() and GetMethodID(),
>> - calling CryptReleaseContext() after CryptDestroyHash(), as it is suggested in MSDN [1].
>> 
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8098854
>> WEBREV: http://cr.openjdk.java.net/~igerasim/8098854/00/webrev/
>> 
>> [1] https://msdn.microsoft.com/en-us/library/windows/desktop/aa380268(v=vs.85).aspx
>> 
>> Sincerely yours,
>> Ivan
>> 
>> 
>> 
> 



More information about the security-dev mailing list