[9] RFR: 8075297: Tests for RFEs 4515853 and 4745056

Weijun Wang weijun.wang at oracle.com
Fri Jul 17 23:49:34 UTC 2015


Oh, I didn't see you clear the properties. I thought you reassign 
correct ones still using system properties. Sorry.

Then there is nothing wrong.

Thanks
Max

On 07/18/2015 07:30 AM, Artem Smotrakov wrote:
> Hi Max,
>
> Yes, it is possible to write it manually, but content of krb5 file
> should be like the following:
>
> [libdefaults]
> default_realm = TEST.REALM
> max_retries = 1
>
> [realms]
> TEST.REALM = {
>      kdc = localhost: 12345
> }
>
> Then, the test overrides kdc/realm with system properties. But finally
> at line 103 it re-load krb5 config file and reads kdc/realm from there.
>
> I would prefer to re-use existing KDC.saveConfig(). It is just shorter.
>
> Artem
>
> On 07/17/2015 04:19 PM, Weijun Wang wrote:
>> Although the java.security.krb5.kdc/realm system properties are able
>> to override the values inside krb5.conf, it is better to write one
>> without realm/kdc info at all. So, instead of
>>
>>   60         KDC.saveConfig(KRB5_CONF_FILENAME, kdc, "max_retries = 1");
>>
>> How about just manually write
>>
>>    Files.write(Paths.get(KRB5_CONF_FILENAME), Arrays.asList(
>>         "[libdefaults]",
>>         "max_retries = 1"));
>>
>> --Max
>>
>>
>> On 07/18/2015 01:51 AM, Artem Smotrakov wrote:
>>> Hi Max,
>>>
>>> Please see an updated webrev:
>>>
>>> http://cr.openjdk.java.net/~asmotrak/8075297/webrev.03/
>>>
>>> Artem
>>>
>>> On 07/16/2015 11:31 PM, Wang Weijun wrote:
>>>>> I think it it enough to add a "max_retries = 1" to [libdefaults] of
>>>>> krb5.conf, and left default timeout value for the test. Please take a
>>>>> look at updated webrev:
>>>>>
>>>>> http://cr.openjdk.java.net/~asmotrak/8075297/webrev.02/
>>>> Can you also add the same line to the krb5.conf for the other test?
>>>>
>>>> Thanks
>>>> Max
>>>
>


More information about the security-dev mailing list