<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 09/19/2011 04:21 PM, <a class="moz-txt-link-abbreviated" href="mailto:michael.x.mcmahon@oracle.com">michael.x.mcmahon@oracle.com</a> wrote:
<blockquote cite="mid:20110919142127.74370477D3@hg.openjdk.java.net"
type="cite">
<pre wrap="">Changeset: e3d78fe803d4
Author: michaelm
Date: 2011-09-19 15:14 +0100
URL: <a class="moz-txt-link-freetext" href="http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3d78fe803d4">http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e3d78fe803d4</a>
7091369: DatagramSocket/Limit.java failing on 8 and 7u2
Reviewed-by: chegar, alanb
! src/windows/classes/java/net/TwoStacksPlainDatagramSocketImpl.java
</pre>
</blockquote>
<br>
Hi Michael,<br>
I'm not a big fan of this code.<br>
I don't see why you're using the precise-rethrow feature here.<br>
<br>
I think the code should be:<br>
<br>
<div style="color:#008800;"> try { <br>
super.create();
</div>
<div style="color:#008800;">} catch (SocketException e) {
</div>
<div style="color:#008800;"> fd1 = null;
</div>
<div style="color:#008800;"> throw e;
</div>
<div style="color:#008800;">}
</div>
<br>
Rémi<br>
<br>
</body>
</html>