<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Sean,<br>
<br>
Thanks for the review!<br>
I didn't update the ProblemList due to another bug 6975859.<br>
Will have to fix that before we remove the entry the ProblemList.<br>
<br>
Valerie<br>
<br>
On 12/21/11 11:15, Sean Mullan wrote:
<blockquote cite="mid:4EF23034.8030208@oracle.com" type="cite">
<pre wrap="">On 12/20/11 6:08 PM, Valerie (Yu-Ching) Peng wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Sean,
Can you please help reviewing the fixes for
6839886: Array overrun in pkcs11
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~valeriep/6839886/webrev.00/">http://cr.openjdk.java.net/~valeriep/6839886/webrev.00/</a>
(fixed to use the correct value; no regression test due to @reg-hard)
</pre>
</blockquote>
<pre wrap=""><!---->
Looks fine.
</pre>
<blockquote type="cite">
<pre wrap="">7033170: Cipher.getMaxAllowedKeyLength(String) throws
NoSuchAlgorithmException
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~valeriep/7033170/webrev.00/">http://cr.openjdk.java.net/~valeriep/7033170/webrev.00/</a>
(changed to always use the full transformation string)
</pre>
</blockquote>
<pre wrap=""><!---->
Looks fine.
</pre>
<blockquote type="cite">
<pre wrap="">7084025: closed/sun/security/rsa/TestLimits.java doesn't compile on Windows
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~valeriep/7084025/webrev.00/">http://cr.openjdk.java.net/~valeriep/7084025/webrev.00/</a>
(No SunPKCS11 classes on windows 64-bit, so changed to use reflection)
</pre>
</blockquote>
<pre wrap=""><!---->
Shouldn't you remove the entry from closed/ProblemList now that the test is fixed?
--Sean
</pre>
</blockquote>
<br>
</body>
</html>