<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Fixes look good.<div>Just a minor comment at l.150 of ParameterCache: the test could use '<='??<div><br><div><div><div><div>On 22 Sep 2012, at 00:45, Valerie (Yu-Ching) Peng wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
<div text="#000000" bgcolor="#FFFFFF">
<pre>Hi, Vinnie,
Can you please review these following 2 JDK8 fixes? They are straight forward regressions found by SQE tests introduced as byproducts of the NSA Suite B changes.
Since they are already caught by existing SQE tests, so I didn't add more regression tests.
<a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199939">7199939</a>: DSA 576 ad 640 bit keys fail when initializing for No precomputed parameters
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~valeriep/7199939/webrev.00/">http://cr.openjdk.java.net/~valeriep/7199939/webrev.00/</a>
Fix: Fixed the impl of DSAKeyPairGenerator.initialize(int, SecureRandom) so it will attempt to generate new parameters (instead
of error out) when no precomputed parameters are available. Also fixed ParameterCache.getNewDSAParameterSpec(...) method to handle legacy DSA key sizes.
<a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199941">7199941</a>: test about AES/ECB mode fails
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~valeriep/7199941/webrev.00/">http://cr.openjdk.java.net/~valeriep/7199941/webrev.00/</a>
Fix: Moved the initialization of the field 'blockMode' back to the right code block.
The failed SQE tests now pass after the code changes.
Thanks!
Valerie
</pre>
</div>
</blockquote></div><br></div></div></div></div></body></html>