<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
John,<br>
<br>
I looked at the changes that you have here:<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~chegar/8001579/webrev.01/">http://cr.openjdk.java.net/~chegar/8001579/webrev.01/</a><br>
<br>
and it's great to get these warnings finally fixed.<br>
<br>
The changes look okay to me and I assume that someone in the
security group will sponsor this.<br>
<br>
Two comments:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
In
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Java_sun_security_jgss_wrapper_GSSLibStub_getMechPtr then I wonder
if additional casts are needed for len as GetArrayLength returns a
jsize and memcpy expects a size_t.<br>
<br>
You might want to check with Vinnie on
src/share/native/sun/security/ec/impl/mpi.c as there may be a desire
to keep this code in sync with the upstream EC code<br>
<br>
-Alan.<br>
<br>
</body>
</html>