<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; white-space: pre-wrap;">Greetings:
I just updated:
<i>jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c
</i>with the recommended changes.
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jzavgren/8014307/webrev.02/">http://cr.openjdk.java.net/~jzavgren/8014307/webrev.02/</a>
Thanks!
John Zavgren
----------------------------------------------------------------------
John,
1) 332-333 can be replaced w/ a deleteGSSOID(nameType) call. Also, with
this deleteGSSOID(nameType) call, we should also add the following line:
resetGSSBuffer(env, jnameVal, &nameVal);
2) I think the ExceptionCheck block on line 932 should also be enhanced
w/ resetGSSBuffer(env, jinToken, &inToken) call as well as free(cb)
call. Same goes for another ExceptionCheck blocks on line 984, 998, 1024.
Thanks,
Valerie
On 05/14/13 19:19, John Zavgren wrote:
><i> Greetings: Please review the following change to the file:
</i>><i> jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c that fixes
</i>><i> two memory leaks.
</i>><i> <a href="http://cr.openjdk.java.net/%7Ejzavgren/8014307/webrev.01/">http://cr.openjdk.java.net/~jzavgren/8014307/webrev.01/</a> Thanks! John
</i>><i> Zavgren </i></pre>
<pre class="moz-signature" cols="72">--
John Zavgren
<a class="moz-txt-link-abbreviated" href="mailto:john.zavgren@oracle.com">john.zavgren@oracle.com</a>
603-821-0904
US-Burlington-MA</pre>
</body>
</html>