<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Thanks, Valerie. I removed the unnecessary resetGSSBuffer(...) call.
The revised webrev is viewable at:<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a href="http://cr.openjdk.java.net/%7Ejzavgren/8014307/webrev.03/">http://cr.openjdk.java.net/~jzavgren/8014307/webrev.03/</a><br>
<br>
John<br>
<blockquote cite="mid:519FB1DE.90607@oracle.com" type="cite">--------
Original Message --------
<br>
Subject: Re: RFR JDK-8014307
<br>
Date: Wed, 22 May 2013 16:18:33 -0700
<br>
From: Valerie (Yu-Ching) Peng <a class="moz-txt-link-rfc2396E" href="mailto:valerie.peng@oracle.com"><valerie.peng@oracle.com></a>
<br>
Reply-To: <a class="moz-txt-link-abbreviated" href="mailto:valerie.peng@oracle.com">valerie.peng@oracle.com</a>
<br>
To: <a class="moz-txt-link-abbreviated" href="mailto:security-dev@openjdk.java.net">security-dev@openjdk.java.net</a>
<br>
<br>
<br>
<br>
The resetGSSBuffer(..) call on line 829 should be removed as the
inToken
<br>
structure isn't even initialized yet (initGSSBuffer call is on
line 833).
<br>
Rest looks fine.
<br>
Thanks,
<br>
Valerie
<br>
<br>
On 05/22/13 11:54, John Zavgren wrote:
<br>
<blockquote type="cite">Greetings:
<br>
I just updated:
<br>
/jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c
<br>
/with the recommended changes.
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jzavgren/8014307/webrev.02/">http://cr.openjdk.java.net/~jzavgren/8014307/webrev.02/</a>
<br>
<br>
Thanks!
<br>
John Zavgren
<br>
----------------------------------------------------------------------
<br>
<br>
<br>
John,
<br>
<br>
1) 332-333 can be replaced w/ a deleteGSSOID(nameType) call.
Also, with
<br>
this deleteGSSOID(nameType) call, we should also add the
following line:
<br>
resetGSSBuffer(env, jnameVal, &nameVal);
<br>
<br>
2) I think the ExceptionCheck block on line 932 should also be
enhanced
<br>
w/ resetGSSBuffer(env, jinToken, &inToken) call as well as
free(cb)
<br>
call. Same goes for another ExceptionCheck blocks on line 984,
998, 1024.
<br>
<br>
Thanks,
<br>
Valerie
<br>
On 05/14/13 19:19, John Zavgren wrote:
<br>
>/ Greetings: Please review the following change to the
file:
<br>
/>/
jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c that
fixes
<br>
/>/ two memory leaks.
<br>
/>/ <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jzavgren/8014307/webrev.01/">http://cr.openjdk.java.net/~jzavgren/8014307/webrev.01/</a>
<a class="moz-txt-link-rfc2396E" href="http://cr.openjdk.java.net/%7Ejzavgren/8014307/webrev.01/"><http://cr.openjdk.java.net/%7Ejzavgren/8014307/webrev.01/></a>
Thanks! John
<br>
/>/ Zavgren/
<br>
--
<br>
John Zavgren
<br>
<a class="moz-txt-link-abbreviated" href="mailto:john.zavgren@oracle.com">john.zavgren@oracle.com</a>
<br>
603-821-0904
<br>
US-Burlington-MA
<br>
</blockquote>
<br>
<br>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
John Zavgren
<a class="moz-txt-link-abbreviated" href="mailto:john.zavgren@oracle.com">john.zavgren@oracle.com</a>
603-821-0904
US-Burlington-MA</pre>
</body>
</html>